1 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr.c:
4 (modest_account_mgr_add_server_account): Set the secure-connection
5 conf key for transport accounts as well as store accounts. I don't know
6 why the if was there. For instance, this makes sure that we use SSL
7 for the gmail preset from the easysetup wizard.
9 2007-05-22 Murray Cumming <murrayc@murrayc.com>
11 * src/gnome/modest-main-window.c:
12 (on_account_store_connecting_finished), (connect_signals):
13 * src/maemo/modest-main-window.c:
14 (on_account_store_connecting_finished), (connect_signals),
15 (modest_main_window_new):
16 Handle TnyAccountStore::connecting-finished instead of
17 TnyDevice::connection-changed, because we cannot actually perform
18 operations on accounts until TnyAccountStore has itself responded to
19 the TnyDevice::connection-changed signal. This prevents a GError from
21 Do not try to update at startup, because we (at least on scratchbox)
22 already do an update at startup when the device goes online.
23 This prevents a GError from tinymail.
24 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
25 Added TODO about stopping simultaneous operations.
27 2007-05-21 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
30 * src/modest-mail-operation-queue.c:
31 (modest_mail_operation_queue_remove):
32 * src/modest-tny-account-store.c: When GErrors happen, give more clues
33 about where they happened.
35 2007-05-21 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-ui-actions.c:
38 (modest_ui_actions_on_password_requested): Make sure that the remember
39 output parameter is always TRUE.
41 2007-05-21 Murray Cumming <murrayc@murrayc.com>
43 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
44 Show a OK/Cancel dialog if the error is a question, though we still do not
45 know anything more about what we are asking the user.
46 * src/widgets/modest-folder-view.c: (on_drag_data_received):
47 Fix an uninitialized variable (helper). This is a logic error, however.
49 2007-05-21 Christian Kellner <ckellner@openismus.com>
51 * src/modest-search.h:
52 Correct bit shifting in the ModestSearchFlags enum.
54 2007-05-21 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-tny-account.c:
57 (modest_tny_account_new_from_server_account): Do not use the lsub and
58 check-all hard-coded IMAP options when using POP.
60 2007-05-21 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-tny-account.c:
63 (modest_tny_account_new_from_server_account):
64 Use NULL for the secure-auth method for POP when Password auth has been
65 specified by the user, as we already do for IMAP. "auth=Login" causes
66 an error from camel or the server.
68 2007-05-17 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/modest-account-settings-dialog.c:
71 (create_page_account_details),
72 (modest_account_settings_dialog_set_account_name):
73 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
74 for the leave-on-server checkbox, rathr than just the checkbox, when
75 the protocol is not POP.
77 2007-05-17 Murray Cumming <murrayc@murrayc.com>
79 * src/widgets/modest-account-view.c:
80 * src/widgets/modest-account-view.h:
81 Added modest_account_view_select_account() which will be useful later
82 to asynchronously re-select the edited account.
84 2007-05-17 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/modest-account-settings-dialog.c:
87 (modest_account_settings_dialog_set_account_name):
88 Automatically choose the port numbers based on the secure authentication
89 methods, if they have not been chosen before.
90 This fixes projects.maemo.org bug NB#56273 .
92 2007-05-17 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/modest-main-window-ui.h:
95 * src/modest-ui-actions.c:
96 * src/modest-ui-actions.h:
97 Connect the Tools/SMTP Servers menu item to
98 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
99 SMTP servers dialog, as in the UI specification and saves changes when it
100 is closed. This fixed projects.maemo.org bug NB#56305 .
102 2007-05-17 Murray Cumming <murrayc@murrayc.com>
104 * src/maemo/modest-connection-specific-smtp-window.c:
105 (modest_connection_specific_smtp_window_init):
106 Use gtk_window_set_default_size() to make this window big enough, so
107 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
109 2007-05-17 Murray Cumming <murrayc@murrayc.com>
111 * src/maemo/modest-connection-specific-smtp-edit-window.h:
112 * src/maemo/modest-connection-specific-smtp-edit-window.c:
113 (modest_connection_specific_smtp_edit_window_init),
114 Do not try to connect to a combobox signal before the combobox exists.
115 This fixes the cras in projects.maemo.org bug NB#56288 .
116 (modest_connection_specific_smtp_edit_window_get_settings):
117 Remove the server_account_name parameter which was being checked for NULL
118 though it was not used.
120 * src/maemo/modest-connection-specific-smtp-window.c:
121 (modest_connection_specific_smtp_window_fill_with_connections),
122 (on_button_edit), (modest_connection_specific_smtp_window_init):
123 Correct the number of treemodel columns to prevent a warning.
124 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
125 libconic does not work.
127 2007-05-16 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-tny-account.c:
130 (modest_tny_account_new_from_server_account):
131 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
132 SMTP when "None" was chosen by the user. However, with my SMTP server that
133 does not support ANONYMOUS, the emails do not leave the Outbox and I see
136 2007-05-16 Murray Cumming <murrayc@murrayc.com>
138 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
139 to explain the memory management issue with the ID in the ModestPair.
141 * src/gnome/modest-account-assistant.c: (add_receiving_page),
142 (add_sending_page), (modest_account_assistant_finalize):
143 * src/gnome/modest-gnome-global-settings-dialog.c:
144 (create_updating_page), (create_composing_page):
145 * src/gnome/modest-msg-edit-window.c: (get_transports),
146 (init_window), (modest_msg_edit_window_finalize),
147 (modest_msg_edit_window_get_msg_data):
148 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
149 * src/gnome/modest-transport-widget.c:
150 (modest_transport_widget_finalize), (smtp_configuration):
151 * src/maemo/modest-maemo-global-settings-dialog.c:
152 (create_updating_page), (create_composing_page):
153 * src/maemo/modest-msg-edit-window.c: (get_transports),
154 (init_window), (modest_msg_edit_window_finalize),
155 (modest_msg_edit_window_get_msg_data),
156 (modest_msg_edit_window_free_msg_data):
157 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
158 (modest_store_widget_finalize):
159 * src/maemo/modest-transport-widget.c:
160 (modest_transport_widget_finalize), (smtp_configuration):
161 * src/modest-main.c: (send_mail):
162 * src/widgets/modest-combo-box.h:
163 * src/widgets/modest-global-settings-dialog-priv.h:
164 * src/widgets/modest-global-settings-dialog.c:
165 (modest_global_settings_dialog_finalize):
166 * src/widgets/modest-msg-edit-window.h:
167 Whenever using modest_combo_box_new(), keep the ModestPairList alive
168 as long as the combo box, to prevent use of freed memory for the ID.
170 2007-05-15 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
173 get_accounts(), to make this clearer. Do not check for the enabled gconf
174 key, because we do not use this for server accounts (at least, not yet).
175 This allows us to send email again.
177 2007-05-15 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/modest-platform.c:
180 (on_modest_conf_update_interval_changed), (modest_platform_init):
181 Only respond to this particular key change. All these strcmp()s cannot be
184 2007-05-15 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/modest-maemo-global-settings-dialog.c:
187 (current_connection): Prevent a crash in scratchbox when
188 ny_maemo_conic_device_get_current_iap_id() returns NULL.
189 * src/maemo/modest-platform.c:
190 (on_modest_conf_update_interval_changed), (modest_platform_init):
191 Get the update interval from gconf and reset it when the gconf key changes.
193 2007-05-15 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-protocol-info.c:
196 * src/modest-protocol-info.h: Adde enum-specific get functions,
197 instead of using a ModestProtocolType enum parameter.
199 * src/gnome/modest-account-assistant.c:
200 * src/gnome/modest-store-widget.c:
201 * src/gnome/modest-store-widget.h:
202 * src/gnome/modest-transport-widget.c:
203 * src/gnome/modest-transport-widget.h:
204 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
205 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
206 * src/maemo/easysetup/modest-easysetup-wizard.c:
207 * src/maemo/modest-account-settings-dialog.c:
208 * src/maemo/modest-account-settings-dialog.h:
209 * src/maemo/modest-store-widget.c:
210 * src/maemo/modest-store-widget.h:
211 * src/maemo/modest-transport-widget.c:
212 * src/maemo/modest-transport-widget.h:
213 * src/modest-account-mgr-helpers.c:
214 * src/modest-account-mgr-helpers.h:
215 * src/modest-account-mgr.c:
216 * src/modest-account-mgr.h:
217 * src/modest-tny-account.c:
218 * src/modest-tny-folder.c:
219 * src/widgets/modest-account-view.c:
220 * src/widgets/modest-retrieve-combo-box.c:
221 * src/widgets/modest-retrieve-combo-box.h:
222 * src/widgets/modest-secureauth-combo-box.c:
223 * src/widgets/modest-serversecurity-combo-box.c:
224 * src/widgets/modest-serversecurity-combo-box.h:
225 * tests/check_account-mgr.c:
226 Use the specific functions, and use the re-renamed enum values for GNOME too.
228 2007-05-15 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
232 so we can get the second based on the first.
234 * src/maemo/modest-account-settings-dialog.h:
235 * src/maemo/modest-account-settings-dialog.c:
236 Added get_supported_secure_authentication_methods(), though it is mostly
237 commented-out for now until the necessary API is committed to tinymail.
238 (modest_account_settings_dialog_set_account_name),
239 (save_configuration): Request the supported authentication methods from the
240 server, so we can choose a working method.
242 * src/modest-tny-account-store.h:
243 * src/modest-tny-account-store.c:
244 (modest_tny_account_store_get_session): Rename from
245 tny_account_store_get_session().
247 2007-05-14 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-protocol-info.h: Split the ModestProtocol enum
250 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
251 There was no need to have these unrelated values in one enum.
253 * src/: many files: Adapted to changed enum. This makes the code a bit
254 clearer, and the compiler could catch some errors.
256 2007-05-14 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
259 Show the detailed internal camel error message when an error happens
260 during the configuration, so that our testers can give us more clues.
261 For instance, in projects.maemo.org bug NB#56910 .
263 2007-05-14 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-tny-account.c:
266 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
267 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
269 2007-05-14 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
272 * src/maemo/modest-account-settings-dialog.c:
273 (modest_account_settings_dialog_set_account_name),
274 (save_configuration): For the incoming secure authentication checkbox,
275 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
276 the UI specification. PLAIN does not seem to be supported for most IMAP
277 servers anyway, and I am not sure what it would mean.
278 However, we probably need to discover which of the secure-authentication
279 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
280 * src/modest-account-mgr-helpers.c:
281 (modest_account_mgr_get_server_account_data):
283 * src/modest-tny-account.c:
284 (modest_tny_account_new_from_server_account):
285 Use tny_account_set_mech() to set secure-authentication methods,
286 with some special-casing for IMAP, based on my observations of how
289 * src/modest-account-mgr-helpers.h:
290 * src/modest-account-mgr.c:
291 * src/modest-defs.h: Comment that the URI is only used for local folders.
293 2007-05-11 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
296 parameter const, just to be neat.
297 * src/modest-text-utils.c: (modest_text_utils_inline):
298 End g_strconcat() with NULL, as its documentation says. This is almost
299 certainly the cause of my crash at startup on the device. Interestingly,
300 valgrind doesn't tell us about these errors.
302 2007-05-11 Murray Cumming <murrayc@murrayc.com>
304 * scripts/build-packages: Added more precise comments about how to use
305 this script, though I still get this error:
306 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
307 error building tinymail
309 2007-05-11 Murray Cumming <murrayc@murrayc.com>
311 * src/maemo/modest-main-window.c: (on_account_update):
312 Very slight cleanup, hoping to make it simpler to discover what causes
313 a crash here sometimes.
315 * src/modest-tny-account.c:
316 (modest_tny_account_new_from_server_account): Set the port. Added
317 comments about the options and a TODO comment because I need to find out
318 how to specify the secure authentication method.
320 2007-05-11 Marcus Bauer <marcusb@openismus.com>
322 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
323 changed CFlags paths form modest to libmodest
325 2007-05-10 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-account-mgr-helpers.c:
328 (modest_account_mgr_get_server_account_data),
329 (modest_account_mgr_free_server_account_data):
330 * src/modest-account-mgr-helpers.h:
331 * src/modest-account-mgr.c:
332 (modest_account_mgr_add_server_account):
334 * src/modest-tny-account.c:
335 (modest_tny_account_new_from_server_account):
336 Determine the options for tny_camel_account_add_option() here,
337 based on the settings, rather than storing them directly in gconf.
339 2007-05-10 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
342 Show a more friendly error dialog now that we expect (from the tinymail
343 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
345 2007-05-10 Murray Cumming <murrayc@murrayc.com>
347 * src/maemo/modest-main-window.c: (on_account_update): Check that
348 account_name is not NULL, to prevent a crash at startup that I am
349 seeing on the N800. I do wonder why it is NULL.
351 * src/maemo/easysetup/modest-easysetup-wizard.c:
352 (create_page_user_details):
353 * src/maemo/modest-account-settings-dialog.c:
354 (create_page_user_details), (create_page_outgoing):
355 * src/maemo/modest-connection-specific-smtp-edit-window.c:
356 (modest_connection_specific_smtp_edit_window_init):
357 * src/modest-ui-actions.c:
358 (modest_ui_actions_on_password_requested):
359 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
360 might do something useful with the on-screen keyboard.
362 2007-05-10 Murray Cumming <murrayc@murrayc.com>
364 * src/maemo/modest-main-window.c: (on_account_update):
365 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
366 NULL, to avoid lots of warnings. However, it probably should not be NULL.
368 2007-05-09 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-tny-account-store.c: (on_account_changed):
371 Correct the signature of this signal handler.
373 2007-05-09 Murray Cumming <murrayc@murrayc.com>
375 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
376 Show a HildonNote instead of a GtkDialog for Maemo.
378 2007-05-09 Murray Cumming <murrayc@murrayc.com>
380 * src/widgets/modest-account-view.h:
381 * src/widgets/modest-account-view.c: (on_account_changed),
382 (on_account_removed). Added a boolean flag, set/unset by
383 modest_account_view_block_conf_updates(),
384 modest_account_view_unblock_conf_updates() to prevent unnecessary
385 updates, but this is not very useful because the gconf notifications are
386 so delays (maybe only on Maemo Bora).
387 So auto-updating is turned off, and these functions do an explicit
388 update when necessary.
389 However, something else is still doing too much work when adding/removing
390 accounts, probably in another part of the application.
392 * src/maemo/modest-account-view-window.c:
393 (on_delete_button_clicked), (on_edit_button_clicked),
394 (on_new_button_clicked): Use the new functions.
396 2007-05-09 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-account-mgr-helpers.c:
399 (modest_account_mgr_set_first_account_as_default):
400 Sort the list of names alphabetically-by-title, so we choose the first one
402 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
403 alphabetically by the title.
405 This fixes projects.maemo.org bug NB#56418 .
407 * src/modest-account-mgr-priv.c:
408 (_modest_account_mgr_account_from_key):
409 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
410 avoid a valgrind error, and possible random behaviour.
412 2007-05-09 Murray Cumming <murrayc@murrayc.com>
414 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
415 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
416 tinymail documentation to say that this can be expected.
417 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
418 pretty, and should not happen, but I would prefer to know when it does.
420 2007-05-09 Murray Cumming <murrayc@murrayc.com>
422 * configure.ac: When using the older hildon version, probably on Bora,
423 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
425 * src/widgets/modest-attachment-view.c:
426 (modest_attachment_view_set_part_default): Initialize variables, to fix the
429 2007-05-09 Marcus Bauer <marcusb@openismus.com>
431 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
432 Implemented the prototype. Can be tested with
433 tests/dbus_api/test_open_message:
435 2007-05-08 Murray Cumming <murrayc@murrayc.com>
437 * src/modest-tny-account-store.c:
438 (modest_tny_account_store_instance_init), (get_password):
439 * src/modest-ui-actions.c:
440 (modest_ui_actions_on_password_requested):
441 Do not store the password in gconf, because this function is called
442 for non-remembered passwords. Actually use the cached (in the hash map)
443 password instead of releasing it.
444 The password will now not be remembered if it is asked via the protected
445 password dialog, as per the UI spec.
447 2007-05-08 Murray Cumming <murrayc@murrayc.com>
450 * src/modest-account-mgr-helpers.h:
451 * src/modest-account-mgr-helpers.c:
452 Added modest_server_account_get_username_has_succeeded(),
453 modest_server_account_set_username_has_succeeded().
454 (modest_server_account_set_username),
455 Reset the has-succeeded flag if the username changes.
457 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
458 * src/maemo/modest-connection-specific-smtp-window.c:
459 (modest_connection_specific_smtp_window_save_server_accounts):
460 Use modest_server_account_set_username() instead of using
461 modest_conf_set_string() directly, so that the has-succeeded flag is always
464 * src/modest-ui-actions.c:
465 (modest_ui_actions_on_password_requested): Dim the username entry if
466 the username has ever worked, as per the UI spec.
468 2007-05-08 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-tny-account-store.c: (get_password):
471 * src/modest-ui-actions.c:
472 (modest_ui_actions_on_password_requested):
473 Allow the username to be changed too, though there is more work to
474 be done on exactly how this behaves.
476 2007-05-08 Murray Cumming <murrayc@murrayc.com>
478 * src/modest-account-mgr-helpers.h:
479 * src/modest-account-mgr-helpers.c:
480 Added modest_account_mgr_get_display_name(),
481 modest_server_account_get_username(),
482 modest_server_account_set_username(),
483 modest_server_account_set_password(),
484 modest_server_account_get_hostname() functions so we do not need to
485 use the conf API directly.
487 * src/maemo/modest-main-window.c: (connect_signals):
488 Actually connect ot the ModestAccountStore::request-password signal,
489 so that we show the dialog when the password is requested by Tinymail,
490 for isntance if it is empty.
492 * src/modest-marshal.list:
493 * src/modest-tny-account-store.c:
494 (modest_tny_account_store_class_init), (get_password),
495 (modest_tny_account_store_alert):
496 * src/modest-tny-account-store.h:
497 * src/modest-ui-actions.h:
498 * src/modest-ui-actions.c:
499 (modest_ui_actions_on_password_requested):
500 Change the signal parameters, so it is obvious that we are providing
501 the non human-readable server name, and receiving both the username
502 and password, though changing of the username is not yet implemented.
503 Change the dialog UI to match the Maemo UI specifications, with #idfefing
504 for the GNOME version.
506 This should fix the projects.maemo.org bug NB#56209, though it does not
507 work on Bora, because the gconf_client_get() for the password fails
508 immediately after we save it with gconf_client_set().
510 2007-05-08 Murray Cumming <murrayc@murrayc.com>
513 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
514 caused an undefined symbol error:
515 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
517 2007-05-08 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-tny-account-store.c:
520 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
521 using a GError instead of a string message, so we can translate it in
524 2007-05-08 Murray Cumming <murrayc@murrayc.com>
526 * src/maemo/modest-address-book.c:
527 (modest_address_book_check_names):
528 * src/maemo/modest-msg-view-window.c:
529 (modest_msg_view_window_clipboard_owner_change):
530 * src/modest-init.c: (modest_init_init_ui):
531 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
532 (update_folders_cb), (modest_mail_operation_update_account):
533 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
534 (modest_ui_actions_on_msg_attachment_clicked),
535 (modest_ui_actions_on_msg_recpt_activated):
536 * src/widgets/modest-header-view.c: (drag_data_get_cb):
537 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
538 (modest_msg_view_search_next):
539 * src/widgets/modest-recpt-editor.c:
540 (modest_recpt_editor_on_button_release_event),
541 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
542 g_message(). At this point we should only be seeing interesting errors on
543 stdout. Debugging messages could be #ifdefed-out if they are still useful.
545 2007-05-07 Murray Cumming <murrayc@murrayc.com>
547 (modest_wizard_dialog_force_title_update):
548 * src/maemo/easysetup/modest-wizard-dialog.h:
549 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
550 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
551 can update the title when appropriate. Otherwise the title is wrong if the
552 pages are added after adding the notebook to the dialog.
553 This must be a problem in HildonWizardDialog too.
554 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
556 * src/maemo/easysetup/modest-easysetup-wizard.c:
557 (create_subsequent_customsetup_pages),
558 (create_subsequent_easysetup_pages):
559 Call modest_wizard_dialog_force_title_update() so that the title is
560 correct even with GTK+ < 2.10.
561 This fixes projects.maemo.org bug NB#56145 .
563 2007-05-07 Murray Cumming <murrayc@murrayc.com>
565 * src/maemo/modest-platform.c:
566 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
567 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
570 2007-05-07 Murray Cumming <murrayc@murrayc.com>
572 * src/widgets/modest-window.h:
573 * src/widgets/modest-window.c: Added a save_state_func vfunc,
574 and modest_window_save_state(), which invokes it.
576 * src/widgets/modest-window-mgr.h:
577 * src/widgets/modest-window-mgr.c:
578 Added modest_window_mgr_save_state_for_all_windows(), which calls
579 the save_state vfunc on all registered windows, if implemented.
581 * src/gnome/modest-msg-edit-window.c:
582 * src/gnome/modest-msg-view-window.c:
583 * src/maemo/modest-msg-edit-window.c:
584 * src/maemo/modest-msg-view-window.c:
585 * src/maemo/modest-main-window.c:
586 Specify the existing save_settings functions as implementations of
587 ModestWindow::save_state_func().
589 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
590 Call modest_window_mgr_save_state_for_all_windows(). This happens before
591 enabling hibernation, for instance.
593 We may need to do the same thing for restoring settings.
596 2007-05-07 Murray Cumming <murrayc@murrayc.com>
598 * src/widgets/modest-window-mgr.c:
599 * src/widgets/modest-window-mgr.h:
600 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
601 modest_window_mgr_get_hibernation_is_prevented().
603 * src/maemo/modest-main-window.c:
604 (on_hildon_program_is_topmost_notify): Prevent hibernation
605 (possible when the application goes to the background in the WM),
606 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
608 * src/maemo/easysetup/modest-easysetup-wizard.c:
609 (modest_easysetup_wizard_dialog_init):
610 * src/maemo/modest-account-settings-dialog.c:
611 (modest_account_settings_dialog_init):
612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
613 (modest_connection_specific_smtp_edit_window_init):
614 * src/maemo/modest-connection-specific-smtp-window.c:
615 (modest_connection_specific_smtp_window_init):
616 * src/maemo/modest-signature-editor-dialog.c:
617 (modest_signature_editor_dialog_init):
618 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
619 prevent hibernation while any of these account settings dialogs are open.
621 2007-05-04 Murray Cumming <murrayc@murrayc.com>
623 * src/maemo/Makefile.am:
624 * src/maemo/modest-osso-state-saving.c:
625 * src/maemo/modest-osso-state-saving.h: Added
626 modest_osso_load_state() and modest_osso_save_state() though they do
627 nothing now. They should iterate through all the open windows and load/save
629 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
630 save state when closing.
632 * src/maemo/modest-main-window.c:
633 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
634 Add a notification handler for the HildonProgram::is-topmost property,
635 so we can allow hibernation when the application goes into the background.
636 But we still need to detect when the accounts setup windows are open so
637 we can stop hibernation when they are open.
638 To do this, I also added the main window the HildonProgram. This might have
639 other side-effects/benefits, and should maybe be done for other windows.
641 * src/maemo/modest-osso-autosave-callbacks.h:
642 * src/maemo/modest-osso-autosave-callbacks.c:
643 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
644 though it does not do anything yet, and we might never need this to do
645 anything. For instance, we already save drafts.
647 * src/maemo/modest-platform.c: (modest_platform_init):
648 Specify the libosso auto-save callback.
650 2007-05-03 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/modest-platform.c:
653 (modest_platform_set_update_interval):
654 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
655 aparently stays valid between application instances, so we can use this
656 to remove and reset it later. According to a maemo-developers email from
659 2007-05-03 Murray Cumming <murrayc@murrayc.com>
661 * configure.ac: Depend on libalarm for Maemo.
663 * src/dbus_api/modest-dbus-api.h:
664 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
665 (on_send_receive), (modest_dbus_req_handler):
666 Handle a SEND_RECEIVE D-Bus method.
668 * libmodest-dbus-client/libmodest-dbus-client.c:
669 (libmodest_dbus_client_send_and_receive):
670 * libmodest-dbus-client/libmodest-dbus-client.h:
671 Add C convenience functions for calling the new D-Bus method.
673 * src/modest-platform.h:
674 * src/gnome/modest-platform.c:
675 * src/maemo/modest-platform.c:
676 Added modest_platform_set_update_interval(), which uses the
678 (modest_platform_init),
679 Call modest_platform_set_update_interval(), using a hard-coded
680 interval for now (until the global settings dialog is implemented),
681 though I am not sure that this makes sense yet.
683 2007-05-02 Murray Cumming <murrayc@murrayc.com>
685 * src/dbus_api/modest-dbus-callbacks.c:
686 (modest_osso_cb_hw_state_handler):
687 * src/dbus_api/modest-dbus-callbacks.h:
688 * src/maemo/modest-platform.c: (modest_platform_init):
689 Registered (empty) callbacks for the osso hardware state D-Bus signals,
690 in case this has some effect on the ability for Maemo to ping the
693 2007-05-02 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
696 Comment out an if() that checks a gchar for < 0, causing a build-breaking
697 warning. It is probably a logic error, but I need to fix the build.
699 2007-05-02 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-account-mgr.h:
702 * src/modest-account-mgr.c:
703 (modest_account_mgr_account_names): Add a gboolean enabled_only
704 parameter, so we can get lists of onlt the enabled accounts.
706 (modest_account_mgr_add_account),,
707 (modest_account_mgr_account_with_display_name_exists):
708 * src/maemo/modest-msg-edit-window.c: (get_transports):
709 * src/modest-account-mgr-helpers.c:
710 (modest_account_mgr_set_first_account_as_default):
711 * src/modest-init.c: (init_default_account_maybe):
712 * src/modest-tny-account-store.c: (get_accounts):
713 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
714 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
715 * tests/check_account-mgr.c: (START_TEST):
716 Provide the extra parameter, as appropriate.
718 * src/widgets/modest-account-view.c: (update_account_view):
719 Do not show disabled accounts (meaning that there is no way to
720 enable/disable accounts in the UI (the feature is not in our UI
721 specification), so we can use this internally only to mark unfinished
722 or temporary account data.
724 * src/maemo/easysetup/modest-easysetup-wizard.c:
725 (create_account): Add boolean enable parameter, so we can specify FALSE
726 to create the temporary account.
727 (on_button_edit_advanced_settings): Create the temporary account as disabled.
728 (on_before_next): When finishing, when there is a temporary account, just
730 Also, use a timeout to delay the showing of the dialog until gconf is likely
731 to return correct information, due to a maemo gconf bug that is fixed in
732 osso 1.1, but not yet in Bora.
733 However, the dialog stays on screen after it is destroyed.
735 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
736 for invalid data when cancelling. Use a hildon note instead of a dialog
737 to complain about invalid data. Do not show the account-saved note if the
738 account is disabled (a temporary account that will not really be saved for use
741 2007-04-30 Murray Cumming <murrayc@murrayc.com>
743 * src/modest-account-mgr-helpers.h:
744 * src/modest-account-mgr-helpers.c:
745 Added modest_account_mgr_unset_default_account(),
746 Added modest_account_mgr_set_first_account_as_default().
748 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
749 If it was the default account, unset the default account name.
751 * src/maemo/modest-account-view-window.c:
752 (on_delete_button_clicked): If it was the default account,
753 set the first remaining account as the default instead.
755 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
756 a NULL account or a NULL default account, to prevent a crash. This should
757 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
760 2007-04-30 Murray Cumming <murrayc@murrayc.com>
762 * src/widgets/modest-recpt-editor.c:
763 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
764 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
765 TODO comment for this. This fixes the build.
767 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
768 be the best place for it. This will in future update all auto-update accounts,
769 rather than just the current/default account, when that gconf key exists.
770 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
771 if there are no accounts, before calling do_send_receive().
772 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
774 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
775 * src/maemo/modest-main-window-ui.h:
776 * src/maemo/modest-main-window.c: (on_connection_changed),
777 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
778 directly, becaue the signal handler does more.
780 2007-04-30 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-account-mgr-helpers.c:
783 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
784 for the case that the account does not exist.
786 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
787 (equivalent to the modest account name) rather than the tinymail account name
788 (equivalent to the modest account title - human readable) to get the account data.
789 Check for null account data to prevent the crash, and add a TODO comment saying that
790 this needs fixing because it is using the server account name instead of the account name.
792 2007-04-29 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
795 * src/maemo/modest-account-settings-dialog.c: (show_error),
797 Use hildon_note_new_information() for informative and error messages,
798 which seems to be expected for Maemo applications (no documentation that I know of
799 says this). I am surprised that there is no distinction between info and error
802 2007-04-29 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
805 it is easy to find where this is used.
807 * src/maemo/easysetup/modest-easysetup-wizard.c:
808 (create_page_welcome), (create_page_account_details),
809 (create_page_user_details), (create_page_complete_easysetup),
810 (create_page_custom_incoming), (create_page_custom_outgoing),
811 (create_page_complete_custom):
812 * src/maemo/modest-account-settings-dialog.c:
813 (create_page_account_details), (create_page_user_details),
814 (create_page_incoming), (create_page_outgoing):
815 * src/maemo/modest-account-view-window.c: (window_vbox_new):
816 * src/maemo/modest-connection-specific-smtp-edit-window.c:
817 (modest_connection_specific_smtp_edit_window_init):
818 * src/maemo/modest-connection-specific-smtp-window.c:
819 (modest_connection_specific_smtp_window_init):
820 * src/maemo/modest-signature-editor-dialog.c:
821 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
822 and scrolling policy as per the Email Application Layout Guide, if I have
825 2007-04-27 Murray Cumming <murrayc@murrayc.com>
827 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
828 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
829 which were empty, because these vfuncs have been removed from TnyAccountStore.
830 This fixes the build.
832 2007-04-27 Murray Cumming <murrayc@murrayc.com>
834 * src/maemo/modest-main-window.c:
835 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
836 showing/hiding it. Added TODO because it probably should not be NULL.
837 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
838 because unnecessary g_warnings() make degugging difficult.
840 2007-04-27 Murray Cumming <murrayc@murrayc.com>
842 * src/maemo/modest-msg-edit-window.c:
843 (modest_msg_edit_window_select_color),
844 (modest_msg_edit_window_select_background_color): 2 const corrections and
845 moving 2 #endifs before closing brackets, to fix the build.
847 2007-04-27 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/easysetup/modest-easysetup-wizard.h:
850 * src/maemo/easysetup/modest-easysetup-wizard.c:
851 (modest_easysetup_wizard_dialog_finalize),
852 (on_button_edit_advanced_settings), (create_page_complete_custom),
853 (on_response), (create_account):
854 Implement the Advanced Settings edit button, by saving the account information,
855 for the Advanded Settings dialog to use directly from gconf, and removing it
856 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
857 Bug #5533 in the projects.maemo.org bugzilla.
859 2007-04-27 Murray Cumming <murrayc@murrayc.com>
861 * src/maemo/modest-msg-view-window.c:
862 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
863 when opening a message window.
865 2007-04-27 Murray Cumming <murrayc@murrayc.com>
867 * src/maemo/easysetup/modest-easysetup-wizard.c:
868 (create_page_custom_outgoing): Correct the position of the horizontal separator to
871 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
872 before showing/hiding them, to avoid a crash when clicking on folders when there are no
873 gconf settings. I probably added more checks than necessary, but that is safer.
875 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
876 variable to fix the build, but this seems to be used when it is still NULL.
878 2007-04-27 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-platform.h:
881 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
882 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
883 * src/modest-main.c: Implement this function so we can avoid using
884 maemo-specific API from cross-platform code.
886 * src/modest-tny-account-store.c:
887 (get_smtp_specific_transport_account_for_open_connection):
888 * src/modest-ui-actions.c: (check_for_connection),
889 (modest_ui_actions_on_item_not_found):
890 Use modest_platform_connect_and_wait() and put #idefs around other
891 maemo-specific code, because only maemo currently has a way to
892 identify connection names.
894 2007-04-27 Murray Cumming <murrayc@murrayc.com>
896 * src/modest-tny-account-store.h:
897 * src/modest-tny-account-store.c:
898 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
899 the connection-specific SMTP server settings in the configuration.
901 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
903 * src/maemo/modest-main-window.c: (on_connection_changed),
905 * src/modest-main.c: (main), (start_ui), (send_mail):
906 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
907 that is what is intended.
909 * src/modest-ui-actions.c: (action_send), (action_receive),
910 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
911 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
912 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
913 SMTP server is used when it is specified.
915 (modest_ui_actions_on_send_receive):
916 Check that a connection is open before proceeding.
917 Receive and then send, instead of vice-versa, as per the specification.
919 2007-04-26 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-mail-operation.c:
922 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
923 though I guess it should be something other than NULL.
925 2007-04-26 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/easysetup/modest-easysetup-wizard.c:
928 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
929 combo twice, to avoid an g_warning and to make it visible again.
930 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
931 attached before detaching it, to avoid a g_warning, and add comment about the implicit
932 (already intended) dereference when detaching, because we then recreate the menu.
933 But I am not sure why the warning was happening, and it is possible that this is a memory
936 2007-04-25 Murray Cumming <murrayc@murrayc.com>
938 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
939 and uri_parse_mailto() utility functions.
940 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
942 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
944 2007-04-24 Murray Cumming <murrayc@murrayc.com>
946 * src/dbus_api/modest-dbus-api.h:
947 * src/dbus_api/modest-dbus-callbacks.c:
948 Use an idle callback to execute the modest code in the application's own thread.
949 Remove the helloworld example method.
950 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
951 parsed, and the open-message method is not implemented because this is not yet implemented in
953 * libmodest-dbus-client/libmodest-dbus-client.c:
954 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
955 (libmodest_dbus_client_open_message):
956 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
958 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
959 body without crashing.
961 * tests/dbus_api/Makefile.am:
962 * tests/dbus_api/test_mail_to.c:
963 * tests/dbus_api/test_open_message.c: New tests for the new methods.
965 2007-04-24 Murray Cumming <murrayc@murrayc.com>
967 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
968 Added file to fix the build. Sorry.
970 * src/dbus_api/Makefile.am:
971 * src/dbus_api/modest-dbus-api.h:
972 * src/dbus_api/modest-dbus-callbacks.h:
973 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
974 (modest_dbus_req_handler):
975 Put constants in a separate header so it can be reused by the
976 client library, without duplication
978 * libmodest-dbus-client/Makefile.am:
979 * libmodest-dbus-client/libmodest-dbus-client.c:
980 (libmodest_dbus_client_call_helloworld),
981 (libmodfest_dbus_client_send_mail),
982 (libmodfest_dbus_client_mailto),
983 (libmodfest_dbus_client_open_message):
984 * libmodest-dbus-client/libmodest-dbus-client.h:
985 (Partly) Implement a send_mail D-Bus method.
987 * tests/dbus_api/Makefile.am:
988 * tests/dbus_api/test_send_mail.c: (main): Added a test for
989 the send_email D-Bus method.
991 2007-04-24 Murray Cumming <murrayc@murrayc.com>
995 * libmodest-dbus-client/Makefile.am:
996 * libmodest-dbus-client/libmodest-dbus-client.c:
997 * libmodest-dbus-client/libmodest-dbus-client.h:
998 * tests/dbus_api/Makefile.am:
999 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1000 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1002 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/easysetup/modest-easysetup-wizard.c:
1005 (create_page_account_details):
1006 * src/maemo/modest-account-settings-dialog.c:
1007 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1008 widgets, because this might not be the default in future versions of the Maemo GTK+.
1009 However, I can not not get capitalization to work even in a simple test case.
1011 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/easysetup/modest-easysetup-wizard.c:
1014 (create_page_custom_incoming), (create_page_custom_outgoing):
1015 * src/maemo/modest-account-settings-dialog.c:
1016 (create_page_account_details), (create_page_incoming),
1017 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1018 instead of using gtk_check_button_with_label(), so they are aligned like the other
1019 widgets, as per the UI spec.
1021 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1023 * src/maemo/easysetup/modest-easysetup-wizard.c:
1024 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1025 * src/widgets/modest-validating-entry.c:
1026 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1027 Modest prefix instead of an EasySetup prefix.
1029 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1031 * src/widgets/modest-validating-entry.h:
1032 * src/widgets/modest-validating-entry.c: (on_insert_text),
1033 Added easysetup_validating_entry_set_max_func(), used to set a callback
1034 to call when the max number of characters is reached. GtkEntry has a max-length
1035 already but is silent about it.
1037 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1038 (create_page_account_details), (create_page_user_details),
1040 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1041 (create_page_account_details), (create_page_user_details),
1042 (create_page_outgoing):
1043 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1044 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1045 the UI spec, when the user tries to enter more than the max number of characters.
1047 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1049 * src/maemo/easysetup/modest-easysetup-wizard.c:
1050 (create_page_user_details), (create_page_custom_incoming),
1051 (create_page_custom_outgoing):
1052 * src/maemo/modest-account-settings-dialog.c:
1053 (create_page_user_details), (create_page_incoming),
1054 (create_page_outgoing):
1055 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1056 (modest_connection_specific_smtp_edit_window_init):
1057 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1058 not appropriate. Bad Maemo-specific defaults!.
1060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1063 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1064 (modest_signature_editor_dialog_set_settings):
1065 Disable the label and textview when the checkbox is disabled, and use the
1066 specified (UI spec) default signature text.
1068 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1070 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1071 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1073 * src/modest-defs.h:
1074 * src/modest-account-mgr-helpers.h:
1075 * src/modest-account-mgr-helpers.c:
1076 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1078 * src/maemo/Makefile.am:
1079 * src/maemo/modest-signature-editor-dialog.c:
1080 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1083 * src/maemo/modest-account-settings-dialog.h:
1084 * src/maemo/modest-account-settings-dialog.c:
1085 (modest_account_settings_dialog_finalize), (on_button_signature),
1086 (save_configuration): Use the new dialog when the Edit button is pressed, and
1087 save the changes if necessary, as per the UI spec.
1089 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/Makefile.am:
1092 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1093 based on maemo-develoers email from Dirk.
1095 * src/maemo/easysetup/modest-easysetup-wizard.c:
1096 (create_page_welcome), (create_page_account_details),
1097 (create_page_user_details), (create_page_complete_easysetup),
1098 (create_page_custom_incoming), (create_page_custom_outgoing),
1099 (create_page_complete_custom),
1100 (modest_easysetup_wizard_dialog_init):
1101 * src/maemo/modest-account-settings-dialog.c:
1102 (create_page_account_details), (create_page_user_details),
1103 (create_page_incoming), (create_page_outgoing),
1104 (modest_account_settings_dialog_init):
1105 * src/maemo/modest-connection-specific-smtp-window.c:
1106 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1108 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1110 * src/maemo/easysetup/modest-easysetup-wizard.c:
1111 (create_page_account_details), (create_page_custom_outgoing),
1112 (create_page_complete_custom):
1113 * src/maemo/modest-account-settings-dialog.c:
1114 (create_page_user_details), (create_page_incoming),
1115 (create_page_outgoing):
1116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1117 (modest_connection_specific_smtp_edit_window_init):
1118 Use the correct (UI spec) port min/max, and use horizontal separators,
1121 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1123 * src/maemo/easysetup/modest-easysetup-wizard.c:
1124 (set_default_custom_servernames):
1125 * src/maemo/modest-account-settings-dialog.c:
1126 (create_page_incoming), (on_combo_outgoing_security_changed),
1127 (on_combo_incoming_security_changed), (create_page_outgoing),
1128 (modest_account_settings_dialog_set_account_name),
1129 (save_configuration):
1130 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1131 (on_combo_security_changed),
1132 (modest_connection_specific_smtp_edit_window_init),
1133 (modest_connection_specific_smtp_edit_window_set_connection),
1134 (modest_connection_specific_smtp_edit_window_get_settings):
1135 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1138 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/easysetup/modest-easysetup-wizard.c:
1142 (create_page_custom_outgoing), (create_page_complete_custom):
1143 * src/maemo/modest-account-settings-dialog.c:
1144 (create_page_user_details), (create_page_outgoing):
1145 * src/maemo/modest-account-view-window.c: (button_box_new):
1146 Use changed logical IDs as per the most recent UI spec:
1147 mcen_bd_emailsetup_edit -> mcen_bd_edit
1148 mcen_bd_emailsetup_delete -> mcen_bd_delete
1149 mcen_bd_emailsetup_close -> mcen_bd_close
1151 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1155 * src/dbus_api/Makefile.am:
1156 * src/dbus_api/modest-dbus-callbacks.c:
1157 * src/dbus_api/modest-dbus-callbacks.h:
1158 * src/maemo/modest-platform.c: (modest_platform_init):
1159 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1161 * tests/Makefile.am:
1162 * tests/dbus_api/Makefile.am:
1163 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1165 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1167 * src/maemo/modest-account-settings-dialog.c:
1168 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1169 Removed unnecessary includes.
1171 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/easysetup/modest-easysetup-wizard.c:
1174 * src/maemo/modest-account-settings-dialog.c:
1175 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1176 * src/widgets/Makefile.am:
1177 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1178 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1179 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1180 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1181 * src/widgets/modest-secureauth-combo-box.c:
1182 * src/widgets/modest-secureauth-combo-box.h:
1183 * src/widgets/modest-serversecurity-combo-box.c:
1184 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1185 made the GObject names more consistent with the rest of the Modest code.
1187 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1189 * src/maemo/easysetup/Makefile.am:
1190 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1191 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1192 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1193 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1194 * src/maemo/easysetup/modest-easysetup-wizard.c:
1195 * src/maemo/easysetup/modest-validating-entry.c:
1196 * src/maemo/easysetup/modest-validating-entry.h:
1197 * src/maemo/modest-account-settings-dialog.c:
1198 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1199 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1200 widgets/ because they are used outside of easysetup too. After checking in,
1201 svn will allow me to rename them too.
1203 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1205 * src/gnome/modest-msg-edit-window.c:
1206 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1207 linker error, to fix the build on the GNOME platform.
1208 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1209 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1210 ifdefed out to avoid a warning.
1212 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1214 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1215 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1216 some alternative for GTK+ 2.6.
1218 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1222 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1223 specified for EmailAccountsDialog in UI spec.
1225 * src/maemo/easysetup/modest-easysetup-wizard.c:
1226 * src/maemo/easysetup/modest-easysetup-wizard.h:
1227 * src/maemo/modest-account-settings-dialog.c:
1228 * src/maemo/modest-account-settings-dialog.h:
1229 Reuse a member window widget for the connection-specific SMTP server accounts,
1230 so we can tell it to create/save the accounts only if we actually save changes.
1232 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1234 (modest_connection_specific_smtp_edit_window_get_settings):
1235 Return a struct instance for temporarily remembering the entered data.
1237 * src/maemo/modest-connection-specific-smtp-window.h:
1238 * src/maemo/modest-connection-specific-smtp-window.c:
1239 (modest_connection_specific_smtp_window_finalize),
1240 (modest_connection_specific_smtp_window_fill_with_connections),
1242 (modest_connection_specific_smtp_window_save_server_accounts),
1243 (update_model_server_names): Do not actually save data until asked,
1244 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1246 (on_selection_changed),
1247 (modest_connection_specific_smtp_window_init): Disable the edit
1248 button when nothing is selected.
1250 * src/modest-account-mgr-helpers.c:
1251 * src/modest-account-mgr-helpers.h:
1252 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1255 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-account-mgr-helpers.h:
1258 * src/modest-account-mgr-helpers.c:
1259 (modest_account_mgr_get_unused_account_name),
1260 (modest_account_mgr_get_unused_account_display_name): Added these
1261 utility functions, to avoid code duplication.
1263 * src/maemo/easysetup/modest-easysetup-wizard.c:
1264 (create_page_account_details), (create_account):
1265 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1266 (on_combo_security_changed),
1267 (modest_connection_specific_smtp_edit_window_init),
1268 (modest_connection_specific_smtp_edit_window_save_settings):
1269 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1270 * src/maemo/modest-connection-specific-smtp-window.c:
1271 (modest_connection_specific_smtp_window_finalize),
1272 (modest_connection_specific_smtp_window_fill_with_connections),
1273 (on_button_edit), (modest_connection_specific_smtp_window_init):
1274 * src/maemo/modest-connection-specific-smtp-window.h:
1275 Implementing saving of connection-specific server accounts.
1277 But I need to refactor this so we can save the data for each
1278 possible connection-specific account and only actually create the server accounts
1279 when the easysetup finished, or the OK button is pressed on the account settings
1282 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1285 (on_combo_security_changed):
1286 (modest_connection_specific_smtp_edit_window_init):
1287 Auto-fill the port number as in the account settings.
1289 (modest_connection_specific_smtp_edit_window_set_connection):
1290 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1291 * src/maemo/modest-connection-specific-smtp-window.c:
1292 (fill_with_connections), (on_button_edit),
1293 (modest_connection_specific_smtp_window_init):
1294 Turn the edit window into a dialog to simplify the code, and
1295 set a WM hint as in a GtkDialog, because only a popup can be on top of
1296 another window in Maemo, and popups usually have no WM decoration.
1298 * src/modest-defs.h:
1299 * src/modest-account-mgr-helpers.c:
1300 (modest_account_mgr_set_connection_specific_smtp),
1301 (modest_account_mgr_remove_connection_specific_smtp),
1302 (modest_account_mgr_get_connection_specific_smtp):
1303 * src/modest-account-mgr-helpers.h: Some functions to write the
1304 connection-specific SMTP server information. Not yet used.
1307 * src/widgets/modest-folder-view.c: (text_cell_data):
1308 Fix a warning about an uninitialized variable.
1309 (on_configuration_key_changed): Put an #ifdef around the use
1310 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1312 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/modest-account-settings-dialog.h:
1315 * src/maemo/modest-account-settings-dialog.c:
1316 Added connect_for_modified() utility function to mark the new modified boolean.
1318 (create_page_account_details), (create_page_user_details),
1319 (create_page_incoming), (create_page_outgoing), (on_response),
1320 (modest_account_settings_dialog_init),
1321 (modest_account_settings_dialog_set_account_name):
1322 Only warn about unsaved changes when there are actually unsaved changes.
1324 * src/modest-account-mgr-helpers.c:
1325 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1326 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1327 to get the data from there in future.
1329 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-defs.h:
1333 * src/modest-account-mgr-helpers.h:
1334 * src/modest-account-mgr-helpers.c:
1335 Store the security account setting in a single conf key instead of using
1336 the options list, so that the list is left for just the to-be-removed camel hack,
1337 and because gconf_client_set_list() is failing for some reason.
1339 * src/modest-account-mgr.c:
1340 (modest_account_mgr_add_server_account):
1341 * src/maemo/modest-account-settings-dialog.c:
1342 (modest_account_settings_dialog_set_account_name),
1343 (save_configuration): Use the renamed functions.
1346 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1348 * src/widgets/Makefile.am:
1349 * src/widgets/modest-limit-retrieve-combo-box.c:
1350 * src/widgets/modest-limit-retrieve-combo-box.h:
1351 * src/widgets/modest-retrieve-combo-box.c:
1352 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1353 the account settings dialog.
1355 * src/modest-defs.h:
1356 * src/modest-account-mgr-helpers.h:
1357 * src/modest-account-mgr-helpers.c:
1358 (modest_server_account_get_option_secure_auth),
1359 (modest_server_account_set_option_secure_auth):
1360 * src/modest-account-mgr.c:
1361 (modest_account_mgr_add_server_account):
1362 Use the existing AUTH_MECH conf key for the secure-auth setting,
1363 instead of putting it in the list options, because this was actually used already.
1365 * src/maemo/modest-account-settings-dialog.c:
1366 (create_page_account_details),
1367 (modest_account_settings_dialog_set_account_name),
1368 (save_configuration):
1369 * src/maemo/modest-account-settings-dialog.h:
1370 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1371 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1373 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1375 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1376 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1377 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1379 * src/modest-defs.h:
1380 * src/maemo/modest-account-settings-dialog.c:
1381 (create_page_incoming), (on_combo_outgoing_security_changed),
1382 (on_combo_incoming_security_changed), (create_page_outgoing),
1383 (modest_account_settings_dialog_set_account_name),
1384 (save_configuration): Load/Save the port number, and change it when the
1385 security combo changes, to suitable defaults.
1387 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1389 * src/modest-account-mgr.c:
1390 (modest_account_mgr_add_server_account): Set the security and secure-auth
1391 options, and add a comment saying that the other camel-specific options should be
1394 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1396 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1398 * src/modest-tny-account-store.c: (account_list_free),
1399 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1400 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1403 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1405 * src/modest-protocol-info.c:
1406 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1407 is required by our UI spec. Maybe something in our implementation will use this eventually.
1408 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1409 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1410 instead of the previous 0 placeholder.
1412 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1413 secure-auth settings.
1414 * src/modest-account-mgr-helpers.h:
1415 * src/modest-account-mgr-helpers.c:
1416 (modest_server_account_data_get_option_secure_auth),
1417 (modest_server_account_set_option_secure_auth),
1418 (modest_server_account_data_get_option_security),
1419 (modest_server_account_set_option_security): Added this API for getting and setting the security
1420 and secure-auth settings.
1422 * src/maemo/modest-account-settings-dialog.h:
1423 * src/maemo/modest-account-settings-dialog.c:
1424 (modest_account_settings_dialog_finalize), (check_data),
1425 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1426 about changing titles.
1427 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1428 (save_configuration): Save the security and secure-auth settings.
1430 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1431 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1433 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1435 * src/modest-defs.h:
1436 * src/modest-account-mgr.c:
1437 (modest_account_mgr_add_server_account):
1438 Added and used defines for the options key and value pair strings,
1439 that are used so far, though they do not seem to correspond to anything in our
1440 UI specs or ModestProtocol enum.
1442 * src/modest-account-mgr-helpers.h:
1443 * src/modest-account-mgr-helpers.c:
1444 (compare_option_strings_for_name),
1445 (modest_server_account_data_get_option_value),
1446 (modest_server_account_data_get_option_bool),
1447 (modest_account_mgr_get_server_account_option):
1448 Added helper functions for parsing the options GSList.
1450 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1452 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1453 display name is based on the supplied account name.
1454 * src/modest-account-mgr.c:
1455 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1456 with an inefficient, but good-enough, implementation.
1458 * src/maemo/easysetup/modest-easysetup-wizard.c:
1459 (create_page_account_details), (on_before_next), (create_account):
1460 Check for existing display names rather than (non-user-visible) account names, and just
1461 create and set a unique account name at the end.
1463 * src/maemo/modest-account-settings-dialog.c:
1464 (modest_account_settings_dialog_init),
1465 (modest_account_settings_dialog_set_account_name),
1466 (create_page_incoming): Show the display name, instead of the account name.
1467 (on_response): Do some (not all) extra checks, as in the UI spec.
1468 (save_configuration): Save the display name if it was changed.
1470 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1472 * po/en_GB.po: Added needed logical ID and translation.
1473 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1474 (init_view): Made the is-default column clicking work.
1476 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1479 * src/maemo/easysetup/Makefile.am:
1480 * src/maemo/easysetup/modest-easysetup-wizard.c:
1481 (modest_easysetup_wizard_dialog_init):
1482 * src/maemo/easysetup/provider-data-test.keyfile:
1483 * src/maemo/easysetup/provider-data.keyfile:
1484 Moved the provider data file to the new modest-providers-data package and used it from there.
1486 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1488 * src/modest-local-folder-info.c:
1489 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1490 N_() was already used on the static strings, but this just marks it for translation without
1491 using the translation.
1493 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/modest-account-settings-dialog.c:
1496 (create_page_incoming),
1497 (modest_account_settings_dialog_set_account_name):
1498 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1499 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1500 I will do this if nobody else gets there first.
1502 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1505 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1506 save the security stuff.
1508 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1510 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1511 Set the email address and user fullname, which I now see must be
1514 * src/maemo/modest-account-settings-dialog.h:
1515 * src/maemo/modest-account-settings-dialog.c:
1517 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1518 leave-on-server and authentication.
1519 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1522 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1525 * src/maemo/modest-account-settings-dialog.c:
1526 * src/maemo/modest-account-settings-dialog.h:
1527 Most (but not all) of the widgets are now present as specified by the UI spec.
1528 No changes are yet saved, and some details are not properly shown yet.
1530 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1532 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/Makefile.am:
1535 * src/maemo/modest-account-settings-dialog.c:
1536 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1537 an existing account. Doesn't do much yet.
1539 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1540 Open the accounts settings dialog when Edit is clicked.
1542 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/easysetup/Makefile.am:
1545 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1547 * src/maemo/easysetup/modest-easysetup-wizard.c:
1548 (modest_easysetup_wizard_dialog_init):
1549 Try to get the source directory from the build system,
1550 instead of hard-coding "./" into the source code, when opening our local
1551 copies of the configuration files.
1552 But this still fails when opening the wizard from the Accounts window,
1553 maybe because the working directory seems to change at runtime.
1554 So the wizard will fail the second time unless you copy the files into their
1555 proper locations - see the stdout warnings for the paths.
1557 (create_page_account_details),(on_before_next):
1558 Check for existing non-server accounts instead of server accounts,
1559 so the default account name is useful again, and to prevent trying to
1562 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1563 Show the wizard when New is clicked.
1565 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1566 (init_view): Show the column headers, and show the columns that are
1567 specified in the UI specs. However, something in Maemo's GTK+ prevents
1568 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1569 change the default account. This is despite unsetting the special properties.
1571 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1573 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1574 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1575 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1576 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1577 to make that clearer.
1578 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1580 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/modest-account-view-window.c:
1583 (modest_account_view_window_init),
1584 (modest_account_view_window_new):
1585 Use the same buttons as specified in the
1586 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1587 the existing widgets, which never had a chance of working.
1588 Put the ModestAccountView treeview in a scrolled window.
1589 Do not repeat the initialization in both _init() and _new().
1591 * src/widgets/modest-account-view.c: (update_account_view):
1592 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1593 this widget and window shows no accounts.
1595 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1597 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/easysetup/modest-easysetup-wizard.c:
1600 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1601 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1602 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1605 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1606 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1607 accounts exist yet, as in the UI spec.
1609 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1611 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/Makefile.am:
1614 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1615 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1616 New window for editing connection-specific smtp details.
1617 Not fully implemented.
1619 * src/maemo/modest-connection-specific-smtp-window.c:
1620 (modest_connection_specific_smtp_window_finalize) :
1621 unref the tree model.
1622 (on_button_edit): Show the edit window.
1624 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1626 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1629 * src/maemo/Makefile.am:
1630 * src/maemo/modest-connection-specific-smtp-window.c:
1631 * src/maemo/modest-connection-specific-smtp-window.h:
1632 New window for showing the list of connections, for connection-specific
1633 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1634 * src/maemo/easysetup/modest-easysetup-wizard.c:
1635 (create_page_custom_outgoing): Show the new window when the button is clicked.
1637 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1639 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1640 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1641 * src/maemo/modest-msg-edit-window.c:
1642 (modest_msg_edit_window_insert_image):
1643 * src/modest-conf.c: (modest_conf_key_escape):
1644 * src/modest-mail-operation.c:
1645 (modest_mail_operation_send_new_mail):
1646 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1647 (modest_ui_actions_on_new_account):
1648 * src/widgets/modest-attachment-view.c: (update_filename_request):
1649 * src/widgets/modest-mail-header-view.c:
1650 Corrected warnings that were breaking the build, by commenting out unused variables,
1651 and a function, and by including a header.
1653 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1655 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1656 so we can #ifdef around platform-specific code when necessary.
1657 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1658 to allow this to build for the GNOME platform too.
1660 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1662 * src/maemo/easysetup/modest-easysetup-wizard.c:
1663 Added util_increment_name() and used it in create_page_account_details()
1664 to make sure that the default account name is always a new name.
1666 (modest_easysetup_wizard_dialog_init),
1667 (set_default_custom_servernames): Some minor memory management fixes.
1669 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1673 * src/modest-runtime.c: (init_i18n): Restored the translation
1674 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1675 are defined in config.h, and the translations are installed.
1677 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1678 is defined for translation.
1680 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1684 * src/maemo/easysetup/modest-easysetup-wizard.c:
1685 (modest_easysetup_wizard_dialog_init):
1686 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1687 Use realistic paths (though they should use $prefix generically) to the
1688 mcc_mapping and provider-data.keyfile files which might work when they
1689 are installed by the future version of the operator-wizard package,
1690 and then fallback to paths in our source code, with an explanatory
1693 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1697 * src/maemo/Makefile.am:
1698 * src/maemo/easysetup/: Added files from the previously-exernal
1699 osso-modest-easysetup.
1700 * src/maemo/modest-main-window-ui.h:
1701 * src/modest-ui-actions.c:
1702 * src/modest-ui-actions.h:
1703 Added modest_ui_actions_on_new_account() as a signal handler for the
1704 New Account menu item. It shows the easysetup wizard.
1705 * po/en_GB.po: Added additional needed logical IDs and translations.
1707 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1708 Apparently ChangeLog is not used for some vague Nokia legal reasons.