git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
   4         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
   5         some alternative for GTK+ 2.6.
   6
   7 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
   8
   9         * src/maemo/modest-address-book.c: Added include to avoid a warning.
  10
  11         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
  12         specified for EmailAccountsDialog in UI spec.
  13
  14         * src/maemo/easysetup/modest-easysetup-wizard.c:
  15         * src/maemo/easysetup/modest-easysetup-wizard.h:
  16         * src/maemo/modest-account-settings-dialog.c:
  17         * src/maemo/modest-account-settings-dialog.h:
  18         Reuse a member window widget for the connection-specific SMTP server accounts,
  19         so we can tell it to create/save the accounts only if we actually save changes.
  20
  21         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  22         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  23         (modest_connection_specific_smtp_edit_window_get_settings):
  24         Return a struct instance for temporarily remembering the entered data.
  25
  26         * src/maemo/modest-connection-specific-smtp-window.h:
  27         * src/maemo/modest-connection-specific-smtp-window.c:
  28         (modest_connection_specific_smtp_window_finalize),
  29         (modest_connection_specific_smtp_window_fill_with_connections),
  30         (on_button_edit),
  31         (modest_connection_specific_smtp_window_save_server_accounts),
  32         (update_model_server_names): Do not actually save data until asked,
  33         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
  34
  35         (on_selection_changed),
  36         (modest_connection_specific_smtp_window_init): Disable the edit
  37         button when nothing is selected.
  38
  39         * src/modest-account-mgr-helpers.c:
  40         * src/modest-account-mgr-helpers.h:
  41         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
  42         elsewhere.
  43
  44 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
  45
  46         * src/modest-account-mgr-helpers.h:
  47         * src/modest-account-mgr-helpers.c:
  48         (modest_account_mgr_get_unused_account_name),
  49         (modest_account_mgr_get_unused_account_display_name): Added these
  50         utility functions, to avoid code duplication.
  51
  52         * src/maemo/easysetup/modest-easysetup-wizard.c:
  53         (create_page_account_details), (create_account):
  54         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  55         (on_combo_security_changed),
  56         (modest_connection_specific_smtp_edit_window_init),
  57         (modest_connection_specific_smtp_edit_window_save_settings):
  58         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  59         * src/maemo/modest-connection-specific-smtp-window.c:
  60         (modest_connection_specific_smtp_window_finalize),
  61         (modest_connection_specific_smtp_window_fill_with_connections),
  62         (on_button_edit), (modest_connection_specific_smtp_window_init):
  63         * src/maemo/modest-connection-specific-smtp-window.h:
  64         Implementing saving of connection-specific server accounts.
  65
  66         But I need to refactor this so we can save the data for each
  67         possible connection-specific account and only actually create the server accounts
  68         when the easysetup finished, or the OK button is pressed on the account settings
  69         dialog.
  70
  71 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  72
  73         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  74         (on_combo_security_changed):
  75         (modest_connection_specific_smtp_edit_window_init):
  76         Auto-fill the port number as in the account settings.
  77
  78         (modest_connection_specific_smtp_edit_window_set_connection):
  79         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  80         * src/maemo/modest-connection-specific-smtp-window.c:
  81         (fill_with_connections), (on_button_edit),
  82         (modest_connection_specific_smtp_window_init):
  83         Turn the edit window into a dialog to simplify the code, and
  84         set a WM hint as in a GtkDialog, because only a popup can be on top of
  85         another window in Maemo, and popups usually have no WM decoration.
  86
  87         * src/modest-defs.h:
  88         * src/modest-account-mgr-helpers.c:
  89         (modest_account_mgr_set_connection_specific_smtp),
  90         (modest_account_mgr_remove_connection_specific_smtp),
  91         (modest_account_mgr_get_connection_specific_smtp):
  92         * src/modest-account-mgr-helpers.h: Some functions to write the
  93         connection-specific SMTP server information. Not yet used.
  94
  95
  96         * src/widgets/modest-folder-view.c: (text_cell_data):
  97         Fix a warning about an uninitialized variable.
  98         (on_configuration_key_changed): Put an #ifdef around the use
  99         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 100
 101 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 102
 103         * src/maemo/modest-account-settings-dialog.h:
 104         * src/maemo/modest-account-settings-dialog.c:
 105         Added connect_for_modified() utility function to mark the new modified boolean.
 106
 107         (create_page_account_details), (create_page_user_details),
 108         (create_page_incoming), (create_page_outgoing), (on_response),
 109         (modest_account_settings_dialog_init),
 110         (modest_account_settings_dialog_set_account_name):
 111         Only warn about unsaved changes when there are actually unsaved changes.
 112
 113         * src/modest-account-mgr-helpers.c:
 114         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 115         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 116         to get the data from there in future.
 117
 118 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 119
 120         * src/modest-defs.h:
 121
 122         * src/modest-account-mgr-helpers.h:
 123         * src/modest-account-mgr-helpers.c:
 124         Store the security account setting in a single conf key instead of using
 125         the options list, so that the list is left for just the to-be-removed camel hack,
 126         and because gconf_client_set_list() is failing for some reason.
 127
 128         * src/modest-account-mgr.c:
 129         (modest_account_mgr_add_server_account):
 130         * src/maemo/modest-account-settings-dialog.c:
 131         (modest_account_settings_dialog_set_account_name),
 132         (save_configuration): Use the renamed functions.
 133
 134
 135 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 136
 137         * src/widgets/Makefile.am:
 138         * src/widgets/modest-limit-retrieve-combo-box.c:
 139         * src/widgets/modest-limit-retrieve-combo-box.h:
 140         * src/widgets/modest-retrieve-combo-box.c:
 141         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 142         the account settings dialog.
 143
 144         * src/modest-defs.h:
 145         * src/modest-account-mgr-helpers.h:
 146         * src/modest-account-mgr-helpers.c:
 147         (modest_server_account_get_option_secure_auth),
 148         (modest_server_account_set_option_secure_auth):
 149         * src/modest-account-mgr.c:
 150         (modest_account_mgr_add_server_account):
 151         Use the existing AUTH_MECH conf key for the secure-auth setting,
 152         instead of putting it in the list options, because this was actually used already.
 153
 154         * src/maemo/modest-account-settings-dialog.c:
 155         (create_page_account_details),
 156         (modest_account_settings_dialog_set_account_name),
 157         (save_configuration):
 158         * src/maemo/modest-account-settings-dialog.h:
 159         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 160         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 161
 162 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 163
 164         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 165         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 166         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 167
 168         * src/modest-defs.h:
 169         * src/maemo/modest-account-settings-dialog.c:
 170         (create_page_incoming), (on_combo_outgoing_security_changed),
 171         (on_combo_incoming_security_changed), (create_page_outgoing),
 172         (modest_account_settings_dialog_set_account_name),
 173         (save_configuration): Load/Save the port number, and change it when the
 174         security combo changes, to suitable defaults.
 175
 176 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 177
 178         * src/modest-account-mgr.c:
 179         (modest_account_mgr_add_server_account): Set the security and secure-auth
 180         options, and add a comment saying that the other camel-specific options should be
 181         removed in future.
 182
 183 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 186         found by valgrind.
 187         * src/modest-tny-account-store.c: (account_list_free),
 188         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 189         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 190         easy to fix.
 191
 192 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 193
 194         * src/modest-protocol-info.c:
 195         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 196         is required by our UI spec. Maybe something in our implementation will use this eventually.
 197         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 198         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 199         instead of the previous 0 placeholder.
 200
 201         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 202         secure-auth settings.
 203         * src/modest-account-mgr-helpers.h:
 204         * src/modest-account-mgr-helpers.c:
 205         (modest_server_account_data_get_option_secure_auth),
 206         (modest_server_account_set_option_secure_auth),
 207         (modest_server_account_data_get_option_security),
 208         (modest_server_account_set_option_security): Added this API for getting and setting the security
 209         and secure-auth settings.
 210
 211         * src/maemo/modest-account-settings-dialog.h:
 212         * src/maemo/modest-account-settings-dialog.c:
 213         (modest_account_settings_dialog_finalize), (check_data),
 214         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 215         about changing titles.
 216         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 217         (save_configuration): Save the security and secure-auth settings.
 218
 219         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 220         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 221
 222 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 223
 224         * src/modest-defs.h:
 225         * src/modest-account-mgr.c:
 226         (modest_account_mgr_add_server_account):
 227         Added and used defines for the options key and value pair strings,
 228         that are used so far, though they do not seem to correspond to anything in our
 229         UI specs or ModestProtocol enum.
 230
 231         * src/modest-account-mgr-helpers.h:
 232         * src/modest-account-mgr-helpers.c:
 233         (compare_option_strings_for_name),
 234         (modest_server_account_data_get_option_value),
 235         (modest_server_account_data_get_option_bool),
 236         (modest_account_mgr_get_server_account_option):
 237         Added helper functions for parsing the options GSList.
 238
 239 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 240
 241         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 242         display name is based on the supplied account name.
 243         * src/modest-account-mgr.c:
 244         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 245         with an inefficient, but good-enough, implementation.
 246
 247         * src/maemo/easysetup/modest-easysetup-wizard.c:
 248         (create_page_account_details), (on_before_next), (create_account):
 249         Check for existing display names rather than (non-user-visible) account names, and just
 250         create and set a unique account name at the end.
 251
 252         * src/maemo/modest-account-settings-dialog.c:
 253         (modest_account_settings_dialog_init),
 254         (modest_account_settings_dialog_set_account_name),
 255         (create_page_incoming): Show the display name, instead of the account name.
 256         (on_response): Do some (not all) extra checks, as in the UI spec.
 257         (save_configuration): Save the display name if it was changed.
 258
 259 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 260
 261         * po/en_GB.po: Added needed logical ID and translation.
 262         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 263         (init_view): Made the is-default column clicking work.
 264
 265 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 266
 267         * configure.ac:
 268         * src/maemo/easysetup/Makefile.am:
 269         * src/maemo/easysetup/modest-easysetup-wizard.c:
 270         (modest_easysetup_wizard_dialog_init):
 271         * src/maemo/easysetup/provider-data-test.keyfile:
 272         * src/maemo/easysetup/provider-data.keyfile:
 273         Moved the provider data file to the new modest-providers-data package and used it from there.
 274
 275 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 276
 277         * src/modest-local-folder-info.c:
 278         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 279         N_() was already used on the static strings, but this just marks it for translation without
 280         using the translation.
 281
 282 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 283
 284         * src/maemo/modest-account-settings-dialog.c:
 285         (create_page_incoming),
 286         (modest_account_settings_dialog_set_account_name):
 287         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 288         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 289         I will do this if nobody else gets there first.
 290
 291 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 292
 293         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 294         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 295         save the security stuff.
 296
 297 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 298
 299         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 300         Set the email address and user fullname, which I now see must be
 301         done separately.
 302
 303         * src/maemo/modest-account-settings-dialog.h:
 304         * src/maemo/modest-account-settings-dialog.c:
 305          (on_response),
 306         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 307         leave-on-server and authentication.
 308         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 309         how to do the rest.
 310
 311 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 312
 313
 314         * src/maemo/modest-account-settings-dialog.c:
 315         * src/maemo/modest-account-settings-dialog.h:
 316         Most (but not all) of the widgets are now present as specified by the UI spec.
 317         No changes are yet saved, and some details are not properly shown yet.
 318
 319         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 320
 321 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 322
 323         * src/maemo/Makefile.am:
 324         * src/maemo/modest-account-settings-dialog.c:
 325         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 326         an existing account. Doesn't do much yet.
 327
 328         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 329         Open the accounts settings dialog when Edit is clicked.
 330
 331 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 332
 333         * src/maemo/easysetup/Makefile.am:
 334         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 335         (load_from_file):
 336         * src/maemo/easysetup/modest-easysetup-wizard.c:
 337         (modest_easysetup_wizard_dialog_init):
 338         Try to get the source directory from the build system,
 339         instead of hard-coding "./" into the source code, when opening our local
 340         copies of the configuration files.
 341         But this still fails when opening the wizard from the Accounts window,
 342         maybe because the working directory seems to change at runtime.
 343         So the wizard will fail the second time unless you copy the files into their
 344         proper locations - see the stdout warnings for the paths.
 345
 346         (create_page_account_details),(on_before_next):
 347         Check for existing non-server accounts instead of server accounts,
 348         so the default account name is useful again, and to prevent trying to
 349         recreate accounts.
 350
 351         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 352         Show the wizard when New is clicked.
 353
 354         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 355         (init_view): Show the column headers, and show the columns that are
 356         specified in the UI specs. However, something in Maemo's GTK+ prevents
 357         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 358         change the default account. This is despite unsetting the special properties.
 359
 360 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 361
 362         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 363         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 364         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 365         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 366         to make that clearer.
 367         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 368
 369 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 370
 371         * src/maemo/modest-account-view-window.c:
 372         (modest_account_view_window_init),
 373         (modest_account_view_window_new):
 374         Use the same buttons as specified in the
 375         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 376         the existing widgets, which never had a chance of working.
 377         Put the ModestAccountView treeview in a scrolled window.
 378         Do not repeat the initialization in both _init() and _new().
 379
 380         * src/widgets/modest-account-view.c: (update_account_view):
 381         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 382         this widget and window shows no accounts.
 383
 384         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 385
 386 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 387
 388         * src/maemo/easysetup/modest-easysetup-wizard.c:
 389         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 390         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 391         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 392         which seems wrong.
 393
 394         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 395         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 396         accounts exist yet, as in the UI spec.
 397
 398         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 399
 400 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 401
 402         * src/maemo/Makefile.am:
 403         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 404         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 405         New window for editing connection-specific smtp details.
 406         Not fully implemented.
 407
 408         * src/maemo/modest-connection-specific-smtp-window.c:
 409         (modest_connection_specific_smtp_window_finalize) :
 410         unref the tree model.
 411         (on_button_edit): Show the edit window.
 412
 413 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 414
 415         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 416         error for me.
 417
 418         * src/maemo/Makefile.am:
 419         * src/maemo/modest-connection-specific-smtp-window.c:
 420         * src/maemo/modest-connection-specific-smtp-window.h:
 421         New window for showing the list of connections, for connection-specific
 422         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 423         * src/maemo/easysetup/modest-easysetup-wizard.c:
 424         (create_page_custom_outgoing): Show the new window when the button is clicked.
 425
 426 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 427
 428         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 429         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 430         * src/maemo/modest-msg-edit-window.c:
 431         (modest_msg_edit_window_insert_image):
 432         * src/modest-conf.c: (modest_conf_key_escape):
 433         * src/modest-mail-operation.c:
 434         (modest_mail_operation_send_new_mail):
 435         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 436         (modest_ui_actions_on_new_account):
 437         * src/widgets/modest-attachment-view.c: (update_filename_request):
 438         * src/widgets/modest-mail-header-view.c:
 439         Corrected warnings that were breaking the build, by commenting out unused variables,
 440         and a function, and by including a header.
 441
 442 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 443
 444         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 445         so we can #ifdef around platform-specific code when necessary.
 446         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 447         to allow this to build for the GNOME platform too.
 448
 449 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 450
 451         * src/maemo/easysetup/modest-easysetup-wizard.c:
 452         Added util_increment_name() and used it in create_page_account_details()
 453         to make sure that the default account name is always a new name.
 454
 455         (modest_easysetup_wizard_dialog_init),
 456         (set_default_custom_servernames): Some minor memory management fixes.
 457
 458 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 459
 460         * Makefile.am:
 461         * configure.ac:
 462         * src/modest-runtime.c: (init_i18n): Restored the translation
 463         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 464         are defined in config.h, and the translations are installed.
 465
 466         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 467         is defined for translation.
 468
 469 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 470
 471         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 472         (load_from_file):
 473         * src/maemo/easysetup/modest-easysetup-wizard.c:
 474         (modest_easysetup_wizard_dialog_init):
 475         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 476         Use realistic paths (though they should use $prefix generically) to the
 477         mcc_mapping and provider-data.keyfile files which might work when they
 478         are installed by the future version of the operator-wizard package,
 479         and then fallback to paths in our source code, with an explanatory
 480         warning.
 481
 482 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 483
 484         * configure.ac:
 485         * src/Makefile.am:
 486         * src/maemo/Makefile.am:
 487         * src/maemo/easysetup/: Added files from the previously-exernal
 488         osso-modest-easysetup.
 489         * src/maemo/modest-main-window-ui.h:
 490         * src/modest-ui-actions.c:
 491         * src/modest-ui-actions.h:
 492         Added modest_ui_actions_on_new_account() as a signal handler for the
 493         New Account menu item. It shows the easysetup wizard.
 494         * po/en_GB.po: Added additional needed logical IDs and translations.
 495
 496 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 497 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 498