git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/widgets/modest-window.h:
   4         * src/widgets/modest-window.c: Added a save_state_func vfunc,
   5         and modest_window_save_state(), which invokes it.
   6
   7         * src/widgets/modest-window-mgr.h:
   8         * src/widgets/modest-window-mgr.c:
   9         Added modest_window_mgr_save_state_for_all_windows(), which calls
  10         the save_state vfunc on all registered windows, if implemented.
  11
  12         * src/gnome/modest-msg-edit-window.c:
  13         * src/gnome/modest-msg-view-window.c:
  14         * src/maemo/modest-msg-edit-window.c:
  15         * src/maemo/modest-msg-view-window.c:
  16         * src/maemo/modest-main-window.c:
  17         Specify the existing save_settings functions as implementations of
  18         ModestWindow::save_state_func().
  19
  20         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
  21         Call modest_window_mgr_save_state_for_all_windows(). This happens before
  22         enabling hibernation, for instance.
  23
  24         We may need to do the same thing for restoring settings.
  25
  26
  27 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
  28
  29         * src/widgets/modest-window-mgr.c:
  30         * src/widgets/modest-window-mgr.h:
  31         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
  32         modest_window_mgr_get_hibernation_is_prevented().
  33
  34         * src/maemo/modest-main-window.c:
  35         (on_hildon_program_is_topmost_notify): Prevent hibernation
  36         (possible when the application goes to the background in the WM),
  37         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
  38
  39         * src/maemo/easysetup/modest-easysetup-wizard.c:
  40         (modest_easysetup_wizard_dialog_init):
  41         * src/maemo/modest-account-settings-dialog.c:
  42         (modest_account_settings_dialog_init):
  43         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  44         (modest_connection_specific_smtp_edit_window_init):
  45         * src/maemo/modest-connection-specific-smtp-window.c:
  46         (modest_connection_specific_smtp_window_init):
  47         * src/maemo/modest-signature-editor-dialog.c:
  48         (modest_signature_editor_dialog_init):
  49         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
  50         prevent hibernation while any of these account settings dialogs are open.
  51
  52 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
  53
  54         * src/maemo/Makefile.am:
  55         * src/maemo/modest-osso-state-saving.c:
  56         * src/maemo/modest-osso-state-saving.h: Added
  57         modest_osso_load_state() and modest_osso_save_state() though they do
  58         nothing now. They should iterate through all the open windows and load/save
  59         their state.
  60         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
  61         save state when closing.
  62
  63         * src/maemo/modest-main-window.c:
  64         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
  65         Add a notification handler for the HildonProgram::is-topmost property,
  66         so we can allow hibernation when the application goes into the background.
  67         But we still need to detect when the accounts setup windows are open so
  68         we can stop hibernation when they are open.
  69         To do this, I also added the main window the HildonProgram. This might have
  70         other side-effects/benefits, and should maybe be done for other windows.
  71
  72         * src/maemo/modest-osso-autosave-callbacks.h:
  73         * src/maemo/modest-osso-autosave-callbacks.c:
  74         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
  75         though it does not do anything yet, and we might never need this to do
  76         anything. For instance, we already save drafts.
  77
  78         * src/maemo/modest-platform.c: (modest_platform_init):
  79         Specify the libosso auto-save callback.
  80
  81 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
  82
  83         * src/maemo/modest-platform.c:
  84         (modest_platform_set_update_interval):
  85         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
  86         aparently stays valid between application instances, so we can use this
  87         to remove and reset it later. According to a maemo-developers email from
  88         David Weinehall.
  89
  90 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
  91
  92         * configure.ac: Depend on libalarm for Maemo.
  93
  94         * src/dbus_api/modest-dbus-api.h:
  95         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
  96         (on_send_receive), (modest_dbus_req_handler):
  97         Handle a SEND_RECEIVE D-Bus method.
  98
  99         * libmodest-dbus-client/libmodest-dbus-client.c:
 100         (libmodest_dbus_client_send_and_receive):
 101         * libmodest-dbus-client/libmodest-dbus-client.h:
 102         Add C convenience functions for calling the new D-Bus method.
 103
 104         * src/modest-platform.h:
 105         * src/gnome/modest-platform.c:
 106         * src/maemo/modest-platform.c:
 107         Added modest_platform_set_update_interval(), which uses the
 108         alarmd API on Maemo.
 109         (modest_platform_init),
 110         Call modest_platform_set_update_interval(), using a hard-coded
 111         interval for now (until the global settings dialog is implemented),
 112         though I am not sure that this makes sense yet.
 113
 114 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 115
 116         * src/dbus_api/modest-dbus-callbacks.c:
 117         (modest_osso_cb_hw_state_handler):
 118         * src/dbus_api/modest-dbus-callbacks.h:
 119         * src/maemo/modest-platform.c: (modest_platform_init):
 120         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 121         in case this has some effect on the ability for Maemo to ping the
 122         application.
 123
 124 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 125
 126         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 127         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 128         warning. It is probably a logic error, but I need to fix the build.
 129
 130 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 131
 132         * src/modest-account-mgr.h:
 133         * src/modest-account-mgr.c:
 134         (modest_account_mgr_account_names): Add a gboolean enabled_only
 135         parameter, so we can get lists of onlt the enabled accounts.
 136
 137         (modest_account_mgr_add_account),,
 138         (modest_account_mgr_account_with_display_name_exists):
 139         * src/maemo/modest-msg-edit-window.c: (get_transports):
 140         * src/modest-account-mgr-helpers.c:
 141         (modest_account_mgr_set_first_account_as_default):
 142         * src/modest-init.c: (init_default_account_maybe):
 143         * src/modest-tny-account-store.c: (get_accounts):
 144         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 145         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 146         * tests/check_account-mgr.c: (START_TEST):
 147         Provide the extra parameter, as appropriate.
 148
 149         * src/widgets/modest-account-view.c: (update_account_view):
 150         Do not show disabled accounts (meaning that there is no way to
 151         enable/disable accounts in the UI (the feature is not in our UI
 152         specification), so we can use this internally only to mark unfinished
 153         or temporary account data.
 154
 155         * src/maemo/easysetup/modest-easysetup-wizard.c:
 156         (create_account): Add boolean enable parameter, so we can specify FALSE
 157         to create the temporary account.
 158         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 159         (on_before_next): When finishing, when there is a temporary account, just
 160         set it as enabled.
 161         Also, use a timeout to delay the showing of the dialog until gconf is likely
 162         to return correct information, due to a maemo gconf bug that is fixed in
 163         osso 1.1, but not yet in Bora.
 164         However, the dialog stays on screen after it is destroyed.
 165
 166         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 167         for invalid data when cancelling. Use a hildon note instead of a dialog
 168         to complain about invalid data. Do not show the account-saved note if the
 169         account is disabled (a temporary account that will not really be saved for use
 170         until later.)
 171
 172 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 173
 174         * src/modest-account-mgr-helpers.h:
 175         * src/modest-account-mgr-helpers.c:
 176         Added modest_account_mgr_unset_default_account(),
 177         Added modest_account_mgr_set_first_account_as_default().
 178
 179         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 180         If it was the default account, unset the default account name.
 181
 182         * src/maemo/modest-account-view-window.c:
 183         (on_delete_button_clicked): If it was the default account,
 184         set the first remaining account as the default instead.
 185
 186         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 187         a NULL account or a NULL default account, to prevent a crash. This should
 188         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 189
 190
 191 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 192
 193         * src/widgets/modest-recpt-editor.c:
 194         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 195         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 196         TODO comment for this. This fixes the build.
 197
 198         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 199         be the best place for it. This will in future update all auto-update accounts,
 200         rather than just the current/default account, when that gconf key exists.
 201         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 202         if there are no accounts, before calling do_send_receive().
 203         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 204
 205         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 206         * src/maemo/modest-main-window-ui.h:
 207         * src/maemo/modest-main-window.c: (on_connection_changed),
 208         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 209         directly, becaue the signal handler does more.
 210
 211 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 212
 213         * src/modest-account-mgr-helpers.c:
 214         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 215         for the case that the account does not exist.
 216
 217         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 218         (equivalent to the modest account name) rather than the tinymail account name
 219         (equivalent to the modest account title - human readable) to get the account data.
 220         Check for null account data to prevent the crash, and add a TODO comment saying that
 221         this needs fixing because it is using the server account name instead of the account name.
 222
 223 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 224
 225         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 226         * src/maemo/modest-account-settings-dialog.c: (show_error),
 227         (show_ok):
 228         Use hildon_note_new_information() for informative and error messages,
 229         which seems to be expected for Maemo applications (no documentation that I know of
 230         says this). I am surprised that there is no distinction between info and error
 231         dialogs.
 232
 233 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 234
 235         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 236         it is easy to find where this is used.
 237
 238         * src/maemo/easysetup/modest-easysetup-wizard.c:
 239         (create_page_welcome), (create_page_account_details),
 240         (create_page_user_details), (create_page_complete_easysetup),
 241         (create_page_custom_incoming), (create_page_custom_outgoing),
 242         (create_page_complete_custom):
 243         * src/maemo/modest-account-settings-dialog.c:
 244         (create_page_account_details), (create_page_user_details),
 245         (create_page_incoming), (create_page_outgoing):
 246         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 247         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 248         (modest_connection_specific_smtp_edit_window_init):
 249         * src/maemo/modest-connection-specific-smtp-window.c:
 250         (modest_connection_specific_smtp_window_init):
 251         * src/maemo/modest-signature-editor-dialog.c:
 252         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 253         and scrolling policy as per the Email Application Layout Guide, if I have
 254         understood it.
 255
 256 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 257
 258         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 259         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 260         which were empty, because these vfuncs have been removed from TnyAccountStore.
 261         This fixes the build.
 262
 263 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 264
 265         * src/maemo/modest-main-window.c:
 266         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 267         showing/hiding it. Added TODO because it probably should not be NULL.
 268         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 269         because unnecessary g_warnings() make degugging difficult.
 270
 271 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 272
 273         * src/maemo/modest-msg-edit-window.c:
 274         (modest_msg_edit_window_select_color),
 275         (modest_msg_edit_window_select_background_color): 2 const corrections and
 276         moving 2 #endifs before closing brackets, to fix the build.
 277
 278 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 279
 280         * src/maemo/easysetup/modest-easysetup-wizard.h:
 281         * src/maemo/easysetup/modest-easysetup-wizard.c:
 282         (modest_easysetup_wizard_dialog_finalize),
 283         (on_button_edit_advanced_settings), (create_page_complete_custom),
 284         (on_response), (create_account):
 285         Implement the Advanced Settings edit button, by saving the account information,
 286         for the Advanded Settings dialog to use directly from gconf, and removing it
 287         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 288         Bug #5533 in the projects.maemo.org bugzilla.
 289
 290 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 291
 292         * src/maemo/modest-msg-view-window.c:
 293         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 294         when opening a message window.
 295
 296 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 297
 298         * src/maemo/easysetup/modest-easysetup-wizard.c:
 299         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 300         match the UI spec.
 301
 302         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 303         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 304         gconf settings. I probably added more checks than necessary, but that is safer.
 305
 306         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 307         variable to fix the build, but this seems to be used when it is still NULL.
 308
 309 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 310
 311         * src/modest-platform.h:
 312         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 313         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 314         * src/modest-main.c: Implement this function so we can avoid using
 315         maemo-specific API from cross-platform code.
 316         (main):
 317         * src/modest-tny-account-store.c:
 318         (get_smtp_specific_transport_account_for_open_connection):
 319         * src/modest-ui-actions.c: (check_for_connection),
 320         (modest_ui_actions_on_item_not_found):
 321         Use modest_platform_connect_and_wait() and put #idefs around other
 322         maemo-specific code, because only maemo currently has a way to
 323         identify connection names.
 324
 325 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 326
 327         * src/modest-tny-account-store.h:
 328         * src/modest-tny-account-store.c:
 329         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 330         the connection-specific SMTP server settings in the configuration.
 331
 332         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 333         (on_idle_mail_to):
 334         * src/maemo/modest-main-window.c: (on_connection_changed),
 335         (connect_signals):
 336         * src/modest-main.c: (main), (start_ui), (send_mail):
 337         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 338         that is what is intended.
 339
 340         * src/modest-ui-actions.c: (action_send), (action_receive),
 341         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 342         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 343         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 344         SMTP server is used when it is specified.
 345
 346         (modest_ui_actions_on_send_receive):
 347         Check that a connection is open before proceeding.
 348         Receive and then send, instead of vice-versa, as per the specification.
 349
 350 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 351
 352         * src/modest-mail-operation.c:
 353         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 354         though I guess it should be something other than NULL.
 355
 356 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 357
 358         * src/maemo/easysetup/modest-easysetup-wizard.c:
 359         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 360         combo twice, to avoid an g_warning and to make it visible again.
 361         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 362         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 363         (already intended) dereference when detaching, because we then recreate the menu.
 364         But I am not sure why the warning was happening, and it is possible that this is a memory
 365         leak.
 366
 367 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 368
 369         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 370         and uri_parse_mailto() utility functions.
 371         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 372         the mailto URI.
 373         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 374
 375 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 376
 377         * src/dbus_api/modest-dbus-api.h:
 378         * src/dbus_api/modest-dbus-callbacks.c:
 379         Use an idle callback to execute the modest code in the application's own thread.
 380         Remove the helloworld example method.
 381         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 382         parsed, and the open-message method is not implemented because this is not yet implemented in
 383         modest itself.
 384         * libmodest-dbus-client/libmodest-dbus-client.c:
 385         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 386         (libmodest_dbus_client_open_message):
 387         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 388
 389         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 390         body without crashing.
 391
 392         * tests/dbus_api/Makefile.am:
 393         * tests/dbus_api/test_mail_to.c:
 394         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 395
 396 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 397
 398         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 399         Added file to fix the build. Sorry.
 400
 401         * src/dbus_api/Makefile.am:
 402         * src/dbus_api/modest-dbus-api.h:
 403         * src/dbus_api/modest-dbus-callbacks.h:
 404         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 405         (modest_dbus_req_handler):
 406         Put constants in a separate header so it can be reused by the
 407         client library, without duplication
 408
 409         * libmodest-dbus-client/Makefile.am:
 410         * libmodest-dbus-client/libmodest-dbus-client.c:
 411         (libmodest_dbus_client_call_helloworld),
 412         (libmodfest_dbus_client_send_mail),
 413         (libmodfest_dbus_client_mailto),
 414         (libmodfest_dbus_client_open_message):
 415         * libmodest-dbus-client/libmodest-dbus-client.h:
 416         (Partly) Implement a send_mail D-Bus method.
 417
 418         * tests/dbus_api/Makefile.am:
 419         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 420         the send_email D-Bus method.
 421
 422 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 423
 424         * Makefile.am:
 425         * configure.ac:
 426         * libmodest-dbus-client/Makefile.am:
 427         * libmodest-dbus-client/libmodest-dbus-client.c:
 428         * libmodest-dbus-client/libmodest-dbus-client.h:
 429         * tests/dbus_api/Makefile.am:
 430         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 431         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 432
 433 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 434
 435         * src/maemo/easysetup/modest-easysetup-wizard.c:
 436         (create_page_account_details):
 437         * src/maemo/modest-account-settings-dialog.c:
 438         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 439         widgets, because this might not be the default in future versions of the Maemo GTK+.
 440         However, I can not not get capitalization to work even in a simple test case.
 441
 442 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 443
 444         * src/maemo/easysetup/modest-easysetup-wizard.c:
 445         (create_page_custom_incoming), (create_page_custom_outgoing):
 446         * src/maemo/modest-account-settings-dialog.c:
 447         (create_page_account_details), (create_page_incoming),
 448         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 449         instead of using gtk_check_button_with_label(), so they are aligned like the other
 450         widgets, as per the UI spec.
 451
 452 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 453
 454         * src/maemo/easysetup/modest-easysetup-wizard.c:
 455         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 456         * src/widgets/modest-validating-entry.c:
 457         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 458         Modest prefix instead of an EasySetup prefix.
 459
 460 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 461
 462         * src/widgets/modest-validating-entry.h:
 463         * src/widgets/modest-validating-entry.c: (on_insert_text),
 464         Added easysetup_validating_entry_set_max_func(), used to set a callback
 465         to call when the max number of characters is reached. GtkEntry has a max-length
 466         already but is silent about it.
 467
 468         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 469         (create_page_account_details), (create_page_user_details),
 470         (create_account):
 471         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 472         (create_page_account_details), (create_page_user_details),
 473         (create_page_outgoing):
 474         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 475         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 476         the UI spec, when the user tries to enter more than the max number of characters.
 477
 478 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 479
 480         * src/maemo/easysetup/modest-easysetup-wizard.c:
 481         (create_page_user_details), (create_page_custom_incoming),
 482         (create_page_custom_outgoing):
 483         * src/maemo/modest-account-settings-dialog.c:
 484         (create_page_user_details), (create_page_incoming),
 485         (create_page_outgoing):
 486         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 487         (modest_connection_specific_smtp_edit_window_init):
 488         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 489         not appropriate. Bad Maemo-specific defaults!.
 490
 491 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 492
 493         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 494         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 495         (modest_signature_editor_dialog_set_settings):
 496         Disable the label and textview when the checkbox is disabled, and use the
 497         specified (UI spec) default signature text.
 498
 499 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 500
 501         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 502         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 503
 504         * src/modest-defs.h:
 505         * src/modest-account-mgr-helpers.h:
 506         * src/modest-account-mgr-helpers.c:
 507         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 508
 509         * src/maemo/Makefile.am:
 510         * src/maemo/modest-signature-editor-dialog.c:
 511         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 512         as per the UI spec.
 513
 514         * src/maemo/modest-account-settings-dialog.h:
 515         * src/maemo/modest-account-settings-dialog.c:
 516         (modest_account_settings_dialog_finalize), (on_button_signature),
 517         (save_configuration): Use the new dialog when the Edit button is pressed, and
 518         save the changes if necessary, as per the UI spec.
 519
 520 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 521
 522         * src/maemo/Makefile.am:
 523         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 524         based on maemo-develoers email from Dirk.
 525
 526         * src/maemo/easysetup/modest-easysetup-wizard.c:
 527         (create_page_welcome), (create_page_account_details),
 528         (create_page_user_details), (create_page_complete_easysetup),
 529         (create_page_custom_incoming), (create_page_custom_outgoing),
 530         (create_page_complete_custom),
 531         (modest_easysetup_wizard_dialog_init):
 532         * src/maemo/modest-account-settings-dialog.c:
 533         (create_page_account_details), (create_page_user_details),
 534         (create_page_incoming), (create_page_outgoing),
 535         (modest_account_settings_dialog_init):
 536         * src/maemo/modest-connection-specific-smtp-window.c:
 537         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 538
 539 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 540
 541         * src/maemo/easysetup/modest-easysetup-wizard.c:
 542         (create_page_account_details), (create_page_custom_outgoing),
 543         (create_page_complete_custom):
 544         * src/maemo/modest-account-settings-dialog.c:
 545         (create_page_user_details), (create_page_incoming),
 546         (create_page_outgoing):
 547         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 548         (modest_connection_specific_smtp_edit_window_init):
 549         Use the correct (UI spec) port min/max, and use horizontal separators,
 550         as per the UI spec.
 551
 552 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 553
 554         * src/maemo/easysetup/modest-easysetup-wizard.c:
 555         (set_default_custom_servernames):
 556         * src/maemo/modest-account-settings-dialog.c:
 557         (create_page_incoming), (on_combo_outgoing_security_changed),
 558         (on_combo_incoming_security_changed), (create_page_outgoing),
 559         (modest_account_settings_dialog_set_account_name),
 560         (save_configuration):
 561         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 562         (on_combo_security_changed),
 563         (modest_connection_specific_smtp_edit_window_init),
 564         (modest_connection_specific_smtp_edit_window_set_connection),
 565         (modest_connection_specific_smtp_edit_window_get_settings):
 566         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 567         as per the UI spec.
 568
 569 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 570
 571         * po/en_GB.po:
 572         * src/maemo/easysetup/modest-easysetup-wizard.c:
 573         (create_page_custom_outgoing), (create_page_complete_custom):
 574         * src/maemo/modest-account-settings-dialog.c:
 575         (create_page_user_details), (create_page_outgoing):
 576         * src/maemo/modest-account-view-window.c: (button_box_new):
 577         Use changed logical IDs as per the most recent UI spec:
 578         mcen_bd_emailsetup_edit -> mcen_bd_edit
 579         mcen_bd_emailsetup_delete -> mcen_bd_delete
 580         mcen_bd_emailsetup_close -> mcen_bd_close
 581
 582 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 583
 584         * configure.ac:
 585         * src/Makefile.am:
 586         * src/dbus_api/Makefile.am:
 587         * src/dbus_api/modest-dbus-callbacks.c:
 588         * src/dbus_api/modest-dbus-callbacks.h:
 589         * src/maemo/modest-platform.c: (modest_platform_init):
 590         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 591         method.
 592         * tests/Makefile.am:
 593         * tests/dbus_api/Makefile.am:
 594         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 595
 596 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 597
 598         * src/maemo/modest-account-settings-dialog.c:
 599         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 600         Removed unnecessary includes.
 601
 602 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 603
 604         * src/maemo/easysetup/modest-easysetup-wizard.c:
 605         * src/maemo/modest-account-settings-dialog.c:
 606         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 607         * src/widgets/Makefile.am:
 608         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 609         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 610         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 611         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 612         * src/widgets/modest-secureauth-combo-box.c:
 613         * src/widgets/modest-secureauth-combo-box.h:
 614         * src/widgets/modest-serversecurity-combo-box.c:
 615         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 616         made the GObject names more consistent with the rest of the Modest code.
 617
 618 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 619
 620         * src/maemo/easysetup/Makefile.am:
 621         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 622         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 623         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 624         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 625         * src/maemo/easysetup/modest-easysetup-wizard.c:
 626         * src/maemo/easysetup/modest-validating-entry.c:
 627         * src/maemo/easysetup/modest-validating-entry.h:
 628         * src/maemo/modest-account-settings-dialog.c:
 629         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 630         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 631         widgets/ because they are used outside of easysetup too. After checking in,
 632         svn will allow me to rename them too.
 633
 634 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/gnome/modest-msg-edit-window.c:
 637         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 638         linker error, to fix the build on the GNOME platform.
 639         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 640         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 641         ifdefed out to avoid a warning.
 642
 643 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 644
 645         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 646         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 647         some alternative for GTK+ 2.6.
 648
 649 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 650
 651         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 652
 653         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 654         specified for EmailAccountsDialog in UI spec.
 655
 656         * src/maemo/easysetup/modest-easysetup-wizard.c:
 657         * src/maemo/easysetup/modest-easysetup-wizard.h:
 658         * src/maemo/modest-account-settings-dialog.c:
 659         * src/maemo/modest-account-settings-dialog.h:
 660         Reuse a member window widget for the connection-specific SMTP server accounts,
 661         so we can tell it to create/save the accounts only if we actually save changes.
 662
 663         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 664         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 665         (modest_connection_specific_smtp_edit_window_get_settings):
 666         Return a struct instance for temporarily remembering the entered data.
 667
 668         * src/maemo/modest-connection-specific-smtp-window.h:
 669         * src/maemo/modest-connection-specific-smtp-window.c:
 670         (modest_connection_specific_smtp_window_finalize),
 671         (modest_connection_specific_smtp_window_fill_with_connections),
 672         (on_button_edit),
 673         (modest_connection_specific_smtp_window_save_server_accounts),
 674         (update_model_server_names): Do not actually save data until asked,
 675         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 676
 677         (on_selection_changed),
 678         (modest_connection_specific_smtp_window_init): Disable the edit
 679         button when nothing is selected.
 680
 681         * src/modest-account-mgr-helpers.c:
 682         * src/modest-account-mgr-helpers.h:
 683         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 684         elsewhere.
 685
 686 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 687
 688         * src/modest-account-mgr-helpers.h:
 689         * src/modest-account-mgr-helpers.c:
 690         (modest_account_mgr_get_unused_account_name),
 691         (modest_account_mgr_get_unused_account_display_name): Added these
 692         utility functions, to avoid code duplication.
 693
 694         * src/maemo/easysetup/modest-easysetup-wizard.c:
 695         (create_page_account_details), (create_account):
 696         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 697         (on_combo_security_changed),
 698         (modest_connection_specific_smtp_edit_window_init),
 699         (modest_connection_specific_smtp_edit_window_save_settings):
 700         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 701         * src/maemo/modest-connection-specific-smtp-window.c:
 702         (modest_connection_specific_smtp_window_finalize),
 703         (modest_connection_specific_smtp_window_fill_with_connections),
 704         (on_button_edit), (modest_connection_specific_smtp_window_init):
 705         * src/maemo/modest-connection-specific-smtp-window.h:
 706         Implementing saving of connection-specific server accounts.
 707
 708         But I need to refactor this so we can save the data for each
 709         possible connection-specific account and only actually create the server accounts
 710         when the easysetup finished, or the OK button is pressed on the account settings
 711         dialog.
 712
 713 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 714
 715         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 716         (on_combo_security_changed):
 717         (modest_connection_specific_smtp_edit_window_init):
 718         Auto-fill the port number as in the account settings.
 719
 720         (modest_connection_specific_smtp_edit_window_set_connection):
 721         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 722         * src/maemo/modest-connection-specific-smtp-window.c:
 723         (fill_with_connections), (on_button_edit),
 724         (modest_connection_specific_smtp_window_init):
 725         Turn the edit window into a dialog to simplify the code, and
 726         set a WM hint as in a GtkDialog, because only a popup can be on top of
 727         another window in Maemo, and popups usually have no WM decoration.
 728
 729         * src/modest-defs.h:
 730         * src/modest-account-mgr-helpers.c:
 731         (modest_account_mgr_set_connection_specific_smtp),
 732         (modest_account_mgr_remove_connection_specific_smtp),
 733         (modest_account_mgr_get_connection_specific_smtp):
 734         * src/modest-account-mgr-helpers.h: Some functions to write the
 735         connection-specific SMTP server information. Not yet used.
 736
 737
 738         * src/widgets/modest-folder-view.c: (text_cell_data):
 739         Fix a warning about an uninitialized variable.
 740         (on_configuration_key_changed): Put an #ifdef around the use
 741         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 742
 743 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 744
 745         * src/maemo/modest-account-settings-dialog.h:
 746         * src/maemo/modest-account-settings-dialog.c:
 747         Added connect_for_modified() utility function to mark the new modified boolean.
 748
 749         (create_page_account_details), (create_page_user_details),
 750         (create_page_incoming), (create_page_outgoing), (on_response),
 751         (modest_account_settings_dialog_init),
 752         (modest_account_settings_dialog_set_account_name):
 753         Only warn about unsaved changes when there are actually unsaved changes.
 754
 755         * src/modest-account-mgr-helpers.c:
 756         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 757         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 758         to get the data from there in future.
 759
 760 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 761
 762         * src/modest-defs.h:
 763
 764         * src/modest-account-mgr-helpers.h:
 765         * src/modest-account-mgr-helpers.c:
 766         Store the security account setting in a single conf key instead of using
 767         the options list, so that the list is left for just the to-be-removed camel hack,
 768         and because gconf_client_set_list() is failing for some reason.
 769
 770         * src/modest-account-mgr.c:
 771         (modest_account_mgr_add_server_account):
 772         * src/maemo/modest-account-settings-dialog.c:
 773         (modest_account_settings_dialog_set_account_name),
 774         (save_configuration): Use the renamed functions.
 775
 776
 777 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 778
 779         * src/widgets/Makefile.am:
 780         * src/widgets/modest-limit-retrieve-combo-box.c:
 781         * src/widgets/modest-limit-retrieve-combo-box.h:
 782         * src/widgets/modest-retrieve-combo-box.c:
 783         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 784         the account settings dialog.
 785
 786         * src/modest-defs.h:
 787         * src/modest-account-mgr-helpers.h:
 788         * src/modest-account-mgr-helpers.c:
 789         (modest_server_account_get_option_secure_auth),
 790         (modest_server_account_set_option_secure_auth):
 791         * src/modest-account-mgr.c:
 792         (modest_account_mgr_add_server_account):
 793         Use the existing AUTH_MECH conf key for the secure-auth setting,
 794         instead of putting it in the list options, because this was actually used already.
 795
 796         * src/maemo/modest-account-settings-dialog.c:
 797         (create_page_account_details),
 798         (modest_account_settings_dialog_set_account_name),
 799         (save_configuration):
 800         * src/maemo/modest-account-settings-dialog.h:
 801         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 802         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 803
 804 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 805
 806         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 807         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 808         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 809
 810         * src/modest-defs.h:
 811         * src/maemo/modest-account-settings-dialog.c:
 812         (create_page_incoming), (on_combo_outgoing_security_changed),
 813         (on_combo_incoming_security_changed), (create_page_outgoing),
 814         (modest_account_settings_dialog_set_account_name),
 815         (save_configuration): Load/Save the port number, and change it when the
 816         security combo changes, to suitable defaults.
 817
 818 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 819
 820         * src/modest-account-mgr.c:
 821         (modest_account_mgr_add_server_account): Set the security and secure-auth
 822         options, and add a comment saying that the other camel-specific options should be
 823         removed in future.
 824
 825 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 826
 827         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 828         found by valgrind.
 829         * src/modest-tny-account-store.c: (account_list_free),
 830         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 831         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 832         easy to fix.
 833
 834 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 835
 836         * src/modest-protocol-info.c:
 837         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 838         is required by our UI spec. Maybe something in our implementation will use this eventually.
 839         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 840         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 841         instead of the previous 0 placeholder.
 842
 843         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 844         secure-auth settings.
 845         * src/modest-account-mgr-helpers.h:
 846         * src/modest-account-mgr-helpers.c:
 847         (modest_server_account_data_get_option_secure_auth),
 848         (modest_server_account_set_option_secure_auth),
 849         (modest_server_account_data_get_option_security),
 850         (modest_server_account_set_option_security): Added this API for getting and setting the security
 851         and secure-auth settings.
 852
 853         * src/maemo/modest-account-settings-dialog.h:
 854         * src/maemo/modest-account-settings-dialog.c:
 855         (modest_account_settings_dialog_finalize), (check_data),
 856         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 857         about changing titles.
 858         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 859         (save_configuration): Save the security and secure-auth settings.
 860
 861         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 862         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 863
 864 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 865
 866         * src/modest-defs.h:
 867         * src/modest-account-mgr.c:
 868         (modest_account_mgr_add_server_account):
 869         Added and used defines for the options key and value pair strings,
 870         that are used so far, though they do not seem to correspond to anything in our
 871         UI specs or ModestProtocol enum.
 872
 873         * src/modest-account-mgr-helpers.h:
 874         * src/modest-account-mgr-helpers.c:
 875         (compare_option_strings_for_name),
 876         (modest_server_account_data_get_option_value),
 877         (modest_server_account_data_get_option_bool),
 878         (modest_account_mgr_get_server_account_option):
 879         Added helper functions for parsing the options GSList.
 880
 881 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 882
 883         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 884         display name is based on the supplied account name.
 885         * src/modest-account-mgr.c:
 886         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 887         with an inefficient, but good-enough, implementation.
 888
 889         * src/maemo/easysetup/modest-easysetup-wizard.c:
 890         (create_page_account_details), (on_before_next), (create_account):
 891         Check for existing display names rather than (non-user-visible) account names, and just
 892         create and set a unique account name at the end.
 893
 894         * src/maemo/modest-account-settings-dialog.c:
 895         (modest_account_settings_dialog_init),
 896         (modest_account_settings_dialog_set_account_name),
 897         (create_page_incoming): Show the display name, instead of the account name.
 898         (on_response): Do some (not all) extra checks, as in the UI spec.
 899         (save_configuration): Save the display name if it was changed.
 900
 901 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 902
 903         * po/en_GB.po: Added needed logical ID and translation.
 904         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 905         (init_view): Made the is-default column clicking work.
 906
 907 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 908
 909         * configure.ac:
 910         * src/maemo/easysetup/Makefile.am:
 911         * src/maemo/easysetup/modest-easysetup-wizard.c:
 912         (modest_easysetup_wizard_dialog_init):
 913         * src/maemo/easysetup/provider-data-test.keyfile:
 914         * src/maemo/easysetup/provider-data.keyfile:
 915         Moved the provider data file to the new modest-providers-data package and used it from there.
 916
 917 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 918
 919         * src/modest-local-folder-info.c:
 920         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 921         N_() was already used on the static strings, but this just marks it for translation without
 922         using the translation.
 923
 924 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 925
 926         * src/maemo/modest-account-settings-dialog.c:
 927         (create_page_incoming),
 928         (modest_account_settings_dialog_set_account_name):
 929         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 930         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 931         I will do this if nobody else gets there first.
 932
 933 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 934
 935         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 936         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 937         save the security stuff.
 938
 939 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 940
 941         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 942         Set the email address and user fullname, which I now see must be
 943         done separately.
 944
 945         * src/maemo/modest-account-settings-dialog.h:
 946         * src/maemo/modest-account-settings-dialog.c:
 947          (on_response),
 948         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 949         leave-on-server and authentication.
 950         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 951         how to do the rest.
 952
 953 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 954
 955
 956         * src/maemo/modest-account-settings-dialog.c:
 957         * src/maemo/modest-account-settings-dialog.h:
 958         Most (but not all) of the widgets are now present as specified by the UI spec.
 959         No changes are yet saved, and some details are not properly shown yet.
 960
 961         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 962
 963 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 964
 965         * src/maemo/Makefile.am:
 966         * src/maemo/modest-account-settings-dialog.c:
 967         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 968         an existing account. Doesn't do much yet.
 969
 970         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 971         Open the accounts settings dialog when Edit is clicked.
 972
 973 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 974
 975         * src/maemo/easysetup/Makefile.am:
 976         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 977         (load_from_file):
 978         * src/maemo/easysetup/modest-easysetup-wizard.c:
 979         (modest_easysetup_wizard_dialog_init):
 980         Try to get the source directory from the build system,
 981         instead of hard-coding "./" into the source code, when opening our local
 982         copies of the configuration files.
 983         But this still fails when opening the wizard from the Accounts window,
 984         maybe because the working directory seems to change at runtime.
 985         So the wizard will fail the second time unless you copy the files into their
 986         proper locations - see the stdout warnings for the paths.
 987
 988         (create_page_account_details),(on_before_next):
 989         Check for existing non-server accounts instead of server accounts,
 990         so the default account name is useful again, and to prevent trying to
 991         recreate accounts.
 992
 993         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 994         Show the wizard when New is clicked.
 995
 996         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 997         (init_view): Show the column headers, and show the columns that are
 998         specified in the UI specs. However, something in Maemo's GTK+ prevents
 999         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1000         change the default account. This is despite unsetting the special properties.
1001
1002 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1003
1004         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1005         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1006         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1007         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1008         to make that clearer.
1009         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1010
1011 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1012
1013         * src/maemo/modest-account-view-window.c:
1014         (modest_account_view_window_init),
1015         (modest_account_view_window_new):
1016         Use the same buttons as specified in the
1017         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1018         the existing widgets, which never had a chance of working.
1019         Put the ModestAccountView treeview in a scrolled window.
1020         Do not repeat the initialization in both _init() and _new().
1021
1022         * src/widgets/modest-account-view.c: (update_account_view):
1023         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1024         this widget and window shows no accounts.
1025
1026         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1027
1028 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1029
1030         * src/maemo/easysetup/modest-easysetup-wizard.c:
1031         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1032         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1033         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1034         which seems wrong.
1035
1036         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1037         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1038         accounts exist yet, as in the UI spec.
1039
1040         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1041
1042 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1043
1044         * src/maemo/Makefile.am:
1045         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1046         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1047         New window for editing connection-specific smtp details.
1048         Not fully implemented.
1049
1050         * src/maemo/modest-connection-specific-smtp-window.c:
1051         (modest_connection_specific_smtp_window_finalize) :
1052         unref the tree model.
1053         (on_button_edit): Show the edit window.
1054
1055 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1056
1057         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1058         error for me.
1059
1060         * src/maemo/Makefile.am:
1061         * src/maemo/modest-connection-specific-smtp-window.c:
1062         * src/maemo/modest-connection-specific-smtp-window.h:
1063         New window for showing the list of connections, for connection-specific
1064         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1065         * src/maemo/easysetup/modest-easysetup-wizard.c:
1066         (create_page_custom_outgoing): Show the new window when the button is clicked.
1067
1068 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1069
1070         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1071         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1072         * src/maemo/modest-msg-edit-window.c:
1073         (modest_msg_edit_window_insert_image):
1074         * src/modest-conf.c: (modest_conf_key_escape):
1075         * src/modest-mail-operation.c:
1076         (modest_mail_operation_send_new_mail):
1077         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1078         (modest_ui_actions_on_new_account):
1079         * src/widgets/modest-attachment-view.c: (update_filename_request):
1080         * src/widgets/modest-mail-header-view.c:
1081         Corrected warnings that were breaking the build, by commenting out unused variables,
1082         and a function, and by including a header.
1083
1084 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1085
1086         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1087         so we can #ifdef around platform-specific code when necessary.
1088         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1089         to allow this to build for the GNOME platform too.
1090
1091 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1092
1093         * src/maemo/easysetup/modest-easysetup-wizard.c:
1094         Added util_increment_name() and used it in create_page_account_details()
1095         to make sure that the default account name is always a new name.
1096
1097         (modest_easysetup_wizard_dialog_init),
1098         (set_default_custom_servernames): Some minor memory management fixes.
1099
1100 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1101
1102         * Makefile.am:
1103         * configure.ac:
1104         * src/modest-runtime.c: (init_i18n): Restored the translation
1105         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1106         are defined in config.h, and the translations are installed.
1107
1108         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1109         is defined for translation.
1110
1111 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1112
1113         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1114         (load_from_file):
1115         * src/maemo/easysetup/modest-easysetup-wizard.c:
1116         (modest_easysetup_wizard_dialog_init):
1117         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1118         Use realistic paths (though they should use $prefix generically) to the
1119         mcc_mapping and provider-data.keyfile files which might work when they
1120         are installed by the future version of the operator-wizard package,
1121         and then fallback to paths in our source code, with an explanatory
1122         warning.
1123
1124 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1125
1126         * configure.ac:
1127         * src/Makefile.am:
1128         * src/maemo/Makefile.am:
1129         * src/maemo/easysetup/: Added files from the previously-exernal
1130         osso-modest-easysetup.
1131         * src/maemo/modest-main-window-ui.h:
1132         * src/modest-ui-actions.c:
1133         * src/modest-ui-actions.h:
1134         Added modest_ui_actions_on_new_account() as a signal handler for the
1135         New Account menu item. It shows the easysetup wizard.
1136         * po/en_GB.po: Added additional needed logical IDs and translations.
1137
1138 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1139 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1140