1 2007-06-12 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
4 NULL, so that the signals get all the keys. This should not actually
5 change any behaviour because we currently update everything when anything
8 2007-06-12 Murray Cumming <murrayc@murrayc.com>
10 * src/widgets/modest-folder-view.c: (text_cell_data),
11 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
12 (find_inbox_iter): If tinymail tells us that the folder is
13 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
14 This causes the inbox to be selected at startup, fixing part of
15 projects.maemo.org bug NB#56305.
17 * src/modest-ui-dimming-rules.c:
18 (modest_ui_dimming_rules_on_tools_smtp_servers):
19 * src/modest-ui-dimming-rules.h: Added a callback function to dim
20 the SMTP servers menu item.
21 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
22 that the SMTP Servers menu item is dimmed when there are no accounts,
23 as a future version of the UI spec will require. This fixes
24 projects.maemo.org bug NB#56305.
26 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
28 * src/maemo/modest-maemo-utils.c:
29 (modest_maemo_utils_get_supported_secure_authentication_methods):
30 Added label to dialog instead of unreadable title
32 * src/maemo/modest-main-window.c: (sync_accounts_cb),
33 (modest_main_window_new):
34 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
37 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
38 * src/modest-account-mgr.h:
39 Added method to avoid code duplication
41 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
42 (modest_ui_actions_on_send_receive):
43 Use modest_account_mgr_has_accounts
45 2007-06-11 Murray Cumming <murrayc@murrayc.com>
47 * src/maemo/easysetup/modest-presets.c:
48 (modest_presets_get_info_server_security): Do not report secure auth
50 * src/modest-protocol-info.c: Use the defines for the gconf key names
51 for secure authentication. This was not working because we were writing
52 Password and reading password, and the check was case sensitive.
53 With this, gmail now works for receiving and sending when created via
56 2007-06-11 Murray Cumming <murrayc@murrayc.com>
58 * src/maemo/easysetup/modest-presets.c:
59 (modest_presets_get_info_server_security): Correct the key name for
60 SecureSmtp, because it seems to be case-sensitive.
61 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
62 Do not try to get the 0th notebook page if there are 0 pages, to
65 2007-06-11 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
68 Prevent use of the new notification feature for now, because it currently
69 shows one dialog for each new email, which is annoying.
71 2007-06-11 Murray Cumming <murrayc@murrayc.com>
73 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
74 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
75 when no country was selected, so that we show the global ones.
76 * src/maemo/easysetup/modest-presets.c:
77 (modest_presets_get_providers): Return only the global providers, not
78 all providers when mmc=0 was requested.
80 2007-06-11 Murray Cumming <murrayc@murrayc.com>
82 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
83 (easysetup_provider_combo_box_fill): Remove debug code that showed the
84 provider ID in the combo.
86 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
87 Do not show the page numbers, because it would be confusing when we add
88 the 2 extra pages for the custom setup, when the user chooses the "Other"
89 provider. This fixes projects.maemo.org bug NB#59028
91 * src/modest-init.c: (modest_init_init_core),
92 (modest_init_local_folders):
94 * src/modest-tny-account.c:
95 (modest_tny_account_new_for_local_folders): Do not create default folders
96 for the memory card. This should fix projects.maemo.org bug NB#59328.
98 2007-06-11 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
101 Free the changed_conf_keys string items. They are already freed in the
102 idle handler if that runs first.
104 2007-06-11 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-ui-actions.c:
107 (modest_ui_actions_on_password_requested): Check that the server name
108 is not NULL, because I just saw a password dialog with (null) as the
111 * src/modest-tny-folder.[h|c]: Added
112 modest_tny_folder_is_memory_card_folder().
113 * src/modest-ui-dimming-rules.c:
114 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
115 menu item for memory cards, as per the UI spec (section 7.4). This should
116 fix projects.maemo.org bug NB#59297.
118 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
120 * src/maemo/modest-main-window.c: (sync_accounts_cb):
121 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
122 is another problem with the code, see Murray's comment at line 772)
124 2007-06-08 Murray Cumming <murrayc@murrayc.com>
126 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
127 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
128 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
129 (load_from_file), (easysetup_country_combo_box_init),
130 (easysetup_country_combo_box_get_active_country_ids),
131 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
132 instead of just one ID, to avoid duplicate country names in the UI.
134 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
135 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
136 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
137 a single ID, avoiding duplicate providers.
138 * src/maemo/easysetup/modest-easysetup-wizard.c:
139 (on_combo_account_country): Adapt to use a list.
141 2007-06-08 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
144 keys changed in the last X seconds.
146 * src/modest-account-mgr.h:
147 * src/modest-account-mgr.c: (on_timeout_notify_changes),
148 (on_key_change), (modest_account_mgr_class_init),
149 (modest_account_mgr_init), (modest_account_mgr_finalize):
150 As the keys are changed, save them in a GSList* and signal that GSList*
151 further every X seconds, to batch changes, to allow us to do just one
152 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
153 bug NB#56941 and other (UI-blocking) delays when changing account settings.
155 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
156 changed signal signature.
158 * src/modest-conf.c: (modest_conf_set_list),
159 (modest_conf_on_change): Reenable notification.
161 (modest_conf_maemo_fake_on_change): Comment out the hack that
162 notified immediately instead of asynchronously.
164 * src/widgets/modest-account-view.h:
165 * src/widgets/modest-account-view.c:
166 (update_account_view): Select the previously-selected account ID,
167 if possible. This fixes projects.maemo.org bug NB#56933.
169 (on_account_changed), (on_account_removed),
170 (modest_account_view_select_account):
172 Remove the block/unblock functions
173 because they were not useful.
175 * src/maemo/modest-account-view-window.c:
176 (on_delete_button_clicked), (on_edit_button_clicked),
177 (on_new_button_clicked): Remove the use of the non-working block/unblock.
179 2007-06-08 Murray Cumming <murrayc@murrayc.com>
181 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
182 Improve the error dialog to show Incorrect Account Settings, which seems
183 clearer, and say that the internal error message (to be removed from the
184 dialog later) is often misleading.
185 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
187 * src/modest-tny-account.c:
188 (modest_tny_account_new_from_server_account): Uncomment the printf of the
189 URL because this is so useful for debugging on the device.
191 * src/widgets/modest-serversecurity-combo-box.c:
192 (modest_serversecurity_combo_box_fill): Correct a logical ID.
194 2007-06-08 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-mail-operation.c:
197 (modest_mail_operation_send_new_mail):
198 Added a comment about a nasty but apparently harmless message. Details
199 added to the wiki g_warnings() page.
201 2007-06-08 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
204 (modest_tny_send_queue_class_init):
205 Do not use the priv struct because it is empty, to avoid g_warnings
206 about a non-existant priv struct.
208 * src/modest-tny-account-store.c:
209 (modest_tny_account_store_get_server_account),
210 (modest_tny_account_store_get_transport_account_for_open_connection
211 ): Do not try to get transport server accounts for local folders,
212 because they don't have any. This avoids a g_warning().
214 * src/maemo/modest-main-window.c:
215 (modest_main_window_notify_send_receive_initied),
216 (on_configuration_key_changed):
217 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
219 * src/modest-mail-operation.c:
220 (modest_mail_operation_update_account):
221 * src/modest-tny-account-store.h:
222 * src/modest-tny-account.c:
223 (modest_tny_account_get_special_folder),
224 (modest_tny_account_new_for_local_folders),
225 (modest_tny_account_new_for_per_account_local_outbox_folder):
226 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
227 * src/modest-tny-local-folders-account.c:
228 (add_account_folders_to_merged_folder):
229 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
230 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
231 (modest_ui_actions_on_send):
232 * src/widgets/modest-folder-view.c: (update_model):
233 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
234 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
235 modest_tny_account_store_get_tny_account_by_account() to
236 modest_tny_account_store_get_server_account() to make the code clearer.
238 2007-06-07 Marcus Bauer <marcusb@openismus.com>
240 * src/dbus_api/modest-dbus-api.h:
241 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
242 * src/maemo/modest-msg-edit-window.c:
243 (modest_msg_edit_window_attach_file_noninteractive):
244 added g_warning in case the file to be attached does not exist
245 * tests/dbus_api/test_compose_mail.c: (main):
246 removed obsolete comment, added generic files as test case
248 2007-06-07 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-tny-account-store.c: (get_server_accounts):
251 Create the local folders account only once, not once for each outbox, and
252 not only when there are some outboxes.
254 2007-06-07 Murray Cumming <murrayc@murrayc.com>
256 * src/widgets/modest-folder-view.c: (update_model): Comment out some
257 code that is causing a crash at startup. Sergio says that he is fixing this.
259 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
261 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
262 * src/maemo/modest-account-settings-dialog.c:
263 (create_page_outgoing),
264 (modest_account_settings_dialog_set_account_name),
265 (save_configuration):
266 - Fixed handling of the "Use secure authentication" toggle to comply with
267 the ui specification. See also projects.maemo.org bug NB#58400
269 - Restore the Secure connection setting combo correctly when loading
272 * src/maemo/modest-maemo-utils.c:
273 (on_camel_account_get_supported_secure_authentication),
274 (modest_maemo_utils_get_supported_secure_authentication_methods):
275 Fixed a crasher if operation is canceled
277 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
278 (modest_protocol_info_auth_is_secure):
279 * src/modest-protocol-info.h:
281 Added two new methods to determine if a protocol/auth method is secure/encrypted in
282 the sense of the "Use secure authentication" toggle.
284 2007-06-07 Murray Cumming <murrayc@murrayc.com>
286 * src/modest-tny-account-store.h:
287 * src/modest-tny-account-store.c:
288 Added modest_tny_account_store_get_local_folders_account().
290 * src/modest-tny-folder.h:
291 * src/modest-tny-folder.c:
292 (modest_tny_folder_get_account):
293 Added this replacement for tny_folder_get_account() which returns
294 the local-folders account for TnyMergeFolders, to avoid the
295 warning about the unimplemented get_account_func() vfunc().
297 (modest_tny_folder_get_rules),
298 * src/modest-ui-actions.c:
299 (modest_ui_actions_on_folder_selection_changed):
300 * src/modest-mail-operation.c:
301 (modest_mail_operation_remove_folder),
302 (modest_mail_operation_xfer_folder),
303 (modest_mail_operation_rename_folder),
304 (modest_mail_operation_get_msg),
305 (modest_mail_operation_get_msgs_full),
306 (modest_mail_operation_remove_msg),
307 (modest_mail_operation_xfer_msgs),
308 (modest_mail_operation_refresh_folder):
309 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
311 2007-06-07 Murray Cumming <murrayc@murrayc.com>
313 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
314 (modest_server_account_set_security):
315 * src/modest-defs.h: Add comments explaining that our
316 UI spec means TLS when it says Normal, so these do not look like errors.
318 * src/modest-tny-account.c:
319 (modest_tny_account_new_from_server_account): Use the new tinymail
320 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
321 for TLS. This should fix projects.maemo.org bug NB#58460.
323 2007-06-06 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/easysetup/modest-easysetup-wizard.c:
326 (create_account): Correct the position of the gconf sanity check warning.
327 (on_button_edit_advanced_settings): Show the dialog immediately, instead
328 of using the g_idle_add() hack, because this does not seem to be necessary
329 on osso 1.1. It might even work on Maemo Bora if the problems were actually
330 caused by something other than maemo's gconf.
331 This fixes projects.maemo.org bug #59022.
333 2007-06-06 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-account-mgr-helpers.c:
336 (modest_account_mgr_get_default_account): Do not check that the account
337 exists if there is no default account (NULL), to fix a runtime warning.
339 2007-06-06 Murray Cumming <murrayc@murrayc.com>
341 * src/widgets/modest-folder-view.c: (update_model):
342 Do not unref the treemodel before we have finished with it.
343 This prevents a valgrind warning and an occasional crash at startup.
345 2007-06-06 Marcus Bauer <marcusb@openismus.com>
347 * libmodest-dbus-client/libmodest-dbus-client.h:
348 added libmodest_dbus_client_compose_mail()
349 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
351 added functions needed for SendAsMail() functionality
352 * src/maemo/modest-msg-edit-window.c:
353 (modest_msg_edit_window_attach_file_noninteractive):
354 non interactively attaching files to message edit window
355 * src/widgets/modest-msg-edit-window.h:
356 * tests/dbus_api/Makefile.am:
357 added test_compose_mail.c
358 * tests/dbus_api/test_compose_mail.c: (main):
360 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
362 * src/modest-account-view.c:
363 Fixed bug projects.maemo.org bug NB#59307
365 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
367 * src/maemo/easysetup/modest-easysetup-wizard.c:
368 (get_serverport_incoming), (on_before_next), (create_account):
369 * src/maemo/modest-account-settings-dialog.c:
370 (modest_account_settings_dialog_set_account_name):
371 * src/maemo/modest-maemo-utils.c:
372 (on_camel_account_get_supported_secure_authentication_status),
373 (on_camel_account_get_supported_secure_authentication),
374 (on_secure_auth_cancel),
375 (modest_maemo_utils_get_supported_secure_authentication_methods):
377 Implemented security authentication for settings and easysetup.
379 2007-06-05 Murray Cumming <murrayc@murrayc.com>
381 * src/maemo/modest-main-window.c: (create_details_widget):
382 Show the total size for memory card accounts too, instead of showing
383 the name again. Fixes bug projects.maemo.org bug NB#59307.
385 2007-06-05 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-simple-folder-store.c:
389 * src/modest-tny-simple-folder-store.h: Removed.
391 * src/modest-tny-local-folders-account.h
392 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
393 for the local-folders maildir, with an extra TnyMergedFolder containing
394 the folders of the per-account outbox store accounts.
395 * src/modest-tny-account-store.c: (get_server_accounts):
396 Add the outboxes to the special local folders account after creating it.
398 * src/modest-tny-account.c:
399 (modest_tny_account_new_for_local_folders): Create the derived
400 account when creating the main local-folders account.
402 * src/maemo/modest-main-window.c: (create_details_widget),
403 (modest_main_window_set_contents_style):
404 Adapted to the use of the derived account instead of the folder store.
406 * src/modest-ui-actions.c:
407 (modest_ui_actions_on_folder_selection_changed):
408 * src/modest-ui-dimming-rules.c:
409 (modest_ui_dimming_rules_on_new_folder):
410 * src/widgets/modest-folder-view.c: (text_cell_data),
411 (icon_cell_data), (filter_row), (update_model),
412 (get_cmp_rows_type_pos):
415 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
416 Do not get the priv struct, because no priv struct has been set,
417 to avoid a runtime warning.
419 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
420 #ifelse with #else, to fix a warning, to fix the build.
423 2007-06-05 Christian Kellner <ckellner@openismus.com>
425 * libmodest-dbus-client/libmodest-dbus-client.c:
426 Fix small typo in doc (why do you always see them
427 AFTER committing stuff?)
430 2007-06-05 Christian Kellner <ckellner@openismus.com>
432 * libmodest-dbus-client/libmodest-dbus-client.c:
433 (libmodest_dbus_client_search):
434 Initialize hit list with NULL. Also set folder list
435 to "" if NULL was supplied.
438 2007-06-03 Christian Kellner <ckellner@openismus.com>
440 * libmodest-dbus-client/libmodest-dbus-client.c:
441 (modest_search_hit_list_free):
442 Make it save to call it with NULL.
444 * src/dbus_api/modest-dbus-callbacks.c:
445 * src/modest-search.c:
446 Return full ModestSearchHits as the search result list not TnyHeader
447 since can't be around withouth the correspoding TnyFolder.
449 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
451 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
452 Added currently commented code to check for secure auth
454 * src/maemo/modest-account-settings-dialog.c: (on_response),
455 (save_configuration), (show_ok):
456 Fixed projects.maemo.org bugs NB #59248 and #59251
458 * src/maemo/modest-maemo-utils.c:
459 (on_camel_account_get_supported_secure_authentication_status),
460 (on_camel_account_get_supported_secure_authentication),
461 (modest_maemo_utils_get_supported_secure_authentication_methods):
462 * src/maemo/modest-maemo-utils.h:
463 Moved get_supported_secure_authentication() method here to be able
464 to use it from easysetup wizard.
466 * src/modest-pair.c: (on_pair_compare_as_string):
467 Should compare string with first part of pair and not
468 strcmp pairs which will crash.
470 * src/modest-protocol-info.c:
471 (modest_protocol_info_protocol_is_store):
472 * src/modest-protocol-info.h:
473 Added modest_protocol_info_get_auth_protocol_name()
475 2007-06-03 Armin Burgmeier <armin@openismus.com>
477 * src/modest-mail-operation.c:
478 (modest_mail_operation_get_msgs_full): Set priv->account also when
479 only retrieving a single message. This avoids a crash when canceling
482 (modest_mail_operation_notify_end): Do not explicitely remove the
483 operation from the queue but only emit the progress_changed signal.
484 The queue itself listens to that signal to remove the operation when
485 it is finished. This reduces coupling and removes a potential deadlock
486 when modest_mail_operation_notify_end() is called from the queue
487 itself. If that is a problem performance-wise, I would suggest to
488 implement a status-changed signal or something.
490 * src/modest-mail-operation-queue.c: Make sure to never call a
491 function from another file while the queue is locked. This (hopefully)
492 fixes another deadlock when exiting the application while retrieving
495 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
497 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
498 Fixed build if libogs is not available
500 2007-06-03 Christian Kellner <ckellner@openismus.com>
502 * libmodest-dbus-client/libmodest-dbus-client.h:
503 * libmodest-dbus-client/libmodest-dbus-client.c:
504 (libmodest_dbus_client_delete_message):
505 Implement deletion of messages (Client side).
507 (modest_search_hit_free),
508 (modest_search_hit_list_free):
509 Utility functions to free the result hits.
511 * src/dbus_api/modest-dbus-api.h:
512 * src/dbus_api/modest-dbus-callbacks.c:
514 (modest_dbus_req_handler):
515 Implement deletion of messages (Server side).
517 * tests/dbus_api/test_search.c: (main):
520 * tests/dbus_api/Makefile.am:
521 * tests/dbus_api/test_delete_message:
522 Add little test for the message deletion logic
524 2007-06-03 Armin Burgmeier <armin@openismus.com>
526 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
527 when the operation queue was not empty. projects.maemo.org bug
530 2007-06-03 Armin Burgmeier <armin@openismus.com>
532 * src/widgets/modest-account-view.c
533 (on_account_default_toggled): Toggle default account column
534 explicitely instead of waiting for gconf notification (which is
535 currently ignored). This should fix projects.maemo.org bug NB#56910
536 for now. It should probably be removed when gconf notifications are
539 2007-06-03 Christian Kellner <ckellner@openismus.com>
541 * libmodest-dbus-client/libmodest-dbus-client.c:
542 Removed debugging spew.
544 * src/dbus_api/modest-dbus-callbacks.c:
545 Added debugging info.
547 * src/modest-search.c:
548 (modest_search_all_accounts):
549 Use tny_account_store_get_accounts () on the account store
550 to get all accounts which is the way to get all accounts.
552 * tests/dbus_api/test_search.c: (main):
553 Make it possible to supply the search term on the command line.
555 2007-06-03 Christian Kellner <ckellner@openismus.com>
557 * libmodest-dbus-client/libmodest-dbus-client.c:
558 * libmodest-dbus-client/libmodest-dbus-client.h:
559 Implement searching for mesages over raw dbus. (Client side)
561 * src/dbus_api/Makefile.am:
562 * src/dbus_api/modest-dbus-api.h:
563 * src/dbus_api/modest-dbus-callbacks.c:
564 * src/dbus_api/modest-dbus-callbacks.h:
565 Search framework (Server side). Also implement on_idle_open_message().
567 * src/maemo/modest-platform.c: (modest_platform_init):
568 Prepare for raw dbus/osso rpc interaction.
570 * src/modest-search.h:
571 Changed minsize from unspecific guint to guint32.
573 * src/modest-search.c:
575 Added strange hack which magically made tnymail work.
577 (modest_search_folder),
578 (modest_search_account),
579 (modest_search_all_accounts):
580 Implement helper functions to search all accounts, specific account
583 * tests/dbus_api/Makefile.am:
584 * tests/dbus_api/test_open_message.c:
585 Read url to open from commandline.
587 * tests/dbus_api/test_search.c:
588 Implement small test for dbus search stuff
590 2007-06-02 Armin Burgmeier <armin@openismus.com>
592 * src/maemo/modest-account-settings-dialog.c: Changed window title to
593 include account type and account title. This fixes projects.maemo.org
596 * src/maemo/modest-account-view-window.c: Set a title for the window.
598 2007-06-02 Armin Burgmeier <armin@openismus.com>
600 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
601 incoming and outgoing server name based on email address and server
602 types as long as the names have not been edited manually. This fixes
603 projects.maemo.org bug NB#58671.
605 2007-06-02 Armin Burgmeier <armin@openismus.com>
607 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
608 server type cannot be changed in future to the incoming details page
609 when creating an account. This fixes projects.maemo.org bug NB#59029.
611 2007-06-02 Armin Burgmeier <armin@openismus.com>
613 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
614 and assigned max width chars so that they wrap instead of being
615 truncated. Fixes projects.maemo.org bug NB#56126.
617 2007-06-02 Armin Burgmeier <armin@openismus.com>
619 * src/maemo/modest-connection-specific-smtp-window.c: Add an
620 introductory note to the connection specific smtp servers dialog, as
621 section 8.12 of the email UI specification requires. This fixes
622 projects.maemo.org bug NB#59212.
624 2007-06-01 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
627 Check for running mail operations, and offer to cancel them, as per the UI
628 spec. This fixes projects.maemo.org bug NB#59041 .
629 However, I suspect that tinymail may still use the network connection
630 in ways that we cannot detect or cancel. But it should at least adapt to
633 2007-06-01 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-tny-account-store.c: (recreate_all_accounts),
636 (get_cached_accounts), (get_server_accounts): Do more sensible
637 ref-counting of the temporarily-cached outbox accounts list. This seems
638 to fix a crash when entering the password when the password was wrong.
640 2007-06-01 Murray Cumming <murrayc@murrayc.com>
642 * src/gnome/modest-main-window.c: (connect_signals):
643 * src/modest-tny-account-store.c: (get_password),
644 (modest_tny_account_store_alert): Added comments and clues and
645 commented-out code about how we currently fail to deal with connection
646 errors and wrong passwords, and how we should.
648 2007-06-01 Murray Cumming <murrayc@murrayc.com>
650 * src/widgets/modest-retrieve-combo-box.c:
651 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
652 This fixes projects.maemo.org bug NB#58472 .
654 2007-06-01 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/easysetup/modest-easysetup-wizard.c:
657 (create_page_complete_easysetup):
658 (create_page_complete_custom): Correct the last commit,
659 putting the correct sentences in the correct pages.
661 2007-06-01 Murray Cumming <murrayc@murrayc.com>
663 * src/maemo/easysetup/modest-easysetup-wizard.c:
664 (create_page_complete_custom): Show the second sentence of text
665 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
668 2007-06-01 Murray Cumming <murrayc@murrayc.com>
670 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
671 Set the leave-on-server conf key by default. This fixes
672 projects.maemo.org bug NB#59258 .
674 2007-06-01 Murray Cumming <murrayc@murrayc.com>
676 * src/maemo/modest-account-view-window.c:
677 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
678 logical ID for the confirmation messages. Fixed projects.maemo.org bug
681 2007-06-01 Murray Cumming <murrayc@murrayc.com>
683 * src/maemo/easysetup/modest-easysetup-wizard.c:
684 (create_caption_new_with_asterisk):
685 * src/maemo/modest-account-settings-dialog.c:
686 (create_caption_new_with_asterisk):
687 Uncomment the code to add the asterisk, because they are no longer in the
688 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
689 (update_incoming_server_title): Add an asterisk here too.
691 2007-06-01 Murray Cumming <murrayc@murrayc.com>
693 * src/maemo/modest-maemo-global-settings-dialog.c:
694 (current_connection): Check that we are even connected before trying to
695 get the current connection name, to prevent a warning.
697 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
698 Change the comments because tny_maemo_conic_device_connect() is now meant to
700 * src/modest-mail-operation.c:
701 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
702 make sure we have a connection and fail if we can't connect.
704 2007-05-31 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/modest-main-window.c:
707 (on_account_store_connecting_finished): Do not try to get the
708 connection ID if we are not really connected. I am surprised that
709 this signal handler is called when we are not connected.
711 2007-05-31 Murray Cumming <murrayc@murrayc.com>
713 * src/modest-error.h:
714 * src/modest-ui-actions.c:
715 (modest_ui_actions_get_msgs_full_error_handler):
716 Renamed an enum, added comments, added an enum
717 for retrieve-limit errors.
719 * src/modest-mail-operation.c: (foreach_add_item),
720 (internal_folder_observer_update), (update_account_thread),
721 (modest_mail_operation_get_msgs_full):
722 (modest_mail_operation_update_account),
723 Added comments about how this works, and some code that should
724 (but does not) check the retrieve-limit. See the TODO comment.
726 2007-05-31 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
729 Initialize help_id to fix the build. Warnings are good.
731 2007-05-31 Murray Cumming <murrayc@murrayc.com>
733 * src/widgets/modest-hbox-cell-renderer.c:
734 (modest_hbox_cell_renderer_append):
735 * src/widgets/modest-vbox-cell-renderer.c:
736 (modest_vbox_cell_renderer_append):
737 Fix the last commit by doing an extra ref.
739 2007-05-31 Murray Cumming <murrayc@murrayc.com>
741 * src/widgets/modest-hbox-cell-renderer.c:
742 (modest_hbox_cell_renderer_append):
743 * src/widgets/modest-vbox-cell-renderer.c:
744 (modest_vbox_cell_renderer_append):
745 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
746 to fix the build with Maemo Bora.
747 However, there seems to be a remaining crash, probably due to reference
750 2007-05-30 Murray Cumming <murrayc@murrayc.com>
752 * src/modest-tny-account.c:
753 (modest_tny_account_new_for_local_folders):
754 Use hildon_file_system_info_async_new() to get a better name for
755 the memory card account, setting it as the account name.
756 The timing seems to work, but this is probably
757 not the best place to do this. See the TODO comment.
758 * src/maemo/modest-main-window.c: (create_details_widget):
759 * src/widgets/modest-folder-view.c: (text_cell_data):
760 Use the tny account name instead of hardcoding a name.
762 2007-05-30 Christian Kellner <ckellner@openismus.com>
764 * src/modest-search.c: (modest_search):
765 Correctly set part_search_func even if we have already parsed
766 the query and thus a valid OgsTextSearcher object.
768 2007-05-30 Christian Kellner <ckellner@openismus.com>
771 Search and check for libogs.
774 Incooparte the ogs build env.
776 * src/modest-mime-part-search-stream.c:
777 * src/modest-mime-part-search-stream.h:
778 Removed since we do the real searching now in modest-search.c.
780 * src/modest-search.c:
781 * src/modest-search.h:
782 Implement support for ogs. We use that if available and requested
783 and fall back to modest_text_utils_utf8_strcmp (). The search logic
784 should now handle the corner case when the search term is spread
785 across multiple reads.
786 Also the logic in modest_search () was corrected to search all
787 requested fields until one is found.
789 2007-05-30 Murray Cumming <murrayc@murrayc.com>
791 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
794 * src/modest-init.c: Made modest_init_local_folders() take a
795 path and be public so we can iniitialize maildir folders on
798 * src/modest-local-folder-info.h:
799 * src/modest-local-folder-info.c:
800 (modest_local_folder_info_get_maildir_path): Add a path parameter.
802 * src/modest-tny-account.c:
803 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
804 still means the standard local-folders path on the local volume.
806 * src/modest-tny-account-store.c:
807 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
808 signal so we can detect mount/unmount of the MMC1 card, and do an update of
809 all accounts when that happens.
810 (get_server_accounts): If the MMC1 card is mounted, create a store account for
811 this too, so it shows up in the treeview.
813 2007-05-28 Murray Cumming <murrayc@murrayc.com>
815 * src/maemo/modest-maemo-global-settings-dialog.c:
816 (current_connection):
817 * src/widgets/modest-global-settings-dialog.c:
818 (current_connection_default):
819 Use the enum values instead of 0, 1 and -1,
820 to make the code clearer.
822 * src/modest-account-mgr-helpers.c:
823 (modest_account_mgr_get_connection_specific_smtp): Make this code
826 * src/modest-runtime.h:
827 * src/modest-runtime.c:
828 Added modest_runtime_remove_all_send_queues().
829 * src/maemo/modest-main-window.c:
830 (on_account_store_connecting_finished): Recreate the send queues,
831 using the appropriate transport accounts for this new connection.
832 Some futher adapting might be needed if the old send queues are not
833 automatically stopped at this point.
835 * src/modest-tny-account-store.c: (get_server_accounts):
836 Create the connection-specific transport accounts, so that they can
837 be found later by their ID.
839 * src/modest-tny-account.h:
840 * src/modest-tny-account.c:
841 Added modest_tny_account_new_from_server_account_name().
842 modest_tny_account_new_from_server_account(): Do not create the
843 send queues here, because they will be
844 recreated anyway when the connection changes for the first time.
846 2007-05-28 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-local-folder-info.h:
849 * src/modest-local-folder-info.c:
850 (modest_per_account_local_outbox_folder_info_get_maildir_path),
851 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
852 tbox_folder): Take a modest account name instead of a server TnyAccount,
853 so we can have per-modest-account rather than per-transport-account
855 We must make sure that we change or recreate the exisitng send queues
856 when the connection changes for connection-specific transport accounts.
858 * src/modest-tny-account-store.c:
859 (create_per_account_local_outbox_folders): Create outboxed per modest
860 account, not per transport account.
862 * src/modest-tny-account.h:
863 * src/modest-tny-account.c:
864 (modest_tny_account_get_special_folder): For outboxes, get the
865 parent modest account name. The account is ignored for other folders.
866 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
867 modest account name rather than a server TnyAccount.
869 2007-05-25 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-tny-account.c:
872 (modest_tny_account_new_from_server_account):
873 Call modest_runtime_get_send_queue() immediately after creating transport
874 accounts, so that they start trying to send email from the outbox as soon
875 as possible at startup. This is probably what we want.
877 * src/modest-mail-operation.c: (update_account_thread):
878 * src/modest-runtime.c: (modest_runtime_get_send_queue):
879 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
880 * src/modest-tny-send-queue.h:
881 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
882 (modest_ui_actions_on_send):
883 Added comments about how sending works, though it needs some more work.
885 2007-05-25 Murray Cumming <murrayc@murrayc.com>
887 * src/modest-tny-account.c:
888 (modest_tny_account_get_special_folder): Add TODO because this fails when
890 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
891 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
892 Do not try to show this window when there is no active account. The UI
893 specs does not tell us what to do in this case.
895 2007-05-24 Murray Cumming <murrayc@murrayc.com>
899 * src/maemo/Makefile.am:
900 * src/widgets/Makefile.am: Some dist fixes.
902 2007-05-24 Murray Cumming <murrayc@murrayc.com>
904 * src/maemo/modest-connection-specific-smtp-window.c:
905 (on_button_edit): Make the code clearer, to prevent a double free.
907 2007-05-24 Murray Cumming <murrayc@murrayc.com>
909 * src/maemo/modest-account-settings-dialog.c:
910 (modest_account_settings_dialog_set_account_name),
911 Check the connection-specific smtp servers checkbox if there are any.
913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
914 (modest_connection_specific_smtp_edit_window_init):
915 Start with a suitable port number.
917 * src/modest-account-mgr-helpers.h:
918 * src/modest-account-mgr-helpers.c: Added
919 modest_account_mgr_get_has_connection_specific_smtp().
921 (modest_account_mgr_set_connection_specific_smtp),
922 (modest_account_mgr_remove_connection_specific_smtp),
923 (modest_account_mgr_get_has_connection_specific_smtp),
924 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
925 connection-specific smtp server accounts in the account, rather than
926 the server account conf dir.
928 This fixes bug projects.maemo.org bug NB#58263 .
930 * src/modest-tny-account-store.c:
931 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
932 if there are no server accounts yet, to prevent an infinite loop when there
933 are no accounts. Document that one must be called before the other.
935 2007-05-24 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-account-mgr-helpers.c:
938 (modest_account_mgr_get_default_account): Make sure that at least
939 one account is always the default, if there are any enabled accounts.
940 This is just a sanity check that shouldn't be necessary.
942 * src/modest-account-mgr-priv.c:
943 (_modest_account_mgr_account_from_key): Unescape the conf key to
944 get the real account name. For instance, this is an issue if a space
945 was in the account name, which can happen because the account name
946 is generated from the display name.
947 (_modest_account_mgr_get_account_keyname): Always escape the
949 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
950 Unescape the conf keys to get the real account names.
952 For instance, previously the is-default radio button in the accounts
953 list was not checked for any accounts at first. This fixes that,
954 and might fix several similar bugs.
956 2007-05-23 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
959 Removed some debug printfs.
961 2007-05-23 Murray Cumming <murrayc@murrayc.com>
963 Modest on-disk outbox directories are now here, for instance:
964 $HOME/.modest/outboxes/<account-id-1>/outbox
965 $HOME/.modest/outboxes/<account-id-2>/outbox
967 $HOME/.modest/local-folders/outbox
968 so we can have a separate outbox for each account.
969 But they are shown as one outbox in the GtkTreeView, by using a
970 TnyMergeFolder in a ModestTnySimpleFolderStore.
973 * src/modest-tny-simple-folder-store.c:
974 * src/modest-tny-simple-folder-store.h:
975 Added ModestTnySimpleFolderStore, used to contain folders from
976 other folder stores, such as other accounts.
978 * src/modest-tny-outbox-account.h:
979 * src/modest-tny-outbox-account.c:
980 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
981 used for the per-account local outbox folders.
983 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
984 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
985 only use this (internally) now for the non-outbox local folders.
988 * src/modest-init.c: Added modest_init_one_local_folder(), for
989 setting up the directory structure for each local folder.
991 * src/modest-local-folder-info.c:
992 (modest_per_account_local_outbox_folder_info_get_maildir_path),
993 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
995 * src/modest-local-folder-info.h:
996 * src/modest-tny-account-store.c: (on_account_removed),
997 (on_account_changed), (create_per_account_local_outbox_folders),
998 (get_server_accounts), (modest_tny_account_store_get_accounts),
999 (modest_tny_account_store_get_tny_account_by_account),
1000 (modest_tny_folder_store_is_virtual_local_folders):
1002 * src/modest-tny-account.h:
1003 * src/modest-tny-account.c:
1004 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1005 to create an on-disk per-account local outbox folder for each
1007 (create_per_account_local_outbox_folders): Create a local outbox folder
1008 for each transport account.
1009 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1010 for all local folders.
1012 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1013 instead of using g_object_get/set() directly. It is clearer.
1015 (modest_tny_folder_store_get_message_count),
1016 (modest_tny_folder_store_get_local_size
1017 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1018 because we now use these with non-acount folder stores.
1020 (modest_tny_account_get_special_folder),
1021 (modest_tny_account_new_from_server_account),
1022 (modest_tny_account_new_from_account):
1023 (recurse_folders): Adjust to the new outbox system.
1025 * src/modest-tny-folder.h:
1026 * src/modest-tny-folder.c:
1027 (modest_tny_folder_is_local_folder),
1028 (modest_tny_folder_get_local_folder_type),
1029 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1031 * src/widgets/modest-main-window.h:
1032 * src/maemo/modest-main-window.c: (create_details_widget),
1033 (modest_main_window_set_contents_style): Show details for any folder store,
1036 (modest_tny_folder_get_rules):
1037 Remove the const. C does not support constness enough for this.
1039 * src/modest-ui-actions.c:
1040 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1041 make all outboxes appear as one, in the usual local-folders tree node.
1043 (set_active_account_from_tny_account),
1044 (modest_ui_actions_on_folder_selection_changed):
1045 * src/widgets/modest-folder-view.c: (text_cell_data),
1046 (icon_cell_data), (filter_row),
1047 (add_account_folders_to_merged_folder),
1048 (add_account_folders_to_simple_folder_store), (),
1049 (get_cmp_rows_type_pos), (cmp_rows),
1050 (modest_folder_view_set_account_id_of_visible_server_account):
1051 Adjust to the new outbox system, using generic folder stores and folders
1052 in the GtkTreeModel.
1054 2007-05-23 Christian Kellner <ckellner@openismus.com>
1056 * src/modest-mail-operation.c:
1057 (modest_mail_operation_update_account):
1058 Use info->max_size instead of unintialized local var [small
1059 build fix]. (Added TODO to review that change since I don't
1062 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1064 * libmodest-dbus-client/libmodest-dbus-client.c:
1065 (libmodest_dbus_client_compose_mail): function added
1066 * src/dbus_api/modest-dbus-api.h:
1067 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1068 (on_compose_mail): Implementation of the SendAsMail functionality
1070 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1072 * src/modest-account-mgr.c:
1073 (modest_account_mgr_add_server_account): Set the secure-connection
1074 conf key for transport accounts as well as store accounts. I don't know
1075 why the if was there. For instance, this makes sure that we use SSL
1076 for the gmail preset from the easysetup wizard.
1078 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1080 * src/gnome/modest-main-window.c:
1081 (on_account_store_connecting_finished), (connect_signals):
1082 * src/maemo/modest-main-window.c:
1083 (on_account_store_connecting_finished), (connect_signals),
1084 (modest_main_window_new):
1085 Handle TnyAccountStore::connecting-finished instead of
1086 TnyDevice::connection-changed, because we cannot actually perform
1087 operations on accounts until TnyAccountStore has itself responded to
1088 the TnyDevice::connection-changed signal. This prevents a GError from
1090 Do not try to update at startup, because we (at least on scratchbox)
1091 already do an update at startup when the device goes online.
1092 This prevents a GError from tinymail.
1093 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1094 Added TODO about stopping simultaneous operations.
1096 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1098 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1099 * src/modest-mail-operation-queue.c:
1100 (modest_mail_operation_queue_remove):
1101 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1102 about where they happened.
1104 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-ui-actions.c:
1107 (modest_ui_actions_on_password_requested): Make sure that the remember
1108 output parameter is always TRUE.
1110 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1112 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1113 Show a OK/Cancel dialog if the error is a question, though we still do not
1114 know anything more about what we are asking the user.
1115 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1116 Fix an uninitialized variable (helper). This is a logic error, however.
1118 2007-05-21 Christian Kellner <ckellner@openismus.com>
1120 * src/modest-search.h:
1121 Correct bit shifting in the ModestSearchFlags enum.
1123 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1125 * src/modest-tny-account.c:
1126 (modest_tny_account_new_from_server_account): Do not use the lsub and
1127 check-all hard-coded IMAP options when using POP.
1129 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account.c:
1132 (modest_tny_account_new_from_server_account):
1133 Use NULL for the secure-auth method for POP when Password auth has been
1134 specified by the user, as we already do for IMAP. "auth=Login" causes
1135 an error from camel or the server.
1137 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1139 * src/maemo/modest-account-settings-dialog.c:
1140 (create_page_account_details),
1141 (modest_account_settings_dialog_set_account_name):
1142 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1143 for the leave-on-server checkbox, rathr than just the checkbox, when
1144 the protocol is not POP.
1146 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1148 * src/widgets/modest-account-view.c:
1149 * src/widgets/modest-account-view.h:
1150 Added modest_account_view_select_account() which will be useful later
1151 to asynchronously re-select the edited account.
1153 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1155 * src/maemo/modest-account-settings-dialog.c:
1156 (modest_account_settings_dialog_set_account_name):
1157 Automatically choose the port numbers based on the secure authentication
1158 methods, if they have not been chosen before.
1159 This fixes projects.maemo.org bug NB#56273 .
1161 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/modest-main-window-ui.h:
1164 * src/modest-ui-actions.c:
1165 * src/modest-ui-actions.h:
1166 Connect the Tools/SMTP Servers menu item to
1167 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1168 SMTP servers dialog, as in the UI specification and saves changes when it
1169 is closed. This fixed projects.maemo.org bug NB#56305 .
1171 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1173 * src/maemo/modest-connection-specific-smtp-window.c:
1174 (modest_connection_specific_smtp_window_init):
1175 Use gtk_window_set_default_size() to make this window big enough, so
1176 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1178 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1180 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1181 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1182 (modest_connection_specific_smtp_edit_window_init),
1183 Do not try to connect to a combobox signal before the combobox exists.
1184 This fixes the cras in projects.maemo.org bug NB#56288 .
1185 (modest_connection_specific_smtp_edit_window_get_settings):
1186 Remove the server_account_name parameter which was being checked for NULL
1187 though it was not used.
1189 * src/maemo/modest-connection-specific-smtp-window.c:
1190 (modest_connection_specific_smtp_window_fill_with_connections),
1191 (on_button_edit), (modest_connection_specific_smtp_window_init):
1192 Correct the number of treemodel columns to prevent a warning.
1193 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1194 libconic does not work.
1196 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1198 * src/modest-tny-account.c:
1199 (modest_tny_account_new_from_server_account):
1200 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1201 SMTP when "None" was chosen by the user. However, with my SMTP server that
1202 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1205 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1208 to explain the memory management issue with the ID in the ModestPair.
1210 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1211 (add_sending_page), (modest_account_assistant_finalize):
1212 * src/gnome/modest-gnome-global-settings-dialog.c:
1213 (create_updating_page), (create_composing_page):
1214 * src/gnome/modest-msg-edit-window.c: (get_transports),
1215 (init_window), (modest_msg_edit_window_finalize),
1216 (modest_msg_edit_window_get_msg_data):
1217 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1218 * src/gnome/modest-transport-widget.c:
1219 (modest_transport_widget_finalize), (smtp_configuration):
1220 * src/maemo/modest-maemo-global-settings-dialog.c:
1221 (create_updating_page), (create_composing_page):
1222 * src/maemo/modest-msg-edit-window.c: (get_transports),
1223 (init_window), (modest_msg_edit_window_finalize),
1224 (modest_msg_edit_window_get_msg_data),
1225 (modest_msg_edit_window_free_msg_data):
1226 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1227 (modest_store_widget_finalize):
1228 * src/maemo/modest-transport-widget.c:
1229 (modest_transport_widget_finalize), (smtp_configuration):
1230 * src/modest-main.c: (send_mail):
1231 * src/widgets/modest-combo-box.h:
1232 * src/widgets/modest-global-settings-dialog-priv.h:
1233 * src/widgets/modest-global-settings-dialog.c:
1234 (modest_global_settings_dialog_finalize):
1235 * src/widgets/modest-msg-edit-window.h:
1236 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1237 as long as the combo box, to prevent use of freed memory for the ID.
1239 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1242 get_accounts(), to make this clearer. Do not check for the enabled gconf
1243 key, because we do not use this for server accounts (at least, not yet).
1244 This allows us to send email again.
1246 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/modest-platform.c:
1249 (on_modest_conf_update_interval_changed), (modest_platform_init):
1250 Only respond to this particular key change. All these strcmp()s cannot be
1253 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/modest-maemo-global-settings-dialog.c:
1256 (current_connection): Prevent a crash in scratchbox when
1257 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1258 * src/maemo/modest-platform.c:
1259 (on_modest_conf_update_interval_changed), (modest_platform_init):
1260 Get the update interval from gconf and reset it when the gconf key changes.
1262 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-protocol-info.c:
1265 * src/modest-protocol-info.h: Adde enum-specific get functions,
1266 instead of using a ModestProtocolType enum parameter.
1268 * src/gnome/modest-account-assistant.c:
1269 * src/gnome/modest-store-widget.c:
1270 * src/gnome/modest-store-widget.h:
1271 * src/gnome/modest-transport-widget.c:
1272 * src/gnome/modest-transport-widget.h:
1273 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1274 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1275 * src/maemo/easysetup/modest-easysetup-wizard.c:
1276 * src/maemo/modest-account-settings-dialog.c:
1277 * src/maemo/modest-account-settings-dialog.h:
1278 * src/maemo/modest-store-widget.c:
1279 * src/maemo/modest-store-widget.h:
1280 * src/maemo/modest-transport-widget.c:
1281 * src/maemo/modest-transport-widget.h:
1282 * src/modest-account-mgr-helpers.c:
1283 * src/modest-account-mgr-helpers.h:
1284 * src/modest-account-mgr.c:
1285 * src/modest-account-mgr.h:
1286 * src/modest-tny-account.c:
1287 * src/modest-tny-folder.c:
1288 * src/widgets/modest-account-view.c:
1289 * src/widgets/modest-retrieve-combo-box.c:
1290 * src/widgets/modest-retrieve-combo-box.h:
1291 * src/widgets/modest-secureauth-combo-box.c:
1292 * src/widgets/modest-serversecurity-combo-box.c:
1293 * src/widgets/modest-serversecurity-combo-box.h:
1294 * tests/check_account-mgr.c:
1295 Use the specific functions, and use the re-renamed enum values for GNOME too.
1297 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-pair.h:
1300 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1301 so we can get the second based on the first.
1303 * src/maemo/modest-account-settings-dialog.h:
1304 * src/maemo/modest-account-settings-dialog.c:
1305 Added get_supported_secure_authentication_methods(), though it is mostly
1306 commented-out for now until the necessary API is committed to tinymail.
1307 (modest_account_settings_dialog_set_account_name),
1308 (save_configuration): Request the supported authentication methods from the
1309 server, so we can choose a working method.
1311 * src/modest-tny-account-store.h:
1312 * src/modest-tny-account-store.c:
1313 (modest_tny_account_store_get_session): Rename from
1314 tny_account_store_get_session().
1316 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-protocol-info.h: Split the ModestProtocol enum
1319 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1320 There was no need to have these unrelated values in one enum.
1322 * src/: many files: Adapted to changed enum. This makes the code a bit
1323 clearer, and the compiler could catch some errors.
1325 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1328 Show the detailed internal camel error message when an error happens
1329 during the configuration, so that our testers can give us more clues.
1330 For instance, in projects.maemo.org bug NB#56910 .
1332 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-tny-account.c:
1335 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1336 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1338 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1341 * src/maemo/modest-account-settings-dialog.c:
1342 (modest_account_settings_dialog_set_account_name),
1343 (save_configuration): For the incoming secure authentication checkbox,
1344 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1345 the UI specification. PLAIN does not seem to be supported for most IMAP
1346 servers anyway, and I am not sure what it would mean.
1347 However, we probably need to discover which of the secure-authentication
1348 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1349 * src/modest-account-mgr-helpers.c:
1350 (modest_account_mgr_get_server_account_data):
1352 * src/modest-tny-account.c:
1353 (modest_tny_account_new_from_server_account):
1354 Use tny_account_set_mech() to set secure-authentication methods,
1355 with some special-casing for IMAP, based on my observations of how
1358 * src/modest-account-mgr-helpers.h:
1359 * src/modest-account-mgr.c:
1360 * src/modest-defs.h: Comment that the URI is only used for local folders.
1362 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1364 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1365 parameter const, just to be neat.
1366 * src/modest-text-utils.c: (modest_text_utils_inline):
1367 End g_strconcat() with NULL, as its documentation says. This is almost
1368 certainly the cause of my crash at startup on the device. Interestingly,
1369 valgrind doesn't tell us about these errors.
1371 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1373 * scripts/build-packages: Added more precise comments about how to use
1374 this script, though I still get this error:
1375 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1376 error building tinymail
1378 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/modest-main-window.c: (on_account_update):
1381 Very slight cleanup, hoping to make it simpler to discover what causes
1382 a crash here sometimes.
1384 * src/modest-tny-account.c:
1385 (modest_tny_account_new_from_server_account): Set the port. Added
1386 comments about the options and a TODO comment because I need to find out
1387 how to specify the secure authentication method.
1389 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1391 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1392 changed CFlags paths form modest to libmodest
1394 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1396 * src/modest-account-mgr-helpers.c:
1397 (modest_account_mgr_get_server_account_data),
1398 (modest_account_mgr_free_server_account_data):
1399 * src/modest-account-mgr-helpers.h:
1400 * src/modest-account-mgr.c:
1401 (modest_account_mgr_add_server_account):
1402 * src/modest-defs.h:
1403 * src/modest-tny-account.c:
1404 (modest_tny_account_new_from_server_account):
1405 Determine the options for tny_camel_account_add_option() here,
1406 based on the settings, rather than storing them directly in gconf.
1408 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1411 Show a more friendly error dialog now that we expect (from the tinymail
1412 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1414 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1416 * src/maemo/modest-main-window.c: (on_account_update): Check that
1417 account_name is not NULL, to prevent a crash at startup that I am
1418 seeing on the N800. I do wonder why it is NULL.
1420 * src/maemo/easysetup/modest-easysetup-wizard.c:
1421 (create_page_user_details):
1422 * src/maemo/modest-account-settings-dialog.c:
1423 (create_page_user_details), (create_page_outgoing):
1424 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1425 (modest_connection_specific_smtp_edit_window_init):
1426 * src/modest-ui-actions.c:
1427 (modest_ui_actions_on_password_requested):
1428 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1429 might do something useful with the on-screen keyboard.
1431 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1433 * src/maemo/modest-main-window.c: (on_account_update):
1434 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1435 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1437 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-tny-account-store.c: (on_account_changed):
1440 Correct the signature of this signal handler.
1442 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1445 Show a HildonNote instead of a GtkDialog for Maemo.
1447 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1449 * src/widgets/modest-account-view.h:
1450 * src/widgets/modest-account-view.c: (on_account_changed),
1451 (on_account_removed). Added a boolean flag, set/unset by
1452 modest_account_view_block_conf_updates(),
1453 modest_account_view_unblock_conf_updates() to prevent unnecessary
1454 updates, but this is not very useful because the gconf notifications are
1455 so delays (maybe only on Maemo Bora).
1456 So auto-updating is turned off, and these functions do an explicit
1457 update when necessary.
1458 However, something else is still doing too much work when adding/removing
1459 accounts, probably in another part of the application.
1461 * src/maemo/modest-account-view-window.c:
1462 (on_delete_button_clicked), (on_edit_button_clicked),
1463 (on_new_button_clicked): Use the new functions.
1465 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-account-mgr-helpers.c:
1468 (modest_account_mgr_set_first_account_as_default):
1469 Sort the list of names alphabetically-by-title, so we choose the first one
1471 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1472 alphabetically by the title.
1474 This fixes projects.maemo.org bug NB#56418 .
1476 * src/modest-account-mgr-priv.c:
1477 (_modest_account_mgr_account_from_key):
1478 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1479 avoid a valgrind error, and possible random behaviour.
1481 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1483 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1484 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1485 tinymail documentation to say that this can be expected.
1486 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1487 pretty, and should not happen, but I would prefer to know when it does.
1489 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1491 * configure.ac: When using the older hildon version, probably on Bora,
1492 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1494 * src/widgets/modest-attachment-view.c:
1495 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1498 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1500 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1501 Implemented the prototype. Can be tested with
1502 tests/dbus_api/test_open_message:
1504 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-tny-account-store.c:
1507 (modest_tny_account_store_instance_init), (get_password):
1508 * src/modest-ui-actions.c:
1509 (modest_ui_actions_on_password_requested):
1510 Do not store the password in gconf, because this function is called
1511 for non-remembered passwords. Actually use the cached (in the hash map)
1512 password instead of releasing it.
1513 The password will now not be remembered if it is asked via the protected
1514 password dialog, as per the UI spec.
1516 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1518 * src/modest-defs.h:
1519 * src/modest-account-mgr-helpers.h:
1520 * src/modest-account-mgr-helpers.c:
1521 Added modest_server_account_get_username_has_succeeded(),
1522 modest_server_account_set_username_has_succeeded().
1523 (modest_server_account_set_username),
1524 Reset the has-succeeded flag if the username changes.
1526 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1527 * src/maemo/modest-connection-specific-smtp-window.c:
1528 (modest_connection_specific_smtp_window_save_server_accounts):
1529 Use modest_server_account_set_username() instead of using
1530 modest_conf_set_string() directly, so that the has-succeeded flag is always
1533 * src/modest-ui-actions.c:
1534 (modest_ui_actions_on_password_requested): Dim the username entry if
1535 the username has ever worked, as per the UI spec.
1537 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-tny-account-store.c: (get_password):
1540 * src/modest-ui-actions.c:
1541 (modest_ui_actions_on_password_requested):
1542 Allow the username to be changed too, though there is more work to
1543 be done on exactly how this behaves.
1545 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1547 * src/modest-account-mgr-helpers.h:
1548 * src/modest-account-mgr-helpers.c:
1549 Added modest_account_mgr_get_display_name(),
1550 modest_server_account_get_username(),
1551 modest_server_account_set_username(),
1552 modest_server_account_set_password(),
1553 modest_server_account_get_hostname() functions so we do not need to
1554 use the conf API directly.
1556 * src/maemo/modest-main-window.c: (connect_signals):
1557 Actually connect ot the ModestAccountStore::request-password signal,
1558 so that we show the dialog when the password is requested by Tinymail,
1559 for isntance if it is empty.
1561 * src/modest-marshal.list:
1562 * src/modest-tny-account-store.c:
1563 (modest_tny_account_store_class_init), (get_password),
1564 (modest_tny_account_store_alert):
1565 * src/modest-tny-account-store.h:
1566 * src/modest-ui-actions.h:
1567 * src/modest-ui-actions.c:
1568 (modest_ui_actions_on_password_requested):
1569 Change the signal parameters, so it is obvious that we are providing
1570 the non human-readable server name, and receiving both the username
1571 and password, though changing of the username is not yet implemented.
1572 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1573 for the GNOME version.
1575 This should fix the projects.maemo.org bug NB#56209, though it does not
1576 work on Bora, because the gconf_client_get() for the password fails
1577 immediately after we save it with gconf_client_set().
1579 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1582 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1583 caused an undefined symbol error:
1584 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1586 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-tny-account-store.c:
1589 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1590 using a GError instead of a string message, so we can translate it in
1593 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/modest-address-book.c:
1596 (modest_address_book_check_names):
1597 * src/maemo/modest-msg-view-window.c:
1598 (modest_msg_view_window_clipboard_owner_change):
1599 * src/modest-init.c: (modest_init_init_ui):
1600 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1601 (update_folders_cb), (modest_mail_operation_update_account):
1602 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1603 (modest_ui_actions_on_msg_attachment_clicked),
1604 (modest_ui_actions_on_msg_recpt_activated):
1605 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1606 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1607 (modest_msg_view_search_next):
1608 * src/widgets/modest-recpt-editor.c:
1609 (modest_recpt_editor_on_button_release_event),
1610 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1611 g_message(). At this point we should only be seeing interesting errors on
1612 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1614 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1616 (modest_wizard_dialog_force_title_update):
1617 * src/maemo/easysetup/modest-wizard-dialog.h:
1618 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1619 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1620 can update the title when appropriate. Otherwise the title is wrong if the
1621 pages are added after adding the notebook to the dialog.
1622 This must be a problem in HildonWizardDialog too.
1623 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1625 * src/maemo/easysetup/modest-easysetup-wizard.c:
1626 (create_subsequent_customsetup_pages),
1627 (create_subsequent_easysetup_pages):
1628 Call modest_wizard_dialog_force_title_update() so that the title is
1629 correct even with GTK+ < 2.10.
1630 This fixes projects.maemo.org bug NB#56145 .
1632 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/modest-platform.c:
1635 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1636 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1639 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1641 * src/widgets/modest-window.h:
1642 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1643 and modest_window_save_state(), which invokes it.
1645 * src/widgets/modest-window-mgr.h:
1646 * src/widgets/modest-window-mgr.c:
1647 Added modest_window_mgr_save_state_for_all_windows(), which calls
1648 the save_state vfunc on all registered windows, if implemented.
1650 * src/gnome/modest-msg-edit-window.c:
1651 * src/gnome/modest-msg-view-window.c:
1652 * src/maemo/modest-msg-edit-window.c:
1653 * src/maemo/modest-msg-view-window.c:
1654 * src/maemo/modest-main-window.c:
1655 Specify the existing save_settings functions as implementations of
1656 ModestWindow::save_state_func().
1658 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1659 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1660 enabling hibernation, for instance.
1662 We may need to do the same thing for restoring settings.
1665 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1667 * src/widgets/modest-window-mgr.c:
1668 * src/widgets/modest-window-mgr.h:
1669 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1670 modest_window_mgr_get_hibernation_is_prevented().
1672 * src/maemo/modest-main-window.c:
1673 (on_hildon_program_is_topmost_notify): Prevent hibernation
1674 (possible when the application goes to the background in the WM),
1675 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1677 * src/maemo/easysetup/modest-easysetup-wizard.c:
1678 (modest_easysetup_wizard_dialog_init):
1679 * src/maemo/modest-account-settings-dialog.c:
1680 (modest_account_settings_dialog_init):
1681 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1682 (modest_connection_specific_smtp_edit_window_init):
1683 * src/maemo/modest-connection-specific-smtp-window.c:
1684 (modest_connection_specific_smtp_window_init):
1685 * src/maemo/modest-signature-editor-dialog.c:
1686 (modest_signature_editor_dialog_init):
1687 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1688 prevent hibernation while any of these account settings dialogs are open.
1690 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1692 * src/maemo/Makefile.am:
1693 * src/maemo/modest-osso-state-saving.c:
1694 * src/maemo/modest-osso-state-saving.h: Added
1695 modest_osso_load_state() and modest_osso_save_state() though they do
1696 nothing now. They should iterate through all the open windows and load/save
1698 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1699 save state when closing.
1701 * src/maemo/modest-main-window.c:
1702 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1703 Add a notification handler for the HildonProgram::is-topmost property,
1704 so we can allow hibernation when the application goes into the background.
1705 But we still need to detect when the accounts setup windows are open so
1706 we can stop hibernation when they are open.
1707 To do this, I also added the main window the HildonProgram. This might have
1708 other side-effects/benefits, and should maybe be done for other windows.
1710 * src/maemo/modest-osso-autosave-callbacks.h:
1711 * src/maemo/modest-osso-autosave-callbacks.c:
1712 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1713 though it does not do anything yet, and we might never need this to do
1714 anything. For instance, we already save drafts.
1716 * src/maemo/modest-platform.c: (modest_platform_init):
1717 Specify the libosso auto-save callback.
1719 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1721 * src/maemo/modest-platform.c:
1722 (modest_platform_set_update_interval):
1723 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1724 aparently stays valid between application instances, so we can use this
1725 to remove and reset it later. According to a maemo-developers email from
1728 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1730 * configure.ac: Depend on libalarm for Maemo.
1732 * src/dbus_api/modest-dbus-api.h:
1733 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1734 (on_send_receive), (modest_dbus_req_handler):
1735 Handle a SEND_RECEIVE D-Bus method.
1737 * libmodest-dbus-client/libmodest-dbus-client.c:
1738 (libmodest_dbus_client_send_and_receive):
1739 * libmodest-dbus-client/libmodest-dbus-client.h:
1740 Add C convenience functions for calling the new D-Bus method.
1742 * src/modest-platform.h:
1743 * src/gnome/modest-platform.c:
1744 * src/maemo/modest-platform.c:
1745 Added modest_platform_set_update_interval(), which uses the
1746 alarmd API on Maemo.
1747 (modest_platform_init),
1748 Call modest_platform_set_update_interval(), using a hard-coded
1749 interval for now (until the global settings dialog is implemented),
1750 though I am not sure that this makes sense yet.
1752 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1754 * src/dbus_api/modest-dbus-callbacks.c:
1755 (modest_osso_cb_hw_state_handler):
1756 * src/dbus_api/modest-dbus-callbacks.h:
1757 * src/maemo/modest-platform.c: (modest_platform_init):
1758 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1759 in case this has some effect on the ability for Maemo to ping the
1762 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1764 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1765 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1766 warning. It is probably a logic error, but I need to fix the build.
1768 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-account-mgr.h:
1771 * src/modest-account-mgr.c:
1772 (modest_account_mgr_account_names): Add a gboolean enabled_only
1773 parameter, so we can get lists of onlt the enabled accounts.
1775 (modest_account_mgr_add_account),,
1776 (modest_account_mgr_account_with_display_name_exists):
1777 * src/maemo/modest-msg-edit-window.c: (get_transports):
1778 * src/modest-account-mgr-helpers.c:
1779 (modest_account_mgr_set_first_account_as_default):
1780 * src/modest-init.c: (init_default_account_maybe):
1781 * src/modest-tny-account-store.c: (get_accounts):
1782 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1783 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1784 * tests/check_account-mgr.c: (START_TEST):
1785 Provide the extra parameter, as appropriate.
1787 * src/widgets/modest-account-view.c: (update_account_view):
1788 Do not show disabled accounts (meaning that there is no way to
1789 enable/disable accounts in the UI (the feature is not in our UI
1790 specification), so we can use this internally only to mark unfinished
1791 or temporary account data.
1793 * src/maemo/easysetup/modest-easysetup-wizard.c:
1794 (create_account): Add boolean enable parameter, so we can specify FALSE
1795 to create the temporary account.
1796 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1797 (on_before_next): When finishing, when there is a temporary account, just
1799 Also, use a timeout to delay the showing of the dialog until gconf is likely
1800 to return correct information, due to a maemo gconf bug that is fixed in
1801 osso 1.1, but not yet in Bora.
1802 However, the dialog stays on screen after it is destroyed.
1804 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1805 for invalid data when cancelling. Use a hildon note instead of a dialog
1806 to complain about invalid data. Do not show the account-saved note if the
1807 account is disabled (a temporary account that will not really be saved for use
1810 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1812 * src/modest-account-mgr-helpers.h:
1813 * src/modest-account-mgr-helpers.c:
1814 Added modest_account_mgr_unset_default_account(),
1815 Added modest_account_mgr_set_first_account_as_default().
1817 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1818 If it was the default account, unset the default account name.
1820 * src/maemo/modest-account-view-window.c:
1821 (on_delete_button_clicked): If it was the default account,
1822 set the first remaining account as the default instead.
1824 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1825 a NULL account or a NULL default account, to prevent a crash. This should
1826 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1829 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1831 * src/widgets/modest-recpt-editor.c:
1832 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1833 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1834 TODO comment for this. This fixes the build.
1836 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1837 be the best place for it. This will in future update all auto-update accounts,
1838 rather than just the current/default account, when that gconf key exists.
1839 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1840 if there are no accounts, before calling do_send_receive().
1841 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1843 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1844 * src/maemo/modest-main-window-ui.h:
1845 * src/maemo/modest-main-window.c: (on_connection_changed),
1846 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1847 directly, becaue the signal handler does more.
1849 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1851 * src/modest-account-mgr-helpers.c:
1852 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1853 for the case that the account does not exist.
1855 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1856 (equivalent to the modest account name) rather than the tinymail account name
1857 (equivalent to the modest account title - human readable) to get the account data.
1858 Check for null account data to prevent the crash, and add a TODO comment saying that
1859 this needs fixing because it is using the server account name instead of the account name.
1861 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1864 * src/maemo/modest-account-settings-dialog.c: (show_error),
1866 Use hildon_note_new_information() for informative and error messages,
1867 which seems to be expected for Maemo applications (no documentation that I know of
1868 says this). I am surprised that there is no distinction between info and error
1871 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1873 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1874 it is easy to find where this is used.
1876 * src/maemo/easysetup/modest-easysetup-wizard.c:
1877 (create_page_welcome), (create_page_account_details),
1878 (create_page_user_details), (create_page_complete_easysetup),
1879 (create_page_custom_incoming), (create_page_custom_outgoing),
1880 (create_page_complete_custom):
1881 * src/maemo/modest-account-settings-dialog.c:
1882 (create_page_account_details), (create_page_user_details),
1883 (create_page_incoming), (create_page_outgoing):
1884 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1885 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1886 (modest_connection_specific_smtp_edit_window_init):
1887 * src/maemo/modest-connection-specific-smtp-window.c:
1888 (modest_connection_specific_smtp_window_init):
1889 * src/maemo/modest-signature-editor-dialog.c:
1890 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1891 and scrolling policy as per the Email Application Layout Guide, if I have
1894 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1897 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1898 which were empty, because these vfuncs have been removed from TnyAccountStore.
1899 This fixes the build.
1901 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/modest-main-window.c:
1904 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1905 showing/hiding it. Added TODO because it probably should not be NULL.
1906 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1907 because unnecessary g_warnings() make degugging difficult.
1909 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/modest-msg-edit-window.c:
1912 (modest_msg_edit_window_select_color),
1913 (modest_msg_edit_window_select_background_color): 2 const corrections and
1914 moving 2 #endifs before closing brackets, to fix the build.
1916 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1918 * src/maemo/easysetup/modest-easysetup-wizard.h:
1919 * src/maemo/easysetup/modest-easysetup-wizard.c:
1920 (modest_easysetup_wizard_dialog_finalize),
1921 (on_button_edit_advanced_settings), (create_page_complete_custom),
1922 (on_response), (create_account):
1923 Implement the Advanced Settings edit button, by saving the account information,
1924 for the Advanded Settings dialog to use directly from gconf, and removing it
1925 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1926 Bug #5533 in the projects.maemo.org bugzilla.
1928 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1930 * src/maemo/modest-msg-view-window.c:
1931 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1932 when opening a message window.
1934 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1936 * src/maemo/easysetup/modest-easysetup-wizard.c:
1937 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1940 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1941 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1942 gconf settings. I probably added more checks than necessary, but that is safer.
1944 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1945 variable to fix the build, but this seems to be used when it is still NULL.
1947 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1949 * src/modest-platform.h:
1950 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1951 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1952 * src/modest-main.c: Implement this function so we can avoid using
1953 maemo-specific API from cross-platform code.
1955 * src/modest-tny-account-store.c:
1956 (get_smtp_specific_transport_account_for_open_connection):
1957 * src/modest-ui-actions.c: (check_for_connection),
1958 (modest_ui_actions_on_item_not_found):
1959 Use modest_platform_connect_and_wait() and put #idefs around other
1960 maemo-specific code, because only maemo currently has a way to
1961 identify connection names.
1963 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1965 * src/modest-tny-account-store.h:
1966 * src/modest-tny-account-store.c:
1967 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1968 the connection-specific SMTP server settings in the configuration.
1970 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1972 * src/maemo/modest-main-window.c: (on_connection_changed),
1974 * src/modest-main.c: (main), (start_ui), (send_mail):
1975 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1976 that is what is intended.
1978 * src/modest-ui-actions.c: (action_send), (action_receive),
1979 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1980 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1981 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1982 SMTP server is used when it is specified.
1984 (modest_ui_actions_on_send_receive):
1985 Check that a connection is open before proceeding.
1986 Receive and then send, instead of vice-versa, as per the specification.
1988 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1990 * src/modest-mail-operation.c:
1991 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1992 though I guess it should be something other than NULL.
1994 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/easysetup/modest-easysetup-wizard.c:
1997 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1998 combo twice, to avoid an g_warning and to make it visible again.
1999 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2000 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2001 (already intended) dereference when detaching, because we then recreate the menu.
2002 But I am not sure why the warning was happening, and it is possible that this is a memory
2005 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2007 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2008 and uri_parse_mailto() utility functions.
2009 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2011 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2013 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2015 * src/dbus_api/modest-dbus-api.h:
2016 * src/dbus_api/modest-dbus-callbacks.c:
2017 Use an idle callback to execute the modest code in the application's own thread.
2018 Remove the helloworld example method.
2019 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2020 parsed, and the open-message method is not implemented because this is not yet implemented in
2022 * libmodest-dbus-client/libmodest-dbus-client.c:
2023 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2024 (libmodest_dbus_client_open_message):
2025 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2027 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2028 body without crashing.
2030 * tests/dbus_api/Makefile.am:
2031 * tests/dbus_api/test_mail_to.c:
2032 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2034 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2036 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2037 Added file to fix the build. Sorry.
2039 * src/dbus_api/Makefile.am:
2040 * src/dbus_api/modest-dbus-api.h:
2041 * src/dbus_api/modest-dbus-callbacks.h:
2042 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2043 (modest_dbus_req_handler):
2044 Put constants in a separate header so it can be reused by the
2045 client library, without duplication
2047 * libmodest-dbus-client/Makefile.am:
2048 * libmodest-dbus-client/libmodest-dbus-client.c:
2049 (libmodest_dbus_client_call_helloworld),
2050 (libmodfest_dbus_client_send_mail),
2051 (libmodfest_dbus_client_mailto),
2052 (libmodfest_dbus_client_open_message):
2053 * libmodest-dbus-client/libmodest-dbus-client.h:
2054 (Partly) Implement a send_mail D-Bus method.
2056 * tests/dbus_api/Makefile.am:
2057 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2058 the send_email D-Bus method.
2060 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2064 * libmodest-dbus-client/Makefile.am:
2065 * libmodest-dbus-client/libmodest-dbus-client.c:
2066 * libmodest-dbus-client/libmodest-dbus-client.h:
2067 * tests/dbus_api/Makefile.am:
2068 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2069 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2071 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2073 * src/maemo/easysetup/modest-easysetup-wizard.c:
2074 (create_page_account_details):
2075 * src/maemo/modest-account-settings-dialog.c:
2076 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2077 widgets, because this might not be the default in future versions of the Maemo GTK+.
2078 However, I can not not get capitalization to work even in a simple test case.
2080 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2082 * src/maemo/easysetup/modest-easysetup-wizard.c:
2083 (create_page_custom_incoming), (create_page_custom_outgoing):
2084 * src/maemo/modest-account-settings-dialog.c:
2085 (create_page_account_details), (create_page_incoming),
2086 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2087 instead of using gtk_check_button_with_label(), so they are aligned like the other
2088 widgets, as per the UI spec.
2090 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2092 * src/maemo/easysetup/modest-easysetup-wizard.c:
2093 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2094 * src/widgets/modest-validating-entry.c:
2095 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2096 Modest prefix instead of an EasySetup prefix.
2098 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2100 * src/widgets/modest-validating-entry.h:
2101 * src/widgets/modest-validating-entry.c: (on_insert_text),
2102 Added easysetup_validating_entry_set_max_func(), used to set a callback
2103 to call when the max number of characters is reached. GtkEntry has a max-length
2104 already but is silent about it.
2106 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2107 (create_page_account_details), (create_page_user_details),
2109 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2110 (create_page_account_details), (create_page_user_details),
2111 (create_page_outgoing):
2112 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2113 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2114 the UI spec, when the user tries to enter more than the max number of characters.
2116 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2118 * src/maemo/easysetup/modest-easysetup-wizard.c:
2119 (create_page_user_details), (create_page_custom_incoming),
2120 (create_page_custom_outgoing):
2121 * src/maemo/modest-account-settings-dialog.c:
2122 (create_page_user_details), (create_page_incoming),
2123 (create_page_outgoing):
2124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2125 (modest_connection_specific_smtp_edit_window_init):
2126 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2127 not appropriate. Bad Maemo-specific defaults!.
2129 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2132 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2133 (modest_signature_editor_dialog_set_settings):
2134 Disable the label and textview when the checkbox is disabled, and use the
2135 specified (UI spec) default signature text.
2137 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2140 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2142 * src/modest-defs.h:
2143 * src/modest-account-mgr-helpers.h:
2144 * src/modest-account-mgr-helpers.c:
2145 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2147 * src/maemo/Makefile.am:
2148 * src/maemo/modest-signature-editor-dialog.c:
2149 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2152 * src/maemo/modest-account-settings-dialog.h:
2153 * src/maemo/modest-account-settings-dialog.c:
2154 (modest_account_settings_dialog_finalize), (on_button_signature),
2155 (save_configuration): Use the new dialog when the Edit button is pressed, and
2156 save the changes if necessary, as per the UI spec.
2158 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2160 * src/maemo/Makefile.am:
2161 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2162 based on maemo-develoers email from Dirk.
2164 * src/maemo/easysetup/modest-easysetup-wizard.c:
2165 (create_page_welcome), (create_page_account_details),
2166 (create_page_user_details), (create_page_complete_easysetup),
2167 (create_page_custom_incoming), (create_page_custom_outgoing),
2168 (create_page_complete_custom),
2169 (modest_easysetup_wizard_dialog_init):
2170 * src/maemo/modest-account-settings-dialog.c:
2171 (create_page_account_details), (create_page_user_details),
2172 (create_page_incoming), (create_page_outgoing),
2173 (modest_account_settings_dialog_init):
2174 * src/maemo/modest-connection-specific-smtp-window.c:
2175 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2177 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/easysetup/modest-easysetup-wizard.c:
2180 (create_page_account_details), (create_page_custom_outgoing),
2181 (create_page_complete_custom):
2182 * src/maemo/modest-account-settings-dialog.c:
2183 (create_page_user_details), (create_page_incoming),
2184 (create_page_outgoing):
2185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2186 (modest_connection_specific_smtp_edit_window_init):
2187 Use the correct (UI spec) port min/max, and use horizontal separators,
2190 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/easysetup/modest-easysetup-wizard.c:
2193 (set_default_custom_servernames):
2194 * src/maemo/modest-account-settings-dialog.c:
2195 (create_page_incoming), (on_combo_outgoing_security_changed),
2196 (on_combo_incoming_security_changed), (create_page_outgoing),
2197 (modest_account_settings_dialog_set_account_name),
2198 (save_configuration):
2199 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2200 (on_combo_security_changed),
2201 (modest_connection_specific_smtp_edit_window_init),
2202 (modest_connection_specific_smtp_edit_window_set_connection),
2203 (modest_connection_specific_smtp_edit_window_get_settings):
2204 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2207 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/easysetup/modest-easysetup-wizard.c:
2211 (create_page_custom_outgoing), (create_page_complete_custom):
2212 * src/maemo/modest-account-settings-dialog.c:
2213 (create_page_user_details), (create_page_outgoing):
2214 * src/maemo/modest-account-view-window.c: (button_box_new):
2215 Use changed logical IDs as per the most recent UI spec:
2216 mcen_bd_emailsetup_edit -> mcen_bd_edit
2217 mcen_bd_emailsetup_delete -> mcen_bd_delete
2218 mcen_bd_emailsetup_close -> mcen_bd_close
2220 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2224 * src/dbus_api/Makefile.am:
2225 * src/dbus_api/modest-dbus-callbacks.c:
2226 * src/dbus_api/modest-dbus-callbacks.h:
2227 * src/maemo/modest-platform.c: (modest_platform_init):
2228 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2230 * tests/Makefile.am:
2231 * tests/dbus_api/Makefile.am:
2232 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2234 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2236 * src/maemo/modest-account-settings-dialog.c:
2237 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2238 Removed unnecessary includes.
2240 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2242 * src/maemo/easysetup/modest-easysetup-wizard.c:
2243 * src/maemo/modest-account-settings-dialog.c:
2244 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2245 * src/widgets/Makefile.am:
2246 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2247 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2248 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2249 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2250 * src/widgets/modest-secureauth-combo-box.c:
2251 * src/widgets/modest-secureauth-combo-box.h:
2252 * src/widgets/modest-serversecurity-combo-box.c:
2253 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2254 made the GObject names more consistent with the rest of the Modest code.
2256 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2258 * src/maemo/easysetup/Makefile.am:
2259 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2260 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2261 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2262 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2263 * src/maemo/easysetup/modest-easysetup-wizard.c:
2264 * src/maemo/easysetup/modest-validating-entry.c:
2265 * src/maemo/easysetup/modest-validating-entry.h:
2266 * src/maemo/modest-account-settings-dialog.c:
2267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2268 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2269 widgets/ because they are used outside of easysetup too. After checking in,
2270 svn will allow me to rename them too.
2272 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2274 * src/gnome/modest-msg-edit-window.c:
2275 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2276 linker error, to fix the build on the GNOME platform.
2277 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2278 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2279 ifdefed out to avoid a warning.
2281 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2283 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2284 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2285 some alternative for GTK+ 2.6.
2287 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2289 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2291 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2292 specified for EmailAccountsDialog in UI spec.
2294 * src/maemo/easysetup/modest-easysetup-wizard.c:
2295 * src/maemo/easysetup/modest-easysetup-wizard.h:
2296 * src/maemo/modest-account-settings-dialog.c:
2297 * src/maemo/modest-account-settings-dialog.h:
2298 Reuse a member window widget for the connection-specific SMTP server accounts,
2299 so we can tell it to create/save the accounts only if we actually save changes.
2301 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2302 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2303 (modest_connection_specific_smtp_edit_window_get_settings):
2304 Return a struct instance for temporarily remembering the entered data.
2306 * src/maemo/modest-connection-specific-smtp-window.h:
2307 * src/maemo/modest-connection-specific-smtp-window.c:
2308 (modest_connection_specific_smtp_window_finalize),
2309 (modest_connection_specific_smtp_window_fill_with_connections),
2311 (modest_connection_specific_smtp_window_save_server_accounts),
2312 (update_model_server_names): Do not actually save data until asked,
2313 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2315 (on_selection_changed),
2316 (modest_connection_specific_smtp_window_init): Disable the edit
2317 button when nothing is selected.
2319 * src/modest-account-mgr-helpers.c:
2320 * src/modest-account-mgr-helpers.h:
2321 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2324 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2326 * src/modest-account-mgr-helpers.h:
2327 * src/modest-account-mgr-helpers.c:
2328 (modest_account_mgr_get_unused_account_name),
2329 (modest_account_mgr_get_unused_account_display_name): Added these
2330 utility functions, to avoid code duplication.
2332 * src/maemo/easysetup/modest-easysetup-wizard.c:
2333 (create_page_account_details), (create_account):
2334 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2335 (on_combo_security_changed),
2336 (modest_connection_specific_smtp_edit_window_init),
2337 (modest_connection_specific_smtp_edit_window_save_settings):
2338 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2339 * src/maemo/modest-connection-specific-smtp-window.c:
2340 (modest_connection_specific_smtp_window_finalize),
2341 (modest_connection_specific_smtp_window_fill_with_connections),
2342 (on_button_edit), (modest_connection_specific_smtp_window_init):
2343 * src/maemo/modest-connection-specific-smtp-window.h:
2344 Implementing saving of connection-specific server accounts.
2346 But I need to refactor this so we can save the data for each
2347 possible connection-specific account and only actually create the server accounts
2348 when the easysetup finished, or the OK button is pressed on the account settings
2351 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2354 (on_combo_security_changed):
2355 (modest_connection_specific_smtp_edit_window_init):
2356 Auto-fill the port number as in the account settings.
2358 (modest_connection_specific_smtp_edit_window_set_connection):
2359 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2360 * src/maemo/modest-connection-specific-smtp-window.c:
2361 (fill_with_connections), (on_button_edit),
2362 (modest_connection_specific_smtp_window_init):
2363 Turn the edit window into a dialog to simplify the code, and
2364 set a WM hint as in a GtkDialog, because only a popup can be on top of
2365 another window in Maemo, and popups usually have no WM decoration.
2367 * src/modest-defs.h:
2368 * src/modest-account-mgr-helpers.c:
2369 (modest_account_mgr_set_connection_specific_smtp),
2370 (modest_account_mgr_remove_connection_specific_smtp),
2371 (modest_account_mgr_get_connection_specific_smtp):
2372 * src/modest-account-mgr-helpers.h: Some functions to write the
2373 connection-specific SMTP server information. Not yet used.
2376 * src/widgets/modest-folder-view.c: (text_cell_data):
2377 Fix a warning about an uninitialized variable.
2378 (on_configuration_key_changed): Put an #ifdef around the use
2379 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2381 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/modest-account-settings-dialog.h:
2384 * src/maemo/modest-account-settings-dialog.c:
2385 Added connect_for_modified() utility function to mark the new modified boolean.
2387 (create_page_account_details), (create_page_user_details),
2388 (create_page_incoming), (create_page_outgoing), (on_response),
2389 (modest_account_settings_dialog_init),
2390 (modest_account_settings_dialog_set_account_name):
2391 Only warn about unsaved changes when there are actually unsaved changes.
2393 * src/modest-account-mgr-helpers.c:
2394 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2395 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2396 to get the data from there in future.
2398 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2400 * src/modest-defs.h:
2402 * src/modest-account-mgr-helpers.h:
2403 * src/modest-account-mgr-helpers.c:
2404 Store the security account setting in a single conf key instead of using
2405 the options list, so that the list is left for just the to-be-removed camel hack,
2406 and because gconf_client_set_list() is failing for some reason.
2408 * src/modest-account-mgr.c:
2409 (modest_account_mgr_add_server_account):
2410 * src/maemo/modest-account-settings-dialog.c:
2411 (modest_account_settings_dialog_set_account_name),
2412 (save_configuration): Use the renamed functions.
2415 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2417 * src/widgets/Makefile.am:
2418 * src/widgets/modest-limit-retrieve-combo-box.c:
2419 * src/widgets/modest-limit-retrieve-combo-box.h:
2420 * src/widgets/modest-retrieve-combo-box.c:
2421 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2422 the account settings dialog.
2424 * src/modest-defs.h:
2425 * src/modest-account-mgr-helpers.h:
2426 * src/modest-account-mgr-helpers.c:
2427 (modest_server_account_get_option_secure_auth),
2428 (modest_server_account_set_option_secure_auth):
2429 * src/modest-account-mgr.c:
2430 (modest_account_mgr_add_server_account):
2431 Use the existing AUTH_MECH conf key for the secure-auth setting,
2432 instead of putting it in the list options, because this was actually used already.
2434 * src/maemo/modest-account-settings-dialog.c:
2435 (create_page_account_details),
2436 (modest_account_settings_dialog_set_account_name),
2437 (save_configuration):
2438 * src/maemo/modest-account-settings-dialog.h:
2439 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2440 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2442 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2444 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2445 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2446 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2448 * src/modest-defs.h:
2449 * src/maemo/modest-account-settings-dialog.c:
2450 (create_page_incoming), (on_combo_outgoing_security_changed),
2451 (on_combo_incoming_security_changed), (create_page_outgoing),
2452 (modest_account_settings_dialog_set_account_name),
2453 (save_configuration): Load/Save the port number, and change it when the
2454 security combo changes, to suitable defaults.
2456 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2458 * src/modest-account-mgr.c:
2459 (modest_account_mgr_add_server_account): Set the security and secure-auth
2460 options, and add a comment saying that the other camel-specific options should be
2463 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2467 * src/modest-tny-account-store.c: (account_list_free),
2468 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2469 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2472 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2474 * src/modest-protocol-info.c:
2475 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2476 is required by our UI spec. Maybe something in our implementation will use this eventually.
2477 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2478 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2479 instead of the previous 0 placeholder.
2481 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2482 secure-auth settings.
2483 * src/modest-account-mgr-helpers.h:
2484 * src/modest-account-mgr-helpers.c:
2485 (modest_server_account_data_get_option_secure_auth),
2486 (modest_server_account_set_option_secure_auth),
2487 (modest_server_account_data_get_option_security),
2488 (modest_server_account_set_option_security): Added this API for getting and setting the security
2489 and secure-auth settings.
2491 * src/maemo/modest-account-settings-dialog.h:
2492 * src/maemo/modest-account-settings-dialog.c:
2493 (modest_account_settings_dialog_finalize), (check_data),
2494 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2495 about changing titles.
2496 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2497 (save_configuration): Save the security and secure-auth settings.
2499 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2500 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2502 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2504 * src/modest-defs.h:
2505 * src/modest-account-mgr.c:
2506 (modest_account_mgr_add_server_account):
2507 Added and used defines for the options key and value pair strings,
2508 that are used so far, though they do not seem to correspond to anything in our
2509 UI specs or ModestProtocol enum.
2511 * src/modest-account-mgr-helpers.h:
2512 * src/modest-account-mgr-helpers.c:
2513 (compare_option_strings_for_name),
2514 (modest_server_account_data_get_option_value),
2515 (modest_server_account_data_get_option_bool),
2516 (modest_account_mgr_get_server_account_option):
2517 Added helper functions for parsing the options GSList.
2519 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2521 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2522 display name is based on the supplied account name.
2523 * src/modest-account-mgr.c:
2524 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2525 with an inefficient, but good-enough, implementation.
2527 * src/maemo/easysetup/modest-easysetup-wizard.c:
2528 (create_page_account_details), (on_before_next), (create_account):
2529 Check for existing display names rather than (non-user-visible) account names, and just
2530 create and set a unique account name at the end.
2532 * src/maemo/modest-account-settings-dialog.c:
2533 (modest_account_settings_dialog_init),
2534 (modest_account_settings_dialog_set_account_name),
2535 (create_page_incoming): Show the display name, instead of the account name.
2536 (on_response): Do some (not all) extra checks, as in the UI spec.
2537 (save_configuration): Save the display name if it was changed.
2539 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2541 * po/en_GB.po: Added needed logical ID and translation.
2542 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2543 (init_view): Made the is-default column clicking work.
2545 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/easysetup/Makefile.am:
2549 * src/maemo/easysetup/modest-easysetup-wizard.c:
2550 (modest_easysetup_wizard_dialog_init):
2551 * src/maemo/easysetup/provider-data-test.keyfile:
2552 * src/maemo/easysetup/provider-data.keyfile:
2553 Moved the provider data file to the new modest-providers-data package and used it from there.
2555 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2557 * src/modest-local-folder-info.c:
2558 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2559 N_() was already used on the static strings, but this just marks it for translation without
2560 using the translation.
2562 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2564 * src/maemo/modest-account-settings-dialog.c:
2565 (create_page_incoming),
2566 (modest_account_settings_dialog_set_account_name):
2567 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2568 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2569 I will do this if nobody else gets there first.
2571 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2574 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2575 save the security stuff.
2577 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2580 Set the email address and user fullname, which I now see must be
2583 * src/maemo/modest-account-settings-dialog.h:
2584 * src/maemo/modest-account-settings-dialog.c:
2586 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2587 leave-on-server and authentication.
2588 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2591 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2594 * src/maemo/modest-account-settings-dialog.c:
2595 * src/maemo/modest-account-settings-dialog.h:
2596 Most (but not all) of the widgets are now present as specified by the UI spec.
2597 No changes are yet saved, and some details are not properly shown yet.
2599 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2601 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2603 * src/maemo/Makefile.am:
2604 * src/maemo/modest-account-settings-dialog.c:
2605 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2606 an existing account. Doesn't do much yet.
2608 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2609 Open the accounts settings dialog when Edit is clicked.
2611 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/easysetup/Makefile.am:
2614 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2616 * src/maemo/easysetup/modest-easysetup-wizard.c:
2617 (modest_easysetup_wizard_dialog_init):
2618 Try to get the source directory from the build system,
2619 instead of hard-coding "./" into the source code, when opening our local
2620 copies of the configuration files.
2621 But this still fails when opening the wizard from the Accounts window,
2622 maybe because the working directory seems to change at runtime.
2623 So the wizard will fail the second time unless you copy the files into their
2624 proper locations - see the stdout warnings for the paths.
2626 (create_page_account_details),(on_before_next):
2627 Check for existing non-server accounts instead of server accounts,
2628 so the default account name is useful again, and to prevent trying to
2631 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2632 Show the wizard when New is clicked.
2634 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2635 (init_view): Show the column headers, and show the columns that are
2636 specified in the UI specs. However, something in Maemo's GTK+ prevents
2637 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2638 change the default account. This is despite unsetting the special properties.
2640 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2642 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2643 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2644 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2645 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2646 to make that clearer.
2647 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2649 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2651 * src/maemo/modest-account-view-window.c:
2652 (modest_account_view_window_init),
2653 (modest_account_view_window_new):
2654 Use the same buttons as specified in the
2655 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2656 the existing widgets, which never had a chance of working.
2657 Put the ModestAccountView treeview in a scrolled window.
2658 Do not repeat the initialization in both _init() and _new().
2660 * src/widgets/modest-account-view.c: (update_account_view):
2661 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2662 this widget and window shows no accounts.
2664 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2666 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/easysetup/modest-easysetup-wizard.c:
2669 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2670 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2671 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2674 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2675 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2676 accounts exist yet, as in the UI spec.
2678 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2680 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2682 * src/maemo/Makefile.am:
2683 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2684 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2685 New window for editing connection-specific smtp details.
2686 Not fully implemented.
2688 * src/maemo/modest-connection-specific-smtp-window.c:
2689 (modest_connection_specific_smtp_window_finalize) :
2690 unref the tree model.
2691 (on_button_edit): Show the edit window.
2693 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2695 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2698 * src/maemo/Makefile.am:
2699 * src/maemo/modest-connection-specific-smtp-window.c:
2700 * src/maemo/modest-connection-specific-smtp-window.h:
2701 New window for showing the list of connections, for connection-specific
2702 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2703 * src/maemo/easysetup/modest-easysetup-wizard.c:
2704 (create_page_custom_outgoing): Show the new window when the button is clicked.
2706 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2708 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2709 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2710 * src/maemo/modest-msg-edit-window.c:
2711 (modest_msg_edit_window_insert_image):
2712 * src/modest-conf.c: (modest_conf_key_escape):
2713 * src/modest-mail-operation.c:
2714 (modest_mail_operation_send_new_mail):
2715 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2716 (modest_ui_actions_on_new_account):
2717 * src/widgets/modest-attachment-view.c: (update_filename_request):
2718 * src/widgets/modest-mail-header-view.c:
2719 Corrected warnings that were breaking the build, by commenting out unused variables,
2720 and a function, and by including a header.
2722 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2724 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2725 so we can #ifdef around platform-specific code when necessary.
2726 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2727 to allow this to build for the GNOME platform too.
2729 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2731 * src/maemo/easysetup/modest-easysetup-wizard.c:
2732 Added util_increment_name() and used it in create_page_account_details()
2733 to make sure that the default account name is always a new name.
2735 (modest_easysetup_wizard_dialog_init),
2736 (set_default_custom_servernames): Some minor memory management fixes.
2738 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2742 * src/modest-runtime.c: (init_i18n): Restored the translation
2743 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2744 are defined in config.h, and the translations are installed.
2746 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2747 is defined for translation.
2749 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2751 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2753 * src/maemo/easysetup/modest-easysetup-wizard.c:
2754 (modest_easysetup_wizard_dialog_init):
2755 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2756 Use realistic paths (though they should use $prefix generically) to the
2757 mcc_mapping and provider-data.keyfile files which might work when they
2758 are installed by the future version of the operator-wizard package,
2759 and then fallback to paths in our source code, with an explanatory
2762 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2766 * src/maemo/Makefile.am:
2767 * src/maemo/easysetup/: Added files from the previously-exernal
2768 osso-modest-easysetup.
2769 * src/maemo/modest-main-window-ui.h:
2770 * src/modest-ui-actions.c:
2771 * src/modest-ui-actions.h:
2772 Added modest_ui_actions_on_new_account() as a signal handler for the
2773 New Account menu item. It shows the easysetup wizard.
2774 * po/en_GB.po: Added additional needed logical IDs and translations.
2776 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2777 Apparently ChangeLog is not used for some vague Nokia legal reasons.