1 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3 * src/gnome/modest-main-window.c:
4 (on_account_store_connecting_finished), (connect_signals):
5 * src/maemo/modest-main-window.c:
6 (on_account_store_connecting_finished), (connect_signals),
7 (modest_main_window_new):
8 Handle TnyAccountStore::connecting-finished instead of
9 TnyDevice::connection-changed, because we cannot actually perform
10 operations on accounts until TnyAccountStore has itself responded to
11 the TnyDevice::connection-changed signal. This prevents a GError from
13 Do not try to update at startup, because we (at least on scratchbox)
14 already do an update at startup when the device goes online.
15 This prevents a GError from tinymail.
16 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
17 Added TODO about stopping simultaneous operations.
19 2007-05-21 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
22 * src/modest-mail-operation-queue.c:
23 (modest_mail_operation_queue_remove):
24 * src/modest-tny-account-store.c: When GErrors happen, give more clues
25 about where they happened.
27 2007-05-21 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-ui-actions.c:
30 (modest_ui_actions_on_password_requested): Make sure that the remember
31 output parameter is always TRUE.
33 2007-05-21 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
36 Show a OK/Cancel dialog if the error is a question, though we still do not
37 know anything more about what we are asking the user.
38 * src/widgets/modest-folder-view.c: (on_drag_data_received):
39 Fix an uninitialized variable (helper). This is a logic error, however.
41 2007-05-21 Christian Kellner <ckellner@openismus.com>
43 * src/modest-search.h:
44 Correct bit shifting in the ModestSearchFlags enum.
46 2007-05-21 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-tny-account.c:
49 (modest_tny_account_new_from_server_account): Do not use the lsub and
50 check-all hard-coded IMAP options when using POP.
52 2007-05-21 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-tny-account.c:
55 (modest_tny_account_new_from_server_account):
56 Use NULL for the secure-auth method for POP when Password auth has been
57 specified by the user, as we already do for IMAP. "auth=Login" causes
58 an error from camel or the server.
60 2007-05-17 Murray Cumming <murrayc@murrayc.com>
62 * src/maemo/modest-account-settings-dialog.c:
63 (create_page_account_details),
64 (modest_account_settings_dialog_set_account_name):
65 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
66 for the leave-on-server checkbox, rathr than just the checkbox, when
67 the protocol is not POP.
69 2007-05-17 Murray Cumming <murrayc@murrayc.com>
71 * src/widgets/modest-account-view.c:
72 * src/widgets/modest-account-view.h:
73 Added modest_account_view_select_account() which will be useful later
74 to asynchronously re-select the edited account.
76 2007-05-17 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/modest-account-settings-dialog.c:
79 (modest_account_settings_dialog_set_account_name):
80 Automatically choose the port numbers based on the secure authentication
81 methods, if they have not been chosen before.
82 This fixes projects.maemo.org bug NB#56273 .
84 2007-05-17 Murray Cumming <murrayc@murrayc.com>
86 * src/maemo/modest-main-window-ui.h:
87 * src/modest-ui-actions.c:
88 * src/modest-ui-actions.h:
89 Connect the Tools/SMTP Servers menu item to
90 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
91 SMTP servers dialog, as in the UI specification and saves changes when it
92 is closed. This fixed projects.maemo.org bug NB#56305 .
94 2007-05-17 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/modest-connection-specific-smtp-window.c:
97 (modest_connection_specific_smtp_window_init):
98 Use gtk_window_set_default_size() to make this window big enough, so
99 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
101 2007-05-17 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-connection-specific-smtp-edit-window.h:
104 * src/maemo/modest-connection-specific-smtp-edit-window.c:
105 (modest_connection_specific_smtp_edit_window_init),
106 Do not try to connect to a combobox signal before the combobox exists.
107 This fixes the cras in projects.maemo.org bug NB#56288 .
108 (modest_connection_specific_smtp_edit_window_get_settings):
109 Remove the server_account_name parameter which was being checked for NULL
110 though it was not used.
112 * src/maemo/modest-connection-specific-smtp-window.c:
113 (modest_connection_specific_smtp_window_fill_with_connections),
114 (on_button_edit), (modest_connection_specific_smtp_window_init):
115 Correct the number of treemodel columns to prevent a warning.
116 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
117 libconic does not work.
119 2007-05-16 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-tny-account.c:
122 (modest_tny_account_new_from_server_account):
123 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
124 SMTP when "None" was chosen by the user. However, with my SMTP server that
125 does not support ANONYMOUS, the emails do not leave the Outbox and I see
128 2007-05-16 Murray Cumming <murrayc@murrayc.com>
130 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
131 to explain the memory management issue with the ID in the ModestPair.
133 * src/gnome/modest-account-assistant.c: (add_receiving_page),
134 (add_sending_page), (modest_account_assistant_finalize):
135 * src/gnome/modest-gnome-global-settings-dialog.c:
136 (create_updating_page), (create_composing_page):
137 * src/gnome/modest-msg-edit-window.c: (get_transports),
138 (init_window), (modest_msg_edit_window_finalize),
139 (modest_msg_edit_window_get_msg_data):
140 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
141 * src/gnome/modest-transport-widget.c:
142 (modest_transport_widget_finalize), (smtp_configuration):
143 * src/maemo/modest-maemo-global-settings-dialog.c:
144 (create_updating_page), (create_composing_page):
145 * src/maemo/modest-msg-edit-window.c: (get_transports),
146 (init_window), (modest_msg_edit_window_finalize),
147 (modest_msg_edit_window_get_msg_data),
148 (modest_msg_edit_window_free_msg_data):
149 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
150 (modest_store_widget_finalize):
151 * src/maemo/modest-transport-widget.c:
152 (modest_transport_widget_finalize), (smtp_configuration):
153 * src/modest-main.c: (send_mail):
154 * src/widgets/modest-combo-box.h:
155 * src/widgets/modest-global-settings-dialog-priv.h:
156 * src/widgets/modest-global-settings-dialog.c:
157 (modest_global_settings_dialog_finalize):
158 * src/widgets/modest-msg-edit-window.h:
159 Whenever using modest_combo_box_new(), keep the ModestPairList alive
160 as long as the combo box, to prevent use of freed memory for the ID.
162 2007-05-15 Murray Cumming <murrayc@murrayc.com>
164 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
165 get_accounts(), to make this clearer. Do not check for the enabled gconf
166 key, because we do not use this for server accounts (at least, not yet).
167 This allows us to send email again.
169 2007-05-15 Murray Cumming <murrayc@murrayc.com>
171 * src/maemo/modest-platform.c:
172 (on_modest_conf_update_interval_changed), (modest_platform_init):
173 Only respond to this particular key change. All these strcmp()s cannot be
176 2007-05-15 Murray Cumming <murrayc@murrayc.com>
178 * src/maemo/modest-maemo-global-settings-dialog.c:
179 (current_connection): Prevent a crash in scratchbox when
180 ny_maemo_conic_device_get_current_iap_id() returns NULL.
181 * src/maemo/modest-platform.c:
182 (on_modest_conf_update_interval_changed), (modest_platform_init):
183 Get the update interval from gconf and reset it when the gconf key changes.
185 2007-05-15 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-protocol-info.c:
188 * src/modest-protocol-info.h: Adde enum-specific get functions,
189 instead of using a ModestProtocolType enum parameter.
191 * src/gnome/modest-account-assistant.c:
192 * src/gnome/modest-store-widget.c:
193 * src/gnome/modest-store-widget.h:
194 * src/gnome/modest-transport-widget.c:
195 * src/gnome/modest-transport-widget.h:
196 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
197 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
198 * src/maemo/easysetup/modest-easysetup-wizard.c:
199 * src/maemo/modest-account-settings-dialog.c:
200 * src/maemo/modest-account-settings-dialog.h:
201 * src/maemo/modest-store-widget.c:
202 * src/maemo/modest-store-widget.h:
203 * src/maemo/modest-transport-widget.c:
204 * src/maemo/modest-transport-widget.h:
205 * src/modest-account-mgr-helpers.c:
206 * src/modest-account-mgr-helpers.h:
207 * src/modest-account-mgr.c:
208 * src/modest-account-mgr.h:
209 * src/modest-tny-account.c:
210 * src/modest-tny-folder.c:
211 * src/widgets/modest-account-view.c:
212 * src/widgets/modest-retrieve-combo-box.c:
213 * src/widgets/modest-retrieve-combo-box.h:
214 * src/widgets/modest-secureauth-combo-box.c:
215 * src/widgets/modest-serversecurity-combo-box.c:
216 * src/widgets/modest-serversecurity-combo-box.h:
217 * tests/check_account-mgr.c:
218 Use the specific functions, and use the re-renamed enum values for GNOME too.
220 2007-05-15 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
224 so we can get the second based on the first.
226 * src/maemo/modest-account-settings-dialog.h:
227 * src/maemo/modest-account-settings-dialog.c:
228 Added get_supported_secure_authentication_methods(), though it is mostly
229 commented-out for now until the necessary API is committed to tinymail.
230 (modest_account_settings_dialog_set_account_name),
231 (save_configuration): Request the supported authentication methods from the
232 server, so we can choose a working method.
234 * src/modest-tny-account-store.h:
235 * src/modest-tny-account-store.c:
236 (modest_tny_account_store_get_session): Rename from
237 tny_account_store_get_session().
239 2007-05-14 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-protocol-info.h: Split the ModestProtocol enum
242 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
243 There was no need to have these unrelated values in one enum.
245 * src/: many files: Adapted to changed enum. This makes the code a bit
246 clearer, and the compiler could catch some errors.
248 2007-05-14 Murray Cumming <murrayc@murrayc.com>
250 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
251 Show the detailed internal camel error message when an error happens
252 during the configuration, so that our testers can give us more clues.
253 For instance, in projects.maemo.org bug NB#56910 .
255 2007-05-14 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-tny-account.c:
258 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
259 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
261 2007-05-14 Murray Cumming <murrayc@murrayc.com>
263 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
264 * src/maemo/modest-account-settings-dialog.c:
265 (modest_account_settings_dialog_set_account_name),
266 (save_configuration): For the incoming secure authentication checkbox,
267 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
268 the UI specification. PLAIN does not seem to be supported for most IMAP
269 servers anyway, and I am not sure what it would mean.
270 However, we probably need to discover which of the secure-authentication
271 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
272 * src/modest-account-mgr-helpers.c:
273 (modest_account_mgr_get_server_account_data):
275 * src/modest-tny-account.c:
276 (modest_tny_account_new_from_server_account):
277 Use tny_account_set_mech() to set secure-authentication methods,
278 with some special-casing for IMAP, based on my observations of how
281 * src/modest-account-mgr-helpers.h:
282 * src/modest-account-mgr.c:
283 * src/modest-defs.h: Comment that the URI is only used for local folders.
285 2007-05-11 Murray Cumming <murrayc@murrayc.com>
287 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
288 parameter const, just to be neat.
289 * src/modest-text-utils.c: (modest_text_utils_inline):
290 End g_strconcat() with NULL, as its documentation says. This is almost
291 certainly the cause of my crash at startup on the device. Interestingly,
292 valgrind doesn't tell us about these errors.
294 2007-05-11 Murray Cumming <murrayc@murrayc.com>
296 * scripts/build-packages: Added more precise comments about how to use
297 this script, though I still get this error:
298 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
299 error building tinymail
301 2007-05-11 Murray Cumming <murrayc@murrayc.com>
303 * src/maemo/modest-main-window.c: (on_account_update):
304 Very slight cleanup, hoping to make it simpler to discover what causes
305 a crash here sometimes.
307 * src/modest-tny-account.c:
308 (modest_tny_account_new_from_server_account): Set the port. Added
309 comments about the options and a TODO comment because I need to find out
310 how to specify the secure authentication method.
312 2007-05-11 Marcus Bauer <marcusb@openismus.com>
314 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
315 changed CFlags paths form modest to libmodest
317 2007-05-10 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-account-mgr-helpers.c:
320 (modest_account_mgr_get_server_account_data),
321 (modest_account_mgr_free_server_account_data):
322 * src/modest-account-mgr-helpers.h:
323 * src/modest-account-mgr.c:
324 (modest_account_mgr_add_server_account):
326 * src/modest-tny-account.c:
327 (modest_tny_account_new_from_server_account):
328 Determine the options for tny_camel_account_add_option() here,
329 based on the settings, rather than storing them directly in gconf.
331 2007-05-10 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
334 Show a more friendly error dialog now that we expect (from the tinymail
335 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
337 2007-05-10 Murray Cumming <murrayc@murrayc.com>
339 * src/maemo/modest-main-window.c: (on_account_update): Check that
340 account_name is not NULL, to prevent a crash at startup that I am
341 seeing on the N800. I do wonder why it is NULL.
343 * src/maemo/easysetup/modest-easysetup-wizard.c:
344 (create_page_user_details):
345 * src/maemo/modest-account-settings-dialog.c:
346 (create_page_user_details), (create_page_outgoing):
347 * src/maemo/modest-connection-specific-smtp-edit-window.c:
348 (modest_connection_specific_smtp_edit_window_init):
349 * src/modest-ui-actions.c:
350 (modest_ui_actions_on_password_requested):
351 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
352 might do something useful with the on-screen keyboard.
354 2007-05-10 Murray Cumming <murrayc@murrayc.com>
356 * src/maemo/modest-main-window.c: (on_account_update):
357 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
358 NULL, to avoid lots of warnings. However, it probably should not be NULL.
360 2007-05-09 Murray Cumming <murrayc@murrayc.com>
362 * src/modest-tny-account-store.c: (on_account_changed):
363 Correct the signature of this signal handler.
365 2007-05-09 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
368 Show a HildonNote instead of a GtkDialog for Maemo.
370 2007-05-09 Murray Cumming <murrayc@murrayc.com>
372 * src/widgets/modest-account-view.h:
373 * src/widgets/modest-account-view.c: (on_account_changed),
374 (on_account_removed). Added a boolean flag, set/unset by
375 modest_account_view_block_conf_updates(),
376 modest_account_view_unblock_conf_updates() to prevent unnecessary
377 updates, but this is not very useful because the gconf notifications are
378 so delays (maybe only on Maemo Bora).
379 So auto-updating is turned off, and these functions do an explicit
380 update when necessary.
381 However, something else is still doing too much work when adding/removing
382 accounts, probably in another part of the application.
384 * src/maemo/modest-account-view-window.c:
385 (on_delete_button_clicked), (on_edit_button_clicked),
386 (on_new_button_clicked): Use the new functions.
388 2007-05-09 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-account-mgr-helpers.c:
391 (modest_account_mgr_set_first_account_as_default):
392 Sort the list of names alphabetically-by-title, so we choose the first one
394 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
395 alphabetically by the title.
397 This fixes projects.maemo.org bug NB#56418 .
399 * src/modest-account-mgr-priv.c:
400 (_modest_account_mgr_account_from_key):
401 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
402 avoid a valgrind error, and possible random behaviour.
404 2007-05-09 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
407 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
408 tinymail documentation to say that this can be expected.
409 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
410 pretty, and should not happen, but I would prefer to know when it does.
412 2007-05-09 Murray Cumming <murrayc@murrayc.com>
414 * configure.ac: When using the older hildon version, probably on Bora,
415 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
417 * src/widgets/modest-attachment-view.c:
418 (modest_attachment_view_set_part_default): Initialize variables, to fix the
421 2007-05-09 Marcus Bauer <marcusb@openismus.com>
423 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
424 Implemented the prototype. Can be tested with
425 tests/dbus_api/test_open_message:
427 2007-05-08 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-tny-account-store.c:
430 (modest_tny_account_store_instance_init), (get_password):
431 * src/modest-ui-actions.c:
432 (modest_ui_actions_on_password_requested):
433 Do not store the password in gconf, because this function is called
434 for non-remembered passwords. Actually use the cached (in the hash map)
435 password instead of releasing it.
436 The password will now not be remembered if it is asked via the protected
437 password dialog, as per the UI spec.
439 2007-05-08 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-account-mgr-helpers.h:
443 * src/modest-account-mgr-helpers.c:
444 Added modest_server_account_get_username_has_succeeded(),
445 modest_server_account_set_username_has_succeeded().
446 (modest_server_account_set_username),
447 Reset the has-succeeded flag if the username changes.
449 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
450 * src/maemo/modest-connection-specific-smtp-window.c:
451 (modest_connection_specific_smtp_window_save_server_accounts):
452 Use modest_server_account_set_username() instead of using
453 modest_conf_set_string() directly, so that the has-succeeded flag is always
456 * src/modest-ui-actions.c:
457 (modest_ui_actions_on_password_requested): Dim the username entry if
458 the username has ever worked, as per the UI spec.
460 2007-05-08 Murray Cumming <murrayc@murrayc.com>
462 * src/modest-tny-account-store.c: (get_password):
463 * src/modest-ui-actions.c:
464 (modest_ui_actions_on_password_requested):
465 Allow the username to be changed too, though there is more work to
466 be done on exactly how this behaves.
468 2007-05-08 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-account-mgr-helpers.h:
471 * src/modest-account-mgr-helpers.c:
472 Added modest_account_mgr_get_display_name(),
473 modest_server_account_get_username(),
474 modest_server_account_set_username(),
475 modest_server_account_set_password(),
476 modest_server_account_get_hostname() functions so we do not need to
477 use the conf API directly.
479 * src/maemo/modest-main-window.c: (connect_signals):
480 Actually connect ot the ModestAccountStore::request-password signal,
481 so that we show the dialog when the password is requested by Tinymail,
482 for isntance if it is empty.
484 * src/modest-marshal.list:
485 * src/modest-tny-account-store.c:
486 (modest_tny_account_store_class_init), (get_password),
487 (modest_tny_account_store_alert):
488 * src/modest-tny-account-store.h:
489 * src/modest-ui-actions.h:
490 * src/modest-ui-actions.c:
491 (modest_ui_actions_on_password_requested):
492 Change the signal parameters, so it is obvious that we are providing
493 the non human-readable server name, and receiving both the username
494 and password, though changing of the username is not yet implemented.
495 Change the dialog UI to match the Maemo UI specifications, with #idfefing
496 for the GNOME version.
498 This should fix the projects.maemo.org bug NB#56209, though it does not
499 work on Bora, because the gconf_client_get() for the password fails
500 immediately after we save it with gconf_client_set().
502 2007-05-08 Murray Cumming <murrayc@murrayc.com>
505 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
506 caused an undefined symbol error:
507 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
509 2007-05-08 Murray Cumming <murrayc@murrayc.com>
511 * src/modest-tny-account-store.c:
512 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
513 using a GError instead of a string message, so we can translate it in
516 2007-05-08 Murray Cumming <murrayc@murrayc.com>
518 * src/maemo/modest-address-book.c:
519 (modest_address_book_check_names):
520 * src/maemo/modest-msg-view-window.c:
521 (modest_msg_view_window_clipboard_owner_change):
522 * src/modest-init.c: (modest_init_init_ui):
523 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
524 (update_folders_cb), (modest_mail_operation_update_account):
525 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
526 (modest_ui_actions_on_msg_attachment_clicked),
527 (modest_ui_actions_on_msg_recpt_activated):
528 * src/widgets/modest-header-view.c: (drag_data_get_cb):
529 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
530 (modest_msg_view_search_next):
531 * src/widgets/modest-recpt-editor.c:
532 (modest_recpt_editor_on_button_release_event),
533 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
534 g_message(). At this point we should only be seeing interesting errors on
535 stdout. Debugging messages could be #ifdefed-out if they are still useful.
537 2007-05-07 Murray Cumming <murrayc@murrayc.com>
539 (modest_wizard_dialog_force_title_update):
540 * src/maemo/easysetup/modest-wizard-dialog.h:
541 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
542 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
543 can update the title when appropriate. Otherwise the title is wrong if the
544 pages are added after adding the notebook to the dialog.
545 This must be a problem in HildonWizardDialog too.
546 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
548 * src/maemo/easysetup/modest-easysetup-wizard.c:
549 (create_subsequent_customsetup_pages),
550 (create_subsequent_easysetup_pages):
551 Call modest_wizard_dialog_force_title_update() so that the title is
552 correct even with GTK+ < 2.10.
553 This fixes projects.maemo.org bug NB#56145 .
555 2007-05-07 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-platform.c:
558 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
559 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
562 2007-05-07 Murray Cumming <murrayc@murrayc.com>
564 * src/widgets/modest-window.h:
565 * src/widgets/modest-window.c: Added a save_state_func vfunc,
566 and modest_window_save_state(), which invokes it.
568 * src/widgets/modest-window-mgr.h:
569 * src/widgets/modest-window-mgr.c:
570 Added modest_window_mgr_save_state_for_all_windows(), which calls
571 the save_state vfunc on all registered windows, if implemented.
573 * src/gnome/modest-msg-edit-window.c:
574 * src/gnome/modest-msg-view-window.c:
575 * src/maemo/modest-msg-edit-window.c:
576 * src/maemo/modest-msg-view-window.c:
577 * src/maemo/modest-main-window.c:
578 Specify the existing save_settings functions as implementations of
579 ModestWindow::save_state_func().
581 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
582 Call modest_window_mgr_save_state_for_all_windows(). This happens before
583 enabling hibernation, for instance.
585 We may need to do the same thing for restoring settings.
588 2007-05-07 Murray Cumming <murrayc@murrayc.com>
590 * src/widgets/modest-window-mgr.c:
591 * src/widgets/modest-window-mgr.h:
592 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
593 modest_window_mgr_get_hibernation_is_prevented().
595 * src/maemo/modest-main-window.c:
596 (on_hildon_program_is_topmost_notify): Prevent hibernation
597 (possible when the application goes to the background in the WM),
598 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
600 * src/maemo/easysetup/modest-easysetup-wizard.c:
601 (modest_easysetup_wizard_dialog_init):
602 * src/maemo/modest-account-settings-dialog.c:
603 (modest_account_settings_dialog_init):
604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
605 (modest_connection_specific_smtp_edit_window_init):
606 * src/maemo/modest-connection-specific-smtp-window.c:
607 (modest_connection_specific_smtp_window_init):
608 * src/maemo/modest-signature-editor-dialog.c:
609 (modest_signature_editor_dialog_init):
610 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
611 prevent hibernation while any of these account settings dialogs are open.
613 2007-05-04 Murray Cumming <murrayc@murrayc.com>
615 * src/maemo/Makefile.am:
616 * src/maemo/modest-osso-state-saving.c:
617 * src/maemo/modest-osso-state-saving.h: Added
618 modest_osso_load_state() and modest_osso_save_state() though they do
619 nothing now. They should iterate through all the open windows and load/save
621 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
622 save state when closing.
624 * src/maemo/modest-main-window.c:
625 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
626 Add a notification handler for the HildonProgram::is-topmost property,
627 so we can allow hibernation when the application goes into the background.
628 But we still need to detect when the accounts setup windows are open so
629 we can stop hibernation when they are open.
630 To do this, I also added the main window the HildonProgram. This might have
631 other side-effects/benefits, and should maybe be done for other windows.
633 * src/maemo/modest-osso-autosave-callbacks.h:
634 * src/maemo/modest-osso-autosave-callbacks.c:
635 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
636 though it does not do anything yet, and we might never need this to do
637 anything. For instance, we already save drafts.
639 * src/maemo/modest-platform.c: (modest_platform_init):
640 Specify the libosso auto-save callback.
642 2007-05-03 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/modest-platform.c:
645 (modest_platform_set_update_interval):
646 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
647 aparently stays valid between application instances, so we can use this
648 to remove and reset it later. According to a maemo-developers email from
651 2007-05-03 Murray Cumming <murrayc@murrayc.com>
653 * configure.ac: Depend on libalarm for Maemo.
655 * src/dbus_api/modest-dbus-api.h:
656 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
657 (on_send_receive), (modest_dbus_req_handler):
658 Handle a SEND_RECEIVE D-Bus method.
660 * libmodest-dbus-client/libmodest-dbus-client.c:
661 (libmodest_dbus_client_send_and_receive):
662 * libmodest-dbus-client/libmodest-dbus-client.h:
663 Add C convenience functions for calling the new D-Bus method.
665 * src/modest-platform.h:
666 * src/gnome/modest-platform.c:
667 * src/maemo/modest-platform.c:
668 Added modest_platform_set_update_interval(), which uses the
670 (modest_platform_init),
671 Call modest_platform_set_update_interval(), using a hard-coded
672 interval for now (until the global settings dialog is implemented),
673 though I am not sure that this makes sense yet.
675 2007-05-02 Murray Cumming <murrayc@murrayc.com>
677 * src/dbus_api/modest-dbus-callbacks.c:
678 (modest_osso_cb_hw_state_handler):
679 * src/dbus_api/modest-dbus-callbacks.h:
680 * src/maemo/modest-platform.c: (modest_platform_init):
681 Registered (empty) callbacks for the osso hardware state D-Bus signals,
682 in case this has some effect on the ability for Maemo to ping the
685 2007-05-02 Murray Cumming <murrayc@murrayc.com>
687 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
688 Comment out an if() that checks a gchar for < 0, causing a build-breaking
689 warning. It is probably a logic error, but I need to fix the build.
691 2007-05-02 Murray Cumming <murrayc@murrayc.com>
693 * src/modest-account-mgr.h:
694 * src/modest-account-mgr.c:
695 (modest_account_mgr_account_names): Add a gboolean enabled_only
696 parameter, so we can get lists of onlt the enabled accounts.
698 (modest_account_mgr_add_account),,
699 (modest_account_mgr_account_with_display_name_exists):
700 * src/maemo/modest-msg-edit-window.c: (get_transports):
701 * src/modest-account-mgr-helpers.c:
702 (modest_account_mgr_set_first_account_as_default):
703 * src/modest-init.c: (init_default_account_maybe):
704 * src/modest-tny-account-store.c: (get_accounts):
705 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
706 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
707 * tests/check_account-mgr.c: (START_TEST):
708 Provide the extra parameter, as appropriate.
710 * src/widgets/modest-account-view.c: (update_account_view):
711 Do not show disabled accounts (meaning that there is no way to
712 enable/disable accounts in the UI (the feature is not in our UI
713 specification), so we can use this internally only to mark unfinished
714 or temporary account data.
716 * src/maemo/easysetup/modest-easysetup-wizard.c:
717 (create_account): Add boolean enable parameter, so we can specify FALSE
718 to create the temporary account.
719 (on_button_edit_advanced_settings): Create the temporary account as disabled.
720 (on_before_next): When finishing, when there is a temporary account, just
722 Also, use a timeout to delay the showing of the dialog until gconf is likely
723 to return correct information, due to a maemo gconf bug that is fixed in
724 osso 1.1, but not yet in Bora.
725 However, the dialog stays on screen after it is destroyed.
727 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
728 for invalid data when cancelling. Use a hildon note instead of a dialog
729 to complain about invalid data. Do not show the account-saved note if the
730 account is disabled (a temporary account that will not really be saved for use
733 2007-04-30 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-account-mgr-helpers.h:
736 * src/modest-account-mgr-helpers.c:
737 Added modest_account_mgr_unset_default_account(),
738 Added modest_account_mgr_set_first_account_as_default().
740 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
741 If it was the default account, unset the default account name.
743 * src/maemo/modest-account-view-window.c:
744 (on_delete_button_clicked): If it was the default account,
745 set the first remaining account as the default instead.
747 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
748 a NULL account or a NULL default account, to prevent a crash. This should
749 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
752 2007-04-30 Murray Cumming <murrayc@murrayc.com>
754 * src/widgets/modest-recpt-editor.c:
755 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
756 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
757 TODO comment for this. This fixes the build.
759 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
760 be the best place for it. This will in future update all auto-update accounts,
761 rather than just the current/default account, when that gconf key exists.
762 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
763 if there are no accounts, before calling do_send_receive().
764 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
766 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
767 * src/maemo/modest-main-window-ui.h:
768 * src/maemo/modest-main-window.c: (on_connection_changed),
769 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
770 directly, becaue the signal handler does more.
772 2007-04-30 Murray Cumming <murrayc@murrayc.com>
774 * src/modest-account-mgr-helpers.c:
775 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
776 for the case that the account does not exist.
778 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
779 (equivalent to the modest account name) rather than the tinymail account name
780 (equivalent to the modest account title - human readable) to get the account data.
781 Check for null account data to prevent the crash, and add a TODO comment saying that
782 this needs fixing because it is using the server account name instead of the account name.
784 2007-04-29 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
787 * src/maemo/modest-account-settings-dialog.c: (show_error),
789 Use hildon_note_new_information() for informative and error messages,
790 which seems to be expected for Maemo applications (no documentation that I know of
791 says this). I am surprised that there is no distinction between info and error
794 2007-04-29 Murray Cumming <murrayc@murrayc.com>
796 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
797 it is easy to find where this is used.
799 * src/maemo/easysetup/modest-easysetup-wizard.c:
800 (create_page_welcome), (create_page_account_details),
801 (create_page_user_details), (create_page_complete_easysetup),
802 (create_page_custom_incoming), (create_page_custom_outgoing),
803 (create_page_complete_custom):
804 * src/maemo/modest-account-settings-dialog.c:
805 (create_page_account_details), (create_page_user_details),
806 (create_page_incoming), (create_page_outgoing):
807 * src/maemo/modest-account-view-window.c: (window_vbox_new):
808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
809 (modest_connection_specific_smtp_edit_window_init):
810 * src/maemo/modest-connection-specific-smtp-window.c:
811 (modest_connection_specific_smtp_window_init):
812 * src/maemo/modest-signature-editor-dialog.c:
813 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
814 and scrolling policy as per the Email Application Layout Guide, if I have
817 2007-04-27 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
820 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
821 which were empty, because these vfuncs have been removed from TnyAccountStore.
822 This fixes the build.
824 2007-04-27 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-main-window.c:
827 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
828 showing/hiding it. Added TODO because it probably should not be NULL.
829 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
830 because unnecessary g_warnings() make degugging difficult.
832 2007-04-27 Murray Cumming <murrayc@murrayc.com>
834 * src/maemo/modest-msg-edit-window.c:
835 (modest_msg_edit_window_select_color),
836 (modest_msg_edit_window_select_background_color): 2 const corrections and
837 moving 2 #endifs before closing brackets, to fix the build.
839 2007-04-27 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/easysetup/modest-easysetup-wizard.h:
842 * src/maemo/easysetup/modest-easysetup-wizard.c:
843 (modest_easysetup_wizard_dialog_finalize),
844 (on_button_edit_advanced_settings), (create_page_complete_custom),
845 (on_response), (create_account):
846 Implement the Advanced Settings edit button, by saving the account information,
847 for the Advanded Settings dialog to use directly from gconf, and removing it
848 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
849 Bug #5533 in the projects.maemo.org bugzilla.
851 2007-04-27 Murray Cumming <murrayc@murrayc.com>
853 * src/maemo/modest-msg-view-window.c:
854 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
855 when opening a message window.
857 2007-04-27 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/easysetup/modest-easysetup-wizard.c:
860 (create_page_custom_outgoing): Correct the position of the horizontal separator to
863 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
864 before showing/hiding them, to avoid a crash when clicking on folders when there are no
865 gconf settings. I probably added more checks than necessary, but that is safer.
867 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
868 variable to fix the build, but this seems to be used when it is still NULL.
870 2007-04-27 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-platform.h:
873 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
874 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
875 * src/modest-main.c: Implement this function so we can avoid using
876 maemo-specific API from cross-platform code.
878 * src/modest-tny-account-store.c:
879 (get_smtp_specific_transport_account_for_open_connection):
880 * src/modest-ui-actions.c: (check_for_connection),
881 (modest_ui_actions_on_item_not_found):
882 Use modest_platform_connect_and_wait() and put #idefs around other
883 maemo-specific code, because only maemo currently has a way to
884 identify connection names.
886 2007-04-27 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-tny-account-store.h:
889 * src/modest-tny-account-store.c:
890 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
891 the connection-specific SMTP server settings in the configuration.
893 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
895 * src/maemo/modest-main-window.c: (on_connection_changed),
897 * src/modest-main.c: (main), (start_ui), (send_mail):
898 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
899 that is what is intended.
901 * src/modest-ui-actions.c: (action_send), (action_receive),
902 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
903 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
904 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
905 SMTP server is used when it is specified.
907 (modest_ui_actions_on_send_receive):
908 Check that a connection is open before proceeding.
909 Receive and then send, instead of vice-versa, as per the specification.
911 2007-04-26 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-mail-operation.c:
914 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
915 though I guess it should be something other than NULL.
917 2007-04-26 Murray Cumming <murrayc@murrayc.com>
919 * src/maemo/easysetup/modest-easysetup-wizard.c:
920 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
921 combo twice, to avoid an g_warning and to make it visible again.
922 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
923 attached before detaching it, to avoid a g_warning, and add comment about the implicit
924 (already intended) dereference when detaching, because we then recreate the menu.
925 But I am not sure why the warning was happening, and it is possible that this is a memory
928 2007-04-25 Murray Cumming <murrayc@murrayc.com>
930 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
931 and uri_parse_mailto() utility functions.
932 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
934 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
936 2007-04-24 Murray Cumming <murrayc@murrayc.com>
938 * src/dbus_api/modest-dbus-api.h:
939 * src/dbus_api/modest-dbus-callbacks.c:
940 Use an idle callback to execute the modest code in the application's own thread.
941 Remove the helloworld example method.
942 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
943 parsed, and the open-message method is not implemented because this is not yet implemented in
945 * libmodest-dbus-client/libmodest-dbus-client.c:
946 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
947 (libmodest_dbus_client_open_message):
948 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
950 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
951 body without crashing.
953 * tests/dbus_api/Makefile.am:
954 * tests/dbus_api/test_mail_to.c:
955 * tests/dbus_api/test_open_message.c: New tests for the new methods.
957 2007-04-24 Murray Cumming <murrayc@murrayc.com>
959 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
960 Added file to fix the build. Sorry.
962 * src/dbus_api/Makefile.am:
963 * src/dbus_api/modest-dbus-api.h:
964 * src/dbus_api/modest-dbus-callbacks.h:
965 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
966 (modest_dbus_req_handler):
967 Put constants in a separate header so it can be reused by the
968 client library, without duplication
970 * libmodest-dbus-client/Makefile.am:
971 * libmodest-dbus-client/libmodest-dbus-client.c:
972 (libmodest_dbus_client_call_helloworld),
973 (libmodfest_dbus_client_send_mail),
974 (libmodfest_dbus_client_mailto),
975 (libmodfest_dbus_client_open_message):
976 * libmodest-dbus-client/libmodest-dbus-client.h:
977 (Partly) Implement a send_mail D-Bus method.
979 * tests/dbus_api/Makefile.am:
980 * tests/dbus_api/test_send_mail.c: (main): Added a test for
981 the send_email D-Bus method.
983 2007-04-24 Murray Cumming <murrayc@murrayc.com>
987 * libmodest-dbus-client/Makefile.am:
988 * libmodest-dbus-client/libmodest-dbus-client.c:
989 * libmodest-dbus-client/libmodest-dbus-client.h:
990 * tests/dbus_api/Makefile.am:
991 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
992 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
994 2007-04-24 Murray Cumming <murrayc@murrayc.com>
996 * src/maemo/easysetup/modest-easysetup-wizard.c:
997 (create_page_account_details):
998 * src/maemo/modest-account-settings-dialog.c:
999 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1000 widgets, because this might not be the default in future versions of the Maemo GTK+.
1001 However, I can not not get capitalization to work even in a simple test case.
1003 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1005 * src/maemo/easysetup/modest-easysetup-wizard.c:
1006 (create_page_custom_incoming), (create_page_custom_outgoing):
1007 * src/maemo/modest-account-settings-dialog.c:
1008 (create_page_account_details), (create_page_incoming),
1009 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1010 instead of using gtk_check_button_with_label(), so they are aligned like the other
1011 widgets, as per the UI spec.
1013 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1015 * src/maemo/easysetup/modest-easysetup-wizard.c:
1016 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1017 * src/widgets/modest-validating-entry.c:
1018 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1019 Modest prefix instead of an EasySetup prefix.
1021 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1023 * src/widgets/modest-validating-entry.h:
1024 * src/widgets/modest-validating-entry.c: (on_insert_text),
1025 Added easysetup_validating_entry_set_max_func(), used to set a callback
1026 to call when the max number of characters is reached. GtkEntry has a max-length
1027 already but is silent about it.
1029 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1030 (create_page_account_details), (create_page_user_details),
1032 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1033 (create_page_account_details), (create_page_user_details),
1034 (create_page_outgoing):
1035 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1036 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1037 the UI spec, when the user tries to enter more than the max number of characters.
1039 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/easysetup/modest-easysetup-wizard.c:
1042 (create_page_user_details), (create_page_custom_incoming),
1043 (create_page_custom_outgoing):
1044 * src/maemo/modest-account-settings-dialog.c:
1045 (create_page_user_details), (create_page_incoming),
1046 (create_page_outgoing):
1047 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1048 (modest_connection_specific_smtp_edit_window_init):
1049 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1050 not appropriate. Bad Maemo-specific defaults!.
1052 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1054 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1055 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1056 (modest_signature_editor_dialog_set_settings):
1057 Disable the label and textview when the checkbox is disabled, and use the
1058 specified (UI spec) default signature text.
1060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1063 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1065 * src/modest-defs.h:
1066 * src/modest-account-mgr-helpers.h:
1067 * src/modest-account-mgr-helpers.c:
1068 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1070 * src/maemo/Makefile.am:
1071 * src/maemo/modest-signature-editor-dialog.c:
1072 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1075 * src/maemo/modest-account-settings-dialog.h:
1076 * src/maemo/modest-account-settings-dialog.c:
1077 (modest_account_settings_dialog_finalize), (on_button_signature),
1078 (save_configuration): Use the new dialog when the Edit button is pressed, and
1079 save the changes if necessary, as per the UI spec.
1081 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1083 * src/maemo/Makefile.am:
1084 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1085 based on maemo-develoers email from Dirk.
1087 * src/maemo/easysetup/modest-easysetup-wizard.c:
1088 (create_page_welcome), (create_page_account_details),
1089 (create_page_user_details), (create_page_complete_easysetup),
1090 (create_page_custom_incoming), (create_page_custom_outgoing),
1091 (create_page_complete_custom),
1092 (modest_easysetup_wizard_dialog_init):
1093 * src/maemo/modest-account-settings-dialog.c:
1094 (create_page_account_details), (create_page_user_details),
1095 (create_page_incoming), (create_page_outgoing),
1096 (modest_account_settings_dialog_init):
1097 * src/maemo/modest-connection-specific-smtp-window.c:
1098 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1100 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/easysetup/modest-easysetup-wizard.c:
1103 (create_page_account_details), (create_page_custom_outgoing),
1104 (create_page_complete_custom):
1105 * src/maemo/modest-account-settings-dialog.c:
1106 (create_page_user_details), (create_page_incoming),
1107 (create_page_outgoing):
1108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1109 (modest_connection_specific_smtp_edit_window_init):
1110 Use the correct (UI spec) port min/max, and use horizontal separators,
1113 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1115 * src/maemo/easysetup/modest-easysetup-wizard.c:
1116 (set_default_custom_servernames):
1117 * src/maemo/modest-account-settings-dialog.c:
1118 (create_page_incoming), (on_combo_outgoing_security_changed),
1119 (on_combo_incoming_security_changed), (create_page_outgoing),
1120 (modest_account_settings_dialog_set_account_name),
1121 (save_configuration):
1122 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1123 (on_combo_security_changed),
1124 (modest_connection_specific_smtp_edit_window_init),
1125 (modest_connection_specific_smtp_edit_window_set_connection),
1126 (modest_connection_specific_smtp_edit_window_get_settings):
1127 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1130 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1133 * src/maemo/easysetup/modest-easysetup-wizard.c:
1134 (create_page_custom_outgoing), (create_page_complete_custom):
1135 * src/maemo/modest-account-settings-dialog.c:
1136 (create_page_user_details), (create_page_outgoing):
1137 * src/maemo/modest-account-view-window.c: (button_box_new):
1138 Use changed logical IDs as per the most recent UI spec:
1139 mcen_bd_emailsetup_edit -> mcen_bd_edit
1140 mcen_bd_emailsetup_delete -> mcen_bd_delete
1141 mcen_bd_emailsetup_close -> mcen_bd_close
1143 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1147 * src/dbus_api/Makefile.am:
1148 * src/dbus_api/modest-dbus-callbacks.c:
1149 * src/dbus_api/modest-dbus-callbacks.h:
1150 * src/maemo/modest-platform.c: (modest_platform_init):
1151 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1153 * tests/Makefile.am:
1154 * tests/dbus_api/Makefile.am:
1155 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1157 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1159 * src/maemo/modest-account-settings-dialog.c:
1160 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1161 Removed unnecessary includes.
1163 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1165 * src/maemo/easysetup/modest-easysetup-wizard.c:
1166 * src/maemo/modest-account-settings-dialog.c:
1167 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1168 * src/widgets/Makefile.am:
1169 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1170 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1171 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1172 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1173 * src/widgets/modest-secureauth-combo-box.c:
1174 * src/widgets/modest-secureauth-combo-box.h:
1175 * src/widgets/modest-serversecurity-combo-box.c:
1176 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1177 made the GObject names more consistent with the rest of the Modest code.
1179 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1181 * src/maemo/easysetup/Makefile.am:
1182 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1183 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1184 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1185 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1186 * src/maemo/easysetup/modest-easysetup-wizard.c:
1187 * src/maemo/easysetup/modest-validating-entry.c:
1188 * src/maemo/easysetup/modest-validating-entry.h:
1189 * src/maemo/modest-account-settings-dialog.c:
1190 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1191 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1192 widgets/ because they are used outside of easysetup too. After checking in,
1193 svn will allow me to rename them too.
1195 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1197 * src/gnome/modest-msg-edit-window.c:
1198 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1199 linker error, to fix the build on the GNOME platform.
1200 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1201 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1202 ifdefed out to avoid a warning.
1204 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1206 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1207 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1208 some alternative for GTK+ 2.6.
1210 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1214 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1215 specified for EmailAccountsDialog in UI spec.
1217 * src/maemo/easysetup/modest-easysetup-wizard.c:
1218 * src/maemo/easysetup/modest-easysetup-wizard.h:
1219 * src/maemo/modest-account-settings-dialog.c:
1220 * src/maemo/modest-account-settings-dialog.h:
1221 Reuse a member window widget for the connection-specific SMTP server accounts,
1222 so we can tell it to create/save the accounts only if we actually save changes.
1224 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1225 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1226 (modest_connection_specific_smtp_edit_window_get_settings):
1227 Return a struct instance for temporarily remembering the entered data.
1229 * src/maemo/modest-connection-specific-smtp-window.h:
1230 * src/maemo/modest-connection-specific-smtp-window.c:
1231 (modest_connection_specific_smtp_window_finalize),
1232 (modest_connection_specific_smtp_window_fill_with_connections),
1234 (modest_connection_specific_smtp_window_save_server_accounts),
1235 (update_model_server_names): Do not actually save data until asked,
1236 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1238 (on_selection_changed),
1239 (modest_connection_specific_smtp_window_init): Disable the edit
1240 button when nothing is selected.
1242 * src/modest-account-mgr-helpers.c:
1243 * src/modest-account-mgr-helpers.h:
1244 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1247 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1249 * src/modest-account-mgr-helpers.h:
1250 * src/modest-account-mgr-helpers.c:
1251 (modest_account_mgr_get_unused_account_name),
1252 (modest_account_mgr_get_unused_account_display_name): Added these
1253 utility functions, to avoid code duplication.
1255 * src/maemo/easysetup/modest-easysetup-wizard.c:
1256 (create_page_account_details), (create_account):
1257 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1258 (on_combo_security_changed),
1259 (modest_connection_specific_smtp_edit_window_init),
1260 (modest_connection_specific_smtp_edit_window_save_settings):
1261 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1262 * src/maemo/modest-connection-specific-smtp-window.c:
1263 (modest_connection_specific_smtp_window_finalize),
1264 (modest_connection_specific_smtp_window_fill_with_connections),
1265 (on_button_edit), (modest_connection_specific_smtp_window_init):
1266 * src/maemo/modest-connection-specific-smtp-window.h:
1267 Implementing saving of connection-specific server accounts.
1269 But I need to refactor this so we can save the data for each
1270 possible connection-specific account and only actually create the server accounts
1271 when the easysetup finished, or the OK button is pressed on the account settings
1274 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1277 (on_combo_security_changed):
1278 (modest_connection_specific_smtp_edit_window_init):
1279 Auto-fill the port number as in the account settings.
1281 (modest_connection_specific_smtp_edit_window_set_connection):
1282 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1283 * src/maemo/modest-connection-specific-smtp-window.c:
1284 (fill_with_connections), (on_button_edit),
1285 (modest_connection_specific_smtp_window_init):
1286 Turn the edit window into a dialog to simplify the code, and
1287 set a WM hint as in a GtkDialog, because only a popup can be on top of
1288 another window in Maemo, and popups usually have no WM decoration.
1290 * src/modest-defs.h:
1291 * src/modest-account-mgr-helpers.c:
1292 (modest_account_mgr_set_connection_specific_smtp),
1293 (modest_account_mgr_remove_connection_specific_smtp),
1294 (modest_account_mgr_get_connection_specific_smtp):
1295 * src/modest-account-mgr-helpers.h: Some functions to write the
1296 connection-specific SMTP server information. Not yet used.
1299 * src/widgets/modest-folder-view.c: (text_cell_data):
1300 Fix a warning about an uninitialized variable.
1301 (on_configuration_key_changed): Put an #ifdef around the use
1302 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1304 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1306 * src/maemo/modest-account-settings-dialog.h:
1307 * src/maemo/modest-account-settings-dialog.c:
1308 Added connect_for_modified() utility function to mark the new modified boolean.
1310 (create_page_account_details), (create_page_user_details),
1311 (create_page_incoming), (create_page_outgoing), (on_response),
1312 (modest_account_settings_dialog_init),
1313 (modest_account_settings_dialog_set_account_name):
1314 Only warn about unsaved changes when there are actually unsaved changes.
1316 * src/modest-account-mgr-helpers.c:
1317 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1318 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1319 to get the data from there in future.
1321 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-defs.h:
1325 * src/modest-account-mgr-helpers.h:
1326 * src/modest-account-mgr-helpers.c:
1327 Store the security account setting in a single conf key instead of using
1328 the options list, so that the list is left for just the to-be-removed camel hack,
1329 and because gconf_client_set_list() is failing for some reason.
1331 * src/modest-account-mgr.c:
1332 (modest_account_mgr_add_server_account):
1333 * src/maemo/modest-account-settings-dialog.c:
1334 (modest_account_settings_dialog_set_account_name),
1335 (save_configuration): Use the renamed functions.
1338 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1340 * src/widgets/Makefile.am:
1341 * src/widgets/modest-limit-retrieve-combo-box.c:
1342 * src/widgets/modest-limit-retrieve-combo-box.h:
1343 * src/widgets/modest-retrieve-combo-box.c:
1344 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1345 the account settings dialog.
1347 * src/modest-defs.h:
1348 * src/modest-account-mgr-helpers.h:
1349 * src/modest-account-mgr-helpers.c:
1350 (modest_server_account_get_option_secure_auth),
1351 (modest_server_account_set_option_secure_auth):
1352 * src/modest-account-mgr.c:
1353 (modest_account_mgr_add_server_account):
1354 Use the existing AUTH_MECH conf key for the secure-auth setting,
1355 instead of putting it in the list options, because this was actually used already.
1357 * src/maemo/modest-account-settings-dialog.c:
1358 (create_page_account_details),
1359 (modest_account_settings_dialog_set_account_name),
1360 (save_configuration):
1361 * src/maemo/modest-account-settings-dialog.h:
1362 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1363 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1365 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1367 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1368 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1369 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1371 * src/modest-defs.h:
1372 * src/maemo/modest-account-settings-dialog.c:
1373 (create_page_incoming), (on_combo_outgoing_security_changed),
1374 (on_combo_incoming_security_changed), (create_page_outgoing),
1375 (modest_account_settings_dialog_set_account_name),
1376 (save_configuration): Load/Save the port number, and change it when the
1377 security combo changes, to suitable defaults.
1379 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1381 * src/modest-account-mgr.c:
1382 (modest_account_mgr_add_server_account): Set the security and secure-auth
1383 options, and add a comment saying that the other camel-specific options should be
1386 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1388 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1390 * src/modest-tny-account-store.c: (account_list_free),
1391 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1392 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1395 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1397 * src/modest-protocol-info.c:
1398 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1399 is required by our UI spec. Maybe something in our implementation will use this eventually.
1400 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1401 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1402 instead of the previous 0 placeholder.
1404 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1405 secure-auth settings.
1406 * src/modest-account-mgr-helpers.h:
1407 * src/modest-account-mgr-helpers.c:
1408 (modest_server_account_data_get_option_secure_auth),
1409 (modest_server_account_set_option_secure_auth),
1410 (modest_server_account_data_get_option_security),
1411 (modest_server_account_set_option_security): Added this API for getting and setting the security
1412 and secure-auth settings.
1414 * src/maemo/modest-account-settings-dialog.h:
1415 * src/maemo/modest-account-settings-dialog.c:
1416 (modest_account_settings_dialog_finalize), (check_data),
1417 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1418 about changing titles.
1419 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1420 (save_configuration): Save the security and secure-auth settings.
1422 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1423 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1425 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-defs.h:
1428 * src/modest-account-mgr.c:
1429 (modest_account_mgr_add_server_account):
1430 Added and used defines for the options key and value pair strings,
1431 that are used so far, though they do not seem to correspond to anything in our
1432 UI specs or ModestProtocol enum.
1434 * src/modest-account-mgr-helpers.h:
1435 * src/modest-account-mgr-helpers.c:
1436 (compare_option_strings_for_name),
1437 (modest_server_account_data_get_option_value),
1438 (modest_server_account_data_get_option_bool),
1439 (modest_account_mgr_get_server_account_option):
1440 Added helper functions for parsing the options GSList.
1442 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1445 display name is based on the supplied account name.
1446 * src/modest-account-mgr.c:
1447 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1448 with an inefficient, but good-enough, implementation.
1450 * src/maemo/easysetup/modest-easysetup-wizard.c:
1451 (create_page_account_details), (on_before_next), (create_account):
1452 Check for existing display names rather than (non-user-visible) account names, and just
1453 create and set a unique account name at the end.
1455 * src/maemo/modest-account-settings-dialog.c:
1456 (modest_account_settings_dialog_init),
1457 (modest_account_settings_dialog_set_account_name),
1458 (create_page_incoming): Show the display name, instead of the account name.
1459 (on_response): Do some (not all) extra checks, as in the UI spec.
1460 (save_configuration): Save the display name if it was changed.
1462 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1464 * po/en_GB.po: Added needed logical ID and translation.
1465 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1466 (init_view): Made the is-default column clicking work.
1468 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1471 * src/maemo/easysetup/Makefile.am:
1472 * src/maemo/easysetup/modest-easysetup-wizard.c:
1473 (modest_easysetup_wizard_dialog_init):
1474 * src/maemo/easysetup/provider-data-test.keyfile:
1475 * src/maemo/easysetup/provider-data.keyfile:
1476 Moved the provider data file to the new modest-providers-data package and used it from there.
1478 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1480 * src/modest-local-folder-info.c:
1481 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1482 N_() was already used on the static strings, but this just marks it for translation without
1483 using the translation.
1485 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1487 * src/maemo/modest-account-settings-dialog.c:
1488 (create_page_incoming),
1489 (modest_account_settings_dialog_set_account_name):
1490 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1491 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1492 I will do this if nobody else gets there first.
1494 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1496 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1497 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1498 save the security stuff.
1500 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1502 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1503 Set the email address and user fullname, which I now see must be
1506 * src/maemo/modest-account-settings-dialog.h:
1507 * src/maemo/modest-account-settings-dialog.c:
1509 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1510 leave-on-server and authentication.
1511 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1514 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1517 * src/maemo/modest-account-settings-dialog.c:
1518 * src/maemo/modest-account-settings-dialog.h:
1519 Most (but not all) of the widgets are now present as specified by the UI spec.
1520 No changes are yet saved, and some details are not properly shown yet.
1522 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1524 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1526 * src/maemo/Makefile.am:
1527 * src/maemo/modest-account-settings-dialog.c:
1528 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1529 an existing account. Doesn't do much yet.
1531 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1532 Open the accounts settings dialog when Edit is clicked.
1534 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1536 * src/maemo/easysetup/Makefile.am:
1537 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1539 * src/maemo/easysetup/modest-easysetup-wizard.c:
1540 (modest_easysetup_wizard_dialog_init):
1541 Try to get the source directory from the build system,
1542 instead of hard-coding "./" into the source code, when opening our local
1543 copies of the configuration files.
1544 But this still fails when opening the wizard from the Accounts window,
1545 maybe because the working directory seems to change at runtime.
1546 So the wizard will fail the second time unless you copy the files into their
1547 proper locations - see the stdout warnings for the paths.
1549 (create_page_account_details),(on_before_next):
1550 Check for existing non-server accounts instead of server accounts,
1551 so the default account name is useful again, and to prevent trying to
1554 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1555 Show the wizard when New is clicked.
1557 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1558 (init_view): Show the column headers, and show the columns that are
1559 specified in the UI specs. However, something in Maemo's GTK+ prevents
1560 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1561 change the default account. This is despite unsetting the special properties.
1563 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1565 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1566 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1567 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1568 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1569 to make that clearer.
1570 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1572 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1574 * src/maemo/modest-account-view-window.c:
1575 (modest_account_view_window_init),
1576 (modest_account_view_window_new):
1577 Use the same buttons as specified in the
1578 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1579 the existing widgets, which never had a chance of working.
1580 Put the ModestAccountView treeview in a scrolled window.
1581 Do not repeat the initialization in both _init() and _new().
1583 * src/widgets/modest-account-view.c: (update_account_view):
1584 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1585 this widget and window shows no accounts.
1587 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1589 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1591 * src/maemo/easysetup/modest-easysetup-wizard.c:
1592 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1593 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1594 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1597 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1598 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1599 accounts exist yet, as in the UI spec.
1601 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1603 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1605 * src/maemo/Makefile.am:
1606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1607 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1608 New window for editing connection-specific smtp details.
1609 Not fully implemented.
1611 * src/maemo/modest-connection-specific-smtp-window.c:
1612 (modest_connection_specific_smtp_window_finalize) :
1613 unref the tree model.
1614 (on_button_edit): Show the edit window.
1616 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1618 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1621 * src/maemo/Makefile.am:
1622 * src/maemo/modest-connection-specific-smtp-window.c:
1623 * src/maemo/modest-connection-specific-smtp-window.h:
1624 New window for showing the list of connections, for connection-specific
1625 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 (create_page_custom_outgoing): Show the new window when the button is clicked.
1629 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1631 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1632 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1633 * src/maemo/modest-msg-edit-window.c:
1634 (modest_msg_edit_window_insert_image):
1635 * src/modest-conf.c: (modest_conf_key_escape):
1636 * src/modest-mail-operation.c:
1637 (modest_mail_operation_send_new_mail):
1638 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1639 (modest_ui_actions_on_new_account):
1640 * src/widgets/modest-attachment-view.c: (update_filename_request):
1641 * src/widgets/modest-mail-header-view.c:
1642 Corrected warnings that were breaking the build, by commenting out unused variables,
1643 and a function, and by including a header.
1645 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1647 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1648 so we can #ifdef around platform-specific code when necessary.
1649 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1650 to allow this to build for the GNOME platform too.
1652 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/easysetup/modest-easysetup-wizard.c:
1655 Added util_increment_name() and used it in create_page_account_details()
1656 to make sure that the default account name is always a new name.
1658 (modest_easysetup_wizard_dialog_init),
1659 (set_default_custom_servernames): Some minor memory management fixes.
1661 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1665 * src/modest-runtime.c: (init_i18n): Restored the translation
1666 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1667 are defined in config.h, and the translations are installed.
1669 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1670 is defined for translation.
1672 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1676 * src/maemo/easysetup/modest-easysetup-wizard.c:
1677 (modest_easysetup_wizard_dialog_init):
1678 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1679 Use realistic paths (though they should use $prefix generically) to the
1680 mcc_mapping and provider-data.keyfile files which might work when they
1681 are installed by the future version of the operator-wizard package,
1682 and then fallback to paths in our source code, with an explanatory
1685 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1689 * src/maemo/Makefile.am:
1690 * src/maemo/easysetup/: Added files from the previously-exernal
1691 osso-modest-easysetup.
1692 * src/maemo/modest-main-window-ui.h:
1693 * src/modest-ui-actions.c:
1694 * src/modest-ui-actions.h:
1695 Added modest_ui_actions_on_new_account() as a signal handler for the
1696 New Account menu item. It shows the easysetup wizard.
1697 * po/en_GB.po: Added additional needed logical IDs and translations.
1699 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1700 Apparently ChangeLog is not used for some vague Nokia legal reasons.