1 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c:
4 (create_page_account_details),
5 (modest_account_settings_dialog_set_account_name):
6 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
7 for the leave-on-server checkbox, rathr than just the checkbox, when
8 the protocol is not POP.
10 2007-05-17 Murray Cumming <murrayc@murrayc.com>
12 * src/widgets/modest-account-view.c:
13 * src/widgets/modest-account-view.h:
14 Added modest_account_view_select_account() which will be useful later
15 to asynchronously re-select the edited account.
17 2007-05-17 Murray Cumming <murrayc@murrayc.com>
19 * src/maemo/modest-account-settings-dialog.c:
20 (modest_account_settings_dialog_set_account_name):
21 Automatically choose the port numbers based on the secure authentication
22 methods, if they have not been chosen before.
23 This fixes projects.maemo.org bug NB#56273 .
25 2007-05-17 Murray Cumming <murrayc@murrayc.com>
27 * src/maemo/modest-main-window-ui.h:
28 * src/modest-ui-actions.c:
29 * src/modest-ui-actions.h:
30 Connect the Tools/SMTP Servers menu item to
31 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
32 SMTP servers dialog, as in the UI specification and saves changes when it
33 is closed. This fixed projects.maemo.org bug NB#56305 .
35 2007-05-17 Murray Cumming <murrayc@murrayc.com>
37 * src/maemo/modest-connection-specific-smtp-window.c:
38 (modest_connection_specific_smtp_window_init):
39 Use gtk_window_set_default_size() to make this window big enough, so
40 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
42 2007-05-17 Murray Cumming <murrayc@murrayc.com>
44 * src/maemo/modest-connection-specific-smtp-edit-window.h:
45 * src/maemo/modest-connection-specific-smtp-edit-window.c:
46 (modest_connection_specific_smtp_edit_window_init),
47 Do not try to connect to a combobox signal before the combobox exists.
48 This fixes the cras in projects.maemo.org bug NB#56288 .
49 (modest_connection_specific_smtp_edit_window_get_settings):
50 Remove the server_account_name parameter which was being checked for NULL
51 though it was not used.
53 * src/maemo/modest-connection-specific-smtp-window.c:
54 (modest_connection_specific_smtp_window_fill_with_connections),
55 (on_button_edit), (modest_connection_specific_smtp_window_init):
56 Correct the number of treemodel columns to prevent a warning.
57 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
58 libconic does not work.
60 2007-05-16 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-tny-account.c:
63 (modest_tny_account_new_from_server_account):
64 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
65 SMTP when "None" was chosen by the user. However, with my SMTP server that
66 does not support ANONYMOUS, the emails do not leave the Outbox and I see
69 2007-05-16 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
72 to explain the memory management issue with the ID in the ModestPair.
74 * src/gnome/modest-account-assistant.c: (add_receiving_page),
75 (add_sending_page), (modest_account_assistant_finalize):
76 * src/gnome/modest-gnome-global-settings-dialog.c:
77 (create_updating_page), (create_composing_page):
78 * src/gnome/modest-msg-edit-window.c: (get_transports),
79 (init_window), (modest_msg_edit_window_finalize),
80 (modest_msg_edit_window_get_msg_data):
81 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
82 * src/gnome/modest-transport-widget.c:
83 (modest_transport_widget_finalize), (smtp_configuration):
84 * src/maemo/modest-maemo-global-settings-dialog.c:
85 (create_updating_page), (create_composing_page):
86 * src/maemo/modest-msg-edit-window.c: (get_transports),
87 (init_window), (modest_msg_edit_window_finalize),
88 (modest_msg_edit_window_get_msg_data),
89 (modest_msg_edit_window_free_msg_data):
90 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
91 (modest_store_widget_finalize):
92 * src/maemo/modest-transport-widget.c:
93 (modest_transport_widget_finalize), (smtp_configuration):
94 * src/modest-main.c: (send_mail):
95 * src/widgets/modest-combo-box.h:
96 * src/widgets/modest-global-settings-dialog-priv.h:
97 * src/widgets/modest-global-settings-dialog.c:
98 (modest_global_settings_dialog_finalize):
99 * src/widgets/modest-msg-edit-window.h:
100 Whenever using modest_combo_box_new(), keep the ModestPairList alive
101 as long as the combo box, to prevent use of freed memory for the ID.
103 2007-05-15 Murray Cumming <murrayc@murrayc.com>
105 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
106 get_accounts(), to make this clearer. Do not check for the enabled gconf
107 key, because we do not use this for server accounts (at least, not yet).
108 This allows us to send email again.
110 2007-05-15 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/modest-platform.c:
113 (on_modest_conf_update_interval_changed), (modest_platform_init):
114 Only respond to this particular key change. All these strcmp()s cannot be
117 2007-05-15 Murray Cumming <murrayc@murrayc.com>
119 * src/maemo/modest-maemo-global-settings-dialog.c:
120 (current_connection): Prevent a crash in scratchbox when
121 ny_maemo_conic_device_get_current_iap_id() returns NULL.
122 * src/maemo/modest-platform.c:
123 (on_modest_conf_update_interval_changed), (modest_platform_init):
124 Get the update interval from gconf and reset it when the gconf key changes.
126 2007-05-15 Murray Cumming <murrayc@murrayc.com>
128 * src/modest-protocol-info.c:
129 * src/modest-protocol-info.h: Adde enum-specific get functions,
130 instead of using a ModestProtocolType enum parameter.
132 * src/gnome/modest-account-assistant.c:
133 * src/gnome/modest-store-widget.c:
134 * src/gnome/modest-store-widget.h:
135 * src/gnome/modest-transport-widget.c:
136 * src/gnome/modest-transport-widget.h:
137 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
138 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
139 * src/maemo/easysetup/modest-easysetup-wizard.c:
140 * src/maemo/modest-account-settings-dialog.c:
141 * src/maemo/modest-account-settings-dialog.h:
142 * src/maemo/modest-store-widget.c:
143 * src/maemo/modest-store-widget.h:
144 * src/maemo/modest-transport-widget.c:
145 * src/maemo/modest-transport-widget.h:
146 * src/modest-account-mgr-helpers.c:
147 * src/modest-account-mgr-helpers.h:
148 * src/modest-account-mgr.c:
149 * src/modest-account-mgr.h:
150 * src/modest-tny-account.c:
151 * src/modest-tny-folder.c:
152 * src/widgets/modest-account-view.c:
153 * src/widgets/modest-retrieve-combo-box.c:
154 * src/widgets/modest-retrieve-combo-box.h:
155 * src/widgets/modest-secureauth-combo-box.c:
156 * src/widgets/modest-serversecurity-combo-box.c:
157 * src/widgets/modest-serversecurity-combo-box.h:
158 * tests/check_account-mgr.c:
159 Use the specific functions, and use the re-renamed enum values for GNOME too.
161 2007-05-15 Murray Cumming <murrayc@murrayc.com>
164 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
165 so we can get the second based on the first.
167 * src/maemo/modest-account-settings-dialog.h:
168 * src/maemo/modest-account-settings-dialog.c:
169 Added get_supported_secure_authentication_methods(), though it is mostly
170 commented-out for now until the necessary API is committed to tinymail.
171 (modest_account_settings_dialog_set_account_name),
172 (save_configuration): Request the supported authentication methods from the
173 server, so we can choose a working method.
175 * src/modest-tny-account-store.h:
176 * src/modest-tny-account-store.c:
177 (modest_tny_account_store_get_session): Rename from
178 tny_account_store_get_session().
180 2007-05-14 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-protocol-info.h: Split the ModestProtocol enum
183 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
184 There was no need to have these unrelated values in one enum.
186 * src/: many files: Adapted to changed enum. This makes the code a bit
187 clearer, and the compiler could catch some errors.
189 2007-05-14 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
192 Show the detailed internal camel error message when an error happens
193 during the configuration, so that our testers can give us more clues.
194 For instance, in projects.maemo.org bug NB#56910 .
196 2007-05-14 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account.c:
199 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
200 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
202 2007-05-14 Murray Cumming <murrayc@murrayc.com>
204 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
205 * src/maemo/modest-account-settings-dialog.c:
206 (modest_account_settings_dialog_set_account_name),
207 (save_configuration): For the incoming secure authentication checkbox,
208 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
209 the UI specification. PLAIN does not seem to be supported for most IMAP
210 servers anyway, and I am not sure what it would mean.
211 However, we probably need to discover which of the secure-authentication
212 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
213 * src/modest-account-mgr-helpers.c:
214 (modest_account_mgr_get_server_account_data):
216 * src/modest-tny-account.c:
217 (modest_tny_account_new_from_server_account):
218 Use tny_account_set_mech() to set secure-authentication methods,
219 with some special-casing for IMAP, based on my observations of how
222 * src/modest-account-mgr-helpers.h:
223 * src/modest-account-mgr.c:
224 * src/modest-defs.h: Comment that the URI is only used for local folders.
226 2007-05-11 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
229 parameter const, just to be neat.
230 * src/modest-text-utils.c: (modest_text_utils_inline):
231 End g_strconcat() with NULL, as its documentation says. This is almost
232 certainly the cause of my crash at startup on the device. Interestingly,
233 valgrind doesn't tell us about these errors.
235 2007-05-11 Murray Cumming <murrayc@murrayc.com>
237 * scripts/build-packages: Added more precise comments about how to use
238 this script, though I still get this error:
239 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
240 error building tinymail
242 2007-05-11 Murray Cumming <murrayc@murrayc.com>
244 * src/maemo/modest-main-window.c: (on_account_update):
245 Very slight cleanup, hoping to make it simpler to discover what causes
246 a crash here sometimes.
248 * src/modest-tny-account.c:
249 (modest_tny_account_new_from_server_account): Set the port. Added
250 comments about the options and a TODO comment because I need to find out
251 how to specify the secure authentication method.
253 2007-05-11 Marcus Bauer <marcusb@openismus.com>
255 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
256 changed CFlags paths form modest to libmodest
258 2007-05-10 Murray Cumming <murrayc@murrayc.com>
260 * src/modest-account-mgr-helpers.c:
261 (modest_account_mgr_get_server_account_data),
262 (modest_account_mgr_free_server_account_data):
263 * src/modest-account-mgr-helpers.h:
264 * src/modest-account-mgr.c:
265 (modest_account_mgr_add_server_account):
267 * src/modest-tny-account.c:
268 (modest_tny_account_new_from_server_account):
269 Determine the options for tny_camel_account_add_option() here,
270 based on the settings, rather than storing them directly in gconf.
272 2007-05-10 Murray Cumming <murrayc@murrayc.com>
274 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
275 Show a more friendly error dialog now that we expect (from the tinymail
276 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
278 2007-05-10 Murray Cumming <murrayc@murrayc.com>
280 * src/maemo/modest-main-window.c: (on_account_update): Check that
281 account_name is not NULL, to prevent a crash at startup that I am
282 seeing on the N800. I do wonder why it is NULL.
284 * src/maemo/easysetup/modest-easysetup-wizard.c:
285 (create_page_user_details):
286 * src/maemo/modest-account-settings-dialog.c:
287 (create_page_user_details), (create_page_outgoing):
288 * src/maemo/modest-connection-specific-smtp-edit-window.c:
289 (modest_connection_specific_smtp_edit_window_init):
290 * src/modest-ui-actions.c:
291 (modest_ui_actions_on_password_requested):
292 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
293 might do something useful with the on-screen keyboard.
295 2007-05-10 Murray Cumming <murrayc@murrayc.com>
297 * src/maemo/modest-main-window.c: (on_account_update):
298 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
299 NULL, to avoid lots of warnings. However, it probably should not be NULL.
301 2007-05-09 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-tny-account-store.c: (on_account_changed):
304 Correct the signature of this signal handler.
306 2007-05-09 Murray Cumming <murrayc@murrayc.com>
308 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
309 Show a HildonNote instead of a GtkDialog for Maemo.
311 2007-05-09 Murray Cumming <murrayc@murrayc.com>
313 * src/widgets/modest-account-view.h:
314 * src/widgets/modest-account-view.c: (on_account_changed),
315 (on_account_removed). Added a boolean flag, set/unset by
316 modest_account_view_block_conf_updates(),
317 modest_account_view_unblock_conf_updates() to prevent unnecessary
318 updates, but this is not very useful because the gconf notifications are
319 so delays (maybe only on Maemo Bora).
320 So auto-updating is turned off, and these functions do an explicit
321 update when necessary.
322 However, something else is still doing too much work when adding/removing
323 accounts, probably in another part of the application.
325 * src/maemo/modest-account-view-window.c:
326 (on_delete_button_clicked), (on_edit_button_clicked),
327 (on_new_button_clicked): Use the new functions.
329 2007-05-09 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-account-mgr-helpers.c:
332 (modest_account_mgr_set_first_account_as_default):
333 Sort the list of names alphabetically-by-title, so we choose the first one
335 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
336 alphabetically by the title.
338 This fixes projects.maemo.org bug NB#56418 .
340 * src/modest-account-mgr-priv.c:
341 (_modest_account_mgr_account_from_key):
342 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
343 avoid a valgrind error, and possible random behaviour.
345 2007-05-09 Murray Cumming <murrayc@murrayc.com>
347 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
348 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
349 tinymail documentation to say that this can be expected.
350 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
351 pretty, and should not happen, but I would prefer to know when it does.
353 2007-05-09 Murray Cumming <murrayc@murrayc.com>
355 * configure.ac: When using the older hildon version, probably on Bora,
356 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
358 * src/widgets/modest-attachment-view.c:
359 (modest_attachment_view_set_part_default): Initialize variables, to fix the
362 2007-05-09 Marcus Bauer <marcusb@openismus.com>
364 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
365 Implemented the prototype. Can be tested with
366 tests/dbus_api/test_open_message:
368 2007-05-08 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-tny-account-store.c:
371 (modest_tny_account_store_instance_init), (get_password):
372 * src/modest-ui-actions.c:
373 (modest_ui_actions_on_password_requested):
374 Do not store the password in gconf, because this function is called
375 for non-remembered passwords. Actually use the cached (in the hash map)
376 password instead of releasing it.
377 The password will now not be remembered if it is asked via the protected
378 password dialog, as per the UI spec.
380 2007-05-08 Murray Cumming <murrayc@murrayc.com>
383 * src/modest-account-mgr-helpers.h:
384 * src/modest-account-mgr-helpers.c:
385 Added modest_server_account_get_username_has_succeeded(),
386 modest_server_account_set_username_has_succeeded().
387 (modest_server_account_set_username),
388 Reset the has-succeeded flag if the username changes.
390 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
391 * src/maemo/modest-connection-specific-smtp-window.c:
392 (modest_connection_specific_smtp_window_save_server_accounts):
393 Use modest_server_account_set_username() instead of using
394 modest_conf_set_string() directly, so that the has-succeeded flag is always
397 * src/modest-ui-actions.c:
398 (modest_ui_actions_on_password_requested): Dim the username entry if
399 the username has ever worked, as per the UI spec.
401 2007-05-08 Murray Cumming <murrayc@murrayc.com>
403 * src/modest-tny-account-store.c: (get_password):
404 * src/modest-ui-actions.c:
405 (modest_ui_actions_on_password_requested):
406 Allow the username to be changed too, though there is more work to
407 be done on exactly how this behaves.
409 2007-05-08 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-account-mgr-helpers.h:
412 * src/modest-account-mgr-helpers.c:
413 Added modest_account_mgr_get_display_name(),
414 modest_server_account_get_username(),
415 modest_server_account_set_username(),
416 modest_server_account_set_password(),
417 modest_server_account_get_hostname() functions so we do not need to
418 use the conf API directly.
420 * src/maemo/modest-main-window.c: (connect_signals):
421 Actually connect ot the ModestAccountStore::request-password signal,
422 so that we show the dialog when the password is requested by Tinymail,
423 for isntance if it is empty.
425 * src/modest-marshal.list:
426 * src/modest-tny-account-store.c:
427 (modest_tny_account_store_class_init), (get_password),
428 (modest_tny_account_store_alert):
429 * src/modest-tny-account-store.h:
430 * src/modest-ui-actions.h:
431 * src/modest-ui-actions.c:
432 (modest_ui_actions_on_password_requested):
433 Change the signal parameters, so it is obvious that we are providing
434 the non human-readable server name, and receiving both the username
435 and password, though changing of the username is not yet implemented.
436 Change the dialog UI to match the Maemo UI specifications, with #idfefing
437 for the GNOME version.
439 This should fix the projects.maemo.org bug NB#56209, though it does not
440 work on Bora, because the gconf_client_get() for the password fails
441 immediately after we save it with gconf_client_set().
443 2007-05-08 Murray Cumming <murrayc@murrayc.com>
446 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
447 caused an undefined symbol error:
448 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
450 2007-05-08 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-tny-account-store.c:
453 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
454 using a GError instead of a string message, so we can translate it in
457 2007-05-08 Murray Cumming <murrayc@murrayc.com>
459 * src/maemo/modest-address-book.c:
460 (modest_address_book_check_names):
461 * src/maemo/modest-msg-view-window.c:
462 (modest_msg_view_window_clipboard_owner_change):
463 * src/modest-init.c: (modest_init_init_ui):
464 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
465 (update_folders_cb), (modest_mail_operation_update_account):
466 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
467 (modest_ui_actions_on_msg_attachment_clicked),
468 (modest_ui_actions_on_msg_recpt_activated):
469 * src/widgets/modest-header-view.c: (drag_data_get_cb):
470 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
471 (modest_msg_view_search_next):
472 * src/widgets/modest-recpt-editor.c:
473 (modest_recpt_editor_on_button_release_event),
474 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
475 g_message(). At this point we should only be seeing interesting errors on
476 stdout. Debugging messages could be #ifdefed-out if they are still useful.
478 2007-05-07 Murray Cumming <murrayc@murrayc.com>
480 (modest_wizard_dialog_force_title_update):
481 * src/maemo/easysetup/modest-wizard-dialog.h:
482 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
483 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
484 can update the title when appropriate. Otherwise the title is wrong if the
485 pages are added after adding the notebook to the dialog.
486 This must be a problem in HildonWizardDialog too.
487 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
489 * src/maemo/easysetup/modest-easysetup-wizard.c:
490 (create_subsequent_customsetup_pages),
491 (create_subsequent_easysetup_pages):
492 Call modest_wizard_dialog_force_title_update() so that the title is
493 correct even with GTK+ < 2.10.
494 This fixes projects.maemo.org bug NB#56145 .
496 2007-05-07 Murray Cumming <murrayc@murrayc.com>
498 * src/maemo/modest-platform.c:
499 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
500 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
503 2007-05-07 Murray Cumming <murrayc@murrayc.com>
505 * src/widgets/modest-window.h:
506 * src/widgets/modest-window.c: Added a save_state_func vfunc,
507 and modest_window_save_state(), which invokes it.
509 * src/widgets/modest-window-mgr.h:
510 * src/widgets/modest-window-mgr.c:
511 Added modest_window_mgr_save_state_for_all_windows(), which calls
512 the save_state vfunc on all registered windows, if implemented.
514 * src/gnome/modest-msg-edit-window.c:
515 * src/gnome/modest-msg-view-window.c:
516 * src/maemo/modest-msg-edit-window.c:
517 * src/maemo/modest-msg-view-window.c:
518 * src/maemo/modest-main-window.c:
519 Specify the existing save_settings functions as implementations of
520 ModestWindow::save_state_func().
522 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
523 Call modest_window_mgr_save_state_for_all_windows(). This happens before
524 enabling hibernation, for instance.
526 We may need to do the same thing for restoring settings.
529 2007-05-07 Murray Cumming <murrayc@murrayc.com>
531 * src/widgets/modest-window-mgr.c:
532 * src/widgets/modest-window-mgr.h:
533 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
534 modest_window_mgr_get_hibernation_is_prevented().
536 * src/maemo/modest-main-window.c:
537 (on_hildon_program_is_topmost_notify): Prevent hibernation
538 (possible when the application goes to the background in the WM),
539 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
541 * src/maemo/easysetup/modest-easysetup-wizard.c:
542 (modest_easysetup_wizard_dialog_init):
543 * src/maemo/modest-account-settings-dialog.c:
544 (modest_account_settings_dialog_init):
545 * src/maemo/modest-connection-specific-smtp-edit-window.c:
546 (modest_connection_specific_smtp_edit_window_init):
547 * src/maemo/modest-connection-specific-smtp-window.c:
548 (modest_connection_specific_smtp_window_init):
549 * src/maemo/modest-signature-editor-dialog.c:
550 (modest_signature_editor_dialog_init):
551 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
552 prevent hibernation while any of these account settings dialogs are open.
554 2007-05-04 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/Makefile.am:
557 * src/maemo/modest-osso-state-saving.c:
558 * src/maemo/modest-osso-state-saving.h: Added
559 modest_osso_load_state() and modest_osso_save_state() though they do
560 nothing now. They should iterate through all the open windows and load/save
562 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
563 save state when closing.
565 * src/maemo/modest-main-window.c:
566 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
567 Add a notification handler for the HildonProgram::is-topmost property,
568 so we can allow hibernation when the application goes into the background.
569 But we still need to detect when the accounts setup windows are open so
570 we can stop hibernation when they are open.
571 To do this, I also added the main window the HildonProgram. This might have
572 other side-effects/benefits, and should maybe be done for other windows.
574 * src/maemo/modest-osso-autosave-callbacks.h:
575 * src/maemo/modest-osso-autosave-callbacks.c:
576 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
577 though it does not do anything yet, and we might never need this to do
578 anything. For instance, we already save drafts.
580 * src/maemo/modest-platform.c: (modest_platform_init):
581 Specify the libosso auto-save callback.
583 2007-05-03 Murray Cumming <murrayc@murrayc.com>
585 * src/maemo/modest-platform.c:
586 (modest_platform_set_update_interval):
587 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
588 aparently stays valid between application instances, so we can use this
589 to remove and reset it later. According to a maemo-developers email from
592 2007-05-03 Murray Cumming <murrayc@murrayc.com>
594 * configure.ac: Depend on libalarm for Maemo.
596 * src/dbus_api/modest-dbus-api.h:
597 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
598 (on_send_receive), (modest_dbus_req_handler):
599 Handle a SEND_RECEIVE D-Bus method.
601 * libmodest-dbus-client/libmodest-dbus-client.c:
602 (libmodest_dbus_client_send_and_receive):
603 * libmodest-dbus-client/libmodest-dbus-client.h:
604 Add C convenience functions for calling the new D-Bus method.
606 * src/modest-platform.h:
607 * src/gnome/modest-platform.c:
608 * src/maemo/modest-platform.c:
609 Added modest_platform_set_update_interval(), which uses the
611 (modest_platform_init),
612 Call modest_platform_set_update_interval(), using a hard-coded
613 interval for now (until the global settings dialog is implemented),
614 though I am not sure that this makes sense yet.
616 2007-05-02 Murray Cumming <murrayc@murrayc.com>
618 * src/dbus_api/modest-dbus-callbacks.c:
619 (modest_osso_cb_hw_state_handler):
620 * src/dbus_api/modest-dbus-callbacks.h:
621 * src/maemo/modest-platform.c: (modest_platform_init):
622 Registered (empty) callbacks for the osso hardware state D-Bus signals,
623 in case this has some effect on the ability for Maemo to ping the
626 2007-05-02 Murray Cumming <murrayc@murrayc.com>
628 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
629 Comment out an if() that checks a gchar for < 0, causing a build-breaking
630 warning. It is probably a logic error, but I need to fix the build.
632 2007-05-02 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-account-mgr.h:
635 * src/modest-account-mgr.c:
636 (modest_account_mgr_account_names): Add a gboolean enabled_only
637 parameter, so we can get lists of onlt the enabled accounts.
639 (modest_account_mgr_add_account),,
640 (modest_account_mgr_account_with_display_name_exists):
641 * src/maemo/modest-msg-edit-window.c: (get_transports):
642 * src/modest-account-mgr-helpers.c:
643 (modest_account_mgr_set_first_account_as_default):
644 * src/modest-init.c: (init_default_account_maybe):
645 * src/modest-tny-account-store.c: (get_accounts):
646 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
647 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
648 * tests/check_account-mgr.c: (START_TEST):
649 Provide the extra parameter, as appropriate.
651 * src/widgets/modest-account-view.c: (update_account_view):
652 Do not show disabled accounts (meaning that there is no way to
653 enable/disable accounts in the UI (the feature is not in our UI
654 specification), so we can use this internally only to mark unfinished
655 or temporary account data.
657 * src/maemo/easysetup/modest-easysetup-wizard.c:
658 (create_account): Add boolean enable parameter, so we can specify FALSE
659 to create the temporary account.
660 (on_button_edit_advanced_settings): Create the temporary account as disabled.
661 (on_before_next): When finishing, when there is a temporary account, just
663 Also, use a timeout to delay the showing of the dialog until gconf is likely
664 to return correct information, due to a maemo gconf bug that is fixed in
665 osso 1.1, but not yet in Bora.
666 However, the dialog stays on screen after it is destroyed.
668 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
669 for invalid data when cancelling. Use a hildon note instead of a dialog
670 to complain about invalid data. Do not show the account-saved note if the
671 account is disabled (a temporary account that will not really be saved for use
674 2007-04-30 Murray Cumming <murrayc@murrayc.com>
676 * src/modest-account-mgr-helpers.h:
677 * src/modest-account-mgr-helpers.c:
678 Added modest_account_mgr_unset_default_account(),
679 Added modest_account_mgr_set_first_account_as_default().
681 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
682 If it was the default account, unset the default account name.
684 * src/maemo/modest-account-view-window.c:
685 (on_delete_button_clicked): If it was the default account,
686 set the first remaining account as the default instead.
688 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
689 a NULL account or a NULL default account, to prevent a crash. This should
690 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
693 2007-04-30 Murray Cumming <murrayc@murrayc.com>
695 * src/widgets/modest-recpt-editor.c:
696 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
697 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
698 TODO comment for this. This fixes the build.
700 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
701 be the best place for it. This will in future update all auto-update accounts,
702 rather than just the current/default account, when that gconf key exists.
703 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
704 if there are no accounts, before calling do_send_receive().
705 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
707 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
708 * src/maemo/modest-main-window-ui.h:
709 * src/maemo/modest-main-window.c: (on_connection_changed),
710 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
711 directly, becaue the signal handler does more.
713 2007-04-30 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-account-mgr-helpers.c:
716 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
717 for the case that the account does not exist.
719 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
720 (equivalent to the modest account name) rather than the tinymail account name
721 (equivalent to the modest account title - human readable) to get the account data.
722 Check for null account data to prevent the crash, and add a TODO comment saying that
723 this needs fixing because it is using the server account name instead of the account name.
725 2007-04-29 Murray Cumming <murrayc@murrayc.com>
727 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
728 * src/maemo/modest-account-settings-dialog.c: (show_error),
730 Use hildon_note_new_information() for informative and error messages,
731 which seems to be expected for Maemo applications (no documentation that I know of
732 says this). I am surprised that there is no distinction between info and error
735 2007-04-29 Murray Cumming <murrayc@murrayc.com>
737 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
738 it is easy to find where this is used.
740 * src/maemo/easysetup/modest-easysetup-wizard.c:
741 (create_page_welcome), (create_page_account_details),
742 (create_page_user_details), (create_page_complete_easysetup),
743 (create_page_custom_incoming), (create_page_custom_outgoing),
744 (create_page_complete_custom):
745 * src/maemo/modest-account-settings-dialog.c:
746 (create_page_account_details), (create_page_user_details),
747 (create_page_incoming), (create_page_outgoing):
748 * src/maemo/modest-account-view-window.c: (window_vbox_new):
749 * src/maemo/modest-connection-specific-smtp-edit-window.c:
750 (modest_connection_specific_smtp_edit_window_init):
751 * src/maemo/modest-connection-specific-smtp-window.c:
752 (modest_connection_specific_smtp_window_init):
753 * src/maemo/modest-signature-editor-dialog.c:
754 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
755 and scrolling policy as per the Email Application Layout Guide, if I have
758 2007-04-27 Murray Cumming <murrayc@murrayc.com>
760 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
761 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
762 which were empty, because these vfuncs have been removed from TnyAccountStore.
763 This fixes the build.
765 2007-04-27 Murray Cumming <murrayc@murrayc.com>
767 * src/maemo/modest-main-window.c:
768 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
769 showing/hiding it. Added TODO because it probably should not be NULL.
770 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
771 because unnecessary g_warnings() make degugging difficult.
773 2007-04-27 Murray Cumming <murrayc@murrayc.com>
775 * src/maemo/modest-msg-edit-window.c:
776 (modest_msg_edit_window_select_color),
777 (modest_msg_edit_window_select_background_color): 2 const corrections and
778 moving 2 #endifs before closing brackets, to fix the build.
780 2007-04-27 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/easysetup/modest-easysetup-wizard.h:
783 * src/maemo/easysetup/modest-easysetup-wizard.c:
784 (modest_easysetup_wizard_dialog_finalize),
785 (on_button_edit_advanced_settings), (create_page_complete_custom),
786 (on_response), (create_account):
787 Implement the Advanced Settings edit button, by saving the account information,
788 for the Advanded Settings dialog to use directly from gconf, and removing it
789 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
790 Bug #5533 in the projects.maemo.org bugzilla.
792 2007-04-27 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/modest-msg-view-window.c:
795 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
796 when opening a message window.
798 2007-04-27 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/easysetup/modest-easysetup-wizard.c:
801 (create_page_custom_outgoing): Correct the position of the horizontal separator to
804 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
805 before showing/hiding them, to avoid a crash when clicking on folders when there are no
806 gconf settings. I probably added more checks than necessary, but that is safer.
808 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
809 variable to fix the build, but this seems to be used when it is still NULL.
811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-platform.h:
814 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
815 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
816 * src/modest-main.c: Implement this function so we can avoid using
817 maemo-specific API from cross-platform code.
819 * src/modest-tny-account-store.c:
820 (get_smtp_specific_transport_account_for_open_connection):
821 * src/modest-ui-actions.c: (check_for_connection),
822 (modest_ui_actions_on_item_not_found):
823 Use modest_platform_connect_and_wait() and put #idefs around other
824 maemo-specific code, because only maemo currently has a way to
825 identify connection names.
827 2007-04-27 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.h:
830 * src/modest-tny-account-store.c:
831 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
832 the connection-specific SMTP server settings in the configuration.
834 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
836 * src/maemo/modest-main-window.c: (on_connection_changed),
838 * src/modest-main.c: (main), (start_ui), (send_mail):
839 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
840 that is what is intended.
842 * src/modest-ui-actions.c: (action_send), (action_receive),
843 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
844 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
845 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
846 SMTP server is used when it is specified.
848 (modest_ui_actions_on_send_receive):
849 Check that a connection is open before proceeding.
850 Receive and then send, instead of vice-versa, as per the specification.
852 2007-04-26 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-mail-operation.c:
855 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
856 though I guess it should be something other than NULL.
858 2007-04-26 Murray Cumming <murrayc@murrayc.com>
860 * src/maemo/easysetup/modest-easysetup-wizard.c:
861 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
862 combo twice, to avoid an g_warning and to make it visible again.
863 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
864 attached before detaching it, to avoid a g_warning, and add comment about the implicit
865 (already intended) dereference when detaching, because we then recreate the menu.
866 But I am not sure why the warning was happening, and it is possible that this is a memory
869 2007-04-25 Murray Cumming <murrayc@murrayc.com>
871 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
872 and uri_parse_mailto() utility functions.
873 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
875 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
877 2007-04-24 Murray Cumming <murrayc@murrayc.com>
879 * src/dbus_api/modest-dbus-api.h:
880 * src/dbus_api/modest-dbus-callbacks.c:
881 Use an idle callback to execute the modest code in the application's own thread.
882 Remove the helloworld example method.
883 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
884 parsed, and the open-message method is not implemented because this is not yet implemented in
886 * libmodest-dbus-client/libmodest-dbus-client.c:
887 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
888 (libmodest_dbus_client_open_message):
889 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
891 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
892 body without crashing.
894 * tests/dbus_api/Makefile.am:
895 * tests/dbus_api/test_mail_to.c:
896 * tests/dbus_api/test_open_message.c: New tests for the new methods.
898 2007-04-24 Murray Cumming <murrayc@murrayc.com>
900 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
901 Added file to fix the build. Sorry.
903 * src/dbus_api/Makefile.am:
904 * src/dbus_api/modest-dbus-api.h:
905 * src/dbus_api/modest-dbus-callbacks.h:
906 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
907 (modest_dbus_req_handler):
908 Put constants in a separate header so it can be reused by the
909 client library, without duplication
911 * libmodest-dbus-client/Makefile.am:
912 * libmodest-dbus-client/libmodest-dbus-client.c:
913 (libmodest_dbus_client_call_helloworld),
914 (libmodfest_dbus_client_send_mail),
915 (libmodfest_dbus_client_mailto),
916 (libmodfest_dbus_client_open_message):
917 * libmodest-dbus-client/libmodest-dbus-client.h:
918 (Partly) Implement a send_mail D-Bus method.
920 * tests/dbus_api/Makefile.am:
921 * tests/dbus_api/test_send_mail.c: (main): Added a test for
922 the send_email D-Bus method.
924 2007-04-24 Murray Cumming <murrayc@murrayc.com>
928 * libmodest-dbus-client/Makefile.am:
929 * libmodest-dbus-client/libmodest-dbus-client.c:
930 * libmodest-dbus-client/libmodest-dbus-client.h:
931 * tests/dbus_api/Makefile.am:
932 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
933 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
935 2007-04-24 Murray Cumming <murrayc@murrayc.com>
937 * src/maemo/easysetup/modest-easysetup-wizard.c:
938 (create_page_account_details):
939 * src/maemo/modest-account-settings-dialog.c:
940 (create_page_account_details): Explicitly set auto-capitalization mode for the title
941 widgets, because this might not be the default in future versions of the Maemo GTK+.
942 However, I can not not get capitalization to work even in a simple test case.
944 2007-04-24 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/easysetup/modest-easysetup-wizard.c:
947 (create_page_custom_incoming), (create_page_custom_outgoing):
948 * src/maemo/modest-account-settings-dialog.c:
949 (create_page_account_details), (create_page_incoming),
950 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
951 instead of using gtk_check_button_with_label(), so they are aligned like the other
952 widgets, as per the UI spec.
954 2007-04-24 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/easysetup/modest-easysetup-wizard.c:
957 * src/maemo/modest-connection-specific-smtp-edit-window.c:
958 * src/widgets/modest-validating-entry.c:
959 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
960 Modest prefix instead of an EasySetup prefix.
962 2007-04-23 Murray Cumming <murrayc@murrayc.com>
964 * src/widgets/modest-validating-entry.h:
965 * src/widgets/modest-validating-entry.c: (on_insert_text),
966 Added easysetup_validating_entry_set_max_func(), used to set a callback
967 to call when the max number of characters is reached. GtkEntry has a max-length
968 already but is silent about it.
970 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
971 (create_page_account_details), (create_page_user_details),
973 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
974 (create_page_account_details), (create_page_user_details),
975 (create_page_outgoing):
976 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
977 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
978 the UI spec, when the user tries to enter more than the max number of characters.
980 2007-04-23 Murray Cumming <murrayc@murrayc.com>
982 * src/maemo/easysetup/modest-easysetup-wizard.c:
983 (create_page_user_details), (create_page_custom_incoming),
984 (create_page_custom_outgoing):
985 * src/maemo/modest-account-settings-dialog.c:
986 (create_page_user_details), (create_page_incoming),
987 (create_page_outgoing):
988 * src/maemo/modest-connection-specific-smtp-edit-window.c:
989 (modest_connection_specific_smtp_edit_window_init):
990 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
991 not appropriate. Bad Maemo-specific defaults!.
993 2007-04-23 Murray Cumming <murrayc@murrayc.com>
995 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
996 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
997 (modest_signature_editor_dialog_set_settings):
998 Disable the label and textview when the checkbox is disabled, and use the
999 specified (UI spec) default signature text.
1001 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1003 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1004 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1006 * src/modest-defs.h:
1007 * src/modest-account-mgr-helpers.h:
1008 * src/modest-account-mgr-helpers.c:
1009 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1011 * src/maemo/Makefile.am:
1012 * src/maemo/modest-signature-editor-dialog.c:
1013 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1016 * src/maemo/modest-account-settings-dialog.h:
1017 * src/maemo/modest-account-settings-dialog.c:
1018 (modest_account_settings_dialog_finalize), (on_button_signature),
1019 (save_configuration): Use the new dialog when the Edit button is pressed, and
1020 save the changes if necessary, as per the UI spec.
1022 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1024 * src/maemo/Makefile.am:
1025 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1026 based on maemo-develoers email from Dirk.
1028 * src/maemo/easysetup/modest-easysetup-wizard.c:
1029 (create_page_welcome), (create_page_account_details),
1030 (create_page_user_details), (create_page_complete_easysetup),
1031 (create_page_custom_incoming), (create_page_custom_outgoing),
1032 (create_page_complete_custom),
1033 (modest_easysetup_wizard_dialog_init):
1034 * src/maemo/modest-account-settings-dialog.c:
1035 (create_page_account_details), (create_page_user_details),
1036 (create_page_incoming), (create_page_outgoing),
1037 (modest_account_settings_dialog_init):
1038 * src/maemo/modest-connection-specific-smtp-window.c:
1039 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1043 * src/maemo/easysetup/modest-easysetup-wizard.c:
1044 (create_page_account_details), (create_page_custom_outgoing),
1045 (create_page_complete_custom):
1046 * src/maemo/modest-account-settings-dialog.c:
1047 (create_page_user_details), (create_page_incoming),
1048 (create_page_outgoing):
1049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1050 (modest_connection_specific_smtp_edit_window_init):
1051 Use the correct (UI spec) port min/max, and use horizontal separators,
1054 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1056 * src/maemo/easysetup/modest-easysetup-wizard.c:
1057 (set_default_custom_servernames):
1058 * src/maemo/modest-account-settings-dialog.c:
1059 (create_page_incoming), (on_combo_outgoing_security_changed),
1060 (on_combo_incoming_security_changed), (create_page_outgoing),
1061 (modest_account_settings_dialog_set_account_name),
1062 (save_configuration):
1063 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1064 (on_combo_security_changed),
1065 (modest_connection_specific_smtp_edit_window_init),
1066 (modest_connection_specific_smtp_edit_window_set_connection),
1067 (modest_connection_specific_smtp_edit_window_get_settings):
1068 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1071 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1074 * src/maemo/easysetup/modest-easysetup-wizard.c:
1075 (create_page_custom_outgoing), (create_page_complete_custom):
1076 * src/maemo/modest-account-settings-dialog.c:
1077 (create_page_user_details), (create_page_outgoing):
1078 * src/maemo/modest-account-view-window.c: (button_box_new):
1079 Use changed logical IDs as per the most recent UI spec:
1080 mcen_bd_emailsetup_edit -> mcen_bd_edit
1081 mcen_bd_emailsetup_delete -> mcen_bd_delete
1082 mcen_bd_emailsetup_close -> mcen_bd_close
1084 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1088 * src/dbus_api/Makefile.am:
1089 * src/dbus_api/modest-dbus-callbacks.c:
1090 * src/dbus_api/modest-dbus-callbacks.h:
1091 * src/maemo/modest-platform.c: (modest_platform_init):
1092 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1094 * tests/Makefile.am:
1095 * tests/dbus_api/Makefile.am:
1096 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1098 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1100 * src/maemo/modest-account-settings-dialog.c:
1101 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1102 Removed unnecessary includes.
1104 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/easysetup/modest-easysetup-wizard.c:
1107 * src/maemo/modest-account-settings-dialog.c:
1108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1109 * src/widgets/Makefile.am:
1110 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1111 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1112 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1113 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1114 * src/widgets/modest-secureauth-combo-box.c:
1115 * src/widgets/modest-secureauth-combo-box.h:
1116 * src/widgets/modest-serversecurity-combo-box.c:
1117 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1118 made the GObject names more consistent with the rest of the Modest code.
1120 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1122 * src/maemo/easysetup/Makefile.am:
1123 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1124 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1125 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1126 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1127 * src/maemo/easysetup/modest-easysetup-wizard.c:
1128 * src/maemo/easysetup/modest-validating-entry.c:
1129 * src/maemo/easysetup/modest-validating-entry.h:
1130 * src/maemo/modest-account-settings-dialog.c:
1131 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1132 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1133 widgets/ because they are used outside of easysetup too. After checking in,
1134 svn will allow me to rename them too.
1136 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1138 * src/gnome/modest-msg-edit-window.c:
1139 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1140 linker error, to fix the build on the GNOME platform.
1141 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1142 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1143 ifdefed out to avoid a warning.
1145 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1147 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1148 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1149 some alternative for GTK+ 2.6.
1151 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1155 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1156 specified for EmailAccountsDialog in UI spec.
1158 * src/maemo/easysetup/modest-easysetup-wizard.c:
1159 * src/maemo/easysetup/modest-easysetup-wizard.h:
1160 * src/maemo/modest-account-settings-dialog.c:
1161 * src/maemo/modest-account-settings-dialog.h:
1162 Reuse a member window widget for the connection-specific SMTP server accounts,
1163 so we can tell it to create/save the accounts only if we actually save changes.
1165 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1167 (modest_connection_specific_smtp_edit_window_get_settings):
1168 Return a struct instance for temporarily remembering the entered data.
1170 * src/maemo/modest-connection-specific-smtp-window.h:
1171 * src/maemo/modest-connection-specific-smtp-window.c:
1172 (modest_connection_specific_smtp_window_finalize),
1173 (modest_connection_specific_smtp_window_fill_with_connections),
1175 (modest_connection_specific_smtp_window_save_server_accounts),
1176 (update_model_server_names): Do not actually save data until asked,
1177 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1179 (on_selection_changed),
1180 (modest_connection_specific_smtp_window_init): Disable the edit
1181 button when nothing is selected.
1183 * src/modest-account-mgr-helpers.c:
1184 * src/modest-account-mgr-helpers.h:
1185 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1188 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-account-mgr-helpers.h:
1191 * src/modest-account-mgr-helpers.c:
1192 (modest_account_mgr_get_unused_account_name),
1193 (modest_account_mgr_get_unused_account_display_name): Added these
1194 utility functions, to avoid code duplication.
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_page_account_details), (create_account):
1198 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1199 (on_combo_security_changed),
1200 (modest_connection_specific_smtp_edit_window_init),
1201 (modest_connection_specific_smtp_edit_window_save_settings):
1202 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1203 * src/maemo/modest-connection-specific-smtp-window.c:
1204 (modest_connection_specific_smtp_window_finalize),
1205 (modest_connection_specific_smtp_window_fill_with_connections),
1206 (on_button_edit), (modest_connection_specific_smtp_window_init):
1207 * src/maemo/modest-connection-specific-smtp-window.h:
1208 Implementing saving of connection-specific server accounts.
1210 But I need to refactor this so we can save the data for each
1211 possible connection-specific account and only actually create the server accounts
1212 when the easysetup finished, or the OK button is pressed on the account settings
1215 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1218 (on_combo_security_changed):
1219 (modest_connection_specific_smtp_edit_window_init):
1220 Auto-fill the port number as in the account settings.
1222 (modest_connection_specific_smtp_edit_window_set_connection):
1223 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1224 * src/maemo/modest-connection-specific-smtp-window.c:
1225 (fill_with_connections), (on_button_edit),
1226 (modest_connection_specific_smtp_window_init):
1227 Turn the edit window into a dialog to simplify the code, and
1228 set a WM hint as in a GtkDialog, because only a popup can be on top of
1229 another window in Maemo, and popups usually have no WM decoration.
1231 * src/modest-defs.h:
1232 * src/modest-account-mgr-helpers.c:
1233 (modest_account_mgr_set_connection_specific_smtp),
1234 (modest_account_mgr_remove_connection_specific_smtp),
1235 (modest_account_mgr_get_connection_specific_smtp):
1236 * src/modest-account-mgr-helpers.h: Some functions to write the
1237 connection-specific SMTP server information. Not yet used.
1240 * src/widgets/modest-folder-view.c: (text_cell_data):
1241 Fix a warning about an uninitialized variable.
1242 (on_configuration_key_changed): Put an #ifdef around the use
1243 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1245 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/modest-account-settings-dialog.h:
1248 * src/maemo/modest-account-settings-dialog.c:
1249 Added connect_for_modified() utility function to mark the new modified boolean.
1251 (create_page_account_details), (create_page_user_details),
1252 (create_page_incoming), (create_page_outgoing), (on_response),
1253 (modest_account_settings_dialog_init),
1254 (modest_account_settings_dialog_set_account_name):
1255 Only warn about unsaved changes when there are actually unsaved changes.
1257 * src/modest-account-mgr-helpers.c:
1258 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1259 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1260 to get the data from there in future.
1262 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-defs.h:
1266 * src/modest-account-mgr-helpers.h:
1267 * src/modest-account-mgr-helpers.c:
1268 Store the security account setting in a single conf key instead of using
1269 the options list, so that the list is left for just the to-be-removed camel hack,
1270 and because gconf_client_set_list() is failing for some reason.
1272 * src/modest-account-mgr.c:
1273 (modest_account_mgr_add_server_account):
1274 * src/maemo/modest-account-settings-dialog.c:
1275 (modest_account_settings_dialog_set_account_name),
1276 (save_configuration): Use the renamed functions.
1279 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1281 * src/widgets/Makefile.am:
1282 * src/widgets/modest-limit-retrieve-combo-box.c:
1283 * src/widgets/modest-limit-retrieve-combo-box.h:
1284 * src/widgets/modest-retrieve-combo-box.c:
1285 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1286 the account settings dialog.
1288 * src/modest-defs.h:
1289 * src/modest-account-mgr-helpers.h:
1290 * src/modest-account-mgr-helpers.c:
1291 (modest_server_account_get_option_secure_auth),
1292 (modest_server_account_set_option_secure_auth):
1293 * src/modest-account-mgr.c:
1294 (modest_account_mgr_add_server_account):
1295 Use the existing AUTH_MECH conf key for the secure-auth setting,
1296 instead of putting it in the list options, because this was actually used already.
1298 * src/maemo/modest-account-settings-dialog.c:
1299 (create_page_account_details),
1300 (modest_account_settings_dialog_set_account_name),
1301 (save_configuration):
1302 * src/maemo/modest-account-settings-dialog.h:
1303 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1304 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1306 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1308 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1309 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1310 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1312 * src/modest-defs.h:
1313 * src/maemo/modest-account-settings-dialog.c:
1314 (create_page_incoming), (on_combo_outgoing_security_changed),
1315 (on_combo_incoming_security_changed), (create_page_outgoing),
1316 (modest_account_settings_dialog_set_account_name),
1317 (save_configuration): Load/Save the port number, and change it when the
1318 security combo changes, to suitable defaults.
1320 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-account-mgr.c:
1323 (modest_account_mgr_add_server_account): Set the security and secure-auth
1324 options, and add a comment saying that the other camel-specific options should be
1327 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1329 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1331 * src/modest-tny-account-store.c: (account_list_free),
1332 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1333 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1336 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-protocol-info.c:
1339 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1340 is required by our UI spec. Maybe something in our implementation will use this eventually.
1341 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1342 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1343 instead of the previous 0 placeholder.
1345 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1346 secure-auth settings.
1347 * src/modest-account-mgr-helpers.h:
1348 * src/modest-account-mgr-helpers.c:
1349 (modest_server_account_data_get_option_secure_auth),
1350 (modest_server_account_set_option_secure_auth),
1351 (modest_server_account_data_get_option_security),
1352 (modest_server_account_set_option_security): Added this API for getting and setting the security
1353 and secure-auth settings.
1355 * src/maemo/modest-account-settings-dialog.h:
1356 * src/maemo/modest-account-settings-dialog.c:
1357 (modest_account_settings_dialog_finalize), (check_data),
1358 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1359 about changing titles.
1360 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1361 (save_configuration): Save the security and secure-auth settings.
1363 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1364 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1366 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-defs.h:
1369 * src/modest-account-mgr.c:
1370 (modest_account_mgr_add_server_account):
1371 Added and used defines for the options key and value pair strings,
1372 that are used so far, though they do not seem to correspond to anything in our
1373 UI specs or ModestProtocol enum.
1375 * src/modest-account-mgr-helpers.h:
1376 * src/modest-account-mgr-helpers.c:
1377 (compare_option_strings_for_name),
1378 (modest_server_account_data_get_option_value),
1379 (modest_server_account_data_get_option_bool),
1380 (modest_account_mgr_get_server_account_option):
1381 Added helper functions for parsing the options GSList.
1383 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1385 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1386 display name is based on the supplied account name.
1387 * src/modest-account-mgr.c:
1388 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1389 with an inefficient, but good-enough, implementation.
1391 * src/maemo/easysetup/modest-easysetup-wizard.c:
1392 (create_page_account_details), (on_before_next), (create_account):
1393 Check for existing display names rather than (non-user-visible) account names, and just
1394 create and set a unique account name at the end.
1396 * src/maemo/modest-account-settings-dialog.c:
1397 (modest_account_settings_dialog_init),
1398 (modest_account_settings_dialog_set_account_name),
1399 (create_page_incoming): Show the display name, instead of the account name.
1400 (on_response): Do some (not all) extra checks, as in the UI spec.
1401 (save_configuration): Save the display name if it was changed.
1403 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1405 * po/en_GB.po: Added needed logical ID and translation.
1406 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1407 (init_view): Made the is-default column clicking work.
1409 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/easysetup/Makefile.am:
1413 * src/maemo/easysetup/modest-easysetup-wizard.c:
1414 (modest_easysetup_wizard_dialog_init):
1415 * src/maemo/easysetup/provider-data-test.keyfile:
1416 * src/maemo/easysetup/provider-data.keyfile:
1417 Moved the provider data file to the new modest-providers-data package and used it from there.
1419 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-local-folder-info.c:
1422 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1423 N_() was already used on the static strings, but this just marks it for translation without
1424 using the translation.
1426 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/modest-account-settings-dialog.c:
1429 (create_page_incoming),
1430 (modest_account_settings_dialog_set_account_name):
1431 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1432 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1433 I will do this if nobody else gets there first.
1435 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1438 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1439 save the security stuff.
1441 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1444 Set the email address and user fullname, which I now see must be
1447 * src/maemo/modest-account-settings-dialog.h:
1448 * src/maemo/modest-account-settings-dialog.c:
1450 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1451 leave-on-server and authentication.
1452 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1455 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/modest-account-settings-dialog.c:
1459 * src/maemo/modest-account-settings-dialog.h:
1460 Most (but not all) of the widgets are now present as specified by the UI spec.
1461 No changes are yet saved, and some details are not properly shown yet.
1463 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1465 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1467 * src/maemo/Makefile.am:
1468 * src/maemo/modest-account-settings-dialog.c:
1469 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1470 an existing account. Doesn't do much yet.
1472 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1473 Open the accounts settings dialog when Edit is clicked.
1475 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/easysetup/Makefile.am:
1478 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1480 * src/maemo/easysetup/modest-easysetup-wizard.c:
1481 (modest_easysetup_wizard_dialog_init):
1482 Try to get the source directory from the build system,
1483 instead of hard-coding "./" into the source code, when opening our local
1484 copies of the configuration files.
1485 But this still fails when opening the wizard from the Accounts window,
1486 maybe because the working directory seems to change at runtime.
1487 So the wizard will fail the second time unless you copy the files into their
1488 proper locations - see the stdout warnings for the paths.
1490 (create_page_account_details),(on_before_next):
1491 Check for existing non-server accounts instead of server accounts,
1492 so the default account name is useful again, and to prevent trying to
1495 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1496 Show the wizard when New is clicked.
1498 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1499 (init_view): Show the column headers, and show the columns that are
1500 specified in the UI specs. However, something in Maemo's GTK+ prevents
1501 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1502 change the default account. This is despite unsetting the special properties.
1504 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1506 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1507 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1508 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1509 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1510 to make that clearer.
1511 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1513 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1515 * src/maemo/modest-account-view-window.c:
1516 (modest_account_view_window_init),
1517 (modest_account_view_window_new):
1518 Use the same buttons as specified in the
1519 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1520 the existing widgets, which never had a chance of working.
1521 Put the ModestAccountView treeview in a scrolled window.
1522 Do not repeat the initialization in both _init() and _new().
1524 * src/widgets/modest-account-view.c: (update_account_view):
1525 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1526 this widget and window shows no accounts.
1528 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1530 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/easysetup/modest-easysetup-wizard.c:
1533 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1534 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1535 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1538 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1539 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1540 accounts exist yet, as in the UI spec.
1542 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1544 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/Makefile.am:
1547 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1549 New window for editing connection-specific smtp details.
1550 Not fully implemented.
1552 * src/maemo/modest-connection-specific-smtp-window.c:
1553 (modest_connection_specific_smtp_window_finalize) :
1554 unref the tree model.
1555 (on_button_edit): Show the edit window.
1557 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1559 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1562 * src/maemo/Makefile.am:
1563 * src/maemo/modest-connection-specific-smtp-window.c:
1564 * src/maemo/modest-connection-specific-smtp-window.h:
1565 New window for showing the list of connections, for connection-specific
1566 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1567 * src/maemo/easysetup/modest-easysetup-wizard.c:
1568 (create_page_custom_outgoing): Show the new window when the button is clicked.
1570 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1572 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1573 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1574 * src/maemo/modest-msg-edit-window.c:
1575 (modest_msg_edit_window_insert_image):
1576 * src/modest-conf.c: (modest_conf_key_escape):
1577 * src/modest-mail-operation.c:
1578 (modest_mail_operation_send_new_mail):
1579 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1580 (modest_ui_actions_on_new_account):
1581 * src/widgets/modest-attachment-view.c: (update_filename_request):
1582 * src/widgets/modest-mail-header-view.c:
1583 Corrected warnings that were breaking the build, by commenting out unused variables,
1584 and a function, and by including a header.
1586 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1588 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1589 so we can #ifdef around platform-specific code when necessary.
1590 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1591 to allow this to build for the GNOME platform too.
1593 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1595 * src/maemo/easysetup/modest-easysetup-wizard.c:
1596 Added util_increment_name() and used it in create_page_account_details()
1597 to make sure that the default account name is always a new name.
1599 (modest_easysetup_wizard_dialog_init),
1600 (set_default_custom_servernames): Some minor memory management fixes.
1602 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-runtime.c: (init_i18n): Restored the translation
1607 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1608 are defined in config.h, and the translations are installed.
1610 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1611 is defined for translation.
1613 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1615 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1617 * src/maemo/easysetup/modest-easysetup-wizard.c:
1618 (modest_easysetup_wizard_dialog_init):
1619 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1620 Use realistic paths (though they should use $prefix generically) to the
1621 mcc_mapping and provider-data.keyfile files which might work when they
1622 are installed by the future version of the operator-wizard package,
1623 and then fallback to paths in our source code, with an explanatory
1626 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1630 * src/maemo/Makefile.am:
1631 * src/maemo/easysetup/: Added files from the previously-exernal
1632 osso-modest-easysetup.
1633 * src/maemo/modest-main-window-ui.h:
1634 * src/modest-ui-actions.c:
1635 * src/modest-ui-actions.h:
1636 Added modest_ui_actions_on_new_account() as a signal handler for the
1637 New Account menu item. It shows the easysetup wizard.
1638 * po/en_GB.po: Added additional needed logical IDs and translations.
1640 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1641 Apparently ChangeLog is not used for some vague Nokia legal reasons.