1 2007-08-27 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
4 recursion when entering text in the subject field.
6 2007-08-27 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
9 which checks every second, 10 times, to wait until the account is online
10 so that we can use it, if the account is in the process of going online.
11 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
12 so that searching works even when the application was not yet started before.
13 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
15 2007-08-24 Armin Burgmeier <armin@openismus.com>
17 * src/modest-widget-memory.c: Always show the default account when the
18 application is started, as stated in the UI spec. This fixes
19 projects.maemo.org bug NB#66630.
21 2007-08-24 Armin Burgmeier <armin@openismus.com>
23 * src/maemo/modest-platform.c:
24 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
25 english text for strings in the rename folder dialog, fixing
26 projects.maemo.org bug NB#66338.
28 2007-08-22 Armin Burgmeier <armin@openismus.com>
30 * src/widgets/modest-account-view.c: Fix for bora by using
31 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
32 latter seems not be used anymore.
34 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
37 * src/maemo/modest-main-window.c: Update menu items when the default
38 account changes so that the current default account is always bolded.
39 This fixes maemo.projects.org bug NB#66173.
41 2007-08-17 Murray Cumming <murrayc@murrayc.com>
43 * src/dbus_api/modest-dbus-callbacks.c:
44 (on_dbus_method_get_folders): Avoid trying to get the account name
45 when there are no accounts, to avoid critical g_warnings, fixing
46 projects.maemo.org bug NB#65574.
48 2007-08-17 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
51 Use modest_account_mgr_get_signature() instead of accessing gconf
52 directly, to slightly simplify the code.
53 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
54 Append the signature also when opening via other applications,
55 fixing projects.maemo.org bug NB#65828.
57 2007-08-17 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
60 Check for NULLs to prevent a crash when opening an email that is
61 an attachment in another email, fixing projects.maemo.org bug
64 2007-08-17 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-ui-dimming-rules.c:
67 (modest_ui_dimming_rules_on_view_window_move_to):
68 Enable the Move To toolbar button for search results, fixing the
69 last part of projects.maemo.org bug NB#63807.
71 2007-08-17 Murray Cumming <murrayc@murrayc.com>
73 * src/dbus_api/modest-dbus-callbacks.c:
74 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
75 because this is called from idle handlers, to fix hangs afte the
77 (find_message_by_url): Added a TODO comment about a crash that
78 happens when tinymail was built with DBC checks.
80 2007-08-16 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-search.c: (modest_search_folder):
83 * src/modest-search.h: Rename ModestSearch::before to start_date
84 and after to end_date, using the same names as the libogs struct
86 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
87 The start_date and end_date were swapped in the check. This
88 fixes date range searches, fixing projects.maemo.org bug NB#63407.
90 2007-08-16 Murray Cumming <murrayc@murrayc.com>
92 * src/maemo/modest-account-view-window.c:
93 Added (check_for_active_acount).
94 (on_delete_button_clicked), (on_edit_button_clicked):
95 When an account is doing something (such as refreshing),
96 show the same warning for account deletion as for account
97 editing, to fix projects.maemo.org bug NB#64588.
99 2007-08-16 Murray Cumming <murrayc@murrayc.com>
101 * src/widgets/modest-msg-view-window.h:
102 * src/gnome/modest-msg-view-window.c:
103 * src/maemo/modest-msg-view-window.c:
104 Added modest_msg_view_window_construct().
105 (modest_msg_view_window_new_with_header_model),
106 Added modest_msg_view_window_new_for_search_result),
107 Renamed modest_msg_view_window_new() to
108 modest_msg_view_window_new_for_attachment(),
109 and modest_msg_view_window_is_search_result(),
110 so we can explicitly know that the window is for an
111 attachment or a search result or a message from the list.
113 (modest_msg_view_window_view_attachment):
114 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
115 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
116 Use modest_msg_view_window_new_for_search_result().
118 * src/modest-ui-dimming-rules.c:
119 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
120 for search results, fixing projects.maemo.org bug NB#63811.
122 2007-08-16 Armin Burgmeier <armin@openismus.com>
124 * src/modest-ui-actions.c: Show a banner instead of a dialog when
125 renaming a folder fails, to stay consistent with what happens when
126 creating a folder fails.
128 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
129 slightly country loading from the mmc_mappings file, fixed a memory
132 2007-08-16 Murray Cumming <murrayc@murrayc.com>
134 * src/modest-tny-account-store.c: (volume_path_is_mounted):
135 Check the GnomeVFSVolume activation path instead of the device path,
136 so that the memory card is really really shown in the UI.
138 2007-08-16 Murray Cumming <murrayc@murrayc.com>
140 * src/maemo/easysetup/modest-easysetup-wizard.c:
141 (get_entered_account_title), (on_before_next), (entry_is_empty),
143 * src/maemo/modest-account-settings-dialog.c:
144 (get_entered_account_title), (on_button_signature), (check_data),
145 (save_configuration), (entry_is_empty):
146 Strip the account title of whitespace at the start and end before
147 using it or checking it. This means that an all-whitespace title
148 is not allowed, fixing projects.maemo.org bug NB#64977.
150 2007-08-15 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-ui-actions.h:
153 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
154 to modest_run_account_setup_wizard() and made it public.
155 * src/dbus_api/modest-dbus-callbacks.c:
156 (check_and_offer_account_creation), (on_idle_mail_to),
157 (on_idle_compose_mail), (on_idle_open_default_inbox):
158 Offer account creation if necessary, fixing projects.maemo.org
161 2007-08-15 Murray Cumming <murrayc@murrayc.com>
163 * src/modest-ui-actions.c: (run_account_setup_wizard):
164 Return a gboolean to indicate success.
165 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
166 (modest_ui_actions_on_send): When offering account creation, only
167 give up (return) if account creation failed. Otherwise continue
168 with the original request. This fixed projects.maemo.org bug
171 2007-08-15 Murray Cumming <murrayc@murrayc.com>
173 * src/widgets/modest-recpt-editor.c:
174 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
175 to fix projects.maemo.org bug NB#63789.
177 2007-08-15 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
180 (modest_tny_account_store_new): Properly detect the memory card at
181 startup, and add an account for it.
183 2007-08-14 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
186 Commented out the MMC code again because it mistakenly detects
187 the card even when it isn't inserted.
189 2007-08-14 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
192 Renabled the call to add_mmc_account() because I do not believe
193 it could be the cause of the mentioned hang (in scratchbox, where
194 there is no memory card), and because I have tested that it works
197 2007-08-14 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
200 Comment out part of the last commit because it apparently causes
203 2007-08-14 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-tny-account-store.c: Added the add_mmc_account()
206 function to save some copy/pasting.
207 (modest_tny_account_store_new): If the memory card is mounted,
208 create an account for it at the start, instead of waiting for the
209 user to unmount it and mount it.
211 2007-08-13 Murray Cumming <murrayc@murrayc.com>
213 * src/widgets/modest-account-view.c: (on_account_changed):
214 Do not try to use the human-readable TnyAccount name instead of the
215 ID of the modest account to get the transport account. And unref
216 the transport account. This prevents a g_warning(), and a possible
219 2007-08-13 Murray Cumming <murrayc@murrayc.com>
221 * src/maemo/modest-platform.c:
222 (modest_platform_set_update_interval): Handle the new
223 alarmd error to warn when alarmd is not running, as is the case in
224 scratchbox for me now because
225 "Module /usr/lib/alarmd/libretu.so initialization failed"
227 2007-08-13 Murray Cumming <murrayc@murrayc.com>
229 * src/widgets/modest-header-view-render.c:
230 (_modest_header_view_compact_header_cell_data):
231 NULL some strings after freeing them, trying to deal with
232 the double deletion found in projects.maemo.org bug 64183,
233 probably having no effect.
235 2007-08-13 Murray Cumming <murrayc@murrayc.com>
237 * src/maemo/modest-account-settings-dialog.c:
238 (create_page_incoming), (create_page_outgoing): Use a define
239 for the min and max port numbers.
241 (check_hildon_number_editor_and_warn_value_not_in_range),
242 (check_data): Do an extra check for an invalid port number, as needed
243 in projects.maemo.org bug #64275, when the number is cleared, but this
244 does not work due to bugs.maemo.org bug #1806.
246 2007-08-13 Murray Cumming <murrayc@murrayc.com>
248 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
249 Comment out the debug warning about the unexpected D-Bus methods.
250 They are just annoying now.
251 * src/maemo/modest-platform.c:
252 (modest_platform_set_update_interval): Correct the D-Bus path, instead
253 of using a file path, though it did not seem to break things before.
254 It might be needed now:
255 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
256 modest is not already running. This is the behaviour of the old client, and
257 Mox says it is what we should do for modest.
258 This closes projects.maemo.org bug NB#64327.
260 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
262 * src/modest-text-utils.c:
263 Fixed invalid jump due to incorrect string/pointer
265 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
268 2007-08-01 Murray Cumming <murrayc@murrayc.com>
270 * src/modest-account-mgr-helpers.h:
271 * src/modest-account-mgr-helpers.c:
272 Added modest_account_mgr_get_first_account_name(),
273 using code from modest_account_mgr_set_first_account_as_default().
275 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
276 (account_number_changed): Call set_at_least_one_account_visible() so that
277 the first account is visible when first added, without the user having to
279 I do wonder how this worked before.
281 2007-08-01 Murray Cumming <murrayc@murrayc.com>
283 * src/modest-tny-account-store.c: (show_password_warning_only),
284 (show_wrong_password), (request_password_and_wait), (get_password),
285 (modest_tny_account_store_alert): Remove the (incomplete anyway)
286 attempts to show UI only in the main context, which used g_idle_add()
287 and mainloops, because tinymail now guarantees that it only calls these
288 callbacks in the mainloop with the gdk lock. This makes everything much
291 2007-08-01 Murray Cumming <murrayc@murrayc.com>
293 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
294 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
295 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
296 error dialog, instead of ignoring it.
298 2007-08-01 Murray Cumming <murrayc@murrayc.com>
300 * src/maemo/modest-msg-view-window.c:
301 (modest_msg_view_window_get_header),
302 (modest_msg_view_window_last_message_selected):
303 Added comments to explain the use of priv->header_model.
304 * src/modest-ui-dimming-rules.c:
305 (modest_ui_dimming_rules_on_open_msg),
306 (modest_ui_dimming_rules_on_mark_as_read_msg),
307 (modest_ui_dimming_rules_on_mark_as_unread_msg),
308 (modest_ui_dimming_rules_on_remove_attachments),
309 (_invalid_attach_selected), (_selected_msg_marked_as):
310 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
311 and changed the parameter to a ModestMainWindow to make it clearer that
312 it never uses any other kind of window.
313 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
314 instead of the selected message.
315 I notice that much of the dimming code and the ModestMsgViewWindow code
316 hard-codes the assumption that the viewed message is always selected in
317 the header view. This does not seem wise or simple.
319 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
320 examine the actual message instead of whatever might be selected
321 in the header view. This stops the delete toolbar button and menu item
322 from being dimmed when opening a message view the search UI,
323 partially fixing projects.maemo.org bug NB#63811.
325 However, when actually deleting, I now get this warning:
326 "tny_header_set_flags: This is a header instance for a new message.
327 Only priority and attachment flags are supported"
329 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
331 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
333 Show account wizard if no accounts are defined while sending
334 (automatic sending after the account wizard finished does not
335 work because it takes some time until the account manager
336 synchronizes everything. (projects.maemo.org NB#62792)
338 2007-07-30 Murray Cumming <murrayc@murrayc.com>
340 * src/modest-tny-account-store.c: (on_account_removed),
341 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
342 account is removed from the View menu. We have TnyAccountStore
343 and ModestTnyAccountStore signals that seem very similar, but this
344 seems to work for now.
346 * src/maemo/modest-main-window.c:
347 (on_show_account_action_activated): Prevent dereference
348 of a NULL if the accoutn does not really exist, though that
349 should not happen anymore.
351 This fixes projects.maemo.org bug NB#64606.
353 2007-07-30 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-ui-actions.c: (run_account_setup_wizard),
356 (modest_ui_actions_on_accounts): Revert a change that set these
357 to modal dialogs, freezing the UI when they show secondary dialogs.
358 This fixed projects.maemo.org bug NB#64519.
360 2007-07-27 Murray Cumming <murrayc@murrayc.com>
362 * src/widgets/modest-header-view-render.c:
363 (_modest_header_view_compact_header_cell_data):
364 Some checks and initialization to try to deal with a crash,
365 probably ineffective.
367 2007-07-27 Murray Cumming <murrayc@murrayc.com>
369 * src/maemo/modest-maemo-utils.c:
370 (modest_maemo_utils_get_supported_secure_authentication_methods):
371 Make sure that we have a connection, asking the user for one
373 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
374 Check for a connection before showing the wizard, because
375 the wizard needs a connection to check for server capabilities.
377 2007-07-27 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/modest-account-view-window.c:
380 (on_new_button_clicked): Remember the wizard dialog instance,
381 so we can just present it again if necessary. This prevents
382 multiple windows from appearing if you click again quickly on the
383 New button before the dialog appears, fixing projects.maemo.org
386 2007-07-27 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
389 Offer a connection dialog if there is no connection when
390 starting modest. This should fix projects.maemo.org bug NB#61134.
392 2007-07-27 Murray Cumming <murrayc@murrayc.com>
394 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
395 Reverted my last commit. I was able to fix the build by doing
396 apt-get install wpeditor0 (replacing other wpeditor packages) and
397 an explicit apt-get install wpeditor-dev to upgrade the -dev
400 2007-07-27 Murray Cumming <murrayc@murrayc.com>
402 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
403 Commented out the use of wp_text_buffer_replace_image()
404 because it does not exist, to break the build. Added a TODO for it.
406 2007-07-26 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-tny-account-store.c: (recreate_all_accounts):
409 Recreate them even if they were NULL before. I guess something
410 else was already creating them before, or this would never
412 (modest_tny_account_store_get_server_account): Make sure that
413 the tny accounts have been created before trying to find one.
414 This allows libmodest_dbus_client_compose_mail() to work
415 when the UI is not yet visible.
416 This is probably useful in other cases too.
418 (get_password): When the password is wrong after it is entered
419 in the protected password dialog, show an info banner (in an
420 idle handler) before showing the protected password dialog
423 2007-07-26 Murray Cumming <murrayc@murrayc.com>
425 * src/modest-ui-actions.h:
426 * src/modest-ui-actions.c: Added
427 modest_do_refresh_current_folder() containing some code from
428 modest_ui_actions_on_send_receive().
429 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
430 Call modest_do_refresh_current_folder() before refreshing the
431 requested account, as in modest_ui_actions_on_send_receive().
432 This is strange, but seems to be necessary to show new mails.
433 Now new emails are finally visible in the UI when downloaded
434 via the automatic update interval, fixing bug NB#57458.
435 This also works because bug NB#57458 has been fixed somehow.
437 2007-07-26 Murray Cumming <murrayc@murrayc.com>
439 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
440 printf more details when we get unhandled D-Bus methods, because
443 * src/modest-mail-operation.c: (update_account_thread):
444 Comment out the tny_camel_pop_store_account_reconnect(), because this
445 is apparently no longer needed, and it did not work before anyway.
446 See the comment in the code.
448 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
449 by checking the header flags. This fixes projects.maemo.org bug
452 2007-07-25 Murray Cumming <murrayc@murrayc.com>
454 * src/maemo/modest-maemo-utils.h:
455 * src/maemo/modest-maemo-utils.c: Added
456 modest_maemo_show_information_note_in_main_context_and_forget().
457 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
458 Use the new function to show simple error dialogs in the main
459 context, though question dialogs are still in the current context,
460 which is unfortunately usually not the main context. This should
463 2007-07-25 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account-store.c: (get_password):
466 Never save the entered username and password in gconf,
467 because the UI spec says we should not. This helps
468 slightly with projects.maemo.org bug NB#63671.
470 2007-07-25 Murray Cumming <murrayc@murrayc.com>
472 * src/widgets/modest-msg-edit-window.h:
473 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
474 Moved some code here to make it simpler.
475 (modest_msg_edit_window_attach_file_one): Renamed from
476 modest_msg_edit_window_attach_file_interactive().
477 (modest_msg_edit_window_offer_attach_file): Renamed from
478 modest_msg_edit_window_attach_file() and used
479 modest_msg_edit_window_attach_file_one() instead of
480 copy/pasting the code. The old code for one was not using
481 GnomeVFS. This allows use of smb:// URLs when using send-as
482 from external applications, fixing bug NB#63741.
484 (modest_msg_edit_window_insert_image),
485 (modest_msg_edit_window_add_attachment_clicked):
486 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
487 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
488 Adapted to the new function names.
490 2007-07-25 Murray Cumming <murrayc@murrayc.com>
492 (modest_platform_set_update_interval): Set the alarm recurrence
493 fields so that auto-update does not just happen the first time.
494 This should have fixed projects.maemo.org bug NB#63938.
496 When this happens you can see a printf when the D-Bus method is
498 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
500 However, I do not actually seem to get new POP messages even when
501 clicking the refresh button manually. A restart gets them.
502 This might be a problem in today's tinymail only.
504 2007-07-24 Murray Cumming <murrayc@murrayc.com>
506 * src/maemo/modest-maemo-global-settings-dialog.c:
507 (current_connection):
508 Avoid a crash (probably only in scratchbox) when strcmp()ing a
509 NULL when closing the dialog.
511 2007-07-24 Murray Cumming <murrayc@murrayc.com>
513 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
514 Remove the hacky send/receive that didn't work, and instead
515 refilter the treemodel to make the deleted email really vanish from
516 the UI (though the delete-from-menu code does has commented out
517 the code that does that). This fixes projects.maemo.org bug
520 2007-07-24 Murray Cumming <murrayc@murrayc.com>
522 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
523 Try a couple of tricks to force the treeview to update (
524 poke the folder, and do a send/receive refresh), but the deleted
525 email still appears with a strike-through instead of really being
528 2007-07-23 Murray Cumming <murrayc@murrayc.com>
530 * src/dbus_api/modest-dbus-callbacks.c:
531 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
532 because their ID is not human-readable (see the comment about
533 improvements needed to the osso-email-interface API) and
534 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
536 2007-07-23 Murray Cumming <murrayc@murrayc.com>
538 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
539 (add_folders_to_list), (on_dbus_method_get_folders),
540 (modest_dbus_req_filter):
541 * src/maemo/modest-maemo-utils.c:
542 (on_camel_account_get_supported_secure_authentication):
543 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
544 (on_header_view_focus_in):
545 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
546 * src/modest-formatter.c: (modest_formatter_create_body_part):
547 * src/modest-mail-operation.c: (recurse_folders),
548 (update_account_thread), (get_msgs_full_thread),
549 (modest_mail_operation_get_msgs_full),
550 (modest_mail_operation_xfer_msgs):
551 * src/modest-search.c: (search_mime_part_and_child_parts),
552 (modest_search_account), (modest_search_all_accounts):
553 * src/modest-tny-account.c:
554 (modest_tny_account_get_special_folder), (recurse_folders):
555 * src/modest-tny-local-folders-account.c:
556 (modest_tny_local_folders_account_query_passes):
557 * src/modest-tny-msg.c: (copy_mime_part),
558 (modest_tny_msg_find_body_part_from_mime_part):
559 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
560 (modest_tny_send_queue_try_to_send):
561 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
562 (_modest_ui_actions_open), (download_uncached_messages),
563 (reply_forward), (modest_ui_actions_on_copy),
564 (modest_ui_actions_on_details), (has_retrieved_msgs),
565 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
567 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
568 (_selected_msg_marked_as), (_msg_download_completed),
569 (_selected_msg_sent_in_progress):
570 * src/widgets/modest-attachments-view.c:
571 (modest_attachments_view_set_message):
572 * src/widgets/modest-msg-view.c: (find_cid_image):
573 * tests/check_folder-transfer.c: (find_folders):
574 * tests/check_update-account.c: (func):
575 * tests/dbus_api/test_get_folders.c: (main):
576 Checked all uses of tny_iterator_get_current(), making sure
577 that the object is unreferenced (3 or 4 places did not),
578 and adding checks for NULL.
580 2007-07-23 Murray Cumming <murrayc@murrayc.com>
582 * src/dbus_api/modest-dbus-callbacks.c:
583 (on_idle_open_default_inbox): Make sure that the application UI is
585 * src/maemo/easysetup/modest-easysetup-wizard.c:
586 (on_entry_invalid_character): Show the word whitespace instead
587 of (null) in the banner when whitespace was entered.
588 (show_error): Add a comment that this does not work in
589 Maemo Bora, though we do not know why.
591 2007-07-23 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-tny-account.c:
594 (modest_tny_account_get_special_folder): Use an if instead of
595 an assert for when the parent account name is NULL, because this
596 might be causing a crash in projects.maemo.org bug 63192.
597 * src/modest-mail-operation.c:
598 (modest_mail_operation_send_new_mail_cb),
599 (modest_mail_operation_remove_folder): unref the folder that is
600 returned from modest_tny_account_get_special_folder().
602 2007-07-23 Murray Cumming <murrayc@murrayc.com>
604 * src/modest-ui-actions.c:
605 (modest_ui_actions_on_password_requested):
606 Show mail_ib_login_cancelled info banner when the user cancels
607 the protected password dialog, to fix projects.maemo.org
610 2007-07-23 Murray Cumming <murrayc@murrayc.com>
612 * src/maemo/modest-account-settings-dialog.c:
613 (create_page_outgoing): Put this page in a GtkScrolledWindow,
614 matching the UI mock-up in the UI spec, and allowing access
615 to all widgets even when the on-screen keyboard is active.
617 2007-07-23 Murray Cumming <murrayc@murrayc.com>
619 Reverted this previous commit from Johannes,
620 because the scrollbars are always visible and because
621 I think we only need it on onepage of the account
622 settings, not the account wizard.
623 (I wrote the wrong instructions in the bug.)
625 * src/maemo/easysetup/modest-easysetup-wizard.c:
626 Added scrollbars to account wizard dialog.
627 Fixed projects.maemo.org NB #62744
629 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
631 * src/maemo/easysetup/modest-easysetup-wizard.c:
632 (create_page_user_details):
633 Use auto-cap for name (projects.maemo.org NB#63716)
634 * src/widgets/modest-account-view.c: (on_account_busy_changed):
636 2007-07-22 Armin Burgmeier <armin@openismus.com>
638 * src/maemo/modest-ui-actions.c: Use current account instead of
639 default account for creating viewer windows, so that the viewer
640 window knows to which account the viewed message belongs.
642 * src/maemo/modest-msg-view-window.c: Destroy the window when the
643 corresponding account is deleted. This fixes projects.maemo.org bug
646 2007-07-18 Armin Burgmeier <armin@openismus.com>
648 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
649 the dialog close after entering an invalid port number and clicking
650 OK. This fixes projects.maemo.org bug NB#63602.
652 2007-07-18 Armin Burgmeier <armin@openismus.com>
654 * src/modest-tny-account-store.c:
655 (get_server_accounts): Set parent modest account name for each
656 connection-specific transport account so that special folders of such
657 an account can be looked up. This fixes a crash when changing account
658 settings. This might also be related to projects.maemo.org bug
661 2007-07-16 Armin Burgmeier <armin@openismus.com>
663 * src/modest-ui-actions.c: Added a button to create a folder to the
664 move-to dialog. This fixes projects.maemo.org bug NB#59863.
666 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
668 * src/maemo/easysetup/modest-easysetup-wizard.c:
669 Added scrollbars to account wizard dialog.
670 Fixed projects.maemo.org NB #62744
672 2007-07-16 Murray Cumming <murrayc@murrayc.com>
674 * src/widgets/modest-msg-view.h:
675 * src/widgets/modest-msg-view.c:
676 Added modest_msg_view_get_message_is_empty() but this needs
678 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
679 Check if there is any text in the message yet.
680 But this needs to be implemented properly.
681 (modest_msg_edit_window_toggle_find_toolbar):
682 * src/maemo/modest-msg-view-window.c:
683 (modest_msg_view_window_toggle_find_toolbar):
684 Show a banner warning if there is no text to search, when
685 trying to start a search. This partially fixes
686 projects.maemo.org bug NB#62350.
688 2007-07-13 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-mail-operation.c: (update_account_thread):
691 Initialized num_new_headers to fix the build.
693 2007-07-13 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
696 Ignore modest accounts whose server accounts don't exist in gconf.
697 This prevents us trying to create TnyAccount instances for those
698 server accounts when the server account has been removed from gconf,
699 but the parent modest account has not yet been removed from modest.
700 I don't know why this is only noticeable now. It was probably just
701 a harmeless g_warning() anyway.
703 2007-07-13 Murray Cumming <murrayc@murrayc.com>
705 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
706 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
708 2007-07-12 Armin Burgmeier <armin@openismus.com>
710 * src/maemo/modest-main-window.c: Make default account appear bold
711 in view, tools/send & receive and toolbar/send & receive SCM menus.
712 This fixes projects.maemo.org bug NB#59010.
714 2007-07-12 Murray Cumming <murrayc@murrayc.com>
716 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
717 Add a short-cut, by checking if the folder store is an account.
718 This ensures that the Sort menu item and toolbar is dimmed for
719 the local-folders account root item, fixing
720 projects.maemo.org bug NB#62545.
722 2007-07-12 Murray Cumming <murrayc@murrayc.com>
724 * src/modest-tny-account-store.c: (get_password):
725 Show the password dialog (via the signal) only in the mainloop, via
726 an idle handler that we wait for. This could theoretically prevent
727 hangs, though I worry that it could introduce some too.
729 2007-07-12 Murray Cumming <murrayc@murrayc.com>
731 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
732 * src/maemo/modest-platform.c:
733 (modest_platform_connect_and_wait):
734 Take a TnyAccount* parameter and try to set it to online
735 (a TnyCamel-only API), because tinymail sets accounts to offline
736 when the user cancels a password dialog, and doesn't ask again until
737 it has been set to online.
738 However, this is commented out because it causes a hang now.
740 (modest_platform_connect_and_wait_if_network_account):
741 * src/modest-mail-operation.c:
742 (modest_mail_operation_update_account):
743 * src/modest-platform.h:
744 * src/modest-ui-actions.c: (_modest_ui_actions_open),
745 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
747 2007-07-12 Armin Burgmeier <armin@openismus.com>
749 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
751 * src/modest-mail-operation.c:
752 * src/modest-ui-actions.c: Check for already existing folder before
753 querying the server, show error message from camel if the request
754 still fails. This fixes projects.maemo.org bug NB#58701.
756 2007-07-12 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-tny-account-store.h:
759 * src/modest-tny-account-store.c:
760 Added modest_tny_account_store_forget_password_in_memory(),
761 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
762 when creating a new account, so that new passwords will be used, instead of
763 us thinking that it's a second request as a result of a failed password again.
765 2007-07-12 Murray Cumming <murrayc@murrayc.com>
767 * src/dbus_api/modest-dbus-callbacks.c:
768 (on_idle_open_message): If the message is in drafts then open it
769 in an edit window instead of a view window. This fixes
770 projects.maemo.org bug NB#63005.
772 2007-07-12 Murray Cumming <murrayc@murrayc.com>
774 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
775 Avoided a harmless g_warning().
777 2007-07-12 Murray Cumming <murrayc@murrayc.com>
779 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
780 Pass the modest account name, not the TnyAccount display name to
781 modest_msg_view_window_new() so that the reply feature works,
782 fixing projects.maemo.org bug NB#62892.
784 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
785 (modest_msg_view_window_new_with_header_model):
786 * src/maemo/modest-msg-view-window.c:
787 (modest_msg_view_window_new_with_header_model),
788 (modest_msg_view_window_new):
789 * src/modest-ui-actions.c: (reply_forward):
790 * src/widgets/modest-msg-view-window.h:
791 * src/widgets/modest-window.c: (modest_window_set_active_account):
792 Rename an account parameter to modest_account_name to make this clearer.
794 2007-07-11 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-ui-actions.h:
797 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
798 modest_do_message_delete().
799 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
800 Call modest_do_message_delete(), hoping that this would cause messages
801 to be really deleted from search instead of just marked with strike through.
802 Does not seem to help.
804 2007-07-11 Armin Burgmeier <armin@openismus.com>
806 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
807 priv->reselect to FALSE prior to calling
808 modest_folder_view_select_first_inbox_or_local() to prevent endless
809 recursion and thus a crash on startup.
811 2007-07-11 Armin Burgmeier <armin@openismus.com>
813 * src/maemo/modest-account-settings-dialog.h: Include
814 <gtk/gtknotebook.h> to fix the build (at least for me).
816 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
817 Use "New FolderN" as default suggested name if "New folder" already
818 exists, with N being the first free number, though never exceed "New
819 folder99" in which case we just fall back to "New Folder" even though
820 it already exists. This fixes projects.maemo.org bug NB#58663.
822 2007-07-11 Murray Cumming <murrayc@murrayc.com>
824 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
825 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
826 projects.maemo.org bug NB#62778.
828 2007-07-11 Murray Cumming <murrayc@murrayc.com>
830 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
831 Ignore the wrong (for now) secure-smtp setting in the presets -
832 just default to requiring secure authentication for SMTP, because
835 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
837 * src/widgets/modest-folder-view.c: (filter_row)
838 Do not show drafts folder (see UI specs)
840 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
842 * src/modest-ui-actions.c:
843 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
844 place and also not necessary.
846 * src/widgets/modest-folder-view.c: (filter_row)
847 Guess folder type and hide Sent & Outbox if necessary.
848 Fixed project.maemo.org NB#57328
850 2007-07-11 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-ui-actions.h:
853 * src/modest-ui-actions.c:
854 (modest_ui_actions_on_delete_message):
855 Move some code into a new
856 modest_ui_actions_refresh_message_window_after_delete()
857 function so we can use it from elsewhere.
859 * src/dbus_api/modest-dbus-callbacks.c:
860 (on_idle_delete_message), (on_delete_message): Used an idle
861 handler, as we do for the other D-Bus method handlers.
862 Call modest_ui_actions_refresh_message_window_after_delete()
863 if the deleted message was open in a window. This fixed
864 projects.maemo.org bug NB#62862.
866 2007-07-11 Murray Cumming <murrayc@murrayc.com>
868 * src/modest-main.c: (main): Only show the UI at the start if
869 the showui command line option was given. For instance,
870 run-standalone src/modest showui
871 Otherwise, we wait for the top_application D-Bus method to
872 be sent by hildon-desktop when the application is selected
874 This allows us to run without a UI when osso-global-search
875 uses our D-Bus methods.
877 2007-07-11 Murray Cumming <murrayc@murrayc.com>
879 * src/dbus_api/modest-dbus-api.h: Added a define for a
880 top-application D-Bus method.
881 * src/dbus_api/modest-dbus-callbacks.c:
882 (on_top_application),
883 (modest_dbus_req_handler): Handle the top-application D-Bus
884 method, which might be an undocumented D-Bus signal sent by
885 hildon-desktop when it starts the application from the menu.
886 But I am not sure and I need to test it on the device, because
887 my scratchbox does not have the application in the menu now.
888 This method shows the main window, so that it can be invisible
889 when started, for instance, just for email searching from
892 * src/maemo/modest-main-window.c: (restore_settings),
893 (modest_main_window_new): Do not show the window immediately
894 upon creation. We show it later.
895 * src/modest-widget-memory.c: (save_settings_paned):
896 Try (unsuccessfully) to avoid saving the paned position when
897 it is not even visible.
898 (restore_settings_paned): Do not allow a silly paned position.
899 This seems necessary when not showing the window at first.
901 * tests/dbus_api/Makefile.am:
902 * tests/dbus_api/test_top_application.c: (main): Test for the
905 2007-07-10 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-ui-dimming-rules.c:
908 (modest_ui_dimming_rules_on_new_msg),
909 (modest_ui_dimming_rules_on_reply_msg),
910 (modest_ui_dimming_rules_on_delete_msg),
911 (modest_ui_dimming_rules_on_details),
912 (modest_ui_dimming_rules_on_view_window_move_to),
913 (modest_ui_dimming_rules_on_view_previous),
914 (modest_ui_dimming_rules_on_view_next),
915 (_invalid_folder_for_purge): Added checks before
916 casting the window. This looks like an actual
917 logic error in _invalid_folder_for_purge(), because it
918 tries to use a ModestMainWindow as a message window.
920 2007-07-10 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/modest-account-settings-dialog.c:
923 (show_error): Use the same implementation as in
924 modest-easysetup-wizard.c:
925 (on_entry_invalid_character): The logical ID contains a %s.
926 Guessed what it should be.
927 (on_entry_max), (check_data), (on_response): Adapt to
928 changed show_error().
929 (create_page_account_details): Really call
930 modest_validating_entry_set_func() on the correct widgets.
931 * src/maemo/easysetup/modest-easysetup-wizard.c:
932 (on_entry_invalid_character): Fix the logical ID here too.
933 (create_page_account_details),
934 (create_page_user_details):
936 modest_validating_entry_set_func() on the correct widgets.
938 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
939 Do not try to use the account if it is NULL.
941 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
943 * src/modest-ui-actions.c: (create_move_to_dialog),
944 (modest_ui_actions_on_main_window_move_to),
945 (modest_ui_actions_on_msg_view_window_move_to):
946 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
947 (filter_row), (modest_folder_view_show_non_move_folders):
948 * src/widgets/modest-folder-view.h:
950 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
951 the Sent folder yet as it does not report the correct folder type.
953 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
955 * src/maemo/modest-msg-edit-window.c: (init_window):
958 2007-07-10 Murray Cumming <murrayc@murrayc.com>
960 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
961 Take a parent widget instead of a parent window, and
962 implement this with hildon_banner_show_information() instead.
963 Non-Maemo builds can just ifdef that there.
964 This fixed projects.maemo.org bug NB#62766.
966 (on_entry_invalid_character): Use show_error() again instead
967 of using hildon directly, and use the _CS() macro to use the correct
969 (create_account), (check_for_supported_auth_methods), (on_entry_max):
970 Pass a widget instead od a window to show_error().
972 2007-07-10 Murray Cumming <murrayc@murrayc.com>
974 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
975 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
976 This allows us to show the server name in the error message, fixing
977 projects.maemo.org bug NB#62904.
978 Also, use the appropriate logical ID message for the account protocol.
980 2007-07-10 Murray Cumming <murrayc@murrayc.com>
982 * src/modest-tny-account-store.c: (on_idle_wrong_password):
983 A compilation fix, though the build wasn't broken for me.
985 2007-07-09 Murray Cumming <murrayc@murrayc.com>
987 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
988 Do not try to unref a NULL folder store, to avoid a runtime warning.
989 This seems to happen sometimes when changing accounts settings.
991 2007-07-09 Murray Cumming <murrayc@murrayc.com>
993 * src/modest-tny-account-store.c:
994 (modest_tny_account_store_instance_init),
995 (modest_tny_account_store_finalize),
996 (on_account_settings_hide), (on_idle_wrong_password):
997 Use a GHashTable to ensure that we only show one account settings
998 dialog per modest account. This avoids us having a dialog open for
999 both the store and transport accounts, or due to repeated get_password()
1000 calls that shouldn't happen anyway.
1002 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1004 * src/maemo/modest-maemo-utils.c: (on_hide),
1005 (modest_maemo_show_dialog_and_forget): Handle the response, because
1006 the window is not even hidden by default.
1008 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1009 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1010 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1011 which seems to prevent some modality problems.
1013 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1014 Ignore user cancellation errors.
1016 * src/modest-account-mgr-helpers.h:
1017 * src/modest-account-mgr-helpers.c:
1018 Added modest_server_account_get_password() and
1019 modest_server_account_get_has_password() to avoid direct use of
1022 * src/maemo/modest-account-settings-dialog.h:
1023 * src/maemo/modest-account-settings-dialog.c:
1024 (modest_account_settings_dialog_init): Store the notebook so we can
1026 Added modest_account_settings_dialog_switch_to_user_info().
1028 * src/modest-tny-account-store.c:
1029 (get_password): When the password in the account settings is wrong (we think),
1030 show the relevant page of the account settings dialog, in the mainloop.
1031 However, we currently get many of these at once because cancel does not
1033 (forget_password): Do not forget the password
1034 from the account settings, because this causes side-effects when
1035 tinymail seems to call it at strange time, maybe because of how we
1036 are cancelling get_password().
1037 (modest_tny_account_store_alert): Ignore user cancellations.
1039 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/modest-maemo-utils.h:
1042 * src/maemo/modest-maemo-utils.c:
1043 Added modest_maemo_show_information_note_and_forget() for use instead of
1044 gtk_dialog_run() when the response is not needed, to avoid an extra
1045 mainloop which could cause a hang.
1047 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1048 Use the logical IDs for the error message, though they are not
1049 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1050 because gtk_dialog_run() caused a hang here (the window did not close).
1051 This fixes projects.maemo.org bug NB#62646.
1053 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-account-mgr-helpers.h:
1056 * src/modest-account-mgr-helpers.c:
1057 Added modest_account_mgr_get_store_protocol().
1059 * src/maemo/modest-account-view-window.c:
1060 (on_delete_button_clicked): Show different warning text depending on
1061 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1062 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1065 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1067 * src/maemo/modest-msg-edit-window.c:
1068 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1069 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1071 2007-07-07 Armin Burgmeier <armin@openismus.com>
1073 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1074 ckdg_ib_maximum_characters_reached from correct package.
1076 * src/modest-ui-actions.c: Show an error message when a folder could
1077 not be created. Tinymail does not give us specific error codes about
1078 what has gone wrong, so we assume that a folder with that name
1079 already exists, though there might be other reasons.
1081 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1084 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1085 give a more exact error message that can be partly translated.
1087 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1089 * src/maemo/modest-address-book.c:
1090 (select_email_addrs_for_contact): Specify a default window size for the
1091 select-email-address dialog, so that it is probably big enough for the
1092 title. This should fix projects.maemo.org bug NB#62277.
1094 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1096 * src/maemo/easysetup/modest-easysetup-wizard.c:
1097 (create_page_complete_easysetup): Use
1098 gtk_widget_set_size() request to ensure that the text wraps
1101 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1103 * src/maemo/easysetup/modest-easysetup-wizard.c:
1104 (on_entry_invalid_character), (create_page_account_details),
1105 (create_page_user_details):
1106 Use new API of ModestValidatingEntry. But for some reason the banner is
1107 not shown. I will have to investigate that further.
1109 * src/widgets/modest-validating-entry.c: (on_insert_text),
1110 (modest_validating_entry_set_func):
1111 * src/widgets/modest-validating-entry.h:
1112 Added a new callback function to be able to react to prevented
1113 characters whitespaces to e.g show a banner.
1115 2007-07-05 Armin Burgmeier <armin@openismus.com>
1117 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1118 notification of HildonNumberEditor instead of remembering the port
1119 number. Thanks to Johannes for pointing this out.
1121 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1123 * src/maemo/easysetup/modest-easysetup-wizard.c:
1124 Check if there are any user changes before showing a confirmation
1125 dialog (projects.maemo.org NB#60946)
1127 2007-07-05 Armin Burgmeier <armin@openismus.com>
1129 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1130 number at the beginning of the dialog and set the modified flag at the
1131 end if the port number has changed. This is necessary because
1132 HildonNumberEditor does not support notification when the value has
1135 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-ui-actions.c:
1138 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1139 a connection before asking anything else. Correct the check for the destination
1140 folder so that it succeeds when online.
1141 This fixed projects.maemo.org bug NB#61645.
1143 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1145 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1146 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1147 to fix projects.maemo.org bug NB#62439.
1149 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1151 * src/modest-tny-account.c: (on_connection_status_changed):
1152 Really do not use tny_device_force_offline() here. See the previous comment.
1154 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1156 * src/modest-tny-account.c: (on_connection_status_changed):
1157 Do not use tny_device_force_offline() when tinymail says that something
1158 went wrong with the connection. It seems to report this unnecessarily.
1160 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/modest-connection-specific-smtp-window.c:
1163 (modest_connection_specific_smtp_window_init):
1164 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1165 does not seem to have any effect in osso 1.1 (though it works in
1166 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1168 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1170 * src/maemo/modest-connection-specific-smtp-window.c:
1171 Fix UI specification problems with projects.meamo.org NB#60479
1173 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1175 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1176 clue when this has failed, because the error dialog is not always shown
1177 (at least in earlier version).
1179 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1180 GError message, because the generic error dialog is not helpful.
1182 'This message is not currently available (can't let a new connection go online)'
1183 when trying to open an IMAP message.
1185 (_modest_ui_actions_open): Offer a connection when some messages would
1186 have to be downloaded and we are offline.
1188 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1190 * src/widgets/modest-folder-view.c:
1191 Don't check for MERGE type anymore as we use the correct type
1193 NOTE: For the last two changes you need to update your tinymail copy
1194 because of API changes!
1196 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1198 * src/modest-tny-local-folders-account.c:
1199 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1200 (see projects.maemo.org NB#61580)
1202 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-tny-account.c: (on_connection_status_changed):
1205 Commented out the call to modest_platform_connect_and_wait() because this
1206 seems to always hang, and I would like to know if this is the only thing
1207 that causes a hang when showing the connection dialog.
1208 It is not very useful anyway.
1210 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-msg-view-window.c:
1213 (modest_msg_view_window_select_next_message):
1215 * src/modest-platform.h:
1216 * src/maemo/modest-platform.c:
1217 Added modest_platform_connect_and_wait(), which calls
1218 tny_maemo_conic_device_connect() always in the main thread, by calling it
1219 in an idle handler and waiting for the idle handler to run. It should be
1220 in the main thread because it uses GTK+ UI code. It just returns TRUE
1221 if the device is already online.
1223 There is some nasty code to ensure that subsequent calls to
1224 modest_platform_connect_and_wait() just wait for the first one to finish,
1225 by checking repeatedly in another idle handler. This is necessary,
1226 because other threads (or even the main thread, via another idle handler)
1227 can call modest_platform_connect_and_wait() while
1228 modest_platform_connect_and_wait() is running.
1230 (modest_platform_connect_and_wait_if_network_account),
1231 (modest_platform_connect_and_wait_if_network_folderstore):
1232 Convenience functions that calls modest_platform_connect_and_wait() if
1233 the account or folder might want network access.
1235 * src/modest-mail-operation.c:
1236 (modest_mail_operation_update_account):
1237 * src/modest-ui-actions.c: (download_uncached_messages),
1238 (modest_ui_actions_on_rename_folder), (delete_folder),
1239 (modest_ui_actions_on_main_window_move_to),
1240 (modest_ui_actions_on_msg_view_window_move_to):
1241 * src/widgets/modest-folder-view.c:
1242 (drag_and_drop_from_folder_view):
1243 Offer a connection if we are offline.
1245 * src/modest-tny-account.c: (on_connection_status_changed):
1246 Document this as only handling errors during network operations in progress,
1247 and replace the idle code with a simple call to
1248 modest_platform_connect_and_wait(), which does this instead.
1250 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1252 * src/modest-tny-account.c:
1253 (modest_tny_account_get_special_folder): (util_on_idle),
1254 Handle the GError so we can see when tny_folder_store_get_folders()
1255 fails, as it currently does while something else is connecting.
1257 Added util_run_in_main_thread_and_wait()
1258 which uses an idlen handler and mainloop to ensure that the function
1259 is called in the main thread.
1260 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1261 to make sure that we call attempt the connection in the mainloop only,
1262 which might solve some hangs.
1264 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1266 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1267 be found by their display name. This is never useful.
1268 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1269 by its ID, instead of trying to use its ID as its display name.
1271 * src/modest-tny-account-store.h:
1272 * src/modest-tny-account.c:
1273 (modest_tny_account_get_special_folder): Add a g_warning() when
1274 tny_folder_store_get_folders() returns an empty list for the maildir.
1276 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1277 Add a g_warning() when this returns NULL, because that it not allowed
1280 2007-07-02 Armin Burgmeier <armin@openismus.com>
1282 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1283 note when trying to cancel the wizard. This fixes projects.maemo.org
1286 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1288 * src/modest-tny-account.h:
1289 * src/modest-tny-account.c:
1290 (modest_tny_account_new_from_server_account),
1291 (modest_tny_account_new_from_server_account_name),
1292 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1293 because this must now be set before setting the proto. This is usd in
1294 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1295 warning in camel_session_get_service() caused by
1296 tny_camel_transport_account_prepare().
1298 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1301 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1305 (modest_connection_specific_smtp_edit_window_init):
1307 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1308 of "changed" for now
1310 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1312 * src/modest-tny-account.c:
1313 (modest_tny_account_new_from_server_account):
1314 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1315 now uses to request a connection when it needs one, and which it uses
1316 to tell us that something is wrong with the connection, so we can force
1317 the accounts offline to prevent further problems.
1319 * src/modest-defs.h:
1320 * src/modest-init.c: (init_default_settings):
1321 * src/modest-mail-operation.c:
1322 (modest_mail_operation_update_account):
1323 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1324 This should not be necessary anymore. Do not set the conf key that
1325 determined this (it was always TRUE and not set anywhere else).
1327 * src/modest-ui-actions.h: Remove unused and unimplemented
1328 modest_ui_actions_on_online_toggle_toggled().
1330 2007-06-29 Murray Cumming <murrayc@murrayc.com
1332 * src/maemo/modest-main-window.c: (connect_signals):
1333 Don't connect to delete_event twice. Maybe this was harmless.
1335 2007-06-29 Murray Cumming <murrayc@murrayc.com
1337 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1338 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1339 Debug output to give some more clue when a folder move is not allowed.
1341 2007-06-28 Murray Cumming <murrayc@murrayc.com
1343 * src/modest-tny-account.c: (on_modest_file_system_info),
1344 (modest_tny_account_get_mmc_account_name):
1345 Always call the callback, without checking whether the name has changed.
1346 * src/widgets/modest-folder-view.c: (strings_are_equal),
1347 (on_model_foreach_set_name), (on_get_mmc_account_name),
1348 (text_cell_data): Compare the name here, and use the name from
1349 the account rather than from the
1350 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1351 if the name was changed after the account was added to the model.
1352 That's a tinymail bug but not one that I want to fix now.
1354 This finally fixes projects.maemo.org bug NB#59301.
1356 2007-06-27 Armin Burgmeier <armin@openismus.com>
1358 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1361 2007-06-27 Murray Cumming <murrayc@murrayc.com
1363 * src/modest-tny-account.h:
1364 * src/modest-tny-account.c:
1365 Added modest_tny_account_get_mmc_account_name(), to set the memory
1366 card name asynchronously for the given account and then notify.
1367 (modest_tny_account_new_for_local_folders): Use this new function instead
1368 of using hildon_file_system_info_async_new() directly.
1370 * src/widgets/modest-folder-view.c: (text_cell_data):
1371 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1372 gtk_tree_model_row_changed() when it is available.
1374 This should fix projects.maemo.org bug NB#59301.
1376 2007-06-27 Murray Cumming <murrayc@murrayc.com
1378 * src/modest-mail-operation.c: (update_account_thread),
1379 (get_msgs_full_thread): Fix typo failures in the revert
1382 2007-06-27 Murray Cumming <murrayc@murrayc.com
1384 * src/maemo/modest-maemo-global-settings-dialog.c:
1385 (idle_select_default_focus):
1386 * src/modest-mail-operation.c: (idle_notify_progress),
1387 (idle_notify_progress_once), (set_last_updated_idle),
1388 (update_account_thread), (get_msgs_full_thread):
1389 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1390 * src/widgets/modest-header-view.c:
1391 (idle_notify_headers_count_changed_destroy),
1392 (idle_notify_headers_count_changed):
1393 Reverted the additions of gdk_threads_enter/leave(), in case this
1394 helps with a startup hang on the device.
1396 2007-06-26 Armin Burgmeier <armin@openismus.com>
1398 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1399 for supported secure authentication methods from server by
1400 gtk_dialog_run(), saving CPU time and a potential race condition.
1402 2007-06-26 Armin Burgmeier <armin@openismus.com>
1404 * src/maemo/modest-maemo-utils.h:
1405 * src/maemo/modest-maemo-utils.c: Added a
1406 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1407 only error code to tell the calling code when the user canceled the
1410 * src/maemo/modest-account-settings-dialog.h:
1411 * src/maemo/modest-account-settings-dialog.c:
1412 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1413 message if the retrieval of secure authentication methods was canceled
1414 by the user. Perform the check before saving anything to configuration
1415 to not end up with half-committed configuration changes, do not show
1416 a "Saving to configuration failed" note when authentication methods
1417 could not be retrieved.
1419 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1422 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1424 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1425 Only return the first level of folders under accounts, because the
1426 osso-global-search UI spec doesn't want the rest.
1427 This fixed projects.maemo.org bug NB#61811.
1429 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-tny-account-store.c:
1432 * src/modest-tny-account-store.h:
1433 Added modest_tny_account_is_memory_card_account().
1434 * src/maemo/modest-main-window.c: (create_details_widget):
1435 Show the same information items for the memory card as we show for the
1436 local-folders, to fix projects.maemo.org bug NB#59307.
1438 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1440 * src/modest-tny-account-store.c: (get_password):
1441 Added some checks for NULL to maybe prevent crashes, though I think
1442 it was Philip's last commit that actually prevented the crash here
1443 when creating a first new account.
1444 But the new account is still not usable (no messages are shown)
1445 until a restart of the application.
1447 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/modest-maemo-global-settings-dialog.c:
1450 (idle_select_default_focus):
1451 * src/modest-mail-operation.c: (idle_notify_progress),
1452 (idle_notify_progress_once), (idle_notify_update_account_queue),
1453 (set_last_updated_idle), (update_account_thread),
1454 (notify_get_msgs_full), (get_msgs_full_destroyer),
1455 (get_msgs_full_thread):
1456 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1457 * src/widgets/modest-header-view.c:
1458 (idle_notify_headers_count_changed_destroy),
1459 (idle_notify_headers_count_changed):
1460 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1461 all idle handlers, because some other thread could be blocking
1462 the GDK lock, so that it can do GUI stuff.
1464 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1466 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1467 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1468 (on_idle_send_receive), (on_idle_open_default_inbox):
1469 * src/maemo/modest-msg-edit-window.c:
1470 (modest_msg_edit_window_attach_file_noninteractive):
1471 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1472 to prevent a hang. I don't quite understand why these are necessary,
1473 beause we should already be in the main loop. I guess something outside
1474 of the main loop is taking the lock.
1476 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1477 we are really using URIs, and use files that are more likely to exist.
1479 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1481 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1482 necessary because configure.ac now defines different variables.
1484 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1486 * libmodest-dbus-client/libmodest-dbus-client.c:
1487 * libmodest-dbus-client/libmodest-dbus-client.h:
1488 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1489 libmodest_dbus_client_compose_mail() is what things actually use.
1491 * src/dbus_api/modest-dbus-api.h:
1492 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1493 * tests/dbus_api/Makefile.am:
1494 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1497 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1499 * src/modest-init.c: (modest_init_local_folders):
1500 For memory-card (or other non local-folders) maildir accounts,
1501 always create an Archive folder, so that there is somewhere to put
1502 messages. This should be less confusing, because the user does not need
1503 to guess that the need to create a folder.
1505 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1507 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1508 Fixed icon size by using (50, 50) which is the same as defined by
1511 2007-06-25 Armin Burgmeier <armin@openismus.com>
1513 * src/widgets/modest-window-mgr.c:
1514 * src/modest-init.c:
1515 * configure.ac: Correctly recognize hildon-notify presence and fixed
1516 the build without it being installed.
1518 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1520 * libmodest-dbus-client/libmodest-dbus-client.c:
1521 (libmodest_dbus_client_search): Fix the build. Sorry.
1522 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1523 (reply_forward_cb): Initialize variables to fix the build.
1525 * src/modest-tny-account-store.c:
1526 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1527 comparison (a silly typo) so that email search results can be opened
1528 when there are more than one account.
1530 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1532 * libmodest-dbus-client/libmodest-dbus-client.c:
1533 (libmodest_dbus_client_search),
1534 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1535 instead of 1 second, because the search gets folders and messages from
1536 the server, which can take a long time. When it times out,
1537 osso-global-search will report no results.
1539 We need to specify whether we should search only cached information
1540 (maybe with a user preference), and the osso-email-search-plugin
1541 API should really be improved to allow that option, and to allow results
1542 to be delivered asynchronously in batches.
1544 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1547 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1548 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1550 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1552 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1553 that is an empty string. D-Bus seems to give us these instead of NULL.
1555 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1557 * src/dbus_api/modest-dbus-callbacks.c:
1558 * src/maemo/easysetup/modest-easysetup-wizard.h:
1559 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1561 (modest_connection_specific_smtp_edit_window_init):
1562 * src/maemo/modest-maemo-global-settings-dialog.c:
1564 * src/maemo/modest-maemo-utils.c:
1565 (modest_maemo_utils_setup_images_filechooser):
1566 * src/maemo/modest-main-window.c: (create_details_widget):
1567 * src/maemo/modest-msg-edit-window.c:
1568 (modest_msg_edit_window_attach_file_noninteractive),
1569 (modest_msg_edit_window_color_button_change),
1570 (modest_msg_edit_window_set_zoom):
1571 * src/modest-mail-operation.c: (update_account_thread):
1572 * src/modest-tny-account-store.c:
1573 * src/modest-tny-account.c:
1574 * src/widgets/modest-global-settings-dialog.c:
1575 * src/widgets/modest-window.h:
1577 Fixed build on bora!
1579 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1581 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1582 * src/modest-search.c: (modest_search_folder),
1583 (modest_search_all_accounts): Actually search only in the specified folder,
1584 doing a simple match on the folder ID.
1585 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1586 and added some documentation.
1588 2007-06-22 Armin Burgmeier <armin@openismus.com>
1590 * src/maemo/modest-maemo-utils.h:
1591 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1592 modest_maemo_utils_get_supported_secure_authentication_methods.
1594 * src/maemo/easysetup/modest-easysetup-wizard.c:
1595 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1596 one occured, not just "Server does not support secure authentication".
1598 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-tny-account-store.c: (get_password):
1601 Restored the call to tny_account_set_user() because Philip seems to have
1602 stopped this from crashing (by not using the freed string). It still does
1603 not work, but now we can test it.
1605 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1607 * src/maemo/modest-msg-edit-window.c: (init_window):
1608 Comment out use of an uninitialzed GtkScrolledWindow variable,
1609 to fix the build and stop a crash. Yet again.
1611 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-tny-account-store.c: (get_password):
1614 Remove the call to tny_account_set_user() because this actually crashes.
1615 As mentioned in the last commit, it is known to not work anyway.
1617 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-tny-account-store.c: (get_password):
1620 Use tny_account_set_username() to tell tinymail that the username might
1621 have changed too. But tinymail ignores this: see projects.maemo.org
1623 * src/modest-ui-actions.c:
1624 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1625 reset the connection when changing the username, and improve the comments.
1626 Save the changed username to gconf at least, so it is used when Modest is
1629 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1631 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1632 Do not use a query, so that we get all folders, including for POP and
1633 local-folders. They work as search criteria too.
1634 This fixes projects.maemo.org bug NB#57740.
1636 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1638 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1639 Comment out the use of hildon_notification_set_sound() because it is
1640 not declared, to fix the build. Warnings are serious, people.
1642 2007-06-21 Armin Burgmeier <armin@openismus.com>
1644 * src/maemo/modest-maemo-utils.h:
1645 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1646 modest_maemo_utils_get_supported_secure_authentication_methods()
1647 to query authentication methods for a specific user. This should fix
1648 projects.maemo.org bug NB#61369.
1650 * src/maemo/easysetup/modest-easysetup-wizard.c:
1651 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1654 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1656 * libmodest-dbus-client/libmodest-dbus-client.h:
1657 * libmodest-dbus-client/libmodest-dbus-client.c:
1658 (modest_dbus_message_iter_get_search_hit),
1659 (libmodest_dbus_client_search):
1660 Reorganised and commented this.
1661 Removed modest_search_hit_free() from the public API because it
1664 Added libmodest_dbus_client_get_folders() and
1665 modest_folder_result_list_free().
1667 * src/dbus_api/modest-dbus-api.h:
1668 * src/dbus_api/modest-dbus-callbacks.c:
1669 (modest_dbus_req_filter): Commented. Moved most code to
1670 on_dbus_method_search() and added on_dbus_method_get_folders().
1672 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1673 of the extra D-Bus handler.
1675 * tests/dbus_api/Makefile.am:
1676 * tests/dbus_api/test_get_folders.c: New test for
1677 libmodest_dbus_client_get_folders(). This seems to return an empty list
1678 at the moment. That could be the same error that causes the message list
1679 to be empty sometimes.
1680 This should help with projects.maemo.org bug NB#57740.
1682 2007-06-21 Armin Burgmeier <armin@openismus.com>
1684 * src/modest-mail-operation.c: Do not call
1685 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1686 notify the operation's end after having set the status to CANCELED for
1687 the operation queue to listen on. This fixes a deadlock when there
1688 were mail operations in the queue during its finalization.
1690 * src/modest-singletons.c: Reordered uninitialization of the account
1691 manager to happen after the mail operation queue was uninitialized
1692 because the mail operation's in the queue might still try to access
1693 the account manager (see modest_mail_operation_notify_end()). This
1694 fixes a potential crash when terminating the application.
1696 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1698 * src/modest-search.c:
1699 (search_mime_part_and_child_parts): Moved some code here so we
1700 can search recursively in child folders.
1701 (modest_search_folder): Search in the message as a mime part, instead
1702 of just its child mime parts.
1703 (read_chunk), (search_mime_part_ogs):
1704 Check how many bytes were read, to prevent an endless loop.
1705 Searching in message bodies now works. This finishes the fix for
1706 projects.maemo.org bug NB#61007.
1708 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1710 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1711 Add a g_warning when the item is not a folder.
1713 * src/modest-ui-dimming-rules.c:
1714 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1715 when selected item is not a folder (for instance, an account), because
1716 the UI spec only talks about folders.
1717 I am not sure what the UI spec wants, so this might not totally fix
1718 projects.maemo.org bug NB#60794.
1720 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1722 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1723 (load_from_file): Sort the list. The unsorted list would be more noticeable
1724 in non-English locales.
1726 * src/maemo/modest-msg-edit-window.c:
1727 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1728 warning and fix the build.
1730 * src/maemo/modest-progress-bar-widget.c:
1731 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1732 avoid a g_warning, and probably to avoid a crash.
1734 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1736 * src/modest-search.c: (modest_search_folder): Check for a GError
1737 when calling tny_folder_get_headers(), to show that this is not the cause
1740 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1742 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1743 Actually set the body query instead of the subject query.
1745 * src/modest-search.c: (search_mime_part_ogs),
1746 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1747 which would probably cause it to fail if we got this far.
1749 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1750 to simplify the code.
1751 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1752 be causing search-in-body to fail.
1754 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1756 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1758 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1759 Better debug message when the folder cannot be found.
1760 This should help with fixing projects.maemo.org bug #61287.
1761 * src/modest-search.c: (add_hit): Do not leak the furl string.
1763 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1765 * src/modest-ui-actions.c:
1766 (modest_ui_actions_on_folder_selection_changed):
1767 Do not special-case TNY_MERGE_FOLDER here, because
1768 modest_tny_folder_get_account() already does that. This fixes
1769 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1770 shown when the Outbox was selected).
1772 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1774 * libmodest-dbus-client/libmodest-dbus-client.c:
1775 (_dbus_iter_get_string_or_null): Initialize the string variable in
1776 case this helps with Dirk's crash.
1778 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1780 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1781 though it is not implemented yet (this function is maybe not even used),
1782 to avoid breaking ABI in future.
1783 * libmodest-dbus-client/libmodest-dbus-client.c:
1784 (get_attachments_string): Moved some code into this generic function.
1785 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1786 sends email. It is maybe not used.
1787 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1788 (on_send_mail): Use attachments.
1790 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1791 * src/maemo/modest-msg-edit-window.c:
1792 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1793 a filename before using it, to fix projects.maemo.org bug NB#58233.
1795 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1797 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1798 Initialize the continue_download variable to fix the build, and probably
1799 to fix randome behaviour.
1801 2007-06-18 Armin Burgmeier <armin@openismus.com>
1803 * src/modest-tny-send-queue.h:
1804 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1805 the queue so we can later show it in the UI. Replaced
1806 modest_tny_send_queue_msg_is_being_sent() by
1807 modest_tny_send_queue_get_msg_status().
1809 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1811 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1812 gpointer. This probably was not harmful, but just to be sure.
1814 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1816 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1817 Fix the build, but leave the function broken on Bora, because
1818 hildon_uri_action_get_service() does not exist.
1819 osso_uri_action_get_service() does not exist either, it seems.
1821 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1823 * src/modest-tny-account.c:
1824 (modest_tny_account_new_from_server_account):
1825 Uncommented the url debug output again, because it is useful for
1826 debugging, as I said in the comment.
1828 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1830 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1832 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1833 for Mameo Bora, to fix the build.
1835 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1838 Fixed build with hildon < 0.99
1840 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1841 Check if the selected account is busy instead of checking all accounts
1843 * src/modest-account-mgr-priv.h:
1844 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1845 (modest_account_mgr_init), (compare_account_name),
1846 (modest_account_mgr_set_account_busy),
1847 (modest_account_mgr_account_is_busy):
1848 * src/modest-account-mgr.h:
1849 Added busy information to the account manager. It possible to
1850 set an account to busy or not busy now.
1852 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1853 (modest_mail_operation_update_account),
1854 (modest_mail_operation_notify_end):
1855 Set the account to busy/not busy depending on the operation state.
1857 * src/widgets/modest-account-view.c:
1858 (modest_account_view_finalize), (get_last_updated_string),
1859 (update_account_view), (on_account_busy_changed), (init_view):
1860 Show string "Refreshing..." if the account is currently busy.
1862 All this fixes projects.maemo.org bug NB#59711
1864 2007-06-14 Armin Burgmeier <armin@openismus.com>
1866 * src/widgets/modest-attachments-view.h:
1867 * src/widgets/modest-attachments-view.c: Added
1868 modest_attachments_view_has_attachments() and fixed coordinate
1869 transformation in get_att_view_at_coords(). This fixes attachment
1872 * src/widgets/modest-msg-view.c: Make use of
1873 modest_attachments_view_has_attachments() to decide whether to show
1874 attachments in the header.
1876 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1878 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1879 (on_change), (on_combo_security_changed),
1880 (modest_connection_specific_smtp_edit_window_init),
1881 (modest_connection_specific_smtp_edit_window_set_connection),
1882 (modest_connection_specific_smtp_edit_window_is_dirty):
1883 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1884 * src/maemo/modest-connection-specific-smtp-window.c:
1887 Show an comfirmation dialog for the smpt-edit-window if there are
1888 unsaved changes and the user hits cancel.
1889 (projects.maemo.org bug NB#60479)
1891 2007-06-14 Armin Burgmeier <armin@openismus.com>
1893 * src/maemo/easysetup/modest-easysetup-wizard.c:
1894 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1895 address" info in banner instead of node, and select all the text as
1896 per UI spec. This fixes projects.maemo.org bug NB#60550.
1898 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1900 reviewed by: <delete if not using a buddy>
1902 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1903 * src/modest-ui-actions.c: (folder_refreshed_cb):
1905 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1907 * src/widgets/modest-folder-view.c: (filter_row):
1908 Explictly filter out the per-account outbox accounts. I don't know why
1909 these only sometimes show up, but now they should never show up in the UI.
1910 This should fix projects.maemo.org bug NB#60160.
1912 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1914 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1915 when the toolbar does not exist yet.
1916 * src/modest-widget-memory.c: (save_settings_header_view):
1917 Added g_warnings() to help us to discover when we are trying to set
1918 an empty columns list in gconf.
1920 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-init.h:
1923 * src/modest-init.c:
1924 Added modest_init_get_default_header_view_column_ids().
1926 * src/modest-widget-memory.c: (restore_settings_header_view):
1927 Use the new function to get defaults, if the gconf key is empty,
1928 instead of not creating any columns. This seems to fix the
1929 empty right-hand pane problems.
1931 * src/widgets/modest-header-view.h: Improved documentation.
1933 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1936 Revert the use of the display name as the account name, because this
1937 is generally wrong and would break the code that follows.
1939 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1941 * src/maemo/easysetup/modest-easysetup-wizard.c:
1942 (check_for_supported_auth_methods), (on_before_next),
1945 More correct fix for projects.maemo.org bug NB# 58991
1946 Do not longer accept AUTH_PASSWORD as secure method and choose
1947 correct method when creating the account.
1949 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1951 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1952 Fixed projects.maemo.org bug NB# 58991
1954 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-init.c: (modest_init_init_core),
1957 (modest_init_local_folders): Fixed compilation errors.
1959 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1961 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1962 Remove unnecessary lib/include, though it is good in principle when needed.
1964 * src/modest-init.c: (modest_init_one_local_folder),
1965 (modest_init_local_folders):
1966 * src/modest-init.h: Initialize the .modest library for memory cards,
1967 instead of just doing nothing for them. This should allow us to create
1968 folders there, fixing projects.maemo.org bug NB#59297.
1970 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1972 * libmodest-dbus-client/libmodest-dbus-client.c:
1973 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1974 (libmodest_dbus_client_compose_mail),
1975 (libmodest_dbus_client_open_message),
1976 (libmodest_dbus_client_send_and_receive),
1977 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1979 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1980 (on_idle_open_message), (modest_dbus_req_handler),
1981 (search_result_to_message), (modest_dbus_req_filter):
1982 * src/modest-search.c: (add_hit), (modest_search_folder),
1983 (modest_search_all_accounts): Improved debug messages.
1985 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1987 * src/modest-tny-account-store.c:
1988 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1991 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1994 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1996 * src/modest-tny-account-store.c: (get_server_accounts):
1997 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1998 even when there are no accounts, so that the Outbox folder is always
1999 visible. This fixes projects.maemo.org bug NB#60158.
2001 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/modest-main-window.c: (create_details_widget):
2004 Use the mcen_va_never logical ID.
2006 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2008 * src/dbus_api/modest-dbus-api.h:
2009 * src/dbus_api/modest-dbus-callbacks.c:
2010 (on_idle_open_default_inbox), (on_open_default_inbox),
2011 (modest_dbus_req_handler):
2012 Added a new OpenDefaultInbox method.
2014 * libmodest-dbus-client/libmodest-dbus-client.h:
2015 * libmodest-dbus-client/libmodest-dbus-client.c:
2016 Added libmodest_dbus_client_open_default_inbox() to call the new
2017 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2018 though it should maybe be used by a new osso-email-interface function.
2020 * tests/dbus_api/Makefile.am:
2021 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2024 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2026 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2027 NULL, so that the signals get all the keys. This should not actually
2028 change any behaviour because we currently update everything when anything
2031 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2033 * src/widgets/modest-folder-view.c: (text_cell_data),
2034 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2035 (find_inbox_iter): If tinymail tells us that the folder is
2036 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2037 This causes the inbox to be selected at startup, fixing part of
2038 projects.maemo.org bug NB#56305.
2040 * src/modest-ui-dimming-rules.c:
2041 (modest_ui_dimming_rules_on_tools_smtp_servers):
2042 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2043 the SMTP servers menu item.
2044 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2045 that the SMTP Servers menu item is dimmed when there are no accounts,
2046 as a future version of the UI spec will require. This fixes
2047 projects.maemo.org bug NB#56305.
2049 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2051 * src/maemo/modest-maemo-utils.c:
2052 (modest_maemo_utils_get_supported_secure_authentication_methods):
2053 Added label to dialog instead of unreadable title
2055 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2056 (modest_main_window_new):
2057 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2060 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2061 * src/modest-account-mgr.h:
2062 Added method to avoid code duplication
2064 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2065 (modest_ui_actions_on_send_receive):
2066 Use modest_account_mgr_has_accounts
2068 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/easysetup/modest-presets.c:
2071 (modest_presets_get_info_server_security): Do not report secure auth
2073 * src/modest-protocol-info.c: Use the defines for the gconf key names
2074 for secure authentication. This was not working because we were writing
2075 Password and reading password, and the check was case sensitive.
2076 With this, gmail now works for receiving and sending when created via
2079 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/easysetup/modest-presets.c:
2082 (modest_presets_get_info_server_security): Correct the key name for
2083 SecureSmtp, because it seems to be case-sensitive.
2084 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2085 Do not try to get the 0th notebook page if there are 0 pages, to
2086 avoid a g_warning().
2088 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2090 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2091 Prevent use of the new notification feature for now, because it currently
2092 shows one dialog for each new email, which is annoying.
2094 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2097 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2098 when no country was selected, so that we show the global ones.
2099 * src/maemo/easysetup/modest-presets.c:
2100 (modest_presets_get_providers): Return only the global providers, not
2101 all providers when mmc=0 was requested.
2103 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2106 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2107 provider ID in the combo.
2109 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2110 Do not show the page numbers, because it would be confusing when we add
2111 the 2 extra pages for the custom setup, when the user chooses the "Other"
2112 provider. This fixes projects.maemo.org bug NB#59028
2114 * src/modest-init.c: (modest_init_init_core),
2115 (modest_init_local_folders):
2116 * src/modest-init.h:
2117 * src/modest-tny-account.c:
2118 (modest_tny_account_new_for_local_folders): Do not create default folders
2119 for the memory card. This should fix projects.maemo.org bug NB#59328.
2121 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2123 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2124 Free the changed_conf_keys string items. They are already freed in the
2125 idle handler if that runs first.
2127 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2129 * src/modest-ui-actions.c:
2130 (modest_ui_actions_on_password_requested): Check that the server name
2131 is not NULL, because I just saw a password dialog with (null) as the
2134 * src/modest-tny-folder.[h|c]: Added
2135 modest_tny_folder_is_memory_card_folder().
2136 * src/modest-ui-dimming-rules.c:
2137 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2138 menu item for memory cards, as per the UI spec (section 7.4). This should
2139 fix projects.maemo.org bug NB#59297.
2141 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2143 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2144 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2145 is another problem with the code, see Murray's comment at line 772)
2147 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2149 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2150 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2151 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2152 (load_from_file), (easysetup_country_combo_box_init),
2153 (easysetup_country_combo_box_get_active_country_ids),
2154 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2155 instead of just one ID, to avoid duplicate country names in the UI.
2157 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2158 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2159 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2160 a single ID, avoiding duplicate providers.
2161 * src/maemo/easysetup/modest-easysetup-wizard.c:
2162 (on_combo_account_country): Adapt to use a list.
2164 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2167 keys changed in the last X seconds.
2169 * src/modest-account-mgr.h:
2170 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2171 (on_key_change), (modest_account_mgr_class_init),
2172 (modest_account_mgr_init), (modest_account_mgr_finalize):
2173 As the keys are changed, save them in a GSList* and signal that GSList*
2174 further every X seconds, to batch changes, to allow us to do just one
2175 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2176 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2178 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2179 changed signal signature.
2181 * src/modest-conf.c: (modest_conf_set_list),
2182 (modest_conf_on_change): Reenable notification.
2184 (modest_conf_maemo_fake_on_change): Comment out the hack that
2185 notified immediately instead of asynchronously.
2187 * src/widgets/modest-account-view.h:
2188 * src/widgets/modest-account-view.c:
2189 (update_account_view): Select the previously-selected account ID,
2190 if possible. This fixes projects.maemo.org bug NB#56933.
2192 (on_account_changed), (on_account_removed),
2193 (modest_account_view_select_account):
2195 Remove the block/unblock functions
2196 because they were not useful.
2198 * src/maemo/modest-account-view-window.c:
2199 (on_delete_button_clicked), (on_edit_button_clicked),
2200 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2202 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2204 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2205 Improve the error dialog to show Incorrect Account Settings, which seems
2206 clearer, and say that the internal error message (to be removed from the
2207 dialog later) is often misleading.
2208 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2210 * src/modest-tny-account.c:
2211 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2212 URL because this is so useful for debugging on the device.
2214 * src/widgets/modest-serversecurity-combo-box.c:
2215 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2217 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2219 * src/modest-mail-operation.c:
2220 (modest_mail_operation_send_new_mail):
2221 Added a comment about a nasty but apparently harmless message. Details
2222 added to the wiki g_warnings() page.
2224 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2226 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2227 (modest_tny_send_queue_class_init):
2228 Do not use the priv struct because it is empty, to avoid g_warnings
2229 about a non-existant priv struct.
2231 * src/modest-tny-account-store.c:
2232 (modest_tny_account_store_get_server_account),
2233 (modest_tny_account_store_get_transport_account_for_open_connection
2234 ): Do not try to get transport server accounts for local folders,
2235 because they don't have any. This avoids a g_warning().
2237 * src/maemo/modest-main-window.c:
2238 (modest_main_window_notify_send_receive_initied),
2239 (on_configuration_key_changed):
2240 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2241 * src/modest-defs.h:
2242 * src/modest-mail-operation.c:
2243 (modest_mail_operation_update_account):
2244 * src/modest-tny-account-store.h:
2245 * src/modest-tny-account.c:
2246 (modest_tny_account_get_special_folder),
2247 (modest_tny_account_new_for_local_folders),
2248 (modest_tny_account_new_for_per_account_local_outbox_folder):
2249 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2250 * src/modest-tny-local-folders-account.c:
2251 (add_account_folders_to_merged_folder):
2252 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2253 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2254 (modest_ui_actions_on_send):
2255 * src/widgets/modest-folder-view.c: (update_model):
2256 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2257 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2258 modest_tny_account_store_get_tny_account_by_account() to
2259 modest_tny_account_store_get_server_account() to make the code clearer.
2261 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2263 * src/dbus_api/modest-dbus-api.h:
2264 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2265 * src/maemo/modest-msg-edit-window.c:
2266 (modest_msg_edit_window_attach_file_noninteractive):
2267 added g_warning in case the file to be attached does not exist
2268 * tests/dbus_api/test_compose_mail.c: (main):
2269 removed obsolete comment, added generic files as test case
2271 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2273 * src/modest-tny-account-store.c: (get_server_accounts):
2274 Create the local folders account only once, not once for each outbox, and
2275 not only when there are some outboxes.
2277 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2279 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2280 code that is causing a crash at startup. Sergio says that he is fixing this.
2282 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2284 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2285 * src/maemo/modest-account-settings-dialog.c:
2286 (create_page_outgoing),
2287 (modest_account_settings_dialog_set_account_name),
2288 (save_configuration):
2289 - Fixed handling of the "Use secure authentication" toggle to comply with
2290 the ui specification. See also projects.maemo.org bug NB#58400
2292 - Restore the Secure connection setting combo correctly when loading
2295 * src/maemo/modest-maemo-utils.c:
2296 (on_camel_account_get_supported_secure_authentication),
2297 (modest_maemo_utils_get_supported_secure_authentication_methods):
2298 Fixed a crasher if operation is canceled
2300 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2301 (modest_protocol_info_auth_is_secure):
2302 * src/modest-protocol-info.h:
2304 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2305 the sense of the "Use secure authentication" toggle.
2307 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-tny-account-store.h:
2310 * src/modest-tny-account-store.c:
2311 Added modest_tny_account_store_get_local_folders_account().
2313 * src/modest-tny-folder.h:
2314 * src/modest-tny-folder.c:
2315 (modest_tny_folder_get_account):
2316 Added this replacement for tny_folder_get_account() which returns
2317 the local-folders account for TnyMergeFolders, to avoid the
2318 warning about the unimplemented get_account_func() vfunc().
2320 (modest_tny_folder_get_rules),
2321 * src/modest-ui-actions.c:
2322 (modest_ui_actions_on_folder_selection_changed):
2323 * src/modest-mail-operation.c:
2324 (modest_mail_operation_remove_folder),
2325 (modest_mail_operation_xfer_folder),
2326 (modest_mail_operation_rename_folder),
2327 (modest_mail_operation_get_msg),
2328 (modest_mail_operation_get_msgs_full),
2329 (modest_mail_operation_remove_msg),
2330 (modest_mail_operation_xfer_msgs),
2331 (modest_mail_operation_refresh_folder):
2332 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2334 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2336 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2337 (modest_server_account_set_security):
2338 * src/modest-defs.h: Add comments explaining that our
2339 UI spec means TLS when it says Normal, so these do not look like errors.
2341 * src/modest-tny-account.c:
2342 (modest_tny_account_new_from_server_account): Use the new tinymail
2343 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2344 for TLS. This should fix projects.maemo.org bug NB#58460.
2346 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/easysetup/modest-easysetup-wizard.c:
2349 (create_account): Correct the position of the gconf sanity check warning.
2350 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2351 of using the g_idle_add() hack, because this does not seem to be necessary
2352 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2353 caused by something other than maemo's gconf.
2354 This fixes projects.maemo.org bug #59022.
2356 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2358 * src/modest-account-mgr-helpers.c:
2359 (modest_account_mgr_get_default_account): Do not check that the account
2360 exists if there is no default account (NULL), to fix a runtime warning.
2362 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2364 * src/widgets/modest-folder-view.c: (update_model):
2365 Do not unref the treemodel before we have finished with it.
2366 This prevents a valgrind warning and an occasional crash at startup.
2368 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2370 * libmodest-dbus-client/libmodest-dbus-client.h:
2371 added libmodest_dbus_client_compose_mail()
2372 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2374 added functions needed for SendAsMail() functionality
2375 * src/maemo/modest-msg-edit-window.c:
2376 (modest_msg_edit_window_attach_file_noninteractive):
2377 non interactively attaching files to message edit window
2378 * src/widgets/modest-msg-edit-window.h:
2379 * tests/dbus_api/Makefile.am:
2380 added test_compose_mail.c
2381 * tests/dbus_api/test_compose_mail.c: (main):
2383 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2385 * src/modest-account-view.c:
2386 Fixed bug projects.maemo.org bug NB#59307
2388 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2390 * src/maemo/easysetup/modest-easysetup-wizard.c:
2391 (get_serverport_incoming), (on_before_next), (create_account):
2392 * src/maemo/modest-account-settings-dialog.c:
2393 (modest_account_settings_dialog_set_account_name):
2394 * src/maemo/modest-maemo-utils.c:
2395 (on_camel_account_get_supported_secure_authentication_status),
2396 (on_camel_account_get_supported_secure_authentication),
2397 (on_secure_auth_cancel),
2398 (modest_maemo_utils_get_supported_secure_authentication_methods):
2400 Implemented security authentication for settings and easysetup.
2402 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2404 * src/maemo/modest-main-window.c: (create_details_widget):
2405 Show the total size for memory card accounts too, instead of showing
2406 the name again. Fixes bug projects.maemo.org bug NB#59307.
2408 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2411 * src/modest-tny-simple-folder-store.c:
2412 * src/modest-tny-simple-folder-store.h: Removed.
2414 * src/modest-tny-local-folders-account.h
2415 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2416 for the local-folders maildir, with an extra TnyMergedFolder containing
2417 the folders of the per-account outbox store accounts.
2418 * src/modest-tny-account-store.c: (get_server_accounts):
2419 Add the outboxes to the special local folders account after creating it.
2421 * src/modest-tny-account.c:
2422 (modest_tny_account_new_for_local_folders): Create the derived
2423 account when creating the main local-folders account.
2425 * src/maemo/modest-main-window.c: (create_details_widget),
2426 (modest_main_window_set_contents_style):
2427 Adapted to the use of the derived account instead of the folder store.
2429 * src/modest-ui-actions.c:
2430 (modest_ui_actions_on_folder_selection_changed):
2431 * src/modest-ui-dimming-rules.c:
2432 (modest_ui_dimming_rules_on_new_folder):
2433 * src/widgets/modest-folder-view.c: (text_cell_data),
2434 (icon_cell_data), (filter_row), (update_model),
2435 (get_cmp_rows_type_pos):
2438 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2439 Do not get the priv struct, because no priv struct has been set,
2440 to avoid a runtime warning.
2442 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2443 #ifelse with #else, to fix a warning, to fix the build.
2446 2007-06-05 Christian Kellner <ckellner@openismus.com>
2448 * libmodest-dbus-client/libmodest-dbus-client.c:
2449 Fix small typo in doc (why do you always see them
2450 AFTER committing stuff?)
2453 2007-06-05 Christian Kellner <ckellner@openismus.com>
2455 * libmodest-dbus-client/libmodest-dbus-client.c:
2456 (libmodest_dbus_client_search):
2457 Initialize hit list with NULL. Also set folder list
2458 to "" if NULL was supplied.
2461 2007-06-03 Christian Kellner <ckellner@openismus.com>
2463 * libmodest-dbus-client/libmodest-dbus-client.c:
2464 (modest_search_hit_list_free):
2465 Make it save to call it with NULL.
2467 * src/dbus_api/modest-dbus-callbacks.c:
2468 * src/modest-search.c:
2469 Return full ModestSearchHits as the search result list not TnyHeader
2470 since can't be around withouth the correspoding TnyFolder.
2472 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2474 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2475 Added currently commented code to check for secure auth
2477 * src/maemo/modest-account-settings-dialog.c: (on_response),
2478 (save_configuration), (show_ok):
2479 Fixed projects.maemo.org bugs NB #59248 and #59251
2481 * src/maemo/modest-maemo-utils.c:
2482 (on_camel_account_get_supported_secure_authentication_status),
2483 (on_camel_account_get_supported_secure_authentication),
2484 (modest_maemo_utils_get_supported_secure_authentication_methods):
2485 * src/maemo/modest-maemo-utils.h:
2486 Moved get_supported_secure_authentication() method here to be able
2487 to use it from easysetup wizard.
2489 * src/modest-pair.c: (on_pair_compare_as_string):
2490 Should compare string with first part of pair and not
2491 strcmp pairs which will crash.
2493 * src/modest-protocol-info.c:
2494 (modest_protocol_info_protocol_is_store):
2495 * src/modest-protocol-info.h:
2496 Added modest_protocol_info_get_auth_protocol_name()
2498 2007-06-03 Armin Burgmeier <armin@openismus.com>
2500 * src/modest-mail-operation.c:
2501 (modest_mail_operation_get_msgs_full): Set priv->account also when
2502 only retrieving a single message. This avoids a crash when canceling
2505 (modest_mail_operation_notify_end): Do not explicitely remove the
2506 operation from the queue but only emit the progress_changed signal.
2507 The queue itself listens to that signal to remove the operation when
2508 it is finished. This reduces coupling and removes a potential deadlock
2509 when modest_mail_operation_notify_end() is called from the queue
2510 itself. If that is a problem performance-wise, I would suggest to
2511 implement a status-changed signal or something.
2513 * src/modest-mail-operation-queue.c: Make sure to never call a
2514 function from another file while the queue is locked. This (hopefully)
2515 fixes another deadlock when exiting the application while retrieving
2518 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2520 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2521 Fixed build if libogs is not available
2523 2007-06-03 Christian Kellner <ckellner@openismus.com>
2525 * libmodest-dbus-client/libmodest-dbus-client.h:
2526 * libmodest-dbus-client/libmodest-dbus-client.c:
2527 (libmodest_dbus_client_delete_message):
2528 Implement deletion of messages (Client side).
2530 (modest_search_hit_free),
2531 (modest_search_hit_list_free):
2532 Utility functions to free the result hits.
2534 * src/dbus_api/modest-dbus-api.h:
2535 * src/dbus_api/modest-dbus-callbacks.c:
2536 (on_delete_message),
2537 (modest_dbus_req_handler):
2538 Implement deletion of messages (Server side).
2540 * tests/dbus_api/test_search.c: (main):
2543 * tests/dbus_api/Makefile.am:
2544 * tests/dbus_api/test_delete_message:
2545 Add little test for the message deletion logic
2547 2007-06-03 Armin Burgmeier <armin@openismus.com>
2549 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2550 when the operation queue was not empty. projects.maemo.org bug
2553 2007-06-03 Armin Burgmeier <armin@openismus.com>
2555 * src/widgets/modest-account-view.c
2556 (on_account_default_toggled): Toggle default account column
2557 explicitely instead of waiting for gconf notification (which is
2558 currently ignored). This should fix projects.maemo.org bug NB#56910
2559 for now. It should probably be removed when gconf notifications are
2562 2007-06-03 Christian Kellner <ckellner@openismus.com>
2564 * libmodest-dbus-client/libmodest-dbus-client.c:
2565 Removed debugging spew.
2567 * src/dbus_api/modest-dbus-callbacks.c:
2568 Added debugging info.
2570 * src/modest-search.c:
2571 (modest_search_all_accounts):
2572 Use tny_account_store_get_accounts () on the account store
2573 to get all accounts which is the way to get all accounts.
2575 * tests/dbus_api/test_search.c: (main):
2576 Make it possible to supply the search term on the command line.
2578 2007-06-03 Christian Kellner <ckellner@openismus.com>
2580 * libmodest-dbus-client/libmodest-dbus-client.c:
2581 * libmodest-dbus-client/libmodest-dbus-client.h:
2582 Implement searching for mesages over raw dbus. (Client side)
2584 * src/dbus_api/Makefile.am:
2585 * src/dbus_api/modest-dbus-api.h:
2586 * src/dbus_api/modest-dbus-callbacks.c:
2587 * src/dbus_api/modest-dbus-callbacks.h:
2588 Search framework (Server side). Also implement on_idle_open_message().
2590 * src/maemo/modest-platform.c: (modest_platform_init):
2591 Prepare for raw dbus/osso rpc interaction.
2593 * src/modest-search.h:
2594 Changed minsize from unspecific guint to guint32.
2596 * src/modest-search.c:
2598 Added strange hack which magically made tnymail work.
2600 (modest_search_folder),
2601 (modest_search_account),
2602 (modest_search_all_accounts):
2603 Implement helper functions to search all accounts, specific account
2606 * tests/dbus_api/Makefile.am:
2607 * tests/dbus_api/test_open_message.c:
2608 Read url to open from commandline.
2610 * tests/dbus_api/test_search.c:
2611 Implement small test for dbus search stuff
2613 2007-06-02 Armin Burgmeier <armin@openismus.com>
2615 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2616 include account type and account title. This fixes projects.maemo.org
2619 * src/maemo/modest-account-view-window.c: Set a title for the window.
2621 2007-06-02 Armin Burgmeier <armin@openismus.com>
2623 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2624 incoming and outgoing server name based on email address and server
2625 types as long as the names have not been edited manually. This fixes
2626 projects.maemo.org bug NB#58671.
2628 2007-06-02 Armin Burgmeier <armin@openismus.com>
2630 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2631 server type cannot be changed in future to the incoming details page
2632 when creating an account. This fixes projects.maemo.org bug NB#59029.
2634 2007-06-02 Armin Burgmeier <armin@openismus.com>
2636 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2637 and assigned max width chars so that they wrap instead of being
2638 truncated. Fixes projects.maemo.org bug NB#56126.
2640 2007-06-02 Armin Burgmeier <armin@openismus.com>
2642 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2643 introductory note to the connection specific smtp servers dialog, as
2644 section 8.12 of the email UI specification requires. This fixes
2645 projects.maemo.org bug NB#59212.
2647 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2650 Check for running mail operations, and offer to cancel them, as per the UI
2651 spec. This fixes projects.maemo.org bug NB#59041 .
2652 However, I suspect that tinymail may still use the network connection
2653 in ways that we cannot detect or cancel. But it should at least adapt to
2654 changes fairly well.
2656 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2658 * src/modest-tny-account-store.c: (recreate_all_accounts),
2659 (get_cached_accounts), (get_server_accounts): Do more sensible
2660 ref-counting of the temporarily-cached outbox accounts list. This seems
2661 to fix a crash when entering the password when the password was wrong.
2663 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2665 * src/gnome/modest-main-window.c: (connect_signals):
2666 * src/modest-tny-account-store.c: (get_password),
2667 (modest_tny_account_store_alert): Added comments and clues and
2668 commented-out code about how we currently fail to deal with connection
2669 errors and wrong passwords, and how we should.
2671 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2673 * src/widgets/modest-retrieve-combo-box.c:
2674 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2675 This fixes projects.maemo.org bug NB#58472 .
2677 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/easysetup/modest-easysetup-wizard.c:
2680 (create_page_complete_easysetup):
2681 (create_page_complete_custom): Correct the last commit,
2682 putting the correct sentences in the correct pages.
2684 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2686 * src/maemo/easysetup/modest-easysetup-wizard.c:
2687 (create_page_complete_custom): Show the second sentence of text
2688 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2691 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2694 Set the leave-on-server conf key by default. This fixes
2695 projects.maemo.org bug NB#59258 .
2697 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-account-view-window.c:
2700 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2701 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2704 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/easysetup/modest-easysetup-wizard.c:
2707 (create_caption_new_with_asterisk):
2708 * src/maemo/modest-account-settings-dialog.c:
2709 (create_caption_new_with_asterisk):
2710 Uncomment the code to add the asterisk, because they are no longer in the
2711 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2712 (update_incoming_server_title): Add an asterisk here too.
2714 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-maemo-global-settings-dialog.c:
2717 (current_connection): Check that we are even connected before trying to
2718 get the current connection name, to prevent a warning.
2720 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2721 Change the comments because tny_maemo_conic_device_connect() is now meant to
2723 * src/modest-mail-operation.c:
2724 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2725 make sure we have a connection and fail if we can't connect.
2727 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2729 * src/maemo/modest-main-window.c:
2730 (on_account_store_connecting_finished): Do not try to get the
2731 connection ID if we are not really connected. I am surprised that
2732 this signal handler is called when we are not connected.
2734 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2736 * src/modest-error.h:
2737 * src/modest-ui-actions.c:
2738 (modest_ui_actions_get_msgs_full_error_handler):
2739 Renamed an enum, added comments, added an enum
2740 for retrieve-limit errors.
2742 * src/modest-mail-operation.c: (foreach_add_item),
2743 (internal_folder_observer_update), (update_account_thread),
2744 (modest_mail_operation_get_msgs_full):
2745 (modest_mail_operation_update_account),
2746 Added comments about how this works, and some code that should
2747 (but does not) check the retrieve-limit. See the TODO comment.
2749 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2751 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2752 Initialize help_id to fix the build. Warnings are good.
2754 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2756 * src/widgets/modest-hbox-cell-renderer.c:
2757 (modest_hbox_cell_renderer_append):
2758 * src/widgets/modest-vbox-cell-renderer.c:
2759 (modest_vbox_cell_renderer_append):
2760 Fix the last commit by doing an extra ref.
2762 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2764 * src/widgets/modest-hbox-cell-renderer.c:
2765 (modest_hbox_cell_renderer_append):
2766 * src/widgets/modest-vbox-cell-renderer.c:
2767 (modest_vbox_cell_renderer_append):
2768 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2769 to fix the build with Maemo Bora.
2770 However, there seems to be a remaining crash, probably due to reference
2773 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2775 * src/modest-tny-account.c:
2776 (modest_tny_account_new_for_local_folders):
2777 Use hildon_file_system_info_async_new() to get a better name for
2778 the memory card account, setting it as the account name.
2779 The timing seems to work, but this is probably
2780 not the best place to do this. See the TODO comment.
2781 * src/maemo/modest-main-window.c: (create_details_widget):
2782 * src/widgets/modest-folder-view.c: (text_cell_data):
2783 Use the tny account name instead of hardcoding a name.
2785 2007-05-30 Christian Kellner <ckellner@openismus.com>
2787 * src/modest-search.c: (modest_search):
2788 Correctly set part_search_func even if we have already parsed
2789 the query and thus a valid OgsTextSearcher object.
2791 2007-05-30 Christian Kellner <ckellner@openismus.com>
2794 Search and check for libogs.
2797 Incooparte the ogs build env.
2799 * src/modest-mime-part-search-stream.c:
2800 * src/modest-mime-part-search-stream.h:
2801 Removed since we do the real searching now in modest-search.c.
2803 * src/modest-search.c:
2804 * src/modest-search.h:
2805 Implement support for ogs. We use that if available and requested
2806 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2807 should now handle the corner case when the search term is spread
2808 across multiple reads.
2809 Also the logic in modest_search () was corrected to search all
2810 requested fields until one is found.
2812 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2814 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2816 * src/modest-init.h:
2817 * src/modest-init.c: Made modest_init_local_folders() take a
2818 path and be public so we can iniitialize maildir folders on
2821 * src/modest-local-folder-info.h:
2822 * src/modest-local-folder-info.c:
2823 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2825 * src/modest-tny-account.c:
2826 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2827 still means the standard local-folders path on the local volume.
2829 * src/modest-tny-account-store.c:
2830 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2831 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2832 all accounts when that happens.
2833 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2834 this too, so it shows up in the treeview.
2836 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2838 * src/maemo/modest-maemo-global-settings-dialog.c:
2839 (current_connection):
2840 * src/widgets/modest-global-settings-dialog.c:
2841 (current_connection_default):
2842 Use the enum values instead of 0, 1 and -1,
2843 to make the code clearer.
2845 * src/modest-account-mgr-helpers.c:
2846 (modest_account_mgr_get_connection_specific_smtp): Make this code
2849 * src/modest-runtime.h:
2850 * src/modest-runtime.c:
2851 Added modest_runtime_remove_all_send_queues().
2852 * src/maemo/modest-main-window.c:
2853 (on_account_store_connecting_finished): Recreate the send queues,
2854 using the appropriate transport accounts for this new connection.
2855 Some futher adapting might be needed if the old send queues are not
2856 automatically stopped at this point.
2858 * src/modest-tny-account-store.c: (get_server_accounts):
2859 Create the connection-specific transport accounts, so that they can
2860 be found later by their ID.
2862 * src/modest-tny-account.h:
2863 * src/modest-tny-account.c:
2864 Added modest_tny_account_new_from_server_account_name().
2865 modest_tny_account_new_from_server_account(): Do not create the
2866 send queues here, because they will be
2867 recreated anyway when the connection changes for the first time.
2869 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-local-folder-info.h:
2872 * src/modest-local-folder-info.c:
2873 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2874 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2875 tbox_folder): Take a modest account name instead of a server TnyAccount,
2876 so we can have per-modest-account rather than per-transport-account
2878 We must make sure that we change or recreate the exisitng send queues
2879 when the connection changes for connection-specific transport accounts.
2881 * src/modest-tny-account-store.c:
2882 (create_per_account_local_outbox_folders): Create outboxed per modest
2883 account, not per transport account.
2885 * src/modest-tny-account.h:
2886 * src/modest-tny-account.c:
2887 (modest_tny_account_get_special_folder): For outboxes, get the
2888 parent modest account name. The account is ignored for other folders.
2889 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2890 modest account name rather than a server TnyAccount.
2892 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2894 * src/modest-tny-account.c:
2895 (modest_tny_account_new_from_server_account):
2896 Call modest_runtime_get_send_queue() immediately after creating transport
2897 accounts, so that they start trying to send email from the outbox as soon
2898 as possible at startup. This is probably what we want.
2900 * src/modest-mail-operation.c: (update_account_thread):
2901 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2902 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2903 * src/modest-tny-send-queue.h:
2904 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2905 (modest_ui_actions_on_send):
2906 Added comments about how sending works, though it needs some more work.
2908 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2910 * src/modest-tny-account.c:
2911 (modest_tny_account_get_special_folder): Add TODO because this fails when
2912 the network is busy.
2913 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2914 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2915 Do not try to show this window when there is no active account. The UI
2916 specs does not tell us what to do in this case.
2918 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2922 * src/maemo/Makefile.am:
2923 * src/widgets/Makefile.am: Some dist fixes.
2925 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2927 * src/maemo/modest-connection-specific-smtp-window.c:
2928 (on_button_edit): Make the code clearer, to prevent a double free.
2930 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2932 * src/maemo/modest-account-settings-dialog.c:
2933 (modest_account_settings_dialog_set_account_name),
2934 Check the connection-specific smtp servers checkbox if there are any.
2936 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2937 (modest_connection_specific_smtp_edit_window_init):
2938 Start with a suitable port number.
2940 * src/modest-account-mgr-helpers.h:
2941 * src/modest-account-mgr-helpers.c: Added
2942 modest_account_mgr_get_has_connection_specific_smtp().
2944 (modest_account_mgr_set_connection_specific_smtp),
2945 (modest_account_mgr_remove_connection_specific_smtp),
2946 (modest_account_mgr_get_has_connection_specific_smtp),
2947 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2948 connection-specific smtp server accounts in the account, rather than
2949 the server account conf dir.
2951 This fixes bug projects.maemo.org bug NB#58263 .
2953 * src/modest-tny-account-store.c:
2954 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2955 if there are no server accounts yet, to prevent an infinite loop when there
2956 are no accounts. Document that one must be called before the other.
2958 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-account-mgr-helpers.c:
2961 (modest_account_mgr_get_default_account): Make sure that at least
2962 one account is always the default, if there are any enabled accounts.
2963 This is just a sanity check that shouldn't be necessary.
2965 * src/modest-account-mgr-priv.c:
2966 (_modest_account_mgr_account_from_key): Unescape the conf key to
2967 get the real account name. For instance, this is an issue if a space
2968 was in the account name, which can happen because the account name
2969 is generated from the display name.
2970 (_modest_account_mgr_get_account_keyname): Always escape the
2972 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2973 Unescape the conf keys to get the real account names.
2975 For instance, previously the is-default radio button in the accounts
2976 list was not checked for any accounts at first. This fixes that,
2977 and might fix several similar bugs.
2979 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2981 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2982 Removed some debug printfs.
2984 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2986 Modest on-disk outbox directories are now here, for instance:
2987 $HOME/.modest/outboxes/<account-id-1>/outbox
2988 $HOME/.modest/outboxes/<account-id-2>/outbox
2990 $HOME/.modest/local-folders/outbox
2991 so we can have a separate outbox for each account.
2992 But they are shown as one outbox in the GtkTreeView, by using a
2993 TnyMergeFolder in a ModestTnySimpleFolderStore.
2996 * src/modest-tny-simple-folder-store.c:
2997 * src/modest-tny-simple-folder-store.h:
2998 Added ModestTnySimpleFolderStore, used to contain folders from
2999 other folder stores, such as other accounts.
3001 * src/modest-tny-outbox-account.h:
3002 * src/modest-tny-outbox-account.c:
3003 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3004 used for the per-account local outbox folders.
3006 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3007 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3008 only use this (internally) now for the non-outbox local folders.
3010 * src/modest-init.h:
3011 * src/modest-init.c: Added modest_init_one_local_folder(), for
3012 setting up the directory structure for each local folder.
3014 * src/modest-local-folder-info.c:
3015 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3016 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3018 * src/modest-local-folder-info.h:
3019 * src/modest-tny-account-store.c: (on_account_removed),
3020 (on_account_changed), (create_per_account_local_outbox_folders),
3021 (get_server_accounts), (modest_tny_account_store_get_accounts),
3022 (modest_tny_account_store_get_tny_account_by_account),
3023 (modest_tny_folder_store_is_virtual_local_folders):
3025 * src/modest-tny-account.h:
3026 * src/modest-tny-account.c:
3027 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3028 to create an on-disk per-account local outbox folder for each
3030 (create_per_account_local_outbox_folders): Create a local outbox folder
3031 for each transport account.
3032 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3033 for all local folders.
3035 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3036 instead of using g_object_get/set() directly. It is clearer.
3038 (modest_tny_folder_store_get_message_count),
3039 (modest_tny_folder_store_get_local_size
3040 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3041 because we now use these with non-acount folder stores.
3043 (modest_tny_account_get_special_folder),
3044 (modest_tny_account_new_from_server_account),
3045 (modest_tny_account_new_from_account):
3046 (recurse_folders): Adjust to the new outbox system.
3048 * src/modest-tny-folder.h:
3049 * src/modest-tny-folder.c:
3050 (modest_tny_folder_is_local_folder),
3051 (modest_tny_folder_get_local_folder_type),
3052 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3054 * src/widgets/modest-main-window.h:
3055 * src/maemo/modest-main-window.c: (create_details_widget),
3056 (modest_main_window_set_contents_style): Show details for any folder store,
3059 (modest_tny_folder_get_rules):
3060 Remove the const. C does not support constness enough for this.
3062 * src/modest-ui-actions.c:
3063 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3064 make all outboxes appear as one, in the usual local-folders tree node.
3066 (set_active_account_from_tny_account),
3067 (modest_ui_actions_on_folder_selection_changed):
3068 * src/widgets/modest-folder-view.c: (text_cell_data),
3069 (icon_cell_data), (filter_row),
3070 (add_account_folders_to_merged_folder),
3071 (add_account_folders_to_simple_folder_store), (),
3072 (get_cmp_rows_type_pos), (cmp_rows),
3073 (modest_folder_view_set_account_id_of_visible_server_account):
3074 Adjust to the new outbox system, using generic folder stores and folders
3075 in the GtkTreeModel.
3077 2007-05-23 Christian Kellner <ckellner@openismus.com>
3079 * src/modest-mail-operation.c:
3080 (modest_mail_operation_update_account):
3081 Use info->max_size instead of unintialized local var [small
3082 build fix]. (Added TODO to review that change since I don't
3085 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3087 * libmodest-dbus-client/libmodest-dbus-client.c:
3088 (libmodest_dbus_client_compose_mail): function added
3089 * src/dbus_api/modest-dbus-api.h:
3090 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3091 (on_compose_mail): Implementation of the SendAsMail functionality
3093 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3095 * src/modest-account-mgr.c:
3096 (modest_account_mgr_add_server_account): Set the secure-connection
3097 conf key for transport accounts as well as store accounts. I don't know
3098 why the if was there. For instance, this makes sure that we use SSL
3099 for the gmail preset from the easysetup wizard.
3101 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3103 * src/gnome/modest-main-window.c:
3104 (on_account_store_connecting_finished), (connect_signals):
3105 * src/maemo/modest-main-window.c:
3106 (on_account_store_connecting_finished), (connect_signals),
3107 (modest_main_window_new):
3108 Handle TnyAccountStore::connecting-finished instead of
3109 TnyDevice::connection-changed, because we cannot actually perform
3110 operations on accounts until TnyAccountStore has itself responded to
3111 the TnyDevice::connection-changed signal. This prevents a GError from
3113 Do not try to update at startup, because we (at least on scratchbox)
3114 already do an update at startup when the device goes online.
3115 This prevents a GError from tinymail.
3116 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3117 Added TODO about stopping simultaneous operations.
3119 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3121 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3122 * src/modest-mail-operation-queue.c:
3123 (modest_mail_operation_queue_remove):
3124 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3125 about where they happened.
3127 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3129 * src/modest-ui-actions.c:
3130 (modest_ui_actions_on_password_requested): Make sure that the remember
3131 output parameter is always TRUE.
3133 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3135 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3136 Show a OK/Cancel dialog if the error is a question, though we still do not
3137 know anything more about what we are asking the user.
3138 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3139 Fix an uninitialized variable (helper). This is a logic error, however.
3141 2007-05-21 Christian Kellner <ckellner@openismus.com>
3143 * src/modest-search.h:
3144 Correct bit shifting in the ModestSearchFlags enum.
3146 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3148 * src/modest-tny-account.c:
3149 (modest_tny_account_new_from_server_account): Do not use the lsub and
3150 check-all hard-coded IMAP options when using POP.
3152 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3154 * src/modest-tny-account.c:
3155 (modest_tny_account_new_from_server_account):
3156 Use NULL for the secure-auth method for POP when Password auth has been
3157 specified by the user, as we already do for IMAP. "auth=Login" causes
3158 an error from camel or the server.
3160 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3162 * src/maemo/modest-account-settings-dialog.c:
3163 (create_page_account_details),
3164 (modest_account_settings_dialog_set_account_name):
3165 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3166 for the leave-on-server checkbox, rathr than just the checkbox, when
3167 the protocol is not POP.
3169 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3171 * src/widgets/modest-account-view.c:
3172 * src/widgets/modest-account-view.h:
3173 Added modest_account_view_select_account() which will be useful later
3174 to asynchronously re-select the edited account.
3176 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3178 * src/maemo/modest-account-settings-dialog.c:
3179 (modest_account_settings_dialog_set_account_name):
3180 Automatically choose the port numbers based on the secure authentication
3181 methods, if they have not been chosen before.
3182 This fixes projects.maemo.org bug NB#56273 .
3184 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3186 * src/maemo/modest-main-window-ui.h:
3187 * src/modest-ui-actions.c:
3188 * src/modest-ui-actions.h:
3189 Connect the Tools/SMTP Servers menu item to
3190 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3191 SMTP servers dialog, as in the UI specification and saves changes when it
3192 is closed. This fixed projects.maemo.org bug NB#56305 .
3194 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/modest-connection-specific-smtp-window.c:
3197 (modest_connection_specific_smtp_window_init):
3198 Use gtk_window_set_default_size() to make this window big enough, so
3199 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3201 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3203 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3205 (modest_connection_specific_smtp_edit_window_init),
3206 Do not try to connect to a combobox signal before the combobox exists.
3207 This fixes the cras in projects.maemo.org bug NB#56288 .
3208 (modest_connection_specific_smtp_edit_window_get_settings):
3209 Remove the server_account_name parameter which was being checked for NULL
3210 though it was not used.
3212 * src/maemo/modest-connection-specific-smtp-window.c:
3213 (modest_connection_specific_smtp_window_fill_with_connections),
3214 (on_button_edit), (modest_connection_specific_smtp_window_init):
3215 Correct the number of treemodel columns to prevent a warning.
3216 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3217 libconic does not work.
3219 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3221 * src/modest-tny-account.c:
3222 (modest_tny_account_new_from_server_account):
3223 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3224 SMTP when "None" was chosen by the user. However, with my SMTP server that
3225 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3228 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3230 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3231 to explain the memory management issue with the ID in the ModestPair.
3233 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3234 (add_sending_page), (modest_account_assistant_finalize):
3235 * src/gnome/modest-gnome-global-settings-dialog.c:
3236 (create_updating_page), (create_composing_page):
3237 * src/gnome/modest-msg-edit-window.c: (get_transports),
3238 (init_window), (modest_msg_edit_window_finalize),
3239 (modest_msg_edit_window_get_msg_data):
3240 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3241 * src/gnome/modest-transport-widget.c:
3242 (modest_transport_widget_finalize), (smtp_configuration):
3243 * src/maemo/modest-maemo-global-settings-dialog.c:
3244 (create_updating_page), (create_composing_page):
3245 * src/maemo/modest-msg-edit-window.c: (get_transports),
3246 (init_window), (modest_msg_edit_window_finalize),
3247 (modest_msg_edit_window_get_msg_data),
3248 (modest_msg_edit_window_free_msg_data):
3249 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3250 (modest_store_widget_finalize):
3251 * src/maemo/modest-transport-widget.c:
3252 (modest_transport_widget_finalize), (smtp_configuration):
3253 * src/modest-main.c: (send_mail):
3254 * src/widgets/modest-combo-box.h:
3255 * src/widgets/modest-global-settings-dialog-priv.h:
3256 * src/widgets/modest-global-settings-dialog.c:
3257 (modest_global_settings_dialog_finalize):
3258 * src/widgets/modest-msg-edit-window.h:
3259 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3260 as long as the combo box, to prevent use of freed memory for the ID.
3262 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3264 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3265 get_accounts(), to make this clearer. Do not check for the enabled gconf
3266 key, because we do not use this for server accounts (at least, not yet).
3267 This allows us to send email again.
3269 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3271 * src/maemo/modest-platform.c:
3272 (on_modest_conf_update_interval_changed), (modest_platform_init):
3273 Only respond to this particular key change. All these strcmp()s cannot be
3276 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3278 * src/maemo/modest-maemo-global-settings-dialog.c:
3279 (current_connection): Prevent a crash in scratchbox when
3280 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3281 * src/maemo/modest-platform.c:
3282 (on_modest_conf_update_interval_changed), (modest_platform_init):
3283 Get the update interval from gconf and reset it when the gconf key changes.
3285 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3287 * src/modest-protocol-info.c:
3288 * src/modest-protocol-info.h: Adde enum-specific get functions,
3289 instead of using a ModestProtocolType enum parameter.
3291 * src/gnome/modest-account-assistant.c:
3292 * src/gnome/modest-store-widget.c:
3293 * src/gnome/modest-store-widget.h:
3294 * src/gnome/modest-transport-widget.c:
3295 * src/gnome/modest-transport-widget.h:
3296 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3297 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3298 * src/maemo/easysetup/modest-easysetup-wizard.c:
3299 * src/maemo/modest-account-settings-dialog.c:
3300 * src/maemo/modest-account-settings-dialog.h:
3301 * src/maemo/modest-store-widget.c:
3302 * src/maemo/modest-store-widget.h:
3303 * src/maemo/modest-transport-widget.c:
3304 * src/maemo/modest-transport-widget.h:
3305 * src/modest-account-mgr-helpers.c:
3306 * src/modest-account-mgr-helpers.h:
3307 * src/modest-account-mgr.c:
3308 * src/modest-account-mgr.h:
3309 * src/modest-tny-account.c:
3310 * src/modest-tny-folder.c:
3311 * src/widgets/modest-account-view.c:
3312 * src/widgets/modest-retrieve-combo-box.c:
3313 * src/widgets/modest-retrieve-combo-box.h:
3314 * src/widgets/modest-secureauth-combo-box.c:
3315 * src/widgets/modest-serversecurity-combo-box.c:
3316 * src/widgets/modest-serversecurity-combo-box.h:
3317 * tests/check_account-mgr.c:
3318 Use the specific functions, and use the re-renamed enum values for GNOME too.
3320 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3322 * src/modest-pair.h:
3323 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3324 so we can get the second based on the first.
3326 * src/maemo/modest-account-settings-dialog.h:
3327 * src/maemo/modest-account-settings-dialog.c:
3328 Added get_supported_secure_authentication_methods(), though it is mostly
3329 commented-out for now until the necessary API is committed to tinymail.
3330 (modest_account_settings_dialog_set_account_name),
3331 (save_configuration): Request the supported authentication methods from the
3332 server, so we can choose a working method.
3334 * src/modest-tny-account-store.h:
3335 * src/modest-tny-account-store.c:
3336 (modest_tny_account_store_get_session): Rename from
3337 tny_account_store_get_session().
3339 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3341 * src/modest-protocol-info.h: Split the ModestProtocol enum
3342 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3343 There was no need to have these unrelated values in one enum.
3345 * src/: many files: Adapted to changed enum. This makes the code a bit
3346 clearer, and the compiler could catch some errors.
3348 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3350 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3351 Show the detailed internal camel error message when an error happens
3352 during the configuration, so that our testers can give us more clues.
3353 For instance, in projects.maemo.org bug NB#56910 .
3355 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3357 * src/modest-tny-account.c:
3358 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3359 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3361 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3363 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3364 * src/maemo/modest-account-settings-dialog.c:
3365 (modest_account_settings_dialog_set_account_name),
3366 (save_configuration): For the incoming secure authentication checkbox,
3367 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3368 the UI specification. PLAIN does not seem to be supported for most IMAP
3369 servers anyway, and I am not sure what it would mean.
3370 However, we probably need to discover which of the secure-authentication
3371 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3372 * src/modest-account-mgr-helpers.c:
3373 (modest_account_mgr_get_server_account_data):
3375 * src/modest-tny-account.c:
3376 (modest_tny_account_new_from_server_account):
3377 Use tny_account_set_mech() to set secure-authentication methods,
3378 with some special-casing for IMAP, based on my observations of how
3381 * src/modest-account-mgr-helpers.h:
3382 * src/modest-account-mgr.c:
3383 * src/modest-defs.h: Comment that the URI is only used for local folders.
3385 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3387 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3388 parameter const, just to be neat.
3389 * src/modest-text-utils.c: (modest_text_utils_inline):
3390 End g_strconcat() with NULL, as its documentation says. This is almost
3391 certainly the cause of my crash at startup on the device. Interestingly,
3392 valgrind doesn't tell us about these errors.
3394 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3396 * scripts/build-packages: Added more precise comments about how to use
3397 this script, though I still get this error:
3398 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3399 error building tinymail
3401 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3403 * src/maemo/modest-main-window.c: (on_account_update):
3404 Very slight cleanup, hoping to make it simpler to discover what causes
3405 a crash here sometimes.
3407 * src/modest-tny-account.c:
3408 (modest_tny_account_new_from_server_account): Set the port. Added
3409 comments about the options and a TODO comment because I need to find out
3410 how to specify the secure authentication method.
3412 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3414 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3415 changed CFlags paths form modest to libmodest
3417 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3419 * src/modest-account-mgr-helpers.c:
3420 (modest_account_mgr_get_server_account_data),
3421 (modest_account_mgr_free_server_account_data):
3422 * src/modest-account-mgr-helpers.h:
3423 * src/modest-account-mgr.c:
3424 (modest_account_mgr_add_server_account):
3425 * src/modest-defs.h:
3426 * src/modest-tny-account.c:
3427 (modest_tny_account_new_from_server_account):
3428 Determine the options for tny_camel_account_add_option() here,
3429 based on the settings, rather than storing them directly in gconf.
3431 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3434 Show a more friendly error dialog now that we expect (from the tinymail
3435 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3437 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3439 * src/maemo/modest-main-window.c: (on_account_update): Check that
3440 account_name is not NULL, to prevent a crash at startup that I am
3441 seeing on the N800. I do wonder why it is NULL.
3443 * src/maemo/easysetup/modest-easysetup-wizard.c:
3444 (create_page_user_details):
3445 * src/maemo/modest-account-settings-dialog.c:
3446 (create_page_user_details), (create_page_outgoing):
3447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3448 (modest_connection_specific_smtp_edit_window_init):
3449 * src/modest-ui-actions.c:
3450 (modest_ui_actions_on_password_requested):
3451 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3452 might do something useful with the on-screen keyboard.
3454 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3456 * src/maemo/modest-main-window.c: (on_account_update):
3457 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3458 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3460 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3462 * src/modest-tny-account-store.c: (on_account_changed):
3463 Correct the signature of this signal handler.
3465 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3467 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3468 Show a HildonNote instead of a GtkDialog for Maemo.
3470 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3472 * src/widgets/modest-account-view.h:
3473 * src/widgets/modest-account-view.c: (on_account_changed),
3474 (on_account_removed). Added a boolean flag, set/unset by
3475 modest_account_view_block_conf_updates(),
3476 modest_account_view_unblock_conf_updates() to prevent unnecessary
3477 updates, but this is not very useful because the gconf notifications are
3478 so delays (maybe only on Maemo Bora).
3479 So auto-updating is turned off, and these functions do an explicit
3480 update when necessary.
3481 However, something else is still doing too much work when adding/removing
3482 accounts, probably in another part of the application.
3484 * src/maemo/modest-account-view-window.c:
3485 (on_delete_button_clicked), (on_edit_button_clicked),
3486 (on_new_button_clicked): Use the new functions.
3488 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3490 * src/modest-account-mgr-helpers.c:
3491 (modest_account_mgr_set_first_account_as_default):
3492 Sort the list of names alphabetically-by-title, so we choose the first one
3494 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3495 alphabetically by the title.
3497 This fixes projects.maemo.org bug NB#56418 .
3499 * src/modest-account-mgr-priv.c:
3500 (_modest_account_mgr_account_from_key):
3501 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3502 avoid a valgrind error, and possible random behaviour.
3504 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3506 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3507 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3508 tinymail documentation to say that this can be expected.
3509 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3510 pretty, and should not happen, but I would prefer to know when it does.
3512 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3514 * configure.ac: When using the older hildon version, probably on Bora,
3515 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3517 * src/widgets/modest-attachment-view.c:
3518 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3521 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3523 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3524 Implemented the prototype. Can be tested with
3525 tests/dbus_api/test_open_message:
3527 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3529 * src/modest-tny-account-store.c:
3530 (modest_tny_account_store_instance_init), (get_password):
3531 * src/modest-ui-actions.c:
3532 (modest_ui_actions_on_password_requested):
3533 Do not store the password in gconf, because this function is called
3534 for non-remembered passwords. Actually use the cached (in the hash map)
3535 password instead of releasing it.
3536 The password will now not be remembered if it is asked via the protected
3537 password dialog, as per the UI spec.
3539 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3541 * src/modest-defs.h:
3542 * src/modest-account-mgr-helpers.h:
3543 * src/modest-account-mgr-helpers.c:
3544 Added modest_server_account_get_username_has_succeeded(),
3545 modest_server_account_set_username_has_succeeded().
3546 (modest_server_account_set_username),
3547 Reset the has-succeeded flag if the username changes.
3549 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3550 * src/maemo/modest-connection-specific-smtp-window.c:
3551 (modest_connection_specific_smtp_window_save_server_accounts):
3552 Use modest_server_account_set_username() instead of using
3553 modest_conf_set_string() directly, so that the has-succeeded flag is always
3556 * src/modest-ui-actions.c:
3557 (modest_ui_actions_on_password_requested): Dim the username entry if
3558 the username has ever worked, as per the UI spec.
3560 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3562 * src/modest-tny-account-store.c: (get_password):
3563 * src/modest-ui-actions.c:
3564 (modest_ui_actions_on_password_requested):
3565 Allow the username to be changed too, though there is more work to
3566 be done on exactly how this behaves.
3568 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3570 * src/modest-account-mgr-helpers.h:
3571 * src/modest-account-mgr-helpers.c:
3572 Added modest_account_mgr_get_display_name(),
3573 modest_server_account_get_username(),
3574 modest_server_account_set_username(),
3575 modest_server_account_set_password(),
3576 modest_server_account_get_hostname() functions so we do not need to
3577 use the conf API directly.
3579 * src/maemo/modest-main-window.c: (connect_signals):
3580 Actually connect ot the ModestAccountStore::request-password signal,
3581 so that we show the dialog when the password is requested by Tinymail,
3582 for isntance if it is empty.
3584 * src/modest-marshal.list:
3585 * src/modest-tny-account-store.c:
3586 (modest_tny_account_store_class_init), (get_password),
3587 (modest_tny_account_store_alert):
3588 * src/modest-tny-account-store.h:
3589 * src/modest-ui-actions.h:
3590 * src/modest-ui-actions.c:
3591 (modest_ui_actions_on_password_requested):
3592 Change the signal parameters, so it is obvious that we are providing
3593 the non human-readable server name, and receiving both the username
3594 and password, though changing of the username is not yet implemented.
3595 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3596 for the GNOME version.
3598 This should fix the projects.maemo.org bug NB#56209, though it does not
3599 work on Bora, because the gconf_client_get() for the password fails
3600 immediately after we save it with gconf_client_set().
3602 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3605 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3606 caused an undefined symbol error:
3607 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3609 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3611 * src/modest-tny-account-store.c:
3612 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3613 using a GError instead of a string message, so we can translate it in
3616 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3618 * src/maemo/modest-address-book.c:
3619 (modest_address_book_check_names):
3620 * src/maemo/modest-msg-view-window.c:
3621 (modest_msg_view_window_clipboard_owner_change):
3622 * src/modest-init.c: (modest_init_init_ui):
3623 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3624 (update_folders_cb), (modest_mail_operation_update_account):
3625 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3626 (modest_ui_actions_on_msg_attachment_clicked),
3627 (modest_ui_actions_on_msg_recpt_activated):
3628 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3629 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3630 (modest_msg_view_search_next):
3631 * src/widgets/modest-recpt-editor.c:
3632 (modest_recpt_editor_on_button_release_event),
3633 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3634 g_message(). At this point we should only be seeing interesting errors on
3635 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3637 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3639 (modest_wizard_dialog_force_title_update):
3640 * src/maemo/easysetup/modest-wizard-dialog.h:
3641 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3642 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3643 can update the title when appropriate. Otherwise the title is wrong if the
3644 pages are added after adding the notebook to the dialog.
3645 This must be a problem in HildonWizardDialog too.
3646 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3648 * src/maemo/easysetup/modest-easysetup-wizard.c:
3649 (create_subsequent_customsetup_pages),
3650 (create_subsequent_easysetup_pages):
3651 Call modest_wizard_dialog_force_title_update() so that the title is
3652 correct even with GTK+ < 2.10.
3653 This fixes projects.maemo.org bug NB#56145 .
3655 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3657 * src/maemo/modest-platform.c:
3658 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3659 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3662 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3664 * src/widgets/modest-window.h:
3665 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3666 and modest_window_save_state(), which invokes it.
3668 * src/widgets/modest-window-mgr.h:
3669 * src/widgets/modest-window-mgr.c:
3670 Added modest_window_mgr_save_state_for_all_windows(), which calls
3671 the save_state vfunc on all registered windows, if implemented.
3673 * src/gnome/modest-msg-edit-window.c:
3674 * src/gnome/modest-msg-view-window.c:
3675 * src/maemo/modest-msg-edit-window.c:
3676 * src/maemo/modest-msg-view-window.c:
3677 * src/maemo/modest-main-window.c:
3678 Specify the existing save_settings functions as implementations of
3679 ModestWindow::save_state_func().
3681 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3682 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3683 enabling hibernation, for instance.
3685 We may need to do the same thing for restoring settings.
3688 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3690 * src/widgets/modest-window-mgr.c:
3691 * src/widgets/modest-window-mgr.h:
3692 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3693 modest_window_mgr_get_hibernation_is_prevented().
3695 * src/maemo/modest-main-window.c:
3696 (on_hildon_program_is_topmost_notify): Prevent hibernation
3697 (possible when the application goes to the background in the WM),
3698 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3700 * src/maemo/easysetup/modest-easysetup-wizard.c:
3701 (modest_easysetup_wizard_dialog_init):
3702 * src/maemo/modest-account-settings-dialog.c:
3703 (modest_account_settings_dialog_init):
3704 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3705 (modest_connection_specific_smtp_edit_window_init):
3706 * src/maemo/modest-connection-specific-smtp-window.c:
3707 (modest_connection_specific_smtp_window_init):
3708 * src/maemo/modest-signature-editor-dialog.c:
3709 (modest_signature_editor_dialog_init):
3710 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3711 prevent hibernation while any of these account settings dialogs are open.
3713 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3715 * src/maemo/Makefile.am:
3716 * src/maemo/modest-osso-state-saving.c:
3717 * src/maemo/modest-osso-state-saving.h: Added
3718 modest_osso_load_state() and modest_osso_save_state() though they do
3719 nothing now. They should iterate through all the open windows and load/save
3721 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3722 save state when closing.
3724 * src/maemo/modest-main-window.c:
3725 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3726 Add a notification handler for the HildonProgram::is-topmost property,
3727 so we can allow hibernation when the application goes into the background.
3728 But we still need to detect when the accounts setup windows are open so
3729 we can stop hibernation when they are open.
3730 To do this, I also added the main window the HildonProgram. This might have
3731 other side-effects/benefits, and should maybe be done for other windows.
3733 * src/maemo/modest-osso-autosave-callbacks.h:
3734 * src/maemo/modest-osso-autosave-callbacks.c:
3735 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3736 though it does not do anything yet, and we might never need this to do
3737 anything. For instance, we already save drafts.
3739 * src/maemo/modest-platform.c: (modest_platform_init):
3740 Specify the libosso auto-save callback.
3742 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3744 * src/maemo/modest-platform.c:
3745 (modest_platform_set_update_interval):
3746 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3747 aparently stays valid between application instances, so we can use this
3748 to remove and reset it later. According to a maemo-developers email from
3751 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3753 * configure.ac: Depend on libalarm for Maemo.
3755 * src/dbus_api/modest-dbus-api.h:
3756 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3757 (on_send_receive), (modest_dbus_req_handler):
3758 Handle a SEND_RECEIVE D-Bus method.
3760 * libmodest-dbus-client/libmodest-dbus-client.c:
3761 (libmodest_dbus_client_send_and_receive):
3762 * libmodest-dbus-client/libmodest-dbus-client.h:
3763 Add C convenience functions for calling the new D-Bus method.
3765 * src/modest-platform.h:
3766 * src/gnome/modest-platform.c:
3767 * src/maemo/modest-platform.c:
3768 Added modest_platform_set_update_interval(), which uses the
3769 alarmd API on Maemo.
3770 (modest_platform_init),
3771 Call modest_platform_set_update_interval(), using a hard-coded
3772 interval for now (until the global settings dialog is implemented),
3773 though I am not sure that this makes sense yet.
3775 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3777 * src/dbus_api/modest-dbus-callbacks.c:
3778 (modest_osso_cb_hw_state_handler):
3779 * src/dbus_api/modest-dbus-callbacks.h:
3780 * src/maemo/modest-platform.c: (modest_platform_init):
3781 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3782 in case this has some effect on the ability for Maemo to ping the
3785 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3787 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3788 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3789 warning. It is probably a logic error, but I need to fix the build.
3791 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3793 * src/modest-account-mgr.h:
3794 * src/modest-account-mgr.c:
3795 (modest_account_mgr_account_names): Add a gboolean enabled_only
3796 parameter, so we can get lists of onlt the enabled accounts.
3798 (modest_account_mgr_add_account),,
3799 (modest_account_mgr_account_with_display_name_exists):
3800 * src/maemo/modest-msg-edit-window.c: (get_transports):
3801 * src/modest-account-mgr-helpers.c:
3802 (modest_account_mgr_set_first_account_as_default):
3803 * src/modest-init.c: (init_default_account_maybe):
3804 * src/modest-tny-account-store.c: (get_accounts):
3805 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3806 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3807 * tests/check_account-mgr.c: (START_TEST):
3808 Provide the extra parameter, as appropriate.
3810 * src/widgets/modest-account-view.c: (update_account_view):
3811 Do not show disabled accounts (meaning that there is no way to
3812 enable/disable accounts in the UI (the feature is not in our UI
3813 specification), so we can use this internally only to mark unfinished
3814 or temporary account data.
3816 * src/maemo/easysetup/modest-easysetup-wizard.c:
3817 (create_account): Add boolean enable parameter, so we can specify FALSE
3818 to create the temporary account.
3819 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3820 (on_before_next): When finishing, when there is a temporary account, just
3822 Also, use a timeout to delay the showing of the dialog until gconf is likely
3823 to return correct information, due to a maemo gconf bug that is fixed in
3824 osso 1.1, but not yet in Bora.
3825 However, the dialog stays on screen after it is destroyed.
3827 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3828 for invalid data when cancelling. Use a hildon note instead of a dialog
3829 to complain about invalid data. Do not show the account-saved note if the
3830 account is disabled (a temporary account that will not really be saved for use
3833 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3835 * src/modest-account-mgr-helpers.h:
3836 * src/modest-account-mgr-helpers.c:
3837 Added modest_account_mgr_unset_default_account(),
3838 Added modest_account_mgr_set_first_account_as_default().
3840 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3841 If it was the default account, unset the default account name.
3843 * src/maemo/modest-account-view-window.c:
3844 (on_delete_button_clicked): If it was the default account,
3845 set the first remaining account as the default instead.
3847 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3848 a NULL account or a NULL default account, to prevent a crash. This should
3849 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3852 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3854 * src/widgets/modest-recpt-editor.c:
3855 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3856 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3857 TODO comment for this. This fixes the build.
3859 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3860 be the best place for it. This will in future update all auto-update accounts,
3861 rather than just the current/default account, when that gconf key exists.
3862 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3863 if there are no accounts, before calling do_send_receive().
3864 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3866 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3867 * src/maemo/modest-main-window-ui.h:
3868 * src/maemo/modest-main-window.c: (on_connection_changed),
3869 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3870 directly, becaue the signal handler does more.
3872 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3874 * src/modest-account-mgr-helpers.c:
3875 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3876 for the case that the account does not exist.
3878 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3879 (equivalent to the modest account name) rather than the tinymail account name
3880 (equivalent to the modest account title - human readable) to get the account data.
3881 Check for null account data to prevent the crash, and add a TODO comment saying that
3882 this needs fixing because it is using the server account name instead of the account name.
3884 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3886 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3887 * src/maemo/modest-account-settings-dialog.c: (show_error),
3889 Use hildon_note_new_information() for informative and error messages,
3890 which seems to be expected for Maemo applications (no documentation that I know of
3891 says this). I am surprised that there is no distinction between info and error
3894 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3896 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3897 it is easy to find where this is used.
3899 * src/maemo/easysetup/modest-easysetup-wizard.c:
3900 (create_page_welcome), (create_page_account_details),
3901 (create_page_user_details), (create_page_complete_easysetup),
3902 (create_page_custom_incoming), (create_page_custom_outgoing),
3903 (create_page_complete_custom):
3904 * src/maemo/modest-account-settings-dialog.c:
3905 (create_page_account_details), (create_page_user_details),
3906 (create_page_incoming), (create_page_outgoing):
3907 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3908 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3909 (modest_connection_specific_smtp_edit_window_init):
3910 * src/maemo/modest-connection-specific-smtp-window.c:
3911 (modest_connection_specific_smtp_window_init):
3912 * src/maemo/modest-signature-editor-dialog.c:
3913 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3914 and scrolling policy as per the Email Application Layout Guide, if I have
3917 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3919 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3920 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3921 which were empty, because these vfuncs have been removed from TnyAccountStore.
3922 This fixes the build.
3924 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3926 * src/maemo/modest-main-window.c:
3927 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3928 showing/hiding it. Added TODO because it probably should not be NULL.
3929 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3930 because unnecessary g_warnings() make degugging difficult.
3932 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3934 * src/maemo/modest-msg-edit-window.c:
3935 (modest_msg_edit_window_select_color),
3936 (modest_msg_edit_window_select_background_color): 2 const corrections and
3937 moving 2 #endifs before closing brackets, to fix the build.
3939 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3941 * src/maemo/easysetup/modest-easysetup-wizard.h:
3942 * src/maemo/easysetup/modest-easysetup-wizard.c:
3943 (modest_easysetup_wizard_dialog_finalize),
3944 (on_button_edit_advanced_settings), (create_page_complete_custom),
3945 (on_response), (create_account):
3946 Implement the Advanced Settings edit button, by saving the account information,
3947 for the Advanded Settings dialog to use directly from gconf, and removing it
3948 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3949 Bug #5533 in the projects.maemo.org bugzilla.
3951 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3953 * src/maemo/modest-msg-view-window.c:
3954 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3955 when opening a message window.
3957 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3959 * src/maemo/easysetup/modest-easysetup-wizard.c:
3960 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3963 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3964 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3965 gconf settings. I probably added more checks than necessary, but that is safer.
3967 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3968 variable to fix the build, but this seems to be used when it is still NULL.
3970 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3972 * src/modest-platform.h:
3973 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3974 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3975 * src/modest-main.c: Implement this function so we can avoid using
3976 maemo-specific API from cross-platform code.
3978 * src/modest-tny-account-store.c:
3979 (get_smtp_specific_transport_account_for_open_connection):
3980 * src/modest-ui-actions.c: (check_for_connection),
3981 (modest_ui_actions_on_item_not_found):
3982 Use modest_platform_connect_and_wait() and put #idefs around other
3983 maemo-specific code, because only maemo currently has a way to
3984 identify connection names.
3986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3988 * src/modest-tny-account-store.h:
3989 * src/modest-tny-account-store.c:
3990 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3991 the connection-specific SMTP server settings in the configuration.
3993 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3995 * src/maemo/modest-main-window.c: (on_connection_changed),
3997 * src/modest-main.c: (main), (start_ui), (send_mail):
3998 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3999 that is what is intended.
4001 * src/modest-ui-actions.c: (action_send), (action_receive),
4002 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4003 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4004 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4005 SMTP server is used when it is specified.
4007 (modest_ui_actions_on_send_receive):
4008 Check that a connection is open before proceeding.
4009 Receive and then send, instead of vice-versa, as per the specification.
4011 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4013 * src/modest-mail-operation.c:
4014 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4015 though I guess it should be something other than NULL.
4017 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4019 * src/maemo/easysetup/modest-easysetup-wizard.c:
4020 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4021 combo twice, to avoid an g_warning and to make it visible again.
4022 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4023 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4024 (already intended) dereference when detaching, because we then recreate the menu.
4025 But I am not sure why the warning was happening, and it is possible that this is a memory
4028 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4030 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4031 and uri_parse_mailto() utility functions.
4032 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4034 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4036 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4038 * src/dbus_api/modest-dbus-api.h:
4039 * src/dbus_api/modest-dbus-callbacks.c:
4040 Use an idle callback to execute the modest code in the application's own thread.
4041 Remove the helloworld example method.
4042 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4043 parsed, and the open-message method is not implemented because this is not yet implemented in
4045 * libmodest-dbus-client/libmodest-dbus-client.c:
4046 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4047 (libmodest_dbus_client_open_message):
4048 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4050 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4051 body without crashing.
4053 * tests/dbus_api/Makefile.am:
4054 * tests/dbus_api/test_mail_to.c:
4055 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4057 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4059 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4060 Added file to fix the build. Sorry.
4062 * src/dbus_api/Makefile.am:
4063 * src/dbus_api/modest-dbus-api.h:
4064 * src/dbus_api/modest-dbus-callbacks.h:
4065 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4066 (modest_dbus_req_handler):
4067 Put constants in a separate header so it can be reused by the
4068 client library, without duplication
4070 * libmodest-dbus-client/Makefile.am:
4071 * libmodest-dbus-client/libmodest-dbus-client.c:
4072 (libmodest_dbus_client_call_helloworld),
4073 (libmodfest_dbus_client_send_mail),
4074 (libmodfest_dbus_client_mailto),
4075 (libmodfest_dbus_client_open_message):
4076 * libmodest-dbus-client/libmodest-dbus-client.h:
4077 (Partly) Implement a send_mail D-Bus method.
4079 * tests/dbus_api/Makefile.am:
4080 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4081 the send_email D-Bus method.
4083 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4087 * libmodest-dbus-client/Makefile.am:
4088 * libmodest-dbus-client/libmodest-dbus-client.c:
4089 * libmodest-dbus-client/libmodest-dbus-client.h:
4090 * tests/dbus_api/Makefile.am:
4091 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4092 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4094 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4096 * src/maemo/easysetup/modest-easysetup-wizard.c:
4097 (create_page_account_details):
4098 * src/maemo/modest-account-settings-dialog.c:
4099 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4100 widgets, because this might not be the default in future versions of the Maemo GTK+.
4101 However, I can not not get capitalization to work even in a simple test case.
4103 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4105 * src/maemo/easysetup/modest-easysetup-wizard.c:
4106 (create_page_custom_incoming), (create_page_custom_outgoing):
4107 * src/maemo/modest-account-settings-dialog.c:
4108 (create_page_account_details), (create_page_incoming),
4109 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4110 instead of using gtk_check_button_with_label(), so they are aligned like the other
4111 widgets, as per the UI spec.
4113 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4115 * src/maemo/easysetup/modest-easysetup-wizard.c:
4116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4117 * src/widgets/modest-validating-entry.c:
4118 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4119 Modest prefix instead of an EasySetup prefix.
4121 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4123 * src/widgets/modest-validating-entry.h:
4124 * src/widgets/modest-validating-entry.c: (on_insert_text),
4125 Added easysetup_validating_entry_set_max_func(), used to set a callback
4126 to call when the max number of characters is reached. GtkEntry has a max-length
4127 already but is silent about it.
4129 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4130 (create_page_account_details), (create_page_user_details),
4132 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4133 (create_page_account_details), (create_page_user_details),
4134 (create_page_outgoing):
4135 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4136 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4137 the UI spec, when the user tries to enter more than the max number of characters.
4139 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4141 * src/maemo/easysetup/modest-easysetup-wizard.c:
4142 (create_page_user_details), (create_page_custom_incoming),
4143 (create_page_custom_outgoing):
4144 * src/maemo/modest-account-settings-dialog.c:
4145 (create_page_user_details), (create_page_incoming),
4146 (create_page_outgoing):
4147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4148 (modest_connection_specific_smtp_edit_window_init):
4149 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4150 not appropriate. Bad Maemo-specific defaults!.
4152 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4154 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4155 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4156 (modest_signature_editor_dialog_set_settings):
4157 Disable the label and textview when the checkbox is disabled, and use the
4158 specified (UI spec) default signature text.
4160 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4163 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4165 * src/modest-defs.h:
4166 * src/modest-account-mgr-helpers.h:
4167 * src/modest-account-mgr-helpers.c:
4168 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4170 * src/maemo/Makefile.am:
4171 * src/maemo/modest-signature-editor-dialog.c:
4172 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4175 * src/maemo/modest-account-settings-dialog.h:
4176 * src/maemo/modest-account-settings-dialog.c:
4177 (modest_account_settings_dialog_finalize), (on_button_signature),
4178 (save_configuration): Use the new dialog when the Edit button is pressed, and
4179 save the changes if necessary, as per the UI spec.
4181 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4183 * src/maemo/Makefile.am:
4184 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4185 based on maemo-develoers email from Dirk.
4187 * src/maemo/easysetup/modest-easysetup-wizard.c:
4188 (create_page_welcome), (create_page_account_details),
4189 (create_page_user_details), (create_page_complete_easysetup),
4190 (create_page_custom_incoming), (create_page_custom_outgoing),
4191 (create_page_complete_custom),
4192 (modest_easysetup_wizard_dialog_init):
4193 * src/maemo/modest-account-settings-dialog.c:
4194 (create_page_account_details), (create_page_user_details),
4195 (create_page_incoming), (create_page_outgoing),
4196 (modest_account_settings_dialog_init):
4197 * src/maemo/modest-connection-specific-smtp-window.c:
4198 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4200 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4202 * src/maemo/easysetup/modest-easysetup-wizard.c:
4203 (create_page_account_details), (create_page_custom_outgoing),
4204 (create_page_complete_custom):
4205 * src/maemo/modest-account-settings-dialog.c:
4206 (create_page_user_details), (create_page_incoming),
4207 (create_page_outgoing):
4208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4209 (modest_connection_specific_smtp_edit_window_init):
4210 Use the correct (UI spec) port min/max, and use horizontal separators,
4213 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4215 * src/maemo/easysetup/modest-easysetup-wizard.c:
4216 (set_default_custom_servernames):
4217 * src/maemo/modest-account-settings-dialog.c:
4218 (create_page_incoming), (on_combo_outgoing_security_changed),
4219 (on_combo_incoming_security_changed), (create_page_outgoing),
4220 (modest_account_settings_dialog_set_account_name),
4221 (save_configuration):
4222 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4223 (on_combo_security_changed),
4224 (modest_connection_specific_smtp_edit_window_init),
4225 (modest_connection_specific_smtp_edit_window_set_connection),
4226 (modest_connection_specific_smtp_edit_window_get_settings):
4227 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4230 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4233 * src/maemo/easysetup/modest-easysetup-wizard.c:
4234 (create_page_custom_outgoing), (create_page_complete_custom):
4235 * src/maemo/modest-account-settings-dialog.c:
4236 (create_page_user_details), (create_page_outgoing):
4237 * src/maemo/modest-account-view-window.c: (button_box_new):
4238 Use changed logical IDs as per the most recent UI spec:
4239 mcen_bd_emailsetup_edit -> mcen_bd_edit
4240 mcen_bd_emailsetup_delete -> mcen_bd_delete
4241 mcen_bd_emailsetup_close -> mcen_bd_close
4243 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4247 * src/dbus_api/Makefile.am:
4248 * src/dbus_api/modest-dbus-callbacks.c:
4249 * src/dbus_api/modest-dbus-callbacks.h:
4250 * src/maemo/modest-platform.c: (modest_platform_init):
4251 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4253 * tests/Makefile.am:
4254 * tests/dbus_api/Makefile.am:
4255 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4257 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4259 * src/maemo/modest-account-settings-dialog.c:
4260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4261 Removed unnecessary includes.
4263 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4265 * src/maemo/easysetup/modest-easysetup-wizard.c:
4266 * src/maemo/modest-account-settings-dialog.c:
4267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4268 * src/widgets/Makefile.am:
4269 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4270 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4271 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4272 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4273 * src/widgets/modest-secureauth-combo-box.c:
4274 * src/widgets/modest-secureauth-combo-box.h:
4275 * src/widgets/modest-serversecurity-combo-box.c:
4276 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4277 made the GObject names more consistent with the rest of the Modest code.
4279 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4281 * src/maemo/easysetup/Makefile.am:
4282 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4283 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4284 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4285 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4286 * src/maemo/easysetup/modest-easysetup-wizard.c:
4287 * src/maemo/easysetup/modest-validating-entry.c:
4288 * src/maemo/easysetup/modest-validating-entry.h:
4289 * src/maemo/modest-account-settings-dialog.c:
4290 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4291 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4292 widgets/ because they are used outside of easysetup too. After checking in,
4293 svn will allow me to rename them too.
4295 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4297 * src/gnome/modest-msg-edit-window.c:
4298 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4299 linker error, to fix the build on the GNOME platform.
4300 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4301 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4302 ifdefed out to avoid a warning.
4304 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4306 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4307 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4308 some alternative for GTK+ 2.6.
4310 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4312 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4314 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4315 specified for EmailAccountsDialog in UI spec.
4317 * src/maemo/easysetup/modest-easysetup-wizard.c:
4318 * src/maemo/easysetup/modest-easysetup-wizard.h:
4319 * src/maemo/modest-account-settings-dialog.c:
4320 * src/maemo/modest-account-settings-dialog.h:
4321 Reuse a member window widget for the connection-specific SMTP server accounts,
4322 so we can tell it to create/save the accounts only if we actually save changes.
4324 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4325 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4326 (modest_connection_specific_smtp_edit_window_get_settings):
4327 Return a struct instance for temporarily remembering the entered data.
4329 * src/maemo/modest-connection-specific-smtp-window.h:
4330 * src/maemo/modest-connection-specific-smtp-window.c:
4331 (modest_connection_specific_smtp_window_finalize),
4332 (modest_connection_specific_smtp_window_fill_with_connections),
4334 (modest_connection_specific_smtp_window_save_server_accounts),
4335 (update_model_server_names): Do not actually save data until asked,
4336 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4338 (on_selection_changed),
4339 (modest_connection_specific_smtp_window_init): Disable the edit
4340 button when nothing is selected.
4342 * src/modest-account-mgr-helpers.c:
4343 * src/modest-account-mgr-helpers.h:
4344 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4347 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4349 * src/modest-account-mgr-helpers.h:
4350 * src/modest-account-mgr-helpers.c:
4351 (modest_account_mgr_get_unused_account_name),
4352 (modest_account_mgr_get_unused_account_display_name): Added these
4353 utility functions, to avoid code duplication.
4355 * src/maemo/easysetup/modest-easysetup-wizard.c:
4356 (create_page_account_details), (create_account):
4357 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4358 (on_combo_security_changed),
4359 (modest_connection_specific_smtp_edit_window_init),
4360 (modest_connection_specific_smtp_edit_window_save_settings):
4361 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4362 * src/maemo/modest-connection-specific-smtp-window.c:
4363 (modest_connection_specific_smtp_window_finalize),
4364 (modest_connection_specific_smtp_window_fill_with_connections),
4365 (on_button_edit), (modest_connection_specific_smtp_window_init):
4366 * src/maemo/modest-connection-specific-smtp-window.h:
4367 Implementing saving of connection-specific server accounts.
4369 But I need to refactor this so we can save the data for each
4370 possible connection-specific account and only actually create the server accounts
4371 when the easysetup finished, or the OK button is pressed on the account settings
4374 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4376 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4377 (on_combo_security_changed):
4378 (modest_connection_specific_smtp_edit_window_init):
4379 Auto-fill the port number as in the account settings.
4381 (modest_connection_specific_smtp_edit_window_set_connection):
4382 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4383 * src/maemo/modest-connection-specific-smtp-window.c:
4384 (fill_with_connections), (on_button_edit),
4385 (modest_connection_specific_smtp_window_init):
4386 Turn the edit window into a dialog to simplify the code, and
4387 set a WM hint as in a GtkDialog, because only a popup can be on top of
4388 another window in Maemo, and popups usually have no WM decoration.
4390 * src/modest-defs.h:
4391 * src/modest-account-mgr-helpers.c:
4392 (modest_account_mgr_set_connection_specific_smtp),
4393 (modest_account_mgr_remove_connection_specific_smtp),
4394 (modest_account_mgr_get_connection_specific_smtp):
4395 * src/modest-account-mgr-helpers.h: Some functions to write the
4396 connection-specific SMTP server information. Not yet used.
4399 * src/widgets/modest-folder-view.c: (text_cell_data):
4400 Fix a warning about an uninitialized variable.
4401 (on_configuration_key_changed): Put an #ifdef around the use
4402 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4404 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4406 * src/maemo/modest-account-settings-dialog.h:
4407 * src/maemo/modest-account-settings-dialog.c:
4408 Added connect_for_modified() utility function to mark the new modified boolean.
4410 (create_page_account_details), (create_page_user_details),
4411 (create_page_incoming), (create_page_outgoing), (on_response),
4412 (modest_account_settings_dialog_init),
4413 (modest_account_settings_dialog_set_account_name):
4414 Only warn about unsaved changes when there are actually unsaved changes.
4416 * src/modest-account-mgr-helpers.c:
4417 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4418 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4419 to get the data from there in future.
4421 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4423 * src/modest-defs.h:
4425 * src/modest-account-mgr-helpers.h:
4426 * src/modest-account-mgr-helpers.c:
4427 Store the security account setting in a single conf key instead of using
4428 the options list, so that the list is left for just the to-be-removed camel hack,
4429 and because gconf_client_set_list() is failing for some reason.
4431 * src/modest-account-mgr.c:
4432 (modest_account_mgr_add_server_account):
4433 * src/maemo/modest-account-settings-dialog.c:
4434 (modest_account_settings_dialog_set_account_name),
4435 (save_configuration): Use the renamed functions.
4438 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4440 * src/widgets/Makefile.am:
4441 * src/widgets/modest-limit-retrieve-combo-box.c:
4442 * src/widgets/modest-limit-retrieve-combo-box.h:
4443 * src/widgets/modest-retrieve-combo-box.c:
4444 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4445 the account settings dialog.
4447 * src/modest-defs.h:
4448 * src/modest-account-mgr-helpers.h:
4449 * src/modest-account-mgr-helpers.c:
4450 (modest_server_account_get_option_secure_auth),
4451 (modest_server_account_set_option_secure_auth):
4452 * src/modest-account-mgr.c:
4453 (modest_account_mgr_add_server_account):
4454 Use the existing AUTH_MECH conf key for the secure-auth setting,
4455 instead of putting it in the list options, because this was actually used already.
4457 * src/maemo/modest-account-settings-dialog.c:
4458 (create_page_account_details),
4459 (modest_account_settings_dialog_set_account_name),
4460 (save_configuration):
4461 * src/maemo/modest-account-settings-dialog.h:
4462 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4463 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4465 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4467 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4468 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4469 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4471 * src/modest-defs.h:
4472 * src/maemo/modest-account-settings-dialog.c:
4473 (create_page_incoming), (on_combo_outgoing_security_changed),
4474 (on_combo_incoming_security_changed), (create_page_outgoing),
4475 (modest_account_settings_dialog_set_account_name),
4476 (save_configuration): Load/Save the port number, and change it when the
4477 security combo changes, to suitable defaults.
4479 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4481 * src/modest-account-mgr.c:
4482 (modest_account_mgr_add_server_account): Set the security and secure-auth
4483 options, and add a comment saying that the other camel-specific options should be
4486 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4488 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4490 * src/modest-tny-account-store.c: (account_list_free),
4491 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4492 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4495 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4497 * src/modest-protocol-info.c:
4498 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4499 is required by our UI spec. Maybe something in our implementation will use this eventually.
4500 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4501 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4502 instead of the previous 0 placeholder.
4504 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4505 secure-auth settings.
4506 * src/modest-account-mgr-helpers.h:
4507 * src/modest-account-mgr-helpers.c:
4508 (modest_server_account_data_get_option_secure_auth),
4509 (modest_server_account_set_option_secure_auth),
4510 (modest_server_account_data_get_option_security),
4511 (modest_server_account_set_option_security): Added this API for getting and setting the security
4512 and secure-auth settings.
4514 * src/maemo/modest-account-settings-dialog.h:
4515 * src/maemo/modest-account-settings-dialog.c:
4516 (modest_account_settings_dialog_finalize), (check_data),
4517 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4518 about changing titles.
4519 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4520 (save_configuration): Save the security and secure-auth settings.
4522 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4523 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4525 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4527 * src/modest-defs.h:
4528 * src/modest-account-mgr.c:
4529 (modest_account_mgr_add_server_account):
4530 Added and used defines for the options key and value pair strings,
4531 that are used so far, though they do not seem to correspond to anything in our
4532 UI specs or ModestProtocol enum.
4534 * src/modest-account-mgr-helpers.h:
4535 * src/modest-account-mgr-helpers.c:
4536 (compare_option_strings_for_name),
4537 (modest_server_account_data_get_option_value),
4538 (modest_server_account_data_get_option_bool),
4539 (modest_account_mgr_get_server_account_option):
4540 Added helper functions for parsing the options GSList.
4542 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4544 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4545 display name is based on the supplied account name.
4546 * src/modest-account-mgr.c:
4547 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4548 with an inefficient, but good-enough, implementation.
4550 * src/maemo/easysetup/modest-easysetup-wizard.c:
4551 (create_page_account_details), (on_before_next), (create_account):
4552 Check for existing display names rather than (non-user-visible) account names, and just
4553 create and set a unique account name at the end.
4555 * src/maemo/modest-account-settings-dialog.c:
4556 (modest_account_settings_dialog_init),
4557 (modest_account_settings_dialog_set_account_name),
4558 (create_page_incoming): Show the display name, instead of the account name.
4559 (on_response): Do some (not all) extra checks, as in the UI spec.
4560 (save_configuration): Save the display name if it was changed.
4562 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4564 * po/en_GB.po: Added needed logical ID and translation.
4565 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4566 (init_view): Made the is-default column clicking work.
4568 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4571 * src/maemo/easysetup/Makefile.am:
4572 * src/maemo/easysetup/modest-easysetup-wizard.c:
4573 (modest_easysetup_wizard_dialog_init):
4574 * src/maemo/easysetup/provider-data-test.keyfile:
4575 * src/maemo/easysetup/provider-data.keyfile:
4576 Moved the provider data file to the new modest-providers-data package and used it from there.
4578 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4580 * src/modest-local-folder-info.c:
4581 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4582 N_() was already used on the static strings, but this just marks it for translation without
4583 using the translation.
4585 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4587 * src/maemo/modest-account-settings-dialog.c:
4588 (create_page_incoming),
4589 (modest_account_settings_dialog_set_account_name):
4590 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4591 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4592 I will do this if nobody else gets there first.
4594 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4596 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4597 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4598 save the security stuff.
4600 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4602 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4603 Set the email address and user fullname, which I now see must be
4606 * src/maemo/modest-account-settings-dialog.h:
4607 * src/maemo/modest-account-settings-dialog.c:
4609 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4610 leave-on-server and authentication.
4611 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4614 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4617 * src/maemo/modest-account-settings-dialog.c:
4618 * src/maemo/modest-account-settings-dialog.h:
4619 Most (but not all) of the widgets are now present as specified by the UI spec.
4620 No changes are yet saved, and some details are not properly shown yet.
4622 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4624 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4626 * src/maemo/Makefile.am:
4627 * src/maemo/modest-account-settings-dialog.c:
4628 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4629 an existing account. Doesn't do much yet.
4631 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4632 Open the accounts settings dialog when Edit is clicked.
4634 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4636 * src/maemo/easysetup/Makefile.am:
4637 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4639 * src/maemo/easysetup/modest-easysetup-wizard.c:
4640 (modest_easysetup_wizard_dialog_init):
4641 Try to get the source directory from the build system,
4642 instead of hard-coding "./" into the source code, when opening our local
4643 copies of the configuration files.
4644 But this still fails when opening the wizard from the Accounts window,
4645 maybe because the working directory seems to change at runtime.
4646 So the wizard will fail the second time unless you copy the files into their
4647 proper locations - see the stdout warnings for the paths.
4649 (create_page_account_details),(on_before_next):
4650 Check for existing non-server accounts instead of server accounts,
4651 so the default account name is useful again, and to prevent trying to
4654 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4655 Show the wizard when New is clicked.
4657 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4658 (init_view): Show the column headers, and show the columns that are
4659 specified in the UI specs. However, something in Maemo's GTK+ prevents
4660 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4661 change the default account. This is despite unsetting the special properties.
4663 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4665 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4666 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4667 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4668 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4669 to make that clearer.
4670 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4672 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4674 * src/maemo/modest-account-view-window.c:
4675 (modest_account_view_window_init),
4676 (modest_account_view_window_new):
4677 Use the same buttons as specified in the
4678 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4679 the existing widgets, which never had a chance of working.
4680 Put the ModestAccountView treeview in a scrolled window.
4681 Do not repeat the initialization in both _init() and _new().
4683 * src/widgets/modest-account-view.c: (update_account_view):
4684 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4685 this widget and window shows no accounts.
4687 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4689 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4691 * src/maemo/easysetup/modest-easysetup-wizard.c:
4692 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4693 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4694 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4697 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4698 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4699 accounts exist yet, as in the UI spec.
4701 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4703 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4705 * src/maemo/Makefile.am:
4706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4707 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4708 New window for editing connection-specific smtp details.
4709 Not fully implemented.
4711 * src/maemo/modest-connection-specific-smtp-window.c:
4712 (modest_connection_specific_smtp_window_finalize) :
4713 unref the tree model.
4714 (on_button_edit): Show the edit window.
4716 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4718 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4721 * src/maemo/Makefile.am:
4722 * src/maemo/modest-connection-specific-smtp-window.c:
4723 * src/maemo/modest-connection-specific-smtp-window.h:
4724 New window for showing the list of connections, for connection-specific
4725 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4726 * src/maemo/easysetup/modest-easysetup-wizard.c:
4727 (create_page_custom_outgoing): Show the new window when the button is clicked.
4729 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4731 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4732 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4733 * src/maemo/modest-msg-edit-window.c:
4734 (modest_msg_edit_window_insert_image):
4735 * src/modest-conf.c: (modest_conf_key_escape):
4736 * src/modest-mail-operation.c:
4737 (modest_mail_operation_send_new_mail):
4738 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4739 (modest_ui_actions_on_new_account):
4740 * src/widgets/modest-attachment-view.c: (update_filename_request):
4741 * src/widgets/modest-mail-header-view.c:
4742 Corrected warnings that were breaking the build, by commenting out unused variables,
4743 and a function, and by including a header.
4745 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4747 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4748 so we can #ifdef around platform-specific code when necessary.
4749 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4750 to allow this to build for the GNOME platform too.
4752 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4754 * src/maemo/easysetup/modest-easysetup-wizard.c:
4755 Added util_increment_name() and used it in create_page_account_details()
4756 to make sure that the default account name is always a new name.
4758 (modest_easysetup_wizard_dialog_init),
4759 (set_default_custom_servernames): Some minor memory management fixes.
4761 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4765 * src/modest-runtime.c: (init_i18n): Restored the translation
4766 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4767 are defined in config.h, and the translations are installed.
4769 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4770 is defined for translation.
4772 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4774 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4776 * src/maemo/easysetup/modest-easysetup-wizard.c:
4777 (modest_easysetup_wizard_dialog_init):
4778 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4779 Use realistic paths (though they should use $prefix generically) to the
4780 mcc_mapping and provider-data.keyfile files which might work when they
4781 are installed by the future version of the operator-wizard package,
4782 and then fallback to paths in our source code, with an explanatory
4785 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4789 * src/maemo/Makefile.am:
4790 * src/maemo/easysetup/: Added files from the previously-exernal
4791 osso-modest-easysetup.
4792 * src/maemo/modest-main-window-ui.h:
4793 * src/modest-ui-actions.c:
4794 * src/modest-ui-actions.h:
4795 Added modest_ui_actions_on_new_account() as a signal handler for the
4796 New Account menu item. It shows the easysetup wizard.
4797 * po/en_GB.po: Added additional needed logical IDs and translations.