1 2007-06-26 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
4 for supported secure authentication methods from server by
5 gtk_dialog_run(), saving CPU time and a potential race condition.
7 2007-06-26 Armin Burgmeier <armin@openismus.com>
9 * src/maemo/modest-maemo-utils.h:
10 * src/maemo/modest-maemo-utils.c: Added a
11 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
12 only error code to tell the calling code when the user canceled the
15 * src/maemo/modest-account-settings-dialog.h:
16 * src/maemo/modest-account-settings-dialog.c:
17 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
18 message if the retrieval of secure authentication methods was canceled
19 by the user. Perform the check before saving anything to configuration
20 to not end up with half-committed configuration changes, do not show
21 a "Saving to configuration failed" note when authentication methods
22 could not be retrieved.
24 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
27 2007-06-26 Murray Cumming <murrayc@murrayc.com>
29 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
30 Only return the first level of folders under accounts, because the
31 osso-global-search UI spec doesn't want the rest.
32 This fixed projects.maemo.org bug NB#61811.
34 2007-06-26 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-tny-account-store.c:
37 * src/modest-tny-account-store.h:
38 Added modest_tny_account_is_memory_card_account().
39 * src/maemo/modest-main-window.c: (create_details_widget):
40 Show the same information items for the memory card as we show for the
41 local-folders, to fix projects.maemo.org bug NB#59307.
43 2007-06-26 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-tny-account-store.c: (get_password):
46 Added some checks for NULL to maybe prevent crashes, though I think
47 it was Philip's last commit that actually prevented the crash here
48 when creating a first new account.
49 But the new account is still not usable (no messages are shown)
50 until a restart of the application.
52 2007-06-26 Murray Cumming <murrayc@murrayc.com>
54 * src/maemo/modest-maemo-global-settings-dialog.c:
55 (idle_select_default_focus):
56 * src/modest-mail-operation.c: (idle_notify_progress),
57 (idle_notify_progress_once), (idle_notify_update_account_queue),
58 (set_last_updated_idle), (update_account_thread),
59 (notify_get_msgs_full), (get_msgs_full_destroyer),
60 (get_msgs_full_thread):
61 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
62 * src/widgets/modest-header-view.c:
63 (idle_notify_headers_count_changed_destroy),
64 (idle_notify_headers_count_changed):
65 Use gdk_threads_enter() and gdk_threads_enter_leave() in
66 all idle handlers, because some other thread could be blocking
67 the GDK lock, so that it can do GUI stuff.
69 2007-06-26 Murray Cumming <murrayc@murrayc.com>
71 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
72 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
73 (on_idle_send_receive), (on_idle_open_default_inbox):
74 * src/maemo/modest-msg-edit-window.c:
75 (modest_msg_edit_window_attach_file_noninteractive):
76 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
77 to prevent a hang. I don't quite understand why these are necessary,
78 beause we should already be in the main loop. I guess something outside
79 of the main loop is taking the lock.
81 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
82 we are really using URIs, and use files that are more likely to exist.
84 2007-06-26 Murray Cumming <murrayc@murrayc.com>
86 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
87 necessary because configure.ac now defines different variables.
89 2007-06-26 Murray Cumming <murrayc@murrayc.com>
91 * libmodest-dbus-client/libmodest-dbus-client.c:
92 * libmodest-dbus-client/libmodest-dbus-client.h:
93 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
94 libmodest_dbus_client_compose_mail() is what things actually use.
96 * src/dbus_api/modest-dbus-api.h:
97 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
98 * tests/dbus_api/Makefile.am:
99 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
102 2007-06-26 Murray Cumming <murrayc@murrayc.com>
104 * src/modest-init.c: (modest_init_local_folders):
105 For memory-card (or other non local-folders) maildir accounts,
106 always create an Archive folder, so that there is somewhere to put
107 messages. This should be less confusing, because the user does not need
108 to guess that the need to create a folder.
110 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
112 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
113 Fixed icon size by using (50, 50) which is the same as defined by
116 2007-06-25 Armin Burgmeier <armin@openismus.com>
118 * src/widgets/modest-window-mgr.c:
120 * configure.ac: Correctly recognize hildon-notify presence and fixed
121 the build without it being installed.
123 2007-06-25 Murray Cumming <murrayc@murrayc.com>
125 * libmodest-dbus-client/libmodest-dbus-client.c:
126 (libmodest_dbus_client_search): Fix the build. Sorry.
127 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
128 (reply_forward_cb): Initialize variables to fix the build.
130 * src/modest-tny-account-store.c:
131 (modest_tny_account_store_get_tny_account_by): Fix the account URI
132 comparison (a silly typo) so that email search results can be opened
133 when there are more than one account.
135 2007-06-25 Murray Cumming <murrayc@murrayc.com>
137 * libmodest-dbus-client/libmodest-dbus-client.c:
138 (libmodest_dbus_client_search),
139 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
140 instead of 1 second, because the search gets folders and messages from
141 the server, which can take a long time. When it times out,
142 osso-global-search will report no results.
144 We need to specify whether we should search only cached information
145 (maybe with a user preference), and the osso-email-search-plugin
146 API should really be improved to allow that option, and to allow results
147 to be delivered asynchronously in batches.
149 2007-06-25 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
152 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
153 GTK_ICON_SIZE_DIALOG is probably the wrong size.
155 2007-06-25 Murray Cumming <murrayc@murrayc.com>
157 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
158 that is an empty string. D-Bus seems to give us these instead of NULL.
160 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
162 * src/dbus_api/modest-dbus-callbacks.c:
163 * src/maemo/easysetup/modest-easysetup-wizard.h:
164 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
165 * src/maemo/modest-connection-specific-smtp-edit-window.c:
166 (modest_connection_specific_smtp_edit_window_init):
167 * src/maemo/modest-maemo-global-settings-dialog.c:
169 * src/maemo/modest-maemo-utils.c:
170 (modest_maemo_utils_setup_images_filechooser):
171 * src/maemo/modest-main-window.c: (create_details_widget):
172 * src/maemo/modest-msg-edit-window.c:
173 (modest_msg_edit_window_attach_file_noninteractive),
174 (modest_msg_edit_window_color_button_change),
175 (modest_msg_edit_window_set_zoom):
176 * src/modest-mail-operation.c: (update_account_thread):
177 * src/modest-tny-account-store.c:
178 * src/modest-tny-account.c:
179 * src/widgets/modest-global-settings-dialog.c:
180 * src/widgets/modest-window.h:
184 2007-06-25 Murray Cumming <murrayc@murrayc.com>
186 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
187 * src/modest-search.c: (modest_search_folder),
188 (modest_search_all_accounts): Actually search only in the specified folder,
189 doing a simple match on the folder ID.
190 * src/modest-search.h: Added a folder field to the ModestSearch struct,
191 and added some documentation.
193 2007-06-22 Armin Burgmeier <armin@openismus.com>
195 * src/maemo/modest-maemo-utils.h:
196 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
197 modest_maemo_utils_get_supported_secure_authentication_methods.
199 * src/maemo/easysetup/modest-easysetup-wizard.c:
200 * src/maemo/modest-account-settings-dialog.c: Show correct error if
201 one occured, not just "Server does not support secure authentication".
203 2007-06-22 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-tny-account-store.c: (get_password):
206 Restored the call to tny_account_set_user() because Philip seems to have
207 stopped this from crashing (by not using the freed string). It still does
208 not work, but now we can test it.
210 2007-06-22 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/modest-msg-edit-window.c: (init_window):
213 Comment out use of an uninitialzed GtkScrolledWindow variable,
214 to fix the build and stop a crash. Yet again.
216 2007-06-22 Murray Cumming <murrayc@murrayc.com>
218 * src/modest-tny-account-store.c: (get_password):
219 Remove the call to tny_account_set_user() because this actually crashes.
220 As mentioned in the last commit, it is known to not work anyway.
222 2007-06-22 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-tny-account-store.c: (get_password):
225 Use tny_account_set_username() to tell tinymail that the username might
226 have changed too. But tinymail ignores this: see projects.maemo.org
228 * src/modest-ui-actions.c:
229 (modest_ui_actions_on_password_requested): Remove the useless attempt to
230 reset the connection when changing the username, and improve the comments.
231 Save the changed username to gconf at least, so it is used when Modest is
234 2007-06-21 Murray Cumming <murrayc@murrayc.com>
236 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
237 Do not use a query, so that we get all folders, including for POP and
238 local-folders. They work as search criteria too.
239 This fixes projects.maemo.org bug NB#57740.
241 2007-06-21 Murray Cumming <murrayc@murrayc.com>
243 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
244 Comment out the use of hildon_notification_set_sound() because it is
245 not declared, to fix the build. Warnings are serious, people.
247 2007-06-21 Armin Burgmeier <armin@openismus.com>
249 * src/maemo/modest-maemo-utils.h:
250 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
251 modest_maemo_utils_get_supported_secure_authentication_methods()
252 to query authentication methods for a specific user. This should fix
253 projects.maemo.org bug NB#61369.
255 * src/maemo/easysetup/modest-easysetup-wizard.c:
256 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
259 2007-06-21 Murray Cumming <murrayc@murrayc.com>
261 * libmodest-dbus-client/libmodest-dbus-client.h:
262 * libmodest-dbus-client/libmodest-dbus-client.c:
263 (modest_dbus_message_iter_get_search_hit),
264 (libmodest_dbus_client_search):
265 Reorganised and commented this.
266 Removed modest_search_hit_free() from the public API because it
269 Added libmodest_dbus_client_get_folders() and
270 modest_folder_result_list_free().
272 * src/dbus_api/modest-dbus-api.h:
273 * src/dbus_api/modest-dbus-callbacks.c:
274 (modest_dbus_req_filter): Commented. Moved most code to
275 on_dbus_method_search() and added on_dbus_method_get_folders().
277 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
278 of the extra D-Bus handler.
280 * tests/dbus_api/Makefile.am:
281 * tests/dbus_api/test_get_folders.c: New test for
282 libmodest_dbus_client_get_folders(). This seems to return an empty list
283 at the moment. That could be the same error that causes the message list
284 to be empty sometimes.
285 This should help with projects.maemo.org bug NB#57740.
287 2007-06-21 Armin Burgmeier <armin@openismus.com>
289 * src/modest-mail-operation.c: Do not call
290 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
291 notify the operation's end after having set the status to CANCELED for
292 the operation queue to listen on. This fixes a deadlock when there
293 were mail operations in the queue during its finalization.
295 * src/modest-singletons.c: Reordered uninitialization of the account
296 manager to happen after the mail operation queue was uninitialized
297 because the mail operation's in the queue might still try to access
298 the account manager (see modest_mail_operation_notify_end()). This
299 fixes a potential crash when terminating the application.
301 2007-06-21 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-search.c:
304 (search_mime_part_and_child_parts): Moved some code here so we
305 can search recursively in child folders.
306 (modest_search_folder): Search in the message as a mime part, instead
307 of just its child mime parts.
308 (read_chunk), (search_mime_part_ogs):
309 Check how many bytes were read, to prevent an endless loop.
310 Searching in message bodies now works. This finishes the fix for
311 projects.maemo.org bug NB#61007.
313 2007-06-20 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
316 Add a g_warning when the item is not a folder.
318 * src/modest-ui-dimming-rules.c:
319 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
320 when selected item is not a folder (for instance, an account), because
321 the UI spec only talks about folders.
322 I am not sure what the UI spec wants, so this might not totally fix
323 projects.maemo.org bug NB#60794.
325 2007-06-20 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
328 (load_from_file): Sort the list. The unsorted list would be more noticeable
329 in non-English locales.
331 * src/maemo/modest-msg-edit-window.c:
332 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
333 warning and fix the build.
335 * src/maemo/modest-progress-bar-widget.c:
336 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
337 avoid a g_warning, and probably to avoid a crash.
339 2007-06-20 Murray Cumming <murrayc@murrayc.com>
341 * src/modest-search.c: (modest_search_folder): Check for a GError
342 when calling tny_folder_get_headers(), to show that this is not the cause
345 2007-06-20 Murray Cumming <murrayc@murrayc.com>
347 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
348 Actually set the body query instead of the subject query.
350 * src/modest-search.c: (search_mime_part_ogs),
351 (search_mime_part_strcmp): Remove extra space from the text/* regex,
352 which would probably cause it to fail if we got this far.
354 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
355 to simplify the code.
356 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
357 be causing search-in-body to fail.
359 2007-06-20 Murray Cumming <murrayc@murrayc.com>
361 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
363 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
364 Better debug message when the folder cannot be found.
365 This should help with fixing projects.maemo.org bug #61287.
366 * src/modest-search.c: (add_hit): Do not leak the furl string.
368 2007-06-20 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-ui-actions.c:
371 (modest_ui_actions_on_folder_selection_changed):
372 Do not special-case TNY_MERGE_FOLDER here, because
373 modest_tny_folder_get_account() already does that. This fixes
374 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
375 shown when the Outbox was selected).
377 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
379 * libmodest-dbus-client/libmodest-dbus-client.c:
380 (_dbus_iter_get_string_or_null): Initialize the string variable in
381 case this helps with Dirk's crash.
383 2007-06-19 Murray Cumming <murrayc@murrayc.com>
385 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
386 though it is not implemented yet (this function is maybe not even used),
387 to avoid breaking ABI in future.
388 * libmodest-dbus-client/libmodest-dbus-client.c:
389 (get_attachments_string): Moved some code into this generic function.
390 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
391 sends email. It is maybe not used.
392 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
393 (on_send_mail): Use attachments.
395 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
396 * src/maemo/modest-msg-edit-window.c:
397 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
398 a filename before using it, to fix projects.maemo.org bug NB#58233.
400 2007-06-19 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
403 Initialize the continue_download variable to fix the build, and probably
404 to fix randome behaviour.
406 2007-06-18 Armin Burgmeier <armin@openismus.com>
408 * src/modest-tny-send-queue.h:
409 * src/modest-tny-send-queue.c: Keep track of the status of messages in
410 the queue so we can later show it in the UI. Replaced
411 modest_tny_send_queue_msg_is_being_sent() by
412 modest_tny_send_queue_get_msg_status().
414 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
416 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
417 gpointer. This probably was not harmful, but just to be sure.
419 2007-06-18 Murray Cumming <murrayc@murrayc.com>
421 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
422 Fix the build, but leave the function broken on Bora, because
423 hildon_uri_action_get_service() does not exist.
424 osso_uri_action_get_service() does not exist either, it seems.
426 2007-06-18 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-tny-account.c:
429 (modest_tny_account_new_from_server_account):
430 Uncommented the url debug output again, because it is useful for
431 debugging, as I said in the comment.
433 2007-06-18 Murray Cumming <murrayc@murrayc.com>
435 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
437 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
438 for Mameo Bora, to fix the build.
440 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
443 Fixed build with hildon < 0.99
445 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
446 Check if the selected account is busy instead of checking all accounts
448 * src/modest-account-mgr-priv.h:
449 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
450 (modest_account_mgr_init), (compare_account_name),
451 (modest_account_mgr_set_account_busy),
452 (modest_account_mgr_account_is_busy):
453 * src/modest-account-mgr.h:
454 Added busy information to the account manager. It possible to
455 set an account to busy or not busy now.
457 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
458 (modest_mail_operation_update_account),
459 (modest_mail_operation_notify_end):
460 Set the account to busy/not busy depending on the operation state.
462 * src/widgets/modest-account-view.c:
463 (modest_account_view_finalize), (get_last_updated_string),
464 (update_account_view), (on_account_busy_changed), (init_view):
465 Show string "Refreshing..." if the account is currently busy.
467 All this fixes projects.maemo.org bug NB#59711
469 2007-06-14 Armin Burgmeier <armin@openismus.com>
471 * src/widgets/modest-attachments-view.h:
472 * src/widgets/modest-attachments-view.c: Added
473 modest_attachments_view_has_attachments() and fixed coordinate
474 transformation in get_att_view_at_coords(). This fixes attachment
477 * src/widgets/modest-msg-view.c: Make use of
478 modest_attachments_view_has_attachments() to decide whether to show
479 attachments in the header.
481 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
483 * src/maemo/modest-connection-specific-smtp-edit-window.c:
484 (on_change), (on_combo_security_changed),
485 (modest_connection_specific_smtp_edit_window_init),
486 (modest_connection_specific_smtp_edit_window_set_connection),
487 (modest_connection_specific_smtp_edit_window_is_dirty):
488 * src/maemo/modest-connection-specific-smtp-edit-window.h:
489 * src/maemo/modest-connection-specific-smtp-window.c:
492 Show an comfirmation dialog for the smpt-edit-window if there are
493 unsaved changes and the user hits cancel.
494 (projects.maemo.org bug NB#60479)
496 2007-06-14 Armin Burgmeier <armin@openismus.com>
498 * src/maemo/easysetup/modest-easysetup-wizard.c:
499 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
500 address" info in banner instead of node, and select all the text as
501 per UI spec. This fixes projects.maemo.org bug NB#60550.
503 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
505 reviewed by: <delete if not using a buddy>
507 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
508 * src/modest-ui-actions.c: (folder_refreshed_cb):
510 2007-06-14 Murray Cumming <murrayc@murrayc.com>
512 * src/widgets/modest-folder-view.c: (filter_row):
513 Explictly filter out the per-account outbox accounts. I don't know why
514 these only sometimes show up, but now they should never show up in the UI.
515 This should fix projects.maemo.org bug NB#60160.
517 2007-06-14 Murray Cumming <murrayc@murrayc.com>
519 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
520 when the toolbar does not exist yet.
521 * src/modest-widget-memory.c: (save_settings_header_view):
522 Added g_warnings() to help us to discover when we are trying to set
523 an empty columns list in gconf.
525 2007-06-14 Murray Cumming <murrayc@murrayc.com>
529 Added modest_init_get_default_header_view_column_ids().
531 * src/modest-widget-memory.c: (restore_settings_header_view):
532 Use the new function to get defaults, if the gconf key is empty,
533 instead of not creating any columns. This seems to fix the
534 empty right-hand pane problems.
536 * src/widgets/modest-header-view.h: Improved documentation.
538 2007-06-13 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
541 Revert the use of the display name as the account name, because this
542 is generally wrong and would break the code that follows.
544 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
546 * src/maemo/easysetup/modest-easysetup-wizard.c:
547 (check_for_supported_auth_methods), (on_before_next),
550 More correct fix for projects.maemo.org bug NB# 58991
551 Do not longer accept AUTH_PASSWORD as secure method and choose
552 correct method when creating the account.
554 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
556 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
557 Fixed projects.maemo.org bug NB# 58991
559 2007-06-13 Murray Cumming <murrayc@murrayc.com>
561 * src/modest-init.c: (modest_init_init_core),
562 (modest_init_local_folders): Fixed compilation errors.
564 2007-06-13 Murray Cumming <murrayc@murrayc.com>
566 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
567 Remove unnecessary lib/include, though it is good in principle when needed.
569 * src/modest-init.c: (modest_init_one_local_folder),
570 (modest_init_local_folders):
571 * src/modest-init.h: Initialize the .modest library for memory cards,
572 instead of just doing nothing for them. This should allow us to create
573 folders there, fixing projects.maemo.org bug NB#59297.
575 2007-06-13 Murray Cumming <murrayc@murrayc.com>
577 * libmodest-dbus-client/libmodest-dbus-client.c:
578 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
579 (libmodest_dbus_client_compose_mail),
580 (libmodest_dbus_client_open_message),
581 (libmodest_dbus_client_send_and_receive),
582 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
584 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
585 (on_idle_open_message), (modest_dbus_req_handler),
586 (search_result_to_message), (modest_dbus_req_filter):
587 * src/modest-search.c: (add_hit), (modest_search_folder),
588 (modest_search_all_accounts): Improved debug messages.
590 * tests/dbus_api/test_open_message.c: (main): Improved comments.
592 * src/modest-tny-account-store.c:
593 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
596 2007-06-13 Murray Cumming <murrayc@murrayc.com>
599 2007-06-12 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-tny-account-store.c: (get_server_accounts):
602 Call modest_tny_local_folders_account_add_merged_outbox_folders()
603 even when there are no accounts, so that the Outbox folder is always
604 visible. This fixes projects.maemo.org bug NB#60158.
606 2007-06-12 Murray Cumming <murrayc@murrayc.com>
608 * src/maemo/modest-main-window.c: (create_details_widget):
609 Use the mcen_va_never logical ID.
611 2007-06-12 Murray Cumming <murrayc@murrayc.com>
613 * src/dbus_api/modest-dbus-api.h:
614 * src/dbus_api/modest-dbus-callbacks.c:
615 (on_idle_open_default_inbox), (on_open_default_inbox),
616 (modest_dbus_req_handler):
617 Added a new OpenDefaultInbox method.
619 * libmodest-dbus-client/libmodest-dbus-client.h:
620 * libmodest-dbus-client/libmodest-dbus-client.c:
621 Added libmodest_dbus_client_open_default_inbox() to call the new
622 dbus method. This should be useful to projects.maemo.org bug NB#57214,
623 though it should maybe be used by a new osso-email-interface function.
625 * tests/dbus_api/Makefile.am:
626 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
629 2007-06-12 Murray Cumming <murrayc@murrayc.com>
631 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
632 NULL, so that the signals get all the keys. This should not actually
633 change any behaviour because we currently update everything when anything
636 2007-06-12 Murray Cumming <murrayc@murrayc.com>
638 * src/widgets/modest-folder-view.c: (text_cell_data),
639 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
640 (find_inbox_iter): If tinymail tells us that the folder is
641 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
642 This causes the inbox to be selected at startup, fixing part of
643 projects.maemo.org bug NB#56305.
645 * src/modest-ui-dimming-rules.c:
646 (modest_ui_dimming_rules_on_tools_smtp_servers):
647 * src/modest-ui-dimming-rules.h: Added a callback function to dim
648 the SMTP servers menu item.
649 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
650 that the SMTP Servers menu item is dimmed when there are no accounts,
651 as a future version of the UI spec will require. This fixes
652 projects.maemo.org bug NB#56305.
654 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
656 * src/maemo/modest-maemo-utils.c:
657 (modest_maemo_utils_get_supported_secure_authentication_methods):
658 Added label to dialog instead of unreadable title
660 * src/maemo/modest-main-window.c: (sync_accounts_cb),
661 (modest_main_window_new):
662 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
665 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
666 * src/modest-account-mgr.h:
667 Added method to avoid code duplication
669 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
670 (modest_ui_actions_on_send_receive):
671 Use modest_account_mgr_has_accounts
673 2007-06-11 Murray Cumming <murrayc@murrayc.com>
675 * src/maemo/easysetup/modest-presets.c:
676 (modest_presets_get_info_server_security): Do not report secure auth
678 * src/modest-protocol-info.c: Use the defines for the gconf key names
679 for secure authentication. This was not working because we were writing
680 Password and reading password, and the check was case sensitive.
681 With this, gmail now works for receiving and sending when created via
684 2007-06-11 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/easysetup/modest-presets.c:
687 (modest_presets_get_info_server_security): Correct the key name for
688 SecureSmtp, because it seems to be case-sensitive.
689 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
690 Do not try to get the 0th notebook page if there are 0 pages, to
693 2007-06-11 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
696 Prevent use of the new notification feature for now, because it currently
697 shows one dialog for each new email, which is annoying.
699 2007-06-11 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
702 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
703 when no country was selected, so that we show the global ones.
704 * src/maemo/easysetup/modest-presets.c:
705 (modest_presets_get_providers): Return only the global providers, not
706 all providers when mmc=0 was requested.
708 2007-06-11 Murray Cumming <murrayc@murrayc.com>
710 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
711 (easysetup_provider_combo_box_fill): Remove debug code that showed the
712 provider ID in the combo.
714 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
715 Do not show the page numbers, because it would be confusing when we add
716 the 2 extra pages for the custom setup, when the user chooses the "Other"
717 provider. This fixes projects.maemo.org bug NB#59028
719 * src/modest-init.c: (modest_init_init_core),
720 (modest_init_local_folders):
722 * src/modest-tny-account.c:
723 (modest_tny_account_new_for_local_folders): Do not create default folders
724 for the memory card. This should fix projects.maemo.org bug NB#59328.
726 2007-06-11 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
729 Free the changed_conf_keys string items. They are already freed in the
730 idle handler if that runs first.
732 2007-06-11 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-ui-actions.c:
735 (modest_ui_actions_on_password_requested): Check that the server name
736 is not NULL, because I just saw a password dialog with (null) as the
739 * src/modest-tny-folder.[h|c]: Added
740 modest_tny_folder_is_memory_card_folder().
741 * src/modest-ui-dimming-rules.c:
742 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
743 menu item for memory cards, as per the UI spec (section 7.4). This should
744 fix projects.maemo.org bug NB#59297.
746 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
748 * src/maemo/modest-main-window.c: (sync_accounts_cb):
749 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
750 is another problem with the code, see Murray's comment at line 772)
752 2007-06-08 Murray Cumming <murrayc@murrayc.com>
754 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
755 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
756 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
757 (load_from_file), (easysetup_country_combo_box_init),
758 (easysetup_country_combo_box_get_active_country_ids),
759 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
760 instead of just one ID, to avoid duplicate country names in the UI.
762 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
763 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
764 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
765 a single ID, avoiding duplicate providers.
766 * src/maemo/easysetup/modest-easysetup-wizard.c:
767 (on_combo_account_country): Adapt to use a list.
769 2007-06-08 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
772 keys changed in the last X seconds.
774 * src/modest-account-mgr.h:
775 * src/modest-account-mgr.c: (on_timeout_notify_changes),
776 (on_key_change), (modest_account_mgr_class_init),
777 (modest_account_mgr_init), (modest_account_mgr_finalize):
778 As the keys are changed, save them in a GSList* and signal that GSList*
779 further every X seconds, to batch changes, to allow us to do just one
780 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
781 bug NB#56941 and other (UI-blocking) delays when changing account settings.
783 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
784 changed signal signature.
786 * src/modest-conf.c: (modest_conf_set_list),
787 (modest_conf_on_change): Reenable notification.
789 (modest_conf_maemo_fake_on_change): Comment out the hack that
790 notified immediately instead of asynchronously.
792 * src/widgets/modest-account-view.h:
793 * src/widgets/modest-account-view.c:
794 (update_account_view): Select the previously-selected account ID,
795 if possible. This fixes projects.maemo.org bug NB#56933.
797 (on_account_changed), (on_account_removed),
798 (modest_account_view_select_account):
800 Remove the block/unblock functions
801 because they were not useful.
803 * src/maemo/modest-account-view-window.c:
804 (on_delete_button_clicked), (on_edit_button_clicked),
805 (on_new_button_clicked): Remove the use of the non-working block/unblock.
807 2007-06-08 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
810 Improve the error dialog to show Incorrect Account Settings, which seems
811 clearer, and say that the internal error message (to be removed from the
812 dialog later) is often misleading.
813 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
815 * src/modest-tny-account.c:
816 (modest_tny_account_new_from_server_account): Uncomment the printf of the
817 URL because this is so useful for debugging on the device.
819 * src/widgets/modest-serversecurity-combo-box.c:
820 (modest_serversecurity_combo_box_fill): Correct a logical ID.
822 2007-06-08 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-mail-operation.c:
825 (modest_mail_operation_send_new_mail):
826 Added a comment about a nasty but apparently harmless message. Details
827 added to the wiki g_warnings() page.
829 2007-06-08 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
832 (modest_tny_send_queue_class_init):
833 Do not use the priv struct because it is empty, to avoid g_warnings
834 about a non-existant priv struct.
836 * src/modest-tny-account-store.c:
837 (modest_tny_account_store_get_server_account),
838 (modest_tny_account_store_get_transport_account_for_open_connection
839 ): Do not try to get transport server accounts for local folders,
840 because they don't have any. This avoids a g_warning().
842 * src/maemo/modest-main-window.c:
843 (modest_main_window_notify_send_receive_initied),
844 (on_configuration_key_changed):
845 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
847 * src/modest-mail-operation.c:
848 (modest_mail_operation_update_account):
849 * src/modest-tny-account-store.h:
850 * src/modest-tny-account.c:
851 (modest_tny_account_get_special_folder),
852 (modest_tny_account_new_for_local_folders),
853 (modest_tny_account_new_for_per_account_local_outbox_folder):
854 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
855 * src/modest-tny-local-folders-account.c:
856 (add_account_folders_to_merged_folder):
857 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
858 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
859 (modest_ui_actions_on_send):
860 * src/widgets/modest-folder-view.c: (update_model):
861 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
862 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
863 modest_tny_account_store_get_tny_account_by_account() to
864 modest_tny_account_store_get_server_account() to make the code clearer.
866 2007-06-07 Marcus Bauer <marcusb@openismus.com>
868 * src/dbus_api/modest-dbus-api.h:
869 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
870 * src/maemo/modest-msg-edit-window.c:
871 (modest_msg_edit_window_attach_file_noninteractive):
872 added g_warning in case the file to be attached does not exist
873 * tests/dbus_api/test_compose_mail.c: (main):
874 removed obsolete comment, added generic files as test case
876 2007-06-07 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-tny-account-store.c: (get_server_accounts):
879 Create the local folders account only once, not once for each outbox, and
880 not only when there are some outboxes.
882 2007-06-07 Murray Cumming <murrayc@murrayc.com>
884 * src/widgets/modest-folder-view.c: (update_model): Comment out some
885 code that is causing a crash at startup. Sergio says that he is fixing this.
887 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
889 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
890 * src/maemo/modest-account-settings-dialog.c:
891 (create_page_outgoing),
892 (modest_account_settings_dialog_set_account_name),
893 (save_configuration):
894 - Fixed handling of the "Use secure authentication" toggle to comply with
895 the ui specification. See also projects.maemo.org bug NB#58400
897 - Restore the Secure connection setting combo correctly when loading
900 * src/maemo/modest-maemo-utils.c:
901 (on_camel_account_get_supported_secure_authentication),
902 (modest_maemo_utils_get_supported_secure_authentication_methods):
903 Fixed a crasher if operation is canceled
905 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
906 (modest_protocol_info_auth_is_secure):
907 * src/modest-protocol-info.h:
909 Added two new methods to determine if a protocol/auth method is secure/encrypted in
910 the sense of the "Use secure authentication" toggle.
912 2007-06-07 Murray Cumming <murrayc@murrayc.com>
914 * src/modest-tny-account-store.h:
915 * src/modest-tny-account-store.c:
916 Added modest_tny_account_store_get_local_folders_account().
918 * src/modest-tny-folder.h:
919 * src/modest-tny-folder.c:
920 (modest_tny_folder_get_account):
921 Added this replacement for tny_folder_get_account() which returns
922 the local-folders account for TnyMergeFolders, to avoid the
923 warning about the unimplemented get_account_func() vfunc().
925 (modest_tny_folder_get_rules),
926 * src/modest-ui-actions.c:
927 (modest_ui_actions_on_folder_selection_changed):
928 * src/modest-mail-operation.c:
929 (modest_mail_operation_remove_folder),
930 (modest_mail_operation_xfer_folder),
931 (modest_mail_operation_rename_folder),
932 (modest_mail_operation_get_msg),
933 (modest_mail_operation_get_msgs_full),
934 (modest_mail_operation_remove_msg),
935 (modest_mail_operation_xfer_msgs),
936 (modest_mail_operation_refresh_folder):
937 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
939 2007-06-07 Murray Cumming <murrayc@murrayc.com>
941 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
942 (modest_server_account_set_security):
943 * src/modest-defs.h: Add comments explaining that our
944 UI spec means TLS when it says Normal, so these do not look like errors.
946 * src/modest-tny-account.c:
947 (modest_tny_account_new_from_server_account): Use the new tinymail
948 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
949 for TLS. This should fix projects.maemo.org bug NB#58460.
951 2007-06-06 Murray Cumming <murrayc@murrayc.com>
953 * src/maemo/easysetup/modest-easysetup-wizard.c:
954 (create_account): Correct the position of the gconf sanity check warning.
955 (on_button_edit_advanced_settings): Show the dialog immediately, instead
956 of using the g_idle_add() hack, because this does not seem to be necessary
957 on osso 1.1. It might even work on Maemo Bora if the problems were actually
958 caused by something other than maemo's gconf.
959 This fixes projects.maemo.org bug #59022.
961 2007-06-06 Murray Cumming <murrayc@murrayc.com>
963 * src/modest-account-mgr-helpers.c:
964 (modest_account_mgr_get_default_account): Do not check that the account
965 exists if there is no default account (NULL), to fix a runtime warning.
967 2007-06-06 Murray Cumming <murrayc@murrayc.com>
969 * src/widgets/modest-folder-view.c: (update_model):
970 Do not unref the treemodel before we have finished with it.
971 This prevents a valgrind warning and an occasional crash at startup.
973 2007-06-06 Marcus Bauer <marcusb@openismus.com>
975 * libmodest-dbus-client/libmodest-dbus-client.h:
976 added libmodest_dbus_client_compose_mail()
977 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
979 added functions needed for SendAsMail() functionality
980 * src/maemo/modest-msg-edit-window.c:
981 (modest_msg_edit_window_attach_file_noninteractive):
982 non interactively attaching files to message edit window
983 * src/widgets/modest-msg-edit-window.h:
984 * tests/dbus_api/Makefile.am:
985 added test_compose_mail.c
986 * tests/dbus_api/test_compose_mail.c: (main):
988 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
990 * src/modest-account-view.c:
991 Fixed bug projects.maemo.org bug NB#59307
993 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
995 * src/maemo/easysetup/modest-easysetup-wizard.c:
996 (get_serverport_incoming), (on_before_next), (create_account):
997 * src/maemo/modest-account-settings-dialog.c:
998 (modest_account_settings_dialog_set_account_name):
999 * src/maemo/modest-maemo-utils.c:
1000 (on_camel_account_get_supported_secure_authentication_status),
1001 (on_camel_account_get_supported_secure_authentication),
1002 (on_secure_auth_cancel),
1003 (modest_maemo_utils_get_supported_secure_authentication_methods):
1005 Implemented security authentication for settings and easysetup.
1007 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1009 * src/maemo/modest-main-window.c: (create_details_widget):
1010 Show the total size for memory card accounts too, instead of showing
1011 the name again. Fixes bug projects.maemo.org bug NB#59307.
1013 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-tny-simple-folder-store.c:
1017 * src/modest-tny-simple-folder-store.h: Removed.
1019 * src/modest-tny-local-folders-account.h
1020 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1021 for the local-folders maildir, with an extra TnyMergedFolder containing
1022 the folders of the per-account outbox store accounts.
1023 * src/modest-tny-account-store.c: (get_server_accounts):
1024 Add the outboxes to the special local folders account after creating it.
1026 * src/modest-tny-account.c:
1027 (modest_tny_account_new_for_local_folders): Create the derived
1028 account when creating the main local-folders account.
1030 * src/maemo/modest-main-window.c: (create_details_widget),
1031 (modest_main_window_set_contents_style):
1032 Adapted to the use of the derived account instead of the folder store.
1034 * src/modest-ui-actions.c:
1035 (modest_ui_actions_on_folder_selection_changed):
1036 * src/modest-ui-dimming-rules.c:
1037 (modest_ui_dimming_rules_on_new_folder):
1038 * src/widgets/modest-folder-view.c: (text_cell_data),
1039 (icon_cell_data), (filter_row), (update_model),
1040 (get_cmp_rows_type_pos):
1043 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1044 Do not get the priv struct, because no priv struct has been set,
1045 to avoid a runtime warning.
1047 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1048 #ifelse with #else, to fix a warning, to fix the build.
1051 2007-06-05 Christian Kellner <ckellner@openismus.com>
1053 * libmodest-dbus-client/libmodest-dbus-client.c:
1054 Fix small typo in doc (why do you always see them
1055 AFTER committing stuff?)
1058 2007-06-05 Christian Kellner <ckellner@openismus.com>
1060 * libmodest-dbus-client/libmodest-dbus-client.c:
1061 (libmodest_dbus_client_search):
1062 Initialize hit list with NULL. Also set folder list
1063 to "" if NULL was supplied.
1066 2007-06-03 Christian Kellner <ckellner@openismus.com>
1068 * libmodest-dbus-client/libmodest-dbus-client.c:
1069 (modest_search_hit_list_free):
1070 Make it save to call it with NULL.
1072 * src/dbus_api/modest-dbus-callbacks.c:
1073 * src/modest-search.c:
1074 Return full ModestSearchHits as the search result list not TnyHeader
1075 since can't be around withouth the correspoding TnyFolder.
1077 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1079 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1080 Added currently commented code to check for secure auth
1082 * src/maemo/modest-account-settings-dialog.c: (on_response),
1083 (save_configuration), (show_ok):
1084 Fixed projects.maemo.org bugs NB #59248 and #59251
1086 * src/maemo/modest-maemo-utils.c:
1087 (on_camel_account_get_supported_secure_authentication_status),
1088 (on_camel_account_get_supported_secure_authentication),
1089 (modest_maemo_utils_get_supported_secure_authentication_methods):
1090 * src/maemo/modest-maemo-utils.h:
1091 Moved get_supported_secure_authentication() method here to be able
1092 to use it from easysetup wizard.
1094 * src/modest-pair.c: (on_pair_compare_as_string):
1095 Should compare string with first part of pair and not
1096 strcmp pairs which will crash.
1098 * src/modest-protocol-info.c:
1099 (modest_protocol_info_protocol_is_store):
1100 * src/modest-protocol-info.h:
1101 Added modest_protocol_info_get_auth_protocol_name()
1103 2007-06-03 Armin Burgmeier <armin@openismus.com>
1105 * src/modest-mail-operation.c:
1106 (modest_mail_operation_get_msgs_full): Set priv->account also when
1107 only retrieving a single message. This avoids a crash when canceling
1110 (modest_mail_operation_notify_end): Do not explicitely remove the
1111 operation from the queue but only emit the progress_changed signal.
1112 The queue itself listens to that signal to remove the operation when
1113 it is finished. This reduces coupling and removes a potential deadlock
1114 when modest_mail_operation_notify_end() is called from the queue
1115 itself. If that is a problem performance-wise, I would suggest to
1116 implement a status-changed signal or something.
1118 * src/modest-mail-operation-queue.c: Make sure to never call a
1119 function from another file while the queue is locked. This (hopefully)
1120 fixes another deadlock when exiting the application while retrieving
1123 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1125 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1126 Fixed build if libogs is not available
1128 2007-06-03 Christian Kellner <ckellner@openismus.com>
1130 * libmodest-dbus-client/libmodest-dbus-client.h:
1131 * libmodest-dbus-client/libmodest-dbus-client.c:
1132 (libmodest_dbus_client_delete_message):
1133 Implement deletion of messages (Client side).
1135 (modest_search_hit_free),
1136 (modest_search_hit_list_free):
1137 Utility functions to free the result hits.
1139 * src/dbus_api/modest-dbus-api.h:
1140 * src/dbus_api/modest-dbus-callbacks.c:
1141 (on_delete_message),
1142 (modest_dbus_req_handler):
1143 Implement deletion of messages (Server side).
1145 * tests/dbus_api/test_search.c: (main):
1148 * tests/dbus_api/Makefile.am:
1149 * tests/dbus_api/test_delete_message:
1150 Add little test for the message deletion logic
1152 2007-06-03 Armin Burgmeier <armin@openismus.com>
1154 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1155 when the operation queue was not empty. projects.maemo.org bug
1158 2007-06-03 Armin Burgmeier <armin@openismus.com>
1160 * src/widgets/modest-account-view.c
1161 (on_account_default_toggled): Toggle default account column
1162 explicitely instead of waiting for gconf notification (which is
1163 currently ignored). This should fix projects.maemo.org bug NB#56910
1164 for now. It should probably be removed when gconf notifications are
1167 2007-06-03 Christian Kellner <ckellner@openismus.com>
1169 * libmodest-dbus-client/libmodest-dbus-client.c:
1170 Removed debugging spew.
1172 * src/dbus_api/modest-dbus-callbacks.c:
1173 Added debugging info.
1175 * src/modest-search.c:
1176 (modest_search_all_accounts):
1177 Use tny_account_store_get_accounts () on the account store
1178 to get all accounts which is the way to get all accounts.
1180 * tests/dbus_api/test_search.c: (main):
1181 Make it possible to supply the search term on the command line.
1183 2007-06-03 Christian Kellner <ckellner@openismus.com>
1185 * libmodest-dbus-client/libmodest-dbus-client.c:
1186 * libmodest-dbus-client/libmodest-dbus-client.h:
1187 Implement searching for mesages over raw dbus. (Client side)
1189 * src/dbus_api/Makefile.am:
1190 * src/dbus_api/modest-dbus-api.h:
1191 * src/dbus_api/modest-dbus-callbacks.c:
1192 * src/dbus_api/modest-dbus-callbacks.h:
1193 Search framework (Server side). Also implement on_idle_open_message().
1195 * src/maemo/modest-platform.c: (modest_platform_init):
1196 Prepare for raw dbus/osso rpc interaction.
1198 * src/modest-search.h:
1199 Changed minsize from unspecific guint to guint32.
1201 * src/modest-search.c:
1203 Added strange hack which magically made tnymail work.
1205 (modest_search_folder),
1206 (modest_search_account),
1207 (modest_search_all_accounts):
1208 Implement helper functions to search all accounts, specific account
1211 * tests/dbus_api/Makefile.am:
1212 * tests/dbus_api/test_open_message.c:
1213 Read url to open from commandline.
1215 * tests/dbus_api/test_search.c:
1216 Implement small test for dbus search stuff
1218 2007-06-02 Armin Burgmeier <armin@openismus.com>
1220 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1221 include account type and account title. This fixes projects.maemo.org
1224 * src/maemo/modest-account-view-window.c: Set a title for the window.
1226 2007-06-02 Armin Burgmeier <armin@openismus.com>
1228 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1229 incoming and outgoing server name based on email address and server
1230 types as long as the names have not been edited manually. This fixes
1231 projects.maemo.org bug NB#58671.
1233 2007-06-02 Armin Burgmeier <armin@openismus.com>
1235 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1236 server type cannot be changed in future to the incoming details page
1237 when creating an account. This fixes projects.maemo.org bug NB#59029.
1239 2007-06-02 Armin Burgmeier <armin@openismus.com>
1241 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1242 and assigned max width chars so that they wrap instead of being
1243 truncated. Fixes projects.maemo.org bug NB#56126.
1245 2007-06-02 Armin Burgmeier <armin@openismus.com>
1247 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1248 introductory note to the connection specific smtp servers dialog, as
1249 section 8.12 of the email UI specification requires. This fixes
1250 projects.maemo.org bug NB#59212.
1252 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1254 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1255 Check for running mail operations, and offer to cancel them, as per the UI
1256 spec. This fixes projects.maemo.org bug NB#59041 .
1257 However, I suspect that tinymail may still use the network connection
1258 in ways that we cannot detect or cancel. But it should at least adapt to
1259 changes fairly well.
1261 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1263 * src/modest-tny-account-store.c: (recreate_all_accounts),
1264 (get_cached_accounts), (get_server_accounts): Do more sensible
1265 ref-counting of the temporarily-cached outbox accounts list. This seems
1266 to fix a crash when entering the password when the password was wrong.
1268 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1270 * src/gnome/modest-main-window.c: (connect_signals):
1271 * src/modest-tny-account-store.c: (get_password),
1272 (modest_tny_account_store_alert): Added comments and clues and
1273 commented-out code about how we currently fail to deal with connection
1274 errors and wrong passwords, and how we should.
1276 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1278 * src/widgets/modest-retrieve-combo-box.c:
1279 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1280 This fixes projects.maemo.org bug NB#58472 .
1282 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/easysetup/modest-easysetup-wizard.c:
1285 (create_page_complete_easysetup):
1286 (create_page_complete_custom): Correct the last commit,
1287 putting the correct sentences in the correct pages.
1289 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1291 * src/maemo/easysetup/modest-easysetup-wizard.c:
1292 (create_page_complete_custom): Show the second sentence of text
1293 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1296 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1299 Set the leave-on-server conf key by default. This fixes
1300 projects.maemo.org bug NB#59258 .
1302 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1304 * src/maemo/modest-account-view-window.c:
1305 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1306 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1309 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/easysetup/modest-easysetup-wizard.c:
1312 (create_caption_new_with_asterisk):
1313 * src/maemo/modest-account-settings-dialog.c:
1314 (create_caption_new_with_asterisk):
1315 Uncomment the code to add the asterisk, because they are no longer in the
1316 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1317 (update_incoming_server_title): Add an asterisk here too.
1319 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/modest-maemo-global-settings-dialog.c:
1322 (current_connection): Check that we are even connected before trying to
1323 get the current connection name, to prevent a warning.
1325 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1326 Change the comments because tny_maemo_conic_device_connect() is now meant to
1328 * src/modest-mail-operation.c:
1329 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1330 make sure we have a connection and fail if we can't connect.
1332 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/modest-main-window.c:
1335 (on_account_store_connecting_finished): Do not try to get the
1336 connection ID if we are not really connected. I am surprised that
1337 this signal handler is called when we are not connected.
1339 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-error.h:
1342 * src/modest-ui-actions.c:
1343 (modest_ui_actions_get_msgs_full_error_handler):
1344 Renamed an enum, added comments, added an enum
1345 for retrieve-limit errors.
1347 * src/modest-mail-operation.c: (foreach_add_item),
1348 (internal_folder_observer_update), (update_account_thread),
1349 (modest_mail_operation_get_msgs_full):
1350 (modest_mail_operation_update_account),
1351 Added comments about how this works, and some code that should
1352 (but does not) check the retrieve-limit. See the TODO comment.
1354 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1356 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1357 Initialize help_id to fix the build. Warnings are good.
1359 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1361 * src/widgets/modest-hbox-cell-renderer.c:
1362 (modest_hbox_cell_renderer_append):
1363 * src/widgets/modest-vbox-cell-renderer.c:
1364 (modest_vbox_cell_renderer_append):
1365 Fix the last commit by doing an extra ref.
1367 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1369 * src/widgets/modest-hbox-cell-renderer.c:
1370 (modest_hbox_cell_renderer_append):
1371 * src/widgets/modest-vbox-cell-renderer.c:
1372 (modest_vbox_cell_renderer_append):
1373 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1374 to fix the build with Maemo Bora.
1375 However, there seems to be a remaining crash, probably due to reference
1378 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1380 * src/modest-tny-account.c:
1381 (modest_tny_account_new_for_local_folders):
1382 Use hildon_file_system_info_async_new() to get a better name for
1383 the memory card account, setting it as the account name.
1384 The timing seems to work, but this is probably
1385 not the best place to do this. See the TODO comment.
1386 * src/maemo/modest-main-window.c: (create_details_widget):
1387 * src/widgets/modest-folder-view.c: (text_cell_data):
1388 Use the tny account name instead of hardcoding a name.
1390 2007-05-30 Christian Kellner <ckellner@openismus.com>
1392 * src/modest-search.c: (modest_search):
1393 Correctly set part_search_func even if we have already parsed
1394 the query and thus a valid OgsTextSearcher object.
1396 2007-05-30 Christian Kellner <ckellner@openismus.com>
1399 Search and check for libogs.
1402 Incooparte the ogs build env.
1404 * src/modest-mime-part-search-stream.c:
1405 * src/modest-mime-part-search-stream.h:
1406 Removed since we do the real searching now in modest-search.c.
1408 * src/modest-search.c:
1409 * src/modest-search.h:
1410 Implement support for ogs. We use that if available and requested
1411 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1412 should now handle the corner case when the search term is spread
1413 across multiple reads.
1414 Also the logic in modest_search () was corrected to search all
1415 requested fields until one is found.
1417 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1419 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1421 * src/modest-init.h:
1422 * src/modest-init.c: Made modest_init_local_folders() take a
1423 path and be public so we can iniitialize maildir folders on
1426 * src/modest-local-folder-info.h:
1427 * src/modest-local-folder-info.c:
1428 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1430 * src/modest-tny-account.c:
1431 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1432 still means the standard local-folders path on the local volume.
1434 * src/modest-tny-account-store.c:
1435 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1436 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1437 all accounts when that happens.
1438 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1439 this too, so it shows up in the treeview.
1441 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/modest-maemo-global-settings-dialog.c:
1444 (current_connection):
1445 * src/widgets/modest-global-settings-dialog.c:
1446 (current_connection_default):
1447 Use the enum values instead of 0, 1 and -1,
1448 to make the code clearer.
1450 * src/modest-account-mgr-helpers.c:
1451 (modest_account_mgr_get_connection_specific_smtp): Make this code
1454 * src/modest-runtime.h:
1455 * src/modest-runtime.c:
1456 Added modest_runtime_remove_all_send_queues().
1457 * src/maemo/modest-main-window.c:
1458 (on_account_store_connecting_finished): Recreate the send queues,
1459 using the appropriate transport accounts for this new connection.
1460 Some futher adapting might be needed if the old send queues are not
1461 automatically stopped at this point.
1463 * src/modest-tny-account-store.c: (get_server_accounts):
1464 Create the connection-specific transport accounts, so that they can
1465 be found later by their ID.
1467 * src/modest-tny-account.h:
1468 * src/modest-tny-account.c:
1469 Added modest_tny_account_new_from_server_account_name().
1470 modest_tny_account_new_from_server_account(): Do not create the
1471 send queues here, because they will be
1472 recreated anyway when the connection changes for the first time.
1474 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-local-folder-info.h:
1477 * src/modest-local-folder-info.c:
1478 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1479 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1480 tbox_folder): Take a modest account name instead of a server TnyAccount,
1481 so we can have per-modest-account rather than per-transport-account
1483 We must make sure that we change or recreate the exisitng send queues
1484 when the connection changes for connection-specific transport accounts.
1486 * src/modest-tny-account-store.c:
1487 (create_per_account_local_outbox_folders): Create outboxed per modest
1488 account, not per transport account.
1490 * src/modest-tny-account.h:
1491 * src/modest-tny-account.c:
1492 (modest_tny_account_get_special_folder): For outboxes, get the
1493 parent modest account name. The account is ignored for other folders.
1494 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1495 modest account name rather than a server TnyAccount.
1497 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1499 * src/modest-tny-account.c:
1500 (modest_tny_account_new_from_server_account):
1501 Call modest_runtime_get_send_queue() immediately after creating transport
1502 accounts, so that they start trying to send email from the outbox as soon
1503 as possible at startup. This is probably what we want.
1505 * src/modest-mail-operation.c: (update_account_thread):
1506 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1507 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1508 * src/modest-tny-send-queue.h:
1509 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1510 (modest_ui_actions_on_send):
1511 Added comments about how sending works, though it needs some more work.
1513 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1515 * src/modest-tny-account.c:
1516 (modest_tny_account_get_special_folder): Add TODO because this fails when
1517 the network is busy.
1518 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1519 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1520 Do not try to show this window when there is no active account. The UI
1521 specs does not tell us what to do in this case.
1523 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1527 * src/maemo/Makefile.am:
1528 * src/widgets/Makefile.am: Some dist fixes.
1530 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1532 * src/maemo/modest-connection-specific-smtp-window.c:
1533 (on_button_edit): Make the code clearer, to prevent a double free.
1535 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/modest-account-settings-dialog.c:
1538 (modest_account_settings_dialog_set_account_name),
1539 Check the connection-specific smtp servers checkbox if there are any.
1541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1542 (modest_connection_specific_smtp_edit_window_init):
1543 Start with a suitable port number.
1545 * src/modest-account-mgr-helpers.h:
1546 * src/modest-account-mgr-helpers.c: Added
1547 modest_account_mgr_get_has_connection_specific_smtp().
1549 (modest_account_mgr_set_connection_specific_smtp),
1550 (modest_account_mgr_remove_connection_specific_smtp),
1551 (modest_account_mgr_get_has_connection_specific_smtp),
1552 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1553 connection-specific smtp server accounts in the account, rather than
1554 the server account conf dir.
1556 This fixes bug projects.maemo.org bug NB#58263 .
1558 * src/modest-tny-account-store.c:
1559 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1560 if there are no server accounts yet, to prevent an infinite loop when there
1561 are no accounts. Document that one must be called before the other.
1563 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-account-mgr-helpers.c:
1566 (modest_account_mgr_get_default_account): Make sure that at least
1567 one account is always the default, if there are any enabled accounts.
1568 This is just a sanity check that shouldn't be necessary.
1570 * src/modest-account-mgr-priv.c:
1571 (_modest_account_mgr_account_from_key): Unescape the conf key to
1572 get the real account name. For instance, this is an issue if a space
1573 was in the account name, which can happen because the account name
1574 is generated from the display name.
1575 (_modest_account_mgr_get_account_keyname): Always escape the
1577 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1578 Unescape the conf keys to get the real account names.
1580 For instance, previously the is-default radio button in the accounts
1581 list was not checked for any accounts at first. This fixes that,
1582 and might fix several similar bugs.
1584 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1586 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1587 Removed some debug printfs.
1589 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1591 Modest on-disk outbox directories are now here, for instance:
1592 $HOME/.modest/outboxes/<account-id-1>/outbox
1593 $HOME/.modest/outboxes/<account-id-2>/outbox
1595 $HOME/.modest/local-folders/outbox
1596 so we can have a separate outbox for each account.
1597 But they are shown as one outbox in the GtkTreeView, by using a
1598 TnyMergeFolder in a ModestTnySimpleFolderStore.
1601 * src/modest-tny-simple-folder-store.c:
1602 * src/modest-tny-simple-folder-store.h:
1603 Added ModestTnySimpleFolderStore, used to contain folders from
1604 other folder stores, such as other accounts.
1606 * src/modest-tny-outbox-account.h:
1607 * src/modest-tny-outbox-account.c:
1608 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1609 used for the per-account local outbox folders.
1611 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1612 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1613 only use this (internally) now for the non-outbox local folders.
1615 * src/modest-init.h:
1616 * src/modest-init.c: Added modest_init_one_local_folder(), for
1617 setting up the directory structure for each local folder.
1619 * src/modest-local-folder-info.c:
1620 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1621 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1623 * src/modest-local-folder-info.h:
1624 * src/modest-tny-account-store.c: (on_account_removed),
1625 (on_account_changed), (create_per_account_local_outbox_folders),
1626 (get_server_accounts), (modest_tny_account_store_get_accounts),
1627 (modest_tny_account_store_get_tny_account_by_account),
1628 (modest_tny_folder_store_is_virtual_local_folders):
1630 * src/modest-tny-account.h:
1631 * src/modest-tny-account.c:
1632 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1633 to create an on-disk per-account local outbox folder for each
1635 (create_per_account_local_outbox_folders): Create a local outbox folder
1636 for each transport account.
1637 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1638 for all local folders.
1640 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1641 instead of using g_object_get/set() directly. It is clearer.
1643 (modest_tny_folder_store_get_message_count),
1644 (modest_tny_folder_store_get_local_size
1645 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1646 because we now use these with non-acount folder stores.
1648 (modest_tny_account_get_special_folder),
1649 (modest_tny_account_new_from_server_account),
1650 (modest_tny_account_new_from_account):
1651 (recurse_folders): Adjust to the new outbox system.
1653 * src/modest-tny-folder.h:
1654 * src/modest-tny-folder.c:
1655 (modest_tny_folder_is_local_folder),
1656 (modest_tny_folder_get_local_folder_type),
1657 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1659 * src/widgets/modest-main-window.h:
1660 * src/maemo/modest-main-window.c: (create_details_widget),
1661 (modest_main_window_set_contents_style): Show details for any folder store,
1664 (modest_tny_folder_get_rules):
1665 Remove the const. C does not support constness enough for this.
1667 * src/modest-ui-actions.c:
1668 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1669 make all outboxes appear as one, in the usual local-folders tree node.
1671 (set_active_account_from_tny_account),
1672 (modest_ui_actions_on_folder_selection_changed):
1673 * src/widgets/modest-folder-view.c: (text_cell_data),
1674 (icon_cell_data), (filter_row),
1675 (add_account_folders_to_merged_folder),
1676 (add_account_folders_to_simple_folder_store), (),
1677 (get_cmp_rows_type_pos), (cmp_rows),
1678 (modest_folder_view_set_account_id_of_visible_server_account):
1679 Adjust to the new outbox system, using generic folder stores and folders
1680 in the GtkTreeModel.
1682 2007-05-23 Christian Kellner <ckellner@openismus.com>
1684 * src/modest-mail-operation.c:
1685 (modest_mail_operation_update_account):
1686 Use info->max_size instead of unintialized local var [small
1687 build fix]. (Added TODO to review that change since I don't
1690 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1692 * libmodest-dbus-client/libmodest-dbus-client.c:
1693 (libmodest_dbus_client_compose_mail): function added
1694 * src/dbus_api/modest-dbus-api.h:
1695 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1696 (on_compose_mail): Implementation of the SendAsMail functionality
1698 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-account-mgr.c:
1701 (modest_account_mgr_add_server_account): Set the secure-connection
1702 conf key for transport accounts as well as store accounts. I don't know
1703 why the if was there. For instance, this makes sure that we use SSL
1704 for the gmail preset from the easysetup wizard.
1706 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1708 * src/gnome/modest-main-window.c:
1709 (on_account_store_connecting_finished), (connect_signals):
1710 * src/maemo/modest-main-window.c:
1711 (on_account_store_connecting_finished), (connect_signals),
1712 (modest_main_window_new):
1713 Handle TnyAccountStore::connecting-finished instead of
1714 TnyDevice::connection-changed, because we cannot actually perform
1715 operations on accounts until TnyAccountStore has itself responded to
1716 the TnyDevice::connection-changed signal. This prevents a GError from
1718 Do not try to update at startup, because we (at least on scratchbox)
1719 already do an update at startup when the device goes online.
1720 This prevents a GError from tinymail.
1721 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1722 Added TODO about stopping simultaneous operations.
1724 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1727 * src/modest-mail-operation-queue.c:
1728 (modest_mail_operation_queue_remove):
1729 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1730 about where they happened.
1732 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-ui-actions.c:
1735 (modest_ui_actions_on_password_requested): Make sure that the remember
1736 output parameter is always TRUE.
1738 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1740 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1741 Show a OK/Cancel dialog if the error is a question, though we still do not
1742 know anything more about what we are asking the user.
1743 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1744 Fix an uninitialized variable (helper). This is a logic error, however.
1746 2007-05-21 Christian Kellner <ckellner@openismus.com>
1748 * src/modest-search.h:
1749 Correct bit shifting in the ModestSearchFlags enum.
1751 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account.c:
1754 (modest_tny_account_new_from_server_account): Do not use the lsub and
1755 check-all hard-coded IMAP options when using POP.
1757 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1759 * src/modest-tny-account.c:
1760 (modest_tny_account_new_from_server_account):
1761 Use NULL for the secure-auth method for POP when Password auth has been
1762 specified by the user, as we already do for IMAP. "auth=Login" causes
1763 an error from camel or the server.
1765 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/modest-account-settings-dialog.c:
1768 (create_page_account_details),
1769 (modest_account_settings_dialog_set_account_name):
1770 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1771 for the leave-on-server checkbox, rathr than just the checkbox, when
1772 the protocol is not POP.
1774 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1776 * src/widgets/modest-account-view.c:
1777 * src/widgets/modest-account-view.h:
1778 Added modest_account_view_select_account() which will be useful later
1779 to asynchronously re-select the edited account.
1781 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1783 * src/maemo/modest-account-settings-dialog.c:
1784 (modest_account_settings_dialog_set_account_name):
1785 Automatically choose the port numbers based on the secure authentication
1786 methods, if they have not been chosen before.
1787 This fixes projects.maemo.org bug NB#56273 .
1789 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1791 * src/maemo/modest-main-window-ui.h:
1792 * src/modest-ui-actions.c:
1793 * src/modest-ui-actions.h:
1794 Connect the Tools/SMTP Servers menu item to
1795 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1796 SMTP servers dialog, as in the UI specification and saves changes when it
1797 is closed. This fixed projects.maemo.org bug NB#56305 .
1799 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1801 * src/maemo/modest-connection-specific-smtp-window.c:
1802 (modest_connection_specific_smtp_window_init):
1803 Use gtk_window_set_default_size() to make this window big enough, so
1804 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1806 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1809 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1810 (modest_connection_specific_smtp_edit_window_init),
1811 Do not try to connect to a combobox signal before the combobox exists.
1812 This fixes the cras in projects.maemo.org bug NB#56288 .
1813 (modest_connection_specific_smtp_edit_window_get_settings):
1814 Remove the server_account_name parameter which was being checked for NULL
1815 though it was not used.
1817 * src/maemo/modest-connection-specific-smtp-window.c:
1818 (modest_connection_specific_smtp_window_fill_with_connections),
1819 (on_button_edit), (modest_connection_specific_smtp_window_init):
1820 Correct the number of treemodel columns to prevent a warning.
1821 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1822 libconic does not work.
1824 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-tny-account.c:
1827 (modest_tny_account_new_from_server_account):
1828 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1829 SMTP when "None" was chosen by the user. However, with my SMTP server that
1830 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1833 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1836 to explain the memory management issue with the ID in the ModestPair.
1838 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1839 (add_sending_page), (modest_account_assistant_finalize):
1840 * src/gnome/modest-gnome-global-settings-dialog.c:
1841 (create_updating_page), (create_composing_page):
1842 * src/gnome/modest-msg-edit-window.c: (get_transports),
1843 (init_window), (modest_msg_edit_window_finalize),
1844 (modest_msg_edit_window_get_msg_data):
1845 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1846 * src/gnome/modest-transport-widget.c:
1847 (modest_transport_widget_finalize), (smtp_configuration):
1848 * src/maemo/modest-maemo-global-settings-dialog.c:
1849 (create_updating_page), (create_composing_page):
1850 * src/maemo/modest-msg-edit-window.c: (get_transports),
1851 (init_window), (modest_msg_edit_window_finalize),
1852 (modest_msg_edit_window_get_msg_data),
1853 (modest_msg_edit_window_free_msg_data):
1854 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1855 (modest_store_widget_finalize):
1856 * src/maemo/modest-transport-widget.c:
1857 (modest_transport_widget_finalize), (smtp_configuration):
1858 * src/modest-main.c: (send_mail):
1859 * src/widgets/modest-combo-box.h:
1860 * src/widgets/modest-global-settings-dialog-priv.h:
1861 * src/widgets/modest-global-settings-dialog.c:
1862 (modest_global_settings_dialog_finalize):
1863 * src/widgets/modest-msg-edit-window.h:
1864 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1865 as long as the combo box, to prevent use of freed memory for the ID.
1867 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1869 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1870 get_accounts(), to make this clearer. Do not check for the enabled gconf
1871 key, because we do not use this for server accounts (at least, not yet).
1872 This allows us to send email again.
1874 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1876 * src/maemo/modest-platform.c:
1877 (on_modest_conf_update_interval_changed), (modest_platform_init):
1878 Only respond to this particular key change. All these strcmp()s cannot be
1881 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/modest-maemo-global-settings-dialog.c:
1884 (current_connection): Prevent a crash in scratchbox when
1885 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1886 * src/maemo/modest-platform.c:
1887 (on_modest_conf_update_interval_changed), (modest_platform_init):
1888 Get the update interval from gconf and reset it when the gconf key changes.
1890 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1892 * src/modest-protocol-info.c:
1893 * src/modest-protocol-info.h: Adde enum-specific get functions,
1894 instead of using a ModestProtocolType enum parameter.
1896 * src/gnome/modest-account-assistant.c:
1897 * src/gnome/modest-store-widget.c:
1898 * src/gnome/modest-store-widget.h:
1899 * src/gnome/modest-transport-widget.c:
1900 * src/gnome/modest-transport-widget.h:
1901 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1902 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1903 * src/maemo/easysetup/modest-easysetup-wizard.c:
1904 * src/maemo/modest-account-settings-dialog.c:
1905 * src/maemo/modest-account-settings-dialog.h:
1906 * src/maemo/modest-store-widget.c:
1907 * src/maemo/modest-store-widget.h:
1908 * src/maemo/modest-transport-widget.c:
1909 * src/maemo/modest-transport-widget.h:
1910 * src/modest-account-mgr-helpers.c:
1911 * src/modest-account-mgr-helpers.h:
1912 * src/modest-account-mgr.c:
1913 * src/modest-account-mgr.h:
1914 * src/modest-tny-account.c:
1915 * src/modest-tny-folder.c:
1916 * src/widgets/modest-account-view.c:
1917 * src/widgets/modest-retrieve-combo-box.c:
1918 * src/widgets/modest-retrieve-combo-box.h:
1919 * src/widgets/modest-secureauth-combo-box.c:
1920 * src/widgets/modest-serversecurity-combo-box.c:
1921 * src/widgets/modest-serversecurity-combo-box.h:
1922 * tests/check_account-mgr.c:
1923 Use the specific functions, and use the re-renamed enum values for GNOME too.
1925 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1927 * src/modest-pair.h:
1928 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1929 so we can get the second based on the first.
1931 * src/maemo/modest-account-settings-dialog.h:
1932 * src/maemo/modest-account-settings-dialog.c:
1933 Added get_supported_secure_authentication_methods(), though it is mostly
1934 commented-out for now until the necessary API is committed to tinymail.
1935 (modest_account_settings_dialog_set_account_name),
1936 (save_configuration): Request the supported authentication methods from the
1937 server, so we can choose a working method.
1939 * src/modest-tny-account-store.h:
1940 * src/modest-tny-account-store.c:
1941 (modest_tny_account_store_get_session): Rename from
1942 tny_account_store_get_session().
1944 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1946 * src/modest-protocol-info.h: Split the ModestProtocol enum
1947 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1948 There was no need to have these unrelated values in one enum.
1950 * src/: many files: Adapted to changed enum. This makes the code a bit
1951 clearer, and the compiler could catch some errors.
1953 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1955 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1956 Show the detailed internal camel error message when an error happens
1957 during the configuration, so that our testers can give us more clues.
1958 For instance, in projects.maemo.org bug NB#56910 .
1960 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1962 * src/modest-tny-account.c:
1963 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1964 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1966 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1968 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1969 * src/maemo/modest-account-settings-dialog.c:
1970 (modest_account_settings_dialog_set_account_name),
1971 (save_configuration): For the incoming secure authentication checkbox,
1972 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1973 the UI specification. PLAIN does not seem to be supported for most IMAP
1974 servers anyway, and I am not sure what it would mean.
1975 However, we probably need to discover which of the secure-authentication
1976 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1977 * src/modest-account-mgr-helpers.c:
1978 (modest_account_mgr_get_server_account_data):
1980 * src/modest-tny-account.c:
1981 (modest_tny_account_new_from_server_account):
1982 Use tny_account_set_mech() to set secure-authentication methods,
1983 with some special-casing for IMAP, based on my observations of how
1986 * src/modest-account-mgr-helpers.h:
1987 * src/modest-account-mgr.c:
1988 * src/modest-defs.h: Comment that the URI is only used for local folders.
1990 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1993 parameter const, just to be neat.
1994 * src/modest-text-utils.c: (modest_text_utils_inline):
1995 End g_strconcat() with NULL, as its documentation says. This is almost
1996 certainly the cause of my crash at startup on the device. Interestingly,
1997 valgrind doesn't tell us about these errors.
1999 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2001 * scripts/build-packages: Added more precise comments about how to use
2002 this script, though I still get this error:
2003 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2004 error building tinymail
2006 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-main-window.c: (on_account_update):
2009 Very slight cleanup, hoping to make it simpler to discover what causes
2010 a crash here sometimes.
2012 * src/modest-tny-account.c:
2013 (modest_tny_account_new_from_server_account): Set the port. Added
2014 comments about the options and a TODO comment because I need to find out
2015 how to specify the secure authentication method.
2017 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2019 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2020 changed CFlags paths form modest to libmodest
2022 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2024 * src/modest-account-mgr-helpers.c:
2025 (modest_account_mgr_get_server_account_data),
2026 (modest_account_mgr_free_server_account_data):
2027 * src/modest-account-mgr-helpers.h:
2028 * src/modest-account-mgr.c:
2029 (modest_account_mgr_add_server_account):
2030 * src/modest-defs.h:
2031 * src/modest-tny-account.c:
2032 (modest_tny_account_new_from_server_account):
2033 Determine the options for tny_camel_account_add_option() here,
2034 based on the settings, rather than storing them directly in gconf.
2036 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2038 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2039 Show a more friendly error dialog now that we expect (from the tinymail
2040 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2042 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/modest-main-window.c: (on_account_update): Check that
2045 account_name is not NULL, to prevent a crash at startup that I am
2046 seeing on the N800. I do wonder why it is NULL.
2048 * src/maemo/easysetup/modest-easysetup-wizard.c:
2049 (create_page_user_details):
2050 * src/maemo/modest-account-settings-dialog.c:
2051 (create_page_user_details), (create_page_outgoing):
2052 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2053 (modest_connection_specific_smtp_edit_window_init):
2054 * src/modest-ui-actions.c:
2055 (modest_ui_actions_on_password_requested):
2056 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2057 might do something useful with the on-screen keyboard.
2059 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/modest-main-window.c: (on_account_update):
2062 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2063 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2065 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2067 * src/modest-tny-account-store.c: (on_account_changed):
2068 Correct the signature of this signal handler.
2070 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2072 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2073 Show a HildonNote instead of a GtkDialog for Maemo.
2075 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2077 * src/widgets/modest-account-view.h:
2078 * src/widgets/modest-account-view.c: (on_account_changed),
2079 (on_account_removed). Added a boolean flag, set/unset by
2080 modest_account_view_block_conf_updates(),
2081 modest_account_view_unblock_conf_updates() to prevent unnecessary
2082 updates, but this is not very useful because the gconf notifications are
2083 so delays (maybe only on Maemo Bora).
2084 So auto-updating is turned off, and these functions do an explicit
2085 update when necessary.
2086 However, something else is still doing too much work when adding/removing
2087 accounts, probably in another part of the application.
2089 * src/maemo/modest-account-view-window.c:
2090 (on_delete_button_clicked), (on_edit_button_clicked),
2091 (on_new_button_clicked): Use the new functions.
2093 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-account-mgr-helpers.c:
2096 (modest_account_mgr_set_first_account_as_default):
2097 Sort the list of names alphabetically-by-title, so we choose the first one
2099 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2100 alphabetically by the title.
2102 This fixes projects.maemo.org bug NB#56418 .
2104 * src/modest-account-mgr-priv.c:
2105 (_modest_account_mgr_account_from_key):
2106 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2107 avoid a valgrind error, and possible random behaviour.
2109 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2111 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2112 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2113 tinymail documentation to say that this can be expected.
2114 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2115 pretty, and should not happen, but I would prefer to know when it does.
2117 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2119 * configure.ac: When using the older hildon version, probably on Bora,
2120 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2122 * src/widgets/modest-attachment-view.c:
2123 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2126 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2128 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2129 Implemented the prototype. Can be tested with
2130 tests/dbus_api/test_open_message:
2132 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-tny-account-store.c:
2135 (modest_tny_account_store_instance_init), (get_password):
2136 * src/modest-ui-actions.c:
2137 (modest_ui_actions_on_password_requested):
2138 Do not store the password in gconf, because this function is called
2139 for non-remembered passwords. Actually use the cached (in the hash map)
2140 password instead of releasing it.
2141 The password will now not be remembered if it is asked via the protected
2142 password dialog, as per the UI spec.
2144 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2146 * src/modest-defs.h:
2147 * src/modest-account-mgr-helpers.h:
2148 * src/modest-account-mgr-helpers.c:
2149 Added modest_server_account_get_username_has_succeeded(),
2150 modest_server_account_set_username_has_succeeded().
2151 (modest_server_account_set_username),
2152 Reset the has-succeeded flag if the username changes.
2154 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2155 * src/maemo/modest-connection-specific-smtp-window.c:
2156 (modest_connection_specific_smtp_window_save_server_accounts):
2157 Use modest_server_account_set_username() instead of using
2158 modest_conf_set_string() directly, so that the has-succeeded flag is always
2161 * src/modest-ui-actions.c:
2162 (modest_ui_actions_on_password_requested): Dim the username entry if
2163 the username has ever worked, as per the UI spec.
2165 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2167 * src/modest-tny-account-store.c: (get_password):
2168 * src/modest-ui-actions.c:
2169 (modest_ui_actions_on_password_requested):
2170 Allow the username to be changed too, though there is more work to
2171 be done on exactly how this behaves.
2173 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2175 * src/modest-account-mgr-helpers.h:
2176 * src/modest-account-mgr-helpers.c:
2177 Added modest_account_mgr_get_display_name(),
2178 modest_server_account_get_username(),
2179 modest_server_account_set_username(),
2180 modest_server_account_set_password(),
2181 modest_server_account_get_hostname() functions so we do not need to
2182 use the conf API directly.
2184 * src/maemo/modest-main-window.c: (connect_signals):
2185 Actually connect ot the ModestAccountStore::request-password signal,
2186 so that we show the dialog when the password is requested by Tinymail,
2187 for isntance if it is empty.
2189 * src/modest-marshal.list:
2190 * src/modest-tny-account-store.c:
2191 (modest_tny_account_store_class_init), (get_password),
2192 (modest_tny_account_store_alert):
2193 * src/modest-tny-account-store.h:
2194 * src/modest-ui-actions.h:
2195 * src/modest-ui-actions.c:
2196 (modest_ui_actions_on_password_requested):
2197 Change the signal parameters, so it is obvious that we are providing
2198 the non human-readable server name, and receiving both the username
2199 and password, though changing of the username is not yet implemented.
2200 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2201 for the GNOME version.
2203 This should fix the projects.maemo.org bug NB#56209, though it does not
2204 work on Bora, because the gconf_client_get() for the password fails
2205 immediately after we save it with gconf_client_set().
2207 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2210 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2211 caused an undefined symbol error:
2212 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2214 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2216 * src/modest-tny-account-store.c:
2217 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2218 using a GError instead of a string message, so we can translate it in
2221 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2223 * src/maemo/modest-address-book.c:
2224 (modest_address_book_check_names):
2225 * src/maemo/modest-msg-view-window.c:
2226 (modest_msg_view_window_clipboard_owner_change):
2227 * src/modest-init.c: (modest_init_init_ui):
2228 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2229 (update_folders_cb), (modest_mail_operation_update_account):
2230 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2231 (modest_ui_actions_on_msg_attachment_clicked),
2232 (modest_ui_actions_on_msg_recpt_activated):
2233 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2234 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2235 (modest_msg_view_search_next):
2236 * src/widgets/modest-recpt-editor.c:
2237 (modest_recpt_editor_on_button_release_event),
2238 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2239 g_message(). At this point we should only be seeing interesting errors on
2240 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2242 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2244 (modest_wizard_dialog_force_title_update):
2245 * src/maemo/easysetup/modest-wizard-dialog.h:
2246 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2247 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2248 can update the title when appropriate. Otherwise the title is wrong if the
2249 pages are added after adding the notebook to the dialog.
2250 This must be a problem in HildonWizardDialog too.
2251 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2253 * src/maemo/easysetup/modest-easysetup-wizard.c:
2254 (create_subsequent_customsetup_pages),
2255 (create_subsequent_easysetup_pages):
2256 Call modest_wizard_dialog_force_title_update() so that the title is
2257 correct even with GTK+ < 2.10.
2258 This fixes projects.maemo.org bug NB#56145 .
2260 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2262 * src/maemo/modest-platform.c:
2263 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2264 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2267 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2269 * src/widgets/modest-window.h:
2270 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2271 and modest_window_save_state(), which invokes it.
2273 * src/widgets/modest-window-mgr.h:
2274 * src/widgets/modest-window-mgr.c:
2275 Added modest_window_mgr_save_state_for_all_windows(), which calls
2276 the save_state vfunc on all registered windows, if implemented.
2278 * src/gnome/modest-msg-edit-window.c:
2279 * src/gnome/modest-msg-view-window.c:
2280 * src/maemo/modest-msg-edit-window.c:
2281 * src/maemo/modest-msg-view-window.c:
2282 * src/maemo/modest-main-window.c:
2283 Specify the existing save_settings functions as implementations of
2284 ModestWindow::save_state_func().
2286 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2287 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2288 enabling hibernation, for instance.
2290 We may need to do the same thing for restoring settings.
2293 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2295 * src/widgets/modest-window-mgr.c:
2296 * src/widgets/modest-window-mgr.h:
2297 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2298 modest_window_mgr_get_hibernation_is_prevented().
2300 * src/maemo/modest-main-window.c:
2301 (on_hildon_program_is_topmost_notify): Prevent hibernation
2302 (possible when the application goes to the background in the WM),
2303 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2305 * src/maemo/easysetup/modest-easysetup-wizard.c:
2306 (modest_easysetup_wizard_dialog_init):
2307 * src/maemo/modest-account-settings-dialog.c:
2308 (modest_account_settings_dialog_init):
2309 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2310 (modest_connection_specific_smtp_edit_window_init):
2311 * src/maemo/modest-connection-specific-smtp-window.c:
2312 (modest_connection_specific_smtp_window_init):
2313 * src/maemo/modest-signature-editor-dialog.c:
2314 (modest_signature_editor_dialog_init):
2315 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2316 prevent hibernation while any of these account settings dialogs are open.
2318 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2320 * src/maemo/Makefile.am:
2321 * src/maemo/modest-osso-state-saving.c:
2322 * src/maemo/modest-osso-state-saving.h: Added
2323 modest_osso_load_state() and modest_osso_save_state() though they do
2324 nothing now. They should iterate through all the open windows and load/save
2326 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2327 save state when closing.
2329 * src/maemo/modest-main-window.c:
2330 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2331 Add a notification handler for the HildonProgram::is-topmost property,
2332 so we can allow hibernation when the application goes into the background.
2333 But we still need to detect when the accounts setup windows are open so
2334 we can stop hibernation when they are open.
2335 To do this, I also added the main window the HildonProgram. This might have
2336 other side-effects/benefits, and should maybe be done for other windows.
2338 * src/maemo/modest-osso-autosave-callbacks.h:
2339 * src/maemo/modest-osso-autosave-callbacks.c:
2340 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2341 though it does not do anything yet, and we might never need this to do
2342 anything. For instance, we already save drafts.
2344 * src/maemo/modest-platform.c: (modest_platform_init):
2345 Specify the libosso auto-save callback.
2347 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/modest-platform.c:
2350 (modest_platform_set_update_interval):
2351 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2352 aparently stays valid between application instances, so we can use this
2353 to remove and reset it later. According to a maemo-developers email from
2356 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2358 * configure.ac: Depend on libalarm for Maemo.
2360 * src/dbus_api/modest-dbus-api.h:
2361 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2362 (on_send_receive), (modest_dbus_req_handler):
2363 Handle a SEND_RECEIVE D-Bus method.
2365 * libmodest-dbus-client/libmodest-dbus-client.c:
2366 (libmodest_dbus_client_send_and_receive):
2367 * libmodest-dbus-client/libmodest-dbus-client.h:
2368 Add C convenience functions for calling the new D-Bus method.
2370 * src/modest-platform.h:
2371 * src/gnome/modest-platform.c:
2372 * src/maemo/modest-platform.c:
2373 Added modest_platform_set_update_interval(), which uses the
2374 alarmd API on Maemo.
2375 (modest_platform_init),
2376 Call modest_platform_set_update_interval(), using a hard-coded
2377 interval for now (until the global settings dialog is implemented),
2378 though I am not sure that this makes sense yet.
2380 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2382 * src/dbus_api/modest-dbus-callbacks.c:
2383 (modest_osso_cb_hw_state_handler):
2384 * src/dbus_api/modest-dbus-callbacks.h:
2385 * src/maemo/modest-platform.c: (modest_platform_init):
2386 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2387 in case this has some effect on the ability for Maemo to ping the
2390 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2392 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2393 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2394 warning. It is probably a logic error, but I need to fix the build.
2396 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2398 * src/modest-account-mgr.h:
2399 * src/modest-account-mgr.c:
2400 (modest_account_mgr_account_names): Add a gboolean enabled_only
2401 parameter, so we can get lists of onlt the enabled accounts.
2403 (modest_account_mgr_add_account),,
2404 (modest_account_mgr_account_with_display_name_exists):
2405 * src/maemo/modest-msg-edit-window.c: (get_transports):
2406 * src/modest-account-mgr-helpers.c:
2407 (modest_account_mgr_set_first_account_as_default):
2408 * src/modest-init.c: (init_default_account_maybe):
2409 * src/modest-tny-account-store.c: (get_accounts):
2410 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2411 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2412 * tests/check_account-mgr.c: (START_TEST):
2413 Provide the extra parameter, as appropriate.
2415 * src/widgets/modest-account-view.c: (update_account_view):
2416 Do not show disabled accounts (meaning that there is no way to
2417 enable/disable accounts in the UI (the feature is not in our UI
2418 specification), so we can use this internally only to mark unfinished
2419 or temporary account data.
2421 * src/maemo/easysetup/modest-easysetup-wizard.c:
2422 (create_account): Add boolean enable parameter, so we can specify FALSE
2423 to create the temporary account.
2424 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2425 (on_before_next): When finishing, when there is a temporary account, just
2427 Also, use a timeout to delay the showing of the dialog until gconf is likely
2428 to return correct information, due to a maemo gconf bug that is fixed in
2429 osso 1.1, but not yet in Bora.
2430 However, the dialog stays on screen after it is destroyed.
2432 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2433 for invalid data when cancelling. Use a hildon note instead of a dialog
2434 to complain about invalid data. Do not show the account-saved note if the
2435 account is disabled (a temporary account that will not really be saved for use
2438 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2440 * src/modest-account-mgr-helpers.h:
2441 * src/modest-account-mgr-helpers.c:
2442 Added modest_account_mgr_unset_default_account(),
2443 Added modest_account_mgr_set_first_account_as_default().
2445 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2446 If it was the default account, unset the default account name.
2448 * src/maemo/modest-account-view-window.c:
2449 (on_delete_button_clicked): If it was the default account,
2450 set the first remaining account as the default instead.
2452 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2453 a NULL account or a NULL default account, to prevent a crash. This should
2454 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2457 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2459 * src/widgets/modest-recpt-editor.c:
2460 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2461 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2462 TODO comment for this. This fixes the build.
2464 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2465 be the best place for it. This will in future update all auto-update accounts,
2466 rather than just the current/default account, when that gconf key exists.
2467 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2468 if there are no accounts, before calling do_send_receive().
2469 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2471 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2472 * src/maemo/modest-main-window-ui.h:
2473 * src/maemo/modest-main-window.c: (on_connection_changed),
2474 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2475 directly, becaue the signal handler does more.
2477 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2479 * src/modest-account-mgr-helpers.c:
2480 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2481 for the case that the account does not exist.
2483 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2484 (equivalent to the modest account name) rather than the tinymail account name
2485 (equivalent to the modest account title - human readable) to get the account data.
2486 Check for null account data to prevent the crash, and add a TODO comment saying that
2487 this needs fixing because it is using the server account name instead of the account name.
2489 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2491 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2492 * src/maemo/modest-account-settings-dialog.c: (show_error),
2494 Use hildon_note_new_information() for informative and error messages,
2495 which seems to be expected for Maemo applications (no documentation that I know of
2496 says this). I am surprised that there is no distinction between info and error
2499 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2501 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2502 it is easy to find where this is used.
2504 * src/maemo/easysetup/modest-easysetup-wizard.c:
2505 (create_page_welcome), (create_page_account_details),
2506 (create_page_user_details), (create_page_complete_easysetup),
2507 (create_page_custom_incoming), (create_page_custom_outgoing),
2508 (create_page_complete_custom):
2509 * src/maemo/modest-account-settings-dialog.c:
2510 (create_page_account_details), (create_page_user_details),
2511 (create_page_incoming), (create_page_outgoing):
2512 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2513 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2514 (modest_connection_specific_smtp_edit_window_init):
2515 * src/maemo/modest-connection-specific-smtp-window.c:
2516 (modest_connection_specific_smtp_window_init):
2517 * src/maemo/modest-signature-editor-dialog.c:
2518 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2519 and scrolling policy as per the Email Application Layout Guide, if I have
2522 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2524 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2525 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2526 which were empty, because these vfuncs have been removed from TnyAccountStore.
2527 This fixes the build.
2529 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/modest-main-window.c:
2532 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2533 showing/hiding it. Added TODO because it probably should not be NULL.
2534 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2535 because unnecessary g_warnings() make degugging difficult.
2537 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2539 * src/maemo/modest-msg-edit-window.c:
2540 (modest_msg_edit_window_select_color),
2541 (modest_msg_edit_window_select_background_color): 2 const corrections and
2542 moving 2 #endifs before closing brackets, to fix the build.
2544 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/easysetup/modest-easysetup-wizard.h:
2547 * src/maemo/easysetup/modest-easysetup-wizard.c:
2548 (modest_easysetup_wizard_dialog_finalize),
2549 (on_button_edit_advanced_settings), (create_page_complete_custom),
2550 (on_response), (create_account):
2551 Implement the Advanced Settings edit button, by saving the account information,
2552 for the Advanded Settings dialog to use directly from gconf, and removing it
2553 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2554 Bug #5533 in the projects.maemo.org bugzilla.
2556 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/modest-msg-view-window.c:
2559 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2560 when opening a message window.
2562 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2564 * src/maemo/easysetup/modest-easysetup-wizard.c:
2565 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2568 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2569 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2570 gconf settings. I probably added more checks than necessary, but that is safer.
2572 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2573 variable to fix the build, but this seems to be used when it is still NULL.
2575 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2577 * src/modest-platform.h:
2578 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2579 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2580 * src/modest-main.c: Implement this function so we can avoid using
2581 maemo-specific API from cross-platform code.
2583 * src/modest-tny-account-store.c:
2584 (get_smtp_specific_transport_account_for_open_connection):
2585 * src/modest-ui-actions.c: (check_for_connection),
2586 (modest_ui_actions_on_item_not_found):
2587 Use modest_platform_connect_and_wait() and put #idefs around other
2588 maemo-specific code, because only maemo currently has a way to
2589 identify connection names.
2591 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2593 * src/modest-tny-account-store.h:
2594 * src/modest-tny-account-store.c:
2595 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2596 the connection-specific SMTP server settings in the configuration.
2598 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2600 * src/maemo/modest-main-window.c: (on_connection_changed),
2602 * src/modest-main.c: (main), (start_ui), (send_mail):
2603 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2604 that is what is intended.
2606 * src/modest-ui-actions.c: (action_send), (action_receive),
2607 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2608 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2609 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2610 SMTP server is used when it is specified.
2612 (modest_ui_actions_on_send_receive):
2613 Check that a connection is open before proceeding.
2614 Receive and then send, instead of vice-versa, as per the specification.
2616 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2618 * src/modest-mail-operation.c:
2619 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2620 though I guess it should be something other than NULL.
2622 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2624 * src/maemo/easysetup/modest-easysetup-wizard.c:
2625 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2626 combo twice, to avoid an g_warning and to make it visible again.
2627 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2628 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2629 (already intended) dereference when detaching, because we then recreate the menu.
2630 But I am not sure why the warning was happening, and it is possible that this is a memory
2633 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2635 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2636 and uri_parse_mailto() utility functions.
2637 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2639 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2641 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2643 * src/dbus_api/modest-dbus-api.h:
2644 * src/dbus_api/modest-dbus-callbacks.c:
2645 Use an idle callback to execute the modest code in the application's own thread.
2646 Remove the helloworld example method.
2647 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2648 parsed, and the open-message method is not implemented because this is not yet implemented in
2650 * libmodest-dbus-client/libmodest-dbus-client.c:
2651 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2652 (libmodest_dbus_client_open_message):
2653 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2655 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2656 body without crashing.
2658 * tests/dbus_api/Makefile.am:
2659 * tests/dbus_api/test_mail_to.c:
2660 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2662 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2664 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2665 Added file to fix the build. Sorry.
2667 * src/dbus_api/Makefile.am:
2668 * src/dbus_api/modest-dbus-api.h:
2669 * src/dbus_api/modest-dbus-callbacks.h:
2670 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2671 (modest_dbus_req_handler):
2672 Put constants in a separate header so it can be reused by the
2673 client library, without duplication
2675 * libmodest-dbus-client/Makefile.am:
2676 * libmodest-dbus-client/libmodest-dbus-client.c:
2677 (libmodest_dbus_client_call_helloworld),
2678 (libmodfest_dbus_client_send_mail),
2679 (libmodfest_dbus_client_mailto),
2680 (libmodfest_dbus_client_open_message):
2681 * libmodest-dbus-client/libmodest-dbus-client.h:
2682 (Partly) Implement a send_mail D-Bus method.
2684 * tests/dbus_api/Makefile.am:
2685 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2686 the send_email D-Bus method.
2688 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2692 * libmodest-dbus-client/Makefile.am:
2693 * libmodest-dbus-client/libmodest-dbus-client.c:
2694 * libmodest-dbus-client/libmodest-dbus-client.h:
2695 * tests/dbus_api/Makefile.am:
2696 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2697 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2699 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/easysetup/modest-easysetup-wizard.c:
2702 (create_page_account_details):
2703 * src/maemo/modest-account-settings-dialog.c:
2704 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2705 widgets, because this might not be the default in future versions of the Maemo GTK+.
2706 However, I can not not get capitalization to work even in a simple test case.
2708 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2710 * src/maemo/easysetup/modest-easysetup-wizard.c:
2711 (create_page_custom_incoming), (create_page_custom_outgoing):
2712 * src/maemo/modest-account-settings-dialog.c:
2713 (create_page_account_details), (create_page_incoming),
2714 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2715 instead of using gtk_check_button_with_label(), so they are aligned like the other
2716 widgets, as per the UI spec.
2718 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2720 * src/maemo/easysetup/modest-easysetup-wizard.c:
2721 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2722 * src/widgets/modest-validating-entry.c:
2723 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2724 Modest prefix instead of an EasySetup prefix.
2726 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2728 * src/widgets/modest-validating-entry.h:
2729 * src/widgets/modest-validating-entry.c: (on_insert_text),
2730 Added easysetup_validating_entry_set_max_func(), used to set a callback
2731 to call when the max number of characters is reached. GtkEntry has a max-length
2732 already but is silent about it.
2734 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2735 (create_page_account_details), (create_page_user_details),
2737 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2738 (create_page_account_details), (create_page_user_details),
2739 (create_page_outgoing):
2740 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2741 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2742 the UI spec, when the user tries to enter more than the max number of characters.
2744 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2746 * src/maemo/easysetup/modest-easysetup-wizard.c:
2747 (create_page_user_details), (create_page_custom_incoming),
2748 (create_page_custom_outgoing):
2749 * src/maemo/modest-account-settings-dialog.c:
2750 (create_page_user_details), (create_page_incoming),
2751 (create_page_outgoing):
2752 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2753 (modest_connection_specific_smtp_edit_window_init):
2754 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2755 not appropriate. Bad Maemo-specific defaults!.
2757 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2759 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2760 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2761 (modest_signature_editor_dialog_set_settings):
2762 Disable the label and textview when the checkbox is disabled, and use the
2763 specified (UI spec) default signature text.
2765 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2768 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2770 * src/modest-defs.h:
2771 * src/modest-account-mgr-helpers.h:
2772 * src/modest-account-mgr-helpers.c:
2773 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2775 * src/maemo/Makefile.am:
2776 * src/maemo/modest-signature-editor-dialog.c:
2777 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2780 * src/maemo/modest-account-settings-dialog.h:
2781 * src/maemo/modest-account-settings-dialog.c:
2782 (modest_account_settings_dialog_finalize), (on_button_signature),
2783 (save_configuration): Use the new dialog when the Edit button is pressed, and
2784 save the changes if necessary, as per the UI spec.
2786 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2788 * src/maemo/Makefile.am:
2789 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2790 based on maemo-develoers email from Dirk.
2792 * src/maemo/easysetup/modest-easysetup-wizard.c:
2793 (create_page_welcome), (create_page_account_details),
2794 (create_page_user_details), (create_page_complete_easysetup),
2795 (create_page_custom_incoming), (create_page_custom_outgoing),
2796 (create_page_complete_custom),
2797 (modest_easysetup_wizard_dialog_init):
2798 * src/maemo/modest-account-settings-dialog.c:
2799 (create_page_account_details), (create_page_user_details),
2800 (create_page_incoming), (create_page_outgoing),
2801 (modest_account_settings_dialog_init):
2802 * src/maemo/modest-connection-specific-smtp-window.c:
2803 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2805 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/easysetup/modest-easysetup-wizard.c:
2808 (create_page_account_details), (create_page_custom_outgoing),
2809 (create_page_complete_custom):
2810 * src/maemo/modest-account-settings-dialog.c:
2811 (create_page_user_details), (create_page_incoming),
2812 (create_page_outgoing):
2813 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2814 (modest_connection_specific_smtp_edit_window_init):
2815 Use the correct (UI spec) port min/max, and use horizontal separators,
2818 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2820 * src/maemo/easysetup/modest-easysetup-wizard.c:
2821 (set_default_custom_servernames):
2822 * src/maemo/modest-account-settings-dialog.c:
2823 (create_page_incoming), (on_combo_outgoing_security_changed),
2824 (on_combo_incoming_security_changed), (create_page_outgoing),
2825 (modest_account_settings_dialog_set_account_name),
2826 (save_configuration):
2827 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2828 (on_combo_security_changed),
2829 (modest_connection_specific_smtp_edit_window_init),
2830 (modest_connection_specific_smtp_edit_window_set_connection),
2831 (modest_connection_specific_smtp_edit_window_get_settings):
2832 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2835 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2838 * src/maemo/easysetup/modest-easysetup-wizard.c:
2839 (create_page_custom_outgoing), (create_page_complete_custom):
2840 * src/maemo/modest-account-settings-dialog.c:
2841 (create_page_user_details), (create_page_outgoing):
2842 * src/maemo/modest-account-view-window.c: (button_box_new):
2843 Use changed logical IDs as per the most recent UI spec:
2844 mcen_bd_emailsetup_edit -> mcen_bd_edit
2845 mcen_bd_emailsetup_delete -> mcen_bd_delete
2846 mcen_bd_emailsetup_close -> mcen_bd_close
2848 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2852 * src/dbus_api/Makefile.am:
2853 * src/dbus_api/modest-dbus-callbacks.c:
2854 * src/dbus_api/modest-dbus-callbacks.h:
2855 * src/maemo/modest-platform.c: (modest_platform_init):
2856 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2858 * tests/Makefile.am:
2859 * tests/dbus_api/Makefile.am:
2860 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2862 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/modest-account-settings-dialog.c:
2865 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2866 Removed unnecessary includes.
2868 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2870 * src/maemo/easysetup/modest-easysetup-wizard.c:
2871 * src/maemo/modest-account-settings-dialog.c:
2872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2873 * src/widgets/Makefile.am:
2874 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2875 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2876 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2877 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2878 * src/widgets/modest-secureauth-combo-box.c:
2879 * src/widgets/modest-secureauth-combo-box.h:
2880 * src/widgets/modest-serversecurity-combo-box.c:
2881 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2882 made the GObject names more consistent with the rest of the Modest code.
2884 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2886 * src/maemo/easysetup/Makefile.am:
2887 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2888 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2889 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2890 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2891 * src/maemo/easysetup/modest-easysetup-wizard.c:
2892 * src/maemo/easysetup/modest-validating-entry.c:
2893 * src/maemo/easysetup/modest-validating-entry.h:
2894 * src/maemo/modest-account-settings-dialog.c:
2895 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2896 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2897 widgets/ because they are used outside of easysetup too. After checking in,
2898 svn will allow me to rename them too.
2900 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2902 * src/gnome/modest-msg-edit-window.c:
2903 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2904 linker error, to fix the build on the GNOME platform.
2905 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2906 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2907 ifdefed out to avoid a warning.
2909 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2911 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2912 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2913 some alternative for GTK+ 2.6.
2915 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2917 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2919 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2920 specified for EmailAccountsDialog in UI spec.
2922 * src/maemo/easysetup/modest-easysetup-wizard.c:
2923 * src/maemo/easysetup/modest-easysetup-wizard.h:
2924 * src/maemo/modest-account-settings-dialog.c:
2925 * src/maemo/modest-account-settings-dialog.h:
2926 Reuse a member window widget for the connection-specific SMTP server accounts,
2927 so we can tell it to create/save the accounts only if we actually save changes.
2929 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2931 (modest_connection_specific_smtp_edit_window_get_settings):
2932 Return a struct instance for temporarily remembering the entered data.
2934 * src/maemo/modest-connection-specific-smtp-window.h:
2935 * src/maemo/modest-connection-specific-smtp-window.c:
2936 (modest_connection_specific_smtp_window_finalize),
2937 (modest_connection_specific_smtp_window_fill_with_connections),
2939 (modest_connection_specific_smtp_window_save_server_accounts),
2940 (update_model_server_names): Do not actually save data until asked,
2941 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2943 (on_selection_changed),
2944 (modest_connection_specific_smtp_window_init): Disable the edit
2945 button when nothing is selected.
2947 * src/modest-account-mgr-helpers.c:
2948 * src/modest-account-mgr-helpers.h:
2949 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2952 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2954 * src/modest-account-mgr-helpers.h:
2955 * src/modest-account-mgr-helpers.c:
2956 (modest_account_mgr_get_unused_account_name),
2957 (modest_account_mgr_get_unused_account_display_name): Added these
2958 utility functions, to avoid code duplication.
2960 * src/maemo/easysetup/modest-easysetup-wizard.c:
2961 (create_page_account_details), (create_account):
2962 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2963 (on_combo_security_changed),
2964 (modest_connection_specific_smtp_edit_window_init),
2965 (modest_connection_specific_smtp_edit_window_save_settings):
2966 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2967 * src/maemo/modest-connection-specific-smtp-window.c:
2968 (modest_connection_specific_smtp_window_finalize),
2969 (modest_connection_specific_smtp_window_fill_with_connections),
2970 (on_button_edit), (modest_connection_specific_smtp_window_init):
2971 * src/maemo/modest-connection-specific-smtp-window.h:
2972 Implementing saving of connection-specific server accounts.
2974 But I need to refactor this so we can save the data for each
2975 possible connection-specific account and only actually create the server accounts
2976 when the easysetup finished, or the OK button is pressed on the account settings
2979 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2981 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2982 (on_combo_security_changed):
2983 (modest_connection_specific_smtp_edit_window_init):
2984 Auto-fill the port number as in the account settings.
2986 (modest_connection_specific_smtp_edit_window_set_connection):
2987 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2988 * src/maemo/modest-connection-specific-smtp-window.c:
2989 (fill_with_connections), (on_button_edit),
2990 (modest_connection_specific_smtp_window_init):
2991 Turn the edit window into a dialog to simplify the code, and
2992 set a WM hint as in a GtkDialog, because only a popup can be on top of
2993 another window in Maemo, and popups usually have no WM decoration.
2995 * src/modest-defs.h:
2996 * src/modest-account-mgr-helpers.c:
2997 (modest_account_mgr_set_connection_specific_smtp),
2998 (modest_account_mgr_remove_connection_specific_smtp),
2999 (modest_account_mgr_get_connection_specific_smtp):
3000 * src/modest-account-mgr-helpers.h: Some functions to write the
3001 connection-specific SMTP server information. Not yet used.
3004 * src/widgets/modest-folder-view.c: (text_cell_data):
3005 Fix a warning about an uninitialized variable.
3006 (on_configuration_key_changed): Put an #ifdef around the use
3007 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3009 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3011 * src/maemo/modest-account-settings-dialog.h:
3012 * src/maemo/modest-account-settings-dialog.c:
3013 Added connect_for_modified() utility function to mark the new modified boolean.
3015 (create_page_account_details), (create_page_user_details),
3016 (create_page_incoming), (create_page_outgoing), (on_response),
3017 (modest_account_settings_dialog_init),
3018 (modest_account_settings_dialog_set_account_name):
3019 Only warn about unsaved changes when there are actually unsaved changes.
3021 * src/modest-account-mgr-helpers.c:
3022 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3023 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3024 to get the data from there in future.
3026 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3028 * src/modest-defs.h:
3030 * src/modest-account-mgr-helpers.h:
3031 * src/modest-account-mgr-helpers.c:
3032 Store the security account setting in a single conf key instead of using
3033 the options list, so that the list is left for just the to-be-removed camel hack,
3034 and because gconf_client_set_list() is failing for some reason.
3036 * src/modest-account-mgr.c:
3037 (modest_account_mgr_add_server_account):
3038 * src/maemo/modest-account-settings-dialog.c:
3039 (modest_account_settings_dialog_set_account_name),
3040 (save_configuration): Use the renamed functions.
3043 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3045 * src/widgets/Makefile.am:
3046 * src/widgets/modest-limit-retrieve-combo-box.c:
3047 * src/widgets/modest-limit-retrieve-combo-box.h:
3048 * src/widgets/modest-retrieve-combo-box.c:
3049 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3050 the account settings dialog.
3052 * src/modest-defs.h:
3053 * src/modest-account-mgr-helpers.h:
3054 * src/modest-account-mgr-helpers.c:
3055 (modest_server_account_get_option_secure_auth),
3056 (modest_server_account_set_option_secure_auth):
3057 * src/modest-account-mgr.c:
3058 (modest_account_mgr_add_server_account):
3059 Use the existing AUTH_MECH conf key for the secure-auth setting,
3060 instead of putting it in the list options, because this was actually used already.
3062 * src/maemo/modest-account-settings-dialog.c:
3063 (create_page_account_details),
3064 (modest_account_settings_dialog_set_account_name),
3065 (save_configuration):
3066 * src/maemo/modest-account-settings-dialog.h:
3067 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3068 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3070 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3072 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3073 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3074 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3076 * src/modest-defs.h:
3077 * src/maemo/modest-account-settings-dialog.c:
3078 (create_page_incoming), (on_combo_outgoing_security_changed),
3079 (on_combo_incoming_security_changed), (create_page_outgoing),
3080 (modest_account_settings_dialog_set_account_name),
3081 (save_configuration): Load/Save the port number, and change it when the
3082 security combo changes, to suitable defaults.
3084 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3086 * src/modest-account-mgr.c:
3087 (modest_account_mgr_add_server_account): Set the security and secure-auth
3088 options, and add a comment saying that the other camel-specific options should be
3091 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3093 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3095 * src/modest-tny-account-store.c: (account_list_free),
3096 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3097 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3100 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3102 * src/modest-protocol-info.c:
3103 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3104 is required by our UI spec. Maybe something in our implementation will use this eventually.
3105 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3106 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3107 instead of the previous 0 placeholder.
3109 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3110 secure-auth settings.
3111 * src/modest-account-mgr-helpers.h:
3112 * src/modest-account-mgr-helpers.c:
3113 (modest_server_account_data_get_option_secure_auth),
3114 (modest_server_account_set_option_secure_auth),
3115 (modest_server_account_data_get_option_security),
3116 (modest_server_account_set_option_security): Added this API for getting and setting the security
3117 and secure-auth settings.
3119 * src/maemo/modest-account-settings-dialog.h:
3120 * src/maemo/modest-account-settings-dialog.c:
3121 (modest_account_settings_dialog_finalize), (check_data),
3122 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3123 about changing titles.
3124 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3125 (save_configuration): Save the security and secure-auth settings.
3127 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3128 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3130 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3132 * src/modest-defs.h:
3133 * src/modest-account-mgr.c:
3134 (modest_account_mgr_add_server_account):
3135 Added and used defines for the options key and value pair strings,
3136 that are used so far, though they do not seem to correspond to anything in our
3137 UI specs or ModestProtocol enum.
3139 * src/modest-account-mgr-helpers.h:
3140 * src/modest-account-mgr-helpers.c:
3141 (compare_option_strings_for_name),
3142 (modest_server_account_data_get_option_value),
3143 (modest_server_account_data_get_option_bool),
3144 (modest_account_mgr_get_server_account_option):
3145 Added helper functions for parsing the options GSList.
3147 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3149 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3150 display name is based on the supplied account name.
3151 * src/modest-account-mgr.c:
3152 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3153 with an inefficient, but good-enough, implementation.
3155 * src/maemo/easysetup/modest-easysetup-wizard.c:
3156 (create_page_account_details), (on_before_next), (create_account):
3157 Check for existing display names rather than (non-user-visible) account names, and just
3158 create and set a unique account name at the end.
3160 * src/maemo/modest-account-settings-dialog.c:
3161 (modest_account_settings_dialog_init),
3162 (modest_account_settings_dialog_set_account_name),
3163 (create_page_incoming): Show the display name, instead of the account name.
3164 (on_response): Do some (not all) extra checks, as in the UI spec.
3165 (save_configuration): Save the display name if it was changed.
3167 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3169 * po/en_GB.po: Added needed logical ID and translation.
3170 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3171 (init_view): Made the is-default column clicking work.
3173 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3176 * src/maemo/easysetup/Makefile.am:
3177 * src/maemo/easysetup/modest-easysetup-wizard.c:
3178 (modest_easysetup_wizard_dialog_init):
3179 * src/maemo/easysetup/provider-data-test.keyfile:
3180 * src/maemo/easysetup/provider-data.keyfile:
3181 Moved the provider data file to the new modest-providers-data package and used it from there.
3183 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-local-folder-info.c:
3186 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3187 N_() was already used on the static strings, but this just marks it for translation without
3188 using the translation.
3190 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3192 * src/maemo/modest-account-settings-dialog.c:
3193 (create_page_incoming),
3194 (modest_account_settings_dialog_set_account_name):
3195 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3196 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3197 I will do this if nobody else gets there first.
3199 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3202 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3203 save the security stuff.
3205 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3207 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3208 Set the email address and user fullname, which I now see must be
3211 * src/maemo/modest-account-settings-dialog.h:
3212 * src/maemo/modest-account-settings-dialog.c:
3214 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3215 leave-on-server and authentication.
3216 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3219 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3222 * src/maemo/modest-account-settings-dialog.c:
3223 * src/maemo/modest-account-settings-dialog.h:
3224 Most (but not all) of the widgets are now present as specified by the UI spec.
3225 No changes are yet saved, and some details are not properly shown yet.
3227 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3229 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/Makefile.am:
3232 * src/maemo/modest-account-settings-dialog.c:
3233 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3234 an existing account. Doesn't do much yet.
3236 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3237 Open the accounts settings dialog when Edit is clicked.
3239 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3241 * src/maemo/easysetup/Makefile.am:
3242 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3244 * src/maemo/easysetup/modest-easysetup-wizard.c:
3245 (modest_easysetup_wizard_dialog_init):
3246 Try to get the source directory from the build system,
3247 instead of hard-coding "./" into the source code, when opening our local
3248 copies of the configuration files.
3249 But this still fails when opening the wizard from the Accounts window,
3250 maybe because the working directory seems to change at runtime.
3251 So the wizard will fail the second time unless you copy the files into their
3252 proper locations - see the stdout warnings for the paths.
3254 (create_page_account_details),(on_before_next):
3255 Check for existing non-server accounts instead of server accounts,
3256 so the default account name is useful again, and to prevent trying to
3259 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3260 Show the wizard when New is clicked.
3262 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3263 (init_view): Show the column headers, and show the columns that are
3264 specified in the UI specs. However, something in Maemo's GTK+ prevents
3265 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3266 change the default account. This is despite unsetting the special properties.
3268 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3270 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3271 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3272 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3273 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3274 to make that clearer.
3275 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3277 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3279 * src/maemo/modest-account-view-window.c:
3280 (modest_account_view_window_init),
3281 (modest_account_view_window_new):
3282 Use the same buttons as specified in the
3283 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3284 the existing widgets, which never had a chance of working.
3285 Put the ModestAccountView treeview in a scrolled window.
3286 Do not repeat the initialization in both _init() and _new().
3288 * src/widgets/modest-account-view.c: (update_account_view):
3289 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3290 this widget and window shows no accounts.
3292 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3294 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/easysetup/modest-easysetup-wizard.c:
3297 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3298 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3299 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3302 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3303 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3304 accounts exist yet, as in the UI spec.
3306 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3308 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3310 * src/maemo/Makefile.am:
3311 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3312 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3313 New window for editing connection-specific smtp details.
3314 Not fully implemented.
3316 * src/maemo/modest-connection-specific-smtp-window.c:
3317 (modest_connection_specific_smtp_window_finalize) :
3318 unref the tree model.
3319 (on_button_edit): Show the edit window.
3321 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3323 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3326 * src/maemo/Makefile.am:
3327 * src/maemo/modest-connection-specific-smtp-window.c:
3328 * src/maemo/modest-connection-specific-smtp-window.h:
3329 New window for showing the list of connections, for connection-specific
3330 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3331 * src/maemo/easysetup/modest-easysetup-wizard.c:
3332 (create_page_custom_outgoing): Show the new window when the button is clicked.
3334 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3336 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3337 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3338 * src/maemo/modest-msg-edit-window.c:
3339 (modest_msg_edit_window_insert_image):
3340 * src/modest-conf.c: (modest_conf_key_escape):
3341 * src/modest-mail-operation.c:
3342 (modest_mail_operation_send_new_mail):
3343 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3344 (modest_ui_actions_on_new_account):
3345 * src/widgets/modest-attachment-view.c: (update_filename_request):
3346 * src/widgets/modest-mail-header-view.c:
3347 Corrected warnings that were breaking the build, by commenting out unused variables,
3348 and a function, and by including a header.
3350 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3352 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3353 so we can #ifdef around platform-specific code when necessary.
3354 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3355 to allow this to build for the GNOME platform too.
3357 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/easysetup/modest-easysetup-wizard.c:
3360 Added util_increment_name() and used it in create_page_account_details()
3361 to make sure that the default account name is always a new name.
3363 (modest_easysetup_wizard_dialog_init),
3364 (set_default_custom_servernames): Some minor memory management fixes.
3366 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3370 * src/modest-runtime.c: (init_i18n): Restored the translation
3371 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3372 are defined in config.h, and the translations are installed.
3374 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3375 is defined for translation.
3377 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3379 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3381 * src/maemo/easysetup/modest-easysetup-wizard.c:
3382 (modest_easysetup_wizard_dialog_init):
3383 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3384 Use realistic paths (though they should use $prefix generically) to the
3385 mcc_mapping and provider-data.keyfile files which might work when they
3386 are installed by the future version of the operator-wizard package,
3387 and then fallback to paths in our source code, with an explanatory
3390 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3394 * src/maemo/Makefile.am:
3395 * src/maemo/easysetup/: Added files from the previously-exernal
3396 osso-modest-easysetup.
3397 * src/maemo/modest-main-window-ui.h:
3398 * src/modest-ui-actions.c:
3399 * src/modest-ui-actions.h:
3400 Added modest_ui_actions_on_new_account() as a signal handler for the
3401 New Account menu item. It shows the easysetup wizard.
3402 * po/en_GB.po: Added additional needed logical IDs and translations.