1 2007-06-22 Armin Burgmeier <armin@openismus.com>
3 * src/maemo/modest-maemo-utils.h:
4 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
5 modest_maemo_utils_get_supported_secure_authentication_methods.
7 * src/maemo/easysetup/modest-easysetup-wizard.c:
8 * src/maemo/modest-account-settings-dialog.c: Show correct error if
9 one occured, not just "Server does not support secure authentication".
11 2007-06-22 Murray Cumming <murrayc@murrayc.com>
13 * src/modest-tny-account-store.c: (get_password):
14 Restored the call to tny_account_set_user() because Philip seems to have
15 stopped this from crashing (by not using the freed string). It still does
16 not work, but now we can test it.
18 2007-06-22 Murray Cumming <murrayc@murrayc.com>
20 * src/maemo/modest-msg-edit-window.c: (init_window):
21 Comment out use of an uninitialzed GtkScrolledWindow variable,
22 to fix the build and stop a crash. Yet again.
24 2007-06-22 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-tny-account-store.c: (get_password):
27 Remove the call to tny_account_set_user() because this actually crashes.
28 As mentioned in the last commit, it is known to not work anyway.
30 2007-06-22 Murray Cumming <murrayc@murrayc.com>
32 * src/modest-tny-account-store.c: (get_password):
33 Use tny_account_set_username() to tell tinymail that the username might
34 have changed too. But tinymail ignores this: see projects.maemo.org
36 * src/modest-ui-actions.c:
37 (modest_ui_actions_on_password_requested): Remove the useless attempt to
38 reset the connection when changing the username, and improve the comments.
39 Save the changed username to gconf at least, so it is used when Modest is
42 2007-06-21 Murray Cumming <murrayc@murrayc.com>
44 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
45 Do not use a query, so that we get all folders, including for POP and
46 local-folders. They work as search criteria too.
47 This fixes projects.maemo.org bug NB#57740.
49 2007-06-21 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
52 Comment out the use of hildon_notification_set_sound() because it is
53 not declared, to fix the build. Warnings are serious, people.
55 2007-06-21 Armin Burgmeier <armin@openismus.com>
57 * src/maemo/modest-maemo-utils.h:
58 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
59 modest_maemo_utils_get_supported_secure_authentication_methods()
60 to query authentication methods for a specific user. This should fix
61 projects.maemo.org bug NB#61369.
63 * src/maemo/easysetup/modest-easysetup-wizard.c:
64 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
67 2007-06-21 Murray Cumming <murrayc@murrayc.com>
69 * libmodest-dbus-client/libmodest-dbus-client.h:
70 * libmodest-dbus-client/libmodest-dbus-client.c:
71 (modest_dbus_message_iter_get_search_hit),
72 (libmodest_dbus_client_search):
73 Reorganised and commented this.
74 Removed modest_search_hit_free() from the public API because it
77 Added libmodest_dbus_client_get_folders() and
78 modest_folder_result_list_free().
80 * src/dbus_api/modest-dbus-api.h:
81 * src/dbus_api/modest-dbus-callbacks.c:
82 (modest_dbus_req_filter): Commented. Moved most code to
83 on_dbus_method_search() and added on_dbus_method_get_folders().
85 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
86 of the extra D-Bus handler.
88 * tests/dbus_api/Makefile.am:
89 * tests/dbus_api/test_get_folders.c: New test for
90 libmodest_dbus_client_get_folders(). This seems to return an empty list
91 at the moment. That could be the same error that causes the message list
92 to be empty sometimes.
93 This should help with projects.maemo.org bug NB#57740.
95 2007-06-21 Armin Burgmeier <armin@openismus.com>
97 * src/modest-mail-operation.c: Do not call
98 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
99 notify the operation's end after having set the status to CANCELED for
100 the operation queue to listen on. This fixes a deadlock when there
101 were mail operations in the queue during its finalization.
103 * src/modest-singletons.c: Reordered uninitialization of the account
104 manager to happen after the mail operation queue was uninitialized
105 because the mail operation's in the queue might still try to access
106 the account manager (see modest_mail_operation_notify_end()). This
107 fixes a potential crash when terminating the application.
109 2007-06-21 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-search.c:
112 (search_mime_part_and_child_parts): Moved some code here so we
113 can search recursively in child folders.
114 (modest_search_folder): Search in the message as a mime part, instead
115 of just its child mime parts.
116 (read_chunk), (search_mime_part_ogs):
117 Check how many bytes were read, to prevent an endless loop.
118 Searching in message bodies now works. This finishes the fix for
119 projects.maemo.org bug NB#61007.
121 2007-06-20 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
124 Add a g_warning when the item is not a folder.
126 * src/modest-ui-dimming-rules.c:
127 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
128 when selected item is not a folder (for instance, an account), because
129 the UI spec only talks about folders.
130 I am not sure what the UI spec wants, so this might not totally fix
131 projects.maemo.org bug NB#60794.
133 2007-06-20 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
136 (load_from_file): Sort the list. The unsorted list would be more noticeable
137 in non-English locales.
139 * src/maemo/modest-msg-edit-window.c:
140 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
141 warning and fix the build.
143 * src/maemo/modest-progress-bar-widget.c:
144 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
145 avoid a g_warning, and probably to avoid a crash.
147 2007-06-20 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-search.c: (modest_search_folder): Check for a GError
150 when calling tny_folder_get_headers(), to show that this is not the cause
153 2007-06-20 Murray Cumming <murrayc@murrayc.com>
155 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
156 Actually set the body query instead of the subject query.
158 * src/modest-search.c: (search_mime_part_ogs),
159 (search_mime_part_strcmp): Remove extra space from the text/* regex,
160 which would probably cause it to fail if we got this far.
162 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
163 to simplify the code.
164 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
165 be causing search-in-body to fail.
167 2007-06-20 Murray Cumming <murrayc@murrayc.com>
169 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
171 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
172 Better debug message when the folder cannot be found.
173 This should help with fixing projects.maemo.org bug #61287.
174 * src/modest-search.c: (add_hit): Do not leak the furl string.
176 2007-06-20 Murray Cumming <murrayc@murrayc.com>
178 * src/modest-ui-actions.c:
179 (modest_ui_actions_on_folder_selection_changed):
180 Do not special-case TNY_MERGE_FOLDER here, because
181 modest_tny_folder_get_account() already does that. This fixes
182 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
183 shown when the Outbox was selected).
185 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
187 * libmodest-dbus-client/libmodest-dbus-client.c:
188 (_dbus_iter_get_string_or_null): Initialize the string variable in
189 case this helps with Dirk's crash.
191 2007-06-19 Murray Cumming <murrayc@murrayc.com>
193 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
194 though it is not implemented yet (this function is maybe not even used),
195 to avoid breaking ABI in future.
196 * libmodest-dbus-client/libmodest-dbus-client.c:
197 (get_attachments_string): Moved some code into this generic function.
198 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
199 sends email. It is maybe not used.
200 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
201 (on_send_mail): Use attachments.
203 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
204 * src/maemo/modest-msg-edit-window.c:
205 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
206 a filename before using it, to fix projects.maemo.org bug NB#58233.
208 2007-06-19 Murray Cumming <murrayc@murrayc.com>
210 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
211 Initialize the continue_download variable to fix the build, and probably
212 to fix randome behaviour.
214 2007-06-18 Armin Burgmeier <armin@openismus.com>
216 * src/modest-tny-send-queue.h:
217 * src/modest-tny-send-queue.c: Keep track of the status of messages in
218 the queue so we can later show it in the UI. Replaced
219 modest_tny_send_queue_msg_is_being_sent() by
220 modest_tny_send_queue_get_msg_status().
222 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
224 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
225 gpointer. This probably was not harmful, but just to be sure.
227 2007-06-18 Murray Cumming <murrayc@murrayc.com>
229 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
230 Fix the build, but leave the function broken on Bora, because
231 hildon_uri_action_get_service() does not exist.
232 osso_uri_action_get_service() does not exist either, it seems.
234 2007-06-18 Murray Cumming <murrayc@murrayc.com>
236 * src/modest-tny-account.c:
237 (modest_tny_account_new_from_server_account):
238 Uncommented the url debug output again, because it is useful for
239 debugging, as I said in the comment.
241 2007-06-18 Murray Cumming <murrayc@murrayc.com>
243 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
245 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
246 for Mameo Bora, to fix the build.
248 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
251 Fixed build with hildon < 0.99
253 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
254 Check if the selected account is busy instead of checking all accounts
256 * src/modest-account-mgr-priv.h:
257 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
258 (modest_account_mgr_init), (compare_account_name),
259 (modest_account_mgr_set_account_busy),
260 (modest_account_mgr_account_is_busy):
261 * src/modest-account-mgr.h:
262 Added busy information to the account manager. It possible to
263 set an account to busy or not busy now.
265 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
266 (modest_mail_operation_update_account),
267 (modest_mail_operation_notify_end):
268 Set the account to busy/not busy depending on the operation state.
270 * src/widgets/modest-account-view.c:
271 (modest_account_view_finalize), (get_last_updated_string),
272 (update_account_view), (on_account_busy_changed), (init_view):
273 Show string "Refreshing..." if the account is currently busy.
275 All this fixes projects.maemo.org bug NB#59711
277 2007-06-14 Armin Burgmeier <armin@openismus.com>
279 * src/widgets/modest-attachments-view.h:
280 * src/widgets/modest-attachments-view.c: Added
281 modest_attachments_view_has_attachments() and fixed coordinate
282 transformation in get_att_view_at_coords(). This fixes attachment
285 * src/widgets/modest-msg-view.c: Make use of
286 modest_attachments_view_has_attachments() to decide whether to show
287 attachments in the header.
289 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
291 * src/maemo/modest-connection-specific-smtp-edit-window.c:
292 (on_change), (on_combo_security_changed),
293 (modest_connection_specific_smtp_edit_window_init),
294 (modest_connection_specific_smtp_edit_window_set_connection),
295 (modest_connection_specific_smtp_edit_window_is_dirty):
296 * src/maemo/modest-connection-specific-smtp-edit-window.h:
297 * src/maemo/modest-connection-specific-smtp-window.c:
300 Show an comfirmation dialog for the smpt-edit-window if there are
301 unsaved changes and the user hits cancel.
302 (projects.maemo.org bug NB#60479)
304 2007-06-14 Armin Burgmeier <armin@openismus.com>
306 * src/maemo/easysetup/modest-easysetup-wizard.c:
307 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
308 address" info in banner instead of node, and select all the text as
309 per UI spec. This fixes projects.maemo.org bug NB#60550.
311 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
313 reviewed by: <delete if not using a buddy>
315 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
316 * src/modest-ui-actions.c: (folder_refreshed_cb):
318 2007-06-14 Murray Cumming <murrayc@murrayc.com>
320 * src/widgets/modest-folder-view.c: (filter_row):
321 Explictly filter out the per-account outbox accounts. I don't know why
322 these only sometimes show up, but now they should never show up in the UI.
323 This should fix projects.maemo.org bug NB#60160.
325 2007-06-14 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
328 when the toolbar does not exist yet.
329 * src/modest-widget-memory.c: (save_settings_header_view):
330 Added g_warnings() to help us to discover when we are trying to set
331 an empty columns list in gconf.
333 2007-06-14 Murray Cumming <murrayc@murrayc.com>
337 Added modest_init_get_default_header_view_column_ids().
339 * src/modest-widget-memory.c: (restore_settings_header_view):
340 Use the new function to get defaults, if the gconf key is empty,
341 instead of not creating any columns. This seems to fix the
342 empty right-hand pane problems.
344 * src/widgets/modest-header-view.h: Improved documentation.
346 2007-06-13 Murray Cumming <murrayc@murrayc.com>
348 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
349 Revert the use of the display name as the account name, because this
350 is generally wrong and would break the code that follows.
352 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
354 * src/maemo/easysetup/modest-easysetup-wizard.c:
355 (check_for_supported_auth_methods), (on_before_next),
358 More correct fix for projects.maemo.org bug NB# 58991
359 Do not longer accept AUTH_PASSWORD as secure method and choose
360 correct method when creating the account.
362 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
364 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
365 Fixed projects.maemo.org bug NB# 58991
367 2007-06-13 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-init.c: (modest_init_init_core),
370 (modest_init_local_folders): Fixed compilation errors.
372 2007-06-13 Murray Cumming <murrayc@murrayc.com>
374 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
375 Remove unnecessary lib/include, though it is good in principle when needed.
377 * src/modest-init.c: (modest_init_one_local_folder),
378 (modest_init_local_folders):
379 * src/modest-init.h: Initialize the .modest library for memory cards,
380 instead of just doing nothing for them. This should allow us to create
381 folders there, fixing projects.maemo.org bug NB#59297.
383 2007-06-13 Murray Cumming <murrayc@murrayc.com>
385 * libmodest-dbus-client/libmodest-dbus-client.c:
386 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
387 (libmodest_dbus_client_compose_mail),
388 (libmodest_dbus_client_open_message),
389 (libmodest_dbus_client_send_and_receive),
390 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
392 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
393 (on_idle_open_message), (modest_dbus_req_handler),
394 (search_result_to_message), (modest_dbus_req_filter):
395 * src/modest-search.c: (add_hit), (modest_search_folder),
396 (modest_search_all_accounts): Improved debug messages.
398 * tests/dbus_api/test_open_message.c: (main): Improved comments.
400 * src/modest-tny-account-store.c:
401 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
404 2007-06-13 Murray Cumming <murrayc@murrayc.com>
407 2007-06-12 Murray Cumming <murrayc@murrayc.com>
409 * src/modest-tny-account-store.c: (get_server_accounts):
410 Call modest_tny_local_folders_account_add_merged_outbox_folders()
411 even when there are no accounts, so that the Outbox folder is always
412 visible. This fixes projects.maemo.org bug NB#60158.
414 2007-06-12 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/modest-main-window.c: (create_details_widget):
417 Use the mcen_va_never logical ID.
419 2007-06-12 Murray Cumming <murrayc@murrayc.com>
421 * src/dbus_api/modest-dbus-api.h:
422 * src/dbus_api/modest-dbus-callbacks.c:
423 (on_idle_open_default_inbox), (on_open_default_inbox),
424 (modest_dbus_req_handler):
425 Added a new OpenDefaultInbox method.
427 * libmodest-dbus-client/libmodest-dbus-client.h:
428 * libmodest-dbus-client/libmodest-dbus-client.c:
429 Added libmodest_dbus_client_open_default_inbox() to call the new
430 dbus method. This should be useful to projects.maemo.org bug NB#57214,
431 though it should maybe be used by a new osso-email-interface function.
433 * tests/dbus_api/Makefile.am:
434 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
437 2007-06-12 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
440 NULL, so that the signals get all the keys. This should not actually
441 change any behaviour because we currently update everything when anything
444 2007-06-12 Murray Cumming <murrayc@murrayc.com>
446 * src/widgets/modest-folder-view.c: (text_cell_data),
447 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
448 (find_inbox_iter): If tinymail tells us that the folder is
449 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
450 This causes the inbox to be selected at startup, fixing part of
451 projects.maemo.org bug NB#56305.
453 * src/modest-ui-dimming-rules.c:
454 (modest_ui_dimming_rules_on_tools_smtp_servers):
455 * src/modest-ui-dimming-rules.h: Added a callback function to dim
456 the SMTP servers menu item.
457 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
458 that the SMTP Servers menu item is dimmed when there are no accounts,
459 as a future version of the UI spec will require. This fixes
460 projects.maemo.org bug NB#56305.
462 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
464 * src/maemo/modest-maemo-utils.c:
465 (modest_maemo_utils_get_supported_secure_authentication_methods):
466 Added label to dialog instead of unreadable title
468 * src/maemo/modest-main-window.c: (sync_accounts_cb),
469 (modest_main_window_new):
470 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
473 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
474 * src/modest-account-mgr.h:
475 Added method to avoid code duplication
477 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
478 (modest_ui_actions_on_send_receive):
479 Use modest_account_mgr_has_accounts
481 2007-06-11 Murray Cumming <murrayc@murrayc.com>
483 * src/maemo/easysetup/modest-presets.c:
484 (modest_presets_get_info_server_security): Do not report secure auth
486 * src/modest-protocol-info.c: Use the defines for the gconf key names
487 for secure authentication. This was not working because we were writing
488 Password and reading password, and the check was case sensitive.
489 With this, gmail now works for receiving and sending when created via
492 2007-06-11 Murray Cumming <murrayc@murrayc.com>
494 * src/maemo/easysetup/modest-presets.c:
495 (modest_presets_get_info_server_security): Correct the key name for
496 SecureSmtp, because it seems to be case-sensitive.
497 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
498 Do not try to get the 0th notebook page if there are 0 pages, to
501 2007-06-11 Murray Cumming <murrayc@murrayc.com>
503 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
504 Prevent use of the new notification feature for now, because it currently
505 shows one dialog for each new email, which is annoying.
507 2007-06-11 Murray Cumming <murrayc@murrayc.com>
509 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
510 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
511 when no country was selected, so that we show the global ones.
512 * src/maemo/easysetup/modest-presets.c:
513 (modest_presets_get_providers): Return only the global providers, not
514 all providers when mmc=0 was requested.
516 2007-06-11 Murray Cumming <murrayc@murrayc.com>
518 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
519 (easysetup_provider_combo_box_fill): Remove debug code that showed the
520 provider ID in the combo.
522 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
523 Do not show the page numbers, because it would be confusing when we add
524 the 2 extra pages for the custom setup, when the user chooses the "Other"
525 provider. This fixes projects.maemo.org bug NB#59028
527 * src/modest-init.c: (modest_init_init_core),
528 (modest_init_local_folders):
530 * src/modest-tny-account.c:
531 (modest_tny_account_new_for_local_folders): Do not create default folders
532 for the memory card. This should fix projects.maemo.org bug NB#59328.
534 2007-06-11 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
537 Free the changed_conf_keys string items. They are already freed in the
538 idle handler if that runs first.
540 2007-06-11 Murray Cumming <murrayc@murrayc.com>
542 * src/modest-ui-actions.c:
543 (modest_ui_actions_on_password_requested): Check that the server name
544 is not NULL, because I just saw a password dialog with (null) as the
547 * src/modest-tny-folder.[h|c]: Added
548 modest_tny_folder_is_memory_card_folder().
549 * src/modest-ui-dimming-rules.c:
550 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
551 menu item for memory cards, as per the UI spec (section 7.4). This should
552 fix projects.maemo.org bug NB#59297.
554 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
556 * src/maemo/modest-main-window.c: (sync_accounts_cb):
557 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
558 is another problem with the code, see Murray's comment at line 772)
560 2007-06-08 Murray Cumming <murrayc@murrayc.com>
562 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
563 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
564 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
565 (load_from_file), (easysetup_country_combo_box_init),
566 (easysetup_country_combo_box_get_active_country_ids),
567 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
568 instead of just one ID, to avoid duplicate country names in the UI.
570 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
571 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
572 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
573 a single ID, avoiding duplicate providers.
574 * src/maemo/easysetup/modest-easysetup-wizard.c:
575 (on_combo_account_country): Adapt to use a list.
577 2007-06-08 Murray Cumming <murrayc@murrayc.com>
579 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
580 keys changed in the last X seconds.
582 * src/modest-account-mgr.h:
583 * src/modest-account-mgr.c: (on_timeout_notify_changes),
584 (on_key_change), (modest_account_mgr_class_init),
585 (modest_account_mgr_init), (modest_account_mgr_finalize):
586 As the keys are changed, save them in a GSList* and signal that GSList*
587 further every X seconds, to batch changes, to allow us to do just one
588 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
589 bug NB#56941 and other (UI-blocking) delays when changing account settings.
591 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
592 changed signal signature.
594 * src/modest-conf.c: (modest_conf_set_list),
595 (modest_conf_on_change): Reenable notification.
597 (modest_conf_maemo_fake_on_change): Comment out the hack that
598 notified immediately instead of asynchronously.
600 * src/widgets/modest-account-view.h:
601 * src/widgets/modest-account-view.c:
602 (update_account_view): Select the previously-selected account ID,
603 if possible. This fixes projects.maemo.org bug NB#56933.
605 (on_account_changed), (on_account_removed),
606 (modest_account_view_select_account):
608 Remove the block/unblock functions
609 because they were not useful.
611 * src/maemo/modest-account-view-window.c:
612 (on_delete_button_clicked), (on_edit_button_clicked),
613 (on_new_button_clicked): Remove the use of the non-working block/unblock.
615 2007-06-08 Murray Cumming <murrayc@murrayc.com>
617 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
618 Improve the error dialog to show Incorrect Account Settings, which seems
619 clearer, and say that the internal error message (to be removed from the
620 dialog later) is often misleading.
621 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
623 * src/modest-tny-account.c:
624 (modest_tny_account_new_from_server_account): Uncomment the printf of the
625 URL because this is so useful for debugging on the device.
627 * src/widgets/modest-serversecurity-combo-box.c:
628 (modest_serversecurity_combo_box_fill): Correct a logical ID.
630 2007-06-08 Murray Cumming <murrayc@murrayc.com>
632 * src/modest-mail-operation.c:
633 (modest_mail_operation_send_new_mail):
634 Added a comment about a nasty but apparently harmless message. Details
635 added to the wiki g_warnings() page.
637 2007-06-08 Murray Cumming <murrayc@murrayc.com>
639 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
640 (modest_tny_send_queue_class_init):
641 Do not use the priv struct because it is empty, to avoid g_warnings
642 about a non-existant priv struct.
644 * src/modest-tny-account-store.c:
645 (modest_tny_account_store_get_server_account),
646 (modest_tny_account_store_get_transport_account_for_open_connection
647 ): Do not try to get transport server accounts for local folders,
648 because they don't have any. This avoids a g_warning().
650 * src/maemo/modest-main-window.c:
651 (modest_main_window_notify_send_receive_initied),
652 (on_configuration_key_changed):
653 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
655 * src/modest-mail-operation.c:
656 (modest_mail_operation_update_account):
657 * src/modest-tny-account-store.h:
658 * src/modest-tny-account.c:
659 (modest_tny_account_get_special_folder),
660 (modest_tny_account_new_for_local_folders),
661 (modest_tny_account_new_for_per_account_local_outbox_folder):
662 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
663 * src/modest-tny-local-folders-account.c:
664 (add_account_folders_to_merged_folder):
665 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
666 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
667 (modest_ui_actions_on_send):
668 * src/widgets/modest-folder-view.c: (update_model):
669 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
670 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
671 modest_tny_account_store_get_tny_account_by_account() to
672 modest_tny_account_store_get_server_account() to make the code clearer.
674 2007-06-07 Marcus Bauer <marcusb@openismus.com>
676 * src/dbus_api/modest-dbus-api.h:
677 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
678 * src/maemo/modest-msg-edit-window.c:
679 (modest_msg_edit_window_attach_file_noninteractive):
680 added g_warning in case the file to be attached does not exist
681 * tests/dbus_api/test_compose_mail.c: (main):
682 removed obsolete comment, added generic files as test case
684 2007-06-07 Murray Cumming <murrayc@murrayc.com>
686 * src/modest-tny-account-store.c: (get_server_accounts):
687 Create the local folders account only once, not once for each outbox, and
688 not only when there are some outboxes.
690 2007-06-07 Murray Cumming <murrayc@murrayc.com>
692 * src/widgets/modest-folder-view.c: (update_model): Comment out some
693 code that is causing a crash at startup. Sergio says that he is fixing this.
695 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
697 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
698 * src/maemo/modest-account-settings-dialog.c:
699 (create_page_outgoing),
700 (modest_account_settings_dialog_set_account_name),
701 (save_configuration):
702 - Fixed handling of the "Use secure authentication" toggle to comply with
703 the ui specification. See also projects.maemo.org bug NB#58400
705 - Restore the Secure connection setting combo correctly when loading
708 * src/maemo/modest-maemo-utils.c:
709 (on_camel_account_get_supported_secure_authentication),
710 (modest_maemo_utils_get_supported_secure_authentication_methods):
711 Fixed a crasher if operation is canceled
713 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
714 (modest_protocol_info_auth_is_secure):
715 * src/modest-protocol-info.h:
717 Added two new methods to determine if a protocol/auth method is secure/encrypted in
718 the sense of the "Use secure authentication" toggle.
720 2007-06-07 Murray Cumming <murrayc@murrayc.com>
722 * src/modest-tny-account-store.h:
723 * src/modest-tny-account-store.c:
724 Added modest_tny_account_store_get_local_folders_account().
726 * src/modest-tny-folder.h:
727 * src/modest-tny-folder.c:
728 (modest_tny_folder_get_account):
729 Added this replacement for tny_folder_get_account() which returns
730 the local-folders account for TnyMergeFolders, to avoid the
731 warning about the unimplemented get_account_func() vfunc().
733 (modest_tny_folder_get_rules),
734 * src/modest-ui-actions.c:
735 (modest_ui_actions_on_folder_selection_changed):
736 * src/modest-mail-operation.c:
737 (modest_mail_operation_remove_folder),
738 (modest_mail_operation_xfer_folder),
739 (modest_mail_operation_rename_folder),
740 (modest_mail_operation_get_msg),
741 (modest_mail_operation_get_msgs_full),
742 (modest_mail_operation_remove_msg),
743 (modest_mail_operation_xfer_msgs),
744 (modest_mail_operation_refresh_folder):
745 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
747 2007-06-07 Murray Cumming <murrayc@murrayc.com>
749 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
750 (modest_server_account_set_security):
751 * src/modest-defs.h: Add comments explaining that our
752 UI spec means TLS when it says Normal, so these do not look like errors.
754 * src/modest-tny-account.c:
755 (modest_tny_account_new_from_server_account): Use the new tinymail
756 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
757 for TLS. This should fix projects.maemo.org bug NB#58460.
759 2007-06-06 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/easysetup/modest-easysetup-wizard.c:
762 (create_account): Correct the position of the gconf sanity check warning.
763 (on_button_edit_advanced_settings): Show the dialog immediately, instead
764 of using the g_idle_add() hack, because this does not seem to be necessary
765 on osso 1.1. It might even work on Maemo Bora if the problems were actually
766 caused by something other than maemo's gconf.
767 This fixes projects.maemo.org bug #59022.
769 2007-06-06 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-account-mgr-helpers.c:
772 (modest_account_mgr_get_default_account): Do not check that the account
773 exists if there is no default account (NULL), to fix a runtime warning.
775 2007-06-06 Murray Cumming <murrayc@murrayc.com>
777 * src/widgets/modest-folder-view.c: (update_model):
778 Do not unref the treemodel before we have finished with it.
779 This prevents a valgrind warning and an occasional crash at startup.
781 2007-06-06 Marcus Bauer <marcusb@openismus.com>
783 * libmodest-dbus-client/libmodest-dbus-client.h:
784 added libmodest_dbus_client_compose_mail()
785 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
787 added functions needed for SendAsMail() functionality
788 * src/maemo/modest-msg-edit-window.c:
789 (modest_msg_edit_window_attach_file_noninteractive):
790 non interactively attaching files to message edit window
791 * src/widgets/modest-msg-edit-window.h:
792 * tests/dbus_api/Makefile.am:
793 added test_compose_mail.c
794 * tests/dbus_api/test_compose_mail.c: (main):
796 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
798 * src/modest-account-view.c:
799 Fixed bug projects.maemo.org bug NB#59307
801 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
803 * src/maemo/easysetup/modest-easysetup-wizard.c:
804 (get_serverport_incoming), (on_before_next), (create_account):
805 * src/maemo/modest-account-settings-dialog.c:
806 (modest_account_settings_dialog_set_account_name):
807 * src/maemo/modest-maemo-utils.c:
808 (on_camel_account_get_supported_secure_authentication_status),
809 (on_camel_account_get_supported_secure_authentication),
810 (on_secure_auth_cancel),
811 (modest_maemo_utils_get_supported_secure_authentication_methods):
813 Implemented security authentication for settings and easysetup.
815 2007-06-05 Murray Cumming <murrayc@murrayc.com>
817 * src/maemo/modest-main-window.c: (create_details_widget):
818 Show the total size for memory card accounts too, instead of showing
819 the name again. Fixes bug projects.maemo.org bug NB#59307.
821 2007-06-05 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-tny-simple-folder-store.c:
825 * src/modest-tny-simple-folder-store.h: Removed.
827 * src/modest-tny-local-folders-account.h
828 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
829 for the local-folders maildir, with an extra TnyMergedFolder containing
830 the folders of the per-account outbox store accounts.
831 * src/modest-tny-account-store.c: (get_server_accounts):
832 Add the outboxes to the special local folders account after creating it.
834 * src/modest-tny-account.c:
835 (modest_tny_account_new_for_local_folders): Create the derived
836 account when creating the main local-folders account.
838 * src/maemo/modest-main-window.c: (create_details_widget),
839 (modest_main_window_set_contents_style):
840 Adapted to the use of the derived account instead of the folder store.
842 * src/modest-ui-actions.c:
843 (modest_ui_actions_on_folder_selection_changed):
844 * src/modest-ui-dimming-rules.c:
845 (modest_ui_dimming_rules_on_new_folder):
846 * src/widgets/modest-folder-view.c: (text_cell_data),
847 (icon_cell_data), (filter_row), (update_model),
848 (get_cmp_rows_type_pos):
851 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
852 Do not get the priv struct, because no priv struct has been set,
853 to avoid a runtime warning.
855 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
856 #ifelse with #else, to fix a warning, to fix the build.
859 2007-06-05 Christian Kellner <ckellner@openismus.com>
861 * libmodest-dbus-client/libmodest-dbus-client.c:
862 Fix small typo in doc (why do you always see them
863 AFTER committing stuff?)
866 2007-06-05 Christian Kellner <ckellner@openismus.com>
868 * libmodest-dbus-client/libmodest-dbus-client.c:
869 (libmodest_dbus_client_search):
870 Initialize hit list with NULL. Also set folder list
871 to "" if NULL was supplied.
874 2007-06-03 Christian Kellner <ckellner@openismus.com>
876 * libmodest-dbus-client/libmodest-dbus-client.c:
877 (modest_search_hit_list_free):
878 Make it save to call it with NULL.
880 * src/dbus_api/modest-dbus-callbacks.c:
881 * src/modest-search.c:
882 Return full ModestSearchHits as the search result list not TnyHeader
883 since can't be around withouth the correspoding TnyFolder.
885 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
887 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
888 Added currently commented code to check for secure auth
890 * src/maemo/modest-account-settings-dialog.c: (on_response),
891 (save_configuration), (show_ok):
892 Fixed projects.maemo.org bugs NB #59248 and #59251
894 * src/maemo/modest-maemo-utils.c:
895 (on_camel_account_get_supported_secure_authentication_status),
896 (on_camel_account_get_supported_secure_authentication),
897 (modest_maemo_utils_get_supported_secure_authentication_methods):
898 * src/maemo/modest-maemo-utils.h:
899 Moved get_supported_secure_authentication() method here to be able
900 to use it from easysetup wizard.
902 * src/modest-pair.c: (on_pair_compare_as_string):
903 Should compare string with first part of pair and not
904 strcmp pairs which will crash.
906 * src/modest-protocol-info.c:
907 (modest_protocol_info_protocol_is_store):
908 * src/modest-protocol-info.h:
909 Added modest_protocol_info_get_auth_protocol_name()
911 2007-06-03 Armin Burgmeier <armin@openismus.com>
913 * src/modest-mail-operation.c:
914 (modest_mail_operation_get_msgs_full): Set priv->account also when
915 only retrieving a single message. This avoids a crash when canceling
918 (modest_mail_operation_notify_end): Do not explicitely remove the
919 operation from the queue but only emit the progress_changed signal.
920 The queue itself listens to that signal to remove the operation when
921 it is finished. This reduces coupling and removes a potential deadlock
922 when modest_mail_operation_notify_end() is called from the queue
923 itself. If that is a problem performance-wise, I would suggest to
924 implement a status-changed signal or something.
926 * src/modest-mail-operation-queue.c: Make sure to never call a
927 function from another file while the queue is locked. This (hopefully)
928 fixes another deadlock when exiting the application while retrieving
931 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
933 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
934 Fixed build if libogs is not available
936 2007-06-03 Christian Kellner <ckellner@openismus.com>
938 * libmodest-dbus-client/libmodest-dbus-client.h:
939 * libmodest-dbus-client/libmodest-dbus-client.c:
940 (libmodest_dbus_client_delete_message):
941 Implement deletion of messages (Client side).
943 (modest_search_hit_free),
944 (modest_search_hit_list_free):
945 Utility functions to free the result hits.
947 * src/dbus_api/modest-dbus-api.h:
948 * src/dbus_api/modest-dbus-callbacks.c:
950 (modest_dbus_req_handler):
951 Implement deletion of messages (Server side).
953 * tests/dbus_api/test_search.c: (main):
956 * tests/dbus_api/Makefile.am:
957 * tests/dbus_api/test_delete_message:
958 Add little test for the message deletion logic
960 2007-06-03 Armin Burgmeier <armin@openismus.com>
962 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
963 when the operation queue was not empty. projects.maemo.org bug
966 2007-06-03 Armin Burgmeier <armin@openismus.com>
968 * src/widgets/modest-account-view.c
969 (on_account_default_toggled): Toggle default account column
970 explicitely instead of waiting for gconf notification (which is
971 currently ignored). This should fix projects.maemo.org bug NB#56910
972 for now. It should probably be removed when gconf notifications are
975 2007-06-03 Christian Kellner <ckellner@openismus.com>
977 * libmodest-dbus-client/libmodest-dbus-client.c:
978 Removed debugging spew.
980 * src/dbus_api/modest-dbus-callbacks.c:
981 Added debugging info.
983 * src/modest-search.c:
984 (modest_search_all_accounts):
985 Use tny_account_store_get_accounts () on the account store
986 to get all accounts which is the way to get all accounts.
988 * tests/dbus_api/test_search.c: (main):
989 Make it possible to supply the search term on the command line.
991 2007-06-03 Christian Kellner <ckellner@openismus.com>
993 * libmodest-dbus-client/libmodest-dbus-client.c:
994 * libmodest-dbus-client/libmodest-dbus-client.h:
995 Implement searching for mesages over raw dbus. (Client side)
997 * src/dbus_api/Makefile.am:
998 * src/dbus_api/modest-dbus-api.h:
999 * src/dbus_api/modest-dbus-callbacks.c:
1000 * src/dbus_api/modest-dbus-callbacks.h:
1001 Search framework (Server side). Also implement on_idle_open_message().
1003 * src/maemo/modest-platform.c: (modest_platform_init):
1004 Prepare for raw dbus/osso rpc interaction.
1006 * src/modest-search.h:
1007 Changed minsize from unspecific guint to guint32.
1009 * src/modest-search.c:
1011 Added strange hack which magically made tnymail work.
1013 (modest_search_folder),
1014 (modest_search_account),
1015 (modest_search_all_accounts):
1016 Implement helper functions to search all accounts, specific account
1019 * tests/dbus_api/Makefile.am:
1020 * tests/dbus_api/test_open_message.c:
1021 Read url to open from commandline.
1023 * tests/dbus_api/test_search.c:
1024 Implement small test for dbus search stuff
1026 2007-06-02 Armin Burgmeier <armin@openismus.com>
1028 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1029 include account type and account title. This fixes projects.maemo.org
1032 * src/maemo/modest-account-view-window.c: Set a title for the window.
1034 2007-06-02 Armin Burgmeier <armin@openismus.com>
1036 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1037 incoming and outgoing server name based on email address and server
1038 types as long as the names have not been edited manually. This fixes
1039 projects.maemo.org bug NB#58671.
1041 2007-06-02 Armin Burgmeier <armin@openismus.com>
1043 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1044 server type cannot be changed in future to the incoming details page
1045 when creating an account. This fixes projects.maemo.org bug NB#59029.
1047 2007-06-02 Armin Burgmeier <armin@openismus.com>
1049 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1050 and assigned max width chars so that they wrap instead of being
1051 truncated. Fixes projects.maemo.org bug NB#56126.
1053 2007-06-02 Armin Burgmeier <armin@openismus.com>
1055 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1056 introductory note to the connection specific smtp servers dialog, as
1057 section 8.12 of the email UI specification requires. This fixes
1058 projects.maemo.org bug NB#59212.
1060 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1063 Check for running mail operations, and offer to cancel them, as per the UI
1064 spec. This fixes projects.maemo.org bug NB#59041 .
1065 However, I suspect that tinymail may still use the network connection
1066 in ways that we cannot detect or cancel. But it should at least adapt to
1067 changes fairly well.
1069 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-tny-account-store.c: (recreate_all_accounts),
1072 (get_cached_accounts), (get_server_accounts): Do more sensible
1073 ref-counting of the temporarily-cached outbox accounts list. This seems
1074 to fix a crash when entering the password when the password was wrong.
1076 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1078 * src/gnome/modest-main-window.c: (connect_signals):
1079 * src/modest-tny-account-store.c: (get_password),
1080 (modest_tny_account_store_alert): Added comments and clues and
1081 commented-out code about how we currently fail to deal with connection
1082 errors and wrong passwords, and how we should.
1084 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1086 * src/widgets/modest-retrieve-combo-box.c:
1087 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1088 This fixes projects.maemo.org bug NB#58472 .
1090 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1092 * src/maemo/easysetup/modest-easysetup-wizard.c:
1093 (create_page_complete_easysetup):
1094 (create_page_complete_custom): Correct the last commit,
1095 putting the correct sentences in the correct pages.
1097 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1099 * src/maemo/easysetup/modest-easysetup-wizard.c:
1100 (create_page_complete_custom): Show the second sentence of text
1101 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1104 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1107 Set the leave-on-server conf key by default. This fixes
1108 projects.maemo.org bug NB#59258 .
1110 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/modest-account-view-window.c:
1113 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1114 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1117 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/easysetup/modest-easysetup-wizard.c:
1120 (create_caption_new_with_asterisk):
1121 * src/maemo/modest-account-settings-dialog.c:
1122 (create_caption_new_with_asterisk):
1123 Uncomment the code to add the asterisk, because they are no longer in the
1124 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1125 (update_incoming_server_title): Add an asterisk here too.
1127 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1129 * src/maemo/modest-maemo-global-settings-dialog.c:
1130 (current_connection): Check that we are even connected before trying to
1131 get the current connection name, to prevent a warning.
1133 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1134 Change the comments because tny_maemo_conic_device_connect() is now meant to
1136 * src/modest-mail-operation.c:
1137 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1138 make sure we have a connection and fail if we can't connect.
1140 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1142 * src/maemo/modest-main-window.c:
1143 (on_account_store_connecting_finished): Do not try to get the
1144 connection ID if we are not really connected. I am surprised that
1145 this signal handler is called when we are not connected.
1147 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-error.h:
1150 * src/modest-ui-actions.c:
1151 (modest_ui_actions_get_msgs_full_error_handler):
1152 Renamed an enum, added comments, added an enum
1153 for retrieve-limit errors.
1155 * src/modest-mail-operation.c: (foreach_add_item),
1156 (internal_folder_observer_update), (update_account_thread),
1157 (modest_mail_operation_get_msgs_full):
1158 (modest_mail_operation_update_account),
1159 Added comments about how this works, and some code that should
1160 (but does not) check the retrieve-limit. See the TODO comment.
1162 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1164 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1165 Initialize help_id to fix the build. Warnings are good.
1167 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1169 * src/widgets/modest-hbox-cell-renderer.c:
1170 (modest_hbox_cell_renderer_append):
1171 * src/widgets/modest-vbox-cell-renderer.c:
1172 (modest_vbox_cell_renderer_append):
1173 Fix the last commit by doing an extra ref.
1175 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1177 * src/widgets/modest-hbox-cell-renderer.c:
1178 (modest_hbox_cell_renderer_append):
1179 * src/widgets/modest-vbox-cell-renderer.c:
1180 (modest_vbox_cell_renderer_append):
1181 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1182 to fix the build with Maemo Bora.
1183 However, there seems to be a remaining crash, probably due to reference
1186 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1188 * src/modest-tny-account.c:
1189 (modest_tny_account_new_for_local_folders):
1190 Use hildon_file_system_info_async_new() to get a better name for
1191 the memory card account, setting it as the account name.
1192 The timing seems to work, but this is probably
1193 not the best place to do this. See the TODO comment.
1194 * src/maemo/modest-main-window.c: (create_details_widget):
1195 * src/widgets/modest-folder-view.c: (text_cell_data):
1196 Use the tny account name instead of hardcoding a name.
1198 2007-05-30 Christian Kellner <ckellner@openismus.com>
1200 * src/modest-search.c: (modest_search):
1201 Correctly set part_search_func even if we have already parsed
1202 the query and thus a valid OgsTextSearcher object.
1204 2007-05-30 Christian Kellner <ckellner@openismus.com>
1207 Search and check for libogs.
1210 Incooparte the ogs build env.
1212 * src/modest-mime-part-search-stream.c:
1213 * src/modest-mime-part-search-stream.h:
1214 Removed since we do the real searching now in modest-search.c.
1216 * src/modest-search.c:
1217 * src/modest-search.h:
1218 Implement support for ogs. We use that if available and requested
1219 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1220 should now handle the corner case when the search term is spread
1221 across multiple reads.
1222 Also the logic in modest_search () was corrected to search all
1223 requested fields until one is found.
1225 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1227 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1229 * src/modest-init.h:
1230 * src/modest-init.c: Made modest_init_local_folders() take a
1231 path and be public so we can iniitialize maildir folders on
1234 * src/modest-local-folder-info.h:
1235 * src/modest-local-folder-info.c:
1236 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1238 * src/modest-tny-account.c:
1239 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1240 still means the standard local-folders path on the local volume.
1242 * src/modest-tny-account-store.c:
1243 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1244 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1245 all accounts when that happens.
1246 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1247 this too, so it shows up in the treeview.
1249 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/modest-maemo-global-settings-dialog.c:
1252 (current_connection):
1253 * src/widgets/modest-global-settings-dialog.c:
1254 (current_connection_default):
1255 Use the enum values instead of 0, 1 and -1,
1256 to make the code clearer.
1258 * src/modest-account-mgr-helpers.c:
1259 (modest_account_mgr_get_connection_specific_smtp): Make this code
1262 * src/modest-runtime.h:
1263 * src/modest-runtime.c:
1264 Added modest_runtime_remove_all_send_queues().
1265 * src/maemo/modest-main-window.c:
1266 (on_account_store_connecting_finished): Recreate the send queues,
1267 using the appropriate transport accounts for this new connection.
1268 Some futher adapting might be needed if the old send queues are not
1269 automatically stopped at this point.
1271 * src/modest-tny-account-store.c: (get_server_accounts):
1272 Create the connection-specific transport accounts, so that they can
1273 be found later by their ID.
1275 * src/modest-tny-account.h:
1276 * src/modest-tny-account.c:
1277 Added modest_tny_account_new_from_server_account_name().
1278 modest_tny_account_new_from_server_account(): Do not create the
1279 send queues here, because they will be
1280 recreated anyway when the connection changes for the first time.
1282 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1284 * src/modest-local-folder-info.h:
1285 * src/modest-local-folder-info.c:
1286 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1287 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1288 tbox_folder): Take a modest account name instead of a server TnyAccount,
1289 so we can have per-modest-account rather than per-transport-account
1291 We must make sure that we change or recreate the exisitng send queues
1292 when the connection changes for connection-specific transport accounts.
1294 * src/modest-tny-account-store.c:
1295 (create_per_account_local_outbox_folders): Create outboxed per modest
1296 account, not per transport account.
1298 * src/modest-tny-account.h:
1299 * src/modest-tny-account.c:
1300 (modest_tny_account_get_special_folder): For outboxes, get the
1301 parent modest account name. The account is ignored for other folders.
1302 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1303 modest account name rather than a server TnyAccount.
1305 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-tny-account.c:
1308 (modest_tny_account_new_from_server_account):
1309 Call modest_runtime_get_send_queue() immediately after creating transport
1310 accounts, so that they start trying to send email from the outbox as soon
1311 as possible at startup. This is probably what we want.
1313 * src/modest-mail-operation.c: (update_account_thread):
1314 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1315 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1316 * src/modest-tny-send-queue.h:
1317 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1318 (modest_ui_actions_on_send):
1319 Added comments about how sending works, though it needs some more work.
1321 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-tny-account.c:
1324 (modest_tny_account_get_special_folder): Add TODO because this fails when
1325 the network is busy.
1326 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1327 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1328 Do not try to show this window when there is no active account. The UI
1329 specs does not tell us what to do in this case.
1331 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/Makefile.am:
1336 * src/widgets/Makefile.am: Some dist fixes.
1338 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1340 * src/maemo/modest-connection-specific-smtp-window.c:
1341 (on_button_edit): Make the code clearer, to prevent a double free.
1343 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1345 * src/maemo/modest-account-settings-dialog.c:
1346 (modest_account_settings_dialog_set_account_name),
1347 Check the connection-specific smtp servers checkbox if there are any.
1349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1350 (modest_connection_specific_smtp_edit_window_init):
1351 Start with a suitable port number.
1353 * src/modest-account-mgr-helpers.h:
1354 * src/modest-account-mgr-helpers.c: Added
1355 modest_account_mgr_get_has_connection_specific_smtp().
1357 (modest_account_mgr_set_connection_specific_smtp),
1358 (modest_account_mgr_remove_connection_specific_smtp),
1359 (modest_account_mgr_get_has_connection_specific_smtp),
1360 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1361 connection-specific smtp server accounts in the account, rather than
1362 the server account conf dir.
1364 This fixes bug projects.maemo.org bug NB#58263 .
1366 * src/modest-tny-account-store.c:
1367 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1368 if there are no server accounts yet, to prevent an infinite loop when there
1369 are no accounts. Document that one must be called before the other.
1371 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1373 * src/modest-account-mgr-helpers.c:
1374 (modest_account_mgr_get_default_account): Make sure that at least
1375 one account is always the default, if there are any enabled accounts.
1376 This is just a sanity check that shouldn't be necessary.
1378 * src/modest-account-mgr-priv.c:
1379 (_modest_account_mgr_account_from_key): Unescape the conf key to
1380 get the real account name. For instance, this is an issue if a space
1381 was in the account name, which can happen because the account name
1382 is generated from the display name.
1383 (_modest_account_mgr_get_account_keyname): Always escape the
1385 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1386 Unescape the conf keys to get the real account names.
1388 For instance, previously the is-default radio button in the accounts
1389 list was not checked for any accounts at first. This fixes that,
1390 and might fix several similar bugs.
1392 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1394 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1395 Removed some debug printfs.
1397 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1399 Modest on-disk outbox directories are now here, for instance:
1400 $HOME/.modest/outboxes/<account-id-1>/outbox
1401 $HOME/.modest/outboxes/<account-id-2>/outbox
1403 $HOME/.modest/local-folders/outbox
1404 so we can have a separate outbox for each account.
1405 But they are shown as one outbox in the GtkTreeView, by using a
1406 TnyMergeFolder in a ModestTnySimpleFolderStore.
1409 * src/modest-tny-simple-folder-store.c:
1410 * src/modest-tny-simple-folder-store.h:
1411 Added ModestTnySimpleFolderStore, used to contain folders from
1412 other folder stores, such as other accounts.
1414 * src/modest-tny-outbox-account.h:
1415 * src/modest-tny-outbox-account.c:
1416 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1417 used for the per-account local outbox folders.
1419 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1420 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1421 only use this (internally) now for the non-outbox local folders.
1423 * src/modest-init.h:
1424 * src/modest-init.c: Added modest_init_one_local_folder(), for
1425 setting up the directory structure for each local folder.
1427 * src/modest-local-folder-info.c:
1428 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1429 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1431 * src/modest-local-folder-info.h:
1432 * src/modest-tny-account-store.c: (on_account_removed),
1433 (on_account_changed), (create_per_account_local_outbox_folders),
1434 (get_server_accounts), (modest_tny_account_store_get_accounts),
1435 (modest_tny_account_store_get_tny_account_by_account),
1436 (modest_tny_folder_store_is_virtual_local_folders):
1438 * src/modest-tny-account.h:
1439 * src/modest-tny-account.c:
1440 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1441 to create an on-disk per-account local outbox folder for each
1443 (create_per_account_local_outbox_folders): Create a local outbox folder
1444 for each transport account.
1445 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1446 for all local folders.
1448 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1449 instead of using g_object_get/set() directly. It is clearer.
1451 (modest_tny_folder_store_get_message_count),
1452 (modest_tny_folder_store_get_local_size
1453 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1454 because we now use these with non-acount folder stores.
1456 (modest_tny_account_get_special_folder),
1457 (modest_tny_account_new_from_server_account),
1458 (modest_tny_account_new_from_account):
1459 (recurse_folders): Adjust to the new outbox system.
1461 * src/modest-tny-folder.h:
1462 * src/modest-tny-folder.c:
1463 (modest_tny_folder_is_local_folder),
1464 (modest_tny_folder_get_local_folder_type),
1465 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1467 * src/widgets/modest-main-window.h:
1468 * src/maemo/modest-main-window.c: (create_details_widget),
1469 (modest_main_window_set_contents_style): Show details for any folder store,
1472 (modest_tny_folder_get_rules):
1473 Remove the const. C does not support constness enough for this.
1475 * src/modest-ui-actions.c:
1476 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1477 make all outboxes appear as one, in the usual local-folders tree node.
1479 (set_active_account_from_tny_account),
1480 (modest_ui_actions_on_folder_selection_changed):
1481 * src/widgets/modest-folder-view.c: (text_cell_data),
1482 (icon_cell_data), (filter_row),
1483 (add_account_folders_to_merged_folder),
1484 (add_account_folders_to_simple_folder_store), (),
1485 (get_cmp_rows_type_pos), (cmp_rows),
1486 (modest_folder_view_set_account_id_of_visible_server_account):
1487 Adjust to the new outbox system, using generic folder stores and folders
1488 in the GtkTreeModel.
1490 2007-05-23 Christian Kellner <ckellner@openismus.com>
1492 * src/modest-mail-operation.c:
1493 (modest_mail_operation_update_account):
1494 Use info->max_size instead of unintialized local var [small
1495 build fix]. (Added TODO to review that change since I don't
1498 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1500 * libmodest-dbus-client/libmodest-dbus-client.c:
1501 (libmodest_dbus_client_compose_mail): function added
1502 * src/dbus_api/modest-dbus-api.h:
1503 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1504 (on_compose_mail): Implementation of the SendAsMail functionality
1506 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1508 * src/modest-account-mgr.c:
1509 (modest_account_mgr_add_server_account): Set the secure-connection
1510 conf key for transport accounts as well as store accounts. I don't know
1511 why the if was there. For instance, this makes sure that we use SSL
1512 for the gmail preset from the easysetup wizard.
1514 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1516 * src/gnome/modest-main-window.c:
1517 (on_account_store_connecting_finished), (connect_signals):
1518 * src/maemo/modest-main-window.c:
1519 (on_account_store_connecting_finished), (connect_signals),
1520 (modest_main_window_new):
1521 Handle TnyAccountStore::connecting-finished instead of
1522 TnyDevice::connection-changed, because we cannot actually perform
1523 operations on accounts until TnyAccountStore has itself responded to
1524 the TnyDevice::connection-changed signal. This prevents a GError from
1526 Do not try to update at startup, because we (at least on scratchbox)
1527 already do an update at startup when the device goes online.
1528 This prevents a GError from tinymail.
1529 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1530 Added TODO about stopping simultaneous operations.
1532 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1535 * src/modest-mail-operation-queue.c:
1536 (modest_mail_operation_queue_remove):
1537 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1538 about where they happened.
1540 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1542 * src/modest-ui-actions.c:
1543 (modest_ui_actions_on_password_requested): Make sure that the remember
1544 output parameter is always TRUE.
1546 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1548 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1549 Show a OK/Cancel dialog if the error is a question, though we still do not
1550 know anything more about what we are asking the user.
1551 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1552 Fix an uninitialized variable (helper). This is a logic error, however.
1554 2007-05-21 Christian Kellner <ckellner@openismus.com>
1556 * src/modest-search.h:
1557 Correct bit shifting in the ModestSearchFlags enum.
1559 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1561 * src/modest-tny-account.c:
1562 (modest_tny_account_new_from_server_account): Do not use the lsub and
1563 check-all hard-coded IMAP options when using POP.
1565 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1567 * src/modest-tny-account.c:
1568 (modest_tny_account_new_from_server_account):
1569 Use NULL for the secure-auth method for POP when Password auth has been
1570 specified by the user, as we already do for IMAP. "auth=Login" causes
1571 an error from camel or the server.
1573 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1575 * src/maemo/modest-account-settings-dialog.c:
1576 (create_page_account_details),
1577 (modest_account_settings_dialog_set_account_name):
1578 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1579 for the leave-on-server checkbox, rathr than just the checkbox, when
1580 the protocol is not POP.
1582 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1584 * src/widgets/modest-account-view.c:
1585 * src/widgets/modest-account-view.h:
1586 Added modest_account_view_select_account() which will be useful later
1587 to asynchronously re-select the edited account.
1589 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1591 * src/maemo/modest-account-settings-dialog.c:
1592 (modest_account_settings_dialog_set_account_name):
1593 Automatically choose the port numbers based on the secure authentication
1594 methods, if they have not been chosen before.
1595 This fixes projects.maemo.org bug NB#56273 .
1597 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/modest-main-window-ui.h:
1600 * src/modest-ui-actions.c:
1601 * src/modest-ui-actions.h:
1602 Connect the Tools/SMTP Servers menu item to
1603 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1604 SMTP servers dialog, as in the UI specification and saves changes when it
1605 is closed. This fixed projects.maemo.org bug NB#56305 .
1607 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1609 * src/maemo/modest-connection-specific-smtp-window.c:
1610 (modest_connection_specific_smtp_window_init):
1611 Use gtk_window_set_default_size() to make this window big enough, so
1612 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1614 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1617 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1618 (modest_connection_specific_smtp_edit_window_init),
1619 Do not try to connect to a combobox signal before the combobox exists.
1620 This fixes the cras in projects.maemo.org bug NB#56288 .
1621 (modest_connection_specific_smtp_edit_window_get_settings):
1622 Remove the server_account_name parameter which was being checked for NULL
1623 though it was not used.
1625 * src/maemo/modest-connection-specific-smtp-window.c:
1626 (modest_connection_specific_smtp_window_fill_with_connections),
1627 (on_button_edit), (modest_connection_specific_smtp_window_init):
1628 Correct the number of treemodel columns to prevent a warning.
1629 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1630 libconic does not work.
1632 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1634 * src/modest-tny-account.c:
1635 (modest_tny_account_new_from_server_account):
1636 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1637 SMTP when "None" was chosen by the user. However, with my SMTP server that
1638 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1641 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1644 to explain the memory management issue with the ID in the ModestPair.
1646 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1647 (add_sending_page), (modest_account_assistant_finalize):
1648 * src/gnome/modest-gnome-global-settings-dialog.c:
1649 (create_updating_page), (create_composing_page):
1650 * src/gnome/modest-msg-edit-window.c: (get_transports),
1651 (init_window), (modest_msg_edit_window_finalize),
1652 (modest_msg_edit_window_get_msg_data):
1653 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1654 * src/gnome/modest-transport-widget.c:
1655 (modest_transport_widget_finalize), (smtp_configuration):
1656 * src/maemo/modest-maemo-global-settings-dialog.c:
1657 (create_updating_page), (create_composing_page):
1658 * src/maemo/modest-msg-edit-window.c: (get_transports),
1659 (init_window), (modest_msg_edit_window_finalize),
1660 (modest_msg_edit_window_get_msg_data),
1661 (modest_msg_edit_window_free_msg_data):
1662 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1663 (modest_store_widget_finalize):
1664 * src/maemo/modest-transport-widget.c:
1665 (modest_transport_widget_finalize), (smtp_configuration):
1666 * src/modest-main.c: (send_mail):
1667 * src/widgets/modest-combo-box.h:
1668 * src/widgets/modest-global-settings-dialog-priv.h:
1669 * src/widgets/modest-global-settings-dialog.c:
1670 (modest_global_settings_dialog_finalize):
1671 * src/widgets/modest-msg-edit-window.h:
1672 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1673 as long as the combo box, to prevent use of freed memory for the ID.
1675 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1677 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1678 get_accounts(), to make this clearer. Do not check for the enabled gconf
1679 key, because we do not use this for server accounts (at least, not yet).
1680 This allows us to send email again.
1682 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1684 * src/maemo/modest-platform.c:
1685 (on_modest_conf_update_interval_changed), (modest_platform_init):
1686 Only respond to this particular key change. All these strcmp()s cannot be
1689 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1691 * src/maemo/modest-maemo-global-settings-dialog.c:
1692 (current_connection): Prevent a crash in scratchbox when
1693 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1694 * src/maemo/modest-platform.c:
1695 (on_modest_conf_update_interval_changed), (modest_platform_init):
1696 Get the update interval from gconf and reset it when the gconf key changes.
1698 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-protocol-info.c:
1701 * src/modest-protocol-info.h: Adde enum-specific get functions,
1702 instead of using a ModestProtocolType enum parameter.
1704 * src/gnome/modest-account-assistant.c:
1705 * src/gnome/modest-store-widget.c:
1706 * src/gnome/modest-store-widget.h:
1707 * src/gnome/modest-transport-widget.c:
1708 * src/gnome/modest-transport-widget.h:
1709 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1710 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1711 * src/maemo/easysetup/modest-easysetup-wizard.c:
1712 * src/maemo/modest-account-settings-dialog.c:
1713 * src/maemo/modest-account-settings-dialog.h:
1714 * src/maemo/modest-store-widget.c:
1715 * src/maemo/modest-store-widget.h:
1716 * src/maemo/modest-transport-widget.c:
1717 * src/maemo/modest-transport-widget.h:
1718 * src/modest-account-mgr-helpers.c:
1719 * src/modest-account-mgr-helpers.h:
1720 * src/modest-account-mgr.c:
1721 * src/modest-account-mgr.h:
1722 * src/modest-tny-account.c:
1723 * src/modest-tny-folder.c:
1724 * src/widgets/modest-account-view.c:
1725 * src/widgets/modest-retrieve-combo-box.c:
1726 * src/widgets/modest-retrieve-combo-box.h:
1727 * src/widgets/modest-secureauth-combo-box.c:
1728 * src/widgets/modest-serversecurity-combo-box.c:
1729 * src/widgets/modest-serversecurity-combo-box.h:
1730 * tests/check_account-mgr.c:
1731 Use the specific functions, and use the re-renamed enum values for GNOME too.
1733 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-pair.h:
1736 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1737 so we can get the second based on the first.
1739 * src/maemo/modest-account-settings-dialog.h:
1740 * src/maemo/modest-account-settings-dialog.c:
1741 Added get_supported_secure_authentication_methods(), though it is mostly
1742 commented-out for now until the necessary API is committed to tinymail.
1743 (modest_account_settings_dialog_set_account_name),
1744 (save_configuration): Request the supported authentication methods from the
1745 server, so we can choose a working method.
1747 * src/modest-tny-account-store.h:
1748 * src/modest-tny-account-store.c:
1749 (modest_tny_account_store_get_session): Rename from
1750 tny_account_store_get_session().
1752 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-protocol-info.h: Split the ModestProtocol enum
1755 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1756 There was no need to have these unrelated values in one enum.
1758 * src/: many files: Adapted to changed enum. This makes the code a bit
1759 clearer, and the compiler could catch some errors.
1761 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1763 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1764 Show the detailed internal camel error message when an error happens
1765 during the configuration, so that our testers can give us more clues.
1766 For instance, in projects.maemo.org bug NB#56910 .
1768 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-tny-account.c:
1771 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1772 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1774 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1776 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1777 * src/maemo/modest-account-settings-dialog.c:
1778 (modest_account_settings_dialog_set_account_name),
1779 (save_configuration): For the incoming secure authentication checkbox,
1780 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1781 the UI specification. PLAIN does not seem to be supported for most IMAP
1782 servers anyway, and I am not sure what it would mean.
1783 However, we probably need to discover which of the secure-authentication
1784 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1785 * src/modest-account-mgr-helpers.c:
1786 (modest_account_mgr_get_server_account_data):
1788 * src/modest-tny-account.c:
1789 (modest_tny_account_new_from_server_account):
1790 Use tny_account_set_mech() to set secure-authentication methods,
1791 with some special-casing for IMAP, based on my observations of how
1794 * src/modest-account-mgr-helpers.h:
1795 * src/modest-account-mgr.c:
1796 * src/modest-defs.h: Comment that the URI is only used for local folders.
1798 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1800 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1801 parameter const, just to be neat.
1802 * src/modest-text-utils.c: (modest_text_utils_inline):
1803 End g_strconcat() with NULL, as its documentation says. This is almost
1804 certainly the cause of my crash at startup on the device. Interestingly,
1805 valgrind doesn't tell us about these errors.
1807 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1809 * scripts/build-packages: Added more precise comments about how to use
1810 this script, though I still get this error:
1811 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1812 error building tinymail
1814 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1816 * src/maemo/modest-main-window.c: (on_account_update):
1817 Very slight cleanup, hoping to make it simpler to discover what causes
1818 a crash here sometimes.
1820 * src/modest-tny-account.c:
1821 (modest_tny_account_new_from_server_account): Set the port. Added
1822 comments about the options and a TODO comment because I need to find out
1823 how to specify the secure authentication method.
1825 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1827 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1828 changed CFlags paths form modest to libmodest
1830 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1832 * src/modest-account-mgr-helpers.c:
1833 (modest_account_mgr_get_server_account_data),
1834 (modest_account_mgr_free_server_account_data):
1835 * src/modest-account-mgr-helpers.h:
1836 * src/modest-account-mgr.c:
1837 (modest_account_mgr_add_server_account):
1838 * src/modest-defs.h:
1839 * src/modest-tny-account.c:
1840 (modest_tny_account_new_from_server_account):
1841 Determine the options for tny_camel_account_add_option() here,
1842 based on the settings, rather than storing them directly in gconf.
1844 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1847 Show a more friendly error dialog now that we expect (from the tinymail
1848 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1850 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/modest-main-window.c: (on_account_update): Check that
1853 account_name is not NULL, to prevent a crash at startup that I am
1854 seeing on the N800. I do wonder why it is NULL.
1856 * src/maemo/easysetup/modest-easysetup-wizard.c:
1857 (create_page_user_details):
1858 * src/maemo/modest-account-settings-dialog.c:
1859 (create_page_user_details), (create_page_outgoing):
1860 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1861 (modest_connection_specific_smtp_edit_window_init):
1862 * src/modest-ui-actions.c:
1863 (modest_ui_actions_on_password_requested):
1864 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1865 might do something useful with the on-screen keyboard.
1867 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/modest-main-window.c: (on_account_update):
1870 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1871 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1873 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1875 * src/modest-tny-account-store.c: (on_account_changed):
1876 Correct the signature of this signal handler.
1878 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1880 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1881 Show a HildonNote instead of a GtkDialog for Maemo.
1883 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1885 * src/widgets/modest-account-view.h:
1886 * src/widgets/modest-account-view.c: (on_account_changed),
1887 (on_account_removed). Added a boolean flag, set/unset by
1888 modest_account_view_block_conf_updates(),
1889 modest_account_view_unblock_conf_updates() to prevent unnecessary
1890 updates, but this is not very useful because the gconf notifications are
1891 so delays (maybe only on Maemo Bora).
1892 So auto-updating is turned off, and these functions do an explicit
1893 update when necessary.
1894 However, something else is still doing too much work when adding/removing
1895 accounts, probably in another part of the application.
1897 * src/maemo/modest-account-view-window.c:
1898 (on_delete_button_clicked), (on_edit_button_clicked),
1899 (on_new_button_clicked): Use the new functions.
1901 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1903 * src/modest-account-mgr-helpers.c:
1904 (modest_account_mgr_set_first_account_as_default):
1905 Sort the list of names alphabetically-by-title, so we choose the first one
1907 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1908 alphabetically by the title.
1910 This fixes projects.maemo.org bug NB#56418 .
1912 * src/modest-account-mgr-priv.c:
1913 (_modest_account_mgr_account_from_key):
1914 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1915 avoid a valgrind error, and possible random behaviour.
1917 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1919 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1920 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1921 tinymail documentation to say that this can be expected.
1922 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1923 pretty, and should not happen, but I would prefer to know when it does.
1925 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1927 * configure.ac: When using the older hildon version, probably on Bora,
1928 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1930 * src/widgets/modest-attachment-view.c:
1931 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1934 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1936 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1937 Implemented the prototype. Can be tested with
1938 tests/dbus_api/test_open_message:
1940 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1942 * src/modest-tny-account-store.c:
1943 (modest_tny_account_store_instance_init), (get_password):
1944 * src/modest-ui-actions.c:
1945 (modest_ui_actions_on_password_requested):
1946 Do not store the password in gconf, because this function is called
1947 for non-remembered passwords. Actually use the cached (in the hash map)
1948 password instead of releasing it.
1949 The password will now not be remembered if it is asked via the protected
1950 password dialog, as per the UI spec.
1952 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1954 * src/modest-defs.h:
1955 * src/modest-account-mgr-helpers.h:
1956 * src/modest-account-mgr-helpers.c:
1957 Added modest_server_account_get_username_has_succeeded(),
1958 modest_server_account_set_username_has_succeeded().
1959 (modest_server_account_set_username),
1960 Reset the has-succeeded flag if the username changes.
1962 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1963 * src/maemo/modest-connection-specific-smtp-window.c:
1964 (modest_connection_specific_smtp_window_save_server_accounts):
1965 Use modest_server_account_set_username() instead of using
1966 modest_conf_set_string() directly, so that the has-succeeded flag is always
1969 * src/modest-ui-actions.c:
1970 (modest_ui_actions_on_password_requested): Dim the username entry if
1971 the username has ever worked, as per the UI spec.
1973 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-tny-account-store.c: (get_password):
1976 * src/modest-ui-actions.c:
1977 (modest_ui_actions_on_password_requested):
1978 Allow the username to be changed too, though there is more work to
1979 be done on exactly how this behaves.
1981 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-account-mgr-helpers.h:
1984 * src/modest-account-mgr-helpers.c:
1985 Added modest_account_mgr_get_display_name(),
1986 modest_server_account_get_username(),
1987 modest_server_account_set_username(),
1988 modest_server_account_set_password(),
1989 modest_server_account_get_hostname() functions so we do not need to
1990 use the conf API directly.
1992 * src/maemo/modest-main-window.c: (connect_signals):
1993 Actually connect ot the ModestAccountStore::request-password signal,
1994 so that we show the dialog when the password is requested by Tinymail,
1995 for isntance if it is empty.
1997 * src/modest-marshal.list:
1998 * src/modest-tny-account-store.c:
1999 (modest_tny_account_store_class_init), (get_password),
2000 (modest_tny_account_store_alert):
2001 * src/modest-tny-account-store.h:
2002 * src/modest-ui-actions.h:
2003 * src/modest-ui-actions.c:
2004 (modest_ui_actions_on_password_requested):
2005 Change the signal parameters, so it is obvious that we are providing
2006 the non human-readable server name, and receiving both the username
2007 and password, though changing of the username is not yet implemented.
2008 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2009 for the GNOME version.
2011 This should fix the projects.maemo.org bug NB#56209, though it does not
2012 work on Bora, because the gconf_client_get() for the password fails
2013 immediately after we save it with gconf_client_set().
2015 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2018 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2019 caused an undefined symbol error:
2020 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2022 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2024 * src/modest-tny-account-store.c:
2025 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2026 using a GError instead of a string message, so we can translate it in
2029 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2031 * src/maemo/modest-address-book.c:
2032 (modest_address_book_check_names):
2033 * src/maemo/modest-msg-view-window.c:
2034 (modest_msg_view_window_clipboard_owner_change):
2035 * src/modest-init.c: (modest_init_init_ui):
2036 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2037 (update_folders_cb), (modest_mail_operation_update_account):
2038 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2039 (modest_ui_actions_on_msg_attachment_clicked),
2040 (modest_ui_actions_on_msg_recpt_activated):
2041 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2042 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2043 (modest_msg_view_search_next):
2044 * src/widgets/modest-recpt-editor.c:
2045 (modest_recpt_editor_on_button_release_event),
2046 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2047 g_message(). At this point we should only be seeing interesting errors on
2048 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2050 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2052 (modest_wizard_dialog_force_title_update):
2053 * src/maemo/easysetup/modest-wizard-dialog.h:
2054 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2055 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2056 can update the title when appropriate. Otherwise the title is wrong if the
2057 pages are added after adding the notebook to the dialog.
2058 This must be a problem in HildonWizardDialog too.
2059 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2061 * src/maemo/easysetup/modest-easysetup-wizard.c:
2062 (create_subsequent_customsetup_pages),
2063 (create_subsequent_easysetup_pages):
2064 Call modest_wizard_dialog_force_title_update() so that the title is
2065 correct even with GTK+ < 2.10.
2066 This fixes projects.maemo.org bug NB#56145 .
2068 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/modest-platform.c:
2071 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2072 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2075 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2077 * src/widgets/modest-window.h:
2078 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2079 and modest_window_save_state(), which invokes it.
2081 * src/widgets/modest-window-mgr.h:
2082 * src/widgets/modest-window-mgr.c:
2083 Added modest_window_mgr_save_state_for_all_windows(), which calls
2084 the save_state vfunc on all registered windows, if implemented.
2086 * src/gnome/modest-msg-edit-window.c:
2087 * src/gnome/modest-msg-view-window.c:
2088 * src/maemo/modest-msg-edit-window.c:
2089 * src/maemo/modest-msg-view-window.c:
2090 * src/maemo/modest-main-window.c:
2091 Specify the existing save_settings functions as implementations of
2092 ModestWindow::save_state_func().
2094 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2095 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2096 enabling hibernation, for instance.
2098 We may need to do the same thing for restoring settings.
2101 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2103 * src/widgets/modest-window-mgr.c:
2104 * src/widgets/modest-window-mgr.h:
2105 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2106 modest_window_mgr_get_hibernation_is_prevented().
2108 * src/maemo/modest-main-window.c:
2109 (on_hildon_program_is_topmost_notify): Prevent hibernation
2110 (possible when the application goes to the background in the WM),
2111 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2113 * src/maemo/easysetup/modest-easysetup-wizard.c:
2114 (modest_easysetup_wizard_dialog_init):
2115 * src/maemo/modest-account-settings-dialog.c:
2116 (modest_account_settings_dialog_init):
2117 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2118 (modest_connection_specific_smtp_edit_window_init):
2119 * src/maemo/modest-connection-specific-smtp-window.c:
2120 (modest_connection_specific_smtp_window_init):
2121 * src/maemo/modest-signature-editor-dialog.c:
2122 (modest_signature_editor_dialog_init):
2123 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2124 prevent hibernation while any of these account settings dialogs are open.
2126 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/Makefile.am:
2129 * src/maemo/modest-osso-state-saving.c:
2130 * src/maemo/modest-osso-state-saving.h: Added
2131 modest_osso_load_state() and modest_osso_save_state() though they do
2132 nothing now. They should iterate through all the open windows and load/save
2134 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2135 save state when closing.
2137 * src/maemo/modest-main-window.c:
2138 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2139 Add a notification handler for the HildonProgram::is-topmost property,
2140 so we can allow hibernation when the application goes into the background.
2141 But we still need to detect when the accounts setup windows are open so
2142 we can stop hibernation when they are open.
2143 To do this, I also added the main window the HildonProgram. This might have
2144 other side-effects/benefits, and should maybe be done for other windows.
2146 * src/maemo/modest-osso-autosave-callbacks.h:
2147 * src/maemo/modest-osso-autosave-callbacks.c:
2148 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2149 though it does not do anything yet, and we might never need this to do
2150 anything. For instance, we already save drafts.
2152 * src/maemo/modest-platform.c: (modest_platform_init):
2153 Specify the libosso auto-save callback.
2155 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-platform.c:
2158 (modest_platform_set_update_interval):
2159 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2160 aparently stays valid between application instances, so we can use this
2161 to remove and reset it later. According to a maemo-developers email from
2164 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2166 * configure.ac: Depend on libalarm for Maemo.
2168 * src/dbus_api/modest-dbus-api.h:
2169 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2170 (on_send_receive), (modest_dbus_req_handler):
2171 Handle a SEND_RECEIVE D-Bus method.
2173 * libmodest-dbus-client/libmodest-dbus-client.c:
2174 (libmodest_dbus_client_send_and_receive):
2175 * libmodest-dbus-client/libmodest-dbus-client.h:
2176 Add C convenience functions for calling the new D-Bus method.
2178 * src/modest-platform.h:
2179 * src/gnome/modest-platform.c:
2180 * src/maemo/modest-platform.c:
2181 Added modest_platform_set_update_interval(), which uses the
2182 alarmd API on Maemo.
2183 (modest_platform_init),
2184 Call modest_platform_set_update_interval(), using a hard-coded
2185 interval for now (until the global settings dialog is implemented),
2186 though I am not sure that this makes sense yet.
2188 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2190 * src/dbus_api/modest-dbus-callbacks.c:
2191 (modest_osso_cb_hw_state_handler):
2192 * src/dbus_api/modest-dbus-callbacks.h:
2193 * src/maemo/modest-platform.c: (modest_platform_init):
2194 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2195 in case this has some effect on the ability for Maemo to ping the
2198 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2201 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2202 warning. It is probably a logic error, but I need to fix the build.
2204 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2206 * src/modest-account-mgr.h:
2207 * src/modest-account-mgr.c:
2208 (modest_account_mgr_account_names): Add a gboolean enabled_only
2209 parameter, so we can get lists of onlt the enabled accounts.
2211 (modest_account_mgr_add_account),,
2212 (modest_account_mgr_account_with_display_name_exists):
2213 * src/maemo/modest-msg-edit-window.c: (get_transports):
2214 * src/modest-account-mgr-helpers.c:
2215 (modest_account_mgr_set_first_account_as_default):
2216 * src/modest-init.c: (init_default_account_maybe):
2217 * src/modest-tny-account-store.c: (get_accounts):
2218 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2219 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2220 * tests/check_account-mgr.c: (START_TEST):
2221 Provide the extra parameter, as appropriate.
2223 * src/widgets/modest-account-view.c: (update_account_view):
2224 Do not show disabled accounts (meaning that there is no way to
2225 enable/disable accounts in the UI (the feature is not in our UI
2226 specification), so we can use this internally only to mark unfinished
2227 or temporary account data.
2229 * src/maemo/easysetup/modest-easysetup-wizard.c:
2230 (create_account): Add boolean enable parameter, so we can specify FALSE
2231 to create the temporary account.
2232 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2233 (on_before_next): When finishing, when there is a temporary account, just
2235 Also, use a timeout to delay the showing of the dialog until gconf is likely
2236 to return correct information, due to a maemo gconf bug that is fixed in
2237 osso 1.1, but not yet in Bora.
2238 However, the dialog stays on screen after it is destroyed.
2240 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2241 for invalid data when cancelling. Use a hildon note instead of a dialog
2242 to complain about invalid data. Do not show the account-saved note if the
2243 account is disabled (a temporary account that will not really be saved for use
2246 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2248 * src/modest-account-mgr-helpers.h:
2249 * src/modest-account-mgr-helpers.c:
2250 Added modest_account_mgr_unset_default_account(),
2251 Added modest_account_mgr_set_first_account_as_default().
2253 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2254 If it was the default account, unset the default account name.
2256 * src/maemo/modest-account-view-window.c:
2257 (on_delete_button_clicked): If it was the default account,
2258 set the first remaining account as the default instead.
2260 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2261 a NULL account or a NULL default account, to prevent a crash. This should
2262 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2265 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2267 * src/widgets/modest-recpt-editor.c:
2268 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2269 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2270 TODO comment for this. This fixes the build.
2272 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2273 be the best place for it. This will in future update all auto-update accounts,
2274 rather than just the current/default account, when that gconf key exists.
2275 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2276 if there are no accounts, before calling do_send_receive().
2277 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2279 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2280 * src/maemo/modest-main-window-ui.h:
2281 * src/maemo/modest-main-window.c: (on_connection_changed),
2282 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2283 directly, becaue the signal handler does more.
2285 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-account-mgr-helpers.c:
2288 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2289 for the case that the account does not exist.
2291 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2292 (equivalent to the modest account name) rather than the tinymail account name
2293 (equivalent to the modest account title - human readable) to get the account data.
2294 Check for null account data to prevent the crash, and add a TODO comment saying that
2295 this needs fixing because it is using the server account name instead of the account name.
2297 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2299 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2300 * src/maemo/modest-account-settings-dialog.c: (show_error),
2302 Use hildon_note_new_information() for informative and error messages,
2303 which seems to be expected for Maemo applications (no documentation that I know of
2304 says this). I am surprised that there is no distinction between info and error
2307 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2309 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2310 it is easy to find where this is used.
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 (create_page_welcome), (create_page_account_details),
2314 (create_page_user_details), (create_page_complete_easysetup),
2315 (create_page_custom_incoming), (create_page_custom_outgoing),
2316 (create_page_complete_custom):
2317 * src/maemo/modest-account-settings-dialog.c:
2318 (create_page_account_details), (create_page_user_details),
2319 (create_page_incoming), (create_page_outgoing):
2320 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2322 (modest_connection_specific_smtp_edit_window_init):
2323 * src/maemo/modest-connection-specific-smtp-window.c:
2324 (modest_connection_specific_smtp_window_init):
2325 * src/maemo/modest-signature-editor-dialog.c:
2326 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2327 and scrolling policy as per the Email Application Layout Guide, if I have
2330 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2332 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2333 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2334 which were empty, because these vfuncs have been removed from TnyAccountStore.
2335 This fixes the build.
2337 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2339 * src/maemo/modest-main-window.c:
2340 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2341 showing/hiding it. Added TODO because it probably should not be NULL.
2342 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2343 because unnecessary g_warnings() make degugging difficult.
2345 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/modest-msg-edit-window.c:
2348 (modest_msg_edit_window_select_color),
2349 (modest_msg_edit_window_select_background_color): 2 const corrections and
2350 moving 2 #endifs before closing brackets, to fix the build.
2352 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2354 * src/maemo/easysetup/modest-easysetup-wizard.h:
2355 * src/maemo/easysetup/modest-easysetup-wizard.c:
2356 (modest_easysetup_wizard_dialog_finalize),
2357 (on_button_edit_advanced_settings), (create_page_complete_custom),
2358 (on_response), (create_account):
2359 Implement the Advanced Settings edit button, by saving the account information,
2360 for the Advanded Settings dialog to use directly from gconf, and removing it
2361 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2362 Bug #5533 in the projects.maemo.org bugzilla.
2364 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2366 * src/maemo/modest-msg-view-window.c:
2367 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2368 when opening a message window.
2370 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2372 * src/maemo/easysetup/modest-easysetup-wizard.c:
2373 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2376 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2377 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2378 gconf settings. I probably added more checks than necessary, but that is safer.
2380 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2381 variable to fix the build, but this seems to be used when it is still NULL.
2383 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2385 * src/modest-platform.h:
2386 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2387 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2388 * src/modest-main.c: Implement this function so we can avoid using
2389 maemo-specific API from cross-platform code.
2391 * src/modest-tny-account-store.c:
2392 (get_smtp_specific_transport_account_for_open_connection):
2393 * src/modest-ui-actions.c: (check_for_connection),
2394 (modest_ui_actions_on_item_not_found):
2395 Use modest_platform_connect_and_wait() and put #idefs around other
2396 maemo-specific code, because only maemo currently has a way to
2397 identify connection names.
2399 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2401 * src/modest-tny-account-store.h:
2402 * src/modest-tny-account-store.c:
2403 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2404 the connection-specific SMTP server settings in the configuration.
2406 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2408 * src/maemo/modest-main-window.c: (on_connection_changed),
2410 * src/modest-main.c: (main), (start_ui), (send_mail):
2411 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2412 that is what is intended.
2414 * src/modest-ui-actions.c: (action_send), (action_receive),
2415 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2416 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2417 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2418 SMTP server is used when it is specified.
2420 (modest_ui_actions_on_send_receive):
2421 Check that a connection is open before proceeding.
2422 Receive and then send, instead of vice-versa, as per the specification.
2424 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2426 * src/modest-mail-operation.c:
2427 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2428 though I guess it should be something other than NULL.
2430 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/easysetup/modest-easysetup-wizard.c:
2433 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2434 combo twice, to avoid an g_warning and to make it visible again.
2435 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2436 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2437 (already intended) dereference when detaching, because we then recreate the menu.
2438 But I am not sure why the warning was happening, and it is possible that this is a memory
2441 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2443 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2444 and uri_parse_mailto() utility functions.
2445 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2447 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2449 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2451 * src/dbus_api/modest-dbus-api.h:
2452 * src/dbus_api/modest-dbus-callbacks.c:
2453 Use an idle callback to execute the modest code in the application's own thread.
2454 Remove the helloworld example method.
2455 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2456 parsed, and the open-message method is not implemented because this is not yet implemented in
2458 * libmodest-dbus-client/libmodest-dbus-client.c:
2459 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2460 (libmodest_dbus_client_open_message):
2461 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2463 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2464 body without crashing.
2466 * tests/dbus_api/Makefile.am:
2467 * tests/dbus_api/test_mail_to.c:
2468 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2470 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2472 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2473 Added file to fix the build. Sorry.
2475 * src/dbus_api/Makefile.am:
2476 * src/dbus_api/modest-dbus-api.h:
2477 * src/dbus_api/modest-dbus-callbacks.h:
2478 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2479 (modest_dbus_req_handler):
2480 Put constants in a separate header so it can be reused by the
2481 client library, without duplication
2483 * libmodest-dbus-client/Makefile.am:
2484 * libmodest-dbus-client/libmodest-dbus-client.c:
2485 (libmodest_dbus_client_call_helloworld),
2486 (libmodfest_dbus_client_send_mail),
2487 (libmodfest_dbus_client_mailto),
2488 (libmodfest_dbus_client_open_message):
2489 * libmodest-dbus-client/libmodest-dbus-client.h:
2490 (Partly) Implement a send_mail D-Bus method.
2492 * tests/dbus_api/Makefile.am:
2493 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2494 the send_email D-Bus method.
2496 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2500 * libmodest-dbus-client/Makefile.am:
2501 * libmodest-dbus-client/libmodest-dbus-client.c:
2502 * libmodest-dbus-client/libmodest-dbus-client.h:
2503 * tests/dbus_api/Makefile.am:
2504 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2505 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2507 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/easysetup/modest-easysetup-wizard.c:
2510 (create_page_account_details):
2511 * src/maemo/modest-account-settings-dialog.c:
2512 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2513 widgets, because this might not be the default in future versions of the Maemo GTK+.
2514 However, I can not not get capitalization to work even in a simple test case.
2516 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/easysetup/modest-easysetup-wizard.c:
2519 (create_page_custom_incoming), (create_page_custom_outgoing):
2520 * src/maemo/modest-account-settings-dialog.c:
2521 (create_page_account_details), (create_page_incoming),
2522 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2523 instead of using gtk_check_button_with_label(), so they are aligned like the other
2524 widgets, as per the UI spec.
2526 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/easysetup/modest-easysetup-wizard.c:
2529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2530 * src/widgets/modest-validating-entry.c:
2531 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2532 Modest prefix instead of an EasySetup prefix.
2534 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2536 * src/widgets/modest-validating-entry.h:
2537 * src/widgets/modest-validating-entry.c: (on_insert_text),
2538 Added easysetup_validating_entry_set_max_func(), used to set a callback
2539 to call when the max number of characters is reached. GtkEntry has a max-length
2540 already but is silent about it.
2542 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2543 (create_page_account_details), (create_page_user_details),
2545 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2546 (create_page_account_details), (create_page_user_details),
2547 (create_page_outgoing):
2548 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2549 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2550 the UI spec, when the user tries to enter more than the max number of characters.
2552 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2554 * src/maemo/easysetup/modest-easysetup-wizard.c:
2555 (create_page_user_details), (create_page_custom_incoming),
2556 (create_page_custom_outgoing):
2557 * src/maemo/modest-account-settings-dialog.c:
2558 (create_page_user_details), (create_page_incoming),
2559 (create_page_outgoing):
2560 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2561 (modest_connection_specific_smtp_edit_window_init):
2562 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2563 not appropriate. Bad Maemo-specific defaults!.
2565 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2568 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2569 (modest_signature_editor_dialog_set_settings):
2570 Disable the label and textview when the checkbox is disabled, and use the
2571 specified (UI spec) default signature text.
2573 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2576 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2578 * src/modest-defs.h:
2579 * src/modest-account-mgr-helpers.h:
2580 * src/modest-account-mgr-helpers.c:
2581 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2583 * src/maemo/Makefile.am:
2584 * src/maemo/modest-signature-editor-dialog.c:
2585 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2588 * src/maemo/modest-account-settings-dialog.h:
2589 * src/maemo/modest-account-settings-dialog.c:
2590 (modest_account_settings_dialog_finalize), (on_button_signature),
2591 (save_configuration): Use the new dialog when the Edit button is pressed, and
2592 save the changes if necessary, as per the UI spec.
2594 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2596 * src/maemo/Makefile.am:
2597 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2598 based on maemo-develoers email from Dirk.
2600 * src/maemo/easysetup/modest-easysetup-wizard.c:
2601 (create_page_welcome), (create_page_account_details),
2602 (create_page_user_details), (create_page_complete_easysetup),
2603 (create_page_custom_incoming), (create_page_custom_outgoing),
2604 (create_page_complete_custom),
2605 (modest_easysetup_wizard_dialog_init):
2606 * src/maemo/modest-account-settings-dialog.c:
2607 (create_page_account_details), (create_page_user_details),
2608 (create_page_incoming), (create_page_outgoing),
2609 (modest_account_settings_dialog_init):
2610 * src/maemo/modest-connection-specific-smtp-window.c:
2611 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2613 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2615 * src/maemo/easysetup/modest-easysetup-wizard.c:
2616 (create_page_account_details), (create_page_custom_outgoing),
2617 (create_page_complete_custom):
2618 * src/maemo/modest-account-settings-dialog.c:
2619 (create_page_user_details), (create_page_incoming),
2620 (create_page_outgoing):
2621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2622 (modest_connection_specific_smtp_edit_window_init):
2623 Use the correct (UI spec) port min/max, and use horizontal separators,
2626 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2628 * src/maemo/easysetup/modest-easysetup-wizard.c:
2629 (set_default_custom_servernames):
2630 * src/maemo/modest-account-settings-dialog.c:
2631 (create_page_incoming), (on_combo_outgoing_security_changed),
2632 (on_combo_incoming_security_changed), (create_page_outgoing),
2633 (modest_account_settings_dialog_set_account_name),
2634 (save_configuration):
2635 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2636 (on_combo_security_changed),
2637 (modest_connection_specific_smtp_edit_window_init),
2638 (modest_connection_specific_smtp_edit_window_set_connection),
2639 (modest_connection_specific_smtp_edit_window_get_settings):
2640 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2643 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2646 * src/maemo/easysetup/modest-easysetup-wizard.c:
2647 (create_page_custom_outgoing), (create_page_complete_custom):
2648 * src/maemo/modest-account-settings-dialog.c:
2649 (create_page_user_details), (create_page_outgoing):
2650 * src/maemo/modest-account-view-window.c: (button_box_new):
2651 Use changed logical IDs as per the most recent UI spec:
2652 mcen_bd_emailsetup_edit -> mcen_bd_edit
2653 mcen_bd_emailsetup_delete -> mcen_bd_delete
2654 mcen_bd_emailsetup_close -> mcen_bd_close
2656 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2660 * src/dbus_api/Makefile.am:
2661 * src/dbus_api/modest-dbus-callbacks.c:
2662 * src/dbus_api/modest-dbus-callbacks.h:
2663 * src/maemo/modest-platform.c: (modest_platform_init):
2664 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2666 * tests/Makefile.am:
2667 * tests/dbus_api/Makefile.am:
2668 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2670 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2672 * src/maemo/modest-account-settings-dialog.c:
2673 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2674 Removed unnecessary includes.
2676 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2678 * src/maemo/easysetup/modest-easysetup-wizard.c:
2679 * src/maemo/modest-account-settings-dialog.c:
2680 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2681 * src/widgets/Makefile.am:
2682 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2683 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2684 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2685 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2686 * src/widgets/modest-secureauth-combo-box.c:
2687 * src/widgets/modest-secureauth-combo-box.h:
2688 * src/widgets/modest-serversecurity-combo-box.c:
2689 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2690 made the GObject names more consistent with the rest of the Modest code.
2692 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2694 * src/maemo/easysetup/Makefile.am:
2695 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2696 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2697 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2698 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2699 * src/maemo/easysetup/modest-easysetup-wizard.c:
2700 * src/maemo/easysetup/modest-validating-entry.c:
2701 * src/maemo/easysetup/modest-validating-entry.h:
2702 * src/maemo/modest-account-settings-dialog.c:
2703 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2704 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2705 widgets/ because they are used outside of easysetup too. After checking in,
2706 svn will allow me to rename them too.
2708 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2710 * src/gnome/modest-msg-edit-window.c:
2711 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2712 linker error, to fix the build on the GNOME platform.
2713 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2714 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2715 ifdefed out to avoid a warning.
2717 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2719 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2720 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2721 some alternative for GTK+ 2.6.
2723 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2725 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2727 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2728 specified for EmailAccountsDialog in UI spec.
2730 * src/maemo/easysetup/modest-easysetup-wizard.c:
2731 * src/maemo/easysetup/modest-easysetup-wizard.h:
2732 * src/maemo/modest-account-settings-dialog.c:
2733 * src/maemo/modest-account-settings-dialog.h:
2734 Reuse a member window widget for the connection-specific SMTP server accounts,
2735 so we can tell it to create/save the accounts only if we actually save changes.
2737 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2738 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2739 (modest_connection_specific_smtp_edit_window_get_settings):
2740 Return a struct instance for temporarily remembering the entered data.
2742 * src/maemo/modest-connection-specific-smtp-window.h:
2743 * src/maemo/modest-connection-specific-smtp-window.c:
2744 (modest_connection_specific_smtp_window_finalize),
2745 (modest_connection_specific_smtp_window_fill_with_connections),
2747 (modest_connection_specific_smtp_window_save_server_accounts),
2748 (update_model_server_names): Do not actually save data until asked,
2749 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2751 (on_selection_changed),
2752 (modest_connection_specific_smtp_window_init): Disable the edit
2753 button when nothing is selected.
2755 * src/modest-account-mgr-helpers.c:
2756 * src/modest-account-mgr-helpers.h:
2757 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2760 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2762 * src/modest-account-mgr-helpers.h:
2763 * src/modest-account-mgr-helpers.c:
2764 (modest_account_mgr_get_unused_account_name),
2765 (modest_account_mgr_get_unused_account_display_name): Added these
2766 utility functions, to avoid code duplication.
2768 * src/maemo/easysetup/modest-easysetup-wizard.c:
2769 (create_page_account_details), (create_account):
2770 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2771 (on_combo_security_changed),
2772 (modest_connection_specific_smtp_edit_window_init),
2773 (modest_connection_specific_smtp_edit_window_save_settings):
2774 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2775 * src/maemo/modest-connection-specific-smtp-window.c:
2776 (modest_connection_specific_smtp_window_finalize),
2777 (modest_connection_specific_smtp_window_fill_with_connections),
2778 (on_button_edit), (modest_connection_specific_smtp_window_init):
2779 * src/maemo/modest-connection-specific-smtp-window.h:
2780 Implementing saving of connection-specific server accounts.
2782 But I need to refactor this so we can save the data for each
2783 possible connection-specific account and only actually create the server accounts
2784 when the easysetup finished, or the OK button is pressed on the account settings
2787 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2789 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2790 (on_combo_security_changed):
2791 (modest_connection_specific_smtp_edit_window_init):
2792 Auto-fill the port number as in the account settings.
2794 (modest_connection_specific_smtp_edit_window_set_connection):
2795 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2796 * src/maemo/modest-connection-specific-smtp-window.c:
2797 (fill_with_connections), (on_button_edit),
2798 (modest_connection_specific_smtp_window_init):
2799 Turn the edit window into a dialog to simplify the code, and
2800 set a WM hint as in a GtkDialog, because only a popup can be on top of
2801 another window in Maemo, and popups usually have no WM decoration.
2803 * src/modest-defs.h:
2804 * src/modest-account-mgr-helpers.c:
2805 (modest_account_mgr_set_connection_specific_smtp),
2806 (modest_account_mgr_remove_connection_specific_smtp),
2807 (modest_account_mgr_get_connection_specific_smtp):
2808 * src/modest-account-mgr-helpers.h: Some functions to write the
2809 connection-specific SMTP server information. Not yet used.
2812 * src/widgets/modest-folder-view.c: (text_cell_data):
2813 Fix a warning about an uninitialized variable.
2814 (on_configuration_key_changed): Put an #ifdef around the use
2815 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2817 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2819 * src/maemo/modest-account-settings-dialog.h:
2820 * src/maemo/modest-account-settings-dialog.c:
2821 Added connect_for_modified() utility function to mark the new modified boolean.
2823 (create_page_account_details), (create_page_user_details),
2824 (create_page_incoming), (create_page_outgoing), (on_response),
2825 (modest_account_settings_dialog_init),
2826 (modest_account_settings_dialog_set_account_name):
2827 Only warn about unsaved changes when there are actually unsaved changes.
2829 * src/modest-account-mgr-helpers.c:
2830 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2831 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2832 to get the data from there in future.
2834 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2836 * src/modest-defs.h:
2838 * src/modest-account-mgr-helpers.h:
2839 * src/modest-account-mgr-helpers.c:
2840 Store the security account setting in a single conf key instead of using
2841 the options list, so that the list is left for just the to-be-removed camel hack,
2842 and because gconf_client_set_list() is failing for some reason.
2844 * src/modest-account-mgr.c:
2845 (modest_account_mgr_add_server_account):
2846 * src/maemo/modest-account-settings-dialog.c:
2847 (modest_account_settings_dialog_set_account_name),
2848 (save_configuration): Use the renamed functions.
2851 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2853 * src/widgets/Makefile.am:
2854 * src/widgets/modest-limit-retrieve-combo-box.c:
2855 * src/widgets/modest-limit-retrieve-combo-box.h:
2856 * src/widgets/modest-retrieve-combo-box.c:
2857 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2858 the account settings dialog.
2860 * src/modest-defs.h:
2861 * src/modest-account-mgr-helpers.h:
2862 * src/modest-account-mgr-helpers.c:
2863 (modest_server_account_get_option_secure_auth),
2864 (modest_server_account_set_option_secure_auth):
2865 * src/modest-account-mgr.c:
2866 (modest_account_mgr_add_server_account):
2867 Use the existing AUTH_MECH conf key for the secure-auth setting,
2868 instead of putting it in the list options, because this was actually used already.
2870 * src/maemo/modest-account-settings-dialog.c:
2871 (create_page_account_details),
2872 (modest_account_settings_dialog_set_account_name),
2873 (save_configuration):
2874 * src/maemo/modest-account-settings-dialog.h:
2875 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2876 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2878 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2881 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2882 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2884 * src/modest-defs.h:
2885 * src/maemo/modest-account-settings-dialog.c:
2886 (create_page_incoming), (on_combo_outgoing_security_changed),
2887 (on_combo_incoming_security_changed), (create_page_outgoing),
2888 (modest_account_settings_dialog_set_account_name),
2889 (save_configuration): Load/Save the port number, and change it when the
2890 security combo changes, to suitable defaults.
2892 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2894 * src/modest-account-mgr.c:
2895 (modest_account_mgr_add_server_account): Set the security and secure-auth
2896 options, and add a comment saying that the other camel-specific options should be
2899 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2901 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2903 * src/modest-tny-account-store.c: (account_list_free),
2904 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2905 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2908 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2910 * src/modest-protocol-info.c:
2911 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2912 is required by our UI spec. Maybe something in our implementation will use this eventually.
2913 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2914 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2915 instead of the previous 0 placeholder.
2917 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2918 secure-auth settings.
2919 * src/modest-account-mgr-helpers.h:
2920 * src/modest-account-mgr-helpers.c:
2921 (modest_server_account_data_get_option_secure_auth),
2922 (modest_server_account_set_option_secure_auth),
2923 (modest_server_account_data_get_option_security),
2924 (modest_server_account_set_option_security): Added this API for getting and setting the security
2925 and secure-auth settings.
2927 * src/maemo/modest-account-settings-dialog.h:
2928 * src/maemo/modest-account-settings-dialog.c:
2929 (modest_account_settings_dialog_finalize), (check_data),
2930 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2931 about changing titles.
2932 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2933 (save_configuration): Save the security and secure-auth settings.
2935 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2936 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2938 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2940 * src/modest-defs.h:
2941 * src/modest-account-mgr.c:
2942 (modest_account_mgr_add_server_account):
2943 Added and used defines for the options key and value pair strings,
2944 that are used so far, though they do not seem to correspond to anything in our
2945 UI specs or ModestProtocol enum.
2947 * src/modest-account-mgr-helpers.h:
2948 * src/modest-account-mgr-helpers.c:
2949 (compare_option_strings_for_name),
2950 (modest_server_account_data_get_option_value),
2951 (modest_server_account_data_get_option_bool),
2952 (modest_account_mgr_get_server_account_option):
2953 Added helper functions for parsing the options GSList.
2955 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2957 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2958 display name is based on the supplied account name.
2959 * src/modest-account-mgr.c:
2960 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2961 with an inefficient, but good-enough, implementation.
2963 * src/maemo/easysetup/modest-easysetup-wizard.c:
2964 (create_page_account_details), (on_before_next), (create_account):
2965 Check for existing display names rather than (non-user-visible) account names, and just
2966 create and set a unique account name at the end.
2968 * src/maemo/modest-account-settings-dialog.c:
2969 (modest_account_settings_dialog_init),
2970 (modest_account_settings_dialog_set_account_name),
2971 (create_page_incoming): Show the display name, instead of the account name.
2972 (on_response): Do some (not all) extra checks, as in the UI spec.
2973 (save_configuration): Save the display name if it was changed.
2975 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2977 * po/en_GB.po: Added needed logical ID and translation.
2978 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2979 (init_view): Made the is-default column clicking work.
2981 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2984 * src/maemo/easysetup/Makefile.am:
2985 * src/maemo/easysetup/modest-easysetup-wizard.c:
2986 (modest_easysetup_wizard_dialog_init):
2987 * src/maemo/easysetup/provider-data-test.keyfile:
2988 * src/maemo/easysetup/provider-data.keyfile:
2989 Moved the provider data file to the new modest-providers-data package and used it from there.
2991 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2993 * src/modest-local-folder-info.c:
2994 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2995 N_() was already used on the static strings, but this just marks it for translation without
2996 using the translation.
2998 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3000 * src/maemo/modest-account-settings-dialog.c:
3001 (create_page_incoming),
3002 (modest_account_settings_dialog_set_account_name):
3003 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3004 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3005 I will do this if nobody else gets there first.
3007 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3009 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3010 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3011 save the security stuff.
3013 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3015 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3016 Set the email address and user fullname, which I now see must be
3019 * src/maemo/modest-account-settings-dialog.h:
3020 * src/maemo/modest-account-settings-dialog.c:
3022 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3023 leave-on-server and authentication.
3024 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3027 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3030 * src/maemo/modest-account-settings-dialog.c:
3031 * src/maemo/modest-account-settings-dialog.h:
3032 Most (but not all) of the widgets are now present as specified by the UI spec.
3033 No changes are yet saved, and some details are not properly shown yet.
3035 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3037 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3039 * src/maemo/Makefile.am:
3040 * src/maemo/modest-account-settings-dialog.c:
3041 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3042 an existing account. Doesn't do much yet.
3044 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3045 Open the accounts settings dialog when Edit is clicked.
3047 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3049 * src/maemo/easysetup/Makefile.am:
3050 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3052 * src/maemo/easysetup/modest-easysetup-wizard.c:
3053 (modest_easysetup_wizard_dialog_init):
3054 Try to get the source directory from the build system,
3055 instead of hard-coding "./" into the source code, when opening our local
3056 copies of the configuration files.
3057 But this still fails when opening the wizard from the Accounts window,
3058 maybe because the working directory seems to change at runtime.
3059 So the wizard will fail the second time unless you copy the files into their
3060 proper locations - see the stdout warnings for the paths.
3062 (create_page_account_details),(on_before_next):
3063 Check for existing non-server accounts instead of server accounts,
3064 so the default account name is useful again, and to prevent trying to
3067 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3068 Show the wizard when New is clicked.
3070 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3071 (init_view): Show the column headers, and show the columns that are
3072 specified in the UI specs. However, something in Maemo's GTK+ prevents
3073 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3074 change the default account. This is despite unsetting the special properties.
3076 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3078 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3079 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3080 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3081 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3082 to make that clearer.
3083 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3085 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3087 * src/maemo/modest-account-view-window.c:
3088 (modest_account_view_window_init),
3089 (modest_account_view_window_new):
3090 Use the same buttons as specified in the
3091 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3092 the existing widgets, which never had a chance of working.
3093 Put the ModestAccountView treeview in a scrolled window.
3094 Do not repeat the initialization in both _init() and _new().
3096 * src/widgets/modest-account-view.c: (update_account_view):
3097 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3098 this widget and window shows no accounts.
3100 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3102 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/easysetup/modest-easysetup-wizard.c:
3105 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3106 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3107 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3110 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3111 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3112 accounts exist yet, as in the UI spec.
3114 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3116 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3118 * src/maemo/Makefile.am:
3119 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3120 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3121 New window for editing connection-specific smtp details.
3122 Not fully implemented.
3124 * src/maemo/modest-connection-specific-smtp-window.c:
3125 (modest_connection_specific_smtp_window_finalize) :
3126 unref the tree model.
3127 (on_button_edit): Show the edit window.
3129 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3131 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3134 * src/maemo/Makefile.am:
3135 * src/maemo/modest-connection-specific-smtp-window.c:
3136 * src/maemo/modest-connection-specific-smtp-window.h:
3137 New window for showing the list of connections, for connection-specific
3138 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3139 * src/maemo/easysetup/modest-easysetup-wizard.c:
3140 (create_page_custom_outgoing): Show the new window when the button is clicked.
3142 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3144 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3145 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3146 * src/maemo/modest-msg-edit-window.c:
3147 (modest_msg_edit_window_insert_image):
3148 * src/modest-conf.c: (modest_conf_key_escape):
3149 * src/modest-mail-operation.c:
3150 (modest_mail_operation_send_new_mail):
3151 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3152 (modest_ui_actions_on_new_account):
3153 * src/widgets/modest-attachment-view.c: (update_filename_request):
3154 * src/widgets/modest-mail-header-view.c:
3155 Corrected warnings that were breaking the build, by commenting out unused variables,
3156 and a function, and by including a header.
3158 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3160 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3161 so we can #ifdef around platform-specific code when necessary.
3162 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3163 to allow this to build for the GNOME platform too.
3165 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3167 * src/maemo/easysetup/modest-easysetup-wizard.c:
3168 Added util_increment_name() and used it in create_page_account_details()
3169 to make sure that the default account name is always a new name.
3171 (modest_easysetup_wizard_dialog_init),
3172 (set_default_custom_servernames): Some minor memory management fixes.
3174 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3178 * src/modest-runtime.c: (init_i18n): Restored the translation
3179 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3180 are defined in config.h, and the translations are installed.
3182 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3183 is defined for translation.
3185 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3187 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3189 * src/maemo/easysetup/modest-easysetup-wizard.c:
3190 (modest_easysetup_wizard_dialog_init):
3191 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3192 Use realistic paths (though they should use $prefix generically) to the
3193 mcc_mapping and provider-data.keyfile files which might work when they
3194 are installed by the future version of the operator-wizard package,
3195 and then fallback to paths in our source code, with an explanatory
3198 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3202 * src/maemo/Makefile.am:
3203 * src/maemo/easysetup/: Added files from the previously-exernal
3204 osso-modest-easysetup.
3205 * src/maemo/modest-main-window-ui.h:
3206 * src/modest-ui-actions.c:
3207 * src/modest-ui-actions.h:
3208 Added modest_ui_actions_on_new_account() as a signal handler for the
3209 New Account menu item. It shows the easysetup wizard.
3210 * po/en_GB.po: Added additional needed logical IDs and translations.