1 2007-06-18 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
4 Fix the build, but leave the function broken on Bora, because
5 hildon_uri_action_get_service() does not exist.
6 osso_uri_action_get_service() does not exist either, it seems.
8 2007-06-18 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-account.c:
11 (modest_tny_account_new_from_server_account):
12 Uncommented the url debug output again, because it is useful for
13 debugging, as I said in the comment.
15 2007-06-18 Murray Cumming <murrayc@murrayc.com>
17 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
19 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
20 for Mameo Bora, to fix the build.
22 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
25 Fixed build with hildon < 0.99
27 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
28 Check if the selected account is busy instead of checking all accounts
30 * src/modest-account-mgr-priv.h:
31 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
32 (modest_account_mgr_init), (compare_account_name),
33 (modest_account_mgr_set_account_busy),
34 (modest_account_mgr_account_is_busy):
35 * src/modest-account-mgr.h:
36 Added busy information to the account manager. It possible to
37 set an account to busy or not busy now.
39 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
40 (modest_mail_operation_update_account),
41 (modest_mail_operation_notify_end):
42 Set the account to busy/not busy depending on the operation state.
44 * src/widgets/modest-account-view.c:
45 (modest_account_view_finalize), (get_last_updated_string),
46 (update_account_view), (on_account_busy_changed), (init_view):
47 Show string "Refreshing..." if the account is currently busy.
49 All this fixes projects.maemo.org bug NB#59711
51 2007-06-14 Armin Burgmeier <armin@openismus.com>
53 * src/widgets/modest-attachments-view.h:
54 * src/widgets/modest-attachments-view.c: Added
55 modest_attachments_view_has_attachments() and fixed coordinate
56 transformation in get_att_view_at_coords(). This fixes attachment
59 * src/widgets/modest-msg-view.c: Make use of
60 modest_attachments_view_has_attachments() to decide whether to show
61 attachments in the header.
63 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
65 * src/maemo/modest-connection-specific-smtp-edit-window.c:
66 (on_change), (on_combo_security_changed),
67 (modest_connection_specific_smtp_edit_window_init),
68 (modest_connection_specific_smtp_edit_window_set_connection),
69 (modest_connection_specific_smtp_edit_window_is_dirty):
70 * src/maemo/modest-connection-specific-smtp-edit-window.h:
71 * src/maemo/modest-connection-specific-smtp-window.c:
74 Show an comfirmation dialog for the smpt-edit-window if there are
75 unsaved changes and the user hits cancel.
76 (projects.maemo.org bug NB#60479)
78 2007-06-14 Armin Burgmeier <armin@openismus.com>
80 * src/maemo/easysetup/modest-easysetup-wizard.c:
81 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
82 address" info in banner instead of node, and select all the text as
83 per UI spec. This fixes projects.maemo.org bug NB#60550.
85 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
87 reviewed by: <delete if not using a buddy>
89 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
90 * src/modest-ui-actions.c: (folder_refreshed_cb):
92 2007-06-14 Murray Cumming <murrayc@murrayc.com>
94 * src/widgets/modest-folder-view.c: (filter_row):
95 Explictly filter out the per-account outbox accounts. I don't know why
96 these only sometimes show up, but now they should never show up in the UI.
97 This should fix projects.maemo.org bug NB#60160.
99 2007-06-14 Murray Cumming <murrayc@murrayc.com>
101 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
102 when the toolbar does not exist yet.
103 * src/modest-widget-memory.c: (save_settings_header_view):
104 Added g_warnings() to help us to discover when we are trying to set
105 an empty columns list in gconf.
107 2007-06-14 Murray Cumming <murrayc@murrayc.com>
111 Added modest_init_get_default_header_view_column_ids().
113 * src/modest-widget-memory.c: (restore_settings_header_view):
114 Use the new function to get defaults, if the gconf key is empty,
115 instead of not creating any columns. This seems to fix the
116 empty right-hand pane problems.
118 * src/widgets/modest-header-view.h: Improved documentation.
120 2007-06-13 Murray Cumming <murrayc@murrayc.com>
122 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
123 Revert the use of the display name as the account name, because this
124 is generally wrong and would break the code that follows.
126 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
128 * src/maemo/easysetup/modest-easysetup-wizard.c:
129 (check_for_supported_auth_methods), (on_before_next),
132 More correct fix for projects.maemo.org bug NB# 58991
133 Do not longer accept AUTH_PASSWORD as secure method and choose
134 correct method when creating the account.
136 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
138 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
139 Fixed projects.maemo.org bug NB# 58991
141 2007-06-13 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-init.c: (modest_init_init_core),
144 (modest_init_local_folders): Fixed compilation errors.
146 2007-06-13 Murray Cumming <murrayc@murrayc.com>
148 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
149 Remove unnecessary lib/include, though it is good in principle when needed.
151 * src/modest-init.c: (modest_init_one_local_folder),
152 (modest_init_local_folders):
153 * src/modest-init.h: Initialize the .modest library for memory cards,
154 instead of just doing nothing for them. This should allow us to create
155 folders there, fixing projects.maemo.org bug NB#59297.
157 2007-06-13 Murray Cumming <murrayc@murrayc.com>
159 * libmodest-dbus-client/libmodest-dbus-client.c:
160 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
161 (libmodest_dbus_client_compose_mail),
162 (libmodest_dbus_client_open_message),
163 (libmodest_dbus_client_send_and_receive),
164 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
166 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
167 (on_idle_open_message), (modest_dbus_req_handler),
168 (search_result_to_message), (modest_dbus_req_filter):
169 * src/modest-search.c: (add_hit), (modest_search_folder),
170 (modest_search_all_accounts): Improved debug messages.
172 * tests/dbus_api/test_open_message.c: (main): Improved comments.
174 * src/modest-tny-account-store.c:
175 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
178 2007-06-13 Murray Cumming <murrayc@murrayc.com>
181 2007-06-12 Murray Cumming <murrayc@murrayc.com>
183 * src/modest-tny-account-store.c: (get_server_accounts):
184 Call modest_tny_local_folders_account_add_merged_outbox_folders()
185 even when there are no accounts, so that the Outbox folder is always
186 visible. This fixes projects.maemo.org bug NB#60158.
188 2007-06-12 Murray Cumming <murrayc@murrayc.com>
190 * src/maemo/modest-main-window.c: (create_details_widget):
191 Use the mcen_va_never logical ID.
193 2007-06-12 Murray Cumming <murrayc@murrayc.com>
195 * src/dbus_api/modest-dbus-api.h:
196 * src/dbus_api/modest-dbus-callbacks.c:
197 (on_idle_open_default_inbox), (on_open_default_inbox),
198 (modest_dbus_req_handler):
199 Added a new OpenDefaultInbox method.
201 * libmodest-dbus-client/libmodest-dbus-client.h:
202 * libmodest-dbus-client/libmodest-dbus-client.c:
203 Added libmodest_dbus_client_open_default_inbox() to call the new
204 dbus method. This should be useful to projects.maemo.org bug NB#57214,
205 though it should maybe be used by a new osso-email-interface function.
207 * tests/dbus_api/Makefile.am:
208 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
211 2007-06-12 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
214 NULL, so that the signals get all the keys. This should not actually
215 change any behaviour because we currently update everything when anything
218 2007-06-12 Murray Cumming <murrayc@murrayc.com>
220 * src/widgets/modest-folder-view.c: (text_cell_data),
221 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
222 (find_inbox_iter): If tinymail tells us that the folder is
223 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
224 This causes the inbox to be selected at startup, fixing part of
225 projects.maemo.org bug NB#56305.
227 * src/modest-ui-dimming-rules.c:
228 (modest_ui_dimming_rules_on_tools_smtp_servers):
229 * src/modest-ui-dimming-rules.h: Added a callback function to dim
230 the SMTP servers menu item.
231 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
232 that the SMTP Servers menu item is dimmed when there are no accounts,
233 as a future version of the UI spec will require. This fixes
234 projects.maemo.org bug NB#56305.
236 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
238 * src/maemo/modest-maemo-utils.c:
239 (modest_maemo_utils_get_supported_secure_authentication_methods):
240 Added label to dialog instead of unreadable title
242 * src/maemo/modest-main-window.c: (sync_accounts_cb),
243 (modest_main_window_new):
244 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
247 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
248 * src/modest-account-mgr.h:
249 Added method to avoid code duplication
251 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
252 (modest_ui_actions_on_send_receive):
253 Use modest_account_mgr_has_accounts
255 2007-06-11 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/easysetup/modest-presets.c:
258 (modest_presets_get_info_server_security): Do not report secure auth
260 * src/modest-protocol-info.c: Use the defines for the gconf key names
261 for secure authentication. This was not working because we were writing
262 Password and reading password, and the check was case sensitive.
263 With this, gmail now works for receiving and sending when created via
266 2007-06-11 Murray Cumming <murrayc@murrayc.com>
268 * src/maemo/easysetup/modest-presets.c:
269 (modest_presets_get_info_server_security): Correct the key name for
270 SecureSmtp, because it seems to be case-sensitive.
271 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
272 Do not try to get the 0th notebook page if there are 0 pages, to
275 2007-06-11 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
278 Prevent use of the new notification feature for now, because it currently
279 shows one dialog for each new email, which is annoying.
281 2007-06-11 Murray Cumming <murrayc@murrayc.com>
283 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
284 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
285 when no country was selected, so that we show the global ones.
286 * src/maemo/easysetup/modest-presets.c:
287 (modest_presets_get_providers): Return only the global providers, not
288 all providers when mmc=0 was requested.
290 2007-06-11 Murray Cumming <murrayc@murrayc.com>
292 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
293 (easysetup_provider_combo_box_fill): Remove debug code that showed the
294 provider ID in the combo.
296 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
297 Do not show the page numbers, because it would be confusing when we add
298 the 2 extra pages for the custom setup, when the user chooses the "Other"
299 provider. This fixes projects.maemo.org bug NB#59028
301 * src/modest-init.c: (modest_init_init_core),
302 (modest_init_local_folders):
304 * src/modest-tny-account.c:
305 (modest_tny_account_new_for_local_folders): Do not create default folders
306 for the memory card. This should fix projects.maemo.org bug NB#59328.
308 2007-06-11 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
311 Free the changed_conf_keys string items. They are already freed in the
312 idle handler if that runs first.
314 2007-06-11 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-ui-actions.c:
317 (modest_ui_actions_on_password_requested): Check that the server name
318 is not NULL, because I just saw a password dialog with (null) as the
321 * src/modest-tny-folder.[h|c]: Added
322 modest_tny_folder_is_memory_card_folder().
323 * src/modest-ui-dimming-rules.c:
324 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
325 menu item for memory cards, as per the UI spec (section 7.4). This should
326 fix projects.maemo.org bug NB#59297.
328 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
330 * src/maemo/modest-main-window.c: (sync_accounts_cb):
331 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
332 is another problem with the code, see Murray's comment at line 772)
334 2007-06-08 Murray Cumming <murrayc@murrayc.com>
336 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
337 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
338 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
339 (load_from_file), (easysetup_country_combo_box_init),
340 (easysetup_country_combo_box_get_active_country_ids),
341 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
342 instead of just one ID, to avoid duplicate country names in the UI.
344 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
345 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
346 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
347 a single ID, avoiding duplicate providers.
348 * src/maemo/easysetup/modest-easysetup-wizard.c:
349 (on_combo_account_country): Adapt to use a list.
351 2007-06-08 Murray Cumming <murrayc@murrayc.com>
353 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
354 keys changed in the last X seconds.
356 * src/modest-account-mgr.h:
357 * src/modest-account-mgr.c: (on_timeout_notify_changes),
358 (on_key_change), (modest_account_mgr_class_init),
359 (modest_account_mgr_init), (modest_account_mgr_finalize):
360 As the keys are changed, save them in a GSList* and signal that GSList*
361 further every X seconds, to batch changes, to allow us to do just one
362 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
363 bug NB#56941 and other (UI-blocking) delays when changing account settings.
365 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
366 changed signal signature.
368 * src/modest-conf.c: (modest_conf_set_list),
369 (modest_conf_on_change): Reenable notification.
371 (modest_conf_maemo_fake_on_change): Comment out the hack that
372 notified immediately instead of asynchronously.
374 * src/widgets/modest-account-view.h:
375 * src/widgets/modest-account-view.c:
376 (update_account_view): Select the previously-selected account ID,
377 if possible. This fixes projects.maemo.org bug NB#56933.
379 (on_account_changed), (on_account_removed),
380 (modest_account_view_select_account):
382 Remove the block/unblock functions
383 because they were not useful.
385 * src/maemo/modest-account-view-window.c:
386 (on_delete_button_clicked), (on_edit_button_clicked),
387 (on_new_button_clicked): Remove the use of the non-working block/unblock.
389 2007-06-08 Murray Cumming <murrayc@murrayc.com>
391 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
392 Improve the error dialog to show Incorrect Account Settings, which seems
393 clearer, and say that the internal error message (to be removed from the
394 dialog later) is often misleading.
395 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
397 * src/modest-tny-account.c:
398 (modest_tny_account_new_from_server_account): Uncomment the printf of the
399 URL because this is so useful for debugging on the device.
401 * src/widgets/modest-serversecurity-combo-box.c:
402 (modest_serversecurity_combo_box_fill): Correct a logical ID.
404 2007-06-08 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-mail-operation.c:
407 (modest_mail_operation_send_new_mail):
408 Added a comment about a nasty but apparently harmless message. Details
409 added to the wiki g_warnings() page.
411 2007-06-08 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
414 (modest_tny_send_queue_class_init):
415 Do not use the priv struct because it is empty, to avoid g_warnings
416 about a non-existant priv struct.
418 * src/modest-tny-account-store.c:
419 (modest_tny_account_store_get_server_account),
420 (modest_tny_account_store_get_transport_account_for_open_connection
421 ): Do not try to get transport server accounts for local folders,
422 because they don't have any. This avoids a g_warning().
424 * src/maemo/modest-main-window.c:
425 (modest_main_window_notify_send_receive_initied),
426 (on_configuration_key_changed):
427 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
429 * src/modest-mail-operation.c:
430 (modest_mail_operation_update_account):
431 * src/modest-tny-account-store.h:
432 * src/modest-tny-account.c:
433 (modest_tny_account_get_special_folder),
434 (modest_tny_account_new_for_local_folders),
435 (modest_tny_account_new_for_per_account_local_outbox_folder):
436 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
437 * src/modest-tny-local-folders-account.c:
438 (add_account_folders_to_merged_folder):
439 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
440 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
441 (modest_ui_actions_on_send):
442 * src/widgets/modest-folder-view.c: (update_model):
443 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
444 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
445 modest_tny_account_store_get_tny_account_by_account() to
446 modest_tny_account_store_get_server_account() to make the code clearer.
448 2007-06-07 Marcus Bauer <marcusb@openismus.com>
450 * src/dbus_api/modest-dbus-api.h:
451 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
452 * src/maemo/modest-msg-edit-window.c:
453 (modest_msg_edit_window_attach_file_noninteractive):
454 added g_warning in case the file to be attached does not exist
455 * tests/dbus_api/test_compose_mail.c: (main):
456 removed obsolete comment, added generic files as test case
458 2007-06-07 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c: (get_server_accounts):
461 Create the local folders account only once, not once for each outbox, and
462 not only when there are some outboxes.
464 2007-06-07 Murray Cumming <murrayc@murrayc.com>
466 * src/widgets/modest-folder-view.c: (update_model): Comment out some
467 code that is causing a crash at startup. Sergio says that he is fixing this.
469 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
471 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
472 * src/maemo/modest-account-settings-dialog.c:
473 (create_page_outgoing),
474 (modest_account_settings_dialog_set_account_name),
475 (save_configuration):
476 - Fixed handling of the "Use secure authentication" toggle to comply with
477 the ui specification. See also projects.maemo.org bug NB#58400
479 - Restore the Secure connection setting combo correctly when loading
482 * src/maemo/modest-maemo-utils.c:
483 (on_camel_account_get_supported_secure_authentication),
484 (modest_maemo_utils_get_supported_secure_authentication_methods):
485 Fixed a crasher if operation is canceled
487 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
488 (modest_protocol_info_auth_is_secure):
489 * src/modest-protocol-info.h:
491 Added two new methods to determine if a protocol/auth method is secure/encrypted in
492 the sense of the "Use secure authentication" toggle.
494 2007-06-07 Murray Cumming <murrayc@murrayc.com>
496 * src/modest-tny-account-store.h:
497 * src/modest-tny-account-store.c:
498 Added modest_tny_account_store_get_local_folders_account().
500 * src/modest-tny-folder.h:
501 * src/modest-tny-folder.c:
502 (modest_tny_folder_get_account):
503 Added this replacement for tny_folder_get_account() which returns
504 the local-folders account for TnyMergeFolders, to avoid the
505 warning about the unimplemented get_account_func() vfunc().
507 (modest_tny_folder_get_rules),
508 * src/modest-ui-actions.c:
509 (modest_ui_actions_on_folder_selection_changed):
510 * src/modest-mail-operation.c:
511 (modest_mail_operation_remove_folder),
512 (modest_mail_operation_xfer_folder),
513 (modest_mail_operation_rename_folder),
514 (modest_mail_operation_get_msg),
515 (modest_mail_operation_get_msgs_full),
516 (modest_mail_operation_remove_msg),
517 (modest_mail_operation_xfer_msgs),
518 (modest_mail_operation_refresh_folder):
519 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
521 2007-06-07 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
524 (modest_server_account_set_security):
525 * src/modest-defs.h: Add comments explaining that our
526 UI spec means TLS when it says Normal, so these do not look like errors.
528 * src/modest-tny-account.c:
529 (modest_tny_account_new_from_server_account): Use the new tinymail
530 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
531 for TLS. This should fix projects.maemo.org bug NB#58460.
533 2007-06-06 Murray Cumming <murrayc@murrayc.com>
535 * src/maemo/easysetup/modest-easysetup-wizard.c:
536 (create_account): Correct the position of the gconf sanity check warning.
537 (on_button_edit_advanced_settings): Show the dialog immediately, instead
538 of using the g_idle_add() hack, because this does not seem to be necessary
539 on osso 1.1. It might even work on Maemo Bora if the problems were actually
540 caused by something other than maemo's gconf.
541 This fixes projects.maemo.org bug #59022.
543 2007-06-06 Murray Cumming <murrayc@murrayc.com>
545 * src/modest-account-mgr-helpers.c:
546 (modest_account_mgr_get_default_account): Do not check that the account
547 exists if there is no default account (NULL), to fix a runtime warning.
549 2007-06-06 Murray Cumming <murrayc@murrayc.com>
551 * src/widgets/modest-folder-view.c: (update_model):
552 Do not unref the treemodel before we have finished with it.
553 This prevents a valgrind warning and an occasional crash at startup.
555 2007-06-06 Marcus Bauer <marcusb@openismus.com>
557 * libmodest-dbus-client/libmodest-dbus-client.h:
558 added libmodest_dbus_client_compose_mail()
559 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
561 added functions needed for SendAsMail() functionality
562 * src/maemo/modest-msg-edit-window.c:
563 (modest_msg_edit_window_attach_file_noninteractive):
564 non interactively attaching files to message edit window
565 * src/widgets/modest-msg-edit-window.h:
566 * tests/dbus_api/Makefile.am:
567 added test_compose_mail.c
568 * tests/dbus_api/test_compose_mail.c: (main):
570 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
572 * src/modest-account-view.c:
573 Fixed bug projects.maemo.org bug NB#59307
575 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c:
578 (get_serverport_incoming), (on_before_next), (create_account):
579 * src/maemo/modest-account-settings-dialog.c:
580 (modest_account_settings_dialog_set_account_name):
581 * src/maemo/modest-maemo-utils.c:
582 (on_camel_account_get_supported_secure_authentication_status),
583 (on_camel_account_get_supported_secure_authentication),
584 (on_secure_auth_cancel),
585 (modest_maemo_utils_get_supported_secure_authentication_methods):
587 Implemented security authentication for settings and easysetup.
589 2007-06-05 Murray Cumming <murrayc@murrayc.com>
591 * src/maemo/modest-main-window.c: (create_details_widget):
592 Show the total size for memory card accounts too, instead of showing
593 the name again. Fixes bug projects.maemo.org bug NB#59307.
595 2007-06-05 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-tny-simple-folder-store.c:
599 * src/modest-tny-simple-folder-store.h: Removed.
601 * src/modest-tny-local-folders-account.h
602 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
603 for the local-folders maildir, with an extra TnyMergedFolder containing
604 the folders of the per-account outbox store accounts.
605 * src/modest-tny-account-store.c: (get_server_accounts):
606 Add the outboxes to the special local folders account after creating it.
608 * src/modest-tny-account.c:
609 (modest_tny_account_new_for_local_folders): Create the derived
610 account when creating the main local-folders account.
612 * src/maemo/modest-main-window.c: (create_details_widget),
613 (modest_main_window_set_contents_style):
614 Adapted to the use of the derived account instead of the folder store.
616 * src/modest-ui-actions.c:
617 (modest_ui_actions_on_folder_selection_changed):
618 * src/modest-ui-dimming-rules.c:
619 (modest_ui_dimming_rules_on_new_folder):
620 * src/widgets/modest-folder-view.c: (text_cell_data),
621 (icon_cell_data), (filter_row), (update_model),
622 (get_cmp_rows_type_pos):
625 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
626 Do not get the priv struct, because no priv struct has been set,
627 to avoid a runtime warning.
629 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
630 #ifelse with #else, to fix a warning, to fix the build.
633 2007-06-05 Christian Kellner <ckellner@openismus.com>
635 * libmodest-dbus-client/libmodest-dbus-client.c:
636 Fix small typo in doc (why do you always see them
637 AFTER committing stuff?)
640 2007-06-05 Christian Kellner <ckellner@openismus.com>
642 * libmodest-dbus-client/libmodest-dbus-client.c:
643 (libmodest_dbus_client_search):
644 Initialize hit list with NULL. Also set folder list
645 to "" if NULL was supplied.
648 2007-06-03 Christian Kellner <ckellner@openismus.com>
650 * libmodest-dbus-client/libmodest-dbus-client.c:
651 (modest_search_hit_list_free):
652 Make it save to call it with NULL.
654 * src/dbus_api/modest-dbus-callbacks.c:
655 * src/modest-search.c:
656 Return full ModestSearchHits as the search result list not TnyHeader
657 since can't be around withouth the correspoding TnyFolder.
659 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
661 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
662 Added currently commented code to check for secure auth
664 * src/maemo/modest-account-settings-dialog.c: (on_response),
665 (save_configuration), (show_ok):
666 Fixed projects.maemo.org bugs NB #59248 and #59251
668 * src/maemo/modest-maemo-utils.c:
669 (on_camel_account_get_supported_secure_authentication_status),
670 (on_camel_account_get_supported_secure_authentication),
671 (modest_maemo_utils_get_supported_secure_authentication_methods):
672 * src/maemo/modest-maemo-utils.h:
673 Moved get_supported_secure_authentication() method here to be able
674 to use it from easysetup wizard.
676 * src/modest-pair.c: (on_pair_compare_as_string):
677 Should compare string with first part of pair and not
678 strcmp pairs which will crash.
680 * src/modest-protocol-info.c:
681 (modest_protocol_info_protocol_is_store):
682 * src/modest-protocol-info.h:
683 Added modest_protocol_info_get_auth_protocol_name()
685 2007-06-03 Armin Burgmeier <armin@openismus.com>
687 * src/modest-mail-operation.c:
688 (modest_mail_operation_get_msgs_full): Set priv->account also when
689 only retrieving a single message. This avoids a crash when canceling
692 (modest_mail_operation_notify_end): Do not explicitely remove the
693 operation from the queue but only emit the progress_changed signal.
694 The queue itself listens to that signal to remove the operation when
695 it is finished. This reduces coupling and removes a potential deadlock
696 when modest_mail_operation_notify_end() is called from the queue
697 itself. If that is a problem performance-wise, I would suggest to
698 implement a status-changed signal or something.
700 * src/modest-mail-operation-queue.c: Make sure to never call a
701 function from another file while the queue is locked. This (hopefully)
702 fixes another deadlock when exiting the application while retrieving
705 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
707 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
708 Fixed build if libogs is not available
710 2007-06-03 Christian Kellner <ckellner@openismus.com>
712 * libmodest-dbus-client/libmodest-dbus-client.h:
713 * libmodest-dbus-client/libmodest-dbus-client.c:
714 (libmodest_dbus_client_delete_message):
715 Implement deletion of messages (Client side).
717 (modest_search_hit_free),
718 (modest_search_hit_list_free):
719 Utility functions to free the result hits.
721 * src/dbus_api/modest-dbus-api.h:
722 * src/dbus_api/modest-dbus-callbacks.c:
724 (modest_dbus_req_handler):
725 Implement deletion of messages (Server side).
727 * tests/dbus_api/test_search.c: (main):
730 * tests/dbus_api/Makefile.am:
731 * tests/dbus_api/test_delete_message:
732 Add little test for the message deletion logic
734 2007-06-03 Armin Burgmeier <armin@openismus.com>
736 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
737 when the operation queue was not empty. projects.maemo.org bug
740 2007-06-03 Armin Burgmeier <armin@openismus.com>
742 * src/widgets/modest-account-view.c
743 (on_account_default_toggled): Toggle default account column
744 explicitely instead of waiting for gconf notification (which is
745 currently ignored). This should fix projects.maemo.org bug NB#56910
746 for now. It should probably be removed when gconf notifications are
749 2007-06-03 Christian Kellner <ckellner@openismus.com>
751 * libmodest-dbus-client/libmodest-dbus-client.c:
752 Removed debugging spew.
754 * src/dbus_api/modest-dbus-callbacks.c:
755 Added debugging info.
757 * src/modest-search.c:
758 (modest_search_all_accounts):
759 Use tny_account_store_get_accounts () on the account store
760 to get all accounts which is the way to get all accounts.
762 * tests/dbus_api/test_search.c: (main):
763 Make it possible to supply the search term on the command line.
765 2007-06-03 Christian Kellner <ckellner@openismus.com>
767 * libmodest-dbus-client/libmodest-dbus-client.c:
768 * libmodest-dbus-client/libmodest-dbus-client.h:
769 Implement searching for mesages over raw dbus. (Client side)
771 * src/dbus_api/Makefile.am:
772 * src/dbus_api/modest-dbus-api.h:
773 * src/dbus_api/modest-dbus-callbacks.c:
774 * src/dbus_api/modest-dbus-callbacks.h:
775 Search framework (Server side). Also implement on_idle_open_message().
777 * src/maemo/modest-platform.c: (modest_platform_init):
778 Prepare for raw dbus/osso rpc interaction.
780 * src/modest-search.h:
781 Changed minsize from unspecific guint to guint32.
783 * src/modest-search.c:
785 Added strange hack which magically made tnymail work.
787 (modest_search_folder),
788 (modest_search_account),
789 (modest_search_all_accounts):
790 Implement helper functions to search all accounts, specific account
793 * tests/dbus_api/Makefile.am:
794 * tests/dbus_api/test_open_message.c:
795 Read url to open from commandline.
797 * tests/dbus_api/test_search.c:
798 Implement small test for dbus search stuff
800 2007-06-02 Armin Burgmeier <armin@openismus.com>
802 * src/maemo/modest-account-settings-dialog.c: Changed window title to
803 include account type and account title. This fixes projects.maemo.org
806 * src/maemo/modest-account-view-window.c: Set a title for the window.
808 2007-06-02 Armin Burgmeier <armin@openismus.com>
810 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
811 incoming and outgoing server name based on email address and server
812 types as long as the names have not been edited manually. This fixes
813 projects.maemo.org bug NB#58671.
815 2007-06-02 Armin Burgmeier <armin@openismus.com>
817 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
818 server type cannot be changed in future to the incoming details page
819 when creating an account. This fixes projects.maemo.org bug NB#59029.
821 2007-06-02 Armin Burgmeier <armin@openismus.com>
823 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
824 and assigned max width chars so that they wrap instead of being
825 truncated. Fixes projects.maemo.org bug NB#56126.
827 2007-06-02 Armin Burgmeier <armin@openismus.com>
829 * src/maemo/modest-connection-specific-smtp-window.c: Add an
830 introductory note to the connection specific smtp servers dialog, as
831 section 8.12 of the email UI specification requires. This fixes
832 projects.maemo.org bug NB#59212.
834 2007-06-01 Murray Cumming <murrayc@murrayc.com>
836 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
837 Check for running mail operations, and offer to cancel them, as per the UI
838 spec. This fixes projects.maemo.org bug NB#59041 .
839 However, I suspect that tinymail may still use the network connection
840 in ways that we cannot detect or cancel. But it should at least adapt to
843 2007-06-01 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-tny-account-store.c: (recreate_all_accounts),
846 (get_cached_accounts), (get_server_accounts): Do more sensible
847 ref-counting of the temporarily-cached outbox accounts list. This seems
848 to fix a crash when entering the password when the password was wrong.
850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
852 * src/gnome/modest-main-window.c: (connect_signals):
853 * src/modest-tny-account-store.c: (get_password),
854 (modest_tny_account_store_alert): Added comments and clues and
855 commented-out code about how we currently fail to deal with connection
856 errors and wrong passwords, and how we should.
858 2007-06-01 Murray Cumming <murrayc@murrayc.com>
860 * src/widgets/modest-retrieve-combo-box.c:
861 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
862 This fixes projects.maemo.org bug NB#58472 .
864 2007-06-01 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/easysetup/modest-easysetup-wizard.c:
867 (create_page_complete_easysetup):
868 (create_page_complete_custom): Correct the last commit,
869 putting the correct sentences in the correct pages.
871 2007-06-01 Murray Cumming <murrayc@murrayc.com>
873 * src/maemo/easysetup/modest-easysetup-wizard.c:
874 (create_page_complete_custom): Show the second sentence of text
875 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
878 2007-06-01 Murray Cumming <murrayc@murrayc.com>
880 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
881 Set the leave-on-server conf key by default. This fixes
882 projects.maemo.org bug NB#59258 .
884 2007-06-01 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/modest-account-view-window.c:
887 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
888 logical ID for the confirmation messages. Fixed projects.maemo.org bug
891 2007-06-01 Murray Cumming <murrayc@murrayc.com>
893 * src/maemo/easysetup/modest-easysetup-wizard.c:
894 (create_caption_new_with_asterisk):
895 * src/maemo/modest-account-settings-dialog.c:
896 (create_caption_new_with_asterisk):
897 Uncomment the code to add the asterisk, because they are no longer in the
898 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
899 (update_incoming_server_title): Add an asterisk here too.
901 2007-06-01 Murray Cumming <murrayc@murrayc.com>
903 * src/maemo/modest-maemo-global-settings-dialog.c:
904 (current_connection): Check that we are even connected before trying to
905 get the current connection name, to prevent a warning.
907 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
908 Change the comments because tny_maemo_conic_device_connect() is now meant to
910 * src/modest-mail-operation.c:
911 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
912 make sure we have a connection and fail if we can't connect.
914 2007-05-31 Murray Cumming <murrayc@murrayc.com>
916 * src/maemo/modest-main-window.c:
917 (on_account_store_connecting_finished): Do not try to get the
918 connection ID if we are not really connected. I am surprised that
919 this signal handler is called when we are not connected.
921 2007-05-31 Murray Cumming <murrayc@murrayc.com>
923 * src/modest-error.h:
924 * src/modest-ui-actions.c:
925 (modest_ui_actions_get_msgs_full_error_handler):
926 Renamed an enum, added comments, added an enum
927 for retrieve-limit errors.
929 * src/modest-mail-operation.c: (foreach_add_item),
930 (internal_folder_observer_update), (update_account_thread),
931 (modest_mail_operation_get_msgs_full):
932 (modest_mail_operation_update_account),
933 Added comments about how this works, and some code that should
934 (but does not) check the retrieve-limit. See the TODO comment.
936 2007-05-31 Murray Cumming <murrayc@murrayc.com>
938 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
939 Initialize help_id to fix the build. Warnings are good.
941 2007-05-31 Murray Cumming <murrayc@murrayc.com>
943 * src/widgets/modest-hbox-cell-renderer.c:
944 (modest_hbox_cell_renderer_append):
945 * src/widgets/modest-vbox-cell-renderer.c:
946 (modest_vbox_cell_renderer_append):
947 Fix the last commit by doing an extra ref.
949 2007-05-31 Murray Cumming <murrayc@murrayc.com>
951 * src/widgets/modest-hbox-cell-renderer.c:
952 (modest_hbox_cell_renderer_append):
953 * src/widgets/modest-vbox-cell-renderer.c:
954 (modest_vbox_cell_renderer_append):
955 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
956 to fix the build with Maemo Bora.
957 However, there seems to be a remaining crash, probably due to reference
960 2007-05-30 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account.c:
963 (modest_tny_account_new_for_local_folders):
964 Use hildon_file_system_info_async_new() to get a better name for
965 the memory card account, setting it as the account name.
966 The timing seems to work, but this is probably
967 not the best place to do this. See the TODO comment.
968 * src/maemo/modest-main-window.c: (create_details_widget):
969 * src/widgets/modest-folder-view.c: (text_cell_data):
970 Use the tny account name instead of hardcoding a name.
972 2007-05-30 Christian Kellner <ckellner@openismus.com>
974 * src/modest-search.c: (modest_search):
975 Correctly set part_search_func even if we have already parsed
976 the query and thus a valid OgsTextSearcher object.
978 2007-05-30 Christian Kellner <ckellner@openismus.com>
981 Search and check for libogs.
984 Incooparte the ogs build env.
986 * src/modest-mime-part-search-stream.c:
987 * src/modest-mime-part-search-stream.h:
988 Removed since we do the real searching now in modest-search.c.
990 * src/modest-search.c:
991 * src/modest-search.h:
992 Implement support for ogs. We use that if available and requested
993 and fall back to modest_text_utils_utf8_strcmp (). The search logic
994 should now handle the corner case when the search term is spread
995 across multiple reads.
996 Also the logic in modest_search () was corrected to search all
997 requested fields until one is found.
999 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1001 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1003 * src/modest-init.h:
1004 * src/modest-init.c: Made modest_init_local_folders() take a
1005 path and be public so we can iniitialize maildir folders on
1008 * src/modest-local-folder-info.h:
1009 * src/modest-local-folder-info.c:
1010 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1012 * src/modest-tny-account.c:
1013 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1014 still means the standard local-folders path on the local volume.
1016 * src/modest-tny-account-store.c:
1017 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1018 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1019 all accounts when that happens.
1020 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1021 this too, so it shows up in the treeview.
1023 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/modest-maemo-global-settings-dialog.c:
1026 (current_connection):
1027 * src/widgets/modest-global-settings-dialog.c:
1028 (current_connection_default):
1029 Use the enum values instead of 0, 1 and -1,
1030 to make the code clearer.
1032 * src/modest-account-mgr-helpers.c:
1033 (modest_account_mgr_get_connection_specific_smtp): Make this code
1036 * src/modest-runtime.h:
1037 * src/modest-runtime.c:
1038 Added modest_runtime_remove_all_send_queues().
1039 * src/maemo/modest-main-window.c:
1040 (on_account_store_connecting_finished): Recreate the send queues,
1041 using the appropriate transport accounts for this new connection.
1042 Some futher adapting might be needed if the old send queues are not
1043 automatically stopped at this point.
1045 * src/modest-tny-account-store.c: (get_server_accounts):
1046 Create the connection-specific transport accounts, so that they can
1047 be found later by their ID.
1049 * src/modest-tny-account.h:
1050 * src/modest-tny-account.c:
1051 Added modest_tny_account_new_from_server_account_name().
1052 modest_tny_account_new_from_server_account(): Do not create the
1053 send queues here, because they will be
1054 recreated anyway when the connection changes for the first time.
1056 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-local-folder-info.h:
1059 * src/modest-local-folder-info.c:
1060 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1061 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1062 tbox_folder): Take a modest account name instead of a server TnyAccount,
1063 so we can have per-modest-account rather than per-transport-account
1065 We must make sure that we change or recreate the exisitng send queues
1066 when the connection changes for connection-specific transport accounts.
1068 * src/modest-tny-account-store.c:
1069 (create_per_account_local_outbox_folders): Create outboxed per modest
1070 account, not per transport account.
1072 * src/modest-tny-account.h:
1073 * src/modest-tny-account.c:
1074 (modest_tny_account_get_special_folder): For outboxes, get the
1075 parent modest account name. The account is ignored for other folders.
1076 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1077 modest account name rather than a server TnyAccount.
1079 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account.c:
1082 (modest_tny_account_new_from_server_account):
1083 Call modest_runtime_get_send_queue() immediately after creating transport
1084 accounts, so that they start trying to send email from the outbox as soon
1085 as possible at startup. This is probably what we want.
1087 * src/modest-mail-operation.c: (update_account_thread):
1088 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1089 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1090 * src/modest-tny-send-queue.h:
1091 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1092 (modest_ui_actions_on_send):
1093 Added comments about how sending works, though it needs some more work.
1095 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-tny-account.c:
1098 (modest_tny_account_get_special_folder): Add TODO because this fails when
1099 the network is busy.
1100 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1101 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1102 Do not try to show this window when there is no active account. The UI
1103 specs does not tell us what to do in this case.
1105 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1109 * src/maemo/Makefile.am:
1110 * src/widgets/Makefile.am: Some dist fixes.
1112 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/modest-connection-specific-smtp-window.c:
1115 (on_button_edit): Make the code clearer, to prevent a double free.
1117 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-account-settings-dialog.c:
1120 (modest_account_settings_dialog_set_account_name),
1121 Check the connection-specific smtp servers checkbox if there are any.
1123 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1124 (modest_connection_specific_smtp_edit_window_init):
1125 Start with a suitable port number.
1127 * src/modest-account-mgr-helpers.h:
1128 * src/modest-account-mgr-helpers.c: Added
1129 modest_account_mgr_get_has_connection_specific_smtp().
1131 (modest_account_mgr_set_connection_specific_smtp),
1132 (modest_account_mgr_remove_connection_specific_smtp),
1133 (modest_account_mgr_get_has_connection_specific_smtp),
1134 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1135 connection-specific smtp server accounts in the account, rather than
1136 the server account conf dir.
1138 This fixes bug projects.maemo.org bug NB#58263 .
1140 * src/modest-tny-account-store.c:
1141 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1142 if there are no server accounts yet, to prevent an infinite loop when there
1143 are no accounts. Document that one must be called before the other.
1145 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1147 * src/modest-account-mgr-helpers.c:
1148 (modest_account_mgr_get_default_account): Make sure that at least
1149 one account is always the default, if there are any enabled accounts.
1150 This is just a sanity check that shouldn't be necessary.
1152 * src/modest-account-mgr-priv.c:
1153 (_modest_account_mgr_account_from_key): Unescape the conf key to
1154 get the real account name. For instance, this is an issue if a space
1155 was in the account name, which can happen because the account name
1156 is generated from the display name.
1157 (_modest_account_mgr_get_account_keyname): Always escape the
1159 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1160 Unescape the conf keys to get the real account names.
1162 For instance, previously the is-default radio button in the accounts
1163 list was not checked for any accounts at first. This fixes that,
1164 and might fix several similar bugs.
1166 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1168 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1169 Removed some debug printfs.
1171 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1173 Modest on-disk outbox directories are now here, for instance:
1174 $HOME/.modest/outboxes/<account-id-1>/outbox
1175 $HOME/.modest/outboxes/<account-id-2>/outbox
1177 $HOME/.modest/local-folders/outbox
1178 so we can have a separate outbox for each account.
1179 But they are shown as one outbox in the GtkTreeView, by using a
1180 TnyMergeFolder in a ModestTnySimpleFolderStore.
1183 * src/modest-tny-simple-folder-store.c:
1184 * src/modest-tny-simple-folder-store.h:
1185 Added ModestTnySimpleFolderStore, used to contain folders from
1186 other folder stores, such as other accounts.
1188 * src/modest-tny-outbox-account.h:
1189 * src/modest-tny-outbox-account.c:
1190 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1191 used for the per-account local outbox folders.
1193 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1194 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1195 only use this (internally) now for the non-outbox local folders.
1197 * src/modest-init.h:
1198 * src/modest-init.c: Added modest_init_one_local_folder(), for
1199 setting up the directory structure for each local folder.
1201 * src/modest-local-folder-info.c:
1202 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1203 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1205 * src/modest-local-folder-info.h:
1206 * src/modest-tny-account-store.c: (on_account_removed),
1207 (on_account_changed), (create_per_account_local_outbox_folders),
1208 (get_server_accounts), (modest_tny_account_store_get_accounts),
1209 (modest_tny_account_store_get_tny_account_by_account),
1210 (modest_tny_folder_store_is_virtual_local_folders):
1212 * src/modest-tny-account.h:
1213 * src/modest-tny-account.c:
1214 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1215 to create an on-disk per-account local outbox folder for each
1217 (create_per_account_local_outbox_folders): Create a local outbox folder
1218 for each transport account.
1219 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1220 for all local folders.
1222 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1223 instead of using g_object_get/set() directly. It is clearer.
1225 (modest_tny_folder_store_get_message_count),
1226 (modest_tny_folder_store_get_local_size
1227 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1228 because we now use these with non-acount folder stores.
1230 (modest_tny_account_get_special_folder),
1231 (modest_tny_account_new_from_server_account),
1232 (modest_tny_account_new_from_account):
1233 (recurse_folders): Adjust to the new outbox system.
1235 * src/modest-tny-folder.h:
1236 * src/modest-tny-folder.c:
1237 (modest_tny_folder_is_local_folder),
1238 (modest_tny_folder_get_local_folder_type),
1239 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1241 * src/widgets/modest-main-window.h:
1242 * src/maemo/modest-main-window.c: (create_details_widget),
1243 (modest_main_window_set_contents_style): Show details for any folder store,
1246 (modest_tny_folder_get_rules):
1247 Remove the const. C does not support constness enough for this.
1249 * src/modest-ui-actions.c:
1250 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1251 make all outboxes appear as one, in the usual local-folders tree node.
1253 (set_active_account_from_tny_account),
1254 (modest_ui_actions_on_folder_selection_changed):
1255 * src/widgets/modest-folder-view.c: (text_cell_data),
1256 (icon_cell_data), (filter_row),
1257 (add_account_folders_to_merged_folder),
1258 (add_account_folders_to_simple_folder_store), (),
1259 (get_cmp_rows_type_pos), (cmp_rows),
1260 (modest_folder_view_set_account_id_of_visible_server_account):
1261 Adjust to the new outbox system, using generic folder stores and folders
1262 in the GtkTreeModel.
1264 2007-05-23 Christian Kellner <ckellner@openismus.com>
1266 * src/modest-mail-operation.c:
1267 (modest_mail_operation_update_account):
1268 Use info->max_size instead of unintialized local var [small
1269 build fix]. (Added TODO to review that change since I don't
1272 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1274 * libmodest-dbus-client/libmodest-dbus-client.c:
1275 (libmodest_dbus_client_compose_mail): function added
1276 * src/dbus_api/modest-dbus-api.h:
1277 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1278 (on_compose_mail): Implementation of the SendAsMail functionality
1280 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-account-mgr.c:
1283 (modest_account_mgr_add_server_account): Set the secure-connection
1284 conf key for transport accounts as well as store accounts. I don't know
1285 why the if was there. For instance, this makes sure that we use SSL
1286 for the gmail preset from the easysetup wizard.
1288 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1290 * src/gnome/modest-main-window.c:
1291 (on_account_store_connecting_finished), (connect_signals):
1292 * src/maemo/modest-main-window.c:
1293 (on_account_store_connecting_finished), (connect_signals),
1294 (modest_main_window_new):
1295 Handle TnyAccountStore::connecting-finished instead of
1296 TnyDevice::connection-changed, because we cannot actually perform
1297 operations on accounts until TnyAccountStore has itself responded to
1298 the TnyDevice::connection-changed signal. This prevents a GError from
1300 Do not try to update at startup, because we (at least on scratchbox)
1301 already do an update at startup when the device goes online.
1302 This prevents a GError from tinymail.
1303 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1304 Added TODO about stopping simultaneous operations.
1306 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1308 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1309 * src/modest-mail-operation-queue.c:
1310 (modest_mail_operation_queue_remove):
1311 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1312 about where they happened.
1314 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-ui-actions.c:
1317 (modest_ui_actions_on_password_requested): Make sure that the remember
1318 output parameter is always TRUE.
1320 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1323 Show a OK/Cancel dialog if the error is a question, though we still do not
1324 know anything more about what we are asking the user.
1325 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1326 Fix an uninitialized variable (helper). This is a logic error, however.
1328 2007-05-21 Christian Kellner <ckellner@openismus.com>
1330 * src/modest-search.h:
1331 Correct bit shifting in the ModestSearchFlags enum.
1333 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-tny-account.c:
1336 (modest_tny_account_new_from_server_account): Do not use the lsub and
1337 check-all hard-coded IMAP options when using POP.
1339 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-tny-account.c:
1342 (modest_tny_account_new_from_server_account):
1343 Use NULL for the secure-auth method for POP when Password auth has been
1344 specified by the user, as we already do for IMAP. "auth=Login" causes
1345 an error from camel or the server.
1347 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1349 * src/maemo/modest-account-settings-dialog.c:
1350 (create_page_account_details),
1351 (modest_account_settings_dialog_set_account_name):
1352 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1353 for the leave-on-server checkbox, rathr than just the checkbox, when
1354 the protocol is not POP.
1356 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1358 * src/widgets/modest-account-view.c:
1359 * src/widgets/modest-account-view.h:
1360 Added modest_account_view_select_account() which will be useful later
1361 to asynchronously re-select the edited account.
1363 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1365 * src/maemo/modest-account-settings-dialog.c:
1366 (modest_account_settings_dialog_set_account_name):
1367 Automatically choose the port numbers based on the secure authentication
1368 methods, if they have not been chosen before.
1369 This fixes projects.maemo.org bug NB#56273 .
1371 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/modest-main-window-ui.h:
1374 * src/modest-ui-actions.c:
1375 * src/modest-ui-actions.h:
1376 Connect the Tools/SMTP Servers menu item to
1377 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1378 SMTP servers dialog, as in the UI specification and saves changes when it
1379 is closed. This fixed projects.maemo.org bug NB#56305 .
1381 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/modest-connection-specific-smtp-window.c:
1384 (modest_connection_specific_smtp_window_init):
1385 Use gtk_window_set_default_size() to make this window big enough, so
1386 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1388 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1390 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1392 (modest_connection_specific_smtp_edit_window_init),
1393 Do not try to connect to a combobox signal before the combobox exists.
1394 This fixes the cras in projects.maemo.org bug NB#56288 .
1395 (modest_connection_specific_smtp_edit_window_get_settings):
1396 Remove the server_account_name parameter which was being checked for NULL
1397 though it was not used.
1399 * src/maemo/modest-connection-specific-smtp-window.c:
1400 (modest_connection_specific_smtp_window_fill_with_connections),
1401 (on_button_edit), (modest_connection_specific_smtp_window_init):
1402 Correct the number of treemodel columns to prevent a warning.
1403 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1404 libconic does not work.
1406 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1408 * src/modest-tny-account.c:
1409 (modest_tny_account_new_from_server_account):
1410 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1411 SMTP when "None" was chosen by the user. However, with my SMTP server that
1412 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1415 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1417 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1418 to explain the memory management issue with the ID in the ModestPair.
1420 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1421 (add_sending_page), (modest_account_assistant_finalize):
1422 * src/gnome/modest-gnome-global-settings-dialog.c:
1423 (create_updating_page), (create_composing_page):
1424 * src/gnome/modest-msg-edit-window.c: (get_transports),
1425 (init_window), (modest_msg_edit_window_finalize),
1426 (modest_msg_edit_window_get_msg_data):
1427 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1428 * src/gnome/modest-transport-widget.c:
1429 (modest_transport_widget_finalize), (smtp_configuration):
1430 * src/maemo/modest-maemo-global-settings-dialog.c:
1431 (create_updating_page), (create_composing_page):
1432 * src/maemo/modest-msg-edit-window.c: (get_transports),
1433 (init_window), (modest_msg_edit_window_finalize),
1434 (modest_msg_edit_window_get_msg_data),
1435 (modest_msg_edit_window_free_msg_data):
1436 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1437 (modest_store_widget_finalize):
1438 * src/maemo/modest-transport-widget.c:
1439 (modest_transport_widget_finalize), (smtp_configuration):
1440 * src/modest-main.c: (send_mail):
1441 * src/widgets/modest-combo-box.h:
1442 * src/widgets/modest-global-settings-dialog-priv.h:
1443 * src/widgets/modest-global-settings-dialog.c:
1444 (modest_global_settings_dialog_finalize):
1445 * src/widgets/modest-msg-edit-window.h:
1446 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1447 as long as the combo box, to prevent use of freed memory for the ID.
1449 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1452 get_accounts(), to make this clearer. Do not check for the enabled gconf
1453 key, because we do not use this for server accounts (at least, not yet).
1454 This allows us to send email again.
1456 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/modest-platform.c:
1459 (on_modest_conf_update_interval_changed), (modest_platform_init):
1460 Only respond to this particular key change. All these strcmp()s cannot be
1463 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1465 * src/maemo/modest-maemo-global-settings-dialog.c:
1466 (current_connection): Prevent a crash in scratchbox when
1467 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1468 * src/maemo/modest-platform.c:
1469 (on_modest_conf_update_interval_changed), (modest_platform_init):
1470 Get the update interval from gconf and reset it when the gconf key changes.
1472 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1474 * src/modest-protocol-info.c:
1475 * src/modest-protocol-info.h: Adde enum-specific get functions,
1476 instead of using a ModestProtocolType enum parameter.
1478 * src/gnome/modest-account-assistant.c:
1479 * src/gnome/modest-store-widget.c:
1480 * src/gnome/modest-store-widget.h:
1481 * src/gnome/modest-transport-widget.c:
1482 * src/gnome/modest-transport-widget.h:
1483 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1484 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1485 * src/maemo/easysetup/modest-easysetup-wizard.c:
1486 * src/maemo/modest-account-settings-dialog.c:
1487 * src/maemo/modest-account-settings-dialog.h:
1488 * src/maemo/modest-store-widget.c:
1489 * src/maemo/modest-store-widget.h:
1490 * src/maemo/modest-transport-widget.c:
1491 * src/maemo/modest-transport-widget.h:
1492 * src/modest-account-mgr-helpers.c:
1493 * src/modest-account-mgr-helpers.h:
1494 * src/modest-account-mgr.c:
1495 * src/modest-account-mgr.h:
1496 * src/modest-tny-account.c:
1497 * src/modest-tny-folder.c:
1498 * src/widgets/modest-account-view.c:
1499 * src/widgets/modest-retrieve-combo-box.c:
1500 * src/widgets/modest-retrieve-combo-box.h:
1501 * src/widgets/modest-secureauth-combo-box.c:
1502 * src/widgets/modest-serversecurity-combo-box.c:
1503 * src/widgets/modest-serversecurity-combo-box.h:
1504 * tests/check_account-mgr.c:
1505 Use the specific functions, and use the re-renamed enum values for GNOME too.
1507 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-pair.h:
1510 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1511 so we can get the second based on the first.
1513 * src/maemo/modest-account-settings-dialog.h:
1514 * src/maemo/modest-account-settings-dialog.c:
1515 Added get_supported_secure_authentication_methods(), though it is mostly
1516 commented-out for now until the necessary API is committed to tinymail.
1517 (modest_account_settings_dialog_set_account_name),
1518 (save_configuration): Request the supported authentication methods from the
1519 server, so we can choose a working method.
1521 * src/modest-tny-account-store.h:
1522 * src/modest-tny-account-store.c:
1523 (modest_tny_account_store_get_session): Rename from
1524 tny_account_store_get_session().
1526 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1528 * src/modest-protocol-info.h: Split the ModestProtocol enum
1529 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1530 There was no need to have these unrelated values in one enum.
1532 * src/: many files: Adapted to changed enum. This makes the code a bit
1533 clearer, and the compiler could catch some errors.
1535 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1538 Show the detailed internal camel error message when an error happens
1539 during the configuration, so that our testers can give us more clues.
1540 For instance, in projects.maemo.org bug NB#56910 .
1542 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account.c:
1545 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1546 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1548 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1551 * src/maemo/modest-account-settings-dialog.c:
1552 (modest_account_settings_dialog_set_account_name),
1553 (save_configuration): For the incoming secure authentication checkbox,
1554 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1555 the UI specification. PLAIN does not seem to be supported for most IMAP
1556 servers anyway, and I am not sure what it would mean.
1557 However, we probably need to discover which of the secure-authentication
1558 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1559 * src/modest-account-mgr-helpers.c:
1560 (modest_account_mgr_get_server_account_data):
1562 * src/modest-tny-account.c:
1563 (modest_tny_account_new_from_server_account):
1564 Use tny_account_set_mech() to set secure-authentication methods,
1565 with some special-casing for IMAP, based on my observations of how
1568 * src/modest-account-mgr-helpers.h:
1569 * src/modest-account-mgr.c:
1570 * src/modest-defs.h: Comment that the URI is only used for local folders.
1572 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1574 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1575 parameter const, just to be neat.
1576 * src/modest-text-utils.c: (modest_text_utils_inline):
1577 End g_strconcat() with NULL, as its documentation says. This is almost
1578 certainly the cause of my crash at startup on the device. Interestingly,
1579 valgrind doesn't tell us about these errors.
1581 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1583 * scripts/build-packages: Added more precise comments about how to use
1584 this script, though I still get this error:
1585 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1586 error building tinymail
1588 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-main-window.c: (on_account_update):
1591 Very slight cleanup, hoping to make it simpler to discover what causes
1592 a crash here sometimes.
1594 * src/modest-tny-account.c:
1595 (modest_tny_account_new_from_server_account): Set the port. Added
1596 comments about the options and a TODO comment because I need to find out
1597 how to specify the secure authentication method.
1599 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1601 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1602 changed CFlags paths form modest to libmodest
1604 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-account-mgr-helpers.c:
1607 (modest_account_mgr_get_server_account_data),
1608 (modest_account_mgr_free_server_account_data):
1609 * src/modest-account-mgr-helpers.h:
1610 * src/modest-account-mgr.c:
1611 (modest_account_mgr_add_server_account):
1612 * src/modest-defs.h:
1613 * src/modest-tny-account.c:
1614 (modest_tny_account_new_from_server_account):
1615 Determine the options for tny_camel_account_add_option() here,
1616 based on the settings, rather than storing them directly in gconf.
1618 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1620 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1621 Show a more friendly error dialog now that we expect (from the tinymail
1622 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1624 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/modest-main-window.c: (on_account_update): Check that
1627 account_name is not NULL, to prevent a crash at startup that I am
1628 seeing on the N800. I do wonder why it is NULL.
1630 * src/maemo/easysetup/modest-easysetup-wizard.c:
1631 (create_page_user_details):
1632 * src/maemo/modest-account-settings-dialog.c:
1633 (create_page_user_details), (create_page_outgoing):
1634 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1635 (modest_connection_specific_smtp_edit_window_init):
1636 * src/modest-ui-actions.c:
1637 (modest_ui_actions_on_password_requested):
1638 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1639 might do something useful with the on-screen keyboard.
1641 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1643 * src/maemo/modest-main-window.c: (on_account_update):
1644 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1645 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1647 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1649 * src/modest-tny-account-store.c: (on_account_changed):
1650 Correct the signature of this signal handler.
1652 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1655 Show a HildonNote instead of a GtkDialog for Maemo.
1657 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1659 * src/widgets/modest-account-view.h:
1660 * src/widgets/modest-account-view.c: (on_account_changed),
1661 (on_account_removed). Added a boolean flag, set/unset by
1662 modest_account_view_block_conf_updates(),
1663 modest_account_view_unblock_conf_updates() to prevent unnecessary
1664 updates, but this is not very useful because the gconf notifications are
1665 so delays (maybe only on Maemo Bora).
1666 So auto-updating is turned off, and these functions do an explicit
1667 update when necessary.
1668 However, something else is still doing too much work when adding/removing
1669 accounts, probably in another part of the application.
1671 * src/maemo/modest-account-view-window.c:
1672 (on_delete_button_clicked), (on_edit_button_clicked),
1673 (on_new_button_clicked): Use the new functions.
1675 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1677 * src/modest-account-mgr-helpers.c:
1678 (modest_account_mgr_set_first_account_as_default):
1679 Sort the list of names alphabetically-by-title, so we choose the first one
1681 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1682 alphabetically by the title.
1684 This fixes projects.maemo.org bug NB#56418 .
1686 * src/modest-account-mgr-priv.c:
1687 (_modest_account_mgr_account_from_key):
1688 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1689 avoid a valgrind error, and possible random behaviour.
1691 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1694 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1695 tinymail documentation to say that this can be expected.
1696 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1697 pretty, and should not happen, but I would prefer to know when it does.
1699 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1701 * configure.ac: When using the older hildon version, probably on Bora,
1702 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1704 * src/widgets/modest-attachment-view.c:
1705 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1708 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1710 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1711 Implemented the prototype. Can be tested with
1712 tests/dbus_api/test_open_message:
1714 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1716 * src/modest-tny-account-store.c:
1717 (modest_tny_account_store_instance_init), (get_password):
1718 * src/modest-ui-actions.c:
1719 (modest_ui_actions_on_password_requested):
1720 Do not store the password in gconf, because this function is called
1721 for non-remembered passwords. Actually use the cached (in the hash map)
1722 password instead of releasing it.
1723 The password will now not be remembered if it is asked via the protected
1724 password dialog, as per the UI spec.
1726 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1728 * src/modest-defs.h:
1729 * src/modest-account-mgr-helpers.h:
1730 * src/modest-account-mgr-helpers.c:
1731 Added modest_server_account_get_username_has_succeeded(),
1732 modest_server_account_set_username_has_succeeded().
1733 (modest_server_account_set_username),
1734 Reset the has-succeeded flag if the username changes.
1736 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1737 * src/maemo/modest-connection-specific-smtp-window.c:
1738 (modest_connection_specific_smtp_window_save_server_accounts):
1739 Use modest_server_account_set_username() instead of using
1740 modest_conf_set_string() directly, so that the has-succeeded flag is always
1743 * src/modest-ui-actions.c:
1744 (modest_ui_actions_on_password_requested): Dim the username entry if
1745 the username has ever worked, as per the UI spec.
1747 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1749 * src/modest-tny-account-store.c: (get_password):
1750 * src/modest-ui-actions.c:
1751 (modest_ui_actions_on_password_requested):
1752 Allow the username to be changed too, though there is more work to
1753 be done on exactly how this behaves.
1755 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-account-mgr-helpers.h:
1758 * src/modest-account-mgr-helpers.c:
1759 Added modest_account_mgr_get_display_name(),
1760 modest_server_account_get_username(),
1761 modest_server_account_set_username(),
1762 modest_server_account_set_password(),
1763 modest_server_account_get_hostname() functions so we do not need to
1764 use the conf API directly.
1766 * src/maemo/modest-main-window.c: (connect_signals):
1767 Actually connect ot the ModestAccountStore::request-password signal,
1768 so that we show the dialog when the password is requested by Tinymail,
1769 for isntance if it is empty.
1771 * src/modest-marshal.list:
1772 * src/modest-tny-account-store.c:
1773 (modest_tny_account_store_class_init), (get_password),
1774 (modest_tny_account_store_alert):
1775 * src/modest-tny-account-store.h:
1776 * src/modest-ui-actions.h:
1777 * src/modest-ui-actions.c:
1778 (modest_ui_actions_on_password_requested):
1779 Change the signal parameters, so it is obvious that we are providing
1780 the non human-readable server name, and receiving both the username
1781 and password, though changing of the username is not yet implemented.
1782 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1783 for the GNOME version.
1785 This should fix the projects.maemo.org bug NB#56209, though it does not
1786 work on Bora, because the gconf_client_get() for the password fails
1787 immediately after we save it with gconf_client_set().
1789 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1792 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1793 caused an undefined symbol error:
1794 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1796 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1798 * src/modest-tny-account-store.c:
1799 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1800 using a GError instead of a string message, so we can translate it in
1803 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1805 * src/maemo/modest-address-book.c:
1806 (modest_address_book_check_names):
1807 * src/maemo/modest-msg-view-window.c:
1808 (modest_msg_view_window_clipboard_owner_change):
1809 * src/modest-init.c: (modest_init_init_ui):
1810 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1811 (update_folders_cb), (modest_mail_operation_update_account):
1812 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1813 (modest_ui_actions_on_msg_attachment_clicked),
1814 (modest_ui_actions_on_msg_recpt_activated):
1815 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1816 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1817 (modest_msg_view_search_next):
1818 * src/widgets/modest-recpt-editor.c:
1819 (modest_recpt_editor_on_button_release_event),
1820 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1821 g_message(). At this point we should only be seeing interesting errors on
1822 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1824 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1826 (modest_wizard_dialog_force_title_update):
1827 * src/maemo/easysetup/modest-wizard-dialog.h:
1828 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1829 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1830 can update the title when appropriate. Otherwise the title is wrong if the
1831 pages are added after adding the notebook to the dialog.
1832 This must be a problem in HildonWizardDialog too.
1833 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1835 * src/maemo/easysetup/modest-easysetup-wizard.c:
1836 (create_subsequent_customsetup_pages),
1837 (create_subsequent_easysetup_pages):
1838 Call modest_wizard_dialog_force_title_update() so that the title is
1839 correct even with GTK+ < 2.10.
1840 This fixes projects.maemo.org bug NB#56145 .
1842 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1844 * src/maemo/modest-platform.c:
1845 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1846 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1849 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1851 * src/widgets/modest-window.h:
1852 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1853 and modest_window_save_state(), which invokes it.
1855 * src/widgets/modest-window-mgr.h:
1856 * src/widgets/modest-window-mgr.c:
1857 Added modest_window_mgr_save_state_for_all_windows(), which calls
1858 the save_state vfunc on all registered windows, if implemented.
1860 * src/gnome/modest-msg-edit-window.c:
1861 * src/gnome/modest-msg-view-window.c:
1862 * src/maemo/modest-msg-edit-window.c:
1863 * src/maemo/modest-msg-view-window.c:
1864 * src/maemo/modest-main-window.c:
1865 Specify the existing save_settings functions as implementations of
1866 ModestWindow::save_state_func().
1868 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1869 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1870 enabling hibernation, for instance.
1872 We may need to do the same thing for restoring settings.
1875 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1877 * src/widgets/modest-window-mgr.c:
1878 * src/widgets/modest-window-mgr.h:
1879 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1880 modest_window_mgr_get_hibernation_is_prevented().
1882 * src/maemo/modest-main-window.c:
1883 (on_hildon_program_is_topmost_notify): Prevent hibernation
1884 (possible when the application goes to the background in the WM),
1885 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1887 * src/maemo/easysetup/modest-easysetup-wizard.c:
1888 (modest_easysetup_wizard_dialog_init):
1889 * src/maemo/modest-account-settings-dialog.c:
1890 (modest_account_settings_dialog_init):
1891 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1892 (modest_connection_specific_smtp_edit_window_init):
1893 * src/maemo/modest-connection-specific-smtp-window.c:
1894 (modest_connection_specific_smtp_window_init):
1895 * src/maemo/modest-signature-editor-dialog.c:
1896 (modest_signature_editor_dialog_init):
1897 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1898 prevent hibernation while any of these account settings dialogs are open.
1900 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1902 * src/maemo/Makefile.am:
1903 * src/maemo/modest-osso-state-saving.c:
1904 * src/maemo/modest-osso-state-saving.h: Added
1905 modest_osso_load_state() and modest_osso_save_state() though they do
1906 nothing now. They should iterate through all the open windows and load/save
1908 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1909 save state when closing.
1911 * src/maemo/modest-main-window.c:
1912 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1913 Add a notification handler for the HildonProgram::is-topmost property,
1914 so we can allow hibernation when the application goes into the background.
1915 But we still need to detect when the accounts setup windows are open so
1916 we can stop hibernation when they are open.
1917 To do this, I also added the main window the HildonProgram. This might have
1918 other side-effects/benefits, and should maybe be done for other windows.
1920 * src/maemo/modest-osso-autosave-callbacks.h:
1921 * src/maemo/modest-osso-autosave-callbacks.c:
1922 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1923 though it does not do anything yet, and we might never need this to do
1924 anything. For instance, we already save drafts.
1926 * src/maemo/modest-platform.c: (modest_platform_init):
1927 Specify the libosso auto-save callback.
1929 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1931 * src/maemo/modest-platform.c:
1932 (modest_platform_set_update_interval):
1933 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1934 aparently stays valid between application instances, so we can use this
1935 to remove and reset it later. According to a maemo-developers email from
1938 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1940 * configure.ac: Depend on libalarm for Maemo.
1942 * src/dbus_api/modest-dbus-api.h:
1943 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1944 (on_send_receive), (modest_dbus_req_handler):
1945 Handle a SEND_RECEIVE D-Bus method.
1947 * libmodest-dbus-client/libmodest-dbus-client.c:
1948 (libmodest_dbus_client_send_and_receive):
1949 * libmodest-dbus-client/libmodest-dbus-client.h:
1950 Add C convenience functions for calling the new D-Bus method.
1952 * src/modest-platform.h:
1953 * src/gnome/modest-platform.c:
1954 * src/maemo/modest-platform.c:
1955 Added modest_platform_set_update_interval(), which uses the
1956 alarmd API on Maemo.
1957 (modest_platform_init),
1958 Call modest_platform_set_update_interval(), using a hard-coded
1959 interval for now (until the global settings dialog is implemented),
1960 though I am not sure that this makes sense yet.
1962 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1964 * src/dbus_api/modest-dbus-callbacks.c:
1965 (modest_osso_cb_hw_state_handler):
1966 * src/dbus_api/modest-dbus-callbacks.h:
1967 * src/maemo/modest-platform.c: (modest_platform_init):
1968 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1969 in case this has some effect on the ability for Maemo to ping the
1972 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1974 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1975 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1976 warning. It is probably a logic error, but I need to fix the build.
1978 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-account-mgr.h:
1981 * src/modest-account-mgr.c:
1982 (modest_account_mgr_account_names): Add a gboolean enabled_only
1983 parameter, so we can get lists of onlt the enabled accounts.
1985 (modest_account_mgr_add_account),,
1986 (modest_account_mgr_account_with_display_name_exists):
1987 * src/maemo/modest-msg-edit-window.c: (get_transports):
1988 * src/modest-account-mgr-helpers.c:
1989 (modest_account_mgr_set_first_account_as_default):
1990 * src/modest-init.c: (init_default_account_maybe):
1991 * src/modest-tny-account-store.c: (get_accounts):
1992 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1993 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1994 * tests/check_account-mgr.c: (START_TEST):
1995 Provide the extra parameter, as appropriate.
1997 * src/widgets/modest-account-view.c: (update_account_view):
1998 Do not show disabled accounts (meaning that there is no way to
1999 enable/disable accounts in the UI (the feature is not in our UI
2000 specification), so we can use this internally only to mark unfinished
2001 or temporary account data.
2003 * src/maemo/easysetup/modest-easysetup-wizard.c:
2004 (create_account): Add boolean enable parameter, so we can specify FALSE
2005 to create the temporary account.
2006 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2007 (on_before_next): When finishing, when there is a temporary account, just
2009 Also, use a timeout to delay the showing of the dialog until gconf is likely
2010 to return correct information, due to a maemo gconf bug that is fixed in
2011 osso 1.1, but not yet in Bora.
2012 However, the dialog stays on screen after it is destroyed.
2014 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2015 for invalid data when cancelling. Use a hildon note instead of a dialog
2016 to complain about invalid data. Do not show the account-saved note if the
2017 account is disabled (a temporary account that will not really be saved for use
2020 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-account-mgr-helpers.h:
2023 * src/modest-account-mgr-helpers.c:
2024 Added modest_account_mgr_unset_default_account(),
2025 Added modest_account_mgr_set_first_account_as_default().
2027 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2028 If it was the default account, unset the default account name.
2030 * src/maemo/modest-account-view-window.c:
2031 (on_delete_button_clicked): If it was the default account,
2032 set the first remaining account as the default instead.
2034 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2035 a NULL account or a NULL default account, to prevent a crash. This should
2036 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2039 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2041 * src/widgets/modest-recpt-editor.c:
2042 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2043 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2044 TODO comment for this. This fixes the build.
2046 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2047 be the best place for it. This will in future update all auto-update accounts,
2048 rather than just the current/default account, when that gconf key exists.
2049 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2050 if there are no accounts, before calling do_send_receive().
2051 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2053 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2054 * src/maemo/modest-main-window-ui.h:
2055 * src/maemo/modest-main-window.c: (on_connection_changed),
2056 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2057 directly, becaue the signal handler does more.
2059 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2061 * src/modest-account-mgr-helpers.c:
2062 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2063 for the case that the account does not exist.
2065 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2066 (equivalent to the modest account name) rather than the tinymail account name
2067 (equivalent to the modest account title - human readable) to get the account data.
2068 Check for null account data to prevent the crash, and add a TODO comment saying that
2069 this needs fixing because it is using the server account name instead of the account name.
2071 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2073 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2074 * src/maemo/modest-account-settings-dialog.c: (show_error),
2076 Use hildon_note_new_information() for informative and error messages,
2077 which seems to be expected for Maemo applications (no documentation that I know of
2078 says this). I am surprised that there is no distinction between info and error
2081 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2083 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2084 it is easy to find where this is used.
2086 * src/maemo/easysetup/modest-easysetup-wizard.c:
2087 (create_page_welcome), (create_page_account_details),
2088 (create_page_user_details), (create_page_complete_easysetup),
2089 (create_page_custom_incoming), (create_page_custom_outgoing),
2090 (create_page_complete_custom):
2091 * src/maemo/modest-account-settings-dialog.c:
2092 (create_page_account_details), (create_page_user_details),
2093 (create_page_incoming), (create_page_outgoing):
2094 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2095 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2096 (modest_connection_specific_smtp_edit_window_init):
2097 * src/maemo/modest-connection-specific-smtp-window.c:
2098 (modest_connection_specific_smtp_window_init):
2099 * src/maemo/modest-signature-editor-dialog.c:
2100 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2101 and scrolling policy as per the Email Application Layout Guide, if I have
2104 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2106 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2107 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2108 which were empty, because these vfuncs have been removed from TnyAccountStore.
2109 This fixes the build.
2111 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2113 * src/maemo/modest-main-window.c:
2114 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2115 showing/hiding it. Added TODO because it probably should not be NULL.
2116 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2117 because unnecessary g_warnings() make degugging difficult.
2119 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2121 * src/maemo/modest-msg-edit-window.c:
2122 (modest_msg_edit_window_select_color),
2123 (modest_msg_edit_window_select_background_color): 2 const corrections and
2124 moving 2 #endifs before closing brackets, to fix the build.
2126 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2128 * src/maemo/easysetup/modest-easysetup-wizard.h:
2129 * src/maemo/easysetup/modest-easysetup-wizard.c:
2130 (modest_easysetup_wizard_dialog_finalize),
2131 (on_button_edit_advanced_settings), (create_page_complete_custom),
2132 (on_response), (create_account):
2133 Implement the Advanced Settings edit button, by saving the account information,
2134 for the Advanded Settings dialog to use directly from gconf, and removing it
2135 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2136 Bug #5533 in the projects.maemo.org bugzilla.
2138 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-msg-view-window.c:
2141 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2142 when opening a message window.
2144 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/easysetup/modest-easysetup-wizard.c:
2147 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2150 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2151 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2152 gconf settings. I probably added more checks than necessary, but that is safer.
2154 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2155 variable to fix the build, but this seems to be used when it is still NULL.
2157 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2159 * src/modest-platform.h:
2160 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2161 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2162 * src/modest-main.c: Implement this function so we can avoid using
2163 maemo-specific API from cross-platform code.
2165 * src/modest-tny-account-store.c:
2166 (get_smtp_specific_transport_account_for_open_connection):
2167 * src/modest-ui-actions.c: (check_for_connection),
2168 (modest_ui_actions_on_item_not_found):
2169 Use modest_platform_connect_and_wait() and put #idefs around other
2170 maemo-specific code, because only maemo currently has a way to
2171 identify connection names.
2173 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2175 * src/modest-tny-account-store.h:
2176 * src/modest-tny-account-store.c:
2177 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2178 the connection-specific SMTP server settings in the configuration.
2180 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2182 * src/maemo/modest-main-window.c: (on_connection_changed),
2184 * src/modest-main.c: (main), (start_ui), (send_mail):
2185 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2186 that is what is intended.
2188 * src/modest-ui-actions.c: (action_send), (action_receive),
2189 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2190 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2191 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2192 SMTP server is used when it is specified.
2194 (modest_ui_actions_on_send_receive):
2195 Check that a connection is open before proceeding.
2196 Receive and then send, instead of vice-versa, as per the specification.
2198 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2200 * src/modest-mail-operation.c:
2201 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2202 though I guess it should be something other than NULL.
2204 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/easysetup/modest-easysetup-wizard.c:
2207 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2208 combo twice, to avoid an g_warning and to make it visible again.
2209 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2210 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2211 (already intended) dereference when detaching, because we then recreate the menu.
2212 But I am not sure why the warning was happening, and it is possible that this is a memory
2215 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2217 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2218 and uri_parse_mailto() utility functions.
2219 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2221 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2223 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2225 * src/dbus_api/modest-dbus-api.h:
2226 * src/dbus_api/modest-dbus-callbacks.c:
2227 Use an idle callback to execute the modest code in the application's own thread.
2228 Remove the helloworld example method.
2229 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2230 parsed, and the open-message method is not implemented because this is not yet implemented in
2232 * libmodest-dbus-client/libmodest-dbus-client.c:
2233 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2234 (libmodest_dbus_client_open_message):
2235 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2237 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2238 body without crashing.
2240 * tests/dbus_api/Makefile.am:
2241 * tests/dbus_api/test_mail_to.c:
2242 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2244 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2246 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2247 Added file to fix the build. Sorry.
2249 * src/dbus_api/Makefile.am:
2250 * src/dbus_api/modest-dbus-api.h:
2251 * src/dbus_api/modest-dbus-callbacks.h:
2252 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2253 (modest_dbus_req_handler):
2254 Put constants in a separate header so it can be reused by the
2255 client library, without duplication
2257 * libmodest-dbus-client/Makefile.am:
2258 * libmodest-dbus-client/libmodest-dbus-client.c:
2259 (libmodest_dbus_client_call_helloworld),
2260 (libmodfest_dbus_client_send_mail),
2261 (libmodfest_dbus_client_mailto),
2262 (libmodfest_dbus_client_open_message):
2263 * libmodest-dbus-client/libmodest-dbus-client.h:
2264 (Partly) Implement a send_mail D-Bus method.
2266 * tests/dbus_api/Makefile.am:
2267 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2268 the send_email D-Bus method.
2270 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2274 * libmodest-dbus-client/Makefile.am:
2275 * libmodest-dbus-client/libmodest-dbus-client.c:
2276 * libmodest-dbus-client/libmodest-dbus-client.h:
2277 * tests/dbus_api/Makefile.am:
2278 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2279 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2281 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/easysetup/modest-easysetup-wizard.c:
2284 (create_page_account_details):
2285 * src/maemo/modest-account-settings-dialog.c:
2286 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2287 widgets, because this might not be the default in future versions of the Maemo GTK+.
2288 However, I can not not get capitalization to work even in a simple test case.
2290 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/easysetup/modest-easysetup-wizard.c:
2293 (create_page_custom_incoming), (create_page_custom_outgoing):
2294 * src/maemo/modest-account-settings-dialog.c:
2295 (create_page_account_details), (create_page_incoming),
2296 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2297 instead of using gtk_check_button_with_label(), so they are aligned like the other
2298 widgets, as per the UI spec.
2300 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2302 * src/maemo/easysetup/modest-easysetup-wizard.c:
2303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2304 * src/widgets/modest-validating-entry.c:
2305 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2306 Modest prefix instead of an EasySetup prefix.
2308 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2310 * src/widgets/modest-validating-entry.h:
2311 * src/widgets/modest-validating-entry.c: (on_insert_text),
2312 Added easysetup_validating_entry_set_max_func(), used to set a callback
2313 to call when the max number of characters is reached. GtkEntry has a max-length
2314 already but is silent about it.
2316 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2317 (create_page_account_details), (create_page_user_details),
2319 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2320 (create_page_account_details), (create_page_user_details),
2321 (create_page_outgoing):
2322 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2323 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2324 the UI spec, when the user tries to enter more than the max number of characters.
2326 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/easysetup/modest-easysetup-wizard.c:
2329 (create_page_user_details), (create_page_custom_incoming),
2330 (create_page_custom_outgoing):
2331 * src/maemo/modest-account-settings-dialog.c:
2332 (create_page_user_details), (create_page_incoming),
2333 (create_page_outgoing):
2334 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2335 (modest_connection_specific_smtp_edit_window_init):
2336 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2337 not appropriate. Bad Maemo-specific defaults!.
2339 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2341 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2342 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2343 (modest_signature_editor_dialog_set_settings):
2344 Disable the label and textview when the checkbox is disabled, and use the
2345 specified (UI spec) default signature text.
2347 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2350 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2352 * src/modest-defs.h:
2353 * src/modest-account-mgr-helpers.h:
2354 * src/modest-account-mgr-helpers.c:
2355 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2357 * src/maemo/Makefile.am:
2358 * src/maemo/modest-signature-editor-dialog.c:
2359 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2362 * src/maemo/modest-account-settings-dialog.h:
2363 * src/maemo/modest-account-settings-dialog.c:
2364 (modest_account_settings_dialog_finalize), (on_button_signature),
2365 (save_configuration): Use the new dialog when the Edit button is pressed, and
2366 save the changes if necessary, as per the UI spec.
2368 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2370 * src/maemo/Makefile.am:
2371 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2372 based on maemo-develoers email from Dirk.
2374 * src/maemo/easysetup/modest-easysetup-wizard.c:
2375 (create_page_welcome), (create_page_account_details),
2376 (create_page_user_details), (create_page_complete_easysetup),
2377 (create_page_custom_incoming), (create_page_custom_outgoing),
2378 (create_page_complete_custom),
2379 (modest_easysetup_wizard_dialog_init):
2380 * src/maemo/modest-account-settings-dialog.c:
2381 (create_page_account_details), (create_page_user_details),
2382 (create_page_incoming), (create_page_outgoing),
2383 (modest_account_settings_dialog_init):
2384 * src/maemo/modest-connection-specific-smtp-window.c:
2385 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2387 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/easysetup/modest-easysetup-wizard.c:
2390 (create_page_account_details), (create_page_custom_outgoing),
2391 (create_page_complete_custom):
2392 * src/maemo/modest-account-settings-dialog.c:
2393 (create_page_user_details), (create_page_incoming),
2394 (create_page_outgoing):
2395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2396 (modest_connection_specific_smtp_edit_window_init):
2397 Use the correct (UI spec) port min/max, and use horizontal separators,
2400 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/easysetup/modest-easysetup-wizard.c:
2403 (set_default_custom_servernames):
2404 * src/maemo/modest-account-settings-dialog.c:
2405 (create_page_incoming), (on_combo_outgoing_security_changed),
2406 (on_combo_incoming_security_changed), (create_page_outgoing),
2407 (modest_account_settings_dialog_set_account_name),
2408 (save_configuration):
2409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2410 (on_combo_security_changed),
2411 (modest_connection_specific_smtp_edit_window_init),
2412 (modest_connection_specific_smtp_edit_window_set_connection),
2413 (modest_connection_specific_smtp_edit_window_get_settings):
2414 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2417 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2420 * src/maemo/easysetup/modest-easysetup-wizard.c:
2421 (create_page_custom_outgoing), (create_page_complete_custom):
2422 * src/maemo/modest-account-settings-dialog.c:
2423 (create_page_user_details), (create_page_outgoing):
2424 * src/maemo/modest-account-view-window.c: (button_box_new):
2425 Use changed logical IDs as per the most recent UI spec:
2426 mcen_bd_emailsetup_edit -> mcen_bd_edit
2427 mcen_bd_emailsetup_delete -> mcen_bd_delete
2428 mcen_bd_emailsetup_close -> mcen_bd_close
2430 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2434 * src/dbus_api/Makefile.am:
2435 * src/dbus_api/modest-dbus-callbacks.c:
2436 * src/dbus_api/modest-dbus-callbacks.h:
2437 * src/maemo/modest-platform.c: (modest_platform_init):
2438 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2440 * tests/Makefile.am:
2441 * tests/dbus_api/Makefile.am:
2442 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2444 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2446 * src/maemo/modest-account-settings-dialog.c:
2447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2448 Removed unnecessary includes.
2450 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2452 * src/maemo/easysetup/modest-easysetup-wizard.c:
2453 * src/maemo/modest-account-settings-dialog.c:
2454 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2455 * src/widgets/Makefile.am:
2456 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2457 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2458 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2459 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2460 * src/widgets/modest-secureauth-combo-box.c:
2461 * src/widgets/modest-secureauth-combo-box.h:
2462 * src/widgets/modest-serversecurity-combo-box.c:
2463 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2464 made the GObject names more consistent with the rest of the Modest code.
2466 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/easysetup/Makefile.am:
2469 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2470 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2471 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2472 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2473 * src/maemo/easysetup/modest-easysetup-wizard.c:
2474 * src/maemo/easysetup/modest-validating-entry.c:
2475 * src/maemo/easysetup/modest-validating-entry.h:
2476 * src/maemo/modest-account-settings-dialog.c:
2477 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2478 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2479 widgets/ because they are used outside of easysetup too. After checking in,
2480 svn will allow me to rename them too.
2482 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2484 * src/gnome/modest-msg-edit-window.c:
2485 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2486 linker error, to fix the build on the GNOME platform.
2487 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2488 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2489 ifdefed out to avoid a warning.
2491 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2493 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2494 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2495 some alternative for GTK+ 2.6.
2497 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2499 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2501 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2502 specified for EmailAccountsDialog in UI spec.
2504 * src/maemo/easysetup/modest-easysetup-wizard.c:
2505 * src/maemo/easysetup/modest-easysetup-wizard.h:
2506 * src/maemo/modest-account-settings-dialog.c:
2507 * src/maemo/modest-account-settings-dialog.h:
2508 Reuse a member window widget for the connection-specific SMTP server accounts,
2509 so we can tell it to create/save the accounts only if we actually save changes.
2511 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2512 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2513 (modest_connection_specific_smtp_edit_window_get_settings):
2514 Return a struct instance for temporarily remembering the entered data.
2516 * src/maemo/modest-connection-specific-smtp-window.h:
2517 * src/maemo/modest-connection-specific-smtp-window.c:
2518 (modest_connection_specific_smtp_window_finalize),
2519 (modest_connection_specific_smtp_window_fill_with_connections),
2521 (modest_connection_specific_smtp_window_save_server_accounts),
2522 (update_model_server_names): Do not actually save data until asked,
2523 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2525 (on_selection_changed),
2526 (modest_connection_specific_smtp_window_init): Disable the edit
2527 button when nothing is selected.
2529 * src/modest-account-mgr-helpers.c:
2530 * src/modest-account-mgr-helpers.h:
2531 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2534 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2536 * src/modest-account-mgr-helpers.h:
2537 * src/modest-account-mgr-helpers.c:
2538 (modest_account_mgr_get_unused_account_name),
2539 (modest_account_mgr_get_unused_account_display_name): Added these
2540 utility functions, to avoid code duplication.
2542 * src/maemo/easysetup/modest-easysetup-wizard.c:
2543 (create_page_account_details), (create_account):
2544 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2545 (on_combo_security_changed),
2546 (modest_connection_specific_smtp_edit_window_init),
2547 (modest_connection_specific_smtp_edit_window_save_settings):
2548 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2549 * src/maemo/modest-connection-specific-smtp-window.c:
2550 (modest_connection_specific_smtp_window_finalize),
2551 (modest_connection_specific_smtp_window_fill_with_connections),
2552 (on_button_edit), (modest_connection_specific_smtp_window_init):
2553 * src/maemo/modest-connection-specific-smtp-window.h:
2554 Implementing saving of connection-specific server accounts.
2556 But I need to refactor this so we can save the data for each
2557 possible connection-specific account and only actually create the server accounts
2558 when the easysetup finished, or the OK button is pressed on the account settings
2561 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2563 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2564 (on_combo_security_changed):
2565 (modest_connection_specific_smtp_edit_window_init):
2566 Auto-fill the port number as in the account settings.
2568 (modest_connection_specific_smtp_edit_window_set_connection):
2569 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2570 * src/maemo/modest-connection-specific-smtp-window.c:
2571 (fill_with_connections), (on_button_edit),
2572 (modest_connection_specific_smtp_window_init):
2573 Turn the edit window into a dialog to simplify the code, and
2574 set a WM hint as in a GtkDialog, because only a popup can be on top of
2575 another window in Maemo, and popups usually have no WM decoration.
2577 * src/modest-defs.h:
2578 * src/modest-account-mgr-helpers.c:
2579 (modest_account_mgr_set_connection_specific_smtp),
2580 (modest_account_mgr_remove_connection_specific_smtp),
2581 (modest_account_mgr_get_connection_specific_smtp):
2582 * src/modest-account-mgr-helpers.h: Some functions to write the
2583 connection-specific SMTP server information. Not yet used.
2586 * src/widgets/modest-folder-view.c: (text_cell_data):
2587 Fix a warning about an uninitialized variable.
2588 (on_configuration_key_changed): Put an #ifdef around the use
2589 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2591 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2593 * src/maemo/modest-account-settings-dialog.h:
2594 * src/maemo/modest-account-settings-dialog.c:
2595 Added connect_for_modified() utility function to mark the new modified boolean.
2597 (create_page_account_details), (create_page_user_details),
2598 (create_page_incoming), (create_page_outgoing), (on_response),
2599 (modest_account_settings_dialog_init),
2600 (modest_account_settings_dialog_set_account_name):
2601 Only warn about unsaved changes when there are actually unsaved changes.
2603 * src/modest-account-mgr-helpers.c:
2604 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2605 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2606 to get the data from there in future.
2608 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2610 * src/modest-defs.h:
2612 * src/modest-account-mgr-helpers.h:
2613 * src/modest-account-mgr-helpers.c:
2614 Store the security account setting in a single conf key instead of using
2615 the options list, so that the list is left for just the to-be-removed camel hack,
2616 and because gconf_client_set_list() is failing for some reason.
2618 * src/modest-account-mgr.c:
2619 (modest_account_mgr_add_server_account):
2620 * src/maemo/modest-account-settings-dialog.c:
2621 (modest_account_settings_dialog_set_account_name),
2622 (save_configuration): Use the renamed functions.
2625 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2627 * src/widgets/Makefile.am:
2628 * src/widgets/modest-limit-retrieve-combo-box.c:
2629 * src/widgets/modest-limit-retrieve-combo-box.h:
2630 * src/widgets/modest-retrieve-combo-box.c:
2631 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2632 the account settings dialog.
2634 * src/modest-defs.h:
2635 * src/modest-account-mgr-helpers.h:
2636 * src/modest-account-mgr-helpers.c:
2637 (modest_server_account_get_option_secure_auth),
2638 (modest_server_account_set_option_secure_auth):
2639 * src/modest-account-mgr.c:
2640 (modest_account_mgr_add_server_account):
2641 Use the existing AUTH_MECH conf key for the secure-auth setting,
2642 instead of putting it in the list options, because this was actually used already.
2644 * src/maemo/modest-account-settings-dialog.c:
2645 (create_page_account_details),
2646 (modest_account_settings_dialog_set_account_name),
2647 (save_configuration):
2648 * src/maemo/modest-account-settings-dialog.h:
2649 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2650 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2652 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2654 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2655 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2656 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2658 * src/modest-defs.h:
2659 * src/maemo/modest-account-settings-dialog.c:
2660 (create_page_incoming), (on_combo_outgoing_security_changed),
2661 (on_combo_incoming_security_changed), (create_page_outgoing),
2662 (modest_account_settings_dialog_set_account_name),
2663 (save_configuration): Load/Save the port number, and change it when the
2664 security combo changes, to suitable defaults.
2666 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2668 * src/modest-account-mgr.c:
2669 (modest_account_mgr_add_server_account): Set the security and secure-auth
2670 options, and add a comment saying that the other camel-specific options should be
2673 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2675 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2677 * src/modest-tny-account-store.c: (account_list_free),
2678 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2679 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2682 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-protocol-info.c:
2685 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2686 is required by our UI spec. Maybe something in our implementation will use this eventually.
2687 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2688 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2689 instead of the previous 0 placeholder.
2691 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2692 secure-auth settings.
2693 * src/modest-account-mgr-helpers.h:
2694 * src/modest-account-mgr-helpers.c:
2695 (modest_server_account_data_get_option_secure_auth),
2696 (modest_server_account_set_option_secure_auth),
2697 (modest_server_account_data_get_option_security),
2698 (modest_server_account_set_option_security): Added this API for getting and setting the security
2699 and secure-auth settings.
2701 * src/maemo/modest-account-settings-dialog.h:
2702 * src/maemo/modest-account-settings-dialog.c:
2703 (modest_account_settings_dialog_finalize), (check_data),
2704 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2705 about changing titles.
2706 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2707 (save_configuration): Save the security and secure-auth settings.
2709 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2710 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2712 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2714 * src/modest-defs.h:
2715 * src/modest-account-mgr.c:
2716 (modest_account_mgr_add_server_account):
2717 Added and used defines for the options key and value pair strings,
2718 that are used so far, though they do not seem to correspond to anything in our
2719 UI specs or ModestProtocol enum.
2721 * src/modest-account-mgr-helpers.h:
2722 * src/modest-account-mgr-helpers.c:
2723 (compare_option_strings_for_name),
2724 (modest_server_account_data_get_option_value),
2725 (modest_server_account_data_get_option_bool),
2726 (modest_account_mgr_get_server_account_option):
2727 Added helper functions for parsing the options GSList.
2729 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2731 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2732 display name is based on the supplied account name.
2733 * src/modest-account-mgr.c:
2734 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2735 with an inefficient, but good-enough, implementation.
2737 * src/maemo/easysetup/modest-easysetup-wizard.c:
2738 (create_page_account_details), (on_before_next), (create_account):
2739 Check for existing display names rather than (non-user-visible) account names, and just
2740 create and set a unique account name at the end.
2742 * src/maemo/modest-account-settings-dialog.c:
2743 (modest_account_settings_dialog_init),
2744 (modest_account_settings_dialog_set_account_name),
2745 (create_page_incoming): Show the display name, instead of the account name.
2746 (on_response): Do some (not all) extra checks, as in the UI spec.
2747 (save_configuration): Save the display name if it was changed.
2749 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2751 * po/en_GB.po: Added needed logical ID and translation.
2752 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2753 (init_view): Made the is-default column clicking work.
2755 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2758 * src/maemo/easysetup/Makefile.am:
2759 * src/maemo/easysetup/modest-easysetup-wizard.c:
2760 (modest_easysetup_wizard_dialog_init):
2761 * src/maemo/easysetup/provider-data-test.keyfile:
2762 * src/maemo/easysetup/provider-data.keyfile:
2763 Moved the provider data file to the new modest-providers-data package and used it from there.
2765 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2767 * src/modest-local-folder-info.c:
2768 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2769 N_() was already used on the static strings, but this just marks it for translation without
2770 using the translation.
2772 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/modest-account-settings-dialog.c:
2775 (create_page_incoming),
2776 (modest_account_settings_dialog_set_account_name):
2777 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2778 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2779 I will do this if nobody else gets there first.
2781 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2783 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2784 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2785 save the security stuff.
2787 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2789 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2790 Set the email address and user fullname, which I now see must be
2793 * src/maemo/modest-account-settings-dialog.h:
2794 * src/maemo/modest-account-settings-dialog.c:
2796 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2797 leave-on-server and authentication.
2798 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2801 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2804 * src/maemo/modest-account-settings-dialog.c:
2805 * src/maemo/modest-account-settings-dialog.h:
2806 Most (but not all) of the widgets are now present as specified by the UI spec.
2807 No changes are yet saved, and some details are not properly shown yet.
2809 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2811 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2813 * src/maemo/Makefile.am:
2814 * src/maemo/modest-account-settings-dialog.c:
2815 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2816 an existing account. Doesn't do much yet.
2818 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2819 Open the accounts settings dialog when Edit is clicked.
2821 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2823 * src/maemo/easysetup/Makefile.am:
2824 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2826 * src/maemo/easysetup/modest-easysetup-wizard.c:
2827 (modest_easysetup_wizard_dialog_init):
2828 Try to get the source directory from the build system,
2829 instead of hard-coding "./" into the source code, when opening our local
2830 copies of the configuration files.
2831 But this still fails when opening the wizard from the Accounts window,
2832 maybe because the working directory seems to change at runtime.
2833 So the wizard will fail the second time unless you copy the files into their
2834 proper locations - see the stdout warnings for the paths.
2836 (create_page_account_details),(on_before_next):
2837 Check for existing non-server accounts instead of server accounts,
2838 so the default account name is useful again, and to prevent trying to
2841 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2842 Show the wizard when New is clicked.
2844 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2845 (init_view): Show the column headers, and show the columns that are
2846 specified in the UI specs. However, something in Maemo's GTK+ prevents
2847 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2848 change the default account. This is despite unsetting the special properties.
2850 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2852 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2853 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2854 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2855 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2856 to make that clearer.
2857 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2859 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2861 * src/maemo/modest-account-view-window.c:
2862 (modest_account_view_window_init),
2863 (modest_account_view_window_new):
2864 Use the same buttons as specified in the
2865 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2866 the existing widgets, which never had a chance of working.
2867 Put the ModestAccountView treeview in a scrolled window.
2868 Do not repeat the initialization in both _init() and _new().
2870 * src/widgets/modest-account-view.c: (update_account_view):
2871 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2872 this widget and window shows no accounts.
2874 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2876 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/easysetup/modest-easysetup-wizard.c:
2879 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2880 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2881 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2884 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2885 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2886 accounts exist yet, as in the UI spec.
2888 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2890 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2892 * src/maemo/Makefile.am:
2893 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2894 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2895 New window for editing connection-specific smtp details.
2896 Not fully implemented.
2898 * src/maemo/modest-connection-specific-smtp-window.c:
2899 (modest_connection_specific_smtp_window_finalize) :
2900 unref the tree model.
2901 (on_button_edit): Show the edit window.
2903 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2905 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2908 * src/maemo/Makefile.am:
2909 * src/maemo/modest-connection-specific-smtp-window.c:
2910 * src/maemo/modest-connection-specific-smtp-window.h:
2911 New window for showing the list of connections, for connection-specific
2912 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2913 * src/maemo/easysetup/modest-easysetup-wizard.c:
2914 (create_page_custom_outgoing): Show the new window when the button is clicked.
2916 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2918 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2919 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2920 * src/maemo/modest-msg-edit-window.c:
2921 (modest_msg_edit_window_insert_image):
2922 * src/modest-conf.c: (modest_conf_key_escape):
2923 * src/modest-mail-operation.c:
2924 (modest_mail_operation_send_new_mail):
2925 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2926 (modest_ui_actions_on_new_account):
2927 * src/widgets/modest-attachment-view.c: (update_filename_request):
2928 * src/widgets/modest-mail-header-view.c:
2929 Corrected warnings that were breaking the build, by commenting out unused variables,
2930 and a function, and by including a header.
2932 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2934 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2935 so we can #ifdef around platform-specific code when necessary.
2936 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2937 to allow this to build for the GNOME platform too.
2939 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2941 * src/maemo/easysetup/modest-easysetup-wizard.c:
2942 Added util_increment_name() and used it in create_page_account_details()
2943 to make sure that the default account name is always a new name.
2945 (modest_easysetup_wizard_dialog_init),
2946 (set_default_custom_servernames): Some minor memory management fixes.
2948 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2952 * src/modest-runtime.c: (init_i18n): Restored the translation
2953 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2954 are defined in config.h, and the translations are installed.
2956 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2957 is defined for translation.
2959 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2961 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2963 * src/maemo/easysetup/modest-easysetup-wizard.c:
2964 (modest_easysetup_wizard_dialog_init):
2965 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2966 Use realistic paths (though they should use $prefix generically) to the
2967 mcc_mapping and provider-data.keyfile files which might work when they
2968 are installed by the future version of the operator-wizard package,
2969 and then fallback to paths in our source code, with an explanatory
2972 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2976 * src/maemo/Makefile.am:
2977 * src/maemo/easysetup/: Added files from the previously-exernal
2978 osso-modest-easysetup.
2979 * src/maemo/modest-main-window-ui.h:
2980 * src/modest-ui-actions.c:
2981 * src/modest-ui-actions.h:
2982 Added modest_ui_actions_on_new_account() as a signal handler for the
2983 New Account menu item. It shows the easysetup wizard.
2984 * po/en_GB.po: Added additional needed logical IDs and translations.
2986 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2987 Apparently ChangeLog is not used for some vague Nokia legal reasons.