1 2007-08-17 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c:
4 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
5 because this is called from idle handlers, to fix hangs afte the
7 (find_message_by_url): Added a TODO comment about a crash that
8 happens when tinymail was built with DBC checks.
10 2007-08-16 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-search.c: (modest_search_folder):
13 * src/modest-search.h: Rename ModestSearch::before to start_date
14 and after to end_date, using the same names as the libogs struct
16 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
17 The start_date and end_date were swapped in the check. This
18 fixes date range searches, fixing projects.maemo.org bug NB#63407.
20 2007-08-16 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-account-view-window.c:
23 Added (check_for_active_acount).
24 (on_delete_button_clicked), (on_edit_button_clicked):
25 When an account is doing something (such as refreshing),
26 show the same warning for account deletion as for account
27 editing, to fix projects.maemo.org bug NB#64588.
29 2007-08-16 Murray Cumming <murrayc@murrayc.com>
31 * src/widgets/modest-msg-view-window.h:
32 * src/gnome/modest-msg-view-window.c:
33 * src/maemo/modest-msg-view-window.c:
34 Added modest_msg_view_window_construct().
35 (modest_msg_view_window_new_with_header_model),
36 Added modest_msg_view_window_new_for_search_result),
37 Renamed modest_msg_view_window_new() to
38 modest_msg_view_window_new_for_attachment(),
39 and modest_msg_view_window_is_search_result(),
40 so we can explicitly know that the window is for an
41 attachment or a search result or a message from the list.
43 (modest_msg_view_window_view_attachment):
44 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
45 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
46 Use modest_msg_view_window_new_for_search_result().
48 * src/modest-ui-dimming-rules.c:
49 (modest_ui_dimming_rules_on_delete_msg): Dim the delete button
50 for search results, fixing projects.maemo.org bug NB#63811.
52 2007-08-16 Armin Burgmeier <armin@openismus.com>
54 * src/modest-ui-actions.c: Show a banner instead of a dialog when
55 renaming a folder fails, to stay consistent with what happens when
56 creating a folder fails.
58 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
59 slightly country loading from the mmc_mappings file, fixed a memory
62 2007-08-16 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account-store.c: (volume_path_is_mounted):
65 Check the GnomeVFSVolume activation path instead of the device path,
66 so that the memory card is really really shown in the UI.
68 2007-08-16 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/easysetup/modest-easysetup-wizard.c:
71 (get_entered_account_title), (on_before_next), (entry_is_empty),
73 * src/maemo/modest-account-settings-dialog.c:
74 (get_entered_account_title), (on_button_signature), (check_data),
75 (save_configuration), (entry_is_empty):
76 Strip the account title of whitespace at the start and end before
77 using it or checking it. This means that an all-whitespace title
78 is not allowed, fixing projects.maemo.org bug NB#64977.
80 2007-08-15 Murray Cumming <murrayc@murrayc.com>
82 * src/modest-ui-actions.h:
83 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
84 to modest_run_account_setup_wizard() and made it public.
85 * src/dbus_api/modest-dbus-callbacks.c:
86 (check_and_offer_account_creation), (on_idle_mail_to),
87 (on_idle_compose_mail), (on_idle_open_default_inbox):
88 Offer account creation if necessary, fixing projects.maemo.org
91 2007-08-15 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-ui-actions.c: (run_account_setup_wizard):
94 Return a gboolean to indicate success.
95 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
96 (modest_ui_actions_on_send): When offering account creation, only
97 give up (return) if account creation failed. Otherwise continue
98 with the original request. This fixed projects.maemo.org bug
101 2007-08-15 Murray Cumming <murrayc@murrayc.com>
103 * src/widgets/modest-recpt-editor.c:
104 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
105 to fix projects.maemo.org bug NB#63789.
107 2007-08-15 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
110 (modest_tny_account_store_new): Properly detect the memory card at
111 startup, and add an account for it.
113 2007-08-14 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
116 Commented out the MMC code again because it mistakenly detects
117 the card even when it isn't inserted.
119 2007-08-14 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
122 Renabled the call to add_mmc_account() because I do not believe
123 it could be the cause of the mentioned hang (in scratchbox, where
124 there is no memory card), and because I have tested that it works
127 2007-08-14 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
130 Comment out part of the last commit because it apparently causes
133 2007-08-14 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-tny-account-store.c: Added the add_mmc_account()
136 function to save some copy/pasting.
137 (modest_tny_account_store_new): If the memory card is mounted,
138 create an account for it at the start, instead of waiting for the
139 user to unmount it and mount it.
141 2007-08-13 Murray Cumming <murrayc@murrayc.com>
143 * src/widgets/modest-account-view.c: (on_account_changed):
144 Do not try to use the human-readable TnyAccount name instead of the
145 ID of the modest account to get the transport account. And unref
146 the transport account. This prevents a g_warning(), and a possible
149 2007-08-13 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/modest-platform.c:
152 (modest_platform_set_update_interval): Handle the new
153 alarmd error to warn when alarmd is not running, as is the case in
154 scratchbox for me now because
155 "Module /usr/lib/alarmd/libretu.so initialization failed"
157 2007-08-13 Murray Cumming <murrayc@murrayc.com>
159 * src/widgets/modest-header-view-render.c:
160 (_modest_header_view_compact_header_cell_data):
161 NULL some strings after freeing them, trying to deal with
162 the double deletion found in projects.maemo.org bug 64183,
163 probably having no effect.
165 2007-08-13 Murray Cumming <murrayc@murrayc.com>
167 * src/maemo/modest-account-settings-dialog.c:
168 (create_page_incoming), (create_page_outgoing): Use a define
169 for the min and max port numbers.
171 (check_hildon_number_editor_and_warn_value_not_in_range),
172 (check_data): Do an extra check for an invalid port number, as needed
173 in projects.maemo.org bug #64275, when the number is cleared, but this
174 does not work due to bugs.maemo.org bug #1806.
176 2007-08-13 Murray Cumming <murrayc@murrayc.com>
178 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
179 Comment out the debug warning about the unexpected D-Bus methods.
180 They are just annoying now.
181 * src/maemo/modest-platform.c:
182 (modest_platform_set_update_interval): Correct the D-Bus path, instead
183 of using a file path, though it did not seem to break things before.
184 It might be needed now:
185 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
186 modest is not already running. This is the behaviour of the old client, and
187 Mox says it is what we should do for modest.
188 This closes projects.maemo.org bug NB#64327.
190 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
192 * src/modest-text-utils.c:
193 Fixed invalid jump due to incorrect string/pointer
195 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
198 2007-08-01 Murray Cumming <murrayc@murrayc.com>
200 * src/modest-account-mgr-helpers.h:
201 * src/modest-account-mgr-helpers.c:
202 Added modest_account_mgr_get_first_account_name(),
203 using code from modest_account_mgr_set_first_account_as_default().
205 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
206 (account_number_changed): Call set_at_least_one_account_visible() so that
207 the first account is visible when first added, without the user having to
209 I do wonder how this worked before.
211 2007-08-01 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-tny-account-store.c: (show_password_warning_only),
214 (show_wrong_password), (request_password_and_wait), (get_password),
215 (modest_tny_account_store_alert): Remove the (incomplete anyway)
216 attempts to show UI only in the main context, which used g_idle_add()
217 and mainloops, because tinymail now guarantees that it only calls these
218 callbacks in the mainloop with the gdk lock. This makes everything much
221 2007-08-01 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
224 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
225 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
226 error dialog, instead of ignoring it.
228 2007-08-01 Murray Cumming <murrayc@murrayc.com>
230 * src/maemo/modest-msg-view-window.c:
231 (modest_msg_view_window_get_header),
232 (modest_msg_view_window_last_message_selected):
233 Added comments to explain the use of priv->header_model.
234 * src/modest-ui-dimming-rules.c:
235 (modest_ui_dimming_rules_on_open_msg),
236 (modest_ui_dimming_rules_on_mark_as_read_msg),
237 (modest_ui_dimming_rules_on_mark_as_unread_msg),
238 (modest_ui_dimming_rules_on_remove_attachments),
239 (_invalid_attach_selected), (_selected_msg_marked_as):
240 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
241 and changed the parameter to a ModestMainWindow to make it clearer that
242 it never uses any other kind of window.
243 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
244 instead of the selected message.
245 I notice that much of the dimming code and the ModestMsgViewWindow code
246 hard-codes the assumption that the viewed message is always selected in
247 the header view. This does not seem wise or simple.
249 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
250 examine the actual message instead of whatever might be selected
251 in the header view. This stops the delete toolbar button and menu item
252 from being dimmed when opening a message view the search UI,
253 partially fixing projects.maemo.org bug NB#63811.
255 However, when actually deleting, I now get this warning:
256 "tny_header_set_flags: This is a header instance for a new message.
257 Only priority and attachment flags are supported"
259 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
261 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
263 Show account wizard if no accounts are defined while sending
264 (automatic sending after the account wizard finished does not
265 work because it takes some time until the account manager
266 synchronizes everything. (projects.maemo.org NB#62792)
268 2007-07-30 Murray Cumming <murrayc@murrayc.com>
270 * src/modest-tny-account-store.c: (on_account_removed),
271 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
272 account is removed from the View menu. We have TnyAccountStore
273 and ModestTnyAccountStore signals that seem very similar, but this
274 seems to work for now.
276 * src/maemo/modest-main-window.c:
277 (on_show_account_action_activated): Prevent dereference
278 of a NULL if the accoutn does not really exist, though that
279 should not happen anymore.
281 This fixes projects.maemo.org bug NB#64606.
283 2007-07-30 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-ui-actions.c: (run_account_setup_wizard),
286 (modest_ui_actions_on_accounts): Revert a change that set these
287 to modal dialogs, freezing the UI when they show secondary dialogs.
288 This fixed projects.maemo.org bug NB#64519.
290 2007-07-27 Murray Cumming <murrayc@murrayc.com>
292 * src/widgets/modest-header-view-render.c:
293 (_modest_header_view_compact_header_cell_data):
294 Some checks and initialization to try to deal with a crash,
295 probably ineffective.
297 2007-07-27 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/modest-maemo-utils.c:
300 (modest_maemo_utils_get_supported_secure_authentication_methods):
301 Make sure that we have a connection, asking the user for one
303 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
304 Check for a connection before showing the wizard, because
305 the wizard needs a connection to check for server capabilities.
307 2007-07-27 Murray Cumming <murrayc@murrayc.com>
309 * src/maemo/modest-account-view-window.c:
310 (on_new_button_clicked): Remember the wizard dialog instance,
311 so we can just present it again if necessary. This prevents
312 multiple windows from appearing if you click again quickly on the
313 New button before the dialog appears, fixing projects.maemo.org
316 2007-07-27 Murray Cumming <murrayc@murrayc.com>
318 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
319 Offer a connection dialog if there is no connection when
320 starting modest. This should fix projects.maemo.org bug NB#61134.
322 2007-07-27 Murray Cumming <murrayc@murrayc.com>
324 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
325 Reverted my last commit. I was able to fix the build by doing
326 apt-get install wpeditor0 (replacing other wpeditor packages) and
327 an explicit apt-get install wpeditor-dev to upgrade the -dev
330 2007-07-27 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
333 Commented out the use of wp_text_buffer_replace_image()
334 because it does not exist, to break the build. Added a TODO for it.
336 2007-07-26 Murray Cumming <murrayc@murrayc.com>
338 * src/modest-tny-account-store.c: (recreate_all_accounts):
339 Recreate them even if they were NULL before. I guess something
340 else was already creating them before, or this would never
342 (modest_tny_account_store_get_server_account): Make sure that
343 the tny accounts have been created before trying to find one.
344 This allows libmodest_dbus_client_compose_mail() to work
345 when the UI is not yet visible.
346 This is probably useful in other cases too.
348 (get_password): When the password is wrong after it is entered
349 in the protected password dialog, show an info banner (in an
350 idle handler) before showing the protected password dialog
353 2007-07-26 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-ui-actions.h:
356 * src/modest-ui-actions.c: Added
357 modest_do_refresh_current_folder() containing some code from
358 modest_ui_actions_on_send_receive().
359 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
360 Call modest_do_refresh_current_folder() before refreshing the
361 requested account, as in modest_ui_actions_on_send_receive().
362 This is strange, but seems to be necessary to show new mails.
363 Now new emails are finally visible in the UI when downloaded
364 via the automatic update interval, fixing bug NB#57458.
365 This also works because bug NB#57458 has been fixed somehow.
367 2007-07-26 Murray Cumming <murrayc@murrayc.com>
369 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
370 printf more details when we get unhandled D-Bus methods, because
373 * src/modest-mail-operation.c: (update_account_thread):
374 Comment out the tny_camel_pop_store_account_reconnect(), because this
375 is apparently no longer needed, and it did not work before anyway.
376 See the comment in the code.
378 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
379 by checking the header flags. This fixes projects.maemo.org bug
382 2007-07-25 Murray Cumming <murrayc@murrayc.com>
384 * src/maemo/modest-maemo-utils.h:
385 * src/maemo/modest-maemo-utils.c: Added
386 modest_maemo_show_information_note_in_main_context_and_forget().
387 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
388 Use the new function to show simple error dialogs in the main
389 context, though question dialogs are still in the current context,
390 which is unfortunately usually not the main context. This should
393 2007-07-25 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-tny-account-store.c: (get_password):
396 Never save the entered username and password in gconf,
397 because the UI spec says we should not. This helps
398 slightly with projects.maemo.org bug NB#63671.
400 2007-07-25 Murray Cumming <murrayc@murrayc.com>
402 * src/widgets/modest-msg-edit-window.h:
403 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
404 Moved some code here to make it simpler.
405 (modest_msg_edit_window_attach_file_one): Renamed from
406 modest_msg_edit_window_attach_file_interactive().
407 (modest_msg_edit_window_offer_attach_file): Renamed from
408 modest_msg_edit_window_attach_file() and used
409 modest_msg_edit_window_attach_file_one() instead of
410 copy/pasting the code. The old code for one was not using
411 GnomeVFS. This allows use of smb:// URLs when using send-as
412 from external applications, fixing bug NB#63741.
414 (modest_msg_edit_window_insert_image),
415 (modest_msg_edit_window_add_attachment_clicked):
416 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
417 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
418 Adapted to the new function names.
420 2007-07-25 Murray Cumming <murrayc@murrayc.com>
422 (modest_platform_set_update_interval): Set the alarm recurrence
423 fields so that auto-update does not just happen the first time.
424 This should have fixed projects.maemo.org bug NB#63938.
426 When this happens you can see a printf when the D-Bus method is
428 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
430 However, I do not actually seem to get new POP messages even when
431 clicking the refresh button manually. A restart gets them.
432 This might be a problem in today's tinymail only.
434 2007-07-24 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/modest-maemo-global-settings-dialog.c:
437 (current_connection):
438 Avoid a crash (probably only in scratchbox) when strcmp()ing a
439 NULL when closing the dialog.
441 2007-07-24 Murray Cumming <murrayc@murrayc.com>
443 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
444 Remove the hacky send/receive that didn't work, and instead
445 refilter the treemodel to make the deleted email really vanish from
446 the UI (though the delete-from-menu code does has commented out
447 the code that does that). This fixes projects.maemo.org bug
450 2007-07-24 Murray Cumming <murrayc@murrayc.com>
452 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
453 Try a couple of tricks to force the treeview to update (
454 poke the folder, and do a send/receive refresh), but the deleted
455 email still appears with a strike-through instead of really being
458 2007-07-23 Murray Cumming <murrayc@murrayc.com>
460 * src/dbus_api/modest-dbus-callbacks.c:
461 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
462 because their ID is not human-readable (see the comment about
463 improvements needed to the osso-email-interface API) and
464 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
466 2007-07-23 Murray Cumming <murrayc@murrayc.com>
468 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
469 (add_folders_to_list), (on_dbus_method_get_folders),
470 (modest_dbus_req_filter):
471 * src/maemo/modest-maemo-utils.c:
472 (on_camel_account_get_supported_secure_authentication):
473 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
474 (on_header_view_focus_in):
475 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
476 * src/modest-formatter.c: (modest_formatter_create_body_part):
477 * src/modest-mail-operation.c: (recurse_folders),
478 (update_account_thread), (get_msgs_full_thread),
479 (modest_mail_operation_get_msgs_full),
480 (modest_mail_operation_xfer_msgs):
481 * src/modest-search.c: (search_mime_part_and_child_parts),
482 (modest_search_account), (modest_search_all_accounts):
483 * src/modest-tny-account.c:
484 (modest_tny_account_get_special_folder), (recurse_folders):
485 * src/modest-tny-local-folders-account.c:
486 (modest_tny_local_folders_account_query_passes):
487 * src/modest-tny-msg.c: (copy_mime_part),
488 (modest_tny_msg_find_body_part_from_mime_part):
489 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
490 (modest_tny_send_queue_try_to_send):
491 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
492 (_modest_ui_actions_open), (download_uncached_messages),
493 (reply_forward), (modest_ui_actions_on_copy),
494 (modest_ui_actions_on_details), (has_retrieved_msgs),
495 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
497 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
498 (_selected_msg_marked_as), (_msg_download_completed),
499 (_selected_msg_sent_in_progress):
500 * src/widgets/modest-attachments-view.c:
501 (modest_attachments_view_set_message):
502 * src/widgets/modest-msg-view.c: (find_cid_image):
503 * tests/check_folder-transfer.c: (find_folders):
504 * tests/check_update-account.c: (func):
505 * tests/dbus_api/test_get_folders.c: (main):
506 Checked all uses of tny_iterator_get_current(), making sure
507 that the object is unreferenced (3 or 4 places did not),
508 and adding checks for NULL.
510 2007-07-23 Murray Cumming <murrayc@murrayc.com>
512 * src/dbus_api/modest-dbus-callbacks.c:
513 (on_idle_open_default_inbox): Make sure that the application UI is
515 * src/maemo/easysetup/modest-easysetup-wizard.c:
516 (on_entry_invalid_character): Show the word whitespace instead
517 of (null) in the banner when whitespace was entered.
518 (show_error): Add a comment that this does not work in
519 Maemo Bora, though we do not know why.
521 2007-07-23 Murray Cumming <murrayc@murrayc.com>
523 * src/modest-tny-account.c:
524 (modest_tny_account_get_special_folder): Use an if instead of
525 an assert for when the parent account name is NULL, because this
526 might be causing a crash in projects.maemo.org bug 63192.
527 * src/modest-mail-operation.c:
528 (modest_mail_operation_send_new_mail_cb),
529 (modest_mail_operation_remove_folder): unref the folder that is
530 returned from modest_tny_account_get_special_folder().
532 2007-07-23 Murray Cumming <murrayc@murrayc.com>
534 * src/modest-ui-actions.c:
535 (modest_ui_actions_on_password_requested):
536 Show mail_ib_login_cancelled info banner when the user cancels
537 the protected password dialog, to fix projects.maemo.org
540 2007-07-23 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/modest-account-settings-dialog.c:
543 (create_page_outgoing): Put this page in a GtkScrolledWindow,
544 matching the UI mock-up in the UI spec, and allowing access
545 to all widgets even when the on-screen keyboard is active.
547 2007-07-23 Murray Cumming <murrayc@murrayc.com>
549 Reverted this previous commit from Johannes,
550 because the scrollbars are always visible and because
551 I think we only need it on onepage of the account
552 settings, not the account wizard.
553 (I wrote the wrong instructions in the bug.)
555 * src/maemo/easysetup/modest-easysetup-wizard.c:
556 Added scrollbars to account wizard dialog.
557 Fixed projects.maemo.org NB #62744
559 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
561 * src/maemo/easysetup/modest-easysetup-wizard.c:
562 (create_page_user_details):
563 Use auto-cap for name (projects.maemo.org NB#63716)
564 * src/widgets/modest-account-view.c: (on_account_busy_changed):
566 2007-07-22 Armin Burgmeier <armin@openismus.com>
568 * src/maemo/modest-ui-actions.c: Use current account instead of
569 default account for creating viewer windows, so that the viewer
570 window knows to which account the viewed message belongs.
572 * src/maemo/modest-msg-view-window.c: Destroy the window when the
573 corresponding account is deleted. This fixes projects.maemo.org bug
576 2007-07-18 Armin Burgmeier <armin@openismus.com>
578 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
579 the dialog close after entering an invalid port number and clicking
580 OK. This fixes projects.maemo.org bug NB#63602.
582 2007-07-18 Armin Burgmeier <armin@openismus.com>
584 * src/modest-tny-account-store.c:
585 (get_server_accounts): Set parent modest account name for each
586 connection-specific transport account so that special folders of such
587 an account can be looked up. This fixes a crash when changing account
588 settings. This might also be related to projects.maemo.org bug
591 2007-07-16 Armin Burgmeier <armin@openismus.com>
593 * src/modest-ui-actions.c: Added a button to create a folder to the
594 move-to dialog. This fixes projects.maemo.org bug NB#59863.
596 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
598 * src/maemo/easysetup/modest-easysetup-wizard.c:
599 Added scrollbars to account wizard dialog.
600 Fixed projects.maemo.org NB #62744
602 2007-07-16 Murray Cumming <murrayc@murrayc.com>
604 * src/widgets/modest-msg-view.h:
605 * src/widgets/modest-msg-view.c:
606 Added modest_msg_view_get_message_is_empty() but this needs
608 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
609 Check if there is any text in the message yet.
610 But this needs to be implemented properly.
611 (modest_msg_edit_window_toggle_find_toolbar):
612 * src/maemo/modest-msg-view-window.c:
613 (modest_msg_view_window_toggle_find_toolbar):
614 Show a banner warning if there is no text to search, when
615 trying to start a search. This partially fixes
616 projects.maemo.org bug NB#62350.
618 2007-07-13 Murray Cumming <murrayc@murrayc.com>
620 * src/modest-mail-operation.c: (update_account_thread):
621 Initialized num_new_headers to fix the build.
623 2007-07-13 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
626 Ignore modest accounts whose server accounts don't exist in gconf.
627 This prevents us trying to create TnyAccount instances for those
628 server accounts when the server account has been removed from gconf,
629 but the parent modest account has not yet been removed from modest.
630 I don't know why this is only noticeable now. It was probably just
631 a harmeless g_warning() anyway.
633 2007-07-13 Murray Cumming <murrayc@murrayc.com>
635 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
636 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
638 2007-07-12 Armin Burgmeier <armin@openismus.com>
640 * src/maemo/modest-main-window.c: Make default account appear bold
641 in view, tools/send & receive and toolbar/send & receive SCM menus.
642 This fixes projects.maemo.org bug NB#59010.
644 2007-07-12 Murray Cumming <murrayc@murrayc.com>
646 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
647 Add a short-cut, by checking if the folder store is an account.
648 This ensures that the Sort menu item and toolbar is dimmed for
649 the local-folders account root item, fixing
650 projects.maemo.org bug NB#62545.
652 2007-07-12 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-tny-account-store.c: (get_password):
655 Show the password dialog (via the signal) only in the mainloop, via
656 an idle handler that we wait for. This could theoretically prevent
657 hangs, though I worry that it could introduce some too.
659 2007-07-12 Murray Cumming <murrayc@murrayc.com>
661 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
662 * src/maemo/modest-platform.c:
663 (modest_platform_connect_and_wait):
664 Take a TnyAccount* parameter and try to set it to online
665 (a TnyCamel-only API), because tinymail sets accounts to offline
666 when the user cancels a password dialog, and doesn't ask again until
667 it has been set to online.
668 However, this is commented out because it causes a hang now.
670 (modest_platform_connect_and_wait_if_network_account):
671 * src/modest-mail-operation.c:
672 (modest_mail_operation_update_account):
673 * src/modest-platform.h:
674 * src/modest-ui-actions.c: (_modest_ui_actions_open),
675 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
677 2007-07-12 Armin Burgmeier <armin@openismus.com>
679 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
681 * src/modest-mail-operation.c:
682 * src/modest-ui-actions.c: Check for already existing folder before
683 querying the server, show error message from camel if the request
684 still fails. This fixes projects.maemo.org bug NB#58701.
686 2007-07-12 Murray Cumming <murrayc@murrayc.com>
688 * src/modest-tny-account-store.h:
689 * src/modest-tny-account-store.c:
690 Added modest_tny_account_store_forget_password_in_memory(),
691 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
692 when creating a new account, so that new passwords will be used, instead of
693 us thinking that it's a second request as a result of a failed password again.
695 2007-07-12 Murray Cumming <murrayc@murrayc.com>
697 * src/dbus_api/modest-dbus-callbacks.c:
698 (on_idle_open_message): If the message is in drafts then open it
699 in an edit window instead of a view window. This fixes
700 projects.maemo.org bug NB#63005.
702 2007-07-12 Murray Cumming <murrayc@murrayc.com>
704 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
705 Avoided a harmless g_warning().
707 2007-07-12 Murray Cumming <murrayc@murrayc.com>
709 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
710 Pass the modest account name, not the TnyAccount display name to
711 modest_msg_view_window_new() so that the reply feature works,
712 fixing projects.maemo.org bug NB#62892.
714 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
715 (modest_msg_view_window_new_with_header_model):
716 * src/maemo/modest-msg-view-window.c:
717 (modest_msg_view_window_new_with_header_model),
718 (modest_msg_view_window_new):
719 * src/modest-ui-actions.c: (reply_forward):
720 * src/widgets/modest-msg-view-window.h:
721 * src/widgets/modest-window.c: (modest_window_set_active_account):
722 Rename an account parameter to modest_account_name to make this clearer.
724 2007-07-11 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-ui-actions.h:
727 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
728 modest_do_message_delete().
729 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
730 Call modest_do_message_delete(), hoping that this would cause messages
731 to be really deleted from search instead of just marked with strike through.
732 Does not seem to help.
734 2007-07-11 Armin Burgmeier <armin@openismus.com>
736 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
737 priv->reselect to FALSE prior to calling
738 modest_folder_view_select_first_inbox_or_local() to prevent endless
739 recursion and thus a crash on startup.
741 2007-07-11 Armin Burgmeier <armin@openismus.com>
743 * src/maemo/modest-account-settings-dialog.h: Include
744 <gtk/gtknotebook.h> to fix the build (at least for me).
746 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
747 Use "New FolderN" as default suggested name if "New folder" already
748 exists, with N being the first free number, though never exceed "New
749 folder99" in which case we just fall back to "New Folder" even though
750 it already exists. This fixes projects.maemo.org bug NB#58663.
752 2007-07-11 Murray Cumming <murrayc@murrayc.com>
754 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
755 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
756 projects.maemo.org bug NB#62778.
758 2007-07-11 Murray Cumming <murrayc@murrayc.com>
760 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
761 Ignore the wrong (for now) secure-smtp setting in the presets -
762 just default to requiring secure authentication for SMTP, because
765 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
767 * src/widgets/modest-folder-view.c: (filter_row)
768 Do not show drafts folder (see UI specs)
770 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
772 * src/modest-ui-actions.c:
773 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
774 place and also not necessary.
776 * src/widgets/modest-folder-view.c: (filter_row)
777 Guess folder type and hide Sent & Outbox if necessary.
778 Fixed project.maemo.org NB#57328
780 2007-07-11 Murray Cumming <murrayc@murrayc.com>
782 * src/modest-ui-actions.h:
783 * src/modest-ui-actions.c:
784 (modest_ui_actions_on_delete_message):
785 Move some code into a new
786 modest_ui_actions_refresh_message_window_after_delete()
787 function so we can use it from elsewhere.
789 * src/dbus_api/modest-dbus-callbacks.c:
790 (on_idle_delete_message), (on_delete_message): Used an idle
791 handler, as we do for the other D-Bus method handlers.
792 Call modest_ui_actions_refresh_message_window_after_delete()
793 if the deleted message was open in a window. This fixed
794 projects.maemo.org bug NB#62862.
796 2007-07-11 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-main.c: (main): Only show the UI at the start if
799 the showui command line option was given. For instance,
800 run-standalone src/modest showui
801 Otherwise, we wait for the top_application D-Bus method to
802 be sent by hildon-desktop when the application is selected
804 This allows us to run without a UI when osso-global-search
805 uses our D-Bus methods.
807 2007-07-11 Murray Cumming <murrayc@murrayc.com>
809 * src/dbus_api/modest-dbus-api.h: Added a define for a
810 top-application D-Bus method.
811 * src/dbus_api/modest-dbus-callbacks.c:
812 (on_top_application),
813 (modest_dbus_req_handler): Handle the top-application D-Bus
814 method, which might be an undocumented D-Bus signal sent by
815 hildon-desktop when it starts the application from the menu.
816 But I am not sure and I need to test it on the device, because
817 my scratchbox does not have the application in the menu now.
818 This method shows the main window, so that it can be invisible
819 when started, for instance, just for email searching from
822 * src/maemo/modest-main-window.c: (restore_settings),
823 (modest_main_window_new): Do not show the window immediately
824 upon creation. We show it later.
825 * src/modest-widget-memory.c: (save_settings_paned):
826 Try (unsuccessfully) to avoid saving the paned position when
827 it is not even visible.
828 (restore_settings_paned): Do not allow a silly paned position.
829 This seems necessary when not showing the window at first.
831 * tests/dbus_api/Makefile.am:
832 * tests/dbus_api/test_top_application.c: (main): Test for the
835 2007-07-10 Murray Cumming <murrayc@murrayc.com>
837 * src/modest-ui-dimming-rules.c:
838 (modest_ui_dimming_rules_on_new_msg),
839 (modest_ui_dimming_rules_on_reply_msg),
840 (modest_ui_dimming_rules_on_delete_msg),
841 (modest_ui_dimming_rules_on_details),
842 (modest_ui_dimming_rules_on_view_window_move_to),
843 (modest_ui_dimming_rules_on_view_previous),
844 (modest_ui_dimming_rules_on_view_next),
845 (_invalid_folder_for_purge): Added checks before
846 casting the window. This looks like an actual
847 logic error in _invalid_folder_for_purge(), because it
848 tries to use a ModestMainWindow as a message window.
850 2007-07-10 Murray Cumming <murrayc@murrayc.com>
852 * src/maemo/modest-account-settings-dialog.c:
853 (show_error): Use the same implementation as in
854 modest-easysetup-wizard.c:
855 (on_entry_invalid_character): The logical ID contains a %s.
856 Guessed what it should be.
857 (on_entry_max), (check_data), (on_response): Adapt to
858 changed show_error().
859 (create_page_account_details): Really call
860 modest_validating_entry_set_func() on the correct widgets.
861 * src/maemo/easysetup/modest-easysetup-wizard.c:
862 (on_entry_invalid_character): Fix the logical ID here too.
863 (create_page_account_details),
864 (create_page_user_details):
866 modest_validating_entry_set_func() on the correct widgets.
868 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
869 Do not try to use the account if it is NULL.
871 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
873 * src/modest-ui-actions.c: (create_move_to_dialog),
874 (modest_ui_actions_on_main_window_move_to),
875 (modest_ui_actions_on_msg_view_window_move_to):
876 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
877 (filter_row), (modest_folder_view_show_non_move_folders):
878 * src/widgets/modest-folder-view.h:
880 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
881 the Sent folder yet as it does not report the correct folder type.
883 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
885 * src/maemo/modest-msg-edit-window.c: (init_window):
888 2007-07-10 Murray Cumming <murrayc@murrayc.com>
890 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
891 Take a parent widget instead of a parent window, and
892 implement this with hildon_banner_show_information() instead.
893 Non-Maemo builds can just ifdef that there.
894 This fixed projects.maemo.org bug NB#62766.
896 (on_entry_invalid_character): Use show_error() again instead
897 of using hildon directly, and use the _CS() macro to use the correct
899 (create_account), (check_for_supported_auth_methods), (on_entry_max):
900 Pass a widget instead od a window to show_error().
902 2007-07-10 Murray Cumming <murrayc@murrayc.com>
904 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
905 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
906 This allows us to show the server name in the error message, fixing
907 projects.maemo.org bug NB#62904.
908 Also, use the appropriate logical ID message for the account protocol.
910 2007-07-10 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-tny-account-store.c: (on_idle_wrong_password):
913 A compilation fix, though the build wasn't broken for me.
915 2007-07-09 Murray Cumming <murrayc@murrayc.com>
917 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
918 Do not try to unref a NULL folder store, to avoid a runtime warning.
919 This seems to happen sometimes when changing accounts settings.
921 2007-07-09 Murray Cumming <murrayc@murrayc.com>
923 * src/modest-tny-account-store.c:
924 (modest_tny_account_store_instance_init),
925 (modest_tny_account_store_finalize),
926 (on_account_settings_hide), (on_idle_wrong_password):
927 Use a GHashTable to ensure that we only show one account settings
928 dialog per modest account. This avoids us having a dialog open for
929 both the store and transport accounts, or due to repeated get_password()
930 calls that shouldn't happen anyway.
932 2007-07-09 Murray Cumming <murrayc@murrayc.com>
934 * src/maemo/modest-maemo-utils.c: (on_hide),
935 (modest_maemo_show_dialog_and_forget): Handle the response, because
936 the window is not even hidden by default.
938 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
939 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
940 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
941 which seems to prevent some modality problems.
943 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
944 Ignore user cancellation errors.
946 * src/modest-account-mgr-helpers.h:
947 * src/modest-account-mgr-helpers.c:
948 Added modest_server_account_get_password() and
949 modest_server_account_get_has_password() to avoid direct use of
952 * src/maemo/modest-account-settings-dialog.h:
953 * src/maemo/modest-account-settings-dialog.c:
954 (modest_account_settings_dialog_init): Store the notebook so we can
956 Added modest_account_settings_dialog_switch_to_user_info().
958 * src/modest-tny-account-store.c:
959 (get_password): When the password in the account settings is wrong (we think),
960 show the relevant page of the account settings dialog, in the mainloop.
961 However, we currently get many of these at once because cancel does not
963 (forget_password): Do not forget the password
964 from the account settings, because this causes side-effects when
965 tinymail seems to call it at strange time, maybe because of how we
966 are cancelling get_password().
967 (modest_tny_account_store_alert): Ignore user cancellations.
969 2007-07-09 Murray Cumming <murrayc@murrayc.com>
971 * src/maemo/modest-maemo-utils.h:
972 * src/maemo/modest-maemo-utils.c:
973 Added modest_maemo_show_information_note_and_forget() for use instead of
974 gtk_dialog_run() when the response is not needed, to avoid an extra
975 mainloop which could cause a hang.
977 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
978 Use the logical IDs for the error message, though they are not
979 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
980 because gtk_dialog_run() caused a hang here (the window did not close).
981 This fixes projects.maemo.org bug NB#62646.
983 2007-07-09 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-account-mgr-helpers.h:
986 * src/modest-account-mgr-helpers.c:
987 Added modest_account_mgr_get_store_protocol().
989 * src/maemo/modest-account-view-window.c:
990 (on_delete_button_clicked): Show different warning text depending on
991 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
992 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
995 2007-07-09 Murray Cumming <murrayc@murrayc.com>
997 * src/maemo/modest-msg-edit-window.c:
998 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
999 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1001 2007-07-07 Armin Burgmeier <armin@openismus.com>
1003 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1004 ckdg_ib_maximum_characters_reached from correct package.
1006 * src/modest-ui-actions.c: Show an error message when a folder could
1007 not be created. Tinymail does not give us specific error codes about
1008 what has gone wrong, so we assume that a folder with that name
1009 already exists, though there might be other reasons.
1011 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1013 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1014 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1015 give a more exact error message that can be partly translated.
1017 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1019 * src/maemo/modest-address-book.c:
1020 (select_email_addrs_for_contact): Specify a default window size for the
1021 select-email-address dialog, so that it is probably big enough for the
1022 title. This should fix projects.maemo.org bug NB#62277.
1024 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1026 * src/maemo/easysetup/modest-easysetup-wizard.c:
1027 (create_page_complete_easysetup): Use
1028 gtk_widget_set_size() request to ensure that the text wraps
1031 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1033 * src/maemo/easysetup/modest-easysetup-wizard.c:
1034 (on_entry_invalid_character), (create_page_account_details),
1035 (create_page_user_details):
1036 Use new API of ModestValidatingEntry. But for some reason the banner is
1037 not shown. I will have to investigate that further.
1039 * src/widgets/modest-validating-entry.c: (on_insert_text),
1040 (modest_validating_entry_set_func):
1041 * src/widgets/modest-validating-entry.h:
1042 Added a new callback function to be able to react to prevented
1043 characters whitespaces to e.g show a banner.
1045 2007-07-05 Armin Burgmeier <armin@openismus.com>
1047 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1048 notification of HildonNumberEditor instead of remembering the port
1049 number. Thanks to Johannes for pointing this out.
1051 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1053 * src/maemo/easysetup/modest-easysetup-wizard.c:
1054 Check if there are any user changes before showing a confirmation
1055 dialog (projects.maemo.org NB#60946)
1057 2007-07-05 Armin Burgmeier <armin@openismus.com>
1059 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1060 number at the beginning of the dialog and set the modified flag at the
1061 end if the port number has changed. This is necessary because
1062 HildonNumberEditor does not support notification when the value has
1065 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-ui-actions.c:
1068 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1069 a connection before asking anything else. Correct the check for the destination
1070 folder so that it succeeds when online.
1071 This fixed projects.maemo.org bug NB#61645.
1073 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1075 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1076 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1077 to fix projects.maemo.org bug NB#62439.
1079 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-tny-account.c: (on_connection_status_changed):
1082 Really do not use tny_device_force_offline() here. See the previous comment.
1084 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-tny-account.c: (on_connection_status_changed):
1087 Do not use tny_device_force_offline() when tinymail says that something
1088 went wrong with the connection. It seems to report this unnecessarily.
1090 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1092 * src/maemo/modest-connection-specific-smtp-window.c:
1093 (modest_connection_specific_smtp_window_init):
1094 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1095 does not seem to have any effect in osso 1.1 (though it works in
1096 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1098 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1100 * src/maemo/modest-connection-specific-smtp-window.c:
1101 Fix UI specification problems with projects.meamo.org NB#60479
1103 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1106 clue when this has failed, because the error dialog is not always shown
1107 (at least in earlier version).
1109 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1110 GError message, because the generic error dialog is not helpful.
1112 'This message is not currently available (can't let a new connection go online)'
1113 when trying to open an IMAP message.
1115 (_modest_ui_actions_open): Offer a connection when some messages would
1116 have to be downloaded and we are offline.
1118 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1120 * src/widgets/modest-folder-view.c:
1121 Don't check for MERGE type anymore as we use the correct type
1123 NOTE: For the last two changes you need to update your tinymail copy
1124 because of API changes!
1126 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1128 * src/modest-tny-local-folders-account.c:
1129 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1130 (see projects.maemo.org NB#61580)
1132 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1134 * src/modest-tny-account.c: (on_connection_status_changed):
1135 Commented out the call to modest_platform_connect_and_wait() because this
1136 seems to always hang, and I would like to know if this is the only thing
1137 that causes a hang when showing the connection dialog.
1138 It is not very useful anyway.
1140 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1142 * src/maemo/modest-msg-view-window.c:
1143 (modest_msg_view_window_select_next_message):
1145 * src/modest-platform.h:
1146 * src/maemo/modest-platform.c:
1147 Added modest_platform_connect_and_wait(), which calls
1148 tny_maemo_conic_device_connect() always in the main thread, by calling it
1149 in an idle handler and waiting for the idle handler to run. It should be
1150 in the main thread because it uses GTK+ UI code. It just returns TRUE
1151 if the device is already online.
1153 There is some nasty code to ensure that subsequent calls to
1154 modest_platform_connect_and_wait() just wait for the first one to finish,
1155 by checking repeatedly in another idle handler. This is necessary,
1156 because other threads (or even the main thread, via another idle handler)
1157 can call modest_platform_connect_and_wait() while
1158 modest_platform_connect_and_wait() is running.
1160 (modest_platform_connect_and_wait_if_network_account),
1161 (modest_platform_connect_and_wait_if_network_folderstore):
1162 Convenience functions that calls modest_platform_connect_and_wait() if
1163 the account or folder might want network access.
1165 * src/modest-mail-operation.c:
1166 (modest_mail_operation_update_account):
1167 * src/modest-ui-actions.c: (download_uncached_messages),
1168 (modest_ui_actions_on_rename_folder), (delete_folder),
1169 (modest_ui_actions_on_main_window_move_to),
1170 (modest_ui_actions_on_msg_view_window_move_to):
1171 * src/widgets/modest-folder-view.c:
1172 (drag_and_drop_from_folder_view):
1173 Offer a connection if we are offline.
1175 * src/modest-tny-account.c: (on_connection_status_changed):
1176 Document this as only handling errors during network operations in progress,
1177 and replace the idle code with a simple call to
1178 modest_platform_connect_and_wait(), which does this instead.
1180 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1182 * src/modest-tny-account.c:
1183 (modest_tny_account_get_special_folder): (util_on_idle),
1184 Handle the GError so we can see when tny_folder_store_get_folders()
1185 fails, as it currently does while something else is connecting.
1187 Added util_run_in_main_thread_and_wait()
1188 which uses an idlen handler and mainloop to ensure that the function
1189 is called in the main thread.
1190 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1191 to make sure that we call attempt the connection in the mainloop only,
1192 which might solve some hangs.
1194 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1196 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1197 be found by their display name. This is never useful.
1198 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1199 by its ID, instead of trying to use its ID as its display name.
1201 * src/modest-tny-account-store.h:
1202 * src/modest-tny-account.c:
1203 (modest_tny_account_get_special_folder): Add a g_warning() when
1204 tny_folder_store_get_folders() returns an empty list for the maildir.
1206 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1207 Add a g_warning() when this returns NULL, because that it not allowed
1210 2007-07-02 Armin Burgmeier <armin@openismus.com>
1212 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1213 note when trying to cancel the wizard. This fixes projects.maemo.org
1216 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1218 * src/modest-tny-account.h:
1219 * src/modest-tny-account.c:
1220 (modest_tny_account_new_from_server_account),
1221 (modest_tny_account_new_from_server_account_name),
1222 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1223 because this must now be set before setting the proto. This is usd in
1224 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1225 warning in camel_session_get_service() caused by
1226 tny_camel_transport_account_prepare().
1228 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1231 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1233 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1235 (modest_connection_specific_smtp_edit_window_init):
1237 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1238 of "changed" for now
1240 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1242 * src/modest-tny-account.c:
1243 (modest_tny_account_new_from_server_account):
1244 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1245 now uses to request a connection when it needs one, and which it uses
1246 to tell us that something is wrong with the connection, so we can force
1247 the accounts offline to prevent further problems.
1249 * src/modest-defs.h:
1250 * src/modest-init.c: (init_default_settings):
1251 * src/modest-mail-operation.c:
1252 (modest_mail_operation_update_account):
1253 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1254 This should not be necessary anymore. Do not set the conf key that
1255 determined this (it was always TRUE and not set anywhere else).
1257 * src/modest-ui-actions.h: Remove unused and unimplemented
1258 modest_ui_actions_on_online_toggle_toggled().
1260 2007-06-29 Murray Cumming <murrayc@murrayc.com
1262 * src/maemo/modest-main-window.c: (connect_signals):
1263 Don't connect to delete_event twice. Maybe this was harmless.
1265 2007-06-29 Murray Cumming <murrayc@murrayc.com
1267 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1268 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1269 Debug output to give some more clue when a folder move is not allowed.
1271 2007-06-28 Murray Cumming <murrayc@murrayc.com
1273 * src/modest-tny-account.c: (on_modest_file_system_info),
1274 (modest_tny_account_get_mmc_account_name):
1275 Always call the callback, without checking whether the name has changed.
1276 * src/widgets/modest-folder-view.c: (strings_are_equal),
1277 (on_model_foreach_set_name), (on_get_mmc_account_name),
1278 (text_cell_data): Compare the name here, and use the name from
1279 the account rather than from the
1280 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1281 if the name was changed after the account was added to the model.
1282 That's a tinymail bug but not one that I want to fix now.
1284 This finally fixes projects.maemo.org bug NB#59301.
1286 2007-06-27 Armin Burgmeier <armin@openismus.com>
1288 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1291 2007-06-27 Murray Cumming <murrayc@murrayc.com
1293 * src/modest-tny-account.h:
1294 * src/modest-tny-account.c:
1295 Added modest_tny_account_get_mmc_account_name(), to set the memory
1296 card name asynchronously for the given account and then notify.
1297 (modest_tny_account_new_for_local_folders): Use this new function instead
1298 of using hildon_file_system_info_async_new() directly.
1300 * src/widgets/modest-folder-view.c: (text_cell_data):
1301 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1302 gtk_tree_model_row_changed() when it is available.
1304 This should fix projects.maemo.org bug NB#59301.
1306 2007-06-27 Murray Cumming <murrayc@murrayc.com
1308 * src/modest-mail-operation.c: (update_account_thread),
1309 (get_msgs_full_thread): Fix typo failures in the revert
1312 2007-06-27 Murray Cumming <murrayc@murrayc.com
1314 * src/maemo/modest-maemo-global-settings-dialog.c:
1315 (idle_select_default_focus):
1316 * src/modest-mail-operation.c: (idle_notify_progress),
1317 (idle_notify_progress_once), (set_last_updated_idle),
1318 (update_account_thread), (get_msgs_full_thread):
1319 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1320 * src/widgets/modest-header-view.c:
1321 (idle_notify_headers_count_changed_destroy),
1322 (idle_notify_headers_count_changed):
1323 Reverted the additions of gdk_threads_enter/leave(), in case this
1324 helps with a startup hang on the device.
1326 2007-06-26 Armin Burgmeier <armin@openismus.com>
1328 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1329 for supported secure authentication methods from server by
1330 gtk_dialog_run(), saving CPU time and a potential race condition.
1332 2007-06-26 Armin Burgmeier <armin@openismus.com>
1334 * src/maemo/modest-maemo-utils.h:
1335 * src/maemo/modest-maemo-utils.c: Added a
1336 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1337 only error code to tell the calling code when the user canceled the
1340 * src/maemo/modest-account-settings-dialog.h:
1341 * src/maemo/modest-account-settings-dialog.c:
1342 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1343 message if the retrieval of secure authentication methods was canceled
1344 by the user. Perform the check before saving anything to configuration
1345 to not end up with half-committed configuration changes, do not show
1346 a "Saving to configuration failed" note when authentication methods
1347 could not be retrieved.
1349 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1352 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1354 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1355 Only return the first level of folders under accounts, because the
1356 osso-global-search UI spec doesn't want the rest.
1357 This fixed projects.maemo.org bug NB#61811.
1359 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-tny-account-store.c:
1362 * src/modest-tny-account-store.h:
1363 Added modest_tny_account_is_memory_card_account().
1364 * src/maemo/modest-main-window.c: (create_details_widget):
1365 Show the same information items for the memory card as we show for the
1366 local-folders, to fix projects.maemo.org bug NB#59307.
1368 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1370 * src/modest-tny-account-store.c: (get_password):
1371 Added some checks for NULL to maybe prevent crashes, though I think
1372 it was Philip's last commit that actually prevented the crash here
1373 when creating a first new account.
1374 But the new account is still not usable (no messages are shown)
1375 until a restart of the application.
1377 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/modest-maemo-global-settings-dialog.c:
1380 (idle_select_default_focus):
1381 * src/modest-mail-operation.c: (idle_notify_progress),
1382 (idle_notify_progress_once), (idle_notify_update_account_queue),
1383 (set_last_updated_idle), (update_account_thread),
1384 (notify_get_msgs_full), (get_msgs_full_destroyer),
1385 (get_msgs_full_thread):
1386 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1387 * src/widgets/modest-header-view.c:
1388 (idle_notify_headers_count_changed_destroy),
1389 (idle_notify_headers_count_changed):
1390 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1391 all idle handlers, because some other thread could be blocking
1392 the GDK lock, so that it can do GUI stuff.
1394 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1396 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1397 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1398 (on_idle_send_receive), (on_idle_open_default_inbox):
1399 * src/maemo/modest-msg-edit-window.c:
1400 (modest_msg_edit_window_attach_file_noninteractive):
1401 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1402 to prevent a hang. I don't quite understand why these are necessary,
1403 beause we should already be in the main loop. I guess something outside
1404 of the main loop is taking the lock.
1406 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1407 we are really using URIs, and use files that are more likely to exist.
1409 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1411 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1412 necessary because configure.ac now defines different variables.
1414 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1416 * libmodest-dbus-client/libmodest-dbus-client.c:
1417 * libmodest-dbus-client/libmodest-dbus-client.h:
1418 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1419 libmodest_dbus_client_compose_mail() is what things actually use.
1421 * src/dbus_api/modest-dbus-api.h:
1422 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1423 * tests/dbus_api/Makefile.am:
1424 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1427 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1429 * src/modest-init.c: (modest_init_local_folders):
1430 For memory-card (or other non local-folders) maildir accounts,
1431 always create an Archive folder, so that there is somewhere to put
1432 messages. This should be less confusing, because the user does not need
1433 to guess that the need to create a folder.
1435 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1437 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1438 Fixed icon size by using (50, 50) which is the same as defined by
1441 2007-06-25 Armin Burgmeier <armin@openismus.com>
1443 * src/widgets/modest-window-mgr.c:
1444 * src/modest-init.c:
1445 * configure.ac: Correctly recognize hildon-notify presence and fixed
1446 the build without it being installed.
1448 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1450 * libmodest-dbus-client/libmodest-dbus-client.c:
1451 (libmodest_dbus_client_search): Fix the build. Sorry.
1452 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1453 (reply_forward_cb): Initialize variables to fix the build.
1455 * src/modest-tny-account-store.c:
1456 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1457 comparison (a silly typo) so that email search results can be opened
1458 when there are more than one account.
1460 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1462 * libmodest-dbus-client/libmodest-dbus-client.c:
1463 (libmodest_dbus_client_search),
1464 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1465 instead of 1 second, because the search gets folders and messages from
1466 the server, which can take a long time. When it times out,
1467 osso-global-search will report no results.
1469 We need to specify whether we should search only cached information
1470 (maybe with a user preference), and the osso-email-search-plugin
1471 API should really be improved to allow that option, and to allow results
1472 to be delivered asynchronously in batches.
1474 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1477 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1478 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1480 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1483 that is an empty string. D-Bus seems to give us these instead of NULL.
1485 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1487 * src/dbus_api/modest-dbus-callbacks.c:
1488 * src/maemo/easysetup/modest-easysetup-wizard.h:
1489 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1490 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1491 (modest_connection_specific_smtp_edit_window_init):
1492 * src/maemo/modest-maemo-global-settings-dialog.c:
1494 * src/maemo/modest-maemo-utils.c:
1495 (modest_maemo_utils_setup_images_filechooser):
1496 * src/maemo/modest-main-window.c: (create_details_widget):
1497 * src/maemo/modest-msg-edit-window.c:
1498 (modest_msg_edit_window_attach_file_noninteractive),
1499 (modest_msg_edit_window_color_button_change),
1500 (modest_msg_edit_window_set_zoom):
1501 * src/modest-mail-operation.c: (update_account_thread):
1502 * src/modest-tny-account-store.c:
1503 * src/modest-tny-account.c:
1504 * src/widgets/modest-global-settings-dialog.c:
1505 * src/widgets/modest-window.h:
1507 Fixed build on bora!
1509 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1511 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1512 * src/modest-search.c: (modest_search_folder),
1513 (modest_search_all_accounts): Actually search only in the specified folder,
1514 doing a simple match on the folder ID.
1515 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1516 and added some documentation.
1518 2007-06-22 Armin Burgmeier <armin@openismus.com>
1520 * src/maemo/modest-maemo-utils.h:
1521 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1522 modest_maemo_utils_get_supported_secure_authentication_methods.
1524 * src/maemo/easysetup/modest-easysetup-wizard.c:
1525 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1526 one occured, not just "Server does not support secure authentication".
1528 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1530 * src/modest-tny-account-store.c: (get_password):
1531 Restored the call to tny_account_set_user() because Philip seems to have
1532 stopped this from crashing (by not using the freed string). It still does
1533 not work, but now we can test it.
1535 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/modest-msg-edit-window.c: (init_window):
1538 Comment out use of an uninitialzed GtkScrolledWindow variable,
1539 to fix the build and stop a crash. Yet again.
1541 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1543 * src/modest-tny-account-store.c: (get_password):
1544 Remove the call to tny_account_set_user() because this actually crashes.
1545 As mentioned in the last commit, it is known to not work anyway.
1547 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1549 * src/modest-tny-account-store.c: (get_password):
1550 Use tny_account_set_username() to tell tinymail that the username might
1551 have changed too. But tinymail ignores this: see projects.maemo.org
1553 * src/modest-ui-actions.c:
1554 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1555 reset the connection when changing the username, and improve the comments.
1556 Save the changed username to gconf at least, so it is used when Modest is
1559 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1561 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1562 Do not use a query, so that we get all folders, including for POP and
1563 local-folders. They work as search criteria too.
1564 This fixes projects.maemo.org bug NB#57740.
1566 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1569 Comment out the use of hildon_notification_set_sound() because it is
1570 not declared, to fix the build. Warnings are serious, people.
1572 2007-06-21 Armin Burgmeier <armin@openismus.com>
1574 * src/maemo/modest-maemo-utils.h:
1575 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1576 modest_maemo_utils_get_supported_secure_authentication_methods()
1577 to query authentication methods for a specific user. This should fix
1578 projects.maemo.org bug NB#61369.
1580 * src/maemo/easysetup/modest-easysetup-wizard.c:
1581 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1584 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1586 * libmodest-dbus-client/libmodest-dbus-client.h:
1587 * libmodest-dbus-client/libmodest-dbus-client.c:
1588 (modest_dbus_message_iter_get_search_hit),
1589 (libmodest_dbus_client_search):
1590 Reorganised and commented this.
1591 Removed modest_search_hit_free() from the public API because it
1594 Added libmodest_dbus_client_get_folders() and
1595 modest_folder_result_list_free().
1597 * src/dbus_api/modest-dbus-api.h:
1598 * src/dbus_api/modest-dbus-callbacks.c:
1599 (modest_dbus_req_filter): Commented. Moved most code to
1600 on_dbus_method_search() and added on_dbus_method_get_folders().
1602 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1603 of the extra D-Bus handler.
1605 * tests/dbus_api/Makefile.am:
1606 * tests/dbus_api/test_get_folders.c: New test for
1607 libmodest_dbus_client_get_folders(). This seems to return an empty list
1608 at the moment. That could be the same error that causes the message list
1609 to be empty sometimes.
1610 This should help with projects.maemo.org bug NB#57740.
1612 2007-06-21 Armin Burgmeier <armin@openismus.com>
1614 * src/modest-mail-operation.c: Do not call
1615 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1616 notify the operation's end after having set the status to CANCELED for
1617 the operation queue to listen on. This fixes a deadlock when there
1618 were mail operations in the queue during its finalization.
1620 * src/modest-singletons.c: Reordered uninitialization of the account
1621 manager to happen after the mail operation queue was uninitialized
1622 because the mail operation's in the queue might still try to access
1623 the account manager (see modest_mail_operation_notify_end()). This
1624 fixes a potential crash when terminating the application.
1626 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1628 * src/modest-search.c:
1629 (search_mime_part_and_child_parts): Moved some code here so we
1630 can search recursively in child folders.
1631 (modest_search_folder): Search in the message as a mime part, instead
1632 of just its child mime parts.
1633 (read_chunk), (search_mime_part_ogs):
1634 Check how many bytes were read, to prevent an endless loop.
1635 Searching in message bodies now works. This finishes the fix for
1636 projects.maemo.org bug NB#61007.
1638 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1640 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1641 Add a g_warning when the item is not a folder.
1643 * src/modest-ui-dimming-rules.c:
1644 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1645 when selected item is not a folder (for instance, an account), because
1646 the UI spec only talks about folders.
1647 I am not sure what the UI spec wants, so this might not totally fix
1648 projects.maemo.org bug NB#60794.
1650 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1652 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1653 (load_from_file): Sort the list. The unsorted list would be more noticeable
1654 in non-English locales.
1656 * src/maemo/modest-msg-edit-window.c:
1657 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1658 warning and fix the build.
1660 * src/maemo/modest-progress-bar-widget.c:
1661 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1662 avoid a g_warning, and probably to avoid a crash.
1664 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-search.c: (modest_search_folder): Check for a GError
1667 when calling tny_folder_get_headers(), to show that this is not the cause
1670 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1672 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1673 Actually set the body query instead of the subject query.
1675 * src/modest-search.c: (search_mime_part_ogs),
1676 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1677 which would probably cause it to fail if we got this far.
1679 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1680 to simplify the code.
1681 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1682 be causing search-in-body to fail.
1684 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1686 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1688 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1689 Better debug message when the folder cannot be found.
1690 This should help with fixing projects.maemo.org bug #61287.
1691 * src/modest-search.c: (add_hit): Do not leak the furl string.
1693 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1695 * src/modest-ui-actions.c:
1696 (modest_ui_actions_on_folder_selection_changed):
1697 Do not special-case TNY_MERGE_FOLDER here, because
1698 modest_tny_folder_get_account() already does that. This fixes
1699 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1700 shown when the Outbox was selected).
1702 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1704 * libmodest-dbus-client/libmodest-dbus-client.c:
1705 (_dbus_iter_get_string_or_null): Initialize the string variable in
1706 case this helps with Dirk's crash.
1708 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1710 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1711 though it is not implemented yet (this function is maybe not even used),
1712 to avoid breaking ABI in future.
1713 * libmodest-dbus-client/libmodest-dbus-client.c:
1714 (get_attachments_string): Moved some code into this generic function.
1715 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1716 sends email. It is maybe not used.
1717 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1718 (on_send_mail): Use attachments.
1720 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1721 * src/maemo/modest-msg-edit-window.c:
1722 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1723 a filename before using it, to fix projects.maemo.org bug NB#58233.
1725 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1727 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1728 Initialize the continue_download variable to fix the build, and probably
1729 to fix randome behaviour.
1731 2007-06-18 Armin Burgmeier <armin@openismus.com>
1733 * src/modest-tny-send-queue.h:
1734 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1735 the queue so we can later show it in the UI. Replaced
1736 modest_tny_send_queue_msg_is_being_sent() by
1737 modest_tny_send_queue_get_msg_status().
1739 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1741 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1742 gpointer. This probably was not harmful, but just to be sure.
1744 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1746 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1747 Fix the build, but leave the function broken on Bora, because
1748 hildon_uri_action_get_service() does not exist.
1749 osso_uri_action_get_service() does not exist either, it seems.
1751 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account.c:
1754 (modest_tny_account_new_from_server_account):
1755 Uncommented the url debug output again, because it is useful for
1756 debugging, as I said in the comment.
1758 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1760 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1762 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1763 for Mameo Bora, to fix the build.
1765 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1768 Fixed build with hildon < 0.99
1770 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1771 Check if the selected account is busy instead of checking all accounts
1773 * src/modest-account-mgr-priv.h:
1774 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1775 (modest_account_mgr_init), (compare_account_name),
1776 (modest_account_mgr_set_account_busy),
1777 (modest_account_mgr_account_is_busy):
1778 * src/modest-account-mgr.h:
1779 Added busy information to the account manager. It possible to
1780 set an account to busy or not busy now.
1782 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1783 (modest_mail_operation_update_account),
1784 (modest_mail_operation_notify_end):
1785 Set the account to busy/not busy depending on the operation state.
1787 * src/widgets/modest-account-view.c:
1788 (modest_account_view_finalize), (get_last_updated_string),
1789 (update_account_view), (on_account_busy_changed), (init_view):
1790 Show string "Refreshing..." if the account is currently busy.
1792 All this fixes projects.maemo.org bug NB#59711
1794 2007-06-14 Armin Burgmeier <armin@openismus.com>
1796 * src/widgets/modest-attachments-view.h:
1797 * src/widgets/modest-attachments-view.c: Added
1798 modest_attachments_view_has_attachments() and fixed coordinate
1799 transformation in get_att_view_at_coords(). This fixes attachment
1802 * src/widgets/modest-msg-view.c: Make use of
1803 modest_attachments_view_has_attachments() to decide whether to show
1804 attachments in the header.
1806 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1809 (on_change), (on_combo_security_changed),
1810 (modest_connection_specific_smtp_edit_window_init),
1811 (modest_connection_specific_smtp_edit_window_set_connection),
1812 (modest_connection_specific_smtp_edit_window_is_dirty):
1813 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1814 * src/maemo/modest-connection-specific-smtp-window.c:
1817 Show an comfirmation dialog for the smpt-edit-window if there are
1818 unsaved changes and the user hits cancel.
1819 (projects.maemo.org bug NB#60479)
1821 2007-06-14 Armin Burgmeier <armin@openismus.com>
1823 * src/maemo/easysetup/modest-easysetup-wizard.c:
1824 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1825 address" info in banner instead of node, and select all the text as
1826 per UI spec. This fixes projects.maemo.org bug NB#60550.
1828 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1830 reviewed by: <delete if not using a buddy>
1832 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1833 * src/modest-ui-actions.c: (folder_refreshed_cb):
1835 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-folder-view.c: (filter_row):
1838 Explictly filter out the per-account outbox accounts. I don't know why
1839 these only sometimes show up, but now they should never show up in the UI.
1840 This should fix projects.maemo.org bug NB#60160.
1842 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1844 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1845 when the toolbar does not exist yet.
1846 * src/modest-widget-memory.c: (save_settings_header_view):
1847 Added g_warnings() to help us to discover when we are trying to set
1848 an empty columns list in gconf.
1850 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-init.h:
1853 * src/modest-init.c:
1854 Added modest_init_get_default_header_view_column_ids().
1856 * src/modest-widget-memory.c: (restore_settings_header_view):
1857 Use the new function to get defaults, if the gconf key is empty,
1858 instead of not creating any columns. This seems to fix the
1859 empty right-hand pane problems.
1861 * src/widgets/modest-header-view.h: Improved documentation.
1863 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1865 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1866 Revert the use of the display name as the account name, because this
1867 is generally wrong and would break the code that follows.
1869 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1871 * src/maemo/easysetup/modest-easysetup-wizard.c:
1872 (check_for_supported_auth_methods), (on_before_next),
1875 More correct fix for projects.maemo.org bug NB# 58991
1876 Do not longer accept AUTH_PASSWORD as secure method and choose
1877 correct method when creating the account.
1879 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1881 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1882 Fixed projects.maemo.org bug NB# 58991
1884 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-init.c: (modest_init_init_core),
1887 (modest_init_local_folders): Fixed compilation errors.
1889 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1891 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1892 Remove unnecessary lib/include, though it is good in principle when needed.
1894 * src/modest-init.c: (modest_init_one_local_folder),
1895 (modest_init_local_folders):
1896 * src/modest-init.h: Initialize the .modest library for memory cards,
1897 instead of just doing nothing for them. This should allow us to create
1898 folders there, fixing projects.maemo.org bug NB#59297.
1900 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1902 * libmodest-dbus-client/libmodest-dbus-client.c:
1903 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1904 (libmodest_dbus_client_compose_mail),
1905 (libmodest_dbus_client_open_message),
1906 (libmodest_dbus_client_send_and_receive),
1907 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1909 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1910 (on_idle_open_message), (modest_dbus_req_handler),
1911 (search_result_to_message), (modest_dbus_req_filter):
1912 * src/modest-search.c: (add_hit), (modest_search_folder),
1913 (modest_search_all_accounts): Improved debug messages.
1915 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1917 * src/modest-tny-account-store.c:
1918 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1921 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1924 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1926 * src/modest-tny-account-store.c: (get_server_accounts):
1927 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1928 even when there are no accounts, so that the Outbox folder is always
1929 visible. This fixes projects.maemo.org bug NB#60158.
1931 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/modest-main-window.c: (create_details_widget):
1934 Use the mcen_va_never logical ID.
1936 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1938 * src/dbus_api/modest-dbus-api.h:
1939 * src/dbus_api/modest-dbus-callbacks.c:
1940 (on_idle_open_default_inbox), (on_open_default_inbox),
1941 (modest_dbus_req_handler):
1942 Added a new OpenDefaultInbox method.
1944 * libmodest-dbus-client/libmodest-dbus-client.h:
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 Added libmodest_dbus_client_open_default_inbox() to call the new
1947 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1948 though it should maybe be used by a new osso-email-interface function.
1950 * tests/dbus_api/Makefile.am:
1951 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1954 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1956 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1957 NULL, so that the signals get all the keys. This should not actually
1958 change any behaviour because we currently update everything when anything
1961 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1963 * src/widgets/modest-folder-view.c: (text_cell_data),
1964 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1965 (find_inbox_iter): If tinymail tells us that the folder is
1966 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1967 This causes the inbox to be selected at startup, fixing part of
1968 projects.maemo.org bug NB#56305.
1970 * src/modest-ui-dimming-rules.c:
1971 (modest_ui_dimming_rules_on_tools_smtp_servers):
1972 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1973 the SMTP servers menu item.
1974 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1975 that the SMTP Servers menu item is dimmed when there are no accounts,
1976 as a future version of the UI spec will require. This fixes
1977 projects.maemo.org bug NB#56305.
1979 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1981 * src/maemo/modest-maemo-utils.c:
1982 (modest_maemo_utils_get_supported_secure_authentication_methods):
1983 Added label to dialog instead of unreadable title
1985 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1986 (modest_main_window_new):
1987 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1990 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1991 * src/modest-account-mgr.h:
1992 Added method to avoid code duplication
1994 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1995 (modest_ui_actions_on_send_receive):
1996 Use modest_account_mgr_has_accounts
1998 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2000 * src/maemo/easysetup/modest-presets.c:
2001 (modest_presets_get_info_server_security): Do not report secure auth
2003 * src/modest-protocol-info.c: Use the defines for the gconf key names
2004 for secure authentication. This was not working because we were writing
2005 Password and reading password, and the check was case sensitive.
2006 With this, gmail now works for receiving and sending when created via
2009 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/easysetup/modest-presets.c:
2012 (modest_presets_get_info_server_security): Correct the key name for
2013 SecureSmtp, because it seems to be case-sensitive.
2014 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2015 Do not try to get the 0th notebook page if there are 0 pages, to
2016 avoid a g_warning().
2018 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2020 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2021 Prevent use of the new notification feature for now, because it currently
2022 shows one dialog for each new email, which is annoying.
2024 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2027 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2028 when no country was selected, so that we show the global ones.
2029 * src/maemo/easysetup/modest-presets.c:
2030 (modest_presets_get_providers): Return only the global providers, not
2031 all providers when mmc=0 was requested.
2033 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2036 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2037 provider ID in the combo.
2039 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2040 Do not show the page numbers, because it would be confusing when we add
2041 the 2 extra pages for the custom setup, when the user chooses the "Other"
2042 provider. This fixes projects.maemo.org bug NB#59028
2044 * src/modest-init.c: (modest_init_init_core),
2045 (modest_init_local_folders):
2046 * src/modest-init.h:
2047 * src/modest-tny-account.c:
2048 (modest_tny_account_new_for_local_folders): Do not create default folders
2049 for the memory card. This should fix projects.maemo.org bug NB#59328.
2051 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2053 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2054 Free the changed_conf_keys string items. They are already freed in the
2055 idle handler if that runs first.
2057 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2059 * src/modest-ui-actions.c:
2060 (modest_ui_actions_on_password_requested): Check that the server name
2061 is not NULL, because I just saw a password dialog with (null) as the
2064 * src/modest-tny-folder.[h|c]: Added
2065 modest_tny_folder_is_memory_card_folder().
2066 * src/modest-ui-dimming-rules.c:
2067 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2068 menu item for memory cards, as per the UI spec (section 7.4). This should
2069 fix projects.maemo.org bug NB#59297.
2071 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2073 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2074 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2075 is another problem with the code, see Murray's comment at line 772)
2077 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2079 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2080 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2081 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2082 (load_from_file), (easysetup_country_combo_box_init),
2083 (easysetup_country_combo_box_get_active_country_ids),
2084 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2085 instead of just one ID, to avoid duplicate country names in the UI.
2087 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2088 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2089 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2090 a single ID, avoiding duplicate providers.
2091 * src/maemo/easysetup/modest-easysetup-wizard.c:
2092 (on_combo_account_country): Adapt to use a list.
2094 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2096 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2097 keys changed in the last X seconds.
2099 * src/modest-account-mgr.h:
2100 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2101 (on_key_change), (modest_account_mgr_class_init),
2102 (modest_account_mgr_init), (modest_account_mgr_finalize):
2103 As the keys are changed, save them in a GSList* and signal that GSList*
2104 further every X seconds, to batch changes, to allow us to do just one
2105 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2106 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2108 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2109 changed signal signature.
2111 * src/modest-conf.c: (modest_conf_set_list),
2112 (modest_conf_on_change): Reenable notification.
2114 (modest_conf_maemo_fake_on_change): Comment out the hack that
2115 notified immediately instead of asynchronously.
2117 * src/widgets/modest-account-view.h:
2118 * src/widgets/modest-account-view.c:
2119 (update_account_view): Select the previously-selected account ID,
2120 if possible. This fixes projects.maemo.org bug NB#56933.
2122 (on_account_changed), (on_account_removed),
2123 (modest_account_view_select_account):
2125 Remove the block/unblock functions
2126 because they were not useful.
2128 * src/maemo/modest-account-view-window.c:
2129 (on_delete_button_clicked), (on_edit_button_clicked),
2130 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2132 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2135 Improve the error dialog to show Incorrect Account Settings, which seems
2136 clearer, and say that the internal error message (to be removed from the
2137 dialog later) is often misleading.
2138 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2140 * src/modest-tny-account.c:
2141 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2142 URL because this is so useful for debugging on the device.
2144 * src/widgets/modest-serversecurity-combo-box.c:
2145 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2147 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2149 * src/modest-mail-operation.c:
2150 (modest_mail_operation_send_new_mail):
2151 Added a comment about a nasty but apparently harmless message. Details
2152 added to the wiki g_warnings() page.
2154 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2156 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2157 (modest_tny_send_queue_class_init):
2158 Do not use the priv struct because it is empty, to avoid g_warnings
2159 about a non-existant priv struct.
2161 * src/modest-tny-account-store.c:
2162 (modest_tny_account_store_get_server_account),
2163 (modest_tny_account_store_get_transport_account_for_open_connection
2164 ): Do not try to get transport server accounts for local folders,
2165 because they don't have any. This avoids a g_warning().
2167 * src/maemo/modest-main-window.c:
2168 (modest_main_window_notify_send_receive_initied),
2169 (on_configuration_key_changed):
2170 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2171 * src/modest-defs.h:
2172 * src/modest-mail-operation.c:
2173 (modest_mail_operation_update_account):
2174 * src/modest-tny-account-store.h:
2175 * src/modest-tny-account.c:
2176 (modest_tny_account_get_special_folder),
2177 (modest_tny_account_new_for_local_folders),
2178 (modest_tny_account_new_for_per_account_local_outbox_folder):
2179 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2180 * src/modest-tny-local-folders-account.c:
2181 (add_account_folders_to_merged_folder):
2182 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2183 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2184 (modest_ui_actions_on_send):
2185 * src/widgets/modest-folder-view.c: (update_model):
2186 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2187 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2188 modest_tny_account_store_get_tny_account_by_account() to
2189 modest_tny_account_store_get_server_account() to make the code clearer.
2191 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2193 * src/dbus_api/modest-dbus-api.h:
2194 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2195 * src/maemo/modest-msg-edit-window.c:
2196 (modest_msg_edit_window_attach_file_noninteractive):
2197 added g_warning in case the file to be attached does not exist
2198 * tests/dbus_api/test_compose_mail.c: (main):
2199 removed obsolete comment, added generic files as test case
2201 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2203 * src/modest-tny-account-store.c: (get_server_accounts):
2204 Create the local folders account only once, not once for each outbox, and
2205 not only when there are some outboxes.
2207 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2209 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2210 code that is causing a crash at startup. Sergio says that he is fixing this.
2212 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2214 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2215 * src/maemo/modest-account-settings-dialog.c:
2216 (create_page_outgoing),
2217 (modest_account_settings_dialog_set_account_name),
2218 (save_configuration):
2219 - Fixed handling of the "Use secure authentication" toggle to comply with
2220 the ui specification. See also projects.maemo.org bug NB#58400
2222 - Restore the Secure connection setting combo correctly when loading
2225 * src/maemo/modest-maemo-utils.c:
2226 (on_camel_account_get_supported_secure_authentication),
2227 (modest_maemo_utils_get_supported_secure_authentication_methods):
2228 Fixed a crasher if operation is canceled
2230 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2231 (modest_protocol_info_auth_is_secure):
2232 * src/modest-protocol-info.h:
2234 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2235 the sense of the "Use secure authentication" toggle.
2237 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2239 * src/modest-tny-account-store.h:
2240 * src/modest-tny-account-store.c:
2241 Added modest_tny_account_store_get_local_folders_account().
2243 * src/modest-tny-folder.h:
2244 * src/modest-tny-folder.c:
2245 (modest_tny_folder_get_account):
2246 Added this replacement for tny_folder_get_account() which returns
2247 the local-folders account for TnyMergeFolders, to avoid the
2248 warning about the unimplemented get_account_func() vfunc().
2250 (modest_tny_folder_get_rules),
2251 * src/modest-ui-actions.c:
2252 (modest_ui_actions_on_folder_selection_changed):
2253 * src/modest-mail-operation.c:
2254 (modest_mail_operation_remove_folder),
2255 (modest_mail_operation_xfer_folder),
2256 (modest_mail_operation_rename_folder),
2257 (modest_mail_operation_get_msg),
2258 (modest_mail_operation_get_msgs_full),
2259 (modest_mail_operation_remove_msg),
2260 (modest_mail_operation_xfer_msgs),
2261 (modest_mail_operation_refresh_folder):
2262 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2264 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2266 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2267 (modest_server_account_set_security):
2268 * src/modest-defs.h: Add comments explaining that our
2269 UI spec means TLS when it says Normal, so these do not look like errors.
2271 * src/modest-tny-account.c:
2272 (modest_tny_account_new_from_server_account): Use the new tinymail
2273 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2274 for TLS. This should fix projects.maemo.org bug NB#58460.
2276 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/easysetup/modest-easysetup-wizard.c:
2279 (create_account): Correct the position of the gconf sanity check warning.
2280 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2281 of using the g_idle_add() hack, because this does not seem to be necessary
2282 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2283 caused by something other than maemo's gconf.
2284 This fixes projects.maemo.org bug #59022.
2286 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2288 * src/modest-account-mgr-helpers.c:
2289 (modest_account_mgr_get_default_account): Do not check that the account
2290 exists if there is no default account (NULL), to fix a runtime warning.
2292 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2294 * src/widgets/modest-folder-view.c: (update_model):
2295 Do not unref the treemodel before we have finished with it.
2296 This prevents a valgrind warning and an occasional crash at startup.
2298 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2300 * libmodest-dbus-client/libmodest-dbus-client.h:
2301 added libmodest_dbus_client_compose_mail()
2302 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2304 added functions needed for SendAsMail() functionality
2305 * src/maemo/modest-msg-edit-window.c:
2306 (modest_msg_edit_window_attach_file_noninteractive):
2307 non interactively attaching files to message edit window
2308 * src/widgets/modest-msg-edit-window.h:
2309 * tests/dbus_api/Makefile.am:
2310 added test_compose_mail.c
2311 * tests/dbus_api/test_compose_mail.c: (main):
2313 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2315 * src/modest-account-view.c:
2316 Fixed bug projects.maemo.org bug NB#59307
2318 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2320 * src/maemo/easysetup/modest-easysetup-wizard.c:
2321 (get_serverport_incoming), (on_before_next), (create_account):
2322 * src/maemo/modest-account-settings-dialog.c:
2323 (modest_account_settings_dialog_set_account_name):
2324 * src/maemo/modest-maemo-utils.c:
2325 (on_camel_account_get_supported_secure_authentication_status),
2326 (on_camel_account_get_supported_secure_authentication),
2327 (on_secure_auth_cancel),
2328 (modest_maemo_utils_get_supported_secure_authentication_methods):
2330 Implemented security authentication for settings and easysetup.
2332 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2334 * src/maemo/modest-main-window.c: (create_details_widget):
2335 Show the total size for memory card accounts too, instead of showing
2336 the name again. Fixes bug projects.maemo.org bug NB#59307.
2338 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2341 * src/modest-tny-simple-folder-store.c:
2342 * src/modest-tny-simple-folder-store.h: Removed.
2344 * src/modest-tny-local-folders-account.h
2345 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2346 for the local-folders maildir, with an extra TnyMergedFolder containing
2347 the folders of the per-account outbox store accounts.
2348 * src/modest-tny-account-store.c: (get_server_accounts):
2349 Add the outboxes to the special local folders account after creating it.
2351 * src/modest-tny-account.c:
2352 (modest_tny_account_new_for_local_folders): Create the derived
2353 account when creating the main local-folders account.
2355 * src/maemo/modest-main-window.c: (create_details_widget),
2356 (modest_main_window_set_contents_style):
2357 Adapted to the use of the derived account instead of the folder store.
2359 * src/modest-ui-actions.c:
2360 (modest_ui_actions_on_folder_selection_changed):
2361 * src/modest-ui-dimming-rules.c:
2362 (modest_ui_dimming_rules_on_new_folder):
2363 * src/widgets/modest-folder-view.c: (text_cell_data),
2364 (icon_cell_data), (filter_row), (update_model),
2365 (get_cmp_rows_type_pos):
2368 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2369 Do not get the priv struct, because no priv struct has been set,
2370 to avoid a runtime warning.
2372 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2373 #ifelse with #else, to fix a warning, to fix the build.
2376 2007-06-05 Christian Kellner <ckellner@openismus.com>
2378 * libmodest-dbus-client/libmodest-dbus-client.c:
2379 Fix small typo in doc (why do you always see them
2380 AFTER committing stuff?)
2383 2007-06-05 Christian Kellner <ckellner@openismus.com>
2385 * libmodest-dbus-client/libmodest-dbus-client.c:
2386 (libmodest_dbus_client_search):
2387 Initialize hit list with NULL. Also set folder list
2388 to "" if NULL was supplied.
2391 2007-06-03 Christian Kellner <ckellner@openismus.com>
2393 * libmodest-dbus-client/libmodest-dbus-client.c:
2394 (modest_search_hit_list_free):
2395 Make it save to call it with NULL.
2397 * src/dbus_api/modest-dbus-callbacks.c:
2398 * src/modest-search.c:
2399 Return full ModestSearchHits as the search result list not TnyHeader
2400 since can't be around withouth the correspoding TnyFolder.
2402 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2404 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2405 Added currently commented code to check for secure auth
2407 * src/maemo/modest-account-settings-dialog.c: (on_response),
2408 (save_configuration), (show_ok):
2409 Fixed projects.maemo.org bugs NB #59248 and #59251
2411 * src/maemo/modest-maemo-utils.c:
2412 (on_camel_account_get_supported_secure_authentication_status),
2413 (on_camel_account_get_supported_secure_authentication),
2414 (modest_maemo_utils_get_supported_secure_authentication_methods):
2415 * src/maemo/modest-maemo-utils.h:
2416 Moved get_supported_secure_authentication() method here to be able
2417 to use it from easysetup wizard.
2419 * src/modest-pair.c: (on_pair_compare_as_string):
2420 Should compare string with first part of pair and not
2421 strcmp pairs which will crash.
2423 * src/modest-protocol-info.c:
2424 (modest_protocol_info_protocol_is_store):
2425 * src/modest-protocol-info.h:
2426 Added modest_protocol_info_get_auth_protocol_name()
2428 2007-06-03 Armin Burgmeier <armin@openismus.com>
2430 * src/modest-mail-operation.c:
2431 (modest_mail_operation_get_msgs_full): Set priv->account also when
2432 only retrieving a single message. This avoids a crash when canceling
2435 (modest_mail_operation_notify_end): Do not explicitely remove the
2436 operation from the queue but only emit the progress_changed signal.
2437 The queue itself listens to that signal to remove the operation when
2438 it is finished. This reduces coupling and removes a potential deadlock
2439 when modest_mail_operation_notify_end() is called from the queue
2440 itself. If that is a problem performance-wise, I would suggest to
2441 implement a status-changed signal or something.
2443 * src/modest-mail-operation-queue.c: Make sure to never call a
2444 function from another file while the queue is locked. This (hopefully)
2445 fixes another deadlock when exiting the application while retrieving
2448 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2450 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2451 Fixed build if libogs is not available
2453 2007-06-03 Christian Kellner <ckellner@openismus.com>
2455 * libmodest-dbus-client/libmodest-dbus-client.h:
2456 * libmodest-dbus-client/libmodest-dbus-client.c:
2457 (libmodest_dbus_client_delete_message):
2458 Implement deletion of messages (Client side).
2460 (modest_search_hit_free),
2461 (modest_search_hit_list_free):
2462 Utility functions to free the result hits.
2464 * src/dbus_api/modest-dbus-api.h:
2465 * src/dbus_api/modest-dbus-callbacks.c:
2466 (on_delete_message),
2467 (modest_dbus_req_handler):
2468 Implement deletion of messages (Server side).
2470 * tests/dbus_api/test_search.c: (main):
2473 * tests/dbus_api/Makefile.am:
2474 * tests/dbus_api/test_delete_message:
2475 Add little test for the message deletion logic
2477 2007-06-03 Armin Burgmeier <armin@openismus.com>
2479 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2480 when the operation queue was not empty. projects.maemo.org bug
2483 2007-06-03 Armin Burgmeier <armin@openismus.com>
2485 * src/widgets/modest-account-view.c
2486 (on_account_default_toggled): Toggle default account column
2487 explicitely instead of waiting for gconf notification (which is
2488 currently ignored). This should fix projects.maemo.org bug NB#56910
2489 for now. It should probably be removed when gconf notifications are
2492 2007-06-03 Christian Kellner <ckellner@openismus.com>
2494 * libmodest-dbus-client/libmodest-dbus-client.c:
2495 Removed debugging spew.
2497 * src/dbus_api/modest-dbus-callbacks.c:
2498 Added debugging info.
2500 * src/modest-search.c:
2501 (modest_search_all_accounts):
2502 Use tny_account_store_get_accounts () on the account store
2503 to get all accounts which is the way to get all accounts.
2505 * tests/dbus_api/test_search.c: (main):
2506 Make it possible to supply the search term on the command line.
2508 2007-06-03 Christian Kellner <ckellner@openismus.com>
2510 * libmodest-dbus-client/libmodest-dbus-client.c:
2511 * libmodest-dbus-client/libmodest-dbus-client.h:
2512 Implement searching for mesages over raw dbus. (Client side)
2514 * src/dbus_api/Makefile.am:
2515 * src/dbus_api/modest-dbus-api.h:
2516 * src/dbus_api/modest-dbus-callbacks.c:
2517 * src/dbus_api/modest-dbus-callbacks.h:
2518 Search framework (Server side). Also implement on_idle_open_message().
2520 * src/maemo/modest-platform.c: (modest_platform_init):
2521 Prepare for raw dbus/osso rpc interaction.
2523 * src/modest-search.h:
2524 Changed minsize from unspecific guint to guint32.
2526 * src/modest-search.c:
2528 Added strange hack which magically made tnymail work.
2530 (modest_search_folder),
2531 (modest_search_account),
2532 (modest_search_all_accounts):
2533 Implement helper functions to search all accounts, specific account
2536 * tests/dbus_api/Makefile.am:
2537 * tests/dbus_api/test_open_message.c:
2538 Read url to open from commandline.
2540 * tests/dbus_api/test_search.c:
2541 Implement small test for dbus search stuff
2543 2007-06-02 Armin Burgmeier <armin@openismus.com>
2545 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2546 include account type and account title. This fixes projects.maemo.org
2549 * src/maemo/modest-account-view-window.c: Set a title for the window.
2551 2007-06-02 Armin Burgmeier <armin@openismus.com>
2553 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2554 incoming and outgoing server name based on email address and server
2555 types as long as the names have not been edited manually. This fixes
2556 projects.maemo.org bug NB#58671.
2558 2007-06-02 Armin Burgmeier <armin@openismus.com>
2560 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2561 server type cannot be changed in future to the incoming details page
2562 when creating an account. This fixes projects.maemo.org bug NB#59029.
2564 2007-06-02 Armin Burgmeier <armin@openismus.com>
2566 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2567 and assigned max width chars so that they wrap instead of being
2568 truncated. Fixes projects.maemo.org bug NB#56126.
2570 2007-06-02 Armin Burgmeier <armin@openismus.com>
2572 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2573 introductory note to the connection specific smtp servers dialog, as
2574 section 8.12 of the email UI specification requires. This fixes
2575 projects.maemo.org bug NB#59212.
2577 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2580 Check for running mail operations, and offer to cancel them, as per the UI
2581 spec. This fixes projects.maemo.org bug NB#59041 .
2582 However, I suspect that tinymail may still use the network connection
2583 in ways that we cannot detect or cancel. But it should at least adapt to
2584 changes fairly well.
2586 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2588 * src/modest-tny-account-store.c: (recreate_all_accounts),
2589 (get_cached_accounts), (get_server_accounts): Do more sensible
2590 ref-counting of the temporarily-cached outbox accounts list. This seems
2591 to fix a crash when entering the password when the password was wrong.
2593 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2595 * src/gnome/modest-main-window.c: (connect_signals):
2596 * src/modest-tny-account-store.c: (get_password),
2597 (modest_tny_account_store_alert): Added comments and clues and
2598 commented-out code about how we currently fail to deal with connection
2599 errors and wrong passwords, and how we should.
2601 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2603 * src/widgets/modest-retrieve-combo-box.c:
2604 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2605 This fixes projects.maemo.org bug NB#58472 .
2607 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2609 * src/maemo/easysetup/modest-easysetup-wizard.c:
2610 (create_page_complete_easysetup):
2611 (create_page_complete_custom): Correct the last commit,
2612 putting the correct sentences in the correct pages.
2614 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2616 * src/maemo/easysetup/modest-easysetup-wizard.c:
2617 (create_page_complete_custom): Show the second sentence of text
2618 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2621 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2623 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2624 Set the leave-on-server conf key by default. This fixes
2625 projects.maemo.org bug NB#59258 .
2627 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/modest-account-view-window.c:
2630 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2631 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2634 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2636 * src/maemo/easysetup/modest-easysetup-wizard.c:
2637 (create_caption_new_with_asterisk):
2638 * src/maemo/modest-account-settings-dialog.c:
2639 (create_caption_new_with_asterisk):
2640 Uncomment the code to add the asterisk, because they are no longer in the
2641 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2642 (update_incoming_server_title): Add an asterisk here too.
2644 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2646 * src/maemo/modest-maemo-global-settings-dialog.c:
2647 (current_connection): Check that we are even connected before trying to
2648 get the current connection name, to prevent a warning.
2650 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2651 Change the comments because tny_maemo_conic_device_connect() is now meant to
2653 * src/modest-mail-operation.c:
2654 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2655 make sure we have a connection and fail if we can't connect.
2657 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-main-window.c:
2660 (on_account_store_connecting_finished): Do not try to get the
2661 connection ID if we are not really connected. I am surprised that
2662 this signal handler is called when we are not connected.
2664 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2666 * src/modest-error.h:
2667 * src/modest-ui-actions.c:
2668 (modest_ui_actions_get_msgs_full_error_handler):
2669 Renamed an enum, added comments, added an enum
2670 for retrieve-limit errors.
2672 * src/modest-mail-operation.c: (foreach_add_item),
2673 (internal_folder_observer_update), (update_account_thread),
2674 (modest_mail_operation_get_msgs_full):
2675 (modest_mail_operation_update_account),
2676 Added comments about how this works, and some code that should
2677 (but does not) check the retrieve-limit. See the TODO comment.
2679 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2681 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2682 Initialize help_id to fix the build. Warnings are good.
2684 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2686 * src/widgets/modest-hbox-cell-renderer.c:
2687 (modest_hbox_cell_renderer_append):
2688 * src/widgets/modest-vbox-cell-renderer.c:
2689 (modest_vbox_cell_renderer_append):
2690 Fix the last commit by doing an extra ref.
2692 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2694 * src/widgets/modest-hbox-cell-renderer.c:
2695 (modest_hbox_cell_renderer_append):
2696 * src/widgets/modest-vbox-cell-renderer.c:
2697 (modest_vbox_cell_renderer_append):
2698 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2699 to fix the build with Maemo Bora.
2700 However, there seems to be a remaining crash, probably due to reference
2703 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2705 * src/modest-tny-account.c:
2706 (modest_tny_account_new_for_local_folders):
2707 Use hildon_file_system_info_async_new() to get a better name for
2708 the memory card account, setting it as the account name.
2709 The timing seems to work, but this is probably
2710 not the best place to do this. See the TODO comment.
2711 * src/maemo/modest-main-window.c: (create_details_widget):
2712 * src/widgets/modest-folder-view.c: (text_cell_data):
2713 Use the tny account name instead of hardcoding a name.
2715 2007-05-30 Christian Kellner <ckellner@openismus.com>
2717 * src/modest-search.c: (modest_search):
2718 Correctly set part_search_func even if we have already parsed
2719 the query and thus a valid OgsTextSearcher object.
2721 2007-05-30 Christian Kellner <ckellner@openismus.com>
2724 Search and check for libogs.
2727 Incooparte the ogs build env.
2729 * src/modest-mime-part-search-stream.c:
2730 * src/modest-mime-part-search-stream.h:
2731 Removed since we do the real searching now in modest-search.c.
2733 * src/modest-search.c:
2734 * src/modest-search.h:
2735 Implement support for ogs. We use that if available and requested
2736 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2737 should now handle the corner case when the search term is spread
2738 across multiple reads.
2739 Also the logic in modest_search () was corrected to search all
2740 requested fields until one is found.
2742 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2744 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2746 * src/modest-init.h:
2747 * src/modest-init.c: Made modest_init_local_folders() take a
2748 path and be public so we can iniitialize maildir folders on
2751 * src/modest-local-folder-info.h:
2752 * src/modest-local-folder-info.c:
2753 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2755 * src/modest-tny-account.c:
2756 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2757 still means the standard local-folders path on the local volume.
2759 * src/modest-tny-account-store.c:
2760 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2761 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2762 all accounts when that happens.
2763 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2764 this too, so it shows up in the treeview.
2766 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/modest-maemo-global-settings-dialog.c:
2769 (current_connection):
2770 * src/widgets/modest-global-settings-dialog.c:
2771 (current_connection_default):
2772 Use the enum values instead of 0, 1 and -1,
2773 to make the code clearer.
2775 * src/modest-account-mgr-helpers.c:
2776 (modest_account_mgr_get_connection_specific_smtp): Make this code
2779 * src/modest-runtime.h:
2780 * src/modest-runtime.c:
2781 Added modest_runtime_remove_all_send_queues().
2782 * src/maemo/modest-main-window.c:
2783 (on_account_store_connecting_finished): Recreate the send queues,
2784 using the appropriate transport accounts for this new connection.
2785 Some futher adapting might be needed if the old send queues are not
2786 automatically stopped at this point.
2788 * src/modest-tny-account-store.c: (get_server_accounts):
2789 Create the connection-specific transport accounts, so that they can
2790 be found later by their ID.
2792 * src/modest-tny-account.h:
2793 * src/modest-tny-account.c:
2794 Added modest_tny_account_new_from_server_account_name().
2795 modest_tny_account_new_from_server_account(): Do not create the
2796 send queues here, because they will be
2797 recreated anyway when the connection changes for the first time.
2799 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2801 * src/modest-local-folder-info.h:
2802 * src/modest-local-folder-info.c:
2803 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2804 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2805 tbox_folder): Take a modest account name instead of a server TnyAccount,
2806 so we can have per-modest-account rather than per-transport-account
2808 We must make sure that we change or recreate the exisitng send queues
2809 when the connection changes for connection-specific transport accounts.
2811 * src/modest-tny-account-store.c:
2812 (create_per_account_local_outbox_folders): Create outboxed per modest
2813 account, not per transport account.
2815 * src/modest-tny-account.h:
2816 * src/modest-tny-account.c:
2817 (modest_tny_account_get_special_folder): For outboxes, get the
2818 parent modest account name. The account is ignored for other folders.
2819 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2820 modest account name rather than a server TnyAccount.
2822 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2824 * src/modest-tny-account.c:
2825 (modest_tny_account_new_from_server_account):
2826 Call modest_runtime_get_send_queue() immediately after creating transport
2827 accounts, so that they start trying to send email from the outbox as soon
2828 as possible at startup. This is probably what we want.
2830 * src/modest-mail-operation.c: (update_account_thread):
2831 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2832 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2833 * src/modest-tny-send-queue.h:
2834 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2835 (modest_ui_actions_on_send):
2836 Added comments about how sending works, though it needs some more work.
2838 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2840 * src/modest-tny-account.c:
2841 (modest_tny_account_get_special_folder): Add TODO because this fails when
2842 the network is busy.
2843 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2844 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2845 Do not try to show this window when there is no active account. The UI
2846 specs does not tell us what to do in this case.
2848 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/Makefile.am:
2853 * src/widgets/Makefile.am: Some dist fixes.
2855 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/modest-connection-specific-smtp-window.c:
2858 (on_button_edit): Make the code clearer, to prevent a double free.
2860 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2862 * src/maemo/modest-account-settings-dialog.c:
2863 (modest_account_settings_dialog_set_account_name),
2864 Check the connection-specific smtp servers checkbox if there are any.
2866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2867 (modest_connection_specific_smtp_edit_window_init):
2868 Start with a suitable port number.
2870 * src/modest-account-mgr-helpers.h:
2871 * src/modest-account-mgr-helpers.c: Added
2872 modest_account_mgr_get_has_connection_specific_smtp().
2874 (modest_account_mgr_set_connection_specific_smtp),
2875 (modest_account_mgr_remove_connection_specific_smtp),
2876 (modest_account_mgr_get_has_connection_specific_smtp),
2877 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2878 connection-specific smtp server accounts in the account, rather than
2879 the server account conf dir.
2881 This fixes bug projects.maemo.org bug NB#58263 .
2883 * src/modest-tny-account-store.c:
2884 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2885 if there are no server accounts yet, to prevent an infinite loop when there
2886 are no accounts. Document that one must be called before the other.
2888 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-account-mgr-helpers.c:
2891 (modest_account_mgr_get_default_account): Make sure that at least
2892 one account is always the default, if there are any enabled accounts.
2893 This is just a sanity check that shouldn't be necessary.
2895 * src/modest-account-mgr-priv.c:
2896 (_modest_account_mgr_account_from_key): Unescape the conf key to
2897 get the real account name. For instance, this is an issue if a space
2898 was in the account name, which can happen because the account name
2899 is generated from the display name.
2900 (_modest_account_mgr_get_account_keyname): Always escape the
2902 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2903 Unescape the conf keys to get the real account names.
2905 For instance, previously the is-default radio button in the accounts
2906 list was not checked for any accounts at first. This fixes that,
2907 and might fix several similar bugs.
2909 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2911 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2912 Removed some debug printfs.
2914 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2916 Modest on-disk outbox directories are now here, for instance:
2917 $HOME/.modest/outboxes/<account-id-1>/outbox
2918 $HOME/.modest/outboxes/<account-id-2>/outbox
2920 $HOME/.modest/local-folders/outbox
2921 so we can have a separate outbox for each account.
2922 But they are shown as one outbox in the GtkTreeView, by using a
2923 TnyMergeFolder in a ModestTnySimpleFolderStore.
2926 * src/modest-tny-simple-folder-store.c:
2927 * src/modest-tny-simple-folder-store.h:
2928 Added ModestTnySimpleFolderStore, used to contain folders from
2929 other folder stores, such as other accounts.
2931 * src/modest-tny-outbox-account.h:
2932 * src/modest-tny-outbox-account.c:
2933 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2934 used for the per-account local outbox folders.
2936 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2937 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2938 only use this (internally) now for the non-outbox local folders.
2940 * src/modest-init.h:
2941 * src/modest-init.c: Added modest_init_one_local_folder(), for
2942 setting up the directory structure for each local folder.
2944 * src/modest-local-folder-info.c:
2945 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2946 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2948 * src/modest-local-folder-info.h:
2949 * src/modest-tny-account-store.c: (on_account_removed),
2950 (on_account_changed), (create_per_account_local_outbox_folders),
2951 (get_server_accounts), (modest_tny_account_store_get_accounts),
2952 (modest_tny_account_store_get_tny_account_by_account),
2953 (modest_tny_folder_store_is_virtual_local_folders):
2955 * src/modest-tny-account.h:
2956 * src/modest-tny-account.c:
2957 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2958 to create an on-disk per-account local outbox folder for each
2960 (create_per_account_local_outbox_folders): Create a local outbox folder
2961 for each transport account.
2962 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2963 for all local folders.
2965 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2966 instead of using g_object_get/set() directly. It is clearer.
2968 (modest_tny_folder_store_get_message_count),
2969 (modest_tny_folder_store_get_local_size
2970 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2971 because we now use these with non-acount folder stores.
2973 (modest_tny_account_get_special_folder),
2974 (modest_tny_account_new_from_server_account),
2975 (modest_tny_account_new_from_account):
2976 (recurse_folders): Adjust to the new outbox system.
2978 * src/modest-tny-folder.h:
2979 * src/modest-tny-folder.c:
2980 (modest_tny_folder_is_local_folder),
2981 (modest_tny_folder_get_local_folder_type),
2982 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2984 * src/widgets/modest-main-window.h:
2985 * src/maemo/modest-main-window.c: (create_details_widget),
2986 (modest_main_window_set_contents_style): Show details for any folder store,
2989 (modest_tny_folder_get_rules):
2990 Remove the const. C does not support constness enough for this.
2992 * src/modest-ui-actions.c:
2993 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2994 make all outboxes appear as one, in the usual local-folders tree node.
2996 (set_active_account_from_tny_account),
2997 (modest_ui_actions_on_folder_selection_changed):
2998 * src/widgets/modest-folder-view.c: (text_cell_data),
2999 (icon_cell_data), (filter_row),
3000 (add_account_folders_to_merged_folder),
3001 (add_account_folders_to_simple_folder_store), (),
3002 (get_cmp_rows_type_pos), (cmp_rows),
3003 (modest_folder_view_set_account_id_of_visible_server_account):
3004 Adjust to the new outbox system, using generic folder stores and folders
3005 in the GtkTreeModel.
3007 2007-05-23 Christian Kellner <ckellner@openismus.com>
3009 * src/modest-mail-operation.c:
3010 (modest_mail_operation_update_account):
3011 Use info->max_size instead of unintialized local var [small
3012 build fix]. (Added TODO to review that change since I don't
3015 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3017 * libmodest-dbus-client/libmodest-dbus-client.c:
3018 (libmodest_dbus_client_compose_mail): function added
3019 * src/dbus_api/modest-dbus-api.h:
3020 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3021 (on_compose_mail): Implementation of the SendAsMail functionality
3023 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3025 * src/modest-account-mgr.c:
3026 (modest_account_mgr_add_server_account): Set the secure-connection
3027 conf key for transport accounts as well as store accounts. I don't know
3028 why the if was there. For instance, this makes sure that we use SSL
3029 for the gmail preset from the easysetup wizard.
3031 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3033 * src/gnome/modest-main-window.c:
3034 (on_account_store_connecting_finished), (connect_signals):
3035 * src/maemo/modest-main-window.c:
3036 (on_account_store_connecting_finished), (connect_signals),
3037 (modest_main_window_new):
3038 Handle TnyAccountStore::connecting-finished instead of
3039 TnyDevice::connection-changed, because we cannot actually perform
3040 operations on accounts until TnyAccountStore has itself responded to
3041 the TnyDevice::connection-changed signal. This prevents a GError from
3043 Do not try to update at startup, because we (at least on scratchbox)
3044 already do an update at startup when the device goes online.
3045 This prevents a GError from tinymail.
3046 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3047 Added TODO about stopping simultaneous operations.
3049 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3052 * src/modest-mail-operation-queue.c:
3053 (modest_mail_operation_queue_remove):
3054 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3055 about where they happened.
3057 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3059 * src/modest-ui-actions.c:
3060 (modest_ui_actions_on_password_requested): Make sure that the remember
3061 output parameter is always TRUE.
3063 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3065 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3066 Show a OK/Cancel dialog if the error is a question, though we still do not
3067 know anything more about what we are asking the user.
3068 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3069 Fix an uninitialized variable (helper). This is a logic error, however.
3071 2007-05-21 Christian Kellner <ckellner@openismus.com>
3073 * src/modest-search.h:
3074 Correct bit shifting in the ModestSearchFlags enum.
3076 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3078 * src/modest-tny-account.c:
3079 (modest_tny_account_new_from_server_account): Do not use the lsub and
3080 check-all hard-coded IMAP options when using POP.
3082 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3084 * src/modest-tny-account.c:
3085 (modest_tny_account_new_from_server_account):
3086 Use NULL for the secure-auth method for POP when Password auth has been
3087 specified by the user, as we already do for IMAP. "auth=Login" causes
3088 an error from camel or the server.
3090 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/modest-account-settings-dialog.c:
3093 (create_page_account_details),
3094 (modest_account_settings_dialog_set_account_name):
3095 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3096 for the leave-on-server checkbox, rathr than just the checkbox, when
3097 the protocol is not POP.
3099 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3101 * src/widgets/modest-account-view.c:
3102 * src/widgets/modest-account-view.h:
3103 Added modest_account_view_select_account() which will be useful later
3104 to asynchronously re-select the edited account.
3106 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3108 * src/maemo/modest-account-settings-dialog.c:
3109 (modest_account_settings_dialog_set_account_name):
3110 Automatically choose the port numbers based on the secure authentication
3111 methods, if they have not been chosen before.
3112 This fixes projects.maemo.org bug NB#56273 .
3114 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3116 * src/maemo/modest-main-window-ui.h:
3117 * src/modest-ui-actions.c:
3118 * src/modest-ui-actions.h:
3119 Connect the Tools/SMTP Servers menu item to
3120 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3121 SMTP servers dialog, as in the UI specification and saves changes when it
3122 is closed. This fixed projects.maemo.org bug NB#56305 .
3124 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3126 * src/maemo/modest-connection-specific-smtp-window.c:
3127 (modest_connection_specific_smtp_window_init):
3128 Use gtk_window_set_default_size() to make this window big enough, so
3129 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3131 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3133 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3134 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3135 (modest_connection_specific_smtp_edit_window_init),
3136 Do not try to connect to a combobox signal before the combobox exists.
3137 This fixes the cras in projects.maemo.org bug NB#56288 .
3138 (modest_connection_specific_smtp_edit_window_get_settings):
3139 Remove the server_account_name parameter which was being checked for NULL
3140 though it was not used.
3142 * src/maemo/modest-connection-specific-smtp-window.c:
3143 (modest_connection_specific_smtp_window_fill_with_connections),
3144 (on_button_edit), (modest_connection_specific_smtp_window_init):
3145 Correct the number of treemodel columns to prevent a warning.
3146 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3147 libconic does not work.
3149 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3151 * src/modest-tny-account.c:
3152 (modest_tny_account_new_from_server_account):
3153 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3154 SMTP when "None" was chosen by the user. However, with my SMTP server that
3155 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3158 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3160 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3161 to explain the memory management issue with the ID in the ModestPair.
3163 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3164 (add_sending_page), (modest_account_assistant_finalize):
3165 * src/gnome/modest-gnome-global-settings-dialog.c:
3166 (create_updating_page), (create_composing_page):
3167 * src/gnome/modest-msg-edit-window.c: (get_transports),
3168 (init_window), (modest_msg_edit_window_finalize),
3169 (modest_msg_edit_window_get_msg_data):
3170 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3171 * src/gnome/modest-transport-widget.c:
3172 (modest_transport_widget_finalize), (smtp_configuration):
3173 * src/maemo/modest-maemo-global-settings-dialog.c:
3174 (create_updating_page), (create_composing_page):
3175 * src/maemo/modest-msg-edit-window.c: (get_transports),
3176 (init_window), (modest_msg_edit_window_finalize),
3177 (modest_msg_edit_window_get_msg_data),
3178 (modest_msg_edit_window_free_msg_data):
3179 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3180 (modest_store_widget_finalize):
3181 * src/maemo/modest-transport-widget.c:
3182 (modest_transport_widget_finalize), (smtp_configuration):
3183 * src/modest-main.c: (send_mail):
3184 * src/widgets/modest-combo-box.h:
3185 * src/widgets/modest-global-settings-dialog-priv.h:
3186 * src/widgets/modest-global-settings-dialog.c:
3187 (modest_global_settings_dialog_finalize):
3188 * src/widgets/modest-msg-edit-window.h:
3189 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3190 as long as the combo box, to prevent use of freed memory for the ID.
3192 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3194 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3195 get_accounts(), to make this clearer. Do not check for the enabled gconf
3196 key, because we do not use this for server accounts (at least, not yet).
3197 This allows us to send email again.
3199 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/modest-platform.c:
3202 (on_modest_conf_update_interval_changed), (modest_platform_init):
3203 Only respond to this particular key change. All these strcmp()s cannot be
3206 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3208 * src/maemo/modest-maemo-global-settings-dialog.c:
3209 (current_connection): Prevent a crash in scratchbox when
3210 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3211 * src/maemo/modest-platform.c:
3212 (on_modest_conf_update_interval_changed), (modest_platform_init):
3213 Get the update interval from gconf and reset it when the gconf key changes.
3215 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3217 * src/modest-protocol-info.c:
3218 * src/modest-protocol-info.h: Adde enum-specific get functions,
3219 instead of using a ModestProtocolType enum parameter.
3221 * src/gnome/modest-account-assistant.c:
3222 * src/gnome/modest-store-widget.c:
3223 * src/gnome/modest-store-widget.h:
3224 * src/gnome/modest-transport-widget.c:
3225 * src/gnome/modest-transport-widget.h:
3226 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3227 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3228 * src/maemo/easysetup/modest-easysetup-wizard.c:
3229 * src/maemo/modest-account-settings-dialog.c:
3230 * src/maemo/modest-account-settings-dialog.h:
3231 * src/maemo/modest-store-widget.c:
3232 * src/maemo/modest-store-widget.h:
3233 * src/maemo/modest-transport-widget.c:
3234 * src/maemo/modest-transport-widget.h:
3235 * src/modest-account-mgr-helpers.c:
3236 * src/modest-account-mgr-helpers.h:
3237 * src/modest-account-mgr.c:
3238 * src/modest-account-mgr.h:
3239 * src/modest-tny-account.c:
3240 * src/modest-tny-folder.c:
3241 * src/widgets/modest-account-view.c:
3242 * src/widgets/modest-retrieve-combo-box.c:
3243 * src/widgets/modest-retrieve-combo-box.h:
3244 * src/widgets/modest-secureauth-combo-box.c:
3245 * src/widgets/modest-serversecurity-combo-box.c:
3246 * src/widgets/modest-serversecurity-combo-box.h:
3247 * tests/check_account-mgr.c:
3248 Use the specific functions, and use the re-renamed enum values for GNOME too.
3250 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3252 * src/modest-pair.h:
3253 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3254 so we can get the second based on the first.
3256 * src/maemo/modest-account-settings-dialog.h:
3257 * src/maemo/modest-account-settings-dialog.c:
3258 Added get_supported_secure_authentication_methods(), though it is mostly
3259 commented-out for now until the necessary API is committed to tinymail.
3260 (modest_account_settings_dialog_set_account_name),
3261 (save_configuration): Request the supported authentication methods from the
3262 server, so we can choose a working method.
3264 * src/modest-tny-account-store.h:
3265 * src/modest-tny-account-store.c:
3266 (modest_tny_account_store_get_session): Rename from
3267 tny_account_store_get_session().
3269 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3271 * src/modest-protocol-info.h: Split the ModestProtocol enum
3272 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3273 There was no need to have these unrelated values in one enum.
3275 * src/: many files: Adapted to changed enum. This makes the code a bit
3276 clearer, and the compiler could catch some errors.
3278 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3281 Show the detailed internal camel error message when an error happens
3282 during the configuration, so that our testers can give us more clues.
3283 For instance, in projects.maemo.org bug NB#56910 .
3285 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3287 * src/modest-tny-account.c:
3288 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3289 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3291 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3294 * src/maemo/modest-account-settings-dialog.c:
3295 (modest_account_settings_dialog_set_account_name),
3296 (save_configuration): For the incoming secure authentication checkbox,
3297 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3298 the UI specification. PLAIN does not seem to be supported for most IMAP
3299 servers anyway, and I am not sure what it would mean.
3300 However, we probably need to discover which of the secure-authentication
3301 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3302 * src/modest-account-mgr-helpers.c:
3303 (modest_account_mgr_get_server_account_data):
3305 * src/modest-tny-account.c:
3306 (modest_tny_account_new_from_server_account):
3307 Use tny_account_set_mech() to set secure-authentication methods,
3308 with some special-casing for IMAP, based on my observations of how
3311 * src/modest-account-mgr-helpers.h:
3312 * src/modest-account-mgr.c:
3313 * src/modest-defs.h: Comment that the URI is only used for local folders.
3315 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3317 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3318 parameter const, just to be neat.
3319 * src/modest-text-utils.c: (modest_text_utils_inline):
3320 End g_strconcat() with NULL, as its documentation says. This is almost
3321 certainly the cause of my crash at startup on the device. Interestingly,
3322 valgrind doesn't tell us about these errors.
3324 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3326 * scripts/build-packages: Added more precise comments about how to use
3327 this script, though I still get this error:
3328 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3329 error building tinymail
3331 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/modest-main-window.c: (on_account_update):
3334 Very slight cleanup, hoping to make it simpler to discover what causes
3335 a crash here sometimes.
3337 * src/modest-tny-account.c:
3338 (modest_tny_account_new_from_server_account): Set the port. Added
3339 comments about the options and a TODO comment because I need to find out
3340 how to specify the secure authentication method.
3342 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3344 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3345 changed CFlags paths form modest to libmodest
3347 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3349 * src/modest-account-mgr-helpers.c:
3350 (modest_account_mgr_get_server_account_data),
3351 (modest_account_mgr_free_server_account_data):
3352 * src/modest-account-mgr-helpers.h:
3353 * src/modest-account-mgr.c:
3354 (modest_account_mgr_add_server_account):
3355 * src/modest-defs.h:
3356 * src/modest-tny-account.c:
3357 (modest_tny_account_new_from_server_account):
3358 Determine the options for tny_camel_account_add_option() here,
3359 based on the settings, rather than storing them directly in gconf.
3361 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3363 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3364 Show a more friendly error dialog now that we expect (from the tinymail
3365 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3367 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3369 * src/maemo/modest-main-window.c: (on_account_update): Check that
3370 account_name is not NULL, to prevent a crash at startup that I am
3371 seeing on the N800. I do wonder why it is NULL.
3373 * src/maemo/easysetup/modest-easysetup-wizard.c:
3374 (create_page_user_details):
3375 * src/maemo/modest-account-settings-dialog.c:
3376 (create_page_user_details), (create_page_outgoing):
3377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3378 (modest_connection_specific_smtp_edit_window_init):
3379 * src/modest-ui-actions.c:
3380 (modest_ui_actions_on_password_requested):
3381 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3382 might do something useful with the on-screen keyboard.
3384 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3386 * src/maemo/modest-main-window.c: (on_account_update):
3387 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3388 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3390 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-tny-account-store.c: (on_account_changed):
3393 Correct the signature of this signal handler.
3395 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3397 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3398 Show a HildonNote instead of a GtkDialog for Maemo.
3400 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3402 * src/widgets/modest-account-view.h:
3403 * src/widgets/modest-account-view.c: (on_account_changed),
3404 (on_account_removed). Added a boolean flag, set/unset by
3405 modest_account_view_block_conf_updates(),
3406 modest_account_view_unblock_conf_updates() to prevent unnecessary
3407 updates, but this is not very useful because the gconf notifications are
3408 so delays (maybe only on Maemo Bora).
3409 So auto-updating is turned off, and these functions do an explicit
3410 update when necessary.
3411 However, something else is still doing too much work when adding/removing
3412 accounts, probably in another part of the application.
3414 * src/maemo/modest-account-view-window.c:
3415 (on_delete_button_clicked), (on_edit_button_clicked),
3416 (on_new_button_clicked): Use the new functions.
3418 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3420 * src/modest-account-mgr-helpers.c:
3421 (modest_account_mgr_set_first_account_as_default):
3422 Sort the list of names alphabetically-by-title, so we choose the first one
3424 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3425 alphabetically by the title.
3427 This fixes projects.maemo.org bug NB#56418 .
3429 * src/modest-account-mgr-priv.c:
3430 (_modest_account_mgr_account_from_key):
3431 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3432 avoid a valgrind error, and possible random behaviour.
3434 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3436 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3437 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3438 tinymail documentation to say that this can be expected.
3439 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3440 pretty, and should not happen, but I would prefer to know when it does.
3442 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3444 * configure.ac: When using the older hildon version, probably on Bora,
3445 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3447 * src/widgets/modest-attachment-view.c:
3448 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3451 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3453 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3454 Implemented the prototype. Can be tested with
3455 tests/dbus_api/test_open_message:
3457 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3459 * src/modest-tny-account-store.c:
3460 (modest_tny_account_store_instance_init), (get_password):
3461 * src/modest-ui-actions.c:
3462 (modest_ui_actions_on_password_requested):
3463 Do not store the password in gconf, because this function is called
3464 for non-remembered passwords. Actually use the cached (in the hash map)
3465 password instead of releasing it.
3466 The password will now not be remembered if it is asked via the protected
3467 password dialog, as per the UI spec.
3469 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3471 * src/modest-defs.h:
3472 * src/modest-account-mgr-helpers.h:
3473 * src/modest-account-mgr-helpers.c:
3474 Added modest_server_account_get_username_has_succeeded(),
3475 modest_server_account_set_username_has_succeeded().
3476 (modest_server_account_set_username),
3477 Reset the has-succeeded flag if the username changes.
3479 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3480 * src/maemo/modest-connection-specific-smtp-window.c:
3481 (modest_connection_specific_smtp_window_save_server_accounts):
3482 Use modest_server_account_set_username() instead of using
3483 modest_conf_set_string() directly, so that the has-succeeded flag is always
3486 * src/modest-ui-actions.c:
3487 (modest_ui_actions_on_password_requested): Dim the username entry if
3488 the username has ever worked, as per the UI spec.
3490 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3492 * src/modest-tny-account-store.c: (get_password):
3493 * src/modest-ui-actions.c:
3494 (modest_ui_actions_on_password_requested):
3495 Allow the username to be changed too, though there is more work to
3496 be done on exactly how this behaves.
3498 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3500 * src/modest-account-mgr-helpers.h:
3501 * src/modest-account-mgr-helpers.c:
3502 Added modest_account_mgr_get_display_name(),
3503 modest_server_account_get_username(),
3504 modest_server_account_set_username(),
3505 modest_server_account_set_password(),
3506 modest_server_account_get_hostname() functions so we do not need to
3507 use the conf API directly.
3509 * src/maemo/modest-main-window.c: (connect_signals):
3510 Actually connect ot the ModestAccountStore::request-password signal,
3511 so that we show the dialog when the password is requested by Tinymail,
3512 for isntance if it is empty.
3514 * src/modest-marshal.list:
3515 * src/modest-tny-account-store.c:
3516 (modest_tny_account_store_class_init), (get_password),
3517 (modest_tny_account_store_alert):
3518 * src/modest-tny-account-store.h:
3519 * src/modest-ui-actions.h:
3520 * src/modest-ui-actions.c:
3521 (modest_ui_actions_on_password_requested):
3522 Change the signal parameters, so it is obvious that we are providing
3523 the non human-readable server name, and receiving both the username
3524 and password, though changing of the username is not yet implemented.
3525 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3526 for the GNOME version.
3528 This should fix the projects.maemo.org bug NB#56209, though it does not
3529 work on Bora, because the gconf_client_get() for the password fails
3530 immediately after we save it with gconf_client_set().
3532 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3535 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3536 caused an undefined symbol error:
3537 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3539 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3541 * src/modest-tny-account-store.c:
3542 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3543 using a GError instead of a string message, so we can translate it in
3546 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3548 * src/maemo/modest-address-book.c:
3549 (modest_address_book_check_names):
3550 * src/maemo/modest-msg-view-window.c:
3551 (modest_msg_view_window_clipboard_owner_change):
3552 * src/modest-init.c: (modest_init_init_ui):
3553 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3554 (update_folders_cb), (modest_mail_operation_update_account):
3555 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3556 (modest_ui_actions_on_msg_attachment_clicked),
3557 (modest_ui_actions_on_msg_recpt_activated):
3558 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3559 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3560 (modest_msg_view_search_next):
3561 * src/widgets/modest-recpt-editor.c:
3562 (modest_recpt_editor_on_button_release_event),
3563 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3564 g_message(). At this point we should only be seeing interesting errors on
3565 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3567 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3569 (modest_wizard_dialog_force_title_update):
3570 * src/maemo/easysetup/modest-wizard-dialog.h:
3571 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3572 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3573 can update the title when appropriate. Otherwise the title is wrong if the
3574 pages are added after adding the notebook to the dialog.
3575 This must be a problem in HildonWizardDialog too.
3576 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3578 * src/maemo/easysetup/modest-easysetup-wizard.c:
3579 (create_subsequent_customsetup_pages),
3580 (create_subsequent_easysetup_pages):
3581 Call modest_wizard_dialog_force_title_update() so that the title is
3582 correct even with GTK+ < 2.10.
3583 This fixes projects.maemo.org bug NB#56145 .
3585 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3587 * src/maemo/modest-platform.c:
3588 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3589 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3592 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3594 * src/widgets/modest-window.h:
3595 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3596 and modest_window_save_state(), which invokes it.
3598 * src/widgets/modest-window-mgr.h:
3599 * src/widgets/modest-window-mgr.c:
3600 Added modest_window_mgr_save_state_for_all_windows(), which calls
3601 the save_state vfunc on all registered windows, if implemented.
3603 * src/gnome/modest-msg-edit-window.c:
3604 * src/gnome/modest-msg-view-window.c:
3605 * src/maemo/modest-msg-edit-window.c:
3606 * src/maemo/modest-msg-view-window.c:
3607 * src/maemo/modest-main-window.c:
3608 Specify the existing save_settings functions as implementations of
3609 ModestWindow::save_state_func().
3611 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3612 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3613 enabling hibernation, for instance.
3615 We may need to do the same thing for restoring settings.
3618 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3620 * src/widgets/modest-window-mgr.c:
3621 * src/widgets/modest-window-mgr.h:
3622 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3623 modest_window_mgr_get_hibernation_is_prevented().
3625 * src/maemo/modest-main-window.c:
3626 (on_hildon_program_is_topmost_notify): Prevent hibernation
3627 (possible when the application goes to the background in the WM),
3628 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3630 * src/maemo/easysetup/modest-easysetup-wizard.c:
3631 (modest_easysetup_wizard_dialog_init):
3632 * src/maemo/modest-account-settings-dialog.c:
3633 (modest_account_settings_dialog_init):
3634 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3635 (modest_connection_specific_smtp_edit_window_init):
3636 * src/maemo/modest-connection-specific-smtp-window.c:
3637 (modest_connection_specific_smtp_window_init):
3638 * src/maemo/modest-signature-editor-dialog.c:
3639 (modest_signature_editor_dialog_init):
3640 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3641 prevent hibernation while any of these account settings dialogs are open.
3643 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3645 * src/maemo/Makefile.am:
3646 * src/maemo/modest-osso-state-saving.c:
3647 * src/maemo/modest-osso-state-saving.h: Added
3648 modest_osso_load_state() and modest_osso_save_state() though they do
3649 nothing now. They should iterate through all the open windows and load/save
3651 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3652 save state when closing.
3654 * src/maemo/modest-main-window.c:
3655 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3656 Add a notification handler for the HildonProgram::is-topmost property,
3657 so we can allow hibernation when the application goes into the background.
3658 But we still need to detect when the accounts setup windows are open so
3659 we can stop hibernation when they are open.
3660 To do this, I also added the main window the HildonProgram. This might have
3661 other side-effects/benefits, and should maybe be done for other windows.
3663 * src/maemo/modest-osso-autosave-callbacks.h:
3664 * src/maemo/modest-osso-autosave-callbacks.c:
3665 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3666 though it does not do anything yet, and we might never need this to do
3667 anything. For instance, we already save drafts.
3669 * src/maemo/modest-platform.c: (modest_platform_init):
3670 Specify the libosso auto-save callback.
3672 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3674 * src/maemo/modest-platform.c:
3675 (modest_platform_set_update_interval):
3676 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3677 aparently stays valid between application instances, so we can use this
3678 to remove and reset it later. According to a maemo-developers email from
3681 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3683 * configure.ac: Depend on libalarm for Maemo.
3685 * src/dbus_api/modest-dbus-api.h:
3686 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3687 (on_send_receive), (modest_dbus_req_handler):
3688 Handle a SEND_RECEIVE D-Bus method.
3690 * libmodest-dbus-client/libmodest-dbus-client.c:
3691 (libmodest_dbus_client_send_and_receive):
3692 * libmodest-dbus-client/libmodest-dbus-client.h:
3693 Add C convenience functions for calling the new D-Bus method.
3695 * src/modest-platform.h:
3696 * src/gnome/modest-platform.c:
3697 * src/maemo/modest-platform.c:
3698 Added modest_platform_set_update_interval(), which uses the
3699 alarmd API on Maemo.
3700 (modest_platform_init),
3701 Call modest_platform_set_update_interval(), using a hard-coded
3702 interval for now (until the global settings dialog is implemented),
3703 though I am not sure that this makes sense yet.
3705 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3707 * src/dbus_api/modest-dbus-callbacks.c:
3708 (modest_osso_cb_hw_state_handler):
3709 * src/dbus_api/modest-dbus-callbacks.h:
3710 * src/maemo/modest-platform.c: (modest_platform_init):
3711 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3712 in case this has some effect on the ability for Maemo to ping the
3715 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3717 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3718 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3719 warning. It is probably a logic error, but I need to fix the build.
3721 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3723 * src/modest-account-mgr.h:
3724 * src/modest-account-mgr.c:
3725 (modest_account_mgr_account_names): Add a gboolean enabled_only
3726 parameter, so we can get lists of onlt the enabled accounts.
3728 (modest_account_mgr_add_account),,
3729 (modest_account_mgr_account_with_display_name_exists):
3730 * src/maemo/modest-msg-edit-window.c: (get_transports):
3731 * src/modest-account-mgr-helpers.c:
3732 (modest_account_mgr_set_first_account_as_default):
3733 * src/modest-init.c: (init_default_account_maybe):
3734 * src/modest-tny-account-store.c: (get_accounts):
3735 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3736 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3737 * tests/check_account-mgr.c: (START_TEST):
3738 Provide the extra parameter, as appropriate.
3740 * src/widgets/modest-account-view.c: (update_account_view):
3741 Do not show disabled accounts (meaning that there is no way to
3742 enable/disable accounts in the UI (the feature is not in our UI
3743 specification), so we can use this internally only to mark unfinished
3744 or temporary account data.
3746 * src/maemo/easysetup/modest-easysetup-wizard.c:
3747 (create_account): Add boolean enable parameter, so we can specify FALSE
3748 to create the temporary account.
3749 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3750 (on_before_next): When finishing, when there is a temporary account, just
3752 Also, use a timeout to delay the showing of the dialog until gconf is likely
3753 to return correct information, due to a maemo gconf bug that is fixed in
3754 osso 1.1, but not yet in Bora.
3755 However, the dialog stays on screen after it is destroyed.
3757 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3758 for invalid data when cancelling. Use a hildon note instead of a dialog
3759 to complain about invalid data. Do not show the account-saved note if the
3760 account is disabled (a temporary account that will not really be saved for use
3763 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3765 * src/modest-account-mgr-helpers.h:
3766 * src/modest-account-mgr-helpers.c:
3767 Added modest_account_mgr_unset_default_account(),
3768 Added modest_account_mgr_set_first_account_as_default().
3770 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3771 If it was the default account, unset the default account name.
3773 * src/maemo/modest-account-view-window.c:
3774 (on_delete_button_clicked): If it was the default account,
3775 set the first remaining account as the default instead.
3777 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3778 a NULL account or a NULL default account, to prevent a crash. This should
3779 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3782 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3784 * src/widgets/modest-recpt-editor.c:
3785 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3786 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3787 TODO comment for this. This fixes the build.
3789 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3790 be the best place for it. This will in future update all auto-update accounts,
3791 rather than just the current/default account, when that gconf key exists.
3792 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3793 if there are no accounts, before calling do_send_receive().
3794 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3796 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3797 * src/maemo/modest-main-window-ui.h:
3798 * src/maemo/modest-main-window.c: (on_connection_changed),
3799 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3800 directly, becaue the signal handler does more.
3802 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3804 * src/modest-account-mgr-helpers.c:
3805 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3806 for the case that the account does not exist.
3808 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3809 (equivalent to the modest account name) rather than the tinymail account name
3810 (equivalent to the modest account title - human readable) to get the account data.
3811 Check for null account data to prevent the crash, and add a TODO comment saying that
3812 this needs fixing because it is using the server account name instead of the account name.
3814 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3816 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3817 * src/maemo/modest-account-settings-dialog.c: (show_error),
3819 Use hildon_note_new_information() for informative and error messages,
3820 which seems to be expected for Maemo applications (no documentation that I know of
3821 says this). I am surprised that there is no distinction between info and error
3824 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3826 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3827 it is easy to find where this is used.
3829 * src/maemo/easysetup/modest-easysetup-wizard.c:
3830 (create_page_welcome), (create_page_account_details),
3831 (create_page_user_details), (create_page_complete_easysetup),
3832 (create_page_custom_incoming), (create_page_custom_outgoing),
3833 (create_page_complete_custom):
3834 * src/maemo/modest-account-settings-dialog.c:
3835 (create_page_account_details), (create_page_user_details),
3836 (create_page_incoming), (create_page_outgoing):
3837 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3839 (modest_connection_specific_smtp_edit_window_init):
3840 * src/maemo/modest-connection-specific-smtp-window.c:
3841 (modest_connection_specific_smtp_window_init):
3842 * src/maemo/modest-signature-editor-dialog.c:
3843 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3844 and scrolling policy as per the Email Application Layout Guide, if I have
3847 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3849 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3850 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3851 which were empty, because these vfuncs have been removed from TnyAccountStore.
3852 This fixes the build.
3854 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3856 * src/maemo/modest-main-window.c:
3857 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3858 showing/hiding it. Added TODO because it probably should not be NULL.
3859 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3860 because unnecessary g_warnings() make degugging difficult.
3862 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3864 * src/maemo/modest-msg-edit-window.c:
3865 (modest_msg_edit_window_select_color),
3866 (modest_msg_edit_window_select_background_color): 2 const corrections and
3867 moving 2 #endifs before closing brackets, to fix the build.
3869 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3871 * src/maemo/easysetup/modest-easysetup-wizard.h:
3872 * src/maemo/easysetup/modest-easysetup-wizard.c:
3873 (modest_easysetup_wizard_dialog_finalize),
3874 (on_button_edit_advanced_settings), (create_page_complete_custom),
3875 (on_response), (create_account):
3876 Implement the Advanced Settings edit button, by saving the account information,
3877 for the Advanded Settings dialog to use directly from gconf, and removing it
3878 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3879 Bug #5533 in the projects.maemo.org bugzilla.
3881 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3883 * src/maemo/modest-msg-view-window.c:
3884 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3885 when opening a message window.
3887 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3889 * src/maemo/easysetup/modest-easysetup-wizard.c:
3890 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3893 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3894 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3895 gconf settings. I probably added more checks than necessary, but that is safer.
3897 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3898 variable to fix the build, but this seems to be used when it is still NULL.
3900 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3902 * src/modest-platform.h:
3903 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3904 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3905 * src/modest-main.c: Implement this function so we can avoid using
3906 maemo-specific API from cross-platform code.
3908 * src/modest-tny-account-store.c:
3909 (get_smtp_specific_transport_account_for_open_connection):
3910 * src/modest-ui-actions.c: (check_for_connection),
3911 (modest_ui_actions_on_item_not_found):
3912 Use modest_platform_connect_and_wait() and put #idefs around other
3913 maemo-specific code, because only maemo currently has a way to
3914 identify connection names.
3916 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3918 * src/modest-tny-account-store.h:
3919 * src/modest-tny-account-store.c:
3920 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3921 the connection-specific SMTP server settings in the configuration.
3923 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3925 * src/maemo/modest-main-window.c: (on_connection_changed),
3927 * src/modest-main.c: (main), (start_ui), (send_mail):
3928 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3929 that is what is intended.
3931 * src/modest-ui-actions.c: (action_send), (action_receive),
3932 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3933 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3934 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3935 SMTP server is used when it is specified.
3937 (modest_ui_actions_on_send_receive):
3938 Check that a connection is open before proceeding.
3939 Receive and then send, instead of vice-versa, as per the specification.
3941 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3943 * src/modest-mail-operation.c:
3944 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3945 though I guess it should be something other than NULL.
3947 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3949 * src/maemo/easysetup/modest-easysetup-wizard.c:
3950 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3951 combo twice, to avoid an g_warning and to make it visible again.
3952 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3953 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3954 (already intended) dereference when detaching, because we then recreate the menu.
3955 But I am not sure why the warning was happening, and it is possible that this is a memory
3958 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3960 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3961 and uri_parse_mailto() utility functions.
3962 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3964 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3966 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3968 * src/dbus_api/modest-dbus-api.h:
3969 * src/dbus_api/modest-dbus-callbacks.c:
3970 Use an idle callback to execute the modest code in the application's own thread.
3971 Remove the helloworld example method.
3972 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3973 parsed, and the open-message method is not implemented because this is not yet implemented in
3975 * libmodest-dbus-client/libmodest-dbus-client.c:
3976 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3977 (libmodest_dbus_client_open_message):
3978 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3980 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3981 body without crashing.
3983 * tests/dbus_api/Makefile.am:
3984 * tests/dbus_api/test_mail_to.c:
3985 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3987 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3989 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3990 Added file to fix the build. Sorry.
3992 * src/dbus_api/Makefile.am:
3993 * src/dbus_api/modest-dbus-api.h:
3994 * src/dbus_api/modest-dbus-callbacks.h:
3995 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3996 (modest_dbus_req_handler):
3997 Put constants in a separate header so it can be reused by the
3998 client library, without duplication
4000 * libmodest-dbus-client/Makefile.am:
4001 * libmodest-dbus-client/libmodest-dbus-client.c:
4002 (libmodest_dbus_client_call_helloworld),
4003 (libmodfest_dbus_client_send_mail),
4004 (libmodfest_dbus_client_mailto),
4005 (libmodfest_dbus_client_open_message):
4006 * libmodest-dbus-client/libmodest-dbus-client.h:
4007 (Partly) Implement a send_mail D-Bus method.
4009 * tests/dbus_api/Makefile.am:
4010 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4011 the send_email D-Bus method.
4013 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4017 * libmodest-dbus-client/Makefile.am:
4018 * libmodest-dbus-client/libmodest-dbus-client.c:
4019 * libmodest-dbus-client/libmodest-dbus-client.h:
4020 * tests/dbus_api/Makefile.am:
4021 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4022 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4024 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4026 * src/maemo/easysetup/modest-easysetup-wizard.c:
4027 (create_page_account_details):
4028 * src/maemo/modest-account-settings-dialog.c:
4029 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4030 widgets, because this might not be the default in future versions of the Maemo GTK+.
4031 However, I can not not get capitalization to work even in a simple test case.
4033 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4035 * src/maemo/easysetup/modest-easysetup-wizard.c:
4036 (create_page_custom_incoming), (create_page_custom_outgoing):
4037 * src/maemo/modest-account-settings-dialog.c:
4038 (create_page_account_details), (create_page_incoming),
4039 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4040 instead of using gtk_check_button_with_label(), so they are aligned like the other
4041 widgets, as per the UI spec.
4043 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4045 * src/maemo/easysetup/modest-easysetup-wizard.c:
4046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4047 * src/widgets/modest-validating-entry.c:
4048 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4049 Modest prefix instead of an EasySetup prefix.
4051 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4053 * src/widgets/modest-validating-entry.h:
4054 * src/widgets/modest-validating-entry.c: (on_insert_text),
4055 Added easysetup_validating_entry_set_max_func(), used to set a callback
4056 to call when the max number of characters is reached. GtkEntry has a max-length
4057 already but is silent about it.
4059 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4060 (create_page_account_details), (create_page_user_details),
4062 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4063 (create_page_account_details), (create_page_user_details),
4064 (create_page_outgoing):
4065 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4066 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4067 the UI spec, when the user tries to enter more than the max number of characters.
4069 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4071 * src/maemo/easysetup/modest-easysetup-wizard.c:
4072 (create_page_user_details), (create_page_custom_incoming),
4073 (create_page_custom_outgoing):
4074 * src/maemo/modest-account-settings-dialog.c:
4075 (create_page_user_details), (create_page_incoming),
4076 (create_page_outgoing):
4077 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4078 (modest_connection_specific_smtp_edit_window_init):
4079 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4080 not appropriate. Bad Maemo-specific defaults!.
4082 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4084 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4085 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4086 (modest_signature_editor_dialog_set_settings):
4087 Disable the label and textview when the checkbox is disabled, and use the
4088 specified (UI spec) default signature text.
4090 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4093 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4095 * src/modest-defs.h:
4096 * src/modest-account-mgr-helpers.h:
4097 * src/modest-account-mgr-helpers.c:
4098 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4100 * src/maemo/Makefile.am:
4101 * src/maemo/modest-signature-editor-dialog.c:
4102 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4105 * src/maemo/modest-account-settings-dialog.h:
4106 * src/maemo/modest-account-settings-dialog.c:
4107 (modest_account_settings_dialog_finalize), (on_button_signature),
4108 (save_configuration): Use the new dialog when the Edit button is pressed, and
4109 save the changes if necessary, as per the UI spec.
4111 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4113 * src/maemo/Makefile.am:
4114 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4115 based on maemo-develoers email from Dirk.
4117 * src/maemo/easysetup/modest-easysetup-wizard.c:
4118 (create_page_welcome), (create_page_account_details),
4119 (create_page_user_details), (create_page_complete_easysetup),
4120 (create_page_custom_incoming), (create_page_custom_outgoing),
4121 (create_page_complete_custom),
4122 (modest_easysetup_wizard_dialog_init):
4123 * src/maemo/modest-account-settings-dialog.c:
4124 (create_page_account_details), (create_page_user_details),
4125 (create_page_incoming), (create_page_outgoing),
4126 (modest_account_settings_dialog_init):
4127 * src/maemo/modest-connection-specific-smtp-window.c:
4128 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4130 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4132 * src/maemo/easysetup/modest-easysetup-wizard.c:
4133 (create_page_account_details), (create_page_custom_outgoing),
4134 (create_page_complete_custom):
4135 * src/maemo/modest-account-settings-dialog.c:
4136 (create_page_user_details), (create_page_incoming),
4137 (create_page_outgoing):
4138 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4139 (modest_connection_specific_smtp_edit_window_init):
4140 Use the correct (UI spec) port min/max, and use horizontal separators,
4143 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4145 * src/maemo/easysetup/modest-easysetup-wizard.c:
4146 (set_default_custom_servernames):
4147 * src/maemo/modest-account-settings-dialog.c:
4148 (create_page_incoming), (on_combo_outgoing_security_changed),
4149 (on_combo_incoming_security_changed), (create_page_outgoing),
4150 (modest_account_settings_dialog_set_account_name),
4151 (save_configuration):
4152 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4153 (on_combo_security_changed),
4154 (modest_connection_specific_smtp_edit_window_init),
4155 (modest_connection_specific_smtp_edit_window_set_connection),
4156 (modest_connection_specific_smtp_edit_window_get_settings):
4157 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4160 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4163 * src/maemo/easysetup/modest-easysetup-wizard.c:
4164 (create_page_custom_outgoing), (create_page_complete_custom):
4165 * src/maemo/modest-account-settings-dialog.c:
4166 (create_page_user_details), (create_page_outgoing):
4167 * src/maemo/modest-account-view-window.c: (button_box_new):
4168 Use changed logical IDs as per the most recent UI spec:
4169 mcen_bd_emailsetup_edit -> mcen_bd_edit
4170 mcen_bd_emailsetup_delete -> mcen_bd_delete
4171 mcen_bd_emailsetup_close -> mcen_bd_close
4173 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4177 * src/dbus_api/Makefile.am:
4178 * src/dbus_api/modest-dbus-callbacks.c:
4179 * src/dbus_api/modest-dbus-callbacks.h:
4180 * src/maemo/modest-platform.c: (modest_platform_init):
4181 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4183 * tests/Makefile.am:
4184 * tests/dbus_api/Makefile.am:
4185 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4187 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4189 * src/maemo/modest-account-settings-dialog.c:
4190 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4191 Removed unnecessary includes.
4193 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4195 * src/maemo/easysetup/modest-easysetup-wizard.c:
4196 * src/maemo/modest-account-settings-dialog.c:
4197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4198 * src/widgets/Makefile.am:
4199 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4200 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4201 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4202 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4203 * src/widgets/modest-secureauth-combo-box.c:
4204 * src/widgets/modest-secureauth-combo-box.h:
4205 * src/widgets/modest-serversecurity-combo-box.c:
4206 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4207 made the GObject names more consistent with the rest of the Modest code.
4209 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4211 * src/maemo/easysetup/Makefile.am:
4212 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4213 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4214 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4215 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4216 * src/maemo/easysetup/modest-easysetup-wizard.c:
4217 * src/maemo/easysetup/modest-validating-entry.c:
4218 * src/maemo/easysetup/modest-validating-entry.h:
4219 * src/maemo/modest-account-settings-dialog.c:
4220 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4221 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4222 widgets/ because they are used outside of easysetup too. After checking in,
4223 svn will allow me to rename them too.
4225 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4227 * src/gnome/modest-msg-edit-window.c:
4228 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4229 linker error, to fix the build on the GNOME platform.
4230 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4231 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4232 ifdefed out to avoid a warning.
4234 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4236 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4237 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4238 some alternative for GTK+ 2.6.
4240 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4242 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4244 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4245 specified for EmailAccountsDialog in UI spec.
4247 * src/maemo/easysetup/modest-easysetup-wizard.c:
4248 * src/maemo/easysetup/modest-easysetup-wizard.h:
4249 * src/maemo/modest-account-settings-dialog.c:
4250 * src/maemo/modest-account-settings-dialog.h:
4251 Reuse a member window widget for the connection-specific SMTP server accounts,
4252 so we can tell it to create/save the accounts only if we actually save changes.
4254 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4256 (modest_connection_specific_smtp_edit_window_get_settings):
4257 Return a struct instance for temporarily remembering the entered data.
4259 * src/maemo/modest-connection-specific-smtp-window.h:
4260 * src/maemo/modest-connection-specific-smtp-window.c:
4261 (modest_connection_specific_smtp_window_finalize),
4262 (modest_connection_specific_smtp_window_fill_with_connections),
4264 (modest_connection_specific_smtp_window_save_server_accounts),
4265 (update_model_server_names): Do not actually save data until asked,
4266 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4268 (on_selection_changed),
4269 (modest_connection_specific_smtp_window_init): Disable the edit
4270 button when nothing is selected.
4272 * src/modest-account-mgr-helpers.c:
4273 * src/modest-account-mgr-helpers.h:
4274 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4277 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4279 * src/modest-account-mgr-helpers.h:
4280 * src/modest-account-mgr-helpers.c:
4281 (modest_account_mgr_get_unused_account_name),
4282 (modest_account_mgr_get_unused_account_display_name): Added these
4283 utility functions, to avoid code duplication.
4285 * src/maemo/easysetup/modest-easysetup-wizard.c:
4286 (create_page_account_details), (create_account):
4287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4288 (on_combo_security_changed),
4289 (modest_connection_specific_smtp_edit_window_init),
4290 (modest_connection_specific_smtp_edit_window_save_settings):
4291 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4292 * src/maemo/modest-connection-specific-smtp-window.c:
4293 (modest_connection_specific_smtp_window_finalize),
4294 (modest_connection_specific_smtp_window_fill_with_connections),
4295 (on_button_edit), (modest_connection_specific_smtp_window_init):
4296 * src/maemo/modest-connection-specific-smtp-window.h:
4297 Implementing saving of connection-specific server accounts.
4299 But I need to refactor this so we can save the data for each
4300 possible connection-specific account and only actually create the server accounts
4301 when the easysetup finished, or the OK button is pressed on the account settings
4304 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4306 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4307 (on_combo_security_changed):
4308 (modest_connection_specific_smtp_edit_window_init):
4309 Auto-fill the port number as in the account settings.
4311 (modest_connection_specific_smtp_edit_window_set_connection):
4312 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4313 * src/maemo/modest-connection-specific-smtp-window.c:
4314 (fill_with_connections), (on_button_edit),
4315 (modest_connection_specific_smtp_window_init):
4316 Turn the edit window into a dialog to simplify the code, and
4317 set a WM hint as in a GtkDialog, because only a popup can be on top of
4318 another window in Maemo, and popups usually have no WM decoration.
4320 * src/modest-defs.h:
4321 * src/modest-account-mgr-helpers.c:
4322 (modest_account_mgr_set_connection_specific_smtp),
4323 (modest_account_mgr_remove_connection_specific_smtp),
4324 (modest_account_mgr_get_connection_specific_smtp):
4325 * src/modest-account-mgr-helpers.h: Some functions to write the
4326 connection-specific SMTP server information. Not yet used.
4329 * src/widgets/modest-folder-view.c: (text_cell_data):
4330 Fix a warning about an uninitialized variable.
4331 (on_configuration_key_changed): Put an #ifdef around the use
4332 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4334 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4336 * src/maemo/modest-account-settings-dialog.h:
4337 * src/maemo/modest-account-settings-dialog.c:
4338 Added connect_for_modified() utility function to mark the new modified boolean.
4340 (create_page_account_details), (create_page_user_details),
4341 (create_page_incoming), (create_page_outgoing), (on_response),
4342 (modest_account_settings_dialog_init),
4343 (modest_account_settings_dialog_set_account_name):
4344 Only warn about unsaved changes when there are actually unsaved changes.
4346 * src/modest-account-mgr-helpers.c:
4347 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4348 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4349 to get the data from there in future.
4351 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4353 * src/modest-defs.h:
4355 * src/modest-account-mgr-helpers.h:
4356 * src/modest-account-mgr-helpers.c:
4357 Store the security account setting in a single conf key instead of using
4358 the options list, so that the list is left for just the to-be-removed camel hack,
4359 and because gconf_client_set_list() is failing for some reason.
4361 * src/modest-account-mgr.c:
4362 (modest_account_mgr_add_server_account):
4363 * src/maemo/modest-account-settings-dialog.c:
4364 (modest_account_settings_dialog_set_account_name),
4365 (save_configuration): Use the renamed functions.
4368 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4370 * src/widgets/Makefile.am:
4371 * src/widgets/modest-limit-retrieve-combo-box.c:
4372 * src/widgets/modest-limit-retrieve-combo-box.h:
4373 * src/widgets/modest-retrieve-combo-box.c:
4374 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4375 the account settings dialog.
4377 * src/modest-defs.h:
4378 * src/modest-account-mgr-helpers.h:
4379 * src/modest-account-mgr-helpers.c:
4380 (modest_server_account_get_option_secure_auth),
4381 (modest_server_account_set_option_secure_auth):
4382 * src/modest-account-mgr.c:
4383 (modest_account_mgr_add_server_account):
4384 Use the existing AUTH_MECH conf key for the secure-auth setting,
4385 instead of putting it in the list options, because this was actually used already.
4387 * src/maemo/modest-account-settings-dialog.c:
4388 (create_page_account_details),
4389 (modest_account_settings_dialog_set_account_name),
4390 (save_configuration):
4391 * src/maemo/modest-account-settings-dialog.h:
4392 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4393 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4395 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4397 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4398 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4399 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4401 * src/modest-defs.h:
4402 * src/maemo/modest-account-settings-dialog.c:
4403 (create_page_incoming), (on_combo_outgoing_security_changed),
4404 (on_combo_incoming_security_changed), (create_page_outgoing),
4405 (modest_account_settings_dialog_set_account_name),
4406 (save_configuration): Load/Save the port number, and change it when the
4407 security combo changes, to suitable defaults.
4409 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4411 * src/modest-account-mgr.c:
4412 (modest_account_mgr_add_server_account): Set the security and secure-auth
4413 options, and add a comment saying that the other camel-specific options should be
4416 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4418 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4420 * src/modest-tny-account-store.c: (account_list_free),
4421 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4422 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4425 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4427 * src/modest-protocol-info.c:
4428 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4429 is required by our UI spec. Maybe something in our implementation will use this eventually.
4430 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4431 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4432 instead of the previous 0 placeholder.
4434 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4435 secure-auth settings.
4436 * src/modest-account-mgr-helpers.h:
4437 * src/modest-account-mgr-helpers.c:
4438 (modest_server_account_data_get_option_secure_auth),
4439 (modest_server_account_set_option_secure_auth),
4440 (modest_server_account_data_get_option_security),
4441 (modest_server_account_set_option_security): Added this API for getting and setting the security
4442 and secure-auth settings.
4444 * src/maemo/modest-account-settings-dialog.h:
4445 * src/maemo/modest-account-settings-dialog.c:
4446 (modest_account_settings_dialog_finalize), (check_data),
4447 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4448 about changing titles.
4449 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4450 (save_configuration): Save the security and secure-auth settings.
4452 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4453 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4455 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4457 * src/modest-defs.h:
4458 * src/modest-account-mgr.c:
4459 (modest_account_mgr_add_server_account):
4460 Added and used defines for the options key and value pair strings,
4461 that are used so far, though they do not seem to correspond to anything in our
4462 UI specs or ModestProtocol enum.
4464 * src/modest-account-mgr-helpers.h:
4465 * src/modest-account-mgr-helpers.c:
4466 (compare_option_strings_for_name),
4467 (modest_server_account_data_get_option_value),
4468 (modest_server_account_data_get_option_bool),
4469 (modest_account_mgr_get_server_account_option):
4470 Added helper functions for parsing the options GSList.
4472 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4474 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4475 display name is based on the supplied account name.
4476 * src/modest-account-mgr.c:
4477 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4478 with an inefficient, but good-enough, implementation.
4480 * src/maemo/easysetup/modest-easysetup-wizard.c:
4481 (create_page_account_details), (on_before_next), (create_account):
4482 Check for existing display names rather than (non-user-visible) account names, and just
4483 create and set a unique account name at the end.
4485 * src/maemo/modest-account-settings-dialog.c:
4486 (modest_account_settings_dialog_init),
4487 (modest_account_settings_dialog_set_account_name),
4488 (create_page_incoming): Show the display name, instead of the account name.
4489 (on_response): Do some (not all) extra checks, as in the UI spec.
4490 (save_configuration): Save the display name if it was changed.
4492 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4494 * po/en_GB.po: Added needed logical ID and translation.
4495 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4496 (init_view): Made the is-default column clicking work.
4498 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4501 * src/maemo/easysetup/Makefile.am:
4502 * src/maemo/easysetup/modest-easysetup-wizard.c:
4503 (modest_easysetup_wizard_dialog_init):
4504 * src/maemo/easysetup/provider-data-test.keyfile:
4505 * src/maemo/easysetup/provider-data.keyfile:
4506 Moved the provider data file to the new modest-providers-data package and used it from there.
4508 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4510 * src/modest-local-folder-info.c:
4511 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4512 N_() was already used on the static strings, but this just marks it for translation without
4513 using the translation.
4515 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4517 * src/maemo/modest-account-settings-dialog.c:
4518 (create_page_incoming),
4519 (modest_account_settings_dialog_set_account_name):
4520 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4521 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4522 I will do this if nobody else gets there first.
4524 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4526 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4527 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4528 save the security stuff.
4530 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4532 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4533 Set the email address and user fullname, which I now see must be
4536 * src/maemo/modest-account-settings-dialog.h:
4537 * src/maemo/modest-account-settings-dialog.c:
4539 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4540 leave-on-server and authentication.
4541 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4544 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4547 * src/maemo/modest-account-settings-dialog.c:
4548 * src/maemo/modest-account-settings-dialog.h:
4549 Most (but not all) of the widgets are now present as specified by the UI spec.
4550 No changes are yet saved, and some details are not properly shown yet.
4552 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4554 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4556 * src/maemo/Makefile.am:
4557 * src/maemo/modest-account-settings-dialog.c:
4558 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4559 an existing account. Doesn't do much yet.
4561 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4562 Open the accounts settings dialog when Edit is clicked.
4564 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4566 * src/maemo/easysetup/Makefile.am:
4567 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4569 * src/maemo/easysetup/modest-easysetup-wizard.c:
4570 (modest_easysetup_wizard_dialog_init):
4571 Try to get the source directory from the build system,
4572 instead of hard-coding "./" into the source code, when opening our local
4573 copies of the configuration files.
4574 But this still fails when opening the wizard from the Accounts window,
4575 maybe because the working directory seems to change at runtime.
4576 So the wizard will fail the second time unless you copy the files into their
4577 proper locations - see the stdout warnings for the paths.
4579 (create_page_account_details),(on_before_next):
4580 Check for existing non-server accounts instead of server accounts,
4581 so the default account name is useful again, and to prevent trying to
4584 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4585 Show the wizard when New is clicked.
4587 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4588 (init_view): Show the column headers, and show the columns that are
4589 specified in the UI specs. However, something in Maemo's GTK+ prevents
4590 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4591 change the default account. This is despite unsetting the special properties.
4593 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4595 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4596 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4597 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4598 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4599 to make that clearer.
4600 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4602 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4604 * src/maemo/modest-account-view-window.c:
4605 (modest_account_view_window_init),
4606 (modest_account_view_window_new):
4607 Use the same buttons as specified in the
4608 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4609 the existing widgets, which never had a chance of working.
4610 Put the ModestAccountView treeview in a scrolled window.
4611 Do not repeat the initialization in both _init() and _new().
4613 * src/widgets/modest-account-view.c: (update_account_view):
4614 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4615 this widget and window shows no accounts.
4617 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4619 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4621 * src/maemo/easysetup/modest-easysetup-wizard.c:
4622 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4623 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4624 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4627 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4628 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4629 accounts exist yet, as in the UI spec.
4631 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4633 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4635 * src/maemo/Makefile.am:
4636 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4637 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4638 New window for editing connection-specific smtp details.
4639 Not fully implemented.
4641 * src/maemo/modest-connection-specific-smtp-window.c:
4642 (modest_connection_specific_smtp_window_finalize) :
4643 unref the tree model.
4644 (on_button_edit): Show the edit window.
4646 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4648 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4651 * src/maemo/Makefile.am:
4652 * src/maemo/modest-connection-specific-smtp-window.c:
4653 * src/maemo/modest-connection-specific-smtp-window.h:
4654 New window for showing the list of connections, for connection-specific
4655 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4656 * src/maemo/easysetup/modest-easysetup-wizard.c:
4657 (create_page_custom_outgoing): Show the new window when the button is clicked.
4659 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4661 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4662 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4663 * src/maemo/modest-msg-edit-window.c:
4664 (modest_msg_edit_window_insert_image):
4665 * src/modest-conf.c: (modest_conf_key_escape):
4666 * src/modest-mail-operation.c:
4667 (modest_mail_operation_send_new_mail):
4668 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4669 (modest_ui_actions_on_new_account):
4670 * src/widgets/modest-attachment-view.c: (update_filename_request):
4671 * src/widgets/modest-mail-header-view.c:
4672 Corrected warnings that were breaking the build, by commenting out unused variables,
4673 and a function, and by including a header.
4675 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4677 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4678 so we can #ifdef around platform-specific code when necessary.
4679 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4680 to allow this to build for the GNOME platform too.
4682 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4684 * src/maemo/easysetup/modest-easysetup-wizard.c:
4685 Added util_increment_name() and used it in create_page_account_details()
4686 to make sure that the default account name is always a new name.
4688 (modest_easysetup_wizard_dialog_init),
4689 (set_default_custom_servernames): Some minor memory management fixes.
4691 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4695 * src/modest-runtime.c: (init_i18n): Restored the translation
4696 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4697 are defined in config.h, and the translations are installed.
4699 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4700 is defined for translation.
4702 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4704 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4706 * src/maemo/easysetup/modest-easysetup-wizard.c:
4707 (modest_easysetup_wizard_dialog_init):
4708 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4709 Use realistic paths (though they should use $prefix generically) to the
4710 mcc_mapping and provider-data.keyfile files which might work when they
4711 are installed by the future version of the operator-wizard package,
4712 and then fallback to paths in our source code, with an explanatory
4715 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4719 * src/maemo/Makefile.am:
4720 * src/maemo/easysetup/: Added files from the previously-exernal
4721 osso-modest-easysetup.
4722 * src/maemo/modest-main-window-ui.h:
4723 * src/modest-ui-actions.c:
4724 * src/modest-ui-actions.h:
4725 Added modest_ui_actions_on_new_account() as a signal handler for the
4726 New Account menu item. It shows the easysetup wizard.
4727 * po/en_GB.po: Added additional needed logical IDs and translations.