1 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
4 Fixed icon size by using (50, 50) which is the same as defined by
7 2007-06-25 Armin Burgmeier <armin@openismus.com>
9 * src/widgets/modest-window-mgr.c:
11 * configure.ac: Correctly recognize hildon-notify presence and fixed
12 the build without it being installed.
14 2007-06-25 Murray Cumming <murrayc@murrayc.com>
16 * libmodest-dbus-client/libmodest-dbus-client.c:
17 (libmodest_dbus_client_search): Fix the build. Sorry.
18 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
19 (reply_forward_cb): Initialize variables to fix the build.
21 * src/modest-tny-account-store.c:
22 (modest_tny_account_store_get_tny_account_by): Fix the account URI
23 comparison (a silly typo) so that email search results can be opened
24 when there are more than one account.
26 2007-06-25 Murray Cumming <murrayc@murrayc.com>
28 * libmodest-dbus-client/libmodest-dbus-client.c:
29 (libmodest_dbus_client_search),
30 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
31 instead of 1 second, because the search gets folders and messages from
32 the server, which can take a long time. When it times out,
33 osso-global-search will report no results.
35 We need to specify whether we should search only cached information
36 (maybe with a user preference), and the osso-email-search-plugin
37 API should really be improved to allow that option, and to allow results
38 to be delivered asynchronously in batches.
40 2007-06-25 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
43 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
44 GTK_ICON_SIZE_DIALOG is probably the wrong size.
46 2007-06-25 Murray Cumming <murrayc@murrayc.com>
48 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
49 that is an empty string. D-Bus seems to give us these instead of NULL.
51 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
53 * src/dbus_api/modest-dbus-callbacks.c:
54 * src/maemo/easysetup/modest-easysetup-wizard.h:
55 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
56 * src/maemo/modest-connection-specific-smtp-edit-window.c:
57 (modest_connection_specific_smtp_edit_window_init):
58 * src/maemo/modest-maemo-global-settings-dialog.c:
60 * src/maemo/modest-maemo-utils.c:
61 (modest_maemo_utils_setup_images_filechooser):
62 * src/maemo/modest-main-window.c: (create_details_widget):
63 * src/maemo/modest-msg-edit-window.c:
64 (modest_msg_edit_window_attach_file_noninteractive),
65 (modest_msg_edit_window_color_button_change),
66 (modest_msg_edit_window_set_zoom):
67 * src/modest-mail-operation.c: (update_account_thread):
68 * src/modest-tny-account-store.c:
69 * src/modest-tny-account.c:
70 * src/widgets/modest-global-settings-dialog.c:
71 * src/widgets/modest-window.h:
75 2007-06-25 Murray Cumming <murrayc@murrayc.com>
77 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
78 * src/modest-search.c: (modest_search_folder),
79 (modest_search_all_accounts): Actually search only in the specified folder,
80 doing a simple match on the folder ID.
81 * src/modest-search.h: Added a folder field to the ModestSearch struct,
82 and added some documentation.
84 2007-06-22 Armin Burgmeier <armin@openismus.com>
86 * src/maemo/modest-maemo-utils.h:
87 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
88 modest_maemo_utils_get_supported_secure_authentication_methods.
90 * src/maemo/easysetup/modest-easysetup-wizard.c:
91 * src/maemo/modest-account-settings-dialog.c: Show correct error if
92 one occured, not just "Server does not support secure authentication".
94 2007-06-22 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-tny-account-store.c: (get_password):
97 Restored the call to tny_account_set_user() because Philip seems to have
98 stopped this from crashing (by not using the freed string). It still does
99 not work, but now we can test it.
101 2007-06-22 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-msg-edit-window.c: (init_window):
104 Comment out use of an uninitialzed GtkScrolledWindow variable,
105 to fix the build and stop a crash. Yet again.
107 2007-06-22 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-tny-account-store.c: (get_password):
110 Remove the call to tny_account_set_user() because this actually crashes.
111 As mentioned in the last commit, it is known to not work anyway.
113 2007-06-22 Murray Cumming <murrayc@murrayc.com>
115 * src/modest-tny-account-store.c: (get_password):
116 Use tny_account_set_username() to tell tinymail that the username might
117 have changed too. But tinymail ignores this: see projects.maemo.org
119 * src/modest-ui-actions.c:
120 (modest_ui_actions_on_password_requested): Remove the useless attempt to
121 reset the connection when changing the username, and improve the comments.
122 Save the changed username to gconf at least, so it is used when Modest is
125 2007-06-21 Murray Cumming <murrayc@murrayc.com>
127 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
128 Do not use a query, so that we get all folders, including for POP and
129 local-folders. They work as search criteria too.
130 This fixes projects.maemo.org bug NB#57740.
132 2007-06-21 Murray Cumming <murrayc@murrayc.com>
134 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
135 Comment out the use of hildon_notification_set_sound() because it is
136 not declared, to fix the build. Warnings are serious, people.
138 2007-06-21 Armin Burgmeier <armin@openismus.com>
140 * src/maemo/modest-maemo-utils.h:
141 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
142 modest_maemo_utils_get_supported_secure_authentication_methods()
143 to query authentication methods for a specific user. This should fix
144 projects.maemo.org bug NB#61369.
146 * src/maemo/easysetup/modest-easysetup-wizard.c:
147 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
150 2007-06-21 Murray Cumming <murrayc@murrayc.com>
152 * libmodest-dbus-client/libmodest-dbus-client.h:
153 * libmodest-dbus-client/libmodest-dbus-client.c:
154 (modest_dbus_message_iter_get_search_hit),
155 (libmodest_dbus_client_search):
156 Reorganised and commented this.
157 Removed modest_search_hit_free() from the public API because it
160 Added libmodest_dbus_client_get_folders() and
161 modest_folder_result_list_free().
163 * src/dbus_api/modest-dbus-api.h:
164 * src/dbus_api/modest-dbus-callbacks.c:
165 (modest_dbus_req_filter): Commented. Moved most code to
166 on_dbus_method_search() and added on_dbus_method_get_folders().
168 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
169 of the extra D-Bus handler.
171 * tests/dbus_api/Makefile.am:
172 * tests/dbus_api/test_get_folders.c: New test for
173 libmodest_dbus_client_get_folders(). This seems to return an empty list
174 at the moment. That could be the same error that causes the message list
175 to be empty sometimes.
176 This should help with projects.maemo.org bug NB#57740.
178 2007-06-21 Armin Burgmeier <armin@openismus.com>
180 * src/modest-mail-operation.c: Do not call
181 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
182 notify the operation's end after having set the status to CANCELED for
183 the operation queue to listen on. This fixes a deadlock when there
184 were mail operations in the queue during its finalization.
186 * src/modest-singletons.c: Reordered uninitialization of the account
187 manager to happen after the mail operation queue was uninitialized
188 because the mail operation's in the queue might still try to access
189 the account manager (see modest_mail_operation_notify_end()). This
190 fixes a potential crash when terminating the application.
192 2007-06-21 Murray Cumming <murrayc@murrayc.com>
194 * src/modest-search.c:
195 (search_mime_part_and_child_parts): Moved some code here so we
196 can search recursively in child folders.
197 (modest_search_folder): Search in the message as a mime part, instead
198 of just its child mime parts.
199 (read_chunk), (search_mime_part_ogs):
200 Check how many bytes were read, to prevent an endless loop.
201 Searching in message bodies now works. This finishes the fix for
202 projects.maemo.org bug NB#61007.
204 2007-06-20 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
207 Add a g_warning when the item is not a folder.
209 * src/modest-ui-dimming-rules.c:
210 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
211 when selected item is not a folder (for instance, an account), because
212 the UI spec only talks about folders.
213 I am not sure what the UI spec wants, so this might not totally fix
214 projects.maemo.org bug NB#60794.
216 2007-06-20 Murray Cumming <murrayc@murrayc.com>
218 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
219 (load_from_file): Sort the list. The unsorted list would be more noticeable
220 in non-English locales.
222 * src/maemo/modest-msg-edit-window.c:
223 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
224 warning and fix the build.
226 * src/maemo/modest-progress-bar-widget.c:
227 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
228 avoid a g_warning, and probably to avoid a crash.
230 2007-06-20 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-search.c: (modest_search_folder): Check for a GError
233 when calling tny_folder_get_headers(), to show that this is not the cause
236 2007-06-20 Murray Cumming <murrayc@murrayc.com>
238 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
239 Actually set the body query instead of the subject query.
241 * src/modest-search.c: (search_mime_part_ogs),
242 (search_mime_part_strcmp): Remove extra space from the text/* regex,
243 which would probably cause it to fail if we got this far.
245 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
246 to simplify the code.
247 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
248 be causing search-in-body to fail.
250 2007-06-20 Murray Cumming <murrayc@murrayc.com>
252 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
254 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
255 Better debug message when the folder cannot be found.
256 This should help with fixing projects.maemo.org bug #61287.
257 * src/modest-search.c: (add_hit): Do not leak the furl string.
259 2007-06-20 Murray Cumming <murrayc@murrayc.com>
261 * src/modest-ui-actions.c:
262 (modest_ui_actions_on_folder_selection_changed):
263 Do not special-case TNY_MERGE_FOLDER here, because
264 modest_tny_folder_get_account() already does that. This fixes
265 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
266 shown when the Outbox was selected).
268 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
270 * libmodest-dbus-client/libmodest-dbus-client.c:
271 (_dbus_iter_get_string_or_null): Initialize the string variable in
272 case this helps with Dirk's crash.
274 2007-06-19 Murray Cumming <murrayc@murrayc.com>
276 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
277 though it is not implemented yet (this function is maybe not even used),
278 to avoid breaking ABI in future.
279 * libmodest-dbus-client/libmodest-dbus-client.c:
280 (get_attachments_string): Moved some code into this generic function.
281 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
282 sends email. It is maybe not used.
283 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
284 (on_send_mail): Use attachments.
286 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
287 * src/maemo/modest-msg-edit-window.c:
288 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
289 a filename before using it, to fix projects.maemo.org bug NB#58233.
291 2007-06-19 Murray Cumming <murrayc@murrayc.com>
293 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
294 Initialize the continue_download variable to fix the build, and probably
295 to fix randome behaviour.
297 2007-06-18 Armin Burgmeier <armin@openismus.com>
299 * src/modest-tny-send-queue.h:
300 * src/modest-tny-send-queue.c: Keep track of the status of messages in
301 the queue so we can later show it in the UI. Replaced
302 modest_tny_send_queue_msg_is_being_sent() by
303 modest_tny_send_queue_get_msg_status().
305 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
307 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
308 gpointer. This probably was not harmful, but just to be sure.
310 2007-06-18 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
313 Fix the build, but leave the function broken on Bora, because
314 hildon_uri_action_get_service() does not exist.
315 osso_uri_action_get_service() does not exist either, it seems.
317 2007-06-18 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-tny-account.c:
320 (modest_tny_account_new_from_server_account):
321 Uncommented the url debug output again, because it is useful for
322 debugging, as I said in the comment.
324 2007-06-18 Murray Cumming <murrayc@murrayc.com>
326 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
328 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
329 for Mameo Bora, to fix the build.
331 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
334 Fixed build with hildon < 0.99
336 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
337 Check if the selected account is busy instead of checking all accounts
339 * src/modest-account-mgr-priv.h:
340 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
341 (modest_account_mgr_init), (compare_account_name),
342 (modest_account_mgr_set_account_busy),
343 (modest_account_mgr_account_is_busy):
344 * src/modest-account-mgr.h:
345 Added busy information to the account manager. It possible to
346 set an account to busy or not busy now.
348 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
349 (modest_mail_operation_update_account),
350 (modest_mail_operation_notify_end):
351 Set the account to busy/not busy depending on the operation state.
353 * src/widgets/modest-account-view.c:
354 (modest_account_view_finalize), (get_last_updated_string),
355 (update_account_view), (on_account_busy_changed), (init_view):
356 Show string "Refreshing..." if the account is currently busy.
358 All this fixes projects.maemo.org bug NB#59711
360 2007-06-14 Armin Burgmeier <armin@openismus.com>
362 * src/widgets/modest-attachments-view.h:
363 * src/widgets/modest-attachments-view.c: Added
364 modest_attachments_view_has_attachments() and fixed coordinate
365 transformation in get_att_view_at_coords(). This fixes attachment
368 * src/widgets/modest-msg-view.c: Make use of
369 modest_attachments_view_has_attachments() to decide whether to show
370 attachments in the header.
372 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
374 * src/maemo/modest-connection-specific-smtp-edit-window.c:
375 (on_change), (on_combo_security_changed),
376 (modest_connection_specific_smtp_edit_window_init),
377 (modest_connection_specific_smtp_edit_window_set_connection),
378 (modest_connection_specific_smtp_edit_window_is_dirty):
379 * src/maemo/modest-connection-specific-smtp-edit-window.h:
380 * src/maemo/modest-connection-specific-smtp-window.c:
383 Show an comfirmation dialog for the smpt-edit-window if there are
384 unsaved changes and the user hits cancel.
385 (projects.maemo.org bug NB#60479)
387 2007-06-14 Armin Burgmeier <armin@openismus.com>
389 * src/maemo/easysetup/modest-easysetup-wizard.c:
390 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
391 address" info in banner instead of node, and select all the text as
392 per UI spec. This fixes projects.maemo.org bug NB#60550.
394 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
396 reviewed by: <delete if not using a buddy>
398 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
399 * src/modest-ui-actions.c: (folder_refreshed_cb):
401 2007-06-14 Murray Cumming <murrayc@murrayc.com>
403 * src/widgets/modest-folder-view.c: (filter_row):
404 Explictly filter out the per-account outbox accounts. I don't know why
405 these only sometimes show up, but now they should never show up in the UI.
406 This should fix projects.maemo.org bug NB#60160.
408 2007-06-14 Murray Cumming <murrayc@murrayc.com>
410 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
411 when the toolbar does not exist yet.
412 * src/modest-widget-memory.c: (save_settings_header_view):
413 Added g_warnings() to help us to discover when we are trying to set
414 an empty columns list in gconf.
416 2007-06-14 Murray Cumming <murrayc@murrayc.com>
420 Added modest_init_get_default_header_view_column_ids().
422 * src/modest-widget-memory.c: (restore_settings_header_view):
423 Use the new function to get defaults, if the gconf key is empty,
424 instead of not creating any columns. This seems to fix the
425 empty right-hand pane problems.
427 * src/widgets/modest-header-view.h: Improved documentation.
429 2007-06-13 Murray Cumming <murrayc@murrayc.com>
431 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
432 Revert the use of the display name as the account name, because this
433 is generally wrong and would break the code that follows.
435 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
437 * src/maemo/easysetup/modest-easysetup-wizard.c:
438 (check_for_supported_auth_methods), (on_before_next),
441 More correct fix for projects.maemo.org bug NB# 58991
442 Do not longer accept AUTH_PASSWORD as secure method and choose
443 correct method when creating the account.
445 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
447 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
448 Fixed projects.maemo.org bug NB# 58991
450 2007-06-13 Murray Cumming <murrayc@murrayc.com>
452 * src/modest-init.c: (modest_init_init_core),
453 (modest_init_local_folders): Fixed compilation errors.
455 2007-06-13 Murray Cumming <murrayc@murrayc.com>
457 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
458 Remove unnecessary lib/include, though it is good in principle when needed.
460 * src/modest-init.c: (modest_init_one_local_folder),
461 (modest_init_local_folders):
462 * src/modest-init.h: Initialize the .modest library for memory cards,
463 instead of just doing nothing for them. This should allow us to create
464 folders there, fixing projects.maemo.org bug NB#59297.
466 2007-06-13 Murray Cumming <murrayc@murrayc.com>
468 * libmodest-dbus-client/libmodest-dbus-client.c:
469 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
470 (libmodest_dbus_client_compose_mail),
471 (libmodest_dbus_client_open_message),
472 (libmodest_dbus_client_send_and_receive),
473 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
475 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
476 (on_idle_open_message), (modest_dbus_req_handler),
477 (search_result_to_message), (modest_dbus_req_filter):
478 * src/modest-search.c: (add_hit), (modest_search_folder),
479 (modest_search_all_accounts): Improved debug messages.
481 * tests/dbus_api/test_open_message.c: (main): Improved comments.
483 * src/modest-tny-account-store.c:
484 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
487 2007-06-13 Murray Cumming <murrayc@murrayc.com>
490 2007-06-12 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-tny-account-store.c: (get_server_accounts):
493 Call modest_tny_local_folders_account_add_merged_outbox_folders()
494 even when there are no accounts, so that the Outbox folder is always
495 visible. This fixes projects.maemo.org bug NB#60158.
497 2007-06-12 Murray Cumming <murrayc@murrayc.com>
499 * src/maemo/modest-main-window.c: (create_details_widget):
500 Use the mcen_va_never logical ID.
502 2007-06-12 Murray Cumming <murrayc@murrayc.com>
504 * src/dbus_api/modest-dbus-api.h:
505 * src/dbus_api/modest-dbus-callbacks.c:
506 (on_idle_open_default_inbox), (on_open_default_inbox),
507 (modest_dbus_req_handler):
508 Added a new OpenDefaultInbox method.
510 * libmodest-dbus-client/libmodest-dbus-client.h:
511 * libmodest-dbus-client/libmodest-dbus-client.c:
512 Added libmodest_dbus_client_open_default_inbox() to call the new
513 dbus method. This should be useful to projects.maemo.org bug NB#57214,
514 though it should maybe be used by a new osso-email-interface function.
516 * tests/dbus_api/Makefile.am:
517 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
520 2007-06-12 Murray Cumming <murrayc@murrayc.com>
522 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
523 NULL, so that the signals get all the keys. This should not actually
524 change any behaviour because we currently update everything when anything
527 2007-06-12 Murray Cumming <murrayc@murrayc.com>
529 * src/widgets/modest-folder-view.c: (text_cell_data),
530 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
531 (find_inbox_iter): If tinymail tells us that the folder is
532 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
533 This causes the inbox to be selected at startup, fixing part of
534 projects.maemo.org bug NB#56305.
536 * src/modest-ui-dimming-rules.c:
537 (modest_ui_dimming_rules_on_tools_smtp_servers):
538 * src/modest-ui-dimming-rules.h: Added a callback function to dim
539 the SMTP servers menu item.
540 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
541 that the SMTP Servers menu item is dimmed when there are no accounts,
542 as a future version of the UI spec will require. This fixes
543 projects.maemo.org bug NB#56305.
545 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
547 * src/maemo/modest-maemo-utils.c:
548 (modest_maemo_utils_get_supported_secure_authentication_methods):
549 Added label to dialog instead of unreadable title
551 * src/maemo/modest-main-window.c: (sync_accounts_cb),
552 (modest_main_window_new):
553 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
556 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
557 * src/modest-account-mgr.h:
558 Added method to avoid code duplication
560 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
561 (modest_ui_actions_on_send_receive):
562 Use modest_account_mgr_has_accounts
564 2007-06-11 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/easysetup/modest-presets.c:
567 (modest_presets_get_info_server_security): Do not report secure auth
569 * src/modest-protocol-info.c: Use the defines for the gconf key names
570 for secure authentication. This was not working because we were writing
571 Password and reading password, and the check was case sensitive.
572 With this, gmail now works for receiving and sending when created via
575 2007-06-11 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/easysetup/modest-presets.c:
578 (modest_presets_get_info_server_security): Correct the key name for
579 SecureSmtp, because it seems to be case-sensitive.
580 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
581 Do not try to get the 0th notebook page if there are 0 pages, to
584 2007-06-11 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
587 Prevent use of the new notification feature for now, because it currently
588 shows one dialog for each new email, which is annoying.
590 2007-06-11 Murray Cumming <murrayc@murrayc.com>
592 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
593 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
594 when no country was selected, so that we show the global ones.
595 * src/maemo/easysetup/modest-presets.c:
596 (modest_presets_get_providers): Return only the global providers, not
597 all providers when mmc=0 was requested.
599 2007-06-11 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
602 (easysetup_provider_combo_box_fill): Remove debug code that showed the
603 provider ID in the combo.
605 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
606 Do not show the page numbers, because it would be confusing when we add
607 the 2 extra pages for the custom setup, when the user chooses the "Other"
608 provider. This fixes projects.maemo.org bug NB#59028
610 * src/modest-init.c: (modest_init_init_core),
611 (modest_init_local_folders):
613 * src/modest-tny-account.c:
614 (modest_tny_account_new_for_local_folders): Do not create default folders
615 for the memory card. This should fix projects.maemo.org bug NB#59328.
617 2007-06-11 Murray Cumming <murrayc@murrayc.com>
619 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
620 Free the changed_conf_keys string items. They are already freed in the
621 idle handler if that runs first.
623 2007-06-11 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-ui-actions.c:
626 (modest_ui_actions_on_password_requested): Check that the server name
627 is not NULL, because I just saw a password dialog with (null) as the
630 * src/modest-tny-folder.[h|c]: Added
631 modest_tny_folder_is_memory_card_folder().
632 * src/modest-ui-dimming-rules.c:
633 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
634 menu item for memory cards, as per the UI spec (section 7.4). This should
635 fix projects.maemo.org bug NB#59297.
637 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
639 * src/maemo/modest-main-window.c: (sync_accounts_cb):
640 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
641 is another problem with the code, see Murray's comment at line 772)
643 2007-06-08 Murray Cumming <murrayc@murrayc.com>
645 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
646 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
647 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
648 (load_from_file), (easysetup_country_combo_box_init),
649 (easysetup_country_combo_box_get_active_country_ids),
650 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
651 instead of just one ID, to avoid duplicate country names in the UI.
653 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
654 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
655 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
656 a single ID, avoiding duplicate providers.
657 * src/maemo/easysetup/modest-easysetup-wizard.c:
658 (on_combo_account_country): Adapt to use a list.
660 2007-06-08 Murray Cumming <murrayc@murrayc.com>
662 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
663 keys changed in the last X seconds.
665 * src/modest-account-mgr.h:
666 * src/modest-account-mgr.c: (on_timeout_notify_changes),
667 (on_key_change), (modest_account_mgr_class_init),
668 (modest_account_mgr_init), (modest_account_mgr_finalize):
669 As the keys are changed, save them in a GSList* and signal that GSList*
670 further every X seconds, to batch changes, to allow us to do just one
671 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
672 bug NB#56941 and other (UI-blocking) delays when changing account settings.
674 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
675 changed signal signature.
677 * src/modest-conf.c: (modest_conf_set_list),
678 (modest_conf_on_change): Reenable notification.
680 (modest_conf_maemo_fake_on_change): Comment out the hack that
681 notified immediately instead of asynchronously.
683 * src/widgets/modest-account-view.h:
684 * src/widgets/modest-account-view.c:
685 (update_account_view): Select the previously-selected account ID,
686 if possible. This fixes projects.maemo.org bug NB#56933.
688 (on_account_changed), (on_account_removed),
689 (modest_account_view_select_account):
691 Remove the block/unblock functions
692 because they were not useful.
694 * src/maemo/modest-account-view-window.c:
695 (on_delete_button_clicked), (on_edit_button_clicked),
696 (on_new_button_clicked): Remove the use of the non-working block/unblock.
698 2007-06-08 Murray Cumming <murrayc@murrayc.com>
700 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
701 Improve the error dialog to show Incorrect Account Settings, which seems
702 clearer, and say that the internal error message (to be removed from the
703 dialog later) is often misleading.
704 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
706 * src/modest-tny-account.c:
707 (modest_tny_account_new_from_server_account): Uncomment the printf of the
708 URL because this is so useful for debugging on the device.
710 * src/widgets/modest-serversecurity-combo-box.c:
711 (modest_serversecurity_combo_box_fill): Correct a logical ID.
713 2007-06-08 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-mail-operation.c:
716 (modest_mail_operation_send_new_mail):
717 Added a comment about a nasty but apparently harmless message. Details
718 added to the wiki g_warnings() page.
720 2007-06-08 Murray Cumming <murrayc@murrayc.com>
722 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
723 (modest_tny_send_queue_class_init):
724 Do not use the priv struct because it is empty, to avoid g_warnings
725 about a non-existant priv struct.
727 * src/modest-tny-account-store.c:
728 (modest_tny_account_store_get_server_account),
729 (modest_tny_account_store_get_transport_account_for_open_connection
730 ): Do not try to get transport server accounts for local folders,
731 because they don't have any. This avoids a g_warning().
733 * src/maemo/modest-main-window.c:
734 (modest_main_window_notify_send_receive_initied),
735 (on_configuration_key_changed):
736 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
738 * src/modest-mail-operation.c:
739 (modest_mail_operation_update_account):
740 * src/modest-tny-account-store.h:
741 * src/modest-tny-account.c:
742 (modest_tny_account_get_special_folder),
743 (modest_tny_account_new_for_local_folders),
744 (modest_tny_account_new_for_per_account_local_outbox_folder):
745 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
746 * src/modest-tny-local-folders-account.c:
747 (add_account_folders_to_merged_folder):
748 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
749 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
750 (modest_ui_actions_on_send):
751 * src/widgets/modest-folder-view.c: (update_model):
752 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
753 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
754 modest_tny_account_store_get_tny_account_by_account() to
755 modest_tny_account_store_get_server_account() to make the code clearer.
757 2007-06-07 Marcus Bauer <marcusb@openismus.com>
759 * src/dbus_api/modest-dbus-api.h:
760 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
761 * src/maemo/modest-msg-edit-window.c:
762 (modest_msg_edit_window_attach_file_noninteractive):
763 added g_warning in case the file to be attached does not exist
764 * tests/dbus_api/test_compose_mail.c: (main):
765 removed obsolete comment, added generic files as test case
767 2007-06-07 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account-store.c: (get_server_accounts):
770 Create the local folders account only once, not once for each outbox, and
771 not only when there are some outboxes.
773 2007-06-07 Murray Cumming <murrayc@murrayc.com>
775 * src/widgets/modest-folder-view.c: (update_model): Comment out some
776 code that is causing a crash at startup. Sergio says that he is fixing this.
778 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
780 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
781 * src/maemo/modest-account-settings-dialog.c:
782 (create_page_outgoing),
783 (modest_account_settings_dialog_set_account_name),
784 (save_configuration):
785 - Fixed handling of the "Use secure authentication" toggle to comply with
786 the ui specification. See also projects.maemo.org bug NB#58400
788 - Restore the Secure connection setting combo correctly when loading
791 * src/maemo/modest-maemo-utils.c:
792 (on_camel_account_get_supported_secure_authentication),
793 (modest_maemo_utils_get_supported_secure_authentication_methods):
794 Fixed a crasher if operation is canceled
796 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
797 (modest_protocol_info_auth_is_secure):
798 * src/modest-protocol-info.h:
800 Added two new methods to determine if a protocol/auth method is secure/encrypted in
801 the sense of the "Use secure authentication" toggle.
803 2007-06-07 Murray Cumming <murrayc@murrayc.com>
805 * src/modest-tny-account-store.h:
806 * src/modest-tny-account-store.c:
807 Added modest_tny_account_store_get_local_folders_account().
809 * src/modest-tny-folder.h:
810 * src/modest-tny-folder.c:
811 (modest_tny_folder_get_account):
812 Added this replacement for tny_folder_get_account() which returns
813 the local-folders account for TnyMergeFolders, to avoid the
814 warning about the unimplemented get_account_func() vfunc().
816 (modest_tny_folder_get_rules),
817 * src/modest-ui-actions.c:
818 (modest_ui_actions_on_folder_selection_changed):
819 * src/modest-mail-operation.c:
820 (modest_mail_operation_remove_folder),
821 (modest_mail_operation_xfer_folder),
822 (modest_mail_operation_rename_folder),
823 (modest_mail_operation_get_msg),
824 (modest_mail_operation_get_msgs_full),
825 (modest_mail_operation_remove_msg),
826 (modest_mail_operation_xfer_msgs),
827 (modest_mail_operation_refresh_folder):
828 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
830 2007-06-07 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
833 (modest_server_account_set_security):
834 * src/modest-defs.h: Add comments explaining that our
835 UI spec means TLS when it says Normal, so these do not look like errors.
837 * src/modest-tny-account.c:
838 (modest_tny_account_new_from_server_account): Use the new tinymail
839 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
840 for TLS. This should fix projects.maemo.org bug NB#58460.
842 2007-06-06 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/easysetup/modest-easysetup-wizard.c:
845 (create_account): Correct the position of the gconf sanity check warning.
846 (on_button_edit_advanced_settings): Show the dialog immediately, instead
847 of using the g_idle_add() hack, because this does not seem to be necessary
848 on osso 1.1. It might even work on Maemo Bora if the problems were actually
849 caused by something other than maemo's gconf.
850 This fixes projects.maemo.org bug #59022.
852 2007-06-06 Murray Cumming <murrayc@murrayc.com>
854 * src/modest-account-mgr-helpers.c:
855 (modest_account_mgr_get_default_account): Do not check that the account
856 exists if there is no default account (NULL), to fix a runtime warning.
858 2007-06-06 Murray Cumming <murrayc@murrayc.com>
860 * src/widgets/modest-folder-view.c: (update_model):
861 Do not unref the treemodel before we have finished with it.
862 This prevents a valgrind warning and an occasional crash at startup.
864 2007-06-06 Marcus Bauer <marcusb@openismus.com>
866 * libmodest-dbus-client/libmodest-dbus-client.h:
867 added libmodest_dbus_client_compose_mail()
868 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
870 added functions needed for SendAsMail() functionality
871 * src/maemo/modest-msg-edit-window.c:
872 (modest_msg_edit_window_attach_file_noninteractive):
873 non interactively attaching files to message edit window
874 * src/widgets/modest-msg-edit-window.h:
875 * tests/dbus_api/Makefile.am:
876 added test_compose_mail.c
877 * tests/dbus_api/test_compose_mail.c: (main):
879 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
881 * src/modest-account-view.c:
882 Fixed bug projects.maemo.org bug NB#59307
884 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
886 * src/maemo/easysetup/modest-easysetup-wizard.c:
887 (get_serverport_incoming), (on_before_next), (create_account):
888 * src/maemo/modest-account-settings-dialog.c:
889 (modest_account_settings_dialog_set_account_name):
890 * src/maemo/modest-maemo-utils.c:
891 (on_camel_account_get_supported_secure_authentication_status),
892 (on_camel_account_get_supported_secure_authentication),
893 (on_secure_auth_cancel),
894 (modest_maemo_utils_get_supported_secure_authentication_methods):
896 Implemented security authentication for settings and easysetup.
898 2007-06-05 Murray Cumming <murrayc@murrayc.com>
900 * src/maemo/modest-main-window.c: (create_details_widget):
901 Show the total size for memory card accounts too, instead of showing
902 the name again. Fixes bug projects.maemo.org bug NB#59307.
904 2007-06-05 Murray Cumming <murrayc@murrayc.com>
907 * src/modest-tny-simple-folder-store.c:
908 * src/modest-tny-simple-folder-store.h: Removed.
910 * src/modest-tny-local-folders-account.h
911 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
912 for the local-folders maildir, with an extra TnyMergedFolder containing
913 the folders of the per-account outbox store accounts.
914 * src/modest-tny-account-store.c: (get_server_accounts):
915 Add the outboxes to the special local folders account after creating it.
917 * src/modest-tny-account.c:
918 (modest_tny_account_new_for_local_folders): Create the derived
919 account when creating the main local-folders account.
921 * src/maemo/modest-main-window.c: (create_details_widget),
922 (modest_main_window_set_contents_style):
923 Adapted to the use of the derived account instead of the folder store.
925 * src/modest-ui-actions.c:
926 (modest_ui_actions_on_folder_selection_changed):
927 * src/modest-ui-dimming-rules.c:
928 (modest_ui_dimming_rules_on_new_folder):
929 * src/widgets/modest-folder-view.c: (text_cell_data),
930 (icon_cell_data), (filter_row), (update_model),
931 (get_cmp_rows_type_pos):
934 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
935 Do not get the priv struct, because no priv struct has been set,
936 to avoid a runtime warning.
938 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
939 #ifelse with #else, to fix a warning, to fix the build.
942 2007-06-05 Christian Kellner <ckellner@openismus.com>
944 * libmodest-dbus-client/libmodest-dbus-client.c:
945 Fix small typo in doc (why do you always see them
946 AFTER committing stuff?)
949 2007-06-05 Christian Kellner <ckellner@openismus.com>
951 * libmodest-dbus-client/libmodest-dbus-client.c:
952 (libmodest_dbus_client_search):
953 Initialize hit list with NULL. Also set folder list
954 to "" if NULL was supplied.
957 2007-06-03 Christian Kellner <ckellner@openismus.com>
959 * libmodest-dbus-client/libmodest-dbus-client.c:
960 (modest_search_hit_list_free):
961 Make it save to call it with NULL.
963 * src/dbus_api/modest-dbus-callbacks.c:
964 * src/modest-search.c:
965 Return full ModestSearchHits as the search result list not TnyHeader
966 since can't be around withouth the correspoding TnyFolder.
968 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
970 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
971 Added currently commented code to check for secure auth
973 * src/maemo/modest-account-settings-dialog.c: (on_response),
974 (save_configuration), (show_ok):
975 Fixed projects.maemo.org bugs NB #59248 and #59251
977 * src/maemo/modest-maemo-utils.c:
978 (on_camel_account_get_supported_secure_authentication_status),
979 (on_camel_account_get_supported_secure_authentication),
980 (modest_maemo_utils_get_supported_secure_authentication_methods):
981 * src/maemo/modest-maemo-utils.h:
982 Moved get_supported_secure_authentication() method here to be able
983 to use it from easysetup wizard.
985 * src/modest-pair.c: (on_pair_compare_as_string):
986 Should compare string with first part of pair and not
987 strcmp pairs which will crash.
989 * src/modest-protocol-info.c:
990 (modest_protocol_info_protocol_is_store):
991 * src/modest-protocol-info.h:
992 Added modest_protocol_info_get_auth_protocol_name()
994 2007-06-03 Armin Burgmeier <armin@openismus.com>
996 * src/modest-mail-operation.c:
997 (modest_mail_operation_get_msgs_full): Set priv->account also when
998 only retrieving a single message. This avoids a crash when canceling
1001 (modest_mail_operation_notify_end): Do not explicitely remove the
1002 operation from the queue but only emit the progress_changed signal.
1003 The queue itself listens to that signal to remove the operation when
1004 it is finished. This reduces coupling and removes a potential deadlock
1005 when modest_mail_operation_notify_end() is called from the queue
1006 itself. If that is a problem performance-wise, I would suggest to
1007 implement a status-changed signal or something.
1009 * src/modest-mail-operation-queue.c: Make sure to never call a
1010 function from another file while the queue is locked. This (hopefully)
1011 fixes another deadlock when exiting the application while retrieving
1014 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1016 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1017 Fixed build if libogs is not available
1019 2007-06-03 Christian Kellner <ckellner@openismus.com>
1021 * libmodest-dbus-client/libmodest-dbus-client.h:
1022 * libmodest-dbus-client/libmodest-dbus-client.c:
1023 (libmodest_dbus_client_delete_message):
1024 Implement deletion of messages (Client side).
1026 (modest_search_hit_free),
1027 (modest_search_hit_list_free):
1028 Utility functions to free the result hits.
1030 * src/dbus_api/modest-dbus-api.h:
1031 * src/dbus_api/modest-dbus-callbacks.c:
1032 (on_delete_message),
1033 (modest_dbus_req_handler):
1034 Implement deletion of messages (Server side).
1036 * tests/dbus_api/test_search.c: (main):
1039 * tests/dbus_api/Makefile.am:
1040 * tests/dbus_api/test_delete_message:
1041 Add little test for the message deletion logic
1043 2007-06-03 Armin Burgmeier <armin@openismus.com>
1045 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1046 when the operation queue was not empty. projects.maemo.org bug
1049 2007-06-03 Armin Burgmeier <armin@openismus.com>
1051 * src/widgets/modest-account-view.c
1052 (on_account_default_toggled): Toggle default account column
1053 explicitely instead of waiting for gconf notification (which is
1054 currently ignored). This should fix projects.maemo.org bug NB#56910
1055 for now. It should probably be removed when gconf notifications are
1058 2007-06-03 Christian Kellner <ckellner@openismus.com>
1060 * libmodest-dbus-client/libmodest-dbus-client.c:
1061 Removed debugging spew.
1063 * src/dbus_api/modest-dbus-callbacks.c:
1064 Added debugging info.
1066 * src/modest-search.c:
1067 (modest_search_all_accounts):
1068 Use tny_account_store_get_accounts () on the account store
1069 to get all accounts which is the way to get all accounts.
1071 * tests/dbus_api/test_search.c: (main):
1072 Make it possible to supply the search term on the command line.
1074 2007-06-03 Christian Kellner <ckellner@openismus.com>
1076 * libmodest-dbus-client/libmodest-dbus-client.c:
1077 * libmodest-dbus-client/libmodest-dbus-client.h:
1078 Implement searching for mesages over raw dbus. (Client side)
1080 * src/dbus_api/Makefile.am:
1081 * src/dbus_api/modest-dbus-api.h:
1082 * src/dbus_api/modest-dbus-callbacks.c:
1083 * src/dbus_api/modest-dbus-callbacks.h:
1084 Search framework (Server side). Also implement on_idle_open_message().
1086 * src/maemo/modest-platform.c: (modest_platform_init):
1087 Prepare for raw dbus/osso rpc interaction.
1089 * src/modest-search.h:
1090 Changed minsize from unspecific guint to guint32.
1092 * src/modest-search.c:
1094 Added strange hack which magically made tnymail work.
1096 (modest_search_folder),
1097 (modest_search_account),
1098 (modest_search_all_accounts):
1099 Implement helper functions to search all accounts, specific account
1102 * tests/dbus_api/Makefile.am:
1103 * tests/dbus_api/test_open_message.c:
1104 Read url to open from commandline.
1106 * tests/dbus_api/test_search.c:
1107 Implement small test for dbus search stuff
1109 2007-06-02 Armin Burgmeier <armin@openismus.com>
1111 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1112 include account type and account title. This fixes projects.maemo.org
1115 * src/maemo/modest-account-view-window.c: Set a title for the window.
1117 2007-06-02 Armin Burgmeier <armin@openismus.com>
1119 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1120 incoming and outgoing server name based on email address and server
1121 types as long as the names have not been edited manually. This fixes
1122 projects.maemo.org bug NB#58671.
1124 2007-06-02 Armin Burgmeier <armin@openismus.com>
1126 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1127 server type cannot be changed in future to the incoming details page
1128 when creating an account. This fixes projects.maemo.org bug NB#59029.
1130 2007-06-02 Armin Burgmeier <armin@openismus.com>
1132 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1133 and assigned max width chars so that they wrap instead of being
1134 truncated. Fixes projects.maemo.org bug NB#56126.
1136 2007-06-02 Armin Burgmeier <armin@openismus.com>
1138 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1139 introductory note to the connection specific smtp servers dialog, as
1140 section 8.12 of the email UI specification requires. This fixes
1141 projects.maemo.org bug NB#59212.
1143 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1145 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1146 Check for running mail operations, and offer to cancel them, as per the UI
1147 spec. This fixes projects.maemo.org bug NB#59041 .
1148 However, I suspect that tinymail may still use the network connection
1149 in ways that we cannot detect or cancel. But it should at least adapt to
1150 changes fairly well.
1152 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-tny-account-store.c: (recreate_all_accounts),
1155 (get_cached_accounts), (get_server_accounts): Do more sensible
1156 ref-counting of the temporarily-cached outbox accounts list. This seems
1157 to fix a crash when entering the password when the password was wrong.
1159 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1161 * src/gnome/modest-main-window.c: (connect_signals):
1162 * src/modest-tny-account-store.c: (get_password),
1163 (modest_tny_account_store_alert): Added comments and clues and
1164 commented-out code about how we currently fail to deal with connection
1165 errors and wrong passwords, and how we should.
1167 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1169 * src/widgets/modest-retrieve-combo-box.c:
1170 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1171 This fixes projects.maemo.org bug NB#58472 .
1173 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1175 * src/maemo/easysetup/modest-easysetup-wizard.c:
1176 (create_page_complete_easysetup):
1177 (create_page_complete_custom): Correct the last commit,
1178 putting the correct sentences in the correct pages.
1180 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1182 * src/maemo/easysetup/modest-easysetup-wizard.c:
1183 (create_page_complete_custom): Show the second sentence of text
1184 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1187 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1189 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1190 Set the leave-on-server conf key by default. This fixes
1191 projects.maemo.org bug NB#59258 .
1193 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1195 * src/maemo/modest-account-view-window.c:
1196 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1197 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1200 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1202 * src/maemo/easysetup/modest-easysetup-wizard.c:
1203 (create_caption_new_with_asterisk):
1204 * src/maemo/modest-account-settings-dialog.c:
1205 (create_caption_new_with_asterisk):
1206 Uncomment the code to add the asterisk, because they are no longer in the
1207 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1208 (update_incoming_server_title): Add an asterisk here too.
1210 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-maemo-global-settings-dialog.c:
1213 (current_connection): Check that we are even connected before trying to
1214 get the current connection name, to prevent a warning.
1216 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1217 Change the comments because tny_maemo_conic_device_connect() is now meant to
1219 * src/modest-mail-operation.c:
1220 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1221 make sure we have a connection and fail if we can't connect.
1223 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1225 * src/maemo/modest-main-window.c:
1226 (on_account_store_connecting_finished): Do not try to get the
1227 connection ID if we are not really connected. I am surprised that
1228 this signal handler is called when we are not connected.
1230 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-error.h:
1233 * src/modest-ui-actions.c:
1234 (modest_ui_actions_get_msgs_full_error_handler):
1235 Renamed an enum, added comments, added an enum
1236 for retrieve-limit errors.
1238 * src/modest-mail-operation.c: (foreach_add_item),
1239 (internal_folder_observer_update), (update_account_thread),
1240 (modest_mail_operation_get_msgs_full):
1241 (modest_mail_operation_update_account),
1242 Added comments about how this works, and some code that should
1243 (but does not) check the retrieve-limit. See the TODO comment.
1245 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1248 Initialize help_id to fix the build. Warnings are good.
1250 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1252 * src/widgets/modest-hbox-cell-renderer.c:
1253 (modest_hbox_cell_renderer_append):
1254 * src/widgets/modest-vbox-cell-renderer.c:
1255 (modest_vbox_cell_renderer_append):
1256 Fix the last commit by doing an extra ref.
1258 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1260 * src/widgets/modest-hbox-cell-renderer.c:
1261 (modest_hbox_cell_renderer_append):
1262 * src/widgets/modest-vbox-cell-renderer.c:
1263 (modest_vbox_cell_renderer_append):
1264 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1265 to fix the build with Maemo Bora.
1266 However, there seems to be a remaining crash, probably due to reference
1269 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-tny-account.c:
1272 (modest_tny_account_new_for_local_folders):
1273 Use hildon_file_system_info_async_new() to get a better name for
1274 the memory card account, setting it as the account name.
1275 The timing seems to work, but this is probably
1276 not the best place to do this. See the TODO comment.
1277 * src/maemo/modest-main-window.c: (create_details_widget):
1278 * src/widgets/modest-folder-view.c: (text_cell_data):
1279 Use the tny account name instead of hardcoding a name.
1281 2007-05-30 Christian Kellner <ckellner@openismus.com>
1283 * src/modest-search.c: (modest_search):
1284 Correctly set part_search_func even if we have already parsed
1285 the query and thus a valid OgsTextSearcher object.
1287 2007-05-30 Christian Kellner <ckellner@openismus.com>
1290 Search and check for libogs.
1293 Incooparte the ogs build env.
1295 * src/modest-mime-part-search-stream.c:
1296 * src/modest-mime-part-search-stream.h:
1297 Removed since we do the real searching now in modest-search.c.
1299 * src/modest-search.c:
1300 * src/modest-search.h:
1301 Implement support for ogs. We use that if available and requested
1302 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1303 should now handle the corner case when the search term is spread
1304 across multiple reads.
1305 Also the logic in modest_search () was corrected to search all
1306 requested fields until one is found.
1308 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1310 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1312 * src/modest-init.h:
1313 * src/modest-init.c: Made modest_init_local_folders() take a
1314 path and be public so we can iniitialize maildir folders on
1317 * src/modest-local-folder-info.h:
1318 * src/modest-local-folder-info.c:
1319 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1321 * src/modest-tny-account.c:
1322 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1323 still means the standard local-folders path on the local volume.
1325 * src/modest-tny-account-store.c:
1326 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1327 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1328 all accounts when that happens.
1329 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1330 this too, so it shows up in the treeview.
1332 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/modest-maemo-global-settings-dialog.c:
1335 (current_connection):
1336 * src/widgets/modest-global-settings-dialog.c:
1337 (current_connection_default):
1338 Use the enum values instead of 0, 1 and -1,
1339 to make the code clearer.
1341 * src/modest-account-mgr-helpers.c:
1342 (modest_account_mgr_get_connection_specific_smtp): Make this code
1345 * src/modest-runtime.h:
1346 * src/modest-runtime.c:
1347 Added modest_runtime_remove_all_send_queues().
1348 * src/maemo/modest-main-window.c:
1349 (on_account_store_connecting_finished): Recreate the send queues,
1350 using the appropriate transport accounts for this new connection.
1351 Some futher adapting might be needed if the old send queues are not
1352 automatically stopped at this point.
1354 * src/modest-tny-account-store.c: (get_server_accounts):
1355 Create the connection-specific transport accounts, so that they can
1356 be found later by their ID.
1358 * src/modest-tny-account.h:
1359 * src/modest-tny-account.c:
1360 Added modest_tny_account_new_from_server_account_name().
1361 modest_tny_account_new_from_server_account(): Do not create the
1362 send queues here, because they will be
1363 recreated anyway when the connection changes for the first time.
1365 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1367 * src/modest-local-folder-info.h:
1368 * src/modest-local-folder-info.c:
1369 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1370 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1371 tbox_folder): Take a modest account name instead of a server TnyAccount,
1372 so we can have per-modest-account rather than per-transport-account
1374 We must make sure that we change or recreate the exisitng send queues
1375 when the connection changes for connection-specific transport accounts.
1377 * src/modest-tny-account-store.c:
1378 (create_per_account_local_outbox_folders): Create outboxed per modest
1379 account, not per transport account.
1381 * src/modest-tny-account.h:
1382 * src/modest-tny-account.c:
1383 (modest_tny_account_get_special_folder): For outboxes, get the
1384 parent modest account name. The account is ignored for other folders.
1385 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1386 modest account name rather than a server TnyAccount.
1388 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1390 * src/modest-tny-account.c:
1391 (modest_tny_account_new_from_server_account):
1392 Call modest_runtime_get_send_queue() immediately after creating transport
1393 accounts, so that they start trying to send email from the outbox as soon
1394 as possible at startup. This is probably what we want.
1396 * src/modest-mail-operation.c: (update_account_thread):
1397 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1398 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1399 * src/modest-tny-send-queue.h:
1400 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1401 (modest_ui_actions_on_send):
1402 Added comments about how sending works, though it needs some more work.
1404 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-tny-account.c:
1407 (modest_tny_account_get_special_folder): Add TODO because this fails when
1408 the network is busy.
1409 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1410 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1411 Do not try to show this window when there is no active account. The UI
1412 specs does not tell us what to do in this case.
1414 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1418 * src/maemo/Makefile.am:
1419 * src/widgets/Makefile.am: Some dist fixes.
1421 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1423 * src/maemo/modest-connection-specific-smtp-window.c:
1424 (on_button_edit): Make the code clearer, to prevent a double free.
1426 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/modest-account-settings-dialog.c:
1429 (modest_account_settings_dialog_set_account_name),
1430 Check the connection-specific smtp servers checkbox if there are any.
1432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1433 (modest_connection_specific_smtp_edit_window_init):
1434 Start with a suitable port number.
1436 * src/modest-account-mgr-helpers.h:
1437 * src/modest-account-mgr-helpers.c: Added
1438 modest_account_mgr_get_has_connection_specific_smtp().
1440 (modest_account_mgr_set_connection_specific_smtp),
1441 (modest_account_mgr_remove_connection_specific_smtp),
1442 (modest_account_mgr_get_has_connection_specific_smtp),
1443 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1444 connection-specific smtp server accounts in the account, rather than
1445 the server account conf dir.
1447 This fixes bug projects.maemo.org bug NB#58263 .
1449 * src/modest-tny-account-store.c:
1450 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1451 if there are no server accounts yet, to prevent an infinite loop when there
1452 are no accounts. Document that one must be called before the other.
1454 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1456 * src/modest-account-mgr-helpers.c:
1457 (modest_account_mgr_get_default_account): Make sure that at least
1458 one account is always the default, if there are any enabled accounts.
1459 This is just a sanity check that shouldn't be necessary.
1461 * src/modest-account-mgr-priv.c:
1462 (_modest_account_mgr_account_from_key): Unescape the conf key to
1463 get the real account name. For instance, this is an issue if a space
1464 was in the account name, which can happen because the account name
1465 is generated from the display name.
1466 (_modest_account_mgr_get_account_keyname): Always escape the
1468 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1469 Unescape the conf keys to get the real account names.
1471 For instance, previously the is-default radio button in the accounts
1472 list was not checked for any accounts at first. This fixes that,
1473 and might fix several similar bugs.
1475 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1477 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1478 Removed some debug printfs.
1480 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1482 Modest on-disk outbox directories are now here, for instance:
1483 $HOME/.modest/outboxes/<account-id-1>/outbox
1484 $HOME/.modest/outboxes/<account-id-2>/outbox
1486 $HOME/.modest/local-folders/outbox
1487 so we can have a separate outbox for each account.
1488 But they are shown as one outbox in the GtkTreeView, by using a
1489 TnyMergeFolder in a ModestTnySimpleFolderStore.
1492 * src/modest-tny-simple-folder-store.c:
1493 * src/modest-tny-simple-folder-store.h:
1494 Added ModestTnySimpleFolderStore, used to contain folders from
1495 other folder stores, such as other accounts.
1497 * src/modest-tny-outbox-account.h:
1498 * src/modest-tny-outbox-account.c:
1499 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1500 used for the per-account local outbox folders.
1502 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1503 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1504 only use this (internally) now for the non-outbox local folders.
1506 * src/modest-init.h:
1507 * src/modest-init.c: Added modest_init_one_local_folder(), for
1508 setting up the directory structure for each local folder.
1510 * src/modest-local-folder-info.c:
1511 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1512 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1514 * src/modest-local-folder-info.h:
1515 * src/modest-tny-account-store.c: (on_account_removed),
1516 (on_account_changed), (create_per_account_local_outbox_folders),
1517 (get_server_accounts), (modest_tny_account_store_get_accounts),
1518 (modest_tny_account_store_get_tny_account_by_account),
1519 (modest_tny_folder_store_is_virtual_local_folders):
1521 * src/modest-tny-account.h:
1522 * src/modest-tny-account.c:
1523 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1524 to create an on-disk per-account local outbox folder for each
1526 (create_per_account_local_outbox_folders): Create a local outbox folder
1527 for each transport account.
1528 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1529 for all local folders.
1531 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1532 instead of using g_object_get/set() directly. It is clearer.
1534 (modest_tny_folder_store_get_message_count),
1535 (modest_tny_folder_store_get_local_size
1536 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1537 because we now use these with non-acount folder stores.
1539 (modest_tny_account_get_special_folder),
1540 (modest_tny_account_new_from_server_account),
1541 (modest_tny_account_new_from_account):
1542 (recurse_folders): Adjust to the new outbox system.
1544 * src/modest-tny-folder.h:
1545 * src/modest-tny-folder.c:
1546 (modest_tny_folder_is_local_folder),
1547 (modest_tny_folder_get_local_folder_type),
1548 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1550 * src/widgets/modest-main-window.h:
1551 * src/maemo/modest-main-window.c: (create_details_widget),
1552 (modest_main_window_set_contents_style): Show details for any folder store,
1555 (modest_tny_folder_get_rules):
1556 Remove the const. C does not support constness enough for this.
1558 * src/modest-ui-actions.c:
1559 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1560 make all outboxes appear as one, in the usual local-folders tree node.
1562 (set_active_account_from_tny_account),
1563 (modest_ui_actions_on_folder_selection_changed):
1564 * src/widgets/modest-folder-view.c: (text_cell_data),
1565 (icon_cell_data), (filter_row),
1566 (add_account_folders_to_merged_folder),
1567 (add_account_folders_to_simple_folder_store), (),
1568 (get_cmp_rows_type_pos), (cmp_rows),
1569 (modest_folder_view_set_account_id_of_visible_server_account):
1570 Adjust to the new outbox system, using generic folder stores and folders
1571 in the GtkTreeModel.
1573 2007-05-23 Christian Kellner <ckellner@openismus.com>
1575 * src/modest-mail-operation.c:
1576 (modest_mail_operation_update_account):
1577 Use info->max_size instead of unintialized local var [small
1578 build fix]. (Added TODO to review that change since I don't
1581 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1583 * libmodest-dbus-client/libmodest-dbus-client.c:
1584 (libmodest_dbus_client_compose_mail): function added
1585 * src/dbus_api/modest-dbus-api.h:
1586 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1587 (on_compose_mail): Implementation of the SendAsMail functionality
1589 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1591 * src/modest-account-mgr.c:
1592 (modest_account_mgr_add_server_account): Set the secure-connection
1593 conf key for transport accounts as well as store accounts. I don't know
1594 why the if was there. For instance, this makes sure that we use SSL
1595 for the gmail preset from the easysetup wizard.
1597 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1599 * src/gnome/modest-main-window.c:
1600 (on_account_store_connecting_finished), (connect_signals):
1601 * src/maemo/modest-main-window.c:
1602 (on_account_store_connecting_finished), (connect_signals),
1603 (modest_main_window_new):
1604 Handle TnyAccountStore::connecting-finished instead of
1605 TnyDevice::connection-changed, because we cannot actually perform
1606 operations on accounts until TnyAccountStore has itself responded to
1607 the TnyDevice::connection-changed signal. This prevents a GError from
1609 Do not try to update at startup, because we (at least on scratchbox)
1610 already do an update at startup when the device goes online.
1611 This prevents a GError from tinymail.
1612 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1613 Added TODO about stopping simultaneous operations.
1615 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1617 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1618 * src/modest-mail-operation-queue.c:
1619 (modest_mail_operation_queue_remove):
1620 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1621 about where they happened.
1623 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-ui-actions.c:
1626 (modest_ui_actions_on_password_requested): Make sure that the remember
1627 output parameter is always TRUE.
1629 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1632 Show a OK/Cancel dialog if the error is a question, though we still do not
1633 know anything more about what we are asking the user.
1634 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1635 Fix an uninitialized variable (helper). This is a logic error, however.
1637 2007-05-21 Christian Kellner <ckellner@openismus.com>
1639 * src/modest-search.h:
1640 Correct bit shifting in the ModestSearchFlags enum.
1642 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-tny-account.c:
1645 (modest_tny_account_new_from_server_account): Do not use the lsub and
1646 check-all hard-coded IMAP options when using POP.
1648 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1650 * src/modest-tny-account.c:
1651 (modest_tny_account_new_from_server_account):
1652 Use NULL for the secure-auth method for POP when Password auth has been
1653 specified by the user, as we already do for IMAP. "auth=Login" causes
1654 an error from camel or the server.
1656 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1658 * src/maemo/modest-account-settings-dialog.c:
1659 (create_page_account_details),
1660 (modest_account_settings_dialog_set_account_name):
1661 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1662 for the leave-on-server checkbox, rathr than just the checkbox, when
1663 the protocol is not POP.
1665 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1667 * src/widgets/modest-account-view.c:
1668 * src/widgets/modest-account-view.h:
1669 Added modest_account_view_select_account() which will be useful later
1670 to asynchronously re-select the edited account.
1672 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1674 * src/maemo/modest-account-settings-dialog.c:
1675 (modest_account_settings_dialog_set_account_name):
1676 Automatically choose the port numbers based on the secure authentication
1677 methods, if they have not been chosen before.
1678 This fixes projects.maemo.org bug NB#56273 .
1680 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1682 * src/maemo/modest-main-window-ui.h:
1683 * src/modest-ui-actions.c:
1684 * src/modest-ui-actions.h:
1685 Connect the Tools/SMTP Servers menu item to
1686 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1687 SMTP servers dialog, as in the UI specification and saves changes when it
1688 is closed. This fixed projects.maemo.org bug NB#56305 .
1690 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1692 * src/maemo/modest-connection-specific-smtp-window.c:
1693 (modest_connection_specific_smtp_window_init):
1694 Use gtk_window_set_default_size() to make this window big enough, so
1695 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1697 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1700 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1701 (modest_connection_specific_smtp_edit_window_init),
1702 Do not try to connect to a combobox signal before the combobox exists.
1703 This fixes the cras in projects.maemo.org bug NB#56288 .
1704 (modest_connection_specific_smtp_edit_window_get_settings):
1705 Remove the server_account_name parameter which was being checked for NULL
1706 though it was not used.
1708 * src/maemo/modest-connection-specific-smtp-window.c:
1709 (modest_connection_specific_smtp_window_fill_with_connections),
1710 (on_button_edit), (modest_connection_specific_smtp_window_init):
1711 Correct the number of treemodel columns to prevent a warning.
1712 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1713 libconic does not work.
1715 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1717 * src/modest-tny-account.c:
1718 (modest_tny_account_new_from_server_account):
1719 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1720 SMTP when "None" was chosen by the user. However, with my SMTP server that
1721 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1724 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1727 to explain the memory management issue with the ID in the ModestPair.
1729 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1730 (add_sending_page), (modest_account_assistant_finalize):
1731 * src/gnome/modest-gnome-global-settings-dialog.c:
1732 (create_updating_page), (create_composing_page):
1733 * src/gnome/modest-msg-edit-window.c: (get_transports),
1734 (init_window), (modest_msg_edit_window_finalize),
1735 (modest_msg_edit_window_get_msg_data):
1736 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1737 * src/gnome/modest-transport-widget.c:
1738 (modest_transport_widget_finalize), (smtp_configuration):
1739 * src/maemo/modest-maemo-global-settings-dialog.c:
1740 (create_updating_page), (create_composing_page):
1741 * src/maemo/modest-msg-edit-window.c: (get_transports),
1742 (init_window), (modest_msg_edit_window_finalize),
1743 (modest_msg_edit_window_get_msg_data),
1744 (modest_msg_edit_window_free_msg_data):
1745 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1746 (modest_store_widget_finalize):
1747 * src/maemo/modest-transport-widget.c:
1748 (modest_transport_widget_finalize), (smtp_configuration):
1749 * src/modest-main.c: (send_mail):
1750 * src/widgets/modest-combo-box.h:
1751 * src/widgets/modest-global-settings-dialog-priv.h:
1752 * src/widgets/modest-global-settings-dialog.c:
1753 (modest_global_settings_dialog_finalize):
1754 * src/widgets/modest-msg-edit-window.h:
1755 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1756 as long as the combo box, to prevent use of freed memory for the ID.
1758 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1761 get_accounts(), to make this clearer. Do not check for the enabled gconf
1762 key, because we do not use this for server accounts (at least, not yet).
1763 This allows us to send email again.
1765 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1767 * src/maemo/modest-platform.c:
1768 (on_modest_conf_update_interval_changed), (modest_platform_init):
1769 Only respond to this particular key change. All these strcmp()s cannot be
1772 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1774 * src/maemo/modest-maemo-global-settings-dialog.c:
1775 (current_connection): Prevent a crash in scratchbox when
1776 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1777 * src/maemo/modest-platform.c:
1778 (on_modest_conf_update_interval_changed), (modest_platform_init):
1779 Get the update interval from gconf and reset it when the gconf key changes.
1781 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1783 * src/modest-protocol-info.c:
1784 * src/modest-protocol-info.h: Adde enum-specific get functions,
1785 instead of using a ModestProtocolType enum parameter.
1787 * src/gnome/modest-account-assistant.c:
1788 * src/gnome/modest-store-widget.c:
1789 * src/gnome/modest-store-widget.h:
1790 * src/gnome/modest-transport-widget.c:
1791 * src/gnome/modest-transport-widget.h:
1792 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1793 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1794 * src/maemo/easysetup/modest-easysetup-wizard.c:
1795 * src/maemo/modest-account-settings-dialog.c:
1796 * src/maemo/modest-account-settings-dialog.h:
1797 * src/maemo/modest-store-widget.c:
1798 * src/maemo/modest-store-widget.h:
1799 * src/maemo/modest-transport-widget.c:
1800 * src/maemo/modest-transport-widget.h:
1801 * src/modest-account-mgr-helpers.c:
1802 * src/modest-account-mgr-helpers.h:
1803 * src/modest-account-mgr.c:
1804 * src/modest-account-mgr.h:
1805 * src/modest-tny-account.c:
1806 * src/modest-tny-folder.c:
1807 * src/widgets/modest-account-view.c:
1808 * src/widgets/modest-retrieve-combo-box.c:
1809 * src/widgets/modest-retrieve-combo-box.h:
1810 * src/widgets/modest-secureauth-combo-box.c:
1811 * src/widgets/modest-serversecurity-combo-box.c:
1812 * src/widgets/modest-serversecurity-combo-box.h:
1813 * tests/check_account-mgr.c:
1814 Use the specific functions, and use the re-renamed enum values for GNOME too.
1816 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1818 * src/modest-pair.h:
1819 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1820 so we can get the second based on the first.
1822 * src/maemo/modest-account-settings-dialog.h:
1823 * src/maemo/modest-account-settings-dialog.c:
1824 Added get_supported_secure_authentication_methods(), though it is mostly
1825 commented-out for now until the necessary API is committed to tinymail.
1826 (modest_account_settings_dialog_set_account_name),
1827 (save_configuration): Request the supported authentication methods from the
1828 server, so we can choose a working method.
1830 * src/modest-tny-account-store.h:
1831 * src/modest-tny-account-store.c:
1832 (modest_tny_account_store_get_session): Rename from
1833 tny_account_store_get_session().
1835 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1837 * src/modest-protocol-info.h: Split the ModestProtocol enum
1838 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1839 There was no need to have these unrelated values in one enum.
1841 * src/: many files: Adapted to changed enum. This makes the code a bit
1842 clearer, and the compiler could catch some errors.
1844 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1847 Show the detailed internal camel error message when an error happens
1848 during the configuration, so that our testers can give us more clues.
1849 For instance, in projects.maemo.org bug NB#56910 .
1851 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1853 * src/modest-tny-account.c:
1854 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1855 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1857 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1859 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1860 * src/maemo/modest-account-settings-dialog.c:
1861 (modest_account_settings_dialog_set_account_name),
1862 (save_configuration): For the incoming secure authentication checkbox,
1863 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1864 the UI specification. PLAIN does not seem to be supported for most IMAP
1865 servers anyway, and I am not sure what it would mean.
1866 However, we probably need to discover which of the secure-authentication
1867 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1868 * src/modest-account-mgr-helpers.c:
1869 (modest_account_mgr_get_server_account_data):
1871 * src/modest-tny-account.c:
1872 (modest_tny_account_new_from_server_account):
1873 Use tny_account_set_mech() to set secure-authentication methods,
1874 with some special-casing for IMAP, based on my observations of how
1877 * src/modest-account-mgr-helpers.h:
1878 * src/modest-account-mgr.c:
1879 * src/modest-defs.h: Comment that the URI is only used for local folders.
1881 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1883 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1884 parameter const, just to be neat.
1885 * src/modest-text-utils.c: (modest_text_utils_inline):
1886 End g_strconcat() with NULL, as its documentation says. This is almost
1887 certainly the cause of my crash at startup on the device. Interestingly,
1888 valgrind doesn't tell us about these errors.
1890 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1892 * scripts/build-packages: Added more precise comments about how to use
1893 this script, though I still get this error:
1894 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1895 error building tinymail
1897 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1899 * src/maemo/modest-main-window.c: (on_account_update):
1900 Very slight cleanup, hoping to make it simpler to discover what causes
1901 a crash here sometimes.
1903 * src/modest-tny-account.c:
1904 (modest_tny_account_new_from_server_account): Set the port. Added
1905 comments about the options and a TODO comment because I need to find out
1906 how to specify the secure authentication method.
1908 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1910 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1911 changed CFlags paths form modest to libmodest
1913 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1915 * src/modest-account-mgr-helpers.c:
1916 (modest_account_mgr_get_server_account_data),
1917 (modest_account_mgr_free_server_account_data):
1918 * src/modest-account-mgr-helpers.h:
1919 * src/modest-account-mgr.c:
1920 (modest_account_mgr_add_server_account):
1921 * src/modest-defs.h:
1922 * src/modest-tny-account.c:
1923 (modest_tny_account_new_from_server_account):
1924 Determine the options for tny_camel_account_add_option() here,
1925 based on the settings, rather than storing them directly in gconf.
1927 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1930 Show a more friendly error dialog now that we expect (from the tinymail
1931 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1933 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/modest-main-window.c: (on_account_update): Check that
1936 account_name is not NULL, to prevent a crash at startup that I am
1937 seeing on the N800. I do wonder why it is NULL.
1939 * src/maemo/easysetup/modest-easysetup-wizard.c:
1940 (create_page_user_details):
1941 * src/maemo/modest-account-settings-dialog.c:
1942 (create_page_user_details), (create_page_outgoing):
1943 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1944 (modest_connection_specific_smtp_edit_window_init):
1945 * src/modest-ui-actions.c:
1946 (modest_ui_actions_on_password_requested):
1947 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1948 might do something useful with the on-screen keyboard.
1950 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1952 * src/maemo/modest-main-window.c: (on_account_update):
1953 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1954 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1956 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1958 * src/modest-tny-account-store.c: (on_account_changed):
1959 Correct the signature of this signal handler.
1961 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1963 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1964 Show a HildonNote instead of a GtkDialog for Maemo.
1966 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1968 * src/widgets/modest-account-view.h:
1969 * src/widgets/modest-account-view.c: (on_account_changed),
1970 (on_account_removed). Added a boolean flag, set/unset by
1971 modest_account_view_block_conf_updates(),
1972 modest_account_view_unblock_conf_updates() to prevent unnecessary
1973 updates, but this is not very useful because the gconf notifications are
1974 so delays (maybe only on Maemo Bora).
1975 So auto-updating is turned off, and these functions do an explicit
1976 update when necessary.
1977 However, something else is still doing too much work when adding/removing
1978 accounts, probably in another part of the application.
1980 * src/maemo/modest-account-view-window.c:
1981 (on_delete_button_clicked), (on_edit_button_clicked),
1982 (on_new_button_clicked): Use the new functions.
1984 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1986 * src/modest-account-mgr-helpers.c:
1987 (modest_account_mgr_set_first_account_as_default):
1988 Sort the list of names alphabetically-by-title, so we choose the first one
1990 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1991 alphabetically by the title.
1993 This fixes projects.maemo.org bug NB#56418 .
1995 * src/modest-account-mgr-priv.c:
1996 (_modest_account_mgr_account_from_key):
1997 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1998 avoid a valgrind error, and possible random behaviour.
2000 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2002 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2003 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2004 tinymail documentation to say that this can be expected.
2005 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2006 pretty, and should not happen, but I would prefer to know when it does.
2008 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2010 * configure.ac: When using the older hildon version, probably on Bora,
2011 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2013 * src/widgets/modest-attachment-view.c:
2014 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2017 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2019 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2020 Implemented the prototype. Can be tested with
2021 tests/dbus_api/test_open_message:
2023 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2025 * src/modest-tny-account-store.c:
2026 (modest_tny_account_store_instance_init), (get_password):
2027 * src/modest-ui-actions.c:
2028 (modest_ui_actions_on_password_requested):
2029 Do not store the password in gconf, because this function is called
2030 for non-remembered passwords. Actually use the cached (in the hash map)
2031 password instead of releasing it.
2032 The password will now not be remembered if it is asked via the protected
2033 password dialog, as per the UI spec.
2035 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2037 * src/modest-defs.h:
2038 * src/modest-account-mgr-helpers.h:
2039 * src/modest-account-mgr-helpers.c:
2040 Added modest_server_account_get_username_has_succeeded(),
2041 modest_server_account_set_username_has_succeeded().
2042 (modest_server_account_set_username),
2043 Reset the has-succeeded flag if the username changes.
2045 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2046 * src/maemo/modest-connection-specific-smtp-window.c:
2047 (modest_connection_specific_smtp_window_save_server_accounts):
2048 Use modest_server_account_set_username() instead of using
2049 modest_conf_set_string() directly, so that the has-succeeded flag is always
2052 * src/modest-ui-actions.c:
2053 (modest_ui_actions_on_password_requested): Dim the username entry if
2054 the username has ever worked, as per the UI spec.
2056 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2058 * src/modest-tny-account-store.c: (get_password):
2059 * src/modest-ui-actions.c:
2060 (modest_ui_actions_on_password_requested):
2061 Allow the username to be changed too, though there is more work to
2062 be done on exactly how this behaves.
2064 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2066 * src/modest-account-mgr-helpers.h:
2067 * src/modest-account-mgr-helpers.c:
2068 Added modest_account_mgr_get_display_name(),
2069 modest_server_account_get_username(),
2070 modest_server_account_set_username(),
2071 modest_server_account_set_password(),
2072 modest_server_account_get_hostname() functions so we do not need to
2073 use the conf API directly.
2075 * src/maemo/modest-main-window.c: (connect_signals):
2076 Actually connect ot the ModestAccountStore::request-password signal,
2077 so that we show the dialog when the password is requested by Tinymail,
2078 for isntance if it is empty.
2080 * src/modest-marshal.list:
2081 * src/modest-tny-account-store.c:
2082 (modest_tny_account_store_class_init), (get_password),
2083 (modest_tny_account_store_alert):
2084 * src/modest-tny-account-store.h:
2085 * src/modest-ui-actions.h:
2086 * src/modest-ui-actions.c:
2087 (modest_ui_actions_on_password_requested):
2088 Change the signal parameters, so it is obvious that we are providing
2089 the non human-readable server name, and receiving both the username
2090 and password, though changing of the username is not yet implemented.
2091 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2092 for the GNOME version.
2094 This should fix the projects.maemo.org bug NB#56209, though it does not
2095 work on Bora, because the gconf_client_get() for the password fails
2096 immediately after we save it with gconf_client_set().
2098 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2101 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2102 caused an undefined symbol error:
2103 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2105 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2107 * src/modest-tny-account-store.c:
2108 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2109 using a GError instead of a string message, so we can translate it in
2112 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-address-book.c:
2115 (modest_address_book_check_names):
2116 * src/maemo/modest-msg-view-window.c:
2117 (modest_msg_view_window_clipboard_owner_change):
2118 * src/modest-init.c: (modest_init_init_ui):
2119 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2120 (update_folders_cb), (modest_mail_operation_update_account):
2121 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2122 (modest_ui_actions_on_msg_attachment_clicked),
2123 (modest_ui_actions_on_msg_recpt_activated):
2124 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2125 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2126 (modest_msg_view_search_next):
2127 * src/widgets/modest-recpt-editor.c:
2128 (modest_recpt_editor_on_button_release_event),
2129 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2130 g_message(). At this point we should only be seeing interesting errors on
2131 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2133 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2135 (modest_wizard_dialog_force_title_update):
2136 * src/maemo/easysetup/modest-wizard-dialog.h:
2137 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2138 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2139 can update the title when appropriate. Otherwise the title is wrong if the
2140 pages are added after adding the notebook to the dialog.
2141 This must be a problem in HildonWizardDialog too.
2142 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2144 * src/maemo/easysetup/modest-easysetup-wizard.c:
2145 (create_subsequent_customsetup_pages),
2146 (create_subsequent_easysetup_pages):
2147 Call modest_wizard_dialog_force_title_update() so that the title is
2148 correct even with GTK+ < 2.10.
2149 This fixes projects.maemo.org bug NB#56145 .
2151 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2153 * src/maemo/modest-platform.c:
2154 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2155 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2158 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2160 * src/widgets/modest-window.h:
2161 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2162 and modest_window_save_state(), which invokes it.
2164 * src/widgets/modest-window-mgr.h:
2165 * src/widgets/modest-window-mgr.c:
2166 Added modest_window_mgr_save_state_for_all_windows(), which calls
2167 the save_state vfunc on all registered windows, if implemented.
2169 * src/gnome/modest-msg-edit-window.c:
2170 * src/gnome/modest-msg-view-window.c:
2171 * src/maemo/modest-msg-edit-window.c:
2172 * src/maemo/modest-msg-view-window.c:
2173 * src/maemo/modest-main-window.c:
2174 Specify the existing save_settings functions as implementations of
2175 ModestWindow::save_state_func().
2177 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2178 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2179 enabling hibernation, for instance.
2181 We may need to do the same thing for restoring settings.
2184 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2186 * src/widgets/modest-window-mgr.c:
2187 * src/widgets/modest-window-mgr.h:
2188 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2189 modest_window_mgr_get_hibernation_is_prevented().
2191 * src/maemo/modest-main-window.c:
2192 (on_hildon_program_is_topmost_notify): Prevent hibernation
2193 (possible when the application goes to the background in the WM),
2194 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2196 * src/maemo/easysetup/modest-easysetup-wizard.c:
2197 (modest_easysetup_wizard_dialog_init):
2198 * src/maemo/modest-account-settings-dialog.c:
2199 (modest_account_settings_dialog_init):
2200 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2201 (modest_connection_specific_smtp_edit_window_init):
2202 * src/maemo/modest-connection-specific-smtp-window.c:
2203 (modest_connection_specific_smtp_window_init):
2204 * src/maemo/modest-signature-editor-dialog.c:
2205 (modest_signature_editor_dialog_init):
2206 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2207 prevent hibernation while any of these account settings dialogs are open.
2209 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2211 * src/maemo/Makefile.am:
2212 * src/maemo/modest-osso-state-saving.c:
2213 * src/maemo/modest-osso-state-saving.h: Added
2214 modest_osso_load_state() and modest_osso_save_state() though they do
2215 nothing now. They should iterate through all the open windows and load/save
2217 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2218 save state when closing.
2220 * src/maemo/modest-main-window.c:
2221 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2222 Add a notification handler for the HildonProgram::is-topmost property,
2223 so we can allow hibernation when the application goes into the background.
2224 But we still need to detect when the accounts setup windows are open so
2225 we can stop hibernation when they are open.
2226 To do this, I also added the main window the HildonProgram. This might have
2227 other side-effects/benefits, and should maybe be done for other windows.
2229 * src/maemo/modest-osso-autosave-callbacks.h:
2230 * src/maemo/modest-osso-autosave-callbacks.c:
2231 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2232 though it does not do anything yet, and we might never need this to do
2233 anything. For instance, we already save drafts.
2235 * src/maemo/modest-platform.c: (modest_platform_init):
2236 Specify the libosso auto-save callback.
2238 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/modest-platform.c:
2241 (modest_platform_set_update_interval):
2242 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2243 aparently stays valid between application instances, so we can use this
2244 to remove and reset it later. According to a maemo-developers email from
2247 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2249 * configure.ac: Depend on libalarm for Maemo.
2251 * src/dbus_api/modest-dbus-api.h:
2252 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2253 (on_send_receive), (modest_dbus_req_handler):
2254 Handle a SEND_RECEIVE D-Bus method.
2256 * libmodest-dbus-client/libmodest-dbus-client.c:
2257 (libmodest_dbus_client_send_and_receive):
2258 * libmodest-dbus-client/libmodest-dbus-client.h:
2259 Add C convenience functions for calling the new D-Bus method.
2261 * src/modest-platform.h:
2262 * src/gnome/modest-platform.c:
2263 * src/maemo/modest-platform.c:
2264 Added modest_platform_set_update_interval(), which uses the
2265 alarmd API on Maemo.
2266 (modest_platform_init),
2267 Call modest_platform_set_update_interval(), using a hard-coded
2268 interval for now (until the global settings dialog is implemented),
2269 though I am not sure that this makes sense yet.
2271 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2273 * src/dbus_api/modest-dbus-callbacks.c:
2274 (modest_osso_cb_hw_state_handler):
2275 * src/dbus_api/modest-dbus-callbacks.h:
2276 * src/maemo/modest-platform.c: (modest_platform_init):
2277 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2278 in case this has some effect on the ability for Maemo to ping the
2281 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2283 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2284 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2285 warning. It is probably a logic error, but I need to fix the build.
2287 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2289 * src/modest-account-mgr.h:
2290 * src/modest-account-mgr.c:
2291 (modest_account_mgr_account_names): Add a gboolean enabled_only
2292 parameter, so we can get lists of onlt the enabled accounts.
2294 (modest_account_mgr_add_account),,
2295 (modest_account_mgr_account_with_display_name_exists):
2296 * src/maemo/modest-msg-edit-window.c: (get_transports):
2297 * src/modest-account-mgr-helpers.c:
2298 (modest_account_mgr_set_first_account_as_default):
2299 * src/modest-init.c: (init_default_account_maybe):
2300 * src/modest-tny-account-store.c: (get_accounts):
2301 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2302 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2303 * tests/check_account-mgr.c: (START_TEST):
2304 Provide the extra parameter, as appropriate.
2306 * src/widgets/modest-account-view.c: (update_account_view):
2307 Do not show disabled accounts (meaning that there is no way to
2308 enable/disable accounts in the UI (the feature is not in our UI
2309 specification), so we can use this internally only to mark unfinished
2310 or temporary account data.
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 (create_account): Add boolean enable parameter, so we can specify FALSE
2314 to create the temporary account.
2315 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2316 (on_before_next): When finishing, when there is a temporary account, just
2318 Also, use a timeout to delay the showing of the dialog until gconf is likely
2319 to return correct information, due to a maemo gconf bug that is fixed in
2320 osso 1.1, but not yet in Bora.
2321 However, the dialog stays on screen after it is destroyed.
2323 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2324 for invalid data when cancelling. Use a hildon note instead of a dialog
2325 to complain about invalid data. Do not show the account-saved note if the
2326 account is disabled (a temporary account that will not really be saved for use
2329 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2331 * src/modest-account-mgr-helpers.h:
2332 * src/modest-account-mgr-helpers.c:
2333 Added modest_account_mgr_unset_default_account(),
2334 Added modest_account_mgr_set_first_account_as_default().
2336 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2337 If it was the default account, unset the default account name.
2339 * src/maemo/modest-account-view-window.c:
2340 (on_delete_button_clicked): If it was the default account,
2341 set the first remaining account as the default instead.
2343 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2344 a NULL account or a NULL default account, to prevent a crash. This should
2345 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2348 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2350 * src/widgets/modest-recpt-editor.c:
2351 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2352 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2353 TODO comment for this. This fixes the build.
2355 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2356 be the best place for it. This will in future update all auto-update accounts,
2357 rather than just the current/default account, when that gconf key exists.
2358 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2359 if there are no accounts, before calling do_send_receive().
2360 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2362 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2363 * src/maemo/modest-main-window-ui.h:
2364 * src/maemo/modest-main-window.c: (on_connection_changed),
2365 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2366 directly, becaue the signal handler does more.
2368 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-account-mgr-helpers.c:
2371 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2372 for the case that the account does not exist.
2374 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2375 (equivalent to the modest account name) rather than the tinymail account name
2376 (equivalent to the modest account title - human readable) to get the account data.
2377 Check for null account data to prevent the crash, and add a TODO comment saying that
2378 this needs fixing because it is using the server account name instead of the account name.
2380 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2383 * src/maemo/modest-account-settings-dialog.c: (show_error),
2385 Use hildon_note_new_information() for informative and error messages,
2386 which seems to be expected for Maemo applications (no documentation that I know of
2387 says this). I am surprised that there is no distinction between info and error
2390 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2392 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2393 it is easy to find where this is used.
2395 * src/maemo/easysetup/modest-easysetup-wizard.c:
2396 (create_page_welcome), (create_page_account_details),
2397 (create_page_user_details), (create_page_complete_easysetup),
2398 (create_page_custom_incoming), (create_page_custom_outgoing),
2399 (create_page_complete_custom):
2400 * src/maemo/modest-account-settings-dialog.c:
2401 (create_page_account_details), (create_page_user_details),
2402 (create_page_incoming), (create_page_outgoing):
2403 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2404 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2405 (modest_connection_specific_smtp_edit_window_init):
2406 * src/maemo/modest-connection-specific-smtp-window.c:
2407 (modest_connection_specific_smtp_window_init):
2408 * src/maemo/modest-signature-editor-dialog.c:
2409 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2410 and scrolling policy as per the Email Application Layout Guide, if I have
2413 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2415 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2416 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2417 which were empty, because these vfuncs have been removed from TnyAccountStore.
2418 This fixes the build.
2420 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2422 * src/maemo/modest-main-window.c:
2423 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2424 showing/hiding it. Added TODO because it probably should not be NULL.
2425 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2426 because unnecessary g_warnings() make degugging difficult.
2428 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2430 * src/maemo/modest-msg-edit-window.c:
2431 (modest_msg_edit_window_select_color),
2432 (modest_msg_edit_window_select_background_color): 2 const corrections and
2433 moving 2 #endifs before closing brackets, to fix the build.
2435 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2437 * src/maemo/easysetup/modest-easysetup-wizard.h:
2438 * src/maemo/easysetup/modest-easysetup-wizard.c:
2439 (modest_easysetup_wizard_dialog_finalize),
2440 (on_button_edit_advanced_settings), (create_page_complete_custom),
2441 (on_response), (create_account):
2442 Implement the Advanced Settings edit button, by saving the account information,
2443 for the Advanded Settings dialog to use directly from gconf, and removing it
2444 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2445 Bug #5533 in the projects.maemo.org bugzilla.
2447 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/modest-msg-view-window.c:
2450 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2451 when opening a message window.
2453 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2455 * src/maemo/easysetup/modest-easysetup-wizard.c:
2456 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2459 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2460 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2461 gconf settings. I probably added more checks than necessary, but that is safer.
2463 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2464 variable to fix the build, but this seems to be used when it is still NULL.
2466 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2468 * src/modest-platform.h:
2469 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2470 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2471 * src/modest-main.c: Implement this function so we can avoid using
2472 maemo-specific API from cross-platform code.
2474 * src/modest-tny-account-store.c:
2475 (get_smtp_specific_transport_account_for_open_connection):
2476 * src/modest-ui-actions.c: (check_for_connection),
2477 (modest_ui_actions_on_item_not_found):
2478 Use modest_platform_connect_and_wait() and put #idefs around other
2479 maemo-specific code, because only maemo currently has a way to
2480 identify connection names.
2482 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2484 * src/modest-tny-account-store.h:
2485 * src/modest-tny-account-store.c:
2486 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2487 the connection-specific SMTP server settings in the configuration.
2489 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2491 * src/maemo/modest-main-window.c: (on_connection_changed),
2493 * src/modest-main.c: (main), (start_ui), (send_mail):
2494 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2495 that is what is intended.
2497 * src/modest-ui-actions.c: (action_send), (action_receive),
2498 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2499 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2500 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2501 SMTP server is used when it is specified.
2503 (modest_ui_actions_on_send_receive):
2504 Check that a connection is open before proceeding.
2505 Receive and then send, instead of vice-versa, as per the specification.
2507 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-mail-operation.c:
2510 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2511 though I guess it should be something other than NULL.
2513 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/easysetup/modest-easysetup-wizard.c:
2516 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2517 combo twice, to avoid an g_warning and to make it visible again.
2518 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2519 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2520 (already intended) dereference when detaching, because we then recreate the menu.
2521 But I am not sure why the warning was happening, and it is possible that this is a memory
2524 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2526 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2527 and uri_parse_mailto() utility functions.
2528 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2530 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2532 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2534 * src/dbus_api/modest-dbus-api.h:
2535 * src/dbus_api/modest-dbus-callbacks.c:
2536 Use an idle callback to execute the modest code in the application's own thread.
2537 Remove the helloworld example method.
2538 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2539 parsed, and the open-message method is not implemented because this is not yet implemented in
2541 * libmodest-dbus-client/libmodest-dbus-client.c:
2542 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2543 (libmodest_dbus_client_open_message):
2544 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2546 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2547 body without crashing.
2549 * tests/dbus_api/Makefile.am:
2550 * tests/dbus_api/test_mail_to.c:
2551 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2553 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2555 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2556 Added file to fix the build. Sorry.
2558 * src/dbus_api/Makefile.am:
2559 * src/dbus_api/modest-dbus-api.h:
2560 * src/dbus_api/modest-dbus-callbacks.h:
2561 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2562 (modest_dbus_req_handler):
2563 Put constants in a separate header so it can be reused by the
2564 client library, without duplication
2566 * libmodest-dbus-client/Makefile.am:
2567 * libmodest-dbus-client/libmodest-dbus-client.c:
2568 (libmodest_dbus_client_call_helloworld),
2569 (libmodfest_dbus_client_send_mail),
2570 (libmodfest_dbus_client_mailto),
2571 (libmodfest_dbus_client_open_message):
2572 * libmodest-dbus-client/libmodest-dbus-client.h:
2573 (Partly) Implement a send_mail D-Bus method.
2575 * tests/dbus_api/Makefile.am:
2576 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2577 the send_email D-Bus method.
2579 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2583 * libmodest-dbus-client/Makefile.am:
2584 * libmodest-dbus-client/libmodest-dbus-client.c:
2585 * libmodest-dbus-client/libmodest-dbus-client.h:
2586 * tests/dbus_api/Makefile.am:
2587 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2588 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2590 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/easysetup/modest-easysetup-wizard.c:
2593 (create_page_account_details):
2594 * src/maemo/modest-account-settings-dialog.c:
2595 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2596 widgets, because this might not be the default in future versions of the Maemo GTK+.
2597 However, I can not not get capitalization to work even in a simple test case.
2599 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2601 * src/maemo/easysetup/modest-easysetup-wizard.c:
2602 (create_page_custom_incoming), (create_page_custom_outgoing):
2603 * src/maemo/modest-account-settings-dialog.c:
2604 (create_page_account_details), (create_page_incoming),
2605 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2606 instead of using gtk_check_button_with_label(), so they are aligned like the other
2607 widgets, as per the UI spec.
2609 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/easysetup/modest-easysetup-wizard.c:
2612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2613 * src/widgets/modest-validating-entry.c:
2614 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2615 Modest prefix instead of an EasySetup prefix.
2617 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2619 * src/widgets/modest-validating-entry.h:
2620 * src/widgets/modest-validating-entry.c: (on_insert_text),
2621 Added easysetup_validating_entry_set_max_func(), used to set a callback
2622 to call when the max number of characters is reached. GtkEntry has a max-length
2623 already but is silent about it.
2625 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2626 (create_page_account_details), (create_page_user_details),
2628 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2629 (create_page_account_details), (create_page_user_details),
2630 (create_page_outgoing):
2631 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2632 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2633 the UI spec, when the user tries to enter more than the max number of characters.
2635 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2637 * src/maemo/easysetup/modest-easysetup-wizard.c:
2638 (create_page_user_details), (create_page_custom_incoming),
2639 (create_page_custom_outgoing):
2640 * src/maemo/modest-account-settings-dialog.c:
2641 (create_page_user_details), (create_page_incoming),
2642 (create_page_outgoing):
2643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2644 (modest_connection_specific_smtp_edit_window_init):
2645 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2646 not appropriate. Bad Maemo-specific defaults!.
2648 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2651 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2652 (modest_signature_editor_dialog_set_settings):
2653 Disable the label and textview when the checkbox is disabled, and use the
2654 specified (UI spec) default signature text.
2656 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2658 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2659 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2661 * src/modest-defs.h:
2662 * src/modest-account-mgr-helpers.h:
2663 * src/modest-account-mgr-helpers.c:
2664 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2666 * src/maemo/Makefile.am:
2667 * src/maemo/modest-signature-editor-dialog.c:
2668 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2671 * src/maemo/modest-account-settings-dialog.h:
2672 * src/maemo/modest-account-settings-dialog.c:
2673 (modest_account_settings_dialog_finalize), (on_button_signature),
2674 (save_configuration): Use the new dialog when the Edit button is pressed, and
2675 save the changes if necessary, as per the UI spec.
2677 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2679 * src/maemo/Makefile.am:
2680 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2681 based on maemo-develoers email from Dirk.
2683 * src/maemo/easysetup/modest-easysetup-wizard.c:
2684 (create_page_welcome), (create_page_account_details),
2685 (create_page_user_details), (create_page_complete_easysetup),
2686 (create_page_custom_incoming), (create_page_custom_outgoing),
2687 (create_page_complete_custom),
2688 (modest_easysetup_wizard_dialog_init):
2689 * src/maemo/modest-account-settings-dialog.c:
2690 (create_page_account_details), (create_page_user_details),
2691 (create_page_incoming), (create_page_outgoing),
2692 (modest_account_settings_dialog_init):
2693 * src/maemo/modest-connection-specific-smtp-window.c:
2694 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2696 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/easysetup/modest-easysetup-wizard.c:
2699 (create_page_account_details), (create_page_custom_outgoing),
2700 (create_page_complete_custom):
2701 * src/maemo/modest-account-settings-dialog.c:
2702 (create_page_user_details), (create_page_incoming),
2703 (create_page_outgoing):
2704 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2705 (modest_connection_specific_smtp_edit_window_init):
2706 Use the correct (UI spec) port min/max, and use horizontal separators,
2709 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/easysetup/modest-easysetup-wizard.c:
2712 (set_default_custom_servernames):
2713 * src/maemo/modest-account-settings-dialog.c:
2714 (create_page_incoming), (on_combo_outgoing_security_changed),
2715 (on_combo_incoming_security_changed), (create_page_outgoing),
2716 (modest_account_settings_dialog_set_account_name),
2717 (save_configuration):
2718 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2719 (on_combo_security_changed),
2720 (modest_connection_specific_smtp_edit_window_init),
2721 (modest_connection_specific_smtp_edit_window_set_connection),
2722 (modest_connection_specific_smtp_edit_window_get_settings):
2723 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2726 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2729 * src/maemo/easysetup/modest-easysetup-wizard.c:
2730 (create_page_custom_outgoing), (create_page_complete_custom):
2731 * src/maemo/modest-account-settings-dialog.c:
2732 (create_page_user_details), (create_page_outgoing):
2733 * src/maemo/modest-account-view-window.c: (button_box_new):
2734 Use changed logical IDs as per the most recent UI spec:
2735 mcen_bd_emailsetup_edit -> mcen_bd_edit
2736 mcen_bd_emailsetup_delete -> mcen_bd_delete
2737 mcen_bd_emailsetup_close -> mcen_bd_close
2739 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2743 * src/dbus_api/Makefile.am:
2744 * src/dbus_api/modest-dbus-callbacks.c:
2745 * src/dbus_api/modest-dbus-callbacks.h:
2746 * src/maemo/modest-platform.c: (modest_platform_init):
2747 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2749 * tests/Makefile.am:
2750 * tests/dbus_api/Makefile.am:
2751 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2753 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/modest-account-settings-dialog.c:
2756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2757 Removed unnecessary includes.
2759 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2761 * src/maemo/easysetup/modest-easysetup-wizard.c:
2762 * src/maemo/modest-account-settings-dialog.c:
2763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2764 * src/widgets/Makefile.am:
2765 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2766 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2767 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2768 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2769 * src/widgets/modest-secureauth-combo-box.c:
2770 * src/widgets/modest-secureauth-combo-box.h:
2771 * src/widgets/modest-serversecurity-combo-box.c:
2772 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2773 made the GObject names more consistent with the rest of the Modest code.
2775 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2777 * src/maemo/easysetup/Makefile.am:
2778 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2779 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2780 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2781 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2782 * src/maemo/easysetup/modest-easysetup-wizard.c:
2783 * src/maemo/easysetup/modest-validating-entry.c:
2784 * src/maemo/easysetup/modest-validating-entry.h:
2785 * src/maemo/modest-account-settings-dialog.c:
2786 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2787 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2788 widgets/ because they are used outside of easysetup too. After checking in,
2789 svn will allow me to rename them too.
2791 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2793 * src/gnome/modest-msg-edit-window.c:
2794 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2795 linker error, to fix the build on the GNOME platform.
2796 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2797 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2798 ifdefed out to avoid a warning.
2800 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2802 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2803 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2804 some alternative for GTK+ 2.6.
2806 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2808 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2810 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2811 specified for EmailAccountsDialog in UI spec.
2813 * src/maemo/easysetup/modest-easysetup-wizard.c:
2814 * src/maemo/easysetup/modest-easysetup-wizard.h:
2815 * src/maemo/modest-account-settings-dialog.c:
2816 * src/maemo/modest-account-settings-dialog.h:
2817 Reuse a member window widget for the connection-specific SMTP server accounts,
2818 so we can tell it to create/save the accounts only if we actually save changes.
2820 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2822 (modest_connection_specific_smtp_edit_window_get_settings):
2823 Return a struct instance for temporarily remembering the entered data.
2825 * src/maemo/modest-connection-specific-smtp-window.h:
2826 * src/maemo/modest-connection-specific-smtp-window.c:
2827 (modest_connection_specific_smtp_window_finalize),
2828 (modest_connection_specific_smtp_window_fill_with_connections),
2830 (modest_connection_specific_smtp_window_save_server_accounts),
2831 (update_model_server_names): Do not actually save data until asked,
2832 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2834 (on_selection_changed),
2835 (modest_connection_specific_smtp_window_init): Disable the edit
2836 button when nothing is selected.
2838 * src/modest-account-mgr-helpers.c:
2839 * src/modest-account-mgr-helpers.h:
2840 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2843 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2845 * src/modest-account-mgr-helpers.h:
2846 * src/modest-account-mgr-helpers.c:
2847 (modest_account_mgr_get_unused_account_name),
2848 (modest_account_mgr_get_unused_account_display_name): Added these
2849 utility functions, to avoid code duplication.
2851 * src/maemo/easysetup/modest-easysetup-wizard.c:
2852 (create_page_account_details), (create_account):
2853 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2854 (on_combo_security_changed),
2855 (modest_connection_specific_smtp_edit_window_init),
2856 (modest_connection_specific_smtp_edit_window_save_settings):
2857 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2858 * src/maemo/modest-connection-specific-smtp-window.c:
2859 (modest_connection_specific_smtp_window_finalize),
2860 (modest_connection_specific_smtp_window_fill_with_connections),
2861 (on_button_edit), (modest_connection_specific_smtp_window_init):
2862 * src/maemo/modest-connection-specific-smtp-window.h:
2863 Implementing saving of connection-specific server accounts.
2865 But I need to refactor this so we can save the data for each
2866 possible connection-specific account and only actually create the server accounts
2867 when the easysetup finished, or the OK button is pressed on the account settings
2870 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2872 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2873 (on_combo_security_changed):
2874 (modest_connection_specific_smtp_edit_window_init):
2875 Auto-fill the port number as in the account settings.
2877 (modest_connection_specific_smtp_edit_window_set_connection):
2878 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2879 * src/maemo/modest-connection-specific-smtp-window.c:
2880 (fill_with_connections), (on_button_edit),
2881 (modest_connection_specific_smtp_window_init):
2882 Turn the edit window into a dialog to simplify the code, and
2883 set a WM hint as in a GtkDialog, because only a popup can be on top of
2884 another window in Maemo, and popups usually have no WM decoration.
2886 * src/modest-defs.h:
2887 * src/modest-account-mgr-helpers.c:
2888 (modest_account_mgr_set_connection_specific_smtp),
2889 (modest_account_mgr_remove_connection_specific_smtp),
2890 (modest_account_mgr_get_connection_specific_smtp):
2891 * src/modest-account-mgr-helpers.h: Some functions to write the
2892 connection-specific SMTP server information. Not yet used.
2895 * src/widgets/modest-folder-view.c: (text_cell_data):
2896 Fix a warning about an uninitialized variable.
2897 (on_configuration_key_changed): Put an #ifdef around the use
2898 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2900 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2902 * src/maemo/modest-account-settings-dialog.h:
2903 * src/maemo/modest-account-settings-dialog.c:
2904 Added connect_for_modified() utility function to mark the new modified boolean.
2906 (create_page_account_details), (create_page_user_details),
2907 (create_page_incoming), (create_page_outgoing), (on_response),
2908 (modest_account_settings_dialog_init),
2909 (modest_account_settings_dialog_set_account_name):
2910 Only warn about unsaved changes when there are actually unsaved changes.
2912 * src/modest-account-mgr-helpers.c:
2913 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2914 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2915 to get the data from there in future.
2917 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2919 * src/modest-defs.h:
2921 * src/modest-account-mgr-helpers.h:
2922 * src/modest-account-mgr-helpers.c:
2923 Store the security account setting in a single conf key instead of using
2924 the options list, so that the list is left for just the to-be-removed camel hack,
2925 and because gconf_client_set_list() is failing for some reason.
2927 * src/modest-account-mgr.c:
2928 (modest_account_mgr_add_server_account):
2929 * src/maemo/modest-account-settings-dialog.c:
2930 (modest_account_settings_dialog_set_account_name),
2931 (save_configuration): Use the renamed functions.
2934 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2936 * src/widgets/Makefile.am:
2937 * src/widgets/modest-limit-retrieve-combo-box.c:
2938 * src/widgets/modest-limit-retrieve-combo-box.h:
2939 * src/widgets/modest-retrieve-combo-box.c:
2940 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2941 the account settings dialog.
2943 * src/modest-defs.h:
2944 * src/modest-account-mgr-helpers.h:
2945 * src/modest-account-mgr-helpers.c:
2946 (modest_server_account_get_option_secure_auth),
2947 (modest_server_account_set_option_secure_auth):
2948 * src/modest-account-mgr.c:
2949 (modest_account_mgr_add_server_account):
2950 Use the existing AUTH_MECH conf key for the secure-auth setting,
2951 instead of putting it in the list options, because this was actually used already.
2953 * src/maemo/modest-account-settings-dialog.c:
2954 (create_page_account_details),
2955 (modest_account_settings_dialog_set_account_name),
2956 (save_configuration):
2957 * src/maemo/modest-account-settings-dialog.h:
2958 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2959 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2961 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2963 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2964 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2965 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2967 * src/modest-defs.h:
2968 * src/maemo/modest-account-settings-dialog.c:
2969 (create_page_incoming), (on_combo_outgoing_security_changed),
2970 (on_combo_incoming_security_changed), (create_page_outgoing),
2971 (modest_account_settings_dialog_set_account_name),
2972 (save_configuration): Load/Save the port number, and change it when the
2973 security combo changes, to suitable defaults.
2975 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2977 * src/modest-account-mgr.c:
2978 (modest_account_mgr_add_server_account): Set the security and secure-auth
2979 options, and add a comment saying that the other camel-specific options should be
2982 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2984 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2986 * src/modest-tny-account-store.c: (account_list_free),
2987 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2988 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2991 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2993 * src/modest-protocol-info.c:
2994 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2995 is required by our UI spec. Maybe something in our implementation will use this eventually.
2996 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2997 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2998 instead of the previous 0 placeholder.
3000 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3001 secure-auth settings.
3002 * src/modest-account-mgr-helpers.h:
3003 * src/modest-account-mgr-helpers.c:
3004 (modest_server_account_data_get_option_secure_auth),
3005 (modest_server_account_set_option_secure_auth),
3006 (modest_server_account_data_get_option_security),
3007 (modest_server_account_set_option_security): Added this API for getting and setting the security
3008 and secure-auth settings.
3010 * src/maemo/modest-account-settings-dialog.h:
3011 * src/maemo/modest-account-settings-dialog.c:
3012 (modest_account_settings_dialog_finalize), (check_data),
3013 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3014 about changing titles.
3015 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3016 (save_configuration): Save the security and secure-auth settings.
3018 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3019 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3021 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3023 * src/modest-defs.h:
3024 * src/modest-account-mgr.c:
3025 (modest_account_mgr_add_server_account):
3026 Added and used defines for the options key and value pair strings,
3027 that are used so far, though they do not seem to correspond to anything in our
3028 UI specs or ModestProtocol enum.
3030 * src/modest-account-mgr-helpers.h:
3031 * src/modest-account-mgr-helpers.c:
3032 (compare_option_strings_for_name),
3033 (modest_server_account_data_get_option_value),
3034 (modest_server_account_data_get_option_bool),
3035 (modest_account_mgr_get_server_account_option):
3036 Added helper functions for parsing the options GSList.
3038 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3040 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3041 display name is based on the supplied account name.
3042 * src/modest-account-mgr.c:
3043 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3044 with an inefficient, but good-enough, implementation.
3046 * src/maemo/easysetup/modest-easysetup-wizard.c:
3047 (create_page_account_details), (on_before_next), (create_account):
3048 Check for existing display names rather than (non-user-visible) account names, and just
3049 create and set a unique account name at the end.
3051 * src/maemo/modest-account-settings-dialog.c:
3052 (modest_account_settings_dialog_init),
3053 (modest_account_settings_dialog_set_account_name),
3054 (create_page_incoming): Show the display name, instead of the account name.
3055 (on_response): Do some (not all) extra checks, as in the UI spec.
3056 (save_configuration): Save the display name if it was changed.
3058 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3060 * po/en_GB.po: Added needed logical ID and translation.
3061 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3062 (init_view): Made the is-default column clicking work.
3064 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/easysetup/Makefile.am:
3068 * src/maemo/easysetup/modest-easysetup-wizard.c:
3069 (modest_easysetup_wizard_dialog_init):
3070 * src/maemo/easysetup/provider-data-test.keyfile:
3071 * src/maemo/easysetup/provider-data.keyfile:
3072 Moved the provider data file to the new modest-providers-data package and used it from there.
3074 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3076 * src/modest-local-folder-info.c:
3077 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3078 N_() was already used on the static strings, but this just marks it for translation without
3079 using the translation.
3081 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3083 * src/maemo/modest-account-settings-dialog.c:
3084 (create_page_incoming),
3085 (modest_account_settings_dialog_set_account_name):
3086 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3087 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3088 I will do this if nobody else gets there first.
3090 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3093 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3094 save the security stuff.
3096 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3098 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3099 Set the email address and user fullname, which I now see must be
3102 * src/maemo/modest-account-settings-dialog.h:
3103 * src/maemo/modest-account-settings-dialog.c:
3105 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3106 leave-on-server and authentication.
3107 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3110 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/modest-account-settings-dialog.c:
3114 * src/maemo/modest-account-settings-dialog.h:
3115 Most (but not all) of the widgets are now present as specified by the UI spec.
3116 No changes are yet saved, and some details are not properly shown yet.
3118 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3120 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/Makefile.am:
3123 * src/maemo/modest-account-settings-dialog.c:
3124 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3125 an existing account. Doesn't do much yet.
3127 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3128 Open the accounts settings dialog when Edit is clicked.
3130 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3132 * src/maemo/easysetup/Makefile.am:
3133 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3135 * src/maemo/easysetup/modest-easysetup-wizard.c:
3136 (modest_easysetup_wizard_dialog_init):
3137 Try to get the source directory from the build system,
3138 instead of hard-coding "./" into the source code, when opening our local
3139 copies of the configuration files.
3140 But this still fails when opening the wizard from the Accounts window,
3141 maybe because the working directory seems to change at runtime.
3142 So the wizard will fail the second time unless you copy the files into their
3143 proper locations - see the stdout warnings for the paths.
3145 (create_page_account_details),(on_before_next):
3146 Check for existing non-server accounts instead of server accounts,
3147 so the default account name is useful again, and to prevent trying to
3150 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3151 Show the wizard when New is clicked.
3153 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3154 (init_view): Show the column headers, and show the columns that are
3155 specified in the UI specs. However, something in Maemo's GTK+ prevents
3156 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3157 change the default account. This is despite unsetting the special properties.
3159 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3161 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3162 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3163 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3164 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3165 to make that clearer.
3166 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3168 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3170 * src/maemo/modest-account-view-window.c:
3171 (modest_account_view_window_init),
3172 (modest_account_view_window_new):
3173 Use the same buttons as specified in the
3174 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3175 the existing widgets, which never had a chance of working.
3176 Put the ModestAccountView treeview in a scrolled window.
3177 Do not repeat the initialization in both _init() and _new().
3179 * src/widgets/modest-account-view.c: (update_account_view):
3180 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3181 this widget and window shows no accounts.
3183 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3185 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3187 * src/maemo/easysetup/modest-easysetup-wizard.c:
3188 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3189 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3190 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3193 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3194 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3195 accounts exist yet, as in the UI spec.
3197 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3199 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/Makefile.am:
3202 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3203 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3204 New window for editing connection-specific smtp details.
3205 Not fully implemented.
3207 * src/maemo/modest-connection-specific-smtp-window.c:
3208 (modest_connection_specific_smtp_window_finalize) :
3209 unref the tree model.
3210 (on_button_edit): Show the edit window.
3212 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3214 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3217 * src/maemo/Makefile.am:
3218 * src/maemo/modest-connection-specific-smtp-window.c:
3219 * src/maemo/modest-connection-specific-smtp-window.h:
3220 New window for showing the list of connections, for connection-specific
3221 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3222 * src/maemo/easysetup/modest-easysetup-wizard.c:
3223 (create_page_custom_outgoing): Show the new window when the button is clicked.
3225 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3228 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3229 * src/maemo/modest-msg-edit-window.c:
3230 (modest_msg_edit_window_insert_image):
3231 * src/modest-conf.c: (modest_conf_key_escape):
3232 * src/modest-mail-operation.c:
3233 (modest_mail_operation_send_new_mail):
3234 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3235 (modest_ui_actions_on_new_account):
3236 * src/widgets/modest-attachment-view.c: (update_filename_request):
3237 * src/widgets/modest-mail-header-view.c:
3238 Corrected warnings that were breaking the build, by commenting out unused variables,
3239 and a function, and by including a header.
3241 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3243 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3244 so we can #ifdef around platform-specific code when necessary.
3245 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3246 to allow this to build for the GNOME platform too.
3248 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3250 * src/maemo/easysetup/modest-easysetup-wizard.c:
3251 Added util_increment_name() and used it in create_page_account_details()
3252 to make sure that the default account name is always a new name.
3254 (modest_easysetup_wizard_dialog_init),
3255 (set_default_custom_servernames): Some minor memory management fixes.
3257 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3261 * src/modest-runtime.c: (init_i18n): Restored the translation
3262 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3263 are defined in config.h, and the translations are installed.
3265 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3266 is defined for translation.
3268 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3270 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3272 * src/maemo/easysetup/modest-easysetup-wizard.c:
3273 (modest_easysetup_wizard_dialog_init):
3274 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3275 Use realistic paths (though they should use $prefix generically) to the
3276 mcc_mapping and provider-data.keyfile files which might work when they
3277 are installed by the future version of the operator-wizard package,
3278 and then fallback to paths in our source code, with an explanatory
3281 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3285 * src/maemo/Makefile.am:
3286 * src/maemo/easysetup/: Added files from the previously-exernal
3287 osso-modest-easysetup.
3288 * src/maemo/modest-main-window-ui.h:
3289 * src/modest-ui-actions.c:
3290 * src/modest-ui-actions.h:
3291 Added modest_ui_actions_on_new_account() as a signal handler for the
3292 New Account menu item. It shows the easysetup wizard.
3293 * po/en_GB.po: Added additional needed logical IDs and translations.