1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
4 (easysetup_provider_combo_box_fill): Remove debug code that showed the
5 provider ID in the combo.
7 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
8 Do not show the page numbers, because it would be confusing when we add
9 the 2 extra pages for the custom setup, when the user chooses the "Other"
10 provider. This fixes projects.maemo.org bug NB#59028
12 * src/modest-init.c: (modest_init_init_core),
13 (modest_init_local_folders):
15 * src/modest-tny-account.c:
16 (modest_tny_account_new_for_local_folders): Do not create default folders
17 for the memory card. This should fix projects.maemo.org bug NB#59328.
19 2007-06-11 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
22 Free the changed_conf_keys string items. They are already freed in the
23 idle handler if that runs first.
25 2007-06-11 Murray Cumming <murrayc@murrayc.com>
27 * src/modest-ui-actions.c:
28 (modest_ui_actions_on_password_requested): Check that the server name
29 is not NULL, because I just saw a password dialog with (null) as the
32 * src/modest-tny-folder.[h|c]: Added
33 modest_tny_folder_is_memory_card_folder().
34 * src/modest-ui-dimming-rules.c:
35 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
36 menu item for memory cards, as per the UI spec (section 7.4). This should
37 fix projects.maemo.org bug NB#59297.
39 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
41 * src/maemo/modest-main-window.c: (sync_accounts_cb):
42 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
43 is another problem with the code, see Murray's comment at line 772)
45 2007-06-08 Murray Cumming <murrayc@murrayc.com>
47 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
48 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
49 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
50 (load_from_file), (easysetup_country_combo_box_init),
51 (easysetup_country_combo_box_get_active_country_ids),
52 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
53 instead of just one ID, to avoid duplicate country names in the UI.
55 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
56 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
57 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
58 a single ID, avoiding duplicate providers.
59 * src/maemo/easysetup/modest-easysetup-wizard.c:
60 (on_combo_account_country): Adapt to use a list.
62 2007-06-08 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
65 keys changed in the last X seconds.
67 * src/modest-account-mgr.h:
68 * src/modest-account-mgr.c: (on_timeout_notify_changes),
69 (on_key_change), (modest_account_mgr_class_init),
70 (modest_account_mgr_init), (modest_account_mgr_finalize):
71 As the keys are changed, save them in a GSList* and signal that GSList*
72 further every X seconds, to batch changes, to allow us to do just one
73 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
74 bug NB#56941 and other (UI-blocking) delays when changing account settings.
76 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
77 changed signal signature.
79 * src/modest-conf.c: (modest_conf_set_list),
80 (modest_conf_on_change): Reenable notification.
82 (modest_conf_maemo_fake_on_change): Comment out the hack that
83 notified immediately instead of asynchronously.
85 * src/widgets/modest-account-view.h:
86 * src/widgets/modest-account-view.c:
87 (update_account_view): Select the previously-selected account ID,
88 if possible. This fixes projects.maemo.org bug NB#56933.
90 (on_account_changed), (on_account_removed),
91 (modest_account_view_select_account):
93 Remove the block/unblock functions
94 because they were not useful.
96 * src/maemo/modest-account-view-window.c:
97 (on_delete_button_clicked), (on_edit_button_clicked),
98 (on_new_button_clicked): Remove the use of the non-working block/unblock.
100 2007-06-08 Murray Cumming <murrayc@murrayc.com>
102 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
103 Improve the error dialog to show Incorrect Account Settings, which seems
104 clearer, and say that the internal error message (to be removed from the
105 dialog later) is often misleading.
106 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
108 * src/modest-tny-account.c:
109 (modest_tny_account_new_from_server_account): Uncomment the printf of the
110 URL because this is so useful for debugging on the device.
112 * src/widgets/modest-serversecurity-combo-box.c:
113 (modest_serversecurity_combo_box_fill): Correct a logical ID.
115 2007-06-08 Murray Cumming <murrayc@murrayc.com>
117 * src/modest-mail-operation.c:
118 (modest_mail_operation_send_new_mail):
119 Added a comment about a nasty but apparently harmless message. Details
120 added to the wiki g_warnings() page.
122 2007-06-08 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
125 (modest_tny_send_queue_class_init):
126 Do not use the priv struct because it is empty, to avoid g_warnings
127 about a non-existant priv struct.
129 * src/modest-tny-account-store.c:
130 (modest_tny_account_store_get_server_account),
131 (modest_tny_account_store_get_transport_account_for_open_connection
132 ): Do not try to get transport server accounts for local folders,
133 because they don't have any. This avoids a g_warning().
135 * src/maemo/modest-main-window.c:
136 (modest_main_window_notify_send_receive_initied),
137 (on_configuration_key_changed):
138 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
140 * src/modest-mail-operation.c:
141 (modest_mail_operation_update_account):
142 * src/modest-tny-account-store.h:
143 * src/modest-tny-account.c:
144 (modest_tny_account_get_special_folder),
145 (modest_tny_account_new_for_local_folders),
146 (modest_tny_account_new_for_per_account_local_outbox_folder):
147 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
148 * src/modest-tny-local-folders-account.c:
149 (add_account_folders_to_merged_folder):
150 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
151 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
152 (modest_ui_actions_on_send):
153 * src/widgets/modest-folder-view.c: (update_model):
154 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
155 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
156 modest_tny_account_store_get_tny_account_by_account() to
157 modest_tny_account_store_get_server_account() to make the code clearer.
159 2007-06-07 Marcus Bauer <marcusb@openismus.com>
161 * src/dbus_api/modest-dbus-api.h:
162 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
163 * src/maemo/modest-msg-edit-window.c:
164 (modest_msg_edit_window_attach_file_noninteractive):
165 added g_warning in case the file to be attached does not exist
166 * tests/dbus_api/test_compose_mail.c: (main):
167 removed obsolete comment, added generic files as test case
169 2007-06-07 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-tny-account-store.c: (get_server_accounts):
172 Create the local folders account only once, not once for each outbox, and
173 not only when there are some outboxes.
175 2007-06-07 Murray Cumming <murrayc@murrayc.com>
177 * src/widgets/modest-folder-view.c: (update_model): Comment out some
178 code that is causing a crash at startup. Sergio says that he is fixing this.
180 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
182 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
183 * src/maemo/modest-account-settings-dialog.c:
184 (create_page_outgoing),
185 (modest_account_settings_dialog_set_account_name),
186 (save_configuration):
187 - Fixed handling of the "Use secure authentication" toggle to comply with
188 the ui specification. See also projects.maemo.org bug NB#58400
190 - Restore the Secure connection setting combo correctly when loading
193 * src/maemo/modest-maemo-utils.c:
194 (on_camel_account_get_supported_secure_authentication),
195 (modest_maemo_utils_get_supported_secure_authentication_methods):
196 Fixed a crasher if operation is canceled
198 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
199 (modest_protocol_info_auth_is_secure):
200 * src/modest-protocol-info.h:
202 Added two new methods to determine if a protocol/auth method is secure/encrypted in
203 the sense of the "Use secure authentication" toggle.
205 2007-06-07 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-tny-account-store.h:
208 * src/modest-tny-account-store.c:
209 Added modest_tny_account_store_get_local_folders_account().
211 * src/modest-tny-folder.h:
212 * src/modest-tny-folder.c:
213 (modest_tny_folder_get_account):
214 Added this replacement for tny_folder_get_account() which returns
215 the local-folders account for TnyMergeFolders, to avoid the
216 warning about the unimplemented get_account_func() vfunc().
218 (modest_tny_folder_get_rules),
219 * src/modest-ui-actions.c:
220 (modest_ui_actions_on_folder_selection_changed):
221 * src/modest-mail-operation.c:
222 (modest_mail_operation_remove_folder),
223 (modest_mail_operation_xfer_folder),
224 (modest_mail_operation_rename_folder),
225 (modest_mail_operation_get_msg),
226 (modest_mail_operation_get_msgs_full),
227 (modest_mail_operation_remove_msg),
228 (modest_mail_operation_xfer_msgs),
229 (modest_mail_operation_refresh_folder):
230 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
232 2007-06-07 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
235 (modest_server_account_set_security):
236 * src/modest-defs.h: Add comments explaining that our
237 UI spec means TLS when it says Normal, so these do not look like errors.
239 * src/modest-tny-account.c:
240 (modest_tny_account_new_from_server_account): Use the new tinymail
241 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
242 for TLS. This should fix projects.maemo.org bug NB#58460.
244 2007-06-06 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c:
247 (create_account): Correct the position of the gconf sanity check warning.
248 (on_button_edit_advanced_settings): Show the dialog immediately, instead
249 of using the g_idle_add() hack, because this does not seem to be necessary
250 on osso 1.1. It might even work on Maemo Bora if the problems were actually
251 caused by something other than maemo's gconf.
252 This fixes projects.maemo.org bug #59022.
254 2007-06-06 Murray Cumming <murrayc@murrayc.com>
256 * src/modest-account-mgr-helpers.c:
257 (modest_account_mgr_get_default_account): Do not check that the account
258 exists if there is no default account (NULL), to fix a runtime warning.
260 2007-06-06 Murray Cumming <murrayc@murrayc.com>
262 * src/widgets/modest-folder-view.c: (update_model):
263 Do not unref the treemodel before we have finished with it.
264 This prevents a valgrind warning and an occasional crash at startup.
266 2007-06-06 Marcus Bauer <marcusb@openismus.com>
268 * libmodest-dbus-client/libmodest-dbus-client.h:
269 added libmodest_dbus_client_compose_mail()
270 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
272 added functions needed for SendAsMail() functionality
273 * src/maemo/modest-msg-edit-window.c:
274 (modest_msg_edit_window_attach_file_noninteractive):
275 non interactively attaching files to message edit window
276 * src/widgets/modest-msg-edit-window.h:
277 * tests/dbus_api/Makefile.am:
278 added test_compose_mail.c
279 * tests/dbus_api/test_compose_mail.c: (main):
281 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
283 * src/modest-account-view.c:
284 Fixed bug projects.maemo.org bug NB#59307
286 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
288 * src/maemo/easysetup/modest-easysetup-wizard.c:
289 (get_serverport_incoming), (on_before_next), (create_account):
290 * src/maemo/modest-account-settings-dialog.c:
291 (modest_account_settings_dialog_set_account_name):
292 * src/maemo/modest-maemo-utils.c:
293 (on_camel_account_get_supported_secure_authentication_status),
294 (on_camel_account_get_supported_secure_authentication),
295 (on_secure_auth_cancel),
296 (modest_maemo_utils_get_supported_secure_authentication_methods):
298 Implemented security authentication for settings and easysetup.
300 2007-06-05 Murray Cumming <murrayc@murrayc.com>
302 * src/maemo/modest-main-window.c: (create_details_widget):
303 Show the total size for memory card accounts too, instead of showing
304 the name again. Fixes bug projects.maemo.org bug NB#59307.
306 2007-06-05 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-tny-simple-folder-store.c:
310 * src/modest-tny-simple-folder-store.h: Removed.
312 * src/modest-tny-local-folders-account.h
313 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
314 for the local-folders maildir, with an extra TnyMergedFolder containing
315 the folders of the per-account outbox store accounts.
316 * src/modest-tny-account-store.c: (get_server_accounts):
317 Add the outboxes to the special local folders account after creating it.
319 * src/modest-tny-account.c:
320 (modest_tny_account_new_for_local_folders): Create the derived
321 account when creating the main local-folders account.
323 * src/maemo/modest-main-window.c: (create_details_widget),
324 (modest_main_window_set_contents_style):
325 Adapted to the use of the derived account instead of the folder store.
327 * src/modest-ui-actions.c:
328 (modest_ui_actions_on_folder_selection_changed):
329 * src/modest-ui-dimming-rules.c:
330 (modest_ui_dimming_rules_on_new_folder):
331 * src/widgets/modest-folder-view.c: (text_cell_data),
332 (icon_cell_data), (filter_row), (update_model),
333 (get_cmp_rows_type_pos):
336 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
337 Do not get the priv struct, because no priv struct has been set,
338 to avoid a runtime warning.
340 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
341 #ifelse with #else, to fix a warning, to fix the build.
344 2007-06-05 Christian Kellner <ckellner@openismus.com>
346 * libmodest-dbus-client/libmodest-dbus-client.c:
347 Fix small typo in doc (why do you always see them
348 AFTER committing stuff?)
351 2007-06-05 Christian Kellner <ckellner@openismus.com>
353 * libmodest-dbus-client/libmodest-dbus-client.c:
354 (libmodest_dbus_client_search):
355 Initialize hit list with NULL. Also set folder list
356 to "" if NULL was supplied.
359 2007-06-03 Christian Kellner <ckellner@openismus.com>
361 * libmodest-dbus-client/libmodest-dbus-client.c:
362 (modest_search_hit_list_free):
363 Make it save to call it with NULL.
365 * src/dbus_api/modest-dbus-callbacks.c:
366 * src/modest-search.c:
367 Return full ModestSearchHits as the search result list not TnyHeader
368 since can't be around withouth the correspoding TnyFolder.
370 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
372 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
373 Added currently commented code to check for secure auth
375 * src/maemo/modest-account-settings-dialog.c: (on_response),
376 (save_configuration), (show_ok):
377 Fixed projects.maemo.org bugs NB #59248 and #59251
379 * src/maemo/modest-maemo-utils.c:
380 (on_camel_account_get_supported_secure_authentication_status),
381 (on_camel_account_get_supported_secure_authentication),
382 (modest_maemo_utils_get_supported_secure_authentication_methods):
383 * src/maemo/modest-maemo-utils.h:
384 Moved get_supported_secure_authentication() method here to be able
385 to use it from easysetup wizard.
387 * src/modest-pair.c: (on_pair_compare_as_string):
388 Should compare string with first part of pair and not
389 strcmp pairs which will crash.
391 * src/modest-protocol-info.c:
392 (modest_protocol_info_protocol_is_store):
393 * src/modest-protocol-info.h:
394 Added modest_protocol_info_get_auth_protocol_name()
396 2007-06-03 Armin Burgmeier <armin@openismus.com>
398 * src/modest-mail-operation.c:
399 (modest_mail_operation_get_msgs_full): Set priv->account also when
400 only retrieving a single message. This avoids a crash when canceling
403 (modest_mail_operation_notify_end): Do not explicitely remove the
404 operation from the queue but only emit the progress_changed signal.
405 The queue itself listens to that signal to remove the operation when
406 it is finished. This reduces coupling and removes a potential deadlock
407 when modest_mail_operation_notify_end() is called from the queue
408 itself. If that is a problem performance-wise, I would suggest to
409 implement a status-changed signal or something.
411 * src/modest-mail-operation-queue.c: Make sure to never call a
412 function from another file while the queue is locked. This (hopefully)
413 fixes another deadlock when exiting the application while retrieving
416 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
418 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
419 Fixed build if libogs is not available
421 2007-06-03 Christian Kellner <ckellner@openismus.com>
423 * libmodest-dbus-client/libmodest-dbus-client.h:
424 * libmodest-dbus-client/libmodest-dbus-client.c:
425 (libmodest_dbus_client_delete_message):
426 Implement deletion of messages (Client side).
428 (modest_search_hit_free),
429 (modest_search_hit_list_free):
430 Utility functions to free the result hits.
432 * src/dbus_api/modest-dbus-api.h:
433 * src/dbus_api/modest-dbus-callbacks.c:
435 (modest_dbus_req_handler):
436 Implement deletion of messages (Server side).
438 * tests/dbus_api/test_search.c: (main):
441 * tests/dbus_api/Makefile.am:
442 * tests/dbus_api/test_delete_message:
443 Add little test for the message deletion logic
445 2007-06-03 Armin Burgmeier <armin@openismus.com>
447 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
448 when the operation queue was not empty. projects.maemo.org bug
451 2007-06-03 Armin Burgmeier <armin@openismus.com>
453 * src/widgets/modest-account-view.c
454 (on_account_default_toggled): Toggle default account column
455 explicitely instead of waiting for gconf notification (which is
456 currently ignored). This should fix projects.maemo.org bug NB#56910
457 for now. It should probably be removed when gconf notifications are
460 2007-06-03 Christian Kellner <ckellner@openismus.com>
462 * libmodest-dbus-client/libmodest-dbus-client.c:
463 Removed debugging spew.
465 * src/dbus_api/modest-dbus-callbacks.c:
466 Added debugging info.
468 * src/modest-search.c:
469 (modest_search_all_accounts):
470 Use tny_account_store_get_accounts () on the account store
471 to get all accounts which is the way to get all accounts.
473 * tests/dbus_api/test_search.c: (main):
474 Make it possible to supply the search term on the command line.
476 2007-06-03 Christian Kellner <ckellner@openismus.com>
478 * libmodest-dbus-client/libmodest-dbus-client.c:
479 * libmodest-dbus-client/libmodest-dbus-client.h:
480 Implement searching for mesages over raw dbus. (Client side)
482 * src/dbus_api/Makefile.am:
483 * src/dbus_api/modest-dbus-api.h:
484 * src/dbus_api/modest-dbus-callbacks.c:
485 * src/dbus_api/modest-dbus-callbacks.h:
486 Search framework (Server side). Also implement on_idle_open_message().
488 * src/maemo/modest-platform.c: (modest_platform_init):
489 Prepare for raw dbus/osso rpc interaction.
491 * src/modest-search.h:
492 Changed minsize from unspecific guint to guint32.
494 * src/modest-search.c:
496 Added strange hack which magically made tnymail work.
498 (modest_search_folder),
499 (modest_search_account),
500 (modest_search_all_accounts):
501 Implement helper functions to search all accounts, specific account
504 * tests/dbus_api/Makefile.am:
505 * tests/dbus_api/test_open_message.c:
506 Read url to open from commandline.
508 * tests/dbus_api/test_search.c:
509 Implement small test for dbus search stuff
511 2007-06-02 Armin Burgmeier <armin@openismus.com>
513 * src/maemo/modest-account-settings-dialog.c: Changed window title to
514 include account type and account title. This fixes projects.maemo.org
517 * src/maemo/modest-account-view-window.c: Set a title for the window.
519 2007-06-02 Armin Burgmeier <armin@openismus.com>
521 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
522 incoming and outgoing server name based on email address and server
523 types as long as the names have not been edited manually. This fixes
524 projects.maemo.org bug NB#58671.
526 2007-06-02 Armin Burgmeier <armin@openismus.com>
528 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
529 server type cannot be changed in future to the incoming details page
530 when creating an account. This fixes projects.maemo.org bug NB#59029.
532 2007-06-02 Armin Burgmeier <armin@openismus.com>
534 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
535 and assigned max width chars so that they wrap instead of being
536 truncated. Fixes projects.maemo.org bug NB#56126.
538 2007-06-02 Armin Burgmeier <armin@openismus.com>
540 * src/maemo/modest-connection-specific-smtp-window.c: Add an
541 introductory note to the connection specific smtp servers dialog, as
542 section 8.12 of the email UI specification requires. This fixes
543 projects.maemo.org bug NB#59212.
545 2007-06-01 Murray Cumming <murrayc@murrayc.com>
547 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
548 Check for running mail operations, and offer to cancel them, as per the UI
549 spec. This fixes projects.maemo.org bug NB#59041 .
550 However, I suspect that tinymail may still use the network connection
551 in ways that we cannot detect or cancel. But it should at least adapt to
554 2007-06-01 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-tny-account-store.c: (recreate_all_accounts),
557 (get_cached_accounts), (get_server_accounts): Do more sensible
558 ref-counting of the temporarily-cached outbox accounts list. This seems
559 to fix a crash when entering the password when the password was wrong.
561 2007-06-01 Murray Cumming <murrayc@murrayc.com>
563 * src/gnome/modest-main-window.c: (connect_signals):
564 * src/modest-tny-account-store.c: (get_password),
565 (modest_tny_account_store_alert): Added comments and clues and
566 commented-out code about how we currently fail to deal with connection
567 errors and wrong passwords, and how we should.
569 2007-06-01 Murray Cumming <murrayc@murrayc.com>
571 * src/widgets/modest-retrieve-combo-box.c:
572 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
573 This fixes projects.maemo.org bug NB#58472 .
575 2007-06-01 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/easysetup/modest-easysetup-wizard.c:
578 (create_page_complete_easysetup):
579 (create_page_complete_custom): Correct the last commit,
580 putting the correct sentences in the correct pages.
582 2007-06-01 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/easysetup/modest-easysetup-wizard.c:
585 (create_page_complete_custom): Show the second sentence of text
586 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
589 2007-06-01 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
592 Set the leave-on-server conf key by default. This fixes
593 projects.maemo.org bug NB#59258 .
595 2007-06-01 Murray Cumming <murrayc@murrayc.com>
597 * src/maemo/modest-account-view-window.c:
598 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
599 logical ID for the confirmation messages. Fixed projects.maemo.org bug
602 2007-06-01 Murray Cumming <murrayc@murrayc.com>
604 * src/maemo/easysetup/modest-easysetup-wizard.c:
605 (create_caption_new_with_asterisk):
606 * src/maemo/modest-account-settings-dialog.c:
607 (create_caption_new_with_asterisk):
608 Uncomment the code to add the asterisk, because they are no longer in the
609 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
610 (update_incoming_server_title): Add an asterisk here too.
612 2007-06-01 Murray Cumming <murrayc@murrayc.com>
614 * src/maemo/modest-maemo-global-settings-dialog.c:
615 (current_connection): Check that we are even connected before trying to
616 get the current connection name, to prevent a warning.
618 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
619 Change the comments because tny_maemo_conic_device_connect() is now meant to
621 * src/modest-mail-operation.c:
622 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
623 make sure we have a connection and fail if we can't connect.
625 2007-05-31 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/modest-main-window.c:
628 (on_account_store_connecting_finished): Do not try to get the
629 connection ID if we are not really connected. I am surprised that
630 this signal handler is called when we are not connected.
632 2007-05-31 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-error.h:
635 * src/modest-ui-actions.c:
636 (modest_ui_actions_get_msgs_full_error_handler):
637 Renamed an enum, added comments, added an enum
638 for retrieve-limit errors.
640 * src/modest-mail-operation.c: (foreach_add_item),
641 (internal_folder_observer_update), (update_account_thread),
642 (modest_mail_operation_get_msgs_full):
643 (modest_mail_operation_update_account),
644 Added comments about how this works, and some code that should
645 (but does not) check the retrieve-limit. See the TODO comment.
647 2007-05-31 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
650 Initialize help_id to fix the build. Warnings are good.
652 2007-05-31 Murray Cumming <murrayc@murrayc.com>
654 * src/widgets/modest-hbox-cell-renderer.c:
655 (modest_hbox_cell_renderer_append):
656 * src/widgets/modest-vbox-cell-renderer.c:
657 (modest_vbox_cell_renderer_append):
658 Fix the last commit by doing an extra ref.
660 2007-05-31 Murray Cumming <murrayc@murrayc.com>
662 * src/widgets/modest-hbox-cell-renderer.c:
663 (modest_hbox_cell_renderer_append):
664 * src/widgets/modest-vbox-cell-renderer.c:
665 (modest_vbox_cell_renderer_append):
666 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
667 to fix the build with Maemo Bora.
668 However, there seems to be a remaining crash, probably due to reference
671 2007-05-30 Murray Cumming <murrayc@murrayc.com>
673 * src/modest-tny-account.c:
674 (modest_tny_account_new_for_local_folders):
675 Use hildon_file_system_info_async_new() to get a better name for
676 the memory card account, setting it as the account name.
677 The timing seems to work, but this is probably
678 not the best place to do this. See the TODO comment.
679 * src/maemo/modest-main-window.c: (create_details_widget):
680 * src/widgets/modest-folder-view.c: (text_cell_data):
681 Use the tny account name instead of hardcoding a name.
683 2007-05-30 Christian Kellner <ckellner@openismus.com>
685 * src/modest-search.c: (modest_search):
686 Correctly set part_search_func even if we have already parsed
687 the query and thus a valid OgsTextSearcher object.
689 2007-05-30 Christian Kellner <ckellner@openismus.com>
692 Search and check for libogs.
695 Incooparte the ogs build env.
697 * src/modest-mime-part-search-stream.c:
698 * src/modest-mime-part-search-stream.h:
699 Removed since we do the real searching now in modest-search.c.
701 * src/modest-search.c:
702 * src/modest-search.h:
703 Implement support for ogs. We use that if available and requested
704 and fall back to modest_text_utils_utf8_strcmp (). The search logic
705 should now handle the corner case when the search term is spread
706 across multiple reads.
707 Also the logic in modest_search () was corrected to search all
708 requested fields until one is found.
710 2007-05-30 Murray Cumming <murrayc@murrayc.com>
712 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
715 * src/modest-init.c: Made modest_init_local_folders() take a
716 path and be public so we can iniitialize maildir folders on
719 * src/modest-local-folder-info.h:
720 * src/modest-local-folder-info.c:
721 (modest_local_folder_info_get_maildir_path): Add a path parameter.
723 * src/modest-tny-account.c:
724 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
725 still means the standard local-folders path on the local volume.
727 * src/modest-tny-account-store.c:
728 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
729 signal so we can detect mount/unmount of the MMC1 card, and do an update of
730 all accounts when that happens.
731 (get_server_accounts): If the MMC1 card is mounted, create a store account for
732 this too, so it shows up in the treeview.
734 2007-05-28 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/modest-maemo-global-settings-dialog.c:
737 (current_connection):
738 * src/widgets/modest-global-settings-dialog.c:
739 (current_connection_default):
740 Use the enum values instead of 0, 1 and -1,
741 to make the code clearer.
743 * src/modest-account-mgr-helpers.c:
744 (modest_account_mgr_get_connection_specific_smtp): Make this code
747 * src/modest-runtime.h:
748 * src/modest-runtime.c:
749 Added modest_runtime_remove_all_send_queues().
750 * src/maemo/modest-main-window.c:
751 (on_account_store_connecting_finished): Recreate the send queues,
752 using the appropriate transport accounts for this new connection.
753 Some futher adapting might be needed if the old send queues are not
754 automatically stopped at this point.
756 * src/modest-tny-account-store.c: (get_server_accounts):
757 Create the connection-specific transport accounts, so that they can
758 be found later by their ID.
760 * src/modest-tny-account.h:
761 * src/modest-tny-account.c:
762 Added modest_tny_account_new_from_server_account_name().
763 modest_tny_account_new_from_server_account(): Do not create the
764 send queues here, because they will be
765 recreated anyway when the connection changes for the first time.
767 2007-05-28 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-local-folder-info.h:
770 * src/modest-local-folder-info.c:
771 (modest_per_account_local_outbox_folder_info_get_maildir_path),
772 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
773 tbox_folder): Take a modest account name instead of a server TnyAccount,
774 so we can have per-modest-account rather than per-transport-account
776 We must make sure that we change or recreate the exisitng send queues
777 when the connection changes for connection-specific transport accounts.
779 * src/modest-tny-account-store.c:
780 (create_per_account_local_outbox_folders): Create outboxed per modest
781 account, not per transport account.
783 * src/modest-tny-account.h:
784 * src/modest-tny-account.c:
785 (modest_tny_account_get_special_folder): For outboxes, get the
786 parent modest account name. The account is ignored for other folders.
787 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
788 modest account name rather than a server TnyAccount.
790 2007-05-25 Murray Cumming <murrayc@murrayc.com>
792 * src/modest-tny-account.c:
793 (modest_tny_account_new_from_server_account):
794 Call modest_runtime_get_send_queue() immediately after creating transport
795 accounts, so that they start trying to send email from the outbox as soon
796 as possible at startup. This is probably what we want.
798 * src/modest-mail-operation.c: (update_account_thread):
799 * src/modest-runtime.c: (modest_runtime_get_send_queue):
800 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
801 * src/modest-tny-send-queue.h:
802 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
803 (modest_ui_actions_on_send):
804 Added comments about how sending works, though it needs some more work.
806 2007-05-25 Murray Cumming <murrayc@murrayc.com>
808 * src/modest-tny-account.c:
809 (modest_tny_account_get_special_folder): Add TODO because this fails when
811 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
812 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
813 Do not try to show this window when there is no active account. The UI
814 specs does not tell us what to do in this case.
816 2007-05-24 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/Makefile.am:
821 * src/widgets/Makefile.am: Some dist fixes.
823 2007-05-24 Murray Cumming <murrayc@murrayc.com>
825 * src/maemo/modest-connection-specific-smtp-window.c:
826 (on_button_edit): Make the code clearer, to prevent a double free.
828 2007-05-24 Murray Cumming <murrayc@murrayc.com>
830 * src/maemo/modest-account-settings-dialog.c:
831 (modest_account_settings_dialog_set_account_name),
832 Check the connection-specific smtp servers checkbox if there are any.
834 * src/maemo/modest-connection-specific-smtp-edit-window.c:
835 (modest_connection_specific_smtp_edit_window_init):
836 Start with a suitable port number.
838 * src/modest-account-mgr-helpers.h:
839 * src/modest-account-mgr-helpers.c: Added
840 modest_account_mgr_get_has_connection_specific_smtp().
842 (modest_account_mgr_set_connection_specific_smtp),
843 (modest_account_mgr_remove_connection_specific_smtp),
844 (modest_account_mgr_get_has_connection_specific_smtp),
845 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
846 connection-specific smtp server accounts in the account, rather than
847 the server account conf dir.
849 This fixes bug projects.maemo.org bug NB#58263 .
851 * src/modest-tny-account-store.c:
852 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
853 if there are no server accounts yet, to prevent an infinite loop when there
854 are no accounts. Document that one must be called before the other.
856 2007-05-24 Murray Cumming <murrayc@murrayc.com>
858 * src/modest-account-mgr-helpers.c:
859 (modest_account_mgr_get_default_account): Make sure that at least
860 one account is always the default, if there are any enabled accounts.
861 This is just a sanity check that shouldn't be necessary.
863 * src/modest-account-mgr-priv.c:
864 (_modest_account_mgr_account_from_key): Unescape the conf key to
865 get the real account name. For instance, this is an issue if a space
866 was in the account name, which can happen because the account name
867 is generated from the display name.
868 (_modest_account_mgr_get_account_keyname): Always escape the
870 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
871 Unescape the conf keys to get the real account names.
873 For instance, previously the is-default radio button in the accounts
874 list was not checked for any accounts at first. This fixes that,
875 and might fix several similar bugs.
877 2007-05-23 Murray Cumming <murrayc@murrayc.com>
879 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
880 Removed some debug printfs.
882 2007-05-23 Murray Cumming <murrayc@murrayc.com>
884 Modest on-disk outbox directories are now here, for instance:
885 $HOME/.modest/outboxes/<account-id-1>/outbox
886 $HOME/.modest/outboxes/<account-id-2>/outbox
888 $HOME/.modest/local-folders/outbox
889 so we can have a separate outbox for each account.
890 But they are shown as one outbox in the GtkTreeView, by using a
891 TnyMergeFolder in a ModestTnySimpleFolderStore.
894 * src/modest-tny-simple-folder-store.c:
895 * src/modest-tny-simple-folder-store.h:
896 Added ModestTnySimpleFolderStore, used to contain folders from
897 other folder stores, such as other accounts.
899 * src/modest-tny-outbox-account.h:
900 * src/modest-tny-outbox-account.c:
901 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
902 used for the per-account local outbox folders.
904 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
905 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
906 only use this (internally) now for the non-outbox local folders.
909 * src/modest-init.c: Added modest_init_one_local_folder(), for
910 setting up the directory structure for each local folder.
912 * src/modest-local-folder-info.c:
913 (modest_per_account_local_outbox_folder_info_get_maildir_path),
914 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
916 * src/modest-local-folder-info.h:
917 * src/modest-tny-account-store.c: (on_account_removed),
918 (on_account_changed), (create_per_account_local_outbox_folders),
919 (get_server_accounts), (modest_tny_account_store_get_accounts),
920 (modest_tny_account_store_get_tny_account_by_account),
921 (modest_tny_folder_store_is_virtual_local_folders):
923 * src/modest-tny-account.h:
924 * src/modest-tny-account.c:
925 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
926 to create an on-disk per-account local outbox folder for each
928 (create_per_account_local_outbox_folders): Create a local outbox folder
929 for each transport account.
930 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
931 for all local folders.
933 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
934 instead of using g_object_get/set() directly. It is clearer.
936 (modest_tny_folder_store_get_message_count),
937 (modest_tny_folder_store_get_local_size
938 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
939 because we now use these with non-acount folder stores.
941 (modest_tny_account_get_special_folder),
942 (modest_tny_account_new_from_server_account),
943 (modest_tny_account_new_from_account):
944 (recurse_folders): Adjust to the new outbox system.
946 * src/modest-tny-folder.h:
947 * src/modest-tny-folder.c:
948 (modest_tny_folder_is_local_folder),
949 (modest_tny_folder_get_local_folder_type),
950 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
952 * src/widgets/modest-main-window.h:
953 * src/maemo/modest-main-window.c: (create_details_widget),
954 (modest_main_window_set_contents_style): Show details for any folder store,
957 (modest_tny_folder_get_rules):
958 Remove the const. C does not support constness enough for this.
960 * src/modest-ui-actions.c:
961 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
962 make all outboxes appear as one, in the usual local-folders tree node.
964 (set_active_account_from_tny_account),
965 (modest_ui_actions_on_folder_selection_changed):
966 * src/widgets/modest-folder-view.c: (text_cell_data),
967 (icon_cell_data), (filter_row),
968 (add_account_folders_to_merged_folder),
969 (add_account_folders_to_simple_folder_store), (),
970 (get_cmp_rows_type_pos), (cmp_rows),
971 (modest_folder_view_set_account_id_of_visible_server_account):
972 Adjust to the new outbox system, using generic folder stores and folders
975 2007-05-23 Christian Kellner <ckellner@openismus.com>
977 * src/modest-mail-operation.c:
978 (modest_mail_operation_update_account):
979 Use info->max_size instead of unintialized local var [small
980 build fix]. (Added TODO to review that change since I don't
983 2007-05-23 Marcus Bauer <marcusb@openismus.com>
985 * libmodest-dbus-client/libmodest-dbus-client.c:
986 (libmodest_dbus_client_compose_mail): function added
987 * src/dbus_api/modest-dbus-api.h:
988 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
989 (on_compose_mail): Implementation of the SendAsMail functionality
991 2007-05-22 Murray Cumming <murrayc@murrayc.com>
993 * src/modest-account-mgr.c:
994 (modest_account_mgr_add_server_account): Set the secure-connection
995 conf key for transport accounts as well as store accounts. I don't know
996 why the if was there. For instance, this makes sure that we use SSL
997 for the gmail preset from the easysetup wizard.
999 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1001 * src/gnome/modest-main-window.c:
1002 (on_account_store_connecting_finished), (connect_signals):
1003 * src/maemo/modest-main-window.c:
1004 (on_account_store_connecting_finished), (connect_signals),
1005 (modest_main_window_new):
1006 Handle TnyAccountStore::connecting-finished instead of
1007 TnyDevice::connection-changed, because we cannot actually perform
1008 operations on accounts until TnyAccountStore has itself responded to
1009 the TnyDevice::connection-changed signal. This prevents a GError from
1011 Do not try to update at startup, because we (at least on scratchbox)
1012 already do an update at startup when the device goes online.
1013 This prevents a GError from tinymail.
1014 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1015 Added TODO about stopping simultaneous operations.
1017 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1020 * src/modest-mail-operation-queue.c:
1021 (modest_mail_operation_queue_remove):
1022 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1023 about where they happened.
1025 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1027 * src/modest-ui-actions.c:
1028 (modest_ui_actions_on_password_requested): Make sure that the remember
1029 output parameter is always TRUE.
1031 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1033 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1034 Show a OK/Cancel dialog if the error is a question, though we still do not
1035 know anything more about what we are asking the user.
1036 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1037 Fix an uninitialized variable (helper). This is a logic error, however.
1039 2007-05-21 Christian Kellner <ckellner@openismus.com>
1041 * src/modest-search.h:
1042 Correct bit shifting in the ModestSearchFlags enum.
1044 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1046 * src/modest-tny-account.c:
1047 (modest_tny_account_new_from_server_account): Do not use the lsub and
1048 check-all hard-coded IMAP options when using POP.
1050 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1052 * src/modest-tny-account.c:
1053 (modest_tny_account_new_from_server_account):
1054 Use NULL for the secure-auth method for POP when Password auth has been
1055 specified by the user, as we already do for IMAP. "auth=Login" causes
1056 an error from camel or the server.
1058 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1060 * src/maemo/modest-account-settings-dialog.c:
1061 (create_page_account_details),
1062 (modest_account_settings_dialog_set_account_name):
1063 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1064 for the leave-on-server checkbox, rathr than just the checkbox, when
1065 the protocol is not POP.
1067 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1069 * src/widgets/modest-account-view.c:
1070 * src/widgets/modest-account-view.h:
1071 Added modest_account_view_select_account() which will be useful later
1072 to asynchronously re-select the edited account.
1074 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/modest-account-settings-dialog.c:
1077 (modest_account_settings_dialog_set_account_name):
1078 Automatically choose the port numbers based on the secure authentication
1079 methods, if they have not been chosen before.
1080 This fixes projects.maemo.org bug NB#56273 .
1082 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/modest-main-window-ui.h:
1085 * src/modest-ui-actions.c:
1086 * src/modest-ui-actions.h:
1087 Connect the Tools/SMTP Servers menu item to
1088 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1089 SMTP servers dialog, as in the UI specification and saves changes when it
1090 is closed. This fixed projects.maemo.org bug NB#56305 .
1092 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1094 * src/maemo/modest-connection-specific-smtp-window.c:
1095 (modest_connection_specific_smtp_window_init):
1096 Use gtk_window_set_default_size() to make this window big enough, so
1097 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1099 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1101 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1102 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1103 (modest_connection_specific_smtp_edit_window_init),
1104 Do not try to connect to a combobox signal before the combobox exists.
1105 This fixes the cras in projects.maemo.org bug NB#56288 .
1106 (modest_connection_specific_smtp_edit_window_get_settings):
1107 Remove the server_account_name parameter which was being checked for NULL
1108 though it was not used.
1110 * src/maemo/modest-connection-specific-smtp-window.c:
1111 (modest_connection_specific_smtp_window_fill_with_connections),
1112 (on_button_edit), (modest_connection_specific_smtp_window_init):
1113 Correct the number of treemodel columns to prevent a warning.
1114 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1115 libconic does not work.
1117 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1119 * src/modest-tny-account.c:
1120 (modest_tny_account_new_from_server_account):
1121 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1122 SMTP when "None" was chosen by the user. However, with my SMTP server that
1123 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1126 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1129 to explain the memory management issue with the ID in the ModestPair.
1131 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1132 (add_sending_page), (modest_account_assistant_finalize):
1133 * src/gnome/modest-gnome-global-settings-dialog.c:
1134 (create_updating_page), (create_composing_page):
1135 * src/gnome/modest-msg-edit-window.c: (get_transports),
1136 (init_window), (modest_msg_edit_window_finalize),
1137 (modest_msg_edit_window_get_msg_data):
1138 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1139 * src/gnome/modest-transport-widget.c:
1140 (modest_transport_widget_finalize), (smtp_configuration):
1141 * src/maemo/modest-maemo-global-settings-dialog.c:
1142 (create_updating_page), (create_composing_page):
1143 * src/maemo/modest-msg-edit-window.c: (get_transports),
1144 (init_window), (modest_msg_edit_window_finalize),
1145 (modest_msg_edit_window_get_msg_data),
1146 (modest_msg_edit_window_free_msg_data):
1147 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1148 (modest_store_widget_finalize):
1149 * src/maemo/modest-transport-widget.c:
1150 (modest_transport_widget_finalize), (smtp_configuration):
1151 * src/modest-main.c: (send_mail):
1152 * src/widgets/modest-combo-box.h:
1153 * src/widgets/modest-global-settings-dialog-priv.h:
1154 * src/widgets/modest-global-settings-dialog.c:
1155 (modest_global_settings_dialog_finalize):
1156 * src/widgets/modest-msg-edit-window.h:
1157 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1158 as long as the combo box, to prevent use of freed memory for the ID.
1160 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1162 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1163 get_accounts(), to make this clearer. Do not check for the enabled gconf
1164 key, because we do not use this for server accounts (at least, not yet).
1165 This allows us to send email again.
1167 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/modest-platform.c:
1170 (on_modest_conf_update_interval_changed), (modest_platform_init):
1171 Only respond to this particular key change. All these strcmp()s cannot be
1174 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1176 * src/maemo/modest-maemo-global-settings-dialog.c:
1177 (current_connection): Prevent a crash in scratchbox when
1178 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1179 * src/maemo/modest-platform.c:
1180 (on_modest_conf_update_interval_changed), (modest_platform_init):
1181 Get the update interval from gconf and reset it when the gconf key changes.
1183 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1185 * src/modest-protocol-info.c:
1186 * src/modest-protocol-info.h: Adde enum-specific get functions,
1187 instead of using a ModestProtocolType enum parameter.
1189 * src/gnome/modest-account-assistant.c:
1190 * src/gnome/modest-store-widget.c:
1191 * src/gnome/modest-store-widget.h:
1192 * src/gnome/modest-transport-widget.c:
1193 * src/gnome/modest-transport-widget.h:
1194 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1195 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 * src/maemo/modest-account-settings-dialog.c:
1198 * src/maemo/modest-account-settings-dialog.h:
1199 * src/maemo/modest-store-widget.c:
1200 * src/maemo/modest-store-widget.h:
1201 * src/maemo/modest-transport-widget.c:
1202 * src/maemo/modest-transport-widget.h:
1203 * src/modest-account-mgr-helpers.c:
1204 * src/modest-account-mgr-helpers.h:
1205 * src/modest-account-mgr.c:
1206 * src/modest-account-mgr.h:
1207 * src/modest-tny-account.c:
1208 * src/modest-tny-folder.c:
1209 * src/widgets/modest-account-view.c:
1210 * src/widgets/modest-retrieve-combo-box.c:
1211 * src/widgets/modest-retrieve-combo-box.h:
1212 * src/widgets/modest-secureauth-combo-box.c:
1213 * src/widgets/modest-serversecurity-combo-box.c:
1214 * src/widgets/modest-serversecurity-combo-box.h:
1215 * tests/check_account-mgr.c:
1216 Use the specific functions, and use the re-renamed enum values for GNOME too.
1218 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-pair.h:
1221 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1222 so we can get the second based on the first.
1224 * src/maemo/modest-account-settings-dialog.h:
1225 * src/maemo/modest-account-settings-dialog.c:
1226 Added get_supported_secure_authentication_methods(), though it is mostly
1227 commented-out for now until the necessary API is committed to tinymail.
1228 (modest_account_settings_dialog_set_account_name),
1229 (save_configuration): Request the supported authentication methods from the
1230 server, so we can choose a working method.
1232 * src/modest-tny-account-store.h:
1233 * src/modest-tny-account-store.c:
1234 (modest_tny_account_store_get_session): Rename from
1235 tny_account_store_get_session().
1237 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1239 * src/modest-protocol-info.h: Split the ModestProtocol enum
1240 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1241 There was no need to have these unrelated values in one enum.
1243 * src/: many files: Adapted to changed enum. This makes the code a bit
1244 clearer, and the compiler could catch some errors.
1246 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1249 Show the detailed internal camel error message when an error happens
1250 during the configuration, so that our testers can give us more clues.
1251 For instance, in projects.maemo.org bug NB#56910 .
1253 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-tny-account.c:
1256 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1257 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1259 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1261 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1262 * src/maemo/modest-account-settings-dialog.c:
1263 (modest_account_settings_dialog_set_account_name),
1264 (save_configuration): For the incoming secure authentication checkbox,
1265 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1266 the UI specification. PLAIN does not seem to be supported for most IMAP
1267 servers anyway, and I am not sure what it would mean.
1268 However, we probably need to discover which of the secure-authentication
1269 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1270 * src/modest-account-mgr-helpers.c:
1271 (modest_account_mgr_get_server_account_data):
1273 * src/modest-tny-account.c:
1274 (modest_tny_account_new_from_server_account):
1275 Use tny_account_set_mech() to set secure-authentication methods,
1276 with some special-casing for IMAP, based on my observations of how
1279 * src/modest-account-mgr-helpers.h:
1280 * src/modest-account-mgr.c:
1281 * src/modest-defs.h: Comment that the URI is only used for local folders.
1283 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1286 parameter const, just to be neat.
1287 * src/modest-text-utils.c: (modest_text_utils_inline):
1288 End g_strconcat() with NULL, as its documentation says. This is almost
1289 certainly the cause of my crash at startup on the device. Interestingly,
1290 valgrind doesn't tell us about these errors.
1292 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1294 * scripts/build-packages: Added more precise comments about how to use
1295 this script, though I still get this error:
1296 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1297 error building tinymail
1299 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/modest-main-window.c: (on_account_update):
1302 Very slight cleanup, hoping to make it simpler to discover what causes
1303 a crash here sometimes.
1305 * src/modest-tny-account.c:
1306 (modest_tny_account_new_from_server_account): Set the port. Added
1307 comments about the options and a TODO comment because I need to find out
1308 how to specify the secure authentication method.
1310 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1312 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1313 changed CFlags paths form modest to libmodest
1315 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1317 * src/modest-account-mgr-helpers.c:
1318 (modest_account_mgr_get_server_account_data),
1319 (modest_account_mgr_free_server_account_data):
1320 * src/modest-account-mgr-helpers.h:
1321 * src/modest-account-mgr.c:
1322 (modest_account_mgr_add_server_account):
1323 * src/modest-defs.h:
1324 * src/modest-tny-account.c:
1325 (modest_tny_account_new_from_server_account):
1326 Determine the options for tny_camel_account_add_option() here,
1327 based on the settings, rather than storing them directly in gconf.
1329 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1332 Show a more friendly error dialog now that we expect (from the tinymail
1333 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1335 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1337 * src/maemo/modest-main-window.c: (on_account_update): Check that
1338 account_name is not NULL, to prevent a crash at startup that I am
1339 seeing on the N800. I do wonder why it is NULL.
1341 * src/maemo/easysetup/modest-easysetup-wizard.c:
1342 (create_page_user_details):
1343 * src/maemo/modest-account-settings-dialog.c:
1344 (create_page_user_details), (create_page_outgoing):
1345 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1346 (modest_connection_specific_smtp_edit_window_init):
1347 * src/modest-ui-actions.c:
1348 (modest_ui_actions_on_password_requested):
1349 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1350 might do something useful with the on-screen keyboard.
1352 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1354 * src/maemo/modest-main-window.c: (on_account_update):
1355 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1356 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1358 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-tny-account-store.c: (on_account_changed):
1361 Correct the signature of this signal handler.
1363 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1365 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1366 Show a HildonNote instead of a GtkDialog for Maemo.
1368 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1370 * src/widgets/modest-account-view.h:
1371 * src/widgets/modest-account-view.c: (on_account_changed),
1372 (on_account_removed). Added a boolean flag, set/unset by
1373 modest_account_view_block_conf_updates(),
1374 modest_account_view_unblock_conf_updates() to prevent unnecessary
1375 updates, but this is not very useful because the gconf notifications are
1376 so delays (maybe only on Maemo Bora).
1377 So auto-updating is turned off, and these functions do an explicit
1378 update when necessary.
1379 However, something else is still doing too much work when adding/removing
1380 accounts, probably in another part of the application.
1382 * src/maemo/modest-account-view-window.c:
1383 (on_delete_button_clicked), (on_edit_button_clicked),
1384 (on_new_button_clicked): Use the new functions.
1386 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1388 * src/modest-account-mgr-helpers.c:
1389 (modest_account_mgr_set_first_account_as_default):
1390 Sort the list of names alphabetically-by-title, so we choose the first one
1392 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1393 alphabetically by the title.
1395 This fixes projects.maemo.org bug NB#56418 .
1397 * src/modest-account-mgr-priv.c:
1398 (_modest_account_mgr_account_from_key):
1399 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1400 avoid a valgrind error, and possible random behaviour.
1402 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1404 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1405 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1406 tinymail documentation to say that this can be expected.
1407 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1408 pretty, and should not happen, but I would prefer to know when it does.
1410 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1412 * configure.ac: When using the older hildon version, probably on Bora,
1413 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1415 * src/widgets/modest-attachment-view.c:
1416 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1419 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1421 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1422 Implemented the prototype. Can be tested with
1423 tests/dbus_api/test_open_message:
1425 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-tny-account-store.c:
1428 (modest_tny_account_store_instance_init), (get_password):
1429 * src/modest-ui-actions.c:
1430 (modest_ui_actions_on_password_requested):
1431 Do not store the password in gconf, because this function is called
1432 for non-remembered passwords. Actually use the cached (in the hash map)
1433 password instead of releasing it.
1434 The password will now not be remembered if it is asked via the protected
1435 password dialog, as per the UI spec.
1437 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-defs.h:
1440 * src/modest-account-mgr-helpers.h:
1441 * src/modest-account-mgr-helpers.c:
1442 Added modest_server_account_get_username_has_succeeded(),
1443 modest_server_account_set_username_has_succeeded().
1444 (modest_server_account_set_username),
1445 Reset the has-succeeded flag if the username changes.
1447 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1448 * src/maemo/modest-connection-specific-smtp-window.c:
1449 (modest_connection_specific_smtp_window_save_server_accounts):
1450 Use modest_server_account_set_username() instead of using
1451 modest_conf_set_string() directly, so that the has-succeeded flag is always
1454 * src/modest-ui-actions.c:
1455 (modest_ui_actions_on_password_requested): Dim the username entry if
1456 the username has ever worked, as per the UI spec.
1458 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-tny-account-store.c: (get_password):
1461 * src/modest-ui-actions.c:
1462 (modest_ui_actions_on_password_requested):
1463 Allow the username to be changed too, though there is more work to
1464 be done on exactly how this behaves.
1466 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1468 * src/modest-account-mgr-helpers.h:
1469 * src/modest-account-mgr-helpers.c:
1470 Added modest_account_mgr_get_display_name(),
1471 modest_server_account_get_username(),
1472 modest_server_account_set_username(),
1473 modest_server_account_set_password(),
1474 modest_server_account_get_hostname() functions so we do not need to
1475 use the conf API directly.
1477 * src/maemo/modest-main-window.c: (connect_signals):
1478 Actually connect ot the ModestAccountStore::request-password signal,
1479 so that we show the dialog when the password is requested by Tinymail,
1480 for isntance if it is empty.
1482 * src/modest-marshal.list:
1483 * src/modest-tny-account-store.c:
1484 (modest_tny_account_store_class_init), (get_password),
1485 (modest_tny_account_store_alert):
1486 * src/modest-tny-account-store.h:
1487 * src/modest-ui-actions.h:
1488 * src/modest-ui-actions.c:
1489 (modest_ui_actions_on_password_requested):
1490 Change the signal parameters, so it is obvious that we are providing
1491 the non human-readable server name, and receiving both the username
1492 and password, though changing of the username is not yet implemented.
1493 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1494 for the GNOME version.
1496 This should fix the projects.maemo.org bug NB#56209, though it does not
1497 work on Bora, because the gconf_client_get() for the password fails
1498 immediately after we save it with gconf_client_set().
1500 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1503 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1504 caused an undefined symbol error:
1505 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1507 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1509 * src/modest-tny-account-store.c:
1510 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1511 using a GError instead of a string message, so we can translate it in
1514 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1516 * src/maemo/modest-address-book.c:
1517 (modest_address_book_check_names):
1518 * src/maemo/modest-msg-view-window.c:
1519 (modest_msg_view_window_clipboard_owner_change):
1520 * src/modest-init.c: (modest_init_init_ui):
1521 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1522 (update_folders_cb), (modest_mail_operation_update_account):
1523 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1524 (modest_ui_actions_on_msg_attachment_clicked),
1525 (modest_ui_actions_on_msg_recpt_activated):
1526 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1527 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1528 (modest_msg_view_search_next):
1529 * src/widgets/modest-recpt-editor.c:
1530 (modest_recpt_editor_on_button_release_event),
1531 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1532 g_message(). At this point we should only be seeing interesting errors on
1533 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1535 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1537 (modest_wizard_dialog_force_title_update):
1538 * src/maemo/easysetup/modest-wizard-dialog.h:
1539 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1540 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1541 can update the title when appropriate. Otherwise the title is wrong if the
1542 pages are added after adding the notebook to the dialog.
1543 This must be a problem in HildonWizardDialog too.
1544 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1546 * src/maemo/easysetup/modest-easysetup-wizard.c:
1547 (create_subsequent_customsetup_pages),
1548 (create_subsequent_easysetup_pages):
1549 Call modest_wizard_dialog_force_title_update() so that the title is
1550 correct even with GTK+ < 2.10.
1551 This fixes projects.maemo.org bug NB#56145 .
1553 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1555 * src/maemo/modest-platform.c:
1556 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1557 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1560 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1562 * src/widgets/modest-window.h:
1563 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1564 and modest_window_save_state(), which invokes it.
1566 * src/widgets/modest-window-mgr.h:
1567 * src/widgets/modest-window-mgr.c:
1568 Added modest_window_mgr_save_state_for_all_windows(), which calls
1569 the save_state vfunc on all registered windows, if implemented.
1571 * src/gnome/modest-msg-edit-window.c:
1572 * src/gnome/modest-msg-view-window.c:
1573 * src/maemo/modest-msg-edit-window.c:
1574 * src/maemo/modest-msg-view-window.c:
1575 * src/maemo/modest-main-window.c:
1576 Specify the existing save_settings functions as implementations of
1577 ModestWindow::save_state_func().
1579 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1580 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1581 enabling hibernation, for instance.
1583 We may need to do the same thing for restoring settings.
1586 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1588 * src/widgets/modest-window-mgr.c:
1589 * src/widgets/modest-window-mgr.h:
1590 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1591 modest_window_mgr_get_hibernation_is_prevented().
1593 * src/maemo/modest-main-window.c:
1594 (on_hildon_program_is_topmost_notify): Prevent hibernation
1595 (possible when the application goes to the background in the WM),
1596 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1598 * src/maemo/easysetup/modest-easysetup-wizard.c:
1599 (modest_easysetup_wizard_dialog_init):
1600 * src/maemo/modest-account-settings-dialog.c:
1601 (modest_account_settings_dialog_init):
1602 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1603 (modest_connection_specific_smtp_edit_window_init):
1604 * src/maemo/modest-connection-specific-smtp-window.c:
1605 (modest_connection_specific_smtp_window_init):
1606 * src/maemo/modest-signature-editor-dialog.c:
1607 (modest_signature_editor_dialog_init):
1608 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1609 prevent hibernation while any of these account settings dialogs are open.
1611 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1613 * src/maemo/Makefile.am:
1614 * src/maemo/modest-osso-state-saving.c:
1615 * src/maemo/modest-osso-state-saving.h: Added
1616 modest_osso_load_state() and modest_osso_save_state() though they do
1617 nothing now. They should iterate through all the open windows and load/save
1619 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1620 save state when closing.
1622 * src/maemo/modest-main-window.c:
1623 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1624 Add a notification handler for the HildonProgram::is-topmost property,
1625 so we can allow hibernation when the application goes into the background.
1626 But we still need to detect when the accounts setup windows are open so
1627 we can stop hibernation when they are open.
1628 To do this, I also added the main window the HildonProgram. This might have
1629 other side-effects/benefits, and should maybe be done for other windows.
1631 * src/maemo/modest-osso-autosave-callbacks.h:
1632 * src/maemo/modest-osso-autosave-callbacks.c:
1633 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1634 though it does not do anything yet, and we might never need this to do
1635 anything. For instance, we already save drafts.
1637 * src/maemo/modest-platform.c: (modest_platform_init):
1638 Specify the libosso auto-save callback.
1640 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1642 * src/maemo/modest-platform.c:
1643 (modest_platform_set_update_interval):
1644 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1645 aparently stays valid between application instances, so we can use this
1646 to remove and reset it later. According to a maemo-developers email from
1649 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1651 * configure.ac: Depend on libalarm for Maemo.
1653 * src/dbus_api/modest-dbus-api.h:
1654 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1655 (on_send_receive), (modest_dbus_req_handler):
1656 Handle a SEND_RECEIVE D-Bus method.
1658 * libmodest-dbus-client/libmodest-dbus-client.c:
1659 (libmodest_dbus_client_send_and_receive):
1660 * libmodest-dbus-client/libmodest-dbus-client.h:
1661 Add C convenience functions for calling the new D-Bus method.
1663 * src/modest-platform.h:
1664 * src/gnome/modest-platform.c:
1665 * src/maemo/modest-platform.c:
1666 Added modest_platform_set_update_interval(), which uses the
1667 alarmd API on Maemo.
1668 (modest_platform_init),
1669 Call modest_platform_set_update_interval(), using a hard-coded
1670 interval for now (until the global settings dialog is implemented),
1671 though I am not sure that this makes sense yet.
1673 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1675 * src/dbus_api/modest-dbus-callbacks.c:
1676 (modest_osso_cb_hw_state_handler):
1677 * src/dbus_api/modest-dbus-callbacks.h:
1678 * src/maemo/modest-platform.c: (modest_platform_init):
1679 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1680 in case this has some effect on the ability for Maemo to ping the
1683 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1685 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1686 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1687 warning. It is probably a logic error, but I need to fix the build.
1689 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1691 * src/modest-account-mgr.h:
1692 * src/modest-account-mgr.c:
1693 (modest_account_mgr_account_names): Add a gboolean enabled_only
1694 parameter, so we can get lists of onlt the enabled accounts.
1696 (modest_account_mgr_add_account),,
1697 (modest_account_mgr_account_with_display_name_exists):
1698 * src/maemo/modest-msg-edit-window.c: (get_transports):
1699 * src/modest-account-mgr-helpers.c:
1700 (modest_account_mgr_set_first_account_as_default):
1701 * src/modest-init.c: (init_default_account_maybe):
1702 * src/modest-tny-account-store.c: (get_accounts):
1703 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1704 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1705 * tests/check_account-mgr.c: (START_TEST):
1706 Provide the extra parameter, as appropriate.
1708 * src/widgets/modest-account-view.c: (update_account_view):
1709 Do not show disabled accounts (meaning that there is no way to
1710 enable/disable accounts in the UI (the feature is not in our UI
1711 specification), so we can use this internally only to mark unfinished
1712 or temporary account data.
1714 * src/maemo/easysetup/modest-easysetup-wizard.c:
1715 (create_account): Add boolean enable parameter, so we can specify FALSE
1716 to create the temporary account.
1717 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1718 (on_before_next): When finishing, when there is a temporary account, just
1720 Also, use a timeout to delay the showing of the dialog until gconf is likely
1721 to return correct information, due to a maemo gconf bug that is fixed in
1722 osso 1.1, but not yet in Bora.
1723 However, the dialog stays on screen after it is destroyed.
1725 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1726 for invalid data when cancelling. Use a hildon note instead of a dialog
1727 to complain about invalid data. Do not show the account-saved note if the
1728 account is disabled (a temporary account that will not really be saved for use
1731 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1733 * src/modest-account-mgr-helpers.h:
1734 * src/modest-account-mgr-helpers.c:
1735 Added modest_account_mgr_unset_default_account(),
1736 Added modest_account_mgr_set_first_account_as_default().
1738 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1739 If it was the default account, unset the default account name.
1741 * src/maemo/modest-account-view-window.c:
1742 (on_delete_button_clicked): If it was the default account,
1743 set the first remaining account as the default instead.
1745 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1746 a NULL account or a NULL default account, to prevent a crash. This should
1747 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1750 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1752 * src/widgets/modest-recpt-editor.c:
1753 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1754 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1755 TODO comment for this. This fixes the build.
1757 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1758 be the best place for it. This will in future update all auto-update accounts,
1759 rather than just the current/default account, when that gconf key exists.
1760 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1761 if there are no accounts, before calling do_send_receive().
1762 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1764 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1765 * src/maemo/modest-main-window-ui.h:
1766 * src/maemo/modest-main-window.c: (on_connection_changed),
1767 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1768 directly, becaue the signal handler does more.
1770 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1772 * src/modest-account-mgr-helpers.c:
1773 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1774 for the case that the account does not exist.
1776 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1777 (equivalent to the modest account name) rather than the tinymail account name
1778 (equivalent to the modest account title - human readable) to get the account data.
1779 Check for null account data to prevent the crash, and add a TODO comment saying that
1780 this needs fixing because it is using the server account name instead of the account name.
1782 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1784 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1785 * src/maemo/modest-account-settings-dialog.c: (show_error),
1787 Use hildon_note_new_information() for informative and error messages,
1788 which seems to be expected for Maemo applications (no documentation that I know of
1789 says this). I am surprised that there is no distinction between info and error
1792 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1794 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1795 it is easy to find where this is used.
1797 * src/maemo/easysetup/modest-easysetup-wizard.c:
1798 (create_page_welcome), (create_page_account_details),
1799 (create_page_user_details), (create_page_complete_easysetup),
1800 (create_page_custom_incoming), (create_page_custom_outgoing),
1801 (create_page_complete_custom):
1802 * src/maemo/modest-account-settings-dialog.c:
1803 (create_page_account_details), (create_page_user_details),
1804 (create_page_incoming), (create_page_outgoing):
1805 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1806 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1807 (modest_connection_specific_smtp_edit_window_init):
1808 * src/maemo/modest-connection-specific-smtp-window.c:
1809 (modest_connection_specific_smtp_window_init):
1810 * src/maemo/modest-signature-editor-dialog.c:
1811 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1812 and scrolling policy as per the Email Application Layout Guide, if I have
1815 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1818 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1819 which were empty, because these vfuncs have been removed from TnyAccountStore.
1820 This fixes the build.
1822 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1824 * src/maemo/modest-main-window.c:
1825 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1826 showing/hiding it. Added TODO because it probably should not be NULL.
1827 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1828 because unnecessary g_warnings() make degugging difficult.
1830 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1832 * src/maemo/modest-msg-edit-window.c:
1833 (modest_msg_edit_window_select_color),
1834 (modest_msg_edit_window_select_background_color): 2 const corrections and
1835 moving 2 #endifs before closing brackets, to fix the build.
1837 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1839 * src/maemo/easysetup/modest-easysetup-wizard.h:
1840 * src/maemo/easysetup/modest-easysetup-wizard.c:
1841 (modest_easysetup_wizard_dialog_finalize),
1842 (on_button_edit_advanced_settings), (create_page_complete_custom),
1843 (on_response), (create_account):
1844 Implement the Advanced Settings edit button, by saving the account information,
1845 for the Advanded Settings dialog to use directly from gconf, and removing it
1846 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1847 Bug #5533 in the projects.maemo.org bugzilla.
1849 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1851 * src/maemo/modest-msg-view-window.c:
1852 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1853 when opening a message window.
1855 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1857 * src/maemo/easysetup/modest-easysetup-wizard.c:
1858 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1861 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1862 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1863 gconf settings. I probably added more checks than necessary, but that is safer.
1865 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1866 variable to fix the build, but this seems to be used when it is still NULL.
1868 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-platform.h:
1871 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1872 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1873 * src/modest-main.c: Implement this function so we can avoid using
1874 maemo-specific API from cross-platform code.
1876 * src/modest-tny-account-store.c:
1877 (get_smtp_specific_transport_account_for_open_connection):
1878 * src/modest-ui-actions.c: (check_for_connection),
1879 (modest_ui_actions_on_item_not_found):
1880 Use modest_platform_connect_and_wait() and put #idefs around other
1881 maemo-specific code, because only maemo currently has a way to
1882 identify connection names.
1884 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-tny-account-store.h:
1887 * src/modest-tny-account-store.c:
1888 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1889 the connection-specific SMTP server settings in the configuration.
1891 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1893 * src/maemo/modest-main-window.c: (on_connection_changed),
1895 * src/modest-main.c: (main), (start_ui), (send_mail):
1896 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1897 that is what is intended.
1899 * src/modest-ui-actions.c: (action_send), (action_receive),
1900 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1901 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1902 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1903 SMTP server is used when it is specified.
1905 (modest_ui_actions_on_send_receive):
1906 Check that a connection is open before proceeding.
1907 Receive and then send, instead of vice-versa, as per the specification.
1909 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1911 * src/modest-mail-operation.c:
1912 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1913 though I guess it should be something other than NULL.
1915 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/easysetup/modest-easysetup-wizard.c:
1918 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1919 combo twice, to avoid an g_warning and to make it visible again.
1920 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1921 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1922 (already intended) dereference when detaching, because we then recreate the menu.
1923 But I am not sure why the warning was happening, and it is possible that this is a memory
1926 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1928 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1929 and uri_parse_mailto() utility functions.
1930 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1932 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1934 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1936 * src/dbus_api/modest-dbus-api.h:
1937 * src/dbus_api/modest-dbus-callbacks.c:
1938 Use an idle callback to execute the modest code in the application's own thread.
1939 Remove the helloworld example method.
1940 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1941 parsed, and the open-message method is not implemented because this is not yet implemented in
1943 * libmodest-dbus-client/libmodest-dbus-client.c:
1944 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1945 (libmodest_dbus_client_open_message):
1946 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1948 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1949 body without crashing.
1951 * tests/dbus_api/Makefile.am:
1952 * tests/dbus_api/test_mail_to.c:
1953 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1955 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1957 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1958 Added file to fix the build. Sorry.
1960 * src/dbus_api/Makefile.am:
1961 * src/dbus_api/modest-dbus-api.h:
1962 * src/dbus_api/modest-dbus-callbacks.h:
1963 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1964 (modest_dbus_req_handler):
1965 Put constants in a separate header so it can be reused by the
1966 client library, without duplication
1968 * libmodest-dbus-client/Makefile.am:
1969 * libmodest-dbus-client/libmodest-dbus-client.c:
1970 (libmodest_dbus_client_call_helloworld),
1971 (libmodfest_dbus_client_send_mail),
1972 (libmodfest_dbus_client_mailto),
1973 (libmodfest_dbus_client_open_message):
1974 * libmodest-dbus-client/libmodest-dbus-client.h:
1975 (Partly) Implement a send_mail D-Bus method.
1977 * tests/dbus_api/Makefile.am:
1978 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1979 the send_email D-Bus method.
1981 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1985 * libmodest-dbus-client/Makefile.am:
1986 * libmodest-dbus-client/libmodest-dbus-client.c:
1987 * libmodest-dbus-client/libmodest-dbus-client.h:
1988 * tests/dbus_api/Makefile.am:
1989 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1990 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1992 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1994 * src/maemo/easysetup/modest-easysetup-wizard.c:
1995 (create_page_account_details):
1996 * src/maemo/modest-account-settings-dialog.c:
1997 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1998 widgets, because this might not be the default in future versions of the Maemo GTK+.
1999 However, I can not not get capitalization to work even in a simple test case.
2001 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/easysetup/modest-easysetup-wizard.c:
2004 (create_page_custom_incoming), (create_page_custom_outgoing):
2005 * src/maemo/modest-account-settings-dialog.c:
2006 (create_page_account_details), (create_page_incoming),
2007 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2008 instead of using gtk_check_button_with_label(), so they are aligned like the other
2009 widgets, as per the UI spec.
2011 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2013 * src/maemo/easysetup/modest-easysetup-wizard.c:
2014 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2015 * src/widgets/modest-validating-entry.c:
2016 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2017 Modest prefix instead of an EasySetup prefix.
2019 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2021 * src/widgets/modest-validating-entry.h:
2022 * src/widgets/modest-validating-entry.c: (on_insert_text),
2023 Added easysetup_validating_entry_set_max_func(), used to set a callback
2024 to call when the max number of characters is reached. GtkEntry has a max-length
2025 already but is silent about it.
2027 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2028 (create_page_account_details), (create_page_user_details),
2030 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2031 (create_page_account_details), (create_page_user_details),
2032 (create_page_outgoing):
2033 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2034 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2035 the UI spec, when the user tries to enter more than the max number of characters.
2037 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2039 * src/maemo/easysetup/modest-easysetup-wizard.c:
2040 (create_page_user_details), (create_page_custom_incoming),
2041 (create_page_custom_outgoing):
2042 * src/maemo/modest-account-settings-dialog.c:
2043 (create_page_user_details), (create_page_incoming),
2044 (create_page_outgoing):
2045 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2046 (modest_connection_specific_smtp_edit_window_init):
2047 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2048 not appropriate. Bad Maemo-specific defaults!.
2050 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2053 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2054 (modest_signature_editor_dialog_set_settings):
2055 Disable the label and textview when the checkbox is disabled, and use the
2056 specified (UI spec) default signature text.
2058 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2061 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2063 * src/modest-defs.h:
2064 * src/modest-account-mgr-helpers.h:
2065 * src/modest-account-mgr-helpers.c:
2066 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2068 * src/maemo/Makefile.am:
2069 * src/maemo/modest-signature-editor-dialog.c:
2070 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2073 * src/maemo/modest-account-settings-dialog.h:
2074 * src/maemo/modest-account-settings-dialog.c:
2075 (modest_account_settings_dialog_finalize), (on_button_signature),
2076 (save_configuration): Use the new dialog when the Edit button is pressed, and
2077 save the changes if necessary, as per the UI spec.
2079 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/Makefile.am:
2082 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2083 based on maemo-develoers email from Dirk.
2085 * src/maemo/easysetup/modest-easysetup-wizard.c:
2086 (create_page_welcome), (create_page_account_details),
2087 (create_page_user_details), (create_page_complete_easysetup),
2088 (create_page_custom_incoming), (create_page_custom_outgoing),
2089 (create_page_complete_custom),
2090 (modest_easysetup_wizard_dialog_init):
2091 * src/maemo/modest-account-settings-dialog.c:
2092 (create_page_account_details), (create_page_user_details),
2093 (create_page_incoming), (create_page_outgoing),
2094 (modest_account_settings_dialog_init):
2095 * src/maemo/modest-connection-specific-smtp-window.c:
2096 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2098 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/modest-easysetup-wizard.c:
2101 (create_page_account_details), (create_page_custom_outgoing),
2102 (create_page_complete_custom):
2103 * src/maemo/modest-account-settings-dialog.c:
2104 (create_page_user_details), (create_page_incoming),
2105 (create_page_outgoing):
2106 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2107 (modest_connection_specific_smtp_edit_window_init):
2108 Use the correct (UI spec) port min/max, and use horizontal separators,
2111 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2113 * src/maemo/easysetup/modest-easysetup-wizard.c:
2114 (set_default_custom_servernames):
2115 * src/maemo/modest-account-settings-dialog.c:
2116 (create_page_incoming), (on_combo_outgoing_security_changed),
2117 (on_combo_incoming_security_changed), (create_page_outgoing),
2118 (modest_account_settings_dialog_set_account_name),
2119 (save_configuration):
2120 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2121 (on_combo_security_changed),
2122 (modest_connection_specific_smtp_edit_window_init),
2123 (modest_connection_specific_smtp_edit_window_set_connection),
2124 (modest_connection_specific_smtp_edit_window_get_settings):
2125 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2128 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/easysetup/modest-easysetup-wizard.c:
2132 (create_page_custom_outgoing), (create_page_complete_custom):
2133 * src/maemo/modest-account-settings-dialog.c:
2134 (create_page_user_details), (create_page_outgoing):
2135 * src/maemo/modest-account-view-window.c: (button_box_new):
2136 Use changed logical IDs as per the most recent UI spec:
2137 mcen_bd_emailsetup_edit -> mcen_bd_edit
2138 mcen_bd_emailsetup_delete -> mcen_bd_delete
2139 mcen_bd_emailsetup_close -> mcen_bd_close
2141 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2145 * src/dbus_api/Makefile.am:
2146 * src/dbus_api/modest-dbus-callbacks.c:
2147 * src/dbus_api/modest-dbus-callbacks.h:
2148 * src/maemo/modest-platform.c: (modest_platform_init):
2149 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2151 * tests/Makefile.am:
2152 * tests/dbus_api/Makefile.am:
2153 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2155 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/modest-account-settings-dialog.c:
2158 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2159 Removed unnecessary includes.
2161 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2163 * src/maemo/easysetup/modest-easysetup-wizard.c:
2164 * src/maemo/modest-account-settings-dialog.c:
2165 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2166 * src/widgets/Makefile.am:
2167 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2168 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2169 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2170 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2171 * src/widgets/modest-secureauth-combo-box.c:
2172 * src/widgets/modest-secureauth-combo-box.h:
2173 * src/widgets/modest-serversecurity-combo-box.c:
2174 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2175 made the GObject names more consistent with the rest of the Modest code.
2177 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/easysetup/Makefile.am:
2180 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2181 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2182 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2183 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2184 * src/maemo/easysetup/modest-easysetup-wizard.c:
2185 * src/maemo/easysetup/modest-validating-entry.c:
2186 * src/maemo/easysetup/modest-validating-entry.h:
2187 * src/maemo/modest-account-settings-dialog.c:
2188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2189 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2190 widgets/ because they are used outside of easysetup too. After checking in,
2191 svn will allow me to rename them too.
2193 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2195 * src/gnome/modest-msg-edit-window.c:
2196 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2197 linker error, to fix the build on the GNOME platform.
2198 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2199 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2200 ifdefed out to avoid a warning.
2202 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2204 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2205 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2206 some alternative for GTK+ 2.6.
2208 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2212 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2213 specified for EmailAccountsDialog in UI spec.
2215 * src/maemo/easysetup/modest-easysetup-wizard.c:
2216 * src/maemo/easysetup/modest-easysetup-wizard.h:
2217 * src/maemo/modest-account-settings-dialog.c:
2218 * src/maemo/modest-account-settings-dialog.h:
2219 Reuse a member window widget for the connection-specific SMTP server accounts,
2220 so we can tell it to create/save the accounts only if we actually save changes.
2222 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2224 (modest_connection_specific_smtp_edit_window_get_settings):
2225 Return a struct instance for temporarily remembering the entered data.
2227 * src/maemo/modest-connection-specific-smtp-window.h:
2228 * src/maemo/modest-connection-specific-smtp-window.c:
2229 (modest_connection_specific_smtp_window_finalize),
2230 (modest_connection_specific_smtp_window_fill_with_connections),
2232 (modest_connection_specific_smtp_window_save_server_accounts),
2233 (update_model_server_names): Do not actually save data until asked,
2234 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2236 (on_selection_changed),
2237 (modest_connection_specific_smtp_window_init): Disable the edit
2238 button when nothing is selected.
2240 * src/modest-account-mgr-helpers.c:
2241 * src/modest-account-mgr-helpers.h:
2242 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2245 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2247 * src/modest-account-mgr-helpers.h:
2248 * src/modest-account-mgr-helpers.c:
2249 (modest_account_mgr_get_unused_account_name),
2250 (modest_account_mgr_get_unused_account_display_name): Added these
2251 utility functions, to avoid code duplication.
2253 * src/maemo/easysetup/modest-easysetup-wizard.c:
2254 (create_page_account_details), (create_account):
2255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2256 (on_combo_security_changed),
2257 (modest_connection_specific_smtp_edit_window_init),
2258 (modest_connection_specific_smtp_edit_window_save_settings):
2259 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2260 * src/maemo/modest-connection-specific-smtp-window.c:
2261 (modest_connection_specific_smtp_window_finalize),
2262 (modest_connection_specific_smtp_window_fill_with_connections),
2263 (on_button_edit), (modest_connection_specific_smtp_window_init):
2264 * src/maemo/modest-connection-specific-smtp-window.h:
2265 Implementing saving of connection-specific server accounts.
2267 But I need to refactor this so we can save the data for each
2268 possible connection-specific account and only actually create the server accounts
2269 when the easysetup finished, or the OK button is pressed on the account settings
2272 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2274 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2275 (on_combo_security_changed):
2276 (modest_connection_specific_smtp_edit_window_init):
2277 Auto-fill the port number as in the account settings.
2279 (modest_connection_specific_smtp_edit_window_set_connection):
2280 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2281 * src/maemo/modest-connection-specific-smtp-window.c:
2282 (fill_with_connections), (on_button_edit),
2283 (modest_connection_specific_smtp_window_init):
2284 Turn the edit window into a dialog to simplify the code, and
2285 set a WM hint as in a GtkDialog, because only a popup can be on top of
2286 another window in Maemo, and popups usually have no WM decoration.
2288 * src/modest-defs.h:
2289 * src/modest-account-mgr-helpers.c:
2290 (modest_account_mgr_set_connection_specific_smtp),
2291 (modest_account_mgr_remove_connection_specific_smtp),
2292 (modest_account_mgr_get_connection_specific_smtp):
2293 * src/modest-account-mgr-helpers.h: Some functions to write the
2294 connection-specific SMTP server information. Not yet used.
2297 * src/widgets/modest-folder-view.c: (text_cell_data):
2298 Fix a warning about an uninitialized variable.
2299 (on_configuration_key_changed): Put an #ifdef around the use
2300 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2302 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2304 * src/maemo/modest-account-settings-dialog.h:
2305 * src/maemo/modest-account-settings-dialog.c:
2306 Added connect_for_modified() utility function to mark the new modified boolean.
2308 (create_page_account_details), (create_page_user_details),
2309 (create_page_incoming), (create_page_outgoing), (on_response),
2310 (modest_account_settings_dialog_init),
2311 (modest_account_settings_dialog_set_account_name):
2312 Only warn about unsaved changes when there are actually unsaved changes.
2314 * src/modest-account-mgr-helpers.c:
2315 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2316 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2317 to get the data from there in future.
2319 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2321 * src/modest-defs.h:
2323 * src/modest-account-mgr-helpers.h:
2324 * src/modest-account-mgr-helpers.c:
2325 Store the security account setting in a single conf key instead of using
2326 the options list, so that the list is left for just the to-be-removed camel hack,
2327 and because gconf_client_set_list() is failing for some reason.
2329 * src/modest-account-mgr.c:
2330 (modest_account_mgr_add_server_account):
2331 * src/maemo/modest-account-settings-dialog.c:
2332 (modest_account_settings_dialog_set_account_name),
2333 (save_configuration): Use the renamed functions.
2336 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2338 * src/widgets/Makefile.am:
2339 * src/widgets/modest-limit-retrieve-combo-box.c:
2340 * src/widgets/modest-limit-retrieve-combo-box.h:
2341 * src/widgets/modest-retrieve-combo-box.c:
2342 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2343 the account settings dialog.
2345 * src/modest-defs.h:
2346 * src/modest-account-mgr-helpers.h:
2347 * src/modest-account-mgr-helpers.c:
2348 (modest_server_account_get_option_secure_auth),
2349 (modest_server_account_set_option_secure_auth):
2350 * src/modest-account-mgr.c:
2351 (modest_account_mgr_add_server_account):
2352 Use the existing AUTH_MECH conf key for the secure-auth setting,
2353 instead of putting it in the list options, because this was actually used already.
2355 * src/maemo/modest-account-settings-dialog.c:
2356 (create_page_account_details),
2357 (modest_account_settings_dialog_set_account_name),
2358 (save_configuration):
2359 * src/maemo/modest-account-settings-dialog.h:
2360 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2361 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2363 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2365 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2366 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2367 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2369 * src/modest-defs.h:
2370 * src/maemo/modest-account-settings-dialog.c:
2371 (create_page_incoming), (on_combo_outgoing_security_changed),
2372 (on_combo_incoming_security_changed), (create_page_outgoing),
2373 (modest_account_settings_dialog_set_account_name),
2374 (save_configuration): Load/Save the port number, and change it when the
2375 security combo changes, to suitable defaults.
2377 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2379 * src/modest-account-mgr.c:
2380 (modest_account_mgr_add_server_account): Set the security and secure-auth
2381 options, and add a comment saying that the other camel-specific options should be
2384 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2386 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2388 * src/modest-tny-account-store.c: (account_list_free),
2389 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2390 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2393 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2395 * src/modest-protocol-info.c:
2396 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2397 is required by our UI spec. Maybe something in our implementation will use this eventually.
2398 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2399 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2400 instead of the previous 0 placeholder.
2402 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2403 secure-auth settings.
2404 * src/modest-account-mgr-helpers.h:
2405 * src/modest-account-mgr-helpers.c:
2406 (modest_server_account_data_get_option_secure_auth),
2407 (modest_server_account_set_option_secure_auth),
2408 (modest_server_account_data_get_option_security),
2409 (modest_server_account_set_option_security): Added this API for getting and setting the security
2410 and secure-auth settings.
2412 * src/maemo/modest-account-settings-dialog.h:
2413 * src/maemo/modest-account-settings-dialog.c:
2414 (modest_account_settings_dialog_finalize), (check_data),
2415 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2416 about changing titles.
2417 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2418 (save_configuration): Save the security and secure-auth settings.
2420 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2421 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2423 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2425 * src/modest-defs.h:
2426 * src/modest-account-mgr.c:
2427 (modest_account_mgr_add_server_account):
2428 Added and used defines for the options key and value pair strings,
2429 that are used so far, though they do not seem to correspond to anything in our
2430 UI specs or ModestProtocol enum.
2432 * src/modest-account-mgr-helpers.h:
2433 * src/modest-account-mgr-helpers.c:
2434 (compare_option_strings_for_name),
2435 (modest_server_account_data_get_option_value),
2436 (modest_server_account_data_get_option_bool),
2437 (modest_account_mgr_get_server_account_option):
2438 Added helper functions for parsing the options GSList.
2440 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2442 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2443 display name is based on the supplied account name.
2444 * src/modest-account-mgr.c:
2445 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2446 with an inefficient, but good-enough, implementation.
2448 * src/maemo/easysetup/modest-easysetup-wizard.c:
2449 (create_page_account_details), (on_before_next), (create_account):
2450 Check for existing display names rather than (non-user-visible) account names, and just
2451 create and set a unique account name at the end.
2453 * src/maemo/modest-account-settings-dialog.c:
2454 (modest_account_settings_dialog_init),
2455 (modest_account_settings_dialog_set_account_name),
2456 (create_page_incoming): Show the display name, instead of the account name.
2457 (on_response): Do some (not all) extra checks, as in the UI spec.
2458 (save_configuration): Save the display name if it was changed.
2460 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2462 * po/en_GB.po: Added needed logical ID and translation.
2463 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2464 (init_view): Made the is-default column clicking work.
2466 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2469 * src/maemo/easysetup/Makefile.am:
2470 * src/maemo/easysetup/modest-easysetup-wizard.c:
2471 (modest_easysetup_wizard_dialog_init):
2472 * src/maemo/easysetup/provider-data-test.keyfile:
2473 * src/maemo/easysetup/provider-data.keyfile:
2474 Moved the provider data file to the new modest-providers-data package and used it from there.
2476 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-local-folder-info.c:
2479 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2480 N_() was already used on the static strings, but this just marks it for translation without
2481 using the translation.
2483 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2485 * src/maemo/modest-account-settings-dialog.c:
2486 (create_page_incoming),
2487 (modest_account_settings_dialog_set_account_name):
2488 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2489 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2490 I will do this if nobody else gets there first.
2492 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2495 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2496 save the security stuff.
2498 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2501 Set the email address and user fullname, which I now see must be
2504 * src/maemo/modest-account-settings-dialog.h:
2505 * src/maemo/modest-account-settings-dialog.c:
2507 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2508 leave-on-server and authentication.
2509 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2512 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/modest-account-settings-dialog.c:
2516 * src/maemo/modest-account-settings-dialog.h:
2517 Most (but not all) of the widgets are now present as specified by the UI spec.
2518 No changes are yet saved, and some details are not properly shown yet.
2520 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2522 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2524 * src/maemo/Makefile.am:
2525 * src/maemo/modest-account-settings-dialog.c:
2526 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2527 an existing account. Doesn't do much yet.
2529 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2530 Open the accounts settings dialog when Edit is clicked.
2532 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2534 * src/maemo/easysetup/Makefile.am:
2535 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2537 * src/maemo/easysetup/modest-easysetup-wizard.c:
2538 (modest_easysetup_wizard_dialog_init):
2539 Try to get the source directory from the build system,
2540 instead of hard-coding "./" into the source code, when opening our local
2541 copies of the configuration files.
2542 But this still fails when opening the wizard from the Accounts window,
2543 maybe because the working directory seems to change at runtime.
2544 So the wizard will fail the second time unless you copy the files into their
2545 proper locations - see the stdout warnings for the paths.
2547 (create_page_account_details),(on_before_next):
2548 Check for existing non-server accounts instead of server accounts,
2549 so the default account name is useful again, and to prevent trying to
2552 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2553 Show the wizard when New is clicked.
2555 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2556 (init_view): Show the column headers, and show the columns that are
2557 specified in the UI specs. However, something in Maemo's GTK+ prevents
2558 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2559 change the default account. This is despite unsetting the special properties.
2561 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2563 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2564 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2565 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2566 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2567 to make that clearer.
2568 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2570 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2572 * src/maemo/modest-account-view-window.c:
2573 (modest_account_view_window_init),
2574 (modest_account_view_window_new):
2575 Use the same buttons as specified in the
2576 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2577 the existing widgets, which never had a chance of working.
2578 Put the ModestAccountView treeview in a scrolled window.
2579 Do not repeat the initialization in both _init() and _new().
2581 * src/widgets/modest-account-view.c: (update_account_view):
2582 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2583 this widget and window shows no accounts.
2585 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2587 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2589 * src/maemo/easysetup/modest-easysetup-wizard.c:
2590 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2591 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2592 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2595 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2596 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2597 accounts exist yet, as in the UI spec.
2599 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2601 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2603 * src/maemo/Makefile.am:
2604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2605 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2606 New window for editing connection-specific smtp details.
2607 Not fully implemented.
2609 * src/maemo/modest-connection-specific-smtp-window.c:
2610 (modest_connection_specific_smtp_window_finalize) :
2611 unref the tree model.
2612 (on_button_edit): Show the edit window.
2614 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2616 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2619 * src/maemo/Makefile.am:
2620 * src/maemo/modest-connection-specific-smtp-window.c:
2621 * src/maemo/modest-connection-specific-smtp-window.h:
2622 New window for showing the list of connections, for connection-specific
2623 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2624 * src/maemo/easysetup/modest-easysetup-wizard.c:
2625 (create_page_custom_outgoing): Show the new window when the button is clicked.
2627 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2629 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2630 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2631 * src/maemo/modest-msg-edit-window.c:
2632 (modest_msg_edit_window_insert_image):
2633 * src/modest-conf.c: (modest_conf_key_escape):
2634 * src/modest-mail-operation.c:
2635 (modest_mail_operation_send_new_mail):
2636 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2637 (modest_ui_actions_on_new_account):
2638 * src/widgets/modest-attachment-view.c: (update_filename_request):
2639 * src/widgets/modest-mail-header-view.c:
2640 Corrected warnings that were breaking the build, by commenting out unused variables,
2641 and a function, and by including a header.
2643 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2645 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2646 so we can #ifdef around platform-specific code when necessary.
2647 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2648 to allow this to build for the GNOME platform too.
2650 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2652 * src/maemo/easysetup/modest-easysetup-wizard.c:
2653 Added util_increment_name() and used it in create_page_account_details()
2654 to make sure that the default account name is always a new name.
2656 (modest_easysetup_wizard_dialog_init),
2657 (set_default_custom_servernames): Some minor memory management fixes.
2659 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2663 * src/modest-runtime.c: (init_i18n): Restored the translation
2664 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2665 are defined in config.h, and the translations are installed.
2667 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2668 is defined for translation.
2670 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2672 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2674 * src/maemo/easysetup/modest-easysetup-wizard.c:
2675 (modest_easysetup_wizard_dialog_init):
2676 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2677 Use realistic paths (though they should use $prefix generically) to the
2678 mcc_mapping and provider-data.keyfile files which might work when they
2679 are installed by the future version of the operator-wizard package,
2680 and then fallback to paths in our source code, with an explanatory
2683 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/Makefile.am:
2688 * src/maemo/easysetup/: Added files from the previously-exernal
2689 osso-modest-easysetup.
2690 * src/maemo/modest-main-window-ui.h:
2691 * src/modest-ui-actions.c:
2692 * src/modest-ui-actions.h:
2693 Added modest_ui_actions_on_new_account() as a signal handler for the
2694 New Account menu item. It shows the easysetup wizard.
2695 * po/en_GB.po: Added additional needed logical IDs and translations.
2697 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2698 Apparently ChangeLog is not used for some vague Nokia legal reasons.