1 2007-06-05 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-main-window.c: (create_details_widget):
4 Show the total size for memory card accounts too, instead of showing
5 the name again. Fixes bug projects.maemo.org bug NB#59307.
7 2007-06-05 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-simple-folder-store.c:
11 * src/modest-tny-simple-folder-store.h: Removed.
13 * src/modest-tny-local-folders-account.h
14 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
15 for the local-folders maildir, with an extra TnyMergedFolder containing
16 the folders of the per-account outbox store accounts.
17 * src/modest-tny-account-store.c: (get_server_accounts):
18 Add the outboxes to the special local folders account after creating it.
20 * src/modest-tny-account.c:
21 (modest_tny_account_new_for_local_folders): Create the derived
22 account when creating the main local-folders account.
24 * src/maemo/modest-main-window.c: (create_details_widget),
25 (modest_main_window_set_contents_style):
26 Adapted to the use of the derived account instead of the folder store.
28 * src/modest-ui-actions.c:
29 (modest_ui_actions_on_folder_selection_changed):
30 * src/modest-ui-dimming-rules.c:
31 (modest_ui_dimming_rules_on_new_folder):
32 * src/widgets/modest-folder-view.c: (text_cell_data),
33 (icon_cell_data), (filter_row), (update_model),
34 (get_cmp_rows_type_pos):
37 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
38 Do not get the priv struct, because no priv struct has been set,
39 to avoid a runtime warning.
41 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
42 #ifelse with #else, to fix a warning, to fix the build.
45 2007-06-05 Christian Kellner <ckellner@openismus.com>
47 * libmodest-dbus-client/libmodest-dbus-client.c:
48 Fix small typo in doc (why do you always see them
49 AFTER committing stuff?)
52 2007-06-05 Christian Kellner <ckellner@openismus.com>
54 * libmodest-dbus-client/libmodest-dbus-client.c:
55 (libmodest_dbus_client_search):
56 Initialize hit list with NULL. Also set folder list
57 to "" if NULL was supplied.
60 2007-06-03 Christian Kellner <ckellner@openismus.com>
62 * libmodest-dbus-client/libmodest-dbus-client.c:
63 (modest_search_hit_list_free):
64 Make it save to call it with NULL.
66 * src/dbus_api/modest-dbus-callbacks.c:
67 * src/modest-search.c:
68 Return full ModestSearchHits as the search result list not TnyHeader
69 since can't be around withouth the correspoding TnyFolder.
71 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
73 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
74 Added currently commented code to check for secure auth
76 * src/maemo/modest-account-settings-dialog.c: (on_response),
77 (save_configuration), (show_ok):
78 Fixed projects.maemo.org bugs NB #59248 and #59251
80 * src/maemo/modest-maemo-utils.c:
81 (on_camel_account_get_supported_secure_authentication_status),
82 (on_camel_account_get_supported_secure_authentication),
83 (modest_maemo_utils_get_supported_secure_authentication_methods):
84 * src/maemo/modest-maemo-utils.h:
85 Moved get_supported_secure_authentication() method here to be able
86 to use it from easysetup wizard.
88 * src/modest-pair.c: (on_pair_compare_as_string):
89 Should compare string with first part of pair and not
90 strcmp pairs which will crash.
92 * src/modest-protocol-info.c:
93 (modest_protocol_info_protocol_is_store):
94 * src/modest-protocol-info.h:
95 Added modest_protocol_info_get_auth_protocol_name()
97 2007-06-03 Armin Burgmeier <armin@openismus.com>
99 * src/modest-mail-operation.c:
100 (modest_mail_operation_get_msgs_full): Set priv->account also when
101 only retrieving a single message. This avoids a crash when canceling
104 (modest_mail_operation_notify_end): Do not explicitely remove the
105 operation from the queue but only emit the progress_changed signal.
106 The queue itself listens to that signal to remove the operation when
107 it is finished. This reduces coupling and removes a potential deadlock
108 when modest_mail_operation_notify_end() is called from the queue
109 itself. If that is a problem performance-wise, I would suggest to
110 implement a status-changed signal or something.
112 * src/modest-mail-operation-queue.c: Make sure to never call a
113 function from another file while the queue is locked. This (hopefully)
114 fixes another deadlock when exiting the application while retrieving
117 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
119 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
120 Fixed build if libogs is not available
122 2007-06-03 Christian Kellner <ckellner@openismus.com>
124 * libmodest-dbus-client/libmodest-dbus-client.h:
125 * libmodest-dbus-client/libmodest-dbus-client.c:
126 (libmodest_dbus_client_delete_message):
127 Implement deletion of messages (Client side).
129 (modest_search_hit_free),
130 (modest_search_hit_list_free):
131 Utility functions to free the result hits.
133 * src/dbus_api/modest-dbus-api.h:
134 * src/dbus_api/modest-dbus-callbacks.c:
136 (modest_dbus_req_handler):
137 Implement deletion of messages (Server side).
139 * tests/dbus_api/test_search.c: (main):
142 * tests/dbus_api/Makefile.am:
143 * tests/dbus_api/test_delete_message:
144 Add little test for the message deletion logic
146 2007-06-03 Armin Burgmeier <armin@openismus.com>
148 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
149 when the operation queue was not empty. projects.maemo.org bug
152 2007-06-03 Armin Burgmeier <armin@openismus.com>
154 * src/widgets/modest-account-view.c
155 (on_account_default_toggled): Toggle default account column
156 explicitely instead of waiting for gconf notification (which is
157 currently ignored). This should fix projects.maemo.org bug NB#56910
158 for now. It should probably be removed when gconf notifications are
161 2007-06-03 Christian Kellner <ckellner@openismus.com>
163 * libmodest-dbus-client/libmodest-dbus-client.c:
164 Removed debugging spew.
166 * src/dbus_api/modest-dbus-callbacks.c:
167 Added debugging info.
169 * src/modest-search.c:
170 (modest_search_all_accounts):
171 Use tny_account_store_get_accounts () on the account store
172 to get all accounts which is the way to get all accounts.
174 * tests/dbus_api/test_search.c: (main):
175 Make it possible to supply the search term on the command line.
177 2007-06-03 Christian Kellner <ckellner@openismus.com>
179 * libmodest-dbus-client/libmodest-dbus-client.c:
180 * libmodest-dbus-client/libmodest-dbus-client.h:
181 Implement searching for mesages over raw dbus. (Client side)
183 * src/dbus_api/Makefile.am:
184 * src/dbus_api/modest-dbus-api.h:
185 * src/dbus_api/modest-dbus-callbacks.c:
186 * src/dbus_api/modest-dbus-callbacks.h:
187 Search framework (Server side). Also implement on_idle_open_message().
189 * src/maemo/modest-platform.c: (modest_platform_init):
190 Prepare for raw dbus/osso rpc interaction.
192 * src/modest-search.h:
193 Changed minsize from unspecific guint to guint32.
195 * src/modest-search.c:
197 Added strange hack which magically made tnymail work.
199 (modest_search_folder),
200 (modest_search_account),
201 (modest_search_all_accounts):
202 Implement helper functions to search all accounts, specific account
205 * tests/dbus_api/Makefile.am:
206 * tests/dbus_api/test_open_message.c:
207 Read url to open from commandline.
209 * tests/dbus_api/test_search.c:
210 Implement small test for dbus search stuff
212 2007-06-02 Armin Burgmeier <armin@openismus.com>
214 * src/maemo/modest-account-settings-dialog.c: Changed window title to
215 include account type and account title. This fixes projects.maemo.org
218 * src/maemo/modest-account-view-window.c: Set a title for the window.
220 2007-06-02 Armin Burgmeier <armin@openismus.com>
222 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
223 incoming and outgoing server name based on email address and server
224 types as long as the names have not been edited manually. This fixes
225 projects.maemo.org bug NB#58671.
227 2007-06-02 Armin Burgmeier <armin@openismus.com>
229 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
230 server type cannot be changed in future to the incoming details page
231 when creating an account. This fixes projects.maemo.org bug NB#59029.
233 2007-06-02 Armin Burgmeier <armin@openismus.com>
235 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
236 and assigned max width chars so that they wrap instead of being
237 truncated. Fixes projects.maemo.org bug NB#56126.
239 2007-06-02 Armin Burgmeier <armin@openismus.com>
241 * src/maemo/modest-connection-specific-smtp-window.c: Add an
242 introductory note to the connection specific smtp servers dialog, as
243 section 8.12 of the email UI specification requires. This fixes
244 projects.maemo.org bug NB#59212.
246 2007-06-01 Murray Cumming <murrayc@murrayc.com>
248 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
249 Check for running mail operations, and offer to cancel them, as per the UI
250 spec. This fixes projects.maemo.org bug NB#59041 .
251 However, I suspect that tinymail may still use the network connection
252 in ways that we cannot detect or cancel. But it should at least adapt to
255 2007-06-01 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-tny-account-store.c: (recreate_all_accounts),
258 (get_cached_accounts), (get_server_accounts): Do more sensible
259 ref-counting of the temporarily-cached outbox accounts list. This seems
260 to fix a crash when entering the password when the password was wrong.
262 2007-06-01 Murray Cumming <murrayc@murrayc.com>
264 * src/gnome/modest-main-window.c: (connect_signals):
265 * src/modest-tny-account-store.c: (get_password),
266 (modest_tny_account_store_alert): Added comments and clues and
267 commented-out code about how we currently fail to deal with connection
268 errors and wrong passwords, and how we should.
270 2007-06-01 Murray Cumming <murrayc@murrayc.com>
272 * src/widgets/modest-retrieve-combo-box.c:
273 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
274 This fixes projects.maemo.org bug NB#58472 .
276 2007-06-01 Murray Cumming <murrayc@murrayc.com>
278 * src/maemo/easysetup/modest-easysetup-wizard.c:
279 (create_page_complete_easysetup):
280 (create_page_complete_custom): Correct the last commit,
281 putting the correct sentences in the correct pages.
283 2007-06-01 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/easysetup/modest-easysetup-wizard.c:
286 (create_page_complete_custom): Show the second sentence of text
287 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
293 Set the leave-on-server conf key by default. This fixes
294 projects.maemo.org bug NB#59258 .
296 2007-06-01 Murray Cumming <murrayc@murrayc.com>
298 * src/maemo/modest-account-view-window.c:
299 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
300 logical ID for the confirmation messages. Fixed projects.maemo.org bug
303 2007-06-01 Murray Cumming <murrayc@murrayc.com>
305 * src/maemo/easysetup/modest-easysetup-wizard.c:
306 (create_caption_new_with_asterisk):
307 * src/maemo/modest-account-settings-dialog.c:
308 (create_caption_new_with_asterisk):
309 Uncomment the code to add the asterisk, because they are no longer in the
310 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
311 (update_incoming_server_title): Add an asterisk here too.
313 2007-06-01 Murray Cumming <murrayc@murrayc.com>
315 * src/maemo/modest-maemo-global-settings-dialog.c:
316 (current_connection): Check that we are even connected before trying to
317 get the current connection name, to prevent a warning.
319 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
320 Change the comments because tny_maemo_conic_device_connect() is now meant to
322 * src/modest-mail-operation.c:
323 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
324 make sure we have a connection and fail if we can't connect.
326 2007-05-31 Murray Cumming <murrayc@murrayc.com>
328 * src/maemo/modest-main-window.c:
329 (on_account_store_connecting_finished): Do not try to get the
330 connection ID if we are not really connected. I am surprised that
331 this signal handler is called when we are not connected.
333 2007-05-31 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-error.h:
336 * src/modest-ui-actions.c:
337 (modest_ui_actions_get_msgs_full_error_handler):
338 Renamed an enum, added comments, added an enum
339 for retrieve-limit errors.
341 * src/modest-mail-operation.c: (foreach_add_item),
342 (internal_folder_observer_update), (update_account_thread),
343 (modest_mail_operation_get_msgs_full):
344 (modest_mail_operation_update_account),
345 Added comments about how this works, and some code that should
346 (but does not) check the retrieve-limit. See the TODO comment.
348 2007-05-31 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
351 Initialize help_id to fix the build. Warnings are good.
353 2007-05-31 Murray Cumming <murrayc@murrayc.com>
355 * src/widgets/modest-hbox-cell-renderer.c:
356 (modest_hbox_cell_renderer_append):
357 * src/widgets/modest-vbox-cell-renderer.c:
358 (modest_vbox_cell_renderer_append):
359 Fix the last commit by doing an extra ref.
361 2007-05-31 Murray Cumming <murrayc@murrayc.com>
363 * src/widgets/modest-hbox-cell-renderer.c:
364 (modest_hbox_cell_renderer_append):
365 * src/widgets/modest-vbox-cell-renderer.c:
366 (modest_vbox_cell_renderer_append):
367 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
368 to fix the build with Maemo Bora.
369 However, there seems to be a remaining crash, probably due to reference
372 2007-05-30 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-tny-account.c:
375 (modest_tny_account_new_for_local_folders):
376 Use hildon_file_system_info_async_new() to get a better name for
377 the memory card account, setting it as the account name.
378 The timing seems to work, but this is probably
379 not the best place to do this. See the TODO comment.
380 * src/maemo/modest-main-window.c: (create_details_widget):
381 * src/widgets/modest-folder-view.c: (text_cell_data):
382 Use the tny account name instead of hardcoding a name.
384 2007-05-30 Christian Kellner <ckellner@openismus.com>
386 * src/modest-search.c: (modest_search):
387 Correctly set part_search_func even if we have already parsed
388 the query and thus a valid OgsTextSearcher object.
390 2007-05-30 Christian Kellner <ckellner@openismus.com>
393 Search and check for libogs.
396 Incooparte the ogs build env.
398 * src/modest-mime-part-search-stream.c:
399 * src/modest-mime-part-search-stream.h:
400 Removed since we do the real searching now in modest-search.c.
402 * src/modest-search.c:
403 * src/modest-search.h:
404 Implement support for ogs. We use that if available and requested
405 and fall back to modest_text_utils_utf8_strcmp (). The search logic
406 should now handle the corner case when the search term is spread
407 across multiple reads.
408 Also the logic in modest_search () was corrected to search all
409 requested fields until one is found.
411 2007-05-30 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
416 * src/modest-init.c: Made modest_init_local_folders() take a
417 path and be public so we can iniitialize maildir folders on
420 * src/modest-local-folder-info.h:
421 * src/modest-local-folder-info.c:
422 (modest_local_folder_info_get_maildir_path): Add a path parameter.
424 * src/modest-tny-account.c:
425 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
426 still means the standard local-folders path on the local volume.
428 * src/modest-tny-account-store.c:
429 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
430 signal so we can detect mount/unmount of the MMC1 card, and do an update of
431 all accounts when that happens.
432 (get_server_accounts): If the MMC1 card is mounted, create a store account for
433 this too, so it shows up in the treeview.
435 2007-05-28 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/modest-maemo-global-settings-dialog.c:
438 (current_connection):
439 * src/widgets/modest-global-settings-dialog.c:
440 (current_connection_default):
441 Use the enum values instead of 0, 1 and -1,
442 to make the code clearer.
444 * src/modest-account-mgr-helpers.c:
445 (modest_account_mgr_get_connection_specific_smtp): Make this code
448 * src/modest-runtime.h:
449 * src/modest-runtime.c:
450 Added modest_runtime_remove_all_send_queues().
451 * src/maemo/modest-main-window.c:
452 (on_account_store_connecting_finished): Recreate the send queues,
453 using the appropriate transport accounts for this new connection.
454 Some futher adapting might be needed if the old send queues are not
455 automatically stopped at this point.
457 * src/modest-tny-account-store.c: (get_server_accounts):
458 Create the connection-specific transport accounts, so that they can
459 be found later by their ID.
461 * src/modest-tny-account.h:
462 * src/modest-tny-account.c:
463 Added modest_tny_account_new_from_server_account_name().
464 modest_tny_account_new_from_server_account(): Do not create the
465 send queues here, because they will be
466 recreated anyway when the connection changes for the first time.
468 2007-05-28 Murray Cumming <murrayc@murrayc.com>
470 * src/modest-local-folder-info.h:
471 * src/modest-local-folder-info.c:
472 (modest_per_account_local_outbox_folder_info_get_maildir_path),
473 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
474 tbox_folder): Take a modest account name instead of a server TnyAccount,
475 so we can have per-modest-account rather than per-transport-account
477 We must make sure that we change or recreate the exisitng send queues
478 when the connection changes for connection-specific transport accounts.
480 * src/modest-tny-account-store.c:
481 (create_per_account_local_outbox_folders): Create outboxed per modest
482 account, not per transport account.
484 * src/modest-tny-account.h:
485 * src/modest-tny-account.c:
486 (modest_tny_account_get_special_folder): For outboxes, get the
487 parent modest account name. The account is ignored for other folders.
488 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
489 modest account name rather than a server TnyAccount.
491 2007-05-25 Murray Cumming <murrayc@murrayc.com>
493 * src/modest-tny-account.c:
494 (modest_tny_account_new_from_server_account):
495 Call modest_runtime_get_send_queue() immediately after creating transport
496 accounts, so that they start trying to send email from the outbox as soon
497 as possible at startup. This is probably what we want.
499 * src/modest-mail-operation.c: (update_account_thread):
500 * src/modest-runtime.c: (modest_runtime_get_send_queue):
501 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
502 * src/modest-tny-send-queue.h:
503 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
504 (modest_ui_actions_on_send):
505 Added comments about how sending works, though it needs some more work.
507 2007-05-25 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-tny-account.c:
510 (modest_tny_account_get_special_folder): Add TODO because this fails when
512 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
513 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
514 Do not try to show this window when there is no active account. The UI
515 specs does not tell us what to do in this case.
517 2007-05-24 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/Makefile.am:
522 * src/widgets/Makefile.am: Some dist fixes.
524 2007-05-24 Murray Cumming <murrayc@murrayc.com>
526 * src/maemo/modest-connection-specific-smtp-window.c:
527 (on_button_edit): Make the code clearer, to prevent a double free.
529 2007-05-24 Murray Cumming <murrayc@murrayc.com>
531 * src/maemo/modest-account-settings-dialog.c:
532 (modest_account_settings_dialog_set_account_name),
533 Check the connection-specific smtp servers checkbox if there are any.
535 * src/maemo/modest-connection-specific-smtp-edit-window.c:
536 (modest_connection_specific_smtp_edit_window_init):
537 Start with a suitable port number.
539 * src/modest-account-mgr-helpers.h:
540 * src/modest-account-mgr-helpers.c: Added
541 modest_account_mgr_get_has_connection_specific_smtp().
543 (modest_account_mgr_set_connection_specific_smtp),
544 (modest_account_mgr_remove_connection_specific_smtp),
545 (modest_account_mgr_get_has_connection_specific_smtp),
546 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
547 connection-specific smtp server accounts in the account, rather than
548 the server account conf dir.
550 This fixes bug projects.maemo.org bug NB#58263 .
552 * src/modest-tny-account-store.c:
553 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
554 if there are no server accounts yet, to prevent an infinite loop when there
555 are no accounts. Document that one must be called before the other.
557 2007-05-24 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-account-mgr-helpers.c:
560 (modest_account_mgr_get_default_account): Make sure that at least
561 one account is always the default, if there are any enabled accounts.
562 This is just a sanity check that shouldn't be necessary.
564 * src/modest-account-mgr-priv.c:
565 (_modest_account_mgr_account_from_key): Unescape the conf key to
566 get the real account name. For instance, this is an issue if a space
567 was in the account name, which can happen because the account name
568 is generated from the display name.
569 (_modest_account_mgr_get_account_keyname): Always escape the
571 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
572 Unescape the conf keys to get the real account names.
574 For instance, previously the is-default radio button in the accounts
575 list was not checked for any accounts at first. This fixes that,
576 and might fix several similar bugs.
578 2007-05-23 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
581 Removed some debug printfs.
583 2007-05-23 Murray Cumming <murrayc@murrayc.com>
585 Modest on-disk outbox directories are now here, for instance:
586 $HOME/.modest/outboxes/<account-id-1>/outbox
587 $HOME/.modest/outboxes/<account-id-2>/outbox
589 $HOME/.modest/local-folders/outbox
590 so we can have a separate outbox for each account.
591 But they are shown as one outbox in the GtkTreeView, by using a
592 TnyMergeFolder in a ModestTnySimpleFolderStore.
595 * src/modest-tny-simple-folder-store.c:
596 * src/modest-tny-simple-folder-store.h:
597 Added ModestTnySimpleFolderStore, used to contain folders from
598 other folder stores, such as other accounts.
600 * src/modest-tny-outbox-account.h:
601 * src/modest-tny-outbox-account.c:
602 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
603 used for the per-account local outbox folders.
605 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
606 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
607 only use this (internally) now for the non-outbox local folders.
610 * src/modest-init.c: Added modest_init_one_local_folder(), for
611 setting up the directory structure for each local folder.
613 * src/modest-local-folder-info.c:
614 (modest_per_account_local_outbox_folder_info_get_maildir_path),
615 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
617 * src/modest-local-folder-info.h:
618 * src/modest-tny-account-store.c: (on_account_removed),
619 (on_account_changed), (create_per_account_local_outbox_folders),
620 (get_server_accounts), (modest_tny_account_store_get_accounts),
621 (modest_tny_account_store_get_tny_account_by_account),
622 (modest_tny_folder_store_is_virtual_local_folders):
624 * src/modest-tny-account.h:
625 * src/modest-tny-account.c:
626 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
627 to create an on-disk per-account local outbox folder for each
629 (create_per_account_local_outbox_folders): Create a local outbox folder
630 for each transport account.
631 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
632 for all local folders.
634 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
635 instead of using g_object_get/set() directly. It is clearer.
637 (modest_tny_folder_store_get_message_count),
638 (modest_tny_folder_store_get_local_size
639 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
640 because we now use these with non-acount folder stores.
642 (modest_tny_account_get_special_folder),
643 (modest_tny_account_new_from_server_account),
644 (modest_tny_account_new_from_account):
645 (recurse_folders): Adjust to the new outbox system.
647 * src/modest-tny-folder.h:
648 * src/modest-tny-folder.c:
649 (modest_tny_folder_is_local_folder),
650 (modest_tny_folder_get_local_folder_type),
651 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
653 * src/widgets/modest-main-window.h:
654 * src/maemo/modest-main-window.c: (create_details_widget),
655 (modest_main_window_set_contents_style): Show details for any folder store,
658 (modest_tny_folder_get_rules):
659 Remove the const. C does not support constness enough for this.
661 * src/modest-ui-actions.c:
662 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
663 make all outboxes appear as one, in the usual local-folders tree node.
665 (set_active_account_from_tny_account),
666 (modest_ui_actions_on_folder_selection_changed):
667 * src/widgets/modest-folder-view.c: (text_cell_data),
668 (icon_cell_data), (filter_row),
669 (add_account_folders_to_merged_folder),
670 (add_account_folders_to_simple_folder_store), (),
671 (get_cmp_rows_type_pos), (cmp_rows),
672 (modest_folder_view_set_account_id_of_visible_server_account):
673 Adjust to the new outbox system, using generic folder stores and folders
676 2007-05-23 Christian Kellner <ckellner@openismus.com>
678 * src/modest-mail-operation.c:
679 (modest_mail_operation_update_account):
680 Use info->max_size instead of unintialized local var [small
681 build fix]. (Added TODO to review that change since I don't
684 2007-05-23 Marcus Bauer <marcusb@openismus.com>
686 * libmodest-dbus-client/libmodest-dbus-client.c:
687 (libmodest_dbus_client_compose_mail): function added
688 * src/dbus_api/modest-dbus-api.h:
689 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
690 (on_compose_mail): Implementation of the SendAsMail functionality
692 2007-05-22 Murray Cumming <murrayc@murrayc.com>
694 * src/modest-account-mgr.c:
695 (modest_account_mgr_add_server_account): Set the secure-connection
696 conf key for transport accounts as well as store accounts. I don't know
697 why the if was there. For instance, this makes sure that we use SSL
698 for the gmail preset from the easysetup wizard.
700 2007-05-22 Murray Cumming <murrayc@murrayc.com>
702 * src/gnome/modest-main-window.c:
703 (on_account_store_connecting_finished), (connect_signals):
704 * src/maemo/modest-main-window.c:
705 (on_account_store_connecting_finished), (connect_signals),
706 (modest_main_window_new):
707 Handle TnyAccountStore::connecting-finished instead of
708 TnyDevice::connection-changed, because we cannot actually perform
709 operations on accounts until TnyAccountStore has itself responded to
710 the TnyDevice::connection-changed signal. This prevents a GError from
712 Do not try to update at startup, because we (at least on scratchbox)
713 already do an update at startup when the device goes online.
714 This prevents a GError from tinymail.
715 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
716 Added TODO about stopping simultaneous operations.
718 2007-05-21 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
721 * src/modest-mail-operation-queue.c:
722 (modest_mail_operation_queue_remove):
723 * src/modest-tny-account-store.c: When GErrors happen, give more clues
724 about where they happened.
726 2007-05-21 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-ui-actions.c:
729 (modest_ui_actions_on_password_requested): Make sure that the remember
730 output parameter is always TRUE.
732 2007-05-21 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
735 Show a OK/Cancel dialog if the error is a question, though we still do not
736 know anything more about what we are asking the user.
737 * src/widgets/modest-folder-view.c: (on_drag_data_received):
738 Fix an uninitialized variable (helper). This is a logic error, however.
740 2007-05-21 Christian Kellner <ckellner@openismus.com>
742 * src/modest-search.h:
743 Correct bit shifting in the ModestSearchFlags enum.
745 2007-05-21 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-tny-account.c:
748 (modest_tny_account_new_from_server_account): Do not use the lsub and
749 check-all hard-coded IMAP options when using POP.
751 2007-05-21 Murray Cumming <murrayc@murrayc.com>
753 * src/modest-tny-account.c:
754 (modest_tny_account_new_from_server_account):
755 Use NULL for the secure-auth method for POP when Password auth has been
756 specified by the user, as we already do for IMAP. "auth=Login" causes
757 an error from camel or the server.
759 2007-05-17 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/modest-account-settings-dialog.c:
762 (create_page_account_details),
763 (modest_account_settings_dialog_set_account_name):
764 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
765 for the leave-on-server checkbox, rathr than just the checkbox, when
766 the protocol is not POP.
768 2007-05-17 Murray Cumming <murrayc@murrayc.com>
770 * src/widgets/modest-account-view.c:
771 * src/widgets/modest-account-view.h:
772 Added modest_account_view_select_account() which will be useful later
773 to asynchronously re-select the edited account.
775 2007-05-17 Murray Cumming <murrayc@murrayc.com>
777 * src/maemo/modest-account-settings-dialog.c:
778 (modest_account_settings_dialog_set_account_name):
779 Automatically choose the port numbers based on the secure authentication
780 methods, if they have not been chosen before.
781 This fixes projects.maemo.org bug NB#56273 .
783 2007-05-17 Murray Cumming <murrayc@murrayc.com>
785 * src/maemo/modest-main-window-ui.h:
786 * src/modest-ui-actions.c:
787 * src/modest-ui-actions.h:
788 Connect the Tools/SMTP Servers menu item to
789 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
790 SMTP servers dialog, as in the UI specification and saves changes when it
791 is closed. This fixed projects.maemo.org bug NB#56305 .
793 2007-05-17 Murray Cumming <murrayc@murrayc.com>
795 * src/maemo/modest-connection-specific-smtp-window.c:
796 (modest_connection_specific_smtp_window_init):
797 Use gtk_window_set_default_size() to make this window big enough, so
798 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
800 2007-05-17 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/modest-connection-specific-smtp-edit-window.h:
803 * src/maemo/modest-connection-specific-smtp-edit-window.c:
804 (modest_connection_specific_smtp_edit_window_init),
805 Do not try to connect to a combobox signal before the combobox exists.
806 This fixes the cras in projects.maemo.org bug NB#56288 .
807 (modest_connection_specific_smtp_edit_window_get_settings):
808 Remove the server_account_name parameter which was being checked for NULL
809 though it was not used.
811 * src/maemo/modest-connection-specific-smtp-window.c:
812 (modest_connection_specific_smtp_window_fill_with_connections),
813 (on_button_edit), (modest_connection_specific_smtp_window_init):
814 Correct the number of treemodel columns to prevent a warning.
815 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
816 libconic does not work.
818 2007-05-16 Murray Cumming <murrayc@murrayc.com>
820 * src/modest-tny-account.c:
821 (modest_tny_account_new_from_server_account):
822 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
823 SMTP when "None" was chosen by the user. However, with my SMTP server that
824 does not support ANONYMOUS, the emails do not leave the Outbox and I see
827 2007-05-16 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
830 to explain the memory management issue with the ID in the ModestPair.
832 * src/gnome/modest-account-assistant.c: (add_receiving_page),
833 (add_sending_page), (modest_account_assistant_finalize):
834 * src/gnome/modest-gnome-global-settings-dialog.c:
835 (create_updating_page), (create_composing_page):
836 * src/gnome/modest-msg-edit-window.c: (get_transports),
837 (init_window), (modest_msg_edit_window_finalize),
838 (modest_msg_edit_window_get_msg_data):
839 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
840 * src/gnome/modest-transport-widget.c:
841 (modest_transport_widget_finalize), (smtp_configuration):
842 * src/maemo/modest-maemo-global-settings-dialog.c:
843 (create_updating_page), (create_composing_page):
844 * src/maemo/modest-msg-edit-window.c: (get_transports),
845 (init_window), (modest_msg_edit_window_finalize),
846 (modest_msg_edit_window_get_msg_data),
847 (modest_msg_edit_window_free_msg_data):
848 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
849 (modest_store_widget_finalize):
850 * src/maemo/modest-transport-widget.c:
851 (modest_transport_widget_finalize), (smtp_configuration):
852 * src/modest-main.c: (send_mail):
853 * src/widgets/modest-combo-box.h:
854 * src/widgets/modest-global-settings-dialog-priv.h:
855 * src/widgets/modest-global-settings-dialog.c:
856 (modest_global_settings_dialog_finalize):
857 * src/widgets/modest-msg-edit-window.h:
858 Whenever using modest_combo_box_new(), keep the ModestPairList alive
859 as long as the combo box, to prevent use of freed memory for the ID.
861 2007-05-15 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
864 get_accounts(), to make this clearer. Do not check for the enabled gconf
865 key, because we do not use this for server accounts (at least, not yet).
866 This allows us to send email again.
868 2007-05-15 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/modest-platform.c:
871 (on_modest_conf_update_interval_changed), (modest_platform_init):
872 Only respond to this particular key change. All these strcmp()s cannot be
875 2007-05-15 Murray Cumming <murrayc@murrayc.com>
877 * src/maemo/modest-maemo-global-settings-dialog.c:
878 (current_connection): Prevent a crash in scratchbox when
879 ny_maemo_conic_device_get_current_iap_id() returns NULL.
880 * src/maemo/modest-platform.c:
881 (on_modest_conf_update_interval_changed), (modest_platform_init):
882 Get the update interval from gconf and reset it when the gconf key changes.
884 2007-05-15 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-protocol-info.c:
887 * src/modest-protocol-info.h: Adde enum-specific get functions,
888 instead of using a ModestProtocolType enum parameter.
890 * src/gnome/modest-account-assistant.c:
891 * src/gnome/modest-store-widget.c:
892 * src/gnome/modest-store-widget.h:
893 * src/gnome/modest-transport-widget.c:
894 * src/gnome/modest-transport-widget.h:
895 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
896 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
897 * src/maemo/easysetup/modest-easysetup-wizard.c:
898 * src/maemo/modest-account-settings-dialog.c:
899 * src/maemo/modest-account-settings-dialog.h:
900 * src/maemo/modest-store-widget.c:
901 * src/maemo/modest-store-widget.h:
902 * src/maemo/modest-transport-widget.c:
903 * src/maemo/modest-transport-widget.h:
904 * src/modest-account-mgr-helpers.c:
905 * src/modest-account-mgr-helpers.h:
906 * src/modest-account-mgr.c:
907 * src/modest-account-mgr.h:
908 * src/modest-tny-account.c:
909 * src/modest-tny-folder.c:
910 * src/widgets/modest-account-view.c:
911 * src/widgets/modest-retrieve-combo-box.c:
912 * src/widgets/modest-retrieve-combo-box.h:
913 * src/widgets/modest-secureauth-combo-box.c:
914 * src/widgets/modest-serversecurity-combo-box.c:
915 * src/widgets/modest-serversecurity-combo-box.h:
916 * tests/check_account-mgr.c:
917 Use the specific functions, and use the re-renamed enum values for GNOME too.
919 2007-05-15 Murray Cumming <murrayc@murrayc.com>
922 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
923 so we can get the second based on the first.
925 * src/maemo/modest-account-settings-dialog.h:
926 * src/maemo/modest-account-settings-dialog.c:
927 Added get_supported_secure_authentication_methods(), though it is mostly
928 commented-out for now until the necessary API is committed to tinymail.
929 (modest_account_settings_dialog_set_account_name),
930 (save_configuration): Request the supported authentication methods from the
931 server, so we can choose a working method.
933 * src/modest-tny-account-store.h:
934 * src/modest-tny-account-store.c:
935 (modest_tny_account_store_get_session): Rename from
936 tny_account_store_get_session().
938 2007-05-14 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-protocol-info.h: Split the ModestProtocol enum
941 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
942 There was no need to have these unrelated values in one enum.
944 * src/: many files: Adapted to changed enum. This makes the code a bit
945 clearer, and the compiler could catch some errors.
947 2007-05-14 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
950 Show the detailed internal camel error message when an error happens
951 during the configuration, so that our testers can give us more clues.
952 For instance, in projects.maemo.org bug NB#56910 .
954 2007-05-14 Murray Cumming <murrayc@murrayc.com>
956 * src/modest-tny-account.c:
957 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
958 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
960 2007-05-14 Murray Cumming <murrayc@murrayc.com>
962 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
963 * src/maemo/modest-account-settings-dialog.c:
964 (modest_account_settings_dialog_set_account_name),
965 (save_configuration): For the incoming secure authentication checkbox,
966 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
967 the UI specification. PLAIN does not seem to be supported for most IMAP
968 servers anyway, and I am not sure what it would mean.
969 However, we probably need to discover which of the secure-authentication
970 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
971 * src/modest-account-mgr-helpers.c:
972 (modest_account_mgr_get_server_account_data):
974 * src/modest-tny-account.c:
975 (modest_tny_account_new_from_server_account):
976 Use tny_account_set_mech() to set secure-authentication methods,
977 with some special-casing for IMAP, based on my observations of how
980 * src/modest-account-mgr-helpers.h:
981 * src/modest-account-mgr.c:
982 * src/modest-defs.h: Comment that the URI is only used for local folders.
984 2007-05-11 Murray Cumming <murrayc@murrayc.com>
986 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
987 parameter const, just to be neat.
988 * src/modest-text-utils.c: (modest_text_utils_inline):
989 End g_strconcat() with NULL, as its documentation says. This is almost
990 certainly the cause of my crash at startup on the device. Interestingly,
991 valgrind doesn't tell us about these errors.
993 2007-05-11 Murray Cumming <murrayc@murrayc.com>
995 * scripts/build-packages: Added more precise comments about how to use
996 this script, though I still get this error:
997 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
998 error building tinymail
1000 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1002 * src/maemo/modest-main-window.c: (on_account_update):
1003 Very slight cleanup, hoping to make it simpler to discover what causes
1004 a crash here sometimes.
1006 * src/modest-tny-account.c:
1007 (modest_tny_account_new_from_server_account): Set the port. Added
1008 comments about the options and a TODO comment because I need to find out
1009 how to specify the secure authentication method.
1011 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1013 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1014 changed CFlags paths form modest to libmodest
1016 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-account-mgr-helpers.c:
1019 (modest_account_mgr_get_server_account_data),
1020 (modest_account_mgr_free_server_account_data):
1021 * src/modest-account-mgr-helpers.h:
1022 * src/modest-account-mgr.c:
1023 (modest_account_mgr_add_server_account):
1024 * src/modest-defs.h:
1025 * src/modest-tny-account.c:
1026 (modest_tny_account_new_from_server_account):
1027 Determine the options for tny_camel_account_add_option() here,
1028 based on the settings, rather than storing them directly in gconf.
1030 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1033 Show a more friendly error dialog now that we expect (from the tinymail
1034 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1036 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1038 * src/maemo/modest-main-window.c: (on_account_update): Check that
1039 account_name is not NULL, to prevent a crash at startup that I am
1040 seeing on the N800. I do wonder why it is NULL.
1042 * src/maemo/easysetup/modest-easysetup-wizard.c:
1043 (create_page_user_details):
1044 * src/maemo/modest-account-settings-dialog.c:
1045 (create_page_user_details), (create_page_outgoing):
1046 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1047 (modest_connection_specific_smtp_edit_window_init):
1048 * src/modest-ui-actions.c:
1049 (modest_ui_actions_on_password_requested):
1050 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1051 might do something useful with the on-screen keyboard.
1053 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1055 * src/maemo/modest-main-window.c: (on_account_update):
1056 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1057 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1059 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-tny-account-store.c: (on_account_changed):
1062 Correct the signature of this signal handler.
1064 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1066 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1067 Show a HildonNote instead of a GtkDialog for Maemo.
1069 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1071 * src/widgets/modest-account-view.h:
1072 * src/widgets/modest-account-view.c: (on_account_changed),
1073 (on_account_removed). Added a boolean flag, set/unset by
1074 modest_account_view_block_conf_updates(),
1075 modest_account_view_unblock_conf_updates() to prevent unnecessary
1076 updates, but this is not very useful because the gconf notifications are
1077 so delays (maybe only on Maemo Bora).
1078 So auto-updating is turned off, and these functions do an explicit
1079 update when necessary.
1080 However, something else is still doing too much work when adding/removing
1081 accounts, probably in another part of the application.
1083 * src/maemo/modest-account-view-window.c:
1084 (on_delete_button_clicked), (on_edit_button_clicked),
1085 (on_new_button_clicked): Use the new functions.
1087 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1089 * src/modest-account-mgr-helpers.c:
1090 (modest_account_mgr_set_first_account_as_default):
1091 Sort the list of names alphabetically-by-title, so we choose the first one
1093 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1094 alphabetically by the title.
1096 This fixes projects.maemo.org bug NB#56418 .
1098 * src/modest-account-mgr-priv.c:
1099 (_modest_account_mgr_account_from_key):
1100 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1101 avoid a valgrind error, and possible random behaviour.
1103 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1106 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1107 tinymail documentation to say that this can be expected.
1108 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1109 pretty, and should not happen, but I would prefer to know when it does.
1111 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1113 * configure.ac: When using the older hildon version, probably on Bora,
1114 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1116 * src/widgets/modest-attachment-view.c:
1117 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1120 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1122 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1123 Implemented the prototype. Can be tested with
1124 tests/dbus_api/test_open_message:
1126 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-tny-account-store.c:
1129 (modest_tny_account_store_instance_init), (get_password):
1130 * src/modest-ui-actions.c:
1131 (modest_ui_actions_on_password_requested):
1132 Do not store the password in gconf, because this function is called
1133 for non-remembered passwords. Actually use the cached (in the hash map)
1134 password instead of releasing it.
1135 The password will now not be remembered if it is asked via the protected
1136 password dialog, as per the UI spec.
1138 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-defs.h:
1141 * src/modest-account-mgr-helpers.h:
1142 * src/modest-account-mgr-helpers.c:
1143 Added modest_server_account_get_username_has_succeeded(),
1144 modest_server_account_set_username_has_succeeded().
1145 (modest_server_account_set_username),
1146 Reset the has-succeeded flag if the username changes.
1148 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1149 * src/maemo/modest-connection-specific-smtp-window.c:
1150 (modest_connection_specific_smtp_window_save_server_accounts):
1151 Use modest_server_account_set_username() instead of using
1152 modest_conf_set_string() directly, so that the has-succeeded flag is always
1155 * src/modest-ui-actions.c:
1156 (modest_ui_actions_on_password_requested): Dim the username entry if
1157 the username has ever worked, as per the UI spec.
1159 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-tny-account-store.c: (get_password):
1162 * src/modest-ui-actions.c:
1163 (modest_ui_actions_on_password_requested):
1164 Allow the username to be changed too, though there is more work to
1165 be done on exactly how this behaves.
1167 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1169 * src/modest-account-mgr-helpers.h:
1170 * src/modest-account-mgr-helpers.c:
1171 Added modest_account_mgr_get_display_name(),
1172 modest_server_account_get_username(),
1173 modest_server_account_set_username(),
1174 modest_server_account_set_password(),
1175 modest_server_account_get_hostname() functions so we do not need to
1176 use the conf API directly.
1178 * src/maemo/modest-main-window.c: (connect_signals):
1179 Actually connect ot the ModestAccountStore::request-password signal,
1180 so that we show the dialog when the password is requested by Tinymail,
1181 for isntance if it is empty.
1183 * src/modest-marshal.list:
1184 * src/modest-tny-account-store.c:
1185 (modest_tny_account_store_class_init), (get_password),
1186 (modest_tny_account_store_alert):
1187 * src/modest-tny-account-store.h:
1188 * src/modest-ui-actions.h:
1189 * src/modest-ui-actions.c:
1190 (modest_ui_actions_on_password_requested):
1191 Change the signal parameters, so it is obvious that we are providing
1192 the non human-readable server name, and receiving both the username
1193 and password, though changing of the username is not yet implemented.
1194 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1195 for the GNOME version.
1197 This should fix the projects.maemo.org bug NB#56209, though it does not
1198 work on Bora, because the gconf_client_get() for the password fails
1199 immediately after we save it with gconf_client_set().
1201 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1204 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1205 caused an undefined symbol error:
1206 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1208 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-tny-account-store.c:
1211 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1212 using a GError instead of a string message, so we can translate it in
1215 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1217 * src/maemo/modest-address-book.c:
1218 (modest_address_book_check_names):
1219 * src/maemo/modest-msg-view-window.c:
1220 (modest_msg_view_window_clipboard_owner_change):
1221 * src/modest-init.c: (modest_init_init_ui):
1222 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1223 (update_folders_cb), (modest_mail_operation_update_account):
1224 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1225 (modest_ui_actions_on_msg_attachment_clicked),
1226 (modest_ui_actions_on_msg_recpt_activated):
1227 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1228 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1229 (modest_msg_view_search_next):
1230 * src/widgets/modest-recpt-editor.c:
1231 (modest_recpt_editor_on_button_release_event),
1232 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1233 g_message(). At this point we should only be seeing interesting errors on
1234 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1236 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1238 (modest_wizard_dialog_force_title_update):
1239 * src/maemo/easysetup/modest-wizard-dialog.h:
1240 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1241 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1242 can update the title when appropriate. Otherwise the title is wrong if the
1243 pages are added after adding the notebook to the dialog.
1244 This must be a problem in HildonWizardDialog too.
1245 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1247 * src/maemo/easysetup/modest-easysetup-wizard.c:
1248 (create_subsequent_customsetup_pages),
1249 (create_subsequent_easysetup_pages):
1250 Call modest_wizard_dialog_force_title_update() so that the title is
1251 correct even with GTK+ < 2.10.
1252 This fixes projects.maemo.org bug NB#56145 .
1254 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1256 * src/maemo/modest-platform.c:
1257 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1258 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1261 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1263 * src/widgets/modest-window.h:
1264 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1265 and modest_window_save_state(), which invokes it.
1267 * src/widgets/modest-window-mgr.h:
1268 * src/widgets/modest-window-mgr.c:
1269 Added modest_window_mgr_save_state_for_all_windows(), which calls
1270 the save_state vfunc on all registered windows, if implemented.
1272 * src/gnome/modest-msg-edit-window.c:
1273 * src/gnome/modest-msg-view-window.c:
1274 * src/maemo/modest-msg-edit-window.c:
1275 * src/maemo/modest-msg-view-window.c:
1276 * src/maemo/modest-main-window.c:
1277 Specify the existing save_settings functions as implementations of
1278 ModestWindow::save_state_func().
1280 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1281 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1282 enabling hibernation, for instance.
1284 We may need to do the same thing for restoring settings.
1287 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1289 * src/widgets/modest-window-mgr.c:
1290 * src/widgets/modest-window-mgr.h:
1291 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1292 modest_window_mgr_get_hibernation_is_prevented().
1294 * src/maemo/modest-main-window.c:
1295 (on_hildon_program_is_topmost_notify): Prevent hibernation
1296 (possible when the application goes to the background in the WM),
1297 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1299 * src/maemo/easysetup/modest-easysetup-wizard.c:
1300 (modest_easysetup_wizard_dialog_init):
1301 * src/maemo/modest-account-settings-dialog.c:
1302 (modest_account_settings_dialog_init):
1303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1304 (modest_connection_specific_smtp_edit_window_init):
1305 * src/maemo/modest-connection-specific-smtp-window.c:
1306 (modest_connection_specific_smtp_window_init):
1307 * src/maemo/modest-signature-editor-dialog.c:
1308 (modest_signature_editor_dialog_init):
1309 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1310 prevent hibernation while any of these account settings dialogs are open.
1312 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1314 * src/maemo/Makefile.am:
1315 * src/maemo/modest-osso-state-saving.c:
1316 * src/maemo/modest-osso-state-saving.h: Added
1317 modest_osso_load_state() and modest_osso_save_state() though they do
1318 nothing now. They should iterate through all the open windows and load/save
1320 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1321 save state when closing.
1323 * src/maemo/modest-main-window.c:
1324 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1325 Add a notification handler for the HildonProgram::is-topmost property,
1326 so we can allow hibernation when the application goes into the background.
1327 But we still need to detect when the accounts setup windows are open so
1328 we can stop hibernation when they are open.
1329 To do this, I also added the main window the HildonProgram. This might have
1330 other side-effects/benefits, and should maybe be done for other windows.
1332 * src/maemo/modest-osso-autosave-callbacks.h:
1333 * src/maemo/modest-osso-autosave-callbacks.c:
1334 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1335 though it does not do anything yet, and we might never need this to do
1336 anything. For instance, we already save drafts.
1338 * src/maemo/modest-platform.c: (modest_platform_init):
1339 Specify the libosso auto-save callback.
1341 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1343 * src/maemo/modest-platform.c:
1344 (modest_platform_set_update_interval):
1345 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1346 aparently stays valid between application instances, so we can use this
1347 to remove and reset it later. According to a maemo-developers email from
1350 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1352 * configure.ac: Depend on libalarm for Maemo.
1354 * src/dbus_api/modest-dbus-api.h:
1355 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1356 (on_send_receive), (modest_dbus_req_handler):
1357 Handle a SEND_RECEIVE D-Bus method.
1359 * libmodest-dbus-client/libmodest-dbus-client.c:
1360 (libmodest_dbus_client_send_and_receive):
1361 * libmodest-dbus-client/libmodest-dbus-client.h:
1362 Add C convenience functions for calling the new D-Bus method.
1364 * src/modest-platform.h:
1365 * src/gnome/modest-platform.c:
1366 * src/maemo/modest-platform.c:
1367 Added modest_platform_set_update_interval(), which uses the
1368 alarmd API on Maemo.
1369 (modest_platform_init),
1370 Call modest_platform_set_update_interval(), using a hard-coded
1371 interval for now (until the global settings dialog is implemented),
1372 though I am not sure that this makes sense yet.
1374 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1376 * src/dbus_api/modest-dbus-callbacks.c:
1377 (modest_osso_cb_hw_state_handler):
1378 * src/dbus_api/modest-dbus-callbacks.h:
1379 * src/maemo/modest-platform.c: (modest_platform_init):
1380 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1381 in case this has some effect on the ability for Maemo to ping the
1384 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1387 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1388 warning. It is probably a logic error, but I need to fix the build.
1390 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1392 * src/modest-account-mgr.h:
1393 * src/modest-account-mgr.c:
1394 (modest_account_mgr_account_names): Add a gboolean enabled_only
1395 parameter, so we can get lists of onlt the enabled accounts.
1397 (modest_account_mgr_add_account),,
1398 (modest_account_mgr_account_with_display_name_exists):
1399 * src/maemo/modest-msg-edit-window.c: (get_transports):
1400 * src/modest-account-mgr-helpers.c:
1401 (modest_account_mgr_set_first_account_as_default):
1402 * src/modest-init.c: (init_default_account_maybe):
1403 * src/modest-tny-account-store.c: (get_accounts):
1404 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1405 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1406 * tests/check_account-mgr.c: (START_TEST):
1407 Provide the extra parameter, as appropriate.
1409 * src/widgets/modest-account-view.c: (update_account_view):
1410 Do not show disabled accounts (meaning that there is no way to
1411 enable/disable accounts in the UI (the feature is not in our UI
1412 specification), so we can use this internally only to mark unfinished
1413 or temporary account data.
1415 * src/maemo/easysetup/modest-easysetup-wizard.c:
1416 (create_account): Add boolean enable parameter, so we can specify FALSE
1417 to create the temporary account.
1418 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1419 (on_before_next): When finishing, when there is a temporary account, just
1421 Also, use a timeout to delay the showing of the dialog until gconf is likely
1422 to return correct information, due to a maemo gconf bug that is fixed in
1423 osso 1.1, but not yet in Bora.
1424 However, the dialog stays on screen after it is destroyed.
1426 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1427 for invalid data when cancelling. Use a hildon note instead of a dialog
1428 to complain about invalid data. Do not show the account-saved note if the
1429 account is disabled (a temporary account that will not really be saved for use
1432 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1434 * src/modest-account-mgr-helpers.h:
1435 * src/modest-account-mgr-helpers.c:
1436 Added modest_account_mgr_unset_default_account(),
1437 Added modest_account_mgr_set_first_account_as_default().
1439 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1440 If it was the default account, unset the default account name.
1442 * src/maemo/modest-account-view-window.c:
1443 (on_delete_button_clicked): If it was the default account,
1444 set the first remaining account as the default instead.
1446 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1447 a NULL account or a NULL default account, to prevent a crash. This should
1448 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1451 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1453 * src/widgets/modest-recpt-editor.c:
1454 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1455 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1456 TODO comment for this. This fixes the build.
1458 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1459 be the best place for it. This will in future update all auto-update accounts,
1460 rather than just the current/default account, when that gconf key exists.
1461 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1462 if there are no accounts, before calling do_send_receive().
1463 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1465 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1466 * src/maemo/modest-main-window-ui.h:
1467 * src/maemo/modest-main-window.c: (on_connection_changed),
1468 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1469 directly, becaue the signal handler does more.
1471 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-account-mgr-helpers.c:
1474 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1475 for the case that the account does not exist.
1477 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1478 (equivalent to the modest account name) rather than the tinymail account name
1479 (equivalent to the modest account title - human readable) to get the account data.
1480 Check for null account data to prevent the crash, and add a TODO comment saying that
1481 this needs fixing because it is using the server account name instead of the account name.
1483 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1485 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1486 * src/maemo/modest-account-settings-dialog.c: (show_error),
1488 Use hildon_note_new_information() for informative and error messages,
1489 which seems to be expected for Maemo applications (no documentation that I know of
1490 says this). I am surprised that there is no distinction between info and error
1493 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1495 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1496 it is easy to find where this is used.
1498 * src/maemo/easysetup/modest-easysetup-wizard.c:
1499 (create_page_welcome), (create_page_account_details),
1500 (create_page_user_details), (create_page_complete_easysetup),
1501 (create_page_custom_incoming), (create_page_custom_outgoing),
1502 (create_page_complete_custom):
1503 * src/maemo/modest-account-settings-dialog.c:
1504 (create_page_account_details), (create_page_user_details),
1505 (create_page_incoming), (create_page_outgoing):
1506 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1508 (modest_connection_specific_smtp_edit_window_init):
1509 * src/maemo/modest-connection-specific-smtp-window.c:
1510 (modest_connection_specific_smtp_window_init):
1511 * src/maemo/modest-signature-editor-dialog.c:
1512 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1513 and scrolling policy as per the Email Application Layout Guide, if I have
1516 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1518 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1519 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1520 which were empty, because these vfuncs have been removed from TnyAccountStore.
1521 This fixes the build.
1523 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1525 * src/maemo/modest-main-window.c:
1526 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1527 showing/hiding it. Added TODO because it probably should not be NULL.
1528 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1529 because unnecessary g_warnings() make degugging difficult.
1531 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1533 * src/maemo/modest-msg-edit-window.c:
1534 (modest_msg_edit_window_select_color),
1535 (modest_msg_edit_window_select_background_color): 2 const corrections and
1536 moving 2 #endifs before closing brackets, to fix the build.
1538 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/easysetup/modest-easysetup-wizard.h:
1541 * src/maemo/easysetup/modest-easysetup-wizard.c:
1542 (modest_easysetup_wizard_dialog_finalize),
1543 (on_button_edit_advanced_settings), (create_page_complete_custom),
1544 (on_response), (create_account):
1545 Implement the Advanced Settings edit button, by saving the account information,
1546 for the Advanded Settings dialog to use directly from gconf, and removing it
1547 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1548 Bug #5533 in the projects.maemo.org bugzilla.
1550 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-msg-view-window.c:
1553 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1554 when opening a message window.
1556 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1558 * src/maemo/easysetup/modest-easysetup-wizard.c:
1559 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1562 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1563 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1564 gconf settings. I probably added more checks than necessary, but that is safer.
1566 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1567 variable to fix the build, but this seems to be used when it is still NULL.
1569 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-platform.h:
1572 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1573 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1574 * src/modest-main.c: Implement this function so we can avoid using
1575 maemo-specific API from cross-platform code.
1577 * src/modest-tny-account-store.c:
1578 (get_smtp_specific_transport_account_for_open_connection):
1579 * src/modest-ui-actions.c: (check_for_connection),
1580 (modest_ui_actions_on_item_not_found):
1581 Use modest_platform_connect_and_wait() and put #idefs around other
1582 maemo-specific code, because only maemo currently has a way to
1583 identify connection names.
1585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-tny-account-store.h:
1588 * src/modest-tny-account-store.c:
1589 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1590 the connection-specific SMTP server settings in the configuration.
1592 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1594 * src/maemo/modest-main-window.c: (on_connection_changed),
1596 * src/modest-main.c: (main), (start_ui), (send_mail):
1597 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1598 that is what is intended.
1600 * src/modest-ui-actions.c: (action_send), (action_receive),
1601 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1602 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1603 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1604 SMTP server is used when it is specified.
1606 (modest_ui_actions_on_send_receive):
1607 Check that a connection is open before proceeding.
1608 Receive and then send, instead of vice-versa, as per the specification.
1610 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-mail-operation.c:
1613 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1614 though I guess it should be something other than NULL.
1616 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/easysetup/modest-easysetup-wizard.c:
1619 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1620 combo twice, to avoid an g_warning and to make it visible again.
1621 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1622 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1623 (already intended) dereference when detaching, because we then recreate the menu.
1624 But I am not sure why the warning was happening, and it is possible that this is a memory
1627 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1629 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1630 and uri_parse_mailto() utility functions.
1631 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1633 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1635 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1637 * src/dbus_api/modest-dbus-api.h:
1638 * src/dbus_api/modest-dbus-callbacks.c:
1639 Use an idle callback to execute the modest code in the application's own thread.
1640 Remove the helloworld example method.
1641 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1642 parsed, and the open-message method is not implemented because this is not yet implemented in
1644 * libmodest-dbus-client/libmodest-dbus-client.c:
1645 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1646 (libmodest_dbus_client_open_message):
1647 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1649 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1650 body without crashing.
1652 * tests/dbus_api/Makefile.am:
1653 * tests/dbus_api/test_mail_to.c:
1654 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1656 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1658 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1659 Added file to fix the build. Sorry.
1661 * src/dbus_api/Makefile.am:
1662 * src/dbus_api/modest-dbus-api.h:
1663 * src/dbus_api/modest-dbus-callbacks.h:
1664 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1665 (modest_dbus_req_handler):
1666 Put constants in a separate header so it can be reused by the
1667 client library, without duplication
1669 * libmodest-dbus-client/Makefile.am:
1670 * libmodest-dbus-client/libmodest-dbus-client.c:
1671 (libmodest_dbus_client_call_helloworld),
1672 (libmodfest_dbus_client_send_mail),
1673 (libmodfest_dbus_client_mailto),
1674 (libmodfest_dbus_client_open_message):
1675 * libmodest-dbus-client/libmodest-dbus-client.h:
1676 (Partly) Implement a send_mail D-Bus method.
1678 * tests/dbus_api/Makefile.am:
1679 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1680 the send_email D-Bus method.
1682 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1686 * libmodest-dbus-client/Makefile.am:
1687 * libmodest-dbus-client/libmodest-dbus-client.c:
1688 * libmodest-dbus-client/libmodest-dbus-client.h:
1689 * tests/dbus_api/Makefile.am:
1690 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1691 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1693 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/easysetup/modest-easysetup-wizard.c:
1696 (create_page_account_details):
1697 * src/maemo/modest-account-settings-dialog.c:
1698 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1699 widgets, because this might not be the default in future versions of the Maemo GTK+.
1700 However, I can not not get capitalization to work even in a simple test case.
1702 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/easysetup/modest-easysetup-wizard.c:
1705 (create_page_custom_incoming), (create_page_custom_outgoing):
1706 * src/maemo/modest-account-settings-dialog.c:
1707 (create_page_account_details), (create_page_incoming),
1708 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1709 instead of using gtk_check_button_with_label(), so they are aligned like the other
1710 widgets, as per the UI spec.
1712 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1714 * src/maemo/easysetup/modest-easysetup-wizard.c:
1715 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1716 * src/widgets/modest-validating-entry.c:
1717 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1718 Modest prefix instead of an EasySetup prefix.
1720 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1722 * src/widgets/modest-validating-entry.h:
1723 * src/widgets/modest-validating-entry.c: (on_insert_text),
1724 Added easysetup_validating_entry_set_max_func(), used to set a callback
1725 to call when the max number of characters is reached. GtkEntry has a max-length
1726 already but is silent about it.
1728 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1729 (create_page_account_details), (create_page_user_details),
1731 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1732 (create_page_account_details), (create_page_user_details),
1733 (create_page_outgoing):
1734 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1735 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1736 the UI spec, when the user tries to enter more than the max number of characters.
1738 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/easysetup/modest-easysetup-wizard.c:
1741 (create_page_user_details), (create_page_custom_incoming),
1742 (create_page_custom_outgoing):
1743 * src/maemo/modest-account-settings-dialog.c:
1744 (create_page_user_details), (create_page_incoming),
1745 (create_page_outgoing):
1746 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1747 (modest_connection_specific_smtp_edit_window_init):
1748 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1749 not appropriate. Bad Maemo-specific defaults!.
1751 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1754 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1755 (modest_signature_editor_dialog_set_settings):
1756 Disable the label and textview when the checkbox is disabled, and use the
1757 specified (UI spec) default signature text.
1759 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1761 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1762 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1764 * src/modest-defs.h:
1765 * src/modest-account-mgr-helpers.h:
1766 * src/modest-account-mgr-helpers.c:
1767 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1769 * src/maemo/Makefile.am:
1770 * src/maemo/modest-signature-editor-dialog.c:
1771 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1774 * src/maemo/modest-account-settings-dialog.h:
1775 * src/maemo/modest-account-settings-dialog.c:
1776 (modest_account_settings_dialog_finalize), (on_button_signature),
1777 (save_configuration): Use the new dialog when the Edit button is pressed, and
1778 save the changes if necessary, as per the UI spec.
1780 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/Makefile.am:
1783 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1784 based on maemo-develoers email from Dirk.
1786 * src/maemo/easysetup/modest-easysetup-wizard.c:
1787 (create_page_welcome), (create_page_account_details),
1788 (create_page_user_details), (create_page_complete_easysetup),
1789 (create_page_custom_incoming), (create_page_custom_outgoing),
1790 (create_page_complete_custom),
1791 (modest_easysetup_wizard_dialog_init):
1792 * src/maemo/modest-account-settings-dialog.c:
1793 (create_page_account_details), (create_page_user_details),
1794 (create_page_incoming), (create_page_outgoing),
1795 (modest_account_settings_dialog_init):
1796 * src/maemo/modest-connection-specific-smtp-window.c:
1797 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1799 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1801 * src/maemo/easysetup/modest-easysetup-wizard.c:
1802 (create_page_account_details), (create_page_custom_outgoing),
1803 (create_page_complete_custom):
1804 * src/maemo/modest-account-settings-dialog.c:
1805 (create_page_user_details), (create_page_incoming),
1806 (create_page_outgoing):
1807 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1808 (modest_connection_specific_smtp_edit_window_init):
1809 Use the correct (UI spec) port min/max, and use horizontal separators,
1812 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c:
1815 (set_default_custom_servernames):
1816 * src/maemo/modest-account-settings-dialog.c:
1817 (create_page_incoming), (on_combo_outgoing_security_changed),
1818 (on_combo_incoming_security_changed), (create_page_outgoing),
1819 (modest_account_settings_dialog_set_account_name),
1820 (save_configuration):
1821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1822 (on_combo_security_changed),
1823 (modest_connection_specific_smtp_edit_window_init),
1824 (modest_connection_specific_smtp_edit_window_set_connection),
1825 (modest_connection_specific_smtp_edit_window_get_settings):
1826 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1829 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1832 * src/maemo/easysetup/modest-easysetup-wizard.c:
1833 (create_page_custom_outgoing), (create_page_complete_custom):
1834 * src/maemo/modest-account-settings-dialog.c:
1835 (create_page_user_details), (create_page_outgoing):
1836 * src/maemo/modest-account-view-window.c: (button_box_new):
1837 Use changed logical IDs as per the most recent UI spec:
1838 mcen_bd_emailsetup_edit -> mcen_bd_edit
1839 mcen_bd_emailsetup_delete -> mcen_bd_delete
1840 mcen_bd_emailsetup_close -> mcen_bd_close
1842 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1846 * src/dbus_api/Makefile.am:
1847 * src/dbus_api/modest-dbus-callbacks.c:
1848 * src/dbus_api/modest-dbus-callbacks.h:
1849 * src/maemo/modest-platform.c: (modest_platform_init):
1850 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1852 * tests/Makefile.am:
1853 * tests/dbus_api/Makefile.am:
1854 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1856 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/modest-account-settings-dialog.c:
1859 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1860 Removed unnecessary includes.
1862 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1864 * src/maemo/easysetup/modest-easysetup-wizard.c:
1865 * src/maemo/modest-account-settings-dialog.c:
1866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1867 * src/widgets/Makefile.am:
1868 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1869 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1870 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1871 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1872 * src/widgets/modest-secureauth-combo-box.c:
1873 * src/widgets/modest-secureauth-combo-box.h:
1874 * src/widgets/modest-serversecurity-combo-box.c:
1875 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1876 made the GObject names more consistent with the rest of the Modest code.
1878 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1880 * src/maemo/easysetup/Makefile.am:
1881 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1882 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1883 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1884 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1885 * src/maemo/easysetup/modest-easysetup-wizard.c:
1886 * src/maemo/easysetup/modest-validating-entry.c:
1887 * src/maemo/easysetup/modest-validating-entry.h:
1888 * src/maemo/modest-account-settings-dialog.c:
1889 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1890 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1891 widgets/ because they are used outside of easysetup too. After checking in,
1892 svn will allow me to rename them too.
1894 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1896 * src/gnome/modest-msg-edit-window.c:
1897 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1898 linker error, to fix the build on the GNOME platform.
1899 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1900 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1901 ifdefed out to avoid a warning.
1903 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1905 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1906 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1907 some alternative for GTK+ 2.6.
1909 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1913 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1914 specified for EmailAccountsDialog in UI spec.
1916 * src/maemo/easysetup/modest-easysetup-wizard.c:
1917 * src/maemo/easysetup/modest-easysetup-wizard.h:
1918 * src/maemo/modest-account-settings-dialog.c:
1919 * src/maemo/modest-account-settings-dialog.h:
1920 Reuse a member window widget for the connection-specific SMTP server accounts,
1921 so we can tell it to create/save the accounts only if we actually save changes.
1923 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1924 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1925 (modest_connection_specific_smtp_edit_window_get_settings):
1926 Return a struct instance for temporarily remembering the entered data.
1928 * src/maemo/modest-connection-specific-smtp-window.h:
1929 * src/maemo/modest-connection-specific-smtp-window.c:
1930 (modest_connection_specific_smtp_window_finalize),
1931 (modest_connection_specific_smtp_window_fill_with_connections),
1933 (modest_connection_specific_smtp_window_save_server_accounts),
1934 (update_model_server_names): Do not actually save data until asked,
1935 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1937 (on_selection_changed),
1938 (modest_connection_specific_smtp_window_init): Disable the edit
1939 button when nothing is selected.
1941 * src/modest-account-mgr-helpers.c:
1942 * src/modest-account-mgr-helpers.h:
1943 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1946 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1948 * src/modest-account-mgr-helpers.h:
1949 * src/modest-account-mgr-helpers.c:
1950 (modest_account_mgr_get_unused_account_name),
1951 (modest_account_mgr_get_unused_account_display_name): Added these
1952 utility functions, to avoid code duplication.
1954 * src/maemo/easysetup/modest-easysetup-wizard.c:
1955 (create_page_account_details), (create_account):
1956 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1957 (on_combo_security_changed),
1958 (modest_connection_specific_smtp_edit_window_init),
1959 (modest_connection_specific_smtp_edit_window_save_settings):
1960 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1961 * src/maemo/modest-connection-specific-smtp-window.c:
1962 (modest_connection_specific_smtp_window_finalize),
1963 (modest_connection_specific_smtp_window_fill_with_connections),
1964 (on_button_edit), (modest_connection_specific_smtp_window_init):
1965 * src/maemo/modest-connection-specific-smtp-window.h:
1966 Implementing saving of connection-specific server accounts.
1968 But I need to refactor this so we can save the data for each
1969 possible connection-specific account and only actually create the server accounts
1970 when the easysetup finished, or the OK button is pressed on the account settings
1973 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1976 (on_combo_security_changed):
1977 (modest_connection_specific_smtp_edit_window_init):
1978 Auto-fill the port number as in the account settings.
1980 (modest_connection_specific_smtp_edit_window_set_connection):
1981 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1982 * src/maemo/modest-connection-specific-smtp-window.c:
1983 (fill_with_connections), (on_button_edit),
1984 (modest_connection_specific_smtp_window_init):
1985 Turn the edit window into a dialog to simplify the code, and
1986 set a WM hint as in a GtkDialog, because only a popup can be on top of
1987 another window in Maemo, and popups usually have no WM decoration.
1989 * src/modest-defs.h:
1990 * src/modest-account-mgr-helpers.c:
1991 (modest_account_mgr_set_connection_specific_smtp),
1992 (modest_account_mgr_remove_connection_specific_smtp),
1993 (modest_account_mgr_get_connection_specific_smtp):
1994 * src/modest-account-mgr-helpers.h: Some functions to write the
1995 connection-specific SMTP server information. Not yet used.
1998 * src/widgets/modest-folder-view.c: (text_cell_data):
1999 Fix a warning about an uninitialized variable.
2000 (on_configuration_key_changed): Put an #ifdef around the use
2001 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2003 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2005 * src/maemo/modest-account-settings-dialog.h:
2006 * src/maemo/modest-account-settings-dialog.c:
2007 Added connect_for_modified() utility function to mark the new modified boolean.
2009 (create_page_account_details), (create_page_user_details),
2010 (create_page_incoming), (create_page_outgoing), (on_response),
2011 (modest_account_settings_dialog_init),
2012 (modest_account_settings_dialog_set_account_name):
2013 Only warn about unsaved changes when there are actually unsaved changes.
2015 * src/modest-account-mgr-helpers.c:
2016 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2017 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2018 to get the data from there in future.
2020 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2022 * src/modest-defs.h:
2024 * src/modest-account-mgr-helpers.h:
2025 * src/modest-account-mgr-helpers.c:
2026 Store the security account setting in a single conf key instead of using
2027 the options list, so that the list is left for just the to-be-removed camel hack,
2028 and because gconf_client_set_list() is failing for some reason.
2030 * src/modest-account-mgr.c:
2031 (modest_account_mgr_add_server_account):
2032 * src/maemo/modest-account-settings-dialog.c:
2033 (modest_account_settings_dialog_set_account_name),
2034 (save_configuration): Use the renamed functions.
2037 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2039 * src/widgets/Makefile.am:
2040 * src/widgets/modest-limit-retrieve-combo-box.c:
2041 * src/widgets/modest-limit-retrieve-combo-box.h:
2042 * src/widgets/modest-retrieve-combo-box.c:
2043 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2044 the account settings dialog.
2046 * src/modest-defs.h:
2047 * src/modest-account-mgr-helpers.h:
2048 * src/modest-account-mgr-helpers.c:
2049 (modest_server_account_get_option_secure_auth),
2050 (modest_server_account_set_option_secure_auth):
2051 * src/modest-account-mgr.c:
2052 (modest_account_mgr_add_server_account):
2053 Use the existing AUTH_MECH conf key for the secure-auth setting,
2054 instead of putting it in the list options, because this was actually used already.
2056 * src/maemo/modest-account-settings-dialog.c:
2057 (create_page_account_details),
2058 (modest_account_settings_dialog_set_account_name),
2059 (save_configuration):
2060 * src/maemo/modest-account-settings-dialog.h:
2061 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2062 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2064 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2066 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2067 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2068 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2070 * src/modest-defs.h:
2071 * src/maemo/modest-account-settings-dialog.c:
2072 (create_page_incoming), (on_combo_outgoing_security_changed),
2073 (on_combo_incoming_security_changed), (create_page_outgoing),
2074 (modest_account_settings_dialog_set_account_name),
2075 (save_configuration): Load/Save the port number, and change it when the
2076 security combo changes, to suitable defaults.
2078 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2080 * src/modest-account-mgr.c:
2081 (modest_account_mgr_add_server_account): Set the security and secure-auth
2082 options, and add a comment saying that the other camel-specific options should be
2085 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2087 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2089 * src/modest-tny-account-store.c: (account_list_free),
2090 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2091 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2094 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2096 * src/modest-protocol-info.c:
2097 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2098 is required by our UI spec. Maybe something in our implementation will use this eventually.
2099 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2100 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2101 instead of the previous 0 placeholder.
2103 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2104 secure-auth settings.
2105 * src/modest-account-mgr-helpers.h:
2106 * src/modest-account-mgr-helpers.c:
2107 (modest_server_account_data_get_option_secure_auth),
2108 (modest_server_account_set_option_secure_auth),
2109 (modest_server_account_data_get_option_security),
2110 (modest_server_account_set_option_security): Added this API for getting and setting the security
2111 and secure-auth settings.
2113 * src/maemo/modest-account-settings-dialog.h:
2114 * src/maemo/modest-account-settings-dialog.c:
2115 (modest_account_settings_dialog_finalize), (check_data),
2116 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2117 about changing titles.
2118 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2119 (save_configuration): Save the security and secure-auth settings.
2121 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2122 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2124 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2126 * src/modest-defs.h:
2127 * src/modest-account-mgr.c:
2128 (modest_account_mgr_add_server_account):
2129 Added and used defines for the options key and value pair strings,
2130 that are used so far, though they do not seem to correspond to anything in our
2131 UI specs or ModestProtocol enum.
2133 * src/modest-account-mgr-helpers.h:
2134 * src/modest-account-mgr-helpers.c:
2135 (compare_option_strings_for_name),
2136 (modest_server_account_data_get_option_value),
2137 (modest_server_account_data_get_option_bool),
2138 (modest_account_mgr_get_server_account_option):
2139 Added helper functions for parsing the options GSList.
2141 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2143 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2144 display name is based on the supplied account name.
2145 * src/modest-account-mgr.c:
2146 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2147 with an inefficient, but good-enough, implementation.
2149 * src/maemo/easysetup/modest-easysetup-wizard.c:
2150 (create_page_account_details), (on_before_next), (create_account):
2151 Check for existing display names rather than (non-user-visible) account names, and just
2152 create and set a unique account name at the end.
2154 * src/maemo/modest-account-settings-dialog.c:
2155 (modest_account_settings_dialog_init),
2156 (modest_account_settings_dialog_set_account_name),
2157 (create_page_incoming): Show the display name, instead of the account name.
2158 (on_response): Do some (not all) extra checks, as in the UI spec.
2159 (save_configuration): Save the display name if it was changed.
2161 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2163 * po/en_GB.po: Added needed logical ID and translation.
2164 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2165 (init_view): Made the is-default column clicking work.
2167 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2170 * src/maemo/easysetup/Makefile.am:
2171 * src/maemo/easysetup/modest-easysetup-wizard.c:
2172 (modest_easysetup_wizard_dialog_init):
2173 * src/maemo/easysetup/provider-data-test.keyfile:
2174 * src/maemo/easysetup/provider-data.keyfile:
2175 Moved the provider data file to the new modest-providers-data package and used it from there.
2177 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2179 * src/modest-local-folder-info.c:
2180 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2181 N_() was already used on the static strings, but this just marks it for translation without
2182 using the translation.
2184 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/modest-account-settings-dialog.c:
2187 (create_page_incoming),
2188 (modest_account_settings_dialog_set_account_name):
2189 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2190 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2191 I will do this if nobody else gets there first.
2193 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2195 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2196 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2197 save the security stuff.
2199 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2201 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2202 Set the email address and user fullname, which I now see must be
2205 * src/maemo/modest-account-settings-dialog.h:
2206 * src/maemo/modest-account-settings-dialog.c:
2208 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2209 leave-on-server and authentication.
2210 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2213 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2216 * src/maemo/modest-account-settings-dialog.c:
2217 * src/maemo/modest-account-settings-dialog.h:
2218 Most (but not all) of the widgets are now present as specified by the UI spec.
2219 No changes are yet saved, and some details are not properly shown yet.
2221 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2223 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2225 * src/maemo/Makefile.am:
2226 * src/maemo/modest-account-settings-dialog.c:
2227 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2228 an existing account. Doesn't do much yet.
2230 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2231 Open the accounts settings dialog when Edit is clicked.
2233 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/easysetup/Makefile.am:
2236 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2238 * src/maemo/easysetup/modest-easysetup-wizard.c:
2239 (modest_easysetup_wizard_dialog_init):
2240 Try to get the source directory from the build system,
2241 instead of hard-coding "./" into the source code, when opening our local
2242 copies of the configuration files.
2243 But this still fails when opening the wizard from the Accounts window,
2244 maybe because the working directory seems to change at runtime.
2245 So the wizard will fail the second time unless you copy the files into their
2246 proper locations - see the stdout warnings for the paths.
2248 (create_page_account_details),(on_before_next):
2249 Check for existing non-server accounts instead of server accounts,
2250 so the default account name is useful again, and to prevent trying to
2253 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2254 Show the wizard when New is clicked.
2256 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2257 (init_view): Show the column headers, and show the columns that are
2258 specified in the UI specs. However, something in Maemo's GTK+ prevents
2259 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2260 change the default account. This is despite unsetting the special properties.
2262 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2264 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2265 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2266 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2267 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2268 to make that clearer.
2269 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2271 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2273 * src/maemo/modest-account-view-window.c:
2274 (modest_account_view_window_init),
2275 (modest_account_view_window_new):
2276 Use the same buttons as specified in the
2277 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2278 the existing widgets, which never had a chance of working.
2279 Put the ModestAccountView treeview in a scrolled window.
2280 Do not repeat the initialization in both _init() and _new().
2282 * src/widgets/modest-account-view.c: (update_account_view):
2283 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2284 this widget and window shows no accounts.
2286 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2288 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2290 * src/maemo/easysetup/modest-easysetup-wizard.c:
2291 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2292 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2293 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2296 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2297 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2298 accounts exist yet, as in the UI spec.
2300 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2302 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2304 * src/maemo/Makefile.am:
2305 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2306 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2307 New window for editing connection-specific smtp details.
2308 Not fully implemented.
2310 * src/maemo/modest-connection-specific-smtp-window.c:
2311 (modest_connection_specific_smtp_window_finalize) :
2312 unref the tree model.
2313 (on_button_edit): Show the edit window.
2315 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2317 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2320 * src/maemo/Makefile.am:
2321 * src/maemo/modest-connection-specific-smtp-window.c:
2322 * src/maemo/modest-connection-specific-smtp-window.h:
2323 New window for showing the list of connections, for connection-specific
2324 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2325 * src/maemo/easysetup/modest-easysetup-wizard.c:
2326 (create_page_custom_outgoing): Show the new window when the button is clicked.
2328 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2330 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2331 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2332 * src/maemo/modest-msg-edit-window.c:
2333 (modest_msg_edit_window_insert_image):
2334 * src/modest-conf.c: (modest_conf_key_escape):
2335 * src/modest-mail-operation.c:
2336 (modest_mail_operation_send_new_mail):
2337 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2338 (modest_ui_actions_on_new_account):
2339 * src/widgets/modest-attachment-view.c: (update_filename_request):
2340 * src/widgets/modest-mail-header-view.c:
2341 Corrected warnings that were breaking the build, by commenting out unused variables,
2342 and a function, and by including a header.
2344 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2346 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2347 so we can #ifdef around platform-specific code when necessary.
2348 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2349 to allow this to build for the GNOME platform too.
2351 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/easysetup/modest-easysetup-wizard.c:
2354 Added util_increment_name() and used it in create_page_account_details()
2355 to make sure that the default account name is always a new name.
2357 (modest_easysetup_wizard_dialog_init),
2358 (set_default_custom_servernames): Some minor memory management fixes.
2360 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-runtime.c: (init_i18n): Restored the translation
2365 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2366 are defined in config.h, and the translations are installed.
2368 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2369 is defined for translation.
2371 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2373 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2375 * src/maemo/easysetup/modest-easysetup-wizard.c:
2376 (modest_easysetup_wizard_dialog_init):
2377 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2378 Use realistic paths (though they should use $prefix generically) to the
2379 mcc_mapping and provider-data.keyfile files which might work when they
2380 are installed by the future version of the operator-wizard package,
2381 and then fallback to paths in our source code, with an explanatory
2384 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2388 * src/maemo/Makefile.am:
2389 * src/maemo/easysetup/: Added files from the previously-exernal
2390 osso-modest-easysetup.
2391 * src/maemo/modest-main-window-ui.h:
2392 * src/modest-ui-actions.c:
2393 * src/modest-ui-actions.h:
2394 Added modest_ui_actions_on_new_account() as a signal handler for the
2395 New Account menu item. It shows the easysetup wizard.
2396 * po/en_GB.po: Added additional needed logical IDs and translations.
2398 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2399 Apparently ChangeLog is not used for some vague Nokia legal reasons.