1 2007-08-28 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: (on_timeout_check_account_is_online),
4 (check_and_wait_for_account_is_online):
5 It is OK for local-folder and mmc accounts to be used when they
6 are in the _INIT folder, instead of waiting for them to change
8 For POP and IMAP, wait from them to stop being _INIT, rather than
9 waiting from them to be _CONNECTED, because that seems to be
10 the status that causes the problems.
12 2007-08-28 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-search.c: (check_and_wait_for_account_is_online):
15 Actually pass the account to the timeout callback.
17 2007-08-28 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-search.c: (on_timeout_check_account_is_online):
20 Added some debug output to help me debug a problem on the N800.
21 (check_and_wait_for_account_is_online): Fail immediately if the
23 modest_search_all_accounts(): Try the search even if the account does
24 not seem to be online, because this can work sometimes, and should work
25 with the cache if there is no active libconic connection.
27 2007-08-27 Armin Burgmeier <armin@openismus.com>
29 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
30 observe outbox for added messages to assign them a status. Previously,
31 this was done in modest_tny_send_queue_add(), but the message id might
32 not yet be known at that point. This reduces warnings when sending
33 mail, though I am not sure how this even worked before.
35 2007-08-27 Murray Cumming <murrayc@murrayc.com>
37 * src/maemo/modest-account-settings-dialog.c:
38 (modest_account_settings_dialog_init):
39 * src/maemo/modest-connection-specific-smtp-edit-window.c:
40 (modest_connection_specific_smtp_edit_window_init):
41 * src/maemo/modest-connection-specific-smtp-window.c:
42 (modest_connection_specific_smtp_window_init):
43 * src/maemo/modest-maemo-utils.c:
44 (modest_maemo_utils_get_supported_secure_authentication_methods):
45 * src/maemo/modest-platform.c:
46 (modest_platform_run_folder_name_dialog):
47 * src/maemo/modest-signature-editor-dialog.c:
48 (modest_signature_editor_dialog_init):
49 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
50 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
51 * src/widgets/modest-global-settings-dialog.c:
52 (modest_global_settings_dialog_init):
53 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
55 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
56 GTK_STOCK_EDIT with mcen_bd_edit, and
57 GTK_STOCK_CLOSE with mcen_bd_close,
58 to fix projects.maemo.org bug NB#64995.
59 I strongly believe that Maemo's GTK+ should have the wanted translations
60 instead of duplicating this in each application and complicating the code.
62 2007-08-27 Armin Burgmeier <armin@openismus.com>
64 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
65 recursion when entering text in the subject field.
67 2007-08-27 Murray Cumming <murrayc@murrayc.com>
69 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
70 which checks every second, 10 times, to wait until the account is online
71 so that we can use it, if the account is in the process of going online.
72 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
73 so that searching works even when the application was not yet started before.
74 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
76 2007-08-24 Armin Burgmeier <armin@openismus.com>
78 * src/modest-widget-memory.c: Always show the default account when the
79 application is started, as stated in the UI spec. This fixes
80 projects.maemo.org bug NB#66630.
82 2007-08-24 Armin Burgmeier <armin@openismus.com>
84 * src/maemo/modest-platform.c:
85 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
86 english text for strings in the rename folder dialog, fixing
87 projects.maemo.org bug NB#66338.
89 2007-08-22 Armin Burgmeier <armin@openismus.com>
91 * src/widgets/modest-account-view.c: Fix for bora by using
92 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
93 latter seems not be used anymore.
95 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
98 * src/maemo/modest-main-window.c: Update menu items when the default
99 account changes so that the current default account is always bolded.
100 This fixes maemo.projects.org bug NB#66173.
102 2007-08-17 Murray Cumming <murrayc@murrayc.com>
104 * src/dbus_api/modest-dbus-callbacks.c:
105 (on_dbus_method_get_folders): Avoid trying to get the account name
106 when there are no accounts, to avoid critical g_warnings, fixing
107 projects.maemo.org bug NB#65574.
109 2007-08-17 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
112 Use modest_account_mgr_get_signature() instead of accessing gconf
113 directly, to slightly simplify the code.
114 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
115 Append the signature also when opening via other applications,
116 fixing projects.maemo.org bug NB#65828.
118 2007-08-17 Murray Cumming <murrayc@murrayc.com>
120 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
121 Check for NULLs to prevent a crash when opening an email that is
122 an attachment in another email, fixing projects.maemo.org bug
125 2007-08-17 Murray Cumming <murrayc@murrayc.com>
127 * src/modest-ui-dimming-rules.c:
128 (modest_ui_dimming_rules_on_view_window_move_to):
129 Enable the Move To toolbar button for search results, fixing the
130 last part of projects.maemo.org bug NB#63807.
132 2007-08-17 Murray Cumming <murrayc@murrayc.com>
134 * src/dbus_api/modest-dbus-callbacks.c:
135 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
136 because this is called from idle handlers, to fix hangs afte the
138 (find_message_by_url): Added a TODO comment about a crash that
139 happens when tinymail was built with DBC checks.
141 2007-08-16 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-search.c: (modest_search_folder):
144 * src/modest-search.h: Rename ModestSearch::before to start_date
145 and after to end_date, using the same names as the libogs struct
147 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
148 The start_date and end_date were swapped in the check. This
149 fixes date range searches, fixing projects.maemo.org bug NB#63407.
151 2007-08-16 Murray Cumming <murrayc@murrayc.com>
153 * src/maemo/modest-account-view-window.c:
154 Added (check_for_active_acount).
155 (on_delete_button_clicked), (on_edit_button_clicked):
156 When an account is doing something (such as refreshing),
157 show the same warning for account deletion as for account
158 editing, to fix projects.maemo.org bug NB#64588.
160 2007-08-16 Murray Cumming <murrayc@murrayc.com>
162 * src/widgets/modest-msg-view-window.h:
163 * src/gnome/modest-msg-view-window.c:
164 * src/maemo/modest-msg-view-window.c:
165 Added modest_msg_view_window_construct().
166 (modest_msg_view_window_new_with_header_model),
167 Added modest_msg_view_window_new_for_search_result),
168 Renamed modest_msg_view_window_new() to
169 modest_msg_view_window_new_for_attachment(),
170 and modest_msg_view_window_is_search_result(),
171 so we can explicitly know that the window is for an
172 attachment or a search result or a message from the list.
174 (modest_msg_view_window_view_attachment):
175 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
176 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
177 Use modest_msg_view_window_new_for_search_result().
179 * src/modest-ui-dimming-rules.c:
180 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
181 for search results, fixing projects.maemo.org bug NB#63811.
183 2007-08-16 Armin Burgmeier <armin@openismus.com>
185 * src/modest-ui-actions.c: Show a banner instead of a dialog when
186 renaming a folder fails, to stay consistent with what happens when
187 creating a folder fails.
189 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
190 slightly country loading from the mmc_mappings file, fixed a memory
193 2007-08-16 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-tny-account-store.c: (volume_path_is_mounted):
196 Check the GnomeVFSVolume activation path instead of the device path,
197 so that the memory card is really really shown in the UI.
199 2007-08-16 Murray Cumming <murrayc@murrayc.com>
201 * src/maemo/easysetup/modest-easysetup-wizard.c:
202 (get_entered_account_title), (on_before_next), (entry_is_empty),
204 * src/maemo/modest-account-settings-dialog.c:
205 (get_entered_account_title), (on_button_signature), (check_data),
206 (save_configuration), (entry_is_empty):
207 Strip the account title of whitespace at the start and end before
208 using it or checking it. This means that an all-whitespace title
209 is not allowed, fixing projects.maemo.org bug NB#64977.
211 2007-08-15 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-ui-actions.h:
214 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
215 to modest_run_account_setup_wizard() and made it public.
216 * src/dbus_api/modest-dbus-callbacks.c:
217 (check_and_offer_account_creation), (on_idle_mail_to),
218 (on_idle_compose_mail), (on_idle_open_default_inbox):
219 Offer account creation if necessary, fixing projects.maemo.org
222 2007-08-15 Murray Cumming <murrayc@murrayc.com>
224 * src/modest-ui-actions.c: (run_account_setup_wizard):
225 Return a gboolean to indicate success.
226 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
227 (modest_ui_actions_on_send): When offering account creation, only
228 give up (return) if account creation failed. Otherwise continue
229 with the original request. This fixed projects.maemo.org bug
232 2007-08-15 Murray Cumming <murrayc@murrayc.com>
234 * src/widgets/modest-recpt-editor.c:
235 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
236 to fix projects.maemo.org bug NB#63789.
238 2007-08-15 Murray Cumming <murrayc@murrayc.com>
240 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
241 (modest_tny_account_store_new): Properly detect the memory card at
242 startup, and add an account for it.
244 2007-08-14 Murray Cumming <murrayc@murrayc.com>
246 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
247 Commented out the MMC code again because it mistakenly detects
248 the card even when it isn't inserted.
250 2007-08-14 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
253 Renabled the call to add_mmc_account() because I do not believe
254 it could be the cause of the mentioned hang (in scratchbox, where
255 there is no memory card), and because I have tested that it works
258 2007-08-14 Murray Cumming <murrayc@murrayc.com>
260 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
261 Comment out part of the last commit because it apparently causes
264 2007-08-14 Murray Cumming <murrayc@murrayc.com>
266 * src/modest-tny-account-store.c: Added the add_mmc_account()
267 function to save some copy/pasting.
268 (modest_tny_account_store_new): If the memory card is mounted,
269 create an account for it at the start, instead of waiting for the
270 user to unmount it and mount it.
272 2007-08-13 Murray Cumming <murrayc@murrayc.com>
274 * src/widgets/modest-account-view.c: (on_account_changed):
275 Do not try to use the human-readable TnyAccount name instead of the
276 ID of the modest account to get the transport account. And unref
277 the transport account. This prevents a g_warning(), and a possible
280 2007-08-13 Murray Cumming <murrayc@murrayc.com>
282 * src/maemo/modest-platform.c:
283 (modest_platform_set_update_interval): Handle the new
284 alarmd error to warn when alarmd is not running, as is the case in
285 scratchbox for me now because
286 "Module /usr/lib/alarmd/libretu.so initialization failed"
288 2007-08-13 Murray Cumming <murrayc@murrayc.com>
290 * src/widgets/modest-header-view-render.c:
291 (_modest_header_view_compact_header_cell_data):
292 NULL some strings after freeing them, trying to deal with
293 the double deletion found in projects.maemo.org bug 64183,
294 probably having no effect.
296 2007-08-13 Murray Cumming <murrayc@murrayc.com>
298 * src/maemo/modest-account-settings-dialog.c:
299 (create_page_incoming), (create_page_outgoing): Use a define
300 for the min and max port numbers.
302 (check_hildon_number_editor_and_warn_value_not_in_range),
303 (check_data): Do an extra check for an invalid port number, as needed
304 in projects.maemo.org bug #64275, when the number is cleared, but this
305 does not work due to bugs.maemo.org bug #1806.
307 2007-08-13 Murray Cumming <murrayc@murrayc.com>
309 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
310 Comment out the debug warning about the unexpected D-Bus methods.
311 They are just annoying now.
312 * src/maemo/modest-platform.c:
313 (modest_platform_set_update_interval): Correct the D-Bus path, instead
314 of using a file path, though it did not seem to break things before.
315 It might be needed now:
316 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
317 modest is not already running. This is the behaviour of the old client, and
318 Mox says it is what we should do for modest.
319 This closes projects.maemo.org bug NB#64327.
321 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
323 * src/modest-text-utils.c:
324 Fixed invalid jump due to incorrect string/pointer
326 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
329 2007-08-01 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-account-mgr-helpers.h:
332 * src/modest-account-mgr-helpers.c:
333 Added modest_account_mgr_get_first_account_name(),
334 using code from modest_account_mgr_set_first_account_as_default().
336 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
337 (account_number_changed): Call set_at_least_one_account_visible() so that
338 the first account is visible when first added, without the user having to
340 I do wonder how this worked before.
342 2007-08-01 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-tny-account-store.c: (show_password_warning_only),
345 (show_wrong_password), (request_password_and_wait), (get_password),
346 (modest_tny_account_store_alert): Remove the (incomplete anyway)
347 attempts to show UI only in the main context, which used g_idle_add()
348 and mainloops, because tinymail now guarantees that it only calls these
349 callbacks in the mainloop with the gdk lock. This makes everything much
352 2007-08-01 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
355 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
356 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
357 error dialog, instead of ignoring it.
359 2007-08-01 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/modest-msg-view-window.c:
362 (modest_msg_view_window_get_header),
363 (modest_msg_view_window_last_message_selected):
364 Added comments to explain the use of priv->header_model.
365 * src/modest-ui-dimming-rules.c:
366 (modest_ui_dimming_rules_on_open_msg),
367 (modest_ui_dimming_rules_on_mark_as_read_msg),
368 (modest_ui_dimming_rules_on_mark_as_unread_msg),
369 (modest_ui_dimming_rules_on_remove_attachments),
370 (_invalid_attach_selected), (_selected_msg_marked_as):
371 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
372 and changed the parameter to a ModestMainWindow to make it clearer that
373 it never uses any other kind of window.
374 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
375 instead of the selected message.
376 I notice that much of the dimming code and the ModestMsgViewWindow code
377 hard-codes the assumption that the viewed message is always selected in
378 the header view. This does not seem wise or simple.
380 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
381 examine the actual message instead of whatever might be selected
382 in the header view. This stops the delete toolbar button and menu item
383 from being dimmed when opening a message view the search UI,
384 partially fixing projects.maemo.org bug NB#63811.
386 However, when actually deleting, I now get this warning:
387 "tny_header_set_flags: This is a header instance for a new message.
388 Only priority and attachment flags are supported"
390 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
392 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
394 Show account wizard if no accounts are defined while sending
395 (automatic sending after the account wizard finished does not
396 work because it takes some time until the account manager
397 synchronizes everything. (projects.maemo.org NB#62792)
399 2007-07-30 Murray Cumming <murrayc@murrayc.com>
401 * src/modest-tny-account-store.c: (on_account_removed),
402 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
403 account is removed from the View menu. We have TnyAccountStore
404 and ModestTnyAccountStore signals that seem very similar, but this
405 seems to work for now.
407 * src/maemo/modest-main-window.c:
408 (on_show_account_action_activated): Prevent dereference
409 of a NULL if the accoutn does not really exist, though that
410 should not happen anymore.
412 This fixes projects.maemo.org bug NB#64606.
414 2007-07-30 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-ui-actions.c: (run_account_setup_wizard),
417 (modest_ui_actions_on_accounts): Revert a change that set these
418 to modal dialogs, freezing the UI when they show secondary dialogs.
419 This fixed projects.maemo.org bug NB#64519.
421 2007-07-27 Murray Cumming <murrayc@murrayc.com>
423 * src/widgets/modest-header-view-render.c:
424 (_modest_header_view_compact_header_cell_data):
425 Some checks and initialization to try to deal with a crash,
426 probably ineffective.
428 2007-07-27 Murray Cumming <murrayc@murrayc.com>
430 * src/maemo/modest-maemo-utils.c:
431 (modest_maemo_utils_get_supported_secure_authentication_methods):
432 Make sure that we have a connection, asking the user for one
434 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
435 Check for a connection before showing the wizard, because
436 the wizard needs a connection to check for server capabilities.
438 2007-07-27 Murray Cumming <murrayc@murrayc.com>
440 * src/maemo/modest-account-view-window.c:
441 (on_new_button_clicked): Remember the wizard dialog instance,
442 so we can just present it again if necessary. This prevents
443 multiple windows from appearing if you click again quickly on the
444 New button before the dialog appears, fixing projects.maemo.org
447 2007-07-27 Murray Cumming <murrayc@murrayc.com>
449 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
450 Offer a connection dialog if there is no connection when
451 starting modest. This should fix projects.maemo.org bug NB#61134.
453 2007-07-27 Murray Cumming <murrayc@murrayc.com>
455 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
456 Reverted my last commit. I was able to fix the build by doing
457 apt-get install wpeditor0 (replacing other wpeditor packages) and
458 an explicit apt-get install wpeditor-dev to upgrade the -dev
461 2007-07-27 Murray Cumming <murrayc@murrayc.com>
463 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
464 Commented out the use of wp_text_buffer_replace_image()
465 because it does not exist, to break the build. Added a TODO for it.
467 2007-07-26 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-tny-account-store.c: (recreate_all_accounts):
470 Recreate them even if they were NULL before. I guess something
471 else was already creating them before, or this would never
473 (modest_tny_account_store_get_server_account): Make sure that
474 the tny accounts have been created before trying to find one.
475 This allows libmodest_dbus_client_compose_mail() to work
476 when the UI is not yet visible.
477 This is probably useful in other cases too.
479 (get_password): When the password is wrong after it is entered
480 in the protected password dialog, show an info banner (in an
481 idle handler) before showing the protected password dialog
484 2007-07-26 Murray Cumming <murrayc@murrayc.com>
486 * src/modest-ui-actions.h:
487 * src/modest-ui-actions.c: Added
488 modest_do_refresh_current_folder() containing some code from
489 modest_ui_actions_on_send_receive().
490 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
491 Call modest_do_refresh_current_folder() before refreshing the
492 requested account, as in modest_ui_actions_on_send_receive().
493 This is strange, but seems to be necessary to show new mails.
494 Now new emails are finally visible in the UI when downloaded
495 via the automatic update interval, fixing bug NB#57458.
496 This also works because bug NB#57458 has been fixed somehow.
498 2007-07-26 Murray Cumming <murrayc@murrayc.com>
500 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
501 printf more details when we get unhandled D-Bus methods, because
504 * src/modest-mail-operation.c: (update_account_thread):
505 Comment out the tny_camel_pop_store_account_reconnect(), because this
506 is apparently no longer needed, and it did not work before anyway.
507 See the comment in the code.
509 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
510 by checking the header flags. This fixes projects.maemo.org bug
513 2007-07-25 Murray Cumming <murrayc@murrayc.com>
515 * src/maemo/modest-maemo-utils.h:
516 * src/maemo/modest-maemo-utils.c: Added
517 modest_maemo_show_information_note_in_main_context_and_forget().
518 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
519 Use the new function to show simple error dialogs in the main
520 context, though question dialogs are still in the current context,
521 which is unfortunately usually not the main context. This should
524 2007-07-25 Murray Cumming <murrayc@murrayc.com>
526 * src/modest-tny-account-store.c: (get_password):
527 Never save the entered username and password in gconf,
528 because the UI spec says we should not. This helps
529 slightly with projects.maemo.org bug NB#63671.
531 2007-07-25 Murray Cumming <murrayc@murrayc.com>
533 * src/widgets/modest-msg-edit-window.h:
534 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
535 Moved some code here to make it simpler.
536 (modest_msg_edit_window_attach_file_one): Renamed from
537 modest_msg_edit_window_attach_file_interactive().
538 (modest_msg_edit_window_offer_attach_file): Renamed from
539 modest_msg_edit_window_attach_file() and used
540 modest_msg_edit_window_attach_file_one() instead of
541 copy/pasting the code. The old code for one was not using
542 GnomeVFS. This allows use of smb:// URLs when using send-as
543 from external applications, fixing bug NB#63741.
545 (modest_msg_edit_window_insert_image),
546 (modest_msg_edit_window_add_attachment_clicked):
547 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
548 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
549 Adapted to the new function names.
551 2007-07-25 Murray Cumming <murrayc@murrayc.com>
553 (modest_platform_set_update_interval): Set the alarm recurrence
554 fields so that auto-update does not just happen the first time.
555 This should have fixed projects.maemo.org bug NB#63938.
557 When this happens you can see a printf when the D-Bus method is
559 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
561 However, I do not actually seem to get new POP messages even when
562 clicking the refresh button manually. A restart gets them.
563 This might be a problem in today's tinymail only.
565 2007-07-24 Murray Cumming <murrayc@murrayc.com>
567 * src/maemo/modest-maemo-global-settings-dialog.c:
568 (current_connection):
569 Avoid a crash (probably only in scratchbox) when strcmp()ing a
570 NULL when closing the dialog.
572 2007-07-24 Murray Cumming <murrayc@murrayc.com>
574 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
575 Remove the hacky send/receive that didn't work, and instead
576 refilter the treemodel to make the deleted email really vanish from
577 the UI (though the delete-from-menu code does has commented out
578 the code that does that). This fixes projects.maemo.org bug
581 2007-07-24 Murray Cumming <murrayc@murrayc.com>
583 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
584 Try a couple of tricks to force the treeview to update (
585 poke the folder, and do a send/receive refresh), but the deleted
586 email still appears with a strike-through instead of really being
589 2007-07-23 Murray Cumming <murrayc@murrayc.com>
591 * src/dbus_api/modest-dbus-callbacks.c:
592 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
593 because their ID is not human-readable (see the comment about
594 improvements needed to the osso-email-interface API) and
595 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
597 2007-07-23 Murray Cumming <murrayc@murrayc.com>
599 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
600 (add_folders_to_list), (on_dbus_method_get_folders),
601 (modest_dbus_req_filter):
602 * src/maemo/modest-maemo-utils.c:
603 (on_camel_account_get_supported_secure_authentication):
604 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
605 (on_header_view_focus_in):
606 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
607 * src/modest-formatter.c: (modest_formatter_create_body_part):
608 * src/modest-mail-operation.c: (recurse_folders),
609 (update_account_thread), (get_msgs_full_thread),
610 (modest_mail_operation_get_msgs_full),
611 (modest_mail_operation_xfer_msgs):
612 * src/modest-search.c: (search_mime_part_and_child_parts),
613 (modest_search_account), (modest_search_all_accounts):
614 * src/modest-tny-account.c:
615 (modest_tny_account_get_special_folder), (recurse_folders):
616 * src/modest-tny-local-folders-account.c:
617 (modest_tny_local_folders_account_query_passes):
618 * src/modest-tny-msg.c: (copy_mime_part),
619 (modest_tny_msg_find_body_part_from_mime_part):
620 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
621 (modest_tny_send_queue_try_to_send):
622 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
623 (_modest_ui_actions_open), (download_uncached_messages),
624 (reply_forward), (modest_ui_actions_on_copy),
625 (modest_ui_actions_on_details), (has_retrieved_msgs),
626 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
628 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
629 (_selected_msg_marked_as), (_msg_download_completed),
630 (_selected_msg_sent_in_progress):
631 * src/widgets/modest-attachments-view.c:
632 (modest_attachments_view_set_message):
633 * src/widgets/modest-msg-view.c: (find_cid_image):
634 * tests/check_folder-transfer.c: (find_folders):
635 * tests/check_update-account.c: (func):
636 * tests/dbus_api/test_get_folders.c: (main):
637 Checked all uses of tny_iterator_get_current(), making sure
638 that the object is unreferenced (3 or 4 places did not),
639 and adding checks for NULL.
641 2007-07-23 Murray Cumming <murrayc@murrayc.com>
643 * src/dbus_api/modest-dbus-callbacks.c:
644 (on_idle_open_default_inbox): Make sure that the application UI is
646 * src/maemo/easysetup/modest-easysetup-wizard.c:
647 (on_entry_invalid_character): Show the word whitespace instead
648 of (null) in the banner when whitespace was entered.
649 (show_error): Add a comment that this does not work in
650 Maemo Bora, though we do not know why.
652 2007-07-23 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-tny-account.c:
655 (modest_tny_account_get_special_folder): Use an if instead of
656 an assert for when the parent account name is NULL, because this
657 might be causing a crash in projects.maemo.org bug 63192.
658 * src/modest-mail-operation.c:
659 (modest_mail_operation_send_new_mail_cb),
660 (modest_mail_operation_remove_folder): unref the folder that is
661 returned from modest_tny_account_get_special_folder().
663 2007-07-23 Murray Cumming <murrayc@murrayc.com>
665 * src/modest-ui-actions.c:
666 (modest_ui_actions_on_password_requested):
667 Show mail_ib_login_cancelled info banner when the user cancels
668 the protected password dialog, to fix projects.maemo.org
671 2007-07-23 Murray Cumming <murrayc@murrayc.com>
673 * src/maemo/modest-account-settings-dialog.c:
674 (create_page_outgoing): Put this page in a GtkScrolledWindow,
675 matching the UI mock-up in the UI spec, and allowing access
676 to all widgets even when the on-screen keyboard is active.
678 2007-07-23 Murray Cumming <murrayc@murrayc.com>
680 Reverted this previous commit from Johannes,
681 because the scrollbars are always visible and because
682 I think we only need it on onepage of the account
683 settings, not the account wizard.
684 (I wrote the wrong instructions in the bug.)
686 * src/maemo/easysetup/modest-easysetup-wizard.c:
687 Added scrollbars to account wizard dialog.
688 Fixed projects.maemo.org NB #62744
690 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
692 * src/maemo/easysetup/modest-easysetup-wizard.c:
693 (create_page_user_details):
694 Use auto-cap for name (projects.maemo.org NB#63716)
695 * src/widgets/modest-account-view.c: (on_account_busy_changed):
697 2007-07-22 Armin Burgmeier <armin@openismus.com>
699 * src/maemo/modest-ui-actions.c: Use current account instead of
700 default account for creating viewer windows, so that the viewer
701 window knows to which account the viewed message belongs.
703 * src/maemo/modest-msg-view-window.c: Destroy the window when the
704 corresponding account is deleted. This fixes projects.maemo.org bug
707 2007-07-18 Armin Burgmeier <armin@openismus.com>
709 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
710 the dialog close after entering an invalid port number and clicking
711 OK. This fixes projects.maemo.org bug NB#63602.
713 2007-07-18 Armin Burgmeier <armin@openismus.com>
715 * src/modest-tny-account-store.c:
716 (get_server_accounts): Set parent modest account name for each
717 connection-specific transport account so that special folders of such
718 an account can be looked up. This fixes a crash when changing account
719 settings. This might also be related to projects.maemo.org bug
722 2007-07-16 Armin Burgmeier <armin@openismus.com>
724 * src/modest-ui-actions.c: Added a button to create a folder to the
725 move-to dialog. This fixes projects.maemo.org bug NB#59863.
727 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
729 * src/maemo/easysetup/modest-easysetup-wizard.c:
730 Added scrollbars to account wizard dialog.
731 Fixed projects.maemo.org NB #62744
733 2007-07-16 Murray Cumming <murrayc@murrayc.com>
735 * src/widgets/modest-msg-view.h:
736 * src/widgets/modest-msg-view.c:
737 Added modest_msg_view_get_message_is_empty() but this needs
739 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
740 Check if there is any text in the message yet.
741 But this needs to be implemented properly.
742 (modest_msg_edit_window_toggle_find_toolbar):
743 * src/maemo/modest-msg-view-window.c:
744 (modest_msg_view_window_toggle_find_toolbar):
745 Show a banner warning if there is no text to search, when
746 trying to start a search. This partially fixes
747 projects.maemo.org bug NB#62350.
749 2007-07-13 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-mail-operation.c: (update_account_thread):
752 Initialized num_new_headers to fix the build.
754 2007-07-13 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
757 Ignore modest accounts whose server accounts don't exist in gconf.
758 This prevents us trying to create TnyAccount instances for those
759 server accounts when the server account has been removed from gconf,
760 but the parent modest account has not yet been removed from modest.
761 I don't know why this is only noticeable now. It was probably just
762 a harmeless g_warning() anyway.
764 2007-07-13 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
767 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
769 2007-07-12 Armin Burgmeier <armin@openismus.com>
771 * src/maemo/modest-main-window.c: Make default account appear bold
772 in view, tools/send & receive and toolbar/send & receive SCM menus.
773 This fixes projects.maemo.org bug NB#59010.
775 2007-07-12 Murray Cumming <murrayc@murrayc.com>
777 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
778 Add a short-cut, by checking if the folder store is an account.
779 This ensures that the Sort menu item and toolbar is dimmed for
780 the local-folders account root item, fixing
781 projects.maemo.org bug NB#62545.
783 2007-07-12 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account-store.c: (get_password):
786 Show the password dialog (via the signal) only in the mainloop, via
787 an idle handler that we wait for. This could theoretically prevent
788 hangs, though I worry that it could introduce some too.
790 2007-07-12 Murray Cumming <murrayc@murrayc.com>
792 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
793 * src/maemo/modest-platform.c:
794 (modest_platform_connect_and_wait):
795 Take a TnyAccount* parameter and try to set it to online
796 (a TnyCamel-only API), because tinymail sets accounts to offline
797 when the user cancels a password dialog, and doesn't ask again until
798 it has been set to online.
799 However, this is commented out because it causes a hang now.
801 (modest_platform_connect_and_wait_if_network_account):
802 * src/modest-mail-operation.c:
803 (modest_mail_operation_update_account):
804 * src/modest-platform.h:
805 * src/modest-ui-actions.c: (_modest_ui_actions_open),
806 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
808 2007-07-12 Armin Burgmeier <armin@openismus.com>
810 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
812 * src/modest-mail-operation.c:
813 * src/modest-ui-actions.c: Check for already existing folder before
814 querying the server, show error message from camel if the request
815 still fails. This fixes projects.maemo.org bug NB#58701.
817 2007-07-12 Murray Cumming <murrayc@murrayc.com>
819 * src/modest-tny-account-store.h:
820 * src/modest-tny-account-store.c:
821 Added modest_tny_account_store_forget_password_in_memory(),
822 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
823 when creating a new account, so that new passwords will be used, instead of
824 us thinking that it's a second request as a result of a failed password again.
826 2007-07-12 Murray Cumming <murrayc@murrayc.com>
828 * src/dbus_api/modest-dbus-callbacks.c:
829 (on_idle_open_message): If the message is in drafts then open it
830 in an edit window instead of a view window. This fixes
831 projects.maemo.org bug NB#63005.
833 2007-07-12 Murray Cumming <murrayc@murrayc.com>
835 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
836 Avoided a harmless g_warning().
838 2007-07-12 Murray Cumming <murrayc@murrayc.com>
840 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
841 Pass the modest account name, not the TnyAccount display name to
842 modest_msg_view_window_new() so that the reply feature works,
843 fixing projects.maemo.org bug NB#62892.
845 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
846 (modest_msg_view_window_new_with_header_model):
847 * src/maemo/modest-msg-view-window.c:
848 (modest_msg_view_window_new_with_header_model),
849 (modest_msg_view_window_new):
850 * src/modest-ui-actions.c: (reply_forward):
851 * src/widgets/modest-msg-view-window.h:
852 * src/widgets/modest-window.c: (modest_window_set_active_account):
853 Rename an account parameter to modest_account_name to make this clearer.
855 2007-07-11 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-ui-actions.h:
858 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
859 modest_do_message_delete().
860 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
861 Call modest_do_message_delete(), hoping that this would cause messages
862 to be really deleted from search instead of just marked with strike through.
863 Does not seem to help.
865 2007-07-11 Armin Burgmeier <armin@openismus.com>
867 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
868 priv->reselect to FALSE prior to calling
869 modest_folder_view_select_first_inbox_or_local() to prevent endless
870 recursion and thus a crash on startup.
872 2007-07-11 Armin Burgmeier <armin@openismus.com>
874 * src/maemo/modest-account-settings-dialog.h: Include
875 <gtk/gtknotebook.h> to fix the build (at least for me).
877 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
878 Use "New FolderN" as default suggested name if "New folder" already
879 exists, with N being the first free number, though never exceed "New
880 folder99" in which case we just fall back to "New Folder" even though
881 it already exists. This fixes projects.maemo.org bug NB#58663.
883 2007-07-11 Murray Cumming <murrayc@murrayc.com>
885 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
886 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
887 projects.maemo.org bug NB#62778.
889 2007-07-11 Murray Cumming <murrayc@murrayc.com>
891 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
892 Ignore the wrong (for now) secure-smtp setting in the presets -
893 just default to requiring secure authentication for SMTP, because
896 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
898 * src/widgets/modest-folder-view.c: (filter_row)
899 Do not show drafts folder (see UI specs)
901 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
903 * src/modest-ui-actions.c:
904 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
905 place and also not necessary.
907 * src/widgets/modest-folder-view.c: (filter_row)
908 Guess folder type and hide Sent & Outbox if necessary.
909 Fixed project.maemo.org NB#57328
911 2007-07-11 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-ui-actions.h:
914 * src/modest-ui-actions.c:
915 (modest_ui_actions_on_delete_message):
916 Move some code into a new
917 modest_ui_actions_refresh_message_window_after_delete()
918 function so we can use it from elsewhere.
920 * src/dbus_api/modest-dbus-callbacks.c:
921 (on_idle_delete_message), (on_delete_message): Used an idle
922 handler, as we do for the other D-Bus method handlers.
923 Call modest_ui_actions_refresh_message_window_after_delete()
924 if the deleted message was open in a window. This fixed
925 projects.maemo.org bug NB#62862.
927 2007-07-11 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-main.c: (main): Only show the UI at the start if
930 the showui command line option was given. For instance,
931 run-standalone src/modest showui
932 Otherwise, we wait for the top_application D-Bus method to
933 be sent by hildon-desktop when the application is selected
935 This allows us to run without a UI when osso-global-search
936 uses our D-Bus methods.
938 2007-07-11 Murray Cumming <murrayc@murrayc.com>
940 * src/dbus_api/modest-dbus-api.h: Added a define for a
941 top-application D-Bus method.
942 * src/dbus_api/modest-dbus-callbacks.c:
943 (on_top_application),
944 (modest_dbus_req_handler): Handle the top-application D-Bus
945 method, which might be an undocumented D-Bus signal sent by
946 hildon-desktop when it starts the application from the menu.
947 But I am not sure and I need to test it on the device, because
948 my scratchbox does not have the application in the menu now.
949 This method shows the main window, so that it can be invisible
950 when started, for instance, just for email searching from
953 * src/maemo/modest-main-window.c: (restore_settings),
954 (modest_main_window_new): Do not show the window immediately
955 upon creation. We show it later.
956 * src/modest-widget-memory.c: (save_settings_paned):
957 Try (unsuccessfully) to avoid saving the paned position when
958 it is not even visible.
959 (restore_settings_paned): Do not allow a silly paned position.
960 This seems necessary when not showing the window at first.
962 * tests/dbus_api/Makefile.am:
963 * tests/dbus_api/test_top_application.c: (main): Test for the
966 2007-07-10 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-ui-dimming-rules.c:
969 (modest_ui_dimming_rules_on_new_msg),
970 (modest_ui_dimming_rules_on_reply_msg),
971 (modest_ui_dimming_rules_on_delete_msg),
972 (modest_ui_dimming_rules_on_details),
973 (modest_ui_dimming_rules_on_view_window_move_to),
974 (modest_ui_dimming_rules_on_view_previous),
975 (modest_ui_dimming_rules_on_view_next),
976 (_invalid_folder_for_purge): Added checks before
977 casting the window. This looks like an actual
978 logic error in _invalid_folder_for_purge(), because it
979 tries to use a ModestMainWindow as a message window.
981 2007-07-10 Murray Cumming <murrayc@murrayc.com>
983 * src/maemo/modest-account-settings-dialog.c:
984 (show_error): Use the same implementation as in
985 modest-easysetup-wizard.c:
986 (on_entry_invalid_character): The logical ID contains a %s.
987 Guessed what it should be.
988 (on_entry_max), (check_data), (on_response): Adapt to
989 changed show_error().
990 (create_page_account_details): Really call
991 modest_validating_entry_set_func() on the correct widgets.
992 * src/maemo/easysetup/modest-easysetup-wizard.c:
993 (on_entry_invalid_character): Fix the logical ID here too.
994 (create_page_account_details),
995 (create_page_user_details):
997 modest_validating_entry_set_func() on the correct widgets.
999 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1000 Do not try to use the account if it is NULL.
1002 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1004 * src/modest-ui-actions.c: (create_move_to_dialog),
1005 (modest_ui_actions_on_main_window_move_to),
1006 (modest_ui_actions_on_msg_view_window_move_to):
1007 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
1008 (filter_row), (modest_folder_view_show_non_move_folders):
1009 * src/widgets/modest-folder-view.h:
1011 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1012 the Sent folder yet as it does not report the correct folder type.
1014 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1016 * src/maemo/modest-msg-edit-window.c: (init_window):
1019 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1021 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1022 Take a parent widget instead of a parent window, and
1023 implement this with hildon_banner_show_information() instead.
1024 Non-Maemo builds can just ifdef that there.
1025 This fixed projects.maemo.org bug NB#62766.
1027 (on_entry_invalid_character): Use show_error() again instead
1028 of using hildon directly, and use the _CS() macro to use the correct
1030 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1031 Pass a widget instead od a window to show_error().
1033 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1036 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1037 This allows us to show the server name in the error message, fixing
1038 projects.maemo.org bug NB#62904.
1039 Also, use the appropriate logical ID message for the account protocol.
1041 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1044 A compilation fix, though the build wasn't broken for me.
1046 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1048 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1049 Do not try to unref a NULL folder store, to avoid a runtime warning.
1050 This seems to happen sometimes when changing accounts settings.
1052 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-tny-account-store.c:
1055 (modest_tny_account_store_instance_init),
1056 (modest_tny_account_store_finalize),
1057 (on_account_settings_hide), (on_idle_wrong_password):
1058 Use a GHashTable to ensure that we only show one account settings
1059 dialog per modest account. This avoids us having a dialog open for
1060 both the store and transport accounts, or due to repeated get_password()
1061 calls that shouldn't happen anyway.
1063 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1065 * src/maemo/modest-maemo-utils.c: (on_hide),
1066 (modest_maemo_show_dialog_and_forget): Handle the response, because
1067 the window is not even hidden by default.
1069 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1070 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1071 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1072 which seems to prevent some modality problems.
1074 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1075 Ignore user cancellation errors.
1077 * src/modest-account-mgr-helpers.h:
1078 * src/modest-account-mgr-helpers.c:
1079 Added modest_server_account_get_password() and
1080 modest_server_account_get_has_password() to avoid direct use of
1083 * src/maemo/modest-account-settings-dialog.h:
1084 * src/maemo/modest-account-settings-dialog.c:
1085 (modest_account_settings_dialog_init): Store the notebook so we can
1087 Added modest_account_settings_dialog_switch_to_user_info().
1089 * src/modest-tny-account-store.c:
1090 (get_password): When the password in the account settings is wrong (we think),
1091 show the relevant page of the account settings dialog, in the mainloop.
1092 However, we currently get many of these at once because cancel does not
1094 (forget_password): Do not forget the password
1095 from the account settings, because this causes side-effects when
1096 tinymail seems to call it at strange time, maybe because of how we
1097 are cancelling get_password().
1098 (modest_tny_account_store_alert): Ignore user cancellations.
1100 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/modest-maemo-utils.h:
1103 * src/maemo/modest-maemo-utils.c:
1104 Added modest_maemo_show_information_note_and_forget() for use instead of
1105 gtk_dialog_run() when the response is not needed, to avoid an extra
1106 mainloop which could cause a hang.
1108 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1109 Use the logical IDs for the error message, though they are not
1110 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1111 because gtk_dialog_run() caused a hang here (the window did not close).
1112 This fixes projects.maemo.org bug NB#62646.
1114 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-account-mgr-helpers.h:
1117 * src/modest-account-mgr-helpers.c:
1118 Added modest_account_mgr_get_store_protocol().
1120 * src/maemo/modest-account-view-window.c:
1121 (on_delete_button_clicked): Show different warning text depending on
1122 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1123 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1126 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1128 * src/maemo/modest-msg-edit-window.c:
1129 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1130 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1132 2007-07-07 Armin Burgmeier <armin@openismus.com>
1134 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1135 ckdg_ib_maximum_characters_reached from correct package.
1137 * src/modest-ui-actions.c: Show an error message when a folder could
1138 not be created. Tinymail does not give us specific error codes about
1139 what has gone wrong, so we assume that a folder with that name
1140 already exists, though there might be other reasons.
1142 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1144 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1145 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1146 give a more exact error message that can be partly translated.
1148 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1150 * src/maemo/modest-address-book.c:
1151 (select_email_addrs_for_contact): Specify a default window size for the
1152 select-email-address dialog, so that it is probably big enough for the
1153 title. This should fix projects.maemo.org bug NB#62277.
1155 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1157 * src/maemo/easysetup/modest-easysetup-wizard.c:
1158 (create_page_complete_easysetup): Use
1159 gtk_widget_set_size() request to ensure that the text wraps
1162 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1164 * src/maemo/easysetup/modest-easysetup-wizard.c:
1165 (on_entry_invalid_character), (create_page_account_details),
1166 (create_page_user_details):
1167 Use new API of ModestValidatingEntry. But for some reason the banner is
1168 not shown. I will have to investigate that further.
1170 * src/widgets/modest-validating-entry.c: (on_insert_text),
1171 (modest_validating_entry_set_func):
1172 * src/widgets/modest-validating-entry.h:
1173 Added a new callback function to be able to react to prevented
1174 characters whitespaces to e.g show a banner.
1176 2007-07-05 Armin Burgmeier <armin@openismus.com>
1178 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1179 notification of HildonNumberEditor instead of remembering the port
1180 number. Thanks to Johannes for pointing this out.
1182 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1184 * src/maemo/easysetup/modest-easysetup-wizard.c:
1185 Check if there are any user changes before showing a confirmation
1186 dialog (projects.maemo.org NB#60946)
1188 2007-07-05 Armin Burgmeier <armin@openismus.com>
1190 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1191 number at the beginning of the dialog and set the modified flag at the
1192 end if the port number has changed. This is necessary because
1193 HildonNumberEditor does not support notification when the value has
1196 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1198 * src/modest-ui-actions.c:
1199 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1200 a connection before asking anything else. Correct the check for the destination
1201 folder so that it succeeds when online.
1202 This fixed projects.maemo.org bug NB#61645.
1204 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1206 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1207 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1208 to fix projects.maemo.org bug NB#62439.
1210 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1212 * src/modest-tny-account.c: (on_connection_status_changed):
1213 Really do not use tny_device_force_offline() here. See the previous comment.
1215 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1217 * src/modest-tny-account.c: (on_connection_status_changed):
1218 Do not use tny_device_force_offline() when tinymail says that something
1219 went wrong with the connection. It seems to report this unnecessarily.
1221 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/modest-connection-specific-smtp-window.c:
1224 (modest_connection_specific_smtp_window_init):
1225 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1226 does not seem to have any effect in osso 1.1 (though it works in
1227 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1229 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1231 * src/maemo/modest-connection-specific-smtp-window.c:
1232 Fix UI specification problems with projects.meamo.org NB#60479
1234 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1237 clue when this has failed, because the error dialog is not always shown
1238 (at least in earlier version).
1240 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1241 GError message, because the generic error dialog is not helpful.
1243 'This message is not currently available (can't let a new connection go online)'
1244 when trying to open an IMAP message.
1246 (_modest_ui_actions_open): Offer a connection when some messages would
1247 have to be downloaded and we are offline.
1249 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1251 * src/widgets/modest-folder-view.c:
1252 Don't check for MERGE type anymore as we use the correct type
1254 NOTE: For the last two changes you need to update your tinymail copy
1255 because of API changes!
1257 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1259 * src/modest-tny-local-folders-account.c:
1260 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1261 (see projects.maemo.org NB#61580)
1263 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-tny-account.c: (on_connection_status_changed):
1266 Commented out the call to modest_platform_connect_and_wait() because this
1267 seems to always hang, and I would like to know if this is the only thing
1268 that causes a hang when showing the connection dialog.
1269 It is not very useful anyway.
1271 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1273 * src/maemo/modest-msg-view-window.c:
1274 (modest_msg_view_window_select_next_message):
1276 * src/modest-platform.h:
1277 * src/maemo/modest-platform.c:
1278 Added modest_platform_connect_and_wait(), which calls
1279 tny_maemo_conic_device_connect() always in the main thread, by calling it
1280 in an idle handler and waiting for the idle handler to run. It should be
1281 in the main thread because it uses GTK+ UI code. It just returns TRUE
1282 if the device is already online.
1284 There is some nasty code to ensure that subsequent calls to
1285 modest_platform_connect_and_wait() just wait for the first one to finish,
1286 by checking repeatedly in another idle handler. This is necessary,
1287 because other threads (or even the main thread, via another idle handler)
1288 can call modest_platform_connect_and_wait() while
1289 modest_platform_connect_and_wait() is running.
1291 (modest_platform_connect_and_wait_if_network_account),
1292 (modest_platform_connect_and_wait_if_network_folderstore):
1293 Convenience functions that calls modest_platform_connect_and_wait() if
1294 the account or folder might want network access.
1296 * src/modest-mail-operation.c:
1297 (modest_mail_operation_update_account):
1298 * src/modest-ui-actions.c: (download_uncached_messages),
1299 (modest_ui_actions_on_rename_folder), (delete_folder),
1300 (modest_ui_actions_on_main_window_move_to),
1301 (modest_ui_actions_on_msg_view_window_move_to):
1302 * src/widgets/modest-folder-view.c:
1303 (drag_and_drop_from_folder_view):
1304 Offer a connection if we are offline.
1306 * src/modest-tny-account.c: (on_connection_status_changed):
1307 Document this as only handling errors during network operations in progress,
1308 and replace the idle code with a simple call to
1309 modest_platform_connect_and_wait(), which does this instead.
1311 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-tny-account.c:
1314 (modest_tny_account_get_special_folder): (util_on_idle),
1315 Handle the GError so we can see when tny_folder_store_get_folders()
1316 fails, as it currently does while something else is connecting.
1318 Added util_run_in_main_thread_and_wait()
1319 which uses an idlen handler and mainloop to ensure that the function
1320 is called in the main thread.
1321 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1322 to make sure that we call attempt the connection in the mainloop only,
1323 which might solve some hangs.
1325 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1327 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1328 be found by their display name. This is never useful.
1329 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1330 by its ID, instead of trying to use its ID as its display name.
1332 * src/modest-tny-account-store.h:
1333 * src/modest-tny-account.c:
1334 (modest_tny_account_get_special_folder): Add a g_warning() when
1335 tny_folder_store_get_folders() returns an empty list for the maildir.
1337 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1338 Add a g_warning() when this returns NULL, because that it not allowed
1341 2007-07-02 Armin Burgmeier <armin@openismus.com>
1343 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1344 note when trying to cancel the wizard. This fixes projects.maemo.org
1347 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1349 * src/modest-tny-account.h:
1350 * src/modest-tny-account.c:
1351 (modest_tny_account_new_from_server_account),
1352 (modest_tny_account_new_from_server_account_name),
1353 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1354 because this must now be set before setting the proto. This is usd in
1355 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1356 warning in camel_session_get_service() caused by
1357 tny_camel_transport_account_prepare().
1359 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1362 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1364 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1366 (modest_connection_specific_smtp_edit_window_init):
1368 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1369 of "changed" for now
1371 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1373 * src/modest-tny-account.c:
1374 (modest_tny_account_new_from_server_account):
1375 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1376 now uses to request a connection when it needs one, and which it uses
1377 to tell us that something is wrong with the connection, so we can force
1378 the accounts offline to prevent further problems.
1380 * src/modest-defs.h:
1381 * src/modest-init.c: (init_default_settings):
1382 * src/modest-mail-operation.c:
1383 (modest_mail_operation_update_account):
1384 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1385 This should not be necessary anymore. Do not set the conf key that
1386 determined this (it was always TRUE and not set anywhere else).
1388 * src/modest-ui-actions.h: Remove unused and unimplemented
1389 modest_ui_actions_on_online_toggle_toggled().
1391 2007-06-29 Murray Cumming <murrayc@murrayc.com
1393 * src/maemo/modest-main-window.c: (connect_signals):
1394 Don't connect to delete_event twice. Maybe this was harmless.
1396 2007-06-29 Murray Cumming <murrayc@murrayc.com
1398 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1399 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1400 Debug output to give some more clue when a folder move is not allowed.
1402 2007-06-28 Murray Cumming <murrayc@murrayc.com
1404 * src/modest-tny-account.c: (on_modest_file_system_info),
1405 (modest_tny_account_get_mmc_account_name):
1406 Always call the callback, without checking whether the name has changed.
1407 * src/widgets/modest-folder-view.c: (strings_are_equal),
1408 (on_model_foreach_set_name), (on_get_mmc_account_name),
1409 (text_cell_data): Compare the name here, and use the name from
1410 the account rather than from the
1411 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1412 if the name was changed after the account was added to the model.
1413 That's a tinymail bug but not one that I want to fix now.
1415 This finally fixes projects.maemo.org bug NB#59301.
1417 2007-06-27 Armin Burgmeier <armin@openismus.com>
1419 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1422 2007-06-27 Murray Cumming <murrayc@murrayc.com
1424 * src/modest-tny-account.h:
1425 * src/modest-tny-account.c:
1426 Added modest_tny_account_get_mmc_account_name(), to set the memory
1427 card name asynchronously for the given account and then notify.
1428 (modest_tny_account_new_for_local_folders): Use this new function instead
1429 of using hildon_file_system_info_async_new() directly.
1431 * src/widgets/modest-folder-view.c: (text_cell_data):
1432 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1433 gtk_tree_model_row_changed() when it is available.
1435 This should fix projects.maemo.org bug NB#59301.
1437 2007-06-27 Murray Cumming <murrayc@murrayc.com
1439 * src/modest-mail-operation.c: (update_account_thread),
1440 (get_msgs_full_thread): Fix typo failures in the revert
1443 2007-06-27 Murray Cumming <murrayc@murrayc.com
1445 * src/maemo/modest-maemo-global-settings-dialog.c:
1446 (idle_select_default_focus):
1447 * src/modest-mail-operation.c: (idle_notify_progress),
1448 (idle_notify_progress_once), (set_last_updated_idle),
1449 (update_account_thread), (get_msgs_full_thread):
1450 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1451 * src/widgets/modest-header-view.c:
1452 (idle_notify_headers_count_changed_destroy),
1453 (idle_notify_headers_count_changed):
1454 Reverted the additions of gdk_threads_enter/leave(), in case this
1455 helps with a startup hang on the device.
1457 2007-06-26 Armin Burgmeier <armin@openismus.com>
1459 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1460 for supported secure authentication methods from server by
1461 gtk_dialog_run(), saving CPU time and a potential race condition.
1463 2007-06-26 Armin Burgmeier <armin@openismus.com>
1465 * src/maemo/modest-maemo-utils.h:
1466 * src/maemo/modest-maemo-utils.c: Added a
1467 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1468 only error code to tell the calling code when the user canceled the
1471 * src/maemo/modest-account-settings-dialog.h:
1472 * src/maemo/modest-account-settings-dialog.c:
1473 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1474 message if the retrieval of secure authentication methods was canceled
1475 by the user. Perform the check before saving anything to configuration
1476 to not end up with half-committed configuration changes, do not show
1477 a "Saving to configuration failed" note when authentication methods
1478 could not be retrieved.
1480 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1483 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1485 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1486 Only return the first level of folders under accounts, because the
1487 osso-global-search UI spec doesn't want the rest.
1488 This fixed projects.maemo.org bug NB#61811.
1490 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-tny-account-store.c:
1493 * src/modest-tny-account-store.h:
1494 Added modest_tny_account_is_memory_card_account().
1495 * src/maemo/modest-main-window.c: (create_details_widget):
1496 Show the same information items for the memory card as we show for the
1497 local-folders, to fix projects.maemo.org bug NB#59307.
1499 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1501 * src/modest-tny-account-store.c: (get_password):
1502 Added some checks for NULL to maybe prevent crashes, though I think
1503 it was Philip's last commit that actually prevented the crash here
1504 when creating a first new account.
1505 But the new account is still not usable (no messages are shown)
1506 until a restart of the application.
1508 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1510 * src/maemo/modest-maemo-global-settings-dialog.c:
1511 (idle_select_default_focus):
1512 * src/modest-mail-operation.c: (idle_notify_progress),
1513 (idle_notify_progress_once), (idle_notify_update_account_queue),
1514 (set_last_updated_idle), (update_account_thread),
1515 (notify_get_msgs_full), (get_msgs_full_destroyer),
1516 (get_msgs_full_thread):
1517 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1518 * src/widgets/modest-header-view.c:
1519 (idle_notify_headers_count_changed_destroy),
1520 (idle_notify_headers_count_changed):
1521 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1522 all idle handlers, because some other thread could be blocking
1523 the GDK lock, so that it can do GUI stuff.
1525 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1527 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1528 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1529 (on_idle_send_receive), (on_idle_open_default_inbox):
1530 * src/maemo/modest-msg-edit-window.c:
1531 (modest_msg_edit_window_attach_file_noninteractive):
1532 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1533 to prevent a hang. I don't quite understand why these are necessary,
1534 beause we should already be in the main loop. I guess something outside
1535 of the main loop is taking the lock.
1537 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1538 we are really using URIs, and use files that are more likely to exist.
1540 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1542 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1543 necessary because configure.ac now defines different variables.
1545 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1547 * libmodest-dbus-client/libmodest-dbus-client.c:
1548 * libmodest-dbus-client/libmodest-dbus-client.h:
1549 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1550 libmodest_dbus_client_compose_mail() is what things actually use.
1552 * src/dbus_api/modest-dbus-api.h:
1553 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1554 * tests/dbus_api/Makefile.am:
1555 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1558 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-init.c: (modest_init_local_folders):
1561 For memory-card (or other non local-folders) maildir accounts,
1562 always create an Archive folder, so that there is somewhere to put
1563 messages. This should be less confusing, because the user does not need
1564 to guess that the need to create a folder.
1566 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1568 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1569 Fixed icon size by using (50, 50) which is the same as defined by
1572 2007-06-25 Armin Burgmeier <armin@openismus.com>
1574 * src/widgets/modest-window-mgr.c:
1575 * src/modest-init.c:
1576 * configure.ac: Correctly recognize hildon-notify presence and fixed
1577 the build without it being installed.
1579 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1581 * libmodest-dbus-client/libmodest-dbus-client.c:
1582 (libmodest_dbus_client_search): Fix the build. Sorry.
1583 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1584 (reply_forward_cb): Initialize variables to fix the build.
1586 * src/modest-tny-account-store.c:
1587 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1588 comparison (a silly typo) so that email search results can be opened
1589 when there are more than one account.
1591 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1593 * libmodest-dbus-client/libmodest-dbus-client.c:
1594 (libmodest_dbus_client_search),
1595 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1596 instead of 1 second, because the search gets folders and messages from
1597 the server, which can take a long time. When it times out,
1598 osso-global-search will report no results.
1600 We need to specify whether we should search only cached information
1601 (maybe with a user preference), and the osso-email-search-plugin
1602 API should really be improved to allow that option, and to allow results
1603 to be delivered asynchronously in batches.
1605 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1607 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1608 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1609 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1611 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1614 that is an empty string. D-Bus seems to give us these instead of NULL.
1616 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1618 * src/dbus_api/modest-dbus-callbacks.c:
1619 * src/maemo/easysetup/modest-easysetup-wizard.h:
1620 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1621 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1622 (modest_connection_specific_smtp_edit_window_init):
1623 * src/maemo/modest-maemo-global-settings-dialog.c:
1625 * src/maemo/modest-maemo-utils.c:
1626 (modest_maemo_utils_setup_images_filechooser):
1627 * src/maemo/modest-main-window.c: (create_details_widget):
1628 * src/maemo/modest-msg-edit-window.c:
1629 (modest_msg_edit_window_attach_file_noninteractive),
1630 (modest_msg_edit_window_color_button_change),
1631 (modest_msg_edit_window_set_zoom):
1632 * src/modest-mail-operation.c: (update_account_thread):
1633 * src/modest-tny-account-store.c:
1634 * src/modest-tny-account.c:
1635 * src/widgets/modest-global-settings-dialog.c:
1636 * src/widgets/modest-window.h:
1638 Fixed build on bora!
1640 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1642 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1643 * src/modest-search.c: (modest_search_folder),
1644 (modest_search_all_accounts): Actually search only in the specified folder,
1645 doing a simple match on the folder ID.
1646 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1647 and added some documentation.
1649 2007-06-22 Armin Burgmeier <armin@openismus.com>
1651 * src/maemo/modest-maemo-utils.h:
1652 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1653 modest_maemo_utils_get_supported_secure_authentication_methods.
1655 * src/maemo/easysetup/modest-easysetup-wizard.c:
1656 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1657 one occured, not just "Server does not support secure authentication".
1659 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1661 * src/modest-tny-account-store.c: (get_password):
1662 Restored the call to tny_account_set_user() because Philip seems to have
1663 stopped this from crashing (by not using the freed string). It still does
1664 not work, but now we can test it.
1666 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/modest-msg-edit-window.c: (init_window):
1669 Comment out use of an uninitialzed GtkScrolledWindow variable,
1670 to fix the build and stop a crash. Yet again.
1672 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-tny-account-store.c: (get_password):
1675 Remove the call to tny_account_set_user() because this actually crashes.
1676 As mentioned in the last commit, it is known to not work anyway.
1678 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1680 * src/modest-tny-account-store.c: (get_password):
1681 Use tny_account_set_username() to tell tinymail that the username might
1682 have changed too. But tinymail ignores this: see projects.maemo.org
1684 * src/modest-ui-actions.c:
1685 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1686 reset the connection when changing the username, and improve the comments.
1687 Save the changed username to gconf at least, so it is used when Modest is
1690 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1692 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1693 Do not use a query, so that we get all folders, including for POP and
1694 local-folders. They work as search criteria too.
1695 This fixes projects.maemo.org bug NB#57740.
1697 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1700 Comment out the use of hildon_notification_set_sound() because it is
1701 not declared, to fix the build. Warnings are serious, people.
1703 2007-06-21 Armin Burgmeier <armin@openismus.com>
1705 * src/maemo/modest-maemo-utils.h:
1706 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1707 modest_maemo_utils_get_supported_secure_authentication_methods()
1708 to query authentication methods for a specific user. This should fix
1709 projects.maemo.org bug NB#61369.
1711 * src/maemo/easysetup/modest-easysetup-wizard.c:
1712 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1715 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1717 * libmodest-dbus-client/libmodest-dbus-client.h:
1718 * libmodest-dbus-client/libmodest-dbus-client.c:
1719 (modest_dbus_message_iter_get_search_hit),
1720 (libmodest_dbus_client_search):
1721 Reorganised and commented this.
1722 Removed modest_search_hit_free() from the public API because it
1725 Added libmodest_dbus_client_get_folders() and
1726 modest_folder_result_list_free().
1728 * src/dbus_api/modest-dbus-api.h:
1729 * src/dbus_api/modest-dbus-callbacks.c:
1730 (modest_dbus_req_filter): Commented. Moved most code to
1731 on_dbus_method_search() and added on_dbus_method_get_folders().
1733 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1734 of the extra D-Bus handler.
1736 * tests/dbus_api/Makefile.am:
1737 * tests/dbus_api/test_get_folders.c: New test for
1738 libmodest_dbus_client_get_folders(). This seems to return an empty list
1739 at the moment. That could be the same error that causes the message list
1740 to be empty sometimes.
1741 This should help with projects.maemo.org bug NB#57740.
1743 2007-06-21 Armin Burgmeier <armin@openismus.com>
1745 * src/modest-mail-operation.c: Do not call
1746 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1747 notify the operation's end after having set the status to CANCELED for
1748 the operation queue to listen on. This fixes a deadlock when there
1749 were mail operations in the queue during its finalization.
1751 * src/modest-singletons.c: Reordered uninitialization of the account
1752 manager to happen after the mail operation queue was uninitialized
1753 because the mail operation's in the queue might still try to access
1754 the account manager (see modest_mail_operation_notify_end()). This
1755 fixes a potential crash when terminating the application.
1757 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1759 * src/modest-search.c:
1760 (search_mime_part_and_child_parts): Moved some code here so we
1761 can search recursively in child folders.
1762 (modest_search_folder): Search in the message as a mime part, instead
1763 of just its child mime parts.
1764 (read_chunk), (search_mime_part_ogs):
1765 Check how many bytes were read, to prevent an endless loop.
1766 Searching in message bodies now works. This finishes the fix for
1767 projects.maemo.org bug NB#61007.
1769 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1771 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1772 Add a g_warning when the item is not a folder.
1774 * src/modest-ui-dimming-rules.c:
1775 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1776 when selected item is not a folder (for instance, an account), because
1777 the UI spec only talks about folders.
1778 I am not sure what the UI spec wants, so this might not totally fix
1779 projects.maemo.org bug NB#60794.
1781 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1783 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1784 (load_from_file): Sort the list. The unsorted list would be more noticeable
1785 in non-English locales.
1787 * src/maemo/modest-msg-edit-window.c:
1788 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1789 warning and fix the build.
1791 * src/maemo/modest-progress-bar-widget.c:
1792 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1793 avoid a g_warning, and probably to avoid a crash.
1795 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1797 * src/modest-search.c: (modest_search_folder): Check for a GError
1798 when calling tny_folder_get_headers(), to show that this is not the cause
1801 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1803 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1804 Actually set the body query instead of the subject query.
1806 * src/modest-search.c: (search_mime_part_ogs),
1807 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1808 which would probably cause it to fail if we got this far.
1810 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1811 to simplify the code.
1812 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1813 be causing search-in-body to fail.
1815 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1817 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1819 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1820 Better debug message when the folder cannot be found.
1821 This should help with fixing projects.maemo.org bug #61287.
1822 * src/modest-search.c: (add_hit): Do not leak the furl string.
1824 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-ui-actions.c:
1827 (modest_ui_actions_on_folder_selection_changed):
1828 Do not special-case TNY_MERGE_FOLDER here, because
1829 modest_tny_folder_get_account() already does that. This fixes
1830 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1831 shown when the Outbox was selected).
1833 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1835 * libmodest-dbus-client/libmodest-dbus-client.c:
1836 (_dbus_iter_get_string_or_null): Initialize the string variable in
1837 case this helps with Dirk's crash.
1839 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1841 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1842 though it is not implemented yet (this function is maybe not even used),
1843 to avoid breaking ABI in future.
1844 * libmodest-dbus-client/libmodest-dbus-client.c:
1845 (get_attachments_string): Moved some code into this generic function.
1846 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1847 sends email. It is maybe not used.
1848 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1849 (on_send_mail): Use attachments.
1851 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1852 * src/maemo/modest-msg-edit-window.c:
1853 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1854 a filename before using it, to fix projects.maemo.org bug NB#58233.
1856 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1859 Initialize the continue_download variable to fix the build, and probably
1860 to fix randome behaviour.
1862 2007-06-18 Armin Burgmeier <armin@openismus.com>
1864 * src/modest-tny-send-queue.h:
1865 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1866 the queue so we can later show it in the UI. Replaced
1867 modest_tny_send_queue_msg_is_being_sent() by
1868 modest_tny_send_queue_get_msg_status().
1870 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1872 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1873 gpointer. This probably was not harmful, but just to be sure.
1875 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1877 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1878 Fix the build, but leave the function broken on Bora, because
1879 hildon_uri_action_get_service() does not exist.
1880 osso_uri_action_get_service() does not exist either, it seems.
1882 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1884 * src/modest-tny-account.c:
1885 (modest_tny_account_new_from_server_account):
1886 Uncommented the url debug output again, because it is useful for
1887 debugging, as I said in the comment.
1889 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1891 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1893 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1894 for Mameo Bora, to fix the build.
1896 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1899 Fixed build with hildon < 0.99
1901 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1902 Check if the selected account is busy instead of checking all accounts
1904 * src/modest-account-mgr-priv.h:
1905 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1906 (modest_account_mgr_init), (compare_account_name),
1907 (modest_account_mgr_set_account_busy),
1908 (modest_account_mgr_account_is_busy):
1909 * src/modest-account-mgr.h:
1910 Added busy information to the account manager. It possible to
1911 set an account to busy or not busy now.
1913 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1914 (modest_mail_operation_update_account),
1915 (modest_mail_operation_notify_end):
1916 Set the account to busy/not busy depending on the operation state.
1918 * src/widgets/modest-account-view.c:
1919 (modest_account_view_finalize), (get_last_updated_string),
1920 (update_account_view), (on_account_busy_changed), (init_view):
1921 Show string "Refreshing..." if the account is currently busy.
1923 All this fixes projects.maemo.org bug NB#59711
1925 2007-06-14 Armin Burgmeier <armin@openismus.com>
1927 * src/widgets/modest-attachments-view.h:
1928 * src/widgets/modest-attachments-view.c: Added
1929 modest_attachments_view_has_attachments() and fixed coordinate
1930 transformation in get_att_view_at_coords(). This fixes attachment
1933 * src/widgets/modest-msg-view.c: Make use of
1934 modest_attachments_view_has_attachments() to decide whether to show
1935 attachments in the header.
1937 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1939 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1940 (on_change), (on_combo_security_changed),
1941 (modest_connection_specific_smtp_edit_window_init),
1942 (modest_connection_specific_smtp_edit_window_set_connection),
1943 (modest_connection_specific_smtp_edit_window_is_dirty):
1944 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1945 * src/maemo/modest-connection-specific-smtp-window.c:
1948 Show an comfirmation dialog for the smpt-edit-window if there are
1949 unsaved changes and the user hits cancel.
1950 (projects.maemo.org bug NB#60479)
1952 2007-06-14 Armin Burgmeier <armin@openismus.com>
1954 * src/maemo/easysetup/modest-easysetup-wizard.c:
1955 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1956 address" info in banner instead of node, and select all the text as
1957 per UI spec. This fixes projects.maemo.org bug NB#60550.
1959 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1961 reviewed by: <delete if not using a buddy>
1963 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1964 * src/modest-ui-actions.c: (folder_refreshed_cb):
1966 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1968 * src/widgets/modest-folder-view.c: (filter_row):
1969 Explictly filter out the per-account outbox accounts. I don't know why
1970 these only sometimes show up, but now they should never show up in the UI.
1971 This should fix projects.maemo.org bug NB#60160.
1973 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1976 when the toolbar does not exist yet.
1977 * src/modest-widget-memory.c: (save_settings_header_view):
1978 Added g_warnings() to help us to discover when we are trying to set
1979 an empty columns list in gconf.
1981 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-init.h:
1984 * src/modest-init.c:
1985 Added modest_init_get_default_header_view_column_ids().
1987 * src/modest-widget-memory.c: (restore_settings_header_view):
1988 Use the new function to get defaults, if the gconf key is empty,
1989 instead of not creating any columns. This seems to fix the
1990 empty right-hand pane problems.
1992 * src/widgets/modest-header-view.h: Improved documentation.
1994 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1996 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1997 Revert the use of the display name as the account name, because this
1998 is generally wrong and would break the code that follows.
2000 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2002 * src/maemo/easysetup/modest-easysetup-wizard.c:
2003 (check_for_supported_auth_methods), (on_before_next),
2006 More correct fix for projects.maemo.org bug NB# 58991
2007 Do not longer accept AUTH_PASSWORD as secure method and choose
2008 correct method when creating the account.
2010 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2012 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2013 Fixed projects.maemo.org bug NB# 58991
2015 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2017 * src/modest-init.c: (modest_init_init_core),
2018 (modest_init_local_folders): Fixed compilation errors.
2020 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2022 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2023 Remove unnecessary lib/include, though it is good in principle when needed.
2025 * src/modest-init.c: (modest_init_one_local_folder),
2026 (modest_init_local_folders):
2027 * src/modest-init.h: Initialize the .modest library for memory cards,
2028 instead of just doing nothing for them. This should allow us to create
2029 folders there, fixing projects.maemo.org bug NB#59297.
2031 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2033 * libmodest-dbus-client/libmodest-dbus-client.c:
2034 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2035 (libmodest_dbus_client_compose_mail),
2036 (libmodest_dbus_client_open_message),
2037 (libmodest_dbus_client_send_and_receive),
2038 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2040 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2041 (on_idle_open_message), (modest_dbus_req_handler),
2042 (search_result_to_message), (modest_dbus_req_filter):
2043 * src/modest-search.c: (add_hit), (modest_search_folder),
2044 (modest_search_all_accounts): Improved debug messages.
2046 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2048 * src/modest-tny-account-store.c:
2049 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2052 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2055 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2057 * src/modest-tny-account-store.c: (get_server_accounts):
2058 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2059 even when there are no accounts, so that the Outbox folder is always
2060 visible. This fixes projects.maemo.org bug NB#60158.
2062 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/modest-main-window.c: (create_details_widget):
2065 Use the mcen_va_never logical ID.
2067 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2069 * src/dbus_api/modest-dbus-api.h:
2070 * src/dbus_api/modest-dbus-callbacks.c:
2071 (on_idle_open_default_inbox), (on_open_default_inbox),
2072 (modest_dbus_req_handler):
2073 Added a new OpenDefaultInbox method.
2075 * libmodest-dbus-client/libmodest-dbus-client.h:
2076 * libmodest-dbus-client/libmodest-dbus-client.c:
2077 Added libmodest_dbus_client_open_default_inbox() to call the new
2078 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2079 though it should maybe be used by a new osso-email-interface function.
2081 * tests/dbus_api/Makefile.am:
2082 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2085 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2088 NULL, so that the signals get all the keys. This should not actually
2089 change any behaviour because we currently update everything when anything
2092 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2094 * src/widgets/modest-folder-view.c: (text_cell_data),
2095 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2096 (find_inbox_iter): If tinymail tells us that the folder is
2097 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2098 This causes the inbox to be selected at startup, fixing part of
2099 projects.maemo.org bug NB#56305.
2101 * src/modest-ui-dimming-rules.c:
2102 (modest_ui_dimming_rules_on_tools_smtp_servers):
2103 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2104 the SMTP servers menu item.
2105 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2106 that the SMTP Servers menu item is dimmed when there are no accounts,
2107 as a future version of the UI spec will require. This fixes
2108 projects.maemo.org bug NB#56305.
2110 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2112 * src/maemo/modest-maemo-utils.c:
2113 (modest_maemo_utils_get_supported_secure_authentication_methods):
2114 Added label to dialog instead of unreadable title
2116 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2117 (modest_main_window_new):
2118 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2121 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2122 * src/modest-account-mgr.h:
2123 Added method to avoid code duplication
2125 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2126 (modest_ui_actions_on_send_receive):
2127 Use modest_account_mgr_has_accounts
2129 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/easysetup/modest-presets.c:
2132 (modest_presets_get_info_server_security): Do not report secure auth
2134 * src/modest-protocol-info.c: Use the defines for the gconf key names
2135 for secure authentication. This was not working because we were writing
2136 Password and reading password, and the check was case sensitive.
2137 With this, gmail now works for receiving and sending when created via
2140 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2142 * src/maemo/easysetup/modest-presets.c:
2143 (modest_presets_get_info_server_security): Correct the key name for
2144 SecureSmtp, because it seems to be case-sensitive.
2145 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2146 Do not try to get the 0th notebook page if there are 0 pages, to
2147 avoid a g_warning().
2149 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2151 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2152 Prevent use of the new notification feature for now, because it currently
2153 shows one dialog for each new email, which is annoying.
2155 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2157 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2158 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2159 when no country was selected, so that we show the global ones.
2160 * src/maemo/easysetup/modest-presets.c:
2161 (modest_presets_get_providers): Return only the global providers, not
2162 all providers when mmc=0 was requested.
2164 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2167 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2168 provider ID in the combo.
2170 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2171 Do not show the page numbers, because it would be confusing when we add
2172 the 2 extra pages for the custom setup, when the user chooses the "Other"
2173 provider. This fixes projects.maemo.org bug NB#59028
2175 * src/modest-init.c: (modest_init_init_core),
2176 (modest_init_local_folders):
2177 * src/modest-init.h:
2178 * src/modest-tny-account.c:
2179 (modest_tny_account_new_for_local_folders): Do not create default folders
2180 for the memory card. This should fix projects.maemo.org bug NB#59328.
2182 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2185 Free the changed_conf_keys string items. They are already freed in the
2186 idle handler if that runs first.
2188 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-ui-actions.c:
2191 (modest_ui_actions_on_password_requested): Check that the server name
2192 is not NULL, because I just saw a password dialog with (null) as the
2195 * src/modest-tny-folder.[h|c]: Added
2196 modest_tny_folder_is_memory_card_folder().
2197 * src/modest-ui-dimming-rules.c:
2198 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2199 menu item for memory cards, as per the UI spec (section 7.4). This should
2200 fix projects.maemo.org bug NB#59297.
2202 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2204 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2205 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2206 is another problem with the code, see Murray's comment at line 772)
2208 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2210 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2211 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2212 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2213 (load_from_file), (easysetup_country_combo_box_init),
2214 (easysetup_country_combo_box_get_active_country_ids),
2215 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2216 instead of just one ID, to avoid duplicate country names in the UI.
2218 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2219 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2220 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2221 a single ID, avoiding duplicate providers.
2222 * src/maemo/easysetup/modest-easysetup-wizard.c:
2223 (on_combo_account_country): Adapt to use a list.
2225 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2227 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2228 keys changed in the last X seconds.
2230 * src/modest-account-mgr.h:
2231 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2232 (on_key_change), (modest_account_mgr_class_init),
2233 (modest_account_mgr_init), (modest_account_mgr_finalize):
2234 As the keys are changed, save them in a GSList* and signal that GSList*
2235 further every X seconds, to batch changes, to allow us to do just one
2236 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2237 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2239 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2240 changed signal signature.
2242 * src/modest-conf.c: (modest_conf_set_list),
2243 (modest_conf_on_change): Reenable notification.
2245 (modest_conf_maemo_fake_on_change): Comment out the hack that
2246 notified immediately instead of asynchronously.
2248 * src/widgets/modest-account-view.h:
2249 * src/widgets/modest-account-view.c:
2250 (update_account_view): Select the previously-selected account ID,
2251 if possible. This fixes projects.maemo.org bug NB#56933.
2253 (on_account_changed), (on_account_removed),
2254 (modest_account_view_select_account):
2256 Remove the block/unblock functions
2257 because they were not useful.
2259 * src/maemo/modest-account-view-window.c:
2260 (on_delete_button_clicked), (on_edit_button_clicked),
2261 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2263 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2265 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2266 Improve the error dialog to show Incorrect Account Settings, which seems
2267 clearer, and say that the internal error message (to be removed from the
2268 dialog later) is often misleading.
2269 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2271 * src/modest-tny-account.c:
2272 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2273 URL because this is so useful for debugging on the device.
2275 * src/widgets/modest-serversecurity-combo-box.c:
2276 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2278 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-mail-operation.c:
2281 (modest_mail_operation_send_new_mail):
2282 Added a comment about a nasty but apparently harmless message. Details
2283 added to the wiki g_warnings() page.
2285 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2287 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2288 (modest_tny_send_queue_class_init):
2289 Do not use the priv struct because it is empty, to avoid g_warnings
2290 about a non-existant priv struct.
2292 * src/modest-tny-account-store.c:
2293 (modest_tny_account_store_get_server_account),
2294 (modest_tny_account_store_get_transport_account_for_open_connection
2295 ): Do not try to get transport server accounts for local folders,
2296 because they don't have any. This avoids a g_warning().
2298 * src/maemo/modest-main-window.c:
2299 (modest_main_window_notify_send_receive_initied),
2300 (on_configuration_key_changed):
2301 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2302 * src/modest-defs.h:
2303 * src/modest-mail-operation.c:
2304 (modest_mail_operation_update_account):
2305 * src/modest-tny-account-store.h:
2306 * src/modest-tny-account.c:
2307 (modest_tny_account_get_special_folder),
2308 (modest_tny_account_new_for_local_folders),
2309 (modest_tny_account_new_for_per_account_local_outbox_folder):
2310 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2311 * src/modest-tny-local-folders-account.c:
2312 (add_account_folders_to_merged_folder):
2313 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2314 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2315 (modest_ui_actions_on_send):
2316 * src/widgets/modest-folder-view.c: (update_model):
2317 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2318 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2319 modest_tny_account_store_get_tny_account_by_account() to
2320 modest_tny_account_store_get_server_account() to make the code clearer.
2322 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2324 * src/dbus_api/modest-dbus-api.h:
2325 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2326 * src/maemo/modest-msg-edit-window.c:
2327 (modest_msg_edit_window_attach_file_noninteractive):
2328 added g_warning in case the file to be attached does not exist
2329 * tests/dbus_api/test_compose_mail.c: (main):
2330 removed obsolete comment, added generic files as test case
2332 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2334 * src/modest-tny-account-store.c: (get_server_accounts):
2335 Create the local folders account only once, not once for each outbox, and
2336 not only when there are some outboxes.
2338 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2340 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2341 code that is causing a crash at startup. Sergio says that he is fixing this.
2343 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2345 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2346 * src/maemo/modest-account-settings-dialog.c:
2347 (create_page_outgoing),
2348 (modest_account_settings_dialog_set_account_name),
2349 (save_configuration):
2350 - Fixed handling of the "Use secure authentication" toggle to comply with
2351 the ui specification. See also projects.maemo.org bug NB#58400
2353 - Restore the Secure connection setting combo correctly when loading
2356 * src/maemo/modest-maemo-utils.c:
2357 (on_camel_account_get_supported_secure_authentication),
2358 (modest_maemo_utils_get_supported_secure_authentication_methods):
2359 Fixed a crasher if operation is canceled
2361 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2362 (modest_protocol_info_auth_is_secure):
2363 * src/modest-protocol-info.h:
2365 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2366 the sense of the "Use secure authentication" toggle.
2368 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2370 * src/modest-tny-account-store.h:
2371 * src/modest-tny-account-store.c:
2372 Added modest_tny_account_store_get_local_folders_account().
2374 * src/modest-tny-folder.h:
2375 * src/modest-tny-folder.c:
2376 (modest_tny_folder_get_account):
2377 Added this replacement for tny_folder_get_account() which returns
2378 the local-folders account for TnyMergeFolders, to avoid the
2379 warning about the unimplemented get_account_func() vfunc().
2381 (modest_tny_folder_get_rules),
2382 * src/modest-ui-actions.c:
2383 (modest_ui_actions_on_folder_selection_changed):
2384 * src/modest-mail-operation.c:
2385 (modest_mail_operation_remove_folder),
2386 (modest_mail_operation_xfer_folder),
2387 (modest_mail_operation_rename_folder),
2388 (modest_mail_operation_get_msg),
2389 (modest_mail_operation_get_msgs_full),
2390 (modest_mail_operation_remove_msg),
2391 (modest_mail_operation_xfer_msgs),
2392 (modest_mail_operation_refresh_folder):
2393 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2395 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2397 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2398 (modest_server_account_set_security):
2399 * src/modest-defs.h: Add comments explaining that our
2400 UI spec means TLS when it says Normal, so these do not look like errors.
2402 * src/modest-tny-account.c:
2403 (modest_tny_account_new_from_server_account): Use the new tinymail
2404 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2405 for TLS. This should fix projects.maemo.org bug NB#58460.
2407 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/easysetup/modest-easysetup-wizard.c:
2410 (create_account): Correct the position of the gconf sanity check warning.
2411 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2412 of using the g_idle_add() hack, because this does not seem to be necessary
2413 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2414 caused by something other than maemo's gconf.
2415 This fixes projects.maemo.org bug #59022.
2417 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2419 * src/modest-account-mgr-helpers.c:
2420 (modest_account_mgr_get_default_account): Do not check that the account
2421 exists if there is no default account (NULL), to fix a runtime warning.
2423 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2425 * src/widgets/modest-folder-view.c: (update_model):
2426 Do not unref the treemodel before we have finished with it.
2427 This prevents a valgrind warning and an occasional crash at startup.
2429 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2431 * libmodest-dbus-client/libmodest-dbus-client.h:
2432 added libmodest_dbus_client_compose_mail()
2433 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2435 added functions needed for SendAsMail() functionality
2436 * src/maemo/modest-msg-edit-window.c:
2437 (modest_msg_edit_window_attach_file_noninteractive):
2438 non interactively attaching files to message edit window
2439 * src/widgets/modest-msg-edit-window.h:
2440 * tests/dbus_api/Makefile.am:
2441 added test_compose_mail.c
2442 * tests/dbus_api/test_compose_mail.c: (main):
2444 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2446 * src/modest-account-view.c:
2447 Fixed bug projects.maemo.org bug NB#59307
2449 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2451 * src/maemo/easysetup/modest-easysetup-wizard.c:
2452 (get_serverport_incoming), (on_before_next), (create_account):
2453 * src/maemo/modest-account-settings-dialog.c:
2454 (modest_account_settings_dialog_set_account_name):
2455 * src/maemo/modest-maemo-utils.c:
2456 (on_camel_account_get_supported_secure_authentication_status),
2457 (on_camel_account_get_supported_secure_authentication),
2458 (on_secure_auth_cancel),
2459 (modest_maemo_utils_get_supported_secure_authentication_methods):
2461 Implemented security authentication for settings and easysetup.
2463 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/modest-main-window.c: (create_details_widget):
2466 Show the total size for memory card accounts too, instead of showing
2467 the name again. Fixes bug projects.maemo.org bug NB#59307.
2469 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2472 * src/modest-tny-simple-folder-store.c:
2473 * src/modest-tny-simple-folder-store.h: Removed.
2475 * src/modest-tny-local-folders-account.h
2476 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2477 for the local-folders maildir, with an extra TnyMergedFolder containing
2478 the folders of the per-account outbox store accounts.
2479 * src/modest-tny-account-store.c: (get_server_accounts):
2480 Add the outboxes to the special local folders account after creating it.
2482 * src/modest-tny-account.c:
2483 (modest_tny_account_new_for_local_folders): Create the derived
2484 account when creating the main local-folders account.
2486 * src/maemo/modest-main-window.c: (create_details_widget),
2487 (modest_main_window_set_contents_style):
2488 Adapted to the use of the derived account instead of the folder store.
2490 * src/modest-ui-actions.c:
2491 (modest_ui_actions_on_folder_selection_changed):
2492 * src/modest-ui-dimming-rules.c:
2493 (modest_ui_dimming_rules_on_new_folder):
2494 * src/widgets/modest-folder-view.c: (text_cell_data),
2495 (icon_cell_data), (filter_row), (update_model),
2496 (get_cmp_rows_type_pos):
2499 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2500 Do not get the priv struct, because no priv struct has been set,
2501 to avoid a runtime warning.
2503 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2504 #ifelse with #else, to fix a warning, to fix the build.
2507 2007-06-05 Christian Kellner <ckellner@openismus.com>
2509 * libmodest-dbus-client/libmodest-dbus-client.c:
2510 Fix small typo in doc (why do you always see them
2511 AFTER committing stuff?)
2514 2007-06-05 Christian Kellner <ckellner@openismus.com>
2516 * libmodest-dbus-client/libmodest-dbus-client.c:
2517 (libmodest_dbus_client_search):
2518 Initialize hit list with NULL. Also set folder list
2519 to "" if NULL was supplied.
2522 2007-06-03 Christian Kellner <ckellner@openismus.com>
2524 * libmodest-dbus-client/libmodest-dbus-client.c:
2525 (modest_search_hit_list_free):
2526 Make it save to call it with NULL.
2528 * src/dbus_api/modest-dbus-callbacks.c:
2529 * src/modest-search.c:
2530 Return full ModestSearchHits as the search result list not TnyHeader
2531 since can't be around withouth the correspoding TnyFolder.
2533 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2535 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2536 Added currently commented code to check for secure auth
2538 * src/maemo/modest-account-settings-dialog.c: (on_response),
2539 (save_configuration), (show_ok):
2540 Fixed projects.maemo.org bugs NB #59248 and #59251
2542 * src/maemo/modest-maemo-utils.c:
2543 (on_camel_account_get_supported_secure_authentication_status),
2544 (on_camel_account_get_supported_secure_authentication),
2545 (modest_maemo_utils_get_supported_secure_authentication_methods):
2546 * src/maemo/modest-maemo-utils.h:
2547 Moved get_supported_secure_authentication() method here to be able
2548 to use it from easysetup wizard.
2550 * src/modest-pair.c: (on_pair_compare_as_string):
2551 Should compare string with first part of pair and not
2552 strcmp pairs which will crash.
2554 * src/modest-protocol-info.c:
2555 (modest_protocol_info_protocol_is_store):
2556 * src/modest-protocol-info.h:
2557 Added modest_protocol_info_get_auth_protocol_name()
2559 2007-06-03 Armin Burgmeier <armin@openismus.com>
2561 * src/modest-mail-operation.c:
2562 (modest_mail_operation_get_msgs_full): Set priv->account also when
2563 only retrieving a single message. This avoids a crash when canceling
2566 (modest_mail_operation_notify_end): Do not explicitely remove the
2567 operation from the queue but only emit the progress_changed signal.
2568 The queue itself listens to that signal to remove the operation when
2569 it is finished. This reduces coupling and removes a potential deadlock
2570 when modest_mail_operation_notify_end() is called from the queue
2571 itself. If that is a problem performance-wise, I would suggest to
2572 implement a status-changed signal or something.
2574 * src/modest-mail-operation-queue.c: Make sure to never call a
2575 function from another file while the queue is locked. This (hopefully)
2576 fixes another deadlock when exiting the application while retrieving
2579 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2581 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2582 Fixed build if libogs is not available
2584 2007-06-03 Christian Kellner <ckellner@openismus.com>
2586 * libmodest-dbus-client/libmodest-dbus-client.h:
2587 * libmodest-dbus-client/libmodest-dbus-client.c:
2588 (libmodest_dbus_client_delete_message):
2589 Implement deletion of messages (Client side).
2591 (modest_search_hit_free),
2592 (modest_search_hit_list_free):
2593 Utility functions to free the result hits.
2595 * src/dbus_api/modest-dbus-api.h:
2596 * src/dbus_api/modest-dbus-callbacks.c:
2597 (on_delete_message),
2598 (modest_dbus_req_handler):
2599 Implement deletion of messages (Server side).
2601 * tests/dbus_api/test_search.c: (main):
2604 * tests/dbus_api/Makefile.am:
2605 * tests/dbus_api/test_delete_message:
2606 Add little test for the message deletion logic
2608 2007-06-03 Armin Burgmeier <armin@openismus.com>
2610 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2611 when the operation queue was not empty. projects.maemo.org bug
2614 2007-06-03 Armin Burgmeier <armin@openismus.com>
2616 * src/widgets/modest-account-view.c
2617 (on_account_default_toggled): Toggle default account column
2618 explicitely instead of waiting for gconf notification (which is
2619 currently ignored). This should fix projects.maemo.org bug NB#56910
2620 for now. It should probably be removed when gconf notifications are
2623 2007-06-03 Christian Kellner <ckellner@openismus.com>
2625 * libmodest-dbus-client/libmodest-dbus-client.c:
2626 Removed debugging spew.
2628 * src/dbus_api/modest-dbus-callbacks.c:
2629 Added debugging info.
2631 * src/modest-search.c:
2632 (modest_search_all_accounts):
2633 Use tny_account_store_get_accounts () on the account store
2634 to get all accounts which is the way to get all accounts.
2636 * tests/dbus_api/test_search.c: (main):
2637 Make it possible to supply the search term on the command line.
2639 2007-06-03 Christian Kellner <ckellner@openismus.com>
2641 * libmodest-dbus-client/libmodest-dbus-client.c:
2642 * libmodest-dbus-client/libmodest-dbus-client.h:
2643 Implement searching for mesages over raw dbus. (Client side)
2645 * src/dbus_api/Makefile.am:
2646 * src/dbus_api/modest-dbus-api.h:
2647 * src/dbus_api/modest-dbus-callbacks.c:
2648 * src/dbus_api/modest-dbus-callbacks.h:
2649 Search framework (Server side). Also implement on_idle_open_message().
2651 * src/maemo/modest-platform.c: (modest_platform_init):
2652 Prepare for raw dbus/osso rpc interaction.
2654 * src/modest-search.h:
2655 Changed minsize from unspecific guint to guint32.
2657 * src/modest-search.c:
2659 Added strange hack which magically made tnymail work.
2661 (modest_search_folder),
2662 (modest_search_account),
2663 (modest_search_all_accounts):
2664 Implement helper functions to search all accounts, specific account
2667 * tests/dbus_api/Makefile.am:
2668 * tests/dbus_api/test_open_message.c:
2669 Read url to open from commandline.
2671 * tests/dbus_api/test_search.c:
2672 Implement small test for dbus search stuff
2674 2007-06-02 Armin Burgmeier <armin@openismus.com>
2676 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2677 include account type and account title. This fixes projects.maemo.org
2680 * src/maemo/modest-account-view-window.c: Set a title for the window.
2682 2007-06-02 Armin Burgmeier <armin@openismus.com>
2684 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2685 incoming and outgoing server name based on email address and server
2686 types as long as the names have not been edited manually. This fixes
2687 projects.maemo.org bug NB#58671.
2689 2007-06-02 Armin Burgmeier <armin@openismus.com>
2691 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2692 server type cannot be changed in future to the incoming details page
2693 when creating an account. This fixes projects.maemo.org bug NB#59029.
2695 2007-06-02 Armin Burgmeier <armin@openismus.com>
2697 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2698 and assigned max width chars so that they wrap instead of being
2699 truncated. Fixes projects.maemo.org bug NB#56126.
2701 2007-06-02 Armin Burgmeier <armin@openismus.com>
2703 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2704 introductory note to the connection specific smtp servers dialog, as
2705 section 8.12 of the email UI specification requires. This fixes
2706 projects.maemo.org bug NB#59212.
2708 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2710 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2711 Check for running mail operations, and offer to cancel them, as per the UI
2712 spec. This fixes projects.maemo.org bug NB#59041 .
2713 However, I suspect that tinymail may still use the network connection
2714 in ways that we cannot detect or cancel. But it should at least adapt to
2715 changes fairly well.
2717 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2719 * src/modest-tny-account-store.c: (recreate_all_accounts),
2720 (get_cached_accounts), (get_server_accounts): Do more sensible
2721 ref-counting of the temporarily-cached outbox accounts list. This seems
2722 to fix a crash when entering the password when the password was wrong.
2724 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2726 * src/gnome/modest-main-window.c: (connect_signals):
2727 * src/modest-tny-account-store.c: (get_password),
2728 (modest_tny_account_store_alert): Added comments and clues and
2729 commented-out code about how we currently fail to deal with connection
2730 errors and wrong passwords, and how we should.
2732 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2734 * src/widgets/modest-retrieve-combo-box.c:
2735 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2736 This fixes projects.maemo.org bug NB#58472 .
2738 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/easysetup/modest-easysetup-wizard.c:
2741 (create_page_complete_easysetup):
2742 (create_page_complete_custom): Correct the last commit,
2743 putting the correct sentences in the correct pages.
2745 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2747 * src/maemo/easysetup/modest-easysetup-wizard.c:
2748 (create_page_complete_custom): Show the second sentence of text
2749 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2754 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2755 Set the leave-on-server conf key by default. This fixes
2756 projects.maemo.org bug NB#59258 .
2758 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/modest-account-view-window.c:
2761 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2762 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2765 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/easysetup/modest-easysetup-wizard.c:
2768 (create_caption_new_with_asterisk):
2769 * src/maemo/modest-account-settings-dialog.c:
2770 (create_caption_new_with_asterisk):
2771 Uncomment the code to add the asterisk, because they are no longer in the
2772 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2773 (update_incoming_server_title): Add an asterisk here too.
2775 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2777 * src/maemo/modest-maemo-global-settings-dialog.c:
2778 (current_connection): Check that we are even connected before trying to
2779 get the current connection name, to prevent a warning.
2781 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2782 Change the comments because tny_maemo_conic_device_connect() is now meant to
2784 * src/modest-mail-operation.c:
2785 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2786 make sure we have a connection and fail if we can't connect.
2788 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2790 * src/maemo/modest-main-window.c:
2791 (on_account_store_connecting_finished): Do not try to get the
2792 connection ID if we are not really connected. I am surprised that
2793 this signal handler is called when we are not connected.
2795 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2797 * src/modest-error.h:
2798 * src/modest-ui-actions.c:
2799 (modest_ui_actions_get_msgs_full_error_handler):
2800 Renamed an enum, added comments, added an enum
2801 for retrieve-limit errors.
2803 * src/modest-mail-operation.c: (foreach_add_item),
2804 (internal_folder_observer_update), (update_account_thread),
2805 (modest_mail_operation_get_msgs_full):
2806 (modest_mail_operation_update_account),
2807 Added comments about how this works, and some code that should
2808 (but does not) check the retrieve-limit. See the TODO comment.
2810 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2812 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2813 Initialize help_id to fix the build. Warnings are good.
2815 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2817 * src/widgets/modest-hbox-cell-renderer.c:
2818 (modest_hbox_cell_renderer_append):
2819 * src/widgets/modest-vbox-cell-renderer.c:
2820 (modest_vbox_cell_renderer_append):
2821 Fix the last commit by doing an extra ref.
2823 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2825 * src/widgets/modest-hbox-cell-renderer.c:
2826 (modest_hbox_cell_renderer_append):
2827 * src/widgets/modest-vbox-cell-renderer.c:
2828 (modest_vbox_cell_renderer_append):
2829 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2830 to fix the build with Maemo Bora.
2831 However, there seems to be a remaining crash, probably due to reference
2834 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2836 * src/modest-tny-account.c:
2837 (modest_tny_account_new_for_local_folders):
2838 Use hildon_file_system_info_async_new() to get a better name for
2839 the memory card account, setting it as the account name.
2840 The timing seems to work, but this is probably
2841 not the best place to do this. See the TODO comment.
2842 * src/maemo/modest-main-window.c: (create_details_widget):
2843 * src/widgets/modest-folder-view.c: (text_cell_data):
2844 Use the tny account name instead of hardcoding a name.
2846 2007-05-30 Christian Kellner <ckellner@openismus.com>
2848 * src/modest-search.c: (modest_search):
2849 Correctly set part_search_func even if we have already parsed
2850 the query and thus a valid OgsTextSearcher object.
2852 2007-05-30 Christian Kellner <ckellner@openismus.com>
2855 Search and check for libogs.
2858 Incooparte the ogs build env.
2860 * src/modest-mime-part-search-stream.c:
2861 * src/modest-mime-part-search-stream.h:
2862 Removed since we do the real searching now in modest-search.c.
2864 * src/modest-search.c:
2865 * src/modest-search.h:
2866 Implement support for ogs. We use that if available and requested
2867 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2868 should now handle the corner case when the search term is spread
2869 across multiple reads.
2870 Also the logic in modest_search () was corrected to search all
2871 requested fields until one is found.
2873 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2875 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2877 * src/modest-init.h:
2878 * src/modest-init.c: Made modest_init_local_folders() take a
2879 path and be public so we can iniitialize maildir folders on
2882 * src/modest-local-folder-info.h:
2883 * src/modest-local-folder-info.c:
2884 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2886 * src/modest-tny-account.c:
2887 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2888 still means the standard local-folders path on the local volume.
2890 * src/modest-tny-account-store.c:
2891 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2892 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2893 all accounts when that happens.
2894 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2895 this too, so it shows up in the treeview.
2897 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/modest-maemo-global-settings-dialog.c:
2900 (current_connection):
2901 * src/widgets/modest-global-settings-dialog.c:
2902 (current_connection_default):
2903 Use the enum values instead of 0, 1 and -1,
2904 to make the code clearer.
2906 * src/modest-account-mgr-helpers.c:
2907 (modest_account_mgr_get_connection_specific_smtp): Make this code
2910 * src/modest-runtime.h:
2911 * src/modest-runtime.c:
2912 Added modest_runtime_remove_all_send_queues().
2913 * src/maemo/modest-main-window.c:
2914 (on_account_store_connecting_finished): Recreate the send queues,
2915 using the appropriate transport accounts for this new connection.
2916 Some futher adapting might be needed if the old send queues are not
2917 automatically stopped at this point.
2919 * src/modest-tny-account-store.c: (get_server_accounts):
2920 Create the connection-specific transport accounts, so that they can
2921 be found later by their ID.
2923 * src/modest-tny-account.h:
2924 * src/modest-tny-account.c:
2925 Added modest_tny_account_new_from_server_account_name().
2926 modest_tny_account_new_from_server_account(): Do not create the
2927 send queues here, because they will be
2928 recreated anyway when the connection changes for the first time.
2930 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2932 * src/modest-local-folder-info.h:
2933 * src/modest-local-folder-info.c:
2934 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2935 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2936 tbox_folder): Take a modest account name instead of a server TnyAccount,
2937 so we can have per-modest-account rather than per-transport-account
2939 We must make sure that we change or recreate the exisitng send queues
2940 when the connection changes for connection-specific transport accounts.
2942 * src/modest-tny-account-store.c:
2943 (create_per_account_local_outbox_folders): Create outboxed per modest
2944 account, not per transport account.
2946 * src/modest-tny-account.h:
2947 * src/modest-tny-account.c:
2948 (modest_tny_account_get_special_folder): For outboxes, get the
2949 parent modest account name. The account is ignored for other folders.
2950 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2951 modest account name rather than a server TnyAccount.
2953 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2955 * src/modest-tny-account.c:
2956 (modest_tny_account_new_from_server_account):
2957 Call modest_runtime_get_send_queue() immediately after creating transport
2958 accounts, so that they start trying to send email from the outbox as soon
2959 as possible at startup. This is probably what we want.
2961 * src/modest-mail-operation.c: (update_account_thread):
2962 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2963 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2964 * src/modest-tny-send-queue.h:
2965 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2966 (modest_ui_actions_on_send):
2967 Added comments about how sending works, though it needs some more work.
2969 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-tny-account.c:
2972 (modest_tny_account_get_special_folder): Add TODO because this fails when
2973 the network is busy.
2974 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2975 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2976 Do not try to show this window when there is no active account. The UI
2977 specs does not tell us what to do in this case.
2979 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2983 * src/maemo/Makefile.am:
2984 * src/widgets/Makefile.am: Some dist fixes.
2986 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2988 * src/maemo/modest-connection-specific-smtp-window.c:
2989 (on_button_edit): Make the code clearer, to prevent a double free.
2991 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2993 * src/maemo/modest-account-settings-dialog.c:
2994 (modest_account_settings_dialog_set_account_name),
2995 Check the connection-specific smtp servers checkbox if there are any.
2997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2998 (modest_connection_specific_smtp_edit_window_init):
2999 Start with a suitable port number.
3001 * src/modest-account-mgr-helpers.h:
3002 * src/modest-account-mgr-helpers.c: Added
3003 modest_account_mgr_get_has_connection_specific_smtp().
3005 (modest_account_mgr_set_connection_specific_smtp),
3006 (modest_account_mgr_remove_connection_specific_smtp),
3007 (modest_account_mgr_get_has_connection_specific_smtp),
3008 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
3009 connection-specific smtp server accounts in the account, rather than
3010 the server account conf dir.
3012 This fixes bug projects.maemo.org bug NB#58263 .
3014 * src/modest-tny-account-store.c:
3015 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3016 if there are no server accounts yet, to prevent an infinite loop when there
3017 are no accounts. Document that one must be called before the other.
3019 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3021 * src/modest-account-mgr-helpers.c:
3022 (modest_account_mgr_get_default_account): Make sure that at least
3023 one account is always the default, if there are any enabled accounts.
3024 This is just a sanity check that shouldn't be necessary.
3026 * src/modest-account-mgr-priv.c:
3027 (_modest_account_mgr_account_from_key): Unescape the conf key to
3028 get the real account name. For instance, this is an issue if a space
3029 was in the account name, which can happen because the account name
3030 is generated from the display name.
3031 (_modest_account_mgr_get_account_keyname): Always escape the
3033 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3034 Unescape the conf keys to get the real account names.
3036 For instance, previously the is-default radio button in the accounts
3037 list was not checked for any accounts at first. This fixes that,
3038 and might fix several similar bugs.
3040 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3043 Removed some debug printfs.
3045 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3047 Modest on-disk outbox directories are now here, for instance:
3048 $HOME/.modest/outboxes/<account-id-1>/outbox
3049 $HOME/.modest/outboxes/<account-id-2>/outbox
3051 $HOME/.modest/local-folders/outbox
3052 so we can have a separate outbox for each account.
3053 But they are shown as one outbox in the GtkTreeView, by using a
3054 TnyMergeFolder in a ModestTnySimpleFolderStore.
3057 * src/modest-tny-simple-folder-store.c:
3058 * src/modest-tny-simple-folder-store.h:
3059 Added ModestTnySimpleFolderStore, used to contain folders from
3060 other folder stores, such as other accounts.
3062 * src/modest-tny-outbox-account.h:
3063 * src/modest-tny-outbox-account.c:
3064 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3065 used for the per-account local outbox folders.
3067 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3068 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3069 only use this (internally) now for the non-outbox local folders.
3071 * src/modest-init.h:
3072 * src/modest-init.c: Added modest_init_one_local_folder(), for
3073 setting up the directory structure for each local folder.
3075 * src/modest-local-folder-info.c:
3076 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3077 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3079 * src/modest-local-folder-info.h:
3080 * src/modest-tny-account-store.c: (on_account_removed),
3081 (on_account_changed), (create_per_account_local_outbox_folders),
3082 (get_server_accounts), (modest_tny_account_store_get_accounts),
3083 (modest_tny_account_store_get_tny_account_by_account),
3084 (modest_tny_folder_store_is_virtual_local_folders):
3086 * src/modest-tny-account.h:
3087 * src/modest-tny-account.c:
3088 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3089 to create an on-disk per-account local outbox folder for each
3091 (create_per_account_local_outbox_folders): Create a local outbox folder
3092 for each transport account.
3093 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3094 for all local folders.
3096 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3097 instead of using g_object_get/set() directly. It is clearer.
3099 (modest_tny_folder_store_get_message_count),
3100 (modest_tny_folder_store_get_local_size
3101 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3102 because we now use these with non-acount folder stores.
3104 (modest_tny_account_get_special_folder),
3105 (modest_tny_account_new_from_server_account),
3106 (modest_tny_account_new_from_account):
3107 (recurse_folders): Adjust to the new outbox system.
3109 * src/modest-tny-folder.h:
3110 * src/modest-tny-folder.c:
3111 (modest_tny_folder_is_local_folder),
3112 (modest_tny_folder_get_local_folder_type),
3113 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3115 * src/widgets/modest-main-window.h:
3116 * src/maemo/modest-main-window.c: (create_details_widget),
3117 (modest_main_window_set_contents_style): Show details for any folder store,
3120 (modest_tny_folder_get_rules):
3121 Remove the const. C does not support constness enough for this.
3123 * src/modest-ui-actions.c:
3124 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3125 make all outboxes appear as one, in the usual local-folders tree node.
3127 (set_active_account_from_tny_account),
3128 (modest_ui_actions_on_folder_selection_changed):
3129 * src/widgets/modest-folder-view.c: (text_cell_data),
3130 (icon_cell_data), (filter_row),
3131 (add_account_folders_to_merged_folder),
3132 (add_account_folders_to_simple_folder_store), (),
3133 (get_cmp_rows_type_pos), (cmp_rows),
3134 (modest_folder_view_set_account_id_of_visible_server_account):
3135 Adjust to the new outbox system, using generic folder stores and folders
3136 in the GtkTreeModel.
3138 2007-05-23 Christian Kellner <ckellner@openismus.com>
3140 * src/modest-mail-operation.c:
3141 (modest_mail_operation_update_account):
3142 Use info->max_size instead of unintialized local var [small
3143 build fix]. (Added TODO to review that change since I don't
3146 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3148 * libmodest-dbus-client/libmodest-dbus-client.c:
3149 (libmodest_dbus_client_compose_mail): function added
3150 * src/dbus_api/modest-dbus-api.h:
3151 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3152 (on_compose_mail): Implementation of the SendAsMail functionality
3154 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3156 * src/modest-account-mgr.c:
3157 (modest_account_mgr_add_server_account): Set the secure-connection
3158 conf key for transport accounts as well as store accounts. I don't know
3159 why the if was there. For instance, this makes sure that we use SSL
3160 for the gmail preset from the easysetup wizard.
3162 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3164 * src/gnome/modest-main-window.c:
3165 (on_account_store_connecting_finished), (connect_signals):
3166 * src/maemo/modest-main-window.c:
3167 (on_account_store_connecting_finished), (connect_signals),
3168 (modest_main_window_new):
3169 Handle TnyAccountStore::connecting-finished instead of
3170 TnyDevice::connection-changed, because we cannot actually perform
3171 operations on accounts until TnyAccountStore has itself responded to
3172 the TnyDevice::connection-changed signal. This prevents a GError from
3174 Do not try to update at startup, because we (at least on scratchbox)
3175 already do an update at startup when the device goes online.
3176 This prevents a GError from tinymail.
3177 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3178 Added TODO about stopping simultaneous operations.
3180 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3182 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3183 * src/modest-mail-operation-queue.c:
3184 (modest_mail_operation_queue_remove):
3185 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3186 about where they happened.
3188 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3190 * src/modest-ui-actions.c:
3191 (modest_ui_actions_on_password_requested): Make sure that the remember
3192 output parameter is always TRUE.
3194 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3196 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3197 Show a OK/Cancel dialog if the error is a question, though we still do not
3198 know anything more about what we are asking the user.
3199 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3200 Fix an uninitialized variable (helper). This is a logic error, however.
3202 2007-05-21 Christian Kellner <ckellner@openismus.com>
3204 * src/modest-search.h:
3205 Correct bit shifting in the ModestSearchFlags enum.
3207 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3209 * src/modest-tny-account.c:
3210 (modest_tny_account_new_from_server_account): Do not use the lsub and
3211 check-all hard-coded IMAP options when using POP.
3213 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3215 * src/modest-tny-account.c:
3216 (modest_tny_account_new_from_server_account):
3217 Use NULL for the secure-auth method for POP when Password auth has been
3218 specified by the user, as we already do for IMAP. "auth=Login" causes
3219 an error from camel or the server.
3221 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3223 * src/maemo/modest-account-settings-dialog.c:
3224 (create_page_account_details),
3225 (modest_account_settings_dialog_set_account_name):
3226 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3227 for the leave-on-server checkbox, rathr than just the checkbox, when
3228 the protocol is not POP.
3230 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3232 * src/widgets/modest-account-view.c:
3233 * src/widgets/modest-account-view.h:
3234 Added modest_account_view_select_account() which will be useful later
3235 to asynchronously re-select the edited account.
3237 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3239 * src/maemo/modest-account-settings-dialog.c:
3240 (modest_account_settings_dialog_set_account_name):
3241 Automatically choose the port numbers based on the secure authentication
3242 methods, if they have not been chosen before.
3243 This fixes projects.maemo.org bug NB#56273 .
3245 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3247 * src/maemo/modest-main-window-ui.h:
3248 * src/modest-ui-actions.c:
3249 * src/modest-ui-actions.h:
3250 Connect the Tools/SMTP Servers menu item to
3251 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3252 SMTP servers dialog, as in the UI specification and saves changes when it
3253 is closed. This fixed projects.maemo.org bug NB#56305 .
3255 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3257 * src/maemo/modest-connection-specific-smtp-window.c:
3258 (modest_connection_specific_smtp_window_init):
3259 Use gtk_window_set_default_size() to make this window big enough, so
3260 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3262 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3264 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3265 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3266 (modest_connection_specific_smtp_edit_window_init),
3267 Do not try to connect to a combobox signal before the combobox exists.
3268 This fixes the cras in projects.maemo.org bug NB#56288 .
3269 (modest_connection_specific_smtp_edit_window_get_settings):
3270 Remove the server_account_name parameter which was being checked for NULL
3271 though it was not used.
3273 * src/maemo/modest-connection-specific-smtp-window.c:
3274 (modest_connection_specific_smtp_window_fill_with_connections),
3275 (on_button_edit), (modest_connection_specific_smtp_window_init):
3276 Correct the number of treemodel columns to prevent a warning.
3277 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3278 libconic does not work.
3280 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3282 * src/modest-tny-account.c:
3283 (modest_tny_account_new_from_server_account):
3284 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3285 SMTP when "None" was chosen by the user. However, with my SMTP server that
3286 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3289 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3291 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3292 to explain the memory management issue with the ID in the ModestPair.
3294 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3295 (add_sending_page), (modest_account_assistant_finalize):
3296 * src/gnome/modest-gnome-global-settings-dialog.c:
3297 (create_updating_page), (create_composing_page):
3298 * src/gnome/modest-msg-edit-window.c: (get_transports),
3299 (init_window), (modest_msg_edit_window_finalize),
3300 (modest_msg_edit_window_get_msg_data):
3301 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3302 * src/gnome/modest-transport-widget.c:
3303 (modest_transport_widget_finalize), (smtp_configuration):
3304 * src/maemo/modest-maemo-global-settings-dialog.c:
3305 (create_updating_page), (create_composing_page):
3306 * src/maemo/modest-msg-edit-window.c: (get_transports),
3307 (init_window), (modest_msg_edit_window_finalize),
3308 (modest_msg_edit_window_get_msg_data),
3309 (modest_msg_edit_window_free_msg_data):
3310 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3311 (modest_store_widget_finalize):
3312 * src/maemo/modest-transport-widget.c:
3313 (modest_transport_widget_finalize), (smtp_configuration):
3314 * src/modest-main.c: (send_mail):
3315 * src/widgets/modest-combo-box.h:
3316 * src/widgets/modest-global-settings-dialog-priv.h:
3317 * src/widgets/modest-global-settings-dialog.c:
3318 (modest_global_settings_dialog_finalize):
3319 * src/widgets/modest-msg-edit-window.h:
3320 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3321 as long as the combo box, to prevent use of freed memory for the ID.
3323 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3325 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3326 get_accounts(), to make this clearer. Do not check for the enabled gconf
3327 key, because we do not use this for server accounts (at least, not yet).
3328 This allows us to send email again.
3330 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3332 * src/maemo/modest-platform.c:
3333 (on_modest_conf_update_interval_changed), (modest_platform_init):
3334 Only respond to this particular key change. All these strcmp()s cannot be
3337 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3339 * src/maemo/modest-maemo-global-settings-dialog.c:
3340 (current_connection): Prevent a crash in scratchbox when
3341 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3342 * src/maemo/modest-platform.c:
3343 (on_modest_conf_update_interval_changed), (modest_platform_init):
3344 Get the update interval from gconf and reset it when the gconf key changes.
3346 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3348 * src/modest-protocol-info.c:
3349 * src/modest-protocol-info.h: Adde enum-specific get functions,
3350 instead of using a ModestProtocolType enum parameter.
3352 * src/gnome/modest-account-assistant.c:
3353 * src/gnome/modest-store-widget.c:
3354 * src/gnome/modest-store-widget.h:
3355 * src/gnome/modest-transport-widget.c:
3356 * src/gnome/modest-transport-widget.h:
3357 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3358 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3359 * src/maemo/easysetup/modest-easysetup-wizard.c:
3360 * src/maemo/modest-account-settings-dialog.c:
3361 * src/maemo/modest-account-settings-dialog.h:
3362 * src/maemo/modest-store-widget.c:
3363 * src/maemo/modest-store-widget.h:
3364 * src/maemo/modest-transport-widget.c:
3365 * src/maemo/modest-transport-widget.h:
3366 * src/modest-account-mgr-helpers.c:
3367 * src/modest-account-mgr-helpers.h:
3368 * src/modest-account-mgr.c:
3369 * src/modest-account-mgr.h:
3370 * src/modest-tny-account.c:
3371 * src/modest-tny-folder.c:
3372 * src/widgets/modest-account-view.c:
3373 * src/widgets/modest-retrieve-combo-box.c:
3374 * src/widgets/modest-retrieve-combo-box.h:
3375 * src/widgets/modest-secureauth-combo-box.c:
3376 * src/widgets/modest-serversecurity-combo-box.c:
3377 * src/widgets/modest-serversecurity-combo-box.h:
3378 * tests/check_account-mgr.c:
3379 Use the specific functions, and use the re-renamed enum values for GNOME too.
3381 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3383 * src/modest-pair.h:
3384 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3385 so we can get the second based on the first.
3387 * src/maemo/modest-account-settings-dialog.h:
3388 * src/maemo/modest-account-settings-dialog.c:
3389 Added get_supported_secure_authentication_methods(), though it is mostly
3390 commented-out for now until the necessary API is committed to tinymail.
3391 (modest_account_settings_dialog_set_account_name),
3392 (save_configuration): Request the supported authentication methods from the
3393 server, so we can choose a working method.
3395 * src/modest-tny-account-store.h:
3396 * src/modest-tny-account-store.c:
3397 (modest_tny_account_store_get_session): Rename from
3398 tny_account_store_get_session().
3400 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3402 * src/modest-protocol-info.h: Split the ModestProtocol enum
3403 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3404 There was no need to have these unrelated values in one enum.
3406 * src/: many files: Adapted to changed enum. This makes the code a bit
3407 clearer, and the compiler could catch some errors.
3409 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3411 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3412 Show the detailed internal camel error message when an error happens
3413 during the configuration, so that our testers can give us more clues.
3414 For instance, in projects.maemo.org bug NB#56910 .
3416 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3418 * src/modest-tny-account.c:
3419 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3420 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3422 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3424 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3425 * src/maemo/modest-account-settings-dialog.c:
3426 (modest_account_settings_dialog_set_account_name),
3427 (save_configuration): For the incoming secure authentication checkbox,
3428 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3429 the UI specification. PLAIN does not seem to be supported for most IMAP
3430 servers anyway, and I am not sure what it would mean.
3431 However, we probably need to discover which of the secure-authentication
3432 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3433 * src/modest-account-mgr-helpers.c:
3434 (modest_account_mgr_get_server_account_data):
3436 * src/modest-tny-account.c:
3437 (modest_tny_account_new_from_server_account):
3438 Use tny_account_set_mech() to set secure-authentication methods,
3439 with some special-casing for IMAP, based on my observations of how
3442 * src/modest-account-mgr-helpers.h:
3443 * src/modest-account-mgr.c:
3444 * src/modest-defs.h: Comment that the URI is only used for local folders.
3446 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3448 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3449 parameter const, just to be neat.
3450 * src/modest-text-utils.c: (modest_text_utils_inline):
3451 End g_strconcat() with NULL, as its documentation says. This is almost
3452 certainly the cause of my crash at startup on the device. Interestingly,
3453 valgrind doesn't tell us about these errors.
3455 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3457 * scripts/build-packages: Added more precise comments about how to use
3458 this script, though I still get this error:
3459 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3460 error building tinymail
3462 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3464 * src/maemo/modest-main-window.c: (on_account_update):
3465 Very slight cleanup, hoping to make it simpler to discover what causes
3466 a crash here sometimes.
3468 * src/modest-tny-account.c:
3469 (modest_tny_account_new_from_server_account): Set the port. Added
3470 comments about the options and a TODO comment because I need to find out
3471 how to specify the secure authentication method.
3473 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3475 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3476 changed CFlags paths form modest to libmodest
3478 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3480 * src/modest-account-mgr-helpers.c:
3481 (modest_account_mgr_get_server_account_data),
3482 (modest_account_mgr_free_server_account_data):
3483 * src/modest-account-mgr-helpers.h:
3484 * src/modest-account-mgr.c:
3485 (modest_account_mgr_add_server_account):
3486 * src/modest-defs.h:
3487 * src/modest-tny-account.c:
3488 (modest_tny_account_new_from_server_account):
3489 Determine the options for tny_camel_account_add_option() here,
3490 based on the settings, rather than storing them directly in gconf.
3492 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3494 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3495 Show a more friendly error dialog now that we expect (from the tinymail
3496 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3498 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3500 * src/maemo/modest-main-window.c: (on_account_update): Check that
3501 account_name is not NULL, to prevent a crash at startup that I am
3502 seeing on the N800. I do wonder why it is NULL.
3504 * src/maemo/easysetup/modest-easysetup-wizard.c:
3505 (create_page_user_details):
3506 * src/maemo/modest-account-settings-dialog.c:
3507 (create_page_user_details), (create_page_outgoing):
3508 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3509 (modest_connection_specific_smtp_edit_window_init):
3510 * src/modest-ui-actions.c:
3511 (modest_ui_actions_on_password_requested):
3512 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3513 might do something useful with the on-screen keyboard.
3515 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3517 * src/maemo/modest-main-window.c: (on_account_update):
3518 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3519 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3521 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3523 * src/modest-tny-account-store.c: (on_account_changed):
3524 Correct the signature of this signal handler.
3526 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3528 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3529 Show a HildonNote instead of a GtkDialog for Maemo.
3531 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3533 * src/widgets/modest-account-view.h:
3534 * src/widgets/modest-account-view.c: (on_account_changed),
3535 (on_account_removed). Added a boolean flag, set/unset by
3536 modest_account_view_block_conf_updates(),
3537 modest_account_view_unblock_conf_updates() to prevent unnecessary
3538 updates, but this is not very useful because the gconf notifications are
3539 so delays (maybe only on Maemo Bora).
3540 So auto-updating is turned off, and these functions do an explicit
3541 update when necessary.
3542 However, something else is still doing too much work when adding/removing
3543 accounts, probably in another part of the application.
3545 * src/maemo/modest-account-view-window.c:
3546 (on_delete_button_clicked), (on_edit_button_clicked),
3547 (on_new_button_clicked): Use the new functions.
3549 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3551 * src/modest-account-mgr-helpers.c:
3552 (modest_account_mgr_set_first_account_as_default):
3553 Sort the list of names alphabetically-by-title, so we choose the first one
3555 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3556 alphabetically by the title.
3558 This fixes projects.maemo.org bug NB#56418 .
3560 * src/modest-account-mgr-priv.c:
3561 (_modest_account_mgr_account_from_key):
3562 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3563 avoid a valgrind error, and possible random behaviour.
3565 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3567 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3568 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3569 tinymail documentation to say that this can be expected.
3570 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3571 pretty, and should not happen, but I would prefer to know when it does.
3573 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3575 * configure.ac: When using the older hildon version, probably on Bora,
3576 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3578 * src/widgets/modest-attachment-view.c:
3579 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3582 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3584 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3585 Implemented the prototype. Can be tested with
3586 tests/dbus_api/test_open_message:
3588 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3590 * src/modest-tny-account-store.c:
3591 (modest_tny_account_store_instance_init), (get_password):
3592 * src/modest-ui-actions.c:
3593 (modest_ui_actions_on_password_requested):
3594 Do not store the password in gconf, because this function is called
3595 for non-remembered passwords. Actually use the cached (in the hash map)
3596 password instead of releasing it.
3597 The password will now not be remembered if it is asked via the protected
3598 password dialog, as per the UI spec.
3600 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3602 * src/modest-defs.h:
3603 * src/modest-account-mgr-helpers.h:
3604 * src/modest-account-mgr-helpers.c:
3605 Added modest_server_account_get_username_has_succeeded(),
3606 modest_server_account_set_username_has_succeeded().
3607 (modest_server_account_set_username),
3608 Reset the has-succeeded flag if the username changes.
3610 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3611 * src/maemo/modest-connection-specific-smtp-window.c:
3612 (modest_connection_specific_smtp_window_save_server_accounts):
3613 Use modest_server_account_set_username() instead of using
3614 modest_conf_set_string() directly, so that the has-succeeded flag is always
3617 * src/modest-ui-actions.c:
3618 (modest_ui_actions_on_password_requested): Dim the username entry if
3619 the username has ever worked, as per the UI spec.
3621 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3623 * src/modest-tny-account-store.c: (get_password):
3624 * src/modest-ui-actions.c:
3625 (modest_ui_actions_on_password_requested):
3626 Allow the username to be changed too, though there is more work to
3627 be done on exactly how this behaves.
3629 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3631 * src/modest-account-mgr-helpers.h:
3632 * src/modest-account-mgr-helpers.c:
3633 Added modest_account_mgr_get_display_name(),
3634 modest_server_account_get_username(),
3635 modest_server_account_set_username(),
3636 modest_server_account_set_password(),
3637 modest_server_account_get_hostname() functions so we do not need to
3638 use the conf API directly.
3640 * src/maemo/modest-main-window.c: (connect_signals):
3641 Actually connect ot the ModestAccountStore::request-password signal,
3642 so that we show the dialog when the password is requested by Tinymail,
3643 for isntance if it is empty.
3645 * src/modest-marshal.list:
3646 * src/modest-tny-account-store.c:
3647 (modest_tny_account_store_class_init), (get_password),
3648 (modest_tny_account_store_alert):
3649 * src/modest-tny-account-store.h:
3650 * src/modest-ui-actions.h:
3651 * src/modest-ui-actions.c:
3652 (modest_ui_actions_on_password_requested):
3653 Change the signal parameters, so it is obvious that we are providing
3654 the non human-readable server name, and receiving both the username
3655 and password, though changing of the username is not yet implemented.
3656 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3657 for the GNOME version.
3659 This should fix the projects.maemo.org bug NB#56209, though it does not
3660 work on Bora, because the gconf_client_get() for the password fails
3661 immediately after we save it with gconf_client_set().
3663 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3666 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3667 caused an undefined symbol error:
3668 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3670 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3672 * src/modest-tny-account-store.c:
3673 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3674 using a GError instead of a string message, so we can translate it in
3677 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3679 * src/maemo/modest-address-book.c:
3680 (modest_address_book_check_names):
3681 * src/maemo/modest-msg-view-window.c:
3682 (modest_msg_view_window_clipboard_owner_change):
3683 * src/modest-init.c: (modest_init_init_ui):
3684 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3685 (update_folders_cb), (modest_mail_operation_update_account):
3686 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3687 (modest_ui_actions_on_msg_attachment_clicked),
3688 (modest_ui_actions_on_msg_recpt_activated):
3689 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3690 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3691 (modest_msg_view_search_next):
3692 * src/widgets/modest-recpt-editor.c:
3693 (modest_recpt_editor_on_button_release_event),
3694 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3695 g_message(). At this point we should only be seeing interesting errors on
3696 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3698 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3700 (modest_wizard_dialog_force_title_update):
3701 * src/maemo/easysetup/modest-wizard-dialog.h:
3702 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3703 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3704 can update the title when appropriate. Otherwise the title is wrong if the
3705 pages are added after adding the notebook to the dialog.
3706 This must be a problem in HildonWizardDialog too.
3707 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3709 * src/maemo/easysetup/modest-easysetup-wizard.c:
3710 (create_subsequent_customsetup_pages),
3711 (create_subsequent_easysetup_pages):
3712 Call modest_wizard_dialog_force_title_update() so that the title is
3713 correct even with GTK+ < 2.10.
3714 This fixes projects.maemo.org bug NB#56145 .
3716 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3718 * src/maemo/modest-platform.c:
3719 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3720 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3723 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3725 * src/widgets/modest-window.h:
3726 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3727 and modest_window_save_state(), which invokes it.
3729 * src/widgets/modest-window-mgr.h:
3730 * src/widgets/modest-window-mgr.c:
3731 Added modest_window_mgr_save_state_for_all_windows(), which calls
3732 the save_state vfunc on all registered windows, if implemented.
3734 * src/gnome/modest-msg-edit-window.c:
3735 * src/gnome/modest-msg-view-window.c:
3736 * src/maemo/modest-msg-edit-window.c:
3737 * src/maemo/modest-msg-view-window.c:
3738 * src/maemo/modest-main-window.c:
3739 Specify the existing save_settings functions as implementations of
3740 ModestWindow::save_state_func().
3742 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3743 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3744 enabling hibernation, for instance.
3746 We may need to do the same thing for restoring settings.
3749 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3751 * src/widgets/modest-window-mgr.c:
3752 * src/widgets/modest-window-mgr.h:
3753 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3754 modest_window_mgr_get_hibernation_is_prevented().
3756 * src/maemo/modest-main-window.c:
3757 (on_hildon_program_is_topmost_notify): Prevent hibernation
3758 (possible when the application goes to the background in the WM),
3759 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3761 * src/maemo/easysetup/modest-easysetup-wizard.c:
3762 (modest_easysetup_wizard_dialog_init):
3763 * src/maemo/modest-account-settings-dialog.c:
3764 (modest_account_settings_dialog_init):
3765 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3766 (modest_connection_specific_smtp_edit_window_init):
3767 * src/maemo/modest-connection-specific-smtp-window.c:
3768 (modest_connection_specific_smtp_window_init):
3769 * src/maemo/modest-signature-editor-dialog.c:
3770 (modest_signature_editor_dialog_init):
3771 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3772 prevent hibernation while any of these account settings dialogs are open.
3774 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3776 * src/maemo/Makefile.am:
3777 * src/maemo/modest-osso-state-saving.c:
3778 * src/maemo/modest-osso-state-saving.h: Added
3779 modest_osso_load_state() and modest_osso_save_state() though they do
3780 nothing now. They should iterate through all the open windows and load/save
3782 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3783 save state when closing.
3785 * src/maemo/modest-main-window.c:
3786 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3787 Add a notification handler for the HildonProgram::is-topmost property,
3788 so we can allow hibernation when the application goes into the background.
3789 But we still need to detect when the accounts setup windows are open so
3790 we can stop hibernation when they are open.
3791 To do this, I also added the main window the HildonProgram. This might have
3792 other side-effects/benefits, and should maybe be done for other windows.
3794 * src/maemo/modest-osso-autosave-callbacks.h:
3795 * src/maemo/modest-osso-autosave-callbacks.c:
3796 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3797 though it does not do anything yet, and we might never need this to do
3798 anything. For instance, we already save drafts.
3800 * src/maemo/modest-platform.c: (modest_platform_init):
3801 Specify the libosso auto-save callback.
3803 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3805 * src/maemo/modest-platform.c:
3806 (modest_platform_set_update_interval):
3807 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3808 aparently stays valid between application instances, so we can use this
3809 to remove and reset it later. According to a maemo-developers email from
3812 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3814 * configure.ac: Depend on libalarm for Maemo.
3816 * src/dbus_api/modest-dbus-api.h:
3817 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3818 (on_send_receive), (modest_dbus_req_handler):
3819 Handle a SEND_RECEIVE D-Bus method.
3821 * libmodest-dbus-client/libmodest-dbus-client.c:
3822 (libmodest_dbus_client_send_and_receive):
3823 * libmodest-dbus-client/libmodest-dbus-client.h:
3824 Add C convenience functions for calling the new D-Bus method.
3826 * src/modest-platform.h:
3827 * src/gnome/modest-platform.c:
3828 * src/maemo/modest-platform.c:
3829 Added modest_platform_set_update_interval(), which uses the
3830 alarmd API on Maemo.
3831 (modest_platform_init),
3832 Call modest_platform_set_update_interval(), using a hard-coded
3833 interval for now (until the global settings dialog is implemented),
3834 though I am not sure that this makes sense yet.
3836 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3838 * src/dbus_api/modest-dbus-callbacks.c:
3839 (modest_osso_cb_hw_state_handler):
3840 * src/dbus_api/modest-dbus-callbacks.h:
3841 * src/maemo/modest-platform.c: (modest_platform_init):
3842 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3843 in case this has some effect on the ability for Maemo to ping the
3846 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3848 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3849 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3850 warning. It is probably a logic error, but I need to fix the build.
3852 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3854 * src/modest-account-mgr.h:
3855 * src/modest-account-mgr.c:
3856 (modest_account_mgr_account_names): Add a gboolean enabled_only
3857 parameter, so we can get lists of onlt the enabled accounts.
3859 (modest_account_mgr_add_account),,
3860 (modest_account_mgr_account_with_display_name_exists):
3861 * src/maemo/modest-msg-edit-window.c: (get_transports):
3862 * src/modest-account-mgr-helpers.c:
3863 (modest_account_mgr_set_first_account_as_default):
3864 * src/modest-init.c: (init_default_account_maybe):
3865 * src/modest-tny-account-store.c: (get_accounts):
3866 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3867 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3868 * tests/check_account-mgr.c: (START_TEST):
3869 Provide the extra parameter, as appropriate.
3871 * src/widgets/modest-account-view.c: (update_account_view):
3872 Do not show disabled accounts (meaning that there is no way to
3873 enable/disable accounts in the UI (the feature is not in our UI
3874 specification), so we can use this internally only to mark unfinished
3875 or temporary account data.
3877 * src/maemo/easysetup/modest-easysetup-wizard.c:
3878 (create_account): Add boolean enable parameter, so we can specify FALSE
3879 to create the temporary account.
3880 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3881 (on_before_next): When finishing, when there is a temporary account, just
3883 Also, use a timeout to delay the showing of the dialog until gconf is likely
3884 to return correct information, due to a maemo gconf bug that is fixed in
3885 osso 1.1, but not yet in Bora.
3886 However, the dialog stays on screen after it is destroyed.
3888 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3889 for invalid data when cancelling. Use a hildon note instead of a dialog
3890 to complain about invalid data. Do not show the account-saved note if the
3891 account is disabled (a temporary account that will not really be saved for use
3894 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3896 * src/modest-account-mgr-helpers.h:
3897 * src/modest-account-mgr-helpers.c:
3898 Added modest_account_mgr_unset_default_account(),
3899 Added modest_account_mgr_set_first_account_as_default().
3901 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3902 If it was the default account, unset the default account name.
3904 * src/maemo/modest-account-view-window.c:
3905 (on_delete_button_clicked): If it was the default account,
3906 set the first remaining account as the default instead.
3908 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3909 a NULL account or a NULL default account, to prevent a crash. This should
3910 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3913 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3915 * src/widgets/modest-recpt-editor.c:
3916 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3917 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3918 TODO comment for this. This fixes the build.
3920 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3921 be the best place for it. This will in future update all auto-update accounts,
3922 rather than just the current/default account, when that gconf key exists.
3923 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3924 if there are no accounts, before calling do_send_receive().
3925 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3927 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3928 * src/maemo/modest-main-window-ui.h:
3929 * src/maemo/modest-main-window.c: (on_connection_changed),
3930 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3931 directly, becaue the signal handler does more.
3933 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3935 * src/modest-account-mgr-helpers.c:
3936 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3937 for the case that the account does not exist.
3939 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3940 (equivalent to the modest account name) rather than the tinymail account name
3941 (equivalent to the modest account title - human readable) to get the account data.
3942 Check for null account data to prevent the crash, and add a TODO comment saying that
3943 this needs fixing because it is using the server account name instead of the account name.
3945 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3947 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3948 * src/maemo/modest-account-settings-dialog.c: (show_error),
3950 Use hildon_note_new_information() for informative and error messages,
3951 which seems to be expected for Maemo applications (no documentation that I know of
3952 says this). I am surprised that there is no distinction between info and error
3955 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3957 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3958 it is easy to find where this is used.
3960 * src/maemo/easysetup/modest-easysetup-wizard.c:
3961 (create_page_welcome), (create_page_account_details),
3962 (create_page_user_details), (create_page_complete_easysetup),
3963 (create_page_custom_incoming), (create_page_custom_outgoing),
3964 (create_page_complete_custom):
3965 * src/maemo/modest-account-settings-dialog.c:
3966 (create_page_account_details), (create_page_user_details),
3967 (create_page_incoming), (create_page_outgoing):
3968 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3969 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3970 (modest_connection_specific_smtp_edit_window_init):
3971 * src/maemo/modest-connection-specific-smtp-window.c:
3972 (modest_connection_specific_smtp_window_init):
3973 * src/maemo/modest-signature-editor-dialog.c:
3974 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3975 and scrolling policy as per the Email Application Layout Guide, if I have
3978 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3980 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3981 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3982 which were empty, because these vfuncs have been removed from TnyAccountStore.
3983 This fixes the build.
3985 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3987 * src/maemo/modest-main-window.c:
3988 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3989 showing/hiding it. Added TODO because it probably should not be NULL.
3990 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3991 because unnecessary g_warnings() make degugging difficult.
3993 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3995 * src/maemo/modest-msg-edit-window.c:
3996 (modest_msg_edit_window_select_color),
3997 (modest_msg_edit_window_select_background_color): 2 const corrections and
3998 moving 2 #endifs before closing brackets, to fix the build.
4000 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4002 * src/maemo/easysetup/modest-easysetup-wizard.h:
4003 * src/maemo/easysetup/modest-easysetup-wizard.c:
4004 (modest_easysetup_wizard_dialog_finalize),
4005 (on_button_edit_advanced_settings), (create_page_complete_custom),
4006 (on_response), (create_account):
4007 Implement the Advanced Settings edit button, by saving the account information,
4008 for the Advanded Settings dialog to use directly from gconf, and removing it
4009 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
4010 Bug #5533 in the projects.maemo.org bugzilla.
4012 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4014 * src/maemo/modest-msg-view-window.c:
4015 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4016 when opening a message window.
4018 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4020 * src/maemo/easysetup/modest-easysetup-wizard.c:
4021 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4024 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4025 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4026 gconf settings. I probably added more checks than necessary, but that is safer.
4028 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4029 variable to fix the build, but this seems to be used when it is still NULL.
4031 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4033 * src/modest-platform.h:
4034 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4035 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4036 * src/modest-main.c: Implement this function so we can avoid using
4037 maemo-specific API from cross-platform code.
4039 * src/modest-tny-account-store.c:
4040 (get_smtp_specific_transport_account_for_open_connection):
4041 * src/modest-ui-actions.c: (check_for_connection),
4042 (modest_ui_actions_on_item_not_found):
4043 Use modest_platform_connect_and_wait() and put #idefs around other
4044 maemo-specific code, because only maemo currently has a way to
4045 identify connection names.
4047 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4049 * src/modest-tny-account-store.h:
4050 * src/modest-tny-account-store.c:
4051 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4052 the connection-specific SMTP server settings in the configuration.
4054 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4056 * src/maemo/modest-main-window.c: (on_connection_changed),
4058 * src/modest-main.c: (main), (start_ui), (send_mail):
4059 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4060 that is what is intended.
4062 * src/modest-ui-actions.c: (action_send), (action_receive),
4063 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4064 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4065 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4066 SMTP server is used when it is specified.
4068 (modest_ui_actions_on_send_receive):
4069 Check that a connection is open before proceeding.
4070 Receive and then send, instead of vice-versa, as per the specification.
4072 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4074 * src/modest-mail-operation.c:
4075 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4076 though I guess it should be something other than NULL.
4078 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4080 * src/maemo/easysetup/modest-easysetup-wizard.c:
4081 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4082 combo twice, to avoid an g_warning and to make it visible again.
4083 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4084 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4085 (already intended) dereference when detaching, because we then recreate the menu.
4086 But I am not sure why the warning was happening, and it is possible that this is a memory
4089 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4091 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4092 and uri_parse_mailto() utility functions.
4093 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4095 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4097 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4099 * src/dbus_api/modest-dbus-api.h:
4100 * src/dbus_api/modest-dbus-callbacks.c:
4101 Use an idle callback to execute the modest code in the application's own thread.
4102 Remove the helloworld example method.
4103 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4104 parsed, and the open-message method is not implemented because this is not yet implemented in
4106 * libmodest-dbus-client/libmodest-dbus-client.c:
4107 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4108 (libmodest_dbus_client_open_message):
4109 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4111 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4112 body without crashing.
4114 * tests/dbus_api/Makefile.am:
4115 * tests/dbus_api/test_mail_to.c:
4116 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4118 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4120 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4121 Added file to fix the build. Sorry.
4123 * src/dbus_api/Makefile.am:
4124 * src/dbus_api/modest-dbus-api.h:
4125 * src/dbus_api/modest-dbus-callbacks.h:
4126 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4127 (modest_dbus_req_handler):
4128 Put constants in a separate header so it can be reused by the
4129 client library, without duplication
4131 * libmodest-dbus-client/Makefile.am:
4132 * libmodest-dbus-client/libmodest-dbus-client.c:
4133 (libmodest_dbus_client_call_helloworld),
4134 (libmodfest_dbus_client_send_mail),
4135 (libmodfest_dbus_client_mailto),
4136 (libmodfest_dbus_client_open_message):
4137 * libmodest-dbus-client/libmodest-dbus-client.h:
4138 (Partly) Implement a send_mail D-Bus method.
4140 * tests/dbus_api/Makefile.am:
4141 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4142 the send_email D-Bus method.
4144 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4148 * libmodest-dbus-client/Makefile.am:
4149 * libmodest-dbus-client/libmodest-dbus-client.c:
4150 * libmodest-dbus-client/libmodest-dbus-client.h:
4151 * tests/dbus_api/Makefile.am:
4152 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4153 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4155 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4157 * src/maemo/easysetup/modest-easysetup-wizard.c:
4158 (create_page_account_details):
4159 * src/maemo/modest-account-settings-dialog.c:
4160 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4161 widgets, because this might not be the default in future versions of the Maemo GTK+.
4162 However, I can not not get capitalization to work even in a simple test case.
4164 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4166 * src/maemo/easysetup/modest-easysetup-wizard.c:
4167 (create_page_custom_incoming), (create_page_custom_outgoing):
4168 * src/maemo/modest-account-settings-dialog.c:
4169 (create_page_account_details), (create_page_incoming),
4170 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4171 instead of using gtk_check_button_with_label(), so they are aligned like the other
4172 widgets, as per the UI spec.
4174 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4176 * src/maemo/easysetup/modest-easysetup-wizard.c:
4177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4178 * src/widgets/modest-validating-entry.c:
4179 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4180 Modest prefix instead of an EasySetup prefix.
4182 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4184 * src/widgets/modest-validating-entry.h:
4185 * src/widgets/modest-validating-entry.c: (on_insert_text),
4186 Added easysetup_validating_entry_set_max_func(), used to set a callback
4187 to call when the max number of characters is reached. GtkEntry has a max-length
4188 already but is silent about it.
4190 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4191 (create_page_account_details), (create_page_user_details),
4193 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4194 (create_page_account_details), (create_page_user_details),
4195 (create_page_outgoing):
4196 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4197 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4198 the UI spec, when the user tries to enter more than the max number of characters.
4200 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4202 * src/maemo/easysetup/modest-easysetup-wizard.c:
4203 (create_page_user_details), (create_page_custom_incoming),
4204 (create_page_custom_outgoing):
4205 * src/maemo/modest-account-settings-dialog.c:
4206 (create_page_user_details), (create_page_incoming),
4207 (create_page_outgoing):
4208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4209 (modest_connection_specific_smtp_edit_window_init):
4210 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4211 not appropriate. Bad Maemo-specific defaults!.
4213 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4215 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4216 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4217 (modest_signature_editor_dialog_set_settings):
4218 Disable the label and textview when the checkbox is disabled, and use the
4219 specified (UI spec) default signature text.
4221 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4224 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4226 * src/modest-defs.h:
4227 * src/modest-account-mgr-helpers.h:
4228 * src/modest-account-mgr-helpers.c:
4229 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4231 * src/maemo/Makefile.am:
4232 * src/maemo/modest-signature-editor-dialog.c:
4233 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4236 * src/maemo/modest-account-settings-dialog.h:
4237 * src/maemo/modest-account-settings-dialog.c:
4238 (modest_account_settings_dialog_finalize), (on_button_signature),
4239 (save_configuration): Use the new dialog when the Edit button is pressed, and
4240 save the changes if necessary, as per the UI spec.
4242 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4244 * src/maemo/Makefile.am:
4245 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4246 based on maemo-develoers email from Dirk.
4248 * src/maemo/easysetup/modest-easysetup-wizard.c:
4249 (create_page_welcome), (create_page_account_details),
4250 (create_page_user_details), (create_page_complete_easysetup),
4251 (create_page_custom_incoming), (create_page_custom_outgoing),
4252 (create_page_complete_custom),
4253 (modest_easysetup_wizard_dialog_init):
4254 * src/maemo/modest-account-settings-dialog.c:
4255 (create_page_account_details), (create_page_user_details),
4256 (create_page_incoming), (create_page_outgoing),
4257 (modest_account_settings_dialog_init):
4258 * src/maemo/modest-connection-specific-smtp-window.c:
4259 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4261 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4263 * src/maemo/easysetup/modest-easysetup-wizard.c:
4264 (create_page_account_details), (create_page_custom_outgoing),
4265 (create_page_complete_custom):
4266 * src/maemo/modest-account-settings-dialog.c:
4267 (create_page_user_details), (create_page_incoming),
4268 (create_page_outgoing):
4269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4270 (modest_connection_specific_smtp_edit_window_init):
4271 Use the correct (UI spec) port min/max, and use horizontal separators,
4274 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4276 * src/maemo/easysetup/modest-easysetup-wizard.c:
4277 (set_default_custom_servernames):
4278 * src/maemo/modest-account-settings-dialog.c:
4279 (create_page_incoming), (on_combo_outgoing_security_changed),
4280 (on_combo_incoming_security_changed), (create_page_outgoing),
4281 (modest_account_settings_dialog_set_account_name),
4282 (save_configuration):
4283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4284 (on_combo_security_changed),
4285 (modest_connection_specific_smtp_edit_window_init),
4286 (modest_connection_specific_smtp_edit_window_set_connection),
4287 (modest_connection_specific_smtp_edit_window_get_settings):
4288 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4291 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4294 * src/maemo/easysetup/modest-easysetup-wizard.c:
4295 (create_page_custom_outgoing), (create_page_complete_custom):
4296 * src/maemo/modest-account-settings-dialog.c:
4297 (create_page_user_details), (create_page_outgoing):
4298 * src/maemo/modest-account-view-window.c: (button_box_new):
4299 Use changed logical IDs as per the most recent UI spec:
4300 mcen_bd_emailsetup_edit -> mcen_bd_edit
4301 mcen_bd_emailsetup_delete -> mcen_bd_delete
4302 mcen_bd_emailsetup_close -> mcen_bd_close
4304 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4308 * src/dbus_api/Makefile.am:
4309 * src/dbus_api/modest-dbus-callbacks.c:
4310 * src/dbus_api/modest-dbus-callbacks.h:
4311 * src/maemo/modest-platform.c: (modest_platform_init):
4312 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4314 * tests/Makefile.am:
4315 * tests/dbus_api/Makefile.am:
4316 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4318 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/modest-account-settings-dialog.c:
4321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4322 Removed unnecessary includes.
4324 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4326 * src/maemo/easysetup/modest-easysetup-wizard.c:
4327 * src/maemo/modest-account-settings-dialog.c:
4328 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4329 * src/widgets/Makefile.am:
4330 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4331 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4332 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4333 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4334 * src/widgets/modest-secureauth-combo-box.c:
4335 * src/widgets/modest-secureauth-combo-box.h:
4336 * src/widgets/modest-serversecurity-combo-box.c:
4337 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4338 made the GObject names more consistent with the rest of the Modest code.
4340 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4342 * src/maemo/easysetup/Makefile.am:
4343 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4344 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4345 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4346 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4347 * src/maemo/easysetup/modest-easysetup-wizard.c:
4348 * src/maemo/easysetup/modest-validating-entry.c:
4349 * src/maemo/easysetup/modest-validating-entry.h:
4350 * src/maemo/modest-account-settings-dialog.c:
4351 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4352 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4353 widgets/ because they are used outside of easysetup too. After checking in,
4354 svn will allow me to rename them too.
4356 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4358 * src/gnome/modest-msg-edit-window.c:
4359 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4360 linker error, to fix the build on the GNOME platform.
4361 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4362 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4363 ifdefed out to avoid a warning.
4365 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4367 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4368 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4369 some alternative for GTK+ 2.6.
4371 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4373 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4375 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4376 specified for EmailAccountsDialog in UI spec.
4378 * src/maemo/easysetup/modest-easysetup-wizard.c:
4379 * src/maemo/easysetup/modest-easysetup-wizard.h:
4380 * src/maemo/modest-account-settings-dialog.c:
4381 * src/maemo/modest-account-settings-dialog.h:
4382 Reuse a member window widget for the connection-specific SMTP server accounts,
4383 so we can tell it to create/save the accounts only if we actually save changes.
4385 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4386 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4387 (modest_connection_specific_smtp_edit_window_get_settings):
4388 Return a struct instance for temporarily remembering the entered data.
4390 * src/maemo/modest-connection-specific-smtp-window.h:
4391 * src/maemo/modest-connection-specific-smtp-window.c:
4392 (modest_connection_specific_smtp_window_finalize),
4393 (modest_connection_specific_smtp_window_fill_with_connections),
4395 (modest_connection_specific_smtp_window_save_server_accounts),
4396 (update_model_server_names): Do not actually save data until asked,
4397 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4399 (on_selection_changed),
4400 (modest_connection_specific_smtp_window_init): Disable the edit
4401 button when nothing is selected.
4403 * src/modest-account-mgr-helpers.c:
4404 * src/modest-account-mgr-helpers.h:
4405 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4408 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4410 * src/modest-account-mgr-helpers.h:
4411 * src/modest-account-mgr-helpers.c:
4412 (modest_account_mgr_get_unused_account_name),
4413 (modest_account_mgr_get_unused_account_display_name): Added these
4414 utility functions, to avoid code duplication.
4416 * src/maemo/easysetup/modest-easysetup-wizard.c:
4417 (create_page_account_details), (create_account):
4418 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4419 (on_combo_security_changed),
4420 (modest_connection_specific_smtp_edit_window_init),
4421 (modest_connection_specific_smtp_edit_window_save_settings):
4422 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4423 * src/maemo/modest-connection-specific-smtp-window.c:
4424 (modest_connection_specific_smtp_window_finalize),
4425 (modest_connection_specific_smtp_window_fill_with_connections),
4426 (on_button_edit), (modest_connection_specific_smtp_window_init):
4427 * src/maemo/modest-connection-specific-smtp-window.h:
4428 Implementing saving of connection-specific server accounts.
4430 But I need to refactor this so we can save the data for each
4431 possible connection-specific account and only actually create the server accounts
4432 when the easysetup finished, or the OK button is pressed on the account settings
4435 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4437 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4438 (on_combo_security_changed):
4439 (modest_connection_specific_smtp_edit_window_init):
4440 Auto-fill the port number as in the account settings.
4442 (modest_connection_specific_smtp_edit_window_set_connection):
4443 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4444 * src/maemo/modest-connection-specific-smtp-window.c:
4445 (fill_with_connections), (on_button_edit),
4446 (modest_connection_specific_smtp_window_init):
4447 Turn the edit window into a dialog to simplify the code, and
4448 set a WM hint as in a GtkDialog, because only a popup can be on top of
4449 another window in Maemo, and popups usually have no WM decoration.
4451 * src/modest-defs.h:
4452 * src/modest-account-mgr-helpers.c:
4453 (modest_account_mgr_set_connection_specific_smtp),
4454 (modest_account_mgr_remove_connection_specific_smtp),
4455 (modest_account_mgr_get_connection_specific_smtp):
4456 * src/modest-account-mgr-helpers.h: Some functions to write the
4457 connection-specific SMTP server information. Not yet used.
4460 * src/widgets/modest-folder-view.c: (text_cell_data):
4461 Fix a warning about an uninitialized variable.
4462 (on_configuration_key_changed): Put an #ifdef around the use
4463 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4465 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4467 * src/maemo/modest-account-settings-dialog.h:
4468 * src/maemo/modest-account-settings-dialog.c:
4469 Added connect_for_modified() utility function to mark the new modified boolean.
4471 (create_page_account_details), (create_page_user_details),
4472 (create_page_incoming), (create_page_outgoing), (on_response),
4473 (modest_account_settings_dialog_init),
4474 (modest_account_settings_dialog_set_account_name):
4475 Only warn about unsaved changes when there are actually unsaved changes.
4477 * src/modest-account-mgr-helpers.c:
4478 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4479 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4480 to get the data from there in future.
4482 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4484 * src/modest-defs.h:
4486 * src/modest-account-mgr-helpers.h:
4487 * src/modest-account-mgr-helpers.c:
4488 Store the security account setting in a single conf key instead of using
4489 the options list, so that the list is left for just the to-be-removed camel hack,
4490 and because gconf_client_set_list() is failing for some reason.
4492 * src/modest-account-mgr.c:
4493 (modest_account_mgr_add_server_account):
4494 * src/maemo/modest-account-settings-dialog.c:
4495 (modest_account_settings_dialog_set_account_name),
4496 (save_configuration): Use the renamed functions.
4499 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4501 * src/widgets/Makefile.am:
4502 * src/widgets/modest-limit-retrieve-combo-box.c:
4503 * src/widgets/modest-limit-retrieve-combo-box.h:
4504 * src/widgets/modest-retrieve-combo-box.c:
4505 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4506 the account settings dialog.
4508 * src/modest-defs.h:
4509 * src/modest-account-mgr-helpers.h:
4510 * src/modest-account-mgr-helpers.c:
4511 (modest_server_account_get_option_secure_auth),
4512 (modest_server_account_set_option_secure_auth):
4513 * src/modest-account-mgr.c:
4514 (modest_account_mgr_add_server_account):
4515 Use the existing AUTH_MECH conf key for the secure-auth setting,
4516 instead of putting it in the list options, because this was actually used already.
4518 * src/maemo/modest-account-settings-dialog.c:
4519 (create_page_account_details),
4520 (modest_account_settings_dialog_set_account_name),
4521 (save_configuration):
4522 * src/maemo/modest-account-settings-dialog.h:
4523 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4524 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4526 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4528 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4529 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4530 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4532 * src/modest-defs.h:
4533 * src/maemo/modest-account-settings-dialog.c:
4534 (create_page_incoming), (on_combo_outgoing_security_changed),
4535 (on_combo_incoming_security_changed), (create_page_outgoing),
4536 (modest_account_settings_dialog_set_account_name),
4537 (save_configuration): Load/Save the port number, and change it when the
4538 security combo changes, to suitable defaults.
4540 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4542 * src/modest-account-mgr.c:
4543 (modest_account_mgr_add_server_account): Set the security and secure-auth
4544 options, and add a comment saying that the other camel-specific options should be
4547 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4549 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4551 * src/modest-tny-account-store.c: (account_list_free),
4552 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4553 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4556 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4558 * src/modest-protocol-info.c:
4559 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4560 is required by our UI spec. Maybe something in our implementation will use this eventually.
4561 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4562 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4563 instead of the previous 0 placeholder.
4565 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4566 secure-auth settings.
4567 * src/modest-account-mgr-helpers.h:
4568 * src/modest-account-mgr-helpers.c:
4569 (modest_server_account_data_get_option_secure_auth),
4570 (modest_server_account_set_option_secure_auth),
4571 (modest_server_account_data_get_option_security),
4572 (modest_server_account_set_option_security): Added this API for getting and setting the security
4573 and secure-auth settings.
4575 * src/maemo/modest-account-settings-dialog.h:
4576 * src/maemo/modest-account-settings-dialog.c:
4577 (modest_account_settings_dialog_finalize), (check_data),
4578 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4579 about changing titles.
4580 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4581 (save_configuration): Save the security and secure-auth settings.
4583 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4584 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4586 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4588 * src/modest-defs.h:
4589 * src/modest-account-mgr.c:
4590 (modest_account_mgr_add_server_account):
4591 Added and used defines for the options key and value pair strings,
4592 that are used so far, though they do not seem to correspond to anything in our
4593 UI specs or ModestProtocol enum.
4595 * src/modest-account-mgr-helpers.h:
4596 * src/modest-account-mgr-helpers.c:
4597 (compare_option_strings_for_name),
4598 (modest_server_account_data_get_option_value),
4599 (modest_server_account_data_get_option_bool),
4600 (modest_account_mgr_get_server_account_option):
4601 Added helper functions for parsing the options GSList.
4603 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4605 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4606 display name is based on the supplied account name.
4607 * src/modest-account-mgr.c:
4608 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4609 with an inefficient, but good-enough, implementation.
4611 * src/maemo/easysetup/modest-easysetup-wizard.c:
4612 (create_page_account_details), (on_before_next), (create_account):
4613 Check for existing display names rather than (non-user-visible) account names, and just
4614 create and set a unique account name at the end.
4616 * src/maemo/modest-account-settings-dialog.c:
4617 (modest_account_settings_dialog_init),
4618 (modest_account_settings_dialog_set_account_name),
4619 (create_page_incoming): Show the display name, instead of the account name.
4620 (on_response): Do some (not all) extra checks, as in the UI spec.
4621 (save_configuration): Save the display name if it was changed.
4623 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4625 * po/en_GB.po: Added needed logical ID and translation.
4626 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4627 (init_view): Made the is-default column clicking work.
4629 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4632 * src/maemo/easysetup/Makefile.am:
4633 * src/maemo/easysetup/modest-easysetup-wizard.c:
4634 (modest_easysetup_wizard_dialog_init):
4635 * src/maemo/easysetup/provider-data-test.keyfile:
4636 * src/maemo/easysetup/provider-data.keyfile:
4637 Moved the provider data file to the new modest-providers-data package and used it from there.
4639 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4641 * src/modest-local-folder-info.c:
4642 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4643 N_() was already used on the static strings, but this just marks it for translation without
4644 using the translation.
4646 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4648 * src/maemo/modest-account-settings-dialog.c:
4649 (create_page_incoming),
4650 (modest_account_settings_dialog_set_account_name):
4651 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4652 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4653 I will do this if nobody else gets there first.
4655 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4657 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4658 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4659 save the security stuff.
4661 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4663 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4664 Set the email address and user fullname, which I now see must be
4667 * src/maemo/modest-account-settings-dialog.h:
4668 * src/maemo/modest-account-settings-dialog.c:
4670 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4671 leave-on-server and authentication.
4672 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4675 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4678 * src/maemo/modest-account-settings-dialog.c:
4679 * src/maemo/modest-account-settings-dialog.h:
4680 Most (but not all) of the widgets are now present as specified by the UI spec.
4681 No changes are yet saved, and some details are not properly shown yet.
4683 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4685 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4687 * src/maemo/Makefile.am:
4688 * src/maemo/modest-account-settings-dialog.c:
4689 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4690 an existing account. Doesn't do much yet.
4692 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4693 Open the accounts settings dialog when Edit is clicked.
4695 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4697 * src/maemo/easysetup/Makefile.am:
4698 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4700 * src/maemo/easysetup/modest-easysetup-wizard.c:
4701 (modest_easysetup_wizard_dialog_init):
4702 Try to get the source directory from the build system,
4703 instead of hard-coding "./" into the source code, when opening our local
4704 copies of the configuration files.
4705 But this still fails when opening the wizard from the Accounts window,
4706 maybe because the working directory seems to change at runtime.
4707 So the wizard will fail the second time unless you copy the files into their
4708 proper locations - see the stdout warnings for the paths.
4710 (create_page_account_details),(on_before_next):
4711 Check for existing non-server accounts instead of server accounts,
4712 so the default account name is useful again, and to prevent trying to
4715 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4716 Show the wizard when New is clicked.
4718 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4719 (init_view): Show the column headers, and show the columns that are
4720 specified in the UI specs. However, something in Maemo's GTK+ prevents
4721 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4722 change the default account. This is despite unsetting the special properties.
4724 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4726 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4727 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4728 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4729 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4730 to make that clearer.
4731 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4733 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4735 * src/maemo/modest-account-view-window.c:
4736 (modest_account_view_window_init),
4737 (modest_account_view_window_new):
4738 Use the same buttons as specified in the
4739 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4740 the existing widgets, which never had a chance of working.
4741 Put the ModestAccountView treeview in a scrolled window.
4742 Do not repeat the initialization in both _init() and _new().
4744 * src/widgets/modest-account-view.c: (update_account_view):
4745 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4746 this widget and window shows no accounts.
4748 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4750 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4752 * src/maemo/easysetup/modest-easysetup-wizard.c:
4753 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4754 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4755 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4758 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4759 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4760 accounts exist yet, as in the UI spec.
4762 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4764 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4766 * src/maemo/Makefile.am:
4767 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4768 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4769 New window for editing connection-specific smtp details.
4770 Not fully implemented.
4772 * src/maemo/modest-connection-specific-smtp-window.c:
4773 (modest_connection_specific_smtp_window_finalize) :
4774 unref the tree model.
4775 (on_button_edit): Show the edit window.
4777 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4779 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4782 * src/maemo/Makefile.am:
4783 * src/maemo/modest-connection-specific-smtp-window.c:
4784 * src/maemo/modest-connection-specific-smtp-window.h:
4785 New window for showing the list of connections, for connection-specific
4786 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4787 * src/maemo/easysetup/modest-easysetup-wizard.c:
4788 (create_page_custom_outgoing): Show the new window when the button is clicked.
4790 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4792 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4793 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4794 * src/maemo/modest-msg-edit-window.c:
4795 (modest_msg_edit_window_insert_image):
4796 * src/modest-conf.c: (modest_conf_key_escape):
4797 * src/modest-mail-operation.c:
4798 (modest_mail_operation_send_new_mail):
4799 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4800 (modest_ui_actions_on_new_account):
4801 * src/widgets/modest-attachment-view.c: (update_filename_request):
4802 * src/widgets/modest-mail-header-view.c:
4803 Corrected warnings that were breaking the build, by commenting out unused variables,
4804 and a function, and by including a header.
4806 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4808 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4809 so we can #ifdef around platform-specific code when necessary.
4810 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4811 to allow this to build for the GNOME platform too.
4813 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4815 * src/maemo/easysetup/modest-easysetup-wizard.c:
4816 Added util_increment_name() and used it in create_page_account_details()
4817 to make sure that the default account name is always a new name.
4819 (modest_easysetup_wizard_dialog_init),
4820 (set_default_custom_servernames): Some minor memory management fixes.
4822 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4826 * src/modest-runtime.c: (init_i18n): Restored the translation
4827 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4828 are defined in config.h, and the translations are installed.
4830 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4831 is defined for translation.
4833 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4835 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4837 * src/maemo/easysetup/modest-easysetup-wizard.c:
4838 (modest_easysetup_wizard_dialog_init):
4839 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4840 Use realistic paths (though they should use $prefix generically) to the
4841 mcc_mapping and provider-data.keyfile files which might work when they
4842 are installed by the future version of the operator-wizard package,
4843 and then fallback to paths in our source code, with an explanatory
4846 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4850 * src/maemo/Makefile.am:
4851 * src/maemo/easysetup/: Added files from the previously-exernal
4852 osso-modest-easysetup.
4853 * src/maemo/modest-main-window-ui.h:
4854 * src/modest-ui-actions.c:
4855 * src/modest-ui-actions.h:
4856 Added modest_ui_actions_on_new_account() as a signal handler for the
4857 New Account menu item. It shows the easysetup wizard.
4858 * po/en_GB.po: Added additional needed logical IDs and translations.