1 2007-06-18 Armin Burgmeier <armin@openismus.com>
3 * src/modest-tny-send-queue.h:
4 * src/modest-tny-send-queue.c: Keep track of the status of messages in
5 the queue so we can later show it in the UI. Replaced
6 modest_tny_send_queue_msg_is_being_sent() by
7 modest_tny_send_queue_get_msg_status().
9 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
11 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
12 gpointer. This probably was not harmful, but just to be sure.
14 2007-06-18 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
17 Fix the build, but leave the function broken on Bora, because
18 hildon_uri_action_get_service() does not exist.
19 osso_uri_action_get_service() does not exist either, it seems.
21 2007-06-18 Murray Cumming <murrayc@murrayc.com>
23 * src/modest-tny-account.c:
24 (modest_tny_account_new_from_server_account):
25 Uncommented the url debug output again, because it is useful for
26 debugging, as I said in the comment.
28 2007-06-18 Murray Cumming <murrayc@murrayc.com>
30 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
32 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
33 for Mameo Bora, to fix the build.
35 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
38 Fixed build with hildon < 0.99
40 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
41 Check if the selected account is busy instead of checking all accounts
43 * src/modest-account-mgr-priv.h:
44 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
45 (modest_account_mgr_init), (compare_account_name),
46 (modest_account_mgr_set_account_busy),
47 (modest_account_mgr_account_is_busy):
48 * src/modest-account-mgr.h:
49 Added busy information to the account manager. It possible to
50 set an account to busy or not busy now.
52 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
53 (modest_mail_operation_update_account),
54 (modest_mail_operation_notify_end):
55 Set the account to busy/not busy depending on the operation state.
57 * src/widgets/modest-account-view.c:
58 (modest_account_view_finalize), (get_last_updated_string),
59 (update_account_view), (on_account_busy_changed), (init_view):
60 Show string "Refreshing..." if the account is currently busy.
62 All this fixes projects.maemo.org bug NB#59711
64 2007-06-14 Armin Burgmeier <armin@openismus.com>
66 * src/widgets/modest-attachments-view.h:
67 * src/widgets/modest-attachments-view.c: Added
68 modest_attachments_view_has_attachments() and fixed coordinate
69 transformation in get_att_view_at_coords(). This fixes attachment
72 * src/widgets/modest-msg-view.c: Make use of
73 modest_attachments_view_has_attachments() to decide whether to show
74 attachments in the header.
76 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
78 * src/maemo/modest-connection-specific-smtp-edit-window.c:
79 (on_change), (on_combo_security_changed),
80 (modest_connection_specific_smtp_edit_window_init),
81 (modest_connection_specific_smtp_edit_window_set_connection),
82 (modest_connection_specific_smtp_edit_window_is_dirty):
83 * src/maemo/modest-connection-specific-smtp-edit-window.h:
84 * src/maemo/modest-connection-specific-smtp-window.c:
87 Show an comfirmation dialog for the smpt-edit-window if there are
88 unsaved changes and the user hits cancel.
89 (projects.maemo.org bug NB#60479)
91 2007-06-14 Armin Burgmeier <armin@openismus.com>
93 * src/maemo/easysetup/modest-easysetup-wizard.c:
94 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
95 address" info in banner instead of node, and select all the text as
96 per UI spec. This fixes projects.maemo.org bug NB#60550.
98 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
100 reviewed by: <delete if not using a buddy>
102 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
103 * src/modest-ui-actions.c: (folder_refreshed_cb):
105 2007-06-14 Murray Cumming <murrayc@murrayc.com>
107 * src/widgets/modest-folder-view.c: (filter_row):
108 Explictly filter out the per-account outbox accounts. I don't know why
109 these only sometimes show up, but now they should never show up in the UI.
110 This should fix projects.maemo.org bug NB#60160.
112 2007-06-14 Murray Cumming <murrayc@murrayc.com>
114 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
115 when the toolbar does not exist yet.
116 * src/modest-widget-memory.c: (save_settings_header_view):
117 Added g_warnings() to help us to discover when we are trying to set
118 an empty columns list in gconf.
120 2007-06-14 Murray Cumming <murrayc@murrayc.com>
124 Added modest_init_get_default_header_view_column_ids().
126 * src/modest-widget-memory.c: (restore_settings_header_view):
127 Use the new function to get defaults, if the gconf key is empty,
128 instead of not creating any columns. This seems to fix the
129 empty right-hand pane problems.
131 * src/widgets/modest-header-view.h: Improved documentation.
133 2007-06-13 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
136 Revert the use of the display name as the account name, because this
137 is generally wrong and would break the code that follows.
139 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
141 * src/maemo/easysetup/modest-easysetup-wizard.c:
142 (check_for_supported_auth_methods), (on_before_next),
145 More correct fix for projects.maemo.org bug NB# 58991
146 Do not longer accept AUTH_PASSWORD as secure method and choose
147 correct method when creating the account.
149 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
151 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
152 Fixed projects.maemo.org bug NB# 58991
154 2007-06-13 Murray Cumming <murrayc@murrayc.com>
156 * src/modest-init.c: (modest_init_init_core),
157 (modest_init_local_folders): Fixed compilation errors.
159 2007-06-13 Murray Cumming <murrayc@murrayc.com>
161 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
162 Remove unnecessary lib/include, though it is good in principle when needed.
164 * src/modest-init.c: (modest_init_one_local_folder),
165 (modest_init_local_folders):
166 * src/modest-init.h: Initialize the .modest library for memory cards,
167 instead of just doing nothing for them. This should allow us to create
168 folders there, fixing projects.maemo.org bug NB#59297.
170 2007-06-13 Murray Cumming <murrayc@murrayc.com>
172 * libmodest-dbus-client/libmodest-dbus-client.c:
173 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
174 (libmodest_dbus_client_compose_mail),
175 (libmodest_dbus_client_open_message),
176 (libmodest_dbus_client_send_and_receive),
177 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
179 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
180 (on_idle_open_message), (modest_dbus_req_handler),
181 (search_result_to_message), (modest_dbus_req_filter):
182 * src/modest-search.c: (add_hit), (modest_search_folder),
183 (modest_search_all_accounts): Improved debug messages.
185 * tests/dbus_api/test_open_message.c: (main): Improved comments.
187 * src/modest-tny-account-store.c:
188 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
191 2007-06-13 Murray Cumming <murrayc@murrayc.com>
194 2007-06-12 Murray Cumming <murrayc@murrayc.com>
196 * src/modest-tny-account-store.c: (get_server_accounts):
197 Call modest_tny_local_folders_account_add_merged_outbox_folders()
198 even when there are no accounts, so that the Outbox folder is always
199 visible. This fixes projects.maemo.org bug NB#60158.
201 2007-06-12 Murray Cumming <murrayc@murrayc.com>
203 * src/maemo/modest-main-window.c: (create_details_widget):
204 Use the mcen_va_never logical ID.
206 2007-06-12 Murray Cumming <murrayc@murrayc.com>
208 * src/dbus_api/modest-dbus-api.h:
209 * src/dbus_api/modest-dbus-callbacks.c:
210 (on_idle_open_default_inbox), (on_open_default_inbox),
211 (modest_dbus_req_handler):
212 Added a new OpenDefaultInbox method.
214 * libmodest-dbus-client/libmodest-dbus-client.h:
215 * libmodest-dbus-client/libmodest-dbus-client.c:
216 Added libmodest_dbus_client_open_default_inbox() to call the new
217 dbus method. This should be useful to projects.maemo.org bug NB#57214,
218 though it should maybe be used by a new osso-email-interface function.
220 * tests/dbus_api/Makefile.am:
221 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
224 2007-06-12 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
227 NULL, so that the signals get all the keys. This should not actually
228 change any behaviour because we currently update everything when anything
231 2007-06-12 Murray Cumming <murrayc@murrayc.com>
233 * src/widgets/modest-folder-view.c: (text_cell_data),
234 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
235 (find_inbox_iter): If tinymail tells us that the folder is
236 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
237 This causes the inbox to be selected at startup, fixing part of
238 projects.maemo.org bug NB#56305.
240 * src/modest-ui-dimming-rules.c:
241 (modest_ui_dimming_rules_on_tools_smtp_servers):
242 * src/modest-ui-dimming-rules.h: Added a callback function to dim
243 the SMTP servers menu item.
244 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
245 that the SMTP Servers menu item is dimmed when there are no accounts,
246 as a future version of the UI spec will require. This fixes
247 projects.maemo.org bug NB#56305.
249 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
251 * src/maemo/modest-maemo-utils.c:
252 (modest_maemo_utils_get_supported_secure_authentication_methods):
253 Added label to dialog instead of unreadable title
255 * src/maemo/modest-main-window.c: (sync_accounts_cb),
256 (modest_main_window_new):
257 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
260 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
261 * src/modest-account-mgr.h:
262 Added method to avoid code duplication
264 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
265 (modest_ui_actions_on_send_receive):
266 Use modest_account_mgr_has_accounts
268 2007-06-11 Murray Cumming <murrayc@murrayc.com>
270 * src/maemo/easysetup/modest-presets.c:
271 (modest_presets_get_info_server_security): Do not report secure auth
273 * src/modest-protocol-info.c: Use the defines for the gconf key names
274 for secure authentication. This was not working because we were writing
275 Password and reading password, and the check was case sensitive.
276 With this, gmail now works for receiving and sending when created via
279 2007-06-11 Murray Cumming <murrayc@murrayc.com>
281 * src/maemo/easysetup/modest-presets.c:
282 (modest_presets_get_info_server_security): Correct the key name for
283 SecureSmtp, because it seems to be case-sensitive.
284 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
285 Do not try to get the 0th notebook page if there are 0 pages, to
288 2007-06-11 Murray Cumming <murrayc@murrayc.com>
290 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
291 Prevent use of the new notification feature for now, because it currently
292 shows one dialog for each new email, which is annoying.
294 2007-06-11 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
297 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
298 when no country was selected, so that we show the global ones.
299 * src/maemo/easysetup/modest-presets.c:
300 (modest_presets_get_providers): Return only the global providers, not
301 all providers when mmc=0 was requested.
303 2007-06-11 Murray Cumming <murrayc@murrayc.com>
305 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
306 (easysetup_provider_combo_box_fill): Remove debug code that showed the
307 provider ID in the combo.
309 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
310 Do not show the page numbers, because it would be confusing when we add
311 the 2 extra pages for the custom setup, when the user chooses the "Other"
312 provider. This fixes projects.maemo.org bug NB#59028
314 * src/modest-init.c: (modest_init_init_core),
315 (modest_init_local_folders):
317 * src/modest-tny-account.c:
318 (modest_tny_account_new_for_local_folders): Do not create default folders
319 for the memory card. This should fix projects.maemo.org bug NB#59328.
321 2007-06-11 Murray Cumming <murrayc@murrayc.com>
323 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
324 Free the changed_conf_keys string items. They are already freed in the
325 idle handler if that runs first.
327 2007-06-11 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-ui-actions.c:
330 (modest_ui_actions_on_password_requested): Check that the server name
331 is not NULL, because I just saw a password dialog with (null) as the
334 * src/modest-tny-folder.[h|c]: Added
335 modest_tny_folder_is_memory_card_folder().
336 * src/modest-ui-dimming-rules.c:
337 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
338 menu item for memory cards, as per the UI spec (section 7.4). This should
339 fix projects.maemo.org bug NB#59297.
341 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
343 * src/maemo/modest-main-window.c: (sync_accounts_cb):
344 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
345 is another problem with the code, see Murray's comment at line 772)
347 2007-06-08 Murray Cumming <murrayc@murrayc.com>
349 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
350 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
351 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
352 (load_from_file), (easysetup_country_combo_box_init),
353 (easysetup_country_combo_box_get_active_country_ids),
354 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
355 instead of just one ID, to avoid duplicate country names in the UI.
357 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
358 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
359 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
360 a single ID, avoiding duplicate providers.
361 * src/maemo/easysetup/modest-easysetup-wizard.c:
362 (on_combo_account_country): Adapt to use a list.
364 2007-06-08 Murray Cumming <murrayc@murrayc.com>
366 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
367 keys changed in the last X seconds.
369 * src/modest-account-mgr.h:
370 * src/modest-account-mgr.c: (on_timeout_notify_changes),
371 (on_key_change), (modest_account_mgr_class_init),
372 (modest_account_mgr_init), (modest_account_mgr_finalize):
373 As the keys are changed, save them in a GSList* and signal that GSList*
374 further every X seconds, to batch changes, to allow us to do just one
375 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
376 bug NB#56941 and other (UI-blocking) delays when changing account settings.
378 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
379 changed signal signature.
381 * src/modest-conf.c: (modest_conf_set_list),
382 (modest_conf_on_change): Reenable notification.
384 (modest_conf_maemo_fake_on_change): Comment out the hack that
385 notified immediately instead of asynchronously.
387 * src/widgets/modest-account-view.h:
388 * src/widgets/modest-account-view.c:
389 (update_account_view): Select the previously-selected account ID,
390 if possible. This fixes projects.maemo.org bug NB#56933.
392 (on_account_changed), (on_account_removed),
393 (modest_account_view_select_account):
395 Remove the block/unblock functions
396 because they were not useful.
398 * src/maemo/modest-account-view-window.c:
399 (on_delete_button_clicked), (on_edit_button_clicked),
400 (on_new_button_clicked): Remove the use of the non-working block/unblock.
402 2007-06-08 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
405 Improve the error dialog to show Incorrect Account Settings, which seems
406 clearer, and say that the internal error message (to be removed from the
407 dialog later) is often misleading.
408 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
410 * src/modest-tny-account.c:
411 (modest_tny_account_new_from_server_account): Uncomment the printf of the
412 URL because this is so useful for debugging on the device.
414 * src/widgets/modest-serversecurity-combo-box.c:
415 (modest_serversecurity_combo_box_fill): Correct a logical ID.
417 2007-06-08 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-mail-operation.c:
420 (modest_mail_operation_send_new_mail):
421 Added a comment about a nasty but apparently harmless message. Details
422 added to the wiki g_warnings() page.
424 2007-06-08 Murray Cumming <murrayc@murrayc.com>
426 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
427 (modest_tny_send_queue_class_init):
428 Do not use the priv struct because it is empty, to avoid g_warnings
429 about a non-existant priv struct.
431 * src/modest-tny-account-store.c:
432 (modest_tny_account_store_get_server_account),
433 (modest_tny_account_store_get_transport_account_for_open_connection
434 ): Do not try to get transport server accounts for local folders,
435 because they don't have any. This avoids a g_warning().
437 * src/maemo/modest-main-window.c:
438 (modest_main_window_notify_send_receive_initied),
439 (on_configuration_key_changed):
440 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
442 * src/modest-mail-operation.c:
443 (modest_mail_operation_update_account):
444 * src/modest-tny-account-store.h:
445 * src/modest-tny-account.c:
446 (modest_tny_account_get_special_folder),
447 (modest_tny_account_new_for_local_folders),
448 (modest_tny_account_new_for_per_account_local_outbox_folder):
449 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
450 * src/modest-tny-local-folders-account.c:
451 (add_account_folders_to_merged_folder):
452 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
453 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
454 (modest_ui_actions_on_send):
455 * src/widgets/modest-folder-view.c: (update_model):
456 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
457 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
458 modest_tny_account_store_get_tny_account_by_account() to
459 modest_tny_account_store_get_server_account() to make the code clearer.
461 2007-06-07 Marcus Bauer <marcusb@openismus.com>
463 * src/dbus_api/modest-dbus-api.h:
464 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
465 * src/maemo/modest-msg-edit-window.c:
466 (modest_msg_edit_window_attach_file_noninteractive):
467 added g_warning in case the file to be attached does not exist
468 * tests/dbus_api/test_compose_mail.c: (main):
469 removed obsolete comment, added generic files as test case
471 2007-06-07 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-tny-account-store.c: (get_server_accounts):
474 Create the local folders account only once, not once for each outbox, and
475 not only when there are some outboxes.
477 2007-06-07 Murray Cumming <murrayc@murrayc.com>
479 * src/widgets/modest-folder-view.c: (update_model): Comment out some
480 code that is causing a crash at startup. Sergio says that he is fixing this.
482 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
484 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
485 * src/maemo/modest-account-settings-dialog.c:
486 (create_page_outgoing),
487 (modest_account_settings_dialog_set_account_name),
488 (save_configuration):
489 - Fixed handling of the "Use secure authentication" toggle to comply with
490 the ui specification. See also projects.maemo.org bug NB#58400
492 - Restore the Secure connection setting combo correctly when loading
495 * src/maemo/modest-maemo-utils.c:
496 (on_camel_account_get_supported_secure_authentication),
497 (modest_maemo_utils_get_supported_secure_authentication_methods):
498 Fixed a crasher if operation is canceled
500 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
501 (modest_protocol_info_auth_is_secure):
502 * src/modest-protocol-info.h:
504 Added two new methods to determine if a protocol/auth method is secure/encrypted in
505 the sense of the "Use secure authentication" toggle.
507 2007-06-07 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-tny-account-store.h:
510 * src/modest-tny-account-store.c:
511 Added modest_tny_account_store_get_local_folders_account().
513 * src/modest-tny-folder.h:
514 * src/modest-tny-folder.c:
515 (modest_tny_folder_get_account):
516 Added this replacement for tny_folder_get_account() which returns
517 the local-folders account for TnyMergeFolders, to avoid the
518 warning about the unimplemented get_account_func() vfunc().
520 (modest_tny_folder_get_rules),
521 * src/modest-ui-actions.c:
522 (modest_ui_actions_on_folder_selection_changed):
523 * src/modest-mail-operation.c:
524 (modest_mail_operation_remove_folder),
525 (modest_mail_operation_xfer_folder),
526 (modest_mail_operation_rename_folder),
527 (modest_mail_operation_get_msg),
528 (modest_mail_operation_get_msgs_full),
529 (modest_mail_operation_remove_msg),
530 (modest_mail_operation_xfer_msgs),
531 (modest_mail_operation_refresh_folder):
532 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
534 2007-06-07 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
537 (modest_server_account_set_security):
538 * src/modest-defs.h: Add comments explaining that our
539 UI spec means TLS when it says Normal, so these do not look like errors.
541 * src/modest-tny-account.c:
542 (modest_tny_account_new_from_server_account): Use the new tinymail
543 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
544 for TLS. This should fix projects.maemo.org bug NB#58460.
546 2007-06-06 Murray Cumming <murrayc@murrayc.com>
548 * src/maemo/easysetup/modest-easysetup-wizard.c:
549 (create_account): Correct the position of the gconf sanity check warning.
550 (on_button_edit_advanced_settings): Show the dialog immediately, instead
551 of using the g_idle_add() hack, because this does not seem to be necessary
552 on osso 1.1. It might even work on Maemo Bora if the problems were actually
553 caused by something other than maemo's gconf.
554 This fixes projects.maemo.org bug #59022.
556 2007-06-06 Murray Cumming <murrayc@murrayc.com>
558 * src/modest-account-mgr-helpers.c:
559 (modest_account_mgr_get_default_account): Do not check that the account
560 exists if there is no default account (NULL), to fix a runtime warning.
562 2007-06-06 Murray Cumming <murrayc@murrayc.com>
564 * src/widgets/modest-folder-view.c: (update_model):
565 Do not unref the treemodel before we have finished with it.
566 This prevents a valgrind warning and an occasional crash at startup.
568 2007-06-06 Marcus Bauer <marcusb@openismus.com>
570 * libmodest-dbus-client/libmodest-dbus-client.h:
571 added libmodest_dbus_client_compose_mail()
572 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
574 added functions needed for SendAsMail() functionality
575 * src/maemo/modest-msg-edit-window.c:
576 (modest_msg_edit_window_attach_file_noninteractive):
577 non interactively attaching files to message edit window
578 * src/widgets/modest-msg-edit-window.h:
579 * tests/dbus_api/Makefile.am:
580 added test_compose_mail.c
581 * tests/dbus_api/test_compose_mail.c: (main):
583 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
585 * src/modest-account-view.c:
586 Fixed bug projects.maemo.org bug NB#59307
588 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
590 * src/maemo/easysetup/modest-easysetup-wizard.c:
591 (get_serverport_incoming), (on_before_next), (create_account):
592 * src/maemo/modest-account-settings-dialog.c:
593 (modest_account_settings_dialog_set_account_name):
594 * src/maemo/modest-maemo-utils.c:
595 (on_camel_account_get_supported_secure_authentication_status),
596 (on_camel_account_get_supported_secure_authentication),
597 (on_secure_auth_cancel),
598 (modest_maemo_utils_get_supported_secure_authentication_methods):
600 Implemented security authentication for settings and easysetup.
602 2007-06-05 Murray Cumming <murrayc@murrayc.com>
604 * src/maemo/modest-main-window.c: (create_details_widget):
605 Show the total size for memory card accounts too, instead of showing
606 the name again. Fixes bug projects.maemo.org bug NB#59307.
608 2007-06-05 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-tny-simple-folder-store.c:
612 * src/modest-tny-simple-folder-store.h: Removed.
614 * src/modest-tny-local-folders-account.h
615 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
616 for the local-folders maildir, with an extra TnyMergedFolder containing
617 the folders of the per-account outbox store accounts.
618 * src/modest-tny-account-store.c: (get_server_accounts):
619 Add the outboxes to the special local folders account after creating it.
621 * src/modest-tny-account.c:
622 (modest_tny_account_new_for_local_folders): Create the derived
623 account when creating the main local-folders account.
625 * src/maemo/modest-main-window.c: (create_details_widget),
626 (modest_main_window_set_contents_style):
627 Adapted to the use of the derived account instead of the folder store.
629 * src/modest-ui-actions.c:
630 (modest_ui_actions_on_folder_selection_changed):
631 * src/modest-ui-dimming-rules.c:
632 (modest_ui_dimming_rules_on_new_folder):
633 * src/widgets/modest-folder-view.c: (text_cell_data),
634 (icon_cell_data), (filter_row), (update_model),
635 (get_cmp_rows_type_pos):
638 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
639 Do not get the priv struct, because no priv struct has been set,
640 to avoid a runtime warning.
642 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
643 #ifelse with #else, to fix a warning, to fix the build.
646 2007-06-05 Christian Kellner <ckellner@openismus.com>
648 * libmodest-dbus-client/libmodest-dbus-client.c:
649 Fix small typo in doc (why do you always see them
650 AFTER committing stuff?)
653 2007-06-05 Christian Kellner <ckellner@openismus.com>
655 * libmodest-dbus-client/libmodest-dbus-client.c:
656 (libmodest_dbus_client_search):
657 Initialize hit list with NULL. Also set folder list
658 to "" if NULL was supplied.
661 2007-06-03 Christian Kellner <ckellner@openismus.com>
663 * libmodest-dbus-client/libmodest-dbus-client.c:
664 (modest_search_hit_list_free):
665 Make it save to call it with NULL.
667 * src/dbus_api/modest-dbus-callbacks.c:
668 * src/modest-search.c:
669 Return full ModestSearchHits as the search result list not TnyHeader
670 since can't be around withouth the correspoding TnyFolder.
672 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
674 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
675 Added currently commented code to check for secure auth
677 * src/maemo/modest-account-settings-dialog.c: (on_response),
678 (save_configuration), (show_ok):
679 Fixed projects.maemo.org bugs NB #59248 and #59251
681 * src/maemo/modest-maemo-utils.c:
682 (on_camel_account_get_supported_secure_authentication_status),
683 (on_camel_account_get_supported_secure_authentication),
684 (modest_maemo_utils_get_supported_secure_authentication_methods):
685 * src/maemo/modest-maemo-utils.h:
686 Moved get_supported_secure_authentication() method here to be able
687 to use it from easysetup wizard.
689 * src/modest-pair.c: (on_pair_compare_as_string):
690 Should compare string with first part of pair and not
691 strcmp pairs which will crash.
693 * src/modest-protocol-info.c:
694 (modest_protocol_info_protocol_is_store):
695 * src/modest-protocol-info.h:
696 Added modest_protocol_info_get_auth_protocol_name()
698 2007-06-03 Armin Burgmeier <armin@openismus.com>
700 * src/modest-mail-operation.c:
701 (modest_mail_operation_get_msgs_full): Set priv->account also when
702 only retrieving a single message. This avoids a crash when canceling
705 (modest_mail_operation_notify_end): Do not explicitely remove the
706 operation from the queue but only emit the progress_changed signal.
707 The queue itself listens to that signal to remove the operation when
708 it is finished. This reduces coupling and removes a potential deadlock
709 when modest_mail_operation_notify_end() is called from the queue
710 itself. If that is a problem performance-wise, I would suggest to
711 implement a status-changed signal or something.
713 * src/modest-mail-operation-queue.c: Make sure to never call a
714 function from another file while the queue is locked. This (hopefully)
715 fixes another deadlock when exiting the application while retrieving
718 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
720 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
721 Fixed build if libogs is not available
723 2007-06-03 Christian Kellner <ckellner@openismus.com>
725 * libmodest-dbus-client/libmodest-dbus-client.h:
726 * libmodest-dbus-client/libmodest-dbus-client.c:
727 (libmodest_dbus_client_delete_message):
728 Implement deletion of messages (Client side).
730 (modest_search_hit_free),
731 (modest_search_hit_list_free):
732 Utility functions to free the result hits.
734 * src/dbus_api/modest-dbus-api.h:
735 * src/dbus_api/modest-dbus-callbacks.c:
737 (modest_dbus_req_handler):
738 Implement deletion of messages (Server side).
740 * tests/dbus_api/test_search.c: (main):
743 * tests/dbus_api/Makefile.am:
744 * tests/dbus_api/test_delete_message:
745 Add little test for the message deletion logic
747 2007-06-03 Armin Burgmeier <armin@openismus.com>
749 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
750 when the operation queue was not empty. projects.maemo.org bug
753 2007-06-03 Armin Burgmeier <armin@openismus.com>
755 * src/widgets/modest-account-view.c
756 (on_account_default_toggled): Toggle default account column
757 explicitely instead of waiting for gconf notification (which is
758 currently ignored). This should fix projects.maemo.org bug NB#56910
759 for now. It should probably be removed when gconf notifications are
762 2007-06-03 Christian Kellner <ckellner@openismus.com>
764 * libmodest-dbus-client/libmodest-dbus-client.c:
765 Removed debugging spew.
767 * src/dbus_api/modest-dbus-callbacks.c:
768 Added debugging info.
770 * src/modest-search.c:
771 (modest_search_all_accounts):
772 Use tny_account_store_get_accounts () on the account store
773 to get all accounts which is the way to get all accounts.
775 * tests/dbus_api/test_search.c: (main):
776 Make it possible to supply the search term on the command line.
778 2007-06-03 Christian Kellner <ckellner@openismus.com>
780 * libmodest-dbus-client/libmodest-dbus-client.c:
781 * libmodest-dbus-client/libmodest-dbus-client.h:
782 Implement searching for mesages over raw dbus. (Client side)
784 * src/dbus_api/Makefile.am:
785 * src/dbus_api/modest-dbus-api.h:
786 * src/dbus_api/modest-dbus-callbacks.c:
787 * src/dbus_api/modest-dbus-callbacks.h:
788 Search framework (Server side). Also implement on_idle_open_message().
790 * src/maemo/modest-platform.c: (modest_platform_init):
791 Prepare for raw dbus/osso rpc interaction.
793 * src/modest-search.h:
794 Changed minsize from unspecific guint to guint32.
796 * src/modest-search.c:
798 Added strange hack which magically made tnymail work.
800 (modest_search_folder),
801 (modest_search_account),
802 (modest_search_all_accounts):
803 Implement helper functions to search all accounts, specific account
806 * tests/dbus_api/Makefile.am:
807 * tests/dbus_api/test_open_message.c:
808 Read url to open from commandline.
810 * tests/dbus_api/test_search.c:
811 Implement small test for dbus search stuff
813 2007-06-02 Armin Burgmeier <armin@openismus.com>
815 * src/maemo/modest-account-settings-dialog.c: Changed window title to
816 include account type and account title. This fixes projects.maemo.org
819 * src/maemo/modest-account-view-window.c: Set a title for the window.
821 2007-06-02 Armin Burgmeier <armin@openismus.com>
823 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
824 incoming and outgoing server name based on email address and server
825 types as long as the names have not been edited manually. This fixes
826 projects.maemo.org bug NB#58671.
828 2007-06-02 Armin Burgmeier <armin@openismus.com>
830 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
831 server type cannot be changed in future to the incoming details page
832 when creating an account. This fixes projects.maemo.org bug NB#59029.
834 2007-06-02 Armin Burgmeier <armin@openismus.com>
836 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
837 and assigned max width chars so that they wrap instead of being
838 truncated. Fixes projects.maemo.org bug NB#56126.
840 2007-06-02 Armin Burgmeier <armin@openismus.com>
842 * src/maemo/modest-connection-specific-smtp-window.c: Add an
843 introductory note to the connection specific smtp servers dialog, as
844 section 8.12 of the email UI specification requires. This fixes
845 projects.maemo.org bug NB#59212.
847 2007-06-01 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
850 Check for running mail operations, and offer to cancel them, as per the UI
851 spec. This fixes projects.maemo.org bug NB#59041 .
852 However, I suspect that tinymail may still use the network connection
853 in ways that we cannot detect or cancel. But it should at least adapt to
856 2007-06-01 Murray Cumming <murrayc@murrayc.com>
858 * src/modest-tny-account-store.c: (recreate_all_accounts),
859 (get_cached_accounts), (get_server_accounts): Do more sensible
860 ref-counting of the temporarily-cached outbox accounts list. This seems
861 to fix a crash when entering the password when the password was wrong.
863 2007-06-01 Murray Cumming <murrayc@murrayc.com>
865 * src/gnome/modest-main-window.c: (connect_signals):
866 * src/modest-tny-account-store.c: (get_password),
867 (modest_tny_account_store_alert): Added comments and clues and
868 commented-out code about how we currently fail to deal with connection
869 errors and wrong passwords, and how we should.
871 2007-06-01 Murray Cumming <murrayc@murrayc.com>
873 * src/widgets/modest-retrieve-combo-box.c:
874 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
875 This fixes projects.maemo.org bug NB#58472 .
877 2007-06-01 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/easysetup/modest-easysetup-wizard.c:
880 (create_page_complete_easysetup):
881 (create_page_complete_custom): Correct the last commit,
882 putting the correct sentences in the correct pages.
884 2007-06-01 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-easysetup-wizard.c:
887 (create_page_complete_custom): Show the second sentence of text
888 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
891 2007-06-01 Murray Cumming <murrayc@murrayc.com>
893 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
894 Set the leave-on-server conf key by default. This fixes
895 projects.maemo.org bug NB#59258 .
897 2007-06-01 Murray Cumming <murrayc@murrayc.com>
899 * src/maemo/modest-account-view-window.c:
900 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
901 logical ID for the confirmation messages. Fixed projects.maemo.org bug
904 2007-06-01 Murray Cumming <murrayc@murrayc.com>
906 * src/maemo/easysetup/modest-easysetup-wizard.c:
907 (create_caption_new_with_asterisk):
908 * src/maemo/modest-account-settings-dialog.c:
909 (create_caption_new_with_asterisk):
910 Uncomment the code to add the asterisk, because they are no longer in the
911 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
912 (update_incoming_server_title): Add an asterisk here too.
914 2007-06-01 Murray Cumming <murrayc@murrayc.com>
916 * src/maemo/modest-maemo-global-settings-dialog.c:
917 (current_connection): Check that we are even connected before trying to
918 get the current connection name, to prevent a warning.
920 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
921 Change the comments because tny_maemo_conic_device_connect() is now meant to
923 * src/modest-mail-operation.c:
924 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
925 make sure we have a connection and fail if we can't connect.
927 2007-05-31 Murray Cumming <murrayc@murrayc.com>
929 * src/maemo/modest-main-window.c:
930 (on_account_store_connecting_finished): Do not try to get the
931 connection ID if we are not really connected. I am surprised that
932 this signal handler is called when we are not connected.
934 2007-05-31 Murray Cumming <murrayc@murrayc.com>
936 * src/modest-error.h:
937 * src/modest-ui-actions.c:
938 (modest_ui_actions_get_msgs_full_error_handler):
939 Renamed an enum, added comments, added an enum
940 for retrieve-limit errors.
942 * src/modest-mail-operation.c: (foreach_add_item),
943 (internal_folder_observer_update), (update_account_thread),
944 (modest_mail_operation_get_msgs_full):
945 (modest_mail_operation_update_account),
946 Added comments about how this works, and some code that should
947 (but does not) check the retrieve-limit. See the TODO comment.
949 2007-05-31 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
952 Initialize help_id to fix the build. Warnings are good.
954 2007-05-31 Murray Cumming <murrayc@murrayc.com>
956 * src/widgets/modest-hbox-cell-renderer.c:
957 (modest_hbox_cell_renderer_append):
958 * src/widgets/modest-vbox-cell-renderer.c:
959 (modest_vbox_cell_renderer_append):
960 Fix the last commit by doing an extra ref.
962 2007-05-31 Murray Cumming <murrayc@murrayc.com>
964 * src/widgets/modest-hbox-cell-renderer.c:
965 (modest_hbox_cell_renderer_append):
966 * src/widgets/modest-vbox-cell-renderer.c:
967 (modest_vbox_cell_renderer_append):
968 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
969 to fix the build with Maemo Bora.
970 However, there seems to be a remaining crash, probably due to reference
973 2007-05-30 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-tny-account.c:
976 (modest_tny_account_new_for_local_folders):
977 Use hildon_file_system_info_async_new() to get a better name for
978 the memory card account, setting it as the account name.
979 The timing seems to work, but this is probably
980 not the best place to do this. See the TODO comment.
981 * src/maemo/modest-main-window.c: (create_details_widget):
982 * src/widgets/modest-folder-view.c: (text_cell_data):
983 Use the tny account name instead of hardcoding a name.
985 2007-05-30 Christian Kellner <ckellner@openismus.com>
987 * src/modest-search.c: (modest_search):
988 Correctly set part_search_func even if we have already parsed
989 the query and thus a valid OgsTextSearcher object.
991 2007-05-30 Christian Kellner <ckellner@openismus.com>
994 Search and check for libogs.
997 Incooparte the ogs build env.
999 * src/modest-mime-part-search-stream.c:
1000 * src/modest-mime-part-search-stream.h:
1001 Removed since we do the real searching now in modest-search.c.
1003 * src/modest-search.c:
1004 * src/modest-search.h:
1005 Implement support for ogs. We use that if available and requested
1006 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1007 should now handle the corner case when the search term is spread
1008 across multiple reads.
1009 Also the logic in modest_search () was corrected to search all
1010 requested fields until one is found.
1012 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1014 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1016 * src/modest-init.h:
1017 * src/modest-init.c: Made modest_init_local_folders() take a
1018 path and be public so we can iniitialize maildir folders on
1021 * src/modest-local-folder-info.h:
1022 * src/modest-local-folder-info.c:
1023 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1025 * src/modest-tny-account.c:
1026 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1027 still means the standard local-folders path on the local volume.
1029 * src/modest-tny-account-store.c:
1030 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1031 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1032 all accounts when that happens.
1033 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1034 this too, so it shows up in the treeview.
1036 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1038 * src/maemo/modest-maemo-global-settings-dialog.c:
1039 (current_connection):
1040 * src/widgets/modest-global-settings-dialog.c:
1041 (current_connection_default):
1042 Use the enum values instead of 0, 1 and -1,
1043 to make the code clearer.
1045 * src/modest-account-mgr-helpers.c:
1046 (modest_account_mgr_get_connection_specific_smtp): Make this code
1049 * src/modest-runtime.h:
1050 * src/modest-runtime.c:
1051 Added modest_runtime_remove_all_send_queues().
1052 * src/maemo/modest-main-window.c:
1053 (on_account_store_connecting_finished): Recreate the send queues,
1054 using the appropriate transport accounts for this new connection.
1055 Some futher adapting might be needed if the old send queues are not
1056 automatically stopped at this point.
1058 * src/modest-tny-account-store.c: (get_server_accounts):
1059 Create the connection-specific transport accounts, so that they can
1060 be found later by their ID.
1062 * src/modest-tny-account.h:
1063 * src/modest-tny-account.c:
1064 Added modest_tny_account_new_from_server_account_name().
1065 modest_tny_account_new_from_server_account(): Do not create the
1066 send queues here, because they will be
1067 recreated anyway when the connection changes for the first time.
1069 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-local-folder-info.h:
1072 * src/modest-local-folder-info.c:
1073 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1074 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1075 tbox_folder): Take a modest account name instead of a server TnyAccount,
1076 so we can have per-modest-account rather than per-transport-account
1078 We must make sure that we change or recreate the exisitng send queues
1079 when the connection changes for connection-specific transport accounts.
1081 * src/modest-tny-account-store.c:
1082 (create_per_account_local_outbox_folders): Create outboxed per modest
1083 account, not per transport account.
1085 * src/modest-tny-account.h:
1086 * src/modest-tny-account.c:
1087 (modest_tny_account_get_special_folder): For outboxes, get the
1088 parent modest account name. The account is ignored for other folders.
1089 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1090 modest account name rather than a server TnyAccount.
1092 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1094 * src/modest-tny-account.c:
1095 (modest_tny_account_new_from_server_account):
1096 Call modest_runtime_get_send_queue() immediately after creating transport
1097 accounts, so that they start trying to send email from the outbox as soon
1098 as possible at startup. This is probably what we want.
1100 * src/modest-mail-operation.c: (update_account_thread):
1101 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1102 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1103 * src/modest-tny-send-queue.h:
1104 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1105 (modest_ui_actions_on_send):
1106 Added comments about how sending works, though it needs some more work.
1108 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-tny-account.c:
1111 (modest_tny_account_get_special_folder): Add TODO because this fails when
1112 the network is busy.
1113 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1114 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1115 Do not try to show this window when there is no active account. The UI
1116 specs does not tell us what to do in this case.
1118 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1122 * src/maemo/Makefile.am:
1123 * src/widgets/Makefile.am: Some dist fixes.
1125 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1127 * src/maemo/modest-connection-specific-smtp-window.c:
1128 (on_button_edit): Make the code clearer, to prevent a double free.
1130 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1132 * src/maemo/modest-account-settings-dialog.c:
1133 (modest_account_settings_dialog_set_account_name),
1134 Check the connection-specific smtp servers checkbox if there are any.
1136 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1137 (modest_connection_specific_smtp_edit_window_init):
1138 Start with a suitable port number.
1140 * src/modest-account-mgr-helpers.h:
1141 * src/modest-account-mgr-helpers.c: Added
1142 modest_account_mgr_get_has_connection_specific_smtp().
1144 (modest_account_mgr_set_connection_specific_smtp),
1145 (modest_account_mgr_remove_connection_specific_smtp),
1146 (modest_account_mgr_get_has_connection_specific_smtp),
1147 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1148 connection-specific smtp server accounts in the account, rather than
1149 the server account conf dir.
1151 This fixes bug projects.maemo.org bug NB#58263 .
1153 * src/modest-tny-account-store.c:
1154 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1155 if there are no server accounts yet, to prevent an infinite loop when there
1156 are no accounts. Document that one must be called before the other.
1158 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1160 * src/modest-account-mgr-helpers.c:
1161 (modest_account_mgr_get_default_account): Make sure that at least
1162 one account is always the default, if there are any enabled accounts.
1163 This is just a sanity check that shouldn't be necessary.
1165 * src/modest-account-mgr-priv.c:
1166 (_modest_account_mgr_account_from_key): Unescape the conf key to
1167 get the real account name. For instance, this is an issue if a space
1168 was in the account name, which can happen because the account name
1169 is generated from the display name.
1170 (_modest_account_mgr_get_account_keyname): Always escape the
1172 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1173 Unescape the conf keys to get the real account names.
1175 For instance, previously the is-default radio button in the accounts
1176 list was not checked for any accounts at first. This fixes that,
1177 and might fix several similar bugs.
1179 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1182 Removed some debug printfs.
1184 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1186 Modest on-disk outbox directories are now here, for instance:
1187 $HOME/.modest/outboxes/<account-id-1>/outbox
1188 $HOME/.modest/outboxes/<account-id-2>/outbox
1190 $HOME/.modest/local-folders/outbox
1191 so we can have a separate outbox for each account.
1192 But they are shown as one outbox in the GtkTreeView, by using a
1193 TnyMergeFolder in a ModestTnySimpleFolderStore.
1196 * src/modest-tny-simple-folder-store.c:
1197 * src/modest-tny-simple-folder-store.h:
1198 Added ModestTnySimpleFolderStore, used to contain folders from
1199 other folder stores, such as other accounts.
1201 * src/modest-tny-outbox-account.h:
1202 * src/modest-tny-outbox-account.c:
1203 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1204 used for the per-account local outbox folders.
1206 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1207 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1208 only use this (internally) now for the non-outbox local folders.
1210 * src/modest-init.h:
1211 * src/modest-init.c: Added modest_init_one_local_folder(), for
1212 setting up the directory structure for each local folder.
1214 * src/modest-local-folder-info.c:
1215 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1216 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1218 * src/modest-local-folder-info.h:
1219 * src/modest-tny-account-store.c: (on_account_removed),
1220 (on_account_changed), (create_per_account_local_outbox_folders),
1221 (get_server_accounts), (modest_tny_account_store_get_accounts),
1222 (modest_tny_account_store_get_tny_account_by_account),
1223 (modest_tny_folder_store_is_virtual_local_folders):
1225 * src/modest-tny-account.h:
1226 * src/modest-tny-account.c:
1227 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1228 to create an on-disk per-account local outbox folder for each
1230 (create_per_account_local_outbox_folders): Create a local outbox folder
1231 for each transport account.
1232 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1233 for all local folders.
1235 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1236 instead of using g_object_get/set() directly. It is clearer.
1238 (modest_tny_folder_store_get_message_count),
1239 (modest_tny_folder_store_get_local_size
1240 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1241 because we now use these with non-acount folder stores.
1243 (modest_tny_account_get_special_folder),
1244 (modest_tny_account_new_from_server_account),
1245 (modest_tny_account_new_from_account):
1246 (recurse_folders): Adjust to the new outbox system.
1248 * src/modest-tny-folder.h:
1249 * src/modest-tny-folder.c:
1250 (modest_tny_folder_is_local_folder),
1251 (modest_tny_folder_get_local_folder_type),
1252 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1254 * src/widgets/modest-main-window.h:
1255 * src/maemo/modest-main-window.c: (create_details_widget),
1256 (modest_main_window_set_contents_style): Show details for any folder store,
1259 (modest_tny_folder_get_rules):
1260 Remove the const. C does not support constness enough for this.
1262 * src/modest-ui-actions.c:
1263 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1264 make all outboxes appear as one, in the usual local-folders tree node.
1266 (set_active_account_from_tny_account),
1267 (modest_ui_actions_on_folder_selection_changed):
1268 * src/widgets/modest-folder-view.c: (text_cell_data),
1269 (icon_cell_data), (filter_row),
1270 (add_account_folders_to_merged_folder),
1271 (add_account_folders_to_simple_folder_store), (),
1272 (get_cmp_rows_type_pos), (cmp_rows),
1273 (modest_folder_view_set_account_id_of_visible_server_account):
1274 Adjust to the new outbox system, using generic folder stores and folders
1275 in the GtkTreeModel.
1277 2007-05-23 Christian Kellner <ckellner@openismus.com>
1279 * src/modest-mail-operation.c:
1280 (modest_mail_operation_update_account):
1281 Use info->max_size instead of unintialized local var [small
1282 build fix]. (Added TODO to review that change since I don't
1285 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1287 * libmodest-dbus-client/libmodest-dbus-client.c:
1288 (libmodest_dbus_client_compose_mail): function added
1289 * src/dbus_api/modest-dbus-api.h:
1290 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1291 (on_compose_mail): Implementation of the SendAsMail functionality
1293 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1295 * src/modest-account-mgr.c:
1296 (modest_account_mgr_add_server_account): Set the secure-connection
1297 conf key for transport accounts as well as store accounts. I don't know
1298 why the if was there. For instance, this makes sure that we use SSL
1299 for the gmail preset from the easysetup wizard.
1301 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1303 * src/gnome/modest-main-window.c:
1304 (on_account_store_connecting_finished), (connect_signals):
1305 * src/maemo/modest-main-window.c:
1306 (on_account_store_connecting_finished), (connect_signals),
1307 (modest_main_window_new):
1308 Handle TnyAccountStore::connecting-finished instead of
1309 TnyDevice::connection-changed, because we cannot actually perform
1310 operations on accounts until TnyAccountStore has itself responded to
1311 the TnyDevice::connection-changed signal. This prevents a GError from
1313 Do not try to update at startup, because we (at least on scratchbox)
1314 already do an update at startup when the device goes online.
1315 This prevents a GError from tinymail.
1316 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1317 Added TODO about stopping simultaneous operations.
1319 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1322 * src/modest-mail-operation-queue.c:
1323 (modest_mail_operation_queue_remove):
1324 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1325 about where they happened.
1327 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-ui-actions.c:
1330 (modest_ui_actions_on_password_requested): Make sure that the remember
1331 output parameter is always TRUE.
1333 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1335 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1336 Show a OK/Cancel dialog if the error is a question, though we still do not
1337 know anything more about what we are asking the user.
1338 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1339 Fix an uninitialized variable (helper). This is a logic error, however.
1341 2007-05-21 Christian Kellner <ckellner@openismus.com>
1343 * src/modest-search.h:
1344 Correct bit shifting in the ModestSearchFlags enum.
1346 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1348 * src/modest-tny-account.c:
1349 (modest_tny_account_new_from_server_account): Do not use the lsub and
1350 check-all hard-coded IMAP options when using POP.
1352 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account.c:
1355 (modest_tny_account_new_from_server_account):
1356 Use NULL for the secure-auth method for POP when Password auth has been
1357 specified by the user, as we already do for IMAP. "auth=Login" causes
1358 an error from camel or the server.
1360 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1362 * src/maemo/modest-account-settings-dialog.c:
1363 (create_page_account_details),
1364 (modest_account_settings_dialog_set_account_name):
1365 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1366 for the leave-on-server checkbox, rathr than just the checkbox, when
1367 the protocol is not POP.
1369 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1371 * src/widgets/modest-account-view.c:
1372 * src/widgets/modest-account-view.h:
1373 Added modest_account_view_select_account() which will be useful later
1374 to asynchronously re-select the edited account.
1376 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/modest-account-settings-dialog.c:
1379 (modest_account_settings_dialog_set_account_name):
1380 Automatically choose the port numbers based on the secure authentication
1381 methods, if they have not been chosen before.
1382 This fixes projects.maemo.org bug NB#56273 .
1384 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1386 * src/maemo/modest-main-window-ui.h:
1387 * src/modest-ui-actions.c:
1388 * src/modest-ui-actions.h:
1389 Connect the Tools/SMTP Servers menu item to
1390 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1391 SMTP servers dialog, as in the UI specification and saves changes when it
1392 is closed. This fixed projects.maemo.org bug NB#56305 .
1394 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1396 * src/maemo/modest-connection-specific-smtp-window.c:
1397 (modest_connection_specific_smtp_window_init):
1398 Use gtk_window_set_default_size() to make this window big enough, so
1399 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1401 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1404 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1405 (modest_connection_specific_smtp_edit_window_init),
1406 Do not try to connect to a combobox signal before the combobox exists.
1407 This fixes the cras in projects.maemo.org bug NB#56288 .
1408 (modest_connection_specific_smtp_edit_window_get_settings):
1409 Remove the server_account_name parameter which was being checked for NULL
1410 though it was not used.
1412 * src/maemo/modest-connection-specific-smtp-window.c:
1413 (modest_connection_specific_smtp_window_fill_with_connections),
1414 (on_button_edit), (modest_connection_specific_smtp_window_init):
1415 Correct the number of treemodel columns to prevent a warning.
1416 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1417 libconic does not work.
1419 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1421 * src/modest-tny-account.c:
1422 (modest_tny_account_new_from_server_account):
1423 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1424 SMTP when "None" was chosen by the user. However, with my SMTP server that
1425 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1428 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1430 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1431 to explain the memory management issue with the ID in the ModestPair.
1433 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1434 (add_sending_page), (modest_account_assistant_finalize):
1435 * src/gnome/modest-gnome-global-settings-dialog.c:
1436 (create_updating_page), (create_composing_page):
1437 * src/gnome/modest-msg-edit-window.c: (get_transports),
1438 (init_window), (modest_msg_edit_window_finalize),
1439 (modest_msg_edit_window_get_msg_data):
1440 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1441 * src/gnome/modest-transport-widget.c:
1442 (modest_transport_widget_finalize), (smtp_configuration):
1443 * src/maemo/modest-maemo-global-settings-dialog.c:
1444 (create_updating_page), (create_composing_page):
1445 * src/maemo/modest-msg-edit-window.c: (get_transports),
1446 (init_window), (modest_msg_edit_window_finalize),
1447 (modest_msg_edit_window_get_msg_data),
1448 (modest_msg_edit_window_free_msg_data):
1449 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1450 (modest_store_widget_finalize):
1451 * src/maemo/modest-transport-widget.c:
1452 (modest_transport_widget_finalize), (smtp_configuration):
1453 * src/modest-main.c: (send_mail):
1454 * src/widgets/modest-combo-box.h:
1455 * src/widgets/modest-global-settings-dialog-priv.h:
1456 * src/widgets/modest-global-settings-dialog.c:
1457 (modest_global_settings_dialog_finalize):
1458 * src/widgets/modest-msg-edit-window.h:
1459 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1460 as long as the combo box, to prevent use of freed memory for the ID.
1462 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1465 get_accounts(), to make this clearer. Do not check for the enabled gconf
1466 key, because we do not use this for server accounts (at least, not yet).
1467 This allows us to send email again.
1469 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1471 * src/maemo/modest-platform.c:
1472 (on_modest_conf_update_interval_changed), (modest_platform_init):
1473 Only respond to this particular key change. All these strcmp()s cannot be
1476 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1478 * src/maemo/modest-maemo-global-settings-dialog.c:
1479 (current_connection): Prevent a crash in scratchbox when
1480 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1481 * src/maemo/modest-platform.c:
1482 (on_modest_conf_update_interval_changed), (modest_platform_init):
1483 Get the update interval from gconf and reset it when the gconf key changes.
1485 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1487 * src/modest-protocol-info.c:
1488 * src/modest-protocol-info.h: Adde enum-specific get functions,
1489 instead of using a ModestProtocolType enum parameter.
1491 * src/gnome/modest-account-assistant.c:
1492 * src/gnome/modest-store-widget.c:
1493 * src/gnome/modest-store-widget.h:
1494 * src/gnome/modest-transport-widget.c:
1495 * src/gnome/modest-transport-widget.h:
1496 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1497 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1498 * src/maemo/easysetup/modest-easysetup-wizard.c:
1499 * src/maemo/modest-account-settings-dialog.c:
1500 * src/maemo/modest-account-settings-dialog.h:
1501 * src/maemo/modest-store-widget.c:
1502 * src/maemo/modest-store-widget.h:
1503 * src/maemo/modest-transport-widget.c:
1504 * src/maemo/modest-transport-widget.h:
1505 * src/modest-account-mgr-helpers.c:
1506 * src/modest-account-mgr-helpers.h:
1507 * src/modest-account-mgr.c:
1508 * src/modest-account-mgr.h:
1509 * src/modest-tny-account.c:
1510 * src/modest-tny-folder.c:
1511 * src/widgets/modest-account-view.c:
1512 * src/widgets/modest-retrieve-combo-box.c:
1513 * src/widgets/modest-retrieve-combo-box.h:
1514 * src/widgets/modest-secureauth-combo-box.c:
1515 * src/widgets/modest-serversecurity-combo-box.c:
1516 * src/widgets/modest-serversecurity-combo-box.h:
1517 * tests/check_account-mgr.c:
1518 Use the specific functions, and use the re-renamed enum values for GNOME too.
1520 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1522 * src/modest-pair.h:
1523 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1524 so we can get the second based on the first.
1526 * src/maemo/modest-account-settings-dialog.h:
1527 * src/maemo/modest-account-settings-dialog.c:
1528 Added get_supported_secure_authentication_methods(), though it is mostly
1529 commented-out for now until the necessary API is committed to tinymail.
1530 (modest_account_settings_dialog_set_account_name),
1531 (save_configuration): Request the supported authentication methods from the
1532 server, so we can choose a working method.
1534 * src/modest-tny-account-store.h:
1535 * src/modest-tny-account-store.c:
1536 (modest_tny_account_store_get_session): Rename from
1537 tny_account_store_get_session().
1539 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1541 * src/modest-protocol-info.h: Split the ModestProtocol enum
1542 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1543 There was no need to have these unrelated values in one enum.
1545 * src/: many files: Adapted to changed enum. This makes the code a bit
1546 clearer, and the compiler could catch some errors.
1548 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1550 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1551 Show the detailed internal camel error message when an error happens
1552 during the configuration, so that our testers can give us more clues.
1553 For instance, in projects.maemo.org bug NB#56910 .
1555 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-tny-account.c:
1558 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1559 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1561 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1564 * src/maemo/modest-account-settings-dialog.c:
1565 (modest_account_settings_dialog_set_account_name),
1566 (save_configuration): For the incoming secure authentication checkbox,
1567 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1568 the UI specification. PLAIN does not seem to be supported for most IMAP
1569 servers anyway, and I am not sure what it would mean.
1570 However, we probably need to discover which of the secure-authentication
1571 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1572 * src/modest-account-mgr-helpers.c:
1573 (modest_account_mgr_get_server_account_data):
1575 * src/modest-tny-account.c:
1576 (modest_tny_account_new_from_server_account):
1577 Use tny_account_set_mech() to set secure-authentication methods,
1578 with some special-casing for IMAP, based on my observations of how
1581 * src/modest-account-mgr-helpers.h:
1582 * src/modest-account-mgr.c:
1583 * src/modest-defs.h: Comment that the URI is only used for local folders.
1585 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1588 parameter const, just to be neat.
1589 * src/modest-text-utils.c: (modest_text_utils_inline):
1590 End g_strconcat() with NULL, as its documentation says. This is almost
1591 certainly the cause of my crash at startup on the device. Interestingly,
1592 valgrind doesn't tell us about these errors.
1594 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1596 * scripts/build-packages: Added more precise comments about how to use
1597 this script, though I still get this error:
1598 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1599 error building tinymail
1601 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1603 * src/maemo/modest-main-window.c: (on_account_update):
1604 Very slight cleanup, hoping to make it simpler to discover what causes
1605 a crash here sometimes.
1607 * src/modest-tny-account.c:
1608 (modest_tny_account_new_from_server_account): Set the port. Added
1609 comments about the options and a TODO comment because I need to find out
1610 how to specify the secure authentication method.
1612 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1614 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1615 changed CFlags paths form modest to libmodest
1617 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1619 * src/modest-account-mgr-helpers.c:
1620 (modest_account_mgr_get_server_account_data),
1621 (modest_account_mgr_free_server_account_data):
1622 * src/modest-account-mgr-helpers.h:
1623 * src/modest-account-mgr.c:
1624 (modest_account_mgr_add_server_account):
1625 * src/modest-defs.h:
1626 * src/modest-tny-account.c:
1627 (modest_tny_account_new_from_server_account):
1628 Determine the options for tny_camel_account_add_option() here,
1629 based on the settings, rather than storing them directly in gconf.
1631 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1633 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1634 Show a more friendly error dialog now that we expect (from the tinymail
1635 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1637 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1639 * src/maemo/modest-main-window.c: (on_account_update): Check that
1640 account_name is not NULL, to prevent a crash at startup that I am
1641 seeing on the N800. I do wonder why it is NULL.
1643 * src/maemo/easysetup/modest-easysetup-wizard.c:
1644 (create_page_user_details):
1645 * src/maemo/modest-account-settings-dialog.c:
1646 (create_page_user_details), (create_page_outgoing):
1647 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1648 (modest_connection_specific_smtp_edit_window_init):
1649 * src/modest-ui-actions.c:
1650 (modest_ui_actions_on_password_requested):
1651 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1652 might do something useful with the on-screen keyboard.
1654 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/modest-main-window.c: (on_account_update):
1657 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1658 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1660 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1662 * src/modest-tny-account-store.c: (on_account_changed):
1663 Correct the signature of this signal handler.
1665 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1668 Show a HildonNote instead of a GtkDialog for Maemo.
1670 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1672 * src/widgets/modest-account-view.h:
1673 * src/widgets/modest-account-view.c: (on_account_changed),
1674 (on_account_removed). Added a boolean flag, set/unset by
1675 modest_account_view_block_conf_updates(),
1676 modest_account_view_unblock_conf_updates() to prevent unnecessary
1677 updates, but this is not very useful because the gconf notifications are
1678 so delays (maybe only on Maemo Bora).
1679 So auto-updating is turned off, and these functions do an explicit
1680 update when necessary.
1681 However, something else is still doing too much work when adding/removing
1682 accounts, probably in another part of the application.
1684 * src/maemo/modest-account-view-window.c:
1685 (on_delete_button_clicked), (on_edit_button_clicked),
1686 (on_new_button_clicked): Use the new functions.
1688 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1690 * src/modest-account-mgr-helpers.c:
1691 (modest_account_mgr_set_first_account_as_default):
1692 Sort the list of names alphabetically-by-title, so we choose the first one
1694 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1695 alphabetically by the title.
1697 This fixes projects.maemo.org bug NB#56418 .
1699 * src/modest-account-mgr-priv.c:
1700 (_modest_account_mgr_account_from_key):
1701 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1702 avoid a valgrind error, and possible random behaviour.
1704 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1706 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1707 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1708 tinymail documentation to say that this can be expected.
1709 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1710 pretty, and should not happen, but I would prefer to know when it does.
1712 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1714 * configure.ac: When using the older hildon version, probably on Bora,
1715 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1717 * src/widgets/modest-attachment-view.c:
1718 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1721 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1723 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1724 Implemented the prototype. Can be tested with
1725 tests/dbus_api/test_open_message:
1727 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1729 * src/modest-tny-account-store.c:
1730 (modest_tny_account_store_instance_init), (get_password):
1731 * src/modest-ui-actions.c:
1732 (modest_ui_actions_on_password_requested):
1733 Do not store the password in gconf, because this function is called
1734 for non-remembered passwords. Actually use the cached (in the hash map)
1735 password instead of releasing it.
1736 The password will now not be remembered if it is asked via the protected
1737 password dialog, as per the UI spec.
1739 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1741 * src/modest-defs.h:
1742 * src/modest-account-mgr-helpers.h:
1743 * src/modest-account-mgr-helpers.c:
1744 Added modest_server_account_get_username_has_succeeded(),
1745 modest_server_account_set_username_has_succeeded().
1746 (modest_server_account_set_username),
1747 Reset the has-succeeded flag if the username changes.
1749 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1750 * src/maemo/modest-connection-specific-smtp-window.c:
1751 (modest_connection_specific_smtp_window_save_server_accounts):
1752 Use modest_server_account_set_username() instead of using
1753 modest_conf_set_string() directly, so that the has-succeeded flag is always
1756 * src/modest-ui-actions.c:
1757 (modest_ui_actions_on_password_requested): Dim the username entry if
1758 the username has ever worked, as per the UI spec.
1760 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1762 * src/modest-tny-account-store.c: (get_password):
1763 * src/modest-ui-actions.c:
1764 (modest_ui_actions_on_password_requested):
1765 Allow the username to be changed too, though there is more work to
1766 be done on exactly how this behaves.
1768 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-account-mgr-helpers.h:
1771 * src/modest-account-mgr-helpers.c:
1772 Added modest_account_mgr_get_display_name(),
1773 modest_server_account_get_username(),
1774 modest_server_account_set_username(),
1775 modest_server_account_set_password(),
1776 modest_server_account_get_hostname() functions so we do not need to
1777 use the conf API directly.
1779 * src/maemo/modest-main-window.c: (connect_signals):
1780 Actually connect ot the ModestAccountStore::request-password signal,
1781 so that we show the dialog when the password is requested by Tinymail,
1782 for isntance if it is empty.
1784 * src/modest-marshal.list:
1785 * src/modest-tny-account-store.c:
1786 (modest_tny_account_store_class_init), (get_password),
1787 (modest_tny_account_store_alert):
1788 * src/modest-tny-account-store.h:
1789 * src/modest-ui-actions.h:
1790 * src/modest-ui-actions.c:
1791 (modest_ui_actions_on_password_requested):
1792 Change the signal parameters, so it is obvious that we are providing
1793 the non human-readable server name, and receiving both the username
1794 and password, though changing of the username is not yet implemented.
1795 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1796 for the GNOME version.
1798 This should fix the projects.maemo.org bug NB#56209, though it does not
1799 work on Bora, because the gconf_client_get() for the password fails
1800 immediately after we save it with gconf_client_set().
1802 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1805 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1806 caused an undefined symbol error:
1807 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1809 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1811 * src/modest-tny-account-store.c:
1812 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1813 using a GError instead of a string message, so we can translate it in
1816 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/modest-address-book.c:
1819 (modest_address_book_check_names):
1820 * src/maemo/modest-msg-view-window.c:
1821 (modest_msg_view_window_clipboard_owner_change):
1822 * src/modest-init.c: (modest_init_init_ui):
1823 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1824 (update_folders_cb), (modest_mail_operation_update_account):
1825 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1826 (modest_ui_actions_on_msg_attachment_clicked),
1827 (modest_ui_actions_on_msg_recpt_activated):
1828 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1829 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1830 (modest_msg_view_search_next):
1831 * src/widgets/modest-recpt-editor.c:
1832 (modest_recpt_editor_on_button_release_event),
1833 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1834 g_message(). At this point we should only be seeing interesting errors on
1835 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1837 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1839 (modest_wizard_dialog_force_title_update):
1840 * src/maemo/easysetup/modest-wizard-dialog.h:
1841 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1842 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1843 can update the title when appropriate. Otherwise the title is wrong if the
1844 pages are added after adding the notebook to the dialog.
1845 This must be a problem in HildonWizardDialog too.
1846 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1848 * src/maemo/easysetup/modest-easysetup-wizard.c:
1849 (create_subsequent_customsetup_pages),
1850 (create_subsequent_easysetup_pages):
1851 Call modest_wizard_dialog_force_title_update() so that the title is
1852 correct even with GTK+ < 2.10.
1853 This fixes projects.maemo.org bug NB#56145 .
1855 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1857 * src/maemo/modest-platform.c:
1858 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1859 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1862 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1864 * src/widgets/modest-window.h:
1865 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1866 and modest_window_save_state(), which invokes it.
1868 * src/widgets/modest-window-mgr.h:
1869 * src/widgets/modest-window-mgr.c:
1870 Added modest_window_mgr_save_state_for_all_windows(), which calls
1871 the save_state vfunc on all registered windows, if implemented.
1873 * src/gnome/modest-msg-edit-window.c:
1874 * src/gnome/modest-msg-view-window.c:
1875 * src/maemo/modest-msg-edit-window.c:
1876 * src/maemo/modest-msg-view-window.c:
1877 * src/maemo/modest-main-window.c:
1878 Specify the existing save_settings functions as implementations of
1879 ModestWindow::save_state_func().
1881 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1882 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1883 enabling hibernation, for instance.
1885 We may need to do the same thing for restoring settings.
1888 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1890 * src/widgets/modest-window-mgr.c:
1891 * src/widgets/modest-window-mgr.h:
1892 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1893 modest_window_mgr_get_hibernation_is_prevented().
1895 * src/maemo/modest-main-window.c:
1896 (on_hildon_program_is_topmost_notify): Prevent hibernation
1897 (possible when the application goes to the background in the WM),
1898 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1900 * src/maemo/easysetup/modest-easysetup-wizard.c:
1901 (modest_easysetup_wizard_dialog_init):
1902 * src/maemo/modest-account-settings-dialog.c:
1903 (modest_account_settings_dialog_init):
1904 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1905 (modest_connection_specific_smtp_edit_window_init):
1906 * src/maemo/modest-connection-specific-smtp-window.c:
1907 (modest_connection_specific_smtp_window_init):
1908 * src/maemo/modest-signature-editor-dialog.c:
1909 (modest_signature_editor_dialog_init):
1910 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1911 prevent hibernation while any of these account settings dialogs are open.
1913 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/Makefile.am:
1916 * src/maemo/modest-osso-state-saving.c:
1917 * src/maemo/modest-osso-state-saving.h: Added
1918 modest_osso_load_state() and modest_osso_save_state() though they do
1919 nothing now. They should iterate through all the open windows and load/save
1921 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1922 save state when closing.
1924 * src/maemo/modest-main-window.c:
1925 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1926 Add a notification handler for the HildonProgram::is-topmost property,
1927 so we can allow hibernation when the application goes into the background.
1928 But we still need to detect when the accounts setup windows are open so
1929 we can stop hibernation when they are open.
1930 To do this, I also added the main window the HildonProgram. This might have
1931 other side-effects/benefits, and should maybe be done for other windows.
1933 * src/maemo/modest-osso-autosave-callbacks.h:
1934 * src/maemo/modest-osso-autosave-callbacks.c:
1935 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1936 though it does not do anything yet, and we might never need this to do
1937 anything. For instance, we already save drafts.
1939 * src/maemo/modest-platform.c: (modest_platform_init):
1940 Specify the libosso auto-save callback.
1942 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1944 * src/maemo/modest-platform.c:
1945 (modest_platform_set_update_interval):
1946 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1947 aparently stays valid between application instances, so we can use this
1948 to remove and reset it later. According to a maemo-developers email from
1951 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1953 * configure.ac: Depend on libalarm for Maemo.
1955 * src/dbus_api/modest-dbus-api.h:
1956 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1957 (on_send_receive), (modest_dbus_req_handler):
1958 Handle a SEND_RECEIVE D-Bus method.
1960 * libmodest-dbus-client/libmodest-dbus-client.c:
1961 (libmodest_dbus_client_send_and_receive):
1962 * libmodest-dbus-client/libmodest-dbus-client.h:
1963 Add C convenience functions for calling the new D-Bus method.
1965 * src/modest-platform.h:
1966 * src/gnome/modest-platform.c:
1967 * src/maemo/modest-platform.c:
1968 Added modest_platform_set_update_interval(), which uses the
1969 alarmd API on Maemo.
1970 (modest_platform_init),
1971 Call modest_platform_set_update_interval(), using a hard-coded
1972 interval for now (until the global settings dialog is implemented),
1973 though I am not sure that this makes sense yet.
1975 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1977 * src/dbus_api/modest-dbus-callbacks.c:
1978 (modest_osso_cb_hw_state_handler):
1979 * src/dbus_api/modest-dbus-callbacks.h:
1980 * src/maemo/modest-platform.c: (modest_platform_init):
1981 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1982 in case this has some effect on the ability for Maemo to ping the
1985 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1988 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1989 warning. It is probably a logic error, but I need to fix the build.
1991 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-account-mgr.h:
1994 * src/modest-account-mgr.c:
1995 (modest_account_mgr_account_names): Add a gboolean enabled_only
1996 parameter, so we can get lists of onlt the enabled accounts.
1998 (modest_account_mgr_add_account),,
1999 (modest_account_mgr_account_with_display_name_exists):
2000 * src/maemo/modest-msg-edit-window.c: (get_transports):
2001 * src/modest-account-mgr-helpers.c:
2002 (modest_account_mgr_set_first_account_as_default):
2003 * src/modest-init.c: (init_default_account_maybe):
2004 * src/modest-tny-account-store.c: (get_accounts):
2005 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2006 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2007 * tests/check_account-mgr.c: (START_TEST):
2008 Provide the extra parameter, as appropriate.
2010 * src/widgets/modest-account-view.c: (update_account_view):
2011 Do not show disabled accounts (meaning that there is no way to
2012 enable/disable accounts in the UI (the feature is not in our UI
2013 specification), so we can use this internally only to mark unfinished
2014 or temporary account data.
2016 * src/maemo/easysetup/modest-easysetup-wizard.c:
2017 (create_account): Add boolean enable parameter, so we can specify FALSE
2018 to create the temporary account.
2019 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2020 (on_before_next): When finishing, when there is a temporary account, just
2022 Also, use a timeout to delay the showing of the dialog until gconf is likely
2023 to return correct information, due to a maemo gconf bug that is fixed in
2024 osso 1.1, but not yet in Bora.
2025 However, the dialog stays on screen after it is destroyed.
2027 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2028 for invalid data when cancelling. Use a hildon note instead of a dialog
2029 to complain about invalid data. Do not show the account-saved note if the
2030 account is disabled (a temporary account that will not really be saved for use
2033 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2035 * src/modest-account-mgr-helpers.h:
2036 * src/modest-account-mgr-helpers.c:
2037 Added modest_account_mgr_unset_default_account(),
2038 Added modest_account_mgr_set_first_account_as_default().
2040 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2041 If it was the default account, unset the default account name.
2043 * src/maemo/modest-account-view-window.c:
2044 (on_delete_button_clicked): If it was the default account,
2045 set the first remaining account as the default instead.
2047 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2048 a NULL account or a NULL default account, to prevent a crash. This should
2049 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2052 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2054 * src/widgets/modest-recpt-editor.c:
2055 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2056 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2057 TODO comment for this. This fixes the build.
2059 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2060 be the best place for it. This will in future update all auto-update accounts,
2061 rather than just the current/default account, when that gconf key exists.
2062 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2063 if there are no accounts, before calling do_send_receive().
2064 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2066 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2067 * src/maemo/modest-main-window-ui.h:
2068 * src/maemo/modest-main-window.c: (on_connection_changed),
2069 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2070 directly, becaue the signal handler does more.
2072 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-account-mgr-helpers.c:
2075 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2076 for the case that the account does not exist.
2078 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2079 (equivalent to the modest account name) rather than the tinymail account name
2080 (equivalent to the modest account title - human readable) to get the account data.
2081 Check for null account data to prevent the crash, and add a TODO comment saying that
2082 this needs fixing because it is using the server account name instead of the account name.
2084 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2086 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2087 * src/maemo/modest-account-settings-dialog.c: (show_error),
2089 Use hildon_note_new_information() for informative and error messages,
2090 which seems to be expected for Maemo applications (no documentation that I know of
2091 says this). I am surprised that there is no distinction between info and error
2094 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2097 it is easy to find where this is used.
2099 * src/maemo/easysetup/modest-easysetup-wizard.c:
2100 (create_page_welcome), (create_page_account_details),
2101 (create_page_user_details), (create_page_complete_easysetup),
2102 (create_page_custom_incoming), (create_page_custom_outgoing),
2103 (create_page_complete_custom):
2104 * src/maemo/modest-account-settings-dialog.c:
2105 (create_page_account_details), (create_page_user_details),
2106 (create_page_incoming), (create_page_outgoing):
2107 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2108 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2109 (modest_connection_specific_smtp_edit_window_init):
2110 * src/maemo/modest-connection-specific-smtp-window.c:
2111 (modest_connection_specific_smtp_window_init):
2112 * src/maemo/modest-signature-editor-dialog.c:
2113 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2114 and scrolling policy as per the Email Application Layout Guide, if I have
2117 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2119 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2120 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2121 which were empty, because these vfuncs have been removed from TnyAccountStore.
2122 This fixes the build.
2124 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/modest-main-window.c:
2127 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2128 showing/hiding it. Added TODO because it probably should not be NULL.
2129 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2130 because unnecessary g_warnings() make degugging difficult.
2132 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2134 * src/maemo/modest-msg-edit-window.c:
2135 (modest_msg_edit_window_select_color),
2136 (modest_msg_edit_window_select_background_color): 2 const corrections and
2137 moving 2 #endifs before closing brackets, to fix the build.
2139 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2141 * src/maemo/easysetup/modest-easysetup-wizard.h:
2142 * src/maemo/easysetup/modest-easysetup-wizard.c:
2143 (modest_easysetup_wizard_dialog_finalize),
2144 (on_button_edit_advanced_settings), (create_page_complete_custom),
2145 (on_response), (create_account):
2146 Implement the Advanced Settings edit button, by saving the account information,
2147 for the Advanded Settings dialog to use directly from gconf, and removing it
2148 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2149 Bug #5533 in the projects.maemo.org bugzilla.
2151 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2153 * src/maemo/modest-msg-view-window.c:
2154 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2155 when opening a message window.
2157 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2159 * src/maemo/easysetup/modest-easysetup-wizard.c:
2160 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2163 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2164 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2165 gconf settings. I probably added more checks than necessary, but that is safer.
2167 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2168 variable to fix the build, but this seems to be used when it is still NULL.
2170 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2172 * src/modest-platform.h:
2173 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2174 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2175 * src/modest-main.c: Implement this function so we can avoid using
2176 maemo-specific API from cross-platform code.
2178 * src/modest-tny-account-store.c:
2179 (get_smtp_specific_transport_account_for_open_connection):
2180 * src/modest-ui-actions.c: (check_for_connection),
2181 (modest_ui_actions_on_item_not_found):
2182 Use modest_platform_connect_and_wait() and put #idefs around other
2183 maemo-specific code, because only maemo currently has a way to
2184 identify connection names.
2186 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-tny-account-store.h:
2189 * src/modest-tny-account-store.c:
2190 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2191 the connection-specific SMTP server settings in the configuration.
2193 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2195 * src/maemo/modest-main-window.c: (on_connection_changed),
2197 * src/modest-main.c: (main), (start_ui), (send_mail):
2198 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2199 that is what is intended.
2201 * src/modest-ui-actions.c: (action_send), (action_receive),
2202 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2203 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2204 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2205 SMTP server is used when it is specified.
2207 (modest_ui_actions_on_send_receive):
2208 Check that a connection is open before proceeding.
2209 Receive and then send, instead of vice-versa, as per the specification.
2211 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2213 * src/modest-mail-operation.c:
2214 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2215 though I guess it should be something other than NULL.
2217 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/easysetup/modest-easysetup-wizard.c:
2220 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2221 combo twice, to avoid an g_warning and to make it visible again.
2222 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2223 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2224 (already intended) dereference when detaching, because we then recreate the menu.
2225 But I am not sure why the warning was happening, and it is possible that this is a memory
2228 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2230 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2231 and uri_parse_mailto() utility functions.
2232 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2234 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2236 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2238 * src/dbus_api/modest-dbus-api.h:
2239 * src/dbus_api/modest-dbus-callbacks.c:
2240 Use an idle callback to execute the modest code in the application's own thread.
2241 Remove the helloworld example method.
2242 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2243 parsed, and the open-message method is not implemented because this is not yet implemented in
2245 * libmodest-dbus-client/libmodest-dbus-client.c:
2246 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2247 (libmodest_dbus_client_open_message):
2248 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2250 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2251 body without crashing.
2253 * tests/dbus_api/Makefile.am:
2254 * tests/dbus_api/test_mail_to.c:
2255 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2257 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2259 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2260 Added file to fix the build. Sorry.
2262 * src/dbus_api/Makefile.am:
2263 * src/dbus_api/modest-dbus-api.h:
2264 * src/dbus_api/modest-dbus-callbacks.h:
2265 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2266 (modest_dbus_req_handler):
2267 Put constants in a separate header so it can be reused by the
2268 client library, without duplication
2270 * libmodest-dbus-client/Makefile.am:
2271 * libmodest-dbus-client/libmodest-dbus-client.c:
2272 (libmodest_dbus_client_call_helloworld),
2273 (libmodfest_dbus_client_send_mail),
2274 (libmodfest_dbus_client_mailto),
2275 (libmodfest_dbus_client_open_message):
2276 * libmodest-dbus-client/libmodest-dbus-client.h:
2277 (Partly) Implement a send_mail D-Bus method.
2279 * tests/dbus_api/Makefile.am:
2280 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2281 the send_email D-Bus method.
2283 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2287 * libmodest-dbus-client/Makefile.am:
2288 * libmodest-dbus-client/libmodest-dbus-client.c:
2289 * libmodest-dbus-client/libmodest-dbus-client.h:
2290 * tests/dbus_api/Makefile.am:
2291 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2292 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2294 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2296 * src/maemo/easysetup/modest-easysetup-wizard.c:
2297 (create_page_account_details):
2298 * src/maemo/modest-account-settings-dialog.c:
2299 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2300 widgets, because this might not be the default in future versions of the Maemo GTK+.
2301 However, I can not not get capitalization to work even in a simple test case.
2303 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2305 * src/maemo/easysetup/modest-easysetup-wizard.c:
2306 (create_page_custom_incoming), (create_page_custom_outgoing):
2307 * src/maemo/modest-account-settings-dialog.c:
2308 (create_page_account_details), (create_page_incoming),
2309 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2310 instead of using gtk_check_button_with_label(), so they are aligned like the other
2311 widgets, as per the UI spec.
2313 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2315 * src/maemo/easysetup/modest-easysetup-wizard.c:
2316 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2317 * src/widgets/modest-validating-entry.c:
2318 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2319 Modest prefix instead of an EasySetup prefix.
2321 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2323 * src/widgets/modest-validating-entry.h:
2324 * src/widgets/modest-validating-entry.c: (on_insert_text),
2325 Added easysetup_validating_entry_set_max_func(), used to set a callback
2326 to call when the max number of characters is reached. GtkEntry has a max-length
2327 already but is silent about it.
2329 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2330 (create_page_account_details), (create_page_user_details),
2332 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2333 (create_page_account_details), (create_page_user_details),
2334 (create_page_outgoing):
2335 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2336 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2337 the UI spec, when the user tries to enter more than the max number of characters.
2339 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2341 * src/maemo/easysetup/modest-easysetup-wizard.c:
2342 (create_page_user_details), (create_page_custom_incoming),
2343 (create_page_custom_outgoing):
2344 * src/maemo/modest-account-settings-dialog.c:
2345 (create_page_user_details), (create_page_incoming),
2346 (create_page_outgoing):
2347 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2348 (modest_connection_specific_smtp_edit_window_init):
2349 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2350 not appropriate. Bad Maemo-specific defaults!.
2352 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2354 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2355 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2356 (modest_signature_editor_dialog_set_settings):
2357 Disable the label and textview when the checkbox is disabled, and use the
2358 specified (UI spec) default signature text.
2360 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2363 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2365 * src/modest-defs.h:
2366 * src/modest-account-mgr-helpers.h:
2367 * src/modest-account-mgr-helpers.c:
2368 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2370 * src/maemo/Makefile.am:
2371 * src/maemo/modest-signature-editor-dialog.c:
2372 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2375 * src/maemo/modest-account-settings-dialog.h:
2376 * src/maemo/modest-account-settings-dialog.c:
2377 (modest_account_settings_dialog_finalize), (on_button_signature),
2378 (save_configuration): Use the new dialog when the Edit button is pressed, and
2379 save the changes if necessary, as per the UI spec.
2381 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2383 * src/maemo/Makefile.am:
2384 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2385 based on maemo-develoers email from Dirk.
2387 * src/maemo/easysetup/modest-easysetup-wizard.c:
2388 (create_page_welcome), (create_page_account_details),
2389 (create_page_user_details), (create_page_complete_easysetup),
2390 (create_page_custom_incoming), (create_page_custom_outgoing),
2391 (create_page_complete_custom),
2392 (modest_easysetup_wizard_dialog_init):
2393 * src/maemo/modest-account-settings-dialog.c:
2394 (create_page_account_details), (create_page_user_details),
2395 (create_page_incoming), (create_page_outgoing),
2396 (modest_account_settings_dialog_init):
2397 * src/maemo/modest-connection-specific-smtp-window.c:
2398 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2400 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2402 * src/maemo/easysetup/modest-easysetup-wizard.c:
2403 (create_page_account_details), (create_page_custom_outgoing),
2404 (create_page_complete_custom):
2405 * src/maemo/modest-account-settings-dialog.c:
2406 (create_page_user_details), (create_page_incoming),
2407 (create_page_outgoing):
2408 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2409 (modest_connection_specific_smtp_edit_window_init):
2410 Use the correct (UI spec) port min/max, and use horizontal separators,
2413 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2415 * src/maemo/easysetup/modest-easysetup-wizard.c:
2416 (set_default_custom_servernames):
2417 * src/maemo/modest-account-settings-dialog.c:
2418 (create_page_incoming), (on_combo_outgoing_security_changed),
2419 (on_combo_incoming_security_changed), (create_page_outgoing),
2420 (modest_account_settings_dialog_set_account_name),
2421 (save_configuration):
2422 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2423 (on_combo_security_changed),
2424 (modest_connection_specific_smtp_edit_window_init),
2425 (modest_connection_specific_smtp_edit_window_set_connection),
2426 (modest_connection_specific_smtp_edit_window_get_settings):
2427 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2430 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2433 * src/maemo/easysetup/modest-easysetup-wizard.c:
2434 (create_page_custom_outgoing), (create_page_complete_custom):
2435 * src/maemo/modest-account-settings-dialog.c:
2436 (create_page_user_details), (create_page_outgoing):
2437 * src/maemo/modest-account-view-window.c: (button_box_new):
2438 Use changed logical IDs as per the most recent UI spec:
2439 mcen_bd_emailsetup_edit -> mcen_bd_edit
2440 mcen_bd_emailsetup_delete -> mcen_bd_delete
2441 mcen_bd_emailsetup_close -> mcen_bd_close
2443 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2447 * src/dbus_api/Makefile.am:
2448 * src/dbus_api/modest-dbus-callbacks.c:
2449 * src/dbus_api/modest-dbus-callbacks.h:
2450 * src/maemo/modest-platform.c: (modest_platform_init):
2451 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2453 * tests/Makefile.am:
2454 * tests/dbus_api/Makefile.am:
2455 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2457 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2459 * src/maemo/modest-account-settings-dialog.c:
2460 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2461 Removed unnecessary includes.
2463 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/easysetup/modest-easysetup-wizard.c:
2466 * src/maemo/modest-account-settings-dialog.c:
2467 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2468 * src/widgets/Makefile.am:
2469 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2470 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2471 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2472 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2473 * src/widgets/modest-secureauth-combo-box.c:
2474 * src/widgets/modest-secureauth-combo-box.h:
2475 * src/widgets/modest-serversecurity-combo-box.c:
2476 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2477 made the GObject names more consistent with the rest of the Modest code.
2479 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2481 * src/maemo/easysetup/Makefile.am:
2482 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2483 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2484 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2485 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2486 * src/maemo/easysetup/modest-easysetup-wizard.c:
2487 * src/maemo/easysetup/modest-validating-entry.c:
2488 * src/maemo/easysetup/modest-validating-entry.h:
2489 * src/maemo/modest-account-settings-dialog.c:
2490 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2491 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2492 widgets/ because they are used outside of easysetup too. After checking in,
2493 svn will allow me to rename them too.
2495 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2497 * src/gnome/modest-msg-edit-window.c:
2498 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2499 linker error, to fix the build on the GNOME platform.
2500 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2501 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2502 ifdefed out to avoid a warning.
2504 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2506 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2507 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2508 some alternative for GTK+ 2.6.
2510 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2512 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2514 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2515 specified for EmailAccountsDialog in UI spec.
2517 * src/maemo/easysetup/modest-easysetup-wizard.c:
2518 * src/maemo/easysetup/modest-easysetup-wizard.h:
2519 * src/maemo/modest-account-settings-dialog.c:
2520 * src/maemo/modest-account-settings-dialog.h:
2521 Reuse a member window widget for the connection-specific SMTP server accounts,
2522 so we can tell it to create/save the accounts only if we actually save changes.
2524 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2525 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2526 (modest_connection_specific_smtp_edit_window_get_settings):
2527 Return a struct instance for temporarily remembering the entered data.
2529 * src/maemo/modest-connection-specific-smtp-window.h:
2530 * src/maemo/modest-connection-specific-smtp-window.c:
2531 (modest_connection_specific_smtp_window_finalize),
2532 (modest_connection_specific_smtp_window_fill_with_connections),
2534 (modest_connection_specific_smtp_window_save_server_accounts),
2535 (update_model_server_names): Do not actually save data until asked,
2536 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2538 (on_selection_changed),
2539 (modest_connection_specific_smtp_window_init): Disable the edit
2540 button when nothing is selected.
2542 * src/modest-account-mgr-helpers.c:
2543 * src/modest-account-mgr-helpers.h:
2544 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2547 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2549 * src/modest-account-mgr-helpers.h:
2550 * src/modest-account-mgr-helpers.c:
2551 (modest_account_mgr_get_unused_account_name),
2552 (modest_account_mgr_get_unused_account_display_name): Added these
2553 utility functions, to avoid code duplication.
2555 * src/maemo/easysetup/modest-easysetup-wizard.c:
2556 (create_page_account_details), (create_account):
2557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2558 (on_combo_security_changed),
2559 (modest_connection_specific_smtp_edit_window_init),
2560 (modest_connection_specific_smtp_edit_window_save_settings):
2561 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2562 * src/maemo/modest-connection-specific-smtp-window.c:
2563 (modest_connection_specific_smtp_window_finalize),
2564 (modest_connection_specific_smtp_window_fill_with_connections),
2565 (on_button_edit), (modest_connection_specific_smtp_window_init):
2566 * src/maemo/modest-connection-specific-smtp-window.h:
2567 Implementing saving of connection-specific server accounts.
2569 But I need to refactor this so we can save the data for each
2570 possible connection-specific account and only actually create the server accounts
2571 when the easysetup finished, or the OK button is pressed on the account settings
2574 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2576 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2577 (on_combo_security_changed):
2578 (modest_connection_specific_smtp_edit_window_init):
2579 Auto-fill the port number as in the account settings.
2581 (modest_connection_specific_smtp_edit_window_set_connection):
2582 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2583 * src/maemo/modest-connection-specific-smtp-window.c:
2584 (fill_with_connections), (on_button_edit),
2585 (modest_connection_specific_smtp_window_init):
2586 Turn the edit window into a dialog to simplify the code, and
2587 set a WM hint as in a GtkDialog, because only a popup can be on top of
2588 another window in Maemo, and popups usually have no WM decoration.
2590 * src/modest-defs.h:
2591 * src/modest-account-mgr-helpers.c:
2592 (modest_account_mgr_set_connection_specific_smtp),
2593 (modest_account_mgr_remove_connection_specific_smtp),
2594 (modest_account_mgr_get_connection_specific_smtp):
2595 * src/modest-account-mgr-helpers.h: Some functions to write the
2596 connection-specific SMTP server information. Not yet used.
2599 * src/widgets/modest-folder-view.c: (text_cell_data):
2600 Fix a warning about an uninitialized variable.
2601 (on_configuration_key_changed): Put an #ifdef around the use
2602 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2604 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2606 * src/maemo/modest-account-settings-dialog.h:
2607 * src/maemo/modest-account-settings-dialog.c:
2608 Added connect_for_modified() utility function to mark the new modified boolean.
2610 (create_page_account_details), (create_page_user_details),
2611 (create_page_incoming), (create_page_outgoing), (on_response),
2612 (modest_account_settings_dialog_init),
2613 (modest_account_settings_dialog_set_account_name):
2614 Only warn about unsaved changes when there are actually unsaved changes.
2616 * src/modest-account-mgr-helpers.c:
2617 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2618 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2619 to get the data from there in future.
2621 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2623 * src/modest-defs.h:
2625 * src/modest-account-mgr-helpers.h:
2626 * src/modest-account-mgr-helpers.c:
2627 Store the security account setting in a single conf key instead of using
2628 the options list, so that the list is left for just the to-be-removed camel hack,
2629 and because gconf_client_set_list() is failing for some reason.
2631 * src/modest-account-mgr.c:
2632 (modest_account_mgr_add_server_account):
2633 * src/maemo/modest-account-settings-dialog.c:
2634 (modest_account_settings_dialog_set_account_name),
2635 (save_configuration): Use the renamed functions.
2638 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2640 * src/widgets/Makefile.am:
2641 * src/widgets/modest-limit-retrieve-combo-box.c:
2642 * src/widgets/modest-limit-retrieve-combo-box.h:
2643 * src/widgets/modest-retrieve-combo-box.c:
2644 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2645 the account settings dialog.
2647 * src/modest-defs.h:
2648 * src/modest-account-mgr-helpers.h:
2649 * src/modest-account-mgr-helpers.c:
2650 (modest_server_account_get_option_secure_auth),
2651 (modest_server_account_set_option_secure_auth):
2652 * src/modest-account-mgr.c:
2653 (modest_account_mgr_add_server_account):
2654 Use the existing AUTH_MECH conf key for the secure-auth setting,
2655 instead of putting it in the list options, because this was actually used already.
2657 * src/maemo/modest-account-settings-dialog.c:
2658 (create_page_account_details),
2659 (modest_account_settings_dialog_set_account_name),
2660 (save_configuration):
2661 * src/maemo/modest-account-settings-dialog.h:
2662 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2663 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2665 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2667 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2668 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2669 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2671 * src/modest-defs.h:
2672 * src/maemo/modest-account-settings-dialog.c:
2673 (create_page_incoming), (on_combo_outgoing_security_changed),
2674 (on_combo_incoming_security_changed), (create_page_outgoing),
2675 (modest_account_settings_dialog_set_account_name),
2676 (save_configuration): Load/Save the port number, and change it when the
2677 security combo changes, to suitable defaults.
2679 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2681 * src/modest-account-mgr.c:
2682 (modest_account_mgr_add_server_account): Set the security and secure-auth
2683 options, and add a comment saying that the other camel-specific options should be
2686 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2688 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2690 * src/modest-tny-account-store.c: (account_list_free),
2691 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2692 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2695 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2697 * src/modest-protocol-info.c:
2698 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2699 is required by our UI spec. Maybe something in our implementation will use this eventually.
2700 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2701 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2702 instead of the previous 0 placeholder.
2704 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2705 secure-auth settings.
2706 * src/modest-account-mgr-helpers.h:
2707 * src/modest-account-mgr-helpers.c:
2708 (modest_server_account_data_get_option_secure_auth),
2709 (modest_server_account_set_option_secure_auth),
2710 (modest_server_account_data_get_option_security),
2711 (modest_server_account_set_option_security): Added this API for getting and setting the security
2712 and secure-auth settings.
2714 * src/maemo/modest-account-settings-dialog.h:
2715 * src/maemo/modest-account-settings-dialog.c:
2716 (modest_account_settings_dialog_finalize), (check_data),
2717 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2718 about changing titles.
2719 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2720 (save_configuration): Save the security and secure-auth settings.
2722 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2723 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2725 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2727 * src/modest-defs.h:
2728 * src/modest-account-mgr.c:
2729 (modest_account_mgr_add_server_account):
2730 Added and used defines for the options key and value pair strings,
2731 that are used so far, though they do not seem to correspond to anything in our
2732 UI specs or ModestProtocol enum.
2734 * src/modest-account-mgr-helpers.h:
2735 * src/modest-account-mgr-helpers.c:
2736 (compare_option_strings_for_name),
2737 (modest_server_account_data_get_option_value),
2738 (modest_server_account_data_get_option_bool),
2739 (modest_account_mgr_get_server_account_option):
2740 Added helper functions for parsing the options GSList.
2742 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2744 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2745 display name is based on the supplied account name.
2746 * src/modest-account-mgr.c:
2747 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2748 with an inefficient, but good-enough, implementation.
2750 * src/maemo/easysetup/modest-easysetup-wizard.c:
2751 (create_page_account_details), (on_before_next), (create_account):
2752 Check for existing display names rather than (non-user-visible) account names, and just
2753 create and set a unique account name at the end.
2755 * src/maemo/modest-account-settings-dialog.c:
2756 (modest_account_settings_dialog_init),
2757 (modest_account_settings_dialog_set_account_name),
2758 (create_page_incoming): Show the display name, instead of the account name.
2759 (on_response): Do some (not all) extra checks, as in the UI spec.
2760 (save_configuration): Save the display name if it was changed.
2762 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2764 * po/en_GB.po: Added needed logical ID and translation.
2765 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2766 (init_view): Made the is-default column clicking work.
2768 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2771 * src/maemo/easysetup/Makefile.am:
2772 * src/maemo/easysetup/modest-easysetup-wizard.c:
2773 (modest_easysetup_wizard_dialog_init):
2774 * src/maemo/easysetup/provider-data-test.keyfile:
2775 * src/maemo/easysetup/provider-data.keyfile:
2776 Moved the provider data file to the new modest-providers-data package and used it from there.
2778 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2780 * src/modest-local-folder-info.c:
2781 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2782 N_() was already used on the static strings, but this just marks it for translation without
2783 using the translation.
2785 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/modest-account-settings-dialog.c:
2788 (create_page_incoming),
2789 (modest_account_settings_dialog_set_account_name):
2790 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2791 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2792 I will do this if nobody else gets there first.
2794 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2797 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2798 save the security stuff.
2800 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2803 Set the email address and user fullname, which I now see must be
2806 * src/maemo/modest-account-settings-dialog.h:
2807 * src/maemo/modest-account-settings-dialog.c:
2809 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2810 leave-on-server and authentication.
2811 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2814 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2817 * src/maemo/modest-account-settings-dialog.c:
2818 * src/maemo/modest-account-settings-dialog.h:
2819 Most (but not all) of the widgets are now present as specified by the UI spec.
2820 No changes are yet saved, and some details are not properly shown yet.
2822 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2824 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2826 * src/maemo/Makefile.am:
2827 * src/maemo/modest-account-settings-dialog.c:
2828 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2829 an existing account. Doesn't do much yet.
2831 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2832 Open the accounts settings dialog when Edit is clicked.
2834 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2836 * src/maemo/easysetup/Makefile.am:
2837 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2839 * src/maemo/easysetup/modest-easysetup-wizard.c:
2840 (modest_easysetup_wizard_dialog_init):
2841 Try to get the source directory from the build system,
2842 instead of hard-coding "./" into the source code, when opening our local
2843 copies of the configuration files.
2844 But this still fails when opening the wizard from the Accounts window,
2845 maybe because the working directory seems to change at runtime.
2846 So the wizard will fail the second time unless you copy the files into their
2847 proper locations - see the stdout warnings for the paths.
2849 (create_page_account_details),(on_before_next):
2850 Check for existing non-server accounts instead of server accounts,
2851 so the default account name is useful again, and to prevent trying to
2854 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2855 Show the wizard when New is clicked.
2857 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2858 (init_view): Show the column headers, and show the columns that are
2859 specified in the UI specs. However, something in Maemo's GTK+ prevents
2860 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2861 change the default account. This is despite unsetting the special properties.
2863 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2865 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2866 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2867 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2868 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2869 to make that clearer.
2870 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2872 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2874 * src/maemo/modest-account-view-window.c:
2875 (modest_account_view_window_init),
2876 (modest_account_view_window_new):
2877 Use the same buttons as specified in the
2878 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2879 the existing widgets, which never had a chance of working.
2880 Put the ModestAccountView treeview in a scrolled window.
2881 Do not repeat the initialization in both _init() and _new().
2883 * src/widgets/modest-account-view.c: (update_account_view):
2884 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2885 this widget and window shows no accounts.
2887 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2889 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2891 * src/maemo/easysetup/modest-easysetup-wizard.c:
2892 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2893 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2894 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2897 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2898 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2899 accounts exist yet, as in the UI spec.
2901 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2903 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2905 * src/maemo/Makefile.am:
2906 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2907 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2908 New window for editing connection-specific smtp details.
2909 Not fully implemented.
2911 * src/maemo/modest-connection-specific-smtp-window.c:
2912 (modest_connection_specific_smtp_window_finalize) :
2913 unref the tree model.
2914 (on_button_edit): Show the edit window.
2916 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2918 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2921 * src/maemo/Makefile.am:
2922 * src/maemo/modest-connection-specific-smtp-window.c:
2923 * src/maemo/modest-connection-specific-smtp-window.h:
2924 New window for showing the list of connections, for connection-specific
2925 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2926 * src/maemo/easysetup/modest-easysetup-wizard.c:
2927 (create_page_custom_outgoing): Show the new window when the button is clicked.
2929 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2931 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2932 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2933 * src/maemo/modest-msg-edit-window.c:
2934 (modest_msg_edit_window_insert_image):
2935 * src/modest-conf.c: (modest_conf_key_escape):
2936 * src/modest-mail-operation.c:
2937 (modest_mail_operation_send_new_mail):
2938 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2939 (modest_ui_actions_on_new_account):
2940 * src/widgets/modest-attachment-view.c: (update_filename_request):
2941 * src/widgets/modest-mail-header-view.c:
2942 Corrected warnings that were breaking the build, by commenting out unused variables,
2943 and a function, and by including a header.
2945 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2947 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2948 so we can #ifdef around platform-specific code when necessary.
2949 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2950 to allow this to build for the GNOME platform too.
2952 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2954 * src/maemo/easysetup/modest-easysetup-wizard.c:
2955 Added util_increment_name() and used it in create_page_account_details()
2956 to make sure that the default account name is always a new name.
2958 (modest_easysetup_wizard_dialog_init),
2959 (set_default_custom_servernames): Some minor memory management fixes.
2961 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2965 * src/modest-runtime.c: (init_i18n): Restored the translation
2966 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2967 are defined in config.h, and the translations are installed.
2969 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2970 is defined for translation.
2972 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2974 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2976 * src/maemo/easysetup/modest-easysetup-wizard.c:
2977 (modest_easysetup_wizard_dialog_init):
2978 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2979 Use realistic paths (though they should use $prefix generically) to the
2980 mcc_mapping and provider-data.keyfile files which might work when they
2981 are installed by the future version of the operator-wizard package,
2982 and then fallback to paths in our source code, with an explanatory
2985 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2989 * src/maemo/Makefile.am:
2990 * src/maemo/easysetup/: Added files from the previously-exernal
2991 osso-modest-easysetup.
2992 * src/maemo/modest-main-window-ui.h:
2993 * src/modest-ui-actions.c:
2994 * src/modest-ui-actions.h:
2995 Added modest_ui_actions_on_new_account() as a signal handler for the
2996 New Account menu item. It shows the easysetup wizard.
2997 * po/en_GB.po: Added additional needed logical IDs and translations.
2999 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3000 Apparently ChangeLog is not used for some vague Nokia legal reasons.