7a97f12044bee0ebe71f3de4050d69c947c7b221
[modest] / ChangeLog2
1 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
2
3         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
5         (modest_signature_editor_dialog_set_settings): 
6         Disable the label and textview when the checkbox is disabled, and use the 
7         specified (UI spec) default signature text.
8
9 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
10
11         * src/maemo/modest-connection-specific-smtp-edit-window.c:
12         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
13         
14         * src/modest-defs.h:
15         * src/modest-account-mgr-helpers.h:
16         * src/modest-account-mgr-helpers.c:
17         Added modest_account_mgr_get/set_signature(), using new gconf keys.
18         
19         * src/maemo/Makefile.am:
20         * src/maemo/modest-signature-editor-dialog.c:
21         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures, 
22         as per the UI spec.
23         
24         * src/maemo/modest-account-settings-dialog.h:
25         * src/maemo/modest-account-settings-dialog.c:
26         (modest_account_settings_dialog_finalize), (on_button_signature),
27         (save_configuration): Use the new dialog when the Edit button is pressed, and 
28         save the changes if necessary, as per the UI spec.
29
30 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
31
32         * src/maemo/Makefile.am:
33         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing, 
34         based on maemo-develoers email from Dirk.
35         
36         * src/maemo/easysetup/modest-easysetup-wizard.c:
37         (create_page_welcome), (create_page_account_details),
38         (create_page_user_details), (create_page_complete_easysetup),
39         (create_page_custom_incoming), (create_page_custom_outgoing),
40         (create_page_complete_custom),
41         (modest_easysetup_wizard_dialog_init):
42         * src/maemo/modest-account-settings-dialog.c:
43         (create_page_account_details), (create_page_user_details),
44         (create_page_incoming), (create_page_outgoing),
45         (modest_account_settings_dialog_init):
46         * src/maemo/modest-connection-specific-smtp-window.c:
47         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
48
49 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
50
51         * src/maemo/easysetup/modest-easysetup-wizard.c:
52         (create_page_account_details), (create_page_custom_outgoing),
53         (create_page_complete_custom):
54         * src/maemo/modest-account-settings-dialog.c:
55         (create_page_user_details), (create_page_incoming),
56         (create_page_outgoing):
57         * src/maemo/modest-connection-specific-smtp-edit-window.c:
58         (modest_connection_specific_smtp_edit_window_init): 
59         Use the correct (UI spec) port min/max, and use horizontal separators, 
60         as per the UI spec.
61
62 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
63
64         * src/maemo/easysetup/modest-easysetup-wizard.c:
65         (set_default_custom_servernames):
66         * src/maemo/modest-account-settings-dialog.c:
67         (create_page_incoming), (on_combo_outgoing_security_changed),
68         (on_combo_incoming_security_changed), (create_page_outgoing),
69         (modest_account_settings_dialog_set_account_name),
70         (save_configuration):
71         * src/maemo/modest-connection-specific-smtp-edit-window.c:
72         (on_combo_security_changed),
73         (modest_connection_specific_smtp_edit_window_init),
74         (modest_connection_specific_smtp_edit_window_set_connection),
75         (modest_connection_specific_smtp_edit_window_get_settings): 
76         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
77         as per the UI spec.
78
79 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
80
81         * po/en_GB.po:
82         * src/maemo/easysetup/modest-easysetup-wizard.c:
83         (create_page_custom_outgoing), (create_page_complete_custom):
84         * src/maemo/modest-account-settings-dialog.c:
85         (create_page_user_details), (create_page_outgoing):
86         * src/maemo/modest-account-view-window.c: (button_box_new):
87         Use changed logical IDs as per the most recent UI spec:
88         mcen_bd_emailsetup_edit -> mcen_bd_edit
89         mcen_bd_emailsetup_delete -> mcen_bd_delete
90         mcen_bd_emailsetup_close -> mcen_bd_close
91
92 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
93
94         * configure.ac:
95         * src/Makefile.am:
96         * src/dbus_api/Makefile.am:
97         * src/dbus_api/modest-dbus-callbacks.c:
98         * src/dbus_api/modest-dbus-callbacks.h:
99         * src/maemo/modest-platform.c: (modest_platform_init):
100         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld 
101         method.
102         * tests/Makefile.am:
103         * tests/dbus_api/Makefile.am:
104         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
105
106 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
107
108         * src/maemo/modest-account-settings-dialog.c:
109         * src/maemo/modest-connection-specific-smtp-edit-window.c:
110         Removed unnecessary includes.
111
112 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
113
114         * src/maemo/easysetup/modest-easysetup-wizard.c:
115         * src/maemo/modest-account-settings-dialog.c:
116         * src/maemo/modest-connection-specific-smtp-edit-window.c:
117         * src/widgets/Makefile.am:
118         * src/widgets/modest-easysetup-secureauth-combo-box.c:
119         * src/widgets/modest-easysetup-secureauth-combo-box.h:
120         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
121         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
122         * src/widgets/modest-secureauth-combo-box.c:
123         * src/widgets/modest-secureauth-combo-box.h:
124         * src/widgets/modest-serversecurity-combo-box.c:
125         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and 
126         made the GObject names more consistent with the rest of the Modest code.
127
128 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
129
130         * src/maemo/easysetup/Makefile.am:
131         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
132         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
133         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
134         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
135         * src/maemo/easysetup/modest-easysetup-wizard.c:
136         * src/maemo/easysetup/modest-validating-entry.c:
137         * src/maemo/easysetup/modest-validating-entry.h:
138         * src/maemo/modest-account-settings-dialog.c:
139         * src/maemo/modest-connection-specific-smtp-edit-window.c:
140         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into 
141         widgets/ because they are used outside of easysetup too. After checking in, 
142         svn will allow me to rename them too.
143
144 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
145
146         * src/gnome/modest-msg-edit-window.c:
147         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a 
148         linker error, to fix the build on the GNOME platform.
149         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(), 
150         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
151         ifdefed out to avoid a warning.
152
153 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
154
155         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the 
156         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs 
157         some alternative for GTK+ 2.6.
158
159 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
160
161         * src/maemo/modest-address-book.c: Added include to avoid a warning.
162
163         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string, 
164         specified for EmailAccountsDialog in UI spec.
165         
166         * src/maemo/easysetup/modest-easysetup-wizard.c:
167         * src/maemo/easysetup/modest-easysetup-wizard.h:
168         * src/maemo/modest-account-settings-dialog.c:
169         * src/maemo/modest-account-settings-dialog.h:
170         Reuse a member window widget for the connection-specific SMTP server accounts, 
171         so we can tell it to create/save the accounts only if we actually save changes.
172
173         * src/maemo/modest-connection-specific-smtp-edit-window.h:      
174         * src/maemo/modest-connection-specific-smtp-edit-window.c:
175         (modest_connection_specific_smtp_edit_window_get_settings): 
176         Return a struct instance for temporarily remembering the entered data.
177
178         * src/maemo/modest-connection-specific-smtp-window.h:
179         * src/maemo/modest-connection-specific-smtp-window.c:
180         (modest_connection_specific_smtp_window_finalize),
181         (modest_connection_specific_smtp_window_fill_with_connections),
182         (on_button_edit),
183         (modest_connection_specific_smtp_window_save_server_accounts),
184         (update_model_server_names): Do not actually save data until asked, 
185         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
186         
187         (on_selection_changed),
188         (modest_connection_specific_smtp_window_init): Disable the edit 
189         button when nothing is selected.
190         
191         * src/modest-account-mgr-helpers.c:
192         * src/modest-account-mgr-helpers.h: 
193         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct 
194         elsewhere.
195
196 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
197
198         * src/modest-account-mgr-helpers.h:
199         * src/modest-account-mgr-helpers.c:
200         (modest_account_mgr_get_unused_account_name),
201         (modest_account_mgr_get_unused_account_display_name): Added these 
202         utility functions, to avoid code duplication.
203
204         * src/maemo/easysetup/modest-easysetup-wizard.c:
205         (create_page_account_details), (create_account):
206         * src/maemo/modest-connection-specific-smtp-edit-window.c:
207         (on_combo_security_changed),
208         (modest_connection_specific_smtp_edit_window_init),
209         (modest_connection_specific_smtp_edit_window_save_settings):
210         * src/maemo/modest-connection-specific-smtp-edit-window.h:
211         * src/maemo/modest-connection-specific-smtp-window.c:
212         (modest_connection_specific_smtp_window_finalize),
213         (modest_connection_specific_smtp_window_fill_with_connections),
214         (on_button_edit), (modest_connection_specific_smtp_window_init):
215         * src/maemo/modest-connection-specific-smtp-window.h:
216         Implementing saving of connection-specific server accounts.
217         
218         But I need to refactor this so we can save the data for each 
219         possible connection-specific account and only actually create the server accounts 
220         when the easysetup finished, or the OK button is pressed on the account settings 
221         dialog.
222
223 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
224
225         * src/maemo/modest-connection-specific-smtp-edit-window.c:
226         (on_combo_security_changed): 
227         (modest_connection_specific_smtp_edit_window_init):
228         Auto-fill the port number as in the account settings.
229         
230         (modest_connection_specific_smtp_edit_window_set_connection):
231         * src/maemo/modest-connection-specific-smtp-edit-window.h:
232         * src/maemo/modest-connection-specific-smtp-window.c:
233         (fill_with_connections), (on_button_edit),
234         (modest_connection_specific_smtp_window_init): 
235         Turn the edit window into a dialog to simplify the code, and 
236         set a WM hint as in a GtkDialog, because only a popup can be on top of 
237         another window in Maemo, and popups usually have no WM decoration.
238         
239         * src/modest-defs.h:
240         * src/modest-account-mgr-helpers.c:
241         (modest_account_mgr_set_connection_specific_smtp),
242         (modest_account_mgr_remove_connection_specific_smtp),
243         (modest_account_mgr_get_connection_specific_smtp):
244         * src/modest-account-mgr-helpers.h: Some functions to write the 
245         connection-specific SMTP server information. Not yet used.
246
247         
248         * src/widgets/modest-folder-view.c: (text_cell_data):
249         Fix a warning about an uninitialized variable.
250         (on_configuration_key_changed): Put an #ifdef around the use 
251         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
252
253 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
254
255         * src/maemo/modest-account-settings-dialog.h:
256         * src/maemo/modest-account-settings-dialog.c:
257         Added connect_for_modified() utility function to mark the new modified boolean.
258         
259         (create_page_account_details), (create_page_user_details),
260         (create_page_incoming), (create_page_outgoing), (on_response),
261         (modest_account_settings_dialog_init),
262         (modest_account_settings_dialog_set_account_name):
263         Only warn about unsaved changes when there are actually unsaved changes.
264         
265         * src/modest-account-mgr-helpers.c:
266         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information 
267         into the ModestServerAccountData struct. I do not use it yet, but someone might expect 
268         to get the data from there in future.
269
270 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
271
272         * src/modest-defs.h:
273
274         * src/modest-account-mgr-helpers.h:
275         * src/modest-account-mgr-helpers.c:
276         Store the security account setting in a single conf key instead of using 
277         the options list, so that the list is left for just the to-be-removed camel hack, 
278         and because gconf_client_set_list() is failing for some reason.
279
280         * src/modest-account-mgr.c:
281         (modest_account_mgr_add_server_account):
282         * src/maemo/modest-account-settings-dialog.c:
283         (modest_account_settings_dialog_set_account_name),
284         (save_configuration): Use the renamed functions.
285
286
287 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
288
289         * src/widgets/Makefile.am:
290         * src/widgets/modest-limit-retrieve-combo-box.c:
291         * src/widgets/modest-limit-retrieve-combo-box.h:
292         * src/widgets/modest-retrieve-combo-box.c:
293         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in 
294         the account settings dialog.
295         
296         * src/modest-defs.h:
297         * src/modest-account-mgr-helpers.h:
298         * src/modest-account-mgr-helpers.c:
299         (modest_server_account_get_option_secure_auth),
300         (modest_server_account_set_option_secure_auth):
301         * src/modest-account-mgr.c:
302         (modest_account_mgr_add_server_account):
303         Use the existing AUTH_MECH conf key for the secure-auth setting, 
304         instead of putting it in the list options, because this was actually used already.
305         
306         * src/maemo/modest-account-settings-dialog.c:
307         (create_page_account_details),
308         (modest_account_settings_dialog_set_account_name),
309         (save_configuration):
310         * src/maemo/modest-account-settings-dialog.h:
311         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
312         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
313
314 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
315
316         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
317         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
318         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
319
320         * src/modest-defs.h:
321         * src/maemo/modest-account-settings-dialog.c:
322         (create_page_incoming), (on_combo_outgoing_security_changed),
323         (on_combo_incoming_security_changed), (create_page_outgoing),
324         (modest_account_settings_dialog_set_account_name),
325         (save_configuration): Load/Save the port number, and change it when the 
326         security combo changes, to suitable defaults.
327
328 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
329
330         * src/modest-account-mgr.c:
331         (modest_account_mgr_add_server_account): Set the security and secure-auth 
332         options, and add a comment saying that the other camel-specific options should be 
333         removed in future.
334
335 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
336
337         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something, 
338         found by valgrind.
339         * src/modest-tny-account-store.c: (account_list_free),
340         (on_account_changed): Add a TODO comment about a valgrind error, caused by using 
341         cursor->data after unreffing it. But there is some strange stuff there so it might not be 
342         easy to fix.
343
344 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
345
346         * src/modest-protocol-info.c:
347         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it 
348         is required by our UI spec. Maybe something in our implementation will use this eventually.
349         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c: 
350         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value 
351         instead of the previous 0 placeholder.
352         
353         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and 
354         secure-auth settings.
355         * src/modest-account-mgr-helpers.h:
356         * src/modest-account-mgr-helpers.c:
357         (modest_server_account_data_get_option_secure_auth),
358         (modest_server_account_set_option_secure_auth),
359         (modest_server_account_data_get_option_security),
360         (modest_server_account_set_option_security): Added this API for getting and setting the security 
361         and secure-auth settings.
362         
363         * src/maemo/modest-account-settings-dialog.h:
364         * src/maemo/modest-account-settings-dialog.c:
365         (modest_account_settings_dialog_finalize), (check_data),
366         (on_response): Store the original title as well as the name, to avoid unnececessary warnings 
367         about changing titles.
368         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
369         (save_configuration): Save the security and secure-auth settings.
370
371         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this 
372         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
373
374 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
375
376         * src/modest-defs.h: 
377         * src/modest-account-mgr.c:
378         (modest_account_mgr_add_server_account):
379         Added and used defines for the options key and value pair strings, 
380         that are used so far, though they do not seem to correspond to anything in our 
381         UI specs or ModestProtocol enum.
382         
383         * src/modest-account-mgr-helpers.h:
384         * src/modest-account-mgr-helpers.c:
385         (compare_option_strings_for_name),
386         (modest_server_account_data_get_option_value),
387         (modest_server_account_data_get_option_bool),
388         (modest_account_mgr_get_server_account_option):
389         Added helper functions for parsing the options GSList.
390
391 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
392
393         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial 
394         display name is based on the supplied account name.
395         * src/modest-account-mgr.c:
396         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(), 
397         with an inefficient, but good-enough, implementation.
398         
399         * src/maemo/easysetup/modest-easysetup-wizard.c:
400         (create_page_account_details), (on_before_next), (create_account): 
401         Check for existing display names rather than (non-user-visible) account names, and just 
402         create and set a unique account name at the end.
403         
404         * src/maemo/modest-account-settings-dialog.c:
405         (modest_account_settings_dialog_init),
406         (modest_account_settings_dialog_set_account_name),
407         (create_page_incoming): Show the display name, instead of the account name.
408         (on_response): Do some (not all) extra checks, as in the UI spec.
409         (save_configuration): Save the display name if it was changed.
410
411 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
412
413         * po/en_GB.po: Added needed logical ID and translation.
414         * src/widgets/modest-account-view.c: (on_account_default_toggled),
415         (init_view): Made the is-default column clicking work.
416
417 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
418
419         * configure.ac:
420         * src/maemo/easysetup/Makefile.am:
421         * src/maemo/easysetup/modest-easysetup-wizard.c:
422         (modest_easysetup_wizard_dialog_init):
423         * src/maemo/easysetup/provider-data-test.keyfile:
424         * src/maemo/easysetup/provider-data.keyfile: 
425         Moved the provider data file to the new modest-providers-data package and used it from there.
426
427 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
428
429         * src/modest-local-folder-info.c:
430         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string. 
431         N_() was already used on the static strings, but this just marks it for translation without 
432         using the translation.
433
434 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
435
436         * src/maemo/modest-account-settings-dialog.c:
437         (create_page_incoming),
438         (modest_account_settings_dialog_set_account_name): 
439         Added comments about the need for new API in ModestAccountMgr to handle the authentication 
440         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
441         I will do this if nobody else gets there first.
442
443 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
444
445         * src/maemo/modest-account-settings-dialog.c: (save_configuration): 
446         Saved much of the incoming and outgoing data too, though I cannot yet see how to 
447         save the security stuff.
448
449 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
450
451         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
452         Set the email address and user fullname, which I now see must be 
453         done separately.
454         
455         * src/maemo/modest-account-settings-dialog.h:
456         * src/maemo/modest-account-settings-dialog.c:
457          (on_response),
458         (modest_account_settings_dialog_set_account_name): Show the email address, fullname, 
459         leave-on-server and authentication.
460         (save_configuration): Save most of the non-server-account specific stuff, but I don't see 
461         how to do the rest.
462
463 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
464
465
466         * src/maemo/modest-account-settings-dialog.c:
467         * src/maemo/modest-account-settings-dialog.h:
468         Most (but not all) of the widgets are now present as specified by the UI spec.
469         No changes are yet saved, and some details are not properly shown yet.
470         
471         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
472
473 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
474
475         * src/maemo/Makefile.am:
476         * src/maemo/modest-account-settings-dialog.c:
477         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit 
478         an existing account. Doesn't do much yet.
479         
480         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked): 
481         Open the accounts settings dialog when Edit is clicked.
482
483 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
484
485         * src/maemo/easysetup/Makefile.am:
486         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
487         (load_from_file): 
488         * src/maemo/easysetup/modest-easysetup-wizard.c:
489         (modest_easysetup_wizard_dialog_init):
490         Try to get the source directory from the build system,
491         instead of hard-coding "./" into the source code, when opening our local 
492         copies of the configuration files.
493         But this still fails when opening the wizard from the Accounts window, 
494         maybe because the working directory seems to change at runtime.
495         So the wizard will fail the second time unless you copy the files into their 
496         proper locations - see the stdout warnings for the paths.
497         
498         (create_page_account_details),(on_before_next): 
499         Check for existing non-server accounts instead of server accounts, 
500         so the default account name is useful again, and to prevent trying to 
501         recreate accounts.
502         
503         * src/maemo/modest-account-view-window.c: (on_new_button_clicked): 
504         Show the wizard when New is clicked.
505         
506         * src/widgets/modest-account-view.c: (on_account_default_toggled),
507         (init_view): Show the column headers, and show the columns that are 
508         specified in the UI specs. However, something in Maemo's GTK+ prevents 
509         us from handling the GtkCellRendererToggle::toggled signal, so we cannot 
510         change the default account. This is despite unsetting the special properties.
511
512 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
513
514         * docs/reference/modest-design.sgml: Corrected spelling mistake.
515         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account): 
516         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
517         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation 
518         to make that clearer.
519         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
520
521 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
522
523         * src/maemo/modest-account-view-window.c:
524         (modest_account_view_window_init),
525         (modest_account_view_window_new):
526         Use the same buttons as specified in the 
527         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to 
528         the existing widgets, which never had a chance of working.
529         Put the ModestAccountView treeview in a scrolled window.
530         Do not repeat the initialization in both _init() and _new().
531         
532         * src/widgets/modest-account-view.c: (update_account_view):
533         Add a warning about modest_account_mgr_account_names() returning NULL, which is why 
534         this widget and window shows no accounts.
535         
536         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
537         
538 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
539
540         * src/maemo/easysetup/modest-easysetup-wizard.c:
541         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
542         (create_account): Do a sanity check, showing that modest_account_mgr_account_names() 
543         returns NULL after modest_account_mgr_add_server_account() returned TRUE, 
544         which seems wrong.
545         
546         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
547         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no 
548         accounts exist yet, as in the UI spec.
549         
550         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
551
552 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
553
554         * src/maemo/Makefile.am:
555         * src/maemo/modest-connection-specific-smtp-edit-window.c:
556         * src/maemo/modest-connection-specific-smtp-edit-window.h: 
557         New window for editing connection-specific smtp details.
558         Not fully implemented.
559
560         * src/maemo/modest-connection-specific-smtp-window.c:
561         (modest_connection_specific_smtp_window_finalize) :
562         unref the tree model.
563         (on_button_edit): Show the edit window.
564
565 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
566
567         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol 
568         error for me.
569         
570         * src/maemo/Makefile.am:
571         * src/maemo/modest-connection-specific-smtp-window.c:
572         * src/maemo/modest-connection-specific-smtp-window.h:
573         New window for showing the list of connections, for connection-specific 
574         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
575         * src/maemo/easysetup/modest-easysetup-wizard.c:
576         (create_page_custom_outgoing): Show the new window when the button is clicked.
577
578 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
579
580         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
581         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
582         * src/maemo/modest-msg-edit-window.c:
583         (modest_msg_edit_window_insert_image):
584         * src/modest-conf.c: (modest_conf_key_escape):
585         * src/modest-mail-operation.c:
586         (modest_mail_operation_send_new_mail):
587         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
588         (modest_ui_actions_on_new_account):
589         * src/widgets/modest-attachment-view.c: (update_filename_request):
590         * src/widgets/modest-mail-header-view.c: 
591         Corrected warnings that were breaking the build, by commenting out unused variables, 
592         and a function, and by including a header.
593
594 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
595
596         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h, 
597         so we can #ifdef around platform-specific code when necessary.
598         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO 
599         to allow this to build for the GNOME platform too.
600
601 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
602
603         * src/maemo/easysetup/modest-easysetup-wizard.c:
604         Added util_increment_name() and used it in create_page_account_details() 
605         to make sure that the default account name is always a new name.
606         
607         (modest_easysetup_wizard_dialog_init), 
608         (set_default_custom_servernames): Some minor memory management fixes.
609
610 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
611
612         * Makefile.am:
613         * configure.ac:
614         * src/modest-runtime.c: (init_i18n): Restored the translation 
615         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR 
616         are defined in config.h, and the translations are installed.
617         
618         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE 
619         is defined for translation.
620
621 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
622
623         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
624         (load_from_file):
625         * src/maemo/easysetup/modest-easysetup-wizard.c:
626         (modest_easysetup_wizard_dialog_init):
627         * src/maemo/easysetup/modest-presets.c: (modest_presets_new): 
628         Use realistic paths (though they should use $prefix generically) to the 
629         mcc_mapping and provider-data.keyfile files which might work when they 
630         are installed by the future version of the operator-wizard package, 
631         and then fallback to paths in our source code, with an explanatory 
632         warning.
633
634 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
635
636         * configure.ac:
637         * src/Makefile.am:
638         * src/maemo/Makefile.am:
639         * src/maemo/easysetup/: Added files from the previously-exernal 
640         osso-modest-easysetup.
641         * src/maemo/modest-main-window-ui.h:
642         * src/modest-ui-actions.c: 
643         * src/modest-ui-actions.h:
644         Added modest_ui_actions_on_new_account() as a signal handler for the 
645         New Account menu item. It shows the easysetup wizard.
646         * po/en_GB.po: Added additional needed logical IDs and translations.
647         
648 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
649 Apparently ChangeLog is not used for some vague Nokia legal reasons.
650