1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
4 Only return the first level of folders under accounts, because the
5 osso-global-search UI spec doesn't want the rest.
6 This fixed projects.maemo.org bug NB#61811.
8 2007-06-26 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-tny-account-store.c:
11 * src/modest-tny-account-store.h:
12 Added modest_tny_account_is_memory_card_account().
13 * src/maemo/modest-main-window.c: (create_details_widget):
14 Show the same information items for the memory card as we show for the
15 local-folders, to fix projects.maemo.org bug NB#59307.
17 2007-06-26 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-tny-account-store.c: (get_password):
20 Added some checks for NULL to maybe prevent crashes, though I think
21 it was Philip's last commit that actually prevented the crash here
22 when creating a first new account.
23 But the new account is still not usable (no messages are shown)
24 until a restart of the application.
26 2007-06-26 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-maemo-global-settings-dialog.c:
29 (idle_select_default_focus):
30 * src/modest-mail-operation.c: (idle_notify_progress),
31 (idle_notify_progress_once), (idle_notify_update_account_queue),
32 (set_last_updated_idle), (update_account_thread),
33 (notify_get_msgs_full), (get_msgs_full_destroyer),
34 (get_msgs_full_thread):
35 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
36 * src/widgets/modest-header-view.c:
37 (idle_notify_headers_count_changed_destroy),
38 (idle_notify_headers_count_changed):
39 Use gdk_threads_enter() and gdk_threads_enter_leave() in
40 all idle handlers, because some other thread could be blocking
41 the GDK lock, so that it can do GUI stuff.
43 2007-06-26 Murray Cumming <murrayc@murrayc.com>
45 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
46 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
47 (on_idle_send_receive), (on_idle_open_default_inbox):
48 * src/maemo/modest-msg-edit-window.c:
49 (modest_msg_edit_window_attach_file_noninteractive):
50 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
51 to prevent a hang. I don't quite understand why these are necessary,
52 beause we should already be in the main loop. I guess something outside
53 of the main loop is taking the lock.
55 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
56 we are really using URIs, and use files that are more likely to exist.
58 2007-06-26 Murray Cumming <murrayc@murrayc.com>
60 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
61 necessary because configure.ac now defines different variables.
63 2007-06-26 Murray Cumming <murrayc@murrayc.com>
65 * libmodest-dbus-client/libmodest-dbus-client.c:
66 * libmodest-dbus-client/libmodest-dbus-client.h:
67 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
68 libmodest_dbus_client_compose_mail() is what things actually use.
70 * src/dbus_api/modest-dbus-api.h:
71 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
72 * tests/dbus_api/Makefile.am:
73 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
76 2007-06-26 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-init.c: (modest_init_local_folders):
79 For memory-card (or other non local-folders) maildir accounts,
80 always create an Archive folder, so that there is somewhere to put
81 messages. This should be less confusing, because the user does not need
82 to guess that the need to create a folder.
84 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
86 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
87 Fixed icon size by using (50, 50) which is the same as defined by
90 2007-06-25 Armin Burgmeier <armin@openismus.com>
92 * src/widgets/modest-window-mgr.c:
94 * configure.ac: Correctly recognize hildon-notify presence and fixed
95 the build without it being installed.
97 2007-06-25 Murray Cumming <murrayc@murrayc.com>
99 * libmodest-dbus-client/libmodest-dbus-client.c:
100 (libmodest_dbus_client_search): Fix the build. Sorry.
101 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
102 (reply_forward_cb): Initialize variables to fix the build.
104 * src/modest-tny-account-store.c:
105 (modest_tny_account_store_get_tny_account_by): Fix the account URI
106 comparison (a silly typo) so that email search results can be opened
107 when there are more than one account.
109 2007-06-25 Murray Cumming <murrayc@murrayc.com>
111 * libmodest-dbus-client/libmodest-dbus-client.c:
112 (libmodest_dbus_client_search),
113 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
114 instead of 1 second, because the search gets folders and messages from
115 the server, which can take a long time. When it times out,
116 osso-global-search will report no results.
118 We need to specify whether we should search only cached information
119 (maybe with a user preference), and the osso-email-search-plugin
120 API should really be improved to allow that option, and to allow results
121 to be delivered asynchronously in batches.
123 2007-06-25 Murray Cumming <murrayc@murrayc.com>
125 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
126 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
127 GTK_ICON_SIZE_DIALOG is probably the wrong size.
129 2007-06-25 Murray Cumming <murrayc@murrayc.com>
131 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
132 that is an empty string. D-Bus seems to give us these instead of NULL.
134 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
136 * src/dbus_api/modest-dbus-callbacks.c:
137 * src/maemo/easysetup/modest-easysetup-wizard.h:
138 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
139 * src/maemo/modest-connection-specific-smtp-edit-window.c:
140 (modest_connection_specific_smtp_edit_window_init):
141 * src/maemo/modest-maemo-global-settings-dialog.c:
143 * src/maemo/modest-maemo-utils.c:
144 (modest_maemo_utils_setup_images_filechooser):
145 * src/maemo/modest-main-window.c: (create_details_widget):
146 * src/maemo/modest-msg-edit-window.c:
147 (modest_msg_edit_window_attach_file_noninteractive),
148 (modest_msg_edit_window_color_button_change),
149 (modest_msg_edit_window_set_zoom):
150 * src/modest-mail-operation.c: (update_account_thread):
151 * src/modest-tny-account-store.c:
152 * src/modest-tny-account.c:
153 * src/widgets/modest-global-settings-dialog.c:
154 * src/widgets/modest-window.h:
158 2007-06-25 Murray Cumming <murrayc@murrayc.com>
160 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
161 * src/modest-search.c: (modest_search_folder),
162 (modest_search_all_accounts): Actually search only in the specified folder,
163 doing a simple match on the folder ID.
164 * src/modest-search.h: Added a folder field to the ModestSearch struct,
165 and added some documentation.
167 2007-06-22 Armin Burgmeier <armin@openismus.com>
169 * src/maemo/modest-maemo-utils.h:
170 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
171 modest_maemo_utils_get_supported_secure_authentication_methods.
173 * src/maemo/easysetup/modest-easysetup-wizard.c:
174 * src/maemo/modest-account-settings-dialog.c: Show correct error if
175 one occured, not just "Server does not support secure authentication".
177 2007-06-22 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-tny-account-store.c: (get_password):
180 Restored the call to tny_account_set_user() because Philip seems to have
181 stopped this from crashing (by not using the freed string). It still does
182 not work, but now we can test it.
184 2007-06-22 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/modest-msg-edit-window.c: (init_window):
187 Comment out use of an uninitialzed GtkScrolledWindow variable,
188 to fix the build and stop a crash. Yet again.
190 2007-06-22 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-tny-account-store.c: (get_password):
193 Remove the call to tny_account_set_user() because this actually crashes.
194 As mentioned in the last commit, it is known to not work anyway.
196 2007-06-22 Murray Cumming <murrayc@murrayc.com>
198 * src/modest-tny-account-store.c: (get_password):
199 Use tny_account_set_username() to tell tinymail that the username might
200 have changed too. But tinymail ignores this: see projects.maemo.org
202 * src/modest-ui-actions.c:
203 (modest_ui_actions_on_password_requested): Remove the useless attempt to
204 reset the connection when changing the username, and improve the comments.
205 Save the changed username to gconf at least, so it is used when Modest is
208 2007-06-21 Murray Cumming <murrayc@murrayc.com>
210 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
211 Do not use a query, so that we get all folders, including for POP and
212 local-folders. They work as search criteria too.
213 This fixes projects.maemo.org bug NB#57740.
215 2007-06-21 Murray Cumming <murrayc@murrayc.com>
217 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
218 Comment out the use of hildon_notification_set_sound() because it is
219 not declared, to fix the build. Warnings are serious, people.
221 2007-06-21 Armin Burgmeier <armin@openismus.com>
223 * src/maemo/modest-maemo-utils.h:
224 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
225 modest_maemo_utils_get_supported_secure_authentication_methods()
226 to query authentication methods for a specific user. This should fix
227 projects.maemo.org bug NB#61369.
229 * src/maemo/easysetup/modest-easysetup-wizard.c:
230 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
233 2007-06-21 Murray Cumming <murrayc@murrayc.com>
235 * libmodest-dbus-client/libmodest-dbus-client.h:
236 * libmodest-dbus-client/libmodest-dbus-client.c:
237 (modest_dbus_message_iter_get_search_hit),
238 (libmodest_dbus_client_search):
239 Reorganised and commented this.
240 Removed modest_search_hit_free() from the public API because it
243 Added libmodest_dbus_client_get_folders() and
244 modest_folder_result_list_free().
246 * src/dbus_api/modest-dbus-api.h:
247 * src/dbus_api/modest-dbus-callbacks.c:
248 (modest_dbus_req_filter): Commented. Moved most code to
249 on_dbus_method_search() and added on_dbus_method_get_folders().
251 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
252 of the extra D-Bus handler.
254 * tests/dbus_api/Makefile.am:
255 * tests/dbus_api/test_get_folders.c: New test for
256 libmodest_dbus_client_get_folders(). This seems to return an empty list
257 at the moment. That could be the same error that causes the message list
258 to be empty sometimes.
259 This should help with projects.maemo.org bug NB#57740.
261 2007-06-21 Armin Burgmeier <armin@openismus.com>
263 * src/modest-mail-operation.c: Do not call
264 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
265 notify the operation's end after having set the status to CANCELED for
266 the operation queue to listen on. This fixes a deadlock when there
267 were mail operations in the queue during its finalization.
269 * src/modest-singletons.c: Reordered uninitialization of the account
270 manager to happen after the mail operation queue was uninitialized
271 because the mail operation's in the queue might still try to access
272 the account manager (see modest_mail_operation_notify_end()). This
273 fixes a potential crash when terminating the application.
275 2007-06-21 Murray Cumming <murrayc@murrayc.com>
277 * src/modest-search.c:
278 (search_mime_part_and_child_parts): Moved some code here so we
279 can search recursively in child folders.
280 (modest_search_folder): Search in the message as a mime part, instead
281 of just its child mime parts.
282 (read_chunk), (search_mime_part_ogs):
283 Check how many bytes were read, to prevent an endless loop.
284 Searching in message bodies now works. This finishes the fix for
285 projects.maemo.org bug NB#61007.
287 2007-06-20 Murray Cumming <murrayc@murrayc.com>
289 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
290 Add a g_warning when the item is not a folder.
292 * src/modest-ui-dimming-rules.c:
293 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
294 when selected item is not a folder (for instance, an account), because
295 the UI spec only talks about folders.
296 I am not sure what the UI spec wants, so this might not totally fix
297 projects.maemo.org bug NB#60794.
299 2007-06-20 Murray Cumming <murrayc@murrayc.com>
301 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
302 (load_from_file): Sort the list. The unsorted list would be more noticeable
303 in non-English locales.
305 * src/maemo/modest-msg-edit-window.c:
306 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
307 warning and fix the build.
309 * src/maemo/modest-progress-bar-widget.c:
310 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
311 avoid a g_warning, and probably to avoid a crash.
313 2007-06-20 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-search.c: (modest_search_folder): Check for a GError
316 when calling tny_folder_get_headers(), to show that this is not the cause
319 2007-06-20 Murray Cumming <murrayc@murrayc.com>
321 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
322 Actually set the body query instead of the subject query.
324 * src/modest-search.c: (search_mime_part_ogs),
325 (search_mime_part_strcmp): Remove extra space from the text/* regex,
326 which would probably cause it to fail if we got this far.
328 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
329 to simplify the code.
330 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
331 be causing search-in-body to fail.
333 2007-06-20 Murray Cumming <murrayc@murrayc.com>
335 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
337 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
338 Better debug message when the folder cannot be found.
339 This should help with fixing projects.maemo.org bug #61287.
340 * src/modest-search.c: (add_hit): Do not leak the furl string.
342 2007-06-20 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-ui-actions.c:
345 (modest_ui_actions_on_folder_selection_changed):
346 Do not special-case TNY_MERGE_FOLDER here, because
347 modest_tny_folder_get_account() already does that. This fixes
348 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
349 shown when the Outbox was selected).
351 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
353 * libmodest-dbus-client/libmodest-dbus-client.c:
354 (_dbus_iter_get_string_or_null): Initialize the string variable in
355 case this helps with Dirk's crash.
357 2007-06-19 Murray Cumming <murrayc@murrayc.com>
359 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
360 though it is not implemented yet (this function is maybe not even used),
361 to avoid breaking ABI in future.
362 * libmodest-dbus-client/libmodest-dbus-client.c:
363 (get_attachments_string): Moved some code into this generic function.
364 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
365 sends email. It is maybe not used.
366 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
367 (on_send_mail): Use attachments.
369 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
370 * src/maemo/modest-msg-edit-window.c:
371 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
372 a filename before using it, to fix projects.maemo.org bug NB#58233.
374 2007-06-19 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
377 Initialize the continue_download variable to fix the build, and probably
378 to fix randome behaviour.
380 2007-06-18 Armin Burgmeier <armin@openismus.com>
382 * src/modest-tny-send-queue.h:
383 * src/modest-tny-send-queue.c: Keep track of the status of messages in
384 the queue so we can later show it in the UI. Replaced
385 modest_tny_send_queue_msg_is_being_sent() by
386 modest_tny_send_queue_get_msg_status().
388 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
390 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
391 gpointer. This probably was not harmful, but just to be sure.
393 2007-06-18 Murray Cumming <murrayc@murrayc.com>
395 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
396 Fix the build, but leave the function broken on Bora, because
397 hildon_uri_action_get_service() does not exist.
398 osso_uri_action_get_service() does not exist either, it seems.
400 2007-06-18 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-tny-account.c:
403 (modest_tny_account_new_from_server_account):
404 Uncommented the url debug output again, because it is useful for
405 debugging, as I said in the comment.
407 2007-06-18 Murray Cumming <murrayc@murrayc.com>
409 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
411 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
412 for Mameo Bora, to fix the build.
414 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
417 Fixed build with hildon < 0.99
419 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
420 Check if the selected account is busy instead of checking all accounts
422 * src/modest-account-mgr-priv.h:
423 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
424 (modest_account_mgr_init), (compare_account_name),
425 (modest_account_mgr_set_account_busy),
426 (modest_account_mgr_account_is_busy):
427 * src/modest-account-mgr.h:
428 Added busy information to the account manager. It possible to
429 set an account to busy or not busy now.
431 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
432 (modest_mail_operation_update_account),
433 (modest_mail_operation_notify_end):
434 Set the account to busy/not busy depending on the operation state.
436 * src/widgets/modest-account-view.c:
437 (modest_account_view_finalize), (get_last_updated_string),
438 (update_account_view), (on_account_busy_changed), (init_view):
439 Show string "Refreshing..." if the account is currently busy.
441 All this fixes projects.maemo.org bug NB#59711
443 2007-06-14 Armin Burgmeier <armin@openismus.com>
445 * src/widgets/modest-attachments-view.h:
446 * src/widgets/modest-attachments-view.c: Added
447 modest_attachments_view_has_attachments() and fixed coordinate
448 transformation in get_att_view_at_coords(). This fixes attachment
451 * src/widgets/modest-msg-view.c: Make use of
452 modest_attachments_view_has_attachments() to decide whether to show
453 attachments in the header.
455 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
458 (on_change), (on_combo_security_changed),
459 (modest_connection_specific_smtp_edit_window_init),
460 (modest_connection_specific_smtp_edit_window_set_connection),
461 (modest_connection_specific_smtp_edit_window_is_dirty):
462 * src/maemo/modest-connection-specific-smtp-edit-window.h:
463 * src/maemo/modest-connection-specific-smtp-window.c:
466 Show an comfirmation dialog for the smpt-edit-window if there are
467 unsaved changes and the user hits cancel.
468 (projects.maemo.org bug NB#60479)
470 2007-06-14 Armin Burgmeier <armin@openismus.com>
472 * src/maemo/easysetup/modest-easysetup-wizard.c:
473 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
474 address" info in banner instead of node, and select all the text as
475 per UI spec. This fixes projects.maemo.org bug NB#60550.
477 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
479 reviewed by: <delete if not using a buddy>
481 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
482 * src/modest-ui-actions.c: (folder_refreshed_cb):
484 2007-06-14 Murray Cumming <murrayc@murrayc.com>
486 * src/widgets/modest-folder-view.c: (filter_row):
487 Explictly filter out the per-account outbox accounts. I don't know why
488 these only sometimes show up, but now they should never show up in the UI.
489 This should fix projects.maemo.org bug NB#60160.
491 2007-06-14 Murray Cumming <murrayc@murrayc.com>
493 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
494 when the toolbar does not exist yet.
495 * src/modest-widget-memory.c: (save_settings_header_view):
496 Added g_warnings() to help us to discover when we are trying to set
497 an empty columns list in gconf.
499 2007-06-14 Murray Cumming <murrayc@murrayc.com>
503 Added modest_init_get_default_header_view_column_ids().
505 * src/modest-widget-memory.c: (restore_settings_header_view):
506 Use the new function to get defaults, if the gconf key is empty,
507 instead of not creating any columns. This seems to fix the
508 empty right-hand pane problems.
510 * src/widgets/modest-header-view.h: Improved documentation.
512 2007-06-13 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
515 Revert the use of the display name as the account name, because this
516 is generally wrong and would break the code that follows.
518 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
520 * src/maemo/easysetup/modest-easysetup-wizard.c:
521 (check_for_supported_auth_methods), (on_before_next),
524 More correct fix for projects.maemo.org bug NB# 58991
525 Do not longer accept AUTH_PASSWORD as secure method and choose
526 correct method when creating the account.
528 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
530 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
531 Fixed projects.maemo.org bug NB# 58991
533 2007-06-13 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-init.c: (modest_init_init_core),
536 (modest_init_local_folders): Fixed compilation errors.
538 2007-06-13 Murray Cumming <murrayc@murrayc.com>
540 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
541 Remove unnecessary lib/include, though it is good in principle when needed.
543 * src/modest-init.c: (modest_init_one_local_folder),
544 (modest_init_local_folders):
545 * src/modest-init.h: Initialize the .modest library for memory cards,
546 instead of just doing nothing for them. This should allow us to create
547 folders there, fixing projects.maemo.org bug NB#59297.
549 2007-06-13 Murray Cumming <murrayc@murrayc.com>
551 * libmodest-dbus-client/libmodest-dbus-client.c:
552 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
553 (libmodest_dbus_client_compose_mail),
554 (libmodest_dbus_client_open_message),
555 (libmodest_dbus_client_send_and_receive),
556 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
558 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
559 (on_idle_open_message), (modest_dbus_req_handler),
560 (search_result_to_message), (modest_dbus_req_filter):
561 * src/modest-search.c: (add_hit), (modest_search_folder),
562 (modest_search_all_accounts): Improved debug messages.
564 * tests/dbus_api/test_open_message.c: (main): Improved comments.
566 * src/modest-tny-account-store.c:
567 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
570 2007-06-13 Murray Cumming <murrayc@murrayc.com>
573 2007-06-12 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-tny-account-store.c: (get_server_accounts):
576 Call modest_tny_local_folders_account_add_merged_outbox_folders()
577 even when there are no accounts, so that the Outbox folder is always
578 visible. This fixes projects.maemo.org bug NB#60158.
580 2007-06-12 Murray Cumming <murrayc@murrayc.com>
582 * src/maemo/modest-main-window.c: (create_details_widget):
583 Use the mcen_va_never logical ID.
585 2007-06-12 Murray Cumming <murrayc@murrayc.com>
587 * src/dbus_api/modest-dbus-api.h:
588 * src/dbus_api/modest-dbus-callbacks.c:
589 (on_idle_open_default_inbox), (on_open_default_inbox),
590 (modest_dbus_req_handler):
591 Added a new OpenDefaultInbox method.
593 * libmodest-dbus-client/libmodest-dbus-client.h:
594 * libmodest-dbus-client/libmodest-dbus-client.c:
595 Added libmodest_dbus_client_open_default_inbox() to call the new
596 dbus method. This should be useful to projects.maemo.org bug NB#57214,
597 though it should maybe be used by a new osso-email-interface function.
599 * tests/dbus_api/Makefile.am:
600 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
603 2007-06-12 Murray Cumming <murrayc@murrayc.com>
605 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
606 NULL, so that the signals get all the keys. This should not actually
607 change any behaviour because we currently update everything when anything
610 2007-06-12 Murray Cumming <murrayc@murrayc.com>
612 * src/widgets/modest-folder-view.c: (text_cell_data),
613 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
614 (find_inbox_iter): If tinymail tells us that the folder is
615 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
616 This causes the inbox to be selected at startup, fixing part of
617 projects.maemo.org bug NB#56305.
619 * src/modest-ui-dimming-rules.c:
620 (modest_ui_dimming_rules_on_tools_smtp_servers):
621 * src/modest-ui-dimming-rules.h: Added a callback function to dim
622 the SMTP servers menu item.
623 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
624 that the SMTP Servers menu item is dimmed when there are no accounts,
625 as a future version of the UI spec will require. This fixes
626 projects.maemo.org bug NB#56305.
628 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
630 * src/maemo/modest-maemo-utils.c:
631 (modest_maemo_utils_get_supported_secure_authentication_methods):
632 Added label to dialog instead of unreadable title
634 * src/maemo/modest-main-window.c: (sync_accounts_cb),
635 (modest_main_window_new):
636 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
639 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
640 * src/modest-account-mgr.h:
641 Added method to avoid code duplication
643 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
644 (modest_ui_actions_on_send_receive):
645 Use modest_account_mgr_has_accounts
647 2007-06-11 Murray Cumming <murrayc@murrayc.com>
649 * src/maemo/easysetup/modest-presets.c:
650 (modest_presets_get_info_server_security): Do not report secure auth
652 * src/modest-protocol-info.c: Use the defines for the gconf key names
653 for secure authentication. This was not working because we were writing
654 Password and reading password, and the check was case sensitive.
655 With this, gmail now works for receiving and sending when created via
658 2007-06-11 Murray Cumming <murrayc@murrayc.com>
660 * src/maemo/easysetup/modest-presets.c:
661 (modest_presets_get_info_server_security): Correct the key name for
662 SecureSmtp, because it seems to be case-sensitive.
663 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
664 Do not try to get the 0th notebook page if there are 0 pages, to
667 2007-06-11 Murray Cumming <murrayc@murrayc.com>
669 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
670 Prevent use of the new notification feature for now, because it currently
671 shows one dialog for each new email, which is annoying.
673 2007-06-11 Murray Cumming <murrayc@murrayc.com>
675 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
676 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
677 when no country was selected, so that we show the global ones.
678 * src/maemo/easysetup/modest-presets.c:
679 (modest_presets_get_providers): Return only the global providers, not
680 all providers when mmc=0 was requested.
682 2007-06-11 Murray Cumming <murrayc@murrayc.com>
684 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
685 (easysetup_provider_combo_box_fill): Remove debug code that showed the
686 provider ID in the combo.
688 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
689 Do not show the page numbers, because it would be confusing when we add
690 the 2 extra pages for the custom setup, when the user chooses the "Other"
691 provider. This fixes projects.maemo.org bug NB#59028
693 * src/modest-init.c: (modest_init_init_core),
694 (modest_init_local_folders):
696 * src/modest-tny-account.c:
697 (modest_tny_account_new_for_local_folders): Do not create default folders
698 for the memory card. This should fix projects.maemo.org bug NB#59328.
700 2007-06-11 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
703 Free the changed_conf_keys string items. They are already freed in the
704 idle handler if that runs first.
706 2007-06-11 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-ui-actions.c:
709 (modest_ui_actions_on_password_requested): Check that the server name
710 is not NULL, because I just saw a password dialog with (null) as the
713 * src/modest-tny-folder.[h|c]: Added
714 modest_tny_folder_is_memory_card_folder().
715 * src/modest-ui-dimming-rules.c:
716 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
717 menu item for memory cards, as per the UI spec (section 7.4). This should
718 fix projects.maemo.org bug NB#59297.
720 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
722 * src/maemo/modest-main-window.c: (sync_accounts_cb):
723 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
724 is another problem with the code, see Murray's comment at line 772)
726 2007-06-08 Murray Cumming <murrayc@murrayc.com>
728 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
729 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
730 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
731 (load_from_file), (easysetup_country_combo_box_init),
732 (easysetup_country_combo_box_get_active_country_ids),
733 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
734 instead of just one ID, to avoid duplicate country names in the UI.
736 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
737 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
738 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
739 a single ID, avoiding duplicate providers.
740 * src/maemo/easysetup/modest-easysetup-wizard.c:
741 (on_combo_account_country): Adapt to use a list.
743 2007-06-08 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
746 keys changed in the last X seconds.
748 * src/modest-account-mgr.h:
749 * src/modest-account-mgr.c: (on_timeout_notify_changes),
750 (on_key_change), (modest_account_mgr_class_init),
751 (modest_account_mgr_init), (modest_account_mgr_finalize):
752 As the keys are changed, save them in a GSList* and signal that GSList*
753 further every X seconds, to batch changes, to allow us to do just one
754 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
755 bug NB#56941 and other (UI-blocking) delays when changing account settings.
757 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
758 changed signal signature.
760 * src/modest-conf.c: (modest_conf_set_list),
761 (modest_conf_on_change): Reenable notification.
763 (modest_conf_maemo_fake_on_change): Comment out the hack that
764 notified immediately instead of asynchronously.
766 * src/widgets/modest-account-view.h:
767 * src/widgets/modest-account-view.c:
768 (update_account_view): Select the previously-selected account ID,
769 if possible. This fixes projects.maemo.org bug NB#56933.
771 (on_account_changed), (on_account_removed),
772 (modest_account_view_select_account):
774 Remove the block/unblock functions
775 because they were not useful.
777 * src/maemo/modest-account-view-window.c:
778 (on_delete_button_clicked), (on_edit_button_clicked),
779 (on_new_button_clicked): Remove the use of the non-working block/unblock.
781 2007-06-08 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
784 Improve the error dialog to show Incorrect Account Settings, which seems
785 clearer, and say that the internal error message (to be removed from the
786 dialog later) is often misleading.
787 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
789 * src/modest-tny-account.c:
790 (modest_tny_account_new_from_server_account): Uncomment the printf of the
791 URL because this is so useful for debugging on the device.
793 * src/widgets/modest-serversecurity-combo-box.c:
794 (modest_serversecurity_combo_box_fill): Correct a logical ID.
796 2007-06-08 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-mail-operation.c:
799 (modest_mail_operation_send_new_mail):
800 Added a comment about a nasty but apparently harmless message. Details
801 added to the wiki g_warnings() page.
803 2007-06-08 Murray Cumming <murrayc@murrayc.com>
805 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
806 (modest_tny_send_queue_class_init):
807 Do not use the priv struct because it is empty, to avoid g_warnings
808 about a non-existant priv struct.
810 * src/modest-tny-account-store.c:
811 (modest_tny_account_store_get_server_account),
812 (modest_tny_account_store_get_transport_account_for_open_connection
813 ): Do not try to get transport server accounts for local folders,
814 because they don't have any. This avoids a g_warning().
816 * src/maemo/modest-main-window.c:
817 (modest_main_window_notify_send_receive_initied),
818 (on_configuration_key_changed):
819 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
821 * src/modest-mail-operation.c:
822 (modest_mail_operation_update_account):
823 * src/modest-tny-account-store.h:
824 * src/modest-tny-account.c:
825 (modest_tny_account_get_special_folder),
826 (modest_tny_account_new_for_local_folders),
827 (modest_tny_account_new_for_per_account_local_outbox_folder):
828 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
829 * src/modest-tny-local-folders-account.c:
830 (add_account_folders_to_merged_folder):
831 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
832 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
833 (modest_ui_actions_on_send):
834 * src/widgets/modest-folder-view.c: (update_model):
835 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
836 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
837 modest_tny_account_store_get_tny_account_by_account() to
838 modest_tny_account_store_get_server_account() to make the code clearer.
840 2007-06-07 Marcus Bauer <marcusb@openismus.com>
842 * src/dbus_api/modest-dbus-api.h:
843 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
844 * src/maemo/modest-msg-edit-window.c:
845 (modest_msg_edit_window_attach_file_noninteractive):
846 added g_warning in case the file to be attached does not exist
847 * tests/dbus_api/test_compose_mail.c: (main):
848 removed obsolete comment, added generic files as test case
850 2007-06-07 Murray Cumming <murrayc@murrayc.com>
852 * src/modest-tny-account-store.c: (get_server_accounts):
853 Create the local folders account only once, not once for each outbox, and
854 not only when there are some outboxes.
856 2007-06-07 Murray Cumming <murrayc@murrayc.com>
858 * src/widgets/modest-folder-view.c: (update_model): Comment out some
859 code that is causing a crash at startup. Sergio says that he is fixing this.
861 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
863 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
864 * src/maemo/modest-account-settings-dialog.c:
865 (create_page_outgoing),
866 (modest_account_settings_dialog_set_account_name),
867 (save_configuration):
868 - Fixed handling of the "Use secure authentication" toggle to comply with
869 the ui specification. See also projects.maemo.org bug NB#58400
871 - Restore the Secure connection setting combo correctly when loading
874 * src/maemo/modest-maemo-utils.c:
875 (on_camel_account_get_supported_secure_authentication),
876 (modest_maemo_utils_get_supported_secure_authentication_methods):
877 Fixed a crasher if operation is canceled
879 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
880 (modest_protocol_info_auth_is_secure):
881 * src/modest-protocol-info.h:
883 Added two new methods to determine if a protocol/auth method is secure/encrypted in
884 the sense of the "Use secure authentication" toggle.
886 2007-06-07 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-tny-account-store.h:
889 * src/modest-tny-account-store.c:
890 Added modest_tny_account_store_get_local_folders_account().
892 * src/modest-tny-folder.h:
893 * src/modest-tny-folder.c:
894 (modest_tny_folder_get_account):
895 Added this replacement for tny_folder_get_account() which returns
896 the local-folders account for TnyMergeFolders, to avoid the
897 warning about the unimplemented get_account_func() vfunc().
899 (modest_tny_folder_get_rules),
900 * src/modest-ui-actions.c:
901 (modest_ui_actions_on_folder_selection_changed):
902 * src/modest-mail-operation.c:
903 (modest_mail_operation_remove_folder),
904 (modest_mail_operation_xfer_folder),
905 (modest_mail_operation_rename_folder),
906 (modest_mail_operation_get_msg),
907 (modest_mail_operation_get_msgs_full),
908 (modest_mail_operation_remove_msg),
909 (modest_mail_operation_xfer_msgs),
910 (modest_mail_operation_refresh_folder):
911 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
913 2007-06-07 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
916 (modest_server_account_set_security):
917 * src/modest-defs.h: Add comments explaining that our
918 UI spec means TLS when it says Normal, so these do not look like errors.
920 * src/modest-tny-account.c:
921 (modest_tny_account_new_from_server_account): Use the new tinymail
922 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
923 for TLS. This should fix projects.maemo.org bug NB#58460.
925 2007-06-06 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/easysetup/modest-easysetup-wizard.c:
928 (create_account): Correct the position of the gconf sanity check warning.
929 (on_button_edit_advanced_settings): Show the dialog immediately, instead
930 of using the g_idle_add() hack, because this does not seem to be necessary
931 on osso 1.1. It might even work on Maemo Bora if the problems were actually
932 caused by something other than maemo's gconf.
933 This fixes projects.maemo.org bug #59022.
935 2007-06-06 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-account-mgr-helpers.c:
938 (modest_account_mgr_get_default_account): Do not check that the account
939 exists if there is no default account (NULL), to fix a runtime warning.
941 2007-06-06 Murray Cumming <murrayc@murrayc.com>
943 * src/widgets/modest-folder-view.c: (update_model):
944 Do not unref the treemodel before we have finished with it.
945 This prevents a valgrind warning and an occasional crash at startup.
947 2007-06-06 Marcus Bauer <marcusb@openismus.com>
949 * libmodest-dbus-client/libmodest-dbus-client.h:
950 added libmodest_dbus_client_compose_mail()
951 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
953 added functions needed for SendAsMail() functionality
954 * src/maemo/modest-msg-edit-window.c:
955 (modest_msg_edit_window_attach_file_noninteractive):
956 non interactively attaching files to message edit window
957 * src/widgets/modest-msg-edit-window.h:
958 * tests/dbus_api/Makefile.am:
959 added test_compose_mail.c
960 * tests/dbus_api/test_compose_mail.c: (main):
962 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
964 * src/modest-account-view.c:
965 Fixed bug projects.maemo.org bug NB#59307
967 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
969 * src/maemo/easysetup/modest-easysetup-wizard.c:
970 (get_serverport_incoming), (on_before_next), (create_account):
971 * src/maemo/modest-account-settings-dialog.c:
972 (modest_account_settings_dialog_set_account_name):
973 * src/maemo/modest-maemo-utils.c:
974 (on_camel_account_get_supported_secure_authentication_status),
975 (on_camel_account_get_supported_secure_authentication),
976 (on_secure_auth_cancel),
977 (modest_maemo_utils_get_supported_secure_authentication_methods):
979 Implemented security authentication for settings and easysetup.
981 2007-06-05 Murray Cumming <murrayc@murrayc.com>
983 * src/maemo/modest-main-window.c: (create_details_widget):
984 Show the total size for memory card accounts too, instead of showing
985 the name again. Fixes bug projects.maemo.org bug NB#59307.
987 2007-06-05 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-tny-simple-folder-store.c:
991 * src/modest-tny-simple-folder-store.h: Removed.
993 * src/modest-tny-local-folders-account.h
994 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
995 for the local-folders maildir, with an extra TnyMergedFolder containing
996 the folders of the per-account outbox store accounts.
997 * src/modest-tny-account-store.c: (get_server_accounts):
998 Add the outboxes to the special local folders account after creating it.
1000 * src/modest-tny-account.c:
1001 (modest_tny_account_new_for_local_folders): Create the derived
1002 account when creating the main local-folders account.
1004 * src/maemo/modest-main-window.c: (create_details_widget),
1005 (modest_main_window_set_contents_style):
1006 Adapted to the use of the derived account instead of the folder store.
1008 * src/modest-ui-actions.c:
1009 (modest_ui_actions_on_folder_selection_changed):
1010 * src/modest-ui-dimming-rules.c:
1011 (modest_ui_dimming_rules_on_new_folder):
1012 * src/widgets/modest-folder-view.c: (text_cell_data),
1013 (icon_cell_data), (filter_row), (update_model),
1014 (get_cmp_rows_type_pos):
1017 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1018 Do not get the priv struct, because no priv struct has been set,
1019 to avoid a runtime warning.
1021 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1022 #ifelse with #else, to fix a warning, to fix the build.
1025 2007-06-05 Christian Kellner <ckellner@openismus.com>
1027 * libmodest-dbus-client/libmodest-dbus-client.c:
1028 Fix small typo in doc (why do you always see them
1029 AFTER committing stuff?)
1032 2007-06-05 Christian Kellner <ckellner@openismus.com>
1034 * libmodest-dbus-client/libmodest-dbus-client.c:
1035 (libmodest_dbus_client_search):
1036 Initialize hit list with NULL. Also set folder list
1037 to "" if NULL was supplied.
1040 2007-06-03 Christian Kellner <ckellner@openismus.com>
1042 * libmodest-dbus-client/libmodest-dbus-client.c:
1043 (modest_search_hit_list_free):
1044 Make it save to call it with NULL.
1046 * src/dbus_api/modest-dbus-callbacks.c:
1047 * src/modest-search.c:
1048 Return full ModestSearchHits as the search result list not TnyHeader
1049 since can't be around withouth the correspoding TnyFolder.
1051 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1053 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1054 Added currently commented code to check for secure auth
1056 * src/maemo/modest-account-settings-dialog.c: (on_response),
1057 (save_configuration), (show_ok):
1058 Fixed projects.maemo.org bugs NB #59248 and #59251
1060 * src/maemo/modest-maemo-utils.c:
1061 (on_camel_account_get_supported_secure_authentication_status),
1062 (on_camel_account_get_supported_secure_authentication),
1063 (modest_maemo_utils_get_supported_secure_authentication_methods):
1064 * src/maemo/modest-maemo-utils.h:
1065 Moved get_supported_secure_authentication() method here to be able
1066 to use it from easysetup wizard.
1068 * src/modest-pair.c: (on_pair_compare_as_string):
1069 Should compare string with first part of pair and not
1070 strcmp pairs which will crash.
1072 * src/modest-protocol-info.c:
1073 (modest_protocol_info_protocol_is_store):
1074 * src/modest-protocol-info.h:
1075 Added modest_protocol_info_get_auth_protocol_name()
1077 2007-06-03 Armin Burgmeier <armin@openismus.com>
1079 * src/modest-mail-operation.c:
1080 (modest_mail_operation_get_msgs_full): Set priv->account also when
1081 only retrieving a single message. This avoids a crash when canceling
1084 (modest_mail_operation_notify_end): Do not explicitely remove the
1085 operation from the queue but only emit the progress_changed signal.
1086 The queue itself listens to that signal to remove the operation when
1087 it is finished. This reduces coupling and removes a potential deadlock
1088 when modest_mail_operation_notify_end() is called from the queue
1089 itself. If that is a problem performance-wise, I would suggest to
1090 implement a status-changed signal or something.
1092 * src/modest-mail-operation-queue.c: Make sure to never call a
1093 function from another file while the queue is locked. This (hopefully)
1094 fixes another deadlock when exiting the application while retrieving
1097 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1099 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1100 Fixed build if libogs is not available
1102 2007-06-03 Christian Kellner <ckellner@openismus.com>
1104 * libmodest-dbus-client/libmodest-dbus-client.h:
1105 * libmodest-dbus-client/libmodest-dbus-client.c:
1106 (libmodest_dbus_client_delete_message):
1107 Implement deletion of messages (Client side).
1109 (modest_search_hit_free),
1110 (modest_search_hit_list_free):
1111 Utility functions to free the result hits.
1113 * src/dbus_api/modest-dbus-api.h:
1114 * src/dbus_api/modest-dbus-callbacks.c:
1115 (on_delete_message),
1116 (modest_dbus_req_handler):
1117 Implement deletion of messages (Server side).
1119 * tests/dbus_api/test_search.c: (main):
1122 * tests/dbus_api/Makefile.am:
1123 * tests/dbus_api/test_delete_message:
1124 Add little test for the message deletion logic
1126 2007-06-03 Armin Burgmeier <armin@openismus.com>
1128 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1129 when the operation queue was not empty. projects.maemo.org bug
1132 2007-06-03 Armin Burgmeier <armin@openismus.com>
1134 * src/widgets/modest-account-view.c
1135 (on_account_default_toggled): Toggle default account column
1136 explicitely instead of waiting for gconf notification (which is
1137 currently ignored). This should fix projects.maemo.org bug NB#56910
1138 for now. It should probably be removed when gconf notifications are
1141 2007-06-03 Christian Kellner <ckellner@openismus.com>
1143 * libmodest-dbus-client/libmodest-dbus-client.c:
1144 Removed debugging spew.
1146 * src/dbus_api/modest-dbus-callbacks.c:
1147 Added debugging info.
1149 * src/modest-search.c:
1150 (modest_search_all_accounts):
1151 Use tny_account_store_get_accounts () on the account store
1152 to get all accounts which is the way to get all accounts.
1154 * tests/dbus_api/test_search.c: (main):
1155 Make it possible to supply the search term on the command line.
1157 2007-06-03 Christian Kellner <ckellner@openismus.com>
1159 * libmodest-dbus-client/libmodest-dbus-client.c:
1160 * libmodest-dbus-client/libmodest-dbus-client.h:
1161 Implement searching for mesages over raw dbus. (Client side)
1163 * src/dbus_api/Makefile.am:
1164 * src/dbus_api/modest-dbus-api.h:
1165 * src/dbus_api/modest-dbus-callbacks.c:
1166 * src/dbus_api/modest-dbus-callbacks.h:
1167 Search framework (Server side). Also implement on_idle_open_message().
1169 * src/maemo/modest-platform.c: (modest_platform_init):
1170 Prepare for raw dbus/osso rpc interaction.
1172 * src/modest-search.h:
1173 Changed minsize from unspecific guint to guint32.
1175 * src/modest-search.c:
1177 Added strange hack which magically made tnymail work.
1179 (modest_search_folder),
1180 (modest_search_account),
1181 (modest_search_all_accounts):
1182 Implement helper functions to search all accounts, specific account
1185 * tests/dbus_api/Makefile.am:
1186 * tests/dbus_api/test_open_message.c:
1187 Read url to open from commandline.
1189 * tests/dbus_api/test_search.c:
1190 Implement small test for dbus search stuff
1192 2007-06-02 Armin Burgmeier <armin@openismus.com>
1194 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1195 include account type and account title. This fixes projects.maemo.org
1198 * src/maemo/modest-account-view-window.c: Set a title for the window.
1200 2007-06-02 Armin Burgmeier <armin@openismus.com>
1202 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1203 incoming and outgoing server name based on email address and server
1204 types as long as the names have not been edited manually. This fixes
1205 projects.maemo.org bug NB#58671.
1207 2007-06-02 Armin Burgmeier <armin@openismus.com>
1209 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1210 server type cannot be changed in future to the incoming details page
1211 when creating an account. This fixes projects.maemo.org bug NB#59029.
1213 2007-06-02 Armin Burgmeier <armin@openismus.com>
1215 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1216 and assigned max width chars so that they wrap instead of being
1217 truncated. Fixes projects.maemo.org bug NB#56126.
1219 2007-06-02 Armin Burgmeier <armin@openismus.com>
1221 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1222 introductory note to the connection specific smtp servers dialog, as
1223 section 8.12 of the email UI specification requires. This fixes
1224 projects.maemo.org bug NB#59212.
1226 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1229 Check for running mail operations, and offer to cancel them, as per the UI
1230 spec. This fixes projects.maemo.org bug NB#59041 .
1231 However, I suspect that tinymail may still use the network connection
1232 in ways that we cannot detect or cancel. But it should at least adapt to
1233 changes fairly well.
1235 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1237 * src/modest-tny-account-store.c: (recreate_all_accounts),
1238 (get_cached_accounts), (get_server_accounts): Do more sensible
1239 ref-counting of the temporarily-cached outbox accounts list. This seems
1240 to fix a crash when entering the password when the password was wrong.
1242 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1244 * src/gnome/modest-main-window.c: (connect_signals):
1245 * src/modest-tny-account-store.c: (get_password),
1246 (modest_tny_account_store_alert): Added comments and clues and
1247 commented-out code about how we currently fail to deal with connection
1248 errors and wrong passwords, and how we should.
1250 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1252 * src/widgets/modest-retrieve-combo-box.c:
1253 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1254 This fixes projects.maemo.org bug NB#58472 .
1256 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/easysetup/modest-easysetup-wizard.c:
1259 (create_page_complete_easysetup):
1260 (create_page_complete_custom): Correct the last commit,
1261 putting the correct sentences in the correct pages.
1263 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1265 * src/maemo/easysetup/modest-easysetup-wizard.c:
1266 (create_page_complete_custom): Show the second sentence of text
1267 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1270 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1273 Set the leave-on-server conf key by default. This fixes
1274 projects.maemo.org bug NB#59258 .
1276 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/modest-account-view-window.c:
1279 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1280 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1283 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/easysetup/modest-easysetup-wizard.c:
1286 (create_caption_new_with_asterisk):
1287 * src/maemo/modest-account-settings-dialog.c:
1288 (create_caption_new_with_asterisk):
1289 Uncomment the code to add the asterisk, because they are no longer in the
1290 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1291 (update_incoming_server_title): Add an asterisk here too.
1293 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1295 * src/maemo/modest-maemo-global-settings-dialog.c:
1296 (current_connection): Check that we are even connected before trying to
1297 get the current connection name, to prevent a warning.
1299 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1300 Change the comments because tny_maemo_conic_device_connect() is now meant to
1302 * src/modest-mail-operation.c:
1303 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1304 make sure we have a connection and fail if we can't connect.
1306 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1308 * src/maemo/modest-main-window.c:
1309 (on_account_store_connecting_finished): Do not try to get the
1310 connection ID if we are not really connected. I am surprised that
1311 this signal handler is called when we are not connected.
1313 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1315 * src/modest-error.h:
1316 * src/modest-ui-actions.c:
1317 (modest_ui_actions_get_msgs_full_error_handler):
1318 Renamed an enum, added comments, added an enum
1319 for retrieve-limit errors.
1321 * src/modest-mail-operation.c: (foreach_add_item),
1322 (internal_folder_observer_update), (update_account_thread),
1323 (modest_mail_operation_get_msgs_full):
1324 (modest_mail_operation_update_account),
1325 Added comments about how this works, and some code that should
1326 (but does not) check the retrieve-limit. See the TODO comment.
1328 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1330 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1331 Initialize help_id to fix the build. Warnings are good.
1333 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1335 * src/widgets/modest-hbox-cell-renderer.c:
1336 (modest_hbox_cell_renderer_append):
1337 * src/widgets/modest-vbox-cell-renderer.c:
1338 (modest_vbox_cell_renderer_append):
1339 Fix the last commit by doing an extra ref.
1341 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1343 * src/widgets/modest-hbox-cell-renderer.c:
1344 (modest_hbox_cell_renderer_append):
1345 * src/widgets/modest-vbox-cell-renderer.c:
1346 (modest_vbox_cell_renderer_append):
1347 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1348 to fix the build with Maemo Bora.
1349 However, there seems to be a remaining crash, probably due to reference
1352 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account.c:
1355 (modest_tny_account_new_for_local_folders):
1356 Use hildon_file_system_info_async_new() to get a better name for
1357 the memory card account, setting it as the account name.
1358 The timing seems to work, but this is probably
1359 not the best place to do this. See the TODO comment.
1360 * src/maemo/modest-main-window.c: (create_details_widget):
1361 * src/widgets/modest-folder-view.c: (text_cell_data):
1362 Use the tny account name instead of hardcoding a name.
1364 2007-05-30 Christian Kellner <ckellner@openismus.com>
1366 * src/modest-search.c: (modest_search):
1367 Correctly set part_search_func even if we have already parsed
1368 the query and thus a valid OgsTextSearcher object.
1370 2007-05-30 Christian Kellner <ckellner@openismus.com>
1373 Search and check for libogs.
1376 Incooparte the ogs build env.
1378 * src/modest-mime-part-search-stream.c:
1379 * src/modest-mime-part-search-stream.h:
1380 Removed since we do the real searching now in modest-search.c.
1382 * src/modest-search.c:
1383 * src/modest-search.h:
1384 Implement support for ogs. We use that if available and requested
1385 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1386 should now handle the corner case when the search term is spread
1387 across multiple reads.
1388 Also the logic in modest_search () was corrected to search all
1389 requested fields until one is found.
1391 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1395 * src/modest-init.h:
1396 * src/modest-init.c: Made modest_init_local_folders() take a
1397 path and be public so we can iniitialize maildir folders on
1400 * src/modest-local-folder-info.h:
1401 * src/modest-local-folder-info.c:
1402 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1404 * src/modest-tny-account.c:
1405 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1406 still means the standard local-folders path on the local volume.
1408 * src/modest-tny-account-store.c:
1409 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1410 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1411 all accounts when that happens.
1412 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1413 this too, so it shows up in the treeview.
1415 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1417 * src/maemo/modest-maemo-global-settings-dialog.c:
1418 (current_connection):
1419 * src/widgets/modest-global-settings-dialog.c:
1420 (current_connection_default):
1421 Use the enum values instead of 0, 1 and -1,
1422 to make the code clearer.
1424 * src/modest-account-mgr-helpers.c:
1425 (modest_account_mgr_get_connection_specific_smtp): Make this code
1428 * src/modest-runtime.h:
1429 * src/modest-runtime.c:
1430 Added modest_runtime_remove_all_send_queues().
1431 * src/maemo/modest-main-window.c:
1432 (on_account_store_connecting_finished): Recreate the send queues,
1433 using the appropriate transport accounts for this new connection.
1434 Some futher adapting might be needed if the old send queues are not
1435 automatically stopped at this point.
1437 * src/modest-tny-account-store.c: (get_server_accounts):
1438 Create the connection-specific transport accounts, so that they can
1439 be found later by their ID.
1441 * src/modest-tny-account.h:
1442 * src/modest-tny-account.c:
1443 Added modest_tny_account_new_from_server_account_name().
1444 modest_tny_account_new_from_server_account(): Do not create the
1445 send queues here, because they will be
1446 recreated anyway when the connection changes for the first time.
1448 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1450 * src/modest-local-folder-info.h:
1451 * src/modest-local-folder-info.c:
1452 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1453 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1454 tbox_folder): Take a modest account name instead of a server TnyAccount,
1455 so we can have per-modest-account rather than per-transport-account
1457 We must make sure that we change or recreate the exisitng send queues
1458 when the connection changes for connection-specific transport accounts.
1460 * src/modest-tny-account-store.c:
1461 (create_per_account_local_outbox_folders): Create outboxed per modest
1462 account, not per transport account.
1464 * src/modest-tny-account.h:
1465 * src/modest-tny-account.c:
1466 (modest_tny_account_get_special_folder): For outboxes, get the
1467 parent modest account name. The account is ignored for other folders.
1468 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1469 modest account name rather than a server TnyAccount.
1471 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1473 * src/modest-tny-account.c:
1474 (modest_tny_account_new_from_server_account):
1475 Call modest_runtime_get_send_queue() immediately after creating transport
1476 accounts, so that they start trying to send email from the outbox as soon
1477 as possible at startup. This is probably what we want.
1479 * src/modest-mail-operation.c: (update_account_thread):
1480 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1481 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1482 * src/modest-tny-send-queue.h:
1483 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1484 (modest_ui_actions_on_send):
1485 Added comments about how sending works, though it needs some more work.
1487 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1489 * src/modest-tny-account.c:
1490 (modest_tny_account_get_special_folder): Add TODO because this fails when
1491 the network is busy.
1492 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1493 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1494 Do not try to show this window when there is no active account. The UI
1495 specs does not tell us what to do in this case.
1497 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1501 * src/maemo/Makefile.am:
1502 * src/widgets/Makefile.am: Some dist fixes.
1504 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/modest-connection-specific-smtp-window.c:
1507 (on_button_edit): Make the code clearer, to prevent a double free.
1509 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1511 * src/maemo/modest-account-settings-dialog.c:
1512 (modest_account_settings_dialog_set_account_name),
1513 Check the connection-specific smtp servers checkbox if there are any.
1515 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1516 (modest_connection_specific_smtp_edit_window_init):
1517 Start with a suitable port number.
1519 * src/modest-account-mgr-helpers.h:
1520 * src/modest-account-mgr-helpers.c: Added
1521 modest_account_mgr_get_has_connection_specific_smtp().
1523 (modest_account_mgr_set_connection_specific_smtp),
1524 (modest_account_mgr_remove_connection_specific_smtp),
1525 (modest_account_mgr_get_has_connection_specific_smtp),
1526 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1527 connection-specific smtp server accounts in the account, rather than
1528 the server account conf dir.
1530 This fixes bug projects.maemo.org bug NB#58263 .
1532 * src/modest-tny-account-store.c:
1533 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1534 if there are no server accounts yet, to prevent an infinite loop when there
1535 are no accounts. Document that one must be called before the other.
1537 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-account-mgr-helpers.c:
1540 (modest_account_mgr_get_default_account): Make sure that at least
1541 one account is always the default, if there are any enabled accounts.
1542 This is just a sanity check that shouldn't be necessary.
1544 * src/modest-account-mgr-priv.c:
1545 (_modest_account_mgr_account_from_key): Unescape the conf key to
1546 get the real account name. For instance, this is an issue if a space
1547 was in the account name, which can happen because the account name
1548 is generated from the display name.
1549 (_modest_account_mgr_get_account_keyname): Always escape the
1551 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1552 Unescape the conf keys to get the real account names.
1554 For instance, previously the is-default radio button in the accounts
1555 list was not checked for any accounts at first. This fixes that,
1556 and might fix several similar bugs.
1558 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1560 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1561 Removed some debug printfs.
1563 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1565 Modest on-disk outbox directories are now here, for instance:
1566 $HOME/.modest/outboxes/<account-id-1>/outbox
1567 $HOME/.modest/outboxes/<account-id-2>/outbox
1569 $HOME/.modest/local-folders/outbox
1570 so we can have a separate outbox for each account.
1571 But they are shown as one outbox in the GtkTreeView, by using a
1572 TnyMergeFolder in a ModestTnySimpleFolderStore.
1575 * src/modest-tny-simple-folder-store.c:
1576 * src/modest-tny-simple-folder-store.h:
1577 Added ModestTnySimpleFolderStore, used to contain folders from
1578 other folder stores, such as other accounts.
1580 * src/modest-tny-outbox-account.h:
1581 * src/modest-tny-outbox-account.c:
1582 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1583 used for the per-account local outbox folders.
1585 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1586 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1587 only use this (internally) now for the non-outbox local folders.
1589 * src/modest-init.h:
1590 * src/modest-init.c: Added modest_init_one_local_folder(), for
1591 setting up the directory structure for each local folder.
1593 * src/modest-local-folder-info.c:
1594 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1595 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1597 * src/modest-local-folder-info.h:
1598 * src/modest-tny-account-store.c: (on_account_removed),
1599 (on_account_changed), (create_per_account_local_outbox_folders),
1600 (get_server_accounts), (modest_tny_account_store_get_accounts),
1601 (modest_tny_account_store_get_tny_account_by_account),
1602 (modest_tny_folder_store_is_virtual_local_folders):
1604 * src/modest-tny-account.h:
1605 * src/modest-tny-account.c:
1606 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1607 to create an on-disk per-account local outbox folder for each
1609 (create_per_account_local_outbox_folders): Create a local outbox folder
1610 for each transport account.
1611 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1612 for all local folders.
1614 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1615 instead of using g_object_get/set() directly. It is clearer.
1617 (modest_tny_folder_store_get_message_count),
1618 (modest_tny_folder_store_get_local_size
1619 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1620 because we now use these with non-acount folder stores.
1622 (modest_tny_account_get_special_folder),
1623 (modest_tny_account_new_from_server_account),
1624 (modest_tny_account_new_from_account):
1625 (recurse_folders): Adjust to the new outbox system.
1627 * src/modest-tny-folder.h:
1628 * src/modest-tny-folder.c:
1629 (modest_tny_folder_is_local_folder),
1630 (modest_tny_folder_get_local_folder_type),
1631 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1633 * src/widgets/modest-main-window.h:
1634 * src/maemo/modest-main-window.c: (create_details_widget),
1635 (modest_main_window_set_contents_style): Show details for any folder store,
1638 (modest_tny_folder_get_rules):
1639 Remove the const. C does not support constness enough for this.
1641 * src/modest-ui-actions.c:
1642 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1643 make all outboxes appear as one, in the usual local-folders tree node.
1645 (set_active_account_from_tny_account),
1646 (modest_ui_actions_on_folder_selection_changed):
1647 * src/widgets/modest-folder-view.c: (text_cell_data),
1648 (icon_cell_data), (filter_row),
1649 (add_account_folders_to_merged_folder),
1650 (add_account_folders_to_simple_folder_store), (),
1651 (get_cmp_rows_type_pos), (cmp_rows),
1652 (modest_folder_view_set_account_id_of_visible_server_account):
1653 Adjust to the new outbox system, using generic folder stores and folders
1654 in the GtkTreeModel.
1656 2007-05-23 Christian Kellner <ckellner@openismus.com>
1658 * src/modest-mail-operation.c:
1659 (modest_mail_operation_update_account):
1660 Use info->max_size instead of unintialized local var [small
1661 build fix]. (Added TODO to review that change since I don't
1664 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1666 * libmodest-dbus-client/libmodest-dbus-client.c:
1667 (libmodest_dbus_client_compose_mail): function added
1668 * src/dbus_api/modest-dbus-api.h:
1669 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1670 (on_compose_mail): Implementation of the SendAsMail functionality
1672 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-account-mgr.c:
1675 (modest_account_mgr_add_server_account): Set the secure-connection
1676 conf key for transport accounts as well as store accounts. I don't know
1677 why the if was there. For instance, this makes sure that we use SSL
1678 for the gmail preset from the easysetup wizard.
1680 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1682 * src/gnome/modest-main-window.c:
1683 (on_account_store_connecting_finished), (connect_signals):
1684 * src/maemo/modest-main-window.c:
1685 (on_account_store_connecting_finished), (connect_signals),
1686 (modest_main_window_new):
1687 Handle TnyAccountStore::connecting-finished instead of
1688 TnyDevice::connection-changed, because we cannot actually perform
1689 operations on accounts until TnyAccountStore has itself responded to
1690 the TnyDevice::connection-changed signal. This prevents a GError from
1692 Do not try to update at startup, because we (at least on scratchbox)
1693 already do an update at startup when the device goes online.
1694 This prevents a GError from tinymail.
1695 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1696 Added TODO about stopping simultaneous operations.
1698 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1701 * src/modest-mail-operation-queue.c:
1702 (modest_mail_operation_queue_remove):
1703 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1704 about where they happened.
1706 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1708 * src/modest-ui-actions.c:
1709 (modest_ui_actions_on_password_requested): Make sure that the remember
1710 output parameter is always TRUE.
1712 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1715 Show a OK/Cancel dialog if the error is a question, though we still do not
1716 know anything more about what we are asking the user.
1717 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1718 Fix an uninitialized variable (helper). This is a logic error, however.
1720 2007-05-21 Christian Kellner <ckellner@openismus.com>
1722 * src/modest-search.h:
1723 Correct bit shifting in the ModestSearchFlags enum.
1725 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1727 * src/modest-tny-account.c:
1728 (modest_tny_account_new_from_server_account): Do not use the lsub and
1729 check-all hard-coded IMAP options when using POP.
1731 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1733 * src/modest-tny-account.c:
1734 (modest_tny_account_new_from_server_account):
1735 Use NULL for the secure-auth method for POP when Password auth has been
1736 specified by the user, as we already do for IMAP. "auth=Login" causes
1737 an error from camel or the server.
1739 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1741 * src/maemo/modest-account-settings-dialog.c:
1742 (create_page_account_details),
1743 (modest_account_settings_dialog_set_account_name):
1744 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1745 for the leave-on-server checkbox, rathr than just the checkbox, when
1746 the protocol is not POP.
1748 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1750 * src/widgets/modest-account-view.c:
1751 * src/widgets/modest-account-view.h:
1752 Added modest_account_view_select_account() which will be useful later
1753 to asynchronously re-select the edited account.
1755 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1757 * src/maemo/modest-account-settings-dialog.c:
1758 (modest_account_settings_dialog_set_account_name):
1759 Automatically choose the port numbers based on the secure authentication
1760 methods, if they have not been chosen before.
1761 This fixes projects.maemo.org bug NB#56273 .
1763 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1765 * src/maemo/modest-main-window-ui.h:
1766 * src/modest-ui-actions.c:
1767 * src/modest-ui-actions.h:
1768 Connect the Tools/SMTP Servers menu item to
1769 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1770 SMTP servers dialog, as in the UI specification and saves changes when it
1771 is closed. This fixed projects.maemo.org bug NB#56305 .
1773 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-connection-specific-smtp-window.c:
1776 (modest_connection_specific_smtp_window_init):
1777 Use gtk_window_set_default_size() to make this window big enough, so
1778 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1780 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1783 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1784 (modest_connection_specific_smtp_edit_window_init),
1785 Do not try to connect to a combobox signal before the combobox exists.
1786 This fixes the cras in projects.maemo.org bug NB#56288 .
1787 (modest_connection_specific_smtp_edit_window_get_settings):
1788 Remove the server_account_name parameter which was being checked for NULL
1789 though it was not used.
1791 * src/maemo/modest-connection-specific-smtp-window.c:
1792 (modest_connection_specific_smtp_window_fill_with_connections),
1793 (on_button_edit), (modest_connection_specific_smtp_window_init):
1794 Correct the number of treemodel columns to prevent a warning.
1795 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1796 libconic does not work.
1798 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-tny-account.c:
1801 (modest_tny_account_new_from_server_account):
1802 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1803 SMTP when "None" was chosen by the user. However, with my SMTP server that
1804 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1807 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1810 to explain the memory management issue with the ID in the ModestPair.
1812 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1813 (add_sending_page), (modest_account_assistant_finalize):
1814 * src/gnome/modest-gnome-global-settings-dialog.c:
1815 (create_updating_page), (create_composing_page):
1816 * src/gnome/modest-msg-edit-window.c: (get_transports),
1817 (init_window), (modest_msg_edit_window_finalize),
1818 (modest_msg_edit_window_get_msg_data):
1819 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1820 * src/gnome/modest-transport-widget.c:
1821 (modest_transport_widget_finalize), (smtp_configuration):
1822 * src/maemo/modest-maemo-global-settings-dialog.c:
1823 (create_updating_page), (create_composing_page):
1824 * src/maemo/modest-msg-edit-window.c: (get_transports),
1825 (init_window), (modest_msg_edit_window_finalize),
1826 (modest_msg_edit_window_get_msg_data),
1827 (modest_msg_edit_window_free_msg_data):
1828 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1829 (modest_store_widget_finalize):
1830 * src/maemo/modest-transport-widget.c:
1831 (modest_transport_widget_finalize), (smtp_configuration):
1832 * src/modest-main.c: (send_mail):
1833 * src/widgets/modest-combo-box.h:
1834 * src/widgets/modest-global-settings-dialog-priv.h:
1835 * src/widgets/modest-global-settings-dialog.c:
1836 (modest_global_settings_dialog_finalize):
1837 * src/widgets/modest-msg-edit-window.h:
1838 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1839 as long as the combo box, to prevent use of freed memory for the ID.
1841 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1843 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1844 get_accounts(), to make this clearer. Do not check for the enabled gconf
1845 key, because we do not use this for server accounts (at least, not yet).
1846 This allows us to send email again.
1848 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1850 * src/maemo/modest-platform.c:
1851 (on_modest_conf_update_interval_changed), (modest_platform_init):
1852 Only respond to this particular key change. All these strcmp()s cannot be
1855 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1857 * src/maemo/modest-maemo-global-settings-dialog.c:
1858 (current_connection): Prevent a crash in scratchbox when
1859 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1860 * src/maemo/modest-platform.c:
1861 (on_modest_conf_update_interval_changed), (modest_platform_init):
1862 Get the update interval from gconf and reset it when the gconf key changes.
1864 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1866 * src/modest-protocol-info.c:
1867 * src/modest-protocol-info.h: Adde enum-specific get functions,
1868 instead of using a ModestProtocolType enum parameter.
1870 * src/gnome/modest-account-assistant.c:
1871 * src/gnome/modest-store-widget.c:
1872 * src/gnome/modest-store-widget.h:
1873 * src/gnome/modest-transport-widget.c:
1874 * src/gnome/modest-transport-widget.h:
1875 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1876 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1877 * src/maemo/easysetup/modest-easysetup-wizard.c:
1878 * src/maemo/modest-account-settings-dialog.c:
1879 * src/maemo/modest-account-settings-dialog.h:
1880 * src/maemo/modest-store-widget.c:
1881 * src/maemo/modest-store-widget.h:
1882 * src/maemo/modest-transport-widget.c:
1883 * src/maemo/modest-transport-widget.h:
1884 * src/modest-account-mgr-helpers.c:
1885 * src/modest-account-mgr-helpers.h:
1886 * src/modest-account-mgr.c:
1887 * src/modest-account-mgr.h:
1888 * src/modest-tny-account.c:
1889 * src/modest-tny-folder.c:
1890 * src/widgets/modest-account-view.c:
1891 * src/widgets/modest-retrieve-combo-box.c:
1892 * src/widgets/modest-retrieve-combo-box.h:
1893 * src/widgets/modest-secureauth-combo-box.c:
1894 * src/widgets/modest-serversecurity-combo-box.c:
1895 * src/widgets/modest-serversecurity-combo-box.h:
1896 * tests/check_account-mgr.c:
1897 Use the specific functions, and use the re-renamed enum values for GNOME too.
1899 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-pair.h:
1902 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1903 so we can get the second based on the first.
1905 * src/maemo/modest-account-settings-dialog.h:
1906 * src/maemo/modest-account-settings-dialog.c:
1907 Added get_supported_secure_authentication_methods(), though it is mostly
1908 commented-out for now until the necessary API is committed to tinymail.
1909 (modest_account_settings_dialog_set_account_name),
1910 (save_configuration): Request the supported authentication methods from the
1911 server, so we can choose a working method.
1913 * src/modest-tny-account-store.h:
1914 * src/modest-tny-account-store.c:
1915 (modest_tny_account_store_get_session): Rename from
1916 tny_account_store_get_session().
1918 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-protocol-info.h: Split the ModestProtocol enum
1921 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1922 There was no need to have these unrelated values in one enum.
1924 * src/: many files: Adapted to changed enum. This makes the code a bit
1925 clearer, and the compiler could catch some errors.
1927 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1930 Show the detailed internal camel error message when an error happens
1931 during the configuration, so that our testers can give us more clues.
1932 For instance, in projects.maemo.org bug NB#56910 .
1934 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-tny-account.c:
1937 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1938 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1940 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1943 * src/maemo/modest-account-settings-dialog.c:
1944 (modest_account_settings_dialog_set_account_name),
1945 (save_configuration): For the incoming secure authentication checkbox,
1946 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1947 the UI specification. PLAIN does not seem to be supported for most IMAP
1948 servers anyway, and I am not sure what it would mean.
1949 However, we probably need to discover which of the secure-authentication
1950 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1951 * src/modest-account-mgr-helpers.c:
1952 (modest_account_mgr_get_server_account_data):
1954 * src/modest-tny-account.c:
1955 (modest_tny_account_new_from_server_account):
1956 Use tny_account_set_mech() to set secure-authentication methods,
1957 with some special-casing for IMAP, based on my observations of how
1960 * src/modest-account-mgr-helpers.h:
1961 * src/modest-account-mgr.c:
1962 * src/modest-defs.h: Comment that the URI is only used for local folders.
1964 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1966 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1967 parameter const, just to be neat.
1968 * src/modest-text-utils.c: (modest_text_utils_inline):
1969 End g_strconcat() with NULL, as its documentation says. This is almost
1970 certainly the cause of my crash at startup on the device. Interestingly,
1971 valgrind doesn't tell us about these errors.
1973 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1975 * scripts/build-packages: Added more precise comments about how to use
1976 this script, though I still get this error:
1977 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1978 error building tinymail
1980 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/modest-main-window.c: (on_account_update):
1983 Very slight cleanup, hoping to make it simpler to discover what causes
1984 a crash here sometimes.
1986 * src/modest-tny-account.c:
1987 (modest_tny_account_new_from_server_account): Set the port. Added
1988 comments about the options and a TODO comment because I need to find out
1989 how to specify the secure authentication method.
1991 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1993 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1994 changed CFlags paths form modest to libmodest
1996 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1998 * src/modest-account-mgr-helpers.c:
1999 (modest_account_mgr_get_server_account_data),
2000 (modest_account_mgr_free_server_account_data):
2001 * src/modest-account-mgr-helpers.h:
2002 * src/modest-account-mgr.c:
2003 (modest_account_mgr_add_server_account):
2004 * src/modest-defs.h:
2005 * src/modest-tny-account.c:
2006 (modest_tny_account_new_from_server_account):
2007 Determine the options for tny_camel_account_add_option() here,
2008 based on the settings, rather than storing them directly in gconf.
2010 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2012 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2013 Show a more friendly error dialog now that we expect (from the tinymail
2014 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2016 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/modest-main-window.c: (on_account_update): Check that
2019 account_name is not NULL, to prevent a crash at startup that I am
2020 seeing on the N800. I do wonder why it is NULL.
2022 * src/maemo/easysetup/modest-easysetup-wizard.c:
2023 (create_page_user_details):
2024 * src/maemo/modest-account-settings-dialog.c:
2025 (create_page_user_details), (create_page_outgoing):
2026 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2027 (modest_connection_specific_smtp_edit_window_init):
2028 * src/modest-ui-actions.c:
2029 (modest_ui_actions_on_password_requested):
2030 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2031 might do something useful with the on-screen keyboard.
2033 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/modest-main-window.c: (on_account_update):
2036 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2037 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2039 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-tny-account-store.c: (on_account_changed):
2042 Correct the signature of this signal handler.
2044 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2046 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2047 Show a HildonNote instead of a GtkDialog for Maemo.
2049 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2051 * src/widgets/modest-account-view.h:
2052 * src/widgets/modest-account-view.c: (on_account_changed),
2053 (on_account_removed). Added a boolean flag, set/unset by
2054 modest_account_view_block_conf_updates(),
2055 modest_account_view_unblock_conf_updates() to prevent unnecessary
2056 updates, but this is not very useful because the gconf notifications are
2057 so delays (maybe only on Maemo Bora).
2058 So auto-updating is turned off, and these functions do an explicit
2059 update when necessary.
2060 However, something else is still doing too much work when adding/removing
2061 accounts, probably in another part of the application.
2063 * src/maemo/modest-account-view-window.c:
2064 (on_delete_button_clicked), (on_edit_button_clicked),
2065 (on_new_button_clicked): Use the new functions.
2067 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-account-mgr-helpers.c:
2070 (modest_account_mgr_set_first_account_as_default):
2071 Sort the list of names alphabetically-by-title, so we choose the first one
2073 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2074 alphabetically by the title.
2076 This fixes projects.maemo.org bug NB#56418 .
2078 * src/modest-account-mgr-priv.c:
2079 (_modest_account_mgr_account_from_key):
2080 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2081 avoid a valgrind error, and possible random behaviour.
2083 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2085 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2086 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2087 tinymail documentation to say that this can be expected.
2088 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2089 pretty, and should not happen, but I would prefer to know when it does.
2091 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2093 * configure.ac: When using the older hildon version, probably on Bora,
2094 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2096 * src/widgets/modest-attachment-view.c:
2097 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2100 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2102 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2103 Implemented the prototype. Can be tested with
2104 tests/dbus_api/test_open_message:
2106 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2108 * src/modest-tny-account-store.c:
2109 (modest_tny_account_store_instance_init), (get_password):
2110 * src/modest-ui-actions.c:
2111 (modest_ui_actions_on_password_requested):
2112 Do not store the password in gconf, because this function is called
2113 for non-remembered passwords. Actually use the cached (in the hash map)
2114 password instead of releasing it.
2115 The password will now not be remembered if it is asked via the protected
2116 password dialog, as per the UI spec.
2118 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2120 * src/modest-defs.h:
2121 * src/modest-account-mgr-helpers.h:
2122 * src/modest-account-mgr-helpers.c:
2123 Added modest_server_account_get_username_has_succeeded(),
2124 modest_server_account_set_username_has_succeeded().
2125 (modest_server_account_set_username),
2126 Reset the has-succeeded flag if the username changes.
2128 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2129 * src/maemo/modest-connection-specific-smtp-window.c:
2130 (modest_connection_specific_smtp_window_save_server_accounts):
2131 Use modest_server_account_set_username() instead of using
2132 modest_conf_set_string() directly, so that the has-succeeded flag is always
2135 * src/modest-ui-actions.c:
2136 (modest_ui_actions_on_password_requested): Dim the username entry if
2137 the username has ever worked, as per the UI spec.
2139 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2141 * src/modest-tny-account-store.c: (get_password):
2142 * src/modest-ui-actions.c:
2143 (modest_ui_actions_on_password_requested):
2144 Allow the username to be changed too, though there is more work to
2145 be done on exactly how this behaves.
2147 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2149 * src/modest-account-mgr-helpers.h:
2150 * src/modest-account-mgr-helpers.c:
2151 Added modest_account_mgr_get_display_name(),
2152 modest_server_account_get_username(),
2153 modest_server_account_set_username(),
2154 modest_server_account_set_password(),
2155 modest_server_account_get_hostname() functions so we do not need to
2156 use the conf API directly.
2158 * src/maemo/modest-main-window.c: (connect_signals):
2159 Actually connect ot the ModestAccountStore::request-password signal,
2160 so that we show the dialog when the password is requested by Tinymail,
2161 for isntance if it is empty.
2163 * src/modest-marshal.list:
2164 * src/modest-tny-account-store.c:
2165 (modest_tny_account_store_class_init), (get_password),
2166 (modest_tny_account_store_alert):
2167 * src/modest-tny-account-store.h:
2168 * src/modest-ui-actions.h:
2169 * src/modest-ui-actions.c:
2170 (modest_ui_actions_on_password_requested):
2171 Change the signal parameters, so it is obvious that we are providing
2172 the non human-readable server name, and receiving both the username
2173 and password, though changing of the username is not yet implemented.
2174 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2175 for the GNOME version.
2177 This should fix the projects.maemo.org bug NB#56209, though it does not
2178 work on Bora, because the gconf_client_get() for the password fails
2179 immediately after we save it with gconf_client_set().
2181 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2184 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2185 caused an undefined symbol error:
2186 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2188 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-tny-account-store.c:
2191 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2192 using a GError instead of a string message, so we can translate it in
2195 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2197 * src/maemo/modest-address-book.c:
2198 (modest_address_book_check_names):
2199 * src/maemo/modest-msg-view-window.c:
2200 (modest_msg_view_window_clipboard_owner_change):
2201 * src/modest-init.c: (modest_init_init_ui):
2202 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2203 (update_folders_cb), (modest_mail_operation_update_account):
2204 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2205 (modest_ui_actions_on_msg_attachment_clicked),
2206 (modest_ui_actions_on_msg_recpt_activated):
2207 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2208 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2209 (modest_msg_view_search_next):
2210 * src/widgets/modest-recpt-editor.c:
2211 (modest_recpt_editor_on_button_release_event),
2212 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2213 g_message(). At this point we should only be seeing interesting errors on
2214 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2216 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2218 (modest_wizard_dialog_force_title_update):
2219 * src/maemo/easysetup/modest-wizard-dialog.h:
2220 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2221 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2222 can update the title when appropriate. Otherwise the title is wrong if the
2223 pages are added after adding the notebook to the dialog.
2224 This must be a problem in HildonWizardDialog too.
2225 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2227 * src/maemo/easysetup/modest-easysetup-wizard.c:
2228 (create_subsequent_customsetup_pages),
2229 (create_subsequent_easysetup_pages):
2230 Call modest_wizard_dialog_force_title_update() so that the title is
2231 correct even with GTK+ < 2.10.
2232 This fixes projects.maemo.org bug NB#56145 .
2234 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2236 * src/maemo/modest-platform.c:
2237 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2238 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2241 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2243 * src/widgets/modest-window.h:
2244 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2245 and modest_window_save_state(), which invokes it.
2247 * src/widgets/modest-window-mgr.h:
2248 * src/widgets/modest-window-mgr.c:
2249 Added modest_window_mgr_save_state_for_all_windows(), which calls
2250 the save_state vfunc on all registered windows, if implemented.
2252 * src/gnome/modest-msg-edit-window.c:
2253 * src/gnome/modest-msg-view-window.c:
2254 * src/maemo/modest-msg-edit-window.c:
2255 * src/maemo/modest-msg-view-window.c:
2256 * src/maemo/modest-main-window.c:
2257 Specify the existing save_settings functions as implementations of
2258 ModestWindow::save_state_func().
2260 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2261 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2262 enabling hibernation, for instance.
2264 We may need to do the same thing for restoring settings.
2267 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2269 * src/widgets/modest-window-mgr.c:
2270 * src/widgets/modest-window-mgr.h:
2271 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2272 modest_window_mgr_get_hibernation_is_prevented().
2274 * src/maemo/modest-main-window.c:
2275 (on_hildon_program_is_topmost_notify): Prevent hibernation
2276 (possible when the application goes to the background in the WM),
2277 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2279 * src/maemo/easysetup/modest-easysetup-wizard.c:
2280 (modest_easysetup_wizard_dialog_init):
2281 * src/maemo/modest-account-settings-dialog.c:
2282 (modest_account_settings_dialog_init):
2283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2284 (modest_connection_specific_smtp_edit_window_init):
2285 * src/maemo/modest-connection-specific-smtp-window.c:
2286 (modest_connection_specific_smtp_window_init):
2287 * src/maemo/modest-signature-editor-dialog.c:
2288 (modest_signature_editor_dialog_init):
2289 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2290 prevent hibernation while any of these account settings dialogs are open.
2292 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2294 * src/maemo/Makefile.am:
2295 * src/maemo/modest-osso-state-saving.c:
2296 * src/maemo/modest-osso-state-saving.h: Added
2297 modest_osso_load_state() and modest_osso_save_state() though they do
2298 nothing now. They should iterate through all the open windows and load/save
2300 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2301 save state when closing.
2303 * src/maemo/modest-main-window.c:
2304 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2305 Add a notification handler for the HildonProgram::is-topmost property,
2306 so we can allow hibernation when the application goes into the background.
2307 But we still need to detect when the accounts setup windows are open so
2308 we can stop hibernation when they are open.
2309 To do this, I also added the main window the HildonProgram. This might have
2310 other side-effects/benefits, and should maybe be done for other windows.
2312 * src/maemo/modest-osso-autosave-callbacks.h:
2313 * src/maemo/modest-osso-autosave-callbacks.c:
2314 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2315 though it does not do anything yet, and we might never need this to do
2316 anything. For instance, we already save drafts.
2318 * src/maemo/modest-platform.c: (modest_platform_init):
2319 Specify the libosso auto-save callback.
2321 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/modest-platform.c:
2324 (modest_platform_set_update_interval):
2325 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2326 aparently stays valid between application instances, so we can use this
2327 to remove and reset it later. According to a maemo-developers email from
2330 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2332 * configure.ac: Depend on libalarm for Maemo.
2334 * src/dbus_api/modest-dbus-api.h:
2335 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2336 (on_send_receive), (modest_dbus_req_handler):
2337 Handle a SEND_RECEIVE D-Bus method.
2339 * libmodest-dbus-client/libmodest-dbus-client.c:
2340 (libmodest_dbus_client_send_and_receive):
2341 * libmodest-dbus-client/libmodest-dbus-client.h:
2342 Add C convenience functions for calling the new D-Bus method.
2344 * src/modest-platform.h:
2345 * src/gnome/modest-platform.c:
2346 * src/maemo/modest-platform.c:
2347 Added modest_platform_set_update_interval(), which uses the
2348 alarmd API on Maemo.
2349 (modest_platform_init),
2350 Call modest_platform_set_update_interval(), using a hard-coded
2351 interval for now (until the global settings dialog is implemented),
2352 though I am not sure that this makes sense yet.
2354 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2356 * src/dbus_api/modest-dbus-callbacks.c:
2357 (modest_osso_cb_hw_state_handler):
2358 * src/dbus_api/modest-dbus-callbacks.h:
2359 * src/maemo/modest-platform.c: (modest_platform_init):
2360 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2361 in case this has some effect on the ability for Maemo to ping the
2364 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2366 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2367 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2368 warning. It is probably a logic error, but I need to fix the build.
2370 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2372 * src/modest-account-mgr.h:
2373 * src/modest-account-mgr.c:
2374 (modest_account_mgr_account_names): Add a gboolean enabled_only
2375 parameter, so we can get lists of onlt the enabled accounts.
2377 (modest_account_mgr_add_account),,
2378 (modest_account_mgr_account_with_display_name_exists):
2379 * src/maemo/modest-msg-edit-window.c: (get_transports):
2380 * src/modest-account-mgr-helpers.c:
2381 (modest_account_mgr_set_first_account_as_default):
2382 * src/modest-init.c: (init_default_account_maybe):
2383 * src/modest-tny-account-store.c: (get_accounts):
2384 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2385 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2386 * tests/check_account-mgr.c: (START_TEST):
2387 Provide the extra parameter, as appropriate.
2389 * src/widgets/modest-account-view.c: (update_account_view):
2390 Do not show disabled accounts (meaning that there is no way to
2391 enable/disable accounts in the UI (the feature is not in our UI
2392 specification), so we can use this internally only to mark unfinished
2393 or temporary account data.
2395 * src/maemo/easysetup/modest-easysetup-wizard.c:
2396 (create_account): Add boolean enable parameter, so we can specify FALSE
2397 to create the temporary account.
2398 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2399 (on_before_next): When finishing, when there is a temporary account, just
2401 Also, use a timeout to delay the showing of the dialog until gconf is likely
2402 to return correct information, due to a maemo gconf bug that is fixed in
2403 osso 1.1, but not yet in Bora.
2404 However, the dialog stays on screen after it is destroyed.
2406 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2407 for invalid data when cancelling. Use a hildon note instead of a dialog
2408 to complain about invalid data. Do not show the account-saved note if the
2409 account is disabled (a temporary account that will not really be saved for use
2412 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-account-mgr-helpers.h:
2415 * src/modest-account-mgr-helpers.c:
2416 Added modest_account_mgr_unset_default_account(),
2417 Added modest_account_mgr_set_first_account_as_default().
2419 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2420 If it was the default account, unset the default account name.
2422 * src/maemo/modest-account-view-window.c:
2423 (on_delete_button_clicked): If it was the default account,
2424 set the first remaining account as the default instead.
2426 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2427 a NULL account or a NULL default account, to prevent a crash. This should
2428 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2431 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2433 * src/widgets/modest-recpt-editor.c:
2434 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2435 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2436 TODO comment for this. This fixes the build.
2438 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2439 be the best place for it. This will in future update all auto-update accounts,
2440 rather than just the current/default account, when that gconf key exists.
2441 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2442 if there are no accounts, before calling do_send_receive().
2443 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2445 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2446 * src/maemo/modest-main-window-ui.h:
2447 * src/maemo/modest-main-window.c: (on_connection_changed),
2448 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2449 directly, becaue the signal handler does more.
2451 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2453 * src/modest-account-mgr-helpers.c:
2454 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2455 for the case that the account does not exist.
2457 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2458 (equivalent to the modest account name) rather than the tinymail account name
2459 (equivalent to the modest account title - human readable) to get the account data.
2460 Check for null account data to prevent the crash, and add a TODO comment saying that
2461 this needs fixing because it is using the server account name instead of the account name.
2463 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2465 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2466 * src/maemo/modest-account-settings-dialog.c: (show_error),
2468 Use hildon_note_new_information() for informative and error messages,
2469 which seems to be expected for Maemo applications (no documentation that I know of
2470 says this). I am surprised that there is no distinction between info and error
2473 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2476 it is easy to find where this is used.
2478 * src/maemo/easysetup/modest-easysetup-wizard.c:
2479 (create_page_welcome), (create_page_account_details),
2480 (create_page_user_details), (create_page_complete_easysetup),
2481 (create_page_custom_incoming), (create_page_custom_outgoing),
2482 (create_page_complete_custom):
2483 * src/maemo/modest-account-settings-dialog.c:
2484 (create_page_account_details), (create_page_user_details),
2485 (create_page_incoming), (create_page_outgoing):
2486 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2487 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2488 (modest_connection_specific_smtp_edit_window_init):
2489 * src/maemo/modest-connection-specific-smtp-window.c:
2490 (modest_connection_specific_smtp_window_init):
2491 * src/maemo/modest-signature-editor-dialog.c:
2492 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2493 and scrolling policy as per the Email Application Layout Guide, if I have
2496 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2498 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2499 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2500 which were empty, because these vfuncs have been removed from TnyAccountStore.
2501 This fixes the build.
2503 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2505 * src/maemo/modest-main-window.c:
2506 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2507 showing/hiding it. Added TODO because it probably should not be NULL.
2508 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2509 because unnecessary g_warnings() make degugging difficult.
2511 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/modest-msg-edit-window.c:
2514 (modest_msg_edit_window_select_color),
2515 (modest_msg_edit_window_select_background_color): 2 const corrections and
2516 moving 2 #endifs before closing brackets, to fix the build.
2518 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2520 * src/maemo/easysetup/modest-easysetup-wizard.h:
2521 * src/maemo/easysetup/modest-easysetup-wizard.c:
2522 (modest_easysetup_wizard_dialog_finalize),
2523 (on_button_edit_advanced_settings), (create_page_complete_custom),
2524 (on_response), (create_account):
2525 Implement the Advanced Settings edit button, by saving the account information,
2526 for the Advanded Settings dialog to use directly from gconf, and removing it
2527 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2528 Bug #5533 in the projects.maemo.org bugzilla.
2530 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2532 * src/maemo/modest-msg-view-window.c:
2533 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2534 when opening a message window.
2536 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2538 * src/maemo/easysetup/modest-easysetup-wizard.c:
2539 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2542 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2543 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2544 gconf settings. I probably added more checks than necessary, but that is safer.
2546 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2547 variable to fix the build, but this seems to be used when it is still NULL.
2549 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2551 * src/modest-platform.h:
2552 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2553 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2554 * src/modest-main.c: Implement this function so we can avoid using
2555 maemo-specific API from cross-platform code.
2557 * src/modest-tny-account-store.c:
2558 (get_smtp_specific_transport_account_for_open_connection):
2559 * src/modest-ui-actions.c: (check_for_connection),
2560 (modest_ui_actions_on_item_not_found):
2561 Use modest_platform_connect_and_wait() and put #idefs around other
2562 maemo-specific code, because only maemo currently has a way to
2563 identify connection names.
2565 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2567 * src/modest-tny-account-store.h:
2568 * src/modest-tny-account-store.c:
2569 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2570 the connection-specific SMTP server settings in the configuration.
2572 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2574 * src/maemo/modest-main-window.c: (on_connection_changed),
2576 * src/modest-main.c: (main), (start_ui), (send_mail):
2577 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2578 that is what is intended.
2580 * src/modest-ui-actions.c: (action_send), (action_receive),
2581 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2582 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2583 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2584 SMTP server is used when it is specified.
2586 (modest_ui_actions_on_send_receive):
2587 Check that a connection is open before proceeding.
2588 Receive and then send, instead of vice-versa, as per the specification.
2590 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2592 * src/modest-mail-operation.c:
2593 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2594 though I guess it should be something other than NULL.
2596 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2600 combo twice, to avoid an g_warning and to make it visible again.
2601 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2602 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2603 (already intended) dereference when detaching, because we then recreate the menu.
2604 But I am not sure why the warning was happening, and it is possible that this is a memory
2607 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2609 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2610 and uri_parse_mailto() utility functions.
2611 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2613 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2615 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2617 * src/dbus_api/modest-dbus-api.h:
2618 * src/dbus_api/modest-dbus-callbacks.c:
2619 Use an idle callback to execute the modest code in the application's own thread.
2620 Remove the helloworld example method.
2621 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2622 parsed, and the open-message method is not implemented because this is not yet implemented in
2624 * libmodest-dbus-client/libmodest-dbus-client.c:
2625 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2626 (libmodest_dbus_client_open_message):
2627 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2629 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2630 body without crashing.
2632 * tests/dbus_api/Makefile.am:
2633 * tests/dbus_api/test_mail_to.c:
2634 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2636 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2638 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2639 Added file to fix the build. Sorry.
2641 * src/dbus_api/Makefile.am:
2642 * src/dbus_api/modest-dbus-api.h:
2643 * src/dbus_api/modest-dbus-callbacks.h:
2644 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2645 (modest_dbus_req_handler):
2646 Put constants in a separate header so it can be reused by the
2647 client library, without duplication
2649 * libmodest-dbus-client/Makefile.am:
2650 * libmodest-dbus-client/libmodest-dbus-client.c:
2651 (libmodest_dbus_client_call_helloworld),
2652 (libmodfest_dbus_client_send_mail),
2653 (libmodfest_dbus_client_mailto),
2654 (libmodfest_dbus_client_open_message):
2655 * libmodest-dbus-client/libmodest-dbus-client.h:
2656 (Partly) Implement a send_mail D-Bus method.
2658 * tests/dbus_api/Makefile.am:
2659 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2660 the send_email D-Bus method.
2662 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2666 * libmodest-dbus-client/Makefile.am:
2667 * libmodest-dbus-client/libmodest-dbus-client.c:
2668 * libmodest-dbus-client/libmodest-dbus-client.h:
2669 * tests/dbus_api/Makefile.am:
2670 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2671 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2673 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2675 * src/maemo/easysetup/modest-easysetup-wizard.c:
2676 (create_page_account_details):
2677 * src/maemo/modest-account-settings-dialog.c:
2678 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2679 widgets, because this might not be the default in future versions of the Maemo GTK+.
2680 However, I can not not get capitalization to work even in a simple test case.
2682 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2684 * src/maemo/easysetup/modest-easysetup-wizard.c:
2685 (create_page_custom_incoming), (create_page_custom_outgoing):
2686 * src/maemo/modest-account-settings-dialog.c:
2687 (create_page_account_details), (create_page_incoming),
2688 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2689 instead of using gtk_check_button_with_label(), so they are aligned like the other
2690 widgets, as per the UI spec.
2692 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2694 * src/maemo/easysetup/modest-easysetup-wizard.c:
2695 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2696 * src/widgets/modest-validating-entry.c:
2697 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2698 Modest prefix instead of an EasySetup prefix.
2700 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2702 * src/widgets/modest-validating-entry.h:
2703 * src/widgets/modest-validating-entry.c: (on_insert_text),
2704 Added easysetup_validating_entry_set_max_func(), used to set a callback
2705 to call when the max number of characters is reached. GtkEntry has a max-length
2706 already but is silent about it.
2708 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2709 (create_page_account_details), (create_page_user_details),
2711 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2712 (create_page_account_details), (create_page_user_details),
2713 (create_page_outgoing):
2714 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2715 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2716 the UI spec, when the user tries to enter more than the max number of characters.
2718 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2720 * src/maemo/easysetup/modest-easysetup-wizard.c:
2721 (create_page_user_details), (create_page_custom_incoming),
2722 (create_page_custom_outgoing):
2723 * src/maemo/modest-account-settings-dialog.c:
2724 (create_page_user_details), (create_page_incoming),
2725 (create_page_outgoing):
2726 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2727 (modest_connection_specific_smtp_edit_window_init):
2728 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2729 not appropriate. Bad Maemo-specific defaults!.
2731 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2733 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2734 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2735 (modest_signature_editor_dialog_set_settings):
2736 Disable the label and textview when the checkbox is disabled, and use the
2737 specified (UI spec) default signature text.
2739 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2742 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2744 * src/modest-defs.h:
2745 * src/modest-account-mgr-helpers.h:
2746 * src/modest-account-mgr-helpers.c:
2747 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2749 * src/maemo/Makefile.am:
2750 * src/maemo/modest-signature-editor-dialog.c:
2751 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2754 * src/maemo/modest-account-settings-dialog.h:
2755 * src/maemo/modest-account-settings-dialog.c:
2756 (modest_account_settings_dialog_finalize), (on_button_signature),
2757 (save_configuration): Use the new dialog when the Edit button is pressed, and
2758 save the changes if necessary, as per the UI spec.
2760 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/Makefile.am:
2763 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2764 based on maemo-develoers email from Dirk.
2766 * src/maemo/easysetup/modest-easysetup-wizard.c:
2767 (create_page_welcome), (create_page_account_details),
2768 (create_page_user_details), (create_page_complete_easysetup),
2769 (create_page_custom_incoming), (create_page_custom_outgoing),
2770 (create_page_complete_custom),
2771 (modest_easysetup_wizard_dialog_init):
2772 * src/maemo/modest-account-settings-dialog.c:
2773 (create_page_account_details), (create_page_user_details),
2774 (create_page_incoming), (create_page_outgoing),
2775 (modest_account_settings_dialog_init):
2776 * src/maemo/modest-connection-specific-smtp-window.c:
2777 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2779 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/easysetup/modest-easysetup-wizard.c:
2782 (create_page_account_details), (create_page_custom_outgoing),
2783 (create_page_complete_custom):
2784 * src/maemo/modest-account-settings-dialog.c:
2785 (create_page_user_details), (create_page_incoming),
2786 (create_page_outgoing):
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 (modest_connection_specific_smtp_edit_window_init):
2789 Use the correct (UI spec) port min/max, and use horizontal separators,
2792 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2794 * src/maemo/easysetup/modest-easysetup-wizard.c:
2795 (set_default_custom_servernames):
2796 * src/maemo/modest-account-settings-dialog.c:
2797 (create_page_incoming), (on_combo_outgoing_security_changed),
2798 (on_combo_incoming_security_changed), (create_page_outgoing),
2799 (modest_account_settings_dialog_set_account_name),
2800 (save_configuration):
2801 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2802 (on_combo_security_changed),
2803 (modest_connection_specific_smtp_edit_window_init),
2804 (modest_connection_specific_smtp_edit_window_set_connection),
2805 (modest_connection_specific_smtp_edit_window_get_settings):
2806 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2809 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/easysetup/modest-easysetup-wizard.c:
2813 (create_page_custom_outgoing), (create_page_complete_custom):
2814 * src/maemo/modest-account-settings-dialog.c:
2815 (create_page_user_details), (create_page_outgoing):
2816 * src/maemo/modest-account-view-window.c: (button_box_new):
2817 Use changed logical IDs as per the most recent UI spec:
2818 mcen_bd_emailsetup_edit -> mcen_bd_edit
2819 mcen_bd_emailsetup_delete -> mcen_bd_delete
2820 mcen_bd_emailsetup_close -> mcen_bd_close
2822 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2826 * src/dbus_api/Makefile.am:
2827 * src/dbus_api/modest-dbus-callbacks.c:
2828 * src/dbus_api/modest-dbus-callbacks.h:
2829 * src/maemo/modest-platform.c: (modest_platform_init):
2830 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2832 * tests/Makefile.am:
2833 * tests/dbus_api/Makefile.am:
2834 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2836 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2838 * src/maemo/modest-account-settings-dialog.c:
2839 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2840 Removed unnecessary includes.
2842 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2844 * src/maemo/easysetup/modest-easysetup-wizard.c:
2845 * src/maemo/modest-account-settings-dialog.c:
2846 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2847 * src/widgets/Makefile.am:
2848 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2849 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2850 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2851 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2852 * src/widgets/modest-secureauth-combo-box.c:
2853 * src/widgets/modest-secureauth-combo-box.h:
2854 * src/widgets/modest-serversecurity-combo-box.c:
2855 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2856 made the GObject names more consistent with the rest of the Modest code.
2858 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/easysetup/Makefile.am:
2861 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2862 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2863 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2864 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2865 * src/maemo/easysetup/modest-easysetup-wizard.c:
2866 * src/maemo/easysetup/modest-validating-entry.c:
2867 * src/maemo/easysetup/modest-validating-entry.h:
2868 * src/maemo/modest-account-settings-dialog.c:
2869 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2870 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2871 widgets/ because they are used outside of easysetup too. After checking in,
2872 svn will allow me to rename them too.
2874 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2876 * src/gnome/modest-msg-edit-window.c:
2877 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2878 linker error, to fix the build on the GNOME platform.
2879 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2880 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2881 ifdefed out to avoid a warning.
2883 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2885 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2886 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2887 some alternative for GTK+ 2.6.
2889 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2891 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2893 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2894 specified for EmailAccountsDialog in UI spec.
2896 * src/maemo/easysetup/modest-easysetup-wizard.c:
2897 * src/maemo/easysetup/modest-easysetup-wizard.h:
2898 * src/maemo/modest-account-settings-dialog.c:
2899 * src/maemo/modest-account-settings-dialog.h:
2900 Reuse a member window widget for the connection-specific SMTP server accounts,
2901 so we can tell it to create/save the accounts only if we actually save changes.
2903 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2904 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2905 (modest_connection_specific_smtp_edit_window_get_settings):
2906 Return a struct instance for temporarily remembering the entered data.
2908 * src/maemo/modest-connection-specific-smtp-window.h:
2909 * src/maemo/modest-connection-specific-smtp-window.c:
2910 (modest_connection_specific_smtp_window_finalize),
2911 (modest_connection_specific_smtp_window_fill_with_connections),
2913 (modest_connection_specific_smtp_window_save_server_accounts),
2914 (update_model_server_names): Do not actually save data until asked,
2915 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2917 (on_selection_changed),
2918 (modest_connection_specific_smtp_window_init): Disable the edit
2919 button when nothing is selected.
2921 * src/modest-account-mgr-helpers.c:
2922 * src/modest-account-mgr-helpers.h:
2923 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2926 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-account-mgr-helpers.h:
2929 * src/modest-account-mgr-helpers.c:
2930 (modest_account_mgr_get_unused_account_name),
2931 (modest_account_mgr_get_unused_account_display_name): Added these
2932 utility functions, to avoid code duplication.
2934 * src/maemo/easysetup/modest-easysetup-wizard.c:
2935 (create_page_account_details), (create_account):
2936 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2937 (on_combo_security_changed),
2938 (modest_connection_specific_smtp_edit_window_init),
2939 (modest_connection_specific_smtp_edit_window_save_settings):
2940 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2941 * src/maemo/modest-connection-specific-smtp-window.c:
2942 (modest_connection_specific_smtp_window_finalize),
2943 (modest_connection_specific_smtp_window_fill_with_connections),
2944 (on_button_edit), (modest_connection_specific_smtp_window_init):
2945 * src/maemo/modest-connection-specific-smtp-window.h:
2946 Implementing saving of connection-specific server accounts.
2948 But I need to refactor this so we can save the data for each
2949 possible connection-specific account and only actually create the server accounts
2950 when the easysetup finished, or the OK button is pressed on the account settings
2953 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2955 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2956 (on_combo_security_changed):
2957 (modest_connection_specific_smtp_edit_window_init):
2958 Auto-fill the port number as in the account settings.
2960 (modest_connection_specific_smtp_edit_window_set_connection):
2961 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2962 * src/maemo/modest-connection-specific-smtp-window.c:
2963 (fill_with_connections), (on_button_edit),
2964 (modest_connection_specific_smtp_window_init):
2965 Turn the edit window into a dialog to simplify the code, and
2966 set a WM hint as in a GtkDialog, because only a popup can be on top of
2967 another window in Maemo, and popups usually have no WM decoration.
2969 * src/modest-defs.h:
2970 * src/modest-account-mgr-helpers.c:
2971 (modest_account_mgr_set_connection_specific_smtp),
2972 (modest_account_mgr_remove_connection_specific_smtp),
2973 (modest_account_mgr_get_connection_specific_smtp):
2974 * src/modest-account-mgr-helpers.h: Some functions to write the
2975 connection-specific SMTP server information. Not yet used.
2978 * src/widgets/modest-folder-view.c: (text_cell_data):
2979 Fix a warning about an uninitialized variable.
2980 (on_configuration_key_changed): Put an #ifdef around the use
2981 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2983 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2985 * src/maemo/modest-account-settings-dialog.h:
2986 * src/maemo/modest-account-settings-dialog.c:
2987 Added connect_for_modified() utility function to mark the new modified boolean.
2989 (create_page_account_details), (create_page_user_details),
2990 (create_page_incoming), (create_page_outgoing), (on_response),
2991 (modest_account_settings_dialog_init),
2992 (modest_account_settings_dialog_set_account_name):
2993 Only warn about unsaved changes when there are actually unsaved changes.
2995 * src/modest-account-mgr-helpers.c:
2996 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2997 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2998 to get the data from there in future.
3000 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3002 * src/modest-defs.h:
3004 * src/modest-account-mgr-helpers.h:
3005 * src/modest-account-mgr-helpers.c:
3006 Store the security account setting in a single conf key instead of using
3007 the options list, so that the list is left for just the to-be-removed camel hack,
3008 and because gconf_client_set_list() is failing for some reason.
3010 * src/modest-account-mgr.c:
3011 (modest_account_mgr_add_server_account):
3012 * src/maemo/modest-account-settings-dialog.c:
3013 (modest_account_settings_dialog_set_account_name),
3014 (save_configuration): Use the renamed functions.
3017 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3019 * src/widgets/Makefile.am:
3020 * src/widgets/modest-limit-retrieve-combo-box.c:
3021 * src/widgets/modest-limit-retrieve-combo-box.h:
3022 * src/widgets/modest-retrieve-combo-box.c:
3023 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3024 the account settings dialog.
3026 * src/modest-defs.h:
3027 * src/modest-account-mgr-helpers.h:
3028 * src/modest-account-mgr-helpers.c:
3029 (modest_server_account_get_option_secure_auth),
3030 (modest_server_account_set_option_secure_auth):
3031 * src/modest-account-mgr.c:
3032 (modest_account_mgr_add_server_account):
3033 Use the existing AUTH_MECH conf key for the secure-auth setting,
3034 instead of putting it in the list options, because this was actually used already.
3036 * src/maemo/modest-account-settings-dialog.c:
3037 (create_page_account_details),
3038 (modest_account_settings_dialog_set_account_name),
3039 (save_configuration):
3040 * src/maemo/modest-account-settings-dialog.h:
3041 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3042 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3044 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3046 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3047 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3048 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3050 * src/modest-defs.h:
3051 * src/maemo/modest-account-settings-dialog.c:
3052 (create_page_incoming), (on_combo_outgoing_security_changed),
3053 (on_combo_incoming_security_changed), (create_page_outgoing),
3054 (modest_account_settings_dialog_set_account_name),
3055 (save_configuration): Load/Save the port number, and change it when the
3056 security combo changes, to suitable defaults.
3058 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-account-mgr.c:
3061 (modest_account_mgr_add_server_account): Set the security and secure-auth
3062 options, and add a comment saying that the other camel-specific options should be
3065 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3067 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3069 * src/modest-tny-account-store.c: (account_list_free),
3070 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3071 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3074 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3076 * src/modest-protocol-info.c:
3077 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3078 is required by our UI spec. Maybe something in our implementation will use this eventually.
3079 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3080 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3081 instead of the previous 0 placeholder.
3083 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3084 secure-auth settings.
3085 * src/modest-account-mgr-helpers.h:
3086 * src/modest-account-mgr-helpers.c:
3087 (modest_server_account_data_get_option_secure_auth),
3088 (modest_server_account_set_option_secure_auth),
3089 (modest_server_account_data_get_option_security),
3090 (modest_server_account_set_option_security): Added this API for getting and setting the security
3091 and secure-auth settings.
3093 * src/maemo/modest-account-settings-dialog.h:
3094 * src/maemo/modest-account-settings-dialog.c:
3095 (modest_account_settings_dialog_finalize), (check_data),
3096 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3097 about changing titles.
3098 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3099 (save_configuration): Save the security and secure-auth settings.
3101 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3102 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3104 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3106 * src/modest-defs.h:
3107 * src/modest-account-mgr.c:
3108 (modest_account_mgr_add_server_account):
3109 Added and used defines for the options key and value pair strings,
3110 that are used so far, though they do not seem to correspond to anything in our
3111 UI specs or ModestProtocol enum.
3113 * src/modest-account-mgr-helpers.h:
3114 * src/modest-account-mgr-helpers.c:
3115 (compare_option_strings_for_name),
3116 (modest_server_account_data_get_option_value),
3117 (modest_server_account_data_get_option_bool),
3118 (modest_account_mgr_get_server_account_option):
3119 Added helper functions for parsing the options GSList.
3121 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3123 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3124 display name is based on the supplied account name.
3125 * src/modest-account-mgr.c:
3126 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3127 with an inefficient, but good-enough, implementation.
3129 * src/maemo/easysetup/modest-easysetup-wizard.c:
3130 (create_page_account_details), (on_before_next), (create_account):
3131 Check for existing display names rather than (non-user-visible) account names, and just
3132 create and set a unique account name at the end.
3134 * src/maemo/modest-account-settings-dialog.c:
3135 (modest_account_settings_dialog_init),
3136 (modest_account_settings_dialog_set_account_name),
3137 (create_page_incoming): Show the display name, instead of the account name.
3138 (on_response): Do some (not all) extra checks, as in the UI spec.
3139 (save_configuration): Save the display name if it was changed.
3141 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3143 * po/en_GB.po: Added needed logical ID and translation.
3144 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3145 (init_view): Made the is-default column clicking work.
3147 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/easysetup/Makefile.am:
3151 * src/maemo/easysetup/modest-easysetup-wizard.c:
3152 (modest_easysetup_wizard_dialog_init):
3153 * src/maemo/easysetup/provider-data-test.keyfile:
3154 * src/maemo/easysetup/provider-data.keyfile:
3155 Moved the provider data file to the new modest-providers-data package and used it from there.
3157 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3159 * src/modest-local-folder-info.c:
3160 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3161 N_() was already used on the static strings, but this just marks it for translation without
3162 using the translation.
3164 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3166 * src/maemo/modest-account-settings-dialog.c:
3167 (create_page_incoming),
3168 (modest_account_settings_dialog_set_account_name):
3169 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3170 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3171 I will do this if nobody else gets there first.
3173 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3175 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3176 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3177 save the security stuff.
3179 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3181 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3182 Set the email address and user fullname, which I now see must be
3185 * src/maemo/modest-account-settings-dialog.h:
3186 * src/maemo/modest-account-settings-dialog.c:
3188 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3189 leave-on-server and authentication.
3190 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3193 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/modest-account-settings-dialog.c:
3197 * src/maemo/modest-account-settings-dialog.h:
3198 Most (but not all) of the widgets are now present as specified by the UI spec.
3199 No changes are yet saved, and some details are not properly shown yet.
3201 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3203 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3205 * src/maemo/Makefile.am:
3206 * src/maemo/modest-account-settings-dialog.c:
3207 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3208 an existing account. Doesn't do much yet.
3210 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3211 Open the accounts settings dialog when Edit is clicked.
3213 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3215 * src/maemo/easysetup/Makefile.am:
3216 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3218 * src/maemo/easysetup/modest-easysetup-wizard.c:
3219 (modest_easysetup_wizard_dialog_init):
3220 Try to get the source directory from the build system,
3221 instead of hard-coding "./" into the source code, when opening our local
3222 copies of the configuration files.
3223 But this still fails when opening the wizard from the Accounts window,
3224 maybe because the working directory seems to change at runtime.
3225 So the wizard will fail the second time unless you copy the files into their
3226 proper locations - see the stdout warnings for the paths.
3228 (create_page_account_details),(on_before_next):
3229 Check for existing non-server accounts instead of server accounts,
3230 so the default account name is useful again, and to prevent trying to
3233 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3234 Show the wizard when New is clicked.
3236 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3237 (init_view): Show the column headers, and show the columns that are
3238 specified in the UI specs. However, something in Maemo's GTK+ prevents
3239 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3240 change the default account. This is despite unsetting the special properties.
3242 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3244 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3245 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3246 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3247 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3248 to make that clearer.
3249 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3251 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/modest-account-view-window.c:
3254 (modest_account_view_window_init),
3255 (modest_account_view_window_new):
3256 Use the same buttons as specified in the
3257 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3258 the existing widgets, which never had a chance of working.
3259 Put the ModestAccountView treeview in a scrolled window.
3260 Do not repeat the initialization in both _init() and _new().
3262 * src/widgets/modest-account-view.c: (update_account_view):
3263 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3264 this widget and window shows no accounts.
3266 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3268 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3270 * src/maemo/easysetup/modest-easysetup-wizard.c:
3271 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3272 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3273 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3276 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3277 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3278 accounts exist yet, as in the UI spec.
3280 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3282 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3284 * src/maemo/Makefile.am:
3285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3286 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3287 New window for editing connection-specific smtp details.
3288 Not fully implemented.
3290 * src/maemo/modest-connection-specific-smtp-window.c:
3291 (modest_connection_specific_smtp_window_finalize) :
3292 unref the tree model.
3293 (on_button_edit): Show the edit window.
3295 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3297 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3300 * src/maemo/Makefile.am:
3301 * src/maemo/modest-connection-specific-smtp-window.c:
3302 * src/maemo/modest-connection-specific-smtp-window.h:
3303 New window for showing the list of connections, for connection-specific
3304 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3305 * src/maemo/easysetup/modest-easysetup-wizard.c:
3306 (create_page_custom_outgoing): Show the new window when the button is clicked.
3308 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3310 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3311 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3312 * src/maemo/modest-msg-edit-window.c:
3313 (modest_msg_edit_window_insert_image):
3314 * src/modest-conf.c: (modest_conf_key_escape):
3315 * src/modest-mail-operation.c:
3316 (modest_mail_operation_send_new_mail):
3317 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3318 (modest_ui_actions_on_new_account):
3319 * src/widgets/modest-attachment-view.c: (update_filename_request):
3320 * src/widgets/modest-mail-header-view.c:
3321 Corrected warnings that were breaking the build, by commenting out unused variables,
3322 and a function, and by including a header.
3324 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3326 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3327 so we can #ifdef around platform-specific code when necessary.
3328 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3329 to allow this to build for the GNOME platform too.
3331 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/easysetup/modest-easysetup-wizard.c:
3334 Added util_increment_name() and used it in create_page_account_details()
3335 to make sure that the default account name is always a new name.
3337 (modest_easysetup_wizard_dialog_init),
3338 (set_default_custom_servernames): Some minor memory management fixes.
3340 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3344 * src/modest-runtime.c: (init_i18n): Restored the translation
3345 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3346 are defined in config.h, and the translations are installed.
3348 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3349 is defined for translation.
3351 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3353 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3355 * src/maemo/easysetup/modest-easysetup-wizard.c:
3356 (modest_easysetup_wizard_dialog_init):
3357 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3358 Use realistic paths (though they should use $prefix generically) to the
3359 mcc_mapping and provider-data.keyfile files which might work when they
3360 are installed by the future version of the operator-wizard package,
3361 and then fallback to paths in our source code, with an explanatory
3364 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/Makefile.am:
3369 * src/maemo/easysetup/: Added files from the previously-exernal
3370 osso-modest-easysetup.
3371 * src/maemo/modest-main-window-ui.h:
3372 * src/modest-ui-actions.c:
3373 * src/modest-ui-actions.h:
3374 Added modest_ui_actions_on_new_account() as a signal handler for the
3375 New Account menu item. It shows the easysetup wizard.
3376 * po/en_GB.po: Added additional needed logical IDs and translations.