1 2007-06-03 Armin Burgmeier <armin@openismus.com>
3 * src/widgets/modest-account-view.c
4 (on_account_default_toggled): Toggle default account column
5 explicitely instead of waiting for gconf notification (which is
6 currently ignored). This should fix maemo.projects.org bug NB#56910
7 for now. It should probably be removed when gconf notifications are
10 2007-06-03 Christian Kellner <ckellner@openismus.com>
12 * libmodest-dbus-client/libmodest-dbus-client.c:
13 Removed debugging spew.
15 * src/dbus_api/modest-dbus-callbacks.c:
18 * src/modest-search.c:
19 (modest_search_all_accounts):
20 Use tny_account_store_get_accounts () on the account store
21 to get all accounts which is the way to get all accounts.
23 * tests/dbus_api/test_search.c: (main):
24 Make it possible to supply the search term on the command line.
26 2007-06-03 Christian Kellner <ckellner@openismus.com>
28 * libmodest-dbus-client/libmodest-dbus-client.c:
29 * libmodest-dbus-client/libmodest-dbus-client.h:
30 Implement searching for mesages over raw dbus. (Client side)
32 * src/dbus_api/Makefile.am:
33 * src/dbus_api/modest-dbus-api.h:
34 * src/dbus_api/modest-dbus-callbacks.c:
35 * src/dbus_api/modest-dbus-callbacks.h:
36 Search framework (Server side). Also implement on_idle_open_message().
38 * src/maemo/modest-platform.c: (modest_platform_init):
39 Prepare for raw dbus/osso rpc interaction.
41 * src/modest-search.h:
42 Changed minsize from unspecific guint to guint32.
44 * src/modest-search.c:
46 Added strange hack which magically made tnymail work.
48 (modest_search_folder),
49 (modest_search_account),
50 (modest_search_all_accounts):
51 Implement helper functions to search all accounts, specific account
54 * tests/dbus_api/Makefile.am:
55 * tests/dbus_api/test_open_message.c:
56 Read url to open from commandline.
58 * tests/dbus_api/test_search.c:
59 Implement small test for dbus search stuff
61 2007-06-02 Armin Burgmeier <armin@openismus.com>
63 * src/maemo/modest-account-settings-dialog.c: Changed window title to
64 include account type and account title. This fixes projects.maemo.org
67 * src/maemo/modest-account-view-window.c: Set a title for the window.
69 2007-06-02 Armin Burgmeier <armin@openismus.com>
71 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
72 incoming and outgoing server name based on email address and server
73 types as long as the names have not been edited manually. This fixes
74 projects.maemo.org bug NB#58671.
76 2007-06-02 Armin Burgmeier <armin@openismus.com>
78 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
79 server type cannot be changed in future to the incoming details page
80 when creating an account. This fixes projects.maemo.org bug NB#59029.
82 2007-06-02 Armin Burgmeier <armin@openismus.com>
84 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
85 and assigned max width chars so that they wrap instead of being
86 truncated. Fixes projects.maemo.org bug NB#56126.
88 2007-06-02 Armin Burgmeier <armin@openismus.com>
90 * src/maemo/modest-connection-specific-smtp-window.c: Add an
91 introductory note to the connection specific smtp servers dialog, as
92 section 8.12 of the email UI specification requires. This fixes
93 projects.maemo.org bug NB#59212.
95 2007-06-01 Murray Cumming <murrayc@murrayc.com>
97 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
98 Check for running mail operations, and offer to cancel them, as per the UI
99 spec. This fixes projects.maemo.org bug NB#59041 .
100 However, I suspect that tinymail may still use the network connection
101 in ways that we cannot detect or cancel. But it should at least adapt to
104 2007-06-01 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-tny-account-store.c: (recreate_all_accounts),
107 (get_cached_accounts), (get_server_accounts): Do more sensible
108 ref-counting of the temporarily-cached outbox accounts list. This seems
109 to fix a crash when entering the password when the password was wrong.
111 2007-06-01 Murray Cumming <murrayc@murrayc.com>
113 * src/gnome/modest-main-window.c: (connect_signals):
114 * src/modest-tny-account-store.c: (get_password),
115 (modest_tny_account_store_alert): Added comments and clues and
116 commented-out code about how we currently fail to deal with connection
117 errors and wrong passwords, and how we should.
119 2007-06-01 Murray Cumming <murrayc@murrayc.com>
121 * src/widgets/modest-retrieve-combo-box.c:
122 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
123 This fixes projects.maemo.org bug NB#58472 .
125 2007-06-01 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/easysetup/modest-easysetup-wizard.c:
128 (create_page_complete_easysetup):
129 (create_page_complete_custom): Correct the last commit,
130 putting the correct sentences in the correct pages.
132 2007-06-01 Murray Cumming <murrayc@murrayc.com>
134 * src/maemo/easysetup/modest-easysetup-wizard.c:
135 (create_page_complete_custom): Show the second sentence of text
136 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
139 2007-06-01 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
142 Set the leave-on-server conf key by default. This fixes
143 projects.maemo.org bug NB#59258 .
145 2007-06-01 Murray Cumming <murrayc@murrayc.com>
147 * src/maemo/modest-account-view-window.c:
148 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
149 logical ID for the confirmation messages. Fixed projects.maemo.org bug
152 2007-06-01 Murray Cumming <murrayc@murrayc.com>
154 * src/maemo/easysetup/modest-easysetup-wizard.c:
155 (create_caption_new_with_asterisk):
156 * src/maemo/modest-account-settings-dialog.c:
157 (create_caption_new_with_asterisk):
158 Uncomment the code to add the asterisk, because they are no longer in the
159 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
160 (update_incoming_server_title): Add an asterisk here too.
162 2007-06-01 Murray Cumming <murrayc@murrayc.com>
164 * src/maemo/modest-maemo-global-settings-dialog.c:
165 (current_connection): Check that we are even connected before trying to
166 get the current connection name, to prevent a warning.
168 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
169 Change the comments because tny_maemo_conic_device_connect() is now meant to
171 * src/modest-mail-operation.c:
172 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
173 make sure we have a connection and fail if we can't connect.
175 2007-05-31 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/modest-main-window.c:
178 (on_account_store_connecting_finished): Do not try to get the
179 connection ID if we are not really connected. I am surprised that
180 this signal handler is called when we are not connected.
182 2007-05-31 Murray Cumming <murrayc@murrayc.com>
184 * src/modest-error.h:
185 * src/modest-ui-actions.c:
186 (modest_ui_actions_get_msgs_full_error_handler):
187 Renamed an enum, added comments, added an enum
188 for retrieve-limit errors.
190 * src/modest-mail-operation.c: (foreach_add_item),
191 (internal_folder_observer_update), (update_account_thread),
192 (modest_mail_operation_get_msgs_full):
193 (modest_mail_operation_update_account),
194 Added comments about how this works, and some code that should
195 (but does not) check the retrieve-limit. See the TODO comment.
197 2007-05-31 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
200 Initialize help_id to fix the build. Warnings are good.
202 2007-05-31 Murray Cumming <murrayc@murrayc.com>
204 * src/widgets/modest-hbox-cell-renderer.c:
205 (modest_hbox_cell_renderer_append):
206 * src/widgets/modest-vbox-cell-renderer.c:
207 (modest_vbox_cell_renderer_append):
208 Fix the last commit by doing an extra ref.
210 2007-05-31 Murray Cumming <murrayc@murrayc.com>
212 * src/widgets/modest-hbox-cell-renderer.c:
213 (modest_hbox_cell_renderer_append):
214 * src/widgets/modest-vbox-cell-renderer.c:
215 (modest_vbox_cell_renderer_append):
216 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
217 to fix the build with Maemo Bora.
218 However, there seems to be a remaining crash, probably due to reference
221 2007-05-30 Murray Cumming <murrayc@murrayc.com>
223 * src/modest-tny-account.c:
224 (modest_tny_account_new_for_local_folders):
225 Use hildon_file_system_info_async_new() to get a better name for
226 the memory card account, setting it as the account name.
227 The timing seems to work, but this is probably
228 not the best place to do this. See the TODO comment.
229 * src/maemo/modest-main-window.c: (create_details_widget):
230 * src/widgets/modest-folder-view.c: (text_cell_data):
231 Use the tny account name instead of hardcoding a name.
233 2007-05-30 Christian Kellner <ckellner@openismus.com>
235 * src/modest-search.c: (modest_search):
236 Correctly set part_search_func even if we have already parsed
237 the query and thus a valid OgsTextSearcher object.
239 2007-05-30 Christian Kellner <ckellner@openismus.com>
242 Search and check for libogs.
245 Incooparte the ogs build env.
247 * src/modest-mime-part-search-stream.c:
248 * src/modest-mime-part-search-stream.h:
249 Removed since we do the real searching now in modest-search.c.
251 * src/modest-search.c:
252 * src/modest-search.h:
253 Implement support for ogs. We use that if available and requested
254 and fall back to modest_text_utils_utf8_strcmp (). The search logic
255 should now handle the corner case when the search term is spread
256 across multiple reads.
257 Also the logic in modest_search () was corrected to search all
258 requested fields until one is found.
260 2007-05-30 Murray Cumming <murrayc@murrayc.com>
262 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
265 * src/modest-init.c: Made modest_init_local_folders() take a
266 path and be public so we can iniitialize maildir folders on
269 * src/modest-local-folder-info.h:
270 * src/modest-local-folder-info.c:
271 (modest_local_folder_info_get_maildir_path): Add a path parameter.
273 * src/modest-tny-account.c:
274 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
275 still means the standard local-folders path on the local volume.
277 * src/modest-tny-account-store.c:
278 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
279 signal so we can detect mount/unmount of the MMC1 card, and do an update of
280 all accounts when that happens.
281 (get_server_accounts): If the MMC1 card is mounted, create a store account for
282 this too, so it shows up in the treeview.
284 2007-05-28 Murray Cumming <murrayc@murrayc.com>
286 * src/maemo/modest-maemo-global-settings-dialog.c:
287 (current_connection):
288 * src/widgets/modest-global-settings-dialog.c:
289 (current_connection_default):
290 Use the enum values instead of 0, 1 and -1,
291 to make the code clearer.
293 * src/modest-account-mgr-helpers.c:
294 (modest_account_mgr_get_connection_specific_smtp): Make this code
297 * src/modest-runtime.h:
298 * src/modest-runtime.c:
299 Added modest_runtime_remove_all_send_queues().
300 * src/maemo/modest-main-window.c:
301 (on_account_store_connecting_finished): Recreate the send queues,
302 using the appropriate transport accounts for this new connection.
303 Some futher adapting might be needed if the old send queues are not
304 automatically stopped at this point.
306 * src/modest-tny-account-store.c: (get_server_accounts):
307 Create the connection-specific transport accounts, so that they can
308 be found later by their ID.
310 * src/modest-tny-account.h:
311 * src/modest-tny-account.c:
312 Added modest_tny_account_new_from_server_account_name().
313 modest_tny_account_new_from_server_account(): Do not create the
314 send queues here, because they will be
315 recreated anyway when the connection changes for the first time.
317 2007-05-28 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-local-folder-info.h:
320 * src/modest-local-folder-info.c:
321 (modest_per_account_local_outbox_folder_info_get_maildir_path),
322 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
323 tbox_folder): Take a modest account name instead of a server TnyAccount,
324 so we can have per-modest-account rather than per-transport-account
326 We must make sure that we change or recreate the exisitng send queues
327 when the connection changes for connection-specific transport accounts.
329 * src/modest-tny-account-store.c:
330 (create_per_account_local_outbox_folders): Create outboxed per modest
331 account, not per transport account.
333 * src/modest-tny-account.h:
334 * src/modest-tny-account.c:
335 (modest_tny_account_get_special_folder): For outboxes, get the
336 parent modest account name. The account is ignored for other folders.
337 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
338 modest account name rather than a server TnyAccount.
340 2007-05-25 Murray Cumming <murrayc@murrayc.com>
342 * src/modest-tny-account.c:
343 (modest_tny_account_new_from_server_account):
344 Call modest_runtime_get_send_queue() immediately after creating transport
345 accounts, so that they start trying to send email from the outbox as soon
346 as possible at startup. This is probably what we want.
348 * src/modest-mail-operation.c: (update_account_thread):
349 * src/modest-runtime.c: (modest_runtime_get_send_queue):
350 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
351 * src/modest-tny-send-queue.h:
352 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
353 (modest_ui_actions_on_send):
354 Added comments about how sending works, though it needs some more work.
356 2007-05-25 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-tny-account.c:
359 (modest_tny_account_get_special_folder): Add TODO because this fails when
361 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
362 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
363 Do not try to show this window when there is no active account. The UI
364 specs does not tell us what to do in this case.
366 2007-05-24 Murray Cumming <murrayc@murrayc.com>
370 * src/maemo/Makefile.am:
371 * src/widgets/Makefile.am: Some dist fixes.
373 2007-05-24 Murray Cumming <murrayc@murrayc.com>
375 * src/maemo/modest-connection-specific-smtp-window.c:
376 (on_button_edit): Make the code clearer, to prevent a double free.
378 2007-05-24 Murray Cumming <murrayc@murrayc.com>
380 * src/maemo/modest-account-settings-dialog.c:
381 (modest_account_settings_dialog_set_account_name),
382 Check the connection-specific smtp servers checkbox if there are any.
384 * src/maemo/modest-connection-specific-smtp-edit-window.c:
385 (modest_connection_specific_smtp_edit_window_init):
386 Start with a suitable port number.
388 * src/modest-account-mgr-helpers.h:
389 * src/modest-account-mgr-helpers.c: Added
390 modest_account_mgr_get_has_connection_specific_smtp().
392 (modest_account_mgr_set_connection_specific_smtp),
393 (modest_account_mgr_remove_connection_specific_smtp),
394 (modest_account_mgr_get_has_connection_specific_smtp),
395 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
396 connection-specific smtp server accounts in the account, rather than
397 the server account conf dir.
399 This fixes bug projects.maemo.org bug NB#58263 .
401 * src/modest-tny-account-store.c:
402 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
403 if there are no server accounts yet, to prevent an infinite loop when there
404 are no accounts. Document that one must be called before the other.
406 2007-05-24 Murray Cumming <murrayc@murrayc.com>
408 * src/modest-account-mgr-helpers.c:
409 (modest_account_mgr_get_default_account): Make sure that at least
410 one account is always the default, if there are any enabled accounts.
411 This is just a sanity check that shouldn't be necessary.
413 * src/modest-account-mgr-priv.c:
414 (_modest_account_mgr_account_from_key): Unescape the conf key to
415 get the real account name. For instance, this is an issue if a space
416 was in the account name, which can happen because the account name
417 is generated from the display name.
418 (_modest_account_mgr_get_account_keyname): Always escape the
420 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
421 Unescape the conf keys to get the real account names.
423 For instance, previously the is-default radio button in the accounts
424 list was not checked for any accounts at first. This fixes that,
425 and might fix several similar bugs.
427 2007-05-23 Murray Cumming <murrayc@murrayc.com>
429 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
430 Removed some debug printfs.
432 2007-05-23 Murray Cumming <murrayc@murrayc.com>
434 Modest on-disk outbox directories are now here, for instance:
435 $HOME/.modest/outboxes/<account-id-1>/outbox
436 $HOME/.modest/outboxes/<account-id-2>/outbox
438 $HOME/.modest/local-folders/outbox
439 so we can have a separate outbox for each account.
440 But they are shown as one outbox in the GtkTreeView, by using a
441 TnyMergeFolder in a ModestTnySimpleFolderStore.
444 * src/modest-tny-simple-folder-store.c:
445 * src/modest-tny-simple-folder-store.h:
446 Added ModestTnySimpleFolderStore, used to contain folders from
447 other folder stores, such as other accounts.
449 * src/modest-tny-outbox-account.h:
450 * src/modest-tny-outbox-account.c:
451 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
452 used for the per-account local outbox folders.
454 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
455 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
456 only use this (internally) now for the non-outbox local folders.
459 * src/modest-init.c: Added modest_init_one_local_folder(), for
460 setting up the directory structure for each local folder.
462 * src/modest-local-folder-info.c:
463 (modest_per_account_local_outbox_folder_info_get_maildir_path),
464 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
466 * src/modest-local-folder-info.h:
467 * src/modest-tny-account-store.c: (on_account_removed),
468 (on_account_changed), (create_per_account_local_outbox_folders),
469 (get_server_accounts), (modest_tny_account_store_get_accounts),
470 (modest_tny_account_store_get_tny_account_by_account),
471 (modest_tny_folder_store_is_virtual_local_folders):
473 * src/modest-tny-account.h:
474 * src/modest-tny-account.c:
475 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
476 to create an on-disk per-account local outbox folder for each
478 (create_per_account_local_outbox_folders): Create a local outbox folder
479 for each transport account.
480 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
481 for all local folders.
483 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
484 instead of using g_object_get/set() directly. It is clearer.
486 (modest_tny_folder_store_get_message_count),
487 (modest_tny_folder_store_get_local_size
488 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
489 because we now use these with non-acount folder stores.
491 (modest_tny_account_get_special_folder),
492 (modest_tny_account_new_from_server_account),
493 (modest_tny_account_new_from_account):
494 (recurse_folders): Adjust to the new outbox system.
496 * src/modest-tny-folder.h:
497 * src/modest-tny-folder.c:
498 (modest_tny_folder_is_local_folder),
499 (modest_tny_folder_get_local_folder_type),
500 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
502 * src/widgets/modest-main-window.h:
503 * src/maemo/modest-main-window.c: (create_details_widget),
504 (modest_main_window_set_contents_style): Show details for any folder store,
507 (modest_tny_folder_get_rules):
508 Remove the const. C does not support constness enough for this.
510 * src/modest-ui-actions.c:
511 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
512 make all outboxes appear as one, in the usual local-folders tree node.
514 (set_active_account_from_tny_account),
515 (modest_ui_actions_on_folder_selection_changed):
516 * src/widgets/modest-folder-view.c: (text_cell_data),
517 (icon_cell_data), (filter_row),
518 (add_account_folders_to_merged_folder),
519 (add_account_folders_to_simple_folder_store), (),
520 (get_cmp_rows_type_pos), (cmp_rows),
521 (modest_folder_view_set_account_id_of_visible_server_account):
522 Adjust to the new outbox system, using generic folder stores and folders
525 2007-05-23 Christian Kellner <ckellner@openismus.com>
527 * src/modest-mail-operation.c:
528 (modest_mail_operation_update_account):
529 Use info->max_size instead of unintialized local var [small
530 build fix]. (Added TODO to review that change since I don't
533 2007-05-23 Marcus Bauer <marcusb@openismus.com>
535 * libmodest-dbus-client/libmodest-dbus-client.c:
536 (libmodest_dbus_client_compose_mail): function added
537 * src/dbus_api/modest-dbus-api.h:
538 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
539 (on_compose_mail): Implementation of the SendAsMail functionality
541 2007-05-22 Murray Cumming <murrayc@murrayc.com>
543 * src/modest-account-mgr.c:
544 (modest_account_mgr_add_server_account): Set the secure-connection
545 conf key for transport accounts as well as store accounts. I don't know
546 why the if was there. For instance, this makes sure that we use SSL
547 for the gmail preset from the easysetup wizard.
549 2007-05-22 Murray Cumming <murrayc@murrayc.com>
551 * src/gnome/modest-main-window.c:
552 (on_account_store_connecting_finished), (connect_signals):
553 * src/maemo/modest-main-window.c:
554 (on_account_store_connecting_finished), (connect_signals),
555 (modest_main_window_new):
556 Handle TnyAccountStore::connecting-finished instead of
557 TnyDevice::connection-changed, because we cannot actually perform
558 operations on accounts until TnyAccountStore has itself responded to
559 the TnyDevice::connection-changed signal. This prevents a GError from
561 Do not try to update at startup, because we (at least on scratchbox)
562 already do an update at startup when the device goes online.
563 This prevents a GError from tinymail.
564 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
565 Added TODO about stopping simultaneous operations.
567 2007-05-21 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
570 * src/modest-mail-operation-queue.c:
571 (modest_mail_operation_queue_remove):
572 * src/modest-tny-account-store.c: When GErrors happen, give more clues
573 about where they happened.
575 2007-05-21 Murray Cumming <murrayc@murrayc.com>
577 * src/modest-ui-actions.c:
578 (modest_ui_actions_on_password_requested): Make sure that the remember
579 output parameter is always TRUE.
581 2007-05-21 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
584 Show a OK/Cancel dialog if the error is a question, though we still do not
585 know anything more about what we are asking the user.
586 * src/widgets/modest-folder-view.c: (on_drag_data_received):
587 Fix an uninitialized variable (helper). This is a logic error, however.
589 2007-05-21 Christian Kellner <ckellner@openismus.com>
591 * src/modest-search.h:
592 Correct bit shifting in the ModestSearchFlags enum.
594 2007-05-21 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-tny-account.c:
597 (modest_tny_account_new_from_server_account): Do not use the lsub and
598 check-all hard-coded IMAP options when using POP.
600 2007-05-21 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-tny-account.c:
603 (modest_tny_account_new_from_server_account):
604 Use NULL for the secure-auth method for POP when Password auth has been
605 specified by the user, as we already do for IMAP. "auth=Login" causes
606 an error from camel or the server.
608 2007-05-17 Murray Cumming <murrayc@murrayc.com>
610 * src/maemo/modest-account-settings-dialog.c:
611 (create_page_account_details),
612 (modest_account_settings_dialog_set_account_name):
613 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
614 for the leave-on-server checkbox, rathr than just the checkbox, when
615 the protocol is not POP.
617 2007-05-17 Murray Cumming <murrayc@murrayc.com>
619 * src/widgets/modest-account-view.c:
620 * src/widgets/modest-account-view.h:
621 Added modest_account_view_select_account() which will be useful later
622 to asynchronously re-select the edited account.
624 2007-05-17 Murray Cumming <murrayc@murrayc.com>
626 * src/maemo/modest-account-settings-dialog.c:
627 (modest_account_settings_dialog_set_account_name):
628 Automatically choose the port numbers based on the secure authentication
629 methods, if they have not been chosen before.
630 This fixes projects.maemo.org bug NB#56273 .
632 2007-05-17 Murray Cumming <murrayc@murrayc.com>
634 * src/maemo/modest-main-window-ui.h:
635 * src/modest-ui-actions.c:
636 * src/modest-ui-actions.h:
637 Connect the Tools/SMTP Servers menu item to
638 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
639 SMTP servers dialog, as in the UI specification and saves changes when it
640 is closed. This fixed projects.maemo.org bug NB#56305 .
642 2007-05-17 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/modest-connection-specific-smtp-window.c:
645 (modest_connection_specific_smtp_window_init):
646 Use gtk_window_set_default_size() to make this window big enough, so
647 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
649 2007-05-17 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-connection-specific-smtp-edit-window.h:
652 * src/maemo/modest-connection-specific-smtp-edit-window.c:
653 (modest_connection_specific_smtp_edit_window_init),
654 Do not try to connect to a combobox signal before the combobox exists.
655 This fixes the cras in projects.maemo.org bug NB#56288 .
656 (modest_connection_specific_smtp_edit_window_get_settings):
657 Remove the server_account_name parameter which was being checked for NULL
658 though it was not used.
660 * src/maemo/modest-connection-specific-smtp-window.c:
661 (modest_connection_specific_smtp_window_fill_with_connections),
662 (on_button_edit), (modest_connection_specific_smtp_window_init):
663 Correct the number of treemodel columns to prevent a warning.
664 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
665 libconic does not work.
667 2007-05-16 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-tny-account.c:
670 (modest_tny_account_new_from_server_account):
671 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
672 SMTP when "None" was chosen by the user. However, with my SMTP server that
673 does not support ANONYMOUS, the emails do not leave the Outbox and I see
676 2007-05-16 Murray Cumming <murrayc@murrayc.com>
678 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
679 to explain the memory management issue with the ID in the ModestPair.
681 * src/gnome/modest-account-assistant.c: (add_receiving_page),
682 (add_sending_page), (modest_account_assistant_finalize):
683 * src/gnome/modest-gnome-global-settings-dialog.c:
684 (create_updating_page), (create_composing_page):
685 * src/gnome/modest-msg-edit-window.c: (get_transports),
686 (init_window), (modest_msg_edit_window_finalize),
687 (modest_msg_edit_window_get_msg_data):
688 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
689 * src/gnome/modest-transport-widget.c:
690 (modest_transport_widget_finalize), (smtp_configuration):
691 * src/maemo/modest-maemo-global-settings-dialog.c:
692 (create_updating_page), (create_composing_page):
693 * src/maemo/modest-msg-edit-window.c: (get_transports),
694 (init_window), (modest_msg_edit_window_finalize),
695 (modest_msg_edit_window_get_msg_data),
696 (modest_msg_edit_window_free_msg_data):
697 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
698 (modest_store_widget_finalize):
699 * src/maemo/modest-transport-widget.c:
700 (modest_transport_widget_finalize), (smtp_configuration):
701 * src/modest-main.c: (send_mail):
702 * src/widgets/modest-combo-box.h:
703 * src/widgets/modest-global-settings-dialog-priv.h:
704 * src/widgets/modest-global-settings-dialog.c:
705 (modest_global_settings_dialog_finalize):
706 * src/widgets/modest-msg-edit-window.h:
707 Whenever using modest_combo_box_new(), keep the ModestPairList alive
708 as long as the combo box, to prevent use of freed memory for the ID.
710 2007-05-15 Murray Cumming <murrayc@murrayc.com>
712 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
713 get_accounts(), to make this clearer. Do not check for the enabled gconf
714 key, because we do not use this for server accounts (at least, not yet).
715 This allows us to send email again.
717 2007-05-15 Murray Cumming <murrayc@murrayc.com>
719 * src/maemo/modest-platform.c:
720 (on_modest_conf_update_interval_changed), (modest_platform_init):
721 Only respond to this particular key change. All these strcmp()s cannot be
724 2007-05-15 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-maemo-global-settings-dialog.c:
727 (current_connection): Prevent a crash in scratchbox when
728 ny_maemo_conic_device_get_current_iap_id() returns NULL.
729 * src/maemo/modest-platform.c:
730 (on_modest_conf_update_interval_changed), (modest_platform_init):
731 Get the update interval from gconf and reset it when the gconf key changes.
733 2007-05-15 Murray Cumming <murrayc@murrayc.com>
735 * src/modest-protocol-info.c:
736 * src/modest-protocol-info.h: Adde enum-specific get functions,
737 instead of using a ModestProtocolType enum parameter.
739 * src/gnome/modest-account-assistant.c:
740 * src/gnome/modest-store-widget.c:
741 * src/gnome/modest-store-widget.h:
742 * src/gnome/modest-transport-widget.c:
743 * src/gnome/modest-transport-widget.h:
744 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
745 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
746 * src/maemo/easysetup/modest-easysetup-wizard.c:
747 * src/maemo/modest-account-settings-dialog.c:
748 * src/maemo/modest-account-settings-dialog.h:
749 * src/maemo/modest-store-widget.c:
750 * src/maemo/modest-store-widget.h:
751 * src/maemo/modest-transport-widget.c:
752 * src/maemo/modest-transport-widget.h:
753 * src/modest-account-mgr-helpers.c:
754 * src/modest-account-mgr-helpers.h:
755 * src/modest-account-mgr.c:
756 * src/modest-account-mgr.h:
757 * src/modest-tny-account.c:
758 * src/modest-tny-folder.c:
759 * src/widgets/modest-account-view.c:
760 * src/widgets/modest-retrieve-combo-box.c:
761 * src/widgets/modest-retrieve-combo-box.h:
762 * src/widgets/modest-secureauth-combo-box.c:
763 * src/widgets/modest-serversecurity-combo-box.c:
764 * src/widgets/modest-serversecurity-combo-box.h:
765 * tests/check_account-mgr.c:
766 Use the specific functions, and use the re-renamed enum values for GNOME too.
768 2007-05-15 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
772 so we can get the second based on the first.
774 * src/maemo/modest-account-settings-dialog.h:
775 * src/maemo/modest-account-settings-dialog.c:
776 Added get_supported_secure_authentication_methods(), though it is mostly
777 commented-out for now until the necessary API is committed to tinymail.
778 (modest_account_settings_dialog_set_account_name),
779 (save_configuration): Request the supported authentication methods from the
780 server, so we can choose a working method.
782 * src/modest-tny-account-store.h:
783 * src/modest-tny-account-store.c:
784 (modest_tny_account_store_get_session): Rename from
785 tny_account_store_get_session().
787 2007-05-14 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-protocol-info.h: Split the ModestProtocol enum
790 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
791 There was no need to have these unrelated values in one enum.
793 * src/: many files: Adapted to changed enum. This makes the code a bit
794 clearer, and the compiler could catch some errors.
796 2007-05-14 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
799 Show the detailed internal camel error message when an error happens
800 during the configuration, so that our testers can give us more clues.
801 For instance, in projects.maemo.org bug NB#56910 .
803 2007-05-14 Murray Cumming <murrayc@murrayc.com>
805 * src/modest-tny-account.c:
806 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
807 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
809 2007-05-14 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
812 * src/maemo/modest-account-settings-dialog.c:
813 (modest_account_settings_dialog_set_account_name),
814 (save_configuration): For the incoming secure authentication checkbox,
815 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
816 the UI specification. PLAIN does not seem to be supported for most IMAP
817 servers anyway, and I am not sure what it would mean.
818 However, we probably need to discover which of the secure-authentication
819 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
820 * src/modest-account-mgr-helpers.c:
821 (modest_account_mgr_get_server_account_data):
823 * src/modest-tny-account.c:
824 (modest_tny_account_new_from_server_account):
825 Use tny_account_set_mech() to set secure-authentication methods,
826 with some special-casing for IMAP, based on my observations of how
829 * src/modest-account-mgr-helpers.h:
830 * src/modest-account-mgr.c:
831 * src/modest-defs.h: Comment that the URI is only used for local folders.
833 2007-05-11 Murray Cumming <murrayc@murrayc.com>
835 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
836 parameter const, just to be neat.
837 * src/modest-text-utils.c: (modest_text_utils_inline):
838 End g_strconcat() with NULL, as its documentation says. This is almost
839 certainly the cause of my crash at startup on the device. Interestingly,
840 valgrind doesn't tell us about these errors.
842 2007-05-11 Murray Cumming <murrayc@murrayc.com>
844 * scripts/build-packages: Added more precise comments about how to use
845 this script, though I still get this error:
846 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
847 error building tinymail
849 2007-05-11 Murray Cumming <murrayc@murrayc.com>
851 * src/maemo/modest-main-window.c: (on_account_update):
852 Very slight cleanup, hoping to make it simpler to discover what causes
853 a crash here sometimes.
855 * src/modest-tny-account.c:
856 (modest_tny_account_new_from_server_account): Set the port. Added
857 comments about the options and a TODO comment because I need to find out
858 how to specify the secure authentication method.
860 2007-05-11 Marcus Bauer <marcusb@openismus.com>
862 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
863 changed CFlags paths form modest to libmodest
865 2007-05-10 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr-helpers.c:
868 (modest_account_mgr_get_server_account_data),
869 (modest_account_mgr_free_server_account_data):
870 * src/modest-account-mgr-helpers.h:
871 * src/modest-account-mgr.c:
872 (modest_account_mgr_add_server_account):
874 * src/modest-tny-account.c:
875 (modest_tny_account_new_from_server_account):
876 Determine the options for tny_camel_account_add_option() here,
877 based on the settings, rather than storing them directly in gconf.
879 2007-05-10 Murray Cumming <murrayc@murrayc.com>
881 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
882 Show a more friendly error dialog now that we expect (from the tinymail
883 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
885 2007-05-10 Murray Cumming <murrayc@murrayc.com>
887 * src/maemo/modest-main-window.c: (on_account_update): Check that
888 account_name is not NULL, to prevent a crash at startup that I am
889 seeing on the N800. I do wonder why it is NULL.
891 * src/maemo/easysetup/modest-easysetup-wizard.c:
892 (create_page_user_details):
893 * src/maemo/modest-account-settings-dialog.c:
894 (create_page_user_details), (create_page_outgoing):
895 * src/maemo/modest-connection-specific-smtp-edit-window.c:
896 (modest_connection_specific_smtp_edit_window_init):
897 * src/modest-ui-actions.c:
898 (modest_ui_actions_on_password_requested):
899 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
900 might do something useful with the on-screen keyboard.
902 2007-05-10 Murray Cumming <murrayc@murrayc.com>
904 * src/maemo/modest-main-window.c: (on_account_update):
905 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
906 NULL, to avoid lots of warnings. However, it probably should not be NULL.
908 2007-05-09 Murray Cumming <murrayc@murrayc.com>
910 * src/modest-tny-account-store.c: (on_account_changed):
911 Correct the signature of this signal handler.
913 2007-05-09 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
916 Show a HildonNote instead of a GtkDialog for Maemo.
918 2007-05-09 Murray Cumming <murrayc@murrayc.com>
920 * src/widgets/modest-account-view.h:
921 * src/widgets/modest-account-view.c: (on_account_changed),
922 (on_account_removed). Added a boolean flag, set/unset by
923 modest_account_view_block_conf_updates(),
924 modest_account_view_unblock_conf_updates() to prevent unnecessary
925 updates, but this is not very useful because the gconf notifications are
926 so delays (maybe only on Maemo Bora).
927 So auto-updating is turned off, and these functions do an explicit
928 update when necessary.
929 However, something else is still doing too much work when adding/removing
930 accounts, probably in another part of the application.
932 * src/maemo/modest-account-view-window.c:
933 (on_delete_button_clicked), (on_edit_button_clicked),
934 (on_new_button_clicked): Use the new functions.
936 2007-05-09 Murray Cumming <murrayc@murrayc.com>
938 * src/modest-account-mgr-helpers.c:
939 (modest_account_mgr_set_first_account_as_default):
940 Sort the list of names alphabetically-by-title, so we choose the first one
942 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
943 alphabetically by the title.
945 This fixes projects.maemo.org bug NB#56418 .
947 * src/modest-account-mgr-priv.c:
948 (_modest_account_mgr_account_from_key):
949 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
950 avoid a valgrind error, and possible random behaviour.
952 2007-05-09 Murray Cumming <murrayc@murrayc.com>
954 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
955 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
956 tinymail documentation to say that this can be expected.
957 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
958 pretty, and should not happen, but I would prefer to know when it does.
960 2007-05-09 Murray Cumming <murrayc@murrayc.com>
962 * configure.ac: When using the older hildon version, probably on Bora,
963 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
965 * src/widgets/modest-attachment-view.c:
966 (modest_attachment_view_set_part_default): Initialize variables, to fix the
969 2007-05-09 Marcus Bauer <marcusb@openismus.com>
971 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
972 Implemented the prototype. Can be tested with
973 tests/dbus_api/test_open_message:
975 2007-05-08 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-tny-account-store.c:
978 (modest_tny_account_store_instance_init), (get_password):
979 * src/modest-ui-actions.c:
980 (modest_ui_actions_on_password_requested):
981 Do not store the password in gconf, because this function is called
982 for non-remembered passwords. Actually use the cached (in the hash map)
983 password instead of releasing it.
984 The password will now not be remembered if it is asked via the protected
985 password dialog, as per the UI spec.
987 2007-05-08 Murray Cumming <murrayc@murrayc.com>
990 * src/modest-account-mgr-helpers.h:
991 * src/modest-account-mgr-helpers.c:
992 Added modest_server_account_get_username_has_succeeded(),
993 modest_server_account_set_username_has_succeeded().
994 (modest_server_account_set_username),
995 Reset the has-succeeded flag if the username changes.
997 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
998 * src/maemo/modest-connection-specific-smtp-window.c:
999 (modest_connection_specific_smtp_window_save_server_accounts):
1000 Use modest_server_account_set_username() instead of using
1001 modest_conf_set_string() directly, so that the has-succeeded flag is always
1004 * src/modest-ui-actions.c:
1005 (modest_ui_actions_on_password_requested): Dim the username entry if
1006 the username has ever worked, as per the UI spec.
1008 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1010 * src/modest-tny-account-store.c: (get_password):
1011 * src/modest-ui-actions.c:
1012 (modest_ui_actions_on_password_requested):
1013 Allow the username to be changed too, though there is more work to
1014 be done on exactly how this behaves.
1016 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1018 * src/modest-account-mgr-helpers.h:
1019 * src/modest-account-mgr-helpers.c:
1020 Added modest_account_mgr_get_display_name(),
1021 modest_server_account_get_username(),
1022 modest_server_account_set_username(),
1023 modest_server_account_set_password(),
1024 modest_server_account_get_hostname() functions so we do not need to
1025 use the conf API directly.
1027 * src/maemo/modest-main-window.c: (connect_signals):
1028 Actually connect ot the ModestAccountStore::request-password signal,
1029 so that we show the dialog when the password is requested by Tinymail,
1030 for isntance if it is empty.
1032 * src/modest-marshal.list:
1033 * src/modest-tny-account-store.c:
1034 (modest_tny_account_store_class_init), (get_password),
1035 (modest_tny_account_store_alert):
1036 * src/modest-tny-account-store.h:
1037 * src/modest-ui-actions.h:
1038 * src/modest-ui-actions.c:
1039 (modest_ui_actions_on_password_requested):
1040 Change the signal parameters, so it is obvious that we are providing
1041 the non human-readable server name, and receiving both the username
1042 and password, though changing of the username is not yet implemented.
1043 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1044 for the GNOME version.
1046 This should fix the projects.maemo.org bug NB#56209, though it does not
1047 work on Bora, because the gconf_client_get() for the password fails
1048 immediately after we save it with gconf_client_set().
1050 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1053 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1054 caused an undefined symbol error:
1055 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1057 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1059 * src/modest-tny-account-store.c:
1060 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1061 using a GError instead of a string message, so we can translate it in
1064 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1066 * src/maemo/modest-address-book.c:
1067 (modest_address_book_check_names):
1068 * src/maemo/modest-msg-view-window.c:
1069 (modest_msg_view_window_clipboard_owner_change):
1070 * src/modest-init.c: (modest_init_init_ui):
1071 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1072 (update_folders_cb), (modest_mail_operation_update_account):
1073 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1074 (modest_ui_actions_on_msg_attachment_clicked),
1075 (modest_ui_actions_on_msg_recpt_activated):
1076 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1077 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1078 (modest_msg_view_search_next):
1079 * src/widgets/modest-recpt-editor.c:
1080 (modest_recpt_editor_on_button_release_event),
1081 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1082 g_message(). At this point we should only be seeing interesting errors on
1083 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1085 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1087 (modest_wizard_dialog_force_title_update):
1088 * src/maemo/easysetup/modest-wizard-dialog.h:
1089 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1090 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1091 can update the title when appropriate. Otherwise the title is wrong if the
1092 pages are added after adding the notebook to the dialog.
1093 This must be a problem in HildonWizardDialog too.
1094 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1096 * src/maemo/easysetup/modest-easysetup-wizard.c:
1097 (create_subsequent_customsetup_pages),
1098 (create_subsequent_easysetup_pages):
1099 Call modest_wizard_dialog_force_title_update() so that the title is
1100 correct even with GTK+ < 2.10.
1101 This fixes projects.maemo.org bug NB#56145 .
1103 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1105 * src/maemo/modest-platform.c:
1106 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1107 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1110 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1112 * src/widgets/modest-window.h:
1113 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1114 and modest_window_save_state(), which invokes it.
1116 * src/widgets/modest-window-mgr.h:
1117 * src/widgets/modest-window-mgr.c:
1118 Added modest_window_mgr_save_state_for_all_windows(), which calls
1119 the save_state vfunc on all registered windows, if implemented.
1121 * src/gnome/modest-msg-edit-window.c:
1122 * src/gnome/modest-msg-view-window.c:
1123 * src/maemo/modest-msg-edit-window.c:
1124 * src/maemo/modest-msg-view-window.c:
1125 * src/maemo/modest-main-window.c:
1126 Specify the existing save_settings functions as implementations of
1127 ModestWindow::save_state_func().
1129 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1130 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1131 enabling hibernation, for instance.
1133 We may need to do the same thing for restoring settings.
1136 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1138 * src/widgets/modest-window-mgr.c:
1139 * src/widgets/modest-window-mgr.h:
1140 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1141 modest_window_mgr_get_hibernation_is_prevented().
1143 * src/maemo/modest-main-window.c:
1144 (on_hildon_program_is_topmost_notify): Prevent hibernation
1145 (possible when the application goes to the background in the WM),
1146 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1148 * src/maemo/easysetup/modest-easysetup-wizard.c:
1149 (modest_easysetup_wizard_dialog_init):
1150 * src/maemo/modest-account-settings-dialog.c:
1151 (modest_account_settings_dialog_init):
1152 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1153 (modest_connection_specific_smtp_edit_window_init):
1154 * src/maemo/modest-connection-specific-smtp-window.c:
1155 (modest_connection_specific_smtp_window_init):
1156 * src/maemo/modest-signature-editor-dialog.c:
1157 (modest_signature_editor_dialog_init):
1158 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1159 prevent hibernation while any of these account settings dialogs are open.
1161 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1163 * src/maemo/Makefile.am:
1164 * src/maemo/modest-osso-state-saving.c:
1165 * src/maemo/modest-osso-state-saving.h: Added
1166 modest_osso_load_state() and modest_osso_save_state() though they do
1167 nothing now. They should iterate through all the open windows and load/save
1169 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1170 save state when closing.
1172 * src/maemo/modest-main-window.c:
1173 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1174 Add a notification handler for the HildonProgram::is-topmost property,
1175 so we can allow hibernation when the application goes into the background.
1176 But we still need to detect when the accounts setup windows are open so
1177 we can stop hibernation when they are open.
1178 To do this, I also added the main window the HildonProgram. This might have
1179 other side-effects/benefits, and should maybe be done for other windows.
1181 * src/maemo/modest-osso-autosave-callbacks.h:
1182 * src/maemo/modest-osso-autosave-callbacks.c:
1183 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1184 though it does not do anything yet, and we might never need this to do
1185 anything. For instance, we already save drafts.
1187 * src/maemo/modest-platform.c: (modest_platform_init):
1188 Specify the libosso auto-save callback.
1190 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1192 * src/maemo/modest-platform.c:
1193 (modest_platform_set_update_interval):
1194 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1195 aparently stays valid between application instances, so we can use this
1196 to remove and reset it later. According to a maemo-developers email from
1199 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1201 * configure.ac: Depend on libalarm for Maemo.
1203 * src/dbus_api/modest-dbus-api.h:
1204 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1205 (on_send_receive), (modest_dbus_req_handler):
1206 Handle a SEND_RECEIVE D-Bus method.
1208 * libmodest-dbus-client/libmodest-dbus-client.c:
1209 (libmodest_dbus_client_send_and_receive):
1210 * libmodest-dbus-client/libmodest-dbus-client.h:
1211 Add C convenience functions for calling the new D-Bus method.
1213 * src/modest-platform.h:
1214 * src/gnome/modest-platform.c:
1215 * src/maemo/modest-platform.c:
1216 Added modest_platform_set_update_interval(), which uses the
1217 alarmd API on Maemo.
1218 (modest_platform_init),
1219 Call modest_platform_set_update_interval(), using a hard-coded
1220 interval for now (until the global settings dialog is implemented),
1221 though I am not sure that this makes sense yet.
1223 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1225 * src/dbus_api/modest-dbus-callbacks.c:
1226 (modest_osso_cb_hw_state_handler):
1227 * src/dbus_api/modest-dbus-callbacks.h:
1228 * src/maemo/modest-platform.c: (modest_platform_init):
1229 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1230 in case this has some effect on the ability for Maemo to ping the
1233 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1236 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1237 warning. It is probably a logic error, but I need to fix the build.
1239 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1241 * src/modest-account-mgr.h:
1242 * src/modest-account-mgr.c:
1243 (modest_account_mgr_account_names): Add a gboolean enabled_only
1244 parameter, so we can get lists of onlt the enabled accounts.
1246 (modest_account_mgr_add_account),,
1247 (modest_account_mgr_account_with_display_name_exists):
1248 * src/maemo/modest-msg-edit-window.c: (get_transports):
1249 * src/modest-account-mgr-helpers.c:
1250 (modest_account_mgr_set_first_account_as_default):
1251 * src/modest-init.c: (init_default_account_maybe):
1252 * src/modest-tny-account-store.c: (get_accounts):
1253 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1254 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1255 * tests/check_account-mgr.c: (START_TEST):
1256 Provide the extra parameter, as appropriate.
1258 * src/widgets/modest-account-view.c: (update_account_view):
1259 Do not show disabled accounts (meaning that there is no way to
1260 enable/disable accounts in the UI (the feature is not in our UI
1261 specification), so we can use this internally only to mark unfinished
1262 or temporary account data.
1264 * src/maemo/easysetup/modest-easysetup-wizard.c:
1265 (create_account): Add boolean enable parameter, so we can specify FALSE
1266 to create the temporary account.
1267 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1268 (on_before_next): When finishing, when there is a temporary account, just
1270 Also, use a timeout to delay the showing of the dialog until gconf is likely
1271 to return correct information, due to a maemo gconf bug that is fixed in
1272 osso 1.1, but not yet in Bora.
1273 However, the dialog stays on screen after it is destroyed.
1275 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1276 for invalid data when cancelling. Use a hildon note instead of a dialog
1277 to complain about invalid data. Do not show the account-saved note if the
1278 account is disabled (a temporary account that will not really be saved for use
1281 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-account-mgr-helpers.h:
1284 * src/modest-account-mgr-helpers.c:
1285 Added modest_account_mgr_unset_default_account(),
1286 Added modest_account_mgr_set_first_account_as_default().
1288 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1289 If it was the default account, unset the default account name.
1291 * src/maemo/modest-account-view-window.c:
1292 (on_delete_button_clicked): If it was the default account,
1293 set the first remaining account as the default instead.
1295 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1296 a NULL account or a NULL default account, to prevent a crash. This should
1297 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1300 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1302 * src/widgets/modest-recpt-editor.c:
1303 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1304 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1305 TODO comment for this. This fixes the build.
1307 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1308 be the best place for it. This will in future update all auto-update accounts,
1309 rather than just the current/default account, when that gconf key exists.
1310 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1311 if there are no accounts, before calling do_send_receive().
1312 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1314 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1315 * src/maemo/modest-main-window-ui.h:
1316 * src/maemo/modest-main-window.c: (on_connection_changed),
1317 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1318 directly, becaue the signal handler does more.
1320 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-account-mgr-helpers.c:
1323 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1324 for the case that the account does not exist.
1326 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1327 (equivalent to the modest account name) rather than the tinymail account name
1328 (equivalent to the modest account title - human readable) to get the account data.
1329 Check for null account data to prevent the crash, and add a TODO comment saying that
1330 this needs fixing because it is using the server account name instead of the account name.
1332 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1334 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1335 * src/maemo/modest-account-settings-dialog.c: (show_error),
1337 Use hildon_note_new_information() for informative and error messages,
1338 which seems to be expected for Maemo applications (no documentation that I know of
1339 says this). I am surprised that there is no distinction between info and error
1342 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1344 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1345 it is easy to find where this is used.
1347 * src/maemo/easysetup/modest-easysetup-wizard.c:
1348 (create_page_welcome), (create_page_account_details),
1349 (create_page_user_details), (create_page_complete_easysetup),
1350 (create_page_custom_incoming), (create_page_custom_outgoing),
1351 (create_page_complete_custom):
1352 * src/maemo/modest-account-settings-dialog.c:
1353 (create_page_account_details), (create_page_user_details),
1354 (create_page_incoming), (create_page_outgoing):
1355 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1357 (modest_connection_specific_smtp_edit_window_init):
1358 * src/maemo/modest-connection-specific-smtp-window.c:
1359 (modest_connection_specific_smtp_window_init):
1360 * src/maemo/modest-signature-editor-dialog.c:
1361 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1362 and scrolling policy as per the Email Application Layout Guide, if I have
1365 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1367 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1368 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1369 which were empty, because these vfuncs have been removed from TnyAccountStore.
1370 This fixes the build.
1372 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1374 * src/maemo/modest-main-window.c:
1375 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1376 showing/hiding it. Added TODO because it probably should not be NULL.
1377 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1378 because unnecessary g_warnings() make degugging difficult.
1380 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1382 * src/maemo/modest-msg-edit-window.c:
1383 (modest_msg_edit_window_select_color),
1384 (modest_msg_edit_window_select_background_color): 2 const corrections and
1385 moving 2 #endifs before closing brackets, to fix the build.
1387 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1389 * src/maemo/easysetup/modest-easysetup-wizard.h:
1390 * src/maemo/easysetup/modest-easysetup-wizard.c:
1391 (modest_easysetup_wizard_dialog_finalize),
1392 (on_button_edit_advanced_settings), (create_page_complete_custom),
1393 (on_response), (create_account):
1394 Implement the Advanced Settings edit button, by saving the account information,
1395 for the Advanded Settings dialog to use directly from gconf, and removing it
1396 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1397 Bug #5533 in the projects.maemo.org bugzilla.
1399 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1401 * src/maemo/modest-msg-view-window.c:
1402 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1403 when opening a message window.
1405 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1407 * src/maemo/easysetup/modest-easysetup-wizard.c:
1408 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1411 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1412 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1413 gconf settings. I probably added more checks than necessary, but that is safer.
1415 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1416 variable to fix the build, but this seems to be used when it is still NULL.
1418 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1420 * src/modest-platform.h:
1421 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1422 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1423 * src/modest-main.c: Implement this function so we can avoid using
1424 maemo-specific API from cross-platform code.
1426 * src/modest-tny-account-store.c:
1427 (get_smtp_specific_transport_account_for_open_connection):
1428 * src/modest-ui-actions.c: (check_for_connection),
1429 (modest_ui_actions_on_item_not_found):
1430 Use modest_platform_connect_and_wait() and put #idefs around other
1431 maemo-specific code, because only maemo currently has a way to
1432 identify connection names.
1434 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-tny-account-store.h:
1437 * src/modest-tny-account-store.c:
1438 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1439 the connection-specific SMTP server settings in the configuration.
1441 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1443 * src/maemo/modest-main-window.c: (on_connection_changed),
1445 * src/modest-main.c: (main), (start_ui), (send_mail):
1446 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1447 that is what is intended.
1449 * src/modest-ui-actions.c: (action_send), (action_receive),
1450 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1451 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1452 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1453 SMTP server is used when it is specified.
1455 (modest_ui_actions_on_send_receive):
1456 Check that a connection is open before proceeding.
1457 Receive and then send, instead of vice-versa, as per the specification.
1459 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1461 * src/modest-mail-operation.c:
1462 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1463 though I guess it should be something other than NULL.
1465 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1467 * src/maemo/easysetup/modest-easysetup-wizard.c:
1468 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1469 combo twice, to avoid an g_warning and to make it visible again.
1470 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1471 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1472 (already intended) dereference when detaching, because we then recreate the menu.
1473 But I am not sure why the warning was happening, and it is possible that this is a memory
1476 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1478 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1479 and uri_parse_mailto() utility functions.
1480 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1482 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1484 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1486 * src/dbus_api/modest-dbus-api.h:
1487 * src/dbus_api/modest-dbus-callbacks.c:
1488 Use an idle callback to execute the modest code in the application's own thread.
1489 Remove the helloworld example method.
1490 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1491 parsed, and the open-message method is not implemented because this is not yet implemented in
1493 * libmodest-dbus-client/libmodest-dbus-client.c:
1494 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1495 (libmodest_dbus_client_open_message):
1496 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1498 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1499 body without crashing.
1501 * tests/dbus_api/Makefile.am:
1502 * tests/dbus_api/test_mail_to.c:
1503 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1505 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1507 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1508 Added file to fix the build. Sorry.
1510 * src/dbus_api/Makefile.am:
1511 * src/dbus_api/modest-dbus-api.h:
1512 * src/dbus_api/modest-dbus-callbacks.h:
1513 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1514 (modest_dbus_req_handler):
1515 Put constants in a separate header so it can be reused by the
1516 client library, without duplication
1518 * libmodest-dbus-client/Makefile.am:
1519 * libmodest-dbus-client/libmodest-dbus-client.c:
1520 (libmodest_dbus_client_call_helloworld),
1521 (libmodfest_dbus_client_send_mail),
1522 (libmodfest_dbus_client_mailto),
1523 (libmodfest_dbus_client_open_message):
1524 * libmodest-dbus-client/libmodest-dbus-client.h:
1525 (Partly) Implement a send_mail D-Bus method.
1527 * tests/dbus_api/Makefile.am:
1528 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1529 the send_email D-Bus method.
1531 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1535 * libmodest-dbus-client/Makefile.am:
1536 * libmodest-dbus-client/libmodest-dbus-client.c:
1537 * libmodest-dbus-client/libmodest-dbus-client.h:
1538 * tests/dbus_api/Makefile.am:
1539 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1540 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1542 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/easysetup/modest-easysetup-wizard.c:
1545 (create_page_account_details):
1546 * src/maemo/modest-account-settings-dialog.c:
1547 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1548 widgets, because this might not be the default in future versions of the Maemo GTK+.
1549 However, I can not not get capitalization to work even in a simple test case.
1551 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1553 * src/maemo/easysetup/modest-easysetup-wizard.c:
1554 (create_page_custom_incoming), (create_page_custom_outgoing):
1555 * src/maemo/modest-account-settings-dialog.c:
1556 (create_page_account_details), (create_page_incoming),
1557 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1558 instead of using gtk_check_button_with_label(), so they are aligned like the other
1559 widgets, as per the UI spec.
1561 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c:
1564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1565 * src/widgets/modest-validating-entry.c:
1566 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1567 Modest prefix instead of an EasySetup prefix.
1569 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1571 * src/widgets/modest-validating-entry.h:
1572 * src/widgets/modest-validating-entry.c: (on_insert_text),
1573 Added easysetup_validating_entry_set_max_func(), used to set a callback
1574 to call when the max number of characters is reached. GtkEntry has a max-length
1575 already but is silent about it.
1577 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1578 (create_page_account_details), (create_page_user_details),
1580 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1581 (create_page_account_details), (create_page_user_details),
1582 (create_page_outgoing):
1583 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1584 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1585 the UI spec, when the user tries to enter more than the max number of characters.
1587 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1589 * src/maemo/easysetup/modest-easysetup-wizard.c:
1590 (create_page_user_details), (create_page_custom_incoming),
1591 (create_page_custom_outgoing):
1592 * src/maemo/modest-account-settings-dialog.c:
1593 (create_page_user_details), (create_page_incoming),
1594 (create_page_outgoing):
1595 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1596 (modest_connection_specific_smtp_edit_window_init):
1597 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1598 not appropriate. Bad Maemo-specific defaults!.
1600 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1602 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1603 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1604 (modest_signature_editor_dialog_set_settings):
1605 Disable the label and textview when the checkbox is disabled, and use the
1606 specified (UI spec) default signature text.
1608 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1610 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1611 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1613 * src/modest-defs.h:
1614 * src/modest-account-mgr-helpers.h:
1615 * src/modest-account-mgr-helpers.c:
1616 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1618 * src/maemo/Makefile.am:
1619 * src/maemo/modest-signature-editor-dialog.c:
1620 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1623 * src/maemo/modest-account-settings-dialog.h:
1624 * src/maemo/modest-account-settings-dialog.c:
1625 (modest_account_settings_dialog_finalize), (on_button_signature),
1626 (save_configuration): Use the new dialog when the Edit button is pressed, and
1627 save the changes if necessary, as per the UI spec.
1629 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1631 * src/maemo/Makefile.am:
1632 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1633 based on maemo-develoers email from Dirk.
1635 * src/maemo/easysetup/modest-easysetup-wizard.c:
1636 (create_page_welcome), (create_page_account_details),
1637 (create_page_user_details), (create_page_complete_easysetup),
1638 (create_page_custom_incoming), (create_page_custom_outgoing),
1639 (create_page_complete_custom),
1640 (modest_easysetup_wizard_dialog_init):
1641 * src/maemo/modest-account-settings-dialog.c:
1642 (create_page_account_details), (create_page_user_details),
1643 (create_page_incoming), (create_page_outgoing),
1644 (modest_account_settings_dialog_init):
1645 * src/maemo/modest-connection-specific-smtp-window.c:
1646 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1648 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1650 * src/maemo/easysetup/modest-easysetup-wizard.c:
1651 (create_page_account_details), (create_page_custom_outgoing),
1652 (create_page_complete_custom):
1653 * src/maemo/modest-account-settings-dialog.c:
1654 (create_page_user_details), (create_page_incoming),
1655 (create_page_outgoing):
1656 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1657 (modest_connection_specific_smtp_edit_window_init):
1658 Use the correct (UI spec) port min/max, and use horizontal separators,
1661 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1663 * src/maemo/easysetup/modest-easysetup-wizard.c:
1664 (set_default_custom_servernames):
1665 * src/maemo/modest-account-settings-dialog.c:
1666 (create_page_incoming), (on_combo_outgoing_security_changed),
1667 (on_combo_incoming_security_changed), (create_page_outgoing),
1668 (modest_account_settings_dialog_set_account_name),
1669 (save_configuration):
1670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1671 (on_combo_security_changed),
1672 (modest_connection_specific_smtp_edit_window_init),
1673 (modest_connection_specific_smtp_edit_window_set_connection),
1674 (modest_connection_specific_smtp_edit_window_get_settings):
1675 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1678 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1681 * src/maemo/easysetup/modest-easysetup-wizard.c:
1682 (create_page_custom_outgoing), (create_page_complete_custom):
1683 * src/maemo/modest-account-settings-dialog.c:
1684 (create_page_user_details), (create_page_outgoing):
1685 * src/maemo/modest-account-view-window.c: (button_box_new):
1686 Use changed logical IDs as per the most recent UI spec:
1687 mcen_bd_emailsetup_edit -> mcen_bd_edit
1688 mcen_bd_emailsetup_delete -> mcen_bd_delete
1689 mcen_bd_emailsetup_close -> mcen_bd_close
1691 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1695 * src/dbus_api/Makefile.am:
1696 * src/dbus_api/modest-dbus-callbacks.c:
1697 * src/dbus_api/modest-dbus-callbacks.h:
1698 * src/maemo/modest-platform.c: (modest_platform_init):
1699 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1701 * tests/Makefile.am:
1702 * tests/dbus_api/Makefile.am:
1703 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1705 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1707 * src/maemo/modest-account-settings-dialog.c:
1708 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1709 Removed unnecessary includes.
1711 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1713 * src/maemo/easysetup/modest-easysetup-wizard.c:
1714 * src/maemo/modest-account-settings-dialog.c:
1715 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1716 * src/widgets/Makefile.am:
1717 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1718 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1719 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1720 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1721 * src/widgets/modest-secureauth-combo-box.c:
1722 * src/widgets/modest-secureauth-combo-box.h:
1723 * src/widgets/modest-serversecurity-combo-box.c:
1724 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1725 made the GObject names more consistent with the rest of the Modest code.
1727 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1729 * src/maemo/easysetup/Makefile.am:
1730 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1731 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1732 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1733 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1734 * src/maemo/easysetup/modest-easysetup-wizard.c:
1735 * src/maemo/easysetup/modest-validating-entry.c:
1736 * src/maemo/easysetup/modest-validating-entry.h:
1737 * src/maemo/modest-account-settings-dialog.c:
1738 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1739 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1740 widgets/ because they are used outside of easysetup too. After checking in,
1741 svn will allow me to rename them too.
1743 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1745 * src/gnome/modest-msg-edit-window.c:
1746 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1747 linker error, to fix the build on the GNOME platform.
1748 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1749 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1750 ifdefed out to avoid a warning.
1752 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1754 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1755 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1756 some alternative for GTK+ 2.6.
1758 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1762 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1763 specified for EmailAccountsDialog in UI spec.
1765 * src/maemo/easysetup/modest-easysetup-wizard.c:
1766 * src/maemo/easysetup/modest-easysetup-wizard.h:
1767 * src/maemo/modest-account-settings-dialog.c:
1768 * src/maemo/modest-account-settings-dialog.h:
1769 Reuse a member window widget for the connection-specific SMTP server accounts,
1770 so we can tell it to create/save the accounts only if we actually save changes.
1772 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1773 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1774 (modest_connection_specific_smtp_edit_window_get_settings):
1775 Return a struct instance for temporarily remembering the entered data.
1777 * src/maemo/modest-connection-specific-smtp-window.h:
1778 * src/maemo/modest-connection-specific-smtp-window.c:
1779 (modest_connection_specific_smtp_window_finalize),
1780 (modest_connection_specific_smtp_window_fill_with_connections),
1782 (modest_connection_specific_smtp_window_save_server_accounts),
1783 (update_model_server_names): Do not actually save data until asked,
1784 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1786 (on_selection_changed),
1787 (modest_connection_specific_smtp_window_init): Disable the edit
1788 button when nothing is selected.
1790 * src/modest-account-mgr-helpers.c:
1791 * src/modest-account-mgr-helpers.h:
1792 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1795 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1797 * src/modest-account-mgr-helpers.h:
1798 * src/modest-account-mgr-helpers.c:
1799 (modest_account_mgr_get_unused_account_name),
1800 (modest_account_mgr_get_unused_account_display_name): Added these
1801 utility functions, to avoid code duplication.
1803 * src/maemo/easysetup/modest-easysetup-wizard.c:
1804 (create_page_account_details), (create_account):
1805 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1806 (on_combo_security_changed),
1807 (modest_connection_specific_smtp_edit_window_init),
1808 (modest_connection_specific_smtp_edit_window_save_settings):
1809 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1810 * src/maemo/modest-connection-specific-smtp-window.c:
1811 (modest_connection_specific_smtp_window_finalize),
1812 (modest_connection_specific_smtp_window_fill_with_connections),
1813 (on_button_edit), (modest_connection_specific_smtp_window_init):
1814 * src/maemo/modest-connection-specific-smtp-window.h:
1815 Implementing saving of connection-specific server accounts.
1817 But I need to refactor this so we can save the data for each
1818 possible connection-specific account and only actually create the server accounts
1819 when the easysetup finished, or the OK button is pressed on the account settings
1822 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1824 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1825 (on_combo_security_changed):
1826 (modest_connection_specific_smtp_edit_window_init):
1827 Auto-fill the port number as in the account settings.
1829 (modest_connection_specific_smtp_edit_window_set_connection):
1830 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1831 * src/maemo/modest-connection-specific-smtp-window.c:
1832 (fill_with_connections), (on_button_edit),
1833 (modest_connection_specific_smtp_window_init):
1834 Turn the edit window into a dialog to simplify the code, and
1835 set a WM hint as in a GtkDialog, because only a popup can be on top of
1836 another window in Maemo, and popups usually have no WM decoration.
1838 * src/modest-defs.h:
1839 * src/modest-account-mgr-helpers.c:
1840 (modest_account_mgr_set_connection_specific_smtp),
1841 (modest_account_mgr_remove_connection_specific_smtp),
1842 (modest_account_mgr_get_connection_specific_smtp):
1843 * src/modest-account-mgr-helpers.h: Some functions to write the
1844 connection-specific SMTP server information. Not yet used.
1847 * src/widgets/modest-folder-view.c: (text_cell_data):
1848 Fix a warning about an uninitialized variable.
1849 (on_configuration_key_changed): Put an #ifdef around the use
1850 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1852 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-account-settings-dialog.h:
1855 * src/maemo/modest-account-settings-dialog.c:
1856 Added connect_for_modified() utility function to mark the new modified boolean.
1858 (create_page_account_details), (create_page_user_details),
1859 (create_page_incoming), (create_page_outgoing), (on_response),
1860 (modest_account_settings_dialog_init),
1861 (modest_account_settings_dialog_set_account_name):
1862 Only warn about unsaved changes when there are actually unsaved changes.
1864 * src/modest-account-mgr-helpers.c:
1865 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1866 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1867 to get the data from there in future.
1869 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1871 * src/modest-defs.h:
1873 * src/modest-account-mgr-helpers.h:
1874 * src/modest-account-mgr-helpers.c:
1875 Store the security account setting in a single conf key instead of using
1876 the options list, so that the list is left for just the to-be-removed camel hack,
1877 and because gconf_client_set_list() is failing for some reason.
1879 * src/modest-account-mgr.c:
1880 (modest_account_mgr_add_server_account):
1881 * src/maemo/modest-account-settings-dialog.c:
1882 (modest_account_settings_dialog_set_account_name),
1883 (save_configuration): Use the renamed functions.
1886 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1888 * src/widgets/Makefile.am:
1889 * src/widgets/modest-limit-retrieve-combo-box.c:
1890 * src/widgets/modest-limit-retrieve-combo-box.h:
1891 * src/widgets/modest-retrieve-combo-box.c:
1892 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1893 the account settings dialog.
1895 * src/modest-defs.h:
1896 * src/modest-account-mgr-helpers.h:
1897 * src/modest-account-mgr-helpers.c:
1898 (modest_server_account_get_option_secure_auth),
1899 (modest_server_account_set_option_secure_auth):
1900 * src/modest-account-mgr.c:
1901 (modest_account_mgr_add_server_account):
1902 Use the existing AUTH_MECH conf key for the secure-auth setting,
1903 instead of putting it in the list options, because this was actually used already.
1905 * src/maemo/modest-account-settings-dialog.c:
1906 (create_page_account_details),
1907 (modest_account_settings_dialog_set_account_name),
1908 (save_configuration):
1909 * src/maemo/modest-account-settings-dialog.h:
1910 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1911 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1913 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1915 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1916 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1917 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1919 * src/modest-defs.h:
1920 * src/maemo/modest-account-settings-dialog.c:
1921 (create_page_incoming), (on_combo_outgoing_security_changed),
1922 (on_combo_incoming_security_changed), (create_page_outgoing),
1923 (modest_account_settings_dialog_set_account_name),
1924 (save_configuration): Load/Save the port number, and change it when the
1925 security combo changes, to suitable defaults.
1927 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-account-mgr.c:
1930 (modest_account_mgr_add_server_account): Set the security and secure-auth
1931 options, and add a comment saying that the other camel-specific options should be
1934 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1936 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1938 * src/modest-tny-account-store.c: (account_list_free),
1939 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1940 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1943 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-protocol-info.c:
1946 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1947 is required by our UI spec. Maybe something in our implementation will use this eventually.
1948 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1949 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1950 instead of the previous 0 placeholder.
1952 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1953 secure-auth settings.
1954 * src/modest-account-mgr-helpers.h:
1955 * src/modest-account-mgr-helpers.c:
1956 (modest_server_account_data_get_option_secure_auth),
1957 (modest_server_account_set_option_secure_auth),
1958 (modest_server_account_data_get_option_security),
1959 (modest_server_account_set_option_security): Added this API for getting and setting the security
1960 and secure-auth settings.
1962 * src/maemo/modest-account-settings-dialog.h:
1963 * src/maemo/modest-account-settings-dialog.c:
1964 (modest_account_settings_dialog_finalize), (check_data),
1965 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1966 about changing titles.
1967 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1968 (save_configuration): Save the security and secure-auth settings.
1970 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1971 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1973 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-defs.h:
1976 * src/modest-account-mgr.c:
1977 (modest_account_mgr_add_server_account):
1978 Added and used defines for the options key and value pair strings,
1979 that are used so far, though they do not seem to correspond to anything in our
1980 UI specs or ModestProtocol enum.
1982 * src/modest-account-mgr-helpers.h:
1983 * src/modest-account-mgr-helpers.c:
1984 (compare_option_strings_for_name),
1985 (modest_server_account_data_get_option_value),
1986 (modest_server_account_data_get_option_bool),
1987 (modest_account_mgr_get_server_account_option):
1988 Added helper functions for parsing the options GSList.
1990 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1992 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1993 display name is based on the supplied account name.
1994 * src/modest-account-mgr.c:
1995 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1996 with an inefficient, but good-enough, implementation.
1998 * src/maemo/easysetup/modest-easysetup-wizard.c:
1999 (create_page_account_details), (on_before_next), (create_account):
2000 Check for existing display names rather than (non-user-visible) account names, and just
2001 create and set a unique account name at the end.
2003 * src/maemo/modest-account-settings-dialog.c:
2004 (modest_account_settings_dialog_init),
2005 (modest_account_settings_dialog_set_account_name),
2006 (create_page_incoming): Show the display name, instead of the account name.
2007 (on_response): Do some (not all) extra checks, as in the UI spec.
2008 (save_configuration): Save the display name if it was changed.
2010 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2012 * po/en_GB.po: Added needed logical ID and translation.
2013 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2014 (init_view): Made the is-default column clicking work.
2016 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/easysetup/Makefile.am:
2020 * src/maemo/easysetup/modest-easysetup-wizard.c:
2021 (modest_easysetup_wizard_dialog_init):
2022 * src/maemo/easysetup/provider-data-test.keyfile:
2023 * src/maemo/easysetup/provider-data.keyfile:
2024 Moved the provider data file to the new modest-providers-data package and used it from there.
2026 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2028 * src/modest-local-folder-info.c:
2029 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2030 N_() was already used on the static strings, but this just marks it for translation without
2031 using the translation.
2033 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/modest-account-settings-dialog.c:
2036 (create_page_incoming),
2037 (modest_account_settings_dialog_set_account_name):
2038 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2039 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2040 I will do this if nobody else gets there first.
2042 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2044 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2045 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2046 save the security stuff.
2048 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2050 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2051 Set the email address and user fullname, which I now see must be
2054 * src/maemo/modest-account-settings-dialog.h:
2055 * src/maemo/modest-account-settings-dialog.c:
2057 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2058 leave-on-server and authentication.
2059 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2062 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/modest-account-settings-dialog.c:
2066 * src/maemo/modest-account-settings-dialog.h:
2067 Most (but not all) of the widgets are now present as specified by the UI spec.
2068 No changes are yet saved, and some details are not properly shown yet.
2070 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2072 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2074 * src/maemo/Makefile.am:
2075 * src/maemo/modest-account-settings-dialog.c:
2076 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2077 an existing account. Doesn't do much yet.
2079 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2080 Open the accounts settings dialog when Edit is clicked.
2082 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/easysetup/Makefile.am:
2085 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2087 * src/maemo/easysetup/modest-easysetup-wizard.c:
2088 (modest_easysetup_wizard_dialog_init):
2089 Try to get the source directory from the build system,
2090 instead of hard-coding "./" into the source code, when opening our local
2091 copies of the configuration files.
2092 But this still fails when opening the wizard from the Accounts window,
2093 maybe because the working directory seems to change at runtime.
2094 So the wizard will fail the second time unless you copy the files into their
2095 proper locations - see the stdout warnings for the paths.
2097 (create_page_account_details),(on_before_next):
2098 Check for existing non-server accounts instead of server accounts,
2099 so the default account name is useful again, and to prevent trying to
2102 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2103 Show the wizard when New is clicked.
2105 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2106 (init_view): Show the column headers, and show the columns that are
2107 specified in the UI specs. However, something in Maemo's GTK+ prevents
2108 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2109 change the default account. This is despite unsetting the special properties.
2111 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2113 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2114 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2115 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2116 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2117 to make that clearer.
2118 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2120 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/modest-account-view-window.c:
2123 (modest_account_view_window_init),
2124 (modest_account_view_window_new):
2125 Use the same buttons as specified in the
2126 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2127 the existing widgets, which never had a chance of working.
2128 Put the ModestAccountView treeview in a scrolled window.
2129 Do not repeat the initialization in both _init() and _new().
2131 * src/widgets/modest-account-view.c: (update_account_view):
2132 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2133 this widget and window shows no accounts.
2135 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2137 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/easysetup/modest-easysetup-wizard.c:
2140 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2141 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2142 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2145 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2146 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2147 accounts exist yet, as in the UI spec.
2149 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2151 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2153 * src/maemo/Makefile.am:
2154 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2155 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2156 New window for editing connection-specific smtp details.
2157 Not fully implemented.
2159 * src/maemo/modest-connection-specific-smtp-window.c:
2160 (modest_connection_specific_smtp_window_finalize) :
2161 unref the tree model.
2162 (on_button_edit): Show the edit window.
2164 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2166 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2169 * src/maemo/Makefile.am:
2170 * src/maemo/modest-connection-specific-smtp-window.c:
2171 * src/maemo/modest-connection-specific-smtp-window.h:
2172 New window for showing the list of connections, for connection-specific
2173 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2174 * src/maemo/easysetup/modest-easysetup-wizard.c:
2175 (create_page_custom_outgoing): Show the new window when the button is clicked.
2177 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2179 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2180 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2181 * src/maemo/modest-msg-edit-window.c:
2182 (modest_msg_edit_window_insert_image):
2183 * src/modest-conf.c: (modest_conf_key_escape):
2184 * src/modest-mail-operation.c:
2185 (modest_mail_operation_send_new_mail):
2186 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2187 (modest_ui_actions_on_new_account):
2188 * src/widgets/modest-attachment-view.c: (update_filename_request):
2189 * src/widgets/modest-mail-header-view.c:
2190 Corrected warnings that were breaking the build, by commenting out unused variables,
2191 and a function, and by including a header.
2193 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2195 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2196 so we can #ifdef around platform-specific code when necessary.
2197 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2198 to allow this to build for the GNOME platform too.
2200 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2202 * src/maemo/easysetup/modest-easysetup-wizard.c:
2203 Added util_increment_name() and used it in create_page_account_details()
2204 to make sure that the default account name is always a new name.
2206 (modest_easysetup_wizard_dialog_init),
2207 (set_default_custom_servernames): Some minor memory management fixes.
2209 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2213 * src/modest-runtime.c: (init_i18n): Restored the translation
2214 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2215 are defined in config.h, and the translations are installed.
2217 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2218 is defined for translation.
2220 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2224 * src/maemo/easysetup/modest-easysetup-wizard.c:
2225 (modest_easysetup_wizard_dialog_init):
2226 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2227 Use realistic paths (though they should use $prefix generically) to the
2228 mcc_mapping and provider-data.keyfile files which might work when they
2229 are installed by the future version of the operator-wizard package,
2230 and then fallback to paths in our source code, with an explanatory
2233 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/Makefile.am:
2238 * src/maemo/easysetup/: Added files from the previously-exernal
2239 osso-modest-easysetup.
2240 * src/maemo/modest-main-window-ui.h:
2241 * src/modest-ui-actions.c:
2242 * src/modest-ui-actions.h:
2243 Added modest_ui_actions_on_new_account() as a signal handler for the
2244 New Account menu item. It shows the easysetup wizard.
2245 * po/en_GB.po: Added additional needed logical IDs and translations.
2247 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2248 Apparently ChangeLog is not used for some vague Nokia legal reasons.