1 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/widgets/modest-folder-view.c: (filter_row)
4 Do not show drafts folder (see UI specs)
6 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
8 * src/modest-ui-actions.c:
9 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
10 place and also not necessary.
12 * src/widgets/modest-folder-view.c: (filter_row)
13 Guess folder type and hide Sent & Outbox if necessary.
14 Fixed project.maemo.org NB#57328
16 2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
18 * src/modest-main.c: (main): Only show the UI at the start if
19 the showui command line option was given. For instance,
20 run-standalone src/modest showui
21 Otherwise, we wait for the top_application D-Bus method to
22 be sent by hildon-desktop when the application is selected
24 This allows us to run without a UI when osso-global-search
25 uses our D-Bus methods.
27 2007-07-11 Murray Cumming <murrayc@murrayc.com>
29 * src/dbus_api/modest-dbus-api.h: Added a define for a
30 top-application D-Bus method.
31 * src/dbus_api/modest-dbus-callbacks.c:
33 (modest_dbus_req_handler): Handle the top-application D-Bus
34 method, which might be an undocumented D-Bus signal sent by
35 hildon-desktop when it starts the application from the menu.
36 But I am not sure and I need to test it on the device, because
37 my scratchbox does not have the application in the menu now.
38 This method shows the main window, so that it can be invisible
39 when started, for instance, just for email searching from
42 * src/maemo/modest-main-window.c: (restore_settings),
43 (modest_main_window_new): Do not show the window immediately
44 upon creation. We show it later.
45 * src/modest-widget-memory.c: (save_settings_paned):
46 Try (unsuccessfully) to avoid saving the paned position when
47 it is not even visible.
48 (restore_settings_paned): Do not allow a silly paned position.
49 This seems necessary when not showing the window at first.
51 * tests/dbus_api/Makefile.am:
52 * tests/dbus_api/test_top_application.c: (main): Test for the
55 2007-07-10 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-ui-dimming-rules.c:
58 (modest_ui_dimming_rules_on_new_msg),
59 (modest_ui_dimming_rules_on_reply_msg),
60 (modest_ui_dimming_rules_on_delete_msg),
61 (modest_ui_dimming_rules_on_details),
62 (modest_ui_dimming_rules_on_view_window_move_to),
63 (modest_ui_dimming_rules_on_view_previous),
64 (modest_ui_dimming_rules_on_view_next),
65 (_invalid_folder_for_purge): Added checks before
66 casting the window. This looks like an actual
67 logic error in _invalid_folder_for_purge(), because it
68 tries to use a ModestMainWindow as a message window.
70 2007-07-10 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-account-settings-dialog.c:
73 (show_error): Use the same implementation as in
74 modest-easysetup-wizard.c:
75 (on_entry_invalid_character): The logical ID contains a %s.
76 Guessed what it should be.
77 (on_entry_max), (check_data), (on_response): Adapt to
79 (create_page_account_details): Really call
80 modest_validating_entry_set_func() on the correct widgets.
81 * src/maemo/easysetup/modest-easysetup-wizard.c:
82 (on_entry_invalid_character): Fix the logical ID here too.
83 (create_page_account_details),
84 (create_page_user_details):
86 modest_validating_entry_set_func() on the correct widgets.
88 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
89 Do not try to use the account if it is NULL.
91 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
93 * src/modest-ui-actions.c: (create_move_to_dialog),
94 (modest_ui_actions_on_main_window_move_to),
95 (modest_ui_actions_on_msg_view_window_move_to):
96 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
97 (filter_row), (modest_folder_view_show_non_move_folders):
98 * src/widgets/modest-folder-view.h:
100 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
101 the Sent folder yet as it does not report the correct folder type.
103 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
105 * src/maemo/modest-msg-edit-window.c: (init_window):
108 2007-07-10 Murray Cumming <murrayc@murrayc.com>
110 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
111 Take a parent widget instead of a parent window, and
112 implement this with hildon_banner_show_information() instead.
113 Non-Maemo builds can just ifdef that there.
114 This fixed projects.maemo.org bug NB#62766.
116 (on_entry_invalid_character): Use show_error() again instead
117 of using hildon directly, and use the _CS() macro to use the correct
119 (create_account), (check_for_supported_auth_methods), (on_entry_max):
120 Pass a widget instead od a window to show_error().
122 2007-07-10 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
125 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
126 This allows us to show the server name in the error message, fixing
127 projects.maemo.org bug NB#62904.
128 Also, use the appropriate logical ID message for the account protocol.
130 2007-07-10 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-tny-account-store.c: (on_idle_wrong_password):
133 A compilation fix, though the build wasn't broken for me.
135 2007-07-09 Murray Cumming <murrayc@murrayc.com>
137 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
138 Do not try to unref a NULL folder store, to avoid a runtime warning.
139 This seems to happen sometimes when changing accounts settings.
141 2007-07-09 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-tny-account-store.c:
144 (modest_tny_account_store_instance_init),
145 (modest_tny_account_store_finalize),
146 (on_account_settings_hide), (on_idle_wrong_password):
147 Use a GHashTable to ensure that we only show one account settings
148 dialog per modest account. This avoids us having a dialog open for
149 both the store and transport accounts, or due to repeated get_password()
150 calls that shouldn't happen anyway.
152 2007-07-09 Murray Cumming <murrayc@murrayc.com>
154 * src/maemo/modest-maemo-utils.c: (on_hide),
155 (modest_maemo_show_dialog_and_forget): Handle the response, because
156 the window is not even hidden by default.
158 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
159 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
160 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
161 which seems to prevent some modality problems.
163 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
164 Ignore user cancellation errors.
166 * src/modest-account-mgr-helpers.h:
167 * src/modest-account-mgr-helpers.c:
168 Added modest_server_account_get_password() and
169 modest_server_account_get_has_password() to avoid direct use of
172 * src/maemo/modest-account-settings-dialog.h:
173 * src/maemo/modest-account-settings-dialog.c:
174 (modest_account_settings_dialog_init): Store the notebook so we can
176 Added modest_account_settings_dialog_switch_to_user_info().
178 * src/modest-tny-account-store.c:
179 (get_password): When the password in the account settings is wrong (we think),
180 show the relevant page of the account settings dialog, in the mainloop.
181 However, we currently get many of these at once because cancel does not
183 (forget_password): Do not forget the password
184 from the account settings, because this causes side-effects when
185 tinymail seems to call it at strange time, maybe because of how we
186 are cancelling get_password().
187 (modest_tny_account_store_alert): Ignore user cancellations.
189 2007-07-09 Murray Cumming <murrayc@murrayc.com>
191 * src/maemo/modest-maemo-utils.h:
192 * src/maemo/modest-maemo-utils.c:
193 Added modest_maemo_show_information_note_and_forget() for use instead of
194 gtk_dialog_run() when the response is not needed, to avoid an extra
195 mainloop which could cause a hang.
197 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
198 Use the logical IDs for the error message, though they are not
199 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
200 because gtk_dialog_run() caused a hang here (the window did not close).
201 This fixes projects.maemo.org bug NB#62646.
203 2007-07-09 Murray Cumming <murrayc@murrayc.com>
205 * src/modest-account-mgr-helpers.h:
206 * src/modest-account-mgr-helpers.c:
207 Added modest_account_mgr_get_store_protocol().
209 * src/maemo/modest-account-view-window.c:
210 (on_delete_button_clicked): Show different warning text depending on
211 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
212 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
215 2007-07-09 Murray Cumming <murrayc@murrayc.com>
217 * src/maemo/modest-msg-edit-window.c:
218 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
219 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
221 2007-07-07 Armin Burgmeier <armin@openismus.com>
223 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
224 ckdg_ib_maximum_characters_reached from correct package.
226 * src/modest-ui-actions.c: Show an error message when a folder could
227 not be created. Tinymail does not give us specific error codes about
228 what has gone wrong, so we assume that a folder with that name
229 already exists, though there might be other reasons.
231 2007-07-06 Murray Cumming <murrayc@murrayc.com>
233 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
234 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
235 give a more exact error message that can be partly translated.
237 2007-07-05 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/modest-address-book.c:
240 (select_email_addrs_for_contact): Specify a default window size for the
241 select-email-address dialog, so that it is probably big enough for the
242 title. This should fix projects.maemo.org bug NB#62277.
244 2007-07-05 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c:
247 (create_page_complete_easysetup): Use
248 gtk_widget_set_size() request to ensure that the text wraps
251 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
253 * src/maemo/easysetup/modest-easysetup-wizard.c:
254 (on_entry_invalid_character), (create_page_account_details),
255 (create_page_user_details):
256 Use new API of ModestValidatingEntry. But for some reason the banner is
257 not shown. I will have to investigate that further.
259 * src/widgets/modest-validating-entry.c: (on_insert_text),
260 (modest_validating_entry_set_func):
261 * src/widgets/modest-validating-entry.h:
262 Added a new callback function to be able to react to prevented
263 characters whitespaces to e.g show a banner.
265 2007-07-05 Armin Burgmeier <armin@openismus.com>
267 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
268 notification of HildonNumberEditor instead of remembering the port
269 number. Thanks to Johannes for pointing this out.
271 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
273 * src/maemo/easysetup/modest-easysetup-wizard.c:
274 Check if there are any user changes before showing a confirmation
275 dialog (projects.maemo.org NB#60946)
277 2007-07-05 Armin Burgmeier <armin@openismus.com>
279 * src/maemo/modest-account-settings-dialog.c: Remember custom port
280 number at the beginning of the dialog and set the modified flag at the
281 end if the port number has changed. This is necessary because
282 HildonNumberEditor does not support notification when the value has
285 2007-07-05 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-ui-actions.c:
288 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
289 a connection before asking anything else. Correct the check for the destination
290 folder so that it succeeds when online.
291 This fixed projects.maemo.org bug NB#61645.
293 2007-07-05 Murray Cumming <murrayc@murrayc.com>
295 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
296 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
297 to fix projects.maemo.org bug NB#62439.
299 2007-07-05 Murray Cumming <murrayc@murrayc.com>
301 * src/modest-tny-account.c: (on_connection_status_changed):
302 Really do not use tny_device_force_offline() here. See the previous comment.
304 2007-07-04 Murray Cumming <murrayc@murrayc.com>
306 * src/modest-tny-account.c: (on_connection_status_changed):
307 Do not use tny_device_force_offline() when tinymail says that something
308 went wrong with the connection. It seems to report this unnecessarily.
310 2007-07-04 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/modest-connection-specific-smtp-window.c:
313 (modest_connection_specific_smtp_window_init):
314 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
315 does not seem to have any effect in osso 1.1 (though it works in
316 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
318 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
320 * src/maemo/modest-connection-specific-smtp-window.c:
321 Fix UI specification problems with projects.meamo.org NB#60479
323 2007-07-04 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
326 clue when this has failed, because the error dialog is not always shown
327 (at least in earlier version).
329 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
330 GError message, because the generic error dialog is not helpful.
332 'This message is not currently available (can't let a new connection go online)'
333 when trying to open an IMAP message.
335 (_modest_ui_actions_open): Offer a connection when some messages would
336 have to be downloaded and we are offline.
338 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
340 * src/widgets/modest-folder-view.c:
341 Don't check for MERGE type anymore as we use the correct type
343 NOTE: For the last two changes you need to update your tinymail copy
344 because of API changes!
346 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
348 * src/modest-tny-local-folders-account.c:
349 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
350 (see projects.maemo.org NB#61580)
352 2007-07-04 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-tny-account.c: (on_connection_status_changed):
355 Commented out the call to modest_platform_connect_and_wait() because this
356 seems to always hang, and I would like to know if this is the only thing
357 that causes a hang when showing the connection dialog.
358 It is not very useful anyway.
360 2007-07-04 Murray Cumming <murrayc@murrayc.com>
362 * src/maemo/modest-msg-view-window.c:
363 (modest_msg_view_window_select_next_message):
365 * src/modest-platform.h:
366 * src/maemo/modest-platform.c:
367 Added modest_platform_connect_and_wait(), which calls
368 tny_maemo_conic_device_connect() always in the main thread, by calling it
369 in an idle handler and waiting for the idle handler to run. It should be
370 in the main thread because it uses GTK+ UI code. It just returns TRUE
371 if the device is already online.
373 There is some nasty code to ensure that subsequent calls to
374 modest_platform_connect_and_wait() just wait for the first one to finish,
375 by checking repeatedly in another idle handler. This is necessary,
376 because other threads (or even the main thread, via another idle handler)
377 can call modest_platform_connect_and_wait() while
378 modest_platform_connect_and_wait() is running.
380 (modest_platform_connect_and_wait_if_network_account),
381 (modest_platform_connect_and_wait_if_network_folderstore):
382 Convenience functions that calls modest_platform_connect_and_wait() if
383 the account or folder might want network access.
385 * src/modest-mail-operation.c:
386 (modest_mail_operation_update_account):
387 * src/modest-ui-actions.c: (download_uncached_messages),
388 (modest_ui_actions_on_rename_folder), (delete_folder),
389 (modest_ui_actions_on_main_window_move_to),
390 (modest_ui_actions_on_msg_view_window_move_to):
391 * src/widgets/modest-folder-view.c:
392 (drag_and_drop_from_folder_view):
393 Offer a connection if we are offline.
395 * src/modest-tny-account.c: (on_connection_status_changed):
396 Document this as only handling errors during network operations in progress,
397 and replace the idle code with a simple call to
398 modest_platform_connect_and_wait(), which does this instead.
400 2007-07-03 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-tny-account.c:
403 (modest_tny_account_get_special_folder): (util_on_idle),
404 Handle the GError so we can see when tny_folder_store_get_folders()
405 fails, as it currently does while something else is connecting.
407 Added util_run_in_main_thread_and_wait()
408 which uses an idlen handler and mainloop to ensure that the function
409 is called in the main thread.
410 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
411 to make sure that we call attempt the connection in the mainloop only,
412 which might solve some hangs.
414 2007-07-03 Murray Cumming <murrayc@murrayc.com>
416 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
417 be found by their display name. This is never useful.
418 * src/modest-tny-account-store.c: (on_account_removed): Find the account
419 by its ID, instead of trying to use its ID as its display name.
421 * src/modest-tny-account-store.h:
422 * src/modest-tny-account.c:
423 (modest_tny_account_get_special_folder): Add a g_warning() when
424 tny_folder_store_get_folders() returns an empty list for the maildir.
426 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
427 Add a g_warning() when this returns NULL, because that it not allowed
430 2007-07-02 Armin Burgmeier <armin@openismus.com>
432 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
433 note when trying to cancel the wizard. This fixes projects.maemo.org
436 2007-07-02 Murray Cumming <murrayc@murrayc.com>
438 * src/modest-tny-account.h:
439 * src/modest-tny-account.c:
440 (modest_tny_account_new_from_server_account),
441 (modest_tny_account_new_from_server_account_name),
442 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
443 because this must now be set before setting the proto. This is usd in
444 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
445 warning in camel_session_get_service() caused by
446 tny_camel_transport_account_prepare().
448 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
451 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
453 * src/maemo/modest-connection-specific-smtp-edit-window.c:
455 (modest_connection_specific_smtp_edit_window_init):
457 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
460 2007-06-29 Murray Cumming <murrayc@murrayc.com>
462 * src/modest-tny-account.c:
463 (modest_tny_account_new_from_server_account):
464 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
465 now uses to request a connection when it needs one, and which it uses
466 to tell us that something is wrong with the connection, so we can force
467 the accounts offline to prevent further problems.
470 * src/modest-init.c: (init_default_settings):
471 * src/modest-mail-operation.c:
472 (modest_mail_operation_update_account):
473 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
474 This should not be necessary anymore. Do not set the conf key that
475 determined this (it was always TRUE and not set anywhere else).
477 * src/modest-ui-actions.h: Remove unused and unimplemented
478 modest_ui_actions_on_online_toggle_toggled().
480 2007-06-29 Murray Cumming <murrayc@murrayc.com
482 * src/maemo/modest-main-window.c: (connect_signals):
483 Don't connect to delete_event twice. Maybe this was harmless.
485 2007-06-29 Murray Cumming <murrayc@murrayc.com
487 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
488 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
489 Debug output to give some more clue when a folder move is not allowed.
491 2007-06-28 Murray Cumming <murrayc@murrayc.com
493 * src/modest-tny-account.c: (on_modest_file_system_info),
494 (modest_tny_account_get_mmc_account_name):
495 Always call the callback, without checking whether the name has changed.
496 * src/widgets/modest-folder-view.c: (strings_are_equal),
497 (on_model_foreach_set_name), (on_get_mmc_account_name),
498 (text_cell_data): Compare the name here, and use the name from
499 the account rather than from the
500 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
501 if the name was changed after the account was added to the model.
502 That's a tinymail bug but not one that I want to fix now.
504 This finally fixes projects.maemo.org bug NB#59301.
506 2007-06-27 Armin Burgmeier <armin@openismus.com>
508 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
511 2007-06-27 Murray Cumming <murrayc@murrayc.com
513 * src/modest-tny-account.h:
514 * src/modest-tny-account.c:
515 Added modest_tny_account_get_mmc_account_name(), to set the memory
516 card name asynchronously for the given account and then notify.
517 (modest_tny_account_new_for_local_folders): Use this new function instead
518 of using hildon_file_system_info_async_new() directly.
520 * src/widgets/modest-folder-view.c: (text_cell_data):
521 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
522 gtk_tree_model_row_changed() when it is available.
524 This should fix projects.maemo.org bug NB#59301.
526 2007-06-27 Murray Cumming <murrayc@murrayc.com
528 * src/modest-mail-operation.c: (update_account_thread),
529 (get_msgs_full_thread): Fix typo failures in the revert
532 2007-06-27 Murray Cumming <murrayc@murrayc.com
534 * src/maemo/modest-maemo-global-settings-dialog.c:
535 (idle_select_default_focus):
536 * src/modest-mail-operation.c: (idle_notify_progress),
537 (idle_notify_progress_once), (set_last_updated_idle),
538 (update_account_thread), (get_msgs_full_thread):
539 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
540 * src/widgets/modest-header-view.c:
541 (idle_notify_headers_count_changed_destroy),
542 (idle_notify_headers_count_changed):
543 Reverted the additions of gdk_threads_enter/leave(), in case this
544 helps with a startup hang on the device.
546 2007-06-26 Armin Burgmeier <armin@openismus.com>
548 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
549 for supported secure authentication methods from server by
550 gtk_dialog_run(), saving CPU time and a potential race condition.
552 2007-06-26 Armin Burgmeier <armin@openismus.com>
554 * src/maemo/modest-maemo-utils.h:
555 * src/maemo/modest-maemo-utils.c: Added a
556 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
557 only error code to tell the calling code when the user canceled the
560 * src/maemo/modest-account-settings-dialog.h:
561 * src/maemo/modest-account-settings-dialog.c:
562 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
563 message if the retrieval of secure authentication methods was canceled
564 by the user. Perform the check before saving anything to configuration
565 to not end up with half-committed configuration changes, do not show
566 a "Saving to configuration failed" note when authentication methods
567 could not be retrieved.
569 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
572 2007-06-26 Murray Cumming <murrayc@murrayc.com>
574 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
575 Only return the first level of folders under accounts, because the
576 osso-global-search UI spec doesn't want the rest.
577 This fixed projects.maemo.org bug NB#61811.
579 2007-06-26 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-tny-account-store.c:
582 * src/modest-tny-account-store.h:
583 Added modest_tny_account_is_memory_card_account().
584 * src/maemo/modest-main-window.c: (create_details_widget):
585 Show the same information items for the memory card as we show for the
586 local-folders, to fix projects.maemo.org bug NB#59307.
588 2007-06-26 Murray Cumming <murrayc@murrayc.com>
590 * src/modest-tny-account-store.c: (get_password):
591 Added some checks for NULL to maybe prevent crashes, though I think
592 it was Philip's last commit that actually prevented the crash here
593 when creating a first new account.
594 But the new account is still not usable (no messages are shown)
595 until a restart of the application.
597 2007-06-26 Murray Cumming <murrayc@murrayc.com>
599 * src/maemo/modest-maemo-global-settings-dialog.c:
600 (idle_select_default_focus):
601 * src/modest-mail-operation.c: (idle_notify_progress),
602 (idle_notify_progress_once), (idle_notify_update_account_queue),
603 (set_last_updated_idle), (update_account_thread),
604 (notify_get_msgs_full), (get_msgs_full_destroyer),
605 (get_msgs_full_thread):
606 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
607 * src/widgets/modest-header-view.c:
608 (idle_notify_headers_count_changed_destroy),
609 (idle_notify_headers_count_changed):
610 Use gdk_threads_enter() and gdk_threads_enter_leave() in
611 all idle handlers, because some other thread could be blocking
612 the GDK lock, so that it can do GUI stuff.
614 2007-06-26 Murray Cumming <murrayc@murrayc.com>
616 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
617 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
618 (on_idle_send_receive), (on_idle_open_default_inbox):
619 * src/maemo/modest-msg-edit-window.c:
620 (modest_msg_edit_window_attach_file_noninteractive):
621 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
622 to prevent a hang. I don't quite understand why these are necessary,
623 beause we should already be in the main loop. I guess something outside
624 of the main loop is taking the lock.
626 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
627 we are really using URIs, and use files that are more likely to exist.
629 2007-06-26 Murray Cumming <murrayc@murrayc.com>
631 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
632 necessary because configure.ac now defines different variables.
634 2007-06-26 Murray Cumming <murrayc@murrayc.com>
636 * libmodest-dbus-client/libmodest-dbus-client.c:
637 * libmodest-dbus-client/libmodest-dbus-client.h:
638 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
639 libmodest_dbus_client_compose_mail() is what things actually use.
641 * src/dbus_api/modest-dbus-api.h:
642 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
643 * tests/dbus_api/Makefile.am:
644 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
647 2007-06-26 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-init.c: (modest_init_local_folders):
650 For memory-card (or other non local-folders) maildir accounts,
651 always create an Archive folder, so that there is somewhere to put
652 messages. This should be less confusing, because the user does not need
653 to guess that the need to create a folder.
655 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
657 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
658 Fixed icon size by using (50, 50) which is the same as defined by
661 2007-06-25 Armin Burgmeier <armin@openismus.com>
663 * src/widgets/modest-window-mgr.c:
665 * configure.ac: Correctly recognize hildon-notify presence and fixed
666 the build without it being installed.
668 2007-06-25 Murray Cumming <murrayc@murrayc.com>
670 * libmodest-dbus-client/libmodest-dbus-client.c:
671 (libmodest_dbus_client_search): Fix the build. Sorry.
672 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
673 (reply_forward_cb): Initialize variables to fix the build.
675 * src/modest-tny-account-store.c:
676 (modest_tny_account_store_get_tny_account_by): Fix the account URI
677 comparison (a silly typo) so that email search results can be opened
678 when there are more than one account.
680 2007-06-25 Murray Cumming <murrayc@murrayc.com>
682 * libmodest-dbus-client/libmodest-dbus-client.c:
683 (libmodest_dbus_client_search),
684 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
685 instead of 1 second, because the search gets folders and messages from
686 the server, which can take a long time. When it times out,
687 osso-global-search will report no results.
689 We need to specify whether we should search only cached information
690 (maybe with a user preference), and the osso-email-search-plugin
691 API should really be improved to allow that option, and to allow results
692 to be delivered asynchronously in batches.
694 2007-06-25 Murray Cumming <murrayc@murrayc.com>
696 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
697 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
698 GTK_ICON_SIZE_DIALOG is probably the wrong size.
700 2007-06-25 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
703 that is an empty string. D-Bus seems to give us these instead of NULL.
705 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
707 * src/dbus_api/modest-dbus-callbacks.c:
708 * src/maemo/easysetup/modest-easysetup-wizard.h:
709 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
710 * src/maemo/modest-connection-specific-smtp-edit-window.c:
711 (modest_connection_specific_smtp_edit_window_init):
712 * src/maemo/modest-maemo-global-settings-dialog.c:
714 * src/maemo/modest-maemo-utils.c:
715 (modest_maemo_utils_setup_images_filechooser):
716 * src/maemo/modest-main-window.c: (create_details_widget):
717 * src/maemo/modest-msg-edit-window.c:
718 (modest_msg_edit_window_attach_file_noninteractive),
719 (modest_msg_edit_window_color_button_change),
720 (modest_msg_edit_window_set_zoom):
721 * src/modest-mail-operation.c: (update_account_thread):
722 * src/modest-tny-account-store.c:
723 * src/modest-tny-account.c:
724 * src/widgets/modest-global-settings-dialog.c:
725 * src/widgets/modest-window.h:
729 2007-06-25 Murray Cumming <murrayc@murrayc.com>
731 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
732 * src/modest-search.c: (modest_search_folder),
733 (modest_search_all_accounts): Actually search only in the specified folder,
734 doing a simple match on the folder ID.
735 * src/modest-search.h: Added a folder field to the ModestSearch struct,
736 and added some documentation.
738 2007-06-22 Armin Burgmeier <armin@openismus.com>
740 * src/maemo/modest-maemo-utils.h:
741 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
742 modest_maemo_utils_get_supported_secure_authentication_methods.
744 * src/maemo/easysetup/modest-easysetup-wizard.c:
745 * src/maemo/modest-account-settings-dialog.c: Show correct error if
746 one occured, not just "Server does not support secure authentication".
748 2007-06-22 Murray Cumming <murrayc@murrayc.com>
750 * src/modest-tny-account-store.c: (get_password):
751 Restored the call to tny_account_set_user() because Philip seems to have
752 stopped this from crashing (by not using the freed string). It still does
753 not work, but now we can test it.
755 2007-06-22 Murray Cumming <murrayc@murrayc.com>
757 * src/maemo/modest-msg-edit-window.c: (init_window):
758 Comment out use of an uninitialzed GtkScrolledWindow variable,
759 to fix the build and stop a crash. Yet again.
761 2007-06-22 Murray Cumming <murrayc@murrayc.com>
763 * src/modest-tny-account-store.c: (get_password):
764 Remove the call to tny_account_set_user() because this actually crashes.
765 As mentioned in the last commit, it is known to not work anyway.
767 2007-06-22 Murray Cumming <murrayc@murrayc.com>
769 * src/modest-tny-account-store.c: (get_password):
770 Use tny_account_set_username() to tell tinymail that the username might
771 have changed too. But tinymail ignores this: see projects.maemo.org
773 * src/modest-ui-actions.c:
774 (modest_ui_actions_on_password_requested): Remove the useless attempt to
775 reset the connection when changing the username, and improve the comments.
776 Save the changed username to gconf at least, so it is used when Modest is
779 2007-06-21 Murray Cumming <murrayc@murrayc.com>
781 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
782 Do not use a query, so that we get all folders, including for POP and
783 local-folders. They work as search criteria too.
784 This fixes projects.maemo.org bug NB#57740.
786 2007-06-21 Murray Cumming <murrayc@murrayc.com>
788 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
789 Comment out the use of hildon_notification_set_sound() because it is
790 not declared, to fix the build. Warnings are serious, people.
792 2007-06-21 Armin Burgmeier <armin@openismus.com>
794 * src/maemo/modest-maemo-utils.h:
795 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
796 modest_maemo_utils_get_supported_secure_authentication_methods()
797 to query authentication methods for a specific user. This should fix
798 projects.maemo.org bug NB#61369.
800 * src/maemo/easysetup/modest-easysetup-wizard.c:
801 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
804 2007-06-21 Murray Cumming <murrayc@murrayc.com>
806 * libmodest-dbus-client/libmodest-dbus-client.h:
807 * libmodest-dbus-client/libmodest-dbus-client.c:
808 (modest_dbus_message_iter_get_search_hit),
809 (libmodest_dbus_client_search):
810 Reorganised and commented this.
811 Removed modest_search_hit_free() from the public API because it
814 Added libmodest_dbus_client_get_folders() and
815 modest_folder_result_list_free().
817 * src/dbus_api/modest-dbus-api.h:
818 * src/dbus_api/modest-dbus-callbacks.c:
819 (modest_dbus_req_filter): Commented. Moved most code to
820 on_dbus_method_search() and added on_dbus_method_get_folders().
822 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
823 of the extra D-Bus handler.
825 * tests/dbus_api/Makefile.am:
826 * tests/dbus_api/test_get_folders.c: New test for
827 libmodest_dbus_client_get_folders(). This seems to return an empty list
828 at the moment. That could be the same error that causes the message list
829 to be empty sometimes.
830 This should help with projects.maemo.org bug NB#57740.
832 2007-06-21 Armin Burgmeier <armin@openismus.com>
834 * src/modest-mail-operation.c: Do not call
835 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
836 notify the operation's end after having set the status to CANCELED for
837 the operation queue to listen on. This fixes a deadlock when there
838 were mail operations in the queue during its finalization.
840 * src/modest-singletons.c: Reordered uninitialization of the account
841 manager to happen after the mail operation queue was uninitialized
842 because the mail operation's in the queue might still try to access
843 the account manager (see modest_mail_operation_notify_end()). This
844 fixes a potential crash when terminating the application.
846 2007-06-21 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-search.c:
849 (search_mime_part_and_child_parts): Moved some code here so we
850 can search recursively in child folders.
851 (modest_search_folder): Search in the message as a mime part, instead
852 of just its child mime parts.
853 (read_chunk), (search_mime_part_ogs):
854 Check how many bytes were read, to prevent an endless loop.
855 Searching in message bodies now works. This finishes the fix for
856 projects.maemo.org bug NB#61007.
858 2007-06-20 Murray Cumming <murrayc@murrayc.com>
860 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
861 Add a g_warning when the item is not a folder.
863 * src/modest-ui-dimming-rules.c:
864 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
865 when selected item is not a folder (for instance, an account), because
866 the UI spec only talks about folders.
867 I am not sure what the UI spec wants, so this might not totally fix
868 projects.maemo.org bug NB#60794.
870 2007-06-20 Murray Cumming <murrayc@murrayc.com>
872 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
873 (load_from_file): Sort the list. The unsorted list would be more noticeable
874 in non-English locales.
876 * src/maemo/modest-msg-edit-window.c:
877 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
878 warning and fix the build.
880 * src/maemo/modest-progress-bar-widget.c:
881 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
882 avoid a g_warning, and probably to avoid a crash.
884 2007-06-20 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-search.c: (modest_search_folder): Check for a GError
887 when calling tny_folder_get_headers(), to show that this is not the cause
890 2007-06-20 Murray Cumming <murrayc@murrayc.com>
892 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
893 Actually set the body query instead of the subject query.
895 * src/modest-search.c: (search_mime_part_ogs),
896 (search_mime_part_strcmp): Remove extra space from the text/* regex,
897 which would probably cause it to fail if we got this far.
899 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
900 to simplify the code.
901 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
902 be causing search-in-body to fail.
904 2007-06-20 Murray Cumming <murrayc@murrayc.com>
906 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
908 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
909 Better debug message when the folder cannot be found.
910 This should help with fixing projects.maemo.org bug #61287.
911 * src/modest-search.c: (add_hit): Do not leak the furl string.
913 2007-06-20 Murray Cumming <murrayc@murrayc.com>
915 * src/modest-ui-actions.c:
916 (modest_ui_actions_on_folder_selection_changed):
917 Do not special-case TNY_MERGE_FOLDER here, because
918 modest_tny_folder_get_account() already does that. This fixes
919 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
920 shown when the Outbox was selected).
922 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
924 * libmodest-dbus-client/libmodest-dbus-client.c:
925 (_dbus_iter_get_string_or_null): Initialize the string variable in
926 case this helps with Dirk's crash.
928 2007-06-19 Murray Cumming <murrayc@murrayc.com>
930 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
931 though it is not implemented yet (this function is maybe not even used),
932 to avoid breaking ABI in future.
933 * libmodest-dbus-client/libmodest-dbus-client.c:
934 (get_attachments_string): Moved some code into this generic function.
935 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
936 sends email. It is maybe not used.
937 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
938 (on_send_mail): Use attachments.
940 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
941 * src/maemo/modest-msg-edit-window.c:
942 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
943 a filename before using it, to fix projects.maemo.org bug NB#58233.
945 2007-06-19 Murray Cumming <murrayc@murrayc.com>
947 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
948 Initialize the continue_download variable to fix the build, and probably
949 to fix randome behaviour.
951 2007-06-18 Armin Burgmeier <armin@openismus.com>
953 * src/modest-tny-send-queue.h:
954 * src/modest-tny-send-queue.c: Keep track of the status of messages in
955 the queue so we can later show it in the UI. Replaced
956 modest_tny_send_queue_msg_is_being_sent() by
957 modest_tny_send_queue_get_msg_status().
959 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
961 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
962 gpointer. This probably was not harmful, but just to be sure.
964 2007-06-18 Murray Cumming <murrayc@murrayc.com>
966 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
967 Fix the build, but leave the function broken on Bora, because
968 hildon_uri_action_get_service() does not exist.
969 osso_uri_action_get_service() does not exist either, it seems.
971 2007-06-18 Murray Cumming <murrayc@murrayc.com>
973 * src/modest-tny-account.c:
974 (modest_tny_account_new_from_server_account):
975 Uncommented the url debug output again, because it is useful for
976 debugging, as I said in the comment.
978 2007-06-18 Murray Cumming <murrayc@murrayc.com>
980 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
982 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
983 for Mameo Bora, to fix the build.
985 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
988 Fixed build with hildon < 0.99
990 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
991 Check if the selected account is busy instead of checking all accounts
993 * src/modest-account-mgr-priv.h:
994 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
995 (modest_account_mgr_init), (compare_account_name),
996 (modest_account_mgr_set_account_busy),
997 (modest_account_mgr_account_is_busy):
998 * src/modest-account-mgr.h:
999 Added busy information to the account manager. It possible to
1000 set an account to busy or not busy now.
1002 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1003 (modest_mail_operation_update_account),
1004 (modest_mail_operation_notify_end):
1005 Set the account to busy/not busy depending on the operation state.
1007 * src/widgets/modest-account-view.c:
1008 (modest_account_view_finalize), (get_last_updated_string),
1009 (update_account_view), (on_account_busy_changed), (init_view):
1010 Show string "Refreshing..." if the account is currently busy.
1012 All this fixes projects.maemo.org bug NB#59711
1014 2007-06-14 Armin Burgmeier <armin@openismus.com>
1016 * src/widgets/modest-attachments-view.h:
1017 * src/widgets/modest-attachments-view.c: Added
1018 modest_attachments_view_has_attachments() and fixed coordinate
1019 transformation in get_att_view_at_coords(). This fixes attachment
1022 * src/widgets/modest-msg-view.c: Make use of
1023 modest_attachments_view_has_attachments() to decide whether to show
1024 attachments in the header.
1026 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1028 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1029 (on_change), (on_combo_security_changed),
1030 (modest_connection_specific_smtp_edit_window_init),
1031 (modest_connection_specific_smtp_edit_window_set_connection),
1032 (modest_connection_specific_smtp_edit_window_is_dirty):
1033 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1034 * src/maemo/modest-connection-specific-smtp-window.c:
1037 Show an comfirmation dialog for the smpt-edit-window if there are
1038 unsaved changes and the user hits cancel.
1039 (projects.maemo.org bug NB#60479)
1041 2007-06-14 Armin Burgmeier <armin@openismus.com>
1043 * src/maemo/easysetup/modest-easysetup-wizard.c:
1044 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1045 address" info in banner instead of node, and select all the text as
1046 per UI spec. This fixes projects.maemo.org bug NB#60550.
1048 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1050 reviewed by: <delete if not using a buddy>
1052 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1053 * src/modest-ui-actions.c: (folder_refreshed_cb):
1055 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1057 * src/widgets/modest-folder-view.c: (filter_row):
1058 Explictly filter out the per-account outbox accounts. I don't know why
1059 these only sometimes show up, but now they should never show up in the UI.
1060 This should fix projects.maemo.org bug NB#60160.
1062 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1065 when the toolbar does not exist yet.
1066 * src/modest-widget-memory.c: (save_settings_header_view):
1067 Added g_warnings() to help us to discover when we are trying to set
1068 an empty columns list in gconf.
1070 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1072 * src/modest-init.h:
1073 * src/modest-init.c:
1074 Added modest_init_get_default_header_view_column_ids().
1076 * src/modest-widget-memory.c: (restore_settings_header_view):
1077 Use the new function to get defaults, if the gconf key is empty,
1078 instead of not creating any columns. This seems to fix the
1079 empty right-hand pane problems.
1081 * src/widgets/modest-header-view.h: Improved documentation.
1083 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1085 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1086 Revert the use of the display name as the account name, because this
1087 is generally wrong and would break the code that follows.
1089 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1091 * src/maemo/easysetup/modest-easysetup-wizard.c:
1092 (check_for_supported_auth_methods), (on_before_next),
1095 More correct fix for projects.maemo.org bug NB# 58991
1096 Do not longer accept AUTH_PASSWORD as secure method and choose
1097 correct method when creating the account.
1099 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1101 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1102 Fixed projects.maemo.org bug NB# 58991
1104 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-init.c: (modest_init_init_core),
1107 (modest_init_local_folders): Fixed compilation errors.
1109 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1111 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1112 Remove unnecessary lib/include, though it is good in principle when needed.
1114 * src/modest-init.c: (modest_init_one_local_folder),
1115 (modest_init_local_folders):
1116 * src/modest-init.h: Initialize the .modest library for memory cards,
1117 instead of just doing nothing for them. This should allow us to create
1118 folders there, fixing projects.maemo.org bug NB#59297.
1120 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1122 * libmodest-dbus-client/libmodest-dbus-client.c:
1123 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1124 (libmodest_dbus_client_compose_mail),
1125 (libmodest_dbus_client_open_message),
1126 (libmodest_dbus_client_send_and_receive),
1127 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1129 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1130 (on_idle_open_message), (modest_dbus_req_handler),
1131 (search_result_to_message), (modest_dbus_req_filter):
1132 * src/modest-search.c: (add_hit), (modest_search_folder),
1133 (modest_search_all_accounts): Improved debug messages.
1135 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1137 * src/modest-tny-account-store.c:
1138 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1141 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1144 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-tny-account-store.c: (get_server_accounts):
1147 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1148 even when there are no accounts, so that the Outbox folder is always
1149 visible. This fixes projects.maemo.org bug NB#60158.
1151 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1153 * src/maemo/modest-main-window.c: (create_details_widget):
1154 Use the mcen_va_never logical ID.
1156 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1158 * src/dbus_api/modest-dbus-api.h:
1159 * src/dbus_api/modest-dbus-callbacks.c:
1160 (on_idle_open_default_inbox), (on_open_default_inbox),
1161 (modest_dbus_req_handler):
1162 Added a new OpenDefaultInbox method.
1164 * libmodest-dbus-client/libmodest-dbus-client.h:
1165 * libmodest-dbus-client/libmodest-dbus-client.c:
1166 Added libmodest_dbus_client_open_default_inbox() to call the new
1167 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1168 though it should maybe be used by a new osso-email-interface function.
1170 * tests/dbus_api/Makefile.am:
1171 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1174 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1177 NULL, so that the signals get all the keys. This should not actually
1178 change any behaviour because we currently update everything when anything
1181 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1183 * src/widgets/modest-folder-view.c: (text_cell_data),
1184 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1185 (find_inbox_iter): If tinymail tells us that the folder is
1186 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1187 This causes the inbox to be selected at startup, fixing part of
1188 projects.maemo.org bug NB#56305.
1190 * src/modest-ui-dimming-rules.c:
1191 (modest_ui_dimming_rules_on_tools_smtp_servers):
1192 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1193 the SMTP servers menu item.
1194 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1195 that the SMTP Servers menu item is dimmed when there are no accounts,
1196 as a future version of the UI spec will require. This fixes
1197 projects.maemo.org bug NB#56305.
1199 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1201 * src/maemo/modest-maemo-utils.c:
1202 (modest_maemo_utils_get_supported_secure_authentication_methods):
1203 Added label to dialog instead of unreadable title
1205 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1206 (modest_main_window_new):
1207 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1210 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1211 * src/modest-account-mgr.h:
1212 Added method to avoid code duplication
1214 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1215 (modest_ui_actions_on_send_receive):
1216 Use modest_account_mgr_has_accounts
1218 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1220 * src/maemo/easysetup/modest-presets.c:
1221 (modest_presets_get_info_server_security): Do not report secure auth
1223 * src/modest-protocol-info.c: Use the defines for the gconf key names
1224 for secure authentication. This was not working because we were writing
1225 Password and reading password, and the check was case sensitive.
1226 With this, gmail now works for receiving and sending when created via
1229 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/easysetup/modest-presets.c:
1232 (modest_presets_get_info_server_security): Correct the key name for
1233 SecureSmtp, because it seems to be case-sensitive.
1234 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1235 Do not try to get the 0th notebook page if there are 0 pages, to
1236 avoid a g_warning().
1238 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1241 Prevent use of the new notification feature for now, because it currently
1242 shows one dialog for each new email, which is annoying.
1244 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1246 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1247 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1248 when no country was selected, so that we show the global ones.
1249 * src/maemo/easysetup/modest-presets.c:
1250 (modest_presets_get_providers): Return only the global providers, not
1251 all providers when mmc=0 was requested.
1253 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1255 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1256 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1257 provider ID in the combo.
1259 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1260 Do not show the page numbers, because it would be confusing when we add
1261 the 2 extra pages for the custom setup, when the user chooses the "Other"
1262 provider. This fixes projects.maemo.org bug NB#59028
1264 * src/modest-init.c: (modest_init_init_core),
1265 (modest_init_local_folders):
1266 * src/modest-init.h:
1267 * src/modest-tny-account.c:
1268 (modest_tny_account_new_for_local_folders): Do not create default folders
1269 for the memory card. This should fix projects.maemo.org bug NB#59328.
1271 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1274 Free the changed_conf_keys string items. They are already freed in the
1275 idle handler if that runs first.
1277 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-ui-actions.c:
1280 (modest_ui_actions_on_password_requested): Check that the server name
1281 is not NULL, because I just saw a password dialog with (null) as the
1284 * src/modest-tny-folder.[h|c]: Added
1285 modest_tny_folder_is_memory_card_folder().
1286 * src/modest-ui-dimming-rules.c:
1287 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1288 menu item for memory cards, as per the UI spec (section 7.4). This should
1289 fix projects.maemo.org bug NB#59297.
1291 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1293 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1294 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1295 is another problem with the code, see Murray's comment at line 772)
1297 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1300 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1301 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1302 (load_from_file), (easysetup_country_combo_box_init),
1303 (easysetup_country_combo_box_get_active_country_ids),
1304 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1305 instead of just one ID, to avoid duplicate country names in the UI.
1307 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1308 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1309 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1310 a single ID, avoiding duplicate providers.
1311 * src/maemo/easysetup/modest-easysetup-wizard.c:
1312 (on_combo_account_country): Adapt to use a list.
1314 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1316 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1317 keys changed in the last X seconds.
1319 * src/modest-account-mgr.h:
1320 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1321 (on_key_change), (modest_account_mgr_class_init),
1322 (modest_account_mgr_init), (modest_account_mgr_finalize):
1323 As the keys are changed, save them in a GSList* and signal that GSList*
1324 further every X seconds, to batch changes, to allow us to do just one
1325 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1326 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1328 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1329 changed signal signature.
1331 * src/modest-conf.c: (modest_conf_set_list),
1332 (modest_conf_on_change): Reenable notification.
1334 (modest_conf_maemo_fake_on_change): Comment out the hack that
1335 notified immediately instead of asynchronously.
1337 * src/widgets/modest-account-view.h:
1338 * src/widgets/modest-account-view.c:
1339 (update_account_view): Select the previously-selected account ID,
1340 if possible. This fixes projects.maemo.org bug NB#56933.
1342 (on_account_changed), (on_account_removed),
1343 (modest_account_view_select_account):
1345 Remove the block/unblock functions
1346 because they were not useful.
1348 * src/maemo/modest-account-view-window.c:
1349 (on_delete_button_clicked), (on_edit_button_clicked),
1350 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1352 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1355 Improve the error dialog to show Incorrect Account Settings, which seems
1356 clearer, and say that the internal error message (to be removed from the
1357 dialog later) is often misleading.
1358 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1360 * src/modest-tny-account.c:
1361 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1362 URL because this is so useful for debugging on the device.
1364 * src/widgets/modest-serversecurity-combo-box.c:
1365 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1367 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-mail-operation.c:
1370 (modest_mail_operation_send_new_mail):
1371 Added a comment about a nasty but apparently harmless message. Details
1372 added to the wiki g_warnings() page.
1374 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1377 (modest_tny_send_queue_class_init):
1378 Do not use the priv struct because it is empty, to avoid g_warnings
1379 about a non-existant priv struct.
1381 * src/modest-tny-account-store.c:
1382 (modest_tny_account_store_get_server_account),
1383 (modest_tny_account_store_get_transport_account_for_open_connection
1384 ): Do not try to get transport server accounts for local folders,
1385 because they don't have any. This avoids a g_warning().
1387 * src/maemo/modest-main-window.c:
1388 (modest_main_window_notify_send_receive_initied),
1389 (on_configuration_key_changed):
1390 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1391 * src/modest-defs.h:
1392 * src/modest-mail-operation.c:
1393 (modest_mail_operation_update_account):
1394 * src/modest-tny-account-store.h:
1395 * src/modest-tny-account.c:
1396 (modest_tny_account_get_special_folder),
1397 (modest_tny_account_new_for_local_folders),
1398 (modest_tny_account_new_for_per_account_local_outbox_folder):
1399 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1400 * src/modest-tny-local-folders-account.c:
1401 (add_account_folders_to_merged_folder):
1402 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1403 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1404 (modest_ui_actions_on_send):
1405 * src/widgets/modest-folder-view.c: (update_model):
1406 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1407 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1408 modest_tny_account_store_get_tny_account_by_account() to
1409 modest_tny_account_store_get_server_account() to make the code clearer.
1411 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1413 * src/dbus_api/modest-dbus-api.h:
1414 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1415 * src/maemo/modest-msg-edit-window.c:
1416 (modest_msg_edit_window_attach_file_noninteractive):
1417 added g_warning in case the file to be attached does not exist
1418 * tests/dbus_api/test_compose_mail.c: (main):
1419 removed obsolete comment, added generic files as test case
1421 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1423 * src/modest-tny-account-store.c: (get_server_accounts):
1424 Create the local folders account only once, not once for each outbox, and
1425 not only when there are some outboxes.
1427 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1429 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1430 code that is causing a crash at startup. Sergio says that he is fixing this.
1432 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1434 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1435 * src/maemo/modest-account-settings-dialog.c:
1436 (create_page_outgoing),
1437 (modest_account_settings_dialog_set_account_name),
1438 (save_configuration):
1439 - Fixed handling of the "Use secure authentication" toggle to comply with
1440 the ui specification. See also projects.maemo.org bug NB#58400
1442 - Restore the Secure connection setting combo correctly when loading
1445 * src/maemo/modest-maemo-utils.c:
1446 (on_camel_account_get_supported_secure_authentication),
1447 (modest_maemo_utils_get_supported_secure_authentication_methods):
1448 Fixed a crasher if operation is canceled
1450 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1451 (modest_protocol_info_auth_is_secure):
1452 * src/modest-protocol-info.h:
1454 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1455 the sense of the "Use secure authentication" toggle.
1457 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1459 * src/modest-tny-account-store.h:
1460 * src/modest-tny-account-store.c:
1461 Added modest_tny_account_store_get_local_folders_account().
1463 * src/modest-tny-folder.h:
1464 * src/modest-tny-folder.c:
1465 (modest_tny_folder_get_account):
1466 Added this replacement for tny_folder_get_account() which returns
1467 the local-folders account for TnyMergeFolders, to avoid the
1468 warning about the unimplemented get_account_func() vfunc().
1470 (modest_tny_folder_get_rules),
1471 * src/modest-ui-actions.c:
1472 (modest_ui_actions_on_folder_selection_changed):
1473 * src/modest-mail-operation.c:
1474 (modest_mail_operation_remove_folder),
1475 (modest_mail_operation_xfer_folder),
1476 (modest_mail_operation_rename_folder),
1477 (modest_mail_operation_get_msg),
1478 (modest_mail_operation_get_msgs_full),
1479 (modest_mail_operation_remove_msg),
1480 (modest_mail_operation_xfer_msgs),
1481 (modest_mail_operation_refresh_folder):
1482 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1484 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1486 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1487 (modest_server_account_set_security):
1488 * src/modest-defs.h: Add comments explaining that our
1489 UI spec means TLS when it says Normal, so these do not look like errors.
1491 * src/modest-tny-account.c:
1492 (modest_tny_account_new_from_server_account): Use the new tinymail
1493 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1494 for TLS. This should fix projects.maemo.org bug NB#58460.
1496 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1498 * src/maemo/easysetup/modest-easysetup-wizard.c:
1499 (create_account): Correct the position of the gconf sanity check warning.
1500 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1501 of using the g_idle_add() hack, because this does not seem to be necessary
1502 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1503 caused by something other than maemo's gconf.
1504 This fixes projects.maemo.org bug #59022.
1506 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1508 * src/modest-account-mgr-helpers.c:
1509 (modest_account_mgr_get_default_account): Do not check that the account
1510 exists if there is no default account (NULL), to fix a runtime warning.
1512 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1514 * src/widgets/modest-folder-view.c: (update_model):
1515 Do not unref the treemodel before we have finished with it.
1516 This prevents a valgrind warning and an occasional crash at startup.
1518 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1520 * libmodest-dbus-client/libmodest-dbus-client.h:
1521 added libmodest_dbus_client_compose_mail()
1522 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1524 added functions needed for SendAsMail() functionality
1525 * src/maemo/modest-msg-edit-window.c:
1526 (modest_msg_edit_window_attach_file_noninteractive):
1527 non interactively attaching files to message edit window
1528 * src/widgets/modest-msg-edit-window.h:
1529 * tests/dbus_api/Makefile.am:
1530 added test_compose_mail.c
1531 * tests/dbus_api/test_compose_mail.c: (main):
1533 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1535 * src/modest-account-view.c:
1536 Fixed bug projects.maemo.org bug NB#59307
1538 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1540 * src/maemo/easysetup/modest-easysetup-wizard.c:
1541 (get_serverport_incoming), (on_before_next), (create_account):
1542 * src/maemo/modest-account-settings-dialog.c:
1543 (modest_account_settings_dialog_set_account_name):
1544 * src/maemo/modest-maemo-utils.c:
1545 (on_camel_account_get_supported_secure_authentication_status),
1546 (on_camel_account_get_supported_secure_authentication),
1547 (on_secure_auth_cancel),
1548 (modest_maemo_utils_get_supported_secure_authentication_methods):
1550 Implemented security authentication for settings and easysetup.
1552 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1554 * src/maemo/modest-main-window.c: (create_details_widget):
1555 Show the total size for memory card accounts too, instead of showing
1556 the name again. Fixes bug projects.maemo.org bug NB#59307.
1558 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1561 * src/modest-tny-simple-folder-store.c:
1562 * src/modest-tny-simple-folder-store.h: Removed.
1564 * src/modest-tny-local-folders-account.h
1565 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1566 for the local-folders maildir, with an extra TnyMergedFolder containing
1567 the folders of the per-account outbox store accounts.
1568 * src/modest-tny-account-store.c: (get_server_accounts):
1569 Add the outboxes to the special local folders account after creating it.
1571 * src/modest-tny-account.c:
1572 (modest_tny_account_new_for_local_folders): Create the derived
1573 account when creating the main local-folders account.
1575 * src/maemo/modest-main-window.c: (create_details_widget),
1576 (modest_main_window_set_contents_style):
1577 Adapted to the use of the derived account instead of the folder store.
1579 * src/modest-ui-actions.c:
1580 (modest_ui_actions_on_folder_selection_changed):
1581 * src/modest-ui-dimming-rules.c:
1582 (modest_ui_dimming_rules_on_new_folder):
1583 * src/widgets/modest-folder-view.c: (text_cell_data),
1584 (icon_cell_data), (filter_row), (update_model),
1585 (get_cmp_rows_type_pos):
1588 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1589 Do not get the priv struct, because no priv struct has been set,
1590 to avoid a runtime warning.
1592 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1593 #ifelse with #else, to fix a warning, to fix the build.
1596 2007-06-05 Christian Kellner <ckellner@openismus.com>
1598 * libmodest-dbus-client/libmodest-dbus-client.c:
1599 Fix small typo in doc (why do you always see them
1600 AFTER committing stuff?)
1603 2007-06-05 Christian Kellner <ckellner@openismus.com>
1605 * libmodest-dbus-client/libmodest-dbus-client.c:
1606 (libmodest_dbus_client_search):
1607 Initialize hit list with NULL. Also set folder list
1608 to "" if NULL was supplied.
1611 2007-06-03 Christian Kellner <ckellner@openismus.com>
1613 * libmodest-dbus-client/libmodest-dbus-client.c:
1614 (modest_search_hit_list_free):
1615 Make it save to call it with NULL.
1617 * src/dbus_api/modest-dbus-callbacks.c:
1618 * src/modest-search.c:
1619 Return full ModestSearchHits as the search result list not TnyHeader
1620 since can't be around withouth the correspoding TnyFolder.
1622 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1624 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1625 Added currently commented code to check for secure auth
1627 * src/maemo/modest-account-settings-dialog.c: (on_response),
1628 (save_configuration), (show_ok):
1629 Fixed projects.maemo.org bugs NB #59248 and #59251
1631 * src/maemo/modest-maemo-utils.c:
1632 (on_camel_account_get_supported_secure_authentication_status),
1633 (on_camel_account_get_supported_secure_authentication),
1634 (modest_maemo_utils_get_supported_secure_authentication_methods):
1635 * src/maemo/modest-maemo-utils.h:
1636 Moved get_supported_secure_authentication() method here to be able
1637 to use it from easysetup wizard.
1639 * src/modest-pair.c: (on_pair_compare_as_string):
1640 Should compare string with first part of pair and not
1641 strcmp pairs which will crash.
1643 * src/modest-protocol-info.c:
1644 (modest_protocol_info_protocol_is_store):
1645 * src/modest-protocol-info.h:
1646 Added modest_protocol_info_get_auth_protocol_name()
1648 2007-06-03 Armin Burgmeier <armin@openismus.com>
1650 * src/modest-mail-operation.c:
1651 (modest_mail_operation_get_msgs_full): Set priv->account also when
1652 only retrieving a single message. This avoids a crash when canceling
1655 (modest_mail_operation_notify_end): Do not explicitely remove the
1656 operation from the queue but only emit the progress_changed signal.
1657 The queue itself listens to that signal to remove the operation when
1658 it is finished. This reduces coupling and removes a potential deadlock
1659 when modest_mail_operation_notify_end() is called from the queue
1660 itself. If that is a problem performance-wise, I would suggest to
1661 implement a status-changed signal or something.
1663 * src/modest-mail-operation-queue.c: Make sure to never call a
1664 function from another file while the queue is locked. This (hopefully)
1665 fixes another deadlock when exiting the application while retrieving
1668 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1670 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1671 Fixed build if libogs is not available
1673 2007-06-03 Christian Kellner <ckellner@openismus.com>
1675 * libmodest-dbus-client/libmodest-dbus-client.h:
1676 * libmodest-dbus-client/libmodest-dbus-client.c:
1677 (libmodest_dbus_client_delete_message):
1678 Implement deletion of messages (Client side).
1680 (modest_search_hit_free),
1681 (modest_search_hit_list_free):
1682 Utility functions to free the result hits.
1684 * src/dbus_api/modest-dbus-api.h:
1685 * src/dbus_api/modest-dbus-callbacks.c:
1686 (on_delete_message),
1687 (modest_dbus_req_handler):
1688 Implement deletion of messages (Server side).
1690 * tests/dbus_api/test_search.c: (main):
1693 * tests/dbus_api/Makefile.am:
1694 * tests/dbus_api/test_delete_message:
1695 Add little test for the message deletion logic
1697 2007-06-03 Armin Burgmeier <armin@openismus.com>
1699 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1700 when the operation queue was not empty. projects.maemo.org bug
1703 2007-06-03 Armin Burgmeier <armin@openismus.com>
1705 * src/widgets/modest-account-view.c
1706 (on_account_default_toggled): Toggle default account column
1707 explicitely instead of waiting for gconf notification (which is
1708 currently ignored). This should fix projects.maemo.org bug NB#56910
1709 for now. It should probably be removed when gconf notifications are
1712 2007-06-03 Christian Kellner <ckellner@openismus.com>
1714 * libmodest-dbus-client/libmodest-dbus-client.c:
1715 Removed debugging spew.
1717 * src/dbus_api/modest-dbus-callbacks.c:
1718 Added debugging info.
1720 * src/modest-search.c:
1721 (modest_search_all_accounts):
1722 Use tny_account_store_get_accounts () on the account store
1723 to get all accounts which is the way to get all accounts.
1725 * tests/dbus_api/test_search.c: (main):
1726 Make it possible to supply the search term on the command line.
1728 2007-06-03 Christian Kellner <ckellner@openismus.com>
1730 * libmodest-dbus-client/libmodest-dbus-client.c:
1731 * libmodest-dbus-client/libmodest-dbus-client.h:
1732 Implement searching for mesages over raw dbus. (Client side)
1734 * src/dbus_api/Makefile.am:
1735 * src/dbus_api/modest-dbus-api.h:
1736 * src/dbus_api/modest-dbus-callbacks.c:
1737 * src/dbus_api/modest-dbus-callbacks.h:
1738 Search framework (Server side). Also implement on_idle_open_message().
1740 * src/maemo/modest-platform.c: (modest_platform_init):
1741 Prepare for raw dbus/osso rpc interaction.
1743 * src/modest-search.h:
1744 Changed minsize from unspecific guint to guint32.
1746 * src/modest-search.c:
1748 Added strange hack which magically made tnymail work.
1750 (modest_search_folder),
1751 (modest_search_account),
1752 (modest_search_all_accounts):
1753 Implement helper functions to search all accounts, specific account
1756 * tests/dbus_api/Makefile.am:
1757 * tests/dbus_api/test_open_message.c:
1758 Read url to open from commandline.
1760 * tests/dbus_api/test_search.c:
1761 Implement small test for dbus search stuff
1763 2007-06-02 Armin Burgmeier <armin@openismus.com>
1765 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1766 include account type and account title. This fixes projects.maemo.org
1769 * src/maemo/modest-account-view-window.c: Set a title for the window.
1771 2007-06-02 Armin Burgmeier <armin@openismus.com>
1773 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1774 incoming and outgoing server name based on email address and server
1775 types as long as the names have not been edited manually. This fixes
1776 projects.maemo.org bug NB#58671.
1778 2007-06-02 Armin Burgmeier <armin@openismus.com>
1780 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1781 server type cannot be changed in future to the incoming details page
1782 when creating an account. This fixes projects.maemo.org bug NB#59029.
1784 2007-06-02 Armin Burgmeier <armin@openismus.com>
1786 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1787 and assigned max width chars so that they wrap instead of being
1788 truncated. Fixes projects.maemo.org bug NB#56126.
1790 2007-06-02 Armin Burgmeier <armin@openismus.com>
1792 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1793 introductory note to the connection specific smtp servers dialog, as
1794 section 8.12 of the email UI specification requires. This fixes
1795 projects.maemo.org bug NB#59212.
1797 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1799 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1800 Check for running mail operations, and offer to cancel them, as per the UI
1801 spec. This fixes projects.maemo.org bug NB#59041 .
1802 However, I suspect that tinymail may still use the network connection
1803 in ways that we cannot detect or cancel. But it should at least adapt to
1804 changes fairly well.
1806 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1808 * src/modest-tny-account-store.c: (recreate_all_accounts),
1809 (get_cached_accounts), (get_server_accounts): Do more sensible
1810 ref-counting of the temporarily-cached outbox accounts list. This seems
1811 to fix a crash when entering the password when the password was wrong.
1813 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1815 * src/gnome/modest-main-window.c: (connect_signals):
1816 * src/modest-tny-account-store.c: (get_password),
1817 (modest_tny_account_store_alert): Added comments and clues and
1818 commented-out code about how we currently fail to deal with connection
1819 errors and wrong passwords, and how we should.
1821 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1823 * src/widgets/modest-retrieve-combo-box.c:
1824 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1825 This fixes projects.maemo.org bug NB#58472 .
1827 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/easysetup/modest-easysetup-wizard.c:
1830 (create_page_complete_easysetup):
1831 (create_page_complete_custom): Correct the last commit,
1832 putting the correct sentences in the correct pages.
1834 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1836 * src/maemo/easysetup/modest-easysetup-wizard.c:
1837 (create_page_complete_custom): Show the second sentence of text
1838 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1841 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1843 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1844 Set the leave-on-server conf key by default. This fixes
1845 projects.maemo.org bug NB#59258 .
1847 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1849 * src/maemo/modest-account-view-window.c:
1850 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1851 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1854 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/easysetup/modest-easysetup-wizard.c:
1857 (create_caption_new_with_asterisk):
1858 * src/maemo/modest-account-settings-dialog.c:
1859 (create_caption_new_with_asterisk):
1860 Uncomment the code to add the asterisk, because they are no longer in the
1861 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1862 (update_incoming_server_title): Add an asterisk here too.
1864 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1866 * src/maemo/modest-maemo-global-settings-dialog.c:
1867 (current_connection): Check that we are even connected before trying to
1868 get the current connection name, to prevent a warning.
1870 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1871 Change the comments because tny_maemo_conic_device_connect() is now meant to
1873 * src/modest-mail-operation.c:
1874 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1875 make sure we have a connection and fail if we can't connect.
1877 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/modest-main-window.c:
1880 (on_account_store_connecting_finished): Do not try to get the
1881 connection ID if we are not really connected. I am surprised that
1882 this signal handler is called when we are not connected.
1884 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1886 * src/modest-error.h:
1887 * src/modest-ui-actions.c:
1888 (modest_ui_actions_get_msgs_full_error_handler):
1889 Renamed an enum, added comments, added an enum
1890 for retrieve-limit errors.
1892 * src/modest-mail-operation.c: (foreach_add_item),
1893 (internal_folder_observer_update), (update_account_thread),
1894 (modest_mail_operation_get_msgs_full):
1895 (modest_mail_operation_update_account),
1896 Added comments about how this works, and some code that should
1897 (but does not) check the retrieve-limit. See the TODO comment.
1899 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1902 Initialize help_id to fix the build. Warnings are good.
1904 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1906 * src/widgets/modest-hbox-cell-renderer.c:
1907 (modest_hbox_cell_renderer_append):
1908 * src/widgets/modest-vbox-cell-renderer.c:
1909 (modest_vbox_cell_renderer_append):
1910 Fix the last commit by doing an extra ref.
1912 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1914 * src/widgets/modest-hbox-cell-renderer.c:
1915 (modest_hbox_cell_renderer_append):
1916 * src/widgets/modest-vbox-cell-renderer.c:
1917 (modest_vbox_cell_renderer_append):
1918 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1919 to fix the build with Maemo Bora.
1920 However, there seems to be a remaining crash, probably due to reference
1923 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1925 * src/modest-tny-account.c:
1926 (modest_tny_account_new_for_local_folders):
1927 Use hildon_file_system_info_async_new() to get a better name for
1928 the memory card account, setting it as the account name.
1929 The timing seems to work, but this is probably
1930 not the best place to do this. See the TODO comment.
1931 * src/maemo/modest-main-window.c: (create_details_widget):
1932 * src/widgets/modest-folder-view.c: (text_cell_data):
1933 Use the tny account name instead of hardcoding a name.
1935 2007-05-30 Christian Kellner <ckellner@openismus.com>
1937 * src/modest-search.c: (modest_search):
1938 Correctly set part_search_func even if we have already parsed
1939 the query and thus a valid OgsTextSearcher object.
1941 2007-05-30 Christian Kellner <ckellner@openismus.com>
1944 Search and check for libogs.
1947 Incooparte the ogs build env.
1949 * src/modest-mime-part-search-stream.c:
1950 * src/modest-mime-part-search-stream.h:
1951 Removed since we do the real searching now in modest-search.c.
1953 * src/modest-search.c:
1954 * src/modest-search.h:
1955 Implement support for ogs. We use that if available and requested
1956 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1957 should now handle the corner case when the search term is spread
1958 across multiple reads.
1959 Also the logic in modest_search () was corrected to search all
1960 requested fields until one is found.
1962 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1964 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1966 * src/modest-init.h:
1967 * src/modest-init.c: Made modest_init_local_folders() take a
1968 path and be public so we can iniitialize maildir folders on
1971 * src/modest-local-folder-info.h:
1972 * src/modest-local-folder-info.c:
1973 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1975 * src/modest-tny-account.c:
1976 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1977 still means the standard local-folders path on the local volume.
1979 * src/modest-tny-account-store.c:
1980 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1981 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1982 all accounts when that happens.
1983 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1984 this too, so it shows up in the treeview.
1986 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/modest-maemo-global-settings-dialog.c:
1989 (current_connection):
1990 * src/widgets/modest-global-settings-dialog.c:
1991 (current_connection_default):
1992 Use the enum values instead of 0, 1 and -1,
1993 to make the code clearer.
1995 * src/modest-account-mgr-helpers.c:
1996 (modest_account_mgr_get_connection_specific_smtp): Make this code
1999 * src/modest-runtime.h:
2000 * src/modest-runtime.c:
2001 Added modest_runtime_remove_all_send_queues().
2002 * src/maemo/modest-main-window.c:
2003 (on_account_store_connecting_finished): Recreate the send queues,
2004 using the appropriate transport accounts for this new connection.
2005 Some futher adapting might be needed if the old send queues are not
2006 automatically stopped at this point.
2008 * src/modest-tny-account-store.c: (get_server_accounts):
2009 Create the connection-specific transport accounts, so that they can
2010 be found later by their ID.
2012 * src/modest-tny-account.h:
2013 * src/modest-tny-account.c:
2014 Added modest_tny_account_new_from_server_account_name().
2015 modest_tny_account_new_from_server_account(): Do not create the
2016 send queues here, because they will be
2017 recreated anyway when the connection changes for the first time.
2019 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-local-folder-info.h:
2022 * src/modest-local-folder-info.c:
2023 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2024 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2025 tbox_folder): Take a modest account name instead of a server TnyAccount,
2026 so we can have per-modest-account rather than per-transport-account
2028 We must make sure that we change or recreate the exisitng send queues
2029 when the connection changes for connection-specific transport accounts.
2031 * src/modest-tny-account-store.c:
2032 (create_per_account_local_outbox_folders): Create outboxed per modest
2033 account, not per transport account.
2035 * src/modest-tny-account.h:
2036 * src/modest-tny-account.c:
2037 (modest_tny_account_get_special_folder): For outboxes, get the
2038 parent modest account name. The account is ignored for other folders.
2039 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2040 modest account name rather than a server TnyAccount.
2042 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-tny-account.c:
2045 (modest_tny_account_new_from_server_account):
2046 Call modest_runtime_get_send_queue() immediately after creating transport
2047 accounts, so that they start trying to send email from the outbox as soon
2048 as possible at startup. This is probably what we want.
2050 * src/modest-mail-operation.c: (update_account_thread):
2051 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2052 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2053 * src/modest-tny-send-queue.h:
2054 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2055 (modest_ui_actions_on_send):
2056 Added comments about how sending works, though it needs some more work.
2058 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2060 * src/modest-tny-account.c:
2061 (modest_tny_account_get_special_folder): Add TODO because this fails when
2062 the network is busy.
2063 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2064 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2065 Do not try to show this window when there is no active account. The UI
2066 specs does not tell us what to do in this case.
2068 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2072 * src/maemo/Makefile.am:
2073 * src/widgets/Makefile.am: Some dist fixes.
2075 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2077 * src/maemo/modest-connection-specific-smtp-window.c:
2078 (on_button_edit): Make the code clearer, to prevent a double free.
2080 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2082 * src/maemo/modest-account-settings-dialog.c:
2083 (modest_account_settings_dialog_set_account_name),
2084 Check the connection-specific smtp servers checkbox if there are any.
2086 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2087 (modest_connection_specific_smtp_edit_window_init):
2088 Start with a suitable port number.
2090 * src/modest-account-mgr-helpers.h:
2091 * src/modest-account-mgr-helpers.c: Added
2092 modest_account_mgr_get_has_connection_specific_smtp().
2094 (modest_account_mgr_set_connection_specific_smtp),
2095 (modest_account_mgr_remove_connection_specific_smtp),
2096 (modest_account_mgr_get_has_connection_specific_smtp),
2097 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2098 connection-specific smtp server accounts in the account, rather than
2099 the server account conf dir.
2101 This fixes bug projects.maemo.org bug NB#58263 .
2103 * src/modest-tny-account-store.c:
2104 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2105 if there are no server accounts yet, to prevent an infinite loop when there
2106 are no accounts. Document that one must be called before the other.
2108 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-account-mgr-helpers.c:
2111 (modest_account_mgr_get_default_account): Make sure that at least
2112 one account is always the default, if there are any enabled accounts.
2113 This is just a sanity check that shouldn't be necessary.
2115 * src/modest-account-mgr-priv.c:
2116 (_modest_account_mgr_account_from_key): Unescape the conf key to
2117 get the real account name. For instance, this is an issue if a space
2118 was in the account name, which can happen because the account name
2119 is generated from the display name.
2120 (_modest_account_mgr_get_account_keyname): Always escape the
2122 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2123 Unescape the conf keys to get the real account names.
2125 For instance, previously the is-default radio button in the accounts
2126 list was not checked for any accounts at first. This fixes that,
2127 and might fix several similar bugs.
2129 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2131 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2132 Removed some debug printfs.
2134 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2136 Modest on-disk outbox directories are now here, for instance:
2137 $HOME/.modest/outboxes/<account-id-1>/outbox
2138 $HOME/.modest/outboxes/<account-id-2>/outbox
2140 $HOME/.modest/local-folders/outbox
2141 so we can have a separate outbox for each account.
2142 But they are shown as one outbox in the GtkTreeView, by using a
2143 TnyMergeFolder in a ModestTnySimpleFolderStore.
2146 * src/modest-tny-simple-folder-store.c:
2147 * src/modest-tny-simple-folder-store.h:
2148 Added ModestTnySimpleFolderStore, used to contain folders from
2149 other folder stores, such as other accounts.
2151 * src/modest-tny-outbox-account.h:
2152 * src/modest-tny-outbox-account.c:
2153 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2154 used for the per-account local outbox folders.
2156 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2157 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2158 only use this (internally) now for the non-outbox local folders.
2160 * src/modest-init.h:
2161 * src/modest-init.c: Added modest_init_one_local_folder(), for
2162 setting up the directory structure for each local folder.
2164 * src/modest-local-folder-info.c:
2165 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2166 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2168 * src/modest-local-folder-info.h:
2169 * src/modest-tny-account-store.c: (on_account_removed),
2170 (on_account_changed), (create_per_account_local_outbox_folders),
2171 (get_server_accounts), (modest_tny_account_store_get_accounts),
2172 (modest_tny_account_store_get_tny_account_by_account),
2173 (modest_tny_folder_store_is_virtual_local_folders):
2175 * src/modest-tny-account.h:
2176 * src/modest-tny-account.c:
2177 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2178 to create an on-disk per-account local outbox folder for each
2180 (create_per_account_local_outbox_folders): Create a local outbox folder
2181 for each transport account.
2182 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2183 for all local folders.
2185 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2186 instead of using g_object_get/set() directly. It is clearer.
2188 (modest_tny_folder_store_get_message_count),
2189 (modest_tny_folder_store_get_local_size
2190 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2191 because we now use these with non-acount folder stores.
2193 (modest_tny_account_get_special_folder),
2194 (modest_tny_account_new_from_server_account),
2195 (modest_tny_account_new_from_account):
2196 (recurse_folders): Adjust to the new outbox system.
2198 * src/modest-tny-folder.h:
2199 * src/modest-tny-folder.c:
2200 (modest_tny_folder_is_local_folder),
2201 (modest_tny_folder_get_local_folder_type),
2202 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2204 * src/widgets/modest-main-window.h:
2205 * src/maemo/modest-main-window.c: (create_details_widget),
2206 (modest_main_window_set_contents_style): Show details for any folder store,
2209 (modest_tny_folder_get_rules):
2210 Remove the const. C does not support constness enough for this.
2212 * src/modest-ui-actions.c:
2213 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2214 make all outboxes appear as one, in the usual local-folders tree node.
2216 (set_active_account_from_tny_account),
2217 (modest_ui_actions_on_folder_selection_changed):
2218 * src/widgets/modest-folder-view.c: (text_cell_data),
2219 (icon_cell_data), (filter_row),
2220 (add_account_folders_to_merged_folder),
2221 (add_account_folders_to_simple_folder_store), (),
2222 (get_cmp_rows_type_pos), (cmp_rows),
2223 (modest_folder_view_set_account_id_of_visible_server_account):
2224 Adjust to the new outbox system, using generic folder stores and folders
2225 in the GtkTreeModel.
2227 2007-05-23 Christian Kellner <ckellner@openismus.com>
2229 * src/modest-mail-operation.c:
2230 (modest_mail_operation_update_account):
2231 Use info->max_size instead of unintialized local var [small
2232 build fix]. (Added TODO to review that change since I don't
2235 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2237 * libmodest-dbus-client/libmodest-dbus-client.c:
2238 (libmodest_dbus_client_compose_mail): function added
2239 * src/dbus_api/modest-dbus-api.h:
2240 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2241 (on_compose_mail): Implementation of the SendAsMail functionality
2243 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2245 * src/modest-account-mgr.c:
2246 (modest_account_mgr_add_server_account): Set the secure-connection
2247 conf key for transport accounts as well as store accounts. I don't know
2248 why the if was there. For instance, this makes sure that we use SSL
2249 for the gmail preset from the easysetup wizard.
2251 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2253 * src/gnome/modest-main-window.c:
2254 (on_account_store_connecting_finished), (connect_signals):
2255 * src/maemo/modest-main-window.c:
2256 (on_account_store_connecting_finished), (connect_signals),
2257 (modest_main_window_new):
2258 Handle TnyAccountStore::connecting-finished instead of
2259 TnyDevice::connection-changed, because we cannot actually perform
2260 operations on accounts until TnyAccountStore has itself responded to
2261 the TnyDevice::connection-changed signal. This prevents a GError from
2263 Do not try to update at startup, because we (at least on scratchbox)
2264 already do an update at startup when the device goes online.
2265 This prevents a GError from tinymail.
2266 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2267 Added TODO about stopping simultaneous operations.
2269 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2272 * src/modest-mail-operation-queue.c:
2273 (modest_mail_operation_queue_remove):
2274 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2275 about where they happened.
2277 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2279 * src/modest-ui-actions.c:
2280 (modest_ui_actions_on_password_requested): Make sure that the remember
2281 output parameter is always TRUE.
2283 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2285 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2286 Show a OK/Cancel dialog if the error is a question, though we still do not
2287 know anything more about what we are asking the user.
2288 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2289 Fix an uninitialized variable (helper). This is a logic error, however.
2291 2007-05-21 Christian Kellner <ckellner@openismus.com>
2293 * src/modest-search.h:
2294 Correct bit shifting in the ModestSearchFlags enum.
2296 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2298 * src/modest-tny-account.c:
2299 (modest_tny_account_new_from_server_account): Do not use the lsub and
2300 check-all hard-coded IMAP options when using POP.
2302 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2304 * src/modest-tny-account.c:
2305 (modest_tny_account_new_from_server_account):
2306 Use NULL for the secure-auth method for POP when Password auth has been
2307 specified by the user, as we already do for IMAP. "auth=Login" causes
2308 an error from camel or the server.
2310 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/modest-account-settings-dialog.c:
2313 (create_page_account_details),
2314 (modest_account_settings_dialog_set_account_name):
2315 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2316 for the leave-on-server checkbox, rathr than just the checkbox, when
2317 the protocol is not POP.
2319 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2321 * src/widgets/modest-account-view.c:
2322 * src/widgets/modest-account-view.h:
2323 Added modest_account_view_select_account() which will be useful later
2324 to asynchronously re-select the edited account.
2326 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-account-settings-dialog.c:
2329 (modest_account_settings_dialog_set_account_name):
2330 Automatically choose the port numbers based on the secure authentication
2331 methods, if they have not been chosen before.
2332 This fixes projects.maemo.org bug NB#56273 .
2334 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2336 * src/maemo/modest-main-window-ui.h:
2337 * src/modest-ui-actions.c:
2338 * src/modest-ui-actions.h:
2339 Connect the Tools/SMTP Servers menu item to
2340 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2341 SMTP servers dialog, as in the UI specification and saves changes when it
2342 is closed. This fixed projects.maemo.org bug NB#56305 .
2344 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2346 * src/maemo/modest-connection-specific-smtp-window.c:
2347 (modest_connection_specific_smtp_window_init):
2348 Use gtk_window_set_default_size() to make this window big enough, so
2349 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2351 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2353 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2355 (modest_connection_specific_smtp_edit_window_init),
2356 Do not try to connect to a combobox signal before the combobox exists.
2357 This fixes the cras in projects.maemo.org bug NB#56288 .
2358 (modest_connection_specific_smtp_edit_window_get_settings):
2359 Remove the server_account_name parameter which was being checked for NULL
2360 though it was not used.
2362 * src/maemo/modest-connection-specific-smtp-window.c:
2363 (modest_connection_specific_smtp_window_fill_with_connections),
2364 (on_button_edit), (modest_connection_specific_smtp_window_init):
2365 Correct the number of treemodel columns to prevent a warning.
2366 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2367 libconic does not work.
2369 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2371 * src/modest-tny-account.c:
2372 (modest_tny_account_new_from_server_account):
2373 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2374 SMTP when "None" was chosen by the user. However, with my SMTP server that
2375 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2378 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2380 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2381 to explain the memory management issue with the ID in the ModestPair.
2383 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2384 (add_sending_page), (modest_account_assistant_finalize):
2385 * src/gnome/modest-gnome-global-settings-dialog.c:
2386 (create_updating_page), (create_composing_page):
2387 * src/gnome/modest-msg-edit-window.c: (get_transports),
2388 (init_window), (modest_msg_edit_window_finalize),
2389 (modest_msg_edit_window_get_msg_data):
2390 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2391 * src/gnome/modest-transport-widget.c:
2392 (modest_transport_widget_finalize), (smtp_configuration):
2393 * src/maemo/modest-maemo-global-settings-dialog.c:
2394 (create_updating_page), (create_composing_page):
2395 * src/maemo/modest-msg-edit-window.c: (get_transports),
2396 (init_window), (modest_msg_edit_window_finalize),
2397 (modest_msg_edit_window_get_msg_data),
2398 (modest_msg_edit_window_free_msg_data):
2399 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2400 (modest_store_widget_finalize):
2401 * src/maemo/modest-transport-widget.c:
2402 (modest_transport_widget_finalize), (smtp_configuration):
2403 * src/modest-main.c: (send_mail):
2404 * src/widgets/modest-combo-box.h:
2405 * src/widgets/modest-global-settings-dialog-priv.h:
2406 * src/widgets/modest-global-settings-dialog.c:
2407 (modest_global_settings_dialog_finalize):
2408 * src/widgets/modest-msg-edit-window.h:
2409 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2410 as long as the combo box, to prevent use of freed memory for the ID.
2412 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2414 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2415 get_accounts(), to make this clearer. Do not check for the enabled gconf
2416 key, because we do not use this for server accounts (at least, not yet).
2417 This allows us to send email again.
2419 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2421 * src/maemo/modest-platform.c:
2422 (on_modest_conf_update_interval_changed), (modest_platform_init):
2423 Only respond to this particular key change. All these strcmp()s cannot be
2426 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2428 * src/maemo/modest-maemo-global-settings-dialog.c:
2429 (current_connection): Prevent a crash in scratchbox when
2430 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2431 * src/maemo/modest-platform.c:
2432 (on_modest_conf_update_interval_changed), (modest_platform_init):
2433 Get the update interval from gconf and reset it when the gconf key changes.
2435 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2437 * src/modest-protocol-info.c:
2438 * src/modest-protocol-info.h: Adde enum-specific get functions,
2439 instead of using a ModestProtocolType enum parameter.
2441 * src/gnome/modest-account-assistant.c:
2442 * src/gnome/modest-store-widget.c:
2443 * src/gnome/modest-store-widget.h:
2444 * src/gnome/modest-transport-widget.c:
2445 * src/gnome/modest-transport-widget.h:
2446 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2447 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2448 * src/maemo/easysetup/modest-easysetup-wizard.c:
2449 * src/maemo/modest-account-settings-dialog.c:
2450 * src/maemo/modest-account-settings-dialog.h:
2451 * src/maemo/modest-store-widget.c:
2452 * src/maemo/modest-store-widget.h:
2453 * src/maemo/modest-transport-widget.c:
2454 * src/maemo/modest-transport-widget.h:
2455 * src/modest-account-mgr-helpers.c:
2456 * src/modest-account-mgr-helpers.h:
2457 * src/modest-account-mgr.c:
2458 * src/modest-account-mgr.h:
2459 * src/modest-tny-account.c:
2460 * src/modest-tny-folder.c:
2461 * src/widgets/modest-account-view.c:
2462 * src/widgets/modest-retrieve-combo-box.c:
2463 * src/widgets/modest-retrieve-combo-box.h:
2464 * src/widgets/modest-secureauth-combo-box.c:
2465 * src/widgets/modest-serversecurity-combo-box.c:
2466 * src/widgets/modest-serversecurity-combo-box.h:
2467 * tests/check_account-mgr.c:
2468 Use the specific functions, and use the re-renamed enum values for GNOME too.
2470 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2472 * src/modest-pair.h:
2473 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2474 so we can get the second based on the first.
2476 * src/maemo/modest-account-settings-dialog.h:
2477 * src/maemo/modest-account-settings-dialog.c:
2478 Added get_supported_secure_authentication_methods(), though it is mostly
2479 commented-out for now until the necessary API is committed to tinymail.
2480 (modest_account_settings_dialog_set_account_name),
2481 (save_configuration): Request the supported authentication methods from the
2482 server, so we can choose a working method.
2484 * src/modest-tny-account-store.h:
2485 * src/modest-tny-account-store.c:
2486 (modest_tny_account_store_get_session): Rename from
2487 tny_account_store_get_session().
2489 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-protocol-info.h: Split the ModestProtocol enum
2492 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2493 There was no need to have these unrelated values in one enum.
2495 * src/: many files: Adapted to changed enum. This makes the code a bit
2496 clearer, and the compiler could catch some errors.
2498 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2500 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2501 Show the detailed internal camel error message when an error happens
2502 during the configuration, so that our testers can give us more clues.
2503 For instance, in projects.maemo.org bug NB#56910 .
2505 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2507 * src/modest-tny-account.c:
2508 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2509 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2511 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2514 * src/maemo/modest-account-settings-dialog.c:
2515 (modest_account_settings_dialog_set_account_name),
2516 (save_configuration): For the incoming secure authentication checkbox,
2517 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2518 the UI specification. PLAIN does not seem to be supported for most IMAP
2519 servers anyway, and I am not sure what it would mean.
2520 However, we probably need to discover which of the secure-authentication
2521 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2522 * src/modest-account-mgr-helpers.c:
2523 (modest_account_mgr_get_server_account_data):
2525 * src/modest-tny-account.c:
2526 (modest_tny_account_new_from_server_account):
2527 Use tny_account_set_mech() to set secure-authentication methods,
2528 with some special-casing for IMAP, based on my observations of how
2531 * src/modest-account-mgr-helpers.h:
2532 * src/modest-account-mgr.c:
2533 * src/modest-defs.h: Comment that the URI is only used for local folders.
2535 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2537 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2538 parameter const, just to be neat.
2539 * src/modest-text-utils.c: (modest_text_utils_inline):
2540 End g_strconcat() with NULL, as its documentation says. This is almost
2541 certainly the cause of my crash at startup on the device. Interestingly,
2542 valgrind doesn't tell us about these errors.
2544 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2546 * scripts/build-packages: Added more precise comments about how to use
2547 this script, though I still get this error:
2548 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2549 error building tinymail
2551 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2553 * src/maemo/modest-main-window.c: (on_account_update):
2554 Very slight cleanup, hoping to make it simpler to discover what causes
2555 a crash here sometimes.
2557 * src/modest-tny-account.c:
2558 (modest_tny_account_new_from_server_account): Set the port. Added
2559 comments about the options and a TODO comment because I need to find out
2560 how to specify the secure authentication method.
2562 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2564 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2565 changed CFlags paths form modest to libmodest
2567 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-account-mgr-helpers.c:
2570 (modest_account_mgr_get_server_account_data),
2571 (modest_account_mgr_free_server_account_data):
2572 * src/modest-account-mgr-helpers.h:
2573 * src/modest-account-mgr.c:
2574 (modest_account_mgr_add_server_account):
2575 * src/modest-defs.h:
2576 * src/modest-tny-account.c:
2577 (modest_tny_account_new_from_server_account):
2578 Determine the options for tny_camel_account_add_option() here,
2579 based on the settings, rather than storing them directly in gconf.
2581 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2583 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2584 Show a more friendly error dialog now that we expect (from the tinymail
2585 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2587 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2589 * src/maemo/modest-main-window.c: (on_account_update): Check that
2590 account_name is not NULL, to prevent a crash at startup that I am
2591 seeing on the N800. I do wonder why it is NULL.
2593 * src/maemo/easysetup/modest-easysetup-wizard.c:
2594 (create_page_user_details):
2595 * src/maemo/modest-account-settings-dialog.c:
2596 (create_page_user_details), (create_page_outgoing):
2597 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2598 (modest_connection_specific_smtp_edit_window_init):
2599 * src/modest-ui-actions.c:
2600 (modest_ui_actions_on_password_requested):
2601 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2602 might do something useful with the on-screen keyboard.
2604 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2606 * src/maemo/modest-main-window.c: (on_account_update):
2607 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2608 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2610 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-tny-account-store.c: (on_account_changed):
2613 Correct the signature of this signal handler.
2615 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2617 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2618 Show a HildonNote instead of a GtkDialog for Maemo.
2620 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2622 * src/widgets/modest-account-view.h:
2623 * src/widgets/modest-account-view.c: (on_account_changed),
2624 (on_account_removed). Added a boolean flag, set/unset by
2625 modest_account_view_block_conf_updates(),
2626 modest_account_view_unblock_conf_updates() to prevent unnecessary
2627 updates, but this is not very useful because the gconf notifications are
2628 so delays (maybe only on Maemo Bora).
2629 So auto-updating is turned off, and these functions do an explicit
2630 update when necessary.
2631 However, something else is still doing too much work when adding/removing
2632 accounts, probably in another part of the application.
2634 * src/maemo/modest-account-view-window.c:
2635 (on_delete_button_clicked), (on_edit_button_clicked),
2636 (on_new_button_clicked): Use the new functions.
2638 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2640 * src/modest-account-mgr-helpers.c:
2641 (modest_account_mgr_set_first_account_as_default):
2642 Sort the list of names alphabetically-by-title, so we choose the first one
2644 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2645 alphabetically by the title.
2647 This fixes projects.maemo.org bug NB#56418 .
2649 * src/modest-account-mgr-priv.c:
2650 (_modest_account_mgr_account_from_key):
2651 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2652 avoid a valgrind error, and possible random behaviour.
2654 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2656 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2657 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2658 tinymail documentation to say that this can be expected.
2659 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2660 pretty, and should not happen, but I would prefer to know when it does.
2662 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2664 * configure.ac: When using the older hildon version, probably on Bora,
2665 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2667 * src/widgets/modest-attachment-view.c:
2668 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2671 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2673 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2674 Implemented the prototype. Can be tested with
2675 tests/dbus_api/test_open_message:
2677 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2679 * src/modest-tny-account-store.c:
2680 (modest_tny_account_store_instance_init), (get_password):
2681 * src/modest-ui-actions.c:
2682 (modest_ui_actions_on_password_requested):
2683 Do not store the password in gconf, because this function is called
2684 for non-remembered passwords. Actually use the cached (in the hash map)
2685 password instead of releasing it.
2686 The password will now not be remembered if it is asked via the protected
2687 password dialog, as per the UI spec.
2689 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2691 * src/modest-defs.h:
2692 * src/modest-account-mgr-helpers.h:
2693 * src/modest-account-mgr-helpers.c:
2694 Added modest_server_account_get_username_has_succeeded(),
2695 modest_server_account_set_username_has_succeeded().
2696 (modest_server_account_set_username),
2697 Reset the has-succeeded flag if the username changes.
2699 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2700 * src/maemo/modest-connection-specific-smtp-window.c:
2701 (modest_connection_specific_smtp_window_save_server_accounts):
2702 Use modest_server_account_set_username() instead of using
2703 modest_conf_set_string() directly, so that the has-succeeded flag is always
2706 * src/modest-ui-actions.c:
2707 (modest_ui_actions_on_password_requested): Dim the username entry if
2708 the username has ever worked, as per the UI spec.
2710 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2712 * src/modest-tny-account-store.c: (get_password):
2713 * src/modest-ui-actions.c:
2714 (modest_ui_actions_on_password_requested):
2715 Allow the username to be changed too, though there is more work to
2716 be done on exactly how this behaves.
2718 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2720 * src/modest-account-mgr-helpers.h:
2721 * src/modest-account-mgr-helpers.c:
2722 Added modest_account_mgr_get_display_name(),
2723 modest_server_account_get_username(),
2724 modest_server_account_set_username(),
2725 modest_server_account_set_password(),
2726 modest_server_account_get_hostname() functions so we do not need to
2727 use the conf API directly.
2729 * src/maemo/modest-main-window.c: (connect_signals):
2730 Actually connect ot the ModestAccountStore::request-password signal,
2731 so that we show the dialog when the password is requested by Tinymail,
2732 for isntance if it is empty.
2734 * src/modest-marshal.list:
2735 * src/modest-tny-account-store.c:
2736 (modest_tny_account_store_class_init), (get_password),
2737 (modest_tny_account_store_alert):
2738 * src/modest-tny-account-store.h:
2739 * src/modest-ui-actions.h:
2740 * src/modest-ui-actions.c:
2741 (modest_ui_actions_on_password_requested):
2742 Change the signal parameters, so it is obvious that we are providing
2743 the non human-readable server name, and receiving both the username
2744 and password, though changing of the username is not yet implemented.
2745 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2746 for the GNOME version.
2748 This should fix the projects.maemo.org bug NB#56209, though it does not
2749 work on Bora, because the gconf_client_get() for the password fails
2750 immediately after we save it with gconf_client_set().
2752 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2755 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2756 caused an undefined symbol error:
2757 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2759 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2761 * src/modest-tny-account-store.c:
2762 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2763 using a GError instead of a string message, so we can translate it in
2766 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/modest-address-book.c:
2769 (modest_address_book_check_names):
2770 * src/maemo/modest-msg-view-window.c:
2771 (modest_msg_view_window_clipboard_owner_change):
2772 * src/modest-init.c: (modest_init_init_ui):
2773 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2774 (update_folders_cb), (modest_mail_operation_update_account):
2775 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2776 (modest_ui_actions_on_msg_attachment_clicked),
2777 (modest_ui_actions_on_msg_recpt_activated):
2778 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2779 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2780 (modest_msg_view_search_next):
2781 * src/widgets/modest-recpt-editor.c:
2782 (modest_recpt_editor_on_button_release_event),
2783 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2784 g_message(). At this point we should only be seeing interesting errors on
2785 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2787 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2789 (modest_wizard_dialog_force_title_update):
2790 * src/maemo/easysetup/modest-wizard-dialog.h:
2791 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2792 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2793 can update the title when appropriate. Otherwise the title is wrong if the
2794 pages are added after adding the notebook to the dialog.
2795 This must be a problem in HildonWizardDialog too.
2796 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2798 * src/maemo/easysetup/modest-easysetup-wizard.c:
2799 (create_subsequent_customsetup_pages),
2800 (create_subsequent_easysetup_pages):
2801 Call modest_wizard_dialog_force_title_update() so that the title is
2802 correct even with GTK+ < 2.10.
2803 This fixes projects.maemo.org bug NB#56145 .
2805 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2807 * src/maemo/modest-platform.c:
2808 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2809 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2812 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2814 * src/widgets/modest-window.h:
2815 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2816 and modest_window_save_state(), which invokes it.
2818 * src/widgets/modest-window-mgr.h:
2819 * src/widgets/modest-window-mgr.c:
2820 Added modest_window_mgr_save_state_for_all_windows(), which calls
2821 the save_state vfunc on all registered windows, if implemented.
2823 * src/gnome/modest-msg-edit-window.c:
2824 * src/gnome/modest-msg-view-window.c:
2825 * src/maemo/modest-msg-edit-window.c:
2826 * src/maemo/modest-msg-view-window.c:
2827 * src/maemo/modest-main-window.c:
2828 Specify the existing save_settings functions as implementations of
2829 ModestWindow::save_state_func().
2831 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2832 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2833 enabling hibernation, for instance.
2835 We may need to do the same thing for restoring settings.
2838 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2840 * src/widgets/modest-window-mgr.c:
2841 * src/widgets/modest-window-mgr.h:
2842 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2843 modest_window_mgr_get_hibernation_is_prevented().
2845 * src/maemo/modest-main-window.c:
2846 (on_hildon_program_is_topmost_notify): Prevent hibernation
2847 (possible when the application goes to the background in the WM),
2848 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2850 * src/maemo/easysetup/modest-easysetup-wizard.c:
2851 (modest_easysetup_wizard_dialog_init):
2852 * src/maemo/modest-account-settings-dialog.c:
2853 (modest_account_settings_dialog_init):
2854 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2855 (modest_connection_specific_smtp_edit_window_init):
2856 * src/maemo/modest-connection-specific-smtp-window.c:
2857 (modest_connection_specific_smtp_window_init):
2858 * src/maemo/modest-signature-editor-dialog.c:
2859 (modest_signature_editor_dialog_init):
2860 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2861 prevent hibernation while any of these account settings dialogs are open.
2863 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2865 * src/maemo/Makefile.am:
2866 * src/maemo/modest-osso-state-saving.c:
2867 * src/maemo/modest-osso-state-saving.h: Added
2868 modest_osso_load_state() and modest_osso_save_state() though they do
2869 nothing now. They should iterate through all the open windows and load/save
2871 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2872 save state when closing.
2874 * src/maemo/modest-main-window.c:
2875 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2876 Add a notification handler for the HildonProgram::is-topmost property,
2877 so we can allow hibernation when the application goes into the background.
2878 But we still need to detect when the accounts setup windows are open so
2879 we can stop hibernation when they are open.
2880 To do this, I also added the main window the HildonProgram. This might have
2881 other side-effects/benefits, and should maybe be done for other windows.
2883 * src/maemo/modest-osso-autosave-callbacks.h:
2884 * src/maemo/modest-osso-autosave-callbacks.c:
2885 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2886 though it does not do anything yet, and we might never need this to do
2887 anything. For instance, we already save drafts.
2889 * src/maemo/modest-platform.c: (modest_platform_init):
2890 Specify the libosso auto-save callback.
2892 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2894 * src/maemo/modest-platform.c:
2895 (modest_platform_set_update_interval):
2896 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2897 aparently stays valid between application instances, so we can use this
2898 to remove and reset it later. According to a maemo-developers email from
2901 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2903 * configure.ac: Depend on libalarm for Maemo.
2905 * src/dbus_api/modest-dbus-api.h:
2906 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2907 (on_send_receive), (modest_dbus_req_handler):
2908 Handle a SEND_RECEIVE D-Bus method.
2910 * libmodest-dbus-client/libmodest-dbus-client.c:
2911 (libmodest_dbus_client_send_and_receive):
2912 * libmodest-dbus-client/libmodest-dbus-client.h:
2913 Add C convenience functions for calling the new D-Bus method.
2915 * src/modest-platform.h:
2916 * src/gnome/modest-platform.c:
2917 * src/maemo/modest-platform.c:
2918 Added modest_platform_set_update_interval(), which uses the
2919 alarmd API on Maemo.
2920 (modest_platform_init),
2921 Call modest_platform_set_update_interval(), using a hard-coded
2922 interval for now (until the global settings dialog is implemented),
2923 though I am not sure that this makes sense yet.
2925 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2927 * src/dbus_api/modest-dbus-callbacks.c:
2928 (modest_osso_cb_hw_state_handler):
2929 * src/dbus_api/modest-dbus-callbacks.h:
2930 * src/maemo/modest-platform.c: (modest_platform_init):
2931 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2932 in case this has some effect on the ability for Maemo to ping the
2935 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2937 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2938 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2939 warning. It is probably a logic error, but I need to fix the build.
2941 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2943 * src/modest-account-mgr.h:
2944 * src/modest-account-mgr.c:
2945 (modest_account_mgr_account_names): Add a gboolean enabled_only
2946 parameter, so we can get lists of onlt the enabled accounts.
2948 (modest_account_mgr_add_account),,
2949 (modest_account_mgr_account_with_display_name_exists):
2950 * src/maemo/modest-msg-edit-window.c: (get_transports):
2951 * src/modest-account-mgr-helpers.c:
2952 (modest_account_mgr_set_first_account_as_default):
2953 * src/modest-init.c: (init_default_account_maybe):
2954 * src/modest-tny-account-store.c: (get_accounts):
2955 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2956 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2957 * tests/check_account-mgr.c: (START_TEST):
2958 Provide the extra parameter, as appropriate.
2960 * src/widgets/modest-account-view.c: (update_account_view):
2961 Do not show disabled accounts (meaning that there is no way to
2962 enable/disable accounts in the UI (the feature is not in our UI
2963 specification), so we can use this internally only to mark unfinished
2964 or temporary account data.
2966 * src/maemo/easysetup/modest-easysetup-wizard.c:
2967 (create_account): Add boolean enable parameter, so we can specify FALSE
2968 to create the temporary account.
2969 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2970 (on_before_next): When finishing, when there is a temporary account, just
2972 Also, use a timeout to delay the showing of the dialog until gconf is likely
2973 to return correct information, due to a maemo gconf bug that is fixed in
2974 osso 1.1, but not yet in Bora.
2975 However, the dialog stays on screen after it is destroyed.
2977 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2978 for invalid data when cancelling. Use a hildon note instead of a dialog
2979 to complain about invalid data. Do not show the account-saved note if the
2980 account is disabled (a temporary account that will not really be saved for use
2983 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2985 * src/modest-account-mgr-helpers.h:
2986 * src/modest-account-mgr-helpers.c:
2987 Added modest_account_mgr_unset_default_account(),
2988 Added modest_account_mgr_set_first_account_as_default().
2990 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2991 If it was the default account, unset the default account name.
2993 * src/maemo/modest-account-view-window.c:
2994 (on_delete_button_clicked): If it was the default account,
2995 set the first remaining account as the default instead.
2997 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2998 a NULL account or a NULL default account, to prevent a crash. This should
2999 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3002 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3004 * src/widgets/modest-recpt-editor.c:
3005 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3006 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3007 TODO comment for this. This fixes the build.
3009 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3010 be the best place for it. This will in future update all auto-update accounts,
3011 rather than just the current/default account, when that gconf key exists.
3012 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3013 if there are no accounts, before calling do_send_receive().
3014 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3016 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3017 * src/maemo/modest-main-window-ui.h:
3018 * src/maemo/modest-main-window.c: (on_connection_changed),
3019 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3020 directly, becaue the signal handler does more.
3022 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3024 * src/modest-account-mgr-helpers.c:
3025 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3026 for the case that the account does not exist.
3028 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3029 (equivalent to the modest account name) rather than the tinymail account name
3030 (equivalent to the modest account title - human readable) to get the account data.
3031 Check for null account data to prevent the crash, and add a TODO comment saying that
3032 this needs fixing because it is using the server account name instead of the account name.
3034 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3036 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3037 * src/maemo/modest-account-settings-dialog.c: (show_error),
3039 Use hildon_note_new_information() for informative and error messages,
3040 which seems to be expected for Maemo applications (no documentation that I know of
3041 says this). I am surprised that there is no distinction between info and error
3044 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3046 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3047 it is easy to find where this is used.
3049 * src/maemo/easysetup/modest-easysetup-wizard.c:
3050 (create_page_welcome), (create_page_account_details),
3051 (create_page_user_details), (create_page_complete_easysetup),
3052 (create_page_custom_incoming), (create_page_custom_outgoing),
3053 (create_page_complete_custom):
3054 * src/maemo/modest-account-settings-dialog.c:
3055 (create_page_account_details), (create_page_user_details),
3056 (create_page_incoming), (create_page_outgoing):
3057 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3058 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3059 (modest_connection_specific_smtp_edit_window_init):
3060 * src/maemo/modest-connection-specific-smtp-window.c:
3061 (modest_connection_specific_smtp_window_init):
3062 * src/maemo/modest-signature-editor-dialog.c:
3063 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3064 and scrolling policy as per the Email Application Layout Guide, if I have
3067 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3069 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3070 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3071 which were empty, because these vfuncs have been removed from TnyAccountStore.
3072 This fixes the build.
3074 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3076 * src/maemo/modest-main-window.c:
3077 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3078 showing/hiding it. Added TODO because it probably should not be NULL.
3079 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3080 because unnecessary g_warnings() make degugging difficult.
3082 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3084 * src/maemo/modest-msg-edit-window.c:
3085 (modest_msg_edit_window_select_color),
3086 (modest_msg_edit_window_select_background_color): 2 const corrections and
3087 moving 2 #endifs before closing brackets, to fix the build.
3089 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3091 * src/maemo/easysetup/modest-easysetup-wizard.h:
3092 * src/maemo/easysetup/modest-easysetup-wizard.c:
3093 (modest_easysetup_wizard_dialog_finalize),
3094 (on_button_edit_advanced_settings), (create_page_complete_custom),
3095 (on_response), (create_account):
3096 Implement the Advanced Settings edit button, by saving the account information,
3097 for the Advanded Settings dialog to use directly from gconf, and removing it
3098 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3099 Bug #5533 in the projects.maemo.org bugzilla.
3101 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3103 * src/maemo/modest-msg-view-window.c:
3104 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3105 when opening a message window.
3107 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3109 * src/maemo/easysetup/modest-easysetup-wizard.c:
3110 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3113 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3114 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3115 gconf settings. I probably added more checks than necessary, but that is safer.
3117 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3118 variable to fix the build, but this seems to be used when it is still NULL.
3120 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-platform.h:
3123 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3124 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3125 * src/modest-main.c: Implement this function so we can avoid using
3126 maemo-specific API from cross-platform code.
3128 * src/modest-tny-account-store.c:
3129 (get_smtp_specific_transport_account_for_open_connection):
3130 * src/modest-ui-actions.c: (check_for_connection),
3131 (modest_ui_actions_on_item_not_found):
3132 Use modest_platform_connect_and_wait() and put #idefs around other
3133 maemo-specific code, because only maemo currently has a way to
3134 identify connection names.
3136 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3138 * src/modest-tny-account-store.h:
3139 * src/modest-tny-account-store.c:
3140 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3141 the connection-specific SMTP server settings in the configuration.
3143 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3145 * src/maemo/modest-main-window.c: (on_connection_changed),
3147 * src/modest-main.c: (main), (start_ui), (send_mail):
3148 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3149 that is what is intended.
3151 * src/modest-ui-actions.c: (action_send), (action_receive),
3152 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3153 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3154 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3155 SMTP server is used when it is specified.
3157 (modest_ui_actions_on_send_receive):
3158 Check that a connection is open before proceeding.
3159 Receive and then send, instead of vice-versa, as per the specification.
3161 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3163 * src/modest-mail-operation.c:
3164 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3165 though I guess it should be something other than NULL.
3167 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3169 * src/maemo/easysetup/modest-easysetup-wizard.c:
3170 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3171 combo twice, to avoid an g_warning and to make it visible again.
3172 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3173 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3174 (already intended) dereference when detaching, because we then recreate the menu.
3175 But I am not sure why the warning was happening, and it is possible that this is a memory
3178 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3180 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3181 and uri_parse_mailto() utility functions.
3182 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3184 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3186 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3188 * src/dbus_api/modest-dbus-api.h:
3189 * src/dbus_api/modest-dbus-callbacks.c:
3190 Use an idle callback to execute the modest code in the application's own thread.
3191 Remove the helloworld example method.
3192 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3193 parsed, and the open-message method is not implemented because this is not yet implemented in
3195 * libmodest-dbus-client/libmodest-dbus-client.c:
3196 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3197 (libmodest_dbus_client_open_message):
3198 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3200 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3201 body without crashing.
3203 * tests/dbus_api/Makefile.am:
3204 * tests/dbus_api/test_mail_to.c:
3205 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3207 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3209 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3210 Added file to fix the build. Sorry.
3212 * src/dbus_api/Makefile.am:
3213 * src/dbus_api/modest-dbus-api.h:
3214 * src/dbus_api/modest-dbus-callbacks.h:
3215 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3216 (modest_dbus_req_handler):
3217 Put constants in a separate header so it can be reused by the
3218 client library, without duplication
3220 * libmodest-dbus-client/Makefile.am:
3221 * libmodest-dbus-client/libmodest-dbus-client.c:
3222 (libmodest_dbus_client_call_helloworld),
3223 (libmodfest_dbus_client_send_mail),
3224 (libmodfest_dbus_client_mailto),
3225 (libmodfest_dbus_client_open_message):
3226 * libmodest-dbus-client/libmodest-dbus-client.h:
3227 (Partly) Implement a send_mail D-Bus method.
3229 * tests/dbus_api/Makefile.am:
3230 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3231 the send_email D-Bus method.
3233 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3237 * libmodest-dbus-client/Makefile.am:
3238 * libmodest-dbus-client/libmodest-dbus-client.c:
3239 * libmodest-dbus-client/libmodest-dbus-client.h:
3240 * tests/dbus_api/Makefile.am:
3241 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3242 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3244 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/easysetup/modest-easysetup-wizard.c:
3247 (create_page_account_details):
3248 * src/maemo/modest-account-settings-dialog.c:
3249 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3250 widgets, because this might not be the default in future versions of the Maemo GTK+.
3251 However, I can not not get capitalization to work even in a simple test case.
3253 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3255 * src/maemo/easysetup/modest-easysetup-wizard.c:
3256 (create_page_custom_incoming), (create_page_custom_outgoing):
3257 * src/maemo/modest-account-settings-dialog.c:
3258 (create_page_account_details), (create_page_incoming),
3259 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3260 instead of using gtk_check_button_with_label(), so they are aligned like the other
3261 widgets, as per the UI spec.
3263 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3265 * src/maemo/easysetup/modest-easysetup-wizard.c:
3266 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3267 * src/widgets/modest-validating-entry.c:
3268 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3269 Modest prefix instead of an EasySetup prefix.
3271 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3273 * src/widgets/modest-validating-entry.h:
3274 * src/widgets/modest-validating-entry.c: (on_insert_text),
3275 Added easysetup_validating_entry_set_max_func(), used to set a callback
3276 to call when the max number of characters is reached. GtkEntry has a max-length
3277 already but is silent about it.
3279 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3280 (create_page_account_details), (create_page_user_details),
3282 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3283 (create_page_account_details), (create_page_user_details),
3284 (create_page_outgoing):
3285 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3286 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3287 the UI spec, when the user tries to enter more than the max number of characters.
3289 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/easysetup/modest-easysetup-wizard.c:
3292 (create_page_user_details), (create_page_custom_incoming),
3293 (create_page_custom_outgoing):
3294 * src/maemo/modest-account-settings-dialog.c:
3295 (create_page_user_details), (create_page_incoming),
3296 (create_page_outgoing):
3297 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3298 (modest_connection_specific_smtp_edit_window_init):
3299 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3300 not appropriate. Bad Maemo-specific defaults!.
3302 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3304 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3305 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3306 (modest_signature_editor_dialog_set_settings):
3307 Disable the label and textview when the checkbox is disabled, and use the
3308 specified (UI spec) default signature text.
3310 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3312 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3313 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3315 * src/modest-defs.h:
3316 * src/modest-account-mgr-helpers.h:
3317 * src/modest-account-mgr-helpers.c:
3318 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3320 * src/maemo/Makefile.am:
3321 * src/maemo/modest-signature-editor-dialog.c:
3322 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3325 * src/maemo/modest-account-settings-dialog.h:
3326 * src/maemo/modest-account-settings-dialog.c:
3327 (modest_account_settings_dialog_finalize), (on_button_signature),
3328 (save_configuration): Use the new dialog when the Edit button is pressed, and
3329 save the changes if necessary, as per the UI spec.
3331 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3333 * src/maemo/Makefile.am:
3334 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3335 based on maemo-develoers email from Dirk.
3337 * src/maemo/easysetup/modest-easysetup-wizard.c:
3338 (create_page_welcome), (create_page_account_details),
3339 (create_page_user_details), (create_page_complete_easysetup),
3340 (create_page_custom_incoming), (create_page_custom_outgoing),
3341 (create_page_complete_custom),
3342 (modest_easysetup_wizard_dialog_init):
3343 * src/maemo/modest-account-settings-dialog.c:
3344 (create_page_account_details), (create_page_user_details),
3345 (create_page_incoming), (create_page_outgoing),
3346 (modest_account_settings_dialog_init):
3347 * src/maemo/modest-connection-specific-smtp-window.c:
3348 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3350 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3352 * src/maemo/easysetup/modest-easysetup-wizard.c:
3353 (create_page_account_details), (create_page_custom_outgoing),
3354 (create_page_complete_custom):
3355 * src/maemo/modest-account-settings-dialog.c:
3356 (create_page_user_details), (create_page_incoming),
3357 (create_page_outgoing):
3358 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3359 (modest_connection_specific_smtp_edit_window_init):
3360 Use the correct (UI spec) port min/max, and use horizontal separators,
3363 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3365 * src/maemo/easysetup/modest-easysetup-wizard.c:
3366 (set_default_custom_servernames):
3367 * src/maemo/modest-account-settings-dialog.c:
3368 (create_page_incoming), (on_combo_outgoing_security_changed),
3369 (on_combo_incoming_security_changed), (create_page_outgoing),
3370 (modest_account_settings_dialog_set_account_name),
3371 (save_configuration):
3372 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3373 (on_combo_security_changed),
3374 (modest_connection_specific_smtp_edit_window_init),
3375 (modest_connection_specific_smtp_edit_window_set_connection),
3376 (modest_connection_specific_smtp_edit_window_get_settings):
3377 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3380 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3383 * src/maemo/easysetup/modest-easysetup-wizard.c:
3384 (create_page_custom_outgoing), (create_page_complete_custom):
3385 * src/maemo/modest-account-settings-dialog.c:
3386 (create_page_user_details), (create_page_outgoing):
3387 * src/maemo/modest-account-view-window.c: (button_box_new):
3388 Use changed logical IDs as per the most recent UI spec:
3389 mcen_bd_emailsetup_edit -> mcen_bd_edit
3390 mcen_bd_emailsetup_delete -> mcen_bd_delete
3391 mcen_bd_emailsetup_close -> mcen_bd_close
3393 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3397 * src/dbus_api/Makefile.am:
3398 * src/dbus_api/modest-dbus-callbacks.c:
3399 * src/dbus_api/modest-dbus-callbacks.h:
3400 * src/maemo/modest-platform.c: (modest_platform_init):
3401 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3403 * tests/Makefile.am:
3404 * tests/dbus_api/Makefile.am:
3405 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3407 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3409 * src/maemo/modest-account-settings-dialog.c:
3410 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3411 Removed unnecessary includes.
3413 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3415 * src/maemo/easysetup/modest-easysetup-wizard.c:
3416 * src/maemo/modest-account-settings-dialog.c:
3417 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3418 * src/widgets/Makefile.am:
3419 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3420 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3421 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3422 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3423 * src/widgets/modest-secureauth-combo-box.c:
3424 * src/widgets/modest-secureauth-combo-box.h:
3425 * src/widgets/modest-serversecurity-combo-box.c:
3426 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3427 made the GObject names more consistent with the rest of the Modest code.
3429 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/easysetup/Makefile.am:
3432 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3433 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3434 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3435 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3436 * src/maemo/easysetup/modest-easysetup-wizard.c:
3437 * src/maemo/easysetup/modest-validating-entry.c:
3438 * src/maemo/easysetup/modest-validating-entry.h:
3439 * src/maemo/modest-account-settings-dialog.c:
3440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3441 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3442 widgets/ because they are used outside of easysetup too. After checking in,
3443 svn will allow me to rename them too.
3445 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3447 * src/gnome/modest-msg-edit-window.c:
3448 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3449 linker error, to fix the build on the GNOME platform.
3450 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3451 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3452 ifdefed out to avoid a warning.
3454 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3456 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3457 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3458 some alternative for GTK+ 2.6.
3460 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3462 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3464 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3465 specified for EmailAccountsDialog in UI spec.
3467 * src/maemo/easysetup/modest-easysetup-wizard.c:
3468 * src/maemo/easysetup/modest-easysetup-wizard.h:
3469 * src/maemo/modest-account-settings-dialog.c:
3470 * src/maemo/modest-account-settings-dialog.h:
3471 Reuse a member window widget for the connection-specific SMTP server accounts,
3472 so we can tell it to create/save the accounts only if we actually save changes.
3474 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3475 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3476 (modest_connection_specific_smtp_edit_window_get_settings):
3477 Return a struct instance for temporarily remembering the entered data.
3479 * src/maemo/modest-connection-specific-smtp-window.h:
3480 * src/maemo/modest-connection-specific-smtp-window.c:
3481 (modest_connection_specific_smtp_window_finalize),
3482 (modest_connection_specific_smtp_window_fill_with_connections),
3484 (modest_connection_specific_smtp_window_save_server_accounts),
3485 (update_model_server_names): Do not actually save data until asked,
3486 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3488 (on_selection_changed),
3489 (modest_connection_specific_smtp_window_init): Disable the edit
3490 button when nothing is selected.
3492 * src/modest-account-mgr-helpers.c:
3493 * src/modest-account-mgr-helpers.h:
3494 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3497 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3499 * src/modest-account-mgr-helpers.h:
3500 * src/modest-account-mgr-helpers.c:
3501 (modest_account_mgr_get_unused_account_name),
3502 (modest_account_mgr_get_unused_account_display_name): Added these
3503 utility functions, to avoid code duplication.
3505 * src/maemo/easysetup/modest-easysetup-wizard.c:
3506 (create_page_account_details), (create_account):
3507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3508 (on_combo_security_changed),
3509 (modest_connection_specific_smtp_edit_window_init),
3510 (modest_connection_specific_smtp_edit_window_save_settings):
3511 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3512 * src/maemo/modest-connection-specific-smtp-window.c:
3513 (modest_connection_specific_smtp_window_finalize),
3514 (modest_connection_specific_smtp_window_fill_with_connections),
3515 (on_button_edit), (modest_connection_specific_smtp_window_init):
3516 * src/maemo/modest-connection-specific-smtp-window.h:
3517 Implementing saving of connection-specific server accounts.
3519 But I need to refactor this so we can save the data for each
3520 possible connection-specific account and only actually create the server accounts
3521 when the easysetup finished, or the OK button is pressed on the account settings
3524 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3526 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3527 (on_combo_security_changed):
3528 (modest_connection_specific_smtp_edit_window_init):
3529 Auto-fill the port number as in the account settings.
3531 (modest_connection_specific_smtp_edit_window_set_connection):
3532 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3533 * src/maemo/modest-connection-specific-smtp-window.c:
3534 (fill_with_connections), (on_button_edit),
3535 (modest_connection_specific_smtp_window_init):
3536 Turn the edit window into a dialog to simplify the code, and
3537 set a WM hint as in a GtkDialog, because only a popup can be on top of
3538 another window in Maemo, and popups usually have no WM decoration.
3540 * src/modest-defs.h:
3541 * src/modest-account-mgr-helpers.c:
3542 (modest_account_mgr_set_connection_specific_smtp),
3543 (modest_account_mgr_remove_connection_specific_smtp),
3544 (modest_account_mgr_get_connection_specific_smtp):
3545 * src/modest-account-mgr-helpers.h: Some functions to write the
3546 connection-specific SMTP server information. Not yet used.
3549 * src/widgets/modest-folder-view.c: (text_cell_data):
3550 Fix a warning about an uninitialized variable.
3551 (on_configuration_key_changed): Put an #ifdef around the use
3552 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3554 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3556 * src/maemo/modest-account-settings-dialog.h:
3557 * src/maemo/modest-account-settings-dialog.c:
3558 Added connect_for_modified() utility function to mark the new modified boolean.
3560 (create_page_account_details), (create_page_user_details),
3561 (create_page_incoming), (create_page_outgoing), (on_response),
3562 (modest_account_settings_dialog_init),
3563 (modest_account_settings_dialog_set_account_name):
3564 Only warn about unsaved changes when there are actually unsaved changes.
3566 * src/modest-account-mgr-helpers.c:
3567 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3568 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3569 to get the data from there in future.
3571 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3573 * src/modest-defs.h:
3575 * src/modest-account-mgr-helpers.h:
3576 * src/modest-account-mgr-helpers.c:
3577 Store the security account setting in a single conf key instead of using
3578 the options list, so that the list is left for just the to-be-removed camel hack,
3579 and because gconf_client_set_list() is failing for some reason.
3581 * src/modest-account-mgr.c:
3582 (modest_account_mgr_add_server_account):
3583 * src/maemo/modest-account-settings-dialog.c:
3584 (modest_account_settings_dialog_set_account_name),
3585 (save_configuration): Use the renamed functions.
3588 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3590 * src/widgets/Makefile.am:
3591 * src/widgets/modest-limit-retrieve-combo-box.c:
3592 * src/widgets/modest-limit-retrieve-combo-box.h:
3593 * src/widgets/modest-retrieve-combo-box.c:
3594 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3595 the account settings dialog.
3597 * src/modest-defs.h:
3598 * src/modest-account-mgr-helpers.h:
3599 * src/modest-account-mgr-helpers.c:
3600 (modest_server_account_get_option_secure_auth),
3601 (modest_server_account_set_option_secure_auth):
3602 * src/modest-account-mgr.c:
3603 (modest_account_mgr_add_server_account):
3604 Use the existing AUTH_MECH conf key for the secure-auth setting,
3605 instead of putting it in the list options, because this was actually used already.
3607 * src/maemo/modest-account-settings-dialog.c:
3608 (create_page_account_details),
3609 (modest_account_settings_dialog_set_account_name),
3610 (save_configuration):
3611 * src/maemo/modest-account-settings-dialog.h:
3612 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3613 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3615 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3618 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3619 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3621 * src/modest-defs.h:
3622 * src/maemo/modest-account-settings-dialog.c:
3623 (create_page_incoming), (on_combo_outgoing_security_changed),
3624 (on_combo_incoming_security_changed), (create_page_outgoing),
3625 (modest_account_settings_dialog_set_account_name),
3626 (save_configuration): Load/Save the port number, and change it when the
3627 security combo changes, to suitable defaults.
3629 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3631 * src/modest-account-mgr.c:
3632 (modest_account_mgr_add_server_account): Set the security and secure-auth
3633 options, and add a comment saying that the other camel-specific options should be
3636 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3638 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3640 * src/modest-tny-account-store.c: (account_list_free),
3641 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3642 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3645 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3647 * src/modest-protocol-info.c:
3648 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3649 is required by our UI spec. Maybe something in our implementation will use this eventually.
3650 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3651 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3652 instead of the previous 0 placeholder.
3654 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3655 secure-auth settings.
3656 * src/modest-account-mgr-helpers.h:
3657 * src/modest-account-mgr-helpers.c:
3658 (modest_server_account_data_get_option_secure_auth),
3659 (modest_server_account_set_option_secure_auth),
3660 (modest_server_account_data_get_option_security),
3661 (modest_server_account_set_option_security): Added this API for getting and setting the security
3662 and secure-auth settings.
3664 * src/maemo/modest-account-settings-dialog.h:
3665 * src/maemo/modest-account-settings-dialog.c:
3666 (modest_account_settings_dialog_finalize), (check_data),
3667 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3668 about changing titles.
3669 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3670 (save_configuration): Save the security and secure-auth settings.
3672 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3673 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3675 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3677 * src/modest-defs.h:
3678 * src/modest-account-mgr.c:
3679 (modest_account_mgr_add_server_account):
3680 Added and used defines for the options key and value pair strings,
3681 that are used so far, though they do not seem to correspond to anything in our
3682 UI specs or ModestProtocol enum.
3684 * src/modest-account-mgr-helpers.h:
3685 * src/modest-account-mgr-helpers.c:
3686 (compare_option_strings_for_name),
3687 (modest_server_account_data_get_option_value),
3688 (modest_server_account_data_get_option_bool),
3689 (modest_account_mgr_get_server_account_option):
3690 Added helper functions for parsing the options GSList.
3692 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3694 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3695 display name is based on the supplied account name.
3696 * src/modest-account-mgr.c:
3697 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3698 with an inefficient, but good-enough, implementation.
3700 * src/maemo/easysetup/modest-easysetup-wizard.c:
3701 (create_page_account_details), (on_before_next), (create_account):
3702 Check for existing display names rather than (non-user-visible) account names, and just
3703 create and set a unique account name at the end.
3705 * src/maemo/modest-account-settings-dialog.c:
3706 (modest_account_settings_dialog_init),
3707 (modest_account_settings_dialog_set_account_name),
3708 (create_page_incoming): Show the display name, instead of the account name.
3709 (on_response): Do some (not all) extra checks, as in the UI spec.
3710 (save_configuration): Save the display name if it was changed.
3712 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3714 * po/en_GB.po: Added needed logical ID and translation.
3715 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3716 (init_view): Made the is-default column clicking work.
3718 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3721 * src/maemo/easysetup/Makefile.am:
3722 * src/maemo/easysetup/modest-easysetup-wizard.c:
3723 (modest_easysetup_wizard_dialog_init):
3724 * src/maemo/easysetup/provider-data-test.keyfile:
3725 * src/maemo/easysetup/provider-data.keyfile:
3726 Moved the provider data file to the new modest-providers-data package and used it from there.
3728 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3730 * src/modest-local-folder-info.c:
3731 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3732 N_() was already used on the static strings, but this just marks it for translation without
3733 using the translation.
3735 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3737 * src/maemo/modest-account-settings-dialog.c:
3738 (create_page_incoming),
3739 (modest_account_settings_dialog_set_account_name):
3740 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3741 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3742 I will do this if nobody else gets there first.
3744 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3746 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3747 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3748 save the security stuff.
3750 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3752 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3753 Set the email address and user fullname, which I now see must be
3756 * src/maemo/modest-account-settings-dialog.h:
3757 * src/maemo/modest-account-settings-dialog.c:
3759 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3760 leave-on-server and authentication.
3761 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3764 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3767 * src/maemo/modest-account-settings-dialog.c:
3768 * src/maemo/modest-account-settings-dialog.h:
3769 Most (but not all) of the widgets are now present as specified by the UI spec.
3770 No changes are yet saved, and some details are not properly shown yet.
3772 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3774 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3776 * src/maemo/Makefile.am:
3777 * src/maemo/modest-account-settings-dialog.c:
3778 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3779 an existing account. Doesn't do much yet.
3781 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3782 Open the accounts settings dialog when Edit is clicked.
3784 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3786 * src/maemo/easysetup/Makefile.am:
3787 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3789 * src/maemo/easysetup/modest-easysetup-wizard.c:
3790 (modest_easysetup_wizard_dialog_init):
3791 Try to get the source directory from the build system,
3792 instead of hard-coding "./" into the source code, when opening our local
3793 copies of the configuration files.
3794 But this still fails when opening the wizard from the Accounts window,
3795 maybe because the working directory seems to change at runtime.
3796 So the wizard will fail the second time unless you copy the files into their
3797 proper locations - see the stdout warnings for the paths.
3799 (create_page_account_details),(on_before_next):
3800 Check for existing non-server accounts instead of server accounts,
3801 so the default account name is useful again, and to prevent trying to
3804 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3805 Show the wizard when New is clicked.
3807 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3808 (init_view): Show the column headers, and show the columns that are
3809 specified in the UI specs. However, something in Maemo's GTK+ prevents
3810 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3811 change the default account. This is despite unsetting the special properties.
3813 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3815 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3816 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3817 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3818 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3819 to make that clearer.
3820 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3822 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3824 * src/maemo/modest-account-view-window.c:
3825 (modest_account_view_window_init),
3826 (modest_account_view_window_new):
3827 Use the same buttons as specified in the
3828 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3829 the existing widgets, which never had a chance of working.
3830 Put the ModestAccountView treeview in a scrolled window.
3831 Do not repeat the initialization in both _init() and _new().
3833 * src/widgets/modest-account-view.c: (update_account_view):
3834 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3835 this widget and window shows no accounts.
3837 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3839 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3841 * src/maemo/easysetup/modest-easysetup-wizard.c:
3842 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3843 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3844 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3847 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3848 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3849 accounts exist yet, as in the UI spec.
3851 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3853 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3855 * src/maemo/Makefile.am:
3856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3857 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3858 New window for editing connection-specific smtp details.
3859 Not fully implemented.
3861 * src/maemo/modest-connection-specific-smtp-window.c:
3862 (modest_connection_specific_smtp_window_finalize) :
3863 unref the tree model.
3864 (on_button_edit): Show the edit window.
3866 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3868 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3871 * src/maemo/Makefile.am:
3872 * src/maemo/modest-connection-specific-smtp-window.c:
3873 * src/maemo/modest-connection-specific-smtp-window.h:
3874 New window for showing the list of connections, for connection-specific
3875 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3876 * src/maemo/easysetup/modest-easysetup-wizard.c:
3877 (create_page_custom_outgoing): Show the new window when the button is clicked.
3879 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3881 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3882 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3883 * src/maemo/modest-msg-edit-window.c:
3884 (modest_msg_edit_window_insert_image):
3885 * src/modest-conf.c: (modest_conf_key_escape):
3886 * src/modest-mail-operation.c:
3887 (modest_mail_operation_send_new_mail):
3888 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3889 (modest_ui_actions_on_new_account):
3890 * src/widgets/modest-attachment-view.c: (update_filename_request):
3891 * src/widgets/modest-mail-header-view.c:
3892 Corrected warnings that were breaking the build, by commenting out unused variables,
3893 and a function, and by including a header.
3895 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3897 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3898 so we can #ifdef around platform-specific code when necessary.
3899 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3900 to allow this to build for the GNOME platform too.
3902 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3904 * src/maemo/easysetup/modest-easysetup-wizard.c:
3905 Added util_increment_name() and used it in create_page_account_details()
3906 to make sure that the default account name is always a new name.
3908 (modest_easysetup_wizard_dialog_init),
3909 (set_default_custom_servernames): Some minor memory management fixes.
3911 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3915 * src/modest-runtime.c: (init_i18n): Restored the translation
3916 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3917 are defined in config.h, and the translations are installed.
3919 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3920 is defined for translation.
3922 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3924 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3926 * src/maemo/easysetup/modest-easysetup-wizard.c:
3927 (modest_easysetup_wizard_dialog_init):
3928 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3929 Use realistic paths (though they should use $prefix generically) to the
3930 mcc_mapping and provider-data.keyfile files which might work when they
3931 are installed by the future version of the operator-wizard package,
3932 and then fallback to paths in our source code, with an explanatory
3935 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3939 * src/maemo/Makefile.am:
3940 * src/maemo/easysetup/: Added files from the previously-exernal
3941 osso-modest-easysetup.
3942 * src/maemo/modest-main-window-ui.h:
3943 * src/modest-ui-actions.c:
3944 * src/modest-ui-actions.h:
3945 Added modest_ui_actions_on_new_account() as a signal handler for the
3946 New Account menu item. It shows the easysetup wizard.
3947 * po/en_GB.po: Added additional needed logical IDs and translations.