1 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/modest-text-utils.c:
4 Fixed invalid jump due to incorrect string/pointer
6 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
9 2007-08-01 Murray Cumming <murrayc@murrayc.com>
11 * src/modest-account-mgr-helpers.h:
12 * src/modest-account-mgr-helpers.c:
13 Added modest_account_mgr_get_first_account_name(),
14 using code from modest_account_mgr_set_first_account_as_default().
16 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
17 (account_number_changed): Call set_at_least_one_account_visible() so that
18 the first account is visible when first added, without the user having to
20 I do wonder how this worked before.
22 2007-08-01 Murray Cumming <murrayc@murrayc.com>
24 * src/modest-tny-account-store.c: (show_password_warning_only),
25 (show_wrong_password), (request_password_and_wait), (get_password),
26 (modest_tny_account_store_alert): Remove the (incomplete anyway)
27 attempts to show UI only in the main context, which used g_idle_add()
28 and mainloops, because tinymail now guarantees that it only calls these
29 callbacks in the mainloop with the gdk lock. This makes everything much
32 2007-08-01 Murray Cumming <murrayc@murrayc.com>
34 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
35 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
36 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
37 error dialog, instead of ignoring it.
39 2007-08-01 Murray Cumming <murrayc@murrayc.com>
41 * src/maemo/modest-msg-view-window.c:
42 (modest_msg_view_window_get_header),
43 (modest_msg_view_window_last_message_selected):
44 Added comments to explain the use of priv->header_model.
45 * src/modest-ui-dimming-rules.c:
46 (modest_ui_dimming_rules_on_open_msg),
47 (modest_ui_dimming_rules_on_mark_as_read_msg),
48 (modest_ui_dimming_rules_on_mark_as_unread_msg),
49 (modest_ui_dimming_rules_on_remove_attachments),
50 (_invalid_attach_selected), (_selected_msg_marked_as):
51 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
52 and changed the parameter to a ModestMainWindow to make it clearer that
53 it never uses any other kind of window.
54 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
55 instead of the selected message.
56 I notice that much of the dimming code and the ModestMsgViewWindow code
57 hard-codes the assumption that the viewed message is always selected in
58 the header view. This does not seem wise or simple.
60 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
61 examine the actual message instead of whatever might be selected
62 in the header view. This stops the delete toolbar button and menu item
63 from being dimmed when opening a message view the search UI,
64 partially fixing projects.maemo.org bug NB#63811.
66 However, when actually deleting, I now get this warning:
67 "tny_header_set_flags: This is a header instance for a new message.
68 Only priority and attachment flags are supported"
70 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
72 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
74 Show account wizard if no accounts are defined while sending
75 (automatic sending after the account wizard finished does not
76 work because it takes some time until the account manager
77 synchronizes everything. (projects.maemo.org NB#62792)
79 2007-07-30 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-tny-account-store.c: (on_account_removed),
82 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
83 account is removed from the View menu. We have TnyAccountStore
84 and ModestTnyAccountStore signals that seem very similar, but this
85 seems to work for now.
87 * src/maemo/modest-main-window.c:
88 (on_show_account_action_activated): Prevent dereference
89 of a NULL if the accoutn does not really exist, though that
90 should not happen anymore.
92 This fixes projects.maemo.org bug NB#64606.
94 2007-07-30 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-ui-actions.c: (run_account_setup_wizard),
97 (modest_ui_actions_on_accounts): Revert a change that set these
98 to modal dialogs, freezing the UI when they show secondary dialogs.
99 This fixed projects.maemo.org bug NB#64519.
101 2007-07-27 Murray Cumming <murrayc@murrayc.com>
103 * src/widgets/modest-header-view-render.c:
104 (_modest_header_view_compact_header_cell_data):
105 Some checks and initialization to try to deal with a crash,
106 probably ineffective.
108 2007-07-27 Murray Cumming <murrayc@murrayc.com>
110 * src/maemo/modest-maemo-utils.c:
111 (modest_maemo_utils_get_supported_secure_authentication_methods):
112 Make sure that we have a connection, asking the user for one
114 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
115 Check for a connection before showing the wizard, because
116 the wizard needs a connection to check for server capabilities.
118 2007-07-27 Murray Cumming <murrayc@murrayc.com>
120 * src/maemo/modest-account-view-window.c:
121 (on_new_button_clicked): Remember the wizard dialog instance,
122 so we can just present it again if necessary. This prevents
123 multiple windows from appearing if you click again quickly on the
124 New button before the dialog appears, fixing projects.maemo.org
127 2007-07-27 Murray Cumming <murrayc@murrayc.com>
129 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
130 Offer a connection dialog if there is no connection when
131 starting modest. This should fix projects.maemo.org bug NB#61134.
133 2007-07-27 Murray Cumming <murrayc@murrayc.com>
135 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
136 Reverted my last commit. I was able to fix the build by doing
137 apt-get install wpeditor0 (replacing other wpeditor packages) and
138 an explicit apt-get install wpeditor-dev to upgrade the -dev
141 2007-07-27 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
144 Commented out the use of wp_text_buffer_replace_image()
145 because it does not exist, to break the build. Added a TODO for it.
147 2007-07-26 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-tny-account-store.c: (recreate_all_accounts):
150 Recreate them even if they were NULL before. I guess something
151 else was already creating them before, or this would never
153 (modest_tny_account_store_get_server_account): Make sure that
154 the tny accounts have been created before trying to find one.
155 This allows libmodest_dbus_client_compose_mail() to work
156 when the UI is not yet visible.
157 This is probably useful in other cases too.
159 (get_password): When the password is wrong after it is entered
160 in the protected password dialog, show an info banner (in an
161 idle handler) before showing the protected password dialog
164 2007-07-26 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-ui-actions.h:
167 * src/modest-ui-actions.c: Added
168 modest_do_refresh_current_folder() containing some code from
169 modest_ui_actions_on_send_receive().
170 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
171 Call modest_do_refresh_current_folder() before refreshing the
172 requested account, as in modest_ui_actions_on_send_receive().
173 This is strange, but seems to be necessary to show new mails.
174 Now new emails are finally visible in the UI when downloaded
175 via the automatic update interval, fixing bug NB#57458.
176 This also works because bug NB#57458 has been fixed somehow.
178 2007-07-26 Murray Cumming <murrayc@murrayc.com>
180 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
181 printf more details when we get unhandled D-Bus methods, because
184 * src/modest-mail-operation.c: (update_account_thread):
185 Comment out the tny_camel_pop_store_account_reconnect(), because this
186 is apparently no longer needed, and it did not work before anyway.
187 See the comment in the code.
189 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
190 by checking the header flags. This fixes projects.maemo.org bug
193 2007-07-25 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/modest-maemo-utils.h:
196 * src/maemo/modest-maemo-utils.c: Added
197 modest_maemo_show_information_note_in_main_context_and_forget().
198 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
199 Use the new function to show simple error dialogs in the main
200 context, though question dialogs are still in the current context,
201 which is unfortunately usually not the main context. This should
204 2007-07-25 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-tny-account-store.c: (get_password):
207 Never save the entered username and password in gconf,
208 because the UI spec says we should not. This helps
209 slightly with projects.maemo.org bug NB#63671.
211 2007-07-25 Murray Cumming <murrayc@murrayc.com>
213 * src/widgets/modest-msg-edit-window.h:
214 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
215 Moved some code here to make it simpler.
216 (modest_msg_edit_window_attach_file_one): Renamed from
217 modest_msg_edit_window_attach_file_interactive().
218 (modest_msg_edit_window_offer_attach_file): Renamed from
219 modest_msg_edit_window_attach_file() and used
220 modest_msg_edit_window_attach_file_one() instead of
221 copy/pasting the code. The old code for one was not using
222 GnomeVFS. This allows use of smb:// URLs when using send-as
223 from external applications, fixing bug NB#63741.
225 (modest_msg_edit_window_insert_image),
226 (modest_msg_edit_window_add_attachment_clicked):
227 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
228 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
229 Adapted to the new function names.
231 2007-07-25 Murray Cumming <murrayc@murrayc.com>
233 (modest_platform_set_update_interval): Set the alarm recurrence
234 fields so that auto-update does not just happen the first time.
235 This should have fixed projects.maemo.org bug NB#63938.
237 When this happens you can see a printf when the D-Bus method is
239 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
241 However, I do not actually seem to get new POP messages even when
242 clicking the refresh button manually. A restart gets them.
243 This might be a problem in today's tinymail only.
245 2007-07-24 Murray Cumming <murrayc@murrayc.com>
247 * src/maemo/modest-maemo-global-settings-dialog.c:
248 (current_connection):
249 Avoid a crash (probably only in scratchbox) when strcmp()ing a
250 NULL when closing the dialog.
252 2007-07-24 Murray Cumming <murrayc@murrayc.com>
254 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
255 Remove the hacky send/receive that didn't work, and instead
256 refilter the treemodel to make the deleted email really vanish from
257 the UI (though the delete-from-menu code does has commented out
258 the code that does that). This fixes projects.maemo.org bug
261 2007-07-24 Murray Cumming <murrayc@murrayc.com>
263 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
264 Try a couple of tricks to force the treeview to update (
265 poke the folder, and do a send/receive refresh), but the deleted
266 email still appears with a strike-through instead of really being
269 2007-07-23 Murray Cumming <murrayc@murrayc.com>
271 * src/dbus_api/modest-dbus-callbacks.c:
272 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
273 because their ID is not human-readable (see the comment about
274 improvements needed to the osso-email-interface API) and
275 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
277 2007-07-23 Murray Cumming <murrayc@murrayc.com>
279 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
280 (add_folders_to_list), (on_dbus_method_get_folders),
281 (modest_dbus_req_filter):
282 * src/maemo/modest-maemo-utils.c:
283 (on_camel_account_get_supported_secure_authentication):
284 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
285 (on_header_view_focus_in):
286 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
287 * src/modest-formatter.c: (modest_formatter_create_body_part):
288 * src/modest-mail-operation.c: (recurse_folders),
289 (update_account_thread), (get_msgs_full_thread),
290 (modest_mail_operation_get_msgs_full),
291 (modest_mail_operation_xfer_msgs):
292 * src/modest-search.c: (search_mime_part_and_child_parts),
293 (modest_search_account), (modest_search_all_accounts):
294 * src/modest-tny-account.c:
295 (modest_tny_account_get_special_folder), (recurse_folders):
296 * src/modest-tny-local-folders-account.c:
297 (modest_tny_local_folders_account_query_passes):
298 * src/modest-tny-msg.c: (copy_mime_part),
299 (modest_tny_msg_find_body_part_from_mime_part):
300 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
301 (modest_tny_send_queue_try_to_send):
302 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
303 (_modest_ui_actions_open), (download_uncached_messages),
304 (reply_forward), (modest_ui_actions_on_copy),
305 (modest_ui_actions_on_details), (has_retrieved_msgs),
306 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
308 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
309 (_selected_msg_marked_as), (_msg_download_completed),
310 (_selected_msg_sent_in_progress):
311 * src/widgets/modest-attachments-view.c:
312 (modest_attachments_view_set_message):
313 * src/widgets/modest-msg-view.c: (find_cid_image):
314 * tests/check_folder-transfer.c: (find_folders):
315 * tests/check_update-account.c: (func):
316 * tests/dbus_api/test_get_folders.c: (main):
317 Checked all uses of tny_iterator_get_current(), making sure
318 that the object is unreferenced (3 or 4 places did not),
319 and adding checks for NULL.
321 2007-07-23 Murray Cumming <murrayc@murrayc.com>
323 * src/dbus_api/modest-dbus-callbacks.c:
324 (on_idle_open_default_inbox): Make sure that the application UI is
326 * src/maemo/easysetup/modest-easysetup-wizard.c:
327 (on_entry_invalid_character): Show the word whitespace instead
328 of (null) in the banner when whitespace was entered.
329 (show_error): Add a comment that this does not work in
330 Maemo Bora, though we do not know why.
332 2007-07-23 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-tny-account.c:
335 (modest_tny_account_get_special_folder): Use an if instead of
336 an assert for when the parent account name is NULL, because this
337 might be causing a crash in projects.maemo.org bug 63192.
338 * src/modest-mail-operation.c:
339 (modest_mail_operation_send_new_mail_cb),
340 (modest_mail_operation_remove_folder): unref the folder that is
341 returned from modest_tny_account_get_special_folder().
343 2007-07-23 Murray Cumming <murrayc@murrayc.com>
345 * src/modest-ui-actions.c:
346 (modest_ui_actions_on_password_requested):
347 Show mail_ib_login_cancelled info banner when the user cancels
348 the protected password dialog, to fix projects.maemo.org
351 2007-07-23 Murray Cumming <murrayc@murrayc.com>
353 * src/maemo/modest-account-settings-dialog.c:
354 (create_page_outgoing): Put this page in a GtkScrolledWindow,
355 matching the UI mock-up in the UI spec, and allowing access
356 to all widgets even when the on-screen keyboard is active.
358 2007-07-23 Murray Cumming <murrayc@murrayc.com>
360 Reverted this previous commit from Johannes,
361 because the scrollbars are always visible and because
362 I think we only need it on onepage of the account
363 settings, not the account wizard.
364 (I wrote the wrong instructions in the bug.)
366 * src/maemo/easysetup/modest-easysetup-wizard.c:
367 Added scrollbars to account wizard dialog.
368 Fixed projects.maemo.org NB #62744
370 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
372 * src/maemo/easysetup/modest-easysetup-wizard.c:
373 (create_page_user_details):
374 Use auto-cap for name (projects.maemo.org NB#63716)
375 * src/widgets/modest-account-view.c: (on_account_busy_changed):
377 2007-07-22 Armin Burgmeier <armin@openismus.com>
379 * src/maemo/modest-ui-actions.c: Use current account instead of
380 default account for creating viewer windows, so that the viewer
381 window knows to which account the viewed message belongs.
383 * src/maemo/modest-msg-view-window.c: Destroy the window when the
384 corresponding account is deleted. This fixes projects.maemo.org bug
387 2007-07-18 Armin Burgmeier <armin@openismus.com>
389 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
390 the dialog close after entering an invalid port number and clicking
391 OK. This fixes projects.maemo.org bug NB#63602.
393 2007-07-18 Armin Burgmeier <armin@openismus.com>
395 * src/modest-tny-account-store.c:
396 (get_server_accounts): Set parent modest account name for each
397 connection-specific transport account so that special folders of such
398 an account can be looked up. This fixes a crash when changing account
399 settings. This might also be related to projects.maemo.org bug
402 2007-07-16 Armin Burgmeier <armin@openismus.com>
404 * src/modest-ui-actions.c: Added a button to create a folder to the
405 move-to dialog. This fixes projects.maemo.org bug NB#.
407 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
409 * src/maemo/easysetup/modest-easysetup-wizard.c:
410 Added scrollbars to account wizard dialog.
411 Fixed projects.maemo.org NB #62744
413 2007-07-16 Murray Cumming <murrayc@murrayc.com>
415 * src/widgets/modest-msg-view.h:
416 * src/widgets/modest-msg-view.c:
417 Added modest_msg_view_get_message_is_empty() but this needs
419 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
420 Check if there is any text in the message yet.
421 But this needs to be implemented properly.
422 (modest_msg_edit_window_toggle_find_toolbar):
423 * src/maemo/modest-msg-view-window.c:
424 (modest_msg_view_window_toggle_find_toolbar):
425 Show a banner warning if there is no text to search, when
426 trying to start a search. This partially fixes
427 projects.maemo.org bug NB#62350.
429 2007-07-13 Murray Cumming <murrayc@murrayc.com>
431 * src/modest-mail-operation.c: (update_account_thread):
432 Initialized num_new_headers to fix the build.
434 2007-07-13 Murray Cumming <murrayc@murrayc.com>
436 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
437 Ignore modest accounts whose server accounts don't exist in gconf.
438 This prevents us trying to create TnyAccount instances for those
439 server accounts when the server account has been removed from gconf,
440 but the parent modest account has not yet been removed from modest.
441 I don't know why this is only noticeable now. It was probably just
442 a harmeless g_warning() anyway.
444 2007-07-13 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
447 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
449 2007-07-12 Armin Burgmeier <armin@openismus.com>
451 * src/maemo/modest-main-window.c: Make default account appear bold
452 in view, tools/send & receive and toolbar/send & receive SCM menus.
453 This fixes projects.maemo.org bug NB#59010.
455 2007-07-12 Murray Cumming <murrayc@murrayc.com>
457 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
458 Add a short-cut, by checking if the folder store is an account.
459 This ensures that the Sort menu item and toolbar is dimmed for
460 the local-folders account root item, fixing
461 projects.maemo.org bug NB#62545.
463 2007-07-12 Murray Cumming <murrayc@murrayc.com>
465 * src/modest-tny-account-store.c: (get_password):
466 Show the password dialog (via the signal) only in the mainloop, via
467 an idle handler that we wait for. This could theoretically prevent
468 hangs, though I worry that it could introduce some too.
470 2007-07-12 Murray Cumming <murrayc@murrayc.com>
472 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
473 * src/maemo/modest-platform.c:
474 (modest_platform_connect_and_wait):
475 Take a TnyAccount* parameter and try to set it to online
476 (a TnyCamel-only API), because tinymail sets accounts to offline
477 when the user cancels a password dialog, and doesn't ask again until
478 it has been set to online.
479 However, this is commented out because it causes a hang now.
481 (modest_platform_connect_and_wait_if_network_account):
482 * src/modest-mail-operation.c:
483 (modest_mail_operation_update_account):
484 * src/modest-platform.h:
485 * src/modest-ui-actions.c: (_modest_ui_actions_open),
486 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
488 2007-07-12 Armin Burgmeier <armin@openismus.com>
490 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
492 * src/modest-mail-operation.c:
493 * src/modest-ui-actions.c: Check for already existing folder before
494 querying the server, show error message from camel if the request
495 still fails. This fixes projects.maemo.org bug NB#58701.
497 2007-07-12 Murray Cumming <murrayc@murrayc.com>
499 * src/modest-tny-account-store.h:
500 * src/modest-tny-account-store.c:
501 Added modest_tny_account_store_forget_password_in_memory(),
502 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
503 when creating a new account, so that new passwords will be used, instead of
504 us thinking that it's a second request as a result of a failed password again.
506 2007-07-12 Murray Cumming <murrayc@murrayc.com>
508 * src/dbus_api/modest-dbus-callbacks.c:
509 (on_idle_open_message): If the message is in drafts then open it
510 in an edit window instead of a view window. This fixes
511 projects.maemo.org bug NB#63005.
513 2007-07-12 Murray Cumming <murrayc@murrayc.com>
515 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
516 Avoided a harmless g_warning().
518 2007-07-12 Murray Cumming <murrayc@murrayc.com>
520 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
521 Pass the modest account name, not the TnyAccount display name to
522 modest_msg_view_window_new() so that the reply feature works,
523 fixing projects.maemo.org bug NB#62892.
525 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
526 (modest_msg_view_window_new_with_header_model):
527 * src/maemo/modest-msg-view-window.c:
528 (modest_msg_view_window_new_with_header_model),
529 (modest_msg_view_window_new):
530 * src/modest-ui-actions.c: (reply_forward):
531 * src/widgets/modest-msg-view-window.h:
532 * src/widgets/modest-window.c: (modest_window_set_active_account):
533 Rename an account parameter to modest_account_name to make this clearer.
535 2007-07-11 Murray Cumming <murrayc@murrayc.com>
537 * src/modest-ui-actions.h:
538 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
539 modest_do_message_delete().
540 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
541 Call modest_do_message_delete(), hoping that this would cause messages
542 to be really deleted from search instead of just marked with strike through.
543 Does not seem to help.
545 2007-07-11 Armin Burgmeier <armin@openismus.com>
547 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
548 priv->reselect to FALSE prior to calling
549 modest_folder_view_select_first_inbox_or_local() to prevent endless
550 recursion and thus a crash on startup.
552 2007-07-11 Armin Burgmeier <armin@openismus.com>
554 * src/maemo/modest-account-settings-dialog.h: Include
555 <gtk/gtknotebook.h> to fix the build (at least for me).
557 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
558 Use "New FolderN" as default suggested name if "New folder" already
559 exists, with N being the first free number, though never exceed "New
560 folder99" in which case we just fall back to "New Folder" even though
561 it already exists. This fixes projects.maemo.org bug NB#58663.
563 2007-07-11 Murray Cumming <murrayc@murrayc.com>
565 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
566 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
567 projects.maemo.org bug NB#62778.
569 2007-07-11 Murray Cumming <murrayc@murrayc.com>
571 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
572 Ignore the wrong (for now) secure-smtp setting in the presets -
573 just default to requiring secure authentication for SMTP, because
576 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
578 * src/widgets/modest-folder-view.c: (filter_row)
579 Do not show drafts folder (see UI specs)
581 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
583 * src/modest-ui-actions.c:
584 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
585 place and also not necessary.
587 * src/widgets/modest-folder-view.c: (filter_row)
588 Guess folder type and hide Sent & Outbox if necessary.
589 Fixed project.maemo.org NB#57328
591 2007-07-11 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-ui-actions.h:
594 * src/modest-ui-actions.c:
595 (modest_ui_actions_on_delete_message):
596 Move some code into a new
597 modest_ui_actions_refresh_message_window_after_delete()
598 function so we can use it from elsewhere.
600 * src/dbus_api/modest-dbus-callbacks.c:
601 (on_idle_delete_message), (on_delete_message): Used an idle
602 handler, as we do for the other D-Bus method handlers.
603 Call modest_ui_actions_refresh_message_window_after_delete()
604 if the deleted message was open in a window. This fixed
605 projects.maemo.org bug NB#62862.
607 2007-07-11 Murray Cumming <murrayc@murrayc.com>
609 * src/modest-main.c: (main): Only show the UI at the start if
610 the showui command line option was given. For instance,
611 run-standalone src/modest showui
612 Otherwise, we wait for the top_application D-Bus method to
613 be sent by hildon-desktop when the application is selected
615 This allows us to run without a UI when osso-global-search
616 uses our D-Bus methods.
618 2007-07-11 Murray Cumming <murrayc@murrayc.com>
620 * src/dbus_api/modest-dbus-api.h: Added a define for a
621 top-application D-Bus method.
622 * src/dbus_api/modest-dbus-callbacks.c:
623 (on_top_application),
624 (modest_dbus_req_handler): Handle the top-application D-Bus
625 method, which might be an undocumented D-Bus signal sent by
626 hildon-desktop when it starts the application from the menu.
627 But I am not sure and I need to test it on the device, because
628 my scratchbox does not have the application in the menu now.
629 This method shows the main window, so that it can be invisible
630 when started, for instance, just for email searching from
633 * src/maemo/modest-main-window.c: (restore_settings),
634 (modest_main_window_new): Do not show the window immediately
635 upon creation. We show it later.
636 * src/modest-widget-memory.c: (save_settings_paned):
637 Try (unsuccessfully) to avoid saving the paned position when
638 it is not even visible.
639 (restore_settings_paned): Do not allow a silly paned position.
640 This seems necessary when not showing the window at first.
642 * tests/dbus_api/Makefile.am:
643 * tests/dbus_api/test_top_application.c: (main): Test for the
646 2007-07-10 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-ui-dimming-rules.c:
649 (modest_ui_dimming_rules_on_new_msg),
650 (modest_ui_dimming_rules_on_reply_msg),
651 (modest_ui_dimming_rules_on_delete_msg),
652 (modest_ui_dimming_rules_on_details),
653 (modest_ui_dimming_rules_on_view_window_move_to),
654 (modest_ui_dimming_rules_on_view_previous),
655 (modest_ui_dimming_rules_on_view_next),
656 (_invalid_folder_for_purge): Added checks before
657 casting the window. This looks like an actual
658 logic error in _invalid_folder_for_purge(), because it
659 tries to use a ModestMainWindow as a message window.
661 2007-07-10 Murray Cumming <murrayc@murrayc.com>
663 * src/maemo/modest-account-settings-dialog.c:
664 (show_error): Use the same implementation as in
665 modest-easysetup-wizard.c:
666 (on_entry_invalid_character): The logical ID contains a %s.
667 Guessed what it should be.
668 (on_entry_max), (check_data), (on_response): Adapt to
669 changed show_error().
670 (create_page_account_details): Really call
671 modest_validating_entry_set_func() on the correct widgets.
672 * src/maemo/easysetup/modest-easysetup-wizard.c:
673 (on_entry_invalid_character): Fix the logical ID here too.
674 (create_page_account_details),
675 (create_page_user_details):
677 modest_validating_entry_set_func() on the correct widgets.
679 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
680 Do not try to use the account if it is NULL.
682 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
684 * src/modest-ui-actions.c: (create_move_to_dialog),
685 (modest_ui_actions_on_main_window_move_to),
686 (modest_ui_actions_on_msg_view_window_move_to):
687 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
688 (filter_row), (modest_folder_view_show_non_move_folders):
689 * src/widgets/modest-folder-view.h:
691 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
692 the Sent folder yet as it does not report the correct folder type.
694 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
696 * src/maemo/modest-msg-edit-window.c: (init_window):
699 2007-07-10 Murray Cumming <murrayc@murrayc.com>
701 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
702 Take a parent widget instead of a parent window, and
703 implement this with hildon_banner_show_information() instead.
704 Non-Maemo builds can just ifdef that there.
705 This fixed projects.maemo.org bug NB#62766.
707 (on_entry_invalid_character): Use show_error() again instead
708 of using hildon directly, and use the _CS() macro to use the correct
710 (create_account), (check_for_supported_auth_methods), (on_entry_max):
711 Pass a widget instead od a window to show_error().
713 2007-07-10 Murray Cumming <murrayc@murrayc.com>
715 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
716 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
717 This allows us to show the server name in the error message, fixing
718 projects.maemo.org bug NB#62904.
719 Also, use the appropriate logical ID message for the account protocol.
721 2007-07-10 Murray Cumming <murrayc@murrayc.com>
723 * src/modest-tny-account-store.c: (on_idle_wrong_password):
724 A compilation fix, though the build wasn't broken for me.
726 2007-07-09 Murray Cumming <murrayc@murrayc.com>
728 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
729 Do not try to unref a NULL folder store, to avoid a runtime warning.
730 This seems to happen sometimes when changing accounts settings.
732 2007-07-09 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-tny-account-store.c:
735 (modest_tny_account_store_instance_init),
736 (modest_tny_account_store_finalize),
737 (on_account_settings_hide), (on_idle_wrong_password):
738 Use a GHashTable to ensure that we only show one account settings
739 dialog per modest account. This avoids us having a dialog open for
740 both the store and transport accounts, or due to repeated get_password()
741 calls that shouldn't happen anyway.
743 2007-07-09 Murray Cumming <murrayc@murrayc.com>
745 * src/maemo/modest-maemo-utils.c: (on_hide),
746 (modest_maemo_show_dialog_and_forget): Handle the response, because
747 the window is not even hidden by default.
749 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
750 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
751 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
752 which seems to prevent some modality problems.
754 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
755 Ignore user cancellation errors.
757 * src/modest-account-mgr-helpers.h:
758 * src/modest-account-mgr-helpers.c:
759 Added modest_server_account_get_password() and
760 modest_server_account_get_has_password() to avoid direct use of
763 * src/maemo/modest-account-settings-dialog.h:
764 * src/maemo/modest-account-settings-dialog.c:
765 (modest_account_settings_dialog_init): Store the notebook so we can
767 Added modest_account_settings_dialog_switch_to_user_info().
769 * src/modest-tny-account-store.c:
770 (get_password): When the password in the account settings is wrong (we think),
771 show the relevant page of the account settings dialog, in the mainloop.
772 However, we currently get many of these at once because cancel does not
774 (forget_password): Do not forget the password
775 from the account settings, because this causes side-effects when
776 tinymail seems to call it at strange time, maybe because of how we
777 are cancelling get_password().
778 (modest_tny_account_store_alert): Ignore user cancellations.
780 2007-07-09 Murray Cumming <murrayc@murrayc.com>
782 * src/maemo/modest-maemo-utils.h:
783 * src/maemo/modest-maemo-utils.c:
784 Added modest_maemo_show_information_note_and_forget() for use instead of
785 gtk_dialog_run() when the response is not needed, to avoid an extra
786 mainloop which could cause a hang.
788 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
789 Use the logical IDs for the error message, though they are not
790 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
791 because gtk_dialog_run() caused a hang here (the window did not close).
792 This fixes projects.maemo.org bug NB#62646.
794 2007-07-09 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-account-mgr-helpers.h:
797 * src/modest-account-mgr-helpers.c:
798 Added modest_account_mgr_get_store_protocol().
800 * src/maemo/modest-account-view-window.c:
801 (on_delete_button_clicked): Show different warning text depending on
802 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
803 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
806 2007-07-09 Murray Cumming <murrayc@murrayc.com>
808 * src/maemo/modest-msg-edit-window.c:
809 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
810 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
812 2007-07-07 Armin Burgmeier <armin@openismus.com>
814 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
815 ckdg_ib_maximum_characters_reached from correct package.
817 * src/modest-ui-actions.c: Show an error message when a folder could
818 not be created. Tinymail does not give us specific error codes about
819 what has gone wrong, so we assume that a folder with that name
820 already exists, though there might be other reasons.
822 2007-07-06 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
825 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
826 give a more exact error message that can be partly translated.
828 2007-07-05 Murray Cumming <murrayc@murrayc.com>
830 * src/maemo/modest-address-book.c:
831 (select_email_addrs_for_contact): Specify a default window size for the
832 select-email-address dialog, so that it is probably big enough for the
833 title. This should fix projects.maemo.org bug NB#62277.
835 2007-07-05 Murray Cumming <murrayc@murrayc.com>
837 * src/maemo/easysetup/modest-easysetup-wizard.c:
838 (create_page_complete_easysetup): Use
839 gtk_widget_set_size() request to ensure that the text wraps
842 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
844 * src/maemo/easysetup/modest-easysetup-wizard.c:
845 (on_entry_invalid_character), (create_page_account_details),
846 (create_page_user_details):
847 Use new API of ModestValidatingEntry. But for some reason the banner is
848 not shown. I will have to investigate that further.
850 * src/widgets/modest-validating-entry.c: (on_insert_text),
851 (modest_validating_entry_set_func):
852 * src/widgets/modest-validating-entry.h:
853 Added a new callback function to be able to react to prevented
854 characters whitespaces to e.g show a banner.
856 2007-07-05 Armin Burgmeier <armin@openismus.com>
858 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
859 notification of HildonNumberEditor instead of remembering the port
860 number. Thanks to Johannes for pointing this out.
862 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
864 * src/maemo/easysetup/modest-easysetup-wizard.c:
865 Check if there are any user changes before showing a confirmation
866 dialog (projects.maemo.org NB#60946)
868 2007-07-05 Armin Burgmeier <armin@openismus.com>
870 * src/maemo/modest-account-settings-dialog.c: Remember custom port
871 number at the beginning of the dialog and set the modified flag at the
872 end if the port number has changed. This is necessary because
873 HildonNumberEditor does not support notification when the value has
876 2007-07-05 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-ui-actions.c:
879 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
880 a connection before asking anything else. Correct the check for the destination
881 folder so that it succeeds when online.
882 This fixed projects.maemo.org bug NB#61645.
884 2007-07-05 Murray Cumming <murrayc@murrayc.com>
886 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
887 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
888 to fix projects.maemo.org bug NB#62439.
890 2007-07-05 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-tny-account.c: (on_connection_status_changed):
893 Really do not use tny_device_force_offline() here. See the previous comment.
895 2007-07-04 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-tny-account.c: (on_connection_status_changed):
898 Do not use tny_device_force_offline() when tinymail says that something
899 went wrong with the connection. It seems to report this unnecessarily.
901 2007-07-04 Murray Cumming <murrayc@murrayc.com>
903 * src/maemo/modest-connection-specific-smtp-window.c:
904 (modest_connection_specific_smtp_window_init):
905 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
906 does not seem to have any effect in osso 1.1 (though it works in
907 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
909 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
911 * src/maemo/modest-connection-specific-smtp-window.c:
912 Fix UI specification problems with projects.meamo.org NB#60479
914 2007-07-04 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
917 clue when this has failed, because the error dialog is not always shown
918 (at least in earlier version).
920 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
921 GError message, because the generic error dialog is not helpful.
923 'This message is not currently available (can't let a new connection go online)'
924 when trying to open an IMAP message.
926 (_modest_ui_actions_open): Offer a connection when some messages would
927 have to be downloaded and we are offline.
929 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
931 * src/widgets/modest-folder-view.c:
932 Don't check for MERGE type anymore as we use the correct type
934 NOTE: For the last two changes you need to update your tinymail copy
935 because of API changes!
937 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
939 * src/modest-tny-local-folders-account.c:
940 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
941 (see projects.maemo.org NB#61580)
943 2007-07-04 Murray Cumming <murrayc@murrayc.com>
945 * src/modest-tny-account.c: (on_connection_status_changed):
946 Commented out the call to modest_platform_connect_and_wait() because this
947 seems to always hang, and I would like to know if this is the only thing
948 that causes a hang when showing the connection dialog.
949 It is not very useful anyway.
951 2007-07-04 Murray Cumming <murrayc@murrayc.com>
953 * src/maemo/modest-msg-view-window.c:
954 (modest_msg_view_window_select_next_message):
956 * src/modest-platform.h:
957 * src/maemo/modest-platform.c:
958 Added modest_platform_connect_and_wait(), which calls
959 tny_maemo_conic_device_connect() always in the main thread, by calling it
960 in an idle handler and waiting for the idle handler to run. It should be
961 in the main thread because it uses GTK+ UI code. It just returns TRUE
962 if the device is already online.
964 There is some nasty code to ensure that subsequent calls to
965 modest_platform_connect_and_wait() just wait for the first one to finish,
966 by checking repeatedly in another idle handler. This is necessary,
967 because other threads (or even the main thread, via another idle handler)
968 can call modest_platform_connect_and_wait() while
969 modest_platform_connect_and_wait() is running.
971 (modest_platform_connect_and_wait_if_network_account),
972 (modest_platform_connect_and_wait_if_network_folderstore):
973 Convenience functions that calls modest_platform_connect_and_wait() if
974 the account or folder might want network access.
976 * src/modest-mail-operation.c:
977 (modest_mail_operation_update_account):
978 * src/modest-ui-actions.c: (download_uncached_messages),
979 (modest_ui_actions_on_rename_folder), (delete_folder),
980 (modest_ui_actions_on_main_window_move_to),
981 (modest_ui_actions_on_msg_view_window_move_to):
982 * src/widgets/modest-folder-view.c:
983 (drag_and_drop_from_folder_view):
984 Offer a connection if we are offline.
986 * src/modest-tny-account.c: (on_connection_status_changed):
987 Document this as only handling errors during network operations in progress,
988 and replace the idle code with a simple call to
989 modest_platform_connect_and_wait(), which does this instead.
991 2007-07-03 Murray Cumming <murrayc@murrayc.com>
993 * src/modest-tny-account.c:
994 (modest_tny_account_get_special_folder): (util_on_idle),
995 Handle the GError so we can see when tny_folder_store_get_folders()
996 fails, as it currently does while something else is connecting.
998 Added util_run_in_main_thread_and_wait()
999 which uses an idlen handler and mainloop to ensure that the function
1000 is called in the main thread.
1001 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1002 to make sure that we call attempt the connection in the mainloop only,
1003 which might solve some hangs.
1005 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1007 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1008 be found by their display name. This is never useful.
1009 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1010 by its ID, instead of trying to use its ID as its display name.
1012 * src/modest-tny-account-store.h:
1013 * src/modest-tny-account.c:
1014 (modest_tny_account_get_special_folder): Add a g_warning() when
1015 tny_folder_store_get_folders() returns an empty list for the maildir.
1017 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1018 Add a g_warning() when this returns NULL, because that it not allowed
1021 2007-07-02 Armin Burgmeier <armin@openismus.com>
1023 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1024 note when trying to cancel the wizard. This fixes projects.maemo.org
1027 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1029 * src/modest-tny-account.h:
1030 * src/modest-tny-account.c:
1031 (modest_tny_account_new_from_server_account),
1032 (modest_tny_account_new_from_server_account_name),
1033 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1034 because this must now be set before setting the proto. This is usd in
1035 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1036 warning in camel_session_get_service() caused by
1037 tny_camel_transport_account_prepare().
1039 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1042 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1044 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1046 (modest_connection_specific_smtp_edit_window_init):
1048 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1049 of "changed" for now
1051 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-tny-account.c:
1054 (modest_tny_account_new_from_server_account):
1055 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1056 now uses to request a connection when it needs one, and which it uses
1057 to tell us that something is wrong with the connection, so we can force
1058 the accounts offline to prevent further problems.
1060 * src/modest-defs.h:
1061 * src/modest-init.c: (init_default_settings):
1062 * src/modest-mail-operation.c:
1063 (modest_mail_operation_update_account):
1064 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1065 This should not be necessary anymore. Do not set the conf key that
1066 determined this (it was always TRUE and not set anywhere else).
1068 * src/modest-ui-actions.h: Remove unused and unimplemented
1069 modest_ui_actions_on_online_toggle_toggled().
1071 2007-06-29 Murray Cumming <murrayc@murrayc.com
1073 * src/maemo/modest-main-window.c: (connect_signals):
1074 Don't connect to delete_event twice. Maybe this was harmless.
1076 2007-06-29 Murray Cumming <murrayc@murrayc.com
1078 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1079 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1080 Debug output to give some more clue when a folder move is not allowed.
1082 2007-06-28 Murray Cumming <murrayc@murrayc.com
1084 * src/modest-tny-account.c: (on_modest_file_system_info),
1085 (modest_tny_account_get_mmc_account_name):
1086 Always call the callback, without checking whether the name has changed.
1087 * src/widgets/modest-folder-view.c: (strings_are_equal),
1088 (on_model_foreach_set_name), (on_get_mmc_account_name),
1089 (text_cell_data): Compare the name here, and use the name from
1090 the account rather than from the
1091 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1092 if the name was changed after the account was added to the model.
1093 That's a tinymail bug but not one that I want to fix now.
1095 This finally fixes projects.maemo.org bug NB#59301.
1097 2007-06-27 Armin Burgmeier <armin@openismus.com>
1099 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1102 2007-06-27 Murray Cumming <murrayc@murrayc.com
1104 * src/modest-tny-account.h:
1105 * src/modest-tny-account.c:
1106 Added modest_tny_account_get_mmc_account_name(), to set the memory
1107 card name asynchronously for the given account and then notify.
1108 (modest_tny_account_new_for_local_folders): Use this new function instead
1109 of using hildon_file_system_info_async_new() directly.
1111 * src/widgets/modest-folder-view.c: (text_cell_data):
1112 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1113 gtk_tree_model_row_changed() when it is available.
1115 This should fix projects.maemo.org bug NB#59301.
1117 2007-06-27 Murray Cumming <murrayc@murrayc.com
1119 * src/modest-mail-operation.c: (update_account_thread),
1120 (get_msgs_full_thread): Fix typo failures in the revert
1123 2007-06-27 Murray Cumming <murrayc@murrayc.com
1125 * src/maemo/modest-maemo-global-settings-dialog.c:
1126 (idle_select_default_focus):
1127 * src/modest-mail-operation.c: (idle_notify_progress),
1128 (idle_notify_progress_once), (set_last_updated_idle),
1129 (update_account_thread), (get_msgs_full_thread):
1130 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1131 * src/widgets/modest-header-view.c:
1132 (idle_notify_headers_count_changed_destroy),
1133 (idle_notify_headers_count_changed):
1134 Reverted the additions of gdk_threads_enter/leave(), in case this
1135 helps with a startup hang on the device.
1137 2007-06-26 Armin Burgmeier <armin@openismus.com>
1139 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1140 for supported secure authentication methods from server by
1141 gtk_dialog_run(), saving CPU time and a potential race condition.
1143 2007-06-26 Armin Burgmeier <armin@openismus.com>
1145 * src/maemo/modest-maemo-utils.h:
1146 * src/maemo/modest-maemo-utils.c: Added a
1147 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1148 only error code to tell the calling code when the user canceled the
1151 * src/maemo/modest-account-settings-dialog.h:
1152 * src/maemo/modest-account-settings-dialog.c:
1153 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1154 message if the retrieval of secure authentication methods was canceled
1155 by the user. Perform the check before saving anything to configuration
1156 to not end up with half-committed configuration changes, do not show
1157 a "Saving to configuration failed" note when authentication methods
1158 could not be retrieved.
1160 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1163 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1165 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1166 Only return the first level of folders under accounts, because the
1167 osso-global-search UI spec doesn't want the rest.
1168 This fixed projects.maemo.org bug NB#61811.
1170 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1172 * src/modest-tny-account-store.c:
1173 * src/modest-tny-account-store.h:
1174 Added modest_tny_account_is_memory_card_account().
1175 * src/maemo/modest-main-window.c: (create_details_widget):
1176 Show the same information items for the memory card as we show for the
1177 local-folders, to fix projects.maemo.org bug NB#59307.
1179 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-tny-account-store.c: (get_password):
1182 Added some checks for NULL to maybe prevent crashes, though I think
1183 it was Philip's last commit that actually prevented the crash here
1184 when creating a first new account.
1185 But the new account is still not usable (no messages are shown)
1186 until a restart of the application.
1188 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1190 * src/maemo/modest-maemo-global-settings-dialog.c:
1191 (idle_select_default_focus):
1192 * src/modest-mail-operation.c: (idle_notify_progress),
1193 (idle_notify_progress_once), (idle_notify_update_account_queue),
1194 (set_last_updated_idle), (update_account_thread),
1195 (notify_get_msgs_full), (get_msgs_full_destroyer),
1196 (get_msgs_full_thread):
1197 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1198 * src/widgets/modest-header-view.c:
1199 (idle_notify_headers_count_changed_destroy),
1200 (idle_notify_headers_count_changed):
1201 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1202 all idle handlers, because some other thread could be blocking
1203 the GDK lock, so that it can do GUI stuff.
1205 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1207 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1208 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1209 (on_idle_send_receive), (on_idle_open_default_inbox):
1210 * src/maemo/modest-msg-edit-window.c:
1211 (modest_msg_edit_window_attach_file_noninteractive):
1212 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1213 to prevent a hang. I don't quite understand why these are necessary,
1214 beause we should already be in the main loop. I guess something outside
1215 of the main loop is taking the lock.
1217 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1218 we are really using URIs, and use files that are more likely to exist.
1220 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1222 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1223 necessary because configure.ac now defines different variables.
1225 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1227 * libmodest-dbus-client/libmodest-dbus-client.c:
1228 * libmodest-dbus-client/libmodest-dbus-client.h:
1229 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1230 libmodest_dbus_client_compose_mail() is what things actually use.
1232 * src/dbus_api/modest-dbus-api.h:
1233 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1234 * tests/dbus_api/Makefile.am:
1235 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1238 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1240 * src/modest-init.c: (modest_init_local_folders):
1241 For memory-card (or other non local-folders) maildir accounts,
1242 always create an Archive folder, so that there is somewhere to put
1243 messages. This should be less confusing, because the user does not need
1244 to guess that the need to create a folder.
1246 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1248 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1249 Fixed icon size by using (50, 50) which is the same as defined by
1252 2007-06-25 Armin Burgmeier <armin@openismus.com>
1254 * src/widgets/modest-window-mgr.c:
1255 * src/modest-init.c:
1256 * configure.ac: Correctly recognize hildon-notify presence and fixed
1257 the build without it being installed.
1259 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1261 * libmodest-dbus-client/libmodest-dbus-client.c:
1262 (libmodest_dbus_client_search): Fix the build. Sorry.
1263 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1264 (reply_forward_cb): Initialize variables to fix the build.
1266 * src/modest-tny-account-store.c:
1267 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1268 comparison (a silly typo) so that email search results can be opened
1269 when there are more than one account.
1271 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1273 * libmodest-dbus-client/libmodest-dbus-client.c:
1274 (libmodest_dbus_client_search),
1275 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1276 instead of 1 second, because the search gets folders and messages from
1277 the server, which can take a long time. When it times out,
1278 osso-global-search will report no results.
1280 We need to specify whether we should search only cached information
1281 (maybe with a user preference), and the osso-email-search-plugin
1282 API should really be improved to allow that option, and to allow results
1283 to be delivered asynchronously in batches.
1285 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1288 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1289 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1291 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1293 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1294 that is an empty string. D-Bus seems to give us these instead of NULL.
1296 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1298 * src/dbus_api/modest-dbus-callbacks.c:
1299 * src/maemo/easysetup/modest-easysetup-wizard.h:
1300 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1301 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1302 (modest_connection_specific_smtp_edit_window_init):
1303 * src/maemo/modest-maemo-global-settings-dialog.c:
1305 * src/maemo/modest-maemo-utils.c:
1306 (modest_maemo_utils_setup_images_filechooser):
1307 * src/maemo/modest-main-window.c: (create_details_widget):
1308 * src/maemo/modest-msg-edit-window.c:
1309 (modest_msg_edit_window_attach_file_noninteractive),
1310 (modest_msg_edit_window_color_button_change),
1311 (modest_msg_edit_window_set_zoom):
1312 * src/modest-mail-operation.c: (update_account_thread):
1313 * src/modest-tny-account-store.c:
1314 * src/modest-tny-account.c:
1315 * src/widgets/modest-global-settings-dialog.c:
1316 * src/widgets/modest-window.h:
1318 Fixed build on bora!
1320 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1322 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1323 * src/modest-search.c: (modest_search_folder),
1324 (modest_search_all_accounts): Actually search only in the specified folder,
1325 doing a simple match on the folder ID.
1326 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1327 and added some documentation.
1329 2007-06-22 Armin Burgmeier <armin@openismus.com>
1331 * src/maemo/modest-maemo-utils.h:
1332 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1333 modest_maemo_utils_get_supported_secure_authentication_methods.
1335 * src/maemo/easysetup/modest-easysetup-wizard.c:
1336 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1337 one occured, not just "Server does not support secure authentication".
1339 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-tny-account-store.c: (get_password):
1342 Restored the call to tny_account_set_user() because Philip seems to have
1343 stopped this from crashing (by not using the freed string). It still does
1344 not work, but now we can test it.
1346 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/modest-msg-edit-window.c: (init_window):
1349 Comment out use of an uninitialzed GtkScrolledWindow variable,
1350 to fix the build and stop a crash. Yet again.
1352 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1354 * src/modest-tny-account-store.c: (get_password):
1355 Remove the call to tny_account_set_user() because this actually crashes.
1356 As mentioned in the last commit, it is known to not work anyway.
1358 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1360 * src/modest-tny-account-store.c: (get_password):
1361 Use tny_account_set_username() to tell tinymail that the username might
1362 have changed too. But tinymail ignores this: see projects.maemo.org
1364 * src/modest-ui-actions.c:
1365 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1366 reset the connection when changing the username, and improve the comments.
1367 Save the changed username to gconf at least, so it is used when Modest is
1370 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1372 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1373 Do not use a query, so that we get all folders, including for POP and
1374 local-folders. They work as search criteria too.
1375 This fixes projects.maemo.org bug NB#57740.
1377 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1379 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1380 Comment out the use of hildon_notification_set_sound() because it is
1381 not declared, to fix the build. Warnings are serious, people.
1383 2007-06-21 Armin Burgmeier <armin@openismus.com>
1385 * src/maemo/modest-maemo-utils.h:
1386 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1387 modest_maemo_utils_get_supported_secure_authentication_methods()
1388 to query authentication methods for a specific user. This should fix
1389 projects.maemo.org bug NB#61369.
1391 * src/maemo/easysetup/modest-easysetup-wizard.c:
1392 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1395 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1397 * libmodest-dbus-client/libmodest-dbus-client.h:
1398 * libmodest-dbus-client/libmodest-dbus-client.c:
1399 (modest_dbus_message_iter_get_search_hit),
1400 (libmodest_dbus_client_search):
1401 Reorganised and commented this.
1402 Removed modest_search_hit_free() from the public API because it
1405 Added libmodest_dbus_client_get_folders() and
1406 modest_folder_result_list_free().
1408 * src/dbus_api/modest-dbus-api.h:
1409 * src/dbus_api/modest-dbus-callbacks.c:
1410 (modest_dbus_req_filter): Commented. Moved most code to
1411 on_dbus_method_search() and added on_dbus_method_get_folders().
1413 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1414 of the extra D-Bus handler.
1416 * tests/dbus_api/Makefile.am:
1417 * tests/dbus_api/test_get_folders.c: New test for
1418 libmodest_dbus_client_get_folders(). This seems to return an empty list
1419 at the moment. That could be the same error that causes the message list
1420 to be empty sometimes.
1421 This should help with projects.maemo.org bug NB#57740.
1423 2007-06-21 Armin Burgmeier <armin@openismus.com>
1425 * src/modest-mail-operation.c: Do not call
1426 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1427 notify the operation's end after having set the status to CANCELED for
1428 the operation queue to listen on. This fixes a deadlock when there
1429 were mail operations in the queue during its finalization.
1431 * src/modest-singletons.c: Reordered uninitialization of the account
1432 manager to happen after the mail operation queue was uninitialized
1433 because the mail operation's in the queue might still try to access
1434 the account manager (see modest_mail_operation_notify_end()). This
1435 fixes a potential crash when terminating the application.
1437 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-search.c:
1440 (search_mime_part_and_child_parts): Moved some code here so we
1441 can search recursively in child folders.
1442 (modest_search_folder): Search in the message as a mime part, instead
1443 of just its child mime parts.
1444 (read_chunk), (search_mime_part_ogs):
1445 Check how many bytes were read, to prevent an endless loop.
1446 Searching in message bodies now works. This finishes the fix for
1447 projects.maemo.org bug NB#61007.
1449 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1452 Add a g_warning when the item is not a folder.
1454 * src/modest-ui-dimming-rules.c:
1455 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1456 when selected item is not a folder (for instance, an account), because
1457 the UI spec only talks about folders.
1458 I am not sure what the UI spec wants, so this might not totally fix
1459 projects.maemo.org bug NB#60794.
1461 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1464 (load_from_file): Sort the list. The unsorted list would be more noticeable
1465 in non-English locales.
1467 * src/maemo/modest-msg-edit-window.c:
1468 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1469 warning and fix the build.
1471 * src/maemo/modest-progress-bar-widget.c:
1472 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1473 avoid a g_warning, and probably to avoid a crash.
1475 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1477 * src/modest-search.c: (modest_search_folder): Check for a GError
1478 when calling tny_folder_get_headers(), to show that this is not the cause
1481 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1483 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1484 Actually set the body query instead of the subject query.
1486 * src/modest-search.c: (search_mime_part_ogs),
1487 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1488 which would probably cause it to fail if we got this far.
1490 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1491 to simplify the code.
1492 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1493 be causing search-in-body to fail.
1495 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1497 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1499 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1500 Better debug message when the folder cannot be found.
1501 This should help with fixing projects.maemo.org bug #61287.
1502 * src/modest-search.c: (add_hit): Do not leak the furl string.
1504 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-ui-actions.c:
1507 (modest_ui_actions_on_folder_selection_changed):
1508 Do not special-case TNY_MERGE_FOLDER here, because
1509 modest_tny_folder_get_account() already does that. This fixes
1510 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1511 shown when the Outbox was selected).
1513 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1515 * libmodest-dbus-client/libmodest-dbus-client.c:
1516 (_dbus_iter_get_string_or_null): Initialize the string variable in
1517 case this helps with Dirk's crash.
1519 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1521 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1522 though it is not implemented yet (this function is maybe not even used),
1523 to avoid breaking ABI in future.
1524 * libmodest-dbus-client/libmodest-dbus-client.c:
1525 (get_attachments_string): Moved some code into this generic function.
1526 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1527 sends email. It is maybe not used.
1528 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1529 (on_send_mail): Use attachments.
1531 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1532 * src/maemo/modest-msg-edit-window.c:
1533 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1534 a filename before using it, to fix projects.maemo.org bug NB#58233.
1536 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1539 Initialize the continue_download variable to fix the build, and probably
1540 to fix randome behaviour.
1542 2007-06-18 Armin Burgmeier <armin@openismus.com>
1544 * src/modest-tny-send-queue.h:
1545 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1546 the queue so we can later show it in the UI. Replaced
1547 modest_tny_send_queue_msg_is_being_sent() by
1548 modest_tny_send_queue_get_msg_status().
1550 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1552 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1553 gpointer. This probably was not harmful, but just to be sure.
1555 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1557 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1558 Fix the build, but leave the function broken on Bora, because
1559 hildon_uri_action_get_service() does not exist.
1560 osso_uri_action_get_service() does not exist either, it seems.
1562 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1564 * src/modest-tny-account.c:
1565 (modest_tny_account_new_from_server_account):
1566 Uncommented the url debug output again, because it is useful for
1567 debugging, as I said in the comment.
1569 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1571 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1573 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1574 for Mameo Bora, to fix the build.
1576 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1579 Fixed build with hildon < 0.99
1581 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1582 Check if the selected account is busy instead of checking all accounts
1584 * src/modest-account-mgr-priv.h:
1585 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1586 (modest_account_mgr_init), (compare_account_name),
1587 (modest_account_mgr_set_account_busy),
1588 (modest_account_mgr_account_is_busy):
1589 * src/modest-account-mgr.h:
1590 Added busy information to the account manager. It possible to
1591 set an account to busy or not busy now.
1593 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1594 (modest_mail_operation_update_account),
1595 (modest_mail_operation_notify_end):
1596 Set the account to busy/not busy depending on the operation state.
1598 * src/widgets/modest-account-view.c:
1599 (modest_account_view_finalize), (get_last_updated_string),
1600 (update_account_view), (on_account_busy_changed), (init_view):
1601 Show string "Refreshing..." if the account is currently busy.
1603 All this fixes projects.maemo.org bug NB#59711
1605 2007-06-14 Armin Burgmeier <armin@openismus.com>
1607 * src/widgets/modest-attachments-view.h:
1608 * src/widgets/modest-attachments-view.c: Added
1609 modest_attachments_view_has_attachments() and fixed coordinate
1610 transformation in get_att_view_at_coords(). This fixes attachment
1613 * src/widgets/modest-msg-view.c: Make use of
1614 modest_attachments_view_has_attachments() to decide whether to show
1615 attachments in the header.
1617 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1619 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1620 (on_change), (on_combo_security_changed),
1621 (modest_connection_specific_smtp_edit_window_init),
1622 (modest_connection_specific_smtp_edit_window_set_connection),
1623 (modest_connection_specific_smtp_edit_window_is_dirty):
1624 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1625 * src/maemo/modest-connection-specific-smtp-window.c:
1628 Show an comfirmation dialog for the smpt-edit-window if there are
1629 unsaved changes and the user hits cancel.
1630 (projects.maemo.org bug NB#60479)
1632 2007-06-14 Armin Burgmeier <armin@openismus.com>
1634 * src/maemo/easysetup/modest-easysetup-wizard.c:
1635 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1636 address" info in banner instead of node, and select all the text as
1637 per UI spec. This fixes projects.maemo.org bug NB#60550.
1639 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1641 reviewed by: <delete if not using a buddy>
1643 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1644 * src/modest-ui-actions.c: (folder_refreshed_cb):
1646 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1648 * src/widgets/modest-folder-view.c: (filter_row):
1649 Explictly filter out the per-account outbox accounts. I don't know why
1650 these only sometimes show up, but now they should never show up in the UI.
1651 This should fix projects.maemo.org bug NB#60160.
1653 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1655 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1656 when the toolbar does not exist yet.
1657 * src/modest-widget-memory.c: (save_settings_header_view):
1658 Added g_warnings() to help us to discover when we are trying to set
1659 an empty columns list in gconf.
1661 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-init.h:
1664 * src/modest-init.c:
1665 Added modest_init_get_default_header_view_column_ids().
1667 * src/modest-widget-memory.c: (restore_settings_header_view):
1668 Use the new function to get defaults, if the gconf key is empty,
1669 instead of not creating any columns. This seems to fix the
1670 empty right-hand pane problems.
1672 * src/widgets/modest-header-view.h: Improved documentation.
1674 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1676 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1677 Revert the use of the display name as the account name, because this
1678 is generally wrong and would break the code that follows.
1680 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1682 * src/maemo/easysetup/modest-easysetup-wizard.c:
1683 (check_for_supported_auth_methods), (on_before_next),
1686 More correct fix for projects.maemo.org bug NB# 58991
1687 Do not longer accept AUTH_PASSWORD as secure method and choose
1688 correct method when creating the account.
1690 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1692 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1693 Fixed projects.maemo.org bug NB# 58991
1695 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1697 * src/modest-init.c: (modest_init_init_core),
1698 (modest_init_local_folders): Fixed compilation errors.
1700 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1702 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1703 Remove unnecessary lib/include, though it is good in principle when needed.
1705 * src/modest-init.c: (modest_init_one_local_folder),
1706 (modest_init_local_folders):
1707 * src/modest-init.h: Initialize the .modest library for memory cards,
1708 instead of just doing nothing for them. This should allow us to create
1709 folders there, fixing projects.maemo.org bug NB#59297.
1711 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1713 * libmodest-dbus-client/libmodest-dbus-client.c:
1714 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1715 (libmodest_dbus_client_compose_mail),
1716 (libmodest_dbus_client_open_message),
1717 (libmodest_dbus_client_send_and_receive),
1718 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1720 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1721 (on_idle_open_message), (modest_dbus_req_handler),
1722 (search_result_to_message), (modest_dbus_req_filter):
1723 * src/modest-search.c: (add_hit), (modest_search_folder),
1724 (modest_search_all_accounts): Improved debug messages.
1726 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1728 * src/modest-tny-account-store.c:
1729 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1732 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1735 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-tny-account-store.c: (get_server_accounts):
1738 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1739 even when there are no accounts, so that the Outbox folder is always
1740 visible. This fixes projects.maemo.org bug NB#60158.
1742 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/modest-main-window.c: (create_details_widget):
1745 Use the mcen_va_never logical ID.
1747 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1749 * src/dbus_api/modest-dbus-api.h:
1750 * src/dbus_api/modest-dbus-callbacks.c:
1751 (on_idle_open_default_inbox), (on_open_default_inbox),
1752 (modest_dbus_req_handler):
1753 Added a new OpenDefaultInbox method.
1755 * libmodest-dbus-client/libmodest-dbus-client.h:
1756 * libmodest-dbus-client/libmodest-dbus-client.c:
1757 Added libmodest_dbus_client_open_default_inbox() to call the new
1758 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1759 though it should maybe be used by a new osso-email-interface function.
1761 * tests/dbus_api/Makefile.am:
1762 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1765 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1768 NULL, so that the signals get all the keys. This should not actually
1769 change any behaviour because we currently update everything when anything
1772 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1774 * src/widgets/modest-folder-view.c: (text_cell_data),
1775 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1776 (find_inbox_iter): If tinymail tells us that the folder is
1777 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1778 This causes the inbox to be selected at startup, fixing part of
1779 projects.maemo.org bug NB#56305.
1781 * src/modest-ui-dimming-rules.c:
1782 (modest_ui_dimming_rules_on_tools_smtp_servers):
1783 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1784 the SMTP servers menu item.
1785 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1786 that the SMTP Servers menu item is dimmed when there are no accounts,
1787 as a future version of the UI spec will require. This fixes
1788 projects.maemo.org bug NB#56305.
1790 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1792 * src/maemo/modest-maemo-utils.c:
1793 (modest_maemo_utils_get_supported_secure_authentication_methods):
1794 Added label to dialog instead of unreadable title
1796 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1797 (modest_main_window_new):
1798 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1801 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1802 * src/modest-account-mgr.h:
1803 Added method to avoid code duplication
1805 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1806 (modest_ui_actions_on_send_receive):
1807 Use modest_account_mgr_has_accounts
1809 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1811 * src/maemo/easysetup/modest-presets.c:
1812 (modest_presets_get_info_server_security): Do not report secure auth
1814 * src/modest-protocol-info.c: Use the defines for the gconf key names
1815 for secure authentication. This was not working because we were writing
1816 Password and reading password, and the check was case sensitive.
1817 With this, gmail now works for receiving and sending when created via
1820 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1822 * src/maemo/easysetup/modest-presets.c:
1823 (modest_presets_get_info_server_security): Correct the key name for
1824 SecureSmtp, because it seems to be case-sensitive.
1825 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1826 Do not try to get the 0th notebook page if there are 0 pages, to
1827 avoid a g_warning().
1829 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1831 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1832 Prevent use of the new notification feature for now, because it currently
1833 shows one dialog for each new email, which is annoying.
1835 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1837 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1838 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1839 when no country was selected, so that we show the global ones.
1840 * src/maemo/easysetup/modest-presets.c:
1841 (modest_presets_get_providers): Return only the global providers, not
1842 all providers when mmc=0 was requested.
1844 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1847 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1848 provider ID in the combo.
1850 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1851 Do not show the page numbers, because it would be confusing when we add
1852 the 2 extra pages for the custom setup, when the user chooses the "Other"
1853 provider. This fixes projects.maemo.org bug NB#59028
1855 * src/modest-init.c: (modest_init_init_core),
1856 (modest_init_local_folders):
1857 * src/modest-init.h:
1858 * src/modest-tny-account.c:
1859 (modest_tny_account_new_for_local_folders): Do not create default folders
1860 for the memory card. This should fix projects.maemo.org bug NB#59328.
1862 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1864 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1865 Free the changed_conf_keys string items. They are already freed in the
1866 idle handler if that runs first.
1868 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1870 * src/modest-ui-actions.c:
1871 (modest_ui_actions_on_password_requested): Check that the server name
1872 is not NULL, because I just saw a password dialog with (null) as the
1875 * src/modest-tny-folder.[h|c]: Added
1876 modest_tny_folder_is_memory_card_folder().
1877 * src/modest-ui-dimming-rules.c:
1878 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1879 menu item for memory cards, as per the UI spec (section 7.4). This should
1880 fix projects.maemo.org bug NB#59297.
1882 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1884 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1885 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1886 is another problem with the code, see Murray's comment at line 772)
1888 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1890 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1891 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1892 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1893 (load_from_file), (easysetup_country_combo_box_init),
1894 (easysetup_country_combo_box_get_active_country_ids),
1895 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1896 instead of just one ID, to avoid duplicate country names in the UI.
1898 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1899 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1900 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1901 a single ID, avoiding duplicate providers.
1902 * src/maemo/easysetup/modest-easysetup-wizard.c:
1903 (on_combo_account_country): Adapt to use a list.
1905 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1907 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1908 keys changed in the last X seconds.
1910 * src/modest-account-mgr.h:
1911 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1912 (on_key_change), (modest_account_mgr_class_init),
1913 (modest_account_mgr_init), (modest_account_mgr_finalize):
1914 As the keys are changed, save them in a GSList* and signal that GSList*
1915 further every X seconds, to batch changes, to allow us to do just one
1916 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1917 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1919 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1920 changed signal signature.
1922 * src/modest-conf.c: (modest_conf_set_list),
1923 (modest_conf_on_change): Reenable notification.
1925 (modest_conf_maemo_fake_on_change): Comment out the hack that
1926 notified immediately instead of asynchronously.
1928 * src/widgets/modest-account-view.h:
1929 * src/widgets/modest-account-view.c:
1930 (update_account_view): Select the previously-selected account ID,
1931 if possible. This fixes projects.maemo.org bug NB#56933.
1933 (on_account_changed), (on_account_removed),
1934 (modest_account_view_select_account):
1936 Remove the block/unblock functions
1937 because they were not useful.
1939 * src/maemo/modest-account-view-window.c:
1940 (on_delete_button_clicked), (on_edit_button_clicked),
1941 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1943 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1946 Improve the error dialog to show Incorrect Account Settings, which seems
1947 clearer, and say that the internal error message (to be removed from the
1948 dialog later) is often misleading.
1949 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1951 * src/modest-tny-account.c:
1952 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1953 URL because this is so useful for debugging on the device.
1955 * src/widgets/modest-serversecurity-combo-box.c:
1956 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1958 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-mail-operation.c:
1961 (modest_mail_operation_send_new_mail):
1962 Added a comment about a nasty but apparently harmless message. Details
1963 added to the wiki g_warnings() page.
1965 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1968 (modest_tny_send_queue_class_init):
1969 Do not use the priv struct because it is empty, to avoid g_warnings
1970 about a non-existant priv struct.
1972 * src/modest-tny-account-store.c:
1973 (modest_tny_account_store_get_server_account),
1974 (modest_tny_account_store_get_transport_account_for_open_connection
1975 ): Do not try to get transport server accounts for local folders,
1976 because they don't have any. This avoids a g_warning().
1978 * src/maemo/modest-main-window.c:
1979 (modest_main_window_notify_send_receive_initied),
1980 (on_configuration_key_changed):
1981 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1982 * src/modest-defs.h:
1983 * src/modest-mail-operation.c:
1984 (modest_mail_operation_update_account):
1985 * src/modest-tny-account-store.h:
1986 * src/modest-tny-account.c:
1987 (modest_tny_account_get_special_folder),
1988 (modest_tny_account_new_for_local_folders),
1989 (modest_tny_account_new_for_per_account_local_outbox_folder):
1990 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1991 * src/modest-tny-local-folders-account.c:
1992 (add_account_folders_to_merged_folder):
1993 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1994 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1995 (modest_ui_actions_on_send):
1996 * src/widgets/modest-folder-view.c: (update_model):
1997 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1998 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1999 modest_tny_account_store_get_tny_account_by_account() to
2000 modest_tny_account_store_get_server_account() to make the code clearer.
2002 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2004 * src/dbus_api/modest-dbus-api.h:
2005 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2006 * src/maemo/modest-msg-edit-window.c:
2007 (modest_msg_edit_window_attach_file_noninteractive):
2008 added g_warning in case the file to be attached does not exist
2009 * tests/dbus_api/test_compose_mail.c: (main):
2010 removed obsolete comment, added generic files as test case
2012 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2014 * src/modest-tny-account-store.c: (get_server_accounts):
2015 Create the local folders account only once, not once for each outbox, and
2016 not only when there are some outboxes.
2018 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2020 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2021 code that is causing a crash at startup. Sergio says that he is fixing this.
2023 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2025 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2026 * src/maemo/modest-account-settings-dialog.c:
2027 (create_page_outgoing),
2028 (modest_account_settings_dialog_set_account_name),
2029 (save_configuration):
2030 - Fixed handling of the "Use secure authentication" toggle to comply with
2031 the ui specification. See also projects.maemo.org bug NB#58400
2033 - Restore the Secure connection setting combo correctly when loading
2036 * src/maemo/modest-maemo-utils.c:
2037 (on_camel_account_get_supported_secure_authentication),
2038 (modest_maemo_utils_get_supported_secure_authentication_methods):
2039 Fixed a crasher if operation is canceled
2041 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2042 (modest_protocol_info_auth_is_secure):
2043 * src/modest-protocol-info.h:
2045 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2046 the sense of the "Use secure authentication" toggle.
2048 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2050 * src/modest-tny-account-store.h:
2051 * src/modest-tny-account-store.c:
2052 Added modest_tny_account_store_get_local_folders_account().
2054 * src/modest-tny-folder.h:
2055 * src/modest-tny-folder.c:
2056 (modest_tny_folder_get_account):
2057 Added this replacement for tny_folder_get_account() which returns
2058 the local-folders account for TnyMergeFolders, to avoid the
2059 warning about the unimplemented get_account_func() vfunc().
2061 (modest_tny_folder_get_rules),
2062 * src/modest-ui-actions.c:
2063 (modest_ui_actions_on_folder_selection_changed):
2064 * src/modest-mail-operation.c:
2065 (modest_mail_operation_remove_folder),
2066 (modest_mail_operation_xfer_folder),
2067 (modest_mail_operation_rename_folder),
2068 (modest_mail_operation_get_msg),
2069 (modest_mail_operation_get_msgs_full),
2070 (modest_mail_operation_remove_msg),
2071 (modest_mail_operation_xfer_msgs),
2072 (modest_mail_operation_refresh_folder):
2073 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2075 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2078 (modest_server_account_set_security):
2079 * src/modest-defs.h: Add comments explaining that our
2080 UI spec means TLS when it says Normal, so these do not look like errors.
2082 * src/modest-tny-account.c:
2083 (modest_tny_account_new_from_server_account): Use the new tinymail
2084 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2085 for TLS. This should fix projects.maemo.org bug NB#58460.
2087 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2089 * src/maemo/easysetup/modest-easysetup-wizard.c:
2090 (create_account): Correct the position of the gconf sanity check warning.
2091 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2092 of using the g_idle_add() hack, because this does not seem to be necessary
2093 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2094 caused by something other than maemo's gconf.
2095 This fixes projects.maemo.org bug #59022.
2097 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-account-mgr-helpers.c:
2100 (modest_account_mgr_get_default_account): Do not check that the account
2101 exists if there is no default account (NULL), to fix a runtime warning.
2103 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2105 * src/widgets/modest-folder-view.c: (update_model):
2106 Do not unref the treemodel before we have finished with it.
2107 This prevents a valgrind warning and an occasional crash at startup.
2109 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2111 * libmodest-dbus-client/libmodest-dbus-client.h:
2112 added libmodest_dbus_client_compose_mail()
2113 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2115 added functions needed for SendAsMail() functionality
2116 * src/maemo/modest-msg-edit-window.c:
2117 (modest_msg_edit_window_attach_file_noninteractive):
2118 non interactively attaching files to message edit window
2119 * src/widgets/modest-msg-edit-window.h:
2120 * tests/dbus_api/Makefile.am:
2121 added test_compose_mail.c
2122 * tests/dbus_api/test_compose_mail.c: (main):
2124 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2126 * src/modest-account-view.c:
2127 Fixed bug projects.maemo.org bug NB#59307
2129 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2131 * src/maemo/easysetup/modest-easysetup-wizard.c:
2132 (get_serverport_incoming), (on_before_next), (create_account):
2133 * src/maemo/modest-account-settings-dialog.c:
2134 (modest_account_settings_dialog_set_account_name):
2135 * src/maemo/modest-maemo-utils.c:
2136 (on_camel_account_get_supported_secure_authentication_status),
2137 (on_camel_account_get_supported_secure_authentication),
2138 (on_secure_auth_cancel),
2139 (modest_maemo_utils_get_supported_secure_authentication_methods):
2141 Implemented security authentication for settings and easysetup.
2143 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2145 * src/maemo/modest-main-window.c: (create_details_widget):
2146 Show the total size for memory card accounts too, instead of showing
2147 the name again. Fixes bug projects.maemo.org bug NB#59307.
2149 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2152 * src/modest-tny-simple-folder-store.c:
2153 * src/modest-tny-simple-folder-store.h: Removed.
2155 * src/modest-tny-local-folders-account.h
2156 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2157 for the local-folders maildir, with an extra TnyMergedFolder containing
2158 the folders of the per-account outbox store accounts.
2159 * src/modest-tny-account-store.c: (get_server_accounts):
2160 Add the outboxes to the special local folders account after creating it.
2162 * src/modest-tny-account.c:
2163 (modest_tny_account_new_for_local_folders): Create the derived
2164 account when creating the main local-folders account.
2166 * src/maemo/modest-main-window.c: (create_details_widget),
2167 (modest_main_window_set_contents_style):
2168 Adapted to the use of the derived account instead of the folder store.
2170 * src/modest-ui-actions.c:
2171 (modest_ui_actions_on_folder_selection_changed):
2172 * src/modest-ui-dimming-rules.c:
2173 (modest_ui_dimming_rules_on_new_folder):
2174 * src/widgets/modest-folder-view.c: (text_cell_data),
2175 (icon_cell_data), (filter_row), (update_model),
2176 (get_cmp_rows_type_pos):
2179 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2180 Do not get the priv struct, because no priv struct has been set,
2181 to avoid a runtime warning.
2183 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2184 #ifelse with #else, to fix a warning, to fix the build.
2187 2007-06-05 Christian Kellner <ckellner@openismus.com>
2189 * libmodest-dbus-client/libmodest-dbus-client.c:
2190 Fix small typo in doc (why do you always see them
2191 AFTER committing stuff?)
2194 2007-06-05 Christian Kellner <ckellner@openismus.com>
2196 * libmodest-dbus-client/libmodest-dbus-client.c:
2197 (libmodest_dbus_client_search):
2198 Initialize hit list with NULL. Also set folder list
2199 to "" if NULL was supplied.
2202 2007-06-03 Christian Kellner <ckellner@openismus.com>
2204 * libmodest-dbus-client/libmodest-dbus-client.c:
2205 (modest_search_hit_list_free):
2206 Make it save to call it with NULL.
2208 * src/dbus_api/modest-dbus-callbacks.c:
2209 * src/modest-search.c:
2210 Return full ModestSearchHits as the search result list not TnyHeader
2211 since can't be around withouth the correspoding TnyFolder.
2213 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2215 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2216 Added currently commented code to check for secure auth
2218 * src/maemo/modest-account-settings-dialog.c: (on_response),
2219 (save_configuration), (show_ok):
2220 Fixed projects.maemo.org bugs NB #59248 and #59251
2222 * src/maemo/modest-maemo-utils.c:
2223 (on_camel_account_get_supported_secure_authentication_status),
2224 (on_camel_account_get_supported_secure_authentication),
2225 (modest_maemo_utils_get_supported_secure_authentication_methods):
2226 * src/maemo/modest-maemo-utils.h:
2227 Moved get_supported_secure_authentication() method here to be able
2228 to use it from easysetup wizard.
2230 * src/modest-pair.c: (on_pair_compare_as_string):
2231 Should compare string with first part of pair and not
2232 strcmp pairs which will crash.
2234 * src/modest-protocol-info.c:
2235 (modest_protocol_info_protocol_is_store):
2236 * src/modest-protocol-info.h:
2237 Added modest_protocol_info_get_auth_protocol_name()
2239 2007-06-03 Armin Burgmeier <armin@openismus.com>
2241 * src/modest-mail-operation.c:
2242 (modest_mail_operation_get_msgs_full): Set priv->account also when
2243 only retrieving a single message. This avoids a crash when canceling
2246 (modest_mail_operation_notify_end): Do not explicitely remove the
2247 operation from the queue but only emit the progress_changed signal.
2248 The queue itself listens to that signal to remove the operation when
2249 it is finished. This reduces coupling and removes a potential deadlock
2250 when modest_mail_operation_notify_end() is called from the queue
2251 itself. If that is a problem performance-wise, I would suggest to
2252 implement a status-changed signal or something.
2254 * src/modest-mail-operation-queue.c: Make sure to never call a
2255 function from another file while the queue is locked. This (hopefully)
2256 fixes another deadlock when exiting the application while retrieving
2259 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2261 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2262 Fixed build if libogs is not available
2264 2007-06-03 Christian Kellner <ckellner@openismus.com>
2266 * libmodest-dbus-client/libmodest-dbus-client.h:
2267 * libmodest-dbus-client/libmodest-dbus-client.c:
2268 (libmodest_dbus_client_delete_message):
2269 Implement deletion of messages (Client side).
2271 (modest_search_hit_free),
2272 (modest_search_hit_list_free):
2273 Utility functions to free the result hits.
2275 * src/dbus_api/modest-dbus-api.h:
2276 * src/dbus_api/modest-dbus-callbacks.c:
2277 (on_delete_message),
2278 (modest_dbus_req_handler):
2279 Implement deletion of messages (Server side).
2281 * tests/dbus_api/test_search.c: (main):
2284 * tests/dbus_api/Makefile.am:
2285 * tests/dbus_api/test_delete_message:
2286 Add little test for the message deletion logic
2288 2007-06-03 Armin Burgmeier <armin@openismus.com>
2290 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2291 when the operation queue was not empty. projects.maemo.org bug
2294 2007-06-03 Armin Burgmeier <armin@openismus.com>
2296 * src/widgets/modest-account-view.c
2297 (on_account_default_toggled): Toggle default account column
2298 explicitely instead of waiting for gconf notification (which is
2299 currently ignored). This should fix projects.maemo.org bug NB#56910
2300 for now. It should probably be removed when gconf notifications are
2303 2007-06-03 Christian Kellner <ckellner@openismus.com>
2305 * libmodest-dbus-client/libmodest-dbus-client.c:
2306 Removed debugging spew.
2308 * src/dbus_api/modest-dbus-callbacks.c:
2309 Added debugging info.
2311 * src/modest-search.c:
2312 (modest_search_all_accounts):
2313 Use tny_account_store_get_accounts () on the account store
2314 to get all accounts which is the way to get all accounts.
2316 * tests/dbus_api/test_search.c: (main):
2317 Make it possible to supply the search term on the command line.
2319 2007-06-03 Christian Kellner <ckellner@openismus.com>
2321 * libmodest-dbus-client/libmodest-dbus-client.c:
2322 * libmodest-dbus-client/libmodest-dbus-client.h:
2323 Implement searching for mesages over raw dbus. (Client side)
2325 * src/dbus_api/Makefile.am:
2326 * src/dbus_api/modest-dbus-api.h:
2327 * src/dbus_api/modest-dbus-callbacks.c:
2328 * src/dbus_api/modest-dbus-callbacks.h:
2329 Search framework (Server side). Also implement on_idle_open_message().
2331 * src/maemo/modest-platform.c: (modest_platform_init):
2332 Prepare for raw dbus/osso rpc interaction.
2334 * src/modest-search.h:
2335 Changed minsize from unspecific guint to guint32.
2337 * src/modest-search.c:
2339 Added strange hack which magically made tnymail work.
2341 (modest_search_folder),
2342 (modest_search_account),
2343 (modest_search_all_accounts):
2344 Implement helper functions to search all accounts, specific account
2347 * tests/dbus_api/Makefile.am:
2348 * tests/dbus_api/test_open_message.c:
2349 Read url to open from commandline.
2351 * tests/dbus_api/test_search.c:
2352 Implement small test for dbus search stuff
2354 2007-06-02 Armin Burgmeier <armin@openismus.com>
2356 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2357 include account type and account title. This fixes projects.maemo.org
2360 * src/maemo/modest-account-view-window.c: Set a title for the window.
2362 2007-06-02 Armin Burgmeier <armin@openismus.com>
2364 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2365 incoming and outgoing server name based on email address and server
2366 types as long as the names have not been edited manually. This fixes
2367 projects.maemo.org bug NB#58671.
2369 2007-06-02 Armin Burgmeier <armin@openismus.com>
2371 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2372 server type cannot be changed in future to the incoming details page
2373 when creating an account. This fixes projects.maemo.org bug NB#59029.
2375 2007-06-02 Armin Burgmeier <armin@openismus.com>
2377 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2378 and assigned max width chars so that they wrap instead of being
2379 truncated. Fixes projects.maemo.org bug NB#56126.
2381 2007-06-02 Armin Burgmeier <armin@openismus.com>
2383 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2384 introductory note to the connection specific smtp servers dialog, as
2385 section 8.12 of the email UI specification requires. This fixes
2386 projects.maemo.org bug NB#59212.
2388 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2390 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2391 Check for running mail operations, and offer to cancel them, as per the UI
2392 spec. This fixes projects.maemo.org bug NB#59041 .
2393 However, I suspect that tinymail may still use the network connection
2394 in ways that we cannot detect or cancel. But it should at least adapt to
2395 changes fairly well.
2397 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2399 * src/modest-tny-account-store.c: (recreate_all_accounts),
2400 (get_cached_accounts), (get_server_accounts): Do more sensible
2401 ref-counting of the temporarily-cached outbox accounts list. This seems
2402 to fix a crash when entering the password when the password was wrong.
2404 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2406 * src/gnome/modest-main-window.c: (connect_signals):
2407 * src/modest-tny-account-store.c: (get_password),
2408 (modest_tny_account_store_alert): Added comments and clues and
2409 commented-out code about how we currently fail to deal with connection
2410 errors and wrong passwords, and how we should.
2412 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2414 * src/widgets/modest-retrieve-combo-box.c:
2415 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2416 This fixes projects.maemo.org bug NB#58472 .
2418 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2420 * src/maemo/easysetup/modest-easysetup-wizard.c:
2421 (create_page_complete_easysetup):
2422 (create_page_complete_custom): Correct the last commit,
2423 putting the correct sentences in the correct pages.
2425 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2427 * src/maemo/easysetup/modest-easysetup-wizard.c:
2428 (create_page_complete_custom): Show the second sentence of text
2429 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2432 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2435 Set the leave-on-server conf key by default. This fixes
2436 projects.maemo.org bug NB#59258 .
2438 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2440 * src/maemo/modest-account-view-window.c:
2441 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2442 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2445 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/easysetup/modest-easysetup-wizard.c:
2448 (create_caption_new_with_asterisk):
2449 * src/maemo/modest-account-settings-dialog.c:
2450 (create_caption_new_with_asterisk):
2451 Uncomment the code to add the asterisk, because they are no longer in the
2452 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2453 (update_incoming_server_title): Add an asterisk here too.
2455 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2457 * src/maemo/modest-maemo-global-settings-dialog.c:
2458 (current_connection): Check that we are even connected before trying to
2459 get the current connection name, to prevent a warning.
2461 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2462 Change the comments because tny_maemo_conic_device_connect() is now meant to
2464 * src/modest-mail-operation.c:
2465 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2466 make sure we have a connection and fail if we can't connect.
2468 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2470 * src/maemo/modest-main-window.c:
2471 (on_account_store_connecting_finished): Do not try to get the
2472 connection ID if we are not really connected. I am surprised that
2473 this signal handler is called when we are not connected.
2475 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2477 * src/modest-error.h:
2478 * src/modest-ui-actions.c:
2479 (modest_ui_actions_get_msgs_full_error_handler):
2480 Renamed an enum, added comments, added an enum
2481 for retrieve-limit errors.
2483 * src/modest-mail-operation.c: (foreach_add_item),
2484 (internal_folder_observer_update), (update_account_thread),
2485 (modest_mail_operation_get_msgs_full):
2486 (modest_mail_operation_update_account),
2487 Added comments about how this works, and some code that should
2488 (but does not) check the retrieve-limit. See the TODO comment.
2490 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2492 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2493 Initialize help_id to fix the build. Warnings are good.
2495 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2497 * src/widgets/modest-hbox-cell-renderer.c:
2498 (modest_hbox_cell_renderer_append):
2499 * src/widgets/modest-vbox-cell-renderer.c:
2500 (modest_vbox_cell_renderer_append):
2501 Fix the last commit by doing an extra ref.
2503 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2505 * src/widgets/modest-hbox-cell-renderer.c:
2506 (modest_hbox_cell_renderer_append):
2507 * src/widgets/modest-vbox-cell-renderer.c:
2508 (modest_vbox_cell_renderer_append):
2509 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2510 to fix the build with Maemo Bora.
2511 However, there seems to be a remaining crash, probably due to reference
2514 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2516 * src/modest-tny-account.c:
2517 (modest_tny_account_new_for_local_folders):
2518 Use hildon_file_system_info_async_new() to get a better name for
2519 the memory card account, setting it as the account name.
2520 The timing seems to work, but this is probably
2521 not the best place to do this. See the TODO comment.
2522 * src/maemo/modest-main-window.c: (create_details_widget):
2523 * src/widgets/modest-folder-view.c: (text_cell_data):
2524 Use the tny account name instead of hardcoding a name.
2526 2007-05-30 Christian Kellner <ckellner@openismus.com>
2528 * src/modest-search.c: (modest_search):
2529 Correctly set part_search_func even if we have already parsed
2530 the query and thus a valid OgsTextSearcher object.
2532 2007-05-30 Christian Kellner <ckellner@openismus.com>
2535 Search and check for libogs.
2538 Incooparte the ogs build env.
2540 * src/modest-mime-part-search-stream.c:
2541 * src/modest-mime-part-search-stream.h:
2542 Removed since we do the real searching now in modest-search.c.
2544 * src/modest-search.c:
2545 * src/modest-search.h:
2546 Implement support for ogs. We use that if available and requested
2547 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2548 should now handle the corner case when the search term is spread
2549 across multiple reads.
2550 Also the logic in modest_search () was corrected to search all
2551 requested fields until one is found.
2553 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2555 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2557 * src/modest-init.h:
2558 * src/modest-init.c: Made modest_init_local_folders() take a
2559 path and be public so we can iniitialize maildir folders on
2562 * src/modest-local-folder-info.h:
2563 * src/modest-local-folder-info.c:
2564 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2566 * src/modest-tny-account.c:
2567 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2568 still means the standard local-folders path on the local volume.
2570 * src/modest-tny-account-store.c:
2571 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2572 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2573 all accounts when that happens.
2574 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2575 this too, so it shows up in the treeview.
2577 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-maemo-global-settings-dialog.c:
2580 (current_connection):
2581 * src/widgets/modest-global-settings-dialog.c:
2582 (current_connection_default):
2583 Use the enum values instead of 0, 1 and -1,
2584 to make the code clearer.
2586 * src/modest-account-mgr-helpers.c:
2587 (modest_account_mgr_get_connection_specific_smtp): Make this code
2590 * src/modest-runtime.h:
2591 * src/modest-runtime.c:
2592 Added modest_runtime_remove_all_send_queues().
2593 * src/maemo/modest-main-window.c:
2594 (on_account_store_connecting_finished): Recreate the send queues,
2595 using the appropriate transport accounts for this new connection.
2596 Some futher adapting might be needed if the old send queues are not
2597 automatically stopped at this point.
2599 * src/modest-tny-account-store.c: (get_server_accounts):
2600 Create the connection-specific transport accounts, so that they can
2601 be found later by their ID.
2603 * src/modest-tny-account.h:
2604 * src/modest-tny-account.c:
2605 Added modest_tny_account_new_from_server_account_name().
2606 modest_tny_account_new_from_server_account(): Do not create the
2607 send queues here, because they will be
2608 recreated anyway when the connection changes for the first time.
2610 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2612 * src/modest-local-folder-info.h:
2613 * src/modest-local-folder-info.c:
2614 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2615 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2616 tbox_folder): Take a modest account name instead of a server TnyAccount,
2617 so we can have per-modest-account rather than per-transport-account
2619 We must make sure that we change or recreate the exisitng send queues
2620 when the connection changes for connection-specific transport accounts.
2622 * src/modest-tny-account-store.c:
2623 (create_per_account_local_outbox_folders): Create outboxed per modest
2624 account, not per transport account.
2626 * src/modest-tny-account.h:
2627 * src/modest-tny-account.c:
2628 (modest_tny_account_get_special_folder): For outboxes, get the
2629 parent modest account name. The account is ignored for other folders.
2630 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2631 modest account name rather than a server TnyAccount.
2633 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2635 * src/modest-tny-account.c:
2636 (modest_tny_account_new_from_server_account):
2637 Call modest_runtime_get_send_queue() immediately after creating transport
2638 accounts, so that they start trying to send email from the outbox as soon
2639 as possible at startup. This is probably what we want.
2641 * src/modest-mail-operation.c: (update_account_thread):
2642 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2643 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2644 * src/modest-tny-send-queue.h:
2645 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2646 (modest_ui_actions_on_send):
2647 Added comments about how sending works, though it needs some more work.
2649 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-tny-account.c:
2652 (modest_tny_account_get_special_folder): Add TODO because this fails when
2653 the network is busy.
2654 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2655 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2656 Do not try to show this window when there is no active account. The UI
2657 specs does not tell us what to do in this case.
2659 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2663 * src/maemo/Makefile.am:
2664 * src/widgets/Makefile.am: Some dist fixes.
2666 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-connection-specific-smtp-window.c:
2669 (on_button_edit): Make the code clearer, to prevent a double free.
2671 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/modest-account-settings-dialog.c:
2674 (modest_account_settings_dialog_set_account_name),
2675 Check the connection-specific smtp servers checkbox if there are any.
2677 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2678 (modest_connection_specific_smtp_edit_window_init):
2679 Start with a suitable port number.
2681 * src/modest-account-mgr-helpers.h:
2682 * src/modest-account-mgr-helpers.c: Added
2683 modest_account_mgr_get_has_connection_specific_smtp().
2685 (modest_account_mgr_set_connection_specific_smtp),
2686 (modest_account_mgr_remove_connection_specific_smtp),
2687 (modest_account_mgr_get_has_connection_specific_smtp),
2688 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2689 connection-specific smtp server accounts in the account, rather than
2690 the server account conf dir.
2692 This fixes bug projects.maemo.org bug NB#58263 .
2694 * src/modest-tny-account-store.c:
2695 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2696 if there are no server accounts yet, to prevent an infinite loop when there
2697 are no accounts. Document that one must be called before the other.
2699 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2701 * src/modest-account-mgr-helpers.c:
2702 (modest_account_mgr_get_default_account): Make sure that at least
2703 one account is always the default, if there are any enabled accounts.
2704 This is just a sanity check that shouldn't be necessary.
2706 * src/modest-account-mgr-priv.c:
2707 (_modest_account_mgr_account_from_key): Unescape the conf key to
2708 get the real account name. For instance, this is an issue if a space
2709 was in the account name, which can happen because the account name
2710 is generated from the display name.
2711 (_modest_account_mgr_get_account_keyname): Always escape the
2713 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2714 Unescape the conf keys to get the real account names.
2716 For instance, previously the is-default radio button in the accounts
2717 list was not checked for any accounts at first. This fixes that,
2718 and might fix several similar bugs.
2720 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2723 Removed some debug printfs.
2725 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2727 Modest on-disk outbox directories are now here, for instance:
2728 $HOME/.modest/outboxes/<account-id-1>/outbox
2729 $HOME/.modest/outboxes/<account-id-2>/outbox
2731 $HOME/.modest/local-folders/outbox
2732 so we can have a separate outbox for each account.
2733 But they are shown as one outbox in the GtkTreeView, by using a
2734 TnyMergeFolder in a ModestTnySimpleFolderStore.
2737 * src/modest-tny-simple-folder-store.c:
2738 * src/modest-tny-simple-folder-store.h:
2739 Added ModestTnySimpleFolderStore, used to contain folders from
2740 other folder stores, such as other accounts.
2742 * src/modest-tny-outbox-account.h:
2743 * src/modest-tny-outbox-account.c:
2744 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2745 used for the per-account local outbox folders.
2747 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2748 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2749 only use this (internally) now for the non-outbox local folders.
2751 * src/modest-init.h:
2752 * src/modest-init.c: Added modest_init_one_local_folder(), for
2753 setting up the directory structure for each local folder.
2755 * src/modest-local-folder-info.c:
2756 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2757 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2759 * src/modest-local-folder-info.h:
2760 * src/modest-tny-account-store.c: (on_account_removed),
2761 (on_account_changed), (create_per_account_local_outbox_folders),
2762 (get_server_accounts), (modest_tny_account_store_get_accounts),
2763 (modest_tny_account_store_get_tny_account_by_account),
2764 (modest_tny_folder_store_is_virtual_local_folders):
2766 * src/modest-tny-account.h:
2767 * src/modest-tny-account.c:
2768 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2769 to create an on-disk per-account local outbox folder for each
2771 (create_per_account_local_outbox_folders): Create a local outbox folder
2772 for each transport account.
2773 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2774 for all local folders.
2776 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2777 instead of using g_object_get/set() directly. It is clearer.
2779 (modest_tny_folder_store_get_message_count),
2780 (modest_tny_folder_store_get_local_size
2781 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2782 because we now use these with non-acount folder stores.
2784 (modest_tny_account_get_special_folder),
2785 (modest_tny_account_new_from_server_account),
2786 (modest_tny_account_new_from_account):
2787 (recurse_folders): Adjust to the new outbox system.
2789 * src/modest-tny-folder.h:
2790 * src/modest-tny-folder.c:
2791 (modest_tny_folder_is_local_folder),
2792 (modest_tny_folder_get_local_folder_type),
2793 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2795 * src/widgets/modest-main-window.h:
2796 * src/maemo/modest-main-window.c: (create_details_widget),
2797 (modest_main_window_set_contents_style): Show details for any folder store,
2800 (modest_tny_folder_get_rules):
2801 Remove the const. C does not support constness enough for this.
2803 * src/modest-ui-actions.c:
2804 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2805 make all outboxes appear as one, in the usual local-folders tree node.
2807 (set_active_account_from_tny_account),
2808 (modest_ui_actions_on_folder_selection_changed):
2809 * src/widgets/modest-folder-view.c: (text_cell_data),
2810 (icon_cell_data), (filter_row),
2811 (add_account_folders_to_merged_folder),
2812 (add_account_folders_to_simple_folder_store), (),
2813 (get_cmp_rows_type_pos), (cmp_rows),
2814 (modest_folder_view_set_account_id_of_visible_server_account):
2815 Adjust to the new outbox system, using generic folder stores and folders
2816 in the GtkTreeModel.
2818 2007-05-23 Christian Kellner <ckellner@openismus.com>
2820 * src/modest-mail-operation.c:
2821 (modest_mail_operation_update_account):
2822 Use info->max_size instead of unintialized local var [small
2823 build fix]. (Added TODO to review that change since I don't
2826 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2828 * libmodest-dbus-client/libmodest-dbus-client.c:
2829 (libmodest_dbus_client_compose_mail): function added
2830 * src/dbus_api/modest-dbus-api.h:
2831 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2832 (on_compose_mail): Implementation of the SendAsMail functionality
2834 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2836 * src/modest-account-mgr.c:
2837 (modest_account_mgr_add_server_account): Set the secure-connection
2838 conf key for transport accounts as well as store accounts. I don't know
2839 why the if was there. For instance, this makes sure that we use SSL
2840 for the gmail preset from the easysetup wizard.
2842 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2844 * src/gnome/modest-main-window.c:
2845 (on_account_store_connecting_finished), (connect_signals):
2846 * src/maemo/modest-main-window.c:
2847 (on_account_store_connecting_finished), (connect_signals),
2848 (modest_main_window_new):
2849 Handle TnyAccountStore::connecting-finished instead of
2850 TnyDevice::connection-changed, because we cannot actually perform
2851 operations on accounts until TnyAccountStore has itself responded to
2852 the TnyDevice::connection-changed signal. This prevents a GError from
2854 Do not try to update at startup, because we (at least on scratchbox)
2855 already do an update at startup when the device goes online.
2856 This prevents a GError from tinymail.
2857 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2858 Added TODO about stopping simultaneous operations.
2860 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2863 * src/modest-mail-operation-queue.c:
2864 (modest_mail_operation_queue_remove):
2865 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2866 about where they happened.
2868 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2870 * src/modest-ui-actions.c:
2871 (modest_ui_actions_on_password_requested): Make sure that the remember
2872 output parameter is always TRUE.
2874 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2876 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2877 Show a OK/Cancel dialog if the error is a question, though we still do not
2878 know anything more about what we are asking the user.
2879 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2880 Fix an uninitialized variable (helper). This is a logic error, however.
2882 2007-05-21 Christian Kellner <ckellner@openismus.com>
2884 * src/modest-search.h:
2885 Correct bit shifting in the ModestSearchFlags enum.
2887 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2889 * src/modest-tny-account.c:
2890 (modest_tny_account_new_from_server_account): Do not use the lsub and
2891 check-all hard-coded IMAP options when using POP.
2893 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-tny-account.c:
2896 (modest_tny_account_new_from_server_account):
2897 Use NULL for the secure-auth method for POP when Password auth has been
2898 specified by the user, as we already do for IMAP. "auth=Login" causes
2899 an error from camel or the server.
2901 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2903 * src/maemo/modest-account-settings-dialog.c:
2904 (create_page_account_details),
2905 (modest_account_settings_dialog_set_account_name):
2906 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2907 for the leave-on-server checkbox, rathr than just the checkbox, when
2908 the protocol is not POP.
2910 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2912 * src/widgets/modest-account-view.c:
2913 * src/widgets/modest-account-view.h:
2914 Added modest_account_view_select_account() which will be useful later
2915 to asynchronously re-select the edited account.
2917 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2919 * src/maemo/modest-account-settings-dialog.c:
2920 (modest_account_settings_dialog_set_account_name):
2921 Automatically choose the port numbers based on the secure authentication
2922 methods, if they have not been chosen before.
2923 This fixes projects.maemo.org bug NB#56273 .
2925 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2927 * src/maemo/modest-main-window-ui.h:
2928 * src/modest-ui-actions.c:
2929 * src/modest-ui-actions.h:
2930 Connect the Tools/SMTP Servers menu item to
2931 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2932 SMTP servers dialog, as in the UI specification and saves changes when it
2933 is closed. This fixed projects.maemo.org bug NB#56305 .
2935 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2937 * src/maemo/modest-connection-specific-smtp-window.c:
2938 (modest_connection_specific_smtp_window_init):
2939 Use gtk_window_set_default_size() to make this window big enough, so
2940 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2942 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2944 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2945 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2946 (modest_connection_specific_smtp_edit_window_init),
2947 Do not try to connect to a combobox signal before the combobox exists.
2948 This fixes the cras in projects.maemo.org bug NB#56288 .
2949 (modest_connection_specific_smtp_edit_window_get_settings):
2950 Remove the server_account_name parameter which was being checked for NULL
2951 though it was not used.
2953 * src/maemo/modest-connection-specific-smtp-window.c:
2954 (modest_connection_specific_smtp_window_fill_with_connections),
2955 (on_button_edit), (modest_connection_specific_smtp_window_init):
2956 Correct the number of treemodel columns to prevent a warning.
2957 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2958 libconic does not work.
2960 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2962 * src/modest-tny-account.c:
2963 (modest_tny_account_new_from_server_account):
2964 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2965 SMTP when "None" was chosen by the user. However, with my SMTP server that
2966 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2969 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2971 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2972 to explain the memory management issue with the ID in the ModestPair.
2974 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2975 (add_sending_page), (modest_account_assistant_finalize):
2976 * src/gnome/modest-gnome-global-settings-dialog.c:
2977 (create_updating_page), (create_composing_page):
2978 * src/gnome/modest-msg-edit-window.c: (get_transports),
2979 (init_window), (modest_msg_edit_window_finalize),
2980 (modest_msg_edit_window_get_msg_data):
2981 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2982 * src/gnome/modest-transport-widget.c:
2983 (modest_transport_widget_finalize), (smtp_configuration):
2984 * src/maemo/modest-maemo-global-settings-dialog.c:
2985 (create_updating_page), (create_composing_page):
2986 * src/maemo/modest-msg-edit-window.c: (get_transports),
2987 (init_window), (modest_msg_edit_window_finalize),
2988 (modest_msg_edit_window_get_msg_data),
2989 (modest_msg_edit_window_free_msg_data):
2990 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2991 (modest_store_widget_finalize):
2992 * src/maemo/modest-transport-widget.c:
2993 (modest_transport_widget_finalize), (smtp_configuration):
2994 * src/modest-main.c: (send_mail):
2995 * src/widgets/modest-combo-box.h:
2996 * src/widgets/modest-global-settings-dialog-priv.h:
2997 * src/widgets/modest-global-settings-dialog.c:
2998 (modest_global_settings_dialog_finalize):
2999 * src/widgets/modest-msg-edit-window.h:
3000 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3001 as long as the combo box, to prevent use of freed memory for the ID.
3003 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3005 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3006 get_accounts(), to make this clearer. Do not check for the enabled gconf
3007 key, because we do not use this for server accounts (at least, not yet).
3008 This allows us to send email again.
3010 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/modest-platform.c:
3013 (on_modest_conf_update_interval_changed), (modest_platform_init):
3014 Only respond to this particular key change. All these strcmp()s cannot be
3017 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3019 * src/maemo/modest-maemo-global-settings-dialog.c:
3020 (current_connection): Prevent a crash in scratchbox when
3021 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3022 * src/maemo/modest-platform.c:
3023 (on_modest_conf_update_interval_changed), (modest_platform_init):
3024 Get the update interval from gconf and reset it when the gconf key changes.
3026 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3028 * src/modest-protocol-info.c:
3029 * src/modest-protocol-info.h: Adde enum-specific get functions,
3030 instead of using a ModestProtocolType enum parameter.
3032 * src/gnome/modest-account-assistant.c:
3033 * src/gnome/modest-store-widget.c:
3034 * src/gnome/modest-store-widget.h:
3035 * src/gnome/modest-transport-widget.c:
3036 * src/gnome/modest-transport-widget.h:
3037 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3038 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3039 * src/maemo/easysetup/modest-easysetup-wizard.c:
3040 * src/maemo/modest-account-settings-dialog.c:
3041 * src/maemo/modest-account-settings-dialog.h:
3042 * src/maemo/modest-store-widget.c:
3043 * src/maemo/modest-store-widget.h:
3044 * src/maemo/modest-transport-widget.c:
3045 * src/maemo/modest-transport-widget.h:
3046 * src/modest-account-mgr-helpers.c:
3047 * src/modest-account-mgr-helpers.h:
3048 * src/modest-account-mgr.c:
3049 * src/modest-account-mgr.h:
3050 * src/modest-tny-account.c:
3051 * src/modest-tny-folder.c:
3052 * src/widgets/modest-account-view.c:
3053 * src/widgets/modest-retrieve-combo-box.c:
3054 * src/widgets/modest-retrieve-combo-box.h:
3055 * src/widgets/modest-secureauth-combo-box.c:
3056 * src/widgets/modest-serversecurity-combo-box.c:
3057 * src/widgets/modest-serversecurity-combo-box.h:
3058 * tests/check_account-mgr.c:
3059 Use the specific functions, and use the re-renamed enum values for GNOME too.
3061 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3063 * src/modest-pair.h:
3064 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3065 so we can get the second based on the first.
3067 * src/maemo/modest-account-settings-dialog.h:
3068 * src/maemo/modest-account-settings-dialog.c:
3069 Added get_supported_secure_authentication_methods(), though it is mostly
3070 commented-out for now until the necessary API is committed to tinymail.
3071 (modest_account_settings_dialog_set_account_name),
3072 (save_configuration): Request the supported authentication methods from the
3073 server, so we can choose a working method.
3075 * src/modest-tny-account-store.h:
3076 * src/modest-tny-account-store.c:
3077 (modest_tny_account_store_get_session): Rename from
3078 tny_account_store_get_session().
3080 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3082 * src/modest-protocol-info.h: Split the ModestProtocol enum
3083 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3084 There was no need to have these unrelated values in one enum.
3086 * src/: many files: Adapted to changed enum. This makes the code a bit
3087 clearer, and the compiler could catch some errors.
3089 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3091 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3092 Show the detailed internal camel error message when an error happens
3093 during the configuration, so that our testers can give us more clues.
3094 For instance, in projects.maemo.org bug NB#56910 .
3096 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3098 * src/modest-tny-account.c:
3099 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3100 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3102 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3104 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3105 * src/maemo/modest-account-settings-dialog.c:
3106 (modest_account_settings_dialog_set_account_name),
3107 (save_configuration): For the incoming secure authentication checkbox,
3108 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3109 the UI specification. PLAIN does not seem to be supported for most IMAP
3110 servers anyway, and I am not sure what it would mean.
3111 However, we probably need to discover which of the secure-authentication
3112 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3113 * src/modest-account-mgr-helpers.c:
3114 (modest_account_mgr_get_server_account_data):
3116 * src/modest-tny-account.c:
3117 (modest_tny_account_new_from_server_account):
3118 Use tny_account_set_mech() to set secure-authentication methods,
3119 with some special-casing for IMAP, based on my observations of how
3122 * src/modest-account-mgr-helpers.h:
3123 * src/modest-account-mgr.c:
3124 * src/modest-defs.h: Comment that the URI is only used for local folders.
3126 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3128 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3129 parameter const, just to be neat.
3130 * src/modest-text-utils.c: (modest_text_utils_inline):
3131 End g_strconcat() with NULL, as its documentation says. This is almost
3132 certainly the cause of my crash at startup on the device. Interestingly,
3133 valgrind doesn't tell us about these errors.
3135 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3137 * scripts/build-packages: Added more precise comments about how to use
3138 this script, though I still get this error:
3139 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3140 error building tinymail
3142 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3144 * src/maemo/modest-main-window.c: (on_account_update):
3145 Very slight cleanup, hoping to make it simpler to discover what causes
3146 a crash here sometimes.
3148 * src/modest-tny-account.c:
3149 (modest_tny_account_new_from_server_account): Set the port. Added
3150 comments about the options and a TODO comment because I need to find out
3151 how to specify the secure authentication method.
3153 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3155 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3156 changed CFlags paths form modest to libmodest
3158 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3160 * src/modest-account-mgr-helpers.c:
3161 (modest_account_mgr_get_server_account_data),
3162 (modest_account_mgr_free_server_account_data):
3163 * src/modest-account-mgr-helpers.h:
3164 * src/modest-account-mgr.c:
3165 (modest_account_mgr_add_server_account):
3166 * src/modest-defs.h:
3167 * src/modest-tny-account.c:
3168 (modest_tny_account_new_from_server_account):
3169 Determine the options for tny_camel_account_add_option() here,
3170 based on the settings, rather than storing them directly in gconf.
3172 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3174 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3175 Show a more friendly error dialog now that we expect (from the tinymail
3176 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3178 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3180 * src/maemo/modest-main-window.c: (on_account_update): Check that
3181 account_name is not NULL, to prevent a crash at startup that I am
3182 seeing on the N800. I do wonder why it is NULL.
3184 * src/maemo/easysetup/modest-easysetup-wizard.c:
3185 (create_page_user_details):
3186 * src/maemo/modest-account-settings-dialog.c:
3187 (create_page_user_details), (create_page_outgoing):
3188 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3189 (modest_connection_specific_smtp_edit_window_init):
3190 * src/modest-ui-actions.c:
3191 (modest_ui_actions_on_password_requested):
3192 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3193 might do something useful with the on-screen keyboard.
3195 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3197 * src/maemo/modest-main-window.c: (on_account_update):
3198 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3199 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3201 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3203 * src/modest-tny-account-store.c: (on_account_changed):
3204 Correct the signature of this signal handler.
3206 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3209 Show a HildonNote instead of a GtkDialog for Maemo.
3211 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3213 * src/widgets/modest-account-view.h:
3214 * src/widgets/modest-account-view.c: (on_account_changed),
3215 (on_account_removed). Added a boolean flag, set/unset by
3216 modest_account_view_block_conf_updates(),
3217 modest_account_view_unblock_conf_updates() to prevent unnecessary
3218 updates, but this is not very useful because the gconf notifications are
3219 so delays (maybe only on Maemo Bora).
3220 So auto-updating is turned off, and these functions do an explicit
3221 update when necessary.
3222 However, something else is still doing too much work when adding/removing
3223 accounts, probably in another part of the application.
3225 * src/maemo/modest-account-view-window.c:
3226 (on_delete_button_clicked), (on_edit_button_clicked),
3227 (on_new_button_clicked): Use the new functions.
3229 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3231 * src/modest-account-mgr-helpers.c:
3232 (modest_account_mgr_set_first_account_as_default):
3233 Sort the list of names alphabetically-by-title, so we choose the first one
3235 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3236 alphabetically by the title.
3238 This fixes projects.maemo.org bug NB#56418 .
3240 * src/modest-account-mgr-priv.c:
3241 (_modest_account_mgr_account_from_key):
3242 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3243 avoid a valgrind error, and possible random behaviour.
3245 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3247 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3248 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3249 tinymail documentation to say that this can be expected.
3250 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3251 pretty, and should not happen, but I would prefer to know when it does.
3253 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3255 * configure.ac: When using the older hildon version, probably on Bora,
3256 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3258 * src/widgets/modest-attachment-view.c:
3259 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3262 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3264 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3265 Implemented the prototype. Can be tested with
3266 tests/dbus_api/test_open_message:
3268 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3270 * src/modest-tny-account-store.c:
3271 (modest_tny_account_store_instance_init), (get_password):
3272 * src/modest-ui-actions.c:
3273 (modest_ui_actions_on_password_requested):
3274 Do not store the password in gconf, because this function is called
3275 for non-remembered passwords. Actually use the cached (in the hash map)
3276 password instead of releasing it.
3277 The password will now not be remembered if it is asked via the protected
3278 password dialog, as per the UI spec.
3280 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3282 * src/modest-defs.h:
3283 * src/modest-account-mgr-helpers.h:
3284 * src/modest-account-mgr-helpers.c:
3285 Added modest_server_account_get_username_has_succeeded(),
3286 modest_server_account_set_username_has_succeeded().
3287 (modest_server_account_set_username),
3288 Reset the has-succeeded flag if the username changes.
3290 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3291 * src/maemo/modest-connection-specific-smtp-window.c:
3292 (modest_connection_specific_smtp_window_save_server_accounts):
3293 Use modest_server_account_set_username() instead of using
3294 modest_conf_set_string() directly, so that the has-succeeded flag is always
3297 * src/modest-ui-actions.c:
3298 (modest_ui_actions_on_password_requested): Dim the username entry if
3299 the username has ever worked, as per the UI spec.
3301 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3303 * src/modest-tny-account-store.c: (get_password):
3304 * src/modest-ui-actions.c:
3305 (modest_ui_actions_on_password_requested):
3306 Allow the username to be changed too, though there is more work to
3307 be done on exactly how this behaves.
3309 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3311 * src/modest-account-mgr-helpers.h:
3312 * src/modest-account-mgr-helpers.c:
3313 Added modest_account_mgr_get_display_name(),
3314 modest_server_account_get_username(),
3315 modest_server_account_set_username(),
3316 modest_server_account_set_password(),
3317 modest_server_account_get_hostname() functions so we do not need to
3318 use the conf API directly.
3320 * src/maemo/modest-main-window.c: (connect_signals):
3321 Actually connect ot the ModestAccountStore::request-password signal,
3322 so that we show the dialog when the password is requested by Tinymail,
3323 for isntance if it is empty.
3325 * src/modest-marshal.list:
3326 * src/modest-tny-account-store.c:
3327 (modest_tny_account_store_class_init), (get_password),
3328 (modest_tny_account_store_alert):
3329 * src/modest-tny-account-store.h:
3330 * src/modest-ui-actions.h:
3331 * src/modest-ui-actions.c:
3332 (modest_ui_actions_on_password_requested):
3333 Change the signal parameters, so it is obvious that we are providing
3334 the non human-readable server name, and receiving both the username
3335 and password, though changing of the username is not yet implemented.
3336 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3337 for the GNOME version.
3339 This should fix the projects.maemo.org bug NB#56209, though it does not
3340 work on Bora, because the gconf_client_get() for the password fails
3341 immediately after we save it with gconf_client_set().
3343 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3346 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3347 caused an undefined symbol error:
3348 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3350 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3352 * src/modest-tny-account-store.c:
3353 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3354 using a GError instead of a string message, so we can translate it in
3357 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3359 * src/maemo/modest-address-book.c:
3360 (modest_address_book_check_names):
3361 * src/maemo/modest-msg-view-window.c:
3362 (modest_msg_view_window_clipboard_owner_change):
3363 * src/modest-init.c: (modest_init_init_ui):
3364 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3365 (update_folders_cb), (modest_mail_operation_update_account):
3366 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3367 (modest_ui_actions_on_msg_attachment_clicked),
3368 (modest_ui_actions_on_msg_recpt_activated):
3369 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3370 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3371 (modest_msg_view_search_next):
3372 * src/widgets/modest-recpt-editor.c:
3373 (modest_recpt_editor_on_button_release_event),
3374 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3375 g_message(). At this point we should only be seeing interesting errors on
3376 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3378 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3380 (modest_wizard_dialog_force_title_update):
3381 * src/maemo/easysetup/modest-wizard-dialog.h:
3382 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3383 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3384 can update the title when appropriate. Otherwise the title is wrong if the
3385 pages are added after adding the notebook to the dialog.
3386 This must be a problem in HildonWizardDialog too.
3387 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3389 * src/maemo/easysetup/modest-easysetup-wizard.c:
3390 (create_subsequent_customsetup_pages),
3391 (create_subsequent_easysetup_pages):
3392 Call modest_wizard_dialog_force_title_update() so that the title is
3393 correct even with GTK+ < 2.10.
3394 This fixes projects.maemo.org bug NB#56145 .
3396 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3398 * src/maemo/modest-platform.c:
3399 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3400 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3403 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3405 * src/widgets/modest-window.h:
3406 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3407 and modest_window_save_state(), which invokes it.
3409 * src/widgets/modest-window-mgr.h:
3410 * src/widgets/modest-window-mgr.c:
3411 Added modest_window_mgr_save_state_for_all_windows(), which calls
3412 the save_state vfunc on all registered windows, if implemented.
3414 * src/gnome/modest-msg-edit-window.c:
3415 * src/gnome/modest-msg-view-window.c:
3416 * src/maemo/modest-msg-edit-window.c:
3417 * src/maemo/modest-msg-view-window.c:
3418 * src/maemo/modest-main-window.c:
3419 Specify the existing save_settings functions as implementations of
3420 ModestWindow::save_state_func().
3422 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3423 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3424 enabling hibernation, for instance.
3426 We may need to do the same thing for restoring settings.
3429 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3431 * src/widgets/modest-window-mgr.c:
3432 * src/widgets/modest-window-mgr.h:
3433 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3434 modest_window_mgr_get_hibernation_is_prevented().
3436 * src/maemo/modest-main-window.c:
3437 (on_hildon_program_is_topmost_notify): Prevent hibernation
3438 (possible when the application goes to the background in the WM),
3439 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3441 * src/maemo/easysetup/modest-easysetup-wizard.c:
3442 (modest_easysetup_wizard_dialog_init):
3443 * src/maemo/modest-account-settings-dialog.c:
3444 (modest_account_settings_dialog_init):
3445 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3446 (modest_connection_specific_smtp_edit_window_init):
3447 * src/maemo/modest-connection-specific-smtp-window.c:
3448 (modest_connection_specific_smtp_window_init):
3449 * src/maemo/modest-signature-editor-dialog.c:
3450 (modest_signature_editor_dialog_init):
3451 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3452 prevent hibernation while any of these account settings dialogs are open.
3454 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3456 * src/maemo/Makefile.am:
3457 * src/maemo/modest-osso-state-saving.c:
3458 * src/maemo/modest-osso-state-saving.h: Added
3459 modest_osso_load_state() and modest_osso_save_state() though they do
3460 nothing now. They should iterate through all the open windows and load/save
3462 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3463 save state when closing.
3465 * src/maemo/modest-main-window.c:
3466 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3467 Add a notification handler for the HildonProgram::is-topmost property,
3468 so we can allow hibernation when the application goes into the background.
3469 But we still need to detect when the accounts setup windows are open so
3470 we can stop hibernation when they are open.
3471 To do this, I also added the main window the HildonProgram. This might have
3472 other side-effects/benefits, and should maybe be done for other windows.
3474 * src/maemo/modest-osso-autosave-callbacks.h:
3475 * src/maemo/modest-osso-autosave-callbacks.c:
3476 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3477 though it does not do anything yet, and we might never need this to do
3478 anything. For instance, we already save drafts.
3480 * src/maemo/modest-platform.c: (modest_platform_init):
3481 Specify the libosso auto-save callback.
3483 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3485 * src/maemo/modest-platform.c:
3486 (modest_platform_set_update_interval):
3487 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3488 aparently stays valid between application instances, so we can use this
3489 to remove and reset it later. According to a maemo-developers email from
3492 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3494 * configure.ac: Depend on libalarm for Maemo.
3496 * src/dbus_api/modest-dbus-api.h:
3497 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3498 (on_send_receive), (modest_dbus_req_handler):
3499 Handle a SEND_RECEIVE D-Bus method.
3501 * libmodest-dbus-client/libmodest-dbus-client.c:
3502 (libmodest_dbus_client_send_and_receive):
3503 * libmodest-dbus-client/libmodest-dbus-client.h:
3504 Add C convenience functions for calling the new D-Bus method.
3506 * src/modest-platform.h:
3507 * src/gnome/modest-platform.c:
3508 * src/maemo/modest-platform.c:
3509 Added modest_platform_set_update_interval(), which uses the
3510 alarmd API on Maemo.
3511 (modest_platform_init),
3512 Call modest_platform_set_update_interval(), using a hard-coded
3513 interval for now (until the global settings dialog is implemented),
3514 though I am not sure that this makes sense yet.
3516 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3518 * src/dbus_api/modest-dbus-callbacks.c:
3519 (modest_osso_cb_hw_state_handler):
3520 * src/dbus_api/modest-dbus-callbacks.h:
3521 * src/maemo/modest-platform.c: (modest_platform_init):
3522 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3523 in case this has some effect on the ability for Maemo to ping the
3526 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3528 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3529 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3530 warning. It is probably a logic error, but I need to fix the build.
3532 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3534 * src/modest-account-mgr.h:
3535 * src/modest-account-mgr.c:
3536 (modest_account_mgr_account_names): Add a gboolean enabled_only
3537 parameter, so we can get lists of onlt the enabled accounts.
3539 (modest_account_mgr_add_account),,
3540 (modest_account_mgr_account_with_display_name_exists):
3541 * src/maemo/modest-msg-edit-window.c: (get_transports):
3542 * src/modest-account-mgr-helpers.c:
3543 (modest_account_mgr_set_first_account_as_default):
3544 * src/modest-init.c: (init_default_account_maybe):
3545 * src/modest-tny-account-store.c: (get_accounts):
3546 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3547 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3548 * tests/check_account-mgr.c: (START_TEST):
3549 Provide the extra parameter, as appropriate.
3551 * src/widgets/modest-account-view.c: (update_account_view):
3552 Do not show disabled accounts (meaning that there is no way to
3553 enable/disable accounts in the UI (the feature is not in our UI
3554 specification), so we can use this internally only to mark unfinished
3555 or temporary account data.
3557 * src/maemo/easysetup/modest-easysetup-wizard.c:
3558 (create_account): Add boolean enable parameter, so we can specify FALSE
3559 to create the temporary account.
3560 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3561 (on_before_next): When finishing, when there is a temporary account, just
3563 Also, use a timeout to delay the showing of the dialog until gconf is likely
3564 to return correct information, due to a maemo gconf bug that is fixed in
3565 osso 1.1, but not yet in Bora.
3566 However, the dialog stays on screen after it is destroyed.
3568 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3569 for invalid data when cancelling. Use a hildon note instead of a dialog
3570 to complain about invalid data. Do not show the account-saved note if the
3571 account is disabled (a temporary account that will not really be saved for use
3574 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3576 * src/modest-account-mgr-helpers.h:
3577 * src/modest-account-mgr-helpers.c:
3578 Added modest_account_mgr_unset_default_account(),
3579 Added modest_account_mgr_set_first_account_as_default().
3581 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3582 If it was the default account, unset the default account name.
3584 * src/maemo/modest-account-view-window.c:
3585 (on_delete_button_clicked): If it was the default account,
3586 set the first remaining account as the default instead.
3588 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3589 a NULL account or a NULL default account, to prevent a crash. This should
3590 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3593 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3595 * src/widgets/modest-recpt-editor.c:
3596 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3597 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3598 TODO comment for this. This fixes the build.
3600 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3601 be the best place for it. This will in future update all auto-update accounts,
3602 rather than just the current/default account, when that gconf key exists.
3603 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3604 if there are no accounts, before calling do_send_receive().
3605 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3607 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3608 * src/maemo/modest-main-window-ui.h:
3609 * src/maemo/modest-main-window.c: (on_connection_changed),
3610 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3611 directly, becaue the signal handler does more.
3613 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3615 * src/modest-account-mgr-helpers.c:
3616 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3617 for the case that the account does not exist.
3619 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3620 (equivalent to the modest account name) rather than the tinymail account name
3621 (equivalent to the modest account title - human readable) to get the account data.
3622 Check for null account data to prevent the crash, and add a TODO comment saying that
3623 this needs fixing because it is using the server account name instead of the account name.
3625 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3627 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3628 * src/maemo/modest-account-settings-dialog.c: (show_error),
3630 Use hildon_note_new_information() for informative and error messages,
3631 which seems to be expected for Maemo applications (no documentation that I know of
3632 says this). I am surprised that there is no distinction between info and error
3635 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3637 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3638 it is easy to find where this is used.
3640 * src/maemo/easysetup/modest-easysetup-wizard.c:
3641 (create_page_welcome), (create_page_account_details),
3642 (create_page_user_details), (create_page_complete_easysetup),
3643 (create_page_custom_incoming), (create_page_custom_outgoing),
3644 (create_page_complete_custom):
3645 * src/maemo/modest-account-settings-dialog.c:
3646 (create_page_account_details), (create_page_user_details),
3647 (create_page_incoming), (create_page_outgoing):
3648 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3649 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3650 (modest_connection_specific_smtp_edit_window_init):
3651 * src/maemo/modest-connection-specific-smtp-window.c:
3652 (modest_connection_specific_smtp_window_init):
3653 * src/maemo/modest-signature-editor-dialog.c:
3654 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3655 and scrolling policy as per the Email Application Layout Guide, if I have
3658 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3660 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3661 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3662 which were empty, because these vfuncs have been removed from TnyAccountStore.
3663 This fixes the build.
3665 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3667 * src/maemo/modest-main-window.c:
3668 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3669 showing/hiding it. Added TODO because it probably should not be NULL.
3670 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3671 because unnecessary g_warnings() make degugging difficult.
3673 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3675 * src/maemo/modest-msg-edit-window.c:
3676 (modest_msg_edit_window_select_color),
3677 (modest_msg_edit_window_select_background_color): 2 const corrections and
3678 moving 2 #endifs before closing brackets, to fix the build.
3680 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3682 * src/maemo/easysetup/modest-easysetup-wizard.h:
3683 * src/maemo/easysetup/modest-easysetup-wizard.c:
3684 (modest_easysetup_wizard_dialog_finalize),
3685 (on_button_edit_advanced_settings), (create_page_complete_custom),
3686 (on_response), (create_account):
3687 Implement the Advanced Settings edit button, by saving the account information,
3688 for the Advanded Settings dialog to use directly from gconf, and removing it
3689 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3690 Bug #5533 in the projects.maemo.org bugzilla.
3692 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3694 * src/maemo/modest-msg-view-window.c:
3695 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3696 when opening a message window.
3698 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3700 * src/maemo/easysetup/modest-easysetup-wizard.c:
3701 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3704 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3705 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3706 gconf settings. I probably added more checks than necessary, but that is safer.
3708 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3709 variable to fix the build, but this seems to be used when it is still NULL.
3711 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3713 * src/modest-platform.h:
3714 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3715 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3716 * src/modest-main.c: Implement this function so we can avoid using
3717 maemo-specific API from cross-platform code.
3719 * src/modest-tny-account-store.c:
3720 (get_smtp_specific_transport_account_for_open_connection):
3721 * src/modest-ui-actions.c: (check_for_connection),
3722 (modest_ui_actions_on_item_not_found):
3723 Use modest_platform_connect_and_wait() and put #idefs around other
3724 maemo-specific code, because only maemo currently has a way to
3725 identify connection names.
3727 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3729 * src/modest-tny-account-store.h:
3730 * src/modest-tny-account-store.c:
3731 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3732 the connection-specific SMTP server settings in the configuration.
3734 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3736 * src/maemo/modest-main-window.c: (on_connection_changed),
3738 * src/modest-main.c: (main), (start_ui), (send_mail):
3739 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3740 that is what is intended.
3742 * src/modest-ui-actions.c: (action_send), (action_receive),
3743 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3744 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3745 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3746 SMTP server is used when it is specified.
3748 (modest_ui_actions_on_send_receive):
3749 Check that a connection is open before proceeding.
3750 Receive and then send, instead of vice-versa, as per the specification.
3752 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3754 * src/modest-mail-operation.c:
3755 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3756 though I guess it should be something other than NULL.
3758 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/easysetup/modest-easysetup-wizard.c:
3761 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3762 combo twice, to avoid an g_warning and to make it visible again.
3763 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3764 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3765 (already intended) dereference when detaching, because we then recreate the menu.
3766 But I am not sure why the warning was happening, and it is possible that this is a memory
3769 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3771 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3772 and uri_parse_mailto() utility functions.
3773 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3775 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3777 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3779 * src/dbus_api/modest-dbus-api.h:
3780 * src/dbus_api/modest-dbus-callbacks.c:
3781 Use an idle callback to execute the modest code in the application's own thread.
3782 Remove the helloworld example method.
3783 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3784 parsed, and the open-message method is not implemented because this is not yet implemented in
3786 * libmodest-dbus-client/libmodest-dbus-client.c:
3787 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3788 (libmodest_dbus_client_open_message):
3789 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3791 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3792 body without crashing.
3794 * tests/dbus_api/Makefile.am:
3795 * tests/dbus_api/test_mail_to.c:
3796 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3798 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3800 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3801 Added file to fix the build. Sorry.
3803 * src/dbus_api/Makefile.am:
3804 * src/dbus_api/modest-dbus-api.h:
3805 * src/dbus_api/modest-dbus-callbacks.h:
3806 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3807 (modest_dbus_req_handler):
3808 Put constants in a separate header so it can be reused by the
3809 client library, without duplication
3811 * libmodest-dbus-client/Makefile.am:
3812 * libmodest-dbus-client/libmodest-dbus-client.c:
3813 (libmodest_dbus_client_call_helloworld),
3814 (libmodfest_dbus_client_send_mail),
3815 (libmodfest_dbus_client_mailto),
3816 (libmodfest_dbus_client_open_message):
3817 * libmodest-dbus-client/libmodest-dbus-client.h:
3818 (Partly) Implement a send_mail D-Bus method.
3820 * tests/dbus_api/Makefile.am:
3821 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3822 the send_email D-Bus method.
3824 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3828 * libmodest-dbus-client/Makefile.am:
3829 * libmodest-dbus-client/libmodest-dbus-client.c:
3830 * libmodest-dbus-client/libmodest-dbus-client.h:
3831 * tests/dbus_api/Makefile.am:
3832 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3833 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3835 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3837 * src/maemo/easysetup/modest-easysetup-wizard.c:
3838 (create_page_account_details):
3839 * src/maemo/modest-account-settings-dialog.c:
3840 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3841 widgets, because this might not be the default in future versions of the Maemo GTK+.
3842 However, I can not not get capitalization to work even in a simple test case.
3844 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3846 * src/maemo/easysetup/modest-easysetup-wizard.c:
3847 (create_page_custom_incoming), (create_page_custom_outgoing):
3848 * src/maemo/modest-account-settings-dialog.c:
3849 (create_page_account_details), (create_page_incoming),
3850 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3851 instead of using gtk_check_button_with_label(), so they are aligned like the other
3852 widgets, as per the UI spec.
3854 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3856 * src/maemo/easysetup/modest-easysetup-wizard.c:
3857 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3858 * src/widgets/modest-validating-entry.c:
3859 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3860 Modest prefix instead of an EasySetup prefix.
3862 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3864 * src/widgets/modest-validating-entry.h:
3865 * src/widgets/modest-validating-entry.c: (on_insert_text),
3866 Added easysetup_validating_entry_set_max_func(), used to set a callback
3867 to call when the max number of characters is reached. GtkEntry has a max-length
3868 already but is silent about it.
3870 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3871 (create_page_account_details), (create_page_user_details),
3873 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3874 (create_page_account_details), (create_page_user_details),
3875 (create_page_outgoing):
3876 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3877 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3878 the UI spec, when the user tries to enter more than the max number of characters.
3880 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3882 * src/maemo/easysetup/modest-easysetup-wizard.c:
3883 (create_page_user_details), (create_page_custom_incoming),
3884 (create_page_custom_outgoing):
3885 * src/maemo/modest-account-settings-dialog.c:
3886 (create_page_user_details), (create_page_incoming),
3887 (create_page_outgoing):
3888 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3889 (modest_connection_specific_smtp_edit_window_init):
3890 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3891 not appropriate. Bad Maemo-specific defaults!.
3893 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3895 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3896 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3897 (modest_signature_editor_dialog_set_settings):
3898 Disable the label and textview when the checkbox is disabled, and use the
3899 specified (UI spec) default signature text.
3901 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3903 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3904 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3906 * src/modest-defs.h:
3907 * src/modest-account-mgr-helpers.h:
3908 * src/modest-account-mgr-helpers.c:
3909 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3911 * src/maemo/Makefile.am:
3912 * src/maemo/modest-signature-editor-dialog.c:
3913 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3916 * src/maemo/modest-account-settings-dialog.h:
3917 * src/maemo/modest-account-settings-dialog.c:
3918 (modest_account_settings_dialog_finalize), (on_button_signature),
3919 (save_configuration): Use the new dialog when the Edit button is pressed, and
3920 save the changes if necessary, as per the UI spec.
3922 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3924 * src/maemo/Makefile.am:
3925 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3926 based on maemo-develoers email from Dirk.
3928 * src/maemo/easysetup/modest-easysetup-wizard.c:
3929 (create_page_welcome), (create_page_account_details),
3930 (create_page_user_details), (create_page_complete_easysetup),
3931 (create_page_custom_incoming), (create_page_custom_outgoing),
3932 (create_page_complete_custom),
3933 (modest_easysetup_wizard_dialog_init):
3934 * src/maemo/modest-account-settings-dialog.c:
3935 (create_page_account_details), (create_page_user_details),
3936 (create_page_incoming), (create_page_outgoing),
3937 (modest_account_settings_dialog_init):
3938 * src/maemo/modest-connection-specific-smtp-window.c:
3939 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3941 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3943 * src/maemo/easysetup/modest-easysetup-wizard.c:
3944 (create_page_account_details), (create_page_custom_outgoing),
3945 (create_page_complete_custom):
3946 * src/maemo/modest-account-settings-dialog.c:
3947 (create_page_user_details), (create_page_incoming),
3948 (create_page_outgoing):
3949 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3950 (modest_connection_specific_smtp_edit_window_init):
3951 Use the correct (UI spec) port min/max, and use horizontal separators,
3954 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3956 * src/maemo/easysetup/modest-easysetup-wizard.c:
3957 (set_default_custom_servernames):
3958 * src/maemo/modest-account-settings-dialog.c:
3959 (create_page_incoming), (on_combo_outgoing_security_changed),
3960 (on_combo_incoming_security_changed), (create_page_outgoing),
3961 (modest_account_settings_dialog_set_account_name),
3962 (save_configuration):
3963 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3964 (on_combo_security_changed),
3965 (modest_connection_specific_smtp_edit_window_init),
3966 (modest_connection_specific_smtp_edit_window_set_connection),
3967 (modest_connection_specific_smtp_edit_window_get_settings):
3968 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3971 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3974 * src/maemo/easysetup/modest-easysetup-wizard.c:
3975 (create_page_custom_outgoing), (create_page_complete_custom):
3976 * src/maemo/modest-account-settings-dialog.c:
3977 (create_page_user_details), (create_page_outgoing):
3978 * src/maemo/modest-account-view-window.c: (button_box_new):
3979 Use changed logical IDs as per the most recent UI spec:
3980 mcen_bd_emailsetup_edit -> mcen_bd_edit
3981 mcen_bd_emailsetup_delete -> mcen_bd_delete
3982 mcen_bd_emailsetup_close -> mcen_bd_close
3984 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3988 * src/dbus_api/Makefile.am:
3989 * src/dbus_api/modest-dbus-callbacks.c:
3990 * src/dbus_api/modest-dbus-callbacks.h:
3991 * src/maemo/modest-platform.c: (modest_platform_init):
3992 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3994 * tests/Makefile.am:
3995 * tests/dbus_api/Makefile.am:
3996 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3998 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4000 * src/maemo/modest-account-settings-dialog.c:
4001 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4002 Removed unnecessary includes.
4004 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4006 * src/maemo/easysetup/modest-easysetup-wizard.c:
4007 * src/maemo/modest-account-settings-dialog.c:
4008 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4009 * src/widgets/Makefile.am:
4010 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4011 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4012 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4013 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4014 * src/widgets/modest-secureauth-combo-box.c:
4015 * src/widgets/modest-secureauth-combo-box.h:
4016 * src/widgets/modest-serversecurity-combo-box.c:
4017 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4018 made the GObject names more consistent with the rest of the Modest code.
4020 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4022 * src/maemo/easysetup/Makefile.am:
4023 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4024 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4025 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4026 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4027 * src/maemo/easysetup/modest-easysetup-wizard.c:
4028 * src/maemo/easysetup/modest-validating-entry.c:
4029 * src/maemo/easysetup/modest-validating-entry.h:
4030 * src/maemo/modest-account-settings-dialog.c:
4031 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4032 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4033 widgets/ because they are used outside of easysetup too. After checking in,
4034 svn will allow me to rename them too.
4036 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4038 * src/gnome/modest-msg-edit-window.c:
4039 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4040 linker error, to fix the build on the GNOME platform.
4041 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4042 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4043 ifdefed out to avoid a warning.
4045 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4047 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4048 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4049 some alternative for GTK+ 2.6.
4051 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4053 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4055 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4056 specified for EmailAccountsDialog in UI spec.
4058 * src/maemo/easysetup/modest-easysetup-wizard.c:
4059 * src/maemo/easysetup/modest-easysetup-wizard.h:
4060 * src/maemo/modest-account-settings-dialog.c:
4061 * src/maemo/modest-account-settings-dialog.h:
4062 Reuse a member window widget for the connection-specific SMTP server accounts,
4063 so we can tell it to create/save the accounts only if we actually save changes.
4065 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4066 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4067 (modest_connection_specific_smtp_edit_window_get_settings):
4068 Return a struct instance for temporarily remembering the entered data.
4070 * src/maemo/modest-connection-specific-smtp-window.h:
4071 * src/maemo/modest-connection-specific-smtp-window.c:
4072 (modest_connection_specific_smtp_window_finalize),
4073 (modest_connection_specific_smtp_window_fill_with_connections),
4075 (modest_connection_specific_smtp_window_save_server_accounts),
4076 (update_model_server_names): Do not actually save data until asked,
4077 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4079 (on_selection_changed),
4080 (modest_connection_specific_smtp_window_init): Disable the edit
4081 button when nothing is selected.
4083 * src/modest-account-mgr-helpers.c:
4084 * src/modest-account-mgr-helpers.h:
4085 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4088 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4090 * src/modest-account-mgr-helpers.h:
4091 * src/modest-account-mgr-helpers.c:
4092 (modest_account_mgr_get_unused_account_name),
4093 (modest_account_mgr_get_unused_account_display_name): Added these
4094 utility functions, to avoid code duplication.
4096 * src/maemo/easysetup/modest-easysetup-wizard.c:
4097 (create_page_account_details), (create_account):
4098 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4099 (on_combo_security_changed),
4100 (modest_connection_specific_smtp_edit_window_init),
4101 (modest_connection_specific_smtp_edit_window_save_settings):
4102 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4103 * src/maemo/modest-connection-specific-smtp-window.c:
4104 (modest_connection_specific_smtp_window_finalize),
4105 (modest_connection_specific_smtp_window_fill_with_connections),
4106 (on_button_edit), (modest_connection_specific_smtp_window_init):
4107 * src/maemo/modest-connection-specific-smtp-window.h:
4108 Implementing saving of connection-specific server accounts.
4110 But I need to refactor this so we can save the data for each
4111 possible connection-specific account and only actually create the server accounts
4112 when the easysetup finished, or the OK button is pressed on the account settings
4115 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4117 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4118 (on_combo_security_changed):
4119 (modest_connection_specific_smtp_edit_window_init):
4120 Auto-fill the port number as in the account settings.
4122 (modest_connection_specific_smtp_edit_window_set_connection):
4123 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4124 * src/maemo/modest-connection-specific-smtp-window.c:
4125 (fill_with_connections), (on_button_edit),
4126 (modest_connection_specific_smtp_window_init):
4127 Turn the edit window into a dialog to simplify the code, and
4128 set a WM hint as in a GtkDialog, because only a popup can be on top of
4129 another window in Maemo, and popups usually have no WM decoration.
4131 * src/modest-defs.h:
4132 * src/modest-account-mgr-helpers.c:
4133 (modest_account_mgr_set_connection_specific_smtp),
4134 (modest_account_mgr_remove_connection_specific_smtp),
4135 (modest_account_mgr_get_connection_specific_smtp):
4136 * src/modest-account-mgr-helpers.h: Some functions to write the
4137 connection-specific SMTP server information. Not yet used.
4140 * src/widgets/modest-folder-view.c: (text_cell_data):
4141 Fix a warning about an uninitialized variable.
4142 (on_configuration_key_changed): Put an #ifdef around the use
4143 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4145 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4147 * src/maemo/modest-account-settings-dialog.h:
4148 * src/maemo/modest-account-settings-dialog.c:
4149 Added connect_for_modified() utility function to mark the new modified boolean.
4151 (create_page_account_details), (create_page_user_details),
4152 (create_page_incoming), (create_page_outgoing), (on_response),
4153 (modest_account_settings_dialog_init),
4154 (modest_account_settings_dialog_set_account_name):
4155 Only warn about unsaved changes when there are actually unsaved changes.
4157 * src/modest-account-mgr-helpers.c:
4158 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4159 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4160 to get the data from there in future.
4162 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4164 * src/modest-defs.h:
4166 * src/modest-account-mgr-helpers.h:
4167 * src/modest-account-mgr-helpers.c:
4168 Store the security account setting in a single conf key instead of using
4169 the options list, so that the list is left for just the to-be-removed camel hack,
4170 and because gconf_client_set_list() is failing for some reason.
4172 * src/modest-account-mgr.c:
4173 (modest_account_mgr_add_server_account):
4174 * src/maemo/modest-account-settings-dialog.c:
4175 (modest_account_settings_dialog_set_account_name),
4176 (save_configuration): Use the renamed functions.
4179 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4181 * src/widgets/Makefile.am:
4182 * src/widgets/modest-limit-retrieve-combo-box.c:
4183 * src/widgets/modest-limit-retrieve-combo-box.h:
4184 * src/widgets/modest-retrieve-combo-box.c:
4185 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4186 the account settings dialog.
4188 * src/modest-defs.h:
4189 * src/modest-account-mgr-helpers.h:
4190 * src/modest-account-mgr-helpers.c:
4191 (modest_server_account_get_option_secure_auth),
4192 (modest_server_account_set_option_secure_auth):
4193 * src/modest-account-mgr.c:
4194 (modest_account_mgr_add_server_account):
4195 Use the existing AUTH_MECH conf key for the secure-auth setting,
4196 instead of putting it in the list options, because this was actually used already.
4198 * src/maemo/modest-account-settings-dialog.c:
4199 (create_page_account_details),
4200 (modest_account_settings_dialog_set_account_name),
4201 (save_configuration):
4202 * src/maemo/modest-account-settings-dialog.h:
4203 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4204 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4206 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4208 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4209 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4210 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4212 * src/modest-defs.h:
4213 * src/maemo/modest-account-settings-dialog.c:
4214 (create_page_incoming), (on_combo_outgoing_security_changed),
4215 (on_combo_incoming_security_changed), (create_page_outgoing),
4216 (modest_account_settings_dialog_set_account_name),
4217 (save_configuration): Load/Save the port number, and change it when the
4218 security combo changes, to suitable defaults.
4220 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4222 * src/modest-account-mgr.c:
4223 (modest_account_mgr_add_server_account): Set the security and secure-auth
4224 options, and add a comment saying that the other camel-specific options should be
4227 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4229 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4231 * src/modest-tny-account-store.c: (account_list_free),
4232 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4233 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4236 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4238 * src/modest-protocol-info.c:
4239 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4240 is required by our UI spec. Maybe something in our implementation will use this eventually.
4241 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4242 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4243 instead of the previous 0 placeholder.
4245 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4246 secure-auth settings.
4247 * src/modest-account-mgr-helpers.h:
4248 * src/modest-account-mgr-helpers.c:
4249 (modest_server_account_data_get_option_secure_auth),
4250 (modest_server_account_set_option_secure_auth),
4251 (modest_server_account_data_get_option_security),
4252 (modest_server_account_set_option_security): Added this API for getting and setting the security
4253 and secure-auth settings.
4255 * src/maemo/modest-account-settings-dialog.h:
4256 * src/maemo/modest-account-settings-dialog.c:
4257 (modest_account_settings_dialog_finalize), (check_data),
4258 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4259 about changing titles.
4260 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4261 (save_configuration): Save the security and secure-auth settings.
4263 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4264 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4266 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4268 * src/modest-defs.h:
4269 * src/modest-account-mgr.c:
4270 (modest_account_mgr_add_server_account):
4271 Added and used defines for the options key and value pair strings,
4272 that are used so far, though they do not seem to correspond to anything in our
4273 UI specs or ModestProtocol enum.
4275 * src/modest-account-mgr-helpers.h:
4276 * src/modest-account-mgr-helpers.c:
4277 (compare_option_strings_for_name),
4278 (modest_server_account_data_get_option_value),
4279 (modest_server_account_data_get_option_bool),
4280 (modest_account_mgr_get_server_account_option):
4281 Added helper functions for parsing the options GSList.
4283 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4285 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4286 display name is based on the supplied account name.
4287 * src/modest-account-mgr.c:
4288 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4289 with an inefficient, but good-enough, implementation.
4291 * src/maemo/easysetup/modest-easysetup-wizard.c:
4292 (create_page_account_details), (on_before_next), (create_account):
4293 Check for existing display names rather than (non-user-visible) account names, and just
4294 create and set a unique account name at the end.
4296 * src/maemo/modest-account-settings-dialog.c:
4297 (modest_account_settings_dialog_init),
4298 (modest_account_settings_dialog_set_account_name),
4299 (create_page_incoming): Show the display name, instead of the account name.
4300 (on_response): Do some (not all) extra checks, as in the UI spec.
4301 (save_configuration): Save the display name if it was changed.
4303 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4305 * po/en_GB.po: Added needed logical ID and translation.
4306 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4307 (init_view): Made the is-default column clicking work.
4309 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4312 * src/maemo/easysetup/Makefile.am:
4313 * src/maemo/easysetup/modest-easysetup-wizard.c:
4314 (modest_easysetup_wizard_dialog_init):
4315 * src/maemo/easysetup/provider-data-test.keyfile:
4316 * src/maemo/easysetup/provider-data.keyfile:
4317 Moved the provider data file to the new modest-providers-data package and used it from there.
4319 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4321 * src/modest-local-folder-info.c:
4322 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4323 N_() was already used on the static strings, but this just marks it for translation without
4324 using the translation.
4326 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4328 * src/maemo/modest-account-settings-dialog.c:
4329 (create_page_incoming),
4330 (modest_account_settings_dialog_set_account_name):
4331 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4332 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4333 I will do this if nobody else gets there first.
4335 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4337 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4338 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4339 save the security stuff.
4341 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4343 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4344 Set the email address and user fullname, which I now see must be
4347 * src/maemo/modest-account-settings-dialog.h:
4348 * src/maemo/modest-account-settings-dialog.c:
4350 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4351 leave-on-server and authentication.
4352 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4355 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4358 * src/maemo/modest-account-settings-dialog.c:
4359 * src/maemo/modest-account-settings-dialog.h:
4360 Most (but not all) of the widgets are now present as specified by the UI spec.
4361 No changes are yet saved, and some details are not properly shown yet.
4363 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4365 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4367 * src/maemo/Makefile.am:
4368 * src/maemo/modest-account-settings-dialog.c:
4369 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4370 an existing account. Doesn't do much yet.
4372 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4373 Open the accounts settings dialog when Edit is clicked.
4375 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4377 * src/maemo/easysetup/Makefile.am:
4378 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4380 * src/maemo/easysetup/modest-easysetup-wizard.c:
4381 (modest_easysetup_wizard_dialog_init):
4382 Try to get the source directory from the build system,
4383 instead of hard-coding "./" into the source code, when opening our local
4384 copies of the configuration files.
4385 But this still fails when opening the wizard from the Accounts window,
4386 maybe because the working directory seems to change at runtime.
4387 So the wizard will fail the second time unless you copy the files into their
4388 proper locations - see the stdout warnings for the paths.
4390 (create_page_account_details),(on_before_next):
4391 Check for existing non-server accounts instead of server accounts,
4392 so the default account name is useful again, and to prevent trying to
4395 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4396 Show the wizard when New is clicked.
4398 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4399 (init_view): Show the column headers, and show the columns that are
4400 specified in the UI specs. However, something in Maemo's GTK+ prevents
4401 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4402 change the default account. This is despite unsetting the special properties.
4404 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4406 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4407 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4408 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4409 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4410 to make that clearer.
4411 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4413 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4415 * src/maemo/modest-account-view-window.c:
4416 (modest_account_view_window_init),
4417 (modest_account_view_window_new):
4418 Use the same buttons as specified in the
4419 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4420 the existing widgets, which never had a chance of working.
4421 Put the ModestAccountView treeview in a scrolled window.
4422 Do not repeat the initialization in both _init() and _new().
4424 * src/widgets/modest-account-view.c: (update_account_view):
4425 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4426 this widget and window shows no accounts.
4428 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4430 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4432 * src/maemo/easysetup/modest-easysetup-wizard.c:
4433 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4434 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4435 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4438 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4439 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4440 accounts exist yet, as in the UI spec.
4442 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4444 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4446 * src/maemo/Makefile.am:
4447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4448 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4449 New window for editing connection-specific smtp details.
4450 Not fully implemented.
4452 * src/maemo/modest-connection-specific-smtp-window.c:
4453 (modest_connection_specific_smtp_window_finalize) :
4454 unref the tree model.
4455 (on_button_edit): Show the edit window.
4457 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4459 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4462 * src/maemo/Makefile.am:
4463 * src/maemo/modest-connection-specific-smtp-window.c:
4464 * src/maemo/modest-connection-specific-smtp-window.h:
4465 New window for showing the list of connections, for connection-specific
4466 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4467 * src/maemo/easysetup/modest-easysetup-wizard.c:
4468 (create_page_custom_outgoing): Show the new window when the button is clicked.
4470 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4472 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4473 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4474 * src/maemo/modest-msg-edit-window.c:
4475 (modest_msg_edit_window_insert_image):
4476 * src/modest-conf.c: (modest_conf_key_escape):
4477 * src/modest-mail-operation.c:
4478 (modest_mail_operation_send_new_mail):
4479 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4480 (modest_ui_actions_on_new_account):
4481 * src/widgets/modest-attachment-view.c: (update_filename_request):
4482 * src/widgets/modest-mail-header-view.c:
4483 Corrected warnings that were breaking the build, by commenting out unused variables,
4484 and a function, and by including a header.
4486 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4488 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4489 so we can #ifdef around platform-specific code when necessary.
4490 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4491 to allow this to build for the GNOME platform too.
4493 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4495 * src/maemo/easysetup/modest-easysetup-wizard.c:
4496 Added util_increment_name() and used it in create_page_account_details()
4497 to make sure that the default account name is always a new name.
4499 (modest_easysetup_wizard_dialog_init),
4500 (set_default_custom_servernames): Some minor memory management fixes.
4502 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4506 * src/modest-runtime.c: (init_i18n): Restored the translation
4507 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4508 are defined in config.h, and the translations are installed.
4510 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4511 is defined for translation.
4513 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4515 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4517 * src/maemo/easysetup/modest-easysetup-wizard.c:
4518 (modest_easysetup_wizard_dialog_init):
4519 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4520 Use realistic paths (though they should use $prefix generically) to the
4521 mcc_mapping and provider-data.keyfile files which might work when they
4522 are installed by the future version of the operator-wizard package,
4523 and then fallback to paths in our source code, with an explanatory
4526 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4530 * src/maemo/Makefile.am:
4531 * src/maemo/easysetup/: Added files from the previously-exernal
4532 osso-modest-easysetup.
4533 * src/maemo/modest-main-window-ui.h:
4534 * src/modest-ui-actions.c:
4535 * src/modest-ui-actions.h:
4536 Added modest_ui_actions_on_new_account() as a signal handler for the
4537 New Account menu item. It shows the easysetup wizard.
4538 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob