git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/modest-tny-account.c:
   4         (modest_tny_account_new_from_server_account):
   5         Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
   6         SMTP when "None" was chosen by the user. However, with my SMTP server that
   7         does not support ANONYMOUS, the emails do not leave the Outbox and I see
   8         no error dialog.
   9
  10 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
  11
  12         * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
  13         to explain the memory management issue with the ID in the ModestPair.
  14
  15         * src/gnome/modest-account-assistant.c: (add_receiving_page),
  16         (add_sending_page), (modest_account_assistant_finalize):
  17         * src/gnome/modest-gnome-global-settings-dialog.c:
  18         (create_updating_page), (create_composing_page):
  19         * src/gnome/modest-msg-edit-window.c: (get_transports),
  20         (init_window), (modest_msg_edit_window_finalize),
  21         (modest_msg_edit_window_get_msg_data):
  22         * src/gnome/modest-store-widget.c: (imap_pop_configuration):
  23         * src/gnome/modest-transport-widget.c:
  24         (modest_transport_widget_finalize), (smtp_configuration):
  25         * src/maemo/modest-maemo-global-settings-dialog.c:
  26         (create_updating_page), (create_composing_page):
  27         * src/maemo/modest-msg-edit-window.c: (get_transports),
  28         (init_window), (modest_msg_edit_window_finalize),
  29         (modest_msg_edit_window_get_msg_data),
  30         (modest_msg_edit_window_free_msg_data):
  31         * src/maemo/modest-store-widget.c: (imap_pop_configuration),
  32         (modest_store_widget_finalize):
  33         * src/maemo/modest-transport-widget.c:
  34         (modest_transport_widget_finalize), (smtp_configuration):
  35         * src/modest-main.c: (send_mail):
  36         * src/widgets/modest-combo-box.h:
  37         * src/widgets/modest-global-settings-dialog-priv.h:
  38         * src/widgets/modest-global-settings-dialog.c:
  39         (modest_global_settings_dialog_finalize):
  40         * src/widgets/modest-msg-edit-window.h:
  41         Whenever using modest_combo_box_new(), keep the ModestPairList alive
  42         as long as the combo box, to prevent use of freed memory for the ID.
  43
  44 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  45
  46         * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
  47         get_accounts(), to make this clearer. Do not check for the enabled gconf
  48         key, because we do not use this for server accounts (at least, not yet).
  49         This allows us to send email again.
  50
  51 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  52
  53         * src/maemo/modest-platform.c:
  54         (on_modest_conf_update_interval_changed), (modest_platform_init):
  55         Only respond to this particular key change. All these strcmp()s cannot be
  56         efficient.
  57
  58 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  59
  60         * src/maemo/modest-maemo-global-settings-dialog.c:
  61         (current_connection): Prevent a crash in scratchbox when
  62         ny_maemo_conic_device_get_current_iap_id() returns NULL.
  63         * src/maemo/modest-platform.c:
  64         (on_modest_conf_update_interval_changed), (modest_platform_init):
  65         Get the update interval from gconf and reset it when the gconf key changes.
  66
  67 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
  68
  69         * src/modest-protocol-info.c:
  70         * src/modest-protocol-info.h: Adde enum-specific get functions,
  71         instead of using a ModestProtocolType enum parameter.
  72
  73         * src/gnome/modest-account-assistant.c:
  74         * src/gnome/modest-store-widget.c:
  75         * src/gnome/modest-store-widget.h:
  76         * src/gnome/modest-transport-widget.c:
  77         * src/gnome/modest-transport-widget.h:
  78         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
  79         * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
  80         * src/maemo/easysetup/modest-easysetup-wizard.c:
  81         * src/maemo/modest-account-settings-dialog.c:
  82         * src/maemo/modest-account-settings-dialog.h:
  83         * src/maemo/modest-store-widget.c:
  84         * src/maemo/modest-store-widget.h:
  85         * src/maemo/modest-transport-widget.c:
  86         * src/maemo/modest-transport-widget.h:
  87         * src/modest-account-mgr-helpers.c:
  88         * src/modest-account-mgr-helpers.h:
  89         * src/modest-account-mgr.c:
  90         * src/modest-account-mgr.h:
  91         * src/modest-tny-account.c:
  92         * src/modest-tny-folder.c:
  93         * src/widgets/modest-account-view.c:
  94         * src/widgets/modest-retrieve-combo-box.c:
  95         * src/widgets/modest-retrieve-combo-box.h:
  96         * src/widgets/modest-secureauth-combo-box.c:
  97         * src/widgets/modest-serversecurity-combo-box.c:
  98         * src/widgets/modest-serversecurity-combo-box.h:
  99         * tests/check_account-mgr.c:
 100         Use the specific functions, and use the re-renamed enum values for GNOME too.
 101
 102 2007-05-15  Murray Cumming  <murrayc@murrayc.com>
 103
 104         * src/modest-pair.h:
 105         * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
 106         so we can get the second based on the first.
 107
 108         * src/maemo/modest-account-settings-dialog.h:
 109         * src/maemo/modest-account-settings-dialog.c:
 110         Added get_supported_secure_authentication_methods(), though it is mostly
 111         commented-out for now until the necessary API is committed to tinymail.
 112         (modest_account_settings_dialog_set_account_name),
 113         (save_configuration): Request the supported authentication methods from the
 114         server, so we can choose a working method.
 115
 116         * src/modest-tny-account-store.h:
 117         * src/modest-tny-account-store.c:
 118         (modest_tny_account_store_get_session): Rename from
 119         tny_account_store_get_session().
 120
 121 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 122
 123         * src/modest-protocol-info.h: Split the ModestProtocol enum
 124         into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
 125         There was no need to have these unrelated values in one enum.
 126
 127         * src/: many files: Adapted to changed enum. This makes the code a bit
 128         clearer, and the compiler could catch some errors.
 129
 130 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 131
 132         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 133         Show the detailed internal camel error message when an error happens
 134         during the configuration, so that our testers can give us more clues.
 135         For instance, in projects.maemo.org bug NB#56910 .
 136
 137 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 138
 139         * src/modest-tny-account.c:
 140         (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
 141         change tny_account_set_mech() to tny_account_set_secure_auth_mech().
 142
 143 2007-05-14  Murray Cumming  <murrayc@murrayc.com>
 144
 145         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 146         * src/maemo/modest-account-settings-dialog.c:
 147         (modest_account_settings_dialog_set_account_name),
 148         (save_configuration): For the incoming secure authentication checkbox,
 149         use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
 150         the UI specification. PLAIN does not seem to be supported for most IMAP
 151         servers anyway, and I am not sure what it would mean.
 152         However, we probably need to discover which of the secure-authentication
 153         mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
 154         * src/modest-account-mgr-helpers.c:
 155         (modest_account_mgr_get_server_account_data):
 156
 157         * src/modest-tny-account.c:
 158         (modest_tny_account_new_from_server_account):
 159         Use tny_account_set_mech() to set secure-authentication methods,
 160         with some special-casing for IMAP, based on my observations of how
 161         evolution behaves.
 162
 163         * src/modest-account-mgr-helpers.h:
 164         * src/modest-account-mgr.c:
 165         * src/modest-defs.h: Comment that the URI is only used for local folders.
 166
 167 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 168
 169         * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
 170         parameter const, just to be neat.
 171         * src/modest-text-utils.c: (modest_text_utils_inline):
 172         End g_strconcat() with NULL, as its documentation says. This is almost
 173         certainly the cause of my crash at startup on the device. Interestingly,
 174         valgrind doesn't tell us about these errors.
 175
 176 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 177
 178         * scripts/build-packages: Added more precise comments about how to use
 179         this script, though I still get this error:
 180         dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
 181         error building tinymail
 182
 183 2007-05-11  Murray Cumming  <murrayc@murrayc.com>
 184
 185         * src/maemo/modest-main-window.c: (on_account_update):
 186         Very slight cleanup, hoping to make it simpler to discover what causes
 187         a crash here sometimes.
 188
 189         * src/modest-tny-account.c:
 190         (modest_tny_account_new_from_server_account): Set the port. Added
 191         comments about the options and a TODO comment because I need to find out
 192         how to specify the secure authentication method.
 193
 194 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
 195
 196         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 197         changed CFlags paths form modest to libmodest
 198
 199 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 200
 201         * src/modest-account-mgr-helpers.c:
 202         (modest_account_mgr_get_server_account_data),
 203         (modest_account_mgr_free_server_account_data):
 204         * src/modest-account-mgr-helpers.h:
 205         * src/modest-account-mgr.c:
 206         (modest_account_mgr_add_server_account):
 207         * src/modest-defs.h:
 208         * src/modest-tny-account.c:
 209         (modest_tny_account_new_from_server_account):
 210         Determine the options for tny_camel_account_add_option() here,
 211         based on the settings, rather than storing them directly in gconf.
 212
 213 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 214
 215         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 216         Show a more friendly error dialog now that we expect (from the tinymail
 217         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
 218
 219 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 220
 221         * src/maemo/modest-main-window.c: (on_account_update): Check that
 222         account_name is not NULL, to prevent a crash at startup that I am
 223         seeing on the N800. I do wonder why it is NULL.
 224
 225         * src/maemo/easysetup/modest-easysetup-wizard.c:
 226         (create_page_user_details):
 227         * src/maemo/modest-account-settings-dialog.c:
 228         (create_page_user_details), (create_page_outgoing):
 229         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 230         (modest_connection_specific_smtp_edit_window_init):
 231         * src/modest-ui-actions.c:
 232         (modest_ui_actions_on_password_requested):
 233         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
 234         might do something useful with the on-screen keyboard.
 235
 236 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
 237
 238         * src/maemo/modest-main-window.c: (on_account_update):
 239         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
 240         NULL, to avoid lots of warnings. However, it probably should not be NULL.
 241
 242 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 243
 244         * src/modest-tny-account-store.c: (on_account_changed):
 245         Correct the signature of this signal handler.
 246
 247 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 248
 249         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 250         Show a HildonNote instead of a GtkDialog for Maemo.
 251
 252 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 253
 254         * src/widgets/modest-account-view.h:
 255         * src/widgets/modest-account-view.c: (on_account_changed),
 256         (on_account_removed). Added a boolean flag, set/unset by
 257         modest_account_view_block_conf_updates(),
 258         modest_account_view_unblock_conf_updates() to prevent unnecessary
 259         updates, but this is not very useful because the gconf notifications are
 260         so delays (maybe only on Maemo Bora).
 261         So auto-updating is turned off, and these functions do an explicit
 262         update when necessary.
 263         However, something else is still doing too much work when adding/removing
 264         accounts, probably in another part of the application.
 265
 266         * src/maemo/modest-account-view-window.c:
 267         (on_delete_button_clicked), (on_edit_button_clicked),
 268         (on_new_button_clicked): Use the new functions.
 269
 270 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 271
 272         * src/modest-account-mgr-helpers.c:
 273         (modest_account_mgr_set_first_account_as_default):
 274         Sort the list of names alphabetically-by-title, so we choose the first one
 275         based on that.
 276         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
 277         alphabetically by the title.
 278
 279         This fixes projects.maemo.org bug NB#56418 .
 280
 281         * src/modest-account-mgr-priv.c:
 282         (_modest_account_mgr_account_from_key):
 283         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
 284         avoid a valgrind error, and possible random behaviour.
 285
 286 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 287
 288         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
 289         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
 290         tinymail documentation to say that this can be expected.
 291         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
 292         pretty, and should not happen, but I would prefer to know when it does.
 293
 294 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 295
 296         * configure.ac: When using the older hildon version, probably on Bora,
 297         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 298         to fix the build.
 299         * src/widgets/modest-attachment-view.c:
 300         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 301         build.
 302
 303 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 304
 305         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 306         Implemented the prototype. Can be tested with
 307         tests/dbus_api/test_open_message:
 308
 309 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 310
 311         * src/modest-tny-account-store.c:
 312         (modest_tny_account_store_instance_init), (get_password):
 313         * src/modest-ui-actions.c:
 314         (modest_ui_actions_on_password_requested):
 315         Do not store the password in gconf, because this function is called
 316         for non-remembered passwords. Actually use the cached (in the hash map)
 317         password instead of releasing it.
 318         The password will now not be remembered if it is asked via the protected
 319         password dialog, as per the UI spec.
 320
 321 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 322
 323         * src/modest-defs.h:
 324         * src/modest-account-mgr-helpers.h:
 325         * src/modest-account-mgr-helpers.c:
 326         Added modest_server_account_get_username_has_succeeded(),
 327         modest_server_account_set_username_has_succeeded().
 328         (modest_server_account_set_username),
 329         Reset the has-succeeded flag if the username changes.
 330
 331         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 332         * src/maemo/modest-connection-specific-smtp-window.c:
 333         (modest_connection_specific_smtp_window_save_server_accounts):
 334         Use modest_server_account_set_username() instead of using
 335         modest_conf_set_string() directly, so that the has-succeeded flag is always
 336         reset.
 337
 338         * src/modest-ui-actions.c:
 339         (modest_ui_actions_on_password_requested): Dim the username entry if
 340         the username has ever worked, as per the UI spec.
 341
 342 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 343
 344         * src/modest-tny-account-store.c: (get_password):
 345         * src/modest-ui-actions.c:
 346         (modest_ui_actions_on_password_requested):
 347         Allow the username to be changed too, though there is more work to
 348         be done on exactly how this behaves.
 349
 350 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 351
 352         * src/modest-account-mgr-helpers.h:
 353         * src/modest-account-mgr-helpers.c:
 354         Added modest_account_mgr_get_display_name(),
 355         modest_server_account_get_username(),
 356         modest_server_account_set_username(),
 357         modest_server_account_set_password(),
 358         modest_server_account_get_hostname() functions so we do not need to
 359         use the conf API directly.
 360
 361         * src/maemo/modest-main-window.c: (connect_signals):
 362         Actually connect ot the ModestAccountStore::request-password signal,
 363         so that we show the dialog when the password is requested by Tinymail,
 364         for isntance if it is empty.
 365
 366         * src/modest-marshal.list:
 367         * src/modest-tny-account-store.c:
 368         (modest_tny_account_store_class_init), (get_password),
 369         (modest_tny_account_store_alert):
 370         * src/modest-tny-account-store.h:
 371         * src/modest-ui-actions.h:
 372         * src/modest-ui-actions.c:
 373         (modest_ui_actions_on_password_requested):
 374         Change the signal parameters, so it is obvious that we are providing
 375         the non human-readable server name, and receiving both the username
 376         and password, though changing of the username is not yet implemented.
 377         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 378         for the GNOME version.
 379
 380         This should fix the projects.maemo.org bug NB#56209, though it does not
 381         work on Bora, because the gconf_client_get() for the password fails
 382         immediately after we save it with gconf_client_set().
 383
 384 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 385
 386         * configure.ac:
 387         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 388         caused an undefined symbol error:
 389         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 390
 391 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 392
 393         * src/modest-tny-account-store.c:
 394         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 395         using a GError instead of a string message, so we can translate it in
 396         Modest.
 397
 398 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 399
 400         * src/maemo/modest-address-book.c:
 401         (modest_address_book_check_names):
 402         * src/maemo/modest-msg-view-window.c:
 403         (modest_msg_view_window_clipboard_owner_change):
 404         * src/modest-init.c: (modest_init_init_ui):
 405         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 406         (update_folders_cb), (modest_mail_operation_update_account):
 407         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 408         (modest_ui_actions_on_msg_attachment_clicked),
 409         (modest_ui_actions_on_msg_recpt_activated):
 410         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 411         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 412         (modest_msg_view_search_next):
 413         * src/widgets/modest-recpt-editor.c:
 414         (modest_recpt_editor_on_button_release_event),
 415         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 416         g_message(). At this point we should only be seeing interesting errors on
 417         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 418
 419 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 420
 421         (modest_wizard_dialog_force_title_update):
 422         * src/maemo/easysetup/modest-wizard-dialog.h:
 423         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 424         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 425         can update the title when appropriate. Otherwise the title is wrong if the
 426         pages are added after adding the notebook to the dialog.
 427         This must be a problem in HildonWizardDialog too.
 428         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 429
 430         * src/maemo/easysetup/modest-easysetup-wizard.c:
 431         (create_subsequent_customsetup_pages),
 432         (create_subsequent_easysetup_pages):
 433         Call modest_wizard_dialog_force_title_update() so that the title is
 434         correct even with GTK+ < 2.10.
 435         This fixes projects.maemo.org bug NB#56145 .
 436
 437 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 438
 439         * src/maemo/modest-platform.c:
 440         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 441         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 442         from being shown.
 443
 444 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 445
 446         * src/widgets/modest-window.h:
 447         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 448         and modest_window_save_state(), which invokes it.
 449
 450         * src/widgets/modest-window-mgr.h:
 451         * src/widgets/modest-window-mgr.c:
 452         Added modest_window_mgr_save_state_for_all_windows(), which calls
 453         the save_state vfunc on all registered windows, if implemented.
 454
 455         * src/gnome/modest-msg-edit-window.c:
 456         * src/gnome/modest-msg-view-window.c:
 457         * src/maemo/modest-msg-edit-window.c:
 458         * src/maemo/modest-msg-view-window.c:
 459         * src/maemo/modest-main-window.c:
 460         Specify the existing save_settings functions as implementations of
 461         ModestWindow::save_state_func().
 462
 463         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 464         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 465         enabling hibernation, for instance.
 466
 467         We may need to do the same thing for restoring settings.
 468
 469
 470 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 471
 472         * src/widgets/modest-window-mgr.c:
 473         * src/widgets/modest-window-mgr.h:
 474         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 475         modest_window_mgr_get_hibernation_is_prevented().
 476
 477         * src/maemo/modest-main-window.c:
 478         (on_hildon_program_is_topmost_notify): Prevent hibernation
 479         (possible when the application goes to the background in the WM),
 480         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 481
 482         * src/maemo/easysetup/modest-easysetup-wizard.c:
 483         (modest_easysetup_wizard_dialog_init):
 484         * src/maemo/modest-account-settings-dialog.c:
 485         (modest_account_settings_dialog_init):
 486         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 487         (modest_connection_specific_smtp_edit_window_init):
 488         * src/maemo/modest-connection-specific-smtp-window.c:
 489         (modest_connection_specific_smtp_window_init):
 490         * src/maemo/modest-signature-editor-dialog.c:
 491         (modest_signature_editor_dialog_init):
 492         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 493         prevent hibernation while any of these account settings dialogs are open.
 494
 495 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 496
 497         * src/maemo/Makefile.am:
 498         * src/maemo/modest-osso-state-saving.c:
 499         * src/maemo/modest-osso-state-saving.h: Added
 500         modest_osso_load_state() and modest_osso_save_state() though they do
 501         nothing now. They should iterate through all the open windows and load/save
 502         their state.
 503         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 504         save state when closing.
 505
 506         * src/maemo/modest-main-window.c:
 507         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 508         Add a notification handler for the HildonProgram::is-topmost property,
 509         so we can allow hibernation when the application goes into the background.
 510         But we still need to detect when the accounts setup windows are open so
 511         we can stop hibernation when they are open.
 512         To do this, I also added the main window the HildonProgram. This might have
 513         other side-effects/benefits, and should maybe be done for other windows.
 514
 515         * src/maemo/modest-osso-autosave-callbacks.h:
 516         * src/maemo/modest-osso-autosave-callbacks.c:
 517         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 518         though it does not do anything yet, and we might never need this to do
 519         anything. For instance, we already save drafts.
 520
 521         * src/maemo/modest-platform.c: (modest_platform_init):
 522         Specify the libosso auto-save callback.
 523
 524 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 525
 526         * src/maemo/modest-platform.c:
 527         (modest_platform_set_update_interval):
 528         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 529         aparently stays valid between application instances, so we can use this
 530         to remove and reset it later. According to a maemo-developers email from
 531         David Weinehall.
 532
 533 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 534
 535         * configure.ac: Depend on libalarm for Maemo.
 536
 537         * src/dbus_api/modest-dbus-api.h:
 538         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 539         (on_send_receive), (modest_dbus_req_handler):
 540         Handle a SEND_RECEIVE D-Bus method.
 541
 542         * libmodest-dbus-client/libmodest-dbus-client.c:
 543         (libmodest_dbus_client_send_and_receive):
 544         * libmodest-dbus-client/libmodest-dbus-client.h:
 545         Add C convenience functions for calling the new D-Bus method.
 546
 547         * src/modest-platform.h:
 548         * src/gnome/modest-platform.c:
 549         * src/maemo/modest-platform.c:
 550         Added modest_platform_set_update_interval(), which uses the
 551         alarmd API on Maemo.
 552         (modest_platform_init),
 553         Call modest_platform_set_update_interval(), using a hard-coded
 554         interval for now (until the global settings dialog is implemented),
 555         though I am not sure that this makes sense yet.
 556
 557 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 558
 559         * src/dbus_api/modest-dbus-callbacks.c:
 560         (modest_osso_cb_hw_state_handler):
 561         * src/dbus_api/modest-dbus-callbacks.h:
 562         * src/maemo/modest-platform.c: (modest_platform_init):
 563         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 564         in case this has some effect on the ability for Maemo to ping the
 565         application.
 566
 567 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 568
 569         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 570         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 571         warning. It is probably a logic error, but I need to fix the build.
 572
 573 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 574
 575         * src/modest-account-mgr.h:
 576         * src/modest-account-mgr.c:
 577         (modest_account_mgr_account_names): Add a gboolean enabled_only
 578         parameter, so we can get lists of onlt the enabled accounts.
 579
 580         (modest_account_mgr_add_account),,
 581         (modest_account_mgr_account_with_display_name_exists):
 582         * src/maemo/modest-msg-edit-window.c: (get_transports):
 583         * src/modest-account-mgr-helpers.c:
 584         (modest_account_mgr_set_first_account_as_default):
 585         * src/modest-init.c: (init_default_account_maybe):
 586         * src/modest-tny-account-store.c: (get_accounts):
 587         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 588         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 589         * tests/check_account-mgr.c: (START_TEST):
 590         Provide the extra parameter, as appropriate.
 591
 592         * src/widgets/modest-account-view.c: (update_account_view):
 593         Do not show disabled accounts (meaning that there is no way to
 594         enable/disable accounts in the UI (the feature is not in our UI
 595         specification), so we can use this internally only to mark unfinished
 596         or temporary account data.
 597
 598         * src/maemo/easysetup/modest-easysetup-wizard.c:
 599         (create_account): Add boolean enable parameter, so we can specify FALSE
 600         to create the temporary account.
 601         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 602         (on_before_next): When finishing, when there is a temporary account, just
 603         set it as enabled.
 604         Also, use a timeout to delay the showing of the dialog until gconf is likely
 605         to return correct information, due to a maemo gconf bug that is fixed in
 606         osso 1.1, but not yet in Bora.
 607         However, the dialog stays on screen after it is destroyed.
 608
 609         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 610         for invalid data when cancelling. Use a hildon note instead of a dialog
 611         to complain about invalid data. Do not show the account-saved note if the
 612         account is disabled (a temporary account that will not really be saved for use
 613         until later.)
 614
 615 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 616
 617         * src/modest-account-mgr-helpers.h:
 618         * src/modest-account-mgr-helpers.c:
 619         Added modest_account_mgr_unset_default_account(),
 620         Added modest_account_mgr_set_first_account_as_default().
 621
 622         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 623         If it was the default account, unset the default account name.
 624
 625         * src/maemo/modest-account-view-window.c:
 626         (on_delete_button_clicked): If it was the default account,
 627         set the first remaining account as the default instead.
 628
 629         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 630         a NULL account or a NULL default account, to prevent a crash. This should
 631         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 632
 633
 634 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/widgets/modest-recpt-editor.c:
 637         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 638         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 639         TODO comment for this. This fixes the build.
 640
 641         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 642         be the best place for it. This will in future update all auto-update accounts,
 643         rather than just the current/default account, when that gconf key exists.
 644         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 645         if there are no accounts, before calling do_send_receive().
 646         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 647
 648         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 649         * src/maemo/modest-main-window-ui.h:
 650         * src/maemo/modest-main-window.c: (on_connection_changed),
 651         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 652         directly, becaue the signal handler does more.
 653
 654 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 655
 656         * src/modest-account-mgr-helpers.c:
 657         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 658         for the case that the account does not exist.
 659
 660         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 661         (equivalent to the modest account name) rather than the tinymail account name
 662         (equivalent to the modest account title - human readable) to get the account data.
 663         Check for null account data to prevent the crash, and add a TODO comment saying that
 664         this needs fixing because it is using the server account name instead of the account name.
 665
 666 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 667
 668         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 669         * src/maemo/modest-account-settings-dialog.c: (show_error),
 670         (show_ok):
 671         Use hildon_note_new_information() for informative and error messages,
 672         which seems to be expected for Maemo applications (no documentation that I know of
 673         says this). I am surprised that there is no distinction between info and error
 674         dialogs.
 675
 676 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 677
 678         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 679         it is easy to find where this is used.
 680
 681         * src/maemo/easysetup/modest-easysetup-wizard.c:
 682         (create_page_welcome), (create_page_account_details),
 683         (create_page_user_details), (create_page_complete_easysetup),
 684         (create_page_custom_incoming), (create_page_custom_outgoing),
 685         (create_page_complete_custom):
 686         * src/maemo/modest-account-settings-dialog.c:
 687         (create_page_account_details), (create_page_user_details),
 688         (create_page_incoming), (create_page_outgoing):
 689         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 690         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 691         (modest_connection_specific_smtp_edit_window_init):
 692         * src/maemo/modest-connection-specific-smtp-window.c:
 693         (modest_connection_specific_smtp_window_init):
 694         * src/maemo/modest-signature-editor-dialog.c:
 695         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 696         and scrolling policy as per the Email Application Layout Guide, if I have
 697         understood it.
 698
 699 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 700
 701         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 702         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 703         which were empty, because these vfuncs have been removed from TnyAccountStore.
 704         This fixes the build.
 705
 706 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 707
 708         * src/maemo/modest-main-window.c:
 709         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 710         showing/hiding it. Added TODO because it probably should not be NULL.
 711         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 712         because unnecessary g_warnings() make degugging difficult.
 713
 714 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 715
 716         * src/maemo/modest-msg-edit-window.c:
 717         (modest_msg_edit_window_select_color),
 718         (modest_msg_edit_window_select_background_color): 2 const corrections and
 719         moving 2 #endifs before closing brackets, to fix the build.
 720
 721 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 722
 723         * src/maemo/easysetup/modest-easysetup-wizard.h:
 724         * src/maemo/easysetup/modest-easysetup-wizard.c:
 725         (modest_easysetup_wizard_dialog_finalize),
 726         (on_button_edit_advanced_settings), (create_page_complete_custom),
 727         (on_response), (create_account):
 728         Implement the Advanced Settings edit button, by saving the account information,
 729         for the Advanded Settings dialog to use directly from gconf, and removing it
 730         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 731         Bug #5533 in the projects.maemo.org bugzilla.
 732
 733 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 734
 735         * src/maemo/modest-msg-view-window.c:
 736         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 737         when opening a message window.
 738
 739 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 740
 741         * src/maemo/easysetup/modest-easysetup-wizard.c:
 742         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 743         match the UI spec.
 744
 745         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 746         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 747         gconf settings. I probably added more checks than necessary, but that is safer.
 748
 749         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 750         variable to fix the build, but this seems to be used when it is still NULL.
 751
 752 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 753
 754         * src/modest-platform.h:
 755         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 756         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 757         * src/modest-main.c: Implement this function so we can avoid using
 758         maemo-specific API from cross-platform code.
 759         (main):
 760         * src/modest-tny-account-store.c:
 761         (get_smtp_specific_transport_account_for_open_connection):
 762         * src/modest-ui-actions.c: (check_for_connection),
 763         (modest_ui_actions_on_item_not_found):
 764         Use modest_platform_connect_and_wait() and put #idefs around other
 765         maemo-specific code, because only maemo currently has a way to
 766         identify connection names.
 767
 768 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 769
 770         * src/modest-tny-account-store.h:
 771         * src/modest-tny-account-store.c:
 772         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 773         the connection-specific SMTP server settings in the configuration.
 774
 775         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 776         (on_idle_mail_to):
 777         * src/maemo/modest-main-window.c: (on_connection_changed),
 778         (connect_signals):
 779         * src/modest-main.c: (main), (start_ui), (send_mail):
 780         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 781         that is what is intended.
 782
 783         * src/modest-ui-actions.c: (action_send), (action_receive),
 784         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 785         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 786         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 787         SMTP server is used when it is specified.
 788
 789         (modest_ui_actions_on_send_receive):
 790         Check that a connection is open before proceeding.
 791         Receive and then send, instead of vice-versa, as per the specification.
 792
 793 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 794
 795         * src/modest-mail-operation.c:
 796         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 797         though I guess it should be something other than NULL.
 798
 799 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 800
 801         * src/maemo/easysetup/modest-easysetup-wizard.c:
 802         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 803         combo twice, to avoid an g_warning and to make it visible again.
 804         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 805         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 806         (already intended) dereference when detaching, because we then recreate the menu.
 807         But I am not sure why the warning was happening, and it is possible that this is a memory
 808         leak.
 809
 810 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 811
 812         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 813         and uri_parse_mailto() utility functions.
 814         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 815         the mailto URI.
 816         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 817
 818 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 819
 820         * src/dbus_api/modest-dbus-api.h:
 821         * src/dbus_api/modest-dbus-callbacks.c:
 822         Use an idle callback to execute the modest code in the application's own thread.
 823         Remove the helloworld example method.
 824         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 825         parsed, and the open-message method is not implemented because this is not yet implemented in
 826         modest itself.
 827         * libmodest-dbus-client/libmodest-dbus-client.c:
 828         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 829         (libmodest_dbus_client_open_message):
 830         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 831
 832         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 833         body without crashing.
 834
 835         * tests/dbus_api/Makefile.am:
 836         * tests/dbus_api/test_mail_to.c:
 837         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 838
 839 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 840
 841         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 842         Added file to fix the build. Sorry.
 843
 844         * src/dbus_api/Makefile.am:
 845         * src/dbus_api/modest-dbus-api.h:
 846         * src/dbus_api/modest-dbus-callbacks.h:
 847         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 848         (modest_dbus_req_handler):
 849         Put constants in a separate header so it can be reused by the
 850         client library, without duplication
 851
 852         * libmodest-dbus-client/Makefile.am:
 853         * libmodest-dbus-client/libmodest-dbus-client.c:
 854         (libmodest_dbus_client_call_helloworld),
 855         (libmodfest_dbus_client_send_mail),
 856         (libmodfest_dbus_client_mailto),
 857         (libmodfest_dbus_client_open_message):
 858         * libmodest-dbus-client/libmodest-dbus-client.h:
 859         (Partly) Implement a send_mail D-Bus method.
 860
 861         * tests/dbus_api/Makefile.am:
 862         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 863         the send_email D-Bus method.
 864
 865 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 866
 867         * Makefile.am:
 868         * configure.ac:
 869         * libmodest-dbus-client/Makefile.am:
 870         * libmodest-dbus-client/libmodest-dbus-client.c:
 871         * libmodest-dbus-client/libmodest-dbus-client.h:
 872         * tests/dbus_api/Makefile.am:
 873         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 874         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 875
 876 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 877
 878         * src/maemo/easysetup/modest-easysetup-wizard.c:
 879         (create_page_account_details):
 880         * src/maemo/modest-account-settings-dialog.c:
 881         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 882         widgets, because this might not be the default in future versions of the Maemo GTK+.
 883         However, I can not not get capitalization to work even in a simple test case.
 884
 885 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 886
 887         * src/maemo/easysetup/modest-easysetup-wizard.c:
 888         (create_page_custom_incoming), (create_page_custom_outgoing):
 889         * src/maemo/modest-account-settings-dialog.c:
 890         (create_page_account_details), (create_page_incoming),
 891         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 892         instead of using gtk_check_button_with_label(), so they are aligned like the other
 893         widgets, as per the UI spec.
 894
 895 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 896
 897         * src/maemo/easysetup/modest-easysetup-wizard.c:
 898         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 899         * src/widgets/modest-validating-entry.c:
 900         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 901         Modest prefix instead of an EasySetup prefix.
 902
 903 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 904
 905         * src/widgets/modest-validating-entry.h:
 906         * src/widgets/modest-validating-entry.c: (on_insert_text),
 907         Added easysetup_validating_entry_set_max_func(), used to set a callback
 908         to call when the max number of characters is reached. GtkEntry has a max-length
 909         already but is silent about it.
 910
 911         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 912         (create_page_account_details), (create_page_user_details),
 913         (create_account):
 914         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 915         (create_page_account_details), (create_page_user_details),
 916         (create_page_outgoing):
 917         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 918         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 919         the UI spec, when the user tries to enter more than the max number of characters.
 920
 921 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 922
 923         * src/maemo/easysetup/modest-easysetup-wizard.c:
 924         (create_page_user_details), (create_page_custom_incoming),
 925         (create_page_custom_outgoing):
 926         * src/maemo/modest-account-settings-dialog.c:
 927         (create_page_user_details), (create_page_incoming),
 928         (create_page_outgoing):
 929         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 930         (modest_connection_specific_smtp_edit_window_init):
 931         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 932         not appropriate. Bad Maemo-specific defaults!.
 933
 934 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 935
 936         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 937         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 938         (modest_signature_editor_dialog_set_settings):
 939         Disable the label and textview when the checkbox is disabled, and use the
 940         specified (UI spec) default signature text.
 941
 942 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 943
 944         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 945         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 946
 947         * src/modest-defs.h:
 948         * src/modest-account-mgr-helpers.h:
 949         * src/modest-account-mgr-helpers.c:
 950         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 951
 952         * src/maemo/Makefile.am:
 953         * src/maemo/modest-signature-editor-dialog.c:
 954         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 955         as per the UI spec.
 956
 957         * src/maemo/modest-account-settings-dialog.h:
 958         * src/maemo/modest-account-settings-dialog.c:
 959         (modest_account_settings_dialog_finalize), (on_button_signature),
 960         (save_configuration): Use the new dialog when the Edit button is pressed, and
 961         save the changes if necessary, as per the UI spec.
 962
 963 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 964
 965         * src/maemo/Makefile.am:
 966         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 967         based on maemo-develoers email from Dirk.
 968
 969         * src/maemo/easysetup/modest-easysetup-wizard.c:
 970         (create_page_welcome), (create_page_account_details),
 971         (create_page_user_details), (create_page_complete_easysetup),
 972         (create_page_custom_incoming), (create_page_custom_outgoing),
 973         (create_page_complete_custom),
 974         (modest_easysetup_wizard_dialog_init):
 975         * src/maemo/modest-account-settings-dialog.c:
 976         (create_page_account_details), (create_page_user_details),
 977         (create_page_incoming), (create_page_outgoing),
 978         (modest_account_settings_dialog_init):
 979         * src/maemo/modest-connection-specific-smtp-window.c:
 980         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 981
 982 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 983
 984         * src/maemo/easysetup/modest-easysetup-wizard.c:
 985         (create_page_account_details), (create_page_custom_outgoing),
 986         (create_page_complete_custom):
 987         * src/maemo/modest-account-settings-dialog.c:
 988         (create_page_user_details), (create_page_incoming),
 989         (create_page_outgoing):
 990         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 991         (modest_connection_specific_smtp_edit_window_init):
 992         Use the correct (UI spec) port min/max, and use horizontal separators,
 993         as per the UI spec.
 994
 995 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 996
 997         * src/maemo/easysetup/modest-easysetup-wizard.c:
 998         (set_default_custom_servernames):
 999         * src/maemo/modest-account-settings-dialog.c:
1000         (create_page_incoming), (on_combo_outgoing_security_changed),
1001         (on_combo_incoming_security_changed), (create_page_outgoing),
1002         (modest_account_settings_dialog_set_account_name),
1003         (save_configuration):
1004         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1005         (on_combo_security_changed),
1006         (modest_connection_specific_smtp_edit_window_init),
1007         (modest_connection_specific_smtp_edit_window_set_connection),
1008         (modest_connection_specific_smtp_edit_window_get_settings):
1009         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1010         as per the UI spec.
1011
1012 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1013
1014         * po/en_GB.po:
1015         * src/maemo/easysetup/modest-easysetup-wizard.c:
1016         (create_page_custom_outgoing), (create_page_complete_custom):
1017         * src/maemo/modest-account-settings-dialog.c:
1018         (create_page_user_details), (create_page_outgoing):
1019         * src/maemo/modest-account-view-window.c: (button_box_new):
1020         Use changed logical IDs as per the most recent UI spec:
1021         mcen_bd_emailsetup_edit -> mcen_bd_edit
1022         mcen_bd_emailsetup_delete -> mcen_bd_delete
1023         mcen_bd_emailsetup_close -> mcen_bd_close
1024
1025 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1026
1027         * configure.ac:
1028         * src/Makefile.am:
1029         * src/dbus_api/Makefile.am:
1030         * src/dbus_api/modest-dbus-callbacks.c:
1031         * src/dbus_api/modest-dbus-callbacks.h:
1032         * src/maemo/modest-platform.c: (modest_platform_init):
1033         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1034         method.
1035         * tests/Makefile.am:
1036         * tests/dbus_api/Makefile.am:
1037         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1038
1039 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1040
1041         * src/maemo/modest-account-settings-dialog.c:
1042         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1043         Removed unnecessary includes.
1044
1045 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1046
1047         * src/maemo/easysetup/modest-easysetup-wizard.c:
1048         * src/maemo/modest-account-settings-dialog.c:
1049         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1050         * src/widgets/Makefile.am:
1051         * src/widgets/modest-easysetup-secureauth-combo-box.c:
1052         * src/widgets/modest-easysetup-secureauth-combo-box.h:
1053         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1054         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1055         * src/widgets/modest-secureauth-combo-box.c:
1056         * src/widgets/modest-secureauth-combo-box.h:
1057         * src/widgets/modest-serversecurity-combo-box.c:
1058         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1059         made the GObject names more consistent with the rest of the Modest code.
1060
1061 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1062
1063         * src/maemo/easysetup/Makefile.am:
1064         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1065         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1066         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1067         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1068         * src/maemo/easysetup/modest-easysetup-wizard.c:
1069         * src/maemo/easysetup/modest-validating-entry.c:
1070         * src/maemo/easysetup/modest-validating-entry.h:
1071         * src/maemo/modest-account-settings-dialog.c:
1072         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1073         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1074         widgets/ because they are used outside of easysetup too. After checking in,
1075         svn will allow me to rename them too.
1076
1077 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1078
1079         * src/gnome/modest-msg-edit-window.c:
1080         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1081         linker error, to fix the build on the GNOME platform.
1082         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1083         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1084         ifdefed out to avoid a warning.
1085
1086 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
1087
1088         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1089         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1090         some alternative for GTK+ 2.6.
1091
1092 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1093
1094         * src/maemo/modest-address-book.c: Added include to avoid a warning.
1095
1096         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1097         specified for EmailAccountsDialog in UI spec.
1098
1099         * src/maemo/easysetup/modest-easysetup-wizard.c:
1100         * src/maemo/easysetup/modest-easysetup-wizard.h:
1101         * src/maemo/modest-account-settings-dialog.c:
1102         * src/maemo/modest-account-settings-dialog.h:
1103         Reuse a member window widget for the connection-specific SMTP server accounts,
1104         so we can tell it to create/save the accounts only if we actually save changes.
1105
1106         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1107         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1108         (modest_connection_specific_smtp_edit_window_get_settings):
1109         Return a struct instance for temporarily remembering the entered data.
1110
1111         * src/maemo/modest-connection-specific-smtp-window.h:
1112         * src/maemo/modest-connection-specific-smtp-window.c:
1113         (modest_connection_specific_smtp_window_finalize),
1114         (modest_connection_specific_smtp_window_fill_with_connections),
1115         (on_button_edit),
1116         (modest_connection_specific_smtp_window_save_server_accounts),
1117         (update_model_server_names): Do not actually save data until asked,
1118         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1119
1120         (on_selection_changed),
1121         (modest_connection_specific_smtp_window_init): Disable the edit
1122         button when nothing is selected.
1123
1124         * src/modest-account-mgr-helpers.c:
1125         * src/modest-account-mgr-helpers.h:
1126         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1127         elsewhere.
1128
1129 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
1130
1131         * src/modest-account-mgr-helpers.h:
1132         * src/modest-account-mgr-helpers.c:
1133         (modest_account_mgr_get_unused_account_name),
1134         (modest_account_mgr_get_unused_account_display_name): Added these
1135         utility functions, to avoid code duplication.
1136
1137         * src/maemo/easysetup/modest-easysetup-wizard.c:
1138         (create_page_account_details), (create_account):
1139         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1140         (on_combo_security_changed),
1141         (modest_connection_specific_smtp_edit_window_init),
1142         (modest_connection_specific_smtp_edit_window_save_settings):
1143         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1144         * src/maemo/modest-connection-specific-smtp-window.c:
1145         (modest_connection_specific_smtp_window_finalize),
1146         (modest_connection_specific_smtp_window_fill_with_connections),
1147         (on_button_edit), (modest_connection_specific_smtp_window_init):
1148         * src/maemo/modest-connection-specific-smtp-window.h:
1149         Implementing saving of connection-specific server accounts.
1150
1151         But I need to refactor this so we can save the data for each
1152         possible connection-specific account and only actually create the server accounts
1153         when the easysetup finished, or the OK button is pressed on the account settings
1154         dialog.
1155
1156 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1157
1158         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1159         (on_combo_security_changed):
1160         (modest_connection_specific_smtp_edit_window_init):
1161         Auto-fill the port number as in the account settings.
1162
1163         (modest_connection_specific_smtp_edit_window_set_connection):
1164         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1165         * src/maemo/modest-connection-specific-smtp-window.c:
1166         (fill_with_connections), (on_button_edit),
1167         (modest_connection_specific_smtp_window_init):
1168         Turn the edit window into a dialog to simplify the code, and
1169         set a WM hint as in a GtkDialog, because only a popup can be on top of
1170         another window in Maemo, and popups usually have no WM decoration.
1171
1172         * src/modest-defs.h:
1173         * src/modest-account-mgr-helpers.c:
1174         (modest_account_mgr_set_connection_specific_smtp),
1175         (modest_account_mgr_remove_connection_specific_smtp),
1176         (modest_account_mgr_get_connection_specific_smtp):
1177         * src/modest-account-mgr-helpers.h: Some functions to write the
1178         connection-specific SMTP server information. Not yet used.
1179
1180
1181         * src/widgets/modest-folder-view.c: (text_cell_data):
1182         Fix a warning about an uninitialized variable.
1183         (on_configuration_key_changed): Put an #ifdef around the use
1184         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1185
1186 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1187
1188         * src/maemo/modest-account-settings-dialog.h:
1189         * src/maemo/modest-account-settings-dialog.c:
1190         Added connect_for_modified() utility function to mark the new modified boolean.
1191
1192         (create_page_account_details), (create_page_user_details),
1193         (create_page_incoming), (create_page_outgoing), (on_response),
1194         (modest_account_settings_dialog_init),
1195         (modest_account_settings_dialog_set_account_name):
1196         Only warn about unsaved changes when there are actually unsaved changes.
1197
1198         * src/modest-account-mgr-helpers.c:
1199         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1200         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1201         to get the data from there in future.
1202
1203 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1204
1205         * src/modest-defs.h:
1206
1207         * src/modest-account-mgr-helpers.h:
1208         * src/modest-account-mgr-helpers.c:
1209         Store the security account setting in a single conf key instead of using
1210         the options list, so that the list is left for just the to-be-removed camel hack,
1211         and because gconf_client_set_list() is failing for some reason.
1212
1213         * src/modest-account-mgr.c:
1214         (modest_account_mgr_add_server_account):
1215         * src/maemo/modest-account-settings-dialog.c:
1216         (modest_account_settings_dialog_set_account_name),
1217         (save_configuration): Use the renamed functions.
1218
1219
1220 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1221
1222         * src/widgets/Makefile.am:
1223         * src/widgets/modest-limit-retrieve-combo-box.c:
1224         * src/widgets/modest-limit-retrieve-combo-box.h:
1225         * src/widgets/modest-retrieve-combo-box.c:
1226         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1227         the account settings dialog.
1228
1229         * src/modest-defs.h:
1230         * src/modest-account-mgr-helpers.h:
1231         * src/modest-account-mgr-helpers.c:
1232         (modest_server_account_get_option_secure_auth),
1233         (modest_server_account_set_option_secure_auth):
1234         * src/modest-account-mgr.c:
1235         (modest_account_mgr_add_server_account):
1236         Use the existing AUTH_MECH conf key for the secure-auth setting,
1237         instead of putting it in the list options, because this was actually used already.
1238
1239         * src/maemo/modest-account-settings-dialog.c:
1240         (create_page_account_details),
1241         (modest_account_settings_dialog_set_account_name),
1242         (save_configuration):
1243         * src/maemo/modest-account-settings-dialog.h:
1244         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1245         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1246
1247 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1248
1249         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1250         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1251         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1252
1253         * src/modest-defs.h:
1254         * src/maemo/modest-account-settings-dialog.c:
1255         (create_page_incoming), (on_combo_outgoing_security_changed),
1256         (on_combo_incoming_security_changed), (create_page_outgoing),
1257         (modest_account_settings_dialog_set_account_name),
1258         (save_configuration): Load/Save the port number, and change it when the
1259         security combo changes, to suitable defaults.
1260
1261 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1262
1263         * src/modest-account-mgr.c:
1264         (modest_account_mgr_add_server_account): Set the security and secure-auth
1265         options, and add a comment saying that the other camel-specific options should be
1266         removed in future.
1267
1268 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1269
1270         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1271         found by valgrind.
1272         * src/modest-tny-account-store.c: (account_list_free),
1273         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1274         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1275         easy to fix.
1276
1277 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1278
1279         * src/modest-protocol-info.c:
1280         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1281         is required by our UI spec. Maybe something in our implementation will use this eventually.
1282         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1283         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1284         instead of the previous 0 placeholder.
1285
1286         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1287         secure-auth settings.
1288         * src/modest-account-mgr-helpers.h:
1289         * src/modest-account-mgr-helpers.c:
1290         (modest_server_account_data_get_option_secure_auth),
1291         (modest_server_account_set_option_secure_auth),
1292         (modest_server_account_data_get_option_security),
1293         (modest_server_account_set_option_security): Added this API for getting and setting the security
1294         and secure-auth settings.
1295
1296         * src/maemo/modest-account-settings-dialog.h:
1297         * src/maemo/modest-account-settings-dialog.c:
1298         (modest_account_settings_dialog_finalize), (check_data),
1299         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1300         about changing titles.
1301         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1302         (save_configuration): Save the security and secure-auth settings.
1303
1304         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1305         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1306
1307 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1308
1309         * src/modest-defs.h:
1310         * src/modest-account-mgr.c:
1311         (modest_account_mgr_add_server_account):
1312         Added and used defines for the options key and value pair strings,
1313         that are used so far, though they do not seem to correspond to anything in our
1314         UI specs or ModestProtocol enum.
1315
1316         * src/modest-account-mgr-helpers.h:
1317         * src/modest-account-mgr-helpers.c:
1318         (compare_option_strings_for_name),
1319         (modest_server_account_data_get_option_value),
1320         (modest_server_account_data_get_option_bool),
1321         (modest_account_mgr_get_server_account_option):
1322         Added helper functions for parsing the options GSList.
1323
1324 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1325
1326         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1327         display name is based on the supplied account name.
1328         * src/modest-account-mgr.c:
1329         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1330         with an inefficient, but good-enough, implementation.
1331
1332         * src/maemo/easysetup/modest-easysetup-wizard.c:
1333         (create_page_account_details), (on_before_next), (create_account):
1334         Check for existing display names rather than (non-user-visible) account names, and just
1335         create and set a unique account name at the end.
1336
1337         * src/maemo/modest-account-settings-dialog.c:
1338         (modest_account_settings_dialog_init),
1339         (modest_account_settings_dialog_set_account_name),
1340         (create_page_incoming): Show the display name, instead of the account name.
1341         (on_response): Do some (not all) extra checks, as in the UI spec.
1342         (save_configuration): Save the display name if it was changed.
1343
1344 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1345
1346         * po/en_GB.po: Added needed logical ID and translation.
1347         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1348         (init_view): Made the is-default column clicking work.
1349
1350 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1351
1352         * configure.ac:
1353         * src/maemo/easysetup/Makefile.am:
1354         * src/maemo/easysetup/modest-easysetup-wizard.c:
1355         (modest_easysetup_wizard_dialog_init):
1356         * src/maemo/easysetup/provider-data-test.keyfile:
1357         * src/maemo/easysetup/provider-data.keyfile:
1358         Moved the provider data file to the new modest-providers-data package and used it from there.
1359
1360 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1361
1362         * src/modest-local-folder-info.c:
1363         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1364         N_() was already used on the static strings, but this just marks it for translation without
1365         using the translation.
1366
1367 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1368
1369         * src/maemo/modest-account-settings-dialog.c:
1370         (create_page_incoming),
1371         (modest_account_settings_dialog_set_account_name):
1372         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1373         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1374         I will do this if nobody else gets there first.
1375
1376 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1377
1378         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1379         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1380         save the security stuff.
1381
1382 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1383
1384         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1385         Set the email address and user fullname, which I now see must be
1386         done separately.
1387
1388         * src/maemo/modest-account-settings-dialog.h:
1389         * src/maemo/modest-account-settings-dialog.c:
1390          (on_response),
1391         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1392         leave-on-server and authentication.
1393         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1394         how to do the rest.
1395
1396 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1397
1398
1399         * src/maemo/modest-account-settings-dialog.c:
1400         * src/maemo/modest-account-settings-dialog.h:
1401         Most (but not all) of the widgets are now present as specified by the UI spec.
1402         No changes are yet saved, and some details are not properly shown yet.
1403
1404         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1405
1406 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1407
1408         * src/maemo/Makefile.am:
1409         * src/maemo/modest-account-settings-dialog.c:
1410         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1411         an existing account. Doesn't do much yet.
1412
1413         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1414         Open the accounts settings dialog when Edit is clicked.
1415
1416 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1417
1418         * src/maemo/easysetup/Makefile.am:
1419         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1420         (load_from_file):
1421         * src/maemo/easysetup/modest-easysetup-wizard.c:
1422         (modest_easysetup_wizard_dialog_init):
1423         Try to get the source directory from the build system,
1424         instead of hard-coding "./" into the source code, when opening our local
1425         copies of the configuration files.
1426         But this still fails when opening the wizard from the Accounts window,
1427         maybe because the working directory seems to change at runtime.
1428         So the wizard will fail the second time unless you copy the files into their
1429         proper locations - see the stdout warnings for the paths.
1430
1431         (create_page_account_details),(on_before_next):
1432         Check for existing non-server accounts instead of server accounts,
1433         so the default account name is useful again, and to prevent trying to
1434         recreate accounts.
1435
1436         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1437         Show the wizard when New is clicked.
1438
1439         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1440         (init_view): Show the column headers, and show the columns that are
1441         specified in the UI specs. However, something in Maemo's GTK+ prevents
1442         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1443         change the default account. This is despite unsetting the special properties.
1444
1445 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1446
1447         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1448         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1449         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1450         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1451         to make that clearer.
1452         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1453
1454 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1455
1456         * src/maemo/modest-account-view-window.c:
1457         (modest_account_view_window_init),
1458         (modest_account_view_window_new):
1459         Use the same buttons as specified in the
1460         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1461         the existing widgets, which never had a chance of working.
1462         Put the ModestAccountView treeview in a scrolled window.
1463         Do not repeat the initialization in both _init() and _new().
1464
1465         * src/widgets/modest-account-view.c: (update_account_view):
1466         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1467         this widget and window shows no accounts.
1468
1469         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1470
1471 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1472
1473         * src/maemo/easysetup/modest-easysetup-wizard.c:
1474         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1475         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1476         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1477         which seems wrong.
1478
1479         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1480         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1481         accounts exist yet, as in the UI spec.
1482
1483         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1484
1485 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1486
1487         * src/maemo/Makefile.am:
1488         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1489         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1490         New window for editing connection-specific smtp details.
1491         Not fully implemented.
1492
1493         * src/maemo/modest-connection-specific-smtp-window.c:
1494         (modest_connection_specific_smtp_window_finalize) :
1495         unref the tree model.
1496         (on_button_edit): Show the edit window.
1497
1498 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1499
1500         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1501         error for me.
1502
1503         * src/maemo/Makefile.am:
1504         * src/maemo/modest-connection-specific-smtp-window.c:
1505         * src/maemo/modest-connection-specific-smtp-window.h:
1506         New window for showing the list of connections, for connection-specific
1507         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1508         * src/maemo/easysetup/modest-easysetup-wizard.c:
1509         (create_page_custom_outgoing): Show the new window when the button is clicked.
1510
1511 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1512
1513         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1514         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1515         * src/maemo/modest-msg-edit-window.c:
1516         (modest_msg_edit_window_insert_image):
1517         * src/modest-conf.c: (modest_conf_key_escape):
1518         * src/modest-mail-operation.c:
1519         (modest_mail_operation_send_new_mail):
1520         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1521         (modest_ui_actions_on_new_account):
1522         * src/widgets/modest-attachment-view.c: (update_filename_request):
1523         * src/widgets/modest-mail-header-view.c:
1524         Corrected warnings that were breaking the build, by commenting out unused variables,
1525         and a function, and by including a header.
1526
1527 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1528
1529         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1530         so we can #ifdef around platform-specific code when necessary.
1531         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1532         to allow this to build for the GNOME platform too.
1533
1534 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1535
1536         * src/maemo/easysetup/modest-easysetup-wizard.c:
1537         Added util_increment_name() and used it in create_page_account_details()
1538         to make sure that the default account name is always a new name.
1539
1540         (modest_easysetup_wizard_dialog_init),
1541         (set_default_custom_servernames): Some minor memory management fixes.
1542
1543 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1544
1545         * Makefile.am:
1546         * configure.ac:
1547         * src/modest-runtime.c: (init_i18n): Restored the translation
1548         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1549         are defined in config.h, and the translations are installed.
1550
1551         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1552         is defined for translation.
1553
1554 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1555
1556         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1557         (load_from_file):
1558         * src/maemo/easysetup/modest-easysetup-wizard.c:
1559         (modest_easysetup_wizard_dialog_init):
1560         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1561         Use realistic paths (though they should use $prefix generically) to the
1562         mcc_mapping and provider-data.keyfile files which might work when they
1563         are installed by the future version of the operator-wizard package,
1564         and then fallback to paths in our source code, with an explanatory
1565         warning.
1566
1567 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1568
1569         * configure.ac:
1570         * src/Makefile.am:
1571         * src/maemo/Makefile.am:
1572         * src/maemo/easysetup/: Added files from the previously-exernal
1573         osso-modest-easysetup.
1574         * src/maemo/modest-main-window-ui.h:
1575         * src/modest-ui-actions.c:
1576         * src/modest-ui-actions.h:
1577         Added modest_ui_actions_on_new_account() as a signal handler for the
1578         New Account menu item. It shows the easysetup wizard.
1579         * po/en_GB.po: Added additional needed logical IDs and translations.
1580
1581 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1582 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1583