1 2007-06-08 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
4 keys changed in the last X seconds.
6 * src/modest-account-mgr.h:
7 * src/modest-account-mgr.c: (on_timeout_notify_changes),
8 (on_key_change), (modest_account_mgr_class_init),
9 (modest_account_mgr_init), (modest_account_mgr_finalize):
10 As the keys are changed, save them in a GSList* and signal that GSList*
11 further every X seconds, to batch changes, to allow us to do just one
12 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
13 bug NB#56941 and other (UI-blocking) delays when changing account settings.
15 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
16 changed signal signature.
18 * src/modest-conf.c: (modest_conf_set_list),
19 (modest_conf_on_change): Reenable notification.
21 (modest_conf_maemo_fake_on_change): Comment out the hack that
22 notified immediately instead of asynchronously.
24 * src/widgets/modest-account-view.h:
25 * src/widgets/modest-account-view.c:
26 (update_account_view): Select the previously-selected account ID,
27 if possible. This fixes projects.maemo.org bug NB#56933.
29 (on_account_changed), (on_account_removed),
30 (modest_account_view_select_account):
32 Remove the block/unblock functions
33 because they were not useful.
35 * src/maemo/modest-account-view-window.c:
36 (on_delete_button_clicked), (on_edit_button_clicked),
37 (on_new_button_clicked): Remove the use of the non-working block/unblock.
39 2007-06-08 Murray Cumming <murrayc@murrayc.com>
41 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
42 Improve the error dialog to show Incorrect Account Settings, which seems
43 clearer, and say that the internal error message (to be removed from the
44 dialog later) is often misleading.
45 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
47 * src/modest-tny-account.c:
48 (modest_tny_account_new_from_server_account): Uncomment the printf of the
49 URL because this is so useful for debugging on the device.
51 * src/widgets/modest-serversecurity-combo-box.c:
52 (modest_serversecurity_combo_box_fill): Correct a logical ID.
54 2007-06-08 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-mail-operation.c:
57 (modest_mail_operation_send_new_mail):
58 Added a comment about a nasty but apparently harmless message. Details
59 added to the wiki g_warnings() page.
61 2007-06-08 Murray Cumming <murrayc@murrayc.com>
63 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
64 (modest_tny_send_queue_class_init):
65 Do not use the priv struct because it is empty, to avoid g_warnings
66 about a non-existant priv struct.
68 * src/modest-tny-account-store.c:
69 (modest_tny_account_store_get_server_account),
70 (modest_tny_account_store_get_transport_account_for_open_connection
71 ): Do not try to get transport server accounts for local folders,
72 because they don't have any. This avoids a g_warning().
74 * src/maemo/modest-main-window.c:
75 (modest_main_window_notify_send_receive_initied),
76 (on_configuration_key_changed):
77 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
79 * src/modest-mail-operation.c:
80 (modest_mail_operation_update_account):
81 * src/modest-tny-account-store.h:
82 * src/modest-tny-account.c:
83 (modest_tny_account_get_special_folder),
84 (modest_tny_account_new_for_local_folders),
85 (modest_tny_account_new_for_per_account_local_outbox_folder):
86 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
87 * src/modest-tny-local-folders-account.c:
88 (add_account_folders_to_merged_folder):
89 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
90 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
91 (modest_ui_actions_on_send):
92 * src/widgets/modest-folder-view.c: (update_model):
93 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
94 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
95 modest_tny_account_store_get_tny_account_by_account() to
96 modest_tny_account_store_get_server_account() to make the code clearer.
98 2007-06-07 Marcus Bauer <marcusb@openismus.com>
100 * src/dbus_api/modest-dbus-api.h:
101 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
102 * src/maemo/modest-msg-edit-window.c:
103 (modest_msg_edit_window_attach_file_noninteractive):
104 added g_warning in case the file to be attached does not exist
105 * tests/dbus_api/test_compose_mail.c: (main):
106 removed obsolete comment, added generic files as test case
108 2007-06-07 Murray Cumming <murrayc@murrayc.com>
110 * src/modest-tny-account-store.c: (get_server_accounts):
111 Create the local folders account only once, not once for each outbox, and
112 not only when there are some outboxes.
114 2007-06-07 Murray Cumming <murrayc@murrayc.com>
116 * src/widgets/modest-folder-view.c: (update_model): Comment out some
117 code that is causing a crash at startup. Sergio says that he is fixing this.
119 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
121 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
122 * src/maemo/modest-account-settings-dialog.c:
123 (create_page_outgoing),
124 (modest_account_settings_dialog_set_account_name),
125 (save_configuration):
126 - Fixed handling of the "Use secure authentication" toggle to comply with
127 the ui specification. See also projects.maemo.org bug NB#58400
129 - Restore the Secure connection setting combo correctly when loading
132 * src/maemo/modest-maemo-utils.c:
133 (on_camel_account_get_supported_secure_authentication),
134 (modest_maemo_utils_get_supported_secure_authentication_methods):
135 Fixed a crasher if operation is canceled
137 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
138 (modest_protocol_info_auth_is_secure):
139 * src/modest-protocol-info.h:
141 Added two new methods to determine if a protocol/auth method is secure/encrypted in
142 the sense of the "Use secure authentication" toggle.
144 2007-06-07 Murray Cumming <murrayc@murrayc.com>
146 * src/modest-tny-account-store.h:
147 * src/modest-tny-account-store.c:
148 Added modest_tny_account_store_get_local_folders_account().
150 * src/modest-tny-folder.h:
151 * src/modest-tny-folder.c:
152 (modest_tny_folder_get_account):
153 Added this replacement for tny_folder_get_account() which returns
154 the local-folders account for TnyMergeFolders, to avoid the
155 warning about the unimplemented get_account_func() vfunc().
157 (modest_tny_folder_get_rules),
158 * src/modest-ui-actions.c:
159 (modest_ui_actions_on_folder_selection_changed):
160 * src/modest-mail-operation.c:
161 (modest_mail_operation_remove_folder),
162 (modest_mail_operation_xfer_folder),
163 (modest_mail_operation_rename_folder),
164 (modest_mail_operation_get_msg),
165 (modest_mail_operation_get_msgs_full),
166 (modest_mail_operation_remove_msg),
167 (modest_mail_operation_xfer_msgs),
168 (modest_mail_operation_refresh_folder):
169 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
171 2007-06-07 Murray Cumming <murrayc@murrayc.com>
173 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
174 (modest_server_account_set_security):
175 * src/modest-defs.h: Add comments explaining that our
176 UI spec means TLS when it says Normal, so these do not look like errors.
178 * src/modest-tny-account.c:
179 (modest_tny_account_new_from_server_account): Use the new tinymail
180 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
181 for TLS. This should fix projects.maemo.org bug NB#58460.
183 2007-06-06 Murray Cumming <murrayc@murrayc.com>
185 * src/maemo/easysetup/modest-easysetup-wizard.c:
186 (create_account): Correct the position of the gconf sanity check warning.
187 (on_button_edit_advanced_settings): Show the dialog immediately, instead
188 of using the g_idle_add() hack, because this does not seem to be necessary
189 on osso 1.1. It might even work on Maemo Bora if the problems were actually
190 caused by something other than maemo's gconf.
191 This fixes projects.maemo.org bug #59022.
193 2007-06-06 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-account-mgr-helpers.c:
196 (modest_account_mgr_get_default_account): Do not check that the account
197 exists if there is no default account (NULL), to fix a runtime warning.
199 2007-06-06 Murray Cumming <murrayc@murrayc.com>
201 * src/widgets/modest-folder-view.c: (update_model):
202 Do not unref the treemodel before we have finished with it.
203 This prevents a valgrind warning and an occasional crash at startup.
205 2007-06-06 Marcus Bauer <marcusb@openismus.com>
207 * libmodest-dbus-client/libmodest-dbus-client.h:
208 added libmodest_dbus_client_compose_mail()
209 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
211 added functions needed for SendAsMail() functionality
212 * src/maemo/modest-msg-edit-window.c:
213 (modest_msg_edit_window_attach_file_noninteractive):
214 non interactively attaching files to message edit window
215 * src/widgets/modest-msg-edit-window.h:
216 * tests/dbus_api/Makefile.am:
217 added test_compose_mail.c
218 * tests/dbus_api/test_compose_mail.c: (main):
220 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
222 * src/modest-account-view.c:
223 Fixed bug projects.maemo.org bug NB#59307
225 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
227 * src/maemo/easysetup/modest-easysetup-wizard.c:
228 (get_serverport_incoming), (on_before_next), (create_account):
229 * src/maemo/modest-account-settings-dialog.c:
230 (modest_account_settings_dialog_set_account_name):
231 * src/maemo/modest-maemo-utils.c:
232 (on_camel_account_get_supported_secure_authentication_status),
233 (on_camel_account_get_supported_secure_authentication),
234 (on_secure_auth_cancel),
235 (modest_maemo_utils_get_supported_secure_authentication_methods):
237 Implemented security authentication for settings and easysetup.
239 2007-06-05 Murray Cumming <murrayc@murrayc.com>
241 * src/maemo/modest-main-window.c: (create_details_widget):
242 Show the total size for memory card accounts too, instead of showing
243 the name again. Fixes bug projects.maemo.org bug NB#59307.
245 2007-06-05 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-tny-simple-folder-store.c:
249 * src/modest-tny-simple-folder-store.h: Removed.
251 * src/modest-tny-local-folders-account.h
252 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
253 for the local-folders maildir, with an extra TnyMergedFolder containing
254 the folders of the per-account outbox store accounts.
255 * src/modest-tny-account-store.c: (get_server_accounts):
256 Add the outboxes to the special local folders account after creating it.
258 * src/modest-tny-account.c:
259 (modest_tny_account_new_for_local_folders): Create the derived
260 account when creating the main local-folders account.
262 * src/maemo/modest-main-window.c: (create_details_widget),
263 (modest_main_window_set_contents_style):
264 Adapted to the use of the derived account instead of the folder store.
266 * src/modest-ui-actions.c:
267 (modest_ui_actions_on_folder_selection_changed):
268 * src/modest-ui-dimming-rules.c:
269 (modest_ui_dimming_rules_on_new_folder):
270 * src/widgets/modest-folder-view.c: (text_cell_data),
271 (icon_cell_data), (filter_row), (update_model),
272 (get_cmp_rows_type_pos):
275 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
276 Do not get the priv struct, because no priv struct has been set,
277 to avoid a runtime warning.
279 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
280 #ifelse with #else, to fix a warning, to fix the build.
283 2007-06-05 Christian Kellner <ckellner@openismus.com>
285 * libmodest-dbus-client/libmodest-dbus-client.c:
286 Fix small typo in doc (why do you always see them
287 AFTER committing stuff?)
290 2007-06-05 Christian Kellner <ckellner@openismus.com>
292 * libmodest-dbus-client/libmodest-dbus-client.c:
293 (libmodest_dbus_client_search):
294 Initialize hit list with NULL. Also set folder list
295 to "" if NULL was supplied.
298 2007-06-03 Christian Kellner <ckellner@openismus.com>
300 * libmodest-dbus-client/libmodest-dbus-client.c:
301 (modest_search_hit_list_free):
302 Make it save to call it with NULL.
304 * src/dbus_api/modest-dbus-callbacks.c:
305 * src/modest-search.c:
306 Return full ModestSearchHits as the search result list not TnyHeader
307 since can't be around withouth the correspoding TnyFolder.
309 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
311 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
312 Added currently commented code to check for secure auth
314 * src/maemo/modest-account-settings-dialog.c: (on_response),
315 (save_configuration), (show_ok):
316 Fixed projects.maemo.org bugs NB #59248 and #59251
318 * src/maemo/modest-maemo-utils.c:
319 (on_camel_account_get_supported_secure_authentication_status),
320 (on_camel_account_get_supported_secure_authentication),
321 (modest_maemo_utils_get_supported_secure_authentication_methods):
322 * src/maemo/modest-maemo-utils.h:
323 Moved get_supported_secure_authentication() method here to be able
324 to use it from easysetup wizard.
326 * src/modest-pair.c: (on_pair_compare_as_string):
327 Should compare string with first part of pair and not
328 strcmp pairs which will crash.
330 * src/modest-protocol-info.c:
331 (modest_protocol_info_protocol_is_store):
332 * src/modest-protocol-info.h:
333 Added modest_protocol_info_get_auth_protocol_name()
335 2007-06-03 Armin Burgmeier <armin@openismus.com>
337 * src/modest-mail-operation.c:
338 (modest_mail_operation_get_msgs_full): Set priv->account also when
339 only retrieving a single message. This avoids a crash when canceling
342 (modest_mail_operation_notify_end): Do not explicitely remove the
343 operation from the queue but only emit the progress_changed signal.
344 The queue itself listens to that signal to remove the operation when
345 it is finished. This reduces coupling and removes a potential deadlock
346 when modest_mail_operation_notify_end() is called from the queue
347 itself. If that is a problem performance-wise, I would suggest to
348 implement a status-changed signal or something.
350 * src/modest-mail-operation-queue.c: Make sure to never call a
351 function from another file while the queue is locked. This (hopefully)
352 fixes another deadlock when exiting the application while retrieving
355 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
357 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
358 Fixed build if libogs is not available
360 2007-06-03 Christian Kellner <ckellner@openismus.com>
362 * libmodest-dbus-client/libmodest-dbus-client.h:
363 * libmodest-dbus-client/libmodest-dbus-client.c:
364 (libmodest_dbus_client_delete_message):
365 Implement deletion of messages (Client side).
367 (modest_search_hit_free),
368 (modest_search_hit_list_free):
369 Utility functions to free the result hits.
371 * src/dbus_api/modest-dbus-api.h:
372 * src/dbus_api/modest-dbus-callbacks.c:
374 (modest_dbus_req_handler):
375 Implement deletion of messages (Server side).
377 * tests/dbus_api/test_search.c: (main):
380 * tests/dbus_api/Makefile.am:
381 * tests/dbus_api/test_delete_message:
382 Add little test for the message deletion logic
384 2007-06-03 Armin Burgmeier <armin@openismus.com>
386 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
387 when the operation queue was not empty. projects.maemo.org bug
390 2007-06-03 Armin Burgmeier <armin@openismus.com>
392 * src/widgets/modest-account-view.c
393 (on_account_default_toggled): Toggle default account column
394 explicitely instead of waiting for gconf notification (which is
395 currently ignored). This should fix projects.maemo.org bug NB#56910
396 for now. It should probably be removed when gconf notifications are
399 2007-06-03 Christian Kellner <ckellner@openismus.com>
401 * libmodest-dbus-client/libmodest-dbus-client.c:
402 Removed debugging spew.
404 * src/dbus_api/modest-dbus-callbacks.c:
405 Added debugging info.
407 * src/modest-search.c:
408 (modest_search_all_accounts):
409 Use tny_account_store_get_accounts () on the account store
410 to get all accounts which is the way to get all accounts.
412 * tests/dbus_api/test_search.c: (main):
413 Make it possible to supply the search term on the command line.
415 2007-06-03 Christian Kellner <ckellner@openismus.com>
417 * libmodest-dbus-client/libmodest-dbus-client.c:
418 * libmodest-dbus-client/libmodest-dbus-client.h:
419 Implement searching for mesages over raw dbus. (Client side)
421 * src/dbus_api/Makefile.am:
422 * src/dbus_api/modest-dbus-api.h:
423 * src/dbus_api/modest-dbus-callbacks.c:
424 * src/dbus_api/modest-dbus-callbacks.h:
425 Search framework (Server side). Also implement on_idle_open_message().
427 * src/maemo/modest-platform.c: (modest_platform_init):
428 Prepare for raw dbus/osso rpc interaction.
430 * src/modest-search.h:
431 Changed minsize from unspecific guint to guint32.
433 * src/modest-search.c:
435 Added strange hack which magically made tnymail work.
437 (modest_search_folder),
438 (modest_search_account),
439 (modest_search_all_accounts):
440 Implement helper functions to search all accounts, specific account
443 * tests/dbus_api/Makefile.am:
444 * tests/dbus_api/test_open_message.c:
445 Read url to open from commandline.
447 * tests/dbus_api/test_search.c:
448 Implement small test for dbus search stuff
450 2007-06-02 Armin Burgmeier <armin@openismus.com>
452 * src/maemo/modest-account-settings-dialog.c: Changed window title to
453 include account type and account title. This fixes projects.maemo.org
456 * src/maemo/modest-account-view-window.c: Set a title for the window.
458 2007-06-02 Armin Burgmeier <armin@openismus.com>
460 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
461 incoming and outgoing server name based on email address and server
462 types as long as the names have not been edited manually. This fixes
463 projects.maemo.org bug NB#58671.
465 2007-06-02 Armin Burgmeier <armin@openismus.com>
467 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
468 server type cannot be changed in future to the incoming details page
469 when creating an account. This fixes projects.maemo.org bug NB#59029.
471 2007-06-02 Armin Burgmeier <armin@openismus.com>
473 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
474 and assigned max width chars so that they wrap instead of being
475 truncated. Fixes projects.maemo.org bug NB#56126.
477 2007-06-02 Armin Burgmeier <armin@openismus.com>
479 * src/maemo/modest-connection-specific-smtp-window.c: Add an
480 introductory note to the connection specific smtp servers dialog, as
481 section 8.12 of the email UI specification requires. This fixes
482 projects.maemo.org bug NB#59212.
484 2007-06-01 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
487 Check for running mail operations, and offer to cancel them, as per the UI
488 spec. This fixes projects.maemo.org bug NB#59041 .
489 However, I suspect that tinymail may still use the network connection
490 in ways that we cannot detect or cancel. But it should at least adapt to
493 2007-06-01 Murray Cumming <murrayc@murrayc.com>
495 * src/modest-tny-account-store.c: (recreate_all_accounts),
496 (get_cached_accounts), (get_server_accounts): Do more sensible
497 ref-counting of the temporarily-cached outbox accounts list. This seems
498 to fix a crash when entering the password when the password was wrong.
500 2007-06-01 Murray Cumming <murrayc@murrayc.com>
502 * src/gnome/modest-main-window.c: (connect_signals):
503 * src/modest-tny-account-store.c: (get_password),
504 (modest_tny_account_store_alert): Added comments and clues and
505 commented-out code about how we currently fail to deal with connection
506 errors and wrong passwords, and how we should.
508 2007-06-01 Murray Cumming <murrayc@murrayc.com>
510 * src/widgets/modest-retrieve-combo-box.c:
511 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
512 This fixes projects.maemo.org bug NB#58472 .
514 2007-06-01 Murray Cumming <murrayc@murrayc.com>
516 * src/maemo/easysetup/modest-easysetup-wizard.c:
517 (create_page_complete_easysetup):
518 (create_page_complete_custom): Correct the last commit,
519 putting the correct sentences in the correct pages.
521 2007-06-01 Murray Cumming <murrayc@murrayc.com>
523 * src/maemo/easysetup/modest-easysetup-wizard.c:
524 (create_page_complete_custom): Show the second sentence of text
525 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
528 2007-06-01 Murray Cumming <murrayc@murrayc.com>
530 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
531 Set the leave-on-server conf key by default. This fixes
532 projects.maemo.org bug NB#59258 .
534 2007-06-01 Murray Cumming <murrayc@murrayc.com>
536 * src/maemo/modest-account-view-window.c:
537 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
538 logical ID for the confirmation messages. Fixed projects.maemo.org bug
541 2007-06-01 Murray Cumming <murrayc@murrayc.com>
543 * src/maemo/easysetup/modest-easysetup-wizard.c:
544 (create_caption_new_with_asterisk):
545 * src/maemo/modest-account-settings-dialog.c:
546 (create_caption_new_with_asterisk):
547 Uncomment the code to add the asterisk, because they are no longer in the
548 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
549 (update_incoming_server_title): Add an asterisk here too.
551 2007-06-01 Murray Cumming <murrayc@murrayc.com>
553 * src/maemo/modest-maemo-global-settings-dialog.c:
554 (current_connection): Check that we are even connected before trying to
555 get the current connection name, to prevent a warning.
557 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
558 Change the comments because tny_maemo_conic_device_connect() is now meant to
560 * src/modest-mail-operation.c:
561 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
562 make sure we have a connection and fail if we can't connect.
564 2007-05-31 Murray Cumming <murrayc@murrayc.com>
566 * src/maemo/modest-main-window.c:
567 (on_account_store_connecting_finished): Do not try to get the
568 connection ID if we are not really connected. I am surprised that
569 this signal handler is called when we are not connected.
571 2007-05-31 Murray Cumming <murrayc@murrayc.com>
573 * src/modest-error.h:
574 * src/modest-ui-actions.c:
575 (modest_ui_actions_get_msgs_full_error_handler):
576 Renamed an enum, added comments, added an enum
577 for retrieve-limit errors.
579 * src/modest-mail-operation.c: (foreach_add_item),
580 (internal_folder_observer_update), (update_account_thread),
581 (modest_mail_operation_get_msgs_full):
582 (modest_mail_operation_update_account),
583 Added comments about how this works, and some code that should
584 (but does not) check the retrieve-limit. See the TODO comment.
586 2007-05-31 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
589 Initialize help_id to fix the build. Warnings are good.
591 2007-05-31 Murray Cumming <murrayc@murrayc.com>
593 * src/widgets/modest-hbox-cell-renderer.c:
594 (modest_hbox_cell_renderer_append):
595 * src/widgets/modest-vbox-cell-renderer.c:
596 (modest_vbox_cell_renderer_append):
597 Fix the last commit by doing an extra ref.
599 2007-05-31 Murray Cumming <murrayc@murrayc.com>
601 * src/widgets/modest-hbox-cell-renderer.c:
602 (modest_hbox_cell_renderer_append):
603 * src/widgets/modest-vbox-cell-renderer.c:
604 (modest_vbox_cell_renderer_append):
605 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
606 to fix the build with Maemo Bora.
607 However, there seems to be a remaining crash, probably due to reference
610 2007-05-30 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-tny-account.c:
613 (modest_tny_account_new_for_local_folders):
614 Use hildon_file_system_info_async_new() to get a better name for
615 the memory card account, setting it as the account name.
616 The timing seems to work, but this is probably
617 not the best place to do this. See the TODO comment.
618 * src/maemo/modest-main-window.c: (create_details_widget):
619 * src/widgets/modest-folder-view.c: (text_cell_data):
620 Use the tny account name instead of hardcoding a name.
622 2007-05-30 Christian Kellner <ckellner@openismus.com>
624 * src/modest-search.c: (modest_search):
625 Correctly set part_search_func even if we have already parsed
626 the query and thus a valid OgsTextSearcher object.
628 2007-05-30 Christian Kellner <ckellner@openismus.com>
631 Search and check for libogs.
634 Incooparte the ogs build env.
636 * src/modest-mime-part-search-stream.c:
637 * src/modest-mime-part-search-stream.h:
638 Removed since we do the real searching now in modest-search.c.
640 * src/modest-search.c:
641 * src/modest-search.h:
642 Implement support for ogs. We use that if available and requested
643 and fall back to modest_text_utils_utf8_strcmp (). The search logic
644 should now handle the corner case when the search term is spread
645 across multiple reads.
646 Also the logic in modest_search () was corrected to search all
647 requested fields until one is found.
649 2007-05-30 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
654 * src/modest-init.c: Made modest_init_local_folders() take a
655 path and be public so we can iniitialize maildir folders on
658 * src/modest-local-folder-info.h:
659 * src/modest-local-folder-info.c:
660 (modest_local_folder_info_get_maildir_path): Add a path parameter.
662 * src/modest-tny-account.c:
663 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
664 still means the standard local-folders path on the local volume.
666 * src/modest-tny-account-store.c:
667 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
668 signal so we can detect mount/unmount of the MMC1 card, and do an update of
669 all accounts when that happens.
670 (get_server_accounts): If the MMC1 card is mounted, create a store account for
671 this too, so it shows up in the treeview.
673 2007-05-28 Murray Cumming <murrayc@murrayc.com>
675 * src/maemo/modest-maemo-global-settings-dialog.c:
676 (current_connection):
677 * src/widgets/modest-global-settings-dialog.c:
678 (current_connection_default):
679 Use the enum values instead of 0, 1 and -1,
680 to make the code clearer.
682 * src/modest-account-mgr-helpers.c:
683 (modest_account_mgr_get_connection_specific_smtp): Make this code
686 * src/modest-runtime.h:
687 * src/modest-runtime.c:
688 Added modest_runtime_remove_all_send_queues().
689 * src/maemo/modest-main-window.c:
690 (on_account_store_connecting_finished): Recreate the send queues,
691 using the appropriate transport accounts for this new connection.
692 Some futher adapting might be needed if the old send queues are not
693 automatically stopped at this point.
695 * src/modest-tny-account-store.c: (get_server_accounts):
696 Create the connection-specific transport accounts, so that they can
697 be found later by their ID.
699 * src/modest-tny-account.h:
700 * src/modest-tny-account.c:
701 Added modest_tny_account_new_from_server_account_name().
702 modest_tny_account_new_from_server_account(): Do not create the
703 send queues here, because they will be
704 recreated anyway when the connection changes for the first time.
706 2007-05-28 Murray Cumming <murrayc@murrayc.com>
708 * src/modest-local-folder-info.h:
709 * src/modest-local-folder-info.c:
710 (modest_per_account_local_outbox_folder_info_get_maildir_path),
711 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
712 tbox_folder): Take a modest account name instead of a server TnyAccount,
713 so we can have per-modest-account rather than per-transport-account
715 We must make sure that we change or recreate the exisitng send queues
716 when the connection changes for connection-specific transport accounts.
718 * src/modest-tny-account-store.c:
719 (create_per_account_local_outbox_folders): Create outboxed per modest
720 account, not per transport account.
722 * src/modest-tny-account.h:
723 * src/modest-tny-account.c:
724 (modest_tny_account_get_special_folder): For outboxes, get the
725 parent modest account name. The account is ignored for other folders.
726 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
727 modest account name rather than a server TnyAccount.
729 2007-05-25 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-tny-account.c:
732 (modest_tny_account_new_from_server_account):
733 Call modest_runtime_get_send_queue() immediately after creating transport
734 accounts, so that they start trying to send email from the outbox as soon
735 as possible at startup. This is probably what we want.
737 * src/modest-mail-operation.c: (update_account_thread):
738 * src/modest-runtime.c: (modest_runtime_get_send_queue):
739 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
740 * src/modest-tny-send-queue.h:
741 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
742 (modest_ui_actions_on_send):
743 Added comments about how sending works, though it needs some more work.
745 2007-05-25 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-tny-account.c:
748 (modest_tny_account_get_special_folder): Add TODO because this fails when
750 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
751 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
752 Do not try to show this window when there is no active account. The UI
753 specs does not tell us what to do in this case.
755 2007-05-24 Murray Cumming <murrayc@murrayc.com>
759 * src/maemo/Makefile.am:
760 * src/widgets/Makefile.am: Some dist fixes.
762 2007-05-24 Murray Cumming <murrayc@murrayc.com>
764 * src/maemo/modest-connection-specific-smtp-window.c:
765 (on_button_edit): Make the code clearer, to prevent a double free.
767 2007-05-24 Murray Cumming <murrayc@murrayc.com>
769 * src/maemo/modest-account-settings-dialog.c:
770 (modest_account_settings_dialog_set_account_name),
771 Check the connection-specific smtp servers checkbox if there are any.
773 * src/maemo/modest-connection-specific-smtp-edit-window.c:
774 (modest_connection_specific_smtp_edit_window_init):
775 Start with a suitable port number.
777 * src/modest-account-mgr-helpers.h:
778 * src/modest-account-mgr-helpers.c: Added
779 modest_account_mgr_get_has_connection_specific_smtp().
781 (modest_account_mgr_set_connection_specific_smtp),
782 (modest_account_mgr_remove_connection_specific_smtp),
783 (modest_account_mgr_get_has_connection_specific_smtp),
784 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
785 connection-specific smtp server accounts in the account, rather than
786 the server account conf dir.
788 This fixes bug projects.maemo.org bug NB#58263 .
790 * src/modest-tny-account-store.c:
791 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
792 if there are no server accounts yet, to prevent an infinite loop when there
793 are no accounts. Document that one must be called before the other.
795 2007-05-24 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-account-mgr-helpers.c:
798 (modest_account_mgr_get_default_account): Make sure that at least
799 one account is always the default, if there are any enabled accounts.
800 This is just a sanity check that shouldn't be necessary.
802 * src/modest-account-mgr-priv.c:
803 (_modest_account_mgr_account_from_key): Unescape the conf key to
804 get the real account name. For instance, this is an issue if a space
805 was in the account name, which can happen because the account name
806 is generated from the display name.
807 (_modest_account_mgr_get_account_keyname): Always escape the
809 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
810 Unescape the conf keys to get the real account names.
812 For instance, previously the is-default radio button in the accounts
813 list was not checked for any accounts at first. This fixes that,
814 and might fix several similar bugs.
816 2007-05-23 Murray Cumming <murrayc@murrayc.com>
818 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
819 Removed some debug printfs.
821 2007-05-23 Murray Cumming <murrayc@murrayc.com>
823 Modest on-disk outbox directories are now here, for instance:
824 $HOME/.modest/outboxes/<account-id-1>/outbox
825 $HOME/.modest/outboxes/<account-id-2>/outbox
827 $HOME/.modest/local-folders/outbox
828 so we can have a separate outbox for each account.
829 But they are shown as one outbox in the GtkTreeView, by using a
830 TnyMergeFolder in a ModestTnySimpleFolderStore.
833 * src/modest-tny-simple-folder-store.c:
834 * src/modest-tny-simple-folder-store.h:
835 Added ModestTnySimpleFolderStore, used to contain folders from
836 other folder stores, such as other accounts.
838 * src/modest-tny-outbox-account.h:
839 * src/modest-tny-outbox-account.c:
840 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
841 used for the per-account local outbox folders.
843 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
844 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
845 only use this (internally) now for the non-outbox local folders.
848 * src/modest-init.c: Added modest_init_one_local_folder(), for
849 setting up the directory structure for each local folder.
851 * src/modest-local-folder-info.c:
852 (modest_per_account_local_outbox_folder_info_get_maildir_path),
853 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
855 * src/modest-local-folder-info.h:
856 * src/modest-tny-account-store.c: (on_account_removed),
857 (on_account_changed), (create_per_account_local_outbox_folders),
858 (get_server_accounts), (modest_tny_account_store_get_accounts),
859 (modest_tny_account_store_get_tny_account_by_account),
860 (modest_tny_folder_store_is_virtual_local_folders):
862 * src/modest-tny-account.h:
863 * src/modest-tny-account.c:
864 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
865 to create an on-disk per-account local outbox folder for each
867 (create_per_account_local_outbox_folders): Create a local outbox folder
868 for each transport account.
869 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
870 for all local folders.
872 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
873 instead of using g_object_get/set() directly. It is clearer.
875 (modest_tny_folder_store_get_message_count),
876 (modest_tny_folder_store_get_local_size
877 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
878 because we now use these with non-acount folder stores.
880 (modest_tny_account_get_special_folder),
881 (modest_tny_account_new_from_server_account),
882 (modest_tny_account_new_from_account):
883 (recurse_folders): Adjust to the new outbox system.
885 * src/modest-tny-folder.h:
886 * src/modest-tny-folder.c:
887 (modest_tny_folder_is_local_folder),
888 (modest_tny_folder_get_local_folder_type),
889 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
891 * src/widgets/modest-main-window.h:
892 * src/maemo/modest-main-window.c: (create_details_widget),
893 (modest_main_window_set_contents_style): Show details for any folder store,
896 (modest_tny_folder_get_rules):
897 Remove the const. C does not support constness enough for this.
899 * src/modest-ui-actions.c:
900 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
901 make all outboxes appear as one, in the usual local-folders tree node.
903 (set_active_account_from_tny_account),
904 (modest_ui_actions_on_folder_selection_changed):
905 * src/widgets/modest-folder-view.c: (text_cell_data),
906 (icon_cell_data), (filter_row),
907 (add_account_folders_to_merged_folder),
908 (add_account_folders_to_simple_folder_store), (),
909 (get_cmp_rows_type_pos), (cmp_rows),
910 (modest_folder_view_set_account_id_of_visible_server_account):
911 Adjust to the new outbox system, using generic folder stores and folders
914 2007-05-23 Christian Kellner <ckellner@openismus.com>
916 * src/modest-mail-operation.c:
917 (modest_mail_operation_update_account):
918 Use info->max_size instead of unintialized local var [small
919 build fix]. (Added TODO to review that change since I don't
922 2007-05-23 Marcus Bauer <marcusb@openismus.com>
924 * libmodest-dbus-client/libmodest-dbus-client.c:
925 (libmodest_dbus_client_compose_mail): function added
926 * src/dbus_api/modest-dbus-api.h:
927 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
928 (on_compose_mail): Implementation of the SendAsMail functionality
930 2007-05-22 Murray Cumming <murrayc@murrayc.com>
932 * src/modest-account-mgr.c:
933 (modest_account_mgr_add_server_account): Set the secure-connection
934 conf key for transport accounts as well as store accounts. I don't know
935 why the if was there. For instance, this makes sure that we use SSL
936 for the gmail preset from the easysetup wizard.
938 2007-05-22 Murray Cumming <murrayc@murrayc.com>
940 * src/gnome/modest-main-window.c:
941 (on_account_store_connecting_finished), (connect_signals):
942 * src/maemo/modest-main-window.c:
943 (on_account_store_connecting_finished), (connect_signals),
944 (modest_main_window_new):
945 Handle TnyAccountStore::connecting-finished instead of
946 TnyDevice::connection-changed, because we cannot actually perform
947 operations on accounts until TnyAccountStore has itself responded to
948 the TnyDevice::connection-changed signal. This prevents a GError from
950 Do not try to update at startup, because we (at least on scratchbox)
951 already do an update at startup when the device goes online.
952 This prevents a GError from tinymail.
953 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
954 Added TODO about stopping simultaneous operations.
956 2007-05-21 Murray Cumming <murrayc@murrayc.com>
958 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
959 * src/modest-mail-operation-queue.c:
960 (modest_mail_operation_queue_remove):
961 * src/modest-tny-account-store.c: When GErrors happen, give more clues
962 about where they happened.
964 2007-05-21 Murray Cumming <murrayc@murrayc.com>
966 * src/modest-ui-actions.c:
967 (modest_ui_actions_on_password_requested): Make sure that the remember
968 output parameter is always TRUE.
970 2007-05-21 Murray Cumming <murrayc@murrayc.com>
972 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
973 Show a OK/Cancel dialog if the error is a question, though we still do not
974 know anything more about what we are asking the user.
975 * src/widgets/modest-folder-view.c: (on_drag_data_received):
976 Fix an uninitialized variable (helper). This is a logic error, however.
978 2007-05-21 Christian Kellner <ckellner@openismus.com>
980 * src/modest-search.h:
981 Correct bit shifting in the ModestSearchFlags enum.
983 2007-05-21 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-tny-account.c:
986 (modest_tny_account_new_from_server_account): Do not use the lsub and
987 check-all hard-coded IMAP options when using POP.
989 2007-05-21 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account.c:
992 (modest_tny_account_new_from_server_account):
993 Use NULL for the secure-auth method for POP when Password auth has been
994 specified by the user, as we already do for IMAP. "auth=Login" causes
995 an error from camel or the server.
997 2007-05-17 Murray Cumming <murrayc@murrayc.com>
999 * src/maemo/modest-account-settings-dialog.c:
1000 (create_page_account_details),
1001 (modest_account_settings_dialog_set_account_name):
1002 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1003 for the leave-on-server checkbox, rathr than just the checkbox, when
1004 the protocol is not POP.
1006 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1008 * src/widgets/modest-account-view.c:
1009 * src/widgets/modest-account-view.h:
1010 Added modest_account_view_select_account() which will be useful later
1011 to asynchronously re-select the edited account.
1013 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1015 * src/maemo/modest-account-settings-dialog.c:
1016 (modest_account_settings_dialog_set_account_name):
1017 Automatically choose the port numbers based on the secure authentication
1018 methods, if they have not been chosen before.
1019 This fixes projects.maemo.org bug NB#56273 .
1021 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1023 * src/maemo/modest-main-window-ui.h:
1024 * src/modest-ui-actions.c:
1025 * src/modest-ui-actions.h:
1026 Connect the Tools/SMTP Servers menu item to
1027 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1028 SMTP servers dialog, as in the UI specification and saves changes when it
1029 is closed. This fixed projects.maemo.org bug NB#56305 .
1031 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1033 * src/maemo/modest-connection-specific-smtp-window.c:
1034 (modest_connection_specific_smtp_window_init):
1035 Use gtk_window_set_default_size() to make this window big enough, so
1036 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1038 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1042 (modest_connection_specific_smtp_edit_window_init),
1043 Do not try to connect to a combobox signal before the combobox exists.
1044 This fixes the cras in projects.maemo.org bug NB#56288 .
1045 (modest_connection_specific_smtp_edit_window_get_settings):
1046 Remove the server_account_name parameter which was being checked for NULL
1047 though it was not used.
1049 * src/maemo/modest-connection-specific-smtp-window.c:
1050 (modest_connection_specific_smtp_window_fill_with_connections),
1051 (on_button_edit), (modest_connection_specific_smtp_window_init):
1052 Correct the number of treemodel columns to prevent a warning.
1053 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1054 libconic does not work.
1056 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-tny-account.c:
1059 (modest_tny_account_new_from_server_account):
1060 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1061 SMTP when "None" was chosen by the user. However, with my SMTP server that
1062 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1065 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1068 to explain the memory management issue with the ID in the ModestPair.
1070 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1071 (add_sending_page), (modest_account_assistant_finalize):
1072 * src/gnome/modest-gnome-global-settings-dialog.c:
1073 (create_updating_page), (create_composing_page):
1074 * src/gnome/modest-msg-edit-window.c: (get_transports),
1075 (init_window), (modest_msg_edit_window_finalize),
1076 (modest_msg_edit_window_get_msg_data):
1077 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1078 * src/gnome/modest-transport-widget.c:
1079 (modest_transport_widget_finalize), (smtp_configuration):
1080 * src/maemo/modest-maemo-global-settings-dialog.c:
1081 (create_updating_page), (create_composing_page):
1082 * src/maemo/modest-msg-edit-window.c: (get_transports),
1083 (init_window), (modest_msg_edit_window_finalize),
1084 (modest_msg_edit_window_get_msg_data),
1085 (modest_msg_edit_window_free_msg_data):
1086 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1087 (modest_store_widget_finalize):
1088 * src/maemo/modest-transport-widget.c:
1089 (modest_transport_widget_finalize), (smtp_configuration):
1090 * src/modest-main.c: (send_mail):
1091 * src/widgets/modest-combo-box.h:
1092 * src/widgets/modest-global-settings-dialog-priv.h:
1093 * src/widgets/modest-global-settings-dialog.c:
1094 (modest_global_settings_dialog_finalize):
1095 * src/widgets/modest-msg-edit-window.h:
1096 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1097 as long as the combo box, to prevent use of freed memory for the ID.
1099 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1101 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1102 get_accounts(), to make this clearer. Do not check for the enabled gconf
1103 key, because we do not use this for server accounts (at least, not yet).
1104 This allows us to send email again.
1106 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1108 * src/maemo/modest-platform.c:
1109 (on_modest_conf_update_interval_changed), (modest_platform_init):
1110 Only respond to this particular key change. All these strcmp()s cannot be
1113 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1115 * src/maemo/modest-maemo-global-settings-dialog.c:
1116 (current_connection): Prevent a crash in scratchbox when
1117 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1118 * src/maemo/modest-platform.c:
1119 (on_modest_conf_update_interval_changed), (modest_platform_init):
1120 Get the update interval from gconf and reset it when the gconf key changes.
1122 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-protocol-info.c:
1125 * src/modest-protocol-info.h: Adde enum-specific get functions,
1126 instead of using a ModestProtocolType enum parameter.
1128 * src/gnome/modest-account-assistant.c:
1129 * src/gnome/modest-store-widget.c:
1130 * src/gnome/modest-store-widget.h:
1131 * src/gnome/modest-transport-widget.c:
1132 * src/gnome/modest-transport-widget.h:
1133 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1134 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1135 * src/maemo/easysetup/modest-easysetup-wizard.c:
1136 * src/maemo/modest-account-settings-dialog.c:
1137 * src/maemo/modest-account-settings-dialog.h:
1138 * src/maemo/modest-store-widget.c:
1139 * src/maemo/modest-store-widget.h:
1140 * src/maemo/modest-transport-widget.c:
1141 * src/maemo/modest-transport-widget.h:
1142 * src/modest-account-mgr-helpers.c:
1143 * src/modest-account-mgr-helpers.h:
1144 * src/modest-account-mgr.c:
1145 * src/modest-account-mgr.h:
1146 * src/modest-tny-account.c:
1147 * src/modest-tny-folder.c:
1148 * src/widgets/modest-account-view.c:
1149 * src/widgets/modest-retrieve-combo-box.c:
1150 * src/widgets/modest-retrieve-combo-box.h:
1151 * src/widgets/modest-secureauth-combo-box.c:
1152 * src/widgets/modest-serversecurity-combo-box.c:
1153 * src/widgets/modest-serversecurity-combo-box.h:
1154 * tests/check_account-mgr.c:
1155 Use the specific functions, and use the re-renamed enum values for GNOME too.
1157 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1159 * src/modest-pair.h:
1160 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1161 so we can get the second based on the first.
1163 * src/maemo/modest-account-settings-dialog.h:
1164 * src/maemo/modest-account-settings-dialog.c:
1165 Added get_supported_secure_authentication_methods(), though it is mostly
1166 commented-out for now until the necessary API is committed to tinymail.
1167 (modest_account_settings_dialog_set_account_name),
1168 (save_configuration): Request the supported authentication methods from the
1169 server, so we can choose a working method.
1171 * src/modest-tny-account-store.h:
1172 * src/modest-tny-account-store.c:
1173 (modest_tny_account_store_get_session): Rename from
1174 tny_account_store_get_session().
1176 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1178 * src/modest-protocol-info.h: Split the ModestProtocol enum
1179 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1180 There was no need to have these unrelated values in one enum.
1182 * src/: many files: Adapted to changed enum. This makes the code a bit
1183 clearer, and the compiler could catch some errors.
1185 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1188 Show the detailed internal camel error message when an error happens
1189 during the configuration, so that our testers can give us more clues.
1190 For instance, in projects.maemo.org bug NB#56910 .
1192 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1194 * src/modest-tny-account.c:
1195 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1196 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1198 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1201 * src/maemo/modest-account-settings-dialog.c:
1202 (modest_account_settings_dialog_set_account_name),
1203 (save_configuration): For the incoming secure authentication checkbox,
1204 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1205 the UI specification. PLAIN does not seem to be supported for most IMAP
1206 servers anyway, and I am not sure what it would mean.
1207 However, we probably need to discover which of the secure-authentication
1208 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1209 * src/modest-account-mgr-helpers.c:
1210 (modest_account_mgr_get_server_account_data):
1212 * src/modest-tny-account.c:
1213 (modest_tny_account_new_from_server_account):
1214 Use tny_account_set_mech() to set secure-authentication methods,
1215 with some special-casing for IMAP, based on my observations of how
1218 * src/modest-account-mgr-helpers.h:
1219 * src/modest-account-mgr.c:
1220 * src/modest-defs.h: Comment that the URI is only used for local folders.
1222 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1224 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1225 parameter const, just to be neat.
1226 * src/modest-text-utils.c: (modest_text_utils_inline):
1227 End g_strconcat() with NULL, as its documentation says. This is almost
1228 certainly the cause of my crash at startup on the device. Interestingly,
1229 valgrind doesn't tell us about these errors.
1231 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1233 * scripts/build-packages: Added more precise comments about how to use
1234 this script, though I still get this error:
1235 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1236 error building tinymail
1238 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/modest-main-window.c: (on_account_update):
1241 Very slight cleanup, hoping to make it simpler to discover what causes
1242 a crash here sometimes.
1244 * src/modest-tny-account.c:
1245 (modest_tny_account_new_from_server_account): Set the port. Added
1246 comments about the options and a TODO comment because I need to find out
1247 how to specify the secure authentication method.
1249 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1251 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1252 changed CFlags paths form modest to libmodest
1254 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1256 * src/modest-account-mgr-helpers.c:
1257 (modest_account_mgr_get_server_account_data),
1258 (modest_account_mgr_free_server_account_data):
1259 * src/modest-account-mgr-helpers.h:
1260 * src/modest-account-mgr.c:
1261 (modest_account_mgr_add_server_account):
1262 * src/modest-defs.h:
1263 * src/modest-tny-account.c:
1264 (modest_tny_account_new_from_server_account):
1265 Determine the options for tny_camel_account_add_option() here,
1266 based on the settings, rather than storing them directly in gconf.
1268 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1270 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1271 Show a more friendly error dialog now that we expect (from the tinymail
1272 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1274 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1276 * src/maemo/modest-main-window.c: (on_account_update): Check that
1277 account_name is not NULL, to prevent a crash at startup that I am
1278 seeing on the N800. I do wonder why it is NULL.
1280 * src/maemo/easysetup/modest-easysetup-wizard.c:
1281 (create_page_user_details):
1282 * src/maemo/modest-account-settings-dialog.c:
1283 (create_page_user_details), (create_page_outgoing):
1284 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1285 (modest_connection_specific_smtp_edit_window_init):
1286 * src/modest-ui-actions.c:
1287 (modest_ui_actions_on_password_requested):
1288 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1289 might do something useful with the on-screen keyboard.
1291 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1293 * src/maemo/modest-main-window.c: (on_account_update):
1294 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1295 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1297 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1299 * src/modest-tny-account-store.c: (on_account_changed):
1300 Correct the signature of this signal handler.
1302 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1304 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1305 Show a HildonNote instead of a GtkDialog for Maemo.
1307 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1309 * src/widgets/modest-account-view.h:
1310 * src/widgets/modest-account-view.c: (on_account_changed),
1311 (on_account_removed). Added a boolean flag, set/unset by
1312 modest_account_view_block_conf_updates(),
1313 modest_account_view_unblock_conf_updates() to prevent unnecessary
1314 updates, but this is not very useful because the gconf notifications are
1315 so delays (maybe only on Maemo Bora).
1316 So auto-updating is turned off, and these functions do an explicit
1317 update when necessary.
1318 However, something else is still doing too much work when adding/removing
1319 accounts, probably in another part of the application.
1321 * src/maemo/modest-account-view-window.c:
1322 (on_delete_button_clicked), (on_edit_button_clicked),
1323 (on_new_button_clicked): Use the new functions.
1325 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-account-mgr-helpers.c:
1328 (modest_account_mgr_set_first_account_as_default):
1329 Sort the list of names alphabetically-by-title, so we choose the first one
1331 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1332 alphabetically by the title.
1334 This fixes projects.maemo.org bug NB#56418 .
1336 * src/modest-account-mgr-priv.c:
1337 (_modest_account_mgr_account_from_key):
1338 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1339 avoid a valgrind error, and possible random behaviour.
1341 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1343 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1344 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1345 tinymail documentation to say that this can be expected.
1346 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1347 pretty, and should not happen, but I would prefer to know when it does.
1349 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1351 * configure.ac: When using the older hildon version, probably on Bora,
1352 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1354 * src/widgets/modest-attachment-view.c:
1355 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1358 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1360 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1361 Implemented the prototype. Can be tested with
1362 tests/dbus_api/test_open_message:
1364 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1366 * src/modest-tny-account-store.c:
1367 (modest_tny_account_store_instance_init), (get_password):
1368 * src/modest-ui-actions.c:
1369 (modest_ui_actions_on_password_requested):
1370 Do not store the password in gconf, because this function is called
1371 for non-remembered passwords. Actually use the cached (in the hash map)
1372 password instead of releasing it.
1373 The password will now not be remembered if it is asked via the protected
1374 password dialog, as per the UI spec.
1376 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1378 * src/modest-defs.h:
1379 * src/modest-account-mgr-helpers.h:
1380 * src/modest-account-mgr-helpers.c:
1381 Added modest_server_account_get_username_has_succeeded(),
1382 modest_server_account_set_username_has_succeeded().
1383 (modest_server_account_set_username),
1384 Reset the has-succeeded flag if the username changes.
1386 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1387 * src/maemo/modest-connection-specific-smtp-window.c:
1388 (modest_connection_specific_smtp_window_save_server_accounts):
1389 Use modest_server_account_set_username() instead of using
1390 modest_conf_set_string() directly, so that the has-succeeded flag is always
1393 * src/modest-ui-actions.c:
1394 (modest_ui_actions_on_password_requested): Dim the username entry if
1395 the username has ever worked, as per the UI spec.
1397 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1399 * src/modest-tny-account-store.c: (get_password):
1400 * src/modest-ui-actions.c:
1401 (modest_ui_actions_on_password_requested):
1402 Allow the username to be changed too, though there is more work to
1403 be done on exactly how this behaves.
1405 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1407 * src/modest-account-mgr-helpers.h:
1408 * src/modest-account-mgr-helpers.c:
1409 Added modest_account_mgr_get_display_name(),
1410 modest_server_account_get_username(),
1411 modest_server_account_set_username(),
1412 modest_server_account_set_password(),
1413 modest_server_account_get_hostname() functions so we do not need to
1414 use the conf API directly.
1416 * src/maemo/modest-main-window.c: (connect_signals):
1417 Actually connect ot the ModestAccountStore::request-password signal,
1418 so that we show the dialog when the password is requested by Tinymail,
1419 for isntance if it is empty.
1421 * src/modest-marshal.list:
1422 * src/modest-tny-account-store.c:
1423 (modest_tny_account_store_class_init), (get_password),
1424 (modest_tny_account_store_alert):
1425 * src/modest-tny-account-store.h:
1426 * src/modest-ui-actions.h:
1427 * src/modest-ui-actions.c:
1428 (modest_ui_actions_on_password_requested):
1429 Change the signal parameters, so it is obvious that we are providing
1430 the non human-readable server name, and receiving both the username
1431 and password, though changing of the username is not yet implemented.
1432 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1433 for the GNOME version.
1435 This should fix the projects.maemo.org bug NB#56209, though it does not
1436 work on Bora, because the gconf_client_get() for the password fails
1437 immediately after we save it with gconf_client_set().
1439 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1442 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1443 caused an undefined symbol error:
1444 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1446 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-tny-account-store.c:
1449 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1450 using a GError instead of a string message, so we can translate it in
1453 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1455 * src/maemo/modest-address-book.c:
1456 (modest_address_book_check_names):
1457 * src/maemo/modest-msg-view-window.c:
1458 (modest_msg_view_window_clipboard_owner_change):
1459 * src/modest-init.c: (modest_init_init_ui):
1460 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1461 (update_folders_cb), (modest_mail_operation_update_account):
1462 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1463 (modest_ui_actions_on_msg_attachment_clicked),
1464 (modest_ui_actions_on_msg_recpt_activated):
1465 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1466 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1467 (modest_msg_view_search_next):
1468 * src/widgets/modest-recpt-editor.c:
1469 (modest_recpt_editor_on_button_release_event),
1470 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1471 g_message(). At this point we should only be seeing interesting errors on
1472 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1474 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1476 (modest_wizard_dialog_force_title_update):
1477 * src/maemo/easysetup/modest-wizard-dialog.h:
1478 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1479 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1480 can update the title when appropriate. Otherwise the title is wrong if the
1481 pages are added after adding the notebook to the dialog.
1482 This must be a problem in HildonWizardDialog too.
1483 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1485 * src/maemo/easysetup/modest-easysetup-wizard.c:
1486 (create_subsequent_customsetup_pages),
1487 (create_subsequent_easysetup_pages):
1488 Call modest_wizard_dialog_force_title_update() so that the title is
1489 correct even with GTK+ < 2.10.
1490 This fixes projects.maemo.org bug NB#56145 .
1492 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1494 * src/maemo/modest-platform.c:
1495 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1496 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1499 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1501 * src/widgets/modest-window.h:
1502 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1503 and modest_window_save_state(), which invokes it.
1505 * src/widgets/modest-window-mgr.h:
1506 * src/widgets/modest-window-mgr.c:
1507 Added modest_window_mgr_save_state_for_all_windows(), which calls
1508 the save_state vfunc on all registered windows, if implemented.
1510 * src/gnome/modest-msg-edit-window.c:
1511 * src/gnome/modest-msg-view-window.c:
1512 * src/maemo/modest-msg-edit-window.c:
1513 * src/maemo/modest-msg-view-window.c:
1514 * src/maemo/modest-main-window.c:
1515 Specify the existing save_settings functions as implementations of
1516 ModestWindow::save_state_func().
1518 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1519 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1520 enabling hibernation, for instance.
1522 We may need to do the same thing for restoring settings.
1525 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1527 * src/widgets/modest-window-mgr.c:
1528 * src/widgets/modest-window-mgr.h:
1529 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1530 modest_window_mgr_get_hibernation_is_prevented().
1532 * src/maemo/modest-main-window.c:
1533 (on_hildon_program_is_topmost_notify): Prevent hibernation
1534 (possible when the application goes to the background in the WM),
1535 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1537 * src/maemo/easysetup/modest-easysetup-wizard.c:
1538 (modest_easysetup_wizard_dialog_init):
1539 * src/maemo/modest-account-settings-dialog.c:
1540 (modest_account_settings_dialog_init):
1541 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1542 (modest_connection_specific_smtp_edit_window_init):
1543 * src/maemo/modest-connection-specific-smtp-window.c:
1544 (modest_connection_specific_smtp_window_init):
1545 * src/maemo/modest-signature-editor-dialog.c:
1546 (modest_signature_editor_dialog_init):
1547 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1548 prevent hibernation while any of these account settings dialogs are open.
1550 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/Makefile.am:
1553 * src/maemo/modest-osso-state-saving.c:
1554 * src/maemo/modest-osso-state-saving.h: Added
1555 modest_osso_load_state() and modest_osso_save_state() though they do
1556 nothing now. They should iterate through all the open windows and load/save
1558 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1559 save state when closing.
1561 * src/maemo/modest-main-window.c:
1562 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1563 Add a notification handler for the HildonProgram::is-topmost property,
1564 so we can allow hibernation when the application goes into the background.
1565 But we still need to detect when the accounts setup windows are open so
1566 we can stop hibernation when they are open.
1567 To do this, I also added the main window the HildonProgram. This might have
1568 other side-effects/benefits, and should maybe be done for other windows.
1570 * src/maemo/modest-osso-autosave-callbacks.h:
1571 * src/maemo/modest-osso-autosave-callbacks.c:
1572 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1573 though it does not do anything yet, and we might never need this to do
1574 anything. For instance, we already save drafts.
1576 * src/maemo/modest-platform.c: (modest_platform_init):
1577 Specify the libosso auto-save callback.
1579 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/modest-platform.c:
1582 (modest_platform_set_update_interval):
1583 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1584 aparently stays valid between application instances, so we can use this
1585 to remove and reset it later. According to a maemo-developers email from
1588 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1590 * configure.ac: Depend on libalarm for Maemo.
1592 * src/dbus_api/modest-dbus-api.h:
1593 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1594 (on_send_receive), (modest_dbus_req_handler):
1595 Handle a SEND_RECEIVE D-Bus method.
1597 * libmodest-dbus-client/libmodest-dbus-client.c:
1598 (libmodest_dbus_client_send_and_receive):
1599 * libmodest-dbus-client/libmodest-dbus-client.h:
1600 Add C convenience functions for calling the new D-Bus method.
1602 * src/modest-platform.h:
1603 * src/gnome/modest-platform.c:
1604 * src/maemo/modest-platform.c:
1605 Added modest_platform_set_update_interval(), which uses the
1606 alarmd API on Maemo.
1607 (modest_platform_init),
1608 Call modest_platform_set_update_interval(), using a hard-coded
1609 interval for now (until the global settings dialog is implemented),
1610 though I am not sure that this makes sense yet.
1612 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1614 * src/dbus_api/modest-dbus-callbacks.c:
1615 (modest_osso_cb_hw_state_handler):
1616 * src/dbus_api/modest-dbus-callbacks.h:
1617 * src/maemo/modest-platform.c: (modest_platform_init):
1618 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1619 in case this has some effect on the ability for Maemo to ping the
1622 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1624 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1625 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1626 warning. It is probably a logic error, but I need to fix the build.
1628 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1630 * src/modest-account-mgr.h:
1631 * src/modest-account-mgr.c:
1632 (modest_account_mgr_account_names): Add a gboolean enabled_only
1633 parameter, so we can get lists of onlt the enabled accounts.
1635 (modest_account_mgr_add_account),,
1636 (modest_account_mgr_account_with_display_name_exists):
1637 * src/maemo/modest-msg-edit-window.c: (get_transports):
1638 * src/modest-account-mgr-helpers.c:
1639 (modest_account_mgr_set_first_account_as_default):
1640 * src/modest-init.c: (init_default_account_maybe):
1641 * src/modest-tny-account-store.c: (get_accounts):
1642 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1643 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1644 * tests/check_account-mgr.c: (START_TEST):
1645 Provide the extra parameter, as appropriate.
1647 * src/widgets/modest-account-view.c: (update_account_view):
1648 Do not show disabled accounts (meaning that there is no way to
1649 enable/disable accounts in the UI (the feature is not in our UI
1650 specification), so we can use this internally only to mark unfinished
1651 or temporary account data.
1653 * src/maemo/easysetup/modest-easysetup-wizard.c:
1654 (create_account): Add boolean enable parameter, so we can specify FALSE
1655 to create the temporary account.
1656 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1657 (on_before_next): When finishing, when there is a temporary account, just
1659 Also, use a timeout to delay the showing of the dialog until gconf is likely
1660 to return correct information, due to a maemo gconf bug that is fixed in
1661 osso 1.1, but not yet in Bora.
1662 However, the dialog stays on screen after it is destroyed.
1664 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1665 for invalid data when cancelling. Use a hildon note instead of a dialog
1666 to complain about invalid data. Do not show the account-saved note if the
1667 account is disabled (a temporary account that will not really be saved for use
1670 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1672 * src/modest-account-mgr-helpers.h:
1673 * src/modest-account-mgr-helpers.c:
1674 Added modest_account_mgr_unset_default_account(),
1675 Added modest_account_mgr_set_first_account_as_default().
1677 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1678 If it was the default account, unset the default account name.
1680 * src/maemo/modest-account-view-window.c:
1681 (on_delete_button_clicked): If it was the default account,
1682 set the first remaining account as the default instead.
1684 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1685 a NULL account or a NULL default account, to prevent a crash. This should
1686 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1689 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1691 * src/widgets/modest-recpt-editor.c:
1692 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1693 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1694 TODO comment for this. This fixes the build.
1696 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1697 be the best place for it. This will in future update all auto-update accounts,
1698 rather than just the current/default account, when that gconf key exists.
1699 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1700 if there are no accounts, before calling do_send_receive().
1701 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1703 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1704 * src/maemo/modest-main-window-ui.h:
1705 * src/maemo/modest-main-window.c: (on_connection_changed),
1706 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1707 directly, becaue the signal handler does more.
1709 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1711 * src/modest-account-mgr-helpers.c:
1712 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1713 for the case that the account does not exist.
1715 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1716 (equivalent to the modest account name) rather than the tinymail account name
1717 (equivalent to the modest account title - human readable) to get the account data.
1718 Check for null account data to prevent the crash, and add a TODO comment saying that
1719 this needs fixing because it is using the server account name instead of the account name.
1721 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1723 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1724 * src/maemo/modest-account-settings-dialog.c: (show_error),
1726 Use hildon_note_new_information() for informative and error messages,
1727 which seems to be expected for Maemo applications (no documentation that I know of
1728 says this). I am surprised that there is no distinction between info and error
1731 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1733 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1734 it is easy to find where this is used.
1736 * src/maemo/easysetup/modest-easysetup-wizard.c:
1737 (create_page_welcome), (create_page_account_details),
1738 (create_page_user_details), (create_page_complete_easysetup),
1739 (create_page_custom_incoming), (create_page_custom_outgoing),
1740 (create_page_complete_custom):
1741 * src/maemo/modest-account-settings-dialog.c:
1742 (create_page_account_details), (create_page_user_details),
1743 (create_page_incoming), (create_page_outgoing):
1744 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1745 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1746 (modest_connection_specific_smtp_edit_window_init):
1747 * src/maemo/modest-connection-specific-smtp-window.c:
1748 (modest_connection_specific_smtp_window_init):
1749 * src/maemo/modest-signature-editor-dialog.c:
1750 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1751 and scrolling policy as per the Email Application Layout Guide, if I have
1754 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1756 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1757 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1758 which were empty, because these vfuncs have been removed from TnyAccountStore.
1759 This fixes the build.
1761 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1763 * src/maemo/modest-main-window.c:
1764 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1765 showing/hiding it. Added TODO because it probably should not be NULL.
1766 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1767 because unnecessary g_warnings() make degugging difficult.
1769 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1771 * src/maemo/modest-msg-edit-window.c:
1772 (modest_msg_edit_window_select_color),
1773 (modest_msg_edit_window_select_background_color): 2 const corrections and
1774 moving 2 #endifs before closing brackets, to fix the build.
1776 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1778 * src/maemo/easysetup/modest-easysetup-wizard.h:
1779 * src/maemo/easysetup/modest-easysetup-wizard.c:
1780 (modest_easysetup_wizard_dialog_finalize),
1781 (on_button_edit_advanced_settings), (create_page_complete_custom),
1782 (on_response), (create_account):
1783 Implement the Advanced Settings edit button, by saving the account information,
1784 for the Advanded Settings dialog to use directly from gconf, and removing it
1785 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1786 Bug #5533 in the projects.maemo.org bugzilla.
1788 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1790 * src/maemo/modest-msg-view-window.c:
1791 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1792 when opening a message window.
1794 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/easysetup/modest-easysetup-wizard.c:
1797 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1800 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1801 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1802 gconf settings. I probably added more checks than necessary, but that is safer.
1804 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1805 variable to fix the build, but this seems to be used when it is still NULL.
1807 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-platform.h:
1810 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1811 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1812 * src/modest-main.c: Implement this function so we can avoid using
1813 maemo-specific API from cross-platform code.
1815 * src/modest-tny-account-store.c:
1816 (get_smtp_specific_transport_account_for_open_connection):
1817 * src/modest-ui-actions.c: (check_for_connection),
1818 (modest_ui_actions_on_item_not_found):
1819 Use modest_platform_connect_and_wait() and put #idefs around other
1820 maemo-specific code, because only maemo currently has a way to
1821 identify connection names.
1823 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1825 * src/modest-tny-account-store.h:
1826 * src/modest-tny-account-store.c:
1827 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1828 the connection-specific SMTP server settings in the configuration.
1830 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1832 * src/maemo/modest-main-window.c: (on_connection_changed),
1834 * src/modest-main.c: (main), (start_ui), (send_mail):
1835 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1836 that is what is intended.
1838 * src/modest-ui-actions.c: (action_send), (action_receive),
1839 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1840 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1841 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1842 SMTP server is used when it is specified.
1844 (modest_ui_actions_on_send_receive):
1845 Check that a connection is open before proceeding.
1846 Receive and then send, instead of vice-versa, as per the specification.
1848 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1850 * src/modest-mail-operation.c:
1851 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1852 though I guess it should be something other than NULL.
1854 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/easysetup/modest-easysetup-wizard.c:
1857 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1858 combo twice, to avoid an g_warning and to make it visible again.
1859 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1860 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1861 (already intended) dereference when detaching, because we then recreate the menu.
1862 But I am not sure why the warning was happening, and it is possible that this is a memory
1865 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1867 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1868 and uri_parse_mailto() utility functions.
1869 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1871 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1873 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1875 * src/dbus_api/modest-dbus-api.h:
1876 * src/dbus_api/modest-dbus-callbacks.c:
1877 Use an idle callback to execute the modest code in the application's own thread.
1878 Remove the helloworld example method.
1879 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1880 parsed, and the open-message method is not implemented because this is not yet implemented in
1882 * libmodest-dbus-client/libmodest-dbus-client.c:
1883 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1884 (libmodest_dbus_client_open_message):
1885 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1887 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1888 body without crashing.
1890 * tests/dbus_api/Makefile.am:
1891 * tests/dbus_api/test_mail_to.c:
1892 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1894 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1896 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1897 Added file to fix the build. Sorry.
1899 * src/dbus_api/Makefile.am:
1900 * src/dbus_api/modest-dbus-api.h:
1901 * src/dbus_api/modest-dbus-callbacks.h:
1902 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1903 (modest_dbus_req_handler):
1904 Put constants in a separate header so it can be reused by the
1905 client library, without duplication
1907 * libmodest-dbus-client/Makefile.am:
1908 * libmodest-dbus-client/libmodest-dbus-client.c:
1909 (libmodest_dbus_client_call_helloworld),
1910 (libmodfest_dbus_client_send_mail),
1911 (libmodfest_dbus_client_mailto),
1912 (libmodfest_dbus_client_open_message):
1913 * libmodest-dbus-client/libmodest-dbus-client.h:
1914 (Partly) Implement a send_mail D-Bus method.
1916 * tests/dbus_api/Makefile.am:
1917 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1918 the send_email D-Bus method.
1920 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1924 * libmodest-dbus-client/Makefile.am:
1925 * libmodest-dbus-client/libmodest-dbus-client.c:
1926 * libmodest-dbus-client/libmodest-dbus-client.h:
1927 * tests/dbus_api/Makefile.am:
1928 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1929 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1931 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1933 * src/maemo/easysetup/modest-easysetup-wizard.c:
1934 (create_page_account_details):
1935 * src/maemo/modest-account-settings-dialog.c:
1936 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1937 widgets, because this might not be the default in future versions of the Maemo GTK+.
1938 However, I can not not get capitalization to work even in a simple test case.
1940 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1942 * src/maemo/easysetup/modest-easysetup-wizard.c:
1943 (create_page_custom_incoming), (create_page_custom_outgoing):
1944 * src/maemo/modest-account-settings-dialog.c:
1945 (create_page_account_details), (create_page_incoming),
1946 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1947 instead of using gtk_check_button_with_label(), so they are aligned like the other
1948 widgets, as per the UI spec.
1950 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1952 * src/maemo/easysetup/modest-easysetup-wizard.c:
1953 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1954 * src/widgets/modest-validating-entry.c:
1955 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1956 Modest prefix instead of an EasySetup prefix.
1958 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1960 * src/widgets/modest-validating-entry.h:
1961 * src/widgets/modest-validating-entry.c: (on_insert_text),
1962 Added easysetup_validating_entry_set_max_func(), used to set a callback
1963 to call when the max number of characters is reached. GtkEntry has a max-length
1964 already but is silent about it.
1966 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1967 (create_page_account_details), (create_page_user_details),
1969 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1970 (create_page_account_details), (create_page_user_details),
1971 (create_page_outgoing):
1972 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1973 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1974 the UI spec, when the user tries to enter more than the max number of characters.
1976 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/easysetup/modest-easysetup-wizard.c:
1979 (create_page_user_details), (create_page_custom_incoming),
1980 (create_page_custom_outgoing):
1981 * src/maemo/modest-account-settings-dialog.c:
1982 (create_page_user_details), (create_page_incoming),
1983 (create_page_outgoing):
1984 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1985 (modest_connection_specific_smtp_edit_window_init):
1986 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1987 not appropriate. Bad Maemo-specific defaults!.
1989 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1992 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1993 (modest_signature_editor_dialog_set_settings):
1994 Disable the label and textview when the checkbox is disabled, and use the
1995 specified (UI spec) default signature text.
1997 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1999 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2000 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2002 * src/modest-defs.h:
2003 * src/modest-account-mgr-helpers.h:
2004 * src/modest-account-mgr-helpers.c:
2005 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2007 * src/maemo/Makefile.am:
2008 * src/maemo/modest-signature-editor-dialog.c:
2009 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2012 * src/maemo/modest-account-settings-dialog.h:
2013 * src/maemo/modest-account-settings-dialog.c:
2014 (modest_account_settings_dialog_finalize), (on_button_signature),
2015 (save_configuration): Use the new dialog when the Edit button is pressed, and
2016 save the changes if necessary, as per the UI spec.
2018 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2020 * src/maemo/Makefile.am:
2021 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2022 based on maemo-develoers email from Dirk.
2024 * src/maemo/easysetup/modest-easysetup-wizard.c:
2025 (create_page_welcome), (create_page_account_details),
2026 (create_page_user_details), (create_page_complete_easysetup),
2027 (create_page_custom_incoming), (create_page_custom_outgoing),
2028 (create_page_complete_custom),
2029 (modest_easysetup_wizard_dialog_init):
2030 * src/maemo/modest-account-settings-dialog.c:
2031 (create_page_account_details), (create_page_user_details),
2032 (create_page_incoming), (create_page_outgoing),
2033 (modest_account_settings_dialog_init):
2034 * src/maemo/modest-connection-specific-smtp-window.c:
2035 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2037 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2039 * src/maemo/easysetup/modest-easysetup-wizard.c:
2040 (create_page_account_details), (create_page_custom_outgoing),
2041 (create_page_complete_custom):
2042 * src/maemo/modest-account-settings-dialog.c:
2043 (create_page_user_details), (create_page_incoming),
2044 (create_page_outgoing):
2045 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2046 (modest_connection_specific_smtp_edit_window_init):
2047 Use the correct (UI spec) port min/max, and use horizontal separators,
2050 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2052 * src/maemo/easysetup/modest-easysetup-wizard.c:
2053 (set_default_custom_servernames):
2054 * src/maemo/modest-account-settings-dialog.c:
2055 (create_page_incoming), (on_combo_outgoing_security_changed),
2056 (on_combo_incoming_security_changed), (create_page_outgoing),
2057 (modest_account_settings_dialog_set_account_name),
2058 (save_configuration):
2059 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2060 (on_combo_security_changed),
2061 (modest_connection_specific_smtp_edit_window_init),
2062 (modest_connection_specific_smtp_edit_window_set_connection),
2063 (modest_connection_specific_smtp_edit_window_get_settings):
2064 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2067 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2070 * src/maemo/easysetup/modest-easysetup-wizard.c:
2071 (create_page_custom_outgoing), (create_page_complete_custom):
2072 * src/maemo/modest-account-settings-dialog.c:
2073 (create_page_user_details), (create_page_outgoing):
2074 * src/maemo/modest-account-view-window.c: (button_box_new):
2075 Use changed logical IDs as per the most recent UI spec:
2076 mcen_bd_emailsetup_edit -> mcen_bd_edit
2077 mcen_bd_emailsetup_delete -> mcen_bd_delete
2078 mcen_bd_emailsetup_close -> mcen_bd_close
2080 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2084 * src/dbus_api/Makefile.am:
2085 * src/dbus_api/modest-dbus-callbacks.c:
2086 * src/dbus_api/modest-dbus-callbacks.h:
2087 * src/maemo/modest-platform.c: (modest_platform_init):
2088 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2090 * tests/Makefile.am:
2091 * tests/dbus_api/Makefile.am:
2092 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2094 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/modest-account-settings-dialog.c:
2097 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2098 Removed unnecessary includes.
2100 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2102 * src/maemo/easysetup/modest-easysetup-wizard.c:
2103 * src/maemo/modest-account-settings-dialog.c:
2104 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2105 * src/widgets/Makefile.am:
2106 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2107 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2108 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2109 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2110 * src/widgets/modest-secureauth-combo-box.c:
2111 * src/widgets/modest-secureauth-combo-box.h:
2112 * src/widgets/modest-serversecurity-combo-box.c:
2113 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2114 made the GObject names more consistent with the rest of the Modest code.
2116 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2118 * src/maemo/easysetup/Makefile.am:
2119 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2120 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2121 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2122 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2123 * src/maemo/easysetup/modest-easysetup-wizard.c:
2124 * src/maemo/easysetup/modest-validating-entry.c:
2125 * src/maemo/easysetup/modest-validating-entry.h:
2126 * src/maemo/modest-account-settings-dialog.c:
2127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2128 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2129 widgets/ because they are used outside of easysetup too. After checking in,
2130 svn will allow me to rename them too.
2132 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2134 * src/gnome/modest-msg-edit-window.c:
2135 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2136 linker error, to fix the build on the GNOME platform.
2137 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2138 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2139 ifdefed out to avoid a warning.
2141 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2143 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2144 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2145 some alternative for GTK+ 2.6.
2147 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2149 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2151 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2152 specified for EmailAccountsDialog in UI spec.
2154 * src/maemo/easysetup/modest-easysetup-wizard.c:
2155 * src/maemo/easysetup/modest-easysetup-wizard.h:
2156 * src/maemo/modest-account-settings-dialog.c:
2157 * src/maemo/modest-account-settings-dialog.h:
2158 Reuse a member window widget for the connection-specific SMTP server accounts,
2159 so we can tell it to create/save the accounts only if we actually save changes.
2161 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2163 (modest_connection_specific_smtp_edit_window_get_settings):
2164 Return a struct instance for temporarily remembering the entered data.
2166 * src/maemo/modest-connection-specific-smtp-window.h:
2167 * src/maemo/modest-connection-specific-smtp-window.c:
2168 (modest_connection_specific_smtp_window_finalize),
2169 (modest_connection_specific_smtp_window_fill_with_connections),
2171 (modest_connection_specific_smtp_window_save_server_accounts),
2172 (update_model_server_names): Do not actually save data until asked,
2173 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2175 (on_selection_changed),
2176 (modest_connection_specific_smtp_window_init): Disable the edit
2177 button when nothing is selected.
2179 * src/modest-account-mgr-helpers.c:
2180 * src/modest-account-mgr-helpers.h:
2181 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2184 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-account-mgr-helpers.h:
2187 * src/modest-account-mgr-helpers.c:
2188 (modest_account_mgr_get_unused_account_name),
2189 (modest_account_mgr_get_unused_account_display_name): Added these
2190 utility functions, to avoid code duplication.
2192 * src/maemo/easysetup/modest-easysetup-wizard.c:
2193 (create_page_account_details), (create_account):
2194 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2195 (on_combo_security_changed),
2196 (modest_connection_specific_smtp_edit_window_init),
2197 (modest_connection_specific_smtp_edit_window_save_settings):
2198 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2199 * src/maemo/modest-connection-specific-smtp-window.c:
2200 (modest_connection_specific_smtp_window_finalize),
2201 (modest_connection_specific_smtp_window_fill_with_connections),
2202 (on_button_edit), (modest_connection_specific_smtp_window_init):
2203 * src/maemo/modest-connection-specific-smtp-window.h:
2204 Implementing saving of connection-specific server accounts.
2206 But I need to refactor this so we can save the data for each
2207 possible connection-specific account and only actually create the server accounts
2208 when the easysetup finished, or the OK button is pressed on the account settings
2211 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2213 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2214 (on_combo_security_changed):
2215 (modest_connection_specific_smtp_edit_window_init):
2216 Auto-fill the port number as in the account settings.
2218 (modest_connection_specific_smtp_edit_window_set_connection):
2219 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2220 * src/maemo/modest-connection-specific-smtp-window.c:
2221 (fill_with_connections), (on_button_edit),
2222 (modest_connection_specific_smtp_window_init):
2223 Turn the edit window into a dialog to simplify the code, and
2224 set a WM hint as in a GtkDialog, because only a popup can be on top of
2225 another window in Maemo, and popups usually have no WM decoration.
2227 * src/modest-defs.h:
2228 * src/modest-account-mgr-helpers.c:
2229 (modest_account_mgr_set_connection_specific_smtp),
2230 (modest_account_mgr_remove_connection_specific_smtp),
2231 (modest_account_mgr_get_connection_specific_smtp):
2232 * src/modest-account-mgr-helpers.h: Some functions to write the
2233 connection-specific SMTP server information. Not yet used.
2236 * src/widgets/modest-folder-view.c: (text_cell_data):
2237 Fix a warning about an uninitialized variable.
2238 (on_configuration_key_changed): Put an #ifdef around the use
2239 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2241 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/modest-account-settings-dialog.h:
2244 * src/maemo/modest-account-settings-dialog.c:
2245 Added connect_for_modified() utility function to mark the new modified boolean.
2247 (create_page_account_details), (create_page_user_details),
2248 (create_page_incoming), (create_page_outgoing), (on_response),
2249 (modest_account_settings_dialog_init),
2250 (modest_account_settings_dialog_set_account_name):
2251 Only warn about unsaved changes when there are actually unsaved changes.
2253 * src/modest-account-mgr-helpers.c:
2254 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2255 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2256 to get the data from there in future.
2258 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2260 * src/modest-defs.h:
2262 * src/modest-account-mgr-helpers.h:
2263 * src/modest-account-mgr-helpers.c:
2264 Store the security account setting in a single conf key instead of using
2265 the options list, so that the list is left for just the to-be-removed camel hack,
2266 and because gconf_client_set_list() is failing for some reason.
2268 * src/modest-account-mgr.c:
2269 (modest_account_mgr_add_server_account):
2270 * src/maemo/modest-account-settings-dialog.c:
2271 (modest_account_settings_dialog_set_account_name),
2272 (save_configuration): Use the renamed functions.
2275 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2277 * src/widgets/Makefile.am:
2278 * src/widgets/modest-limit-retrieve-combo-box.c:
2279 * src/widgets/modest-limit-retrieve-combo-box.h:
2280 * src/widgets/modest-retrieve-combo-box.c:
2281 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2282 the account settings dialog.
2284 * src/modest-defs.h:
2285 * src/modest-account-mgr-helpers.h:
2286 * src/modest-account-mgr-helpers.c:
2287 (modest_server_account_get_option_secure_auth),
2288 (modest_server_account_set_option_secure_auth):
2289 * src/modest-account-mgr.c:
2290 (modest_account_mgr_add_server_account):
2291 Use the existing AUTH_MECH conf key for the secure-auth setting,
2292 instead of putting it in the list options, because this was actually used already.
2294 * src/maemo/modest-account-settings-dialog.c:
2295 (create_page_account_details),
2296 (modest_account_settings_dialog_set_account_name),
2297 (save_configuration):
2298 * src/maemo/modest-account-settings-dialog.h:
2299 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2300 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2302 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2304 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2305 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2306 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2308 * src/modest-defs.h:
2309 * src/maemo/modest-account-settings-dialog.c:
2310 (create_page_incoming), (on_combo_outgoing_security_changed),
2311 (on_combo_incoming_security_changed), (create_page_outgoing),
2312 (modest_account_settings_dialog_set_account_name),
2313 (save_configuration): Load/Save the port number, and change it when the
2314 security combo changes, to suitable defaults.
2316 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2318 * src/modest-account-mgr.c:
2319 (modest_account_mgr_add_server_account): Set the security and secure-auth
2320 options, and add a comment saying that the other camel-specific options should be
2323 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2327 * src/modest-tny-account-store.c: (account_list_free),
2328 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2329 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2332 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2334 * src/modest-protocol-info.c:
2335 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2336 is required by our UI spec. Maybe something in our implementation will use this eventually.
2337 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2338 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2339 instead of the previous 0 placeholder.
2341 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2342 secure-auth settings.
2343 * src/modest-account-mgr-helpers.h:
2344 * src/modest-account-mgr-helpers.c:
2345 (modest_server_account_data_get_option_secure_auth),
2346 (modest_server_account_set_option_secure_auth),
2347 (modest_server_account_data_get_option_security),
2348 (modest_server_account_set_option_security): Added this API for getting and setting the security
2349 and secure-auth settings.
2351 * src/maemo/modest-account-settings-dialog.h:
2352 * src/maemo/modest-account-settings-dialog.c:
2353 (modest_account_settings_dialog_finalize), (check_data),
2354 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2355 about changing titles.
2356 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2357 (save_configuration): Save the security and secure-auth settings.
2359 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2360 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2362 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2364 * src/modest-defs.h:
2365 * src/modest-account-mgr.c:
2366 (modest_account_mgr_add_server_account):
2367 Added and used defines for the options key and value pair strings,
2368 that are used so far, though they do not seem to correspond to anything in our
2369 UI specs or ModestProtocol enum.
2371 * src/modest-account-mgr-helpers.h:
2372 * src/modest-account-mgr-helpers.c:
2373 (compare_option_strings_for_name),
2374 (modest_server_account_data_get_option_value),
2375 (modest_server_account_data_get_option_bool),
2376 (modest_account_mgr_get_server_account_option):
2377 Added helper functions for parsing the options GSList.
2379 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2381 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2382 display name is based on the supplied account name.
2383 * src/modest-account-mgr.c:
2384 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2385 with an inefficient, but good-enough, implementation.
2387 * src/maemo/easysetup/modest-easysetup-wizard.c:
2388 (create_page_account_details), (on_before_next), (create_account):
2389 Check for existing display names rather than (non-user-visible) account names, and just
2390 create and set a unique account name at the end.
2392 * src/maemo/modest-account-settings-dialog.c:
2393 (modest_account_settings_dialog_init),
2394 (modest_account_settings_dialog_set_account_name),
2395 (create_page_incoming): Show the display name, instead of the account name.
2396 (on_response): Do some (not all) extra checks, as in the UI spec.
2397 (save_configuration): Save the display name if it was changed.
2399 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2401 * po/en_GB.po: Added needed logical ID and translation.
2402 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2403 (init_view): Made the is-default column clicking work.
2405 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2408 * src/maemo/easysetup/Makefile.am:
2409 * src/maemo/easysetup/modest-easysetup-wizard.c:
2410 (modest_easysetup_wizard_dialog_init):
2411 * src/maemo/easysetup/provider-data-test.keyfile:
2412 * src/maemo/easysetup/provider-data.keyfile:
2413 Moved the provider data file to the new modest-providers-data package and used it from there.
2415 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2417 * src/modest-local-folder-info.c:
2418 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2419 N_() was already used on the static strings, but this just marks it for translation without
2420 using the translation.
2422 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/modest-account-settings-dialog.c:
2425 (create_page_incoming),
2426 (modest_account_settings_dialog_set_account_name):
2427 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2428 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2429 I will do this if nobody else gets there first.
2431 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2433 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2434 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2435 save the security stuff.
2437 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2440 Set the email address and user fullname, which I now see must be
2443 * src/maemo/modest-account-settings-dialog.h:
2444 * src/maemo/modest-account-settings-dialog.c:
2446 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2447 leave-on-server and authentication.
2448 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2451 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2454 * src/maemo/modest-account-settings-dialog.c:
2455 * src/maemo/modest-account-settings-dialog.h:
2456 Most (but not all) of the widgets are now present as specified by the UI spec.
2457 No changes are yet saved, and some details are not properly shown yet.
2459 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2461 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2463 * src/maemo/Makefile.am:
2464 * src/maemo/modest-account-settings-dialog.c:
2465 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2466 an existing account. Doesn't do much yet.
2468 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2469 Open the accounts settings dialog when Edit is clicked.
2471 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2473 * src/maemo/easysetup/Makefile.am:
2474 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2476 * src/maemo/easysetup/modest-easysetup-wizard.c:
2477 (modest_easysetup_wizard_dialog_init):
2478 Try to get the source directory from the build system,
2479 instead of hard-coding "./" into the source code, when opening our local
2480 copies of the configuration files.
2481 But this still fails when opening the wizard from the Accounts window,
2482 maybe because the working directory seems to change at runtime.
2483 So the wizard will fail the second time unless you copy the files into their
2484 proper locations - see the stdout warnings for the paths.
2486 (create_page_account_details),(on_before_next):
2487 Check for existing non-server accounts instead of server accounts,
2488 so the default account name is useful again, and to prevent trying to
2491 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2492 Show the wizard when New is clicked.
2494 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2495 (init_view): Show the column headers, and show the columns that are
2496 specified in the UI specs. However, something in Maemo's GTK+ prevents
2497 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2498 change the default account. This is despite unsetting the special properties.
2500 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2502 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2503 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2504 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2505 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2506 to make that clearer.
2507 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2509 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/modest-account-view-window.c:
2512 (modest_account_view_window_init),
2513 (modest_account_view_window_new):
2514 Use the same buttons as specified in the
2515 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2516 the existing widgets, which never had a chance of working.
2517 Put the ModestAccountView treeview in a scrolled window.
2518 Do not repeat the initialization in both _init() and _new().
2520 * src/widgets/modest-account-view.c: (update_account_view):
2521 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2522 this widget and window shows no accounts.
2524 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2526 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/easysetup/modest-easysetup-wizard.c:
2529 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2530 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2531 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2534 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2535 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2536 accounts exist yet, as in the UI spec.
2538 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2540 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2542 * src/maemo/Makefile.am:
2543 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2544 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2545 New window for editing connection-specific smtp details.
2546 Not fully implemented.
2548 * src/maemo/modest-connection-specific-smtp-window.c:
2549 (modest_connection_specific_smtp_window_finalize) :
2550 unref the tree model.
2551 (on_button_edit): Show the edit window.
2553 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2555 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2558 * src/maemo/Makefile.am:
2559 * src/maemo/modest-connection-specific-smtp-window.c:
2560 * src/maemo/modest-connection-specific-smtp-window.h:
2561 New window for showing the list of connections, for connection-specific
2562 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2563 * src/maemo/easysetup/modest-easysetup-wizard.c:
2564 (create_page_custom_outgoing): Show the new window when the button is clicked.
2566 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2568 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2569 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2570 * src/maemo/modest-msg-edit-window.c:
2571 (modest_msg_edit_window_insert_image):
2572 * src/modest-conf.c: (modest_conf_key_escape):
2573 * src/modest-mail-operation.c:
2574 (modest_mail_operation_send_new_mail):
2575 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2576 (modest_ui_actions_on_new_account):
2577 * src/widgets/modest-attachment-view.c: (update_filename_request):
2578 * src/widgets/modest-mail-header-view.c:
2579 Corrected warnings that were breaking the build, by commenting out unused variables,
2580 and a function, and by including a header.
2582 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2584 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2585 so we can #ifdef around platform-specific code when necessary.
2586 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2587 to allow this to build for the GNOME platform too.
2589 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/easysetup/modest-easysetup-wizard.c:
2592 Added util_increment_name() and used it in create_page_account_details()
2593 to make sure that the default account name is always a new name.
2595 (modest_easysetup_wizard_dialog_init),
2596 (set_default_custom_servernames): Some minor memory management fixes.
2598 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-runtime.c: (init_i18n): Restored the translation
2603 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2604 are defined in config.h, and the translations are installed.
2606 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2607 is defined for translation.
2609 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2611 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2613 * src/maemo/easysetup/modest-easysetup-wizard.c:
2614 (modest_easysetup_wizard_dialog_init):
2615 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2616 Use realistic paths (though they should use $prefix generically) to the
2617 mcc_mapping and provider-data.keyfile files which might work when they
2618 are installed by the future version of the operator-wizard package,
2619 and then fallback to paths in our source code, with an explanatory
2622 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2626 * src/maemo/Makefile.am:
2627 * src/maemo/easysetup/: Added files from the previously-exernal
2628 osso-modest-easysetup.
2629 * src/maemo/modest-main-window-ui.h:
2630 * src/modest-ui-actions.c:
2631 * src/modest-ui-actions.h:
2632 Added modest_ui_actions_on_new_account() as a signal handler for the
2633 New Account menu item. It shows the easysetup wizard.
2634 * po/en_GB.po: Added additional needed logical IDs and translations.
2636 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2637 Apparently ChangeLog is not used for some vague Nokia legal reasons.