1 2007-06-07 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_server_accounts):
4 Create the local folders account only once, not once for each outbox, and
5 not only when there are some outboxes.
7 2007-06-07 Murray Cumming <murrayc@murrayc.com>
9 * src/widgets/modest-folder-view.c: (update_model): Comment out some
10 code that is causing a crash at startup. Sergio says that he is fixing this.
12 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
14 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
15 * src/maemo/modest-account-settings-dialog.c:
16 (create_page_outgoing),
17 (modest_account_settings_dialog_set_account_name),
19 - Fixed handling of the "Use secure authentication" toggle to comply with
20 the ui specification. See also projects.maemo.org bug NB#58400
22 - Restore the Secure connection setting combo correctly when loading
25 * src/maemo/modest-maemo-utils.c:
26 (on_camel_account_get_supported_secure_authentication),
27 (modest_maemo_utils_get_supported_secure_authentication_methods):
28 Fixed a crasher if operation is canceled
30 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
31 (modest_protocol_info_auth_is_secure):
32 * src/modest-protocol-info.h:
34 Added two new methods to determine if a protocol/auth method is secure/encrypted in
35 the sense of the "Use secure authentication" toggle.
37 2007-06-07 Murray Cumming <murrayc@murrayc.com>
39 * src/modest-tny-account-store.h:
40 * src/modest-tny-account-store.c:
41 Added modest_tny_account_store_get_local_folders_account().
43 * src/modest-tny-folder.h:
44 * src/modest-tny-folder.c:
45 (modest_tny_folder_get_account):
46 Added this replacement for tny_folder_get_account() which returns
47 the local-folders account for TnyMergeFolders, to avoid the
48 warning about the unimplemented get_account_func() vfunc().
50 (modest_tny_folder_get_rules),
51 * src/modest-ui-actions.c:
52 (modest_ui_actions_on_folder_selection_changed):
53 * src/modest-mail-operation.c:
54 (modest_mail_operation_remove_folder),
55 (modest_mail_operation_xfer_folder),
56 (modest_mail_operation_rename_folder),
57 (modest_mail_operation_get_msg),
58 (modest_mail_operation_get_msgs_full),
59 (modest_mail_operation_remove_msg),
60 (modest_mail_operation_xfer_msgs),
61 (modest_mail_operation_refresh_folder):
62 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
64 2007-06-07 Murray Cumming <murrayc@murrayc.com>
66 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
67 (modest_server_account_set_security):
68 * src/modest-defs.h: Add comments explaining that our
69 UI spec means TLS when it says Normal, so these do not look like errors.
71 * src/modest-tny-account.c:
72 (modest_tny_account_new_from_server_account): Use the new tinymail
73 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
74 for TLS. This should fix projects.maemo.org bug NB#58460.
76 2007-06-06 Murray Cumming <murrayc@murrayc.com>
78 * src/maemo/easysetup/modest-easysetup-wizard.c:
79 (create_account): Correct the position of the gconf sanity check warning.
80 (on_button_edit_advanced_settings): Show the dialog immediately, instead
81 of using the g_idle_add() hack, because this does not seem to be necessary
82 on osso 1.1. It might even work on Maemo Bora if the problems were actually
83 caused by something other than maemo's gconf.
84 This fixes projects.maemo.org bug #59022.
86 2007-06-06 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-account-mgr-helpers.c:
89 (modest_account_mgr_get_default_account): Do not check that the account
90 exists if there is no default account (NULL), to fix a runtime warning.
92 2007-06-06 Murray Cumming <murrayc@murrayc.com>
94 * src/widgets/modest-folder-view.c: (update_model):
95 Do not unref the treemodel before we have finished with it.
96 This prevents a valgrind warning and an occasional crash at startup.
98 2007-06-06 Marcus Bauer <marcusb@openismus.com>
100 * libmodest-dbus-client/libmodest-dbus-client.h:
101 added libmodest_dbus_client_compose_mail()
102 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
104 added functions needed for SendAsMail() functionality
105 * src/maemo/modest-msg-edit-window.c:
106 (modest_msg_edit_window_attach_file_noninteractive):
107 non interactively attaching files to message edit window
108 * src/widgets/modest-msg-edit-window.h:
109 * tests/dbus_api/Makefile.am:
110 added test_compose_mail.c
111 * tests/dbus_api/test_compose_mail.c: (main):
113 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
115 * src/modest-account-view.c:
116 Fixed bug projects.maemo.org bug NB#59307
118 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
120 * src/maemo/easysetup/modest-easysetup-wizard.c:
121 (get_serverport_incoming), (on_before_next), (create_account):
122 * src/maemo/modest-account-settings-dialog.c:
123 (modest_account_settings_dialog_set_account_name):
124 * src/maemo/modest-maemo-utils.c:
125 (on_camel_account_get_supported_secure_authentication_status),
126 (on_camel_account_get_supported_secure_authentication),
127 (on_secure_auth_cancel),
128 (modest_maemo_utils_get_supported_secure_authentication_methods):
130 Implemented security authentication for settings and easysetup.
132 2007-06-05 Murray Cumming <murrayc@murrayc.com>
134 * src/maemo/modest-main-window.c: (create_details_widget):
135 Show the total size for memory card accounts too, instead of showing
136 the name again. Fixes bug projects.maemo.org bug NB#59307.
138 2007-06-05 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-tny-simple-folder-store.c:
142 * src/modest-tny-simple-folder-store.h: Removed.
144 * src/modest-tny-local-folders-account.h
145 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
146 for the local-folders maildir, with an extra TnyMergedFolder containing
147 the folders of the per-account outbox store accounts.
148 * src/modest-tny-account-store.c: (get_server_accounts):
149 Add the outboxes to the special local folders account after creating it.
151 * src/modest-tny-account.c:
152 (modest_tny_account_new_for_local_folders): Create the derived
153 account when creating the main local-folders account.
155 * src/maemo/modest-main-window.c: (create_details_widget),
156 (modest_main_window_set_contents_style):
157 Adapted to the use of the derived account instead of the folder store.
159 * src/modest-ui-actions.c:
160 (modest_ui_actions_on_folder_selection_changed):
161 * src/modest-ui-dimming-rules.c:
162 (modest_ui_dimming_rules_on_new_folder):
163 * src/widgets/modest-folder-view.c: (text_cell_data),
164 (icon_cell_data), (filter_row), (update_model),
165 (get_cmp_rows_type_pos):
168 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
169 Do not get the priv struct, because no priv struct has been set,
170 to avoid a runtime warning.
172 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
173 #ifelse with #else, to fix a warning, to fix the build.
176 2007-06-05 Christian Kellner <ckellner@openismus.com>
178 * libmodest-dbus-client/libmodest-dbus-client.c:
179 Fix small typo in doc (why do you always see them
180 AFTER committing stuff?)
183 2007-06-05 Christian Kellner <ckellner@openismus.com>
185 * libmodest-dbus-client/libmodest-dbus-client.c:
186 (libmodest_dbus_client_search):
187 Initialize hit list with NULL. Also set folder list
188 to "" if NULL was supplied.
191 2007-06-03 Christian Kellner <ckellner@openismus.com>
193 * libmodest-dbus-client/libmodest-dbus-client.c:
194 (modest_search_hit_list_free):
195 Make it save to call it with NULL.
197 * src/dbus_api/modest-dbus-callbacks.c:
198 * src/modest-search.c:
199 Return full ModestSearchHits as the search result list not TnyHeader
200 since can't be around withouth the correspoding TnyFolder.
202 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
204 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
205 Added currently commented code to check for secure auth
207 * src/maemo/modest-account-settings-dialog.c: (on_response),
208 (save_configuration), (show_ok):
209 Fixed projects.maemo.org bugs NB #59248 and #59251
211 * src/maemo/modest-maemo-utils.c:
212 (on_camel_account_get_supported_secure_authentication_status),
213 (on_camel_account_get_supported_secure_authentication),
214 (modest_maemo_utils_get_supported_secure_authentication_methods):
215 * src/maemo/modest-maemo-utils.h:
216 Moved get_supported_secure_authentication() method here to be able
217 to use it from easysetup wizard.
219 * src/modest-pair.c: (on_pair_compare_as_string):
220 Should compare string with first part of pair and not
221 strcmp pairs which will crash.
223 * src/modest-protocol-info.c:
224 (modest_protocol_info_protocol_is_store):
225 * src/modest-protocol-info.h:
226 Added modest_protocol_info_get_auth_protocol_name()
228 2007-06-03 Armin Burgmeier <armin@openismus.com>
230 * src/modest-mail-operation.c:
231 (modest_mail_operation_get_msgs_full): Set priv->account also when
232 only retrieving a single message. This avoids a crash when canceling
235 (modest_mail_operation_notify_end): Do not explicitely remove the
236 operation from the queue but only emit the progress_changed signal.
237 The queue itself listens to that signal to remove the operation when
238 it is finished. This reduces coupling and removes a potential deadlock
239 when modest_mail_operation_notify_end() is called from the queue
240 itself. If that is a problem performance-wise, I would suggest to
241 implement a status-changed signal or something.
243 * src/modest-mail-operation-queue.c: Make sure to never call a
244 function from another file while the queue is locked. This (hopefully)
245 fixes another deadlock when exiting the application while retrieving
248 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
250 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
251 Fixed build if libogs is not available
253 2007-06-03 Christian Kellner <ckellner@openismus.com>
255 * libmodest-dbus-client/libmodest-dbus-client.h:
256 * libmodest-dbus-client/libmodest-dbus-client.c:
257 (libmodest_dbus_client_delete_message):
258 Implement deletion of messages (Client side).
260 (modest_search_hit_free),
261 (modest_search_hit_list_free):
262 Utility functions to free the result hits.
264 * src/dbus_api/modest-dbus-api.h:
265 * src/dbus_api/modest-dbus-callbacks.c:
267 (modest_dbus_req_handler):
268 Implement deletion of messages (Server side).
270 * tests/dbus_api/test_search.c: (main):
273 * tests/dbus_api/Makefile.am:
274 * tests/dbus_api/test_delete_message:
275 Add little test for the message deletion logic
277 2007-06-03 Armin Burgmeier <armin@openismus.com>
279 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
280 when the operation queue was not empty. projects.maemo.org bug
283 2007-06-03 Armin Burgmeier <armin@openismus.com>
285 * src/widgets/modest-account-view.c
286 (on_account_default_toggled): Toggle default account column
287 explicitely instead of waiting for gconf notification (which is
288 currently ignored). This should fix projects.maemo.org bug NB#56910
289 for now. It should probably be removed when gconf notifications are
292 2007-06-03 Christian Kellner <ckellner@openismus.com>
294 * libmodest-dbus-client/libmodest-dbus-client.c:
295 Removed debugging spew.
297 * src/dbus_api/modest-dbus-callbacks.c:
298 Added debugging info.
300 * src/modest-search.c:
301 (modest_search_all_accounts):
302 Use tny_account_store_get_accounts () on the account store
303 to get all accounts which is the way to get all accounts.
305 * tests/dbus_api/test_search.c: (main):
306 Make it possible to supply the search term on the command line.
308 2007-06-03 Christian Kellner <ckellner@openismus.com>
310 * libmodest-dbus-client/libmodest-dbus-client.c:
311 * libmodest-dbus-client/libmodest-dbus-client.h:
312 Implement searching for mesages over raw dbus. (Client side)
314 * src/dbus_api/Makefile.am:
315 * src/dbus_api/modest-dbus-api.h:
316 * src/dbus_api/modest-dbus-callbacks.c:
317 * src/dbus_api/modest-dbus-callbacks.h:
318 Search framework (Server side). Also implement on_idle_open_message().
320 * src/maemo/modest-platform.c: (modest_platform_init):
321 Prepare for raw dbus/osso rpc interaction.
323 * src/modest-search.h:
324 Changed minsize from unspecific guint to guint32.
326 * src/modest-search.c:
328 Added strange hack which magically made tnymail work.
330 (modest_search_folder),
331 (modest_search_account),
332 (modest_search_all_accounts):
333 Implement helper functions to search all accounts, specific account
336 * tests/dbus_api/Makefile.am:
337 * tests/dbus_api/test_open_message.c:
338 Read url to open from commandline.
340 * tests/dbus_api/test_search.c:
341 Implement small test for dbus search stuff
343 2007-06-02 Armin Burgmeier <armin@openismus.com>
345 * src/maemo/modest-account-settings-dialog.c: Changed window title to
346 include account type and account title. This fixes projects.maemo.org
349 * src/maemo/modest-account-view-window.c: Set a title for the window.
351 2007-06-02 Armin Burgmeier <armin@openismus.com>
353 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
354 incoming and outgoing server name based on email address and server
355 types as long as the names have not been edited manually. This fixes
356 projects.maemo.org bug NB#58671.
358 2007-06-02 Armin Burgmeier <armin@openismus.com>
360 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
361 server type cannot be changed in future to the incoming details page
362 when creating an account. This fixes projects.maemo.org bug NB#59029.
364 2007-06-02 Armin Burgmeier <armin@openismus.com>
366 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
367 and assigned max width chars so that they wrap instead of being
368 truncated. Fixes projects.maemo.org bug NB#56126.
370 2007-06-02 Armin Burgmeier <armin@openismus.com>
372 * src/maemo/modest-connection-specific-smtp-window.c: Add an
373 introductory note to the connection specific smtp servers dialog, as
374 section 8.12 of the email UI specification requires. This fixes
375 projects.maemo.org bug NB#59212.
377 2007-06-01 Murray Cumming <murrayc@murrayc.com>
379 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
380 Check for running mail operations, and offer to cancel them, as per the UI
381 spec. This fixes projects.maemo.org bug NB#59041 .
382 However, I suspect that tinymail may still use the network connection
383 in ways that we cannot detect or cancel. But it should at least adapt to
386 2007-06-01 Murray Cumming <murrayc@murrayc.com>
388 * src/modest-tny-account-store.c: (recreate_all_accounts),
389 (get_cached_accounts), (get_server_accounts): Do more sensible
390 ref-counting of the temporarily-cached outbox accounts list. This seems
391 to fix a crash when entering the password when the password was wrong.
393 2007-06-01 Murray Cumming <murrayc@murrayc.com>
395 * src/gnome/modest-main-window.c: (connect_signals):
396 * src/modest-tny-account-store.c: (get_password),
397 (modest_tny_account_store_alert): Added comments and clues and
398 commented-out code about how we currently fail to deal with connection
399 errors and wrong passwords, and how we should.
401 2007-06-01 Murray Cumming <murrayc@murrayc.com>
403 * src/widgets/modest-retrieve-combo-box.c:
404 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
405 This fixes projects.maemo.org bug NB#58472 .
407 2007-06-01 Murray Cumming <murrayc@murrayc.com>
409 * src/maemo/easysetup/modest-easysetup-wizard.c:
410 (create_page_complete_easysetup):
411 (create_page_complete_custom): Correct the last commit,
412 putting the correct sentences in the correct pages.
414 2007-06-01 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/easysetup/modest-easysetup-wizard.c:
417 (create_page_complete_custom): Show the second sentence of text
418 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
421 2007-06-01 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
424 Set the leave-on-server conf key by default. This fixes
425 projects.maemo.org bug NB#59258 .
427 2007-06-01 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-account-view-window.c:
430 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
431 logical ID for the confirmation messages. Fixed projects.maemo.org bug
434 2007-06-01 Murray Cumming <murrayc@murrayc.com>
436 * src/maemo/easysetup/modest-easysetup-wizard.c:
437 (create_caption_new_with_asterisk):
438 * src/maemo/modest-account-settings-dialog.c:
439 (create_caption_new_with_asterisk):
440 Uncomment the code to add the asterisk, because they are no longer in the
441 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
442 (update_incoming_server_title): Add an asterisk here too.
444 2007-06-01 Murray Cumming <murrayc@murrayc.com>
446 * src/maemo/modest-maemo-global-settings-dialog.c:
447 (current_connection): Check that we are even connected before trying to
448 get the current connection name, to prevent a warning.
450 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
451 Change the comments because tny_maemo_conic_device_connect() is now meant to
453 * src/modest-mail-operation.c:
454 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
455 make sure we have a connection and fail if we can't connect.
457 2007-05-31 Murray Cumming <murrayc@murrayc.com>
459 * src/maemo/modest-main-window.c:
460 (on_account_store_connecting_finished): Do not try to get the
461 connection ID if we are not really connected. I am surprised that
462 this signal handler is called when we are not connected.
464 2007-05-31 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-error.h:
467 * src/modest-ui-actions.c:
468 (modest_ui_actions_get_msgs_full_error_handler):
469 Renamed an enum, added comments, added an enum
470 for retrieve-limit errors.
472 * src/modest-mail-operation.c: (foreach_add_item),
473 (internal_folder_observer_update), (update_account_thread),
474 (modest_mail_operation_get_msgs_full):
475 (modest_mail_operation_update_account),
476 Added comments about how this works, and some code that should
477 (but does not) check the retrieve-limit. See the TODO comment.
479 2007-05-31 Murray Cumming <murrayc@murrayc.com>
481 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
482 Initialize help_id to fix the build. Warnings are good.
484 2007-05-31 Murray Cumming <murrayc@murrayc.com>
486 * src/widgets/modest-hbox-cell-renderer.c:
487 (modest_hbox_cell_renderer_append):
488 * src/widgets/modest-vbox-cell-renderer.c:
489 (modest_vbox_cell_renderer_append):
490 Fix the last commit by doing an extra ref.
492 2007-05-31 Murray Cumming <murrayc@murrayc.com>
494 * src/widgets/modest-hbox-cell-renderer.c:
495 (modest_hbox_cell_renderer_append):
496 * src/widgets/modest-vbox-cell-renderer.c:
497 (modest_vbox_cell_renderer_append):
498 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
499 to fix the build with Maemo Bora.
500 However, there seems to be a remaining crash, probably due to reference
503 2007-05-30 Murray Cumming <murrayc@murrayc.com>
505 * src/modest-tny-account.c:
506 (modest_tny_account_new_for_local_folders):
507 Use hildon_file_system_info_async_new() to get a better name for
508 the memory card account, setting it as the account name.
509 The timing seems to work, but this is probably
510 not the best place to do this. See the TODO comment.
511 * src/maemo/modest-main-window.c: (create_details_widget):
512 * src/widgets/modest-folder-view.c: (text_cell_data):
513 Use the tny account name instead of hardcoding a name.
515 2007-05-30 Christian Kellner <ckellner@openismus.com>
517 * src/modest-search.c: (modest_search):
518 Correctly set part_search_func even if we have already parsed
519 the query and thus a valid OgsTextSearcher object.
521 2007-05-30 Christian Kellner <ckellner@openismus.com>
524 Search and check for libogs.
527 Incooparte the ogs build env.
529 * src/modest-mime-part-search-stream.c:
530 * src/modest-mime-part-search-stream.h:
531 Removed since we do the real searching now in modest-search.c.
533 * src/modest-search.c:
534 * src/modest-search.h:
535 Implement support for ogs. We use that if available and requested
536 and fall back to modest_text_utils_utf8_strcmp (). The search logic
537 should now handle the corner case when the search term is spread
538 across multiple reads.
539 Also the logic in modest_search () was corrected to search all
540 requested fields until one is found.
542 2007-05-30 Murray Cumming <murrayc@murrayc.com>
544 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
547 * src/modest-init.c: Made modest_init_local_folders() take a
548 path and be public so we can iniitialize maildir folders on
551 * src/modest-local-folder-info.h:
552 * src/modest-local-folder-info.c:
553 (modest_local_folder_info_get_maildir_path): Add a path parameter.
555 * src/modest-tny-account.c:
556 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
557 still means the standard local-folders path on the local volume.
559 * src/modest-tny-account-store.c:
560 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
561 signal so we can detect mount/unmount of the MMC1 card, and do an update of
562 all accounts when that happens.
563 (get_server_accounts): If the MMC1 card is mounted, create a store account for
564 this too, so it shows up in the treeview.
566 2007-05-28 Murray Cumming <murrayc@murrayc.com>
568 * src/maemo/modest-maemo-global-settings-dialog.c:
569 (current_connection):
570 * src/widgets/modest-global-settings-dialog.c:
571 (current_connection_default):
572 Use the enum values instead of 0, 1 and -1,
573 to make the code clearer.
575 * src/modest-account-mgr-helpers.c:
576 (modest_account_mgr_get_connection_specific_smtp): Make this code
579 * src/modest-runtime.h:
580 * src/modest-runtime.c:
581 Added modest_runtime_remove_all_send_queues().
582 * src/maemo/modest-main-window.c:
583 (on_account_store_connecting_finished): Recreate the send queues,
584 using the appropriate transport accounts for this new connection.
585 Some futher adapting might be needed if the old send queues are not
586 automatically stopped at this point.
588 * src/modest-tny-account-store.c: (get_server_accounts):
589 Create the connection-specific transport accounts, so that they can
590 be found later by their ID.
592 * src/modest-tny-account.h:
593 * src/modest-tny-account.c:
594 Added modest_tny_account_new_from_server_account_name().
595 modest_tny_account_new_from_server_account(): Do not create the
596 send queues here, because they will be
597 recreated anyway when the connection changes for the first time.
599 2007-05-28 Murray Cumming <murrayc@murrayc.com>
601 * src/modest-local-folder-info.h:
602 * src/modest-local-folder-info.c:
603 (modest_per_account_local_outbox_folder_info_get_maildir_path),
604 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
605 tbox_folder): Take a modest account name instead of a server TnyAccount,
606 so we can have per-modest-account rather than per-transport-account
608 We must make sure that we change or recreate the exisitng send queues
609 when the connection changes for connection-specific transport accounts.
611 * src/modest-tny-account-store.c:
612 (create_per_account_local_outbox_folders): Create outboxed per modest
613 account, not per transport account.
615 * src/modest-tny-account.h:
616 * src/modest-tny-account.c:
617 (modest_tny_account_get_special_folder): For outboxes, get the
618 parent modest account name. The account is ignored for other folders.
619 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
620 modest account name rather than a server TnyAccount.
622 2007-05-25 Murray Cumming <murrayc@murrayc.com>
624 * src/modest-tny-account.c:
625 (modest_tny_account_new_from_server_account):
626 Call modest_runtime_get_send_queue() immediately after creating transport
627 accounts, so that they start trying to send email from the outbox as soon
628 as possible at startup. This is probably what we want.
630 * src/modest-mail-operation.c: (update_account_thread):
631 * src/modest-runtime.c: (modest_runtime_get_send_queue):
632 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
633 * src/modest-tny-send-queue.h:
634 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
635 (modest_ui_actions_on_send):
636 Added comments about how sending works, though it needs some more work.
638 2007-05-25 Murray Cumming <murrayc@murrayc.com>
640 * src/modest-tny-account.c:
641 (modest_tny_account_get_special_folder): Add TODO because this fails when
643 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
644 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
645 Do not try to show this window when there is no active account. The UI
646 specs does not tell us what to do in this case.
648 2007-05-24 Murray Cumming <murrayc@murrayc.com>
652 * src/maemo/Makefile.am:
653 * src/widgets/Makefile.am: Some dist fixes.
655 2007-05-24 Murray Cumming <murrayc@murrayc.com>
657 * src/maemo/modest-connection-specific-smtp-window.c:
658 (on_button_edit): Make the code clearer, to prevent a double free.
660 2007-05-24 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/modest-account-settings-dialog.c:
663 (modest_account_settings_dialog_set_account_name),
664 Check the connection-specific smtp servers checkbox if there are any.
666 * src/maemo/modest-connection-specific-smtp-edit-window.c:
667 (modest_connection_specific_smtp_edit_window_init):
668 Start with a suitable port number.
670 * src/modest-account-mgr-helpers.h:
671 * src/modest-account-mgr-helpers.c: Added
672 modest_account_mgr_get_has_connection_specific_smtp().
674 (modest_account_mgr_set_connection_specific_smtp),
675 (modest_account_mgr_remove_connection_specific_smtp),
676 (modest_account_mgr_get_has_connection_specific_smtp),
677 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
678 connection-specific smtp server accounts in the account, rather than
679 the server account conf dir.
681 This fixes bug projects.maemo.org bug NB#58263 .
683 * src/modest-tny-account-store.c:
684 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
685 if there are no server accounts yet, to prevent an infinite loop when there
686 are no accounts. Document that one must be called before the other.
688 2007-05-24 Murray Cumming <murrayc@murrayc.com>
690 * src/modest-account-mgr-helpers.c:
691 (modest_account_mgr_get_default_account): Make sure that at least
692 one account is always the default, if there are any enabled accounts.
693 This is just a sanity check that shouldn't be necessary.
695 * src/modest-account-mgr-priv.c:
696 (_modest_account_mgr_account_from_key): Unescape the conf key to
697 get the real account name. For instance, this is an issue if a space
698 was in the account name, which can happen because the account name
699 is generated from the display name.
700 (_modest_account_mgr_get_account_keyname): Always escape the
702 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
703 Unescape the conf keys to get the real account names.
705 For instance, previously the is-default radio button in the accounts
706 list was not checked for any accounts at first. This fixes that,
707 and might fix several similar bugs.
709 2007-05-23 Murray Cumming <murrayc@murrayc.com>
711 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
712 Removed some debug printfs.
714 2007-05-23 Murray Cumming <murrayc@murrayc.com>
716 Modest on-disk outbox directories are now here, for instance:
717 $HOME/.modest/outboxes/<account-id-1>/outbox
718 $HOME/.modest/outboxes/<account-id-2>/outbox
720 $HOME/.modest/local-folders/outbox
721 so we can have a separate outbox for each account.
722 But they are shown as one outbox in the GtkTreeView, by using a
723 TnyMergeFolder in a ModestTnySimpleFolderStore.
726 * src/modest-tny-simple-folder-store.c:
727 * src/modest-tny-simple-folder-store.h:
728 Added ModestTnySimpleFolderStore, used to contain folders from
729 other folder stores, such as other accounts.
731 * src/modest-tny-outbox-account.h:
732 * src/modest-tny-outbox-account.c:
733 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
734 used for the per-account local outbox folders.
736 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
737 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
738 only use this (internally) now for the non-outbox local folders.
741 * src/modest-init.c: Added modest_init_one_local_folder(), for
742 setting up the directory structure for each local folder.
744 * src/modest-local-folder-info.c:
745 (modest_per_account_local_outbox_folder_info_get_maildir_path),
746 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
748 * src/modest-local-folder-info.h:
749 * src/modest-tny-account-store.c: (on_account_removed),
750 (on_account_changed), (create_per_account_local_outbox_folders),
751 (get_server_accounts), (modest_tny_account_store_get_accounts),
752 (modest_tny_account_store_get_tny_account_by_account),
753 (modest_tny_folder_store_is_virtual_local_folders):
755 * src/modest-tny-account.h:
756 * src/modest-tny-account.c:
757 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
758 to create an on-disk per-account local outbox folder for each
760 (create_per_account_local_outbox_folders): Create a local outbox folder
761 for each transport account.
762 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
763 for all local folders.
765 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
766 instead of using g_object_get/set() directly. It is clearer.
768 (modest_tny_folder_store_get_message_count),
769 (modest_tny_folder_store_get_local_size
770 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
771 because we now use these with non-acount folder stores.
773 (modest_tny_account_get_special_folder),
774 (modest_tny_account_new_from_server_account),
775 (modest_tny_account_new_from_account):
776 (recurse_folders): Adjust to the new outbox system.
778 * src/modest-tny-folder.h:
779 * src/modest-tny-folder.c:
780 (modest_tny_folder_is_local_folder),
781 (modest_tny_folder_get_local_folder_type),
782 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
784 * src/widgets/modest-main-window.h:
785 * src/maemo/modest-main-window.c: (create_details_widget),
786 (modest_main_window_set_contents_style): Show details for any folder store,
789 (modest_tny_folder_get_rules):
790 Remove the const. C does not support constness enough for this.
792 * src/modest-ui-actions.c:
793 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
794 make all outboxes appear as one, in the usual local-folders tree node.
796 (set_active_account_from_tny_account),
797 (modest_ui_actions_on_folder_selection_changed):
798 * src/widgets/modest-folder-view.c: (text_cell_data),
799 (icon_cell_data), (filter_row),
800 (add_account_folders_to_merged_folder),
801 (add_account_folders_to_simple_folder_store), (),
802 (get_cmp_rows_type_pos), (cmp_rows),
803 (modest_folder_view_set_account_id_of_visible_server_account):
804 Adjust to the new outbox system, using generic folder stores and folders
807 2007-05-23 Christian Kellner <ckellner@openismus.com>
809 * src/modest-mail-operation.c:
810 (modest_mail_operation_update_account):
811 Use info->max_size instead of unintialized local var [small
812 build fix]. (Added TODO to review that change since I don't
815 2007-05-23 Marcus Bauer <marcusb@openismus.com>
817 * libmodest-dbus-client/libmodest-dbus-client.c:
818 (libmodest_dbus_client_compose_mail): function added
819 * src/dbus_api/modest-dbus-api.h:
820 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
821 (on_compose_mail): Implementation of the SendAsMail functionality
823 2007-05-22 Murray Cumming <murrayc@murrayc.com>
825 * src/modest-account-mgr.c:
826 (modest_account_mgr_add_server_account): Set the secure-connection
827 conf key for transport accounts as well as store accounts. I don't know
828 why the if was there. For instance, this makes sure that we use SSL
829 for the gmail preset from the easysetup wizard.
831 2007-05-22 Murray Cumming <murrayc@murrayc.com>
833 * src/gnome/modest-main-window.c:
834 (on_account_store_connecting_finished), (connect_signals):
835 * src/maemo/modest-main-window.c:
836 (on_account_store_connecting_finished), (connect_signals),
837 (modest_main_window_new):
838 Handle TnyAccountStore::connecting-finished instead of
839 TnyDevice::connection-changed, because we cannot actually perform
840 operations on accounts until TnyAccountStore has itself responded to
841 the TnyDevice::connection-changed signal. This prevents a GError from
843 Do not try to update at startup, because we (at least on scratchbox)
844 already do an update at startup when the device goes online.
845 This prevents a GError from tinymail.
846 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
847 Added TODO about stopping simultaneous operations.
849 2007-05-21 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
852 * src/modest-mail-operation-queue.c:
853 (modest_mail_operation_queue_remove):
854 * src/modest-tny-account-store.c: When GErrors happen, give more clues
855 about where they happened.
857 2007-05-21 Murray Cumming <murrayc@murrayc.com>
859 * src/modest-ui-actions.c:
860 (modest_ui_actions_on_password_requested): Make sure that the remember
861 output parameter is always TRUE.
863 2007-05-21 Murray Cumming <murrayc@murrayc.com>
865 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
866 Show a OK/Cancel dialog if the error is a question, though we still do not
867 know anything more about what we are asking the user.
868 * src/widgets/modest-folder-view.c: (on_drag_data_received):
869 Fix an uninitialized variable (helper). This is a logic error, however.
871 2007-05-21 Christian Kellner <ckellner@openismus.com>
873 * src/modest-search.h:
874 Correct bit shifting in the ModestSearchFlags enum.
876 2007-05-21 Murray Cumming <murrayc@murrayc.com>
878 * src/modest-tny-account.c:
879 (modest_tny_account_new_from_server_account): Do not use the lsub and
880 check-all hard-coded IMAP options when using POP.
882 2007-05-21 Murray Cumming <murrayc@murrayc.com>
884 * src/modest-tny-account.c:
885 (modest_tny_account_new_from_server_account):
886 Use NULL for the secure-auth method for POP when Password auth has been
887 specified by the user, as we already do for IMAP. "auth=Login" causes
888 an error from camel or the server.
890 2007-05-17 Murray Cumming <murrayc@murrayc.com>
892 * src/maemo/modest-account-settings-dialog.c:
893 (create_page_account_details),
894 (modest_account_settings_dialog_set_account_name):
895 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
896 for the leave-on-server checkbox, rathr than just the checkbox, when
897 the protocol is not POP.
899 2007-05-17 Murray Cumming <murrayc@murrayc.com>
901 * src/widgets/modest-account-view.c:
902 * src/widgets/modest-account-view.h:
903 Added modest_account_view_select_account() which will be useful later
904 to asynchronously re-select the edited account.
906 2007-05-17 Murray Cumming <murrayc@murrayc.com>
908 * src/maemo/modest-account-settings-dialog.c:
909 (modest_account_settings_dialog_set_account_name):
910 Automatically choose the port numbers based on the secure authentication
911 methods, if they have not been chosen before.
912 This fixes projects.maemo.org bug NB#56273 .
914 2007-05-17 Murray Cumming <murrayc@murrayc.com>
916 * src/maemo/modest-main-window-ui.h:
917 * src/modest-ui-actions.c:
918 * src/modest-ui-actions.h:
919 Connect the Tools/SMTP Servers menu item to
920 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
921 SMTP servers dialog, as in the UI specification and saves changes when it
922 is closed. This fixed projects.maemo.org bug NB#56305 .
924 2007-05-17 Murray Cumming <murrayc@murrayc.com>
926 * src/maemo/modest-connection-specific-smtp-window.c:
927 (modest_connection_specific_smtp_window_init):
928 Use gtk_window_set_default_size() to make this window big enough, so
929 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
931 2007-05-17 Murray Cumming <murrayc@murrayc.com>
933 * src/maemo/modest-connection-specific-smtp-edit-window.h:
934 * src/maemo/modest-connection-specific-smtp-edit-window.c:
935 (modest_connection_specific_smtp_edit_window_init),
936 Do not try to connect to a combobox signal before the combobox exists.
937 This fixes the cras in projects.maemo.org bug NB#56288 .
938 (modest_connection_specific_smtp_edit_window_get_settings):
939 Remove the server_account_name parameter which was being checked for NULL
940 though it was not used.
942 * src/maemo/modest-connection-specific-smtp-window.c:
943 (modest_connection_specific_smtp_window_fill_with_connections),
944 (on_button_edit), (modest_connection_specific_smtp_window_init):
945 Correct the number of treemodel columns to prevent a warning.
946 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
947 libconic does not work.
949 2007-05-16 Murray Cumming <murrayc@murrayc.com>
951 * src/modest-tny-account.c:
952 (modest_tny_account_new_from_server_account):
953 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
954 SMTP when "None" was chosen by the user. However, with my SMTP server that
955 does not support ANONYMOUS, the emails do not leave the Outbox and I see
958 2007-05-16 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
961 to explain the memory management issue with the ID in the ModestPair.
963 * src/gnome/modest-account-assistant.c: (add_receiving_page),
964 (add_sending_page), (modest_account_assistant_finalize):
965 * src/gnome/modest-gnome-global-settings-dialog.c:
966 (create_updating_page), (create_composing_page):
967 * src/gnome/modest-msg-edit-window.c: (get_transports),
968 (init_window), (modest_msg_edit_window_finalize),
969 (modest_msg_edit_window_get_msg_data):
970 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
971 * src/gnome/modest-transport-widget.c:
972 (modest_transport_widget_finalize), (smtp_configuration):
973 * src/maemo/modest-maemo-global-settings-dialog.c:
974 (create_updating_page), (create_composing_page):
975 * src/maemo/modest-msg-edit-window.c: (get_transports),
976 (init_window), (modest_msg_edit_window_finalize),
977 (modest_msg_edit_window_get_msg_data),
978 (modest_msg_edit_window_free_msg_data):
979 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
980 (modest_store_widget_finalize):
981 * src/maemo/modest-transport-widget.c:
982 (modest_transport_widget_finalize), (smtp_configuration):
983 * src/modest-main.c: (send_mail):
984 * src/widgets/modest-combo-box.h:
985 * src/widgets/modest-global-settings-dialog-priv.h:
986 * src/widgets/modest-global-settings-dialog.c:
987 (modest_global_settings_dialog_finalize):
988 * src/widgets/modest-msg-edit-window.h:
989 Whenever using modest_combo_box_new(), keep the ModestPairList alive
990 as long as the combo box, to prevent use of freed memory for the ID.
992 2007-05-15 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
995 get_accounts(), to make this clearer. Do not check for the enabled gconf
996 key, because we do not use this for server accounts (at least, not yet).
997 This allows us to send email again.
999 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/modest-platform.c:
1002 (on_modest_conf_update_interval_changed), (modest_platform_init):
1003 Only respond to this particular key change. All these strcmp()s cannot be
1006 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1008 * src/maemo/modest-maemo-global-settings-dialog.c:
1009 (current_connection): Prevent a crash in scratchbox when
1010 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1011 * src/maemo/modest-platform.c:
1012 (on_modest_conf_update_interval_changed), (modest_platform_init):
1013 Get the update interval from gconf and reset it when the gconf key changes.
1015 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-protocol-info.c:
1018 * src/modest-protocol-info.h: Adde enum-specific get functions,
1019 instead of using a ModestProtocolType enum parameter.
1021 * src/gnome/modest-account-assistant.c:
1022 * src/gnome/modest-store-widget.c:
1023 * src/gnome/modest-store-widget.h:
1024 * src/gnome/modest-transport-widget.c:
1025 * src/gnome/modest-transport-widget.h:
1026 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1027 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1028 * src/maemo/easysetup/modest-easysetup-wizard.c:
1029 * src/maemo/modest-account-settings-dialog.c:
1030 * src/maemo/modest-account-settings-dialog.h:
1031 * src/maemo/modest-store-widget.c:
1032 * src/maemo/modest-store-widget.h:
1033 * src/maemo/modest-transport-widget.c:
1034 * src/maemo/modest-transport-widget.h:
1035 * src/modest-account-mgr-helpers.c:
1036 * src/modest-account-mgr-helpers.h:
1037 * src/modest-account-mgr.c:
1038 * src/modest-account-mgr.h:
1039 * src/modest-tny-account.c:
1040 * src/modest-tny-folder.c:
1041 * src/widgets/modest-account-view.c:
1042 * src/widgets/modest-retrieve-combo-box.c:
1043 * src/widgets/modest-retrieve-combo-box.h:
1044 * src/widgets/modest-secureauth-combo-box.c:
1045 * src/widgets/modest-serversecurity-combo-box.c:
1046 * src/widgets/modest-serversecurity-combo-box.h:
1047 * tests/check_account-mgr.c:
1048 Use the specific functions, and use the re-renamed enum values for GNOME too.
1050 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1052 * src/modest-pair.h:
1053 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1054 so we can get the second based on the first.
1056 * src/maemo/modest-account-settings-dialog.h:
1057 * src/maemo/modest-account-settings-dialog.c:
1058 Added get_supported_secure_authentication_methods(), though it is mostly
1059 commented-out for now until the necessary API is committed to tinymail.
1060 (modest_account_settings_dialog_set_account_name),
1061 (save_configuration): Request the supported authentication methods from the
1062 server, so we can choose a working method.
1064 * src/modest-tny-account-store.h:
1065 * src/modest-tny-account-store.c:
1066 (modest_tny_account_store_get_session): Rename from
1067 tny_account_store_get_session().
1069 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1071 * src/modest-protocol-info.h: Split the ModestProtocol enum
1072 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1073 There was no need to have these unrelated values in one enum.
1075 * src/: many files: Adapted to changed enum. This makes the code a bit
1076 clearer, and the compiler could catch some errors.
1078 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1080 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1081 Show the detailed internal camel error message when an error happens
1082 during the configuration, so that our testers can give us more clues.
1083 For instance, in projects.maemo.org bug NB#56910 .
1085 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1087 * src/modest-tny-account.c:
1088 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1089 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1091 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1093 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1094 * src/maemo/modest-account-settings-dialog.c:
1095 (modest_account_settings_dialog_set_account_name),
1096 (save_configuration): For the incoming secure authentication checkbox,
1097 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1098 the UI specification. PLAIN does not seem to be supported for most IMAP
1099 servers anyway, and I am not sure what it would mean.
1100 However, we probably need to discover which of the secure-authentication
1101 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1102 * src/modest-account-mgr-helpers.c:
1103 (modest_account_mgr_get_server_account_data):
1105 * src/modest-tny-account.c:
1106 (modest_tny_account_new_from_server_account):
1107 Use tny_account_set_mech() to set secure-authentication methods,
1108 with some special-casing for IMAP, based on my observations of how
1111 * src/modest-account-mgr-helpers.h:
1112 * src/modest-account-mgr.c:
1113 * src/modest-defs.h: Comment that the URI is only used for local folders.
1115 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1117 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1118 parameter const, just to be neat.
1119 * src/modest-text-utils.c: (modest_text_utils_inline):
1120 End g_strconcat() with NULL, as its documentation says. This is almost
1121 certainly the cause of my crash at startup on the device. Interestingly,
1122 valgrind doesn't tell us about these errors.
1124 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1126 * scripts/build-packages: Added more precise comments about how to use
1127 this script, though I still get this error:
1128 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1129 error building tinymail
1131 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1133 * src/maemo/modest-main-window.c: (on_account_update):
1134 Very slight cleanup, hoping to make it simpler to discover what causes
1135 a crash here sometimes.
1137 * src/modest-tny-account.c:
1138 (modest_tny_account_new_from_server_account): Set the port. Added
1139 comments about the options and a TODO comment because I need to find out
1140 how to specify the secure authentication method.
1142 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1144 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1145 changed CFlags paths form modest to libmodest
1147 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1149 * src/modest-account-mgr-helpers.c:
1150 (modest_account_mgr_get_server_account_data),
1151 (modest_account_mgr_free_server_account_data):
1152 * src/modest-account-mgr-helpers.h:
1153 * src/modest-account-mgr.c:
1154 (modest_account_mgr_add_server_account):
1155 * src/modest-defs.h:
1156 * src/modest-tny-account.c:
1157 (modest_tny_account_new_from_server_account):
1158 Determine the options for tny_camel_account_add_option() here,
1159 based on the settings, rather than storing them directly in gconf.
1161 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1164 Show a more friendly error dialog now that we expect (from the tinymail
1165 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1167 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/modest-main-window.c: (on_account_update): Check that
1170 account_name is not NULL, to prevent a crash at startup that I am
1171 seeing on the N800. I do wonder why it is NULL.
1173 * src/maemo/easysetup/modest-easysetup-wizard.c:
1174 (create_page_user_details):
1175 * src/maemo/modest-account-settings-dialog.c:
1176 (create_page_user_details), (create_page_outgoing):
1177 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1178 (modest_connection_specific_smtp_edit_window_init):
1179 * src/modest-ui-actions.c:
1180 (modest_ui_actions_on_password_requested):
1181 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1182 might do something useful with the on-screen keyboard.
1184 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-main-window.c: (on_account_update):
1187 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1188 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1190 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1192 * src/modest-tny-account-store.c: (on_account_changed):
1193 Correct the signature of this signal handler.
1195 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1197 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1198 Show a HildonNote instead of a GtkDialog for Maemo.
1200 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1202 * src/widgets/modest-account-view.h:
1203 * src/widgets/modest-account-view.c: (on_account_changed),
1204 (on_account_removed). Added a boolean flag, set/unset by
1205 modest_account_view_block_conf_updates(),
1206 modest_account_view_unblock_conf_updates() to prevent unnecessary
1207 updates, but this is not very useful because the gconf notifications are
1208 so delays (maybe only on Maemo Bora).
1209 So auto-updating is turned off, and these functions do an explicit
1210 update when necessary.
1211 However, something else is still doing too much work when adding/removing
1212 accounts, probably in another part of the application.
1214 * src/maemo/modest-account-view-window.c:
1215 (on_delete_button_clicked), (on_edit_button_clicked),
1216 (on_new_button_clicked): Use the new functions.
1218 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-account-mgr-helpers.c:
1221 (modest_account_mgr_set_first_account_as_default):
1222 Sort the list of names alphabetically-by-title, so we choose the first one
1224 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1225 alphabetically by the title.
1227 This fixes projects.maemo.org bug NB#56418 .
1229 * src/modest-account-mgr-priv.c:
1230 (_modest_account_mgr_account_from_key):
1231 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1232 avoid a valgrind error, and possible random behaviour.
1234 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1236 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1237 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1238 tinymail documentation to say that this can be expected.
1239 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1240 pretty, and should not happen, but I would prefer to know when it does.
1242 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1244 * configure.ac: When using the older hildon version, probably on Bora,
1245 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1247 * src/widgets/modest-attachment-view.c:
1248 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1251 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1253 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1254 Implemented the prototype. Can be tested with
1255 tests/dbus_api/test_open_message:
1257 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1259 * src/modest-tny-account-store.c:
1260 (modest_tny_account_store_instance_init), (get_password):
1261 * src/modest-ui-actions.c:
1262 (modest_ui_actions_on_password_requested):
1263 Do not store the password in gconf, because this function is called
1264 for non-remembered passwords. Actually use the cached (in the hash map)
1265 password instead of releasing it.
1266 The password will now not be remembered if it is asked via the protected
1267 password dialog, as per the UI spec.
1269 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1271 * src/modest-defs.h:
1272 * src/modest-account-mgr-helpers.h:
1273 * src/modest-account-mgr-helpers.c:
1274 Added modest_server_account_get_username_has_succeeded(),
1275 modest_server_account_set_username_has_succeeded().
1276 (modest_server_account_set_username),
1277 Reset the has-succeeded flag if the username changes.
1279 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1280 * src/maemo/modest-connection-specific-smtp-window.c:
1281 (modest_connection_specific_smtp_window_save_server_accounts):
1282 Use modest_server_account_set_username() instead of using
1283 modest_conf_set_string() directly, so that the has-succeeded flag is always
1286 * src/modest-ui-actions.c:
1287 (modest_ui_actions_on_password_requested): Dim the username entry if
1288 the username has ever worked, as per the UI spec.
1290 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1292 * src/modest-tny-account-store.c: (get_password):
1293 * src/modest-ui-actions.c:
1294 (modest_ui_actions_on_password_requested):
1295 Allow the username to be changed too, though there is more work to
1296 be done on exactly how this behaves.
1298 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-account-mgr-helpers.h:
1301 * src/modest-account-mgr-helpers.c:
1302 Added modest_account_mgr_get_display_name(),
1303 modest_server_account_get_username(),
1304 modest_server_account_set_username(),
1305 modest_server_account_set_password(),
1306 modest_server_account_get_hostname() functions so we do not need to
1307 use the conf API directly.
1309 * src/maemo/modest-main-window.c: (connect_signals):
1310 Actually connect ot the ModestAccountStore::request-password signal,
1311 so that we show the dialog when the password is requested by Tinymail,
1312 for isntance if it is empty.
1314 * src/modest-marshal.list:
1315 * src/modest-tny-account-store.c:
1316 (modest_tny_account_store_class_init), (get_password),
1317 (modest_tny_account_store_alert):
1318 * src/modest-tny-account-store.h:
1319 * src/modest-ui-actions.h:
1320 * src/modest-ui-actions.c:
1321 (modest_ui_actions_on_password_requested):
1322 Change the signal parameters, so it is obvious that we are providing
1323 the non human-readable server name, and receiving both the username
1324 and password, though changing of the username is not yet implemented.
1325 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1326 for the GNOME version.
1328 This should fix the projects.maemo.org bug NB#56209, though it does not
1329 work on Bora, because the gconf_client_get() for the password fails
1330 immediately after we save it with gconf_client_set().
1332 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1335 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1336 caused an undefined symbol error:
1337 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1339 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-tny-account-store.c:
1342 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1343 using a GError instead of a string message, so we can translate it in
1346 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/modest-address-book.c:
1349 (modest_address_book_check_names):
1350 * src/maemo/modest-msg-view-window.c:
1351 (modest_msg_view_window_clipboard_owner_change):
1352 * src/modest-init.c: (modest_init_init_ui):
1353 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1354 (update_folders_cb), (modest_mail_operation_update_account):
1355 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1356 (modest_ui_actions_on_msg_attachment_clicked),
1357 (modest_ui_actions_on_msg_recpt_activated):
1358 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1359 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1360 (modest_msg_view_search_next):
1361 * src/widgets/modest-recpt-editor.c:
1362 (modest_recpt_editor_on_button_release_event),
1363 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1364 g_message(). At this point we should only be seeing interesting errors on
1365 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1367 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1369 (modest_wizard_dialog_force_title_update):
1370 * src/maemo/easysetup/modest-wizard-dialog.h:
1371 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1372 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1373 can update the title when appropriate. Otherwise the title is wrong if the
1374 pages are added after adding the notebook to the dialog.
1375 This must be a problem in HildonWizardDialog too.
1376 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1378 * src/maemo/easysetup/modest-easysetup-wizard.c:
1379 (create_subsequent_customsetup_pages),
1380 (create_subsequent_easysetup_pages):
1381 Call modest_wizard_dialog_force_title_update() so that the title is
1382 correct even with GTK+ < 2.10.
1383 This fixes projects.maemo.org bug NB#56145 .
1385 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1387 * src/maemo/modest-platform.c:
1388 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1389 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1392 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1394 * src/widgets/modest-window.h:
1395 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1396 and modest_window_save_state(), which invokes it.
1398 * src/widgets/modest-window-mgr.h:
1399 * src/widgets/modest-window-mgr.c:
1400 Added modest_window_mgr_save_state_for_all_windows(), which calls
1401 the save_state vfunc on all registered windows, if implemented.
1403 * src/gnome/modest-msg-edit-window.c:
1404 * src/gnome/modest-msg-view-window.c:
1405 * src/maemo/modest-msg-edit-window.c:
1406 * src/maemo/modest-msg-view-window.c:
1407 * src/maemo/modest-main-window.c:
1408 Specify the existing save_settings functions as implementations of
1409 ModestWindow::save_state_func().
1411 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1412 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1413 enabling hibernation, for instance.
1415 We may need to do the same thing for restoring settings.
1418 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1420 * src/widgets/modest-window-mgr.c:
1421 * src/widgets/modest-window-mgr.h:
1422 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1423 modest_window_mgr_get_hibernation_is_prevented().
1425 * src/maemo/modest-main-window.c:
1426 (on_hildon_program_is_topmost_notify): Prevent hibernation
1427 (possible when the application goes to the background in the WM),
1428 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1430 * src/maemo/easysetup/modest-easysetup-wizard.c:
1431 (modest_easysetup_wizard_dialog_init):
1432 * src/maemo/modest-account-settings-dialog.c:
1433 (modest_account_settings_dialog_init):
1434 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1435 (modest_connection_specific_smtp_edit_window_init):
1436 * src/maemo/modest-connection-specific-smtp-window.c:
1437 (modest_connection_specific_smtp_window_init):
1438 * src/maemo/modest-signature-editor-dialog.c:
1439 (modest_signature_editor_dialog_init):
1440 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1441 prevent hibernation while any of these account settings dialogs are open.
1443 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1445 * src/maemo/Makefile.am:
1446 * src/maemo/modest-osso-state-saving.c:
1447 * src/maemo/modest-osso-state-saving.h: Added
1448 modest_osso_load_state() and modest_osso_save_state() though they do
1449 nothing now. They should iterate through all the open windows and load/save
1451 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1452 save state when closing.
1454 * src/maemo/modest-main-window.c:
1455 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1456 Add a notification handler for the HildonProgram::is-topmost property,
1457 so we can allow hibernation when the application goes into the background.
1458 But we still need to detect when the accounts setup windows are open so
1459 we can stop hibernation when they are open.
1460 To do this, I also added the main window the HildonProgram. This might have
1461 other side-effects/benefits, and should maybe be done for other windows.
1463 * src/maemo/modest-osso-autosave-callbacks.h:
1464 * src/maemo/modest-osso-autosave-callbacks.c:
1465 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1466 though it does not do anything yet, and we might never need this to do
1467 anything. For instance, we already save drafts.
1469 * src/maemo/modest-platform.c: (modest_platform_init):
1470 Specify the libosso auto-save callback.
1472 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1474 * src/maemo/modest-platform.c:
1475 (modest_platform_set_update_interval):
1476 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1477 aparently stays valid between application instances, so we can use this
1478 to remove and reset it later. According to a maemo-developers email from
1481 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1483 * configure.ac: Depend on libalarm for Maemo.
1485 * src/dbus_api/modest-dbus-api.h:
1486 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1487 (on_send_receive), (modest_dbus_req_handler):
1488 Handle a SEND_RECEIVE D-Bus method.
1490 * libmodest-dbus-client/libmodest-dbus-client.c:
1491 (libmodest_dbus_client_send_and_receive):
1492 * libmodest-dbus-client/libmodest-dbus-client.h:
1493 Add C convenience functions for calling the new D-Bus method.
1495 * src/modest-platform.h:
1496 * src/gnome/modest-platform.c:
1497 * src/maemo/modest-platform.c:
1498 Added modest_platform_set_update_interval(), which uses the
1499 alarmd API on Maemo.
1500 (modest_platform_init),
1501 Call modest_platform_set_update_interval(), using a hard-coded
1502 interval for now (until the global settings dialog is implemented),
1503 though I am not sure that this makes sense yet.
1505 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1507 * src/dbus_api/modest-dbus-callbacks.c:
1508 (modest_osso_cb_hw_state_handler):
1509 * src/dbus_api/modest-dbus-callbacks.h:
1510 * src/maemo/modest-platform.c: (modest_platform_init):
1511 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1512 in case this has some effect on the ability for Maemo to ping the
1515 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1517 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1518 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1519 warning. It is probably a logic error, but I need to fix the build.
1521 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-account-mgr.h:
1524 * src/modest-account-mgr.c:
1525 (modest_account_mgr_account_names): Add a gboolean enabled_only
1526 parameter, so we can get lists of onlt the enabled accounts.
1528 (modest_account_mgr_add_account),,
1529 (modest_account_mgr_account_with_display_name_exists):
1530 * src/maemo/modest-msg-edit-window.c: (get_transports):
1531 * src/modest-account-mgr-helpers.c:
1532 (modest_account_mgr_set_first_account_as_default):
1533 * src/modest-init.c: (init_default_account_maybe):
1534 * src/modest-tny-account-store.c: (get_accounts):
1535 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1536 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1537 * tests/check_account-mgr.c: (START_TEST):
1538 Provide the extra parameter, as appropriate.
1540 * src/widgets/modest-account-view.c: (update_account_view):
1541 Do not show disabled accounts (meaning that there is no way to
1542 enable/disable accounts in the UI (the feature is not in our UI
1543 specification), so we can use this internally only to mark unfinished
1544 or temporary account data.
1546 * src/maemo/easysetup/modest-easysetup-wizard.c:
1547 (create_account): Add boolean enable parameter, so we can specify FALSE
1548 to create the temporary account.
1549 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1550 (on_before_next): When finishing, when there is a temporary account, just
1552 Also, use a timeout to delay the showing of the dialog until gconf is likely
1553 to return correct information, due to a maemo gconf bug that is fixed in
1554 osso 1.1, but not yet in Bora.
1555 However, the dialog stays on screen after it is destroyed.
1557 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1558 for invalid data when cancelling. Use a hildon note instead of a dialog
1559 to complain about invalid data. Do not show the account-saved note if the
1560 account is disabled (a temporary account that will not really be saved for use
1563 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-account-mgr-helpers.h:
1566 * src/modest-account-mgr-helpers.c:
1567 Added modest_account_mgr_unset_default_account(),
1568 Added modest_account_mgr_set_first_account_as_default().
1570 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1571 If it was the default account, unset the default account name.
1573 * src/maemo/modest-account-view-window.c:
1574 (on_delete_button_clicked): If it was the default account,
1575 set the first remaining account as the default instead.
1577 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1578 a NULL account or a NULL default account, to prevent a crash. This should
1579 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1582 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1584 * src/widgets/modest-recpt-editor.c:
1585 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1586 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1587 TODO comment for this. This fixes the build.
1589 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1590 be the best place for it. This will in future update all auto-update accounts,
1591 rather than just the current/default account, when that gconf key exists.
1592 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1593 if there are no accounts, before calling do_send_receive().
1594 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1596 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1597 * src/maemo/modest-main-window-ui.h:
1598 * src/maemo/modest-main-window.c: (on_connection_changed),
1599 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1600 directly, becaue the signal handler does more.
1602 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-account-mgr-helpers.c:
1605 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1606 for the case that the account does not exist.
1608 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1609 (equivalent to the modest account name) rather than the tinymail account name
1610 (equivalent to the modest account title - human readable) to get the account data.
1611 Check for null account data to prevent the crash, and add a TODO comment saying that
1612 this needs fixing because it is using the server account name instead of the account name.
1614 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1616 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1617 * src/maemo/modest-account-settings-dialog.c: (show_error),
1619 Use hildon_note_new_information() for informative and error messages,
1620 which seems to be expected for Maemo applications (no documentation that I know of
1621 says this). I am surprised that there is no distinction between info and error
1624 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1627 it is easy to find where this is used.
1629 * src/maemo/easysetup/modest-easysetup-wizard.c:
1630 (create_page_welcome), (create_page_account_details),
1631 (create_page_user_details), (create_page_complete_easysetup),
1632 (create_page_custom_incoming), (create_page_custom_outgoing),
1633 (create_page_complete_custom):
1634 * src/maemo/modest-account-settings-dialog.c:
1635 (create_page_account_details), (create_page_user_details),
1636 (create_page_incoming), (create_page_outgoing):
1637 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1638 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1639 (modest_connection_specific_smtp_edit_window_init):
1640 * src/maemo/modest-connection-specific-smtp-window.c:
1641 (modest_connection_specific_smtp_window_init):
1642 * src/maemo/modest-signature-editor-dialog.c:
1643 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1644 and scrolling policy as per the Email Application Layout Guide, if I have
1647 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1649 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1650 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1651 which were empty, because these vfuncs have been removed from TnyAccountStore.
1652 This fixes the build.
1654 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1656 * src/maemo/modest-main-window.c:
1657 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1658 showing/hiding it. Added TODO because it probably should not be NULL.
1659 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1660 because unnecessary g_warnings() make degugging difficult.
1662 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1664 * src/maemo/modest-msg-edit-window.c:
1665 (modest_msg_edit_window_select_color),
1666 (modest_msg_edit_window_select_background_color): 2 const corrections and
1667 moving 2 #endifs before closing brackets, to fix the build.
1669 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1671 * src/maemo/easysetup/modest-easysetup-wizard.h:
1672 * src/maemo/easysetup/modest-easysetup-wizard.c:
1673 (modest_easysetup_wizard_dialog_finalize),
1674 (on_button_edit_advanced_settings), (create_page_complete_custom),
1675 (on_response), (create_account):
1676 Implement the Advanced Settings edit button, by saving the account information,
1677 for the Advanded Settings dialog to use directly from gconf, and removing it
1678 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1679 Bug #5533 in the projects.maemo.org bugzilla.
1681 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1683 * src/maemo/modest-msg-view-window.c:
1684 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1685 when opening a message window.
1687 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1689 * src/maemo/easysetup/modest-easysetup-wizard.c:
1690 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1693 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1694 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1695 gconf settings. I probably added more checks than necessary, but that is safer.
1697 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1698 variable to fix the build, but this seems to be used when it is still NULL.
1700 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1702 * src/modest-platform.h:
1703 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1704 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1705 * src/modest-main.c: Implement this function so we can avoid using
1706 maemo-specific API from cross-platform code.
1708 * src/modest-tny-account-store.c:
1709 (get_smtp_specific_transport_account_for_open_connection):
1710 * src/modest-ui-actions.c: (check_for_connection),
1711 (modest_ui_actions_on_item_not_found):
1712 Use modest_platform_connect_and_wait() and put #idefs around other
1713 maemo-specific code, because only maemo currently has a way to
1714 identify connection names.
1716 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1718 * src/modest-tny-account-store.h:
1719 * src/modest-tny-account-store.c:
1720 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1721 the connection-specific SMTP server settings in the configuration.
1723 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1725 * src/maemo/modest-main-window.c: (on_connection_changed),
1727 * src/modest-main.c: (main), (start_ui), (send_mail):
1728 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1729 that is what is intended.
1731 * src/modest-ui-actions.c: (action_send), (action_receive),
1732 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1733 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1734 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1735 SMTP server is used when it is specified.
1737 (modest_ui_actions_on_send_receive):
1738 Check that a connection is open before proceeding.
1739 Receive and then send, instead of vice-versa, as per the specification.
1741 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1743 * src/modest-mail-operation.c:
1744 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1745 though I guess it should be something other than NULL.
1747 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1749 * src/maemo/easysetup/modest-easysetup-wizard.c:
1750 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1751 combo twice, to avoid an g_warning and to make it visible again.
1752 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1753 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1754 (already intended) dereference when detaching, because we then recreate the menu.
1755 But I am not sure why the warning was happening, and it is possible that this is a memory
1758 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1760 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1761 and uri_parse_mailto() utility functions.
1762 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1764 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1766 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1768 * src/dbus_api/modest-dbus-api.h:
1769 * src/dbus_api/modest-dbus-callbacks.c:
1770 Use an idle callback to execute the modest code in the application's own thread.
1771 Remove the helloworld example method.
1772 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1773 parsed, and the open-message method is not implemented because this is not yet implemented in
1775 * libmodest-dbus-client/libmodest-dbus-client.c:
1776 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1777 (libmodest_dbus_client_open_message):
1778 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1780 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1781 body without crashing.
1783 * tests/dbus_api/Makefile.am:
1784 * tests/dbus_api/test_mail_to.c:
1785 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1787 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1789 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1790 Added file to fix the build. Sorry.
1792 * src/dbus_api/Makefile.am:
1793 * src/dbus_api/modest-dbus-api.h:
1794 * src/dbus_api/modest-dbus-callbacks.h:
1795 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1796 (modest_dbus_req_handler):
1797 Put constants in a separate header so it can be reused by the
1798 client library, without duplication
1800 * libmodest-dbus-client/Makefile.am:
1801 * libmodest-dbus-client/libmodest-dbus-client.c:
1802 (libmodest_dbus_client_call_helloworld),
1803 (libmodfest_dbus_client_send_mail),
1804 (libmodfest_dbus_client_mailto),
1805 (libmodfest_dbus_client_open_message):
1806 * libmodest-dbus-client/libmodest-dbus-client.h:
1807 (Partly) Implement a send_mail D-Bus method.
1809 * tests/dbus_api/Makefile.am:
1810 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1811 the send_email D-Bus method.
1813 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1817 * libmodest-dbus-client/Makefile.am:
1818 * libmodest-dbus-client/libmodest-dbus-client.c:
1819 * libmodest-dbus-client/libmodest-dbus-client.h:
1820 * tests/dbus_api/Makefile.am:
1821 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1822 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1824 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1826 * src/maemo/easysetup/modest-easysetup-wizard.c:
1827 (create_page_account_details):
1828 * src/maemo/modest-account-settings-dialog.c:
1829 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1830 widgets, because this might not be the default in future versions of the Maemo GTK+.
1831 However, I can not not get capitalization to work even in a simple test case.
1833 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1835 * src/maemo/easysetup/modest-easysetup-wizard.c:
1836 (create_page_custom_incoming), (create_page_custom_outgoing):
1837 * src/maemo/modest-account-settings-dialog.c:
1838 (create_page_account_details), (create_page_incoming),
1839 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1840 instead of using gtk_check_button_with_label(), so they are aligned like the other
1841 widgets, as per the UI spec.
1843 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/easysetup/modest-easysetup-wizard.c:
1846 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1847 * src/widgets/modest-validating-entry.c:
1848 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1849 Modest prefix instead of an EasySetup prefix.
1851 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1853 * src/widgets/modest-validating-entry.h:
1854 * src/widgets/modest-validating-entry.c: (on_insert_text),
1855 Added easysetup_validating_entry_set_max_func(), used to set a callback
1856 to call when the max number of characters is reached. GtkEntry has a max-length
1857 already but is silent about it.
1859 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1860 (create_page_account_details), (create_page_user_details),
1862 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1863 (create_page_account_details), (create_page_user_details),
1864 (create_page_outgoing):
1865 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1866 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1867 the UI spec, when the user tries to enter more than the max number of characters.
1869 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1871 * src/maemo/easysetup/modest-easysetup-wizard.c:
1872 (create_page_user_details), (create_page_custom_incoming),
1873 (create_page_custom_outgoing):
1874 * src/maemo/modest-account-settings-dialog.c:
1875 (create_page_user_details), (create_page_incoming),
1876 (create_page_outgoing):
1877 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1878 (modest_connection_specific_smtp_edit_window_init):
1879 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1880 not appropriate. Bad Maemo-specific defaults!.
1882 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1884 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1885 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1886 (modest_signature_editor_dialog_set_settings):
1887 Disable the label and textview when the checkbox is disabled, and use the
1888 specified (UI spec) default signature text.
1890 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1892 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1893 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1895 * src/modest-defs.h:
1896 * src/modest-account-mgr-helpers.h:
1897 * src/modest-account-mgr-helpers.c:
1898 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1900 * src/maemo/Makefile.am:
1901 * src/maemo/modest-signature-editor-dialog.c:
1902 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1905 * src/maemo/modest-account-settings-dialog.h:
1906 * src/maemo/modest-account-settings-dialog.c:
1907 (modest_account_settings_dialog_finalize), (on_button_signature),
1908 (save_configuration): Use the new dialog when the Edit button is pressed, and
1909 save the changes if necessary, as per the UI spec.
1911 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1913 * src/maemo/Makefile.am:
1914 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1915 based on maemo-develoers email from Dirk.
1917 * src/maemo/easysetup/modest-easysetup-wizard.c:
1918 (create_page_welcome), (create_page_account_details),
1919 (create_page_user_details), (create_page_complete_easysetup),
1920 (create_page_custom_incoming), (create_page_custom_outgoing),
1921 (create_page_complete_custom),
1922 (modest_easysetup_wizard_dialog_init):
1923 * src/maemo/modest-account-settings-dialog.c:
1924 (create_page_account_details), (create_page_user_details),
1925 (create_page_incoming), (create_page_outgoing),
1926 (modest_account_settings_dialog_init):
1927 * src/maemo/modest-connection-specific-smtp-window.c:
1928 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1930 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/easysetup/modest-easysetup-wizard.c:
1933 (create_page_account_details), (create_page_custom_outgoing),
1934 (create_page_complete_custom):
1935 * src/maemo/modest-account-settings-dialog.c:
1936 (create_page_user_details), (create_page_incoming),
1937 (create_page_outgoing):
1938 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1939 (modest_connection_specific_smtp_edit_window_init):
1940 Use the correct (UI spec) port min/max, and use horizontal separators,
1943 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1945 * src/maemo/easysetup/modest-easysetup-wizard.c:
1946 (set_default_custom_servernames):
1947 * src/maemo/modest-account-settings-dialog.c:
1948 (create_page_incoming), (on_combo_outgoing_security_changed),
1949 (on_combo_incoming_security_changed), (create_page_outgoing),
1950 (modest_account_settings_dialog_set_account_name),
1951 (save_configuration):
1952 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1953 (on_combo_security_changed),
1954 (modest_connection_specific_smtp_edit_window_init),
1955 (modest_connection_specific_smtp_edit_window_set_connection),
1956 (modest_connection_specific_smtp_edit_window_get_settings):
1957 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1960 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1963 * src/maemo/easysetup/modest-easysetup-wizard.c:
1964 (create_page_custom_outgoing), (create_page_complete_custom):
1965 * src/maemo/modest-account-settings-dialog.c:
1966 (create_page_user_details), (create_page_outgoing):
1967 * src/maemo/modest-account-view-window.c: (button_box_new):
1968 Use changed logical IDs as per the most recent UI spec:
1969 mcen_bd_emailsetup_edit -> mcen_bd_edit
1970 mcen_bd_emailsetup_delete -> mcen_bd_delete
1971 mcen_bd_emailsetup_close -> mcen_bd_close
1973 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1977 * src/dbus_api/Makefile.am:
1978 * src/dbus_api/modest-dbus-callbacks.c:
1979 * src/dbus_api/modest-dbus-callbacks.h:
1980 * src/maemo/modest-platform.c: (modest_platform_init):
1981 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1983 * tests/Makefile.am:
1984 * tests/dbus_api/Makefile.am:
1985 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1987 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1989 * src/maemo/modest-account-settings-dialog.c:
1990 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1991 Removed unnecessary includes.
1993 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1995 * src/maemo/easysetup/modest-easysetup-wizard.c:
1996 * src/maemo/modest-account-settings-dialog.c:
1997 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1998 * src/widgets/Makefile.am:
1999 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2000 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2001 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2002 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2003 * src/widgets/modest-secureauth-combo-box.c:
2004 * src/widgets/modest-secureauth-combo-box.h:
2005 * src/widgets/modest-serversecurity-combo-box.c:
2006 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2007 made the GObject names more consistent with the rest of the Modest code.
2009 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/easysetup/Makefile.am:
2012 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2013 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2014 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2015 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2016 * src/maemo/easysetup/modest-easysetup-wizard.c:
2017 * src/maemo/easysetup/modest-validating-entry.c:
2018 * src/maemo/easysetup/modest-validating-entry.h:
2019 * src/maemo/modest-account-settings-dialog.c:
2020 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2021 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2022 widgets/ because they are used outside of easysetup too. After checking in,
2023 svn will allow me to rename them too.
2025 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2027 * src/gnome/modest-msg-edit-window.c:
2028 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2029 linker error, to fix the build on the GNOME platform.
2030 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2031 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2032 ifdefed out to avoid a warning.
2034 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2036 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2037 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2038 some alternative for GTK+ 2.6.
2040 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2042 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2044 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2045 specified for EmailAccountsDialog in UI spec.
2047 * src/maemo/easysetup/modest-easysetup-wizard.c:
2048 * src/maemo/easysetup/modest-easysetup-wizard.h:
2049 * src/maemo/modest-account-settings-dialog.c:
2050 * src/maemo/modest-account-settings-dialog.h:
2051 Reuse a member window widget for the connection-specific SMTP server accounts,
2052 so we can tell it to create/save the accounts only if we actually save changes.
2054 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2055 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2056 (modest_connection_specific_smtp_edit_window_get_settings):
2057 Return a struct instance for temporarily remembering the entered data.
2059 * src/maemo/modest-connection-specific-smtp-window.h:
2060 * src/maemo/modest-connection-specific-smtp-window.c:
2061 (modest_connection_specific_smtp_window_finalize),
2062 (modest_connection_specific_smtp_window_fill_with_connections),
2064 (modest_connection_specific_smtp_window_save_server_accounts),
2065 (update_model_server_names): Do not actually save data until asked,
2066 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2068 (on_selection_changed),
2069 (modest_connection_specific_smtp_window_init): Disable the edit
2070 button when nothing is selected.
2072 * src/modest-account-mgr-helpers.c:
2073 * src/modest-account-mgr-helpers.h:
2074 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2077 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2079 * src/modest-account-mgr-helpers.h:
2080 * src/modest-account-mgr-helpers.c:
2081 (modest_account_mgr_get_unused_account_name),
2082 (modest_account_mgr_get_unused_account_display_name): Added these
2083 utility functions, to avoid code duplication.
2085 * src/maemo/easysetup/modest-easysetup-wizard.c:
2086 (create_page_account_details), (create_account):
2087 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2088 (on_combo_security_changed),
2089 (modest_connection_specific_smtp_edit_window_init),
2090 (modest_connection_specific_smtp_edit_window_save_settings):
2091 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2092 * src/maemo/modest-connection-specific-smtp-window.c:
2093 (modest_connection_specific_smtp_window_finalize),
2094 (modest_connection_specific_smtp_window_fill_with_connections),
2095 (on_button_edit), (modest_connection_specific_smtp_window_init):
2096 * src/maemo/modest-connection-specific-smtp-window.h:
2097 Implementing saving of connection-specific server accounts.
2099 But I need to refactor this so we can save the data for each
2100 possible connection-specific account and only actually create the server accounts
2101 when the easysetup finished, or the OK button is pressed on the account settings
2104 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2107 (on_combo_security_changed):
2108 (modest_connection_specific_smtp_edit_window_init):
2109 Auto-fill the port number as in the account settings.
2111 (modest_connection_specific_smtp_edit_window_set_connection):
2112 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2113 * src/maemo/modest-connection-specific-smtp-window.c:
2114 (fill_with_connections), (on_button_edit),
2115 (modest_connection_specific_smtp_window_init):
2116 Turn the edit window into a dialog to simplify the code, and
2117 set a WM hint as in a GtkDialog, because only a popup can be on top of
2118 another window in Maemo, and popups usually have no WM decoration.
2120 * src/modest-defs.h:
2121 * src/modest-account-mgr-helpers.c:
2122 (modest_account_mgr_set_connection_specific_smtp),
2123 (modest_account_mgr_remove_connection_specific_smtp),
2124 (modest_account_mgr_get_connection_specific_smtp):
2125 * src/modest-account-mgr-helpers.h: Some functions to write the
2126 connection-specific SMTP server information. Not yet used.
2129 * src/widgets/modest-folder-view.c: (text_cell_data):
2130 Fix a warning about an uninitialized variable.
2131 (on_configuration_key_changed): Put an #ifdef around the use
2132 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2134 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2136 * src/maemo/modest-account-settings-dialog.h:
2137 * src/maemo/modest-account-settings-dialog.c:
2138 Added connect_for_modified() utility function to mark the new modified boolean.
2140 (create_page_account_details), (create_page_user_details),
2141 (create_page_incoming), (create_page_outgoing), (on_response),
2142 (modest_account_settings_dialog_init),
2143 (modest_account_settings_dialog_set_account_name):
2144 Only warn about unsaved changes when there are actually unsaved changes.
2146 * src/modest-account-mgr-helpers.c:
2147 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2148 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2149 to get the data from there in future.
2151 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2153 * src/modest-defs.h:
2155 * src/modest-account-mgr-helpers.h:
2156 * src/modest-account-mgr-helpers.c:
2157 Store the security account setting in a single conf key instead of using
2158 the options list, so that the list is left for just the to-be-removed camel hack,
2159 and because gconf_client_set_list() is failing for some reason.
2161 * src/modest-account-mgr.c:
2162 (modest_account_mgr_add_server_account):
2163 * src/maemo/modest-account-settings-dialog.c:
2164 (modest_account_settings_dialog_set_account_name),
2165 (save_configuration): Use the renamed functions.
2168 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2170 * src/widgets/Makefile.am:
2171 * src/widgets/modest-limit-retrieve-combo-box.c:
2172 * src/widgets/modest-limit-retrieve-combo-box.h:
2173 * src/widgets/modest-retrieve-combo-box.c:
2174 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2175 the account settings dialog.
2177 * src/modest-defs.h:
2178 * src/modest-account-mgr-helpers.h:
2179 * src/modest-account-mgr-helpers.c:
2180 (modest_server_account_get_option_secure_auth),
2181 (modest_server_account_set_option_secure_auth):
2182 * src/modest-account-mgr.c:
2183 (modest_account_mgr_add_server_account):
2184 Use the existing AUTH_MECH conf key for the secure-auth setting,
2185 instead of putting it in the list options, because this was actually used already.
2187 * src/maemo/modest-account-settings-dialog.c:
2188 (create_page_account_details),
2189 (modest_account_settings_dialog_set_account_name),
2190 (save_configuration):
2191 * src/maemo/modest-account-settings-dialog.h:
2192 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2193 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2195 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2197 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2198 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2199 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2201 * src/modest-defs.h:
2202 * src/maemo/modest-account-settings-dialog.c:
2203 (create_page_incoming), (on_combo_outgoing_security_changed),
2204 (on_combo_incoming_security_changed), (create_page_outgoing),
2205 (modest_account_settings_dialog_set_account_name),
2206 (save_configuration): Load/Save the port number, and change it when the
2207 security combo changes, to suitable defaults.
2209 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2211 * src/modest-account-mgr.c:
2212 (modest_account_mgr_add_server_account): Set the security and secure-auth
2213 options, and add a comment saying that the other camel-specific options should be
2216 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2218 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2220 * src/modest-tny-account-store.c: (account_list_free),
2221 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2222 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2225 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2227 * src/modest-protocol-info.c:
2228 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2229 is required by our UI spec. Maybe something in our implementation will use this eventually.
2230 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2231 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2232 instead of the previous 0 placeholder.
2234 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2235 secure-auth settings.
2236 * src/modest-account-mgr-helpers.h:
2237 * src/modest-account-mgr-helpers.c:
2238 (modest_server_account_data_get_option_secure_auth),
2239 (modest_server_account_set_option_secure_auth),
2240 (modest_server_account_data_get_option_security),
2241 (modest_server_account_set_option_security): Added this API for getting and setting the security
2242 and secure-auth settings.
2244 * src/maemo/modest-account-settings-dialog.h:
2245 * src/maemo/modest-account-settings-dialog.c:
2246 (modest_account_settings_dialog_finalize), (check_data),
2247 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2248 about changing titles.
2249 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2250 (save_configuration): Save the security and secure-auth settings.
2252 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2253 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2255 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2257 * src/modest-defs.h:
2258 * src/modest-account-mgr.c:
2259 (modest_account_mgr_add_server_account):
2260 Added and used defines for the options key and value pair strings,
2261 that are used so far, though they do not seem to correspond to anything in our
2262 UI specs or ModestProtocol enum.
2264 * src/modest-account-mgr-helpers.h:
2265 * src/modest-account-mgr-helpers.c:
2266 (compare_option_strings_for_name),
2267 (modest_server_account_data_get_option_value),
2268 (modest_server_account_data_get_option_bool),
2269 (modest_account_mgr_get_server_account_option):
2270 Added helper functions for parsing the options GSList.
2272 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2274 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2275 display name is based on the supplied account name.
2276 * src/modest-account-mgr.c:
2277 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2278 with an inefficient, but good-enough, implementation.
2280 * src/maemo/easysetup/modest-easysetup-wizard.c:
2281 (create_page_account_details), (on_before_next), (create_account):
2282 Check for existing display names rather than (non-user-visible) account names, and just
2283 create and set a unique account name at the end.
2285 * src/maemo/modest-account-settings-dialog.c:
2286 (modest_account_settings_dialog_init),
2287 (modest_account_settings_dialog_set_account_name),
2288 (create_page_incoming): Show the display name, instead of the account name.
2289 (on_response): Do some (not all) extra checks, as in the UI spec.
2290 (save_configuration): Save the display name if it was changed.
2292 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2294 * po/en_GB.po: Added needed logical ID and translation.
2295 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2296 (init_view): Made the is-default column clicking work.
2298 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2301 * src/maemo/easysetup/Makefile.am:
2302 * src/maemo/easysetup/modest-easysetup-wizard.c:
2303 (modest_easysetup_wizard_dialog_init):
2304 * src/maemo/easysetup/provider-data-test.keyfile:
2305 * src/maemo/easysetup/provider-data.keyfile:
2306 Moved the provider data file to the new modest-providers-data package and used it from there.
2308 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2310 * src/modest-local-folder-info.c:
2311 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2312 N_() was already used on the static strings, but this just marks it for translation without
2313 using the translation.
2315 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2317 * src/maemo/modest-account-settings-dialog.c:
2318 (create_page_incoming),
2319 (modest_account_settings_dialog_set_account_name):
2320 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2321 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2322 I will do this if nobody else gets there first.
2324 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2326 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2327 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2328 save the security stuff.
2330 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2332 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2333 Set the email address and user fullname, which I now see must be
2336 * src/maemo/modest-account-settings-dialog.h:
2337 * src/maemo/modest-account-settings-dialog.c:
2339 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2340 leave-on-server and authentication.
2341 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2344 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2347 * src/maemo/modest-account-settings-dialog.c:
2348 * src/maemo/modest-account-settings-dialog.h:
2349 Most (but not all) of the widgets are now present as specified by the UI spec.
2350 No changes are yet saved, and some details are not properly shown yet.
2352 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2354 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2356 * src/maemo/Makefile.am:
2357 * src/maemo/modest-account-settings-dialog.c:
2358 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2359 an existing account. Doesn't do much yet.
2361 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2362 Open the accounts settings dialog when Edit is clicked.
2364 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2366 * src/maemo/easysetup/Makefile.am:
2367 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2369 * src/maemo/easysetup/modest-easysetup-wizard.c:
2370 (modest_easysetup_wizard_dialog_init):
2371 Try to get the source directory from the build system,
2372 instead of hard-coding "./" into the source code, when opening our local
2373 copies of the configuration files.
2374 But this still fails when opening the wizard from the Accounts window,
2375 maybe because the working directory seems to change at runtime.
2376 So the wizard will fail the second time unless you copy the files into their
2377 proper locations - see the stdout warnings for the paths.
2379 (create_page_account_details),(on_before_next):
2380 Check for existing non-server accounts instead of server accounts,
2381 so the default account name is useful again, and to prevent trying to
2384 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2385 Show the wizard when New is clicked.
2387 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2388 (init_view): Show the column headers, and show the columns that are
2389 specified in the UI specs. However, something in Maemo's GTK+ prevents
2390 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2391 change the default account. This is despite unsetting the special properties.
2393 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2395 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2396 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2397 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2398 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2399 to make that clearer.
2400 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2402 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2404 * src/maemo/modest-account-view-window.c:
2405 (modest_account_view_window_init),
2406 (modest_account_view_window_new):
2407 Use the same buttons as specified in the
2408 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2409 the existing widgets, which never had a chance of working.
2410 Put the ModestAccountView treeview in a scrolled window.
2411 Do not repeat the initialization in both _init() and _new().
2413 * src/widgets/modest-account-view.c: (update_account_view):
2414 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2415 this widget and window shows no accounts.
2417 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2419 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2421 * src/maemo/easysetup/modest-easysetup-wizard.c:
2422 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2423 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2424 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2427 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2428 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2429 accounts exist yet, as in the UI spec.
2431 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2433 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2435 * src/maemo/Makefile.am:
2436 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2437 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2438 New window for editing connection-specific smtp details.
2439 Not fully implemented.
2441 * src/maemo/modest-connection-specific-smtp-window.c:
2442 (modest_connection_specific_smtp_window_finalize) :
2443 unref the tree model.
2444 (on_button_edit): Show the edit window.
2446 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2448 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2451 * src/maemo/Makefile.am:
2452 * src/maemo/modest-connection-specific-smtp-window.c:
2453 * src/maemo/modest-connection-specific-smtp-window.h:
2454 New window for showing the list of connections, for connection-specific
2455 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2456 * src/maemo/easysetup/modest-easysetup-wizard.c:
2457 (create_page_custom_outgoing): Show the new window when the button is clicked.
2459 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2462 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2463 * src/maemo/modest-msg-edit-window.c:
2464 (modest_msg_edit_window_insert_image):
2465 * src/modest-conf.c: (modest_conf_key_escape):
2466 * src/modest-mail-operation.c:
2467 (modest_mail_operation_send_new_mail):
2468 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2469 (modest_ui_actions_on_new_account):
2470 * src/widgets/modest-attachment-view.c: (update_filename_request):
2471 * src/widgets/modest-mail-header-view.c:
2472 Corrected warnings that were breaking the build, by commenting out unused variables,
2473 and a function, and by including a header.
2475 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2477 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2478 so we can #ifdef around platform-specific code when necessary.
2479 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2480 to allow this to build for the GNOME platform too.
2482 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2484 * src/maemo/easysetup/modest-easysetup-wizard.c:
2485 Added util_increment_name() and used it in create_page_account_details()
2486 to make sure that the default account name is always a new name.
2488 (modest_easysetup_wizard_dialog_init),
2489 (set_default_custom_servernames): Some minor memory management fixes.
2491 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2495 * src/modest-runtime.c: (init_i18n): Restored the translation
2496 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2497 are defined in config.h, and the translations are installed.
2499 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2500 is defined for translation.
2502 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2504 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2506 * src/maemo/easysetup/modest-easysetup-wizard.c:
2507 (modest_easysetup_wizard_dialog_init):
2508 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2509 Use realistic paths (though they should use $prefix generically) to the
2510 mcc_mapping and provider-data.keyfile files which might work when they
2511 are installed by the future version of the operator-wizard package,
2512 and then fallback to paths in our source code, with an explanatory
2515 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2519 * src/maemo/Makefile.am:
2520 * src/maemo/easysetup/: Added files from the previously-exernal
2521 osso-modest-easysetup.
2522 * src/maemo/modest-main-window-ui.h:
2523 * src/modest-ui-actions.c:
2524 * src/modest-ui-actions.h:
2525 Added modest_ui_actions_on_new_account() as a signal handler for the
2526 New Account menu item. It shows the easysetup wizard.
2527 * po/en_GB.po: Added additional needed logical IDs and translations.
2529 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2530 Apparently ChangeLog is not used for some vague Nokia legal reasons.