1 2007-08-28 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-search.c: (check_and_wait_for_account_is_online):
4 Actually pass the account to the timeout callback.
6 2007-08-28 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-search.c: (on_timeout_check_account_is_online):
9 Added some debug output to help me debug a problem on the N800.
10 (check_and_wait_for_account_is_online): Fail immediately if the
12 modest_search_all_accounts(): Try the search even if the account does
13 not seem to be online, because this can work sometimes, and should work
14 with the cache if there is no active libconic connection.
16 2007-08-27 Armin Burgmeier <armin@openismus.com>
18 * src/modest-tny-send-queue.c: Implement TnyFolderObserver and
19 observe outbox for added messages to assign them a status. Previously,
20 this was done in modest_tny_send_queue_add(), but the message id might
21 not yet be known at that point. This reduces warnings when sending
22 mail, though I am not sure how this even worked before.
24 2007-08-27 Murray Cumming <murrayc@murrayc.com>
26 * src/maemo/modest-account-settings-dialog.c:
27 (modest_account_settings_dialog_init):
28 * src/maemo/modest-connection-specific-smtp-edit-window.c:
29 (modest_connection_specific_smtp_edit_window_init):
30 * src/maemo/modest-connection-specific-smtp-window.c:
31 (modest_connection_specific_smtp_window_init):
32 * src/maemo/modest-maemo-utils.c:
33 (modest_maemo_utils_get_supported_secure_authentication_methods):
34 * src/maemo/modest-platform.c:
35 (modest_platform_run_folder_name_dialog):
36 * src/maemo/modest-signature-editor-dialog.c:
37 (modest_signature_editor_dialog_init):
38 * src/modest-ui-actions.c: (modest_ui_actions_on_item_not_found),
39 (modest_ui_actions_on_password_requested), (create_move_to_dialog):
40 * src/widgets/modest-global-settings-dialog.c:
41 (modest_global_settings_dialog_init):
42 Replace all uses of GTK_STOCK_OK (and GTK_BUTTONS_OK) with
44 GTK_STOCK_CANCEL with mcen_bd_dialog_cancel,
45 GTK_STOCK_EDIT with mcen_bd_edit, and
46 GTK_STOCK_CLOSE with mcen_bd_close,
47 to fix projects.maemo.org bug NB#64995.
48 I strongly believe that Maemo's GTK+ should have the wanted translations
49 instead of duplicating this in each application and complicating the code.
51 2007-08-27 Armin Burgmeier <armin@openismus.com>
53 * src/maemo/modest-msg-edit-window.c: Fixed a crash due to endless
54 recursion when entering text in the subject field.
56 2007-08-27 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-search.c: Added check_and_wait_for_account_is_online(),
59 which checks every second, 10 times, to wait until the account is online
60 so that we can use it, if the account is in the process of going online.
61 (modest_search_all_accounts): Use check_and_wait_for_account_is_online()
62 so that searching works even when the application was not yet started before.
63 This fixes projects.maemo.org bug NB#63784, at least in scratchbox.
65 2007-08-24 Armin Burgmeier <armin@openismus.com>
67 * src/modest-widget-memory.c: Always show the default account when the
68 application is started, as stated in the UI spec. This fixes
69 projects.maemo.org bug NB#66630.
71 2007-08-24 Armin Burgmeier <armin@openismus.com>
73 * src/maemo/modest-platform.c:
74 (modest_platform_run_rename_folder_dialog): Use logical IDs instead of
75 english text for strings in the rename folder dialog, fixing
76 projects.maemo.org bug NB#66338.
78 2007-08-22 Armin Burgmeier <armin@openismus.com>
80 * src/widgets/modest-account-view.c: Fix for bora by using
81 MODEST_HAVE_HILDON0_WIDGETS instead of MODEST_HILDON_VERSION_0. The
82 latter seems not be used anymore.
84 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c: Some
87 * src/maemo/modest-main-window.c: Update menu items when the default
88 account changes so that the current default account is always bolded.
89 This fixes maemo.projects.org bug NB#66173.
91 2007-08-17 Murray Cumming <murrayc@murrayc.com>
93 * src/dbus_api/modest-dbus-callbacks.c:
94 (on_dbus_method_get_folders): Avoid trying to get the account name
95 when there are no accounts, to avoid critical g_warnings, fixing
96 projects.maemo.org bug NB#65574.
98 2007-08-17 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg):
101 Use modest_account_mgr_get_signature() instead of accessing gconf
102 directly, to slightly simplify the code.
103 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
104 Append the signature also when opening via other applications,
105 fixing projects.maemo.org bug NB#65828.
107 2007-08-17 Murray Cumming <murrayc@murrayc.com>
109 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
110 Check for NULLs to prevent a crash when opening an email that is
111 an attachment in another email, fixing projects.maemo.org bug
114 2007-08-17 Murray Cumming <murrayc@murrayc.com>
116 * src/modest-ui-dimming-rules.c:
117 (modest_ui_dimming_rules_on_view_window_move_to):
118 Enable the Move To toolbar button for search results, fixing the
119 last part of projects.maemo.org bug NB#63807.
121 2007-08-17 Murray Cumming <murrayc@murrayc.com>
123 * src/dbus_api/modest-dbus-callbacks.c:
124 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
125 because this is called from idle handlers, to fix hangs afte the
127 (find_message_by_url): Added a TODO comment about a crash that
128 happens when tinymail was built with DBC checks.
130 2007-08-16 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-search.c: (modest_search_folder):
133 * src/modest-search.h: Rename ModestSearch::before to start_date
134 and after to end_date, using the same names as the libogs struct
136 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
137 The start_date and end_date were swapped in the check. This
138 fixes date range searches, fixing projects.maemo.org bug NB#63407.
140 2007-08-16 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/modest-account-view-window.c:
143 Added (check_for_active_acount).
144 (on_delete_button_clicked), (on_edit_button_clicked):
145 When an account is doing something (such as refreshing),
146 show the same warning for account deletion as for account
147 editing, to fix projects.maemo.org bug NB#64588.
149 2007-08-16 Murray Cumming <murrayc@murrayc.com>
151 * src/widgets/modest-msg-view-window.h:
152 * src/gnome/modest-msg-view-window.c:
153 * src/maemo/modest-msg-view-window.c:
154 Added modest_msg_view_window_construct().
155 (modest_msg_view_window_new_with_header_model),
156 Added modest_msg_view_window_new_for_search_result),
157 Renamed modest_msg_view_window_new() to
158 modest_msg_view_window_new_for_attachment(),
159 and modest_msg_view_window_is_search_result(),
160 so we can explicitly know that the window is for an
161 attachment or a search result or a message from the list.
163 (modest_msg_view_window_view_attachment):
164 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
165 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
166 Use modest_msg_view_window_new_for_search_result().
168 * src/modest-ui-dimming-rules.c:
169 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
170 for search results, fixing projects.maemo.org bug NB#63811.
172 2007-08-16 Armin Burgmeier <armin@openismus.com>
174 * src/modest-ui-actions.c: Show a banner instead of a dialog when
175 renaming a folder fails, to stay consistent with what happens when
176 creating a folder fails.
178 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
179 slightly country loading from the mmc_mappings file, fixed a memory
182 2007-08-16 Murray Cumming <murrayc@murrayc.com>
184 * src/modest-tny-account-store.c: (volume_path_is_mounted):
185 Check the GnomeVFSVolume activation path instead of the device path,
186 so that the memory card is really really shown in the UI.
188 2007-08-16 Murray Cumming <murrayc@murrayc.com>
190 * src/maemo/easysetup/modest-easysetup-wizard.c:
191 (get_entered_account_title), (on_before_next), (entry_is_empty),
193 * src/maemo/modest-account-settings-dialog.c:
194 (get_entered_account_title), (on_button_signature), (check_data),
195 (save_configuration), (entry_is_empty):
196 Strip the account title of whitespace at the start and end before
197 using it or checking it. This means that an all-whitespace title
198 is not allowed, fixing projects.maemo.org bug NB#64977.
200 2007-08-15 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-ui-actions.h:
203 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
204 to modest_run_account_setup_wizard() and made it public.
205 * src/dbus_api/modest-dbus-callbacks.c:
206 (check_and_offer_account_creation), (on_idle_mail_to),
207 (on_idle_compose_mail), (on_idle_open_default_inbox):
208 Offer account creation if necessary, fixing projects.maemo.org
211 2007-08-15 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-ui-actions.c: (run_account_setup_wizard):
214 Return a gboolean to indicate success.
215 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
216 (modest_ui_actions_on_send): When offering account creation, only
217 give up (return) if account creation failed. Otherwise continue
218 with the original request. This fixed projects.maemo.org bug
221 2007-08-15 Murray Cumming <murrayc@murrayc.com>
223 * src/widgets/modest-recpt-editor.c:
224 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
225 to fix projects.maemo.org bug NB#63789.
227 2007-08-15 Murray Cumming <murrayc@murrayc.com>
229 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
230 (modest_tny_account_store_new): Properly detect the memory card at
231 startup, and add an account for it.
233 2007-08-14 Murray Cumming <murrayc@murrayc.com>
235 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
236 Commented out the MMC code again because it mistakenly detects
237 the card even when it isn't inserted.
239 2007-08-14 Murray Cumming <murrayc@murrayc.com>
241 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
242 Renabled the call to add_mmc_account() because I do not believe
243 it could be the cause of the mentioned hang (in scratchbox, where
244 there is no memory card), and because I have tested that it works
247 2007-08-14 Murray Cumming <murrayc@murrayc.com>
249 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
250 Comment out part of the last commit because it apparently causes
253 2007-08-14 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-tny-account-store.c: Added the add_mmc_account()
256 function to save some copy/pasting.
257 (modest_tny_account_store_new): If the memory card is mounted,
258 create an account for it at the start, instead of waiting for the
259 user to unmount it and mount it.
261 2007-08-13 Murray Cumming <murrayc@murrayc.com>
263 * src/widgets/modest-account-view.c: (on_account_changed):
264 Do not try to use the human-readable TnyAccount name instead of the
265 ID of the modest account to get the transport account. And unref
266 the transport account. This prevents a g_warning(), and a possible
269 2007-08-13 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-platform.c:
272 (modest_platform_set_update_interval): Handle the new
273 alarmd error to warn when alarmd is not running, as is the case in
274 scratchbox for me now because
275 "Module /usr/lib/alarmd/libretu.so initialization failed"
277 2007-08-13 Murray Cumming <murrayc@murrayc.com>
279 * src/widgets/modest-header-view-render.c:
280 (_modest_header_view_compact_header_cell_data):
281 NULL some strings after freeing them, trying to deal with
282 the double deletion found in projects.maemo.org bug 64183,
283 probably having no effect.
285 2007-08-13 Murray Cumming <murrayc@murrayc.com>
287 * src/maemo/modest-account-settings-dialog.c:
288 (create_page_incoming), (create_page_outgoing): Use a define
289 for the min and max port numbers.
291 (check_hildon_number_editor_and_warn_value_not_in_range),
292 (check_data): Do an extra check for an invalid port number, as needed
293 in projects.maemo.org bug #64275, when the number is cleared, but this
294 does not work due to bugs.maemo.org bug #1806.
296 2007-08-13 Murray Cumming <murrayc@murrayc.com>
298 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
299 Comment out the debug warning about the unexpected D-Bus methods.
300 They are just annoying now.
301 * src/maemo/modest-platform.c:
302 (modest_platform_set_update_interval): Correct the D-Bus path, instead
303 of using a file path, though it did not seem to break things before.
304 It might be needed now:
305 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
306 modest is not already running. This is the behaviour of the old client, and
307 Mox says it is what we should do for modest.
308 This closes projects.maemo.org bug NB#64327.
310 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
312 * src/modest-text-utils.c:
313 Fixed invalid jump due to incorrect string/pointer
315 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
318 2007-08-01 Murray Cumming <murrayc@murrayc.com>
320 * src/modest-account-mgr-helpers.h:
321 * src/modest-account-mgr-helpers.c:
322 Added modest_account_mgr_get_first_account_name(),
323 using code from modest_account_mgr_set_first_account_as_default().
325 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
326 (account_number_changed): Call set_at_least_one_account_visible() so that
327 the first account is visible when first added, without the user having to
329 I do wonder how this worked before.
331 2007-08-01 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account-store.c: (show_password_warning_only),
334 (show_wrong_password), (request_password_and_wait), (get_password),
335 (modest_tny_account_store_alert): Remove the (incomplete anyway)
336 attempts to show UI only in the main context, which used g_idle_add()
337 and mainloops, because tinymail now guarantees that it only calls these
338 callbacks in the mainloop with the gdk lock. This makes everything much
341 2007-08-01 Murray Cumming <murrayc@murrayc.com>
343 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
344 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
345 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
346 error dialog, instead of ignoring it.
348 2007-08-01 Murray Cumming <murrayc@murrayc.com>
350 * src/maemo/modest-msg-view-window.c:
351 (modest_msg_view_window_get_header),
352 (modest_msg_view_window_last_message_selected):
353 Added comments to explain the use of priv->header_model.
354 * src/modest-ui-dimming-rules.c:
355 (modest_ui_dimming_rules_on_open_msg),
356 (modest_ui_dimming_rules_on_mark_as_read_msg),
357 (modest_ui_dimming_rules_on_mark_as_unread_msg),
358 (modest_ui_dimming_rules_on_remove_attachments),
359 (_invalid_attach_selected), (_selected_msg_marked_as):
360 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
361 and changed the parameter to a ModestMainWindow to make it clearer that
362 it never uses any other kind of window.
363 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
364 instead of the selected message.
365 I notice that much of the dimming code and the ModestMsgViewWindow code
366 hard-codes the assumption that the viewed message is always selected in
367 the header view. This does not seem wise or simple.
369 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
370 examine the actual message instead of whatever might be selected
371 in the header view. This stops the delete toolbar button and menu item
372 from being dimmed when opening a message view the search UI,
373 partially fixing projects.maemo.org bug NB#63811.
375 However, when actually deleting, I now get this warning:
376 "tny_header_set_flags: This is a header instance for a new message.
377 Only priority and attachment flags are supported"
379 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
381 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
383 Show account wizard if no accounts are defined while sending
384 (automatic sending after the account wizard finished does not
385 work because it takes some time until the account manager
386 synchronizes everything. (projects.maemo.org NB#62792)
388 2007-07-30 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-tny-account-store.c: (on_account_removed),
391 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
392 account is removed from the View menu. We have TnyAccountStore
393 and ModestTnyAccountStore signals that seem very similar, but this
394 seems to work for now.
396 * src/maemo/modest-main-window.c:
397 (on_show_account_action_activated): Prevent dereference
398 of a NULL if the accoutn does not really exist, though that
399 should not happen anymore.
401 This fixes projects.maemo.org bug NB#64606.
403 2007-07-30 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-ui-actions.c: (run_account_setup_wizard),
406 (modest_ui_actions_on_accounts): Revert a change that set these
407 to modal dialogs, freezing the UI when they show secondary dialogs.
408 This fixed projects.maemo.org bug NB#64519.
410 2007-07-27 Murray Cumming <murrayc@murrayc.com>
412 * src/widgets/modest-header-view-render.c:
413 (_modest_header_view_compact_header_cell_data):
414 Some checks and initialization to try to deal with a crash,
415 probably ineffective.
417 2007-07-27 Murray Cumming <murrayc@murrayc.com>
419 * src/maemo/modest-maemo-utils.c:
420 (modest_maemo_utils_get_supported_secure_authentication_methods):
421 Make sure that we have a connection, asking the user for one
423 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
424 Check for a connection before showing the wizard, because
425 the wizard needs a connection to check for server capabilities.
427 2007-07-27 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/modest-account-view-window.c:
430 (on_new_button_clicked): Remember the wizard dialog instance,
431 so we can just present it again if necessary. This prevents
432 multiple windows from appearing if you click again quickly on the
433 New button before the dialog appears, fixing projects.maemo.org
436 2007-07-27 Murray Cumming <murrayc@murrayc.com>
438 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
439 Offer a connection dialog if there is no connection when
440 starting modest. This should fix projects.maemo.org bug NB#61134.
442 2007-07-27 Murray Cumming <murrayc@murrayc.com>
444 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
445 Reverted my last commit. I was able to fix the build by doing
446 apt-get install wpeditor0 (replacing other wpeditor packages) and
447 an explicit apt-get install wpeditor-dev to upgrade the -dev
450 2007-07-27 Murray Cumming <murrayc@murrayc.com>
452 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
453 Commented out the use of wp_text_buffer_replace_image()
454 because it does not exist, to break the build. Added a TODO for it.
456 2007-07-26 Murray Cumming <murrayc@murrayc.com>
458 * src/modest-tny-account-store.c: (recreate_all_accounts):
459 Recreate them even if they were NULL before. I guess something
460 else was already creating them before, or this would never
462 (modest_tny_account_store_get_server_account): Make sure that
463 the tny accounts have been created before trying to find one.
464 This allows libmodest_dbus_client_compose_mail() to work
465 when the UI is not yet visible.
466 This is probably useful in other cases too.
468 (get_password): When the password is wrong after it is entered
469 in the protected password dialog, show an info banner (in an
470 idle handler) before showing the protected password dialog
473 2007-07-26 Murray Cumming <murrayc@murrayc.com>
475 * src/modest-ui-actions.h:
476 * src/modest-ui-actions.c: Added
477 modest_do_refresh_current_folder() containing some code from
478 modest_ui_actions_on_send_receive().
479 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
480 Call modest_do_refresh_current_folder() before refreshing the
481 requested account, as in modest_ui_actions_on_send_receive().
482 This is strange, but seems to be necessary to show new mails.
483 Now new emails are finally visible in the UI when downloaded
484 via the automatic update interval, fixing bug NB#57458.
485 This also works because bug NB#57458 has been fixed somehow.
487 2007-07-26 Murray Cumming <murrayc@murrayc.com>
489 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
490 printf more details when we get unhandled D-Bus methods, because
493 * src/modest-mail-operation.c: (update_account_thread):
494 Comment out the tny_camel_pop_store_account_reconnect(), because this
495 is apparently no longer needed, and it did not work before anyway.
496 See the comment in the code.
498 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
499 by checking the header flags. This fixes projects.maemo.org bug
502 2007-07-25 Murray Cumming <murrayc@murrayc.com>
504 * src/maemo/modest-maemo-utils.h:
505 * src/maemo/modest-maemo-utils.c: Added
506 modest_maemo_show_information_note_in_main_context_and_forget().
507 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
508 Use the new function to show simple error dialogs in the main
509 context, though question dialogs are still in the current context,
510 which is unfortunately usually not the main context. This should
513 2007-07-25 Murray Cumming <murrayc@murrayc.com>
515 * src/modest-tny-account-store.c: (get_password):
516 Never save the entered username and password in gconf,
517 because the UI spec says we should not. This helps
518 slightly with projects.maemo.org bug NB#63671.
520 2007-07-25 Murray Cumming <murrayc@murrayc.com>
522 * src/widgets/modest-msg-edit-window.h:
523 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
524 Moved some code here to make it simpler.
525 (modest_msg_edit_window_attach_file_one): Renamed from
526 modest_msg_edit_window_attach_file_interactive().
527 (modest_msg_edit_window_offer_attach_file): Renamed from
528 modest_msg_edit_window_attach_file() and used
529 modest_msg_edit_window_attach_file_one() instead of
530 copy/pasting the code. The old code for one was not using
531 GnomeVFS. This allows use of smb:// URLs when using send-as
532 from external applications, fixing bug NB#63741.
534 (modest_msg_edit_window_insert_image),
535 (modest_msg_edit_window_add_attachment_clicked):
536 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
537 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
538 Adapted to the new function names.
540 2007-07-25 Murray Cumming <murrayc@murrayc.com>
542 (modest_platform_set_update_interval): Set the alarm recurrence
543 fields so that auto-update does not just happen the first time.
544 This should have fixed projects.maemo.org bug NB#63938.
546 When this happens you can see a printf when the D-Bus method is
548 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
550 However, I do not actually seem to get new POP messages even when
551 clicking the refresh button manually. A restart gets them.
552 This might be a problem in today's tinymail only.
554 2007-07-24 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/modest-maemo-global-settings-dialog.c:
557 (current_connection):
558 Avoid a crash (probably only in scratchbox) when strcmp()ing a
559 NULL when closing the dialog.
561 2007-07-24 Murray Cumming <murrayc@murrayc.com>
563 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
564 Remove the hacky send/receive that didn't work, and instead
565 refilter the treemodel to make the deleted email really vanish from
566 the UI (though the delete-from-menu code does has commented out
567 the code that does that). This fixes projects.maemo.org bug
570 2007-07-24 Murray Cumming <murrayc@murrayc.com>
572 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
573 Try a couple of tricks to force the treeview to update (
574 poke the folder, and do a send/receive refresh), but the deleted
575 email still appears with a strike-through instead of really being
578 2007-07-23 Murray Cumming <murrayc@murrayc.com>
580 * src/dbus_api/modest-dbus-callbacks.c:
581 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
582 because their ID is not human-readable (see the comment about
583 improvements needed to the osso-email-interface API) and
584 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
586 2007-07-23 Murray Cumming <murrayc@murrayc.com>
588 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
589 (add_folders_to_list), (on_dbus_method_get_folders),
590 (modest_dbus_req_filter):
591 * src/maemo/modest-maemo-utils.c:
592 (on_camel_account_get_supported_secure_authentication):
593 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
594 (on_header_view_focus_in):
595 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
596 * src/modest-formatter.c: (modest_formatter_create_body_part):
597 * src/modest-mail-operation.c: (recurse_folders),
598 (update_account_thread), (get_msgs_full_thread),
599 (modest_mail_operation_get_msgs_full),
600 (modest_mail_operation_xfer_msgs):
601 * src/modest-search.c: (search_mime_part_and_child_parts),
602 (modest_search_account), (modest_search_all_accounts):
603 * src/modest-tny-account.c:
604 (modest_tny_account_get_special_folder), (recurse_folders):
605 * src/modest-tny-local-folders-account.c:
606 (modest_tny_local_folders_account_query_passes):
607 * src/modest-tny-msg.c: (copy_mime_part),
608 (modest_tny_msg_find_body_part_from_mime_part):
609 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
610 (modest_tny_send_queue_try_to_send):
611 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
612 (_modest_ui_actions_open), (download_uncached_messages),
613 (reply_forward), (modest_ui_actions_on_copy),
614 (modest_ui_actions_on_details), (has_retrieved_msgs),
615 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
617 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
618 (_selected_msg_marked_as), (_msg_download_completed),
619 (_selected_msg_sent_in_progress):
620 * src/widgets/modest-attachments-view.c:
621 (modest_attachments_view_set_message):
622 * src/widgets/modest-msg-view.c: (find_cid_image):
623 * tests/check_folder-transfer.c: (find_folders):
624 * tests/check_update-account.c: (func):
625 * tests/dbus_api/test_get_folders.c: (main):
626 Checked all uses of tny_iterator_get_current(), making sure
627 that the object is unreferenced (3 or 4 places did not),
628 and adding checks for NULL.
630 2007-07-23 Murray Cumming <murrayc@murrayc.com>
632 * src/dbus_api/modest-dbus-callbacks.c:
633 (on_idle_open_default_inbox): Make sure that the application UI is
635 * src/maemo/easysetup/modest-easysetup-wizard.c:
636 (on_entry_invalid_character): Show the word whitespace instead
637 of (null) in the banner when whitespace was entered.
638 (show_error): Add a comment that this does not work in
639 Maemo Bora, though we do not know why.
641 2007-07-23 Murray Cumming <murrayc@murrayc.com>
643 * src/modest-tny-account.c:
644 (modest_tny_account_get_special_folder): Use an if instead of
645 an assert for when the parent account name is NULL, because this
646 might be causing a crash in projects.maemo.org bug 63192.
647 * src/modest-mail-operation.c:
648 (modest_mail_operation_send_new_mail_cb),
649 (modest_mail_operation_remove_folder): unref the folder that is
650 returned from modest_tny_account_get_special_folder().
652 2007-07-23 Murray Cumming <murrayc@murrayc.com>
654 * src/modest-ui-actions.c:
655 (modest_ui_actions_on_password_requested):
656 Show mail_ib_login_cancelled info banner when the user cancels
657 the protected password dialog, to fix projects.maemo.org
660 2007-07-23 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/modest-account-settings-dialog.c:
663 (create_page_outgoing): Put this page in a GtkScrolledWindow,
664 matching the UI mock-up in the UI spec, and allowing access
665 to all widgets even when the on-screen keyboard is active.
667 2007-07-23 Murray Cumming <murrayc@murrayc.com>
669 Reverted this previous commit from Johannes,
670 because the scrollbars are always visible and because
671 I think we only need it on onepage of the account
672 settings, not the account wizard.
673 (I wrote the wrong instructions in the bug.)
675 * src/maemo/easysetup/modest-easysetup-wizard.c:
676 Added scrollbars to account wizard dialog.
677 Fixed projects.maemo.org NB #62744
679 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
681 * src/maemo/easysetup/modest-easysetup-wizard.c:
682 (create_page_user_details):
683 Use auto-cap for name (projects.maemo.org NB#63716)
684 * src/widgets/modest-account-view.c: (on_account_busy_changed):
686 2007-07-22 Armin Burgmeier <armin@openismus.com>
688 * src/maemo/modest-ui-actions.c: Use current account instead of
689 default account for creating viewer windows, so that the viewer
690 window knows to which account the viewed message belongs.
692 * src/maemo/modest-msg-view-window.c: Destroy the window when the
693 corresponding account is deleted. This fixes projects.maemo.org bug
696 2007-07-18 Armin Burgmeier <armin@openismus.com>
698 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
699 the dialog close after entering an invalid port number and clicking
700 OK. This fixes projects.maemo.org bug NB#63602.
702 2007-07-18 Armin Burgmeier <armin@openismus.com>
704 * src/modest-tny-account-store.c:
705 (get_server_accounts): Set parent modest account name for each
706 connection-specific transport account so that special folders of such
707 an account can be looked up. This fixes a crash when changing account
708 settings. This might also be related to projects.maemo.org bug
711 2007-07-16 Armin Burgmeier <armin@openismus.com>
713 * src/modest-ui-actions.c: Added a button to create a folder to the
714 move-to dialog. This fixes projects.maemo.org bug NB#59863.
716 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
718 * src/maemo/easysetup/modest-easysetup-wizard.c:
719 Added scrollbars to account wizard dialog.
720 Fixed projects.maemo.org NB #62744
722 2007-07-16 Murray Cumming <murrayc@murrayc.com>
724 * src/widgets/modest-msg-view.h:
725 * src/widgets/modest-msg-view.c:
726 Added modest_msg_view_get_message_is_empty() but this needs
728 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
729 Check if there is any text in the message yet.
730 But this needs to be implemented properly.
731 (modest_msg_edit_window_toggle_find_toolbar):
732 * src/maemo/modest-msg-view-window.c:
733 (modest_msg_view_window_toggle_find_toolbar):
734 Show a banner warning if there is no text to search, when
735 trying to start a search. This partially fixes
736 projects.maemo.org bug NB#62350.
738 2007-07-13 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-mail-operation.c: (update_account_thread):
741 Initialized num_new_headers to fix the build.
743 2007-07-13 Murray Cumming <murrayc@murrayc.com>
745 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
746 Ignore modest accounts whose server accounts don't exist in gconf.
747 This prevents us trying to create TnyAccount instances for those
748 server accounts when the server account has been removed from gconf,
749 but the parent modest account has not yet been removed from modest.
750 I don't know why this is only noticeable now. It was probably just
751 a harmeless g_warning() anyway.
753 2007-07-13 Murray Cumming <murrayc@murrayc.com>
755 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
756 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
758 2007-07-12 Armin Burgmeier <armin@openismus.com>
760 * src/maemo/modest-main-window.c: Make default account appear bold
761 in view, tools/send & receive and toolbar/send & receive SCM menus.
762 This fixes projects.maemo.org bug NB#59010.
764 2007-07-12 Murray Cumming <murrayc@murrayc.com>
766 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
767 Add a short-cut, by checking if the folder store is an account.
768 This ensures that the Sort menu item and toolbar is dimmed for
769 the local-folders account root item, fixing
770 projects.maemo.org bug NB#62545.
772 2007-07-12 Murray Cumming <murrayc@murrayc.com>
774 * src/modest-tny-account-store.c: (get_password):
775 Show the password dialog (via the signal) only in the mainloop, via
776 an idle handler that we wait for. This could theoretically prevent
777 hangs, though I worry that it could introduce some too.
779 2007-07-12 Murray Cumming <murrayc@murrayc.com>
781 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
782 * src/maemo/modest-platform.c:
783 (modest_platform_connect_and_wait):
784 Take a TnyAccount* parameter and try to set it to online
785 (a TnyCamel-only API), because tinymail sets accounts to offline
786 when the user cancels a password dialog, and doesn't ask again until
787 it has been set to online.
788 However, this is commented out because it causes a hang now.
790 (modest_platform_connect_and_wait_if_network_account):
791 * src/modest-mail-operation.c:
792 (modest_mail_operation_update_account):
793 * src/modest-platform.h:
794 * src/modest-ui-actions.c: (_modest_ui_actions_open),
795 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
797 2007-07-12 Armin Burgmeier <armin@openismus.com>
799 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
801 * src/modest-mail-operation.c:
802 * src/modest-ui-actions.c: Check for already existing folder before
803 querying the server, show error message from camel if the request
804 still fails. This fixes projects.maemo.org bug NB#58701.
806 2007-07-12 Murray Cumming <murrayc@murrayc.com>
808 * src/modest-tny-account-store.h:
809 * src/modest-tny-account-store.c:
810 Added modest_tny_account_store_forget_password_in_memory(),
811 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
812 when creating a new account, so that new passwords will be used, instead of
813 us thinking that it's a second request as a result of a failed password again.
815 2007-07-12 Murray Cumming <murrayc@murrayc.com>
817 * src/dbus_api/modest-dbus-callbacks.c:
818 (on_idle_open_message): If the message is in drafts then open it
819 in an edit window instead of a view window. This fixes
820 projects.maemo.org bug NB#63005.
822 2007-07-12 Murray Cumming <murrayc@murrayc.com>
824 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
825 Avoided a harmless g_warning().
827 2007-07-12 Murray Cumming <murrayc@murrayc.com>
829 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
830 Pass the modest account name, not the TnyAccount display name to
831 modest_msg_view_window_new() so that the reply feature works,
832 fixing projects.maemo.org bug NB#62892.
834 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
835 (modest_msg_view_window_new_with_header_model):
836 * src/maemo/modest-msg-view-window.c:
837 (modest_msg_view_window_new_with_header_model),
838 (modest_msg_view_window_new):
839 * src/modest-ui-actions.c: (reply_forward):
840 * src/widgets/modest-msg-view-window.h:
841 * src/widgets/modest-window.c: (modest_window_set_active_account):
842 Rename an account parameter to modest_account_name to make this clearer.
844 2007-07-11 Murray Cumming <murrayc@murrayc.com>
846 * src/modest-ui-actions.h:
847 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
848 modest_do_message_delete().
849 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
850 Call modest_do_message_delete(), hoping that this would cause messages
851 to be really deleted from search instead of just marked with strike through.
852 Does not seem to help.
854 2007-07-11 Armin Burgmeier <armin@openismus.com>
856 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
857 priv->reselect to FALSE prior to calling
858 modest_folder_view_select_first_inbox_or_local() to prevent endless
859 recursion and thus a crash on startup.
861 2007-07-11 Armin Burgmeier <armin@openismus.com>
863 * src/maemo/modest-account-settings-dialog.h: Include
864 <gtk/gtknotebook.h> to fix the build (at least for me).
866 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
867 Use "New FolderN" as default suggested name if "New folder" already
868 exists, with N being the first free number, though never exceed "New
869 folder99" in which case we just fall back to "New Folder" even though
870 it already exists. This fixes projects.maemo.org bug NB#58663.
872 2007-07-11 Murray Cumming <murrayc@murrayc.com>
874 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
875 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
876 projects.maemo.org bug NB#62778.
878 2007-07-11 Murray Cumming <murrayc@murrayc.com>
880 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
881 Ignore the wrong (for now) secure-smtp setting in the presets -
882 just default to requiring secure authentication for SMTP, because
885 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
887 * src/widgets/modest-folder-view.c: (filter_row)
888 Do not show drafts folder (see UI specs)
890 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
892 * src/modest-ui-actions.c:
893 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
894 place and also not necessary.
896 * src/widgets/modest-folder-view.c: (filter_row)
897 Guess folder type and hide Sent & Outbox if necessary.
898 Fixed project.maemo.org NB#57328
900 2007-07-11 Murray Cumming <murrayc@murrayc.com>
902 * src/modest-ui-actions.h:
903 * src/modest-ui-actions.c:
904 (modest_ui_actions_on_delete_message):
905 Move some code into a new
906 modest_ui_actions_refresh_message_window_after_delete()
907 function so we can use it from elsewhere.
909 * src/dbus_api/modest-dbus-callbacks.c:
910 (on_idle_delete_message), (on_delete_message): Used an idle
911 handler, as we do for the other D-Bus method handlers.
912 Call modest_ui_actions_refresh_message_window_after_delete()
913 if the deleted message was open in a window. This fixed
914 projects.maemo.org bug NB#62862.
916 2007-07-11 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-main.c: (main): Only show the UI at the start if
919 the showui command line option was given. For instance,
920 run-standalone src/modest showui
921 Otherwise, we wait for the top_application D-Bus method to
922 be sent by hildon-desktop when the application is selected
924 This allows us to run without a UI when osso-global-search
925 uses our D-Bus methods.
927 2007-07-11 Murray Cumming <murrayc@murrayc.com>
929 * src/dbus_api/modest-dbus-api.h: Added a define for a
930 top-application D-Bus method.
931 * src/dbus_api/modest-dbus-callbacks.c:
932 (on_top_application),
933 (modest_dbus_req_handler): Handle the top-application D-Bus
934 method, which might be an undocumented D-Bus signal sent by
935 hildon-desktop when it starts the application from the menu.
936 But I am not sure and I need to test it on the device, because
937 my scratchbox does not have the application in the menu now.
938 This method shows the main window, so that it can be invisible
939 when started, for instance, just for email searching from
942 * src/maemo/modest-main-window.c: (restore_settings),
943 (modest_main_window_new): Do not show the window immediately
944 upon creation. We show it later.
945 * src/modest-widget-memory.c: (save_settings_paned):
946 Try (unsuccessfully) to avoid saving the paned position when
947 it is not even visible.
948 (restore_settings_paned): Do not allow a silly paned position.
949 This seems necessary when not showing the window at first.
951 * tests/dbus_api/Makefile.am:
952 * tests/dbus_api/test_top_application.c: (main): Test for the
955 2007-07-10 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-ui-dimming-rules.c:
958 (modest_ui_dimming_rules_on_new_msg),
959 (modest_ui_dimming_rules_on_reply_msg),
960 (modest_ui_dimming_rules_on_delete_msg),
961 (modest_ui_dimming_rules_on_details),
962 (modest_ui_dimming_rules_on_view_window_move_to),
963 (modest_ui_dimming_rules_on_view_previous),
964 (modest_ui_dimming_rules_on_view_next),
965 (_invalid_folder_for_purge): Added checks before
966 casting the window. This looks like an actual
967 logic error in _invalid_folder_for_purge(), because it
968 tries to use a ModestMainWindow as a message window.
970 2007-07-10 Murray Cumming <murrayc@murrayc.com>
972 * src/maemo/modest-account-settings-dialog.c:
973 (show_error): Use the same implementation as in
974 modest-easysetup-wizard.c:
975 (on_entry_invalid_character): The logical ID contains a %s.
976 Guessed what it should be.
977 (on_entry_max), (check_data), (on_response): Adapt to
978 changed show_error().
979 (create_page_account_details): Really call
980 modest_validating_entry_set_func() on the correct widgets.
981 * src/maemo/easysetup/modest-easysetup-wizard.c:
982 (on_entry_invalid_character): Fix the logical ID here too.
983 (create_page_account_details),
984 (create_page_user_details):
986 modest_validating_entry_set_func() on the correct widgets.
988 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
989 Do not try to use the account if it is NULL.
991 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
993 * src/modest-ui-actions.c: (create_move_to_dialog),
994 (modest_ui_actions_on_main_window_move_to),
995 (modest_ui_actions_on_msg_view_window_move_to):
996 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
997 (filter_row), (modest_folder_view_show_non_move_folders):
998 * src/widgets/modest-folder-view.h:
1000 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
1001 the Sent folder yet as it does not report the correct folder type.
1003 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
1005 * src/maemo/modest-msg-edit-window.c: (init_window):
1008 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1011 Take a parent widget instead of a parent window, and
1012 implement this with hildon_banner_show_information() instead.
1013 Non-Maemo builds can just ifdef that there.
1014 This fixed projects.maemo.org bug NB#62766.
1016 (on_entry_invalid_character): Use show_error() again instead
1017 of using hildon directly, and use the _CS() macro to use the correct
1019 (create_account), (check_for_supported_auth_methods), (on_entry_max):
1020 Pass a widget instead od a window to show_error().
1022 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1025 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
1026 This allows us to show the server name in the error message, fixing
1027 projects.maemo.org bug NB#62904.
1028 Also, use the appropriate logical ID message for the account protocol.
1030 2007-07-10 Murray Cumming <murrayc@murrayc.com>
1032 * src/modest-tny-account-store.c: (on_idle_wrong_password):
1033 A compilation fix, though the build wasn't broken for me.
1035 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
1038 Do not try to unref a NULL folder store, to avoid a runtime warning.
1039 This seems to happen sometimes when changing accounts settings.
1041 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-tny-account-store.c:
1044 (modest_tny_account_store_instance_init),
1045 (modest_tny_account_store_finalize),
1046 (on_account_settings_hide), (on_idle_wrong_password):
1047 Use a GHashTable to ensure that we only show one account settings
1048 dialog per modest account. This avoids us having a dialog open for
1049 both the store and transport accounts, or due to repeated get_password()
1050 calls that shouldn't happen anyway.
1052 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1054 * src/maemo/modest-maemo-utils.c: (on_hide),
1055 (modest_maemo_show_dialog_and_forget): Handle the response, because
1056 the window is not even hidden by default.
1058 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1059 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
1060 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
1061 which seems to prevent some modality problems.
1063 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1064 Ignore user cancellation errors.
1066 * src/modest-account-mgr-helpers.h:
1067 * src/modest-account-mgr-helpers.c:
1068 Added modest_server_account_get_password() and
1069 modest_server_account_get_has_password() to avoid direct use of
1072 * src/maemo/modest-account-settings-dialog.h:
1073 * src/maemo/modest-account-settings-dialog.c:
1074 (modest_account_settings_dialog_init): Store the notebook so we can
1076 Added modest_account_settings_dialog_switch_to_user_info().
1078 * src/modest-tny-account-store.c:
1079 (get_password): When the password in the account settings is wrong (we think),
1080 show the relevant page of the account settings dialog, in the mainloop.
1081 However, we currently get many of these at once because cancel does not
1083 (forget_password): Do not forget the password
1084 from the account settings, because this causes side-effects when
1085 tinymail seems to call it at strange time, maybe because of how we
1086 are cancelling get_password().
1087 (modest_tny_account_store_alert): Ignore user cancellations.
1089 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/modest-maemo-utils.h:
1092 * src/maemo/modest-maemo-utils.c:
1093 Added modest_maemo_show_information_note_and_forget() for use instead of
1094 gtk_dialog_run() when the response is not needed, to avoid an extra
1095 mainloop which could cause a hang.
1097 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
1098 Use the logical IDs for the error message, though they are not
1099 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
1100 because gtk_dialog_run() caused a hang here (the window did not close).
1101 This fixes projects.maemo.org bug NB#62646.
1103 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1105 * src/modest-account-mgr-helpers.h:
1106 * src/modest-account-mgr-helpers.c:
1107 Added modest_account_mgr_get_store_protocol().
1109 * src/maemo/modest-account-view-window.c:
1110 (on_delete_button_clicked): Show different warning text depending on
1111 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1112 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1115 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1117 * src/maemo/modest-msg-edit-window.c:
1118 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1119 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1121 2007-07-07 Armin Burgmeier <armin@openismus.com>
1123 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1124 ckdg_ib_maximum_characters_reached from correct package.
1126 * src/modest-ui-actions.c: Show an error message when a folder could
1127 not be created. Tinymail does not give us specific error codes about
1128 what has gone wrong, so we assume that a folder with that name
1129 already exists, though there might be other reasons.
1131 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1134 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1135 give a more exact error message that can be partly translated.
1137 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1139 * src/maemo/modest-address-book.c:
1140 (select_email_addrs_for_contact): Specify a default window size for the
1141 select-email-address dialog, so that it is probably big enough for the
1142 title. This should fix projects.maemo.org bug NB#62277.
1144 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1146 * src/maemo/easysetup/modest-easysetup-wizard.c:
1147 (create_page_complete_easysetup): Use
1148 gtk_widget_set_size() request to ensure that the text wraps
1151 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1153 * src/maemo/easysetup/modest-easysetup-wizard.c:
1154 (on_entry_invalid_character), (create_page_account_details),
1155 (create_page_user_details):
1156 Use new API of ModestValidatingEntry. But for some reason the banner is
1157 not shown. I will have to investigate that further.
1159 * src/widgets/modest-validating-entry.c: (on_insert_text),
1160 (modest_validating_entry_set_func):
1161 * src/widgets/modest-validating-entry.h:
1162 Added a new callback function to be able to react to prevented
1163 characters whitespaces to e.g show a banner.
1165 2007-07-05 Armin Burgmeier <armin@openismus.com>
1167 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1168 notification of HildonNumberEditor instead of remembering the port
1169 number. Thanks to Johannes for pointing this out.
1171 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1173 * src/maemo/easysetup/modest-easysetup-wizard.c:
1174 Check if there are any user changes before showing a confirmation
1175 dialog (projects.maemo.org NB#60946)
1177 2007-07-05 Armin Burgmeier <armin@openismus.com>
1179 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1180 number at the beginning of the dialog and set the modified flag at the
1181 end if the port number has changed. This is necessary because
1182 HildonNumberEditor does not support notification when the value has
1185 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1187 * src/modest-ui-actions.c:
1188 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1189 a connection before asking anything else. Correct the check for the destination
1190 folder so that it succeeds when online.
1191 This fixed projects.maemo.org bug NB#61645.
1193 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1196 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1197 to fix projects.maemo.org bug NB#62439.
1199 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1201 * src/modest-tny-account.c: (on_connection_status_changed):
1202 Really do not use tny_device_force_offline() here. See the previous comment.
1204 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1206 * src/modest-tny-account.c: (on_connection_status_changed):
1207 Do not use tny_device_force_offline() when tinymail says that something
1208 went wrong with the connection. It seems to report this unnecessarily.
1210 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1212 * src/maemo/modest-connection-specific-smtp-window.c:
1213 (modest_connection_specific_smtp_window_init):
1214 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1215 does not seem to have any effect in osso 1.1 (though it works in
1216 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1218 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1220 * src/maemo/modest-connection-specific-smtp-window.c:
1221 Fix UI specification problems with projects.meamo.org NB#60479
1223 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1225 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1226 clue when this has failed, because the error dialog is not always shown
1227 (at least in earlier version).
1229 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1230 GError message, because the generic error dialog is not helpful.
1232 'This message is not currently available (can't let a new connection go online)'
1233 when trying to open an IMAP message.
1235 (_modest_ui_actions_open): Offer a connection when some messages would
1236 have to be downloaded and we are offline.
1238 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1240 * src/widgets/modest-folder-view.c:
1241 Don't check for MERGE type anymore as we use the correct type
1243 NOTE: For the last two changes you need to update your tinymail copy
1244 because of API changes!
1246 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1248 * src/modest-tny-local-folders-account.c:
1249 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1250 (see projects.maemo.org NB#61580)
1252 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-tny-account.c: (on_connection_status_changed):
1255 Commented out the call to modest_platform_connect_and_wait() because this
1256 seems to always hang, and I would like to know if this is the only thing
1257 that causes a hang when showing the connection dialog.
1258 It is not very useful anyway.
1260 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1262 * src/maemo/modest-msg-view-window.c:
1263 (modest_msg_view_window_select_next_message):
1265 * src/modest-platform.h:
1266 * src/maemo/modest-platform.c:
1267 Added modest_platform_connect_and_wait(), which calls
1268 tny_maemo_conic_device_connect() always in the main thread, by calling it
1269 in an idle handler and waiting for the idle handler to run. It should be
1270 in the main thread because it uses GTK+ UI code. It just returns TRUE
1271 if the device is already online.
1273 There is some nasty code to ensure that subsequent calls to
1274 modest_platform_connect_and_wait() just wait for the first one to finish,
1275 by checking repeatedly in another idle handler. This is necessary,
1276 because other threads (or even the main thread, via another idle handler)
1277 can call modest_platform_connect_and_wait() while
1278 modest_platform_connect_and_wait() is running.
1280 (modest_platform_connect_and_wait_if_network_account),
1281 (modest_platform_connect_and_wait_if_network_folderstore):
1282 Convenience functions that calls modest_platform_connect_and_wait() if
1283 the account or folder might want network access.
1285 * src/modest-mail-operation.c:
1286 (modest_mail_operation_update_account):
1287 * src/modest-ui-actions.c: (download_uncached_messages),
1288 (modest_ui_actions_on_rename_folder), (delete_folder),
1289 (modest_ui_actions_on_main_window_move_to),
1290 (modest_ui_actions_on_msg_view_window_move_to):
1291 * src/widgets/modest-folder-view.c:
1292 (drag_and_drop_from_folder_view):
1293 Offer a connection if we are offline.
1295 * src/modest-tny-account.c: (on_connection_status_changed):
1296 Document this as only handling errors during network operations in progress,
1297 and replace the idle code with a simple call to
1298 modest_platform_connect_and_wait(), which does this instead.
1300 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-tny-account.c:
1303 (modest_tny_account_get_special_folder): (util_on_idle),
1304 Handle the GError so we can see when tny_folder_store_get_folders()
1305 fails, as it currently does while something else is connecting.
1307 Added util_run_in_main_thread_and_wait()
1308 which uses an idlen handler and mainloop to ensure that the function
1309 is called in the main thread.
1310 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1311 to make sure that we call attempt the connection in the mainloop only,
1312 which might solve some hangs.
1314 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1316 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1317 be found by their display name. This is never useful.
1318 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1319 by its ID, instead of trying to use its ID as its display name.
1321 * src/modest-tny-account-store.h:
1322 * src/modest-tny-account.c:
1323 (modest_tny_account_get_special_folder): Add a g_warning() when
1324 tny_folder_store_get_folders() returns an empty list for the maildir.
1326 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1327 Add a g_warning() when this returns NULL, because that it not allowed
1330 2007-07-02 Armin Burgmeier <armin@openismus.com>
1332 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1333 note when trying to cancel the wizard. This fixes projects.maemo.org
1336 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1338 * src/modest-tny-account.h:
1339 * src/modest-tny-account.c:
1340 (modest_tny_account_new_from_server_account),
1341 (modest_tny_account_new_from_server_account_name),
1342 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1343 because this must now be set before setting the proto. This is usd in
1344 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1345 warning in camel_session_get_service() caused by
1346 tny_camel_transport_account_prepare().
1348 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1351 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1353 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1355 (modest_connection_specific_smtp_edit_window_init):
1357 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1358 of "changed" for now
1360 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1362 * src/modest-tny-account.c:
1363 (modest_tny_account_new_from_server_account):
1364 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1365 now uses to request a connection when it needs one, and which it uses
1366 to tell us that something is wrong with the connection, so we can force
1367 the accounts offline to prevent further problems.
1369 * src/modest-defs.h:
1370 * src/modest-init.c: (init_default_settings):
1371 * src/modest-mail-operation.c:
1372 (modest_mail_operation_update_account):
1373 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1374 This should not be necessary anymore. Do not set the conf key that
1375 determined this (it was always TRUE and not set anywhere else).
1377 * src/modest-ui-actions.h: Remove unused and unimplemented
1378 modest_ui_actions_on_online_toggle_toggled().
1380 2007-06-29 Murray Cumming <murrayc@murrayc.com
1382 * src/maemo/modest-main-window.c: (connect_signals):
1383 Don't connect to delete_event twice. Maybe this was harmless.
1385 2007-06-29 Murray Cumming <murrayc@murrayc.com
1387 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1388 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1389 Debug output to give some more clue when a folder move is not allowed.
1391 2007-06-28 Murray Cumming <murrayc@murrayc.com
1393 * src/modest-tny-account.c: (on_modest_file_system_info),
1394 (modest_tny_account_get_mmc_account_name):
1395 Always call the callback, without checking whether the name has changed.
1396 * src/widgets/modest-folder-view.c: (strings_are_equal),
1397 (on_model_foreach_set_name), (on_get_mmc_account_name),
1398 (text_cell_data): Compare the name here, and use the name from
1399 the account rather than from the
1400 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1401 if the name was changed after the account was added to the model.
1402 That's a tinymail bug but not one that I want to fix now.
1404 This finally fixes projects.maemo.org bug NB#59301.
1406 2007-06-27 Armin Burgmeier <armin@openismus.com>
1408 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1411 2007-06-27 Murray Cumming <murrayc@murrayc.com
1413 * src/modest-tny-account.h:
1414 * src/modest-tny-account.c:
1415 Added modest_tny_account_get_mmc_account_name(), to set the memory
1416 card name asynchronously for the given account and then notify.
1417 (modest_tny_account_new_for_local_folders): Use this new function instead
1418 of using hildon_file_system_info_async_new() directly.
1420 * src/widgets/modest-folder-view.c: (text_cell_data):
1421 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1422 gtk_tree_model_row_changed() when it is available.
1424 This should fix projects.maemo.org bug NB#59301.
1426 2007-06-27 Murray Cumming <murrayc@murrayc.com
1428 * src/modest-mail-operation.c: (update_account_thread),
1429 (get_msgs_full_thread): Fix typo failures in the revert
1432 2007-06-27 Murray Cumming <murrayc@murrayc.com
1434 * src/maemo/modest-maemo-global-settings-dialog.c:
1435 (idle_select_default_focus):
1436 * src/modest-mail-operation.c: (idle_notify_progress),
1437 (idle_notify_progress_once), (set_last_updated_idle),
1438 (update_account_thread), (get_msgs_full_thread):
1439 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1440 * src/widgets/modest-header-view.c:
1441 (idle_notify_headers_count_changed_destroy),
1442 (idle_notify_headers_count_changed):
1443 Reverted the additions of gdk_threads_enter/leave(), in case this
1444 helps with a startup hang on the device.
1446 2007-06-26 Armin Burgmeier <armin@openismus.com>
1448 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1449 for supported secure authentication methods from server by
1450 gtk_dialog_run(), saving CPU time and a potential race condition.
1452 2007-06-26 Armin Burgmeier <armin@openismus.com>
1454 * src/maemo/modest-maemo-utils.h:
1455 * src/maemo/modest-maemo-utils.c: Added a
1456 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1457 only error code to tell the calling code when the user canceled the
1460 * src/maemo/modest-account-settings-dialog.h:
1461 * src/maemo/modest-account-settings-dialog.c:
1462 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1463 message if the retrieval of secure authentication methods was canceled
1464 by the user. Perform the check before saving anything to configuration
1465 to not end up with half-committed configuration changes, do not show
1466 a "Saving to configuration failed" note when authentication methods
1467 could not be retrieved.
1469 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1472 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1474 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1475 Only return the first level of folders under accounts, because the
1476 osso-global-search UI spec doesn't want the rest.
1477 This fixed projects.maemo.org bug NB#61811.
1479 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1481 * src/modest-tny-account-store.c:
1482 * src/modest-tny-account-store.h:
1483 Added modest_tny_account_is_memory_card_account().
1484 * src/maemo/modest-main-window.c: (create_details_widget):
1485 Show the same information items for the memory card as we show for the
1486 local-folders, to fix projects.maemo.org bug NB#59307.
1488 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1490 * src/modest-tny-account-store.c: (get_password):
1491 Added some checks for NULL to maybe prevent crashes, though I think
1492 it was Philip's last commit that actually prevented the crash here
1493 when creating a first new account.
1494 But the new account is still not usable (no messages are shown)
1495 until a restart of the application.
1497 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/modest-maemo-global-settings-dialog.c:
1500 (idle_select_default_focus):
1501 * src/modest-mail-operation.c: (idle_notify_progress),
1502 (idle_notify_progress_once), (idle_notify_update_account_queue),
1503 (set_last_updated_idle), (update_account_thread),
1504 (notify_get_msgs_full), (get_msgs_full_destroyer),
1505 (get_msgs_full_thread):
1506 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1507 * src/widgets/modest-header-view.c:
1508 (idle_notify_headers_count_changed_destroy),
1509 (idle_notify_headers_count_changed):
1510 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1511 all idle handlers, because some other thread could be blocking
1512 the GDK lock, so that it can do GUI stuff.
1514 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1516 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1517 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1518 (on_idle_send_receive), (on_idle_open_default_inbox):
1519 * src/maemo/modest-msg-edit-window.c:
1520 (modest_msg_edit_window_attach_file_noninteractive):
1521 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1522 to prevent a hang. I don't quite understand why these are necessary,
1523 beause we should already be in the main loop. I guess something outside
1524 of the main loop is taking the lock.
1526 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1527 we are really using URIs, and use files that are more likely to exist.
1529 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1531 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1532 necessary because configure.ac now defines different variables.
1534 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1536 * libmodest-dbus-client/libmodest-dbus-client.c:
1537 * libmodest-dbus-client/libmodest-dbus-client.h:
1538 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1539 libmodest_dbus_client_compose_mail() is what things actually use.
1541 * src/dbus_api/modest-dbus-api.h:
1542 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1543 * tests/dbus_api/Makefile.am:
1544 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1547 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1549 * src/modest-init.c: (modest_init_local_folders):
1550 For memory-card (or other non local-folders) maildir accounts,
1551 always create an Archive folder, so that there is somewhere to put
1552 messages. This should be less confusing, because the user does not need
1553 to guess that the need to create a folder.
1555 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1557 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1558 Fixed icon size by using (50, 50) which is the same as defined by
1561 2007-06-25 Armin Burgmeier <armin@openismus.com>
1563 * src/widgets/modest-window-mgr.c:
1564 * src/modest-init.c:
1565 * configure.ac: Correctly recognize hildon-notify presence and fixed
1566 the build without it being installed.
1568 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1570 * libmodest-dbus-client/libmodest-dbus-client.c:
1571 (libmodest_dbus_client_search): Fix the build. Sorry.
1572 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1573 (reply_forward_cb): Initialize variables to fix the build.
1575 * src/modest-tny-account-store.c:
1576 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1577 comparison (a silly typo) so that email search results can be opened
1578 when there are more than one account.
1580 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1582 * libmodest-dbus-client/libmodest-dbus-client.c:
1583 (libmodest_dbus_client_search),
1584 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1585 instead of 1 second, because the search gets folders and messages from
1586 the server, which can take a long time. When it times out,
1587 osso-global-search will report no results.
1589 We need to specify whether we should search only cached information
1590 (maybe with a user preference), and the osso-email-search-plugin
1591 API should really be improved to allow that option, and to allow results
1592 to be delivered asynchronously in batches.
1594 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1596 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1597 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1598 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1600 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1602 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1603 that is an empty string. D-Bus seems to give us these instead of NULL.
1605 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1607 * src/dbus_api/modest-dbus-callbacks.c:
1608 * src/maemo/easysetup/modest-easysetup-wizard.h:
1609 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1610 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1611 (modest_connection_specific_smtp_edit_window_init):
1612 * src/maemo/modest-maemo-global-settings-dialog.c:
1614 * src/maemo/modest-maemo-utils.c:
1615 (modest_maemo_utils_setup_images_filechooser):
1616 * src/maemo/modest-main-window.c: (create_details_widget):
1617 * src/maemo/modest-msg-edit-window.c:
1618 (modest_msg_edit_window_attach_file_noninteractive),
1619 (modest_msg_edit_window_color_button_change),
1620 (modest_msg_edit_window_set_zoom):
1621 * src/modest-mail-operation.c: (update_account_thread):
1622 * src/modest-tny-account-store.c:
1623 * src/modest-tny-account.c:
1624 * src/widgets/modest-global-settings-dialog.c:
1625 * src/widgets/modest-window.h:
1627 Fixed build on bora!
1629 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1631 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1632 * src/modest-search.c: (modest_search_folder),
1633 (modest_search_all_accounts): Actually search only in the specified folder,
1634 doing a simple match on the folder ID.
1635 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1636 and added some documentation.
1638 2007-06-22 Armin Burgmeier <armin@openismus.com>
1640 * src/maemo/modest-maemo-utils.h:
1641 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1642 modest_maemo_utils_get_supported_secure_authentication_methods.
1644 * src/maemo/easysetup/modest-easysetup-wizard.c:
1645 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1646 one occured, not just "Server does not support secure authentication".
1648 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1650 * src/modest-tny-account-store.c: (get_password):
1651 Restored the call to tny_account_set_user() because Philip seems to have
1652 stopped this from crashing (by not using the freed string). It still does
1653 not work, but now we can test it.
1655 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1657 * src/maemo/modest-msg-edit-window.c: (init_window):
1658 Comment out use of an uninitialzed GtkScrolledWindow variable,
1659 to fix the build and stop a crash. Yet again.
1661 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-tny-account-store.c: (get_password):
1664 Remove the call to tny_account_set_user() because this actually crashes.
1665 As mentioned in the last commit, it is known to not work anyway.
1667 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1669 * src/modest-tny-account-store.c: (get_password):
1670 Use tny_account_set_username() to tell tinymail that the username might
1671 have changed too. But tinymail ignores this: see projects.maemo.org
1673 * src/modest-ui-actions.c:
1674 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1675 reset the connection when changing the username, and improve the comments.
1676 Save the changed username to gconf at least, so it is used when Modest is
1679 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1681 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1682 Do not use a query, so that we get all folders, including for POP and
1683 local-folders. They work as search criteria too.
1684 This fixes projects.maemo.org bug NB#57740.
1686 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1688 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1689 Comment out the use of hildon_notification_set_sound() because it is
1690 not declared, to fix the build. Warnings are serious, people.
1692 2007-06-21 Armin Burgmeier <armin@openismus.com>
1694 * src/maemo/modest-maemo-utils.h:
1695 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1696 modest_maemo_utils_get_supported_secure_authentication_methods()
1697 to query authentication methods for a specific user. This should fix
1698 projects.maemo.org bug NB#61369.
1700 * src/maemo/easysetup/modest-easysetup-wizard.c:
1701 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1704 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1706 * libmodest-dbus-client/libmodest-dbus-client.h:
1707 * libmodest-dbus-client/libmodest-dbus-client.c:
1708 (modest_dbus_message_iter_get_search_hit),
1709 (libmodest_dbus_client_search):
1710 Reorganised and commented this.
1711 Removed modest_search_hit_free() from the public API because it
1714 Added libmodest_dbus_client_get_folders() and
1715 modest_folder_result_list_free().
1717 * src/dbus_api/modest-dbus-api.h:
1718 * src/dbus_api/modest-dbus-callbacks.c:
1719 (modest_dbus_req_filter): Commented. Moved most code to
1720 on_dbus_method_search() and added on_dbus_method_get_folders().
1722 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1723 of the extra D-Bus handler.
1725 * tests/dbus_api/Makefile.am:
1726 * tests/dbus_api/test_get_folders.c: New test for
1727 libmodest_dbus_client_get_folders(). This seems to return an empty list
1728 at the moment. That could be the same error that causes the message list
1729 to be empty sometimes.
1730 This should help with projects.maemo.org bug NB#57740.
1732 2007-06-21 Armin Burgmeier <armin@openismus.com>
1734 * src/modest-mail-operation.c: Do not call
1735 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1736 notify the operation's end after having set the status to CANCELED for
1737 the operation queue to listen on. This fixes a deadlock when there
1738 were mail operations in the queue during its finalization.
1740 * src/modest-singletons.c: Reordered uninitialization of the account
1741 manager to happen after the mail operation queue was uninitialized
1742 because the mail operation's in the queue might still try to access
1743 the account manager (see modest_mail_operation_notify_end()). This
1744 fixes a potential crash when terminating the application.
1746 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-search.c:
1749 (search_mime_part_and_child_parts): Moved some code here so we
1750 can search recursively in child folders.
1751 (modest_search_folder): Search in the message as a mime part, instead
1752 of just its child mime parts.
1753 (read_chunk), (search_mime_part_ogs):
1754 Check how many bytes were read, to prevent an endless loop.
1755 Searching in message bodies now works. This finishes the fix for
1756 projects.maemo.org bug NB#61007.
1758 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1761 Add a g_warning when the item is not a folder.
1763 * src/modest-ui-dimming-rules.c:
1764 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1765 when selected item is not a folder (for instance, an account), because
1766 the UI spec only talks about folders.
1767 I am not sure what the UI spec wants, so this might not totally fix
1768 projects.maemo.org bug NB#60794.
1770 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1772 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1773 (load_from_file): Sort the list. The unsorted list would be more noticeable
1774 in non-English locales.
1776 * src/maemo/modest-msg-edit-window.c:
1777 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1778 warning and fix the build.
1780 * src/maemo/modest-progress-bar-widget.c:
1781 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1782 avoid a g_warning, and probably to avoid a crash.
1784 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-search.c: (modest_search_folder): Check for a GError
1787 when calling tny_folder_get_headers(), to show that this is not the cause
1790 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1792 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1793 Actually set the body query instead of the subject query.
1795 * src/modest-search.c: (search_mime_part_ogs),
1796 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1797 which would probably cause it to fail if we got this far.
1799 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1800 to simplify the code.
1801 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1802 be causing search-in-body to fail.
1804 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1806 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1808 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1809 Better debug message when the folder cannot be found.
1810 This should help with fixing projects.maemo.org bug #61287.
1811 * src/modest-search.c: (add_hit): Do not leak the furl string.
1813 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1815 * src/modest-ui-actions.c:
1816 (modest_ui_actions_on_folder_selection_changed):
1817 Do not special-case TNY_MERGE_FOLDER here, because
1818 modest_tny_folder_get_account() already does that. This fixes
1819 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1820 shown when the Outbox was selected).
1822 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1824 * libmodest-dbus-client/libmodest-dbus-client.c:
1825 (_dbus_iter_get_string_or_null): Initialize the string variable in
1826 case this helps with Dirk's crash.
1828 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1830 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1831 though it is not implemented yet (this function is maybe not even used),
1832 to avoid breaking ABI in future.
1833 * libmodest-dbus-client/libmodest-dbus-client.c:
1834 (get_attachments_string): Moved some code into this generic function.
1835 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1836 sends email. It is maybe not used.
1837 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1838 (on_send_mail): Use attachments.
1840 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1841 * src/maemo/modest-msg-edit-window.c:
1842 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1843 a filename before using it, to fix projects.maemo.org bug NB#58233.
1845 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1848 Initialize the continue_download variable to fix the build, and probably
1849 to fix randome behaviour.
1851 2007-06-18 Armin Burgmeier <armin@openismus.com>
1853 * src/modest-tny-send-queue.h:
1854 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1855 the queue so we can later show it in the UI. Replaced
1856 modest_tny_send_queue_msg_is_being_sent() by
1857 modest_tny_send_queue_get_msg_status().
1859 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1861 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1862 gpointer. This probably was not harmful, but just to be sure.
1864 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1866 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1867 Fix the build, but leave the function broken on Bora, because
1868 hildon_uri_action_get_service() does not exist.
1869 osso_uri_action_get_service() does not exist either, it seems.
1871 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1873 * src/modest-tny-account.c:
1874 (modest_tny_account_new_from_server_account):
1875 Uncommented the url debug output again, because it is useful for
1876 debugging, as I said in the comment.
1878 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1880 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1882 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1883 for Mameo Bora, to fix the build.
1885 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1888 Fixed build with hildon < 0.99
1890 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1891 Check if the selected account is busy instead of checking all accounts
1893 * src/modest-account-mgr-priv.h:
1894 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1895 (modest_account_mgr_init), (compare_account_name),
1896 (modest_account_mgr_set_account_busy),
1897 (modest_account_mgr_account_is_busy):
1898 * src/modest-account-mgr.h:
1899 Added busy information to the account manager. It possible to
1900 set an account to busy or not busy now.
1902 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1903 (modest_mail_operation_update_account),
1904 (modest_mail_operation_notify_end):
1905 Set the account to busy/not busy depending on the operation state.
1907 * src/widgets/modest-account-view.c:
1908 (modest_account_view_finalize), (get_last_updated_string),
1909 (update_account_view), (on_account_busy_changed), (init_view):
1910 Show string "Refreshing..." if the account is currently busy.
1912 All this fixes projects.maemo.org bug NB#59711
1914 2007-06-14 Armin Burgmeier <armin@openismus.com>
1916 * src/widgets/modest-attachments-view.h:
1917 * src/widgets/modest-attachments-view.c: Added
1918 modest_attachments_view_has_attachments() and fixed coordinate
1919 transformation in get_att_view_at_coords(). This fixes attachment
1922 * src/widgets/modest-msg-view.c: Make use of
1923 modest_attachments_view_has_attachments() to decide whether to show
1924 attachments in the header.
1926 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1928 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1929 (on_change), (on_combo_security_changed),
1930 (modest_connection_specific_smtp_edit_window_init),
1931 (modest_connection_specific_smtp_edit_window_set_connection),
1932 (modest_connection_specific_smtp_edit_window_is_dirty):
1933 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1934 * src/maemo/modest-connection-specific-smtp-window.c:
1937 Show an comfirmation dialog for the smpt-edit-window if there are
1938 unsaved changes and the user hits cancel.
1939 (projects.maemo.org bug NB#60479)
1941 2007-06-14 Armin Burgmeier <armin@openismus.com>
1943 * src/maemo/easysetup/modest-easysetup-wizard.c:
1944 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1945 address" info in banner instead of node, and select all the text as
1946 per UI spec. This fixes projects.maemo.org bug NB#60550.
1948 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1950 reviewed by: <delete if not using a buddy>
1952 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1953 * src/modest-ui-actions.c: (folder_refreshed_cb):
1955 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1957 * src/widgets/modest-folder-view.c: (filter_row):
1958 Explictly filter out the per-account outbox accounts. I don't know why
1959 these only sometimes show up, but now they should never show up in the UI.
1960 This should fix projects.maemo.org bug NB#60160.
1962 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1964 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1965 when the toolbar does not exist yet.
1966 * src/modest-widget-memory.c: (save_settings_header_view):
1967 Added g_warnings() to help us to discover when we are trying to set
1968 an empty columns list in gconf.
1970 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-init.h:
1973 * src/modest-init.c:
1974 Added modest_init_get_default_header_view_column_ids().
1976 * src/modest-widget-memory.c: (restore_settings_header_view):
1977 Use the new function to get defaults, if the gconf key is empty,
1978 instead of not creating any columns. This seems to fix the
1979 empty right-hand pane problems.
1981 * src/widgets/modest-header-view.h: Improved documentation.
1983 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1985 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1986 Revert the use of the display name as the account name, because this
1987 is generally wrong and would break the code that follows.
1989 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1991 * src/maemo/easysetup/modest-easysetup-wizard.c:
1992 (check_for_supported_auth_methods), (on_before_next),
1995 More correct fix for projects.maemo.org bug NB# 58991
1996 Do not longer accept AUTH_PASSWORD as secure method and choose
1997 correct method when creating the account.
1999 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
2001 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2002 Fixed projects.maemo.org bug NB# 58991
2004 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2006 * src/modest-init.c: (modest_init_init_core),
2007 (modest_init_local_folders): Fixed compilation errors.
2009 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2011 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2012 Remove unnecessary lib/include, though it is good in principle when needed.
2014 * src/modest-init.c: (modest_init_one_local_folder),
2015 (modest_init_local_folders):
2016 * src/modest-init.h: Initialize the .modest library for memory cards,
2017 instead of just doing nothing for them. This should allow us to create
2018 folders there, fixing projects.maemo.org bug NB#59297.
2020 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2022 * libmodest-dbus-client/libmodest-dbus-client.c:
2023 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2024 (libmodest_dbus_client_compose_mail),
2025 (libmodest_dbus_client_open_message),
2026 (libmodest_dbus_client_send_and_receive),
2027 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
2029 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
2030 (on_idle_open_message), (modest_dbus_req_handler),
2031 (search_result_to_message), (modest_dbus_req_filter):
2032 * src/modest-search.c: (add_hit), (modest_search_folder),
2033 (modest_search_all_accounts): Improved debug messages.
2035 * tests/dbus_api/test_open_message.c: (main): Improved comments.
2037 * src/modest-tny-account-store.c:
2038 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
2041 2007-06-13 Murray Cumming <murrayc@murrayc.com>
2044 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2046 * src/modest-tny-account-store.c: (get_server_accounts):
2047 Call modest_tny_local_folders_account_add_merged_outbox_folders()
2048 even when there are no accounts, so that the Outbox folder is always
2049 visible. This fixes projects.maemo.org bug NB#60158.
2051 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2053 * src/maemo/modest-main-window.c: (create_details_widget):
2054 Use the mcen_va_never logical ID.
2056 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2058 * src/dbus_api/modest-dbus-api.h:
2059 * src/dbus_api/modest-dbus-callbacks.c:
2060 (on_idle_open_default_inbox), (on_open_default_inbox),
2061 (modest_dbus_req_handler):
2062 Added a new OpenDefaultInbox method.
2064 * libmodest-dbus-client/libmodest-dbus-client.h:
2065 * libmodest-dbus-client/libmodest-dbus-client.c:
2066 Added libmodest_dbus_client_open_default_inbox() to call the new
2067 dbus method. This should be useful to projects.maemo.org bug NB#57214,
2068 though it should maybe be used by a new osso-email-interface function.
2070 * tests/dbus_api/Makefile.am:
2071 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
2074 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2076 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
2077 NULL, so that the signals get all the keys. This should not actually
2078 change any behaviour because we currently update everything when anything
2081 2007-06-12 Murray Cumming <murrayc@murrayc.com>
2083 * src/widgets/modest-folder-view.c: (text_cell_data),
2084 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
2085 (find_inbox_iter): If tinymail tells us that the folder is
2086 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
2087 This causes the inbox to be selected at startup, fixing part of
2088 projects.maemo.org bug NB#56305.
2090 * src/modest-ui-dimming-rules.c:
2091 (modest_ui_dimming_rules_on_tools_smtp_servers):
2092 * src/modest-ui-dimming-rules.h: Added a callback function to dim
2093 the SMTP servers menu item.
2094 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
2095 that the SMTP Servers menu item is dimmed when there are no accounts,
2096 as a future version of the UI spec will require. This fixes
2097 projects.maemo.org bug NB#56305.
2099 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
2101 * src/maemo/modest-maemo-utils.c:
2102 (modest_maemo_utils_get_supported_secure_authentication_methods):
2103 Added label to dialog instead of unreadable title
2105 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2106 (modest_main_window_new):
2107 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2110 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2111 * src/modest-account-mgr.h:
2112 Added method to avoid code duplication
2114 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2115 (modest_ui_actions_on_send_receive):
2116 Use modest_account_mgr_has_accounts
2118 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2120 * src/maemo/easysetup/modest-presets.c:
2121 (modest_presets_get_info_server_security): Do not report secure auth
2123 * src/modest-protocol-info.c: Use the defines for the gconf key names
2124 for secure authentication. This was not working because we were writing
2125 Password and reading password, and the check was case sensitive.
2126 With this, gmail now works for receiving and sending when created via
2129 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2131 * src/maemo/easysetup/modest-presets.c:
2132 (modest_presets_get_info_server_security): Correct the key name for
2133 SecureSmtp, because it seems to be case-sensitive.
2134 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2135 Do not try to get the 0th notebook page if there are 0 pages, to
2136 avoid a g_warning().
2138 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2141 Prevent use of the new notification feature for now, because it currently
2142 shows one dialog for each new email, which is annoying.
2144 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2147 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2148 when no country was selected, so that we show the global ones.
2149 * src/maemo/easysetup/modest-presets.c:
2150 (modest_presets_get_providers): Return only the global providers, not
2151 all providers when mmc=0 was requested.
2153 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2156 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2157 provider ID in the combo.
2159 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2160 Do not show the page numbers, because it would be confusing when we add
2161 the 2 extra pages for the custom setup, when the user chooses the "Other"
2162 provider. This fixes projects.maemo.org bug NB#59028
2164 * src/modest-init.c: (modest_init_init_core),
2165 (modest_init_local_folders):
2166 * src/modest-init.h:
2167 * src/modest-tny-account.c:
2168 (modest_tny_account_new_for_local_folders): Do not create default folders
2169 for the memory card. This should fix projects.maemo.org bug NB#59328.
2171 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2173 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2174 Free the changed_conf_keys string items. They are already freed in the
2175 idle handler if that runs first.
2177 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2179 * src/modest-ui-actions.c:
2180 (modest_ui_actions_on_password_requested): Check that the server name
2181 is not NULL, because I just saw a password dialog with (null) as the
2184 * src/modest-tny-folder.[h|c]: Added
2185 modest_tny_folder_is_memory_card_folder().
2186 * src/modest-ui-dimming-rules.c:
2187 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2188 menu item for memory cards, as per the UI spec (section 7.4). This should
2189 fix projects.maemo.org bug NB#59297.
2191 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2193 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2194 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2195 is another problem with the code, see Murray's comment at line 772)
2197 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2199 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2200 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2201 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2202 (load_from_file), (easysetup_country_combo_box_init),
2203 (easysetup_country_combo_box_get_active_country_ids),
2204 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2205 instead of just one ID, to avoid duplicate country names in the UI.
2207 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2208 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2209 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2210 a single ID, avoiding duplicate providers.
2211 * src/maemo/easysetup/modest-easysetup-wizard.c:
2212 (on_combo_account_country): Adapt to use a list.
2214 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2216 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2217 keys changed in the last X seconds.
2219 * src/modest-account-mgr.h:
2220 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2221 (on_key_change), (modest_account_mgr_class_init),
2222 (modest_account_mgr_init), (modest_account_mgr_finalize):
2223 As the keys are changed, save them in a GSList* and signal that GSList*
2224 further every X seconds, to batch changes, to allow us to do just one
2225 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2226 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2228 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2229 changed signal signature.
2231 * src/modest-conf.c: (modest_conf_set_list),
2232 (modest_conf_on_change): Reenable notification.
2234 (modest_conf_maemo_fake_on_change): Comment out the hack that
2235 notified immediately instead of asynchronously.
2237 * src/widgets/modest-account-view.h:
2238 * src/widgets/modest-account-view.c:
2239 (update_account_view): Select the previously-selected account ID,
2240 if possible. This fixes projects.maemo.org bug NB#56933.
2242 (on_account_changed), (on_account_removed),
2243 (modest_account_view_select_account):
2245 Remove the block/unblock functions
2246 because they were not useful.
2248 * src/maemo/modest-account-view-window.c:
2249 (on_delete_button_clicked), (on_edit_button_clicked),
2250 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2252 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2254 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2255 Improve the error dialog to show Incorrect Account Settings, which seems
2256 clearer, and say that the internal error message (to be removed from the
2257 dialog later) is often misleading.
2258 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2260 * src/modest-tny-account.c:
2261 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2262 URL because this is so useful for debugging on the device.
2264 * src/widgets/modest-serversecurity-combo-box.c:
2265 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2267 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2269 * src/modest-mail-operation.c:
2270 (modest_mail_operation_send_new_mail):
2271 Added a comment about a nasty but apparently harmless message. Details
2272 added to the wiki g_warnings() page.
2274 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2276 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2277 (modest_tny_send_queue_class_init):
2278 Do not use the priv struct because it is empty, to avoid g_warnings
2279 about a non-existant priv struct.
2281 * src/modest-tny-account-store.c:
2282 (modest_tny_account_store_get_server_account),
2283 (modest_tny_account_store_get_transport_account_for_open_connection
2284 ): Do not try to get transport server accounts for local folders,
2285 because they don't have any. This avoids a g_warning().
2287 * src/maemo/modest-main-window.c:
2288 (modest_main_window_notify_send_receive_initied),
2289 (on_configuration_key_changed):
2290 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2291 * src/modest-defs.h:
2292 * src/modest-mail-operation.c:
2293 (modest_mail_operation_update_account):
2294 * src/modest-tny-account-store.h:
2295 * src/modest-tny-account.c:
2296 (modest_tny_account_get_special_folder),
2297 (modest_tny_account_new_for_local_folders),
2298 (modest_tny_account_new_for_per_account_local_outbox_folder):
2299 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2300 * src/modest-tny-local-folders-account.c:
2301 (add_account_folders_to_merged_folder):
2302 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2303 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2304 (modest_ui_actions_on_send):
2305 * src/widgets/modest-folder-view.c: (update_model):
2306 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2307 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2308 modest_tny_account_store_get_tny_account_by_account() to
2309 modest_tny_account_store_get_server_account() to make the code clearer.
2311 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2313 * src/dbus_api/modest-dbus-api.h:
2314 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2315 * src/maemo/modest-msg-edit-window.c:
2316 (modest_msg_edit_window_attach_file_noninteractive):
2317 added g_warning in case the file to be attached does not exist
2318 * tests/dbus_api/test_compose_mail.c: (main):
2319 removed obsolete comment, added generic files as test case
2321 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2323 * src/modest-tny-account-store.c: (get_server_accounts):
2324 Create the local folders account only once, not once for each outbox, and
2325 not only when there are some outboxes.
2327 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2329 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2330 code that is causing a crash at startup. Sergio says that he is fixing this.
2332 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2334 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2335 * src/maemo/modest-account-settings-dialog.c:
2336 (create_page_outgoing),
2337 (modest_account_settings_dialog_set_account_name),
2338 (save_configuration):
2339 - Fixed handling of the "Use secure authentication" toggle to comply with
2340 the ui specification. See also projects.maemo.org bug NB#58400
2342 - Restore the Secure connection setting combo correctly when loading
2345 * src/maemo/modest-maemo-utils.c:
2346 (on_camel_account_get_supported_secure_authentication),
2347 (modest_maemo_utils_get_supported_secure_authentication_methods):
2348 Fixed a crasher if operation is canceled
2350 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2351 (modest_protocol_info_auth_is_secure):
2352 * src/modest-protocol-info.h:
2354 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2355 the sense of the "Use secure authentication" toggle.
2357 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2359 * src/modest-tny-account-store.h:
2360 * src/modest-tny-account-store.c:
2361 Added modest_tny_account_store_get_local_folders_account().
2363 * src/modest-tny-folder.h:
2364 * src/modest-tny-folder.c:
2365 (modest_tny_folder_get_account):
2366 Added this replacement for tny_folder_get_account() which returns
2367 the local-folders account for TnyMergeFolders, to avoid the
2368 warning about the unimplemented get_account_func() vfunc().
2370 (modest_tny_folder_get_rules),
2371 * src/modest-ui-actions.c:
2372 (modest_ui_actions_on_folder_selection_changed):
2373 * src/modest-mail-operation.c:
2374 (modest_mail_operation_remove_folder),
2375 (modest_mail_operation_xfer_folder),
2376 (modest_mail_operation_rename_folder),
2377 (modest_mail_operation_get_msg),
2378 (modest_mail_operation_get_msgs_full),
2379 (modest_mail_operation_remove_msg),
2380 (modest_mail_operation_xfer_msgs),
2381 (modest_mail_operation_refresh_folder):
2382 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2384 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2386 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2387 (modest_server_account_set_security):
2388 * src/modest-defs.h: Add comments explaining that our
2389 UI spec means TLS when it says Normal, so these do not look like errors.
2391 * src/modest-tny-account.c:
2392 (modest_tny_account_new_from_server_account): Use the new tinymail
2393 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2394 for TLS. This should fix projects.maemo.org bug NB#58460.
2396 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2398 * src/maemo/easysetup/modest-easysetup-wizard.c:
2399 (create_account): Correct the position of the gconf sanity check warning.
2400 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2401 of using the g_idle_add() hack, because this does not seem to be necessary
2402 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2403 caused by something other than maemo's gconf.
2404 This fixes projects.maemo.org bug #59022.
2406 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2408 * src/modest-account-mgr-helpers.c:
2409 (modest_account_mgr_get_default_account): Do not check that the account
2410 exists if there is no default account (NULL), to fix a runtime warning.
2412 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2414 * src/widgets/modest-folder-view.c: (update_model):
2415 Do not unref the treemodel before we have finished with it.
2416 This prevents a valgrind warning and an occasional crash at startup.
2418 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2420 * libmodest-dbus-client/libmodest-dbus-client.h:
2421 added libmodest_dbus_client_compose_mail()
2422 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2424 added functions needed for SendAsMail() functionality
2425 * src/maemo/modest-msg-edit-window.c:
2426 (modest_msg_edit_window_attach_file_noninteractive):
2427 non interactively attaching files to message edit window
2428 * src/widgets/modest-msg-edit-window.h:
2429 * tests/dbus_api/Makefile.am:
2430 added test_compose_mail.c
2431 * tests/dbus_api/test_compose_mail.c: (main):
2433 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2435 * src/modest-account-view.c:
2436 Fixed bug projects.maemo.org bug NB#59307
2438 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2440 * src/maemo/easysetup/modest-easysetup-wizard.c:
2441 (get_serverport_incoming), (on_before_next), (create_account):
2442 * src/maemo/modest-account-settings-dialog.c:
2443 (modest_account_settings_dialog_set_account_name):
2444 * src/maemo/modest-maemo-utils.c:
2445 (on_camel_account_get_supported_secure_authentication_status),
2446 (on_camel_account_get_supported_secure_authentication),
2447 (on_secure_auth_cancel),
2448 (modest_maemo_utils_get_supported_secure_authentication_methods):
2450 Implemented security authentication for settings and easysetup.
2452 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2454 * src/maemo/modest-main-window.c: (create_details_widget):
2455 Show the total size for memory card accounts too, instead of showing
2456 the name again. Fixes bug projects.maemo.org bug NB#59307.
2458 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-tny-simple-folder-store.c:
2462 * src/modest-tny-simple-folder-store.h: Removed.
2464 * src/modest-tny-local-folders-account.h
2465 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2466 for the local-folders maildir, with an extra TnyMergedFolder containing
2467 the folders of the per-account outbox store accounts.
2468 * src/modest-tny-account-store.c: (get_server_accounts):
2469 Add the outboxes to the special local folders account after creating it.
2471 * src/modest-tny-account.c:
2472 (modest_tny_account_new_for_local_folders): Create the derived
2473 account when creating the main local-folders account.
2475 * src/maemo/modest-main-window.c: (create_details_widget),
2476 (modest_main_window_set_contents_style):
2477 Adapted to the use of the derived account instead of the folder store.
2479 * src/modest-ui-actions.c:
2480 (modest_ui_actions_on_folder_selection_changed):
2481 * src/modest-ui-dimming-rules.c:
2482 (modest_ui_dimming_rules_on_new_folder):
2483 * src/widgets/modest-folder-view.c: (text_cell_data),
2484 (icon_cell_data), (filter_row), (update_model),
2485 (get_cmp_rows_type_pos):
2488 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2489 Do not get the priv struct, because no priv struct has been set,
2490 to avoid a runtime warning.
2492 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2493 #ifelse with #else, to fix a warning, to fix the build.
2496 2007-06-05 Christian Kellner <ckellner@openismus.com>
2498 * libmodest-dbus-client/libmodest-dbus-client.c:
2499 Fix small typo in doc (why do you always see them
2500 AFTER committing stuff?)
2503 2007-06-05 Christian Kellner <ckellner@openismus.com>
2505 * libmodest-dbus-client/libmodest-dbus-client.c:
2506 (libmodest_dbus_client_search):
2507 Initialize hit list with NULL. Also set folder list
2508 to "" if NULL was supplied.
2511 2007-06-03 Christian Kellner <ckellner@openismus.com>
2513 * libmodest-dbus-client/libmodest-dbus-client.c:
2514 (modest_search_hit_list_free):
2515 Make it save to call it with NULL.
2517 * src/dbus_api/modest-dbus-callbacks.c:
2518 * src/modest-search.c:
2519 Return full ModestSearchHits as the search result list not TnyHeader
2520 since can't be around withouth the correspoding TnyFolder.
2522 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2524 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2525 Added currently commented code to check for secure auth
2527 * src/maemo/modest-account-settings-dialog.c: (on_response),
2528 (save_configuration), (show_ok):
2529 Fixed projects.maemo.org bugs NB #59248 and #59251
2531 * src/maemo/modest-maemo-utils.c:
2532 (on_camel_account_get_supported_secure_authentication_status),
2533 (on_camel_account_get_supported_secure_authentication),
2534 (modest_maemo_utils_get_supported_secure_authentication_methods):
2535 * src/maemo/modest-maemo-utils.h:
2536 Moved get_supported_secure_authentication() method here to be able
2537 to use it from easysetup wizard.
2539 * src/modest-pair.c: (on_pair_compare_as_string):
2540 Should compare string with first part of pair and not
2541 strcmp pairs which will crash.
2543 * src/modest-protocol-info.c:
2544 (modest_protocol_info_protocol_is_store):
2545 * src/modest-protocol-info.h:
2546 Added modest_protocol_info_get_auth_protocol_name()
2548 2007-06-03 Armin Burgmeier <armin@openismus.com>
2550 * src/modest-mail-operation.c:
2551 (modest_mail_operation_get_msgs_full): Set priv->account also when
2552 only retrieving a single message. This avoids a crash when canceling
2555 (modest_mail_operation_notify_end): Do not explicitely remove the
2556 operation from the queue but only emit the progress_changed signal.
2557 The queue itself listens to that signal to remove the operation when
2558 it is finished. This reduces coupling and removes a potential deadlock
2559 when modest_mail_operation_notify_end() is called from the queue
2560 itself. If that is a problem performance-wise, I would suggest to
2561 implement a status-changed signal or something.
2563 * src/modest-mail-operation-queue.c: Make sure to never call a
2564 function from another file while the queue is locked. This (hopefully)
2565 fixes another deadlock when exiting the application while retrieving
2568 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2570 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2571 Fixed build if libogs is not available
2573 2007-06-03 Christian Kellner <ckellner@openismus.com>
2575 * libmodest-dbus-client/libmodest-dbus-client.h:
2576 * libmodest-dbus-client/libmodest-dbus-client.c:
2577 (libmodest_dbus_client_delete_message):
2578 Implement deletion of messages (Client side).
2580 (modest_search_hit_free),
2581 (modest_search_hit_list_free):
2582 Utility functions to free the result hits.
2584 * src/dbus_api/modest-dbus-api.h:
2585 * src/dbus_api/modest-dbus-callbacks.c:
2586 (on_delete_message),
2587 (modest_dbus_req_handler):
2588 Implement deletion of messages (Server side).
2590 * tests/dbus_api/test_search.c: (main):
2593 * tests/dbus_api/Makefile.am:
2594 * tests/dbus_api/test_delete_message:
2595 Add little test for the message deletion logic
2597 2007-06-03 Armin Burgmeier <armin@openismus.com>
2599 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2600 when the operation queue was not empty. projects.maemo.org bug
2603 2007-06-03 Armin Burgmeier <armin@openismus.com>
2605 * src/widgets/modest-account-view.c
2606 (on_account_default_toggled): Toggle default account column
2607 explicitely instead of waiting for gconf notification (which is
2608 currently ignored). This should fix projects.maemo.org bug NB#56910
2609 for now. It should probably be removed when gconf notifications are
2612 2007-06-03 Christian Kellner <ckellner@openismus.com>
2614 * libmodest-dbus-client/libmodest-dbus-client.c:
2615 Removed debugging spew.
2617 * src/dbus_api/modest-dbus-callbacks.c:
2618 Added debugging info.
2620 * src/modest-search.c:
2621 (modest_search_all_accounts):
2622 Use tny_account_store_get_accounts () on the account store
2623 to get all accounts which is the way to get all accounts.
2625 * tests/dbus_api/test_search.c: (main):
2626 Make it possible to supply the search term on the command line.
2628 2007-06-03 Christian Kellner <ckellner@openismus.com>
2630 * libmodest-dbus-client/libmodest-dbus-client.c:
2631 * libmodest-dbus-client/libmodest-dbus-client.h:
2632 Implement searching for mesages over raw dbus. (Client side)
2634 * src/dbus_api/Makefile.am:
2635 * src/dbus_api/modest-dbus-api.h:
2636 * src/dbus_api/modest-dbus-callbacks.c:
2637 * src/dbus_api/modest-dbus-callbacks.h:
2638 Search framework (Server side). Also implement on_idle_open_message().
2640 * src/maemo/modest-platform.c: (modest_platform_init):
2641 Prepare for raw dbus/osso rpc interaction.
2643 * src/modest-search.h:
2644 Changed minsize from unspecific guint to guint32.
2646 * src/modest-search.c:
2648 Added strange hack which magically made tnymail work.
2650 (modest_search_folder),
2651 (modest_search_account),
2652 (modest_search_all_accounts):
2653 Implement helper functions to search all accounts, specific account
2656 * tests/dbus_api/Makefile.am:
2657 * tests/dbus_api/test_open_message.c:
2658 Read url to open from commandline.
2660 * tests/dbus_api/test_search.c:
2661 Implement small test for dbus search stuff
2663 2007-06-02 Armin Burgmeier <armin@openismus.com>
2665 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2666 include account type and account title. This fixes projects.maemo.org
2669 * src/maemo/modest-account-view-window.c: Set a title for the window.
2671 2007-06-02 Armin Burgmeier <armin@openismus.com>
2673 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2674 incoming and outgoing server name based on email address and server
2675 types as long as the names have not been edited manually. This fixes
2676 projects.maemo.org bug NB#58671.
2678 2007-06-02 Armin Burgmeier <armin@openismus.com>
2680 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2681 server type cannot be changed in future to the incoming details page
2682 when creating an account. This fixes projects.maemo.org bug NB#59029.
2684 2007-06-02 Armin Burgmeier <armin@openismus.com>
2686 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2687 and assigned max width chars so that they wrap instead of being
2688 truncated. Fixes projects.maemo.org bug NB#56126.
2690 2007-06-02 Armin Burgmeier <armin@openismus.com>
2692 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2693 introductory note to the connection specific smtp servers dialog, as
2694 section 8.12 of the email UI specification requires. This fixes
2695 projects.maemo.org bug NB#59212.
2697 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2699 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2700 Check for running mail operations, and offer to cancel them, as per the UI
2701 spec. This fixes projects.maemo.org bug NB#59041 .
2702 However, I suspect that tinymail may still use the network connection
2703 in ways that we cannot detect or cancel. But it should at least adapt to
2704 changes fairly well.
2706 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2708 * src/modest-tny-account-store.c: (recreate_all_accounts),
2709 (get_cached_accounts), (get_server_accounts): Do more sensible
2710 ref-counting of the temporarily-cached outbox accounts list. This seems
2711 to fix a crash when entering the password when the password was wrong.
2713 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2715 * src/gnome/modest-main-window.c: (connect_signals):
2716 * src/modest-tny-account-store.c: (get_password),
2717 (modest_tny_account_store_alert): Added comments and clues and
2718 commented-out code about how we currently fail to deal with connection
2719 errors and wrong passwords, and how we should.
2721 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2723 * src/widgets/modest-retrieve-combo-box.c:
2724 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2725 This fixes projects.maemo.org bug NB#58472 .
2727 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2729 * src/maemo/easysetup/modest-easysetup-wizard.c:
2730 (create_page_complete_easysetup):
2731 (create_page_complete_custom): Correct the last commit,
2732 putting the correct sentences in the correct pages.
2734 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2736 * src/maemo/easysetup/modest-easysetup-wizard.c:
2737 (create_page_complete_custom): Show the second sentence of text
2738 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2741 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2743 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2744 Set the leave-on-server conf key by default. This fixes
2745 projects.maemo.org bug NB#59258 .
2747 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2749 * src/maemo/modest-account-view-window.c:
2750 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2751 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2754 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2756 * src/maemo/easysetup/modest-easysetup-wizard.c:
2757 (create_caption_new_with_asterisk):
2758 * src/maemo/modest-account-settings-dialog.c:
2759 (create_caption_new_with_asterisk):
2760 Uncomment the code to add the asterisk, because they are no longer in the
2761 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2762 (update_incoming_server_title): Add an asterisk here too.
2764 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2766 * src/maemo/modest-maemo-global-settings-dialog.c:
2767 (current_connection): Check that we are even connected before trying to
2768 get the current connection name, to prevent a warning.
2770 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2771 Change the comments because tny_maemo_conic_device_connect() is now meant to
2773 * src/modest-mail-operation.c:
2774 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2775 make sure we have a connection and fail if we can't connect.
2777 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2779 * src/maemo/modest-main-window.c:
2780 (on_account_store_connecting_finished): Do not try to get the
2781 connection ID if we are not really connected. I am surprised that
2782 this signal handler is called when we are not connected.
2784 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2786 * src/modest-error.h:
2787 * src/modest-ui-actions.c:
2788 (modest_ui_actions_get_msgs_full_error_handler):
2789 Renamed an enum, added comments, added an enum
2790 for retrieve-limit errors.
2792 * src/modest-mail-operation.c: (foreach_add_item),
2793 (internal_folder_observer_update), (update_account_thread),
2794 (modest_mail_operation_get_msgs_full):
2795 (modest_mail_operation_update_account),
2796 Added comments about how this works, and some code that should
2797 (but does not) check the retrieve-limit. See the TODO comment.
2799 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2801 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2802 Initialize help_id to fix the build. Warnings are good.
2804 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2806 * src/widgets/modest-hbox-cell-renderer.c:
2807 (modest_hbox_cell_renderer_append):
2808 * src/widgets/modest-vbox-cell-renderer.c:
2809 (modest_vbox_cell_renderer_append):
2810 Fix the last commit by doing an extra ref.
2812 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2814 * src/widgets/modest-hbox-cell-renderer.c:
2815 (modest_hbox_cell_renderer_append):
2816 * src/widgets/modest-vbox-cell-renderer.c:
2817 (modest_vbox_cell_renderer_append):
2818 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2819 to fix the build with Maemo Bora.
2820 However, there seems to be a remaining crash, probably due to reference
2823 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2825 * src/modest-tny-account.c:
2826 (modest_tny_account_new_for_local_folders):
2827 Use hildon_file_system_info_async_new() to get a better name for
2828 the memory card account, setting it as the account name.
2829 The timing seems to work, but this is probably
2830 not the best place to do this. See the TODO comment.
2831 * src/maemo/modest-main-window.c: (create_details_widget):
2832 * src/widgets/modest-folder-view.c: (text_cell_data):
2833 Use the tny account name instead of hardcoding a name.
2835 2007-05-30 Christian Kellner <ckellner@openismus.com>
2837 * src/modest-search.c: (modest_search):
2838 Correctly set part_search_func even if we have already parsed
2839 the query and thus a valid OgsTextSearcher object.
2841 2007-05-30 Christian Kellner <ckellner@openismus.com>
2844 Search and check for libogs.
2847 Incooparte the ogs build env.
2849 * src/modest-mime-part-search-stream.c:
2850 * src/modest-mime-part-search-stream.h:
2851 Removed since we do the real searching now in modest-search.c.
2853 * src/modest-search.c:
2854 * src/modest-search.h:
2855 Implement support for ogs. We use that if available and requested
2856 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2857 should now handle the corner case when the search term is spread
2858 across multiple reads.
2859 Also the logic in modest_search () was corrected to search all
2860 requested fields until one is found.
2862 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2864 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2866 * src/modest-init.h:
2867 * src/modest-init.c: Made modest_init_local_folders() take a
2868 path and be public so we can iniitialize maildir folders on
2871 * src/modest-local-folder-info.h:
2872 * src/modest-local-folder-info.c:
2873 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2875 * src/modest-tny-account.c:
2876 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2877 still means the standard local-folders path on the local volume.
2879 * src/modest-tny-account-store.c:
2880 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2881 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2882 all accounts when that happens.
2883 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2884 this too, so it shows up in the treeview.
2886 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2888 * src/maemo/modest-maemo-global-settings-dialog.c:
2889 (current_connection):
2890 * src/widgets/modest-global-settings-dialog.c:
2891 (current_connection_default):
2892 Use the enum values instead of 0, 1 and -1,
2893 to make the code clearer.
2895 * src/modest-account-mgr-helpers.c:
2896 (modest_account_mgr_get_connection_specific_smtp): Make this code
2899 * src/modest-runtime.h:
2900 * src/modest-runtime.c:
2901 Added modest_runtime_remove_all_send_queues().
2902 * src/maemo/modest-main-window.c:
2903 (on_account_store_connecting_finished): Recreate the send queues,
2904 using the appropriate transport accounts for this new connection.
2905 Some futher adapting might be needed if the old send queues are not
2906 automatically stopped at this point.
2908 * src/modest-tny-account-store.c: (get_server_accounts):
2909 Create the connection-specific transport accounts, so that they can
2910 be found later by their ID.
2912 * src/modest-tny-account.h:
2913 * src/modest-tny-account.c:
2914 Added modest_tny_account_new_from_server_account_name().
2915 modest_tny_account_new_from_server_account(): Do not create the
2916 send queues here, because they will be
2917 recreated anyway when the connection changes for the first time.
2919 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2921 * src/modest-local-folder-info.h:
2922 * src/modest-local-folder-info.c:
2923 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2924 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2925 tbox_folder): Take a modest account name instead of a server TnyAccount,
2926 so we can have per-modest-account rather than per-transport-account
2928 We must make sure that we change or recreate the exisitng send queues
2929 when the connection changes for connection-specific transport accounts.
2931 * src/modest-tny-account-store.c:
2932 (create_per_account_local_outbox_folders): Create outboxed per modest
2933 account, not per transport account.
2935 * src/modest-tny-account.h:
2936 * src/modest-tny-account.c:
2937 (modest_tny_account_get_special_folder): For outboxes, get the
2938 parent modest account name. The account is ignored for other folders.
2939 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2940 modest account name rather than a server TnyAccount.
2942 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2944 * src/modest-tny-account.c:
2945 (modest_tny_account_new_from_server_account):
2946 Call modest_runtime_get_send_queue() immediately after creating transport
2947 accounts, so that they start trying to send email from the outbox as soon
2948 as possible at startup. This is probably what we want.
2950 * src/modest-mail-operation.c: (update_account_thread):
2951 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2952 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2953 * src/modest-tny-send-queue.h:
2954 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2955 (modest_ui_actions_on_send):
2956 Added comments about how sending works, though it needs some more work.
2958 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2960 * src/modest-tny-account.c:
2961 (modest_tny_account_get_special_folder): Add TODO because this fails when
2962 the network is busy.
2963 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2964 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2965 Do not try to show this window when there is no active account. The UI
2966 specs does not tell us what to do in this case.
2968 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/Makefile.am:
2973 * src/widgets/Makefile.am: Some dist fixes.
2975 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2977 * src/maemo/modest-connection-specific-smtp-window.c:
2978 (on_button_edit): Make the code clearer, to prevent a double free.
2980 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2982 * src/maemo/modest-account-settings-dialog.c:
2983 (modest_account_settings_dialog_set_account_name),
2984 Check the connection-specific smtp servers checkbox if there are any.
2986 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2987 (modest_connection_specific_smtp_edit_window_init):
2988 Start with a suitable port number.
2990 * src/modest-account-mgr-helpers.h:
2991 * src/modest-account-mgr-helpers.c: Added
2992 modest_account_mgr_get_has_connection_specific_smtp().
2994 (modest_account_mgr_set_connection_specific_smtp),
2995 (modest_account_mgr_remove_connection_specific_smtp),
2996 (modest_account_mgr_get_has_connection_specific_smtp),
2997 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2998 connection-specific smtp server accounts in the account, rather than
2999 the server account conf dir.
3001 This fixes bug projects.maemo.org bug NB#58263 .
3003 * src/modest-tny-account-store.c:
3004 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
3005 if there are no server accounts yet, to prevent an infinite loop when there
3006 are no accounts. Document that one must be called before the other.
3008 2007-05-24 Murray Cumming <murrayc@murrayc.com>
3010 * src/modest-account-mgr-helpers.c:
3011 (modest_account_mgr_get_default_account): Make sure that at least
3012 one account is always the default, if there are any enabled accounts.
3013 This is just a sanity check that shouldn't be necessary.
3015 * src/modest-account-mgr-priv.c:
3016 (_modest_account_mgr_account_from_key): Unescape the conf key to
3017 get the real account name. For instance, this is an issue if a space
3018 was in the account name, which can happen because the account name
3019 is generated from the display name.
3020 (_modest_account_mgr_get_account_keyname): Always escape the
3022 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
3023 Unescape the conf keys to get the real account names.
3025 For instance, previously the is-default radio button in the accounts
3026 list was not checked for any accounts at first. This fixes that,
3027 and might fix several similar bugs.
3029 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3031 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
3032 Removed some debug printfs.
3034 2007-05-23 Murray Cumming <murrayc@murrayc.com>
3036 Modest on-disk outbox directories are now here, for instance:
3037 $HOME/.modest/outboxes/<account-id-1>/outbox
3038 $HOME/.modest/outboxes/<account-id-2>/outbox
3040 $HOME/.modest/local-folders/outbox
3041 so we can have a separate outbox for each account.
3042 But they are shown as one outbox in the GtkTreeView, by using a
3043 TnyMergeFolder in a ModestTnySimpleFolderStore.
3046 * src/modest-tny-simple-folder-store.c:
3047 * src/modest-tny-simple-folder-store.h:
3048 Added ModestTnySimpleFolderStore, used to contain folders from
3049 other folder stores, such as other accounts.
3051 * src/modest-tny-outbox-account.h:
3052 * src/modest-tny-outbox-account.c:
3053 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
3054 used for the per-account local outbox folders.
3056 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
3057 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
3058 only use this (internally) now for the non-outbox local folders.
3060 * src/modest-init.h:
3061 * src/modest-init.c: Added modest_init_one_local_folder(), for
3062 setting up the directory structure for each local folder.
3064 * src/modest-local-folder-info.c:
3065 (modest_per_account_local_outbox_folder_info_get_maildir_path),
3066 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
3068 * src/modest-local-folder-info.h:
3069 * src/modest-tny-account-store.c: (on_account_removed),
3070 (on_account_changed), (create_per_account_local_outbox_folders),
3071 (get_server_accounts), (modest_tny_account_store_get_accounts),
3072 (modest_tny_account_store_get_tny_account_by_account),
3073 (modest_tny_folder_store_is_virtual_local_folders):
3075 * src/modest-tny-account.h:
3076 * src/modest-tny-account.c:
3077 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
3078 to create an on-disk per-account local outbox folder for each
3080 (create_per_account_local_outbox_folders): Create a local outbox folder
3081 for each transport account.
3082 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
3083 for all local folders.
3085 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
3086 instead of using g_object_get/set() directly. It is clearer.
3088 (modest_tny_folder_store_get_message_count),
3089 (modest_tny_folder_store_get_local_size
3090 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
3091 because we now use these with non-acount folder stores.
3093 (modest_tny_account_get_special_folder),
3094 (modest_tny_account_new_from_server_account),
3095 (modest_tny_account_new_from_account):
3096 (recurse_folders): Adjust to the new outbox system.
3098 * src/modest-tny-folder.h:
3099 * src/modest-tny-folder.c:
3100 (modest_tny_folder_is_local_folder),
3101 (modest_tny_folder_get_local_folder_type),
3102 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
3104 * src/widgets/modest-main-window.h:
3105 * src/maemo/modest-main-window.c: (create_details_widget),
3106 (modest_main_window_set_contents_style): Show details for any folder store,
3109 (modest_tny_folder_get_rules):
3110 Remove the const. C does not support constness enough for this.
3112 * src/modest-ui-actions.c:
3113 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3114 make all outboxes appear as one, in the usual local-folders tree node.
3116 (set_active_account_from_tny_account),
3117 (modest_ui_actions_on_folder_selection_changed):
3118 * src/widgets/modest-folder-view.c: (text_cell_data),
3119 (icon_cell_data), (filter_row),
3120 (add_account_folders_to_merged_folder),
3121 (add_account_folders_to_simple_folder_store), (),
3122 (get_cmp_rows_type_pos), (cmp_rows),
3123 (modest_folder_view_set_account_id_of_visible_server_account):
3124 Adjust to the new outbox system, using generic folder stores and folders
3125 in the GtkTreeModel.
3127 2007-05-23 Christian Kellner <ckellner@openismus.com>
3129 * src/modest-mail-operation.c:
3130 (modest_mail_operation_update_account):
3131 Use info->max_size instead of unintialized local var [small
3132 build fix]. (Added TODO to review that change since I don't
3135 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3137 * libmodest-dbus-client/libmodest-dbus-client.c:
3138 (libmodest_dbus_client_compose_mail): function added
3139 * src/dbus_api/modest-dbus-api.h:
3140 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3141 (on_compose_mail): Implementation of the SendAsMail functionality
3143 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3145 * src/modest-account-mgr.c:
3146 (modest_account_mgr_add_server_account): Set the secure-connection
3147 conf key for transport accounts as well as store accounts. I don't know
3148 why the if was there. For instance, this makes sure that we use SSL
3149 for the gmail preset from the easysetup wizard.
3151 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3153 * src/gnome/modest-main-window.c:
3154 (on_account_store_connecting_finished), (connect_signals):
3155 * src/maemo/modest-main-window.c:
3156 (on_account_store_connecting_finished), (connect_signals),
3157 (modest_main_window_new):
3158 Handle TnyAccountStore::connecting-finished instead of
3159 TnyDevice::connection-changed, because we cannot actually perform
3160 operations on accounts until TnyAccountStore has itself responded to
3161 the TnyDevice::connection-changed signal. This prevents a GError from
3163 Do not try to update at startup, because we (at least on scratchbox)
3164 already do an update at startup when the device goes online.
3165 This prevents a GError from tinymail.
3166 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3167 Added TODO about stopping simultaneous operations.
3169 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3171 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3172 * src/modest-mail-operation-queue.c:
3173 (modest_mail_operation_queue_remove):
3174 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3175 about where they happened.
3177 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3179 * src/modest-ui-actions.c:
3180 (modest_ui_actions_on_password_requested): Make sure that the remember
3181 output parameter is always TRUE.
3183 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3185 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3186 Show a OK/Cancel dialog if the error is a question, though we still do not
3187 know anything more about what we are asking the user.
3188 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3189 Fix an uninitialized variable (helper). This is a logic error, however.
3191 2007-05-21 Christian Kellner <ckellner@openismus.com>
3193 * src/modest-search.h:
3194 Correct bit shifting in the ModestSearchFlags enum.
3196 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3198 * src/modest-tny-account.c:
3199 (modest_tny_account_new_from_server_account): Do not use the lsub and
3200 check-all hard-coded IMAP options when using POP.
3202 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3204 * src/modest-tny-account.c:
3205 (modest_tny_account_new_from_server_account):
3206 Use NULL for the secure-auth method for POP when Password auth has been
3207 specified by the user, as we already do for IMAP. "auth=Login" causes
3208 an error from camel or the server.
3210 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3212 * src/maemo/modest-account-settings-dialog.c:
3213 (create_page_account_details),
3214 (modest_account_settings_dialog_set_account_name):
3215 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3216 for the leave-on-server checkbox, rathr than just the checkbox, when
3217 the protocol is not POP.
3219 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3221 * src/widgets/modest-account-view.c:
3222 * src/widgets/modest-account-view.h:
3223 Added modest_account_view_select_account() which will be useful later
3224 to asynchronously re-select the edited account.
3226 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3228 * src/maemo/modest-account-settings-dialog.c:
3229 (modest_account_settings_dialog_set_account_name):
3230 Automatically choose the port numbers based on the secure authentication
3231 methods, if they have not been chosen before.
3232 This fixes projects.maemo.org bug NB#56273 .
3234 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3236 * src/maemo/modest-main-window-ui.h:
3237 * src/modest-ui-actions.c:
3238 * src/modest-ui-actions.h:
3239 Connect the Tools/SMTP Servers menu item to
3240 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3241 SMTP servers dialog, as in the UI specification and saves changes when it
3242 is closed. This fixed projects.maemo.org bug NB#56305 .
3244 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/modest-connection-specific-smtp-window.c:
3247 (modest_connection_specific_smtp_window_init):
3248 Use gtk_window_set_default_size() to make this window big enough, so
3249 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3251 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3253 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3254 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3255 (modest_connection_specific_smtp_edit_window_init),
3256 Do not try to connect to a combobox signal before the combobox exists.
3257 This fixes the cras in projects.maemo.org bug NB#56288 .
3258 (modest_connection_specific_smtp_edit_window_get_settings):
3259 Remove the server_account_name parameter which was being checked for NULL
3260 though it was not used.
3262 * src/maemo/modest-connection-specific-smtp-window.c:
3263 (modest_connection_specific_smtp_window_fill_with_connections),
3264 (on_button_edit), (modest_connection_specific_smtp_window_init):
3265 Correct the number of treemodel columns to prevent a warning.
3266 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3267 libconic does not work.
3269 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3271 * src/modest-tny-account.c:
3272 (modest_tny_account_new_from_server_account):
3273 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3274 SMTP when "None" was chosen by the user. However, with my SMTP server that
3275 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3278 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3281 to explain the memory management issue with the ID in the ModestPair.
3283 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3284 (add_sending_page), (modest_account_assistant_finalize):
3285 * src/gnome/modest-gnome-global-settings-dialog.c:
3286 (create_updating_page), (create_composing_page):
3287 * src/gnome/modest-msg-edit-window.c: (get_transports),
3288 (init_window), (modest_msg_edit_window_finalize),
3289 (modest_msg_edit_window_get_msg_data):
3290 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3291 * src/gnome/modest-transport-widget.c:
3292 (modest_transport_widget_finalize), (smtp_configuration):
3293 * src/maemo/modest-maemo-global-settings-dialog.c:
3294 (create_updating_page), (create_composing_page):
3295 * src/maemo/modest-msg-edit-window.c: (get_transports),
3296 (init_window), (modest_msg_edit_window_finalize),
3297 (modest_msg_edit_window_get_msg_data),
3298 (modest_msg_edit_window_free_msg_data):
3299 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3300 (modest_store_widget_finalize):
3301 * src/maemo/modest-transport-widget.c:
3302 (modest_transport_widget_finalize), (smtp_configuration):
3303 * src/modest-main.c: (send_mail):
3304 * src/widgets/modest-combo-box.h:
3305 * src/widgets/modest-global-settings-dialog-priv.h:
3306 * src/widgets/modest-global-settings-dialog.c:
3307 (modest_global_settings_dialog_finalize):
3308 * src/widgets/modest-msg-edit-window.h:
3309 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3310 as long as the combo box, to prevent use of freed memory for the ID.
3312 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3314 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3315 get_accounts(), to make this clearer. Do not check for the enabled gconf
3316 key, because we do not use this for server accounts (at least, not yet).
3317 This allows us to send email again.
3319 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3321 * src/maemo/modest-platform.c:
3322 (on_modest_conf_update_interval_changed), (modest_platform_init):
3323 Only respond to this particular key change. All these strcmp()s cannot be
3326 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3328 * src/maemo/modest-maemo-global-settings-dialog.c:
3329 (current_connection): Prevent a crash in scratchbox when
3330 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3331 * src/maemo/modest-platform.c:
3332 (on_modest_conf_update_interval_changed), (modest_platform_init):
3333 Get the update interval from gconf and reset it when the gconf key changes.
3335 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3337 * src/modest-protocol-info.c:
3338 * src/modest-protocol-info.h: Adde enum-specific get functions,
3339 instead of using a ModestProtocolType enum parameter.
3341 * src/gnome/modest-account-assistant.c:
3342 * src/gnome/modest-store-widget.c:
3343 * src/gnome/modest-store-widget.h:
3344 * src/gnome/modest-transport-widget.c:
3345 * src/gnome/modest-transport-widget.h:
3346 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3347 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3348 * src/maemo/easysetup/modest-easysetup-wizard.c:
3349 * src/maemo/modest-account-settings-dialog.c:
3350 * src/maemo/modest-account-settings-dialog.h:
3351 * src/maemo/modest-store-widget.c:
3352 * src/maemo/modest-store-widget.h:
3353 * src/maemo/modest-transport-widget.c:
3354 * src/maemo/modest-transport-widget.h:
3355 * src/modest-account-mgr-helpers.c:
3356 * src/modest-account-mgr-helpers.h:
3357 * src/modest-account-mgr.c:
3358 * src/modest-account-mgr.h:
3359 * src/modest-tny-account.c:
3360 * src/modest-tny-folder.c:
3361 * src/widgets/modest-account-view.c:
3362 * src/widgets/modest-retrieve-combo-box.c:
3363 * src/widgets/modest-retrieve-combo-box.h:
3364 * src/widgets/modest-secureauth-combo-box.c:
3365 * src/widgets/modest-serversecurity-combo-box.c:
3366 * src/widgets/modest-serversecurity-combo-box.h:
3367 * tests/check_account-mgr.c:
3368 Use the specific functions, and use the re-renamed enum values for GNOME too.
3370 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3372 * src/modest-pair.h:
3373 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3374 so we can get the second based on the first.
3376 * src/maemo/modest-account-settings-dialog.h:
3377 * src/maemo/modest-account-settings-dialog.c:
3378 Added get_supported_secure_authentication_methods(), though it is mostly
3379 commented-out for now until the necessary API is committed to tinymail.
3380 (modest_account_settings_dialog_set_account_name),
3381 (save_configuration): Request the supported authentication methods from the
3382 server, so we can choose a working method.
3384 * src/modest-tny-account-store.h:
3385 * src/modest-tny-account-store.c:
3386 (modest_tny_account_store_get_session): Rename from
3387 tny_account_store_get_session().
3389 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3391 * src/modest-protocol-info.h: Split the ModestProtocol enum
3392 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3393 There was no need to have these unrelated values in one enum.
3395 * src/: many files: Adapted to changed enum. This makes the code a bit
3396 clearer, and the compiler could catch some errors.
3398 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3400 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3401 Show the detailed internal camel error message when an error happens
3402 during the configuration, so that our testers can give us more clues.
3403 For instance, in projects.maemo.org bug NB#56910 .
3405 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3407 * src/modest-tny-account.c:
3408 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3409 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3411 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3413 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3414 * src/maemo/modest-account-settings-dialog.c:
3415 (modest_account_settings_dialog_set_account_name),
3416 (save_configuration): For the incoming secure authentication checkbox,
3417 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3418 the UI specification. PLAIN does not seem to be supported for most IMAP
3419 servers anyway, and I am not sure what it would mean.
3420 However, we probably need to discover which of the secure-authentication
3421 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3422 * src/modest-account-mgr-helpers.c:
3423 (modest_account_mgr_get_server_account_data):
3425 * src/modest-tny-account.c:
3426 (modest_tny_account_new_from_server_account):
3427 Use tny_account_set_mech() to set secure-authentication methods,
3428 with some special-casing for IMAP, based on my observations of how
3431 * src/modest-account-mgr-helpers.h:
3432 * src/modest-account-mgr.c:
3433 * src/modest-defs.h: Comment that the URI is only used for local folders.
3435 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3437 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3438 parameter const, just to be neat.
3439 * src/modest-text-utils.c: (modest_text_utils_inline):
3440 End g_strconcat() with NULL, as its documentation says. This is almost
3441 certainly the cause of my crash at startup on the device. Interestingly,
3442 valgrind doesn't tell us about these errors.
3444 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3446 * scripts/build-packages: Added more precise comments about how to use
3447 this script, though I still get this error:
3448 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3449 error building tinymail
3451 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3453 * src/maemo/modest-main-window.c: (on_account_update):
3454 Very slight cleanup, hoping to make it simpler to discover what causes
3455 a crash here sometimes.
3457 * src/modest-tny-account.c:
3458 (modest_tny_account_new_from_server_account): Set the port. Added
3459 comments about the options and a TODO comment because I need to find out
3460 how to specify the secure authentication method.
3462 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3464 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3465 changed CFlags paths form modest to libmodest
3467 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3469 * src/modest-account-mgr-helpers.c:
3470 (modest_account_mgr_get_server_account_data),
3471 (modest_account_mgr_free_server_account_data):
3472 * src/modest-account-mgr-helpers.h:
3473 * src/modest-account-mgr.c:
3474 (modest_account_mgr_add_server_account):
3475 * src/modest-defs.h:
3476 * src/modest-tny-account.c:
3477 (modest_tny_account_new_from_server_account):
3478 Determine the options for tny_camel_account_add_option() here,
3479 based on the settings, rather than storing them directly in gconf.
3481 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3484 Show a more friendly error dialog now that we expect (from the tinymail
3485 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3487 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/modest-main-window.c: (on_account_update): Check that
3490 account_name is not NULL, to prevent a crash at startup that I am
3491 seeing on the N800. I do wonder why it is NULL.
3493 * src/maemo/easysetup/modest-easysetup-wizard.c:
3494 (create_page_user_details):
3495 * src/maemo/modest-account-settings-dialog.c:
3496 (create_page_user_details), (create_page_outgoing):
3497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3498 (modest_connection_specific_smtp_edit_window_init):
3499 * src/modest-ui-actions.c:
3500 (modest_ui_actions_on_password_requested):
3501 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3502 might do something useful with the on-screen keyboard.
3504 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3506 * src/maemo/modest-main-window.c: (on_account_update):
3507 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3508 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3510 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3512 * src/modest-tny-account-store.c: (on_account_changed):
3513 Correct the signature of this signal handler.
3515 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3517 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3518 Show a HildonNote instead of a GtkDialog for Maemo.
3520 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3522 * src/widgets/modest-account-view.h:
3523 * src/widgets/modest-account-view.c: (on_account_changed),
3524 (on_account_removed). Added a boolean flag, set/unset by
3525 modest_account_view_block_conf_updates(),
3526 modest_account_view_unblock_conf_updates() to prevent unnecessary
3527 updates, but this is not very useful because the gconf notifications are
3528 so delays (maybe only on Maemo Bora).
3529 So auto-updating is turned off, and these functions do an explicit
3530 update when necessary.
3531 However, something else is still doing too much work when adding/removing
3532 accounts, probably in another part of the application.
3534 * src/maemo/modest-account-view-window.c:
3535 (on_delete_button_clicked), (on_edit_button_clicked),
3536 (on_new_button_clicked): Use the new functions.
3538 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3540 * src/modest-account-mgr-helpers.c:
3541 (modest_account_mgr_set_first_account_as_default):
3542 Sort the list of names alphabetically-by-title, so we choose the first one
3544 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3545 alphabetically by the title.
3547 This fixes projects.maemo.org bug NB#56418 .
3549 * src/modest-account-mgr-priv.c:
3550 (_modest_account_mgr_account_from_key):
3551 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3552 avoid a valgrind error, and possible random behaviour.
3554 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3556 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3557 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3558 tinymail documentation to say that this can be expected.
3559 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3560 pretty, and should not happen, but I would prefer to know when it does.
3562 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3564 * configure.ac: When using the older hildon version, probably on Bora,
3565 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3567 * src/widgets/modest-attachment-view.c:
3568 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3571 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3573 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3574 Implemented the prototype. Can be tested with
3575 tests/dbus_api/test_open_message:
3577 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3579 * src/modest-tny-account-store.c:
3580 (modest_tny_account_store_instance_init), (get_password):
3581 * src/modest-ui-actions.c:
3582 (modest_ui_actions_on_password_requested):
3583 Do not store the password in gconf, because this function is called
3584 for non-remembered passwords. Actually use the cached (in the hash map)
3585 password instead of releasing it.
3586 The password will now not be remembered if it is asked via the protected
3587 password dialog, as per the UI spec.
3589 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3591 * src/modest-defs.h:
3592 * src/modest-account-mgr-helpers.h:
3593 * src/modest-account-mgr-helpers.c:
3594 Added modest_server_account_get_username_has_succeeded(),
3595 modest_server_account_set_username_has_succeeded().
3596 (modest_server_account_set_username),
3597 Reset the has-succeeded flag if the username changes.
3599 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3600 * src/maemo/modest-connection-specific-smtp-window.c:
3601 (modest_connection_specific_smtp_window_save_server_accounts):
3602 Use modest_server_account_set_username() instead of using
3603 modest_conf_set_string() directly, so that the has-succeeded flag is always
3606 * src/modest-ui-actions.c:
3607 (modest_ui_actions_on_password_requested): Dim the username entry if
3608 the username has ever worked, as per the UI spec.
3610 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3612 * src/modest-tny-account-store.c: (get_password):
3613 * src/modest-ui-actions.c:
3614 (modest_ui_actions_on_password_requested):
3615 Allow the username to be changed too, though there is more work to
3616 be done on exactly how this behaves.
3618 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3620 * src/modest-account-mgr-helpers.h:
3621 * src/modest-account-mgr-helpers.c:
3622 Added modest_account_mgr_get_display_name(),
3623 modest_server_account_get_username(),
3624 modest_server_account_set_username(),
3625 modest_server_account_set_password(),
3626 modest_server_account_get_hostname() functions so we do not need to
3627 use the conf API directly.
3629 * src/maemo/modest-main-window.c: (connect_signals):
3630 Actually connect ot the ModestAccountStore::request-password signal,
3631 so that we show the dialog when the password is requested by Tinymail,
3632 for isntance if it is empty.
3634 * src/modest-marshal.list:
3635 * src/modest-tny-account-store.c:
3636 (modest_tny_account_store_class_init), (get_password),
3637 (modest_tny_account_store_alert):
3638 * src/modest-tny-account-store.h:
3639 * src/modest-ui-actions.h:
3640 * src/modest-ui-actions.c:
3641 (modest_ui_actions_on_password_requested):
3642 Change the signal parameters, so it is obvious that we are providing
3643 the non human-readable server name, and receiving both the username
3644 and password, though changing of the username is not yet implemented.
3645 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3646 for the GNOME version.
3648 This should fix the projects.maemo.org bug NB#56209, though it does not
3649 work on Bora, because the gconf_client_get() for the password fails
3650 immediately after we save it with gconf_client_set().
3652 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3655 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3656 caused an undefined symbol error:
3657 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3659 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3661 * src/modest-tny-account-store.c:
3662 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3663 using a GError instead of a string message, so we can translate it in
3666 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3668 * src/maemo/modest-address-book.c:
3669 (modest_address_book_check_names):
3670 * src/maemo/modest-msg-view-window.c:
3671 (modest_msg_view_window_clipboard_owner_change):
3672 * src/modest-init.c: (modest_init_init_ui):
3673 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3674 (update_folders_cb), (modest_mail_operation_update_account):
3675 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3676 (modest_ui_actions_on_msg_attachment_clicked),
3677 (modest_ui_actions_on_msg_recpt_activated):
3678 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3679 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3680 (modest_msg_view_search_next):
3681 * src/widgets/modest-recpt-editor.c:
3682 (modest_recpt_editor_on_button_release_event),
3683 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3684 g_message(). At this point we should only be seeing interesting errors on
3685 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3687 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3689 (modest_wizard_dialog_force_title_update):
3690 * src/maemo/easysetup/modest-wizard-dialog.h:
3691 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3692 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3693 can update the title when appropriate. Otherwise the title is wrong if the
3694 pages are added after adding the notebook to the dialog.
3695 This must be a problem in HildonWizardDialog too.
3696 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3698 * src/maemo/easysetup/modest-easysetup-wizard.c:
3699 (create_subsequent_customsetup_pages),
3700 (create_subsequent_easysetup_pages):
3701 Call modest_wizard_dialog_force_title_update() so that the title is
3702 correct even with GTK+ < 2.10.
3703 This fixes projects.maemo.org bug NB#56145 .
3705 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3707 * src/maemo/modest-platform.c:
3708 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3709 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3712 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3714 * src/widgets/modest-window.h:
3715 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3716 and modest_window_save_state(), which invokes it.
3718 * src/widgets/modest-window-mgr.h:
3719 * src/widgets/modest-window-mgr.c:
3720 Added modest_window_mgr_save_state_for_all_windows(), which calls
3721 the save_state vfunc on all registered windows, if implemented.
3723 * src/gnome/modest-msg-edit-window.c:
3724 * src/gnome/modest-msg-view-window.c:
3725 * src/maemo/modest-msg-edit-window.c:
3726 * src/maemo/modest-msg-view-window.c:
3727 * src/maemo/modest-main-window.c:
3728 Specify the existing save_settings functions as implementations of
3729 ModestWindow::save_state_func().
3731 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3732 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3733 enabling hibernation, for instance.
3735 We may need to do the same thing for restoring settings.
3738 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3740 * src/widgets/modest-window-mgr.c:
3741 * src/widgets/modest-window-mgr.h:
3742 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3743 modest_window_mgr_get_hibernation_is_prevented().
3745 * src/maemo/modest-main-window.c:
3746 (on_hildon_program_is_topmost_notify): Prevent hibernation
3747 (possible when the application goes to the background in the WM),
3748 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3750 * src/maemo/easysetup/modest-easysetup-wizard.c:
3751 (modest_easysetup_wizard_dialog_init):
3752 * src/maemo/modest-account-settings-dialog.c:
3753 (modest_account_settings_dialog_init):
3754 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3755 (modest_connection_specific_smtp_edit_window_init):
3756 * src/maemo/modest-connection-specific-smtp-window.c:
3757 (modest_connection_specific_smtp_window_init):
3758 * src/maemo/modest-signature-editor-dialog.c:
3759 (modest_signature_editor_dialog_init):
3760 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3761 prevent hibernation while any of these account settings dialogs are open.
3763 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/Makefile.am:
3766 * src/maemo/modest-osso-state-saving.c:
3767 * src/maemo/modest-osso-state-saving.h: Added
3768 modest_osso_load_state() and modest_osso_save_state() though they do
3769 nothing now. They should iterate through all the open windows and load/save
3771 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3772 save state when closing.
3774 * src/maemo/modest-main-window.c:
3775 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3776 Add a notification handler for the HildonProgram::is-topmost property,
3777 so we can allow hibernation when the application goes into the background.
3778 But we still need to detect when the accounts setup windows are open so
3779 we can stop hibernation when they are open.
3780 To do this, I also added the main window the HildonProgram. This might have
3781 other side-effects/benefits, and should maybe be done for other windows.
3783 * src/maemo/modest-osso-autosave-callbacks.h:
3784 * src/maemo/modest-osso-autosave-callbacks.c:
3785 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3786 though it does not do anything yet, and we might never need this to do
3787 anything. For instance, we already save drafts.
3789 * src/maemo/modest-platform.c: (modest_platform_init):
3790 Specify the libosso auto-save callback.
3792 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3794 * src/maemo/modest-platform.c:
3795 (modest_platform_set_update_interval):
3796 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3797 aparently stays valid between application instances, so we can use this
3798 to remove and reset it later. According to a maemo-developers email from
3801 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3803 * configure.ac: Depend on libalarm for Maemo.
3805 * src/dbus_api/modest-dbus-api.h:
3806 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3807 (on_send_receive), (modest_dbus_req_handler):
3808 Handle a SEND_RECEIVE D-Bus method.
3810 * libmodest-dbus-client/libmodest-dbus-client.c:
3811 (libmodest_dbus_client_send_and_receive):
3812 * libmodest-dbus-client/libmodest-dbus-client.h:
3813 Add C convenience functions for calling the new D-Bus method.
3815 * src/modest-platform.h:
3816 * src/gnome/modest-platform.c:
3817 * src/maemo/modest-platform.c:
3818 Added modest_platform_set_update_interval(), which uses the
3819 alarmd API on Maemo.
3820 (modest_platform_init),
3821 Call modest_platform_set_update_interval(), using a hard-coded
3822 interval for now (until the global settings dialog is implemented),
3823 though I am not sure that this makes sense yet.
3825 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3827 * src/dbus_api/modest-dbus-callbacks.c:
3828 (modest_osso_cb_hw_state_handler):
3829 * src/dbus_api/modest-dbus-callbacks.h:
3830 * src/maemo/modest-platform.c: (modest_platform_init):
3831 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3832 in case this has some effect on the ability for Maemo to ping the
3835 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3837 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3838 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3839 warning. It is probably a logic error, but I need to fix the build.
3841 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3843 * src/modest-account-mgr.h:
3844 * src/modest-account-mgr.c:
3845 (modest_account_mgr_account_names): Add a gboolean enabled_only
3846 parameter, so we can get lists of onlt the enabled accounts.
3848 (modest_account_mgr_add_account),,
3849 (modest_account_mgr_account_with_display_name_exists):
3850 * src/maemo/modest-msg-edit-window.c: (get_transports):
3851 * src/modest-account-mgr-helpers.c:
3852 (modest_account_mgr_set_first_account_as_default):
3853 * src/modest-init.c: (init_default_account_maybe):
3854 * src/modest-tny-account-store.c: (get_accounts):
3855 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3856 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3857 * tests/check_account-mgr.c: (START_TEST):
3858 Provide the extra parameter, as appropriate.
3860 * src/widgets/modest-account-view.c: (update_account_view):
3861 Do not show disabled accounts (meaning that there is no way to
3862 enable/disable accounts in the UI (the feature is not in our UI
3863 specification), so we can use this internally only to mark unfinished
3864 or temporary account data.
3866 * src/maemo/easysetup/modest-easysetup-wizard.c:
3867 (create_account): Add boolean enable parameter, so we can specify FALSE
3868 to create the temporary account.
3869 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3870 (on_before_next): When finishing, when there is a temporary account, just
3872 Also, use a timeout to delay the showing of the dialog until gconf is likely
3873 to return correct information, due to a maemo gconf bug that is fixed in
3874 osso 1.1, but not yet in Bora.
3875 However, the dialog stays on screen after it is destroyed.
3877 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3878 for invalid data when cancelling. Use a hildon note instead of a dialog
3879 to complain about invalid data. Do not show the account-saved note if the
3880 account is disabled (a temporary account that will not really be saved for use
3883 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3885 * src/modest-account-mgr-helpers.h:
3886 * src/modest-account-mgr-helpers.c:
3887 Added modest_account_mgr_unset_default_account(),
3888 Added modest_account_mgr_set_first_account_as_default().
3890 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3891 If it was the default account, unset the default account name.
3893 * src/maemo/modest-account-view-window.c:
3894 (on_delete_button_clicked): If it was the default account,
3895 set the first remaining account as the default instead.
3897 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3898 a NULL account or a NULL default account, to prevent a crash. This should
3899 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3902 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3904 * src/widgets/modest-recpt-editor.c:
3905 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3906 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3907 TODO comment for this. This fixes the build.
3909 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3910 be the best place for it. This will in future update all auto-update accounts,
3911 rather than just the current/default account, when that gconf key exists.
3912 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3913 if there are no accounts, before calling do_send_receive().
3914 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3916 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3917 * src/maemo/modest-main-window-ui.h:
3918 * src/maemo/modest-main-window.c: (on_connection_changed),
3919 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3920 directly, becaue the signal handler does more.
3922 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3924 * src/modest-account-mgr-helpers.c:
3925 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3926 for the case that the account does not exist.
3928 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3929 (equivalent to the modest account name) rather than the tinymail account name
3930 (equivalent to the modest account title - human readable) to get the account data.
3931 Check for null account data to prevent the crash, and add a TODO comment saying that
3932 this needs fixing because it is using the server account name instead of the account name.
3934 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3937 * src/maemo/modest-account-settings-dialog.c: (show_error),
3939 Use hildon_note_new_information() for informative and error messages,
3940 which seems to be expected for Maemo applications (no documentation that I know of
3941 says this). I am surprised that there is no distinction between info and error
3944 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3946 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3947 it is easy to find where this is used.
3949 * src/maemo/easysetup/modest-easysetup-wizard.c:
3950 (create_page_welcome), (create_page_account_details),
3951 (create_page_user_details), (create_page_complete_easysetup),
3952 (create_page_custom_incoming), (create_page_custom_outgoing),
3953 (create_page_complete_custom):
3954 * src/maemo/modest-account-settings-dialog.c:
3955 (create_page_account_details), (create_page_user_details),
3956 (create_page_incoming), (create_page_outgoing):
3957 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3958 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3959 (modest_connection_specific_smtp_edit_window_init):
3960 * src/maemo/modest-connection-specific-smtp-window.c:
3961 (modest_connection_specific_smtp_window_init):
3962 * src/maemo/modest-signature-editor-dialog.c:
3963 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3964 and scrolling policy as per the Email Application Layout Guide, if I have
3967 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3969 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3970 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3971 which were empty, because these vfuncs have been removed from TnyAccountStore.
3972 This fixes the build.
3974 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3976 * src/maemo/modest-main-window.c:
3977 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3978 showing/hiding it. Added TODO because it probably should not be NULL.
3979 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3980 because unnecessary g_warnings() make degugging difficult.
3982 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/modest-msg-edit-window.c:
3985 (modest_msg_edit_window_select_color),
3986 (modest_msg_edit_window_select_background_color): 2 const corrections and
3987 moving 2 #endifs before closing brackets, to fix the build.
3989 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3991 * src/maemo/easysetup/modest-easysetup-wizard.h:
3992 * src/maemo/easysetup/modest-easysetup-wizard.c:
3993 (modest_easysetup_wizard_dialog_finalize),
3994 (on_button_edit_advanced_settings), (create_page_complete_custom),
3995 (on_response), (create_account):
3996 Implement the Advanced Settings edit button, by saving the account information,
3997 for the Advanded Settings dialog to use directly from gconf, and removing it
3998 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3999 Bug #5533 in the projects.maemo.org bugzilla.
4001 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4003 * src/maemo/modest-msg-view-window.c:
4004 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
4005 when opening a message window.
4007 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4009 * src/maemo/easysetup/modest-easysetup-wizard.c:
4010 (create_page_custom_outgoing): Correct the position of the horizontal separator to
4013 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
4014 before showing/hiding them, to avoid a crash when clicking on folders when there are no
4015 gconf settings. I probably added more checks than necessary, but that is safer.
4017 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
4018 variable to fix the build, but this seems to be used when it is still NULL.
4020 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4022 * src/modest-platform.h:
4023 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4024 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
4025 * src/modest-main.c: Implement this function so we can avoid using
4026 maemo-specific API from cross-platform code.
4028 * src/modest-tny-account-store.c:
4029 (get_smtp_specific_transport_account_for_open_connection):
4030 * src/modest-ui-actions.c: (check_for_connection),
4031 (modest_ui_actions_on_item_not_found):
4032 Use modest_platform_connect_and_wait() and put #idefs around other
4033 maemo-specific code, because only maemo currently has a way to
4034 identify connection names.
4036 2007-04-27 Murray Cumming <murrayc@murrayc.com>
4038 * src/modest-tny-account-store.h:
4039 * src/modest-tny-account-store.c:
4040 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
4041 the connection-specific SMTP server settings in the configuration.
4043 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
4045 * src/maemo/modest-main-window.c: (on_connection_changed),
4047 * src/modest-main.c: (main), (start_ui), (send_mail):
4048 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
4049 that is what is intended.
4051 * src/modest-ui-actions.c: (action_send), (action_receive),
4052 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
4053 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
4054 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
4055 SMTP server is used when it is specified.
4057 (modest_ui_actions_on_send_receive):
4058 Check that a connection is open before proceeding.
4059 Receive and then send, instead of vice-versa, as per the specification.
4061 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4063 * src/modest-mail-operation.c:
4064 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
4065 though I guess it should be something other than NULL.
4067 2007-04-26 Murray Cumming <murrayc@murrayc.com>
4069 * src/maemo/easysetup/modest-easysetup-wizard.c:
4070 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
4071 combo twice, to avoid an g_warning and to make it visible again.
4072 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
4073 attached before detaching it, to avoid a g_warning, and add comment about the implicit
4074 (already intended) dereference when detaching, because we then recreate the menu.
4075 But I am not sure why the warning was happening, and it is possible that this is a memory
4078 2007-04-25 Murray Cumming <murrayc@murrayc.com>
4080 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
4081 and uri_parse_mailto() utility functions.
4082 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
4084 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
4086 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4088 * src/dbus_api/modest-dbus-api.h:
4089 * src/dbus_api/modest-dbus-callbacks.c:
4090 Use an idle callback to execute the modest code in the application's own thread.
4091 Remove the helloworld example method.
4092 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
4093 parsed, and the open-message method is not implemented because this is not yet implemented in
4095 * libmodest-dbus-client/libmodest-dbus-client.c:
4096 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
4097 (libmodest_dbus_client_open_message):
4098 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
4100 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
4101 body without crashing.
4103 * tests/dbus_api/Makefile.am:
4104 * tests/dbus_api/test_mail_to.c:
4105 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4107 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4109 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4110 Added file to fix the build. Sorry.
4112 * src/dbus_api/Makefile.am:
4113 * src/dbus_api/modest-dbus-api.h:
4114 * src/dbus_api/modest-dbus-callbacks.h:
4115 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4116 (modest_dbus_req_handler):
4117 Put constants in a separate header so it can be reused by the
4118 client library, without duplication
4120 * libmodest-dbus-client/Makefile.am:
4121 * libmodest-dbus-client/libmodest-dbus-client.c:
4122 (libmodest_dbus_client_call_helloworld),
4123 (libmodfest_dbus_client_send_mail),
4124 (libmodfest_dbus_client_mailto),
4125 (libmodfest_dbus_client_open_message):
4126 * libmodest-dbus-client/libmodest-dbus-client.h:
4127 (Partly) Implement a send_mail D-Bus method.
4129 * tests/dbus_api/Makefile.am:
4130 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4131 the send_email D-Bus method.
4133 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4137 * libmodest-dbus-client/Makefile.am:
4138 * libmodest-dbus-client/libmodest-dbus-client.c:
4139 * libmodest-dbus-client/libmodest-dbus-client.h:
4140 * tests/dbus_api/Makefile.am:
4141 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4142 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4144 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4146 * src/maemo/easysetup/modest-easysetup-wizard.c:
4147 (create_page_account_details):
4148 * src/maemo/modest-account-settings-dialog.c:
4149 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4150 widgets, because this might not be the default in future versions of the Maemo GTK+.
4151 However, I can not not get capitalization to work even in a simple test case.
4153 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4155 * src/maemo/easysetup/modest-easysetup-wizard.c:
4156 (create_page_custom_incoming), (create_page_custom_outgoing):
4157 * src/maemo/modest-account-settings-dialog.c:
4158 (create_page_account_details), (create_page_incoming),
4159 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4160 instead of using gtk_check_button_with_label(), so they are aligned like the other
4161 widgets, as per the UI spec.
4163 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4165 * src/maemo/easysetup/modest-easysetup-wizard.c:
4166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4167 * src/widgets/modest-validating-entry.c:
4168 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4169 Modest prefix instead of an EasySetup prefix.
4171 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4173 * src/widgets/modest-validating-entry.h:
4174 * src/widgets/modest-validating-entry.c: (on_insert_text),
4175 Added easysetup_validating_entry_set_max_func(), used to set a callback
4176 to call when the max number of characters is reached. GtkEntry has a max-length
4177 already but is silent about it.
4179 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4180 (create_page_account_details), (create_page_user_details),
4182 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4183 (create_page_account_details), (create_page_user_details),
4184 (create_page_outgoing):
4185 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4186 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4187 the UI spec, when the user tries to enter more than the max number of characters.
4189 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4191 * src/maemo/easysetup/modest-easysetup-wizard.c:
4192 (create_page_user_details), (create_page_custom_incoming),
4193 (create_page_custom_outgoing):
4194 * src/maemo/modest-account-settings-dialog.c:
4195 (create_page_user_details), (create_page_incoming),
4196 (create_page_outgoing):
4197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4198 (modest_connection_specific_smtp_edit_window_init):
4199 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4200 not appropriate. Bad Maemo-specific defaults!.
4202 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4204 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4205 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4206 (modest_signature_editor_dialog_set_settings):
4207 Disable the label and textview when the checkbox is disabled, and use the
4208 specified (UI spec) default signature text.
4210 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4213 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4215 * src/modest-defs.h:
4216 * src/modest-account-mgr-helpers.h:
4217 * src/modest-account-mgr-helpers.c:
4218 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4220 * src/maemo/Makefile.am:
4221 * src/maemo/modest-signature-editor-dialog.c:
4222 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4225 * src/maemo/modest-account-settings-dialog.h:
4226 * src/maemo/modest-account-settings-dialog.c:
4227 (modest_account_settings_dialog_finalize), (on_button_signature),
4228 (save_configuration): Use the new dialog when the Edit button is pressed, and
4229 save the changes if necessary, as per the UI spec.
4231 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4233 * src/maemo/Makefile.am:
4234 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4235 based on maemo-develoers email from Dirk.
4237 * src/maemo/easysetup/modest-easysetup-wizard.c:
4238 (create_page_welcome), (create_page_account_details),
4239 (create_page_user_details), (create_page_complete_easysetup),
4240 (create_page_custom_incoming), (create_page_custom_outgoing),
4241 (create_page_complete_custom),
4242 (modest_easysetup_wizard_dialog_init):
4243 * src/maemo/modest-account-settings-dialog.c:
4244 (create_page_account_details), (create_page_user_details),
4245 (create_page_incoming), (create_page_outgoing),
4246 (modest_account_settings_dialog_init):
4247 * src/maemo/modest-connection-specific-smtp-window.c:
4248 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4250 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4252 * src/maemo/easysetup/modest-easysetup-wizard.c:
4253 (create_page_account_details), (create_page_custom_outgoing),
4254 (create_page_complete_custom):
4255 * src/maemo/modest-account-settings-dialog.c:
4256 (create_page_user_details), (create_page_incoming),
4257 (create_page_outgoing):
4258 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4259 (modest_connection_specific_smtp_edit_window_init):
4260 Use the correct (UI spec) port min/max, and use horizontal separators,
4263 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4265 * src/maemo/easysetup/modest-easysetup-wizard.c:
4266 (set_default_custom_servernames):
4267 * src/maemo/modest-account-settings-dialog.c:
4268 (create_page_incoming), (on_combo_outgoing_security_changed),
4269 (on_combo_incoming_security_changed), (create_page_outgoing),
4270 (modest_account_settings_dialog_set_account_name),
4271 (save_configuration):
4272 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4273 (on_combo_security_changed),
4274 (modest_connection_specific_smtp_edit_window_init),
4275 (modest_connection_specific_smtp_edit_window_set_connection),
4276 (modest_connection_specific_smtp_edit_window_get_settings):
4277 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4280 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4283 * src/maemo/easysetup/modest-easysetup-wizard.c:
4284 (create_page_custom_outgoing), (create_page_complete_custom):
4285 * src/maemo/modest-account-settings-dialog.c:
4286 (create_page_user_details), (create_page_outgoing):
4287 * src/maemo/modest-account-view-window.c: (button_box_new):
4288 Use changed logical IDs as per the most recent UI spec:
4289 mcen_bd_emailsetup_edit -> mcen_bd_edit
4290 mcen_bd_emailsetup_delete -> mcen_bd_delete
4291 mcen_bd_emailsetup_close -> mcen_bd_close
4293 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4297 * src/dbus_api/Makefile.am:
4298 * src/dbus_api/modest-dbus-callbacks.c:
4299 * src/dbus_api/modest-dbus-callbacks.h:
4300 * src/maemo/modest-platform.c: (modest_platform_init):
4301 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4303 * tests/Makefile.am:
4304 * tests/dbus_api/Makefile.am:
4305 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4307 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4309 * src/maemo/modest-account-settings-dialog.c:
4310 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4311 Removed unnecessary includes.
4313 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4315 * src/maemo/easysetup/modest-easysetup-wizard.c:
4316 * src/maemo/modest-account-settings-dialog.c:
4317 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4318 * src/widgets/Makefile.am:
4319 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4320 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4321 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4322 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4323 * src/widgets/modest-secureauth-combo-box.c:
4324 * src/widgets/modest-secureauth-combo-box.h:
4325 * src/widgets/modest-serversecurity-combo-box.c:
4326 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4327 made the GObject names more consistent with the rest of the Modest code.
4329 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4331 * src/maemo/easysetup/Makefile.am:
4332 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4333 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4334 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4335 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4336 * src/maemo/easysetup/modest-easysetup-wizard.c:
4337 * src/maemo/easysetup/modest-validating-entry.c:
4338 * src/maemo/easysetup/modest-validating-entry.h:
4339 * src/maemo/modest-account-settings-dialog.c:
4340 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4341 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4342 widgets/ because they are used outside of easysetup too. After checking in,
4343 svn will allow me to rename them too.
4345 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4347 * src/gnome/modest-msg-edit-window.c:
4348 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4349 linker error, to fix the build on the GNOME platform.
4350 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4351 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4352 ifdefed out to avoid a warning.
4354 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4356 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4357 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4358 some alternative for GTK+ 2.6.
4360 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4362 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4364 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4365 specified for EmailAccountsDialog in UI spec.
4367 * src/maemo/easysetup/modest-easysetup-wizard.c:
4368 * src/maemo/easysetup/modest-easysetup-wizard.h:
4369 * src/maemo/modest-account-settings-dialog.c:
4370 * src/maemo/modest-account-settings-dialog.h:
4371 Reuse a member window widget for the connection-specific SMTP server accounts,
4372 so we can tell it to create/save the accounts only if we actually save changes.
4374 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4375 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4376 (modest_connection_specific_smtp_edit_window_get_settings):
4377 Return a struct instance for temporarily remembering the entered data.
4379 * src/maemo/modest-connection-specific-smtp-window.h:
4380 * src/maemo/modest-connection-specific-smtp-window.c:
4381 (modest_connection_specific_smtp_window_finalize),
4382 (modest_connection_specific_smtp_window_fill_with_connections),
4384 (modest_connection_specific_smtp_window_save_server_accounts),
4385 (update_model_server_names): Do not actually save data until asked,
4386 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4388 (on_selection_changed),
4389 (modest_connection_specific_smtp_window_init): Disable the edit
4390 button when nothing is selected.
4392 * src/modest-account-mgr-helpers.c:
4393 * src/modest-account-mgr-helpers.h:
4394 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4397 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4399 * src/modest-account-mgr-helpers.h:
4400 * src/modest-account-mgr-helpers.c:
4401 (modest_account_mgr_get_unused_account_name),
4402 (modest_account_mgr_get_unused_account_display_name): Added these
4403 utility functions, to avoid code duplication.
4405 * src/maemo/easysetup/modest-easysetup-wizard.c:
4406 (create_page_account_details), (create_account):
4407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4408 (on_combo_security_changed),
4409 (modest_connection_specific_smtp_edit_window_init),
4410 (modest_connection_specific_smtp_edit_window_save_settings):
4411 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4412 * src/maemo/modest-connection-specific-smtp-window.c:
4413 (modest_connection_specific_smtp_window_finalize),
4414 (modest_connection_specific_smtp_window_fill_with_connections),
4415 (on_button_edit), (modest_connection_specific_smtp_window_init):
4416 * src/maemo/modest-connection-specific-smtp-window.h:
4417 Implementing saving of connection-specific server accounts.
4419 But I need to refactor this so we can save the data for each
4420 possible connection-specific account and only actually create the server accounts
4421 when the easysetup finished, or the OK button is pressed on the account settings
4424 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4426 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4427 (on_combo_security_changed):
4428 (modest_connection_specific_smtp_edit_window_init):
4429 Auto-fill the port number as in the account settings.
4431 (modest_connection_specific_smtp_edit_window_set_connection):
4432 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4433 * src/maemo/modest-connection-specific-smtp-window.c:
4434 (fill_with_connections), (on_button_edit),
4435 (modest_connection_specific_smtp_window_init):
4436 Turn the edit window into a dialog to simplify the code, and
4437 set a WM hint as in a GtkDialog, because only a popup can be on top of
4438 another window in Maemo, and popups usually have no WM decoration.
4440 * src/modest-defs.h:
4441 * src/modest-account-mgr-helpers.c:
4442 (modest_account_mgr_set_connection_specific_smtp),
4443 (modest_account_mgr_remove_connection_specific_smtp),
4444 (modest_account_mgr_get_connection_specific_smtp):
4445 * src/modest-account-mgr-helpers.h: Some functions to write the
4446 connection-specific SMTP server information. Not yet used.
4449 * src/widgets/modest-folder-view.c: (text_cell_data):
4450 Fix a warning about an uninitialized variable.
4451 (on_configuration_key_changed): Put an #ifdef around the use
4452 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4454 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4456 * src/maemo/modest-account-settings-dialog.h:
4457 * src/maemo/modest-account-settings-dialog.c:
4458 Added connect_for_modified() utility function to mark the new modified boolean.
4460 (create_page_account_details), (create_page_user_details),
4461 (create_page_incoming), (create_page_outgoing), (on_response),
4462 (modest_account_settings_dialog_init),
4463 (modest_account_settings_dialog_set_account_name):
4464 Only warn about unsaved changes when there are actually unsaved changes.
4466 * src/modest-account-mgr-helpers.c:
4467 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4468 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4469 to get the data from there in future.
4471 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4473 * src/modest-defs.h:
4475 * src/modest-account-mgr-helpers.h:
4476 * src/modest-account-mgr-helpers.c:
4477 Store the security account setting in a single conf key instead of using
4478 the options list, so that the list is left for just the to-be-removed camel hack,
4479 and because gconf_client_set_list() is failing for some reason.
4481 * src/modest-account-mgr.c:
4482 (modest_account_mgr_add_server_account):
4483 * src/maemo/modest-account-settings-dialog.c:
4484 (modest_account_settings_dialog_set_account_name),
4485 (save_configuration): Use the renamed functions.
4488 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4490 * src/widgets/Makefile.am:
4491 * src/widgets/modest-limit-retrieve-combo-box.c:
4492 * src/widgets/modest-limit-retrieve-combo-box.h:
4493 * src/widgets/modest-retrieve-combo-box.c:
4494 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4495 the account settings dialog.
4497 * src/modest-defs.h:
4498 * src/modest-account-mgr-helpers.h:
4499 * src/modest-account-mgr-helpers.c:
4500 (modest_server_account_get_option_secure_auth),
4501 (modest_server_account_set_option_secure_auth):
4502 * src/modest-account-mgr.c:
4503 (modest_account_mgr_add_server_account):
4504 Use the existing AUTH_MECH conf key for the secure-auth setting,
4505 instead of putting it in the list options, because this was actually used already.
4507 * src/maemo/modest-account-settings-dialog.c:
4508 (create_page_account_details),
4509 (modest_account_settings_dialog_set_account_name),
4510 (save_configuration):
4511 * src/maemo/modest-account-settings-dialog.h:
4512 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4513 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4515 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4517 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4518 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4519 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4521 * src/modest-defs.h:
4522 * src/maemo/modest-account-settings-dialog.c:
4523 (create_page_incoming), (on_combo_outgoing_security_changed),
4524 (on_combo_incoming_security_changed), (create_page_outgoing),
4525 (modest_account_settings_dialog_set_account_name),
4526 (save_configuration): Load/Save the port number, and change it when the
4527 security combo changes, to suitable defaults.
4529 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4531 * src/modest-account-mgr.c:
4532 (modest_account_mgr_add_server_account): Set the security and secure-auth
4533 options, and add a comment saying that the other camel-specific options should be
4536 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4538 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4540 * src/modest-tny-account-store.c: (account_list_free),
4541 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4542 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4545 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4547 * src/modest-protocol-info.c:
4548 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4549 is required by our UI spec. Maybe something in our implementation will use this eventually.
4550 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4551 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4552 instead of the previous 0 placeholder.
4554 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4555 secure-auth settings.
4556 * src/modest-account-mgr-helpers.h:
4557 * src/modest-account-mgr-helpers.c:
4558 (modest_server_account_data_get_option_secure_auth),
4559 (modest_server_account_set_option_secure_auth),
4560 (modest_server_account_data_get_option_security),
4561 (modest_server_account_set_option_security): Added this API for getting and setting the security
4562 and secure-auth settings.
4564 * src/maemo/modest-account-settings-dialog.h:
4565 * src/maemo/modest-account-settings-dialog.c:
4566 (modest_account_settings_dialog_finalize), (check_data),
4567 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4568 about changing titles.
4569 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4570 (save_configuration): Save the security and secure-auth settings.
4572 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4573 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4575 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4577 * src/modest-defs.h:
4578 * src/modest-account-mgr.c:
4579 (modest_account_mgr_add_server_account):
4580 Added and used defines for the options key and value pair strings,
4581 that are used so far, though they do not seem to correspond to anything in our
4582 UI specs or ModestProtocol enum.
4584 * src/modest-account-mgr-helpers.h:
4585 * src/modest-account-mgr-helpers.c:
4586 (compare_option_strings_for_name),
4587 (modest_server_account_data_get_option_value),
4588 (modest_server_account_data_get_option_bool),
4589 (modest_account_mgr_get_server_account_option):
4590 Added helper functions for parsing the options GSList.
4592 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4594 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4595 display name is based on the supplied account name.
4596 * src/modest-account-mgr.c:
4597 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4598 with an inefficient, but good-enough, implementation.
4600 * src/maemo/easysetup/modest-easysetup-wizard.c:
4601 (create_page_account_details), (on_before_next), (create_account):
4602 Check for existing display names rather than (non-user-visible) account names, and just
4603 create and set a unique account name at the end.
4605 * src/maemo/modest-account-settings-dialog.c:
4606 (modest_account_settings_dialog_init),
4607 (modest_account_settings_dialog_set_account_name),
4608 (create_page_incoming): Show the display name, instead of the account name.
4609 (on_response): Do some (not all) extra checks, as in the UI spec.
4610 (save_configuration): Save the display name if it was changed.
4612 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4614 * po/en_GB.po: Added needed logical ID and translation.
4615 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4616 (init_view): Made the is-default column clicking work.
4618 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4621 * src/maemo/easysetup/Makefile.am:
4622 * src/maemo/easysetup/modest-easysetup-wizard.c:
4623 (modest_easysetup_wizard_dialog_init):
4624 * src/maemo/easysetup/provider-data-test.keyfile:
4625 * src/maemo/easysetup/provider-data.keyfile:
4626 Moved the provider data file to the new modest-providers-data package and used it from there.
4628 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4630 * src/modest-local-folder-info.c:
4631 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4632 N_() was already used on the static strings, but this just marks it for translation without
4633 using the translation.
4635 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4637 * src/maemo/modest-account-settings-dialog.c:
4638 (create_page_incoming),
4639 (modest_account_settings_dialog_set_account_name):
4640 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4641 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4642 I will do this if nobody else gets there first.
4644 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4646 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4647 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4648 save the security stuff.
4650 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4652 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4653 Set the email address and user fullname, which I now see must be
4656 * src/maemo/modest-account-settings-dialog.h:
4657 * src/maemo/modest-account-settings-dialog.c:
4659 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4660 leave-on-server and authentication.
4661 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4664 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4667 * src/maemo/modest-account-settings-dialog.c:
4668 * src/maemo/modest-account-settings-dialog.h:
4669 Most (but not all) of the widgets are now present as specified by the UI spec.
4670 No changes are yet saved, and some details are not properly shown yet.
4672 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4674 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4676 * src/maemo/Makefile.am:
4677 * src/maemo/modest-account-settings-dialog.c:
4678 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4679 an existing account. Doesn't do much yet.
4681 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4682 Open the accounts settings dialog when Edit is clicked.
4684 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4686 * src/maemo/easysetup/Makefile.am:
4687 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4689 * src/maemo/easysetup/modest-easysetup-wizard.c:
4690 (modest_easysetup_wizard_dialog_init):
4691 Try to get the source directory from the build system,
4692 instead of hard-coding "./" into the source code, when opening our local
4693 copies of the configuration files.
4694 But this still fails when opening the wizard from the Accounts window,
4695 maybe because the working directory seems to change at runtime.
4696 So the wizard will fail the second time unless you copy the files into their
4697 proper locations - see the stdout warnings for the paths.
4699 (create_page_account_details),(on_before_next):
4700 Check for existing non-server accounts instead of server accounts,
4701 so the default account name is useful again, and to prevent trying to
4704 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4705 Show the wizard when New is clicked.
4707 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4708 (init_view): Show the column headers, and show the columns that are
4709 specified in the UI specs. However, something in Maemo's GTK+ prevents
4710 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4711 change the default account. This is despite unsetting the special properties.
4713 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4715 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4716 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4717 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4718 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4719 to make that clearer.
4720 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4722 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4724 * src/maemo/modest-account-view-window.c:
4725 (modest_account_view_window_init),
4726 (modest_account_view_window_new):
4727 Use the same buttons as specified in the
4728 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4729 the existing widgets, which never had a chance of working.
4730 Put the ModestAccountView treeview in a scrolled window.
4731 Do not repeat the initialization in both _init() and _new().
4733 * src/widgets/modest-account-view.c: (update_account_view):
4734 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4735 this widget and window shows no accounts.
4737 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4739 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4741 * src/maemo/easysetup/modest-easysetup-wizard.c:
4742 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4743 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4744 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4747 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4748 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4749 accounts exist yet, as in the UI spec.
4751 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4753 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4755 * src/maemo/Makefile.am:
4756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4757 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4758 New window for editing connection-specific smtp details.
4759 Not fully implemented.
4761 * src/maemo/modest-connection-specific-smtp-window.c:
4762 (modest_connection_specific_smtp_window_finalize) :
4763 unref the tree model.
4764 (on_button_edit): Show the edit window.
4766 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4768 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4771 * src/maemo/Makefile.am:
4772 * src/maemo/modest-connection-specific-smtp-window.c:
4773 * src/maemo/modest-connection-specific-smtp-window.h:
4774 New window for showing the list of connections, for connection-specific
4775 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4776 * src/maemo/easysetup/modest-easysetup-wizard.c:
4777 (create_page_custom_outgoing): Show the new window when the button is clicked.
4779 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4781 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4782 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4783 * src/maemo/modest-msg-edit-window.c:
4784 (modest_msg_edit_window_insert_image):
4785 * src/modest-conf.c: (modest_conf_key_escape):
4786 * src/modest-mail-operation.c:
4787 (modest_mail_operation_send_new_mail):
4788 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4789 (modest_ui_actions_on_new_account):
4790 * src/widgets/modest-attachment-view.c: (update_filename_request):
4791 * src/widgets/modest-mail-header-view.c:
4792 Corrected warnings that were breaking the build, by commenting out unused variables,
4793 and a function, and by including a header.
4795 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4797 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4798 so we can #ifdef around platform-specific code when necessary.
4799 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4800 to allow this to build for the GNOME platform too.
4802 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4804 * src/maemo/easysetup/modest-easysetup-wizard.c:
4805 Added util_increment_name() and used it in create_page_account_details()
4806 to make sure that the default account name is always a new name.
4808 (modest_easysetup_wizard_dialog_init),
4809 (set_default_custom_servernames): Some minor memory management fixes.
4811 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4815 * src/modest-runtime.c: (init_i18n): Restored the translation
4816 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4817 are defined in config.h, and the translations are installed.
4819 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4820 is defined for translation.
4822 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4824 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4826 * src/maemo/easysetup/modest-easysetup-wizard.c:
4827 (modest_easysetup_wizard_dialog_init):
4828 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4829 Use realistic paths (though they should use $prefix generically) to the
4830 mcc_mapping and provider-data.keyfile files which might work when they
4831 are installed by the future version of the operator-wizard package,
4832 and then fallback to paths in our source code, with an explanatory
4835 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4839 * src/maemo/Makefile.am:
4840 * src/maemo/easysetup/: Added files from the previously-exernal
4841 osso-modest-easysetup.
4842 * src/maemo/modest-main-window-ui.h:
4843 * src/modest-ui-actions.c:
4844 * src/modest-ui-actions.h:
4845 Added modest_ui_actions_on_new_account() as a signal handler for the
4846 New Account menu item. It shows the easysetup wizard.
4847 * po/en_GB.po: Added additional needed logical IDs and translations.