git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-05-11  Marcus Bauer  <marcusb@openismus.com>
   2
   3         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
   4         changed CFlags paths form modest to libmodest
   5
   6 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
   7
   8         * src/modest-account-mgr-helpers.c:
   9         (modest_account_mgr_get_server_account_data),
  10         (modest_account_mgr_free_server_account_data):
  11         * src/modest-account-mgr-helpers.h:
  12         * src/modest-account-mgr.c:
  13         (modest_account_mgr_add_server_account):
  14         * src/modest-defs.h:
  15         * src/modest-tny-account.c:
  16         (modest_tny_account_new_from_server_account):
  17         Determine the options for tny_camel_account_add_option() here,
  18         based on the settings, rather than storing them directly in gconf.
  19
  20 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  21
  22         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  23         Show a more friendly error dialog now that we expect (from the tinymail
  24         documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
  25
  26 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  27
  28         * src/maemo/modest-main-window.c: (on_account_update): Check that
  29         account_name is not NULL, to prevent a crash at startup that I am
  30         seeing on the N800. I do wonder why it is NULL.
  31
  32         * src/maemo/easysetup/modest-easysetup-wizard.c:
  33         (create_page_user_details):
  34         * src/maemo/modest-account-settings-dialog.c:
  35         (create_page_user_details), (create_page_outgoing):
  36         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  37         (modest_connection_specific_smtp_edit_window_init):
  38         * src/modest-ui-actions.c:
  39         (modest_ui_actions_on_password_requested):
  40         Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
  41         might do something useful with the on-screen keyboard.
  42
  43 2007-05-10  Murray Cumming  <murrayc@murrayc.com>
  44
  45         * src/maemo/modest-main-window.c: (on_account_update):
  46         Avoid adding a menu item to priv->accounts_popup if accounts_popup is
  47         NULL, to avoid lots of warnings. However, it probably should not be NULL.
  48
  49 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  50
  51         * src/modest-tny-account-store.c: (on_account_changed):
  52         Correct the signature of this signal handler.
  53
  54 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  55
  56         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  57         Show a HildonNote instead of a GtkDialog for Maemo.
  58
  59 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  60
  61         * src/widgets/modest-account-view.h:
  62         * src/widgets/modest-account-view.c: (on_account_changed),
  63         (on_account_removed). Added a boolean flag, set/unset by
  64         modest_account_view_block_conf_updates(),
  65         modest_account_view_unblock_conf_updates() to prevent unnecessary
  66         updates, but this is not very useful because the gconf notifications are
  67         so delays (maybe only on Maemo Bora).
  68         So auto-updating is turned off, and these functions do an explicit
  69         update when necessary.
  70         However, something else is still doing too much work when adding/removing
  71         accounts, probably in another part of the application.
  72
  73         * src/maemo/modest-account-view-window.c:
  74         (on_delete_button_clicked), (on_edit_button_clicked),
  75         (on_new_button_clicked): Use the new functions.
  76
  77 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  78
  79         * src/modest-account-mgr-helpers.c:
  80         (modest_account_mgr_set_first_account_as_default):
  81         Sort the list of names alphabetically-by-title, so we choose the first one
  82         based on that.
  83         * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
  84         alphabetically by the title.
  85
  86         This fixes projects.maemo.org bug NB#56418 .
  87
  88         * src/modest-account-mgr-priv.c:
  89         (_modest_account_mgr_account_from_key):
  90         * src/modest-account-mgr.c: (on_key_change): Initialize variables to
  91         avoid a valgrind error, and possible random behaviour.
  92
  93 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
  94
  95         * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
  96         Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
  97         tinymail documentation to say that this can be expected.
  98         Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
  99         pretty, and should not happen, but I would prefer to know when it does.
 100
 101 2007-05-09  Murray Cumming  <murrayc@murrayc.com>
 102
 103         * configure.ac: When using the older hildon version, probably on Bora,
 104         require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
 105         to fix the build.
 106         * src/widgets/modest-attachment-view.c:
 107         (modest_attachment_view_set_part_default): Initialize variables, to fix the
 108         build.
 109
 110 2007-05-09  Marcus Bauer  <marcusb@openismus.com>
 111
 112         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
 113         Implemented the prototype. Can be tested with
 114         tests/dbus_api/test_open_message:
 115
 116 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 117
 118         * src/modest-tny-account-store.c:
 119         (modest_tny_account_store_instance_init), (get_password):
 120         * src/modest-ui-actions.c:
 121         (modest_ui_actions_on_password_requested):
 122         Do not store the password in gconf, because this function is called
 123         for non-remembered passwords. Actually use the cached (in the hash map)
 124         password instead of releasing it.
 125         The password will now not be remembered if it is asked via the protected
 126         password dialog, as per the UI spec.
 127
 128 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 129
 130         * src/modest-defs.h:
 131         * src/modest-account-mgr-helpers.h:
 132         * src/modest-account-mgr-helpers.c:
 133         Added modest_server_account_get_username_has_succeeded(),
 134         modest_server_account_set_username_has_succeeded().
 135         (modest_server_account_set_username),
 136         Reset the has-succeeded flag if the username changes.
 137
 138         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 139         * src/maemo/modest-connection-specific-smtp-window.c:
 140         (modest_connection_specific_smtp_window_save_server_accounts):
 141         Use modest_server_account_set_username() instead of using
 142         modest_conf_set_string() directly, so that the has-succeeded flag is always
 143         reset.
 144
 145         * src/modest-ui-actions.c:
 146         (modest_ui_actions_on_password_requested): Dim the username entry if
 147         the username has ever worked, as per the UI spec.
 148
 149 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 150
 151         * src/modest-tny-account-store.c: (get_password):
 152         * src/modest-ui-actions.c:
 153         (modest_ui_actions_on_password_requested):
 154         Allow the username to be changed too, though there is more work to
 155         be done on exactly how this behaves.
 156
 157 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 158
 159         * src/modest-account-mgr-helpers.h:
 160         * src/modest-account-mgr-helpers.c:
 161         Added modest_account_mgr_get_display_name(),
 162         modest_server_account_get_username(),
 163         modest_server_account_set_username(),
 164         modest_server_account_set_password(),
 165         modest_server_account_get_hostname() functions so we do not need to
 166         use the conf API directly.
 167
 168         * src/maemo/modest-main-window.c: (connect_signals):
 169         Actually connect ot the ModestAccountStore::request-password signal,
 170         so that we show the dialog when the password is requested by Tinymail,
 171         for isntance if it is empty.
 172
 173         * src/modest-marshal.list:
 174         * src/modest-tny-account-store.c:
 175         (modest_tny_account_store_class_init), (get_password),
 176         (modest_tny_account_store_alert):
 177         * src/modest-tny-account-store.h:
 178         * src/modest-ui-actions.h:
 179         * src/modest-ui-actions.c:
 180         (modest_ui_actions_on_password_requested):
 181         Change the signal parameters, so it is obvious that we are providing
 182         the non human-readable server name, and receiving both the username
 183         and password, though changing of the username is not yet implemented.
 184         Change the dialog UI to match the Maemo UI specifications, with #idfefing
 185         for the GNOME version.
 186
 187         This should fix the projects.maemo.org bug NB#56209, though it does not
 188         work on Bora, because the gconf_client_get() for the password fails
 189         immediately after we save it with gconf_client_set().
 190
 191 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 192
 193         * configure.ac:
 194         * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
 195         caused an undefined symbol error:
 196         modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
 197
 198 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 199
 200         * src/modest-tny-account-store.c:
 201         (modest_tny_account_store_alert): Adapt to the changed tinymail API,
 202         using a GError instead of a string message, so we can translate it in
 203         Modest.
 204
 205 2007-05-08  Murray Cumming  <murrayc@murrayc.com>
 206
 207         * src/maemo/modest-address-book.c:
 208         (modest_address_book_check_names):
 209         * src/maemo/modest-msg-view-window.c:
 210         (modest_msg_view_window_clipboard_owner_change):
 211         * src/modest-init.c: (modest_init_init_ui):
 212         * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
 213         (update_folders_cb), (modest_mail_operation_update_account):
 214         * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
 215         (modest_ui_actions_on_msg_attachment_clicked),
 216         (modest_ui_actions_on_msg_recpt_activated):
 217         * src/widgets/modest-header-view.c: (drag_data_get_cb):
 218         * src/widgets/modest-msg-view.c: (modest_msg_view_search),
 219         (modest_msg_view_search_next):
 220         * src/widgets/modest-recpt-editor.c:
 221         (modest_recpt_editor_on_button_release_event),
 222         (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
 223         g_message(). At this point we should only be seeing interesting errors on
 224         stdout. Debugging messages could be #ifdefed-out if they are still useful.
 225
 226 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 227
 228         (modest_wizard_dialog_force_title_update):
 229         * src/maemo/easysetup/modest-wizard-dialog.h:
 230         * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
 231         For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
 232         can update the title when appropriate. Otherwise the title is wrong if the
 233         pages are added after adding the notebook to the dialog.
 234         This must be a problem in HildonWizardDialog too.
 235         Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
 236
 237         * src/maemo/easysetup/modest-easysetup-wizard.c:
 238         (create_subsequent_customsetup_pages),
 239         (create_subsequent_easysetup_pages):
 240         Call modest_wizard_dialog_force_title_update() so that the title is
 241         correct even with GTK+ < 2.10.
 242         This fixes projects.maemo.org bug NB#56145 .
 243
 244 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 245
 246         * src/maemo/modest-platform.c:
 247         (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
 248         flag (awful lack of namespacing in this API) to prevent a useless %s dialog
 249         from being shown.
 250
 251 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 252
 253         * src/widgets/modest-window.h:
 254         * src/widgets/modest-window.c: Added a save_state_func vfunc,
 255         and modest_window_save_state(), which invokes it.
 256
 257         * src/widgets/modest-window-mgr.h:
 258         * src/widgets/modest-window-mgr.c:
 259         Added modest_window_mgr_save_state_for_all_windows(), which calls
 260         the save_state vfunc on all registered windows, if implemented.
 261
 262         * src/gnome/modest-msg-edit-window.c:
 263         * src/gnome/modest-msg-view-window.c:
 264         * src/maemo/modest-msg-edit-window.c:
 265         * src/maemo/modest-msg-view-window.c:
 266         * src/maemo/modest-main-window.c:
 267         Specify the existing save_settings functions as implementations of
 268         ModestWindow::save_state_func().
 269
 270         * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
 271         Call modest_window_mgr_save_state_for_all_windows(). This happens before
 272         enabling hibernation, for instance.
 273
 274         We may need to do the same thing for restoring settings.
 275
 276
 277 2007-05-07  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/widgets/modest-window-mgr.c:
 280         * src/widgets/modest-window-mgr.h:
 281         Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
 282         modest_window_mgr_get_hibernation_is_prevented().
 283
 284         * src/maemo/modest-main-window.c:
 285         (on_hildon_program_is_topmost_notify): Prevent hibernation
 286         (possible when the application goes to the background in the WM),
 287         if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
 288
 289         * src/maemo/easysetup/modest-easysetup-wizard.c:
 290         (modest_easysetup_wizard_dialog_init):
 291         * src/maemo/modest-account-settings-dialog.c:
 292         (modest_account_settings_dialog_init):
 293         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 294         (modest_connection_specific_smtp_edit_window_init):
 295         * src/maemo/modest-connection-specific-smtp-window.c:
 296         (modest_connection_specific_smtp_window_init):
 297         * src/maemo/modest-signature-editor-dialog.c:
 298         (modest_signature_editor_dialog_init):
 299         Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
 300         prevent hibernation while any of these account settings dialogs are open.
 301
 302 2007-05-04  Murray Cumming  <murrayc@murrayc.com>
 303
 304         * src/maemo/Makefile.am:
 305         * src/maemo/modest-osso-state-saving.c:
 306         * src/maemo/modest-osso-state-saving.h: Added
 307         modest_osso_load_state() and modest_osso_save_state() though they do
 308         nothing now. They should iterate through all the open windows and load/save
 309         their state.
 310         * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
 311         save state when closing.
 312
 313         * src/maemo/modest-main-window.c:
 314         (on_hildon_program_is_topmost_notify), (modest_main_window_new):
 315         Add a notification handler for the HildonProgram::is-topmost property,
 316         so we can allow hibernation when the application goes into the background.
 317         But we still need to detect when the accounts setup windows are open so
 318         we can stop hibernation when they are open.
 319         To do this, I also added the main window the HildonProgram. This might have
 320         other side-effects/benefits, and should maybe be done for other windows.
 321
 322         * src/maemo/modest-osso-autosave-callbacks.h:
 323         * src/maemo/modest-osso-autosave-callbacks.c:
 324         (modest_on_osso_application_autosave): Add a libosso auto-save callback,
 325         though it does not do anything yet, and we might never need this to do
 326         anything. For instance, we already save drafts.
 327
 328         * src/maemo/modest-platform.c: (modest_platform_init):
 329         Specify the libosso auto-save callback.
 330
 331 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 332
 333         * src/maemo/modest-platform.c:
 334         (modest_platform_set_update_interval):
 335         * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
 336         aparently stays valid between application instances, so we can use this
 337         to remove and reset it later. According to a maemo-developers email from
 338         David Weinehall.
 339
 340 2007-05-03  Murray Cumming  <murrayc@murrayc.com>
 341
 342         * configure.ac: Depend on libalarm for Maemo.
 343
 344         * src/dbus_api/modest-dbus-api.h:
 345         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
 346         (on_send_receive), (modest_dbus_req_handler):
 347         Handle a SEND_RECEIVE D-Bus method.
 348
 349         * libmodest-dbus-client/libmodest-dbus-client.c:
 350         (libmodest_dbus_client_send_and_receive):
 351         * libmodest-dbus-client/libmodest-dbus-client.h:
 352         Add C convenience functions for calling the new D-Bus method.
 353
 354         * src/modest-platform.h:
 355         * src/gnome/modest-platform.c:
 356         * src/maemo/modest-platform.c:
 357         Added modest_platform_set_update_interval(), which uses the
 358         alarmd API on Maemo.
 359         (modest_platform_init),
 360         Call modest_platform_set_update_interval(), using a hard-coded
 361         interval for now (until the global settings dialog is implemented),
 362         though I am not sure that this makes sense yet.
 363
 364 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 365
 366         * src/dbus_api/modest-dbus-callbacks.c:
 367         (modest_osso_cb_hw_state_handler):
 368         * src/dbus_api/modest-dbus-callbacks.h:
 369         * src/maemo/modest-platform.c: (modest_platform_init):
 370         Registered (empty) callbacks for the osso hardware state D-Bus signals,
 371         in case this has some effect on the ability for Maemo to ping the
 372         application.
 373
 374 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 375
 376         * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
 377         Comment out an if() that checks a gchar for < 0, causing a build-breaking
 378         warning. It is probably a logic error, but I need to fix the build.
 379
 380 2007-05-02  Murray Cumming  <murrayc@murrayc.com>
 381
 382         * src/modest-account-mgr.h:
 383         * src/modest-account-mgr.c:
 384         (modest_account_mgr_account_names): Add a gboolean enabled_only
 385         parameter, so we can get lists of onlt the enabled accounts.
 386
 387         (modest_account_mgr_add_account),,
 388         (modest_account_mgr_account_with_display_name_exists):
 389         * src/maemo/modest-msg-edit-window.c: (get_transports):
 390         * src/modest-account-mgr-helpers.c:
 391         (modest_account_mgr_set_first_account_as_default):
 392         * src/modest-init.c: (init_default_account_maybe):
 393         * src/modest-tny-account-store.c: (get_accounts):
 394         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 395         (do_send_receive_auto), (modest_ui_actions_on_send_receive):
 396         * tests/check_account-mgr.c: (START_TEST):
 397         Provide the extra parameter, as appropriate.
 398
 399         * src/widgets/modest-account-view.c: (update_account_view):
 400         Do not show disabled accounts (meaning that there is no way to
 401         enable/disable accounts in the UI (the feature is not in our UI
 402         specification), so we can use this internally only to mark unfinished
 403         or temporary account data.
 404
 405         * src/maemo/easysetup/modest-easysetup-wizard.c:
 406         (create_account): Add boolean enable parameter, so we can specify FALSE
 407         to create the temporary account.
 408         (on_button_edit_advanced_settings): Create the temporary account as disabled.
 409         (on_before_next): When finishing, when there is a temporary account, just
 410         set it as enabled.
 411         Also, use a timeout to delay the showing of the dialog until gconf is likely
 412         to return correct information, due to a maemo gconf bug that is fixed in
 413         osso 1.1, but not yet in Bora.
 414         However, the dialog stays on screen after it is destroyed.
 415
 416         * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
 417         for invalid data when cancelling. Use a hildon note instead of a dialog
 418         to complain about invalid data. Do not show the account-saved note if the
 419         account is disabled (a temporary account that will not really be saved for use
 420         until later.)
 421
 422 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 423
 424         * src/modest-account-mgr-helpers.h:
 425         * src/modest-account-mgr-helpers.c:
 426         Added modest_account_mgr_unset_default_account(),
 427         Added modest_account_mgr_set_first_account_as_default().
 428
 429         * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
 430         If it was the default account, unset the default account name.
 431
 432         * src/maemo/modest-account-view-window.c:
 433         (on_delete_button_clicked): If it was the default account,
 434         set the first remaining account as the default instead.
 435
 436         * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
 437         a NULL account or a NULL default account, to prevent a crash. This should
 438         not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
 439
 440
 441 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 442
 443         * src/widgets/modest-recpt-editor.c:
 444         (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
 445         use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
 446         TODO comment for this. This fixes the build.
 447
 448         * src/modest-ui-actions.c: Add do_send_receive(), though it might not
 449         be the best place for it. This will in future update all auto-update accounts,
 450         rather than just the current/default account, when that gconf key exists.
 451         (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
 452         if there are no accounts, before calling do_send_receive().
 453         * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
 454
 455         * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
 456         * src/maemo/modest-main-window-ui.h:
 457         * src/maemo/modest-main-window.c: (on_connection_changed),
 458         (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
 459         directly, becaue the signal handler does more.
 460
 461 2007-04-30  Murray Cumming  <murrayc@murrayc.com>
 462
 463         * src/modest-account-mgr-helpers.c:
 464         (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
 465         for the case that the account does not exist.
 466
 467         * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
 468         (equivalent to the modest account name) rather than the tinymail account name
 469         (equivalent to the modest account title - human readable) to get the account data.
 470         Check for null account data to prevent the crash, and add a TODO comment saying that
 471         this needs fixing because it is using the server account name instead of the account name.
 472
 473 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 474
 475         * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
 476         * src/maemo/modest-account-settings-dialog.c: (show_error),
 477         (show_ok):
 478         Use hildon_note_new_information() for informative and error messages,
 479         which seems to be expected for Maemo applications (no documentation that I know of
 480         says this). I am surprised that there is no distinction between info and error
 481         dialogs.
 482
 483 2007-04-29  Murray Cumming  <murrayc@murrayc.com>
 484
 485         * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
 486         it is easy to find where this is used.
 487
 488         * src/maemo/easysetup/modest-easysetup-wizard.c:
 489         (create_page_welcome), (create_page_account_details),
 490         (create_page_user_details), (create_page_complete_easysetup),
 491         (create_page_custom_incoming), (create_page_custom_outgoing),
 492         (create_page_complete_custom):
 493         * src/maemo/modest-account-settings-dialog.c:
 494         (create_page_account_details), (create_page_user_details),
 495         (create_page_incoming), (create_page_outgoing):
 496         * src/maemo/modest-account-view-window.c: (window_vbox_new):
 497         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 498         (modest_connection_specific_smtp_edit_window_init):
 499         * src/maemo/modest-connection-specific-smtp-window.c:
 500         (modest_connection_specific_smtp_window_init):
 501         * src/maemo/modest-signature-editor-dialog.c:
 502         (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
 503         and scrolling policy as per the Email Application Layout Guide, if I have
 504         understood it.
 505
 506 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 507
 508         * src/modest-tny-account-store.c: (modest_tny_account_store_init):
 509         Remove the add_transport_account_func and add_store_account_func vfunc implementations,
 510         which were empty, because these vfuncs have been removed from TnyAccountStore.
 511         This fixes the build.
 512
 513 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 514
 515         * src/maemo/modest-main-window.c:
 516         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
 517         showing/hiding it. Added TODO because it probably should not be NULL.
 518         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
 519         because unnecessary g_warnings() make degugging difficult.
 520
 521 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 522
 523         * src/maemo/modest-msg-edit-window.c:
 524         (modest_msg_edit_window_select_color),
 525         (modest_msg_edit_window_select_background_color): 2 const corrections and
 526         moving 2 #endifs before closing brackets, to fix the build.
 527
 528 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 529
 530         * src/maemo/easysetup/modest-easysetup-wizard.h:
 531         * src/maemo/easysetup/modest-easysetup-wizard.c:
 532         (modest_easysetup_wizard_dialog_finalize),
 533         (on_button_edit_advanced_settings), (create_page_complete_custom),
 534         (on_response), (create_account):
 535         Implement the Advanced Settings edit button, by saving the account information,
 536         for the Advanded Settings dialog to use directly from gconf, and removing it
 537         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
 538         Bug #5533 in the projects.maemo.org bugzilla.
 539
 540 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 541
 542         * src/maemo/modest-msg-view-window.c:
 543         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
 544         when opening a message window.
 545
 546 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 547
 548         * src/maemo/easysetup/modest-easysetup-wizard.c:
 549         (create_page_custom_outgoing): Correct the position of the horizontal separator to
 550         match the UI spec.
 551
 552         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
 553         before showing/hiding them, to avoid a crash when clicking on folders when there are no
 554         gconf settings. I probably added more checks than necessary, but that is safer.
 555
 556         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
 557         variable to fix the build, but this seems to be used when it is still NULL.
 558
 559 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 560
 561         * src/modest-platform.h:
 562         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
 563         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
 564         * src/modest-main.c: Implement this function so we can avoid using
 565         maemo-specific API from cross-platform code.
 566         (main):
 567         * src/modest-tny-account-store.c:
 568         (get_smtp_specific_transport_account_for_open_connection):
 569         * src/modest-ui-actions.c: (check_for_connection),
 570         (modest_ui_actions_on_item_not_found):
 571         Use modest_platform_connect_and_wait() and put #idefs around other
 572         maemo-specific code, because only maemo currently has a way to
 573         identify connection names.
 574
 575 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
 576
 577         * src/modest-tny-account-store.h:
 578         * src/modest-tny-account-store.c:
 579         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
 580         the connection-specific SMTP server settings in the configuration.
 581
 582         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
 583         (on_idle_mail_to):
 584         * src/maemo/modest-main-window.c: (on_connection_changed),
 585         (connect_signals):
 586         * src/modest-main.c: (main), (start_ui), (send_mail):
 587         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
 588         that is what is intended.
 589
 590         * src/modest-ui-actions.c: (action_send), (action_receive),
 591         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
 592         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
 593         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
 594         SMTP server is used when it is specified.
 595
 596         (modest_ui_actions_on_send_receive):
 597         Check that a connection is open before proceeding.
 598         Receive and then send, instead of vice-versa, as per the specification.
 599
 600 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 601
 602         * src/modest-mail-operation.c:
 603         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
 604         though I guess it should be something other than NULL.
 605
 606 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
 607
 608         * src/maemo/easysetup/modest-easysetup-wizard.c:
 609         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
 610         combo twice, to avoid an g_warning and to make it visible again.
 611         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 612         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 613         (already intended) dereference when detaching, because we then recreate the menu.
 614         But I am not sure why the warning was happening, and it is possible that this is a memory
 615         leak.
 616
 617 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 618
 619         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 620         and uri_parse_mailto() utility functions.
 621         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 622         the mailto URI.
 623         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 624
 625 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 626
 627         * src/dbus_api/modest-dbus-api.h:
 628         * src/dbus_api/modest-dbus-callbacks.c:
 629         Use an idle callback to execute the modest code in the application's own thread.
 630         Remove the helloworld example method.
 631         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 632         parsed, and the open-message method is not implemented because this is not yet implemented in
 633         modest itself.
 634         * libmodest-dbus-client/libmodest-dbus-client.c:
 635         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 636         (libmodest_dbus_client_open_message):
 637         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 638
 639         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 640         body without crashing.
 641
 642         * tests/dbus_api/Makefile.am:
 643         * tests/dbus_api/test_mail_to.c:
 644         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 645
 646 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 647
 648         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 649         Added file to fix the build. Sorry.
 650
 651         * src/dbus_api/Makefile.am:
 652         * src/dbus_api/modest-dbus-api.h:
 653         * src/dbus_api/modest-dbus-callbacks.h:
 654         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 655         (modest_dbus_req_handler):
 656         Put constants in a separate header so it can be reused by the
 657         client library, without duplication
 658
 659         * libmodest-dbus-client/Makefile.am:
 660         * libmodest-dbus-client/libmodest-dbus-client.c:
 661         (libmodest_dbus_client_call_helloworld),
 662         (libmodfest_dbus_client_send_mail),
 663         (libmodfest_dbus_client_mailto),
 664         (libmodfest_dbus_client_open_message):
 665         * libmodest-dbus-client/libmodest-dbus-client.h:
 666         (Partly) Implement a send_mail D-Bus method.
 667
 668         * tests/dbus_api/Makefile.am:
 669         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 670         the send_email D-Bus method.
 671
 672 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 673
 674         * Makefile.am:
 675         * configure.ac:
 676         * libmodest-dbus-client/Makefile.am:
 677         * libmodest-dbus-client/libmodest-dbus-client.c:
 678         * libmodest-dbus-client/libmodest-dbus-client.h:
 679         * tests/dbus_api/Makefile.am:
 680         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 681         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 682
 683 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 684
 685         * src/maemo/easysetup/modest-easysetup-wizard.c:
 686         (create_page_account_details):
 687         * src/maemo/modest-account-settings-dialog.c:
 688         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 689         widgets, because this might not be the default in future versions of the Maemo GTK+.
 690         However, I can not not get capitalization to work even in a simple test case.
 691
 692 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 693
 694         * src/maemo/easysetup/modest-easysetup-wizard.c:
 695         (create_page_custom_incoming), (create_page_custom_outgoing):
 696         * src/maemo/modest-account-settings-dialog.c:
 697         (create_page_account_details), (create_page_incoming),
 698         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 699         instead of using gtk_check_button_with_label(), so they are aligned like the other
 700         widgets, as per the UI spec.
 701
 702 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 703
 704         * src/maemo/easysetup/modest-easysetup-wizard.c:
 705         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 706         * src/widgets/modest-validating-entry.c:
 707         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 708         Modest prefix instead of an EasySetup prefix.
 709
 710 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 711
 712         * src/widgets/modest-validating-entry.h:
 713         * src/widgets/modest-validating-entry.c: (on_insert_text),
 714         Added easysetup_validating_entry_set_max_func(), used to set a callback
 715         to call when the max number of characters is reached. GtkEntry has a max-length
 716         already but is silent about it.
 717
 718         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 719         (create_page_account_details), (create_page_user_details),
 720         (create_account):
 721         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 722         (create_page_account_details), (create_page_user_details),
 723         (create_page_outgoing):
 724         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 725         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 726         the UI spec, when the user tries to enter more than the max number of characters.
 727
 728 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 729
 730         * src/maemo/easysetup/modest-easysetup-wizard.c:
 731         (create_page_user_details), (create_page_custom_incoming),
 732         (create_page_custom_outgoing):
 733         * src/maemo/modest-account-settings-dialog.c:
 734         (create_page_user_details), (create_page_incoming),
 735         (create_page_outgoing):
 736         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 737         (modest_connection_specific_smtp_edit_window_init):
 738         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 739         not appropriate. Bad Maemo-specific defaults!.
 740
 741 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 742
 743         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 744         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 745         (modest_signature_editor_dialog_set_settings):
 746         Disable the label and textview when the checkbox is disabled, and use the
 747         specified (UI spec) default signature text.
 748
 749 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 750
 751         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 752         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 753
 754         * src/modest-defs.h:
 755         * src/modest-account-mgr-helpers.h:
 756         * src/modest-account-mgr-helpers.c:
 757         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 758
 759         * src/maemo/Makefile.am:
 760         * src/maemo/modest-signature-editor-dialog.c:
 761         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 762         as per the UI spec.
 763
 764         * src/maemo/modest-account-settings-dialog.h:
 765         * src/maemo/modest-account-settings-dialog.c:
 766         (modest_account_settings_dialog_finalize), (on_button_signature),
 767         (save_configuration): Use the new dialog when the Edit button is pressed, and
 768         save the changes if necessary, as per the UI spec.
 769
 770 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 771
 772         * src/maemo/Makefile.am:
 773         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 774         based on maemo-develoers email from Dirk.
 775
 776         * src/maemo/easysetup/modest-easysetup-wizard.c:
 777         (create_page_welcome), (create_page_account_details),
 778         (create_page_user_details), (create_page_complete_easysetup),
 779         (create_page_custom_incoming), (create_page_custom_outgoing),
 780         (create_page_complete_custom),
 781         (modest_easysetup_wizard_dialog_init):
 782         * src/maemo/modest-account-settings-dialog.c:
 783         (create_page_account_details), (create_page_user_details),
 784         (create_page_incoming), (create_page_outgoing),
 785         (modest_account_settings_dialog_init):
 786         * src/maemo/modest-connection-specific-smtp-window.c:
 787         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 788
 789 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 790
 791         * src/maemo/easysetup/modest-easysetup-wizard.c:
 792         (create_page_account_details), (create_page_custom_outgoing),
 793         (create_page_complete_custom):
 794         * src/maemo/modest-account-settings-dialog.c:
 795         (create_page_user_details), (create_page_incoming),
 796         (create_page_outgoing):
 797         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 798         (modest_connection_specific_smtp_edit_window_init):
 799         Use the correct (UI spec) port min/max, and use horizontal separators,
 800         as per the UI spec.
 801
 802 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 803
 804         * src/maemo/easysetup/modest-easysetup-wizard.c:
 805         (set_default_custom_servernames):
 806         * src/maemo/modest-account-settings-dialog.c:
 807         (create_page_incoming), (on_combo_outgoing_security_changed),
 808         (on_combo_incoming_security_changed), (create_page_outgoing),
 809         (modest_account_settings_dialog_set_account_name),
 810         (save_configuration):
 811         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 812         (on_combo_security_changed),
 813         (modest_connection_specific_smtp_edit_window_init),
 814         (modest_connection_specific_smtp_edit_window_set_connection),
 815         (modest_connection_specific_smtp_edit_window_get_settings):
 816         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 817         as per the UI spec.
 818
 819 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 820
 821         * po/en_GB.po:
 822         * src/maemo/easysetup/modest-easysetup-wizard.c:
 823         (create_page_custom_outgoing), (create_page_complete_custom):
 824         * src/maemo/modest-account-settings-dialog.c:
 825         (create_page_user_details), (create_page_outgoing):
 826         * src/maemo/modest-account-view-window.c: (button_box_new):
 827         Use changed logical IDs as per the most recent UI spec:
 828         mcen_bd_emailsetup_edit -> mcen_bd_edit
 829         mcen_bd_emailsetup_delete -> mcen_bd_delete
 830         mcen_bd_emailsetup_close -> mcen_bd_close
 831
 832 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 833
 834         * configure.ac:
 835         * src/Makefile.am:
 836         * src/dbus_api/Makefile.am:
 837         * src/dbus_api/modest-dbus-callbacks.c:
 838         * src/dbus_api/modest-dbus-callbacks.h:
 839         * src/maemo/modest-platform.c: (modest_platform_init):
 840         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 841         method.
 842         * tests/Makefile.am:
 843         * tests/dbus_api/Makefile.am:
 844         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 845
 846 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 847
 848         * src/maemo/modest-account-settings-dialog.c:
 849         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 850         Removed unnecessary includes.
 851
 852 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 853
 854         * src/maemo/easysetup/modest-easysetup-wizard.c:
 855         * src/maemo/modest-account-settings-dialog.c:
 856         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 857         * src/widgets/Makefile.am:
 858         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 859         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 860         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 861         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 862         * src/widgets/modest-secureauth-combo-box.c:
 863         * src/widgets/modest-secureauth-combo-box.h:
 864         * src/widgets/modest-serversecurity-combo-box.c:
 865         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 866         made the GObject names more consistent with the rest of the Modest code.
 867
 868 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 869
 870         * src/maemo/easysetup/Makefile.am:
 871         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 872         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 873         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 874         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 875         * src/maemo/easysetup/modest-easysetup-wizard.c:
 876         * src/maemo/easysetup/modest-validating-entry.c:
 877         * src/maemo/easysetup/modest-validating-entry.h:
 878         * src/maemo/modest-account-settings-dialog.c:
 879         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 880         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 881         widgets/ because they are used outside of easysetup too. After checking in,
 882         svn will allow me to rename them too.
 883
 884 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 885
 886         * src/gnome/modest-msg-edit-window.c:
 887         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 888         linker error, to fix the build on the GNOME platform.
 889         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 890         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 891         ifdefed out to avoid a warning.
 892
 893 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 894
 895         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 896         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 897         some alternative for GTK+ 2.6.
 898
 899 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 900
 901         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 902
 903         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 904         specified for EmailAccountsDialog in UI spec.
 905
 906         * src/maemo/easysetup/modest-easysetup-wizard.c:
 907         * src/maemo/easysetup/modest-easysetup-wizard.h:
 908         * src/maemo/modest-account-settings-dialog.c:
 909         * src/maemo/modest-account-settings-dialog.h:
 910         Reuse a member window widget for the connection-specific SMTP server accounts,
 911         so we can tell it to create/save the accounts only if we actually save changes.
 912
 913         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 914         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 915         (modest_connection_specific_smtp_edit_window_get_settings):
 916         Return a struct instance for temporarily remembering the entered data.
 917
 918         * src/maemo/modest-connection-specific-smtp-window.h:
 919         * src/maemo/modest-connection-specific-smtp-window.c:
 920         (modest_connection_specific_smtp_window_finalize),
 921         (modest_connection_specific_smtp_window_fill_with_connections),
 922         (on_button_edit),
 923         (modest_connection_specific_smtp_window_save_server_accounts),
 924         (update_model_server_names): Do not actually save data until asked,
 925         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 926
 927         (on_selection_changed),
 928         (modest_connection_specific_smtp_window_init): Disable the edit
 929         button when nothing is selected.
 930
 931         * src/modest-account-mgr-helpers.c:
 932         * src/modest-account-mgr-helpers.h:
 933         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 934         elsewhere.
 935
 936 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 937
 938         * src/modest-account-mgr-helpers.h:
 939         * src/modest-account-mgr-helpers.c:
 940         (modest_account_mgr_get_unused_account_name),
 941         (modest_account_mgr_get_unused_account_display_name): Added these
 942         utility functions, to avoid code duplication.
 943
 944         * src/maemo/easysetup/modest-easysetup-wizard.c:
 945         (create_page_account_details), (create_account):
 946         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 947         (on_combo_security_changed),
 948         (modest_connection_specific_smtp_edit_window_init),
 949         (modest_connection_specific_smtp_edit_window_save_settings):
 950         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 951         * src/maemo/modest-connection-specific-smtp-window.c:
 952         (modest_connection_specific_smtp_window_finalize),
 953         (modest_connection_specific_smtp_window_fill_with_connections),
 954         (on_button_edit), (modest_connection_specific_smtp_window_init):
 955         * src/maemo/modest-connection-specific-smtp-window.h:
 956         Implementing saving of connection-specific server accounts.
 957
 958         But I need to refactor this so we can save the data for each
 959         possible connection-specific account and only actually create the server accounts
 960         when the easysetup finished, or the OK button is pressed on the account settings
 961         dialog.
 962
 963 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 964
 965         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 966         (on_combo_security_changed):
 967         (modest_connection_specific_smtp_edit_window_init):
 968         Auto-fill the port number as in the account settings.
 969
 970         (modest_connection_specific_smtp_edit_window_set_connection):
 971         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 972         * src/maemo/modest-connection-specific-smtp-window.c:
 973         (fill_with_connections), (on_button_edit),
 974         (modest_connection_specific_smtp_window_init):
 975         Turn the edit window into a dialog to simplify the code, and
 976         set a WM hint as in a GtkDialog, because only a popup can be on top of
 977         another window in Maemo, and popups usually have no WM decoration.
 978
 979         * src/modest-defs.h:
 980         * src/modest-account-mgr-helpers.c:
 981         (modest_account_mgr_set_connection_specific_smtp),
 982         (modest_account_mgr_remove_connection_specific_smtp),
 983         (modest_account_mgr_get_connection_specific_smtp):
 984         * src/modest-account-mgr-helpers.h: Some functions to write the
 985         connection-specific SMTP server information. Not yet used.
 986
 987
 988         * src/widgets/modest-folder-view.c: (text_cell_data):
 989         Fix a warning about an uninitialized variable.
 990         (on_configuration_key_changed): Put an #ifdef around the use
 991         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 992
 993 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 994
 995         * src/maemo/modest-account-settings-dialog.h:
 996         * src/maemo/modest-account-settings-dialog.c:
 997         Added connect_for_modified() utility function to mark the new modified boolean.
 998
 999         (create_page_account_details), (create_page_user_details),
1000         (create_page_incoming), (create_page_outgoing), (on_response),
1001         (modest_account_settings_dialog_init),
1002         (modest_account_settings_dialog_set_account_name):
1003         Only warn about unsaved changes when there are actually unsaved changes.
1004
1005         * src/modest-account-mgr-helpers.c:
1006         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1007         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1008         to get the data from there in future.
1009
1010 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1011
1012         * src/modest-defs.h:
1013
1014         * src/modest-account-mgr-helpers.h:
1015         * src/modest-account-mgr-helpers.c:
1016         Store the security account setting in a single conf key instead of using
1017         the options list, so that the list is left for just the to-be-removed camel hack,
1018         and because gconf_client_set_list() is failing for some reason.
1019
1020         * src/modest-account-mgr.c:
1021         (modest_account_mgr_add_server_account):
1022         * src/maemo/modest-account-settings-dialog.c:
1023         (modest_account_settings_dialog_set_account_name),
1024         (save_configuration): Use the renamed functions.
1025
1026
1027 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1028
1029         * src/widgets/Makefile.am:
1030         * src/widgets/modest-limit-retrieve-combo-box.c:
1031         * src/widgets/modest-limit-retrieve-combo-box.h:
1032         * src/widgets/modest-retrieve-combo-box.c:
1033         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1034         the account settings dialog.
1035
1036         * src/modest-defs.h:
1037         * src/modest-account-mgr-helpers.h:
1038         * src/modest-account-mgr-helpers.c:
1039         (modest_server_account_get_option_secure_auth),
1040         (modest_server_account_set_option_secure_auth):
1041         * src/modest-account-mgr.c:
1042         (modest_account_mgr_add_server_account):
1043         Use the existing AUTH_MECH conf key for the secure-auth setting,
1044         instead of putting it in the list options, because this was actually used already.
1045
1046         * src/maemo/modest-account-settings-dialog.c:
1047         (create_page_account_details),
1048         (modest_account_settings_dialog_set_account_name),
1049         (save_configuration):
1050         * src/maemo/modest-account-settings-dialog.h:
1051         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1052         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1053
1054 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
1055
1056         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1057         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1058         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1059
1060         * src/modest-defs.h:
1061         * src/maemo/modest-account-settings-dialog.c:
1062         (create_page_incoming), (on_combo_outgoing_security_changed),
1063         (on_combo_incoming_security_changed), (create_page_outgoing),
1064         (modest_account_settings_dialog_set_account_name),
1065         (save_configuration): Load/Save the port number, and change it when the
1066         security combo changes, to suitable defaults.
1067
1068 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1069
1070         * src/modest-account-mgr.c:
1071         (modest_account_mgr_add_server_account): Set the security and secure-auth
1072         options, and add a comment saying that the other camel-specific options should be
1073         removed in future.
1074
1075 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1076
1077         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1078         found by valgrind.
1079         * src/modest-tny-account-store.c: (account_list_free),
1080         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1081         cursor->data after unreffing it. But there is some strange stuff there so it might not be
1082         easy to fix.
1083
1084 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1085
1086         * src/modest-protocol-info.c:
1087         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1088         is required by our UI spec. Maybe something in our implementation will use this eventually.
1089         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1090         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1091         instead of the previous 0 placeholder.
1092
1093         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1094         secure-auth settings.
1095         * src/modest-account-mgr-helpers.h:
1096         * src/modest-account-mgr-helpers.c:
1097         (modest_server_account_data_get_option_secure_auth),
1098         (modest_server_account_set_option_secure_auth),
1099         (modest_server_account_data_get_option_security),
1100         (modest_server_account_set_option_security): Added this API for getting and setting the security
1101         and secure-auth settings.
1102
1103         * src/maemo/modest-account-settings-dialog.h:
1104         * src/maemo/modest-account-settings-dialog.c:
1105         (modest_account_settings_dialog_finalize), (check_data),
1106         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1107         about changing titles.
1108         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1109         (save_configuration): Save the security and secure-auth settings.
1110
1111         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1112         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1113
1114 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
1115
1116         * src/modest-defs.h:
1117         * src/modest-account-mgr.c:
1118         (modest_account_mgr_add_server_account):
1119         Added and used defines for the options key and value pair strings,
1120         that are used so far, though they do not seem to correspond to anything in our
1121         UI specs or ModestProtocol enum.
1122
1123         * src/modest-account-mgr-helpers.h:
1124         * src/modest-account-mgr-helpers.c:
1125         (compare_option_strings_for_name),
1126         (modest_server_account_data_get_option_value),
1127         (modest_server_account_data_get_option_bool),
1128         (modest_account_mgr_get_server_account_option):
1129         Added helper functions for parsing the options GSList.
1130
1131 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1132
1133         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1134         display name is based on the supplied account name.
1135         * src/modest-account-mgr.c:
1136         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1137         with an inefficient, but good-enough, implementation.
1138
1139         * src/maemo/easysetup/modest-easysetup-wizard.c:
1140         (create_page_account_details), (on_before_next), (create_account):
1141         Check for existing display names rather than (non-user-visible) account names, and just
1142         create and set a unique account name at the end.
1143
1144         * src/maemo/modest-account-settings-dialog.c:
1145         (modest_account_settings_dialog_init),
1146         (modest_account_settings_dialog_set_account_name),
1147         (create_page_incoming): Show the display name, instead of the account name.
1148         (on_response): Do some (not all) extra checks, as in the UI spec.
1149         (save_configuration): Save the display name if it was changed.
1150
1151 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1152
1153         * po/en_GB.po: Added needed logical ID and translation.
1154         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1155         (init_view): Made the is-default column clicking work.
1156
1157 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1158
1159         * configure.ac:
1160         * src/maemo/easysetup/Makefile.am:
1161         * src/maemo/easysetup/modest-easysetup-wizard.c:
1162         (modest_easysetup_wizard_dialog_init):
1163         * src/maemo/easysetup/provider-data-test.keyfile:
1164         * src/maemo/easysetup/provider-data.keyfile:
1165         Moved the provider data file to the new modest-providers-data package and used it from there.
1166
1167 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
1168
1169         * src/modest-local-folder-info.c:
1170         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1171         N_() was already used on the static strings, but this just marks it for translation without
1172         using the translation.
1173
1174 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1175
1176         * src/maemo/modest-account-settings-dialog.c:
1177         (create_page_incoming),
1178         (modest_account_settings_dialog_set_account_name):
1179         Added comments about the need for new API in ModestAccountMgr to handle the authentication
1180         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1181         I will do this if nobody else gets there first.
1182
1183 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1184
1185         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1186         Saved much of the incoming and outgoing data too, though I cannot yet see how to
1187         save the security stuff.
1188
1189 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1190
1191         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1192         Set the email address and user fullname, which I now see must be
1193         done separately.
1194
1195         * src/maemo/modest-account-settings-dialog.h:
1196         * src/maemo/modest-account-settings-dialog.c:
1197          (on_response),
1198         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1199         leave-on-server and authentication.
1200         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1201         how to do the rest.
1202
1203 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1204
1205
1206         * src/maemo/modest-account-settings-dialog.c:
1207         * src/maemo/modest-account-settings-dialog.h:
1208         Most (but not all) of the widgets are now present as specified by the UI spec.
1209         No changes are yet saved, and some details are not properly shown yet.
1210
1211         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1212
1213 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
1214
1215         * src/maemo/Makefile.am:
1216         * src/maemo/modest-account-settings-dialog.c:
1217         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1218         an existing account. Doesn't do much yet.
1219
1220         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1221         Open the accounts settings dialog when Edit is clicked.
1222
1223 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1224
1225         * src/maemo/easysetup/Makefile.am:
1226         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1227         (load_from_file):
1228         * src/maemo/easysetup/modest-easysetup-wizard.c:
1229         (modest_easysetup_wizard_dialog_init):
1230         Try to get the source directory from the build system,
1231         instead of hard-coding "./" into the source code, when opening our local
1232         copies of the configuration files.
1233         But this still fails when opening the wizard from the Accounts window,
1234         maybe because the working directory seems to change at runtime.
1235         So the wizard will fail the second time unless you copy the files into their
1236         proper locations - see the stdout warnings for the paths.
1237
1238         (create_page_account_details),(on_before_next):
1239         Check for existing non-server accounts instead of server accounts,
1240         so the default account name is useful again, and to prevent trying to
1241         recreate accounts.
1242
1243         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1244         Show the wizard when New is clicked.
1245
1246         * src/widgets/modest-account-view.c: (on_account_default_toggled),
1247         (init_view): Show the column headers, and show the columns that are
1248         specified in the UI specs. However, something in Maemo's GTK+ prevents
1249         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1250         change the default account. This is despite unsetting the special properties.
1251
1252 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1253
1254         * docs/reference/modest-design.sgml: Corrected spelling mistake.
1255         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1256         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1257         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1258         to make that clearer.
1259         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1260
1261 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1262
1263         * src/maemo/modest-account-view-window.c:
1264         (modest_account_view_window_init),
1265         (modest_account_view_window_new):
1266         Use the same buttons as specified in the
1267         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1268         the existing widgets, which never had a chance of working.
1269         Put the ModestAccountView treeview in a scrolled window.
1270         Do not repeat the initialization in both _init() and _new().
1271
1272         * src/widgets/modest-account-view.c: (update_account_view):
1273         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1274         this widget and window shows no accounts.
1275
1276         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1277
1278 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1279
1280         * src/maemo/easysetup/modest-easysetup-wizard.c:
1281         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1282         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1283         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1284         which seems wrong.
1285
1286         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1287         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1288         accounts exist yet, as in the UI spec.
1289
1290         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1291
1292 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1293
1294         * src/maemo/Makefile.am:
1295         * src/maemo/modest-connection-specific-smtp-edit-window.c:
1296         * src/maemo/modest-connection-specific-smtp-edit-window.h:
1297         New window for editing connection-specific smtp details.
1298         Not fully implemented.
1299
1300         * src/maemo/modest-connection-specific-smtp-window.c:
1301         (modest_connection_specific_smtp_window_finalize) :
1302         unref the tree model.
1303         (on_button_edit): Show the edit window.
1304
1305 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
1306
1307         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1308         error for me.
1309
1310         * src/maemo/Makefile.am:
1311         * src/maemo/modest-connection-specific-smtp-window.c:
1312         * src/maemo/modest-connection-specific-smtp-window.h:
1313         New window for showing the list of connections, for connection-specific
1314         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1315         * src/maemo/easysetup/modest-easysetup-wizard.c:
1316         (create_page_custom_outgoing): Show the new window when the button is clicked.
1317
1318 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1319
1320         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1321         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1322         * src/maemo/modest-msg-edit-window.c:
1323         (modest_msg_edit_window_insert_image):
1324         * src/modest-conf.c: (modest_conf_key_escape):
1325         * src/modest-mail-operation.c:
1326         (modest_mail_operation_send_new_mail):
1327         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1328         (modest_ui_actions_on_new_account):
1329         * src/widgets/modest-attachment-view.c: (update_filename_request):
1330         * src/widgets/modest-mail-header-view.c:
1331         Corrected warnings that were breaking the build, by commenting out unused variables,
1332         and a function, and by including a header.
1333
1334 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1335
1336         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1337         so we can #ifdef around platform-specific code when necessary.
1338         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1339         to allow this to build for the GNOME platform too.
1340
1341 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1342
1343         * src/maemo/easysetup/modest-easysetup-wizard.c:
1344         Added util_increment_name() and used it in create_page_account_details()
1345         to make sure that the default account name is always a new name.
1346
1347         (modest_easysetup_wizard_dialog_init),
1348         (set_default_custom_servernames): Some minor memory management fixes.
1349
1350 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
1351
1352         * Makefile.am:
1353         * configure.ac:
1354         * src/modest-runtime.c: (init_i18n): Restored the translation
1355         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1356         are defined in config.h, and the translations are installed.
1357
1358         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1359         is defined for translation.
1360
1361 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1362
1363         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1364         (load_from_file):
1365         * src/maemo/easysetup/modest-easysetup-wizard.c:
1366         (modest_easysetup_wizard_dialog_init):
1367         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1368         Use realistic paths (though they should use $prefix generically) to the
1369         mcc_mapping and provider-data.keyfile files which might work when they
1370         are installed by the future version of the operator-wizard package,
1371         and then fallback to paths in our source code, with an explanatory
1372         warning.
1373
1374 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
1375
1376         * configure.ac:
1377         * src/Makefile.am:
1378         * src/maemo/Makefile.am:
1379         * src/maemo/easysetup/: Added files from the previously-exernal
1380         osso-modest-easysetup.
1381         * src/maemo/modest-main-window-ui.h:
1382         * src/modest-ui-actions.c:
1383         * src/modest-ui-actions.h:
1384         Added modest_ui_actions_on_new_account() as a signal handler for the
1385         New Account menu item. It shows the easysetup wizard.
1386         * po/en_GB.po: Added additional needed logical IDs and translations.
1387
1388 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1389 Apparently ChangeLog is not used for some vague Nokia legal reasons.
1390