1 2007-08-15 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-ui-actions.h:
4 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
5 to modest_run_account_setup_wizard() and made it public.
6 * src/dbus_api/modest-dbus-callbacks.c:
7 (check_and_offer_account_creation), (on_idle_mail_to),
8 (on_idle_compose_mail), (on_idle_open_default_inbox):
9 Offer account creation if necessary, fixing projects.maemo.org
12 2007-08-15 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-ui-actions.c: (run_account_setup_wizard):
15 Return a gboolean to indicate success.
16 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
17 (modest_ui_actions_on_send): When offering account creation, only
18 give up (return) if account creation failed. Otherwise continue
19 with the original request. This fixed projects.maemo.org bug
22 2007-08-15 Murray Cumming <murrayc@murrayc.com>
24 * src/widgets/modest-recpt-editor.c:
25 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
26 to fix projects.maemo.org bug NB#63789.
28 2007-08-15 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
31 (modest_tny_account_store_new): Properly detect the memory card at
32 startup, and add an account for it.
34 2007-08-14 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
37 Commented out the MMC code again because it mistakenly detects
38 the card even when it isn't inserted.
40 2007-08-14 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
43 Renabled the call to add_mmc_account() because I do not believe
44 it could be the cause of the mentioned hang (in scratchbox, where
45 there is no memory card), and because I have tested that it works
48 2007-08-14 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
51 Comment out part of the last commit because it apparently causes
54 2007-08-14 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-tny-account-store.c: Added the add_mmc_account()
57 function to save some copy/pasting.
58 (modest_tny_account_store_new): If the memory card is mounted,
59 create an account for it at the start, instead of waiting for the
60 user to unmount it and mount it.
62 2007-08-13 Murray Cumming <murrayc@murrayc.com>
64 * src/widgets/modest-account-view.c: (on_account_changed):
65 Do not try to use the human-readable TnyAccount name instead of the
66 ID of the modest account to get the transport account. And unref
67 the transport account. This prevents a g_warning(), and a possible
70 2007-08-13 Murray Cumming <murrayc@murrayc.com>
72 * src/maemo/modest-platform.c:
73 (modest_platform_set_update_interval): Handle the new
74 alarmd error to warn when alarmd is not running, as is the case in
75 scratchbox for me now because
76 "Module /usr/lib/alarmd/libretu.so initialization failed"
78 2007-08-13 Murray Cumming <murrayc@murrayc.com>
80 * src/widgets/modest-header-view-render.c:
81 (_modest_header_view_compact_header_cell_data):
82 NULL some strings after freeing them, trying to deal with
83 the double deletion found in projects.maemo.org bug 64183,
84 probably having no effect.
86 2007-08-13 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/modest-account-settings-dialog.c:
89 (create_page_incoming), (create_page_outgoing): Use a define
90 for the min and max port numbers.
92 (check_hildon_number_editor_and_warn_value_not_in_range),
93 (check_data): Do an extra check for an invalid port number, as needed
94 in projects.maemo.org bug #64275, when the number is cleared, but this
95 does not work due to bugs.maemo.org bug #1806.
97 2007-08-13 Murray Cumming <murrayc@murrayc.com>
99 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
100 Comment out the debug warning about the unexpected D-Bus methods.
101 They are just annoying now.
102 * src/maemo/modest-platform.c:
103 (modest_platform_set_update_interval): Correct the D-Bus path, instead
104 of using a file path, though it did not seem to break things before.
105 It might be needed now:
106 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
107 modest is not already running. This is the behaviour of the old client, and
108 Mox says it is what we should do for modest.
109 This closes projects.maemo.org bug NB#64327.
111 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
113 * src/modest-text-utils.c:
114 Fixed invalid jump due to incorrect string/pointer
116 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
119 2007-08-01 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-account-mgr-helpers.h:
122 * src/modest-account-mgr-helpers.c:
123 Added modest_account_mgr_get_first_account_name(),
124 using code from modest_account_mgr_set_first_account_as_default().
126 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
127 (account_number_changed): Call set_at_least_one_account_visible() so that
128 the first account is visible when first added, without the user having to
130 I do wonder how this worked before.
132 2007-08-01 Murray Cumming <murrayc@murrayc.com>
134 * src/modest-tny-account-store.c: (show_password_warning_only),
135 (show_wrong_password), (request_password_and_wait), (get_password),
136 (modest_tny_account_store_alert): Remove the (incomplete anyway)
137 attempts to show UI only in the main context, which used g_idle_add()
138 and mainloops, because tinymail now guarantees that it only calls these
139 callbacks in the mainloop with the gdk lock. This makes everything much
142 2007-08-01 Murray Cumming <murrayc@murrayc.com>
144 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
145 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
146 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
147 error dialog, instead of ignoring it.
149 2007-08-01 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/modest-msg-view-window.c:
152 (modest_msg_view_window_get_header),
153 (modest_msg_view_window_last_message_selected):
154 Added comments to explain the use of priv->header_model.
155 * src/modest-ui-dimming-rules.c:
156 (modest_ui_dimming_rules_on_open_msg),
157 (modest_ui_dimming_rules_on_mark_as_read_msg),
158 (modest_ui_dimming_rules_on_mark_as_unread_msg),
159 (modest_ui_dimming_rules_on_remove_attachments),
160 (_invalid_attach_selected), (_selected_msg_marked_as):
161 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
162 and changed the parameter to a ModestMainWindow to make it clearer that
163 it never uses any other kind of window.
164 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
165 instead of the selected message.
166 I notice that much of the dimming code and the ModestMsgViewWindow code
167 hard-codes the assumption that the viewed message is always selected in
168 the header view. This does not seem wise or simple.
170 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
171 examine the actual message instead of whatever might be selected
172 in the header view. This stops the delete toolbar button and menu item
173 from being dimmed when opening a message view the search UI,
174 partially fixing projects.maemo.org bug NB#63811.
176 However, when actually deleting, I now get this warning:
177 "tny_header_set_flags: This is a header instance for a new message.
178 Only priority and attachment flags are supported"
180 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
182 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
184 Show account wizard if no accounts are defined while sending
185 (automatic sending after the account wizard finished does not
186 work because it takes some time until the account manager
187 synchronizes everything. (projects.maemo.org NB#62792)
189 2007-07-30 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account-store.c: (on_account_removed),
192 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
193 account is removed from the View menu. We have TnyAccountStore
194 and ModestTnyAccountStore signals that seem very similar, but this
195 seems to work for now.
197 * src/maemo/modest-main-window.c:
198 (on_show_account_action_activated): Prevent dereference
199 of a NULL if the accoutn does not really exist, though that
200 should not happen anymore.
202 This fixes projects.maemo.org bug NB#64606.
204 2007-07-30 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-ui-actions.c: (run_account_setup_wizard),
207 (modest_ui_actions_on_accounts): Revert a change that set these
208 to modal dialogs, freezing the UI when they show secondary dialogs.
209 This fixed projects.maemo.org bug NB#64519.
211 2007-07-27 Murray Cumming <murrayc@murrayc.com>
213 * src/widgets/modest-header-view-render.c:
214 (_modest_header_view_compact_header_cell_data):
215 Some checks and initialization to try to deal with a crash,
216 probably ineffective.
218 2007-07-27 Murray Cumming <murrayc@murrayc.com>
220 * src/maemo/modest-maemo-utils.c:
221 (modest_maemo_utils_get_supported_secure_authentication_methods):
222 Make sure that we have a connection, asking the user for one
224 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
225 Check for a connection before showing the wizard, because
226 the wizard needs a connection to check for server capabilities.
228 2007-07-27 Murray Cumming <murrayc@murrayc.com>
230 * src/maemo/modest-account-view-window.c:
231 (on_new_button_clicked): Remember the wizard dialog instance,
232 so we can just present it again if necessary. This prevents
233 multiple windows from appearing if you click again quickly on the
234 New button before the dialog appears, fixing projects.maemo.org
237 2007-07-27 Murray Cumming <murrayc@murrayc.com>
239 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
240 Offer a connection dialog if there is no connection when
241 starting modest. This should fix projects.maemo.org bug NB#61134.
243 2007-07-27 Murray Cumming <murrayc@murrayc.com>
245 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
246 Reverted my last commit. I was able to fix the build by doing
247 apt-get install wpeditor0 (replacing other wpeditor packages) and
248 an explicit apt-get install wpeditor-dev to upgrade the -dev
251 2007-07-27 Murray Cumming <murrayc@murrayc.com>
253 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
254 Commented out the use of wp_text_buffer_replace_image()
255 because it does not exist, to break the build. Added a TODO for it.
257 2007-07-26 Murray Cumming <murrayc@murrayc.com>
259 * src/modest-tny-account-store.c: (recreate_all_accounts):
260 Recreate them even if they were NULL before. I guess something
261 else was already creating them before, or this would never
263 (modest_tny_account_store_get_server_account): Make sure that
264 the tny accounts have been created before trying to find one.
265 This allows libmodest_dbus_client_compose_mail() to work
266 when the UI is not yet visible.
267 This is probably useful in other cases too.
269 (get_password): When the password is wrong after it is entered
270 in the protected password dialog, show an info banner (in an
271 idle handler) before showing the protected password dialog
274 2007-07-26 Murray Cumming <murrayc@murrayc.com>
276 * src/modest-ui-actions.h:
277 * src/modest-ui-actions.c: Added
278 modest_do_refresh_current_folder() containing some code from
279 modest_ui_actions_on_send_receive().
280 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
281 Call modest_do_refresh_current_folder() before refreshing the
282 requested account, as in modest_ui_actions_on_send_receive().
283 This is strange, but seems to be necessary to show new mails.
284 Now new emails are finally visible in the UI when downloaded
285 via the automatic update interval, fixing bug NB#57458.
286 This also works because bug NB#57458 has been fixed somehow.
288 2007-07-26 Murray Cumming <murrayc@murrayc.com>
290 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
291 printf more details when we get unhandled D-Bus methods, because
294 * src/modest-mail-operation.c: (update_account_thread):
295 Comment out the tny_camel_pop_store_account_reconnect(), because this
296 is apparently no longer needed, and it did not work before anyway.
297 See the comment in the code.
299 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
300 by checking the header flags. This fixes projects.maemo.org bug
303 2007-07-25 Murray Cumming <murrayc@murrayc.com>
305 * src/maemo/modest-maemo-utils.h:
306 * src/maemo/modest-maemo-utils.c: Added
307 modest_maemo_show_information_note_in_main_context_and_forget().
308 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
309 Use the new function to show simple error dialogs in the main
310 context, though question dialogs are still in the current context,
311 which is unfortunately usually not the main context. This should
314 2007-07-25 Murray Cumming <murrayc@murrayc.com>
316 * src/modest-tny-account-store.c: (get_password):
317 Never save the entered username and password in gconf,
318 because the UI spec says we should not. This helps
319 slightly with projects.maemo.org bug NB#63671.
321 2007-07-25 Murray Cumming <murrayc@murrayc.com>
323 * src/widgets/modest-msg-edit-window.h:
324 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
325 Moved some code here to make it simpler.
326 (modest_msg_edit_window_attach_file_one): Renamed from
327 modest_msg_edit_window_attach_file_interactive().
328 (modest_msg_edit_window_offer_attach_file): Renamed from
329 modest_msg_edit_window_attach_file() and used
330 modest_msg_edit_window_attach_file_one() instead of
331 copy/pasting the code. The old code for one was not using
332 GnomeVFS. This allows use of smb:// URLs when using send-as
333 from external applications, fixing bug NB#63741.
335 (modest_msg_edit_window_insert_image),
336 (modest_msg_edit_window_add_attachment_clicked):
337 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
338 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
339 Adapted to the new function names.
341 2007-07-25 Murray Cumming <murrayc@murrayc.com>
343 (modest_platform_set_update_interval): Set the alarm recurrence
344 fields so that auto-update does not just happen the first time.
345 This should have fixed projects.maemo.org bug NB#63938.
347 When this happens you can see a printf when the D-Bus method is
349 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
351 However, I do not actually seem to get new POP messages even when
352 clicking the refresh button manually. A restart gets them.
353 This might be a problem in today's tinymail only.
355 2007-07-24 Murray Cumming <murrayc@murrayc.com>
357 * src/maemo/modest-maemo-global-settings-dialog.c:
358 (current_connection):
359 Avoid a crash (probably only in scratchbox) when strcmp()ing a
360 NULL when closing the dialog.
362 2007-07-24 Murray Cumming <murrayc@murrayc.com>
364 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
365 Remove the hacky send/receive that didn't work, and instead
366 refilter the treemodel to make the deleted email really vanish from
367 the UI (though the delete-from-menu code does has commented out
368 the code that does that). This fixes projects.maemo.org bug
371 2007-07-24 Murray Cumming <murrayc@murrayc.com>
373 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
374 Try a couple of tricks to force the treeview to update (
375 poke the folder, and do a send/receive refresh), but the deleted
376 email still appears with a strike-through instead of really being
379 2007-07-23 Murray Cumming <murrayc@murrayc.com>
381 * src/dbus_api/modest-dbus-callbacks.c:
382 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
383 because their ID is not human-readable (see the comment about
384 improvements needed to the osso-email-interface API) and
385 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
387 2007-07-23 Murray Cumming <murrayc@murrayc.com>
389 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
390 (add_folders_to_list), (on_dbus_method_get_folders),
391 (modest_dbus_req_filter):
392 * src/maemo/modest-maemo-utils.c:
393 (on_camel_account_get_supported_secure_authentication):
394 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
395 (on_header_view_focus_in):
396 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
397 * src/modest-formatter.c: (modest_formatter_create_body_part):
398 * src/modest-mail-operation.c: (recurse_folders),
399 (update_account_thread), (get_msgs_full_thread),
400 (modest_mail_operation_get_msgs_full),
401 (modest_mail_operation_xfer_msgs):
402 * src/modest-search.c: (search_mime_part_and_child_parts),
403 (modest_search_account), (modest_search_all_accounts):
404 * src/modest-tny-account.c:
405 (modest_tny_account_get_special_folder), (recurse_folders):
406 * src/modest-tny-local-folders-account.c:
407 (modest_tny_local_folders_account_query_passes):
408 * src/modest-tny-msg.c: (copy_mime_part),
409 (modest_tny_msg_find_body_part_from_mime_part):
410 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
411 (modest_tny_send_queue_try_to_send):
412 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
413 (_modest_ui_actions_open), (download_uncached_messages),
414 (reply_forward), (modest_ui_actions_on_copy),
415 (modest_ui_actions_on_details), (has_retrieved_msgs),
416 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
418 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
419 (_selected_msg_marked_as), (_msg_download_completed),
420 (_selected_msg_sent_in_progress):
421 * src/widgets/modest-attachments-view.c:
422 (modest_attachments_view_set_message):
423 * src/widgets/modest-msg-view.c: (find_cid_image):
424 * tests/check_folder-transfer.c: (find_folders):
425 * tests/check_update-account.c: (func):
426 * tests/dbus_api/test_get_folders.c: (main):
427 Checked all uses of tny_iterator_get_current(), making sure
428 that the object is unreferenced (3 or 4 places did not),
429 and adding checks for NULL.
431 2007-07-23 Murray Cumming <murrayc@murrayc.com>
433 * src/dbus_api/modest-dbus-callbacks.c:
434 (on_idle_open_default_inbox): Make sure that the application UI is
436 * src/maemo/easysetup/modest-easysetup-wizard.c:
437 (on_entry_invalid_character): Show the word whitespace instead
438 of (null) in the banner when whitespace was entered.
439 (show_error): Add a comment that this does not work in
440 Maemo Bora, though we do not know why.
442 2007-07-23 Murray Cumming <murrayc@murrayc.com>
444 * src/modest-tny-account.c:
445 (modest_tny_account_get_special_folder): Use an if instead of
446 an assert for when the parent account name is NULL, because this
447 might be causing a crash in projects.maemo.org bug 63192.
448 * src/modest-mail-operation.c:
449 (modest_mail_operation_send_new_mail_cb),
450 (modest_mail_operation_remove_folder): unref the folder that is
451 returned from modest_tny_account_get_special_folder().
453 2007-07-23 Murray Cumming <murrayc@murrayc.com>
455 * src/modest-ui-actions.c:
456 (modest_ui_actions_on_password_requested):
457 Show mail_ib_login_cancelled info banner when the user cancels
458 the protected password dialog, to fix projects.maemo.org
461 2007-07-23 Murray Cumming <murrayc@murrayc.com>
463 * src/maemo/modest-account-settings-dialog.c:
464 (create_page_outgoing): Put this page in a GtkScrolledWindow,
465 matching the UI mock-up in the UI spec, and allowing access
466 to all widgets even when the on-screen keyboard is active.
468 2007-07-23 Murray Cumming <murrayc@murrayc.com>
470 Reverted this previous commit from Johannes,
471 because the scrollbars are always visible and because
472 I think we only need it on onepage of the account
473 settings, not the account wizard.
474 (I wrote the wrong instructions in the bug.)
476 * src/maemo/easysetup/modest-easysetup-wizard.c:
477 Added scrollbars to account wizard dialog.
478 Fixed projects.maemo.org NB #62744
480 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
482 * src/maemo/easysetup/modest-easysetup-wizard.c:
483 (create_page_user_details):
484 Use auto-cap for name (projects.maemo.org NB#63716)
485 * src/widgets/modest-account-view.c: (on_account_busy_changed):
487 2007-07-22 Armin Burgmeier <armin@openismus.com>
489 * src/maemo/modest-ui-actions.c: Use current account instead of
490 default account for creating viewer windows, so that the viewer
491 window knows to which account the viewed message belongs.
493 * src/maemo/modest-msg-view-window.c: Destroy the window when the
494 corresponding account is deleted. This fixes projects.maemo.org bug
497 2007-07-18 Armin Burgmeier <armin@openismus.com>
499 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
500 the dialog close after entering an invalid port number and clicking
501 OK. This fixes projects.maemo.org bug NB#63602.
503 2007-07-18 Armin Burgmeier <armin@openismus.com>
505 * src/modest-tny-account-store.c:
506 (get_server_accounts): Set parent modest account name for each
507 connection-specific transport account so that special folders of such
508 an account can be looked up. This fixes a crash when changing account
509 settings. This might also be related to projects.maemo.org bug
512 2007-07-16 Armin Burgmeier <armin@openismus.com>
514 * src/modest-ui-actions.c: Added a button to create a folder to the
515 move-to dialog. This fixes projects.maemo.org bug NB#.
517 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
519 * src/maemo/easysetup/modest-easysetup-wizard.c:
520 Added scrollbars to account wizard dialog.
521 Fixed projects.maemo.org NB #62744
523 2007-07-16 Murray Cumming <murrayc@murrayc.com>
525 * src/widgets/modest-msg-view.h:
526 * src/widgets/modest-msg-view.c:
527 Added modest_msg_view_get_message_is_empty() but this needs
529 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
530 Check if there is any text in the message yet.
531 But this needs to be implemented properly.
532 (modest_msg_edit_window_toggle_find_toolbar):
533 * src/maemo/modest-msg-view-window.c:
534 (modest_msg_view_window_toggle_find_toolbar):
535 Show a banner warning if there is no text to search, when
536 trying to start a search. This partially fixes
537 projects.maemo.org bug NB#62350.
539 2007-07-13 Murray Cumming <murrayc@murrayc.com>
541 * src/modest-mail-operation.c: (update_account_thread):
542 Initialized num_new_headers to fix the build.
544 2007-07-13 Murray Cumming <murrayc@murrayc.com>
546 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
547 Ignore modest accounts whose server accounts don't exist in gconf.
548 This prevents us trying to create TnyAccount instances for those
549 server accounts when the server account has been removed from gconf,
550 but the parent modest account has not yet been removed from modest.
551 I don't know why this is only noticeable now. It was probably just
552 a harmeless g_warning() anyway.
554 2007-07-13 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
557 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
559 2007-07-12 Armin Burgmeier <armin@openismus.com>
561 * src/maemo/modest-main-window.c: Make default account appear bold
562 in view, tools/send & receive and toolbar/send & receive SCM menus.
563 This fixes projects.maemo.org bug NB#59010.
565 2007-07-12 Murray Cumming <murrayc@murrayc.com>
567 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
568 Add a short-cut, by checking if the folder store is an account.
569 This ensures that the Sort menu item and toolbar is dimmed for
570 the local-folders account root item, fixing
571 projects.maemo.org bug NB#62545.
573 2007-07-12 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-tny-account-store.c: (get_password):
576 Show the password dialog (via the signal) only in the mainloop, via
577 an idle handler that we wait for. This could theoretically prevent
578 hangs, though I worry that it could introduce some too.
580 2007-07-12 Murray Cumming <murrayc@murrayc.com>
582 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
583 * src/maemo/modest-platform.c:
584 (modest_platform_connect_and_wait):
585 Take a TnyAccount* parameter and try to set it to online
586 (a TnyCamel-only API), because tinymail sets accounts to offline
587 when the user cancels a password dialog, and doesn't ask again until
588 it has been set to online.
589 However, this is commented out because it causes a hang now.
591 (modest_platform_connect_and_wait_if_network_account):
592 * src/modest-mail-operation.c:
593 (modest_mail_operation_update_account):
594 * src/modest-platform.h:
595 * src/modest-ui-actions.c: (_modest_ui_actions_open),
596 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
598 2007-07-12 Armin Burgmeier <armin@openismus.com>
600 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
602 * src/modest-mail-operation.c:
603 * src/modest-ui-actions.c: Check for already existing folder before
604 querying the server, show error message from camel if the request
605 still fails. This fixes projects.maemo.org bug NB#58701.
607 2007-07-12 Murray Cumming <murrayc@murrayc.com>
609 * src/modest-tny-account-store.h:
610 * src/modest-tny-account-store.c:
611 Added modest_tny_account_store_forget_password_in_memory(),
612 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
613 when creating a new account, so that new passwords will be used, instead of
614 us thinking that it's a second request as a result of a failed password again.
616 2007-07-12 Murray Cumming <murrayc@murrayc.com>
618 * src/dbus_api/modest-dbus-callbacks.c:
619 (on_idle_open_message): If the message is in drafts then open it
620 in an edit window instead of a view window. This fixes
621 projects.maemo.org bug NB#63005.
623 2007-07-12 Murray Cumming <murrayc@murrayc.com>
625 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
626 Avoided a harmless g_warning().
628 2007-07-12 Murray Cumming <murrayc@murrayc.com>
630 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
631 Pass the modest account name, not the TnyAccount display name to
632 modest_msg_view_window_new() so that the reply feature works,
633 fixing projects.maemo.org bug NB#62892.
635 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
636 (modest_msg_view_window_new_with_header_model):
637 * src/maemo/modest-msg-view-window.c:
638 (modest_msg_view_window_new_with_header_model),
639 (modest_msg_view_window_new):
640 * src/modest-ui-actions.c: (reply_forward):
641 * src/widgets/modest-msg-view-window.h:
642 * src/widgets/modest-window.c: (modest_window_set_active_account):
643 Rename an account parameter to modest_account_name to make this clearer.
645 2007-07-11 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-ui-actions.h:
648 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
649 modest_do_message_delete().
650 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
651 Call modest_do_message_delete(), hoping that this would cause messages
652 to be really deleted from search instead of just marked with strike through.
653 Does not seem to help.
655 2007-07-11 Armin Burgmeier <armin@openismus.com>
657 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
658 priv->reselect to FALSE prior to calling
659 modest_folder_view_select_first_inbox_or_local() to prevent endless
660 recursion and thus a crash on startup.
662 2007-07-11 Armin Burgmeier <armin@openismus.com>
664 * src/maemo/modest-account-settings-dialog.h: Include
665 <gtk/gtknotebook.h> to fix the build (at least for me).
667 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
668 Use "New FolderN" as default suggested name if "New folder" already
669 exists, with N being the first free number, though never exceed "New
670 folder99" in which case we just fall back to "New Folder" even though
671 it already exists. This fixes projects.maemo.org bug NB#58663.
673 2007-07-11 Murray Cumming <murrayc@murrayc.com>
675 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
676 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
677 projects.maemo.org bug NB#62778.
679 2007-07-11 Murray Cumming <murrayc@murrayc.com>
681 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
682 Ignore the wrong (for now) secure-smtp setting in the presets -
683 just default to requiring secure authentication for SMTP, because
686 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
688 * src/widgets/modest-folder-view.c: (filter_row)
689 Do not show drafts folder (see UI specs)
691 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
693 * src/modest-ui-actions.c:
694 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
695 place and also not necessary.
697 * src/widgets/modest-folder-view.c: (filter_row)
698 Guess folder type and hide Sent & Outbox if necessary.
699 Fixed project.maemo.org NB#57328
701 2007-07-11 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-ui-actions.h:
704 * src/modest-ui-actions.c:
705 (modest_ui_actions_on_delete_message):
706 Move some code into a new
707 modest_ui_actions_refresh_message_window_after_delete()
708 function so we can use it from elsewhere.
710 * src/dbus_api/modest-dbus-callbacks.c:
711 (on_idle_delete_message), (on_delete_message): Used an idle
712 handler, as we do for the other D-Bus method handlers.
713 Call modest_ui_actions_refresh_message_window_after_delete()
714 if the deleted message was open in a window. This fixed
715 projects.maemo.org bug NB#62862.
717 2007-07-11 Murray Cumming <murrayc@murrayc.com>
719 * src/modest-main.c: (main): Only show the UI at the start if
720 the showui command line option was given. For instance,
721 run-standalone src/modest showui
722 Otherwise, we wait for the top_application D-Bus method to
723 be sent by hildon-desktop when the application is selected
725 This allows us to run without a UI when osso-global-search
726 uses our D-Bus methods.
728 2007-07-11 Murray Cumming <murrayc@murrayc.com>
730 * src/dbus_api/modest-dbus-api.h: Added a define for a
731 top-application D-Bus method.
732 * src/dbus_api/modest-dbus-callbacks.c:
733 (on_top_application),
734 (modest_dbus_req_handler): Handle the top-application D-Bus
735 method, which might be an undocumented D-Bus signal sent by
736 hildon-desktop when it starts the application from the menu.
737 But I am not sure and I need to test it on the device, because
738 my scratchbox does not have the application in the menu now.
739 This method shows the main window, so that it can be invisible
740 when started, for instance, just for email searching from
743 * src/maemo/modest-main-window.c: (restore_settings),
744 (modest_main_window_new): Do not show the window immediately
745 upon creation. We show it later.
746 * src/modest-widget-memory.c: (save_settings_paned):
747 Try (unsuccessfully) to avoid saving the paned position when
748 it is not even visible.
749 (restore_settings_paned): Do not allow a silly paned position.
750 This seems necessary when not showing the window at first.
752 * tests/dbus_api/Makefile.am:
753 * tests/dbus_api/test_top_application.c: (main): Test for the
756 2007-07-10 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-ui-dimming-rules.c:
759 (modest_ui_dimming_rules_on_new_msg),
760 (modest_ui_dimming_rules_on_reply_msg),
761 (modest_ui_dimming_rules_on_delete_msg),
762 (modest_ui_dimming_rules_on_details),
763 (modest_ui_dimming_rules_on_view_window_move_to),
764 (modest_ui_dimming_rules_on_view_previous),
765 (modest_ui_dimming_rules_on_view_next),
766 (_invalid_folder_for_purge): Added checks before
767 casting the window. This looks like an actual
768 logic error in _invalid_folder_for_purge(), because it
769 tries to use a ModestMainWindow as a message window.
771 2007-07-10 Murray Cumming <murrayc@murrayc.com>
773 * src/maemo/modest-account-settings-dialog.c:
774 (show_error): Use the same implementation as in
775 modest-easysetup-wizard.c:
776 (on_entry_invalid_character): The logical ID contains a %s.
777 Guessed what it should be.
778 (on_entry_max), (check_data), (on_response): Adapt to
779 changed show_error().
780 (create_page_account_details): Really call
781 modest_validating_entry_set_func() on the correct widgets.
782 * src/maemo/easysetup/modest-easysetup-wizard.c:
783 (on_entry_invalid_character): Fix the logical ID here too.
784 (create_page_account_details),
785 (create_page_user_details):
787 modest_validating_entry_set_func() on the correct widgets.
789 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
790 Do not try to use the account if it is NULL.
792 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
794 * src/modest-ui-actions.c: (create_move_to_dialog),
795 (modest_ui_actions_on_main_window_move_to),
796 (modest_ui_actions_on_msg_view_window_move_to):
797 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
798 (filter_row), (modest_folder_view_show_non_move_folders):
799 * src/widgets/modest-folder-view.h:
801 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
802 the Sent folder yet as it does not report the correct folder type.
804 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
806 * src/maemo/modest-msg-edit-window.c: (init_window):
809 2007-07-10 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
812 Take a parent widget instead of a parent window, and
813 implement this with hildon_banner_show_information() instead.
814 Non-Maemo builds can just ifdef that there.
815 This fixed projects.maemo.org bug NB#62766.
817 (on_entry_invalid_character): Use show_error() again instead
818 of using hildon directly, and use the _CS() macro to use the correct
820 (create_account), (check_for_supported_auth_methods), (on_entry_max):
821 Pass a widget instead od a window to show_error().
823 2007-07-10 Murray Cumming <murrayc@murrayc.com>
825 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
826 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
827 This allows us to show the server name in the error message, fixing
828 projects.maemo.org bug NB#62904.
829 Also, use the appropriate logical ID message for the account protocol.
831 2007-07-10 Murray Cumming <murrayc@murrayc.com>
833 * src/modest-tny-account-store.c: (on_idle_wrong_password):
834 A compilation fix, though the build wasn't broken for me.
836 2007-07-09 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
839 Do not try to unref a NULL folder store, to avoid a runtime warning.
840 This seems to happen sometimes when changing accounts settings.
842 2007-07-09 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-tny-account-store.c:
845 (modest_tny_account_store_instance_init),
846 (modest_tny_account_store_finalize),
847 (on_account_settings_hide), (on_idle_wrong_password):
848 Use a GHashTable to ensure that we only show one account settings
849 dialog per modest account. This avoids us having a dialog open for
850 both the store and transport accounts, or due to repeated get_password()
851 calls that shouldn't happen anyway.
853 2007-07-09 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/modest-maemo-utils.c: (on_hide),
856 (modest_maemo_show_dialog_and_forget): Handle the response, because
857 the window is not even hidden by default.
859 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
860 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
861 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
862 which seems to prevent some modality problems.
864 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
865 Ignore user cancellation errors.
867 * src/modest-account-mgr-helpers.h:
868 * src/modest-account-mgr-helpers.c:
869 Added modest_server_account_get_password() and
870 modest_server_account_get_has_password() to avoid direct use of
873 * src/maemo/modest-account-settings-dialog.h:
874 * src/maemo/modest-account-settings-dialog.c:
875 (modest_account_settings_dialog_init): Store the notebook so we can
877 Added modest_account_settings_dialog_switch_to_user_info().
879 * src/modest-tny-account-store.c:
880 (get_password): When the password in the account settings is wrong (we think),
881 show the relevant page of the account settings dialog, in the mainloop.
882 However, we currently get many of these at once because cancel does not
884 (forget_password): Do not forget the password
885 from the account settings, because this causes side-effects when
886 tinymail seems to call it at strange time, maybe because of how we
887 are cancelling get_password().
888 (modest_tny_account_store_alert): Ignore user cancellations.
890 2007-07-09 Murray Cumming <murrayc@murrayc.com>
892 * src/maemo/modest-maemo-utils.h:
893 * src/maemo/modest-maemo-utils.c:
894 Added modest_maemo_show_information_note_and_forget() for use instead of
895 gtk_dialog_run() when the response is not needed, to avoid an extra
896 mainloop which could cause a hang.
898 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
899 Use the logical IDs for the error message, though they are not
900 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
901 because gtk_dialog_run() caused a hang here (the window did not close).
902 This fixes projects.maemo.org bug NB#62646.
904 2007-07-09 Murray Cumming <murrayc@murrayc.com>
906 * src/modest-account-mgr-helpers.h:
907 * src/modest-account-mgr-helpers.c:
908 Added modest_account_mgr_get_store_protocol().
910 * src/maemo/modest-account-view-window.c:
911 (on_delete_button_clicked): Show different warning text depending on
912 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
913 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
916 2007-07-09 Murray Cumming <murrayc@murrayc.com>
918 * src/maemo/modest-msg-edit-window.c:
919 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
920 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
922 2007-07-07 Armin Burgmeier <armin@openismus.com>
924 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
925 ckdg_ib_maximum_characters_reached from correct package.
927 * src/modest-ui-actions.c: Show an error message when a folder could
928 not be created. Tinymail does not give us specific error codes about
929 what has gone wrong, so we assume that a folder with that name
930 already exists, though there might be other reasons.
932 2007-07-06 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
935 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
936 give a more exact error message that can be partly translated.
938 2007-07-05 Murray Cumming <murrayc@murrayc.com>
940 * src/maemo/modest-address-book.c:
941 (select_email_addrs_for_contact): Specify a default window size for the
942 select-email-address dialog, so that it is probably big enough for the
943 title. This should fix projects.maemo.org bug NB#62277.
945 2007-07-05 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/easysetup/modest-easysetup-wizard.c:
948 (create_page_complete_easysetup): Use
949 gtk_widget_set_size() request to ensure that the text wraps
952 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
954 * src/maemo/easysetup/modest-easysetup-wizard.c:
955 (on_entry_invalid_character), (create_page_account_details),
956 (create_page_user_details):
957 Use new API of ModestValidatingEntry. But for some reason the banner is
958 not shown. I will have to investigate that further.
960 * src/widgets/modest-validating-entry.c: (on_insert_text),
961 (modest_validating_entry_set_func):
962 * src/widgets/modest-validating-entry.h:
963 Added a new callback function to be able to react to prevented
964 characters whitespaces to e.g show a banner.
966 2007-07-05 Armin Burgmeier <armin@openismus.com>
968 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
969 notification of HildonNumberEditor instead of remembering the port
970 number. Thanks to Johannes for pointing this out.
972 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
974 * src/maemo/easysetup/modest-easysetup-wizard.c:
975 Check if there are any user changes before showing a confirmation
976 dialog (projects.maemo.org NB#60946)
978 2007-07-05 Armin Burgmeier <armin@openismus.com>
980 * src/maemo/modest-account-settings-dialog.c: Remember custom port
981 number at the beginning of the dialog and set the modified flag at the
982 end if the port number has changed. This is necessary because
983 HildonNumberEditor does not support notification when the value has
986 2007-07-05 Murray Cumming <murrayc@murrayc.com>
988 * src/modest-ui-actions.c:
989 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
990 a connection before asking anything else. Correct the check for the destination
991 folder so that it succeeds when online.
992 This fixed projects.maemo.org bug NB#61645.
994 2007-07-05 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
997 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
998 to fix projects.maemo.org bug NB#62439.
1000 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-tny-account.c: (on_connection_status_changed):
1003 Really do not use tny_device_force_offline() here. See the previous comment.
1005 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1007 * src/modest-tny-account.c: (on_connection_status_changed):
1008 Do not use tny_device_force_offline() when tinymail says that something
1009 went wrong with the connection. It seems to report this unnecessarily.
1011 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/modest-connection-specific-smtp-window.c:
1014 (modest_connection_specific_smtp_window_init):
1015 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1016 does not seem to have any effect in osso 1.1 (though it works in
1017 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1019 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1021 * src/maemo/modest-connection-specific-smtp-window.c:
1022 Fix UI specification problems with projects.meamo.org NB#60479
1024 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1027 clue when this has failed, because the error dialog is not always shown
1028 (at least in earlier version).
1030 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1031 GError message, because the generic error dialog is not helpful.
1033 'This message is not currently available (can't let a new connection go online)'
1034 when trying to open an IMAP message.
1036 (_modest_ui_actions_open): Offer a connection when some messages would
1037 have to be downloaded and we are offline.
1039 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1041 * src/widgets/modest-folder-view.c:
1042 Don't check for MERGE type anymore as we use the correct type
1044 NOTE: For the last two changes you need to update your tinymail copy
1045 because of API changes!
1047 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1049 * src/modest-tny-local-folders-account.c:
1050 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1051 (see projects.maemo.org NB#61580)
1053 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-tny-account.c: (on_connection_status_changed):
1056 Commented out the call to modest_platform_connect_and_wait() because this
1057 seems to always hang, and I would like to know if this is the only thing
1058 that causes a hang when showing the connection dialog.
1059 It is not very useful anyway.
1061 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1063 * src/maemo/modest-msg-view-window.c:
1064 (modest_msg_view_window_select_next_message):
1066 * src/modest-platform.h:
1067 * src/maemo/modest-platform.c:
1068 Added modest_platform_connect_and_wait(), which calls
1069 tny_maemo_conic_device_connect() always in the main thread, by calling it
1070 in an idle handler and waiting for the idle handler to run. It should be
1071 in the main thread because it uses GTK+ UI code. It just returns TRUE
1072 if the device is already online.
1074 There is some nasty code to ensure that subsequent calls to
1075 modest_platform_connect_and_wait() just wait for the first one to finish,
1076 by checking repeatedly in another idle handler. This is necessary,
1077 because other threads (or even the main thread, via another idle handler)
1078 can call modest_platform_connect_and_wait() while
1079 modest_platform_connect_and_wait() is running.
1081 (modest_platform_connect_and_wait_if_network_account),
1082 (modest_platform_connect_and_wait_if_network_folderstore):
1083 Convenience functions that calls modest_platform_connect_and_wait() if
1084 the account or folder might want network access.
1086 * src/modest-mail-operation.c:
1087 (modest_mail_operation_update_account):
1088 * src/modest-ui-actions.c: (download_uncached_messages),
1089 (modest_ui_actions_on_rename_folder), (delete_folder),
1090 (modest_ui_actions_on_main_window_move_to),
1091 (modest_ui_actions_on_msg_view_window_move_to):
1092 * src/widgets/modest-folder-view.c:
1093 (drag_and_drop_from_folder_view):
1094 Offer a connection if we are offline.
1096 * src/modest-tny-account.c: (on_connection_status_changed):
1097 Document this as only handling errors during network operations in progress,
1098 and replace the idle code with a simple call to
1099 modest_platform_connect_and_wait(), which does this instead.
1101 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1103 * src/modest-tny-account.c:
1104 (modest_tny_account_get_special_folder): (util_on_idle),
1105 Handle the GError so we can see when tny_folder_store_get_folders()
1106 fails, as it currently does while something else is connecting.
1108 Added util_run_in_main_thread_and_wait()
1109 which uses an idlen handler and mainloop to ensure that the function
1110 is called in the main thread.
1111 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1112 to make sure that we call attempt the connection in the mainloop only,
1113 which might solve some hangs.
1115 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1117 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1118 be found by their display name. This is never useful.
1119 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1120 by its ID, instead of trying to use its ID as its display name.
1122 * src/modest-tny-account-store.h:
1123 * src/modest-tny-account.c:
1124 (modest_tny_account_get_special_folder): Add a g_warning() when
1125 tny_folder_store_get_folders() returns an empty list for the maildir.
1127 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1128 Add a g_warning() when this returns NULL, because that it not allowed
1131 2007-07-02 Armin Burgmeier <armin@openismus.com>
1133 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1134 note when trying to cancel the wizard. This fixes projects.maemo.org
1137 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-tny-account.h:
1140 * src/modest-tny-account.c:
1141 (modest_tny_account_new_from_server_account),
1142 (modest_tny_account_new_from_server_account_name),
1143 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1144 because this must now be set before setting the proto. This is usd in
1145 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1146 warning in camel_session_get_service() caused by
1147 tny_camel_transport_account_prepare().
1149 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1152 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1154 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1156 (modest_connection_specific_smtp_edit_window_init):
1158 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1159 of "changed" for now
1161 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1163 * src/modest-tny-account.c:
1164 (modest_tny_account_new_from_server_account):
1165 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1166 now uses to request a connection when it needs one, and which it uses
1167 to tell us that something is wrong with the connection, so we can force
1168 the accounts offline to prevent further problems.
1170 * src/modest-defs.h:
1171 * src/modest-init.c: (init_default_settings):
1172 * src/modest-mail-operation.c:
1173 (modest_mail_operation_update_account):
1174 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1175 This should not be necessary anymore. Do not set the conf key that
1176 determined this (it was always TRUE and not set anywhere else).
1178 * src/modest-ui-actions.h: Remove unused and unimplemented
1179 modest_ui_actions_on_online_toggle_toggled().
1181 2007-06-29 Murray Cumming <murrayc@murrayc.com
1183 * src/maemo/modest-main-window.c: (connect_signals):
1184 Don't connect to delete_event twice. Maybe this was harmless.
1186 2007-06-29 Murray Cumming <murrayc@murrayc.com
1188 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1189 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1190 Debug output to give some more clue when a folder move is not allowed.
1192 2007-06-28 Murray Cumming <murrayc@murrayc.com
1194 * src/modest-tny-account.c: (on_modest_file_system_info),
1195 (modest_tny_account_get_mmc_account_name):
1196 Always call the callback, without checking whether the name has changed.
1197 * src/widgets/modest-folder-view.c: (strings_are_equal),
1198 (on_model_foreach_set_name), (on_get_mmc_account_name),
1199 (text_cell_data): Compare the name here, and use the name from
1200 the account rather than from the
1201 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1202 if the name was changed after the account was added to the model.
1203 That's a tinymail bug but not one that I want to fix now.
1205 This finally fixes projects.maemo.org bug NB#59301.
1207 2007-06-27 Armin Burgmeier <armin@openismus.com>
1209 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1212 2007-06-27 Murray Cumming <murrayc@murrayc.com
1214 * src/modest-tny-account.h:
1215 * src/modest-tny-account.c:
1216 Added modest_tny_account_get_mmc_account_name(), to set the memory
1217 card name asynchronously for the given account and then notify.
1218 (modest_tny_account_new_for_local_folders): Use this new function instead
1219 of using hildon_file_system_info_async_new() directly.
1221 * src/widgets/modest-folder-view.c: (text_cell_data):
1222 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1223 gtk_tree_model_row_changed() when it is available.
1225 This should fix projects.maemo.org bug NB#59301.
1227 2007-06-27 Murray Cumming <murrayc@murrayc.com
1229 * src/modest-mail-operation.c: (update_account_thread),
1230 (get_msgs_full_thread): Fix typo failures in the revert
1233 2007-06-27 Murray Cumming <murrayc@murrayc.com
1235 * src/maemo/modest-maemo-global-settings-dialog.c:
1236 (idle_select_default_focus):
1237 * src/modest-mail-operation.c: (idle_notify_progress),
1238 (idle_notify_progress_once), (set_last_updated_idle),
1239 (update_account_thread), (get_msgs_full_thread):
1240 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1241 * src/widgets/modest-header-view.c:
1242 (idle_notify_headers_count_changed_destroy),
1243 (idle_notify_headers_count_changed):
1244 Reverted the additions of gdk_threads_enter/leave(), in case this
1245 helps with a startup hang on the device.
1247 2007-06-26 Armin Burgmeier <armin@openismus.com>
1249 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1250 for supported secure authentication methods from server by
1251 gtk_dialog_run(), saving CPU time and a potential race condition.
1253 2007-06-26 Armin Burgmeier <armin@openismus.com>
1255 * src/maemo/modest-maemo-utils.h:
1256 * src/maemo/modest-maemo-utils.c: Added a
1257 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1258 only error code to tell the calling code when the user canceled the
1261 * src/maemo/modest-account-settings-dialog.h:
1262 * src/maemo/modest-account-settings-dialog.c:
1263 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1264 message if the retrieval of secure authentication methods was canceled
1265 by the user. Perform the check before saving anything to configuration
1266 to not end up with half-committed configuration changes, do not show
1267 a "Saving to configuration failed" note when authentication methods
1268 could not be retrieved.
1270 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1273 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1275 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1276 Only return the first level of folders under accounts, because the
1277 osso-global-search UI spec doesn't want the rest.
1278 This fixed projects.maemo.org bug NB#61811.
1280 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1282 * src/modest-tny-account-store.c:
1283 * src/modest-tny-account-store.h:
1284 Added modest_tny_account_is_memory_card_account().
1285 * src/maemo/modest-main-window.c: (create_details_widget):
1286 Show the same information items for the memory card as we show for the
1287 local-folders, to fix projects.maemo.org bug NB#59307.
1289 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1291 * src/modest-tny-account-store.c: (get_password):
1292 Added some checks for NULL to maybe prevent crashes, though I think
1293 it was Philip's last commit that actually prevented the crash here
1294 when creating a first new account.
1295 But the new account is still not usable (no messages are shown)
1296 until a restart of the application.
1298 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1300 * src/maemo/modest-maemo-global-settings-dialog.c:
1301 (idle_select_default_focus):
1302 * src/modest-mail-operation.c: (idle_notify_progress),
1303 (idle_notify_progress_once), (idle_notify_update_account_queue),
1304 (set_last_updated_idle), (update_account_thread),
1305 (notify_get_msgs_full), (get_msgs_full_destroyer),
1306 (get_msgs_full_thread):
1307 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1308 * src/widgets/modest-header-view.c:
1309 (idle_notify_headers_count_changed_destroy),
1310 (idle_notify_headers_count_changed):
1311 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1312 all idle handlers, because some other thread could be blocking
1313 the GDK lock, so that it can do GUI stuff.
1315 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1317 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1318 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1319 (on_idle_send_receive), (on_idle_open_default_inbox):
1320 * src/maemo/modest-msg-edit-window.c:
1321 (modest_msg_edit_window_attach_file_noninteractive):
1322 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1323 to prevent a hang. I don't quite understand why these are necessary,
1324 beause we should already be in the main loop. I guess something outside
1325 of the main loop is taking the lock.
1327 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1328 we are really using URIs, and use files that are more likely to exist.
1330 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1332 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1333 necessary because configure.ac now defines different variables.
1335 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1337 * libmodest-dbus-client/libmodest-dbus-client.c:
1338 * libmodest-dbus-client/libmodest-dbus-client.h:
1339 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1340 libmodest_dbus_client_compose_mail() is what things actually use.
1342 * src/dbus_api/modest-dbus-api.h:
1343 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1344 * tests/dbus_api/Makefile.am:
1345 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1348 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-init.c: (modest_init_local_folders):
1351 For memory-card (or other non local-folders) maildir accounts,
1352 always create an Archive folder, so that there is somewhere to put
1353 messages. This should be less confusing, because the user does not need
1354 to guess that the need to create a folder.
1356 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1358 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1359 Fixed icon size by using (50, 50) which is the same as defined by
1362 2007-06-25 Armin Burgmeier <armin@openismus.com>
1364 * src/widgets/modest-window-mgr.c:
1365 * src/modest-init.c:
1366 * configure.ac: Correctly recognize hildon-notify presence and fixed
1367 the build without it being installed.
1369 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1371 * libmodest-dbus-client/libmodest-dbus-client.c:
1372 (libmodest_dbus_client_search): Fix the build. Sorry.
1373 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1374 (reply_forward_cb): Initialize variables to fix the build.
1376 * src/modest-tny-account-store.c:
1377 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1378 comparison (a silly typo) so that email search results can be opened
1379 when there are more than one account.
1381 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1383 * libmodest-dbus-client/libmodest-dbus-client.c:
1384 (libmodest_dbus_client_search),
1385 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1386 instead of 1 second, because the search gets folders and messages from
1387 the server, which can take a long time. When it times out,
1388 osso-global-search will report no results.
1390 We need to specify whether we should search only cached information
1391 (maybe with a user preference), and the osso-email-search-plugin
1392 API should really be improved to allow that option, and to allow results
1393 to be delivered asynchronously in batches.
1395 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1397 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1398 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1399 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1401 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1404 that is an empty string. D-Bus seems to give us these instead of NULL.
1406 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1408 * src/dbus_api/modest-dbus-callbacks.c:
1409 * src/maemo/easysetup/modest-easysetup-wizard.h:
1410 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1411 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1412 (modest_connection_specific_smtp_edit_window_init):
1413 * src/maemo/modest-maemo-global-settings-dialog.c:
1415 * src/maemo/modest-maemo-utils.c:
1416 (modest_maemo_utils_setup_images_filechooser):
1417 * src/maemo/modest-main-window.c: (create_details_widget):
1418 * src/maemo/modest-msg-edit-window.c:
1419 (modest_msg_edit_window_attach_file_noninteractive),
1420 (modest_msg_edit_window_color_button_change),
1421 (modest_msg_edit_window_set_zoom):
1422 * src/modest-mail-operation.c: (update_account_thread):
1423 * src/modest-tny-account-store.c:
1424 * src/modest-tny-account.c:
1425 * src/widgets/modest-global-settings-dialog.c:
1426 * src/widgets/modest-window.h:
1428 Fixed build on bora!
1430 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1432 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1433 * src/modest-search.c: (modest_search_folder),
1434 (modest_search_all_accounts): Actually search only in the specified folder,
1435 doing a simple match on the folder ID.
1436 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1437 and added some documentation.
1439 2007-06-22 Armin Burgmeier <armin@openismus.com>
1441 * src/maemo/modest-maemo-utils.h:
1442 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1443 modest_maemo_utils_get_supported_secure_authentication_methods.
1445 * src/maemo/easysetup/modest-easysetup-wizard.c:
1446 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1447 one occured, not just "Server does not support secure authentication".
1449 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-tny-account-store.c: (get_password):
1452 Restored the call to tny_account_set_user() because Philip seems to have
1453 stopped this from crashing (by not using the freed string). It still does
1454 not work, but now we can test it.
1456 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/modest-msg-edit-window.c: (init_window):
1459 Comment out use of an uninitialzed GtkScrolledWindow variable,
1460 to fix the build and stop a crash. Yet again.
1462 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-tny-account-store.c: (get_password):
1465 Remove the call to tny_account_set_user() because this actually crashes.
1466 As mentioned in the last commit, it is known to not work anyway.
1468 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1470 * src/modest-tny-account-store.c: (get_password):
1471 Use tny_account_set_username() to tell tinymail that the username might
1472 have changed too. But tinymail ignores this: see projects.maemo.org
1474 * src/modest-ui-actions.c:
1475 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1476 reset the connection when changing the username, and improve the comments.
1477 Save the changed username to gconf at least, so it is used when Modest is
1480 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1482 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1483 Do not use a query, so that we get all folders, including for POP and
1484 local-folders. They work as search criteria too.
1485 This fixes projects.maemo.org bug NB#57740.
1487 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1489 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1490 Comment out the use of hildon_notification_set_sound() because it is
1491 not declared, to fix the build. Warnings are serious, people.
1493 2007-06-21 Armin Burgmeier <armin@openismus.com>
1495 * src/maemo/modest-maemo-utils.h:
1496 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1497 modest_maemo_utils_get_supported_secure_authentication_methods()
1498 to query authentication methods for a specific user. This should fix
1499 projects.maemo.org bug NB#61369.
1501 * src/maemo/easysetup/modest-easysetup-wizard.c:
1502 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1505 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1507 * libmodest-dbus-client/libmodest-dbus-client.h:
1508 * libmodest-dbus-client/libmodest-dbus-client.c:
1509 (modest_dbus_message_iter_get_search_hit),
1510 (libmodest_dbus_client_search):
1511 Reorganised and commented this.
1512 Removed modest_search_hit_free() from the public API because it
1515 Added libmodest_dbus_client_get_folders() and
1516 modest_folder_result_list_free().
1518 * src/dbus_api/modest-dbus-api.h:
1519 * src/dbus_api/modest-dbus-callbacks.c:
1520 (modest_dbus_req_filter): Commented. Moved most code to
1521 on_dbus_method_search() and added on_dbus_method_get_folders().
1523 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1524 of the extra D-Bus handler.
1526 * tests/dbus_api/Makefile.am:
1527 * tests/dbus_api/test_get_folders.c: New test for
1528 libmodest_dbus_client_get_folders(). This seems to return an empty list
1529 at the moment. That could be the same error that causes the message list
1530 to be empty sometimes.
1531 This should help with projects.maemo.org bug NB#57740.
1533 2007-06-21 Armin Burgmeier <armin@openismus.com>
1535 * src/modest-mail-operation.c: Do not call
1536 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1537 notify the operation's end after having set the status to CANCELED for
1538 the operation queue to listen on. This fixes a deadlock when there
1539 were mail operations in the queue during its finalization.
1541 * src/modest-singletons.c: Reordered uninitialization of the account
1542 manager to happen after the mail operation queue was uninitialized
1543 because the mail operation's in the queue might still try to access
1544 the account manager (see modest_mail_operation_notify_end()). This
1545 fixes a potential crash when terminating the application.
1547 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1549 * src/modest-search.c:
1550 (search_mime_part_and_child_parts): Moved some code here so we
1551 can search recursively in child folders.
1552 (modest_search_folder): Search in the message as a mime part, instead
1553 of just its child mime parts.
1554 (read_chunk), (search_mime_part_ogs):
1555 Check how many bytes were read, to prevent an endless loop.
1556 Searching in message bodies now works. This finishes the fix for
1557 projects.maemo.org bug NB#61007.
1559 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1561 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1562 Add a g_warning when the item is not a folder.
1564 * src/modest-ui-dimming-rules.c:
1565 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1566 when selected item is not a folder (for instance, an account), because
1567 the UI spec only talks about folders.
1568 I am not sure what the UI spec wants, so this might not totally fix
1569 projects.maemo.org bug NB#60794.
1571 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1573 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1574 (load_from_file): Sort the list. The unsorted list would be more noticeable
1575 in non-English locales.
1577 * src/maemo/modest-msg-edit-window.c:
1578 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1579 warning and fix the build.
1581 * src/maemo/modest-progress-bar-widget.c:
1582 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1583 avoid a g_warning, and probably to avoid a crash.
1585 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-search.c: (modest_search_folder): Check for a GError
1588 when calling tny_folder_get_headers(), to show that this is not the cause
1591 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1593 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1594 Actually set the body query instead of the subject query.
1596 * src/modest-search.c: (search_mime_part_ogs),
1597 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1598 which would probably cause it to fail if we got this far.
1600 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1601 to simplify the code.
1602 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1603 be causing search-in-body to fail.
1605 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1607 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1609 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1610 Better debug message when the folder cannot be found.
1611 This should help with fixing projects.maemo.org bug #61287.
1612 * src/modest-search.c: (add_hit): Do not leak the furl string.
1614 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1616 * src/modest-ui-actions.c:
1617 (modest_ui_actions_on_folder_selection_changed):
1618 Do not special-case TNY_MERGE_FOLDER here, because
1619 modest_tny_folder_get_account() already does that. This fixes
1620 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1621 shown when the Outbox was selected).
1623 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1625 * libmodest-dbus-client/libmodest-dbus-client.c:
1626 (_dbus_iter_get_string_or_null): Initialize the string variable in
1627 case this helps with Dirk's crash.
1629 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1631 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1632 though it is not implemented yet (this function is maybe not even used),
1633 to avoid breaking ABI in future.
1634 * libmodest-dbus-client/libmodest-dbus-client.c:
1635 (get_attachments_string): Moved some code into this generic function.
1636 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1637 sends email. It is maybe not used.
1638 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1639 (on_send_mail): Use attachments.
1641 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1642 * src/maemo/modest-msg-edit-window.c:
1643 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1644 a filename before using it, to fix projects.maemo.org bug NB#58233.
1646 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1648 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1649 Initialize the continue_download variable to fix the build, and probably
1650 to fix randome behaviour.
1652 2007-06-18 Armin Burgmeier <armin@openismus.com>
1654 * src/modest-tny-send-queue.h:
1655 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1656 the queue so we can later show it in the UI. Replaced
1657 modest_tny_send_queue_msg_is_being_sent() by
1658 modest_tny_send_queue_get_msg_status().
1660 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1662 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1663 gpointer. This probably was not harmful, but just to be sure.
1665 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1667 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1668 Fix the build, but leave the function broken on Bora, because
1669 hildon_uri_action_get_service() does not exist.
1670 osso_uri_action_get_service() does not exist either, it seems.
1672 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1674 * src/modest-tny-account.c:
1675 (modest_tny_account_new_from_server_account):
1676 Uncommented the url debug output again, because it is useful for
1677 debugging, as I said in the comment.
1679 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1681 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1683 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1684 for Mameo Bora, to fix the build.
1686 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1689 Fixed build with hildon < 0.99
1691 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1692 Check if the selected account is busy instead of checking all accounts
1694 * src/modest-account-mgr-priv.h:
1695 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1696 (modest_account_mgr_init), (compare_account_name),
1697 (modest_account_mgr_set_account_busy),
1698 (modest_account_mgr_account_is_busy):
1699 * src/modest-account-mgr.h:
1700 Added busy information to the account manager. It possible to
1701 set an account to busy or not busy now.
1703 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1704 (modest_mail_operation_update_account),
1705 (modest_mail_operation_notify_end):
1706 Set the account to busy/not busy depending on the operation state.
1708 * src/widgets/modest-account-view.c:
1709 (modest_account_view_finalize), (get_last_updated_string),
1710 (update_account_view), (on_account_busy_changed), (init_view):
1711 Show string "Refreshing..." if the account is currently busy.
1713 All this fixes projects.maemo.org bug NB#59711
1715 2007-06-14 Armin Burgmeier <armin@openismus.com>
1717 * src/widgets/modest-attachments-view.h:
1718 * src/widgets/modest-attachments-view.c: Added
1719 modest_attachments_view_has_attachments() and fixed coordinate
1720 transformation in get_att_view_at_coords(). This fixes attachment
1723 * src/widgets/modest-msg-view.c: Make use of
1724 modest_attachments_view_has_attachments() to decide whether to show
1725 attachments in the header.
1727 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1729 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1730 (on_change), (on_combo_security_changed),
1731 (modest_connection_specific_smtp_edit_window_init),
1732 (modest_connection_specific_smtp_edit_window_set_connection),
1733 (modest_connection_specific_smtp_edit_window_is_dirty):
1734 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1735 * src/maemo/modest-connection-specific-smtp-window.c:
1738 Show an comfirmation dialog for the smpt-edit-window if there are
1739 unsaved changes and the user hits cancel.
1740 (projects.maemo.org bug NB#60479)
1742 2007-06-14 Armin Burgmeier <armin@openismus.com>
1744 * src/maemo/easysetup/modest-easysetup-wizard.c:
1745 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1746 address" info in banner instead of node, and select all the text as
1747 per UI spec. This fixes projects.maemo.org bug NB#60550.
1749 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1751 reviewed by: <delete if not using a buddy>
1753 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1754 * src/modest-ui-actions.c: (folder_refreshed_cb):
1756 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1758 * src/widgets/modest-folder-view.c: (filter_row):
1759 Explictly filter out the per-account outbox accounts. I don't know why
1760 these only sometimes show up, but now they should never show up in the UI.
1761 This should fix projects.maemo.org bug NB#60160.
1763 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1765 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1766 when the toolbar does not exist yet.
1767 * src/modest-widget-memory.c: (save_settings_header_view):
1768 Added g_warnings() to help us to discover when we are trying to set
1769 an empty columns list in gconf.
1771 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-init.h:
1774 * src/modest-init.c:
1775 Added modest_init_get_default_header_view_column_ids().
1777 * src/modest-widget-memory.c: (restore_settings_header_view):
1778 Use the new function to get defaults, if the gconf key is empty,
1779 instead of not creating any columns. This seems to fix the
1780 empty right-hand pane problems.
1782 * src/widgets/modest-header-view.h: Improved documentation.
1784 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1786 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1787 Revert the use of the display name as the account name, because this
1788 is generally wrong and would break the code that follows.
1790 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1792 * src/maemo/easysetup/modest-easysetup-wizard.c:
1793 (check_for_supported_auth_methods), (on_before_next),
1796 More correct fix for projects.maemo.org bug NB# 58991
1797 Do not longer accept AUTH_PASSWORD as secure method and choose
1798 correct method when creating the account.
1800 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1802 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1803 Fixed projects.maemo.org bug NB# 58991
1805 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1807 * src/modest-init.c: (modest_init_init_core),
1808 (modest_init_local_folders): Fixed compilation errors.
1810 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1812 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1813 Remove unnecessary lib/include, though it is good in principle when needed.
1815 * src/modest-init.c: (modest_init_one_local_folder),
1816 (modest_init_local_folders):
1817 * src/modest-init.h: Initialize the .modest library for memory cards,
1818 instead of just doing nothing for them. This should allow us to create
1819 folders there, fixing projects.maemo.org bug NB#59297.
1821 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1823 * libmodest-dbus-client/libmodest-dbus-client.c:
1824 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1825 (libmodest_dbus_client_compose_mail),
1826 (libmodest_dbus_client_open_message),
1827 (libmodest_dbus_client_send_and_receive),
1828 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1830 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1831 (on_idle_open_message), (modest_dbus_req_handler),
1832 (search_result_to_message), (modest_dbus_req_filter):
1833 * src/modest-search.c: (add_hit), (modest_search_folder),
1834 (modest_search_all_accounts): Improved debug messages.
1836 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1838 * src/modest-tny-account-store.c:
1839 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1842 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1845 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1847 * src/modest-tny-account-store.c: (get_server_accounts):
1848 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1849 even when there are no accounts, so that the Outbox folder is always
1850 visible. This fixes projects.maemo.org bug NB#60158.
1852 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1854 * src/maemo/modest-main-window.c: (create_details_widget):
1855 Use the mcen_va_never logical ID.
1857 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1859 * src/dbus_api/modest-dbus-api.h:
1860 * src/dbus_api/modest-dbus-callbacks.c:
1861 (on_idle_open_default_inbox), (on_open_default_inbox),
1862 (modest_dbus_req_handler):
1863 Added a new OpenDefaultInbox method.
1865 * libmodest-dbus-client/libmodest-dbus-client.h:
1866 * libmodest-dbus-client/libmodest-dbus-client.c:
1867 Added libmodest_dbus_client_open_default_inbox() to call the new
1868 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1869 though it should maybe be used by a new osso-email-interface function.
1871 * tests/dbus_api/Makefile.am:
1872 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1875 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1877 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1878 NULL, so that the signals get all the keys. This should not actually
1879 change any behaviour because we currently update everything when anything
1882 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1884 * src/widgets/modest-folder-view.c: (text_cell_data),
1885 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1886 (find_inbox_iter): If tinymail tells us that the folder is
1887 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1888 This causes the inbox to be selected at startup, fixing part of
1889 projects.maemo.org bug NB#56305.
1891 * src/modest-ui-dimming-rules.c:
1892 (modest_ui_dimming_rules_on_tools_smtp_servers):
1893 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1894 the SMTP servers menu item.
1895 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1896 that the SMTP Servers menu item is dimmed when there are no accounts,
1897 as a future version of the UI spec will require. This fixes
1898 projects.maemo.org bug NB#56305.
1900 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1902 * src/maemo/modest-maemo-utils.c:
1903 (modest_maemo_utils_get_supported_secure_authentication_methods):
1904 Added label to dialog instead of unreadable title
1906 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1907 (modest_main_window_new):
1908 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1911 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1912 * src/modest-account-mgr.h:
1913 Added method to avoid code duplication
1915 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1916 (modest_ui_actions_on_send_receive):
1917 Use modest_account_mgr_has_accounts
1919 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/easysetup/modest-presets.c:
1922 (modest_presets_get_info_server_security): Do not report secure auth
1924 * src/modest-protocol-info.c: Use the defines for the gconf key names
1925 for secure authentication. This was not working because we were writing
1926 Password and reading password, and the check was case sensitive.
1927 With this, gmail now works for receiving and sending when created via
1930 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1932 * src/maemo/easysetup/modest-presets.c:
1933 (modest_presets_get_info_server_security): Correct the key name for
1934 SecureSmtp, because it seems to be case-sensitive.
1935 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1936 Do not try to get the 0th notebook page if there are 0 pages, to
1937 avoid a g_warning().
1939 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1942 Prevent use of the new notification feature for now, because it currently
1943 shows one dialog for each new email, which is annoying.
1945 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1947 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1948 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1949 when no country was selected, so that we show the global ones.
1950 * src/maemo/easysetup/modest-presets.c:
1951 (modest_presets_get_providers): Return only the global providers, not
1952 all providers when mmc=0 was requested.
1954 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1956 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1957 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1958 provider ID in the combo.
1960 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1961 Do not show the page numbers, because it would be confusing when we add
1962 the 2 extra pages for the custom setup, when the user chooses the "Other"
1963 provider. This fixes projects.maemo.org bug NB#59028
1965 * src/modest-init.c: (modest_init_init_core),
1966 (modest_init_local_folders):
1967 * src/modest-init.h:
1968 * src/modest-tny-account.c:
1969 (modest_tny_account_new_for_local_folders): Do not create default folders
1970 for the memory card. This should fix projects.maemo.org bug NB#59328.
1972 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1974 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1975 Free the changed_conf_keys string items. They are already freed in the
1976 idle handler if that runs first.
1978 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1980 * src/modest-ui-actions.c:
1981 (modest_ui_actions_on_password_requested): Check that the server name
1982 is not NULL, because I just saw a password dialog with (null) as the
1985 * src/modest-tny-folder.[h|c]: Added
1986 modest_tny_folder_is_memory_card_folder().
1987 * src/modest-ui-dimming-rules.c:
1988 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1989 menu item for memory cards, as per the UI spec (section 7.4). This should
1990 fix projects.maemo.org bug NB#59297.
1992 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1994 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1995 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1996 is another problem with the code, see Murray's comment at line 772)
1998 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2000 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2001 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2002 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2003 (load_from_file), (easysetup_country_combo_box_init),
2004 (easysetup_country_combo_box_get_active_country_ids),
2005 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2006 instead of just one ID, to avoid duplicate country names in the UI.
2008 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2009 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2010 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2011 a single ID, avoiding duplicate providers.
2012 * src/maemo/easysetup/modest-easysetup-wizard.c:
2013 (on_combo_account_country): Adapt to use a list.
2015 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2017 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2018 keys changed in the last X seconds.
2020 * src/modest-account-mgr.h:
2021 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2022 (on_key_change), (modest_account_mgr_class_init),
2023 (modest_account_mgr_init), (modest_account_mgr_finalize):
2024 As the keys are changed, save them in a GSList* and signal that GSList*
2025 further every X seconds, to batch changes, to allow us to do just one
2026 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2027 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2029 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2030 changed signal signature.
2032 * src/modest-conf.c: (modest_conf_set_list),
2033 (modest_conf_on_change): Reenable notification.
2035 (modest_conf_maemo_fake_on_change): Comment out the hack that
2036 notified immediately instead of asynchronously.
2038 * src/widgets/modest-account-view.h:
2039 * src/widgets/modest-account-view.c:
2040 (update_account_view): Select the previously-selected account ID,
2041 if possible. This fixes projects.maemo.org bug NB#56933.
2043 (on_account_changed), (on_account_removed),
2044 (modest_account_view_select_account):
2046 Remove the block/unblock functions
2047 because they were not useful.
2049 * src/maemo/modest-account-view-window.c:
2050 (on_delete_button_clicked), (on_edit_button_clicked),
2051 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2053 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2056 Improve the error dialog to show Incorrect Account Settings, which seems
2057 clearer, and say that the internal error message (to be removed from the
2058 dialog later) is often misleading.
2059 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2061 * src/modest-tny-account.c:
2062 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2063 URL because this is so useful for debugging on the device.
2065 * src/widgets/modest-serversecurity-combo-box.c:
2066 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2068 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2070 * src/modest-mail-operation.c:
2071 (modest_mail_operation_send_new_mail):
2072 Added a comment about a nasty but apparently harmless message. Details
2073 added to the wiki g_warnings() page.
2075 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2077 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2078 (modest_tny_send_queue_class_init):
2079 Do not use the priv struct because it is empty, to avoid g_warnings
2080 about a non-existant priv struct.
2082 * src/modest-tny-account-store.c:
2083 (modest_tny_account_store_get_server_account),
2084 (modest_tny_account_store_get_transport_account_for_open_connection
2085 ): Do not try to get transport server accounts for local folders,
2086 because they don't have any. This avoids a g_warning().
2088 * src/maemo/modest-main-window.c:
2089 (modest_main_window_notify_send_receive_initied),
2090 (on_configuration_key_changed):
2091 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2092 * src/modest-defs.h:
2093 * src/modest-mail-operation.c:
2094 (modest_mail_operation_update_account):
2095 * src/modest-tny-account-store.h:
2096 * src/modest-tny-account.c:
2097 (modest_tny_account_get_special_folder),
2098 (modest_tny_account_new_for_local_folders),
2099 (modest_tny_account_new_for_per_account_local_outbox_folder):
2100 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2101 * src/modest-tny-local-folders-account.c:
2102 (add_account_folders_to_merged_folder):
2103 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2104 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2105 (modest_ui_actions_on_send):
2106 * src/widgets/modest-folder-view.c: (update_model):
2107 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2108 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2109 modest_tny_account_store_get_tny_account_by_account() to
2110 modest_tny_account_store_get_server_account() to make the code clearer.
2112 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2114 * src/dbus_api/modest-dbus-api.h:
2115 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2116 * src/maemo/modest-msg-edit-window.c:
2117 (modest_msg_edit_window_attach_file_noninteractive):
2118 added g_warning in case the file to be attached does not exist
2119 * tests/dbus_api/test_compose_mail.c: (main):
2120 removed obsolete comment, added generic files as test case
2122 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-tny-account-store.c: (get_server_accounts):
2125 Create the local folders account only once, not once for each outbox, and
2126 not only when there are some outboxes.
2128 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2130 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2131 code that is causing a crash at startup. Sergio says that he is fixing this.
2133 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2135 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2136 * src/maemo/modest-account-settings-dialog.c:
2137 (create_page_outgoing),
2138 (modest_account_settings_dialog_set_account_name),
2139 (save_configuration):
2140 - Fixed handling of the "Use secure authentication" toggle to comply with
2141 the ui specification. See also projects.maemo.org bug NB#58400
2143 - Restore the Secure connection setting combo correctly when loading
2146 * src/maemo/modest-maemo-utils.c:
2147 (on_camel_account_get_supported_secure_authentication),
2148 (modest_maemo_utils_get_supported_secure_authentication_methods):
2149 Fixed a crasher if operation is canceled
2151 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2152 (modest_protocol_info_auth_is_secure):
2153 * src/modest-protocol-info.h:
2155 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2156 the sense of the "Use secure authentication" toggle.
2158 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2160 * src/modest-tny-account-store.h:
2161 * src/modest-tny-account-store.c:
2162 Added modest_tny_account_store_get_local_folders_account().
2164 * src/modest-tny-folder.h:
2165 * src/modest-tny-folder.c:
2166 (modest_tny_folder_get_account):
2167 Added this replacement for tny_folder_get_account() which returns
2168 the local-folders account for TnyMergeFolders, to avoid the
2169 warning about the unimplemented get_account_func() vfunc().
2171 (modest_tny_folder_get_rules),
2172 * src/modest-ui-actions.c:
2173 (modest_ui_actions_on_folder_selection_changed):
2174 * src/modest-mail-operation.c:
2175 (modest_mail_operation_remove_folder),
2176 (modest_mail_operation_xfer_folder),
2177 (modest_mail_operation_rename_folder),
2178 (modest_mail_operation_get_msg),
2179 (modest_mail_operation_get_msgs_full),
2180 (modest_mail_operation_remove_msg),
2181 (modest_mail_operation_xfer_msgs),
2182 (modest_mail_operation_refresh_folder):
2183 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2185 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2187 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2188 (modest_server_account_set_security):
2189 * src/modest-defs.h: Add comments explaining that our
2190 UI spec means TLS when it says Normal, so these do not look like errors.
2192 * src/modest-tny-account.c:
2193 (modest_tny_account_new_from_server_account): Use the new tinymail
2194 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2195 for TLS. This should fix projects.maemo.org bug NB#58460.
2197 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2199 * src/maemo/easysetup/modest-easysetup-wizard.c:
2200 (create_account): Correct the position of the gconf sanity check warning.
2201 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2202 of using the g_idle_add() hack, because this does not seem to be necessary
2203 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2204 caused by something other than maemo's gconf.
2205 This fixes projects.maemo.org bug #59022.
2207 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2209 * src/modest-account-mgr-helpers.c:
2210 (modest_account_mgr_get_default_account): Do not check that the account
2211 exists if there is no default account (NULL), to fix a runtime warning.
2213 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2215 * src/widgets/modest-folder-view.c: (update_model):
2216 Do not unref the treemodel before we have finished with it.
2217 This prevents a valgrind warning and an occasional crash at startup.
2219 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2221 * libmodest-dbus-client/libmodest-dbus-client.h:
2222 added libmodest_dbus_client_compose_mail()
2223 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2225 added functions needed for SendAsMail() functionality
2226 * src/maemo/modest-msg-edit-window.c:
2227 (modest_msg_edit_window_attach_file_noninteractive):
2228 non interactively attaching files to message edit window
2229 * src/widgets/modest-msg-edit-window.h:
2230 * tests/dbus_api/Makefile.am:
2231 added test_compose_mail.c
2232 * tests/dbus_api/test_compose_mail.c: (main):
2234 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2236 * src/modest-account-view.c:
2237 Fixed bug projects.maemo.org bug NB#59307
2239 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2241 * src/maemo/easysetup/modest-easysetup-wizard.c:
2242 (get_serverport_incoming), (on_before_next), (create_account):
2243 * src/maemo/modest-account-settings-dialog.c:
2244 (modest_account_settings_dialog_set_account_name):
2245 * src/maemo/modest-maemo-utils.c:
2246 (on_camel_account_get_supported_secure_authentication_status),
2247 (on_camel_account_get_supported_secure_authentication),
2248 (on_secure_auth_cancel),
2249 (modest_maemo_utils_get_supported_secure_authentication_methods):
2251 Implemented security authentication for settings and easysetup.
2253 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2255 * src/maemo/modest-main-window.c: (create_details_widget):
2256 Show the total size for memory card accounts too, instead of showing
2257 the name again. Fixes bug projects.maemo.org bug NB#59307.
2259 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2262 * src/modest-tny-simple-folder-store.c:
2263 * src/modest-tny-simple-folder-store.h: Removed.
2265 * src/modest-tny-local-folders-account.h
2266 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2267 for the local-folders maildir, with an extra TnyMergedFolder containing
2268 the folders of the per-account outbox store accounts.
2269 * src/modest-tny-account-store.c: (get_server_accounts):
2270 Add the outboxes to the special local folders account after creating it.
2272 * src/modest-tny-account.c:
2273 (modest_tny_account_new_for_local_folders): Create the derived
2274 account when creating the main local-folders account.
2276 * src/maemo/modest-main-window.c: (create_details_widget),
2277 (modest_main_window_set_contents_style):
2278 Adapted to the use of the derived account instead of the folder store.
2280 * src/modest-ui-actions.c:
2281 (modest_ui_actions_on_folder_selection_changed):
2282 * src/modest-ui-dimming-rules.c:
2283 (modest_ui_dimming_rules_on_new_folder):
2284 * src/widgets/modest-folder-view.c: (text_cell_data),
2285 (icon_cell_data), (filter_row), (update_model),
2286 (get_cmp_rows_type_pos):
2289 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2290 Do not get the priv struct, because no priv struct has been set,
2291 to avoid a runtime warning.
2293 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2294 #ifelse with #else, to fix a warning, to fix the build.
2297 2007-06-05 Christian Kellner <ckellner@openismus.com>
2299 * libmodest-dbus-client/libmodest-dbus-client.c:
2300 Fix small typo in doc (why do you always see them
2301 AFTER committing stuff?)
2304 2007-06-05 Christian Kellner <ckellner@openismus.com>
2306 * libmodest-dbus-client/libmodest-dbus-client.c:
2307 (libmodest_dbus_client_search):
2308 Initialize hit list with NULL. Also set folder list
2309 to "" if NULL was supplied.
2312 2007-06-03 Christian Kellner <ckellner@openismus.com>
2314 * libmodest-dbus-client/libmodest-dbus-client.c:
2315 (modest_search_hit_list_free):
2316 Make it save to call it with NULL.
2318 * src/dbus_api/modest-dbus-callbacks.c:
2319 * src/modest-search.c:
2320 Return full ModestSearchHits as the search result list not TnyHeader
2321 since can't be around withouth the correspoding TnyFolder.
2323 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2325 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2326 Added currently commented code to check for secure auth
2328 * src/maemo/modest-account-settings-dialog.c: (on_response),
2329 (save_configuration), (show_ok):
2330 Fixed projects.maemo.org bugs NB #59248 and #59251
2332 * src/maemo/modest-maemo-utils.c:
2333 (on_camel_account_get_supported_secure_authentication_status),
2334 (on_camel_account_get_supported_secure_authentication),
2335 (modest_maemo_utils_get_supported_secure_authentication_methods):
2336 * src/maemo/modest-maemo-utils.h:
2337 Moved get_supported_secure_authentication() method here to be able
2338 to use it from easysetup wizard.
2340 * src/modest-pair.c: (on_pair_compare_as_string):
2341 Should compare string with first part of pair and not
2342 strcmp pairs which will crash.
2344 * src/modest-protocol-info.c:
2345 (modest_protocol_info_protocol_is_store):
2346 * src/modest-protocol-info.h:
2347 Added modest_protocol_info_get_auth_protocol_name()
2349 2007-06-03 Armin Burgmeier <armin@openismus.com>
2351 * src/modest-mail-operation.c:
2352 (modest_mail_operation_get_msgs_full): Set priv->account also when
2353 only retrieving a single message. This avoids a crash when canceling
2356 (modest_mail_operation_notify_end): Do not explicitely remove the
2357 operation from the queue but only emit the progress_changed signal.
2358 The queue itself listens to that signal to remove the operation when
2359 it is finished. This reduces coupling and removes a potential deadlock
2360 when modest_mail_operation_notify_end() is called from the queue
2361 itself. If that is a problem performance-wise, I would suggest to
2362 implement a status-changed signal or something.
2364 * src/modest-mail-operation-queue.c: Make sure to never call a
2365 function from another file while the queue is locked. This (hopefully)
2366 fixes another deadlock when exiting the application while retrieving
2369 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2371 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2372 Fixed build if libogs is not available
2374 2007-06-03 Christian Kellner <ckellner@openismus.com>
2376 * libmodest-dbus-client/libmodest-dbus-client.h:
2377 * libmodest-dbus-client/libmodest-dbus-client.c:
2378 (libmodest_dbus_client_delete_message):
2379 Implement deletion of messages (Client side).
2381 (modest_search_hit_free),
2382 (modest_search_hit_list_free):
2383 Utility functions to free the result hits.
2385 * src/dbus_api/modest-dbus-api.h:
2386 * src/dbus_api/modest-dbus-callbacks.c:
2387 (on_delete_message),
2388 (modest_dbus_req_handler):
2389 Implement deletion of messages (Server side).
2391 * tests/dbus_api/test_search.c: (main):
2394 * tests/dbus_api/Makefile.am:
2395 * tests/dbus_api/test_delete_message:
2396 Add little test for the message deletion logic
2398 2007-06-03 Armin Burgmeier <armin@openismus.com>
2400 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2401 when the operation queue was not empty. projects.maemo.org bug
2404 2007-06-03 Armin Burgmeier <armin@openismus.com>
2406 * src/widgets/modest-account-view.c
2407 (on_account_default_toggled): Toggle default account column
2408 explicitely instead of waiting for gconf notification (which is
2409 currently ignored). This should fix projects.maemo.org bug NB#56910
2410 for now. It should probably be removed when gconf notifications are
2413 2007-06-03 Christian Kellner <ckellner@openismus.com>
2415 * libmodest-dbus-client/libmodest-dbus-client.c:
2416 Removed debugging spew.
2418 * src/dbus_api/modest-dbus-callbacks.c:
2419 Added debugging info.
2421 * src/modest-search.c:
2422 (modest_search_all_accounts):
2423 Use tny_account_store_get_accounts () on the account store
2424 to get all accounts which is the way to get all accounts.
2426 * tests/dbus_api/test_search.c: (main):
2427 Make it possible to supply the search term on the command line.
2429 2007-06-03 Christian Kellner <ckellner@openismus.com>
2431 * libmodest-dbus-client/libmodest-dbus-client.c:
2432 * libmodest-dbus-client/libmodest-dbus-client.h:
2433 Implement searching for mesages over raw dbus. (Client side)
2435 * src/dbus_api/Makefile.am:
2436 * src/dbus_api/modest-dbus-api.h:
2437 * src/dbus_api/modest-dbus-callbacks.c:
2438 * src/dbus_api/modest-dbus-callbacks.h:
2439 Search framework (Server side). Also implement on_idle_open_message().
2441 * src/maemo/modest-platform.c: (modest_platform_init):
2442 Prepare for raw dbus/osso rpc interaction.
2444 * src/modest-search.h:
2445 Changed minsize from unspecific guint to guint32.
2447 * src/modest-search.c:
2449 Added strange hack which magically made tnymail work.
2451 (modest_search_folder),
2452 (modest_search_account),
2453 (modest_search_all_accounts):
2454 Implement helper functions to search all accounts, specific account
2457 * tests/dbus_api/Makefile.am:
2458 * tests/dbus_api/test_open_message.c:
2459 Read url to open from commandline.
2461 * tests/dbus_api/test_search.c:
2462 Implement small test for dbus search stuff
2464 2007-06-02 Armin Burgmeier <armin@openismus.com>
2466 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2467 include account type and account title. This fixes projects.maemo.org
2470 * src/maemo/modest-account-view-window.c: Set a title for the window.
2472 2007-06-02 Armin Burgmeier <armin@openismus.com>
2474 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2475 incoming and outgoing server name based on email address and server
2476 types as long as the names have not been edited manually. This fixes
2477 projects.maemo.org bug NB#58671.
2479 2007-06-02 Armin Burgmeier <armin@openismus.com>
2481 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2482 server type cannot be changed in future to the incoming details page
2483 when creating an account. This fixes projects.maemo.org bug NB#59029.
2485 2007-06-02 Armin Burgmeier <armin@openismus.com>
2487 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2488 and assigned max width chars so that they wrap instead of being
2489 truncated. Fixes projects.maemo.org bug NB#56126.
2491 2007-06-02 Armin Burgmeier <armin@openismus.com>
2493 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2494 introductory note to the connection specific smtp servers dialog, as
2495 section 8.12 of the email UI specification requires. This fixes
2496 projects.maemo.org bug NB#59212.
2498 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2500 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2501 Check for running mail operations, and offer to cancel them, as per the UI
2502 spec. This fixes projects.maemo.org bug NB#59041 .
2503 However, I suspect that tinymail may still use the network connection
2504 in ways that we cannot detect or cancel. But it should at least adapt to
2505 changes fairly well.
2507 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2509 * src/modest-tny-account-store.c: (recreate_all_accounts),
2510 (get_cached_accounts), (get_server_accounts): Do more sensible
2511 ref-counting of the temporarily-cached outbox accounts list. This seems
2512 to fix a crash when entering the password when the password was wrong.
2514 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2516 * src/gnome/modest-main-window.c: (connect_signals):
2517 * src/modest-tny-account-store.c: (get_password),
2518 (modest_tny_account_store_alert): Added comments and clues and
2519 commented-out code about how we currently fail to deal with connection
2520 errors and wrong passwords, and how we should.
2522 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2524 * src/widgets/modest-retrieve-combo-box.c:
2525 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2526 This fixes projects.maemo.org bug NB#58472 .
2528 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2530 * src/maemo/easysetup/modest-easysetup-wizard.c:
2531 (create_page_complete_easysetup):
2532 (create_page_complete_custom): Correct the last commit,
2533 putting the correct sentences in the correct pages.
2535 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2537 * src/maemo/easysetup/modest-easysetup-wizard.c:
2538 (create_page_complete_custom): Show the second sentence of text
2539 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2542 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2545 Set the leave-on-server conf key by default. This fixes
2546 projects.maemo.org bug NB#59258 .
2548 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-account-view-window.c:
2551 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2552 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2555 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2557 * src/maemo/easysetup/modest-easysetup-wizard.c:
2558 (create_caption_new_with_asterisk):
2559 * src/maemo/modest-account-settings-dialog.c:
2560 (create_caption_new_with_asterisk):
2561 Uncomment the code to add the asterisk, because they are no longer in the
2562 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2563 (update_incoming_server_title): Add an asterisk here too.
2565 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2567 * src/maemo/modest-maemo-global-settings-dialog.c:
2568 (current_connection): Check that we are even connected before trying to
2569 get the current connection name, to prevent a warning.
2571 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2572 Change the comments because tny_maemo_conic_device_connect() is now meant to
2574 * src/modest-mail-operation.c:
2575 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2576 make sure we have a connection and fail if we can't connect.
2578 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2580 * src/maemo/modest-main-window.c:
2581 (on_account_store_connecting_finished): Do not try to get the
2582 connection ID if we are not really connected. I am surprised that
2583 this signal handler is called when we are not connected.
2585 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2587 * src/modest-error.h:
2588 * src/modest-ui-actions.c:
2589 (modest_ui_actions_get_msgs_full_error_handler):
2590 Renamed an enum, added comments, added an enum
2591 for retrieve-limit errors.
2593 * src/modest-mail-operation.c: (foreach_add_item),
2594 (internal_folder_observer_update), (update_account_thread),
2595 (modest_mail_operation_get_msgs_full):
2596 (modest_mail_operation_update_account),
2597 Added comments about how this works, and some code that should
2598 (but does not) check the retrieve-limit. See the TODO comment.
2600 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2603 Initialize help_id to fix the build. Warnings are good.
2605 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2607 * src/widgets/modest-hbox-cell-renderer.c:
2608 (modest_hbox_cell_renderer_append):
2609 * src/widgets/modest-vbox-cell-renderer.c:
2610 (modest_vbox_cell_renderer_append):
2611 Fix the last commit by doing an extra ref.
2613 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2615 * src/widgets/modest-hbox-cell-renderer.c:
2616 (modest_hbox_cell_renderer_append):
2617 * src/widgets/modest-vbox-cell-renderer.c:
2618 (modest_vbox_cell_renderer_append):
2619 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2620 to fix the build with Maemo Bora.
2621 However, there seems to be a remaining crash, probably due to reference
2624 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-tny-account.c:
2627 (modest_tny_account_new_for_local_folders):
2628 Use hildon_file_system_info_async_new() to get a better name for
2629 the memory card account, setting it as the account name.
2630 The timing seems to work, but this is probably
2631 not the best place to do this. See the TODO comment.
2632 * src/maemo/modest-main-window.c: (create_details_widget):
2633 * src/widgets/modest-folder-view.c: (text_cell_data):
2634 Use the tny account name instead of hardcoding a name.
2636 2007-05-30 Christian Kellner <ckellner@openismus.com>
2638 * src/modest-search.c: (modest_search):
2639 Correctly set part_search_func even if we have already parsed
2640 the query and thus a valid OgsTextSearcher object.
2642 2007-05-30 Christian Kellner <ckellner@openismus.com>
2645 Search and check for libogs.
2648 Incooparte the ogs build env.
2650 * src/modest-mime-part-search-stream.c:
2651 * src/modest-mime-part-search-stream.h:
2652 Removed since we do the real searching now in modest-search.c.
2654 * src/modest-search.c:
2655 * src/modest-search.h:
2656 Implement support for ogs. We use that if available and requested
2657 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2658 should now handle the corner case when the search term is spread
2659 across multiple reads.
2660 Also the logic in modest_search () was corrected to search all
2661 requested fields until one is found.
2663 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2665 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2667 * src/modest-init.h:
2668 * src/modest-init.c: Made modest_init_local_folders() take a
2669 path and be public so we can iniitialize maildir folders on
2672 * src/modest-local-folder-info.h:
2673 * src/modest-local-folder-info.c:
2674 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2676 * src/modest-tny-account.c:
2677 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2678 still means the standard local-folders path on the local volume.
2680 * src/modest-tny-account-store.c:
2681 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2682 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2683 all accounts when that happens.
2684 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2685 this too, so it shows up in the treeview.
2687 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2689 * src/maemo/modest-maemo-global-settings-dialog.c:
2690 (current_connection):
2691 * src/widgets/modest-global-settings-dialog.c:
2692 (current_connection_default):
2693 Use the enum values instead of 0, 1 and -1,
2694 to make the code clearer.
2696 * src/modest-account-mgr-helpers.c:
2697 (modest_account_mgr_get_connection_specific_smtp): Make this code
2700 * src/modest-runtime.h:
2701 * src/modest-runtime.c:
2702 Added modest_runtime_remove_all_send_queues().
2703 * src/maemo/modest-main-window.c:
2704 (on_account_store_connecting_finished): Recreate the send queues,
2705 using the appropriate transport accounts for this new connection.
2706 Some futher adapting might be needed if the old send queues are not
2707 automatically stopped at this point.
2709 * src/modest-tny-account-store.c: (get_server_accounts):
2710 Create the connection-specific transport accounts, so that they can
2711 be found later by their ID.
2713 * src/modest-tny-account.h:
2714 * src/modest-tny-account.c:
2715 Added modest_tny_account_new_from_server_account_name().
2716 modest_tny_account_new_from_server_account(): Do not create the
2717 send queues here, because they will be
2718 recreated anyway when the connection changes for the first time.
2720 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2722 * src/modest-local-folder-info.h:
2723 * src/modest-local-folder-info.c:
2724 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2725 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2726 tbox_folder): Take a modest account name instead of a server TnyAccount,
2727 so we can have per-modest-account rather than per-transport-account
2729 We must make sure that we change or recreate the exisitng send queues
2730 when the connection changes for connection-specific transport accounts.
2732 * src/modest-tny-account-store.c:
2733 (create_per_account_local_outbox_folders): Create outboxed per modest
2734 account, not per transport account.
2736 * src/modest-tny-account.h:
2737 * src/modest-tny-account.c:
2738 (modest_tny_account_get_special_folder): For outboxes, get the
2739 parent modest account name. The account is ignored for other folders.
2740 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2741 modest account name rather than a server TnyAccount.
2743 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2745 * src/modest-tny-account.c:
2746 (modest_tny_account_new_from_server_account):
2747 Call modest_runtime_get_send_queue() immediately after creating transport
2748 accounts, so that they start trying to send email from the outbox as soon
2749 as possible at startup. This is probably what we want.
2751 * src/modest-mail-operation.c: (update_account_thread):
2752 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2753 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2754 * src/modest-tny-send-queue.h:
2755 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2756 (modest_ui_actions_on_send):
2757 Added comments about how sending works, though it needs some more work.
2759 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2761 * src/modest-tny-account.c:
2762 (modest_tny_account_get_special_folder): Add TODO because this fails when
2763 the network is busy.
2764 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2765 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2766 Do not try to show this window when there is no active account. The UI
2767 specs does not tell us what to do in this case.
2769 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/Makefile.am:
2774 * src/widgets/Makefile.am: Some dist fixes.
2776 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2778 * src/maemo/modest-connection-specific-smtp-window.c:
2779 (on_button_edit): Make the code clearer, to prevent a double free.
2781 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2783 * src/maemo/modest-account-settings-dialog.c:
2784 (modest_account_settings_dialog_set_account_name),
2785 Check the connection-specific smtp servers checkbox if there are any.
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 (modest_connection_specific_smtp_edit_window_init):
2789 Start with a suitable port number.
2791 * src/modest-account-mgr-helpers.h:
2792 * src/modest-account-mgr-helpers.c: Added
2793 modest_account_mgr_get_has_connection_specific_smtp().
2795 (modest_account_mgr_set_connection_specific_smtp),
2796 (modest_account_mgr_remove_connection_specific_smtp),
2797 (modest_account_mgr_get_has_connection_specific_smtp),
2798 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2799 connection-specific smtp server accounts in the account, rather than
2800 the server account conf dir.
2802 This fixes bug projects.maemo.org bug NB#58263 .
2804 * src/modest-tny-account-store.c:
2805 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2806 if there are no server accounts yet, to prevent an infinite loop when there
2807 are no accounts. Document that one must be called before the other.
2809 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2811 * src/modest-account-mgr-helpers.c:
2812 (modest_account_mgr_get_default_account): Make sure that at least
2813 one account is always the default, if there are any enabled accounts.
2814 This is just a sanity check that shouldn't be necessary.
2816 * src/modest-account-mgr-priv.c:
2817 (_modest_account_mgr_account_from_key): Unescape the conf key to
2818 get the real account name. For instance, this is an issue if a space
2819 was in the account name, which can happen because the account name
2820 is generated from the display name.
2821 (_modest_account_mgr_get_account_keyname): Always escape the
2823 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2824 Unescape the conf keys to get the real account names.
2826 For instance, previously the is-default radio button in the accounts
2827 list was not checked for any accounts at first. This fixes that,
2828 and might fix several similar bugs.
2830 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2832 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2833 Removed some debug printfs.
2835 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2837 Modest on-disk outbox directories are now here, for instance:
2838 $HOME/.modest/outboxes/<account-id-1>/outbox
2839 $HOME/.modest/outboxes/<account-id-2>/outbox
2841 $HOME/.modest/local-folders/outbox
2842 so we can have a separate outbox for each account.
2843 But they are shown as one outbox in the GtkTreeView, by using a
2844 TnyMergeFolder in a ModestTnySimpleFolderStore.
2847 * src/modest-tny-simple-folder-store.c:
2848 * src/modest-tny-simple-folder-store.h:
2849 Added ModestTnySimpleFolderStore, used to contain folders from
2850 other folder stores, such as other accounts.
2852 * src/modest-tny-outbox-account.h:
2853 * src/modest-tny-outbox-account.c:
2854 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2855 used for the per-account local outbox folders.
2857 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2858 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2859 only use this (internally) now for the non-outbox local folders.
2861 * src/modest-init.h:
2862 * src/modest-init.c: Added modest_init_one_local_folder(), for
2863 setting up the directory structure for each local folder.
2865 * src/modest-local-folder-info.c:
2866 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2867 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2869 * src/modest-local-folder-info.h:
2870 * src/modest-tny-account-store.c: (on_account_removed),
2871 (on_account_changed), (create_per_account_local_outbox_folders),
2872 (get_server_accounts), (modest_tny_account_store_get_accounts),
2873 (modest_tny_account_store_get_tny_account_by_account),
2874 (modest_tny_folder_store_is_virtual_local_folders):
2876 * src/modest-tny-account.h:
2877 * src/modest-tny-account.c:
2878 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2879 to create an on-disk per-account local outbox folder for each
2881 (create_per_account_local_outbox_folders): Create a local outbox folder
2882 for each transport account.
2883 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2884 for all local folders.
2886 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2887 instead of using g_object_get/set() directly. It is clearer.
2889 (modest_tny_folder_store_get_message_count),
2890 (modest_tny_folder_store_get_local_size
2891 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2892 because we now use these with non-acount folder stores.
2894 (modest_tny_account_get_special_folder),
2895 (modest_tny_account_new_from_server_account),
2896 (modest_tny_account_new_from_account):
2897 (recurse_folders): Adjust to the new outbox system.
2899 * src/modest-tny-folder.h:
2900 * src/modest-tny-folder.c:
2901 (modest_tny_folder_is_local_folder),
2902 (modest_tny_folder_get_local_folder_type),
2903 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2905 * src/widgets/modest-main-window.h:
2906 * src/maemo/modest-main-window.c: (create_details_widget),
2907 (modest_main_window_set_contents_style): Show details for any folder store,
2910 (modest_tny_folder_get_rules):
2911 Remove the const. C does not support constness enough for this.
2913 * src/modest-ui-actions.c:
2914 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2915 make all outboxes appear as one, in the usual local-folders tree node.
2917 (set_active_account_from_tny_account),
2918 (modest_ui_actions_on_folder_selection_changed):
2919 * src/widgets/modest-folder-view.c: (text_cell_data),
2920 (icon_cell_data), (filter_row),
2921 (add_account_folders_to_merged_folder),
2922 (add_account_folders_to_simple_folder_store), (),
2923 (get_cmp_rows_type_pos), (cmp_rows),
2924 (modest_folder_view_set_account_id_of_visible_server_account):
2925 Adjust to the new outbox system, using generic folder stores and folders
2926 in the GtkTreeModel.
2928 2007-05-23 Christian Kellner <ckellner@openismus.com>
2930 * src/modest-mail-operation.c:
2931 (modest_mail_operation_update_account):
2932 Use info->max_size instead of unintialized local var [small
2933 build fix]. (Added TODO to review that change since I don't
2936 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2938 * libmodest-dbus-client/libmodest-dbus-client.c:
2939 (libmodest_dbus_client_compose_mail): function added
2940 * src/dbus_api/modest-dbus-api.h:
2941 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2942 (on_compose_mail): Implementation of the SendAsMail functionality
2944 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2946 * src/modest-account-mgr.c:
2947 (modest_account_mgr_add_server_account): Set the secure-connection
2948 conf key for transport accounts as well as store accounts. I don't know
2949 why the if was there. For instance, this makes sure that we use SSL
2950 for the gmail preset from the easysetup wizard.
2952 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2954 * src/gnome/modest-main-window.c:
2955 (on_account_store_connecting_finished), (connect_signals):
2956 * src/maemo/modest-main-window.c:
2957 (on_account_store_connecting_finished), (connect_signals),
2958 (modest_main_window_new):
2959 Handle TnyAccountStore::connecting-finished instead of
2960 TnyDevice::connection-changed, because we cannot actually perform
2961 operations on accounts until TnyAccountStore has itself responded to
2962 the TnyDevice::connection-changed signal. This prevents a GError from
2964 Do not try to update at startup, because we (at least on scratchbox)
2965 already do an update at startup when the device goes online.
2966 This prevents a GError from tinymail.
2967 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2968 Added TODO about stopping simultaneous operations.
2970 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2972 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2973 * src/modest-mail-operation-queue.c:
2974 (modest_mail_operation_queue_remove):
2975 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2976 about where they happened.
2978 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2980 * src/modest-ui-actions.c:
2981 (modest_ui_actions_on_password_requested): Make sure that the remember
2982 output parameter is always TRUE.
2984 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2986 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2987 Show a OK/Cancel dialog if the error is a question, though we still do not
2988 know anything more about what we are asking the user.
2989 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2990 Fix an uninitialized variable (helper). This is a logic error, however.
2992 2007-05-21 Christian Kellner <ckellner@openismus.com>
2994 * src/modest-search.h:
2995 Correct bit shifting in the ModestSearchFlags enum.
2997 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2999 * src/modest-tny-account.c:
3000 (modest_tny_account_new_from_server_account): Do not use the lsub and
3001 check-all hard-coded IMAP options when using POP.
3003 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3005 * src/modest-tny-account.c:
3006 (modest_tny_account_new_from_server_account):
3007 Use NULL for the secure-auth method for POP when Password auth has been
3008 specified by the user, as we already do for IMAP. "auth=Login" causes
3009 an error from camel or the server.
3011 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3013 * src/maemo/modest-account-settings-dialog.c:
3014 (create_page_account_details),
3015 (modest_account_settings_dialog_set_account_name):
3016 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3017 for the leave-on-server checkbox, rathr than just the checkbox, when
3018 the protocol is not POP.
3020 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3022 * src/widgets/modest-account-view.c:
3023 * src/widgets/modest-account-view.h:
3024 Added modest_account_view_select_account() which will be useful later
3025 to asynchronously re-select the edited account.
3027 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3029 * src/maemo/modest-account-settings-dialog.c:
3030 (modest_account_settings_dialog_set_account_name):
3031 Automatically choose the port numbers based on the secure authentication
3032 methods, if they have not been chosen before.
3033 This fixes projects.maemo.org bug NB#56273 .
3035 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3037 * src/maemo/modest-main-window-ui.h:
3038 * src/modest-ui-actions.c:
3039 * src/modest-ui-actions.h:
3040 Connect the Tools/SMTP Servers menu item to
3041 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3042 SMTP servers dialog, as in the UI specification and saves changes when it
3043 is closed. This fixed projects.maemo.org bug NB#56305 .
3045 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3047 * src/maemo/modest-connection-specific-smtp-window.c:
3048 (modest_connection_specific_smtp_window_init):
3049 Use gtk_window_set_default_size() to make this window big enough, so
3050 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3052 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3054 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3055 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3056 (modest_connection_specific_smtp_edit_window_init),
3057 Do not try to connect to a combobox signal before the combobox exists.
3058 This fixes the cras in projects.maemo.org bug NB#56288 .
3059 (modest_connection_specific_smtp_edit_window_get_settings):
3060 Remove the server_account_name parameter which was being checked for NULL
3061 though it was not used.
3063 * src/maemo/modest-connection-specific-smtp-window.c:
3064 (modest_connection_specific_smtp_window_fill_with_connections),
3065 (on_button_edit), (modest_connection_specific_smtp_window_init):
3066 Correct the number of treemodel columns to prevent a warning.
3067 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3068 libconic does not work.
3070 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3072 * src/modest-tny-account.c:
3073 (modest_tny_account_new_from_server_account):
3074 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3075 SMTP when "None" was chosen by the user. However, with my SMTP server that
3076 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3079 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3082 to explain the memory management issue with the ID in the ModestPair.
3084 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3085 (add_sending_page), (modest_account_assistant_finalize):
3086 * src/gnome/modest-gnome-global-settings-dialog.c:
3087 (create_updating_page), (create_composing_page):
3088 * src/gnome/modest-msg-edit-window.c: (get_transports),
3089 (init_window), (modest_msg_edit_window_finalize),
3090 (modest_msg_edit_window_get_msg_data):
3091 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3092 * src/gnome/modest-transport-widget.c:
3093 (modest_transport_widget_finalize), (smtp_configuration):
3094 * src/maemo/modest-maemo-global-settings-dialog.c:
3095 (create_updating_page), (create_composing_page):
3096 * src/maemo/modest-msg-edit-window.c: (get_transports),
3097 (init_window), (modest_msg_edit_window_finalize),
3098 (modest_msg_edit_window_get_msg_data),
3099 (modest_msg_edit_window_free_msg_data):
3100 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3101 (modest_store_widget_finalize):
3102 * src/maemo/modest-transport-widget.c:
3103 (modest_transport_widget_finalize), (smtp_configuration):
3104 * src/modest-main.c: (send_mail):
3105 * src/widgets/modest-combo-box.h:
3106 * src/widgets/modest-global-settings-dialog-priv.h:
3107 * src/widgets/modest-global-settings-dialog.c:
3108 (modest_global_settings_dialog_finalize):
3109 * src/widgets/modest-msg-edit-window.h:
3110 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3111 as long as the combo box, to prevent use of freed memory for the ID.
3113 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3115 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3116 get_accounts(), to make this clearer. Do not check for the enabled gconf
3117 key, because we do not use this for server accounts (at least, not yet).
3118 This allows us to send email again.
3120 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/modest-platform.c:
3123 (on_modest_conf_update_interval_changed), (modest_platform_init):
3124 Only respond to this particular key change. All these strcmp()s cannot be
3127 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3129 * src/maemo/modest-maemo-global-settings-dialog.c:
3130 (current_connection): Prevent a crash in scratchbox when
3131 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3132 * src/maemo/modest-platform.c:
3133 (on_modest_conf_update_interval_changed), (modest_platform_init):
3134 Get the update interval from gconf and reset it when the gconf key changes.
3136 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3138 * src/modest-protocol-info.c:
3139 * src/modest-protocol-info.h: Adde enum-specific get functions,
3140 instead of using a ModestProtocolType enum parameter.
3142 * src/gnome/modest-account-assistant.c:
3143 * src/gnome/modest-store-widget.c:
3144 * src/gnome/modest-store-widget.h:
3145 * src/gnome/modest-transport-widget.c:
3146 * src/gnome/modest-transport-widget.h:
3147 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3148 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3149 * src/maemo/easysetup/modest-easysetup-wizard.c:
3150 * src/maemo/modest-account-settings-dialog.c:
3151 * src/maemo/modest-account-settings-dialog.h:
3152 * src/maemo/modest-store-widget.c:
3153 * src/maemo/modest-store-widget.h:
3154 * src/maemo/modest-transport-widget.c:
3155 * src/maemo/modest-transport-widget.h:
3156 * src/modest-account-mgr-helpers.c:
3157 * src/modest-account-mgr-helpers.h:
3158 * src/modest-account-mgr.c:
3159 * src/modest-account-mgr.h:
3160 * src/modest-tny-account.c:
3161 * src/modest-tny-folder.c:
3162 * src/widgets/modest-account-view.c:
3163 * src/widgets/modest-retrieve-combo-box.c:
3164 * src/widgets/modest-retrieve-combo-box.h:
3165 * src/widgets/modest-secureauth-combo-box.c:
3166 * src/widgets/modest-serversecurity-combo-box.c:
3167 * src/widgets/modest-serversecurity-combo-box.h:
3168 * tests/check_account-mgr.c:
3169 Use the specific functions, and use the re-renamed enum values for GNOME too.
3171 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3173 * src/modest-pair.h:
3174 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3175 so we can get the second based on the first.
3177 * src/maemo/modest-account-settings-dialog.h:
3178 * src/maemo/modest-account-settings-dialog.c:
3179 Added get_supported_secure_authentication_methods(), though it is mostly
3180 commented-out for now until the necessary API is committed to tinymail.
3181 (modest_account_settings_dialog_set_account_name),
3182 (save_configuration): Request the supported authentication methods from the
3183 server, so we can choose a working method.
3185 * src/modest-tny-account-store.h:
3186 * src/modest-tny-account-store.c:
3187 (modest_tny_account_store_get_session): Rename from
3188 tny_account_store_get_session().
3190 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3192 * src/modest-protocol-info.h: Split the ModestProtocol enum
3193 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3194 There was no need to have these unrelated values in one enum.
3196 * src/: many files: Adapted to changed enum. This makes the code a bit
3197 clearer, and the compiler could catch some errors.
3199 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3202 Show the detailed internal camel error message when an error happens
3203 during the configuration, so that our testers can give us more clues.
3204 For instance, in projects.maemo.org bug NB#56910 .
3206 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-tny-account.c:
3209 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3210 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3212 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3214 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3215 * src/maemo/modest-account-settings-dialog.c:
3216 (modest_account_settings_dialog_set_account_name),
3217 (save_configuration): For the incoming secure authentication checkbox,
3218 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3219 the UI specification. PLAIN does not seem to be supported for most IMAP
3220 servers anyway, and I am not sure what it would mean.
3221 However, we probably need to discover which of the secure-authentication
3222 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3223 * src/modest-account-mgr-helpers.c:
3224 (modest_account_mgr_get_server_account_data):
3226 * src/modest-tny-account.c:
3227 (modest_tny_account_new_from_server_account):
3228 Use tny_account_set_mech() to set secure-authentication methods,
3229 with some special-casing for IMAP, based on my observations of how
3232 * src/modest-account-mgr-helpers.h:
3233 * src/modest-account-mgr.c:
3234 * src/modest-defs.h: Comment that the URI is only used for local folders.
3236 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3238 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3239 parameter const, just to be neat.
3240 * src/modest-text-utils.c: (modest_text_utils_inline):
3241 End g_strconcat() with NULL, as its documentation says. This is almost
3242 certainly the cause of my crash at startup on the device. Interestingly,
3243 valgrind doesn't tell us about these errors.
3245 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3247 * scripts/build-packages: Added more precise comments about how to use
3248 this script, though I still get this error:
3249 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3250 error building tinymail
3252 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3254 * src/maemo/modest-main-window.c: (on_account_update):
3255 Very slight cleanup, hoping to make it simpler to discover what causes
3256 a crash here sometimes.
3258 * src/modest-tny-account.c:
3259 (modest_tny_account_new_from_server_account): Set the port. Added
3260 comments about the options and a TODO comment because I need to find out
3261 how to specify the secure authentication method.
3263 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3265 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3266 changed CFlags paths form modest to libmodest
3268 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3270 * src/modest-account-mgr-helpers.c:
3271 (modest_account_mgr_get_server_account_data),
3272 (modest_account_mgr_free_server_account_data):
3273 * src/modest-account-mgr-helpers.h:
3274 * src/modest-account-mgr.c:
3275 (modest_account_mgr_add_server_account):
3276 * src/modest-defs.h:
3277 * src/modest-tny-account.c:
3278 (modest_tny_account_new_from_server_account):
3279 Determine the options for tny_camel_account_add_option() here,
3280 based on the settings, rather than storing them directly in gconf.
3282 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3284 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3285 Show a more friendly error dialog now that we expect (from the tinymail
3286 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3288 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3290 * src/maemo/modest-main-window.c: (on_account_update): Check that
3291 account_name is not NULL, to prevent a crash at startup that I am
3292 seeing on the N800. I do wonder why it is NULL.
3294 * src/maemo/easysetup/modest-easysetup-wizard.c:
3295 (create_page_user_details):
3296 * src/maemo/modest-account-settings-dialog.c:
3297 (create_page_user_details), (create_page_outgoing):
3298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3299 (modest_connection_specific_smtp_edit_window_init):
3300 * src/modest-ui-actions.c:
3301 (modest_ui_actions_on_password_requested):
3302 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3303 might do something useful with the on-screen keyboard.
3305 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/modest-main-window.c: (on_account_update):
3308 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3309 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3311 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3313 * src/modest-tny-account-store.c: (on_account_changed):
3314 Correct the signature of this signal handler.
3316 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3318 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3319 Show a HildonNote instead of a GtkDialog for Maemo.
3321 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3323 * src/widgets/modest-account-view.h:
3324 * src/widgets/modest-account-view.c: (on_account_changed),
3325 (on_account_removed). Added a boolean flag, set/unset by
3326 modest_account_view_block_conf_updates(),
3327 modest_account_view_unblock_conf_updates() to prevent unnecessary
3328 updates, but this is not very useful because the gconf notifications are
3329 so delays (maybe only on Maemo Bora).
3330 So auto-updating is turned off, and these functions do an explicit
3331 update when necessary.
3332 However, something else is still doing too much work when adding/removing
3333 accounts, probably in another part of the application.
3335 * src/maemo/modest-account-view-window.c:
3336 (on_delete_button_clicked), (on_edit_button_clicked),
3337 (on_new_button_clicked): Use the new functions.
3339 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3341 * src/modest-account-mgr-helpers.c:
3342 (modest_account_mgr_set_first_account_as_default):
3343 Sort the list of names alphabetically-by-title, so we choose the first one
3345 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3346 alphabetically by the title.
3348 This fixes projects.maemo.org bug NB#56418 .
3350 * src/modest-account-mgr-priv.c:
3351 (_modest_account_mgr_account_from_key):
3352 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3353 avoid a valgrind error, and possible random behaviour.
3355 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3357 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3358 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3359 tinymail documentation to say that this can be expected.
3360 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3361 pretty, and should not happen, but I would prefer to know when it does.
3363 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3365 * configure.ac: When using the older hildon version, probably on Bora,
3366 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3368 * src/widgets/modest-attachment-view.c:
3369 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3372 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3374 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3375 Implemented the prototype. Can be tested with
3376 tests/dbus_api/test_open_message:
3378 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3380 * src/modest-tny-account-store.c:
3381 (modest_tny_account_store_instance_init), (get_password):
3382 * src/modest-ui-actions.c:
3383 (modest_ui_actions_on_password_requested):
3384 Do not store the password in gconf, because this function is called
3385 for non-remembered passwords. Actually use the cached (in the hash map)
3386 password instead of releasing it.
3387 The password will now not be remembered if it is asked via the protected
3388 password dialog, as per the UI spec.
3390 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-defs.h:
3393 * src/modest-account-mgr-helpers.h:
3394 * src/modest-account-mgr-helpers.c:
3395 Added modest_server_account_get_username_has_succeeded(),
3396 modest_server_account_set_username_has_succeeded().
3397 (modest_server_account_set_username),
3398 Reset the has-succeeded flag if the username changes.
3400 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3401 * src/maemo/modest-connection-specific-smtp-window.c:
3402 (modest_connection_specific_smtp_window_save_server_accounts):
3403 Use modest_server_account_set_username() instead of using
3404 modest_conf_set_string() directly, so that the has-succeeded flag is always
3407 * src/modest-ui-actions.c:
3408 (modest_ui_actions_on_password_requested): Dim the username entry if
3409 the username has ever worked, as per the UI spec.
3411 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3413 * src/modest-tny-account-store.c: (get_password):
3414 * src/modest-ui-actions.c:
3415 (modest_ui_actions_on_password_requested):
3416 Allow the username to be changed too, though there is more work to
3417 be done on exactly how this behaves.
3419 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3421 * src/modest-account-mgr-helpers.h:
3422 * src/modest-account-mgr-helpers.c:
3423 Added modest_account_mgr_get_display_name(),
3424 modest_server_account_get_username(),
3425 modest_server_account_set_username(),
3426 modest_server_account_set_password(),
3427 modest_server_account_get_hostname() functions so we do not need to
3428 use the conf API directly.
3430 * src/maemo/modest-main-window.c: (connect_signals):
3431 Actually connect ot the ModestAccountStore::request-password signal,
3432 so that we show the dialog when the password is requested by Tinymail,
3433 for isntance if it is empty.
3435 * src/modest-marshal.list:
3436 * src/modest-tny-account-store.c:
3437 (modest_tny_account_store_class_init), (get_password),
3438 (modest_tny_account_store_alert):
3439 * src/modest-tny-account-store.h:
3440 * src/modest-ui-actions.h:
3441 * src/modest-ui-actions.c:
3442 (modest_ui_actions_on_password_requested):
3443 Change the signal parameters, so it is obvious that we are providing
3444 the non human-readable server name, and receiving both the username
3445 and password, though changing of the username is not yet implemented.
3446 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3447 for the GNOME version.
3449 This should fix the projects.maemo.org bug NB#56209, though it does not
3450 work on Bora, because the gconf_client_get() for the password fails
3451 immediately after we save it with gconf_client_set().
3453 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3456 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3457 caused an undefined symbol error:
3458 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3460 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3462 * src/modest-tny-account-store.c:
3463 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3464 using a GError instead of a string message, so we can translate it in
3467 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3469 * src/maemo/modest-address-book.c:
3470 (modest_address_book_check_names):
3471 * src/maemo/modest-msg-view-window.c:
3472 (modest_msg_view_window_clipboard_owner_change):
3473 * src/modest-init.c: (modest_init_init_ui):
3474 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3475 (update_folders_cb), (modest_mail_operation_update_account):
3476 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3477 (modest_ui_actions_on_msg_attachment_clicked),
3478 (modest_ui_actions_on_msg_recpt_activated):
3479 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3480 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3481 (modest_msg_view_search_next):
3482 * src/widgets/modest-recpt-editor.c:
3483 (modest_recpt_editor_on_button_release_event),
3484 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3485 g_message(). At this point we should only be seeing interesting errors on
3486 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3488 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3490 (modest_wizard_dialog_force_title_update):
3491 * src/maemo/easysetup/modest-wizard-dialog.h:
3492 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3493 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3494 can update the title when appropriate. Otherwise the title is wrong if the
3495 pages are added after adding the notebook to the dialog.
3496 This must be a problem in HildonWizardDialog too.
3497 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3499 * src/maemo/easysetup/modest-easysetup-wizard.c:
3500 (create_subsequent_customsetup_pages),
3501 (create_subsequent_easysetup_pages):
3502 Call modest_wizard_dialog_force_title_update() so that the title is
3503 correct even with GTK+ < 2.10.
3504 This fixes projects.maemo.org bug NB#56145 .
3506 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3508 * src/maemo/modest-platform.c:
3509 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3510 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3513 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3515 * src/widgets/modest-window.h:
3516 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3517 and modest_window_save_state(), which invokes it.
3519 * src/widgets/modest-window-mgr.h:
3520 * src/widgets/modest-window-mgr.c:
3521 Added modest_window_mgr_save_state_for_all_windows(), which calls
3522 the save_state vfunc on all registered windows, if implemented.
3524 * src/gnome/modest-msg-edit-window.c:
3525 * src/gnome/modest-msg-view-window.c:
3526 * src/maemo/modest-msg-edit-window.c:
3527 * src/maemo/modest-msg-view-window.c:
3528 * src/maemo/modest-main-window.c:
3529 Specify the existing save_settings functions as implementations of
3530 ModestWindow::save_state_func().
3532 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3533 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3534 enabling hibernation, for instance.
3536 We may need to do the same thing for restoring settings.
3539 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3541 * src/widgets/modest-window-mgr.c:
3542 * src/widgets/modest-window-mgr.h:
3543 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3544 modest_window_mgr_get_hibernation_is_prevented().
3546 * src/maemo/modest-main-window.c:
3547 (on_hildon_program_is_topmost_notify): Prevent hibernation
3548 (possible when the application goes to the background in the WM),
3549 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3551 * src/maemo/easysetup/modest-easysetup-wizard.c:
3552 (modest_easysetup_wizard_dialog_init):
3553 * src/maemo/modest-account-settings-dialog.c:
3554 (modest_account_settings_dialog_init):
3555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3556 (modest_connection_specific_smtp_edit_window_init):
3557 * src/maemo/modest-connection-specific-smtp-window.c:
3558 (modest_connection_specific_smtp_window_init):
3559 * src/maemo/modest-signature-editor-dialog.c:
3560 (modest_signature_editor_dialog_init):
3561 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3562 prevent hibernation while any of these account settings dialogs are open.
3564 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3566 * src/maemo/Makefile.am:
3567 * src/maemo/modest-osso-state-saving.c:
3568 * src/maemo/modest-osso-state-saving.h: Added
3569 modest_osso_load_state() and modest_osso_save_state() though they do
3570 nothing now. They should iterate through all the open windows and load/save
3572 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3573 save state when closing.
3575 * src/maemo/modest-main-window.c:
3576 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3577 Add a notification handler for the HildonProgram::is-topmost property,
3578 so we can allow hibernation when the application goes into the background.
3579 But we still need to detect when the accounts setup windows are open so
3580 we can stop hibernation when they are open.
3581 To do this, I also added the main window the HildonProgram. This might have
3582 other side-effects/benefits, and should maybe be done for other windows.
3584 * src/maemo/modest-osso-autosave-callbacks.h:
3585 * src/maemo/modest-osso-autosave-callbacks.c:
3586 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3587 though it does not do anything yet, and we might never need this to do
3588 anything. For instance, we already save drafts.
3590 * src/maemo/modest-platform.c: (modest_platform_init):
3591 Specify the libosso auto-save callback.
3593 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3595 * src/maemo/modest-platform.c:
3596 (modest_platform_set_update_interval):
3597 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3598 aparently stays valid between application instances, so we can use this
3599 to remove and reset it later. According to a maemo-developers email from
3602 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3604 * configure.ac: Depend on libalarm for Maemo.
3606 * src/dbus_api/modest-dbus-api.h:
3607 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3608 (on_send_receive), (modest_dbus_req_handler):
3609 Handle a SEND_RECEIVE D-Bus method.
3611 * libmodest-dbus-client/libmodest-dbus-client.c:
3612 (libmodest_dbus_client_send_and_receive):
3613 * libmodest-dbus-client/libmodest-dbus-client.h:
3614 Add C convenience functions for calling the new D-Bus method.
3616 * src/modest-platform.h:
3617 * src/gnome/modest-platform.c:
3618 * src/maemo/modest-platform.c:
3619 Added modest_platform_set_update_interval(), which uses the
3620 alarmd API on Maemo.
3621 (modest_platform_init),
3622 Call modest_platform_set_update_interval(), using a hard-coded
3623 interval for now (until the global settings dialog is implemented),
3624 though I am not sure that this makes sense yet.
3626 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3628 * src/dbus_api/modest-dbus-callbacks.c:
3629 (modest_osso_cb_hw_state_handler):
3630 * src/dbus_api/modest-dbus-callbacks.h:
3631 * src/maemo/modest-platform.c: (modest_platform_init):
3632 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3633 in case this has some effect on the ability for Maemo to ping the
3636 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3638 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3639 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3640 warning. It is probably a logic error, but I need to fix the build.
3642 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3644 * src/modest-account-mgr.h:
3645 * src/modest-account-mgr.c:
3646 (modest_account_mgr_account_names): Add a gboolean enabled_only
3647 parameter, so we can get lists of onlt the enabled accounts.
3649 (modest_account_mgr_add_account),,
3650 (modest_account_mgr_account_with_display_name_exists):
3651 * src/maemo/modest-msg-edit-window.c: (get_transports):
3652 * src/modest-account-mgr-helpers.c:
3653 (modest_account_mgr_set_first_account_as_default):
3654 * src/modest-init.c: (init_default_account_maybe):
3655 * src/modest-tny-account-store.c: (get_accounts):
3656 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3657 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3658 * tests/check_account-mgr.c: (START_TEST):
3659 Provide the extra parameter, as appropriate.
3661 * src/widgets/modest-account-view.c: (update_account_view):
3662 Do not show disabled accounts (meaning that there is no way to
3663 enable/disable accounts in the UI (the feature is not in our UI
3664 specification), so we can use this internally only to mark unfinished
3665 or temporary account data.
3667 * src/maemo/easysetup/modest-easysetup-wizard.c:
3668 (create_account): Add boolean enable parameter, so we can specify FALSE
3669 to create the temporary account.
3670 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3671 (on_before_next): When finishing, when there is a temporary account, just
3673 Also, use a timeout to delay the showing of the dialog until gconf is likely
3674 to return correct information, due to a maemo gconf bug that is fixed in
3675 osso 1.1, but not yet in Bora.
3676 However, the dialog stays on screen after it is destroyed.
3678 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3679 for invalid data when cancelling. Use a hildon note instead of a dialog
3680 to complain about invalid data. Do not show the account-saved note if the
3681 account is disabled (a temporary account that will not really be saved for use
3684 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3686 * src/modest-account-mgr-helpers.h:
3687 * src/modest-account-mgr-helpers.c:
3688 Added modest_account_mgr_unset_default_account(),
3689 Added modest_account_mgr_set_first_account_as_default().
3691 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3692 If it was the default account, unset the default account name.
3694 * src/maemo/modest-account-view-window.c:
3695 (on_delete_button_clicked): If it was the default account,
3696 set the first remaining account as the default instead.
3698 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3699 a NULL account or a NULL default account, to prevent a crash. This should
3700 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3703 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3705 * src/widgets/modest-recpt-editor.c:
3706 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3707 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3708 TODO comment for this. This fixes the build.
3710 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3711 be the best place for it. This will in future update all auto-update accounts,
3712 rather than just the current/default account, when that gconf key exists.
3713 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3714 if there are no accounts, before calling do_send_receive().
3715 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3717 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3718 * src/maemo/modest-main-window-ui.h:
3719 * src/maemo/modest-main-window.c: (on_connection_changed),
3720 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3721 directly, becaue the signal handler does more.
3723 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3725 * src/modest-account-mgr-helpers.c:
3726 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3727 for the case that the account does not exist.
3729 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3730 (equivalent to the modest account name) rather than the tinymail account name
3731 (equivalent to the modest account title - human readable) to get the account data.
3732 Check for null account data to prevent the crash, and add a TODO comment saying that
3733 this needs fixing because it is using the server account name instead of the account name.
3735 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3737 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3738 * src/maemo/modest-account-settings-dialog.c: (show_error),
3740 Use hildon_note_new_information() for informative and error messages,
3741 which seems to be expected for Maemo applications (no documentation that I know of
3742 says this). I am surprised that there is no distinction between info and error
3745 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3747 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3748 it is easy to find where this is used.
3750 * src/maemo/easysetup/modest-easysetup-wizard.c:
3751 (create_page_welcome), (create_page_account_details),
3752 (create_page_user_details), (create_page_complete_easysetup),
3753 (create_page_custom_incoming), (create_page_custom_outgoing),
3754 (create_page_complete_custom):
3755 * src/maemo/modest-account-settings-dialog.c:
3756 (create_page_account_details), (create_page_user_details),
3757 (create_page_incoming), (create_page_outgoing):
3758 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3759 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3760 (modest_connection_specific_smtp_edit_window_init):
3761 * src/maemo/modest-connection-specific-smtp-window.c:
3762 (modest_connection_specific_smtp_window_init):
3763 * src/maemo/modest-signature-editor-dialog.c:
3764 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3765 and scrolling policy as per the Email Application Layout Guide, if I have
3768 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3770 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3771 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3772 which were empty, because these vfuncs have been removed from TnyAccountStore.
3773 This fixes the build.
3775 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3777 * src/maemo/modest-main-window.c:
3778 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3779 showing/hiding it. Added TODO because it probably should not be NULL.
3780 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3781 because unnecessary g_warnings() make degugging difficult.
3783 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3785 * src/maemo/modest-msg-edit-window.c:
3786 (modest_msg_edit_window_select_color),
3787 (modest_msg_edit_window_select_background_color): 2 const corrections and
3788 moving 2 #endifs before closing brackets, to fix the build.
3790 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3792 * src/maemo/easysetup/modest-easysetup-wizard.h:
3793 * src/maemo/easysetup/modest-easysetup-wizard.c:
3794 (modest_easysetup_wizard_dialog_finalize),
3795 (on_button_edit_advanced_settings), (create_page_complete_custom),
3796 (on_response), (create_account):
3797 Implement the Advanced Settings edit button, by saving the account information,
3798 for the Advanded Settings dialog to use directly from gconf, and removing it
3799 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3800 Bug #5533 in the projects.maemo.org bugzilla.
3802 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3804 * src/maemo/modest-msg-view-window.c:
3805 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3806 when opening a message window.
3808 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3810 * src/maemo/easysetup/modest-easysetup-wizard.c:
3811 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3814 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3815 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3816 gconf settings. I probably added more checks than necessary, but that is safer.
3818 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3819 variable to fix the build, but this seems to be used when it is still NULL.
3821 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3823 * src/modest-platform.h:
3824 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3825 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3826 * src/modest-main.c: Implement this function so we can avoid using
3827 maemo-specific API from cross-platform code.
3829 * src/modest-tny-account-store.c:
3830 (get_smtp_specific_transport_account_for_open_connection):
3831 * src/modest-ui-actions.c: (check_for_connection),
3832 (modest_ui_actions_on_item_not_found):
3833 Use modest_platform_connect_and_wait() and put #idefs around other
3834 maemo-specific code, because only maemo currently has a way to
3835 identify connection names.
3837 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3839 * src/modest-tny-account-store.h:
3840 * src/modest-tny-account-store.c:
3841 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3842 the connection-specific SMTP server settings in the configuration.
3844 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3846 * src/maemo/modest-main-window.c: (on_connection_changed),
3848 * src/modest-main.c: (main), (start_ui), (send_mail):
3849 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3850 that is what is intended.
3852 * src/modest-ui-actions.c: (action_send), (action_receive),
3853 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3854 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3855 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3856 SMTP server is used when it is specified.
3858 (modest_ui_actions_on_send_receive):
3859 Check that a connection is open before proceeding.
3860 Receive and then send, instead of vice-versa, as per the specification.
3862 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3864 * src/modest-mail-operation.c:
3865 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3866 though I guess it should be something other than NULL.
3868 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/easysetup/modest-easysetup-wizard.c:
3871 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3872 combo twice, to avoid an g_warning and to make it visible again.
3873 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3874 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3875 (already intended) dereference when detaching, because we then recreate the menu.
3876 But I am not sure why the warning was happening, and it is possible that this is a memory
3879 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3881 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3882 and uri_parse_mailto() utility functions.
3883 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3885 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3887 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3889 * src/dbus_api/modest-dbus-api.h:
3890 * src/dbus_api/modest-dbus-callbacks.c:
3891 Use an idle callback to execute the modest code in the application's own thread.
3892 Remove the helloworld example method.
3893 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3894 parsed, and the open-message method is not implemented because this is not yet implemented in
3896 * libmodest-dbus-client/libmodest-dbus-client.c:
3897 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3898 (libmodest_dbus_client_open_message):
3899 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3901 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3902 body without crashing.
3904 * tests/dbus_api/Makefile.am:
3905 * tests/dbus_api/test_mail_to.c:
3906 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3908 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3910 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3911 Added file to fix the build. Sorry.
3913 * src/dbus_api/Makefile.am:
3914 * src/dbus_api/modest-dbus-api.h:
3915 * src/dbus_api/modest-dbus-callbacks.h:
3916 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3917 (modest_dbus_req_handler):
3918 Put constants in a separate header so it can be reused by the
3919 client library, without duplication
3921 * libmodest-dbus-client/Makefile.am:
3922 * libmodest-dbus-client/libmodest-dbus-client.c:
3923 (libmodest_dbus_client_call_helloworld),
3924 (libmodfest_dbus_client_send_mail),
3925 (libmodfest_dbus_client_mailto),
3926 (libmodfest_dbus_client_open_message):
3927 * libmodest-dbus-client/libmodest-dbus-client.h:
3928 (Partly) Implement a send_mail D-Bus method.
3930 * tests/dbus_api/Makefile.am:
3931 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3932 the send_email D-Bus method.
3934 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3938 * libmodest-dbus-client/Makefile.am:
3939 * libmodest-dbus-client/libmodest-dbus-client.c:
3940 * libmodest-dbus-client/libmodest-dbus-client.h:
3941 * tests/dbus_api/Makefile.am:
3942 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3943 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3945 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3947 * src/maemo/easysetup/modest-easysetup-wizard.c:
3948 (create_page_account_details):
3949 * src/maemo/modest-account-settings-dialog.c:
3950 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3951 widgets, because this might not be the default in future versions of the Maemo GTK+.
3952 However, I can not not get capitalization to work even in a simple test case.
3954 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3956 * src/maemo/easysetup/modest-easysetup-wizard.c:
3957 (create_page_custom_incoming), (create_page_custom_outgoing):
3958 * src/maemo/modest-account-settings-dialog.c:
3959 (create_page_account_details), (create_page_incoming),
3960 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3961 instead of using gtk_check_button_with_label(), so they are aligned like the other
3962 widgets, as per the UI spec.
3964 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3966 * src/maemo/easysetup/modest-easysetup-wizard.c:
3967 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3968 * src/widgets/modest-validating-entry.c:
3969 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3970 Modest prefix instead of an EasySetup prefix.
3972 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3974 * src/widgets/modest-validating-entry.h:
3975 * src/widgets/modest-validating-entry.c: (on_insert_text),
3976 Added easysetup_validating_entry_set_max_func(), used to set a callback
3977 to call when the max number of characters is reached. GtkEntry has a max-length
3978 already but is silent about it.
3980 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3981 (create_page_account_details), (create_page_user_details),
3983 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3984 (create_page_account_details), (create_page_user_details),
3985 (create_page_outgoing):
3986 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3987 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3988 the UI spec, when the user tries to enter more than the max number of characters.
3990 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3992 * src/maemo/easysetup/modest-easysetup-wizard.c:
3993 (create_page_user_details), (create_page_custom_incoming),
3994 (create_page_custom_outgoing):
3995 * src/maemo/modest-account-settings-dialog.c:
3996 (create_page_user_details), (create_page_incoming),
3997 (create_page_outgoing):
3998 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3999 (modest_connection_specific_smtp_edit_window_init):
4000 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4001 not appropriate. Bad Maemo-specific defaults!.
4003 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4005 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4006 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4007 (modest_signature_editor_dialog_set_settings):
4008 Disable the label and textview when the checkbox is disabled, and use the
4009 specified (UI spec) default signature text.
4011 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4013 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4014 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4016 * src/modest-defs.h:
4017 * src/modest-account-mgr-helpers.h:
4018 * src/modest-account-mgr-helpers.c:
4019 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4021 * src/maemo/Makefile.am:
4022 * src/maemo/modest-signature-editor-dialog.c:
4023 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4026 * src/maemo/modest-account-settings-dialog.h:
4027 * src/maemo/modest-account-settings-dialog.c:
4028 (modest_account_settings_dialog_finalize), (on_button_signature),
4029 (save_configuration): Use the new dialog when the Edit button is pressed, and
4030 save the changes if necessary, as per the UI spec.
4032 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4034 * src/maemo/Makefile.am:
4035 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4036 based on maemo-develoers email from Dirk.
4038 * src/maemo/easysetup/modest-easysetup-wizard.c:
4039 (create_page_welcome), (create_page_account_details),
4040 (create_page_user_details), (create_page_complete_easysetup),
4041 (create_page_custom_incoming), (create_page_custom_outgoing),
4042 (create_page_complete_custom),
4043 (modest_easysetup_wizard_dialog_init):
4044 * src/maemo/modest-account-settings-dialog.c:
4045 (create_page_account_details), (create_page_user_details),
4046 (create_page_incoming), (create_page_outgoing),
4047 (modest_account_settings_dialog_init):
4048 * src/maemo/modest-connection-specific-smtp-window.c:
4049 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4051 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4053 * src/maemo/easysetup/modest-easysetup-wizard.c:
4054 (create_page_account_details), (create_page_custom_outgoing),
4055 (create_page_complete_custom):
4056 * src/maemo/modest-account-settings-dialog.c:
4057 (create_page_user_details), (create_page_incoming),
4058 (create_page_outgoing):
4059 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4060 (modest_connection_specific_smtp_edit_window_init):
4061 Use the correct (UI spec) port min/max, and use horizontal separators,
4064 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4066 * src/maemo/easysetup/modest-easysetup-wizard.c:
4067 (set_default_custom_servernames):
4068 * src/maemo/modest-account-settings-dialog.c:
4069 (create_page_incoming), (on_combo_outgoing_security_changed),
4070 (on_combo_incoming_security_changed), (create_page_outgoing),
4071 (modest_account_settings_dialog_set_account_name),
4072 (save_configuration):
4073 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4074 (on_combo_security_changed),
4075 (modest_connection_specific_smtp_edit_window_init),
4076 (modest_connection_specific_smtp_edit_window_set_connection),
4077 (modest_connection_specific_smtp_edit_window_get_settings):
4078 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4081 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4084 * src/maemo/easysetup/modest-easysetup-wizard.c:
4085 (create_page_custom_outgoing), (create_page_complete_custom):
4086 * src/maemo/modest-account-settings-dialog.c:
4087 (create_page_user_details), (create_page_outgoing):
4088 * src/maemo/modest-account-view-window.c: (button_box_new):
4089 Use changed logical IDs as per the most recent UI spec:
4090 mcen_bd_emailsetup_edit -> mcen_bd_edit
4091 mcen_bd_emailsetup_delete -> mcen_bd_delete
4092 mcen_bd_emailsetup_close -> mcen_bd_close
4094 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4098 * src/dbus_api/Makefile.am:
4099 * src/dbus_api/modest-dbus-callbacks.c:
4100 * src/dbus_api/modest-dbus-callbacks.h:
4101 * src/maemo/modest-platform.c: (modest_platform_init):
4102 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4104 * tests/Makefile.am:
4105 * tests/dbus_api/Makefile.am:
4106 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4108 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4110 * src/maemo/modest-account-settings-dialog.c:
4111 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4112 Removed unnecessary includes.
4114 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4116 * src/maemo/easysetup/modest-easysetup-wizard.c:
4117 * src/maemo/modest-account-settings-dialog.c:
4118 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4119 * src/widgets/Makefile.am:
4120 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4121 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4122 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4123 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4124 * src/widgets/modest-secureauth-combo-box.c:
4125 * src/widgets/modest-secureauth-combo-box.h:
4126 * src/widgets/modest-serversecurity-combo-box.c:
4127 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4128 made the GObject names more consistent with the rest of the Modest code.
4130 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4132 * src/maemo/easysetup/Makefile.am:
4133 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4134 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4135 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4136 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4137 * src/maemo/easysetup/modest-easysetup-wizard.c:
4138 * src/maemo/easysetup/modest-validating-entry.c:
4139 * src/maemo/easysetup/modest-validating-entry.h:
4140 * src/maemo/modest-account-settings-dialog.c:
4141 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4142 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4143 widgets/ because they are used outside of easysetup too. After checking in,
4144 svn will allow me to rename them too.
4146 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4148 * src/gnome/modest-msg-edit-window.c:
4149 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4150 linker error, to fix the build on the GNOME platform.
4151 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4152 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4153 ifdefed out to avoid a warning.
4155 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4157 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4158 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4159 some alternative for GTK+ 2.6.
4161 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4163 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4165 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4166 specified for EmailAccountsDialog in UI spec.
4168 * src/maemo/easysetup/modest-easysetup-wizard.c:
4169 * src/maemo/easysetup/modest-easysetup-wizard.h:
4170 * src/maemo/modest-account-settings-dialog.c:
4171 * src/maemo/modest-account-settings-dialog.h:
4172 Reuse a member window widget for the connection-specific SMTP server accounts,
4173 so we can tell it to create/save the accounts only if we actually save changes.
4175 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4176 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4177 (modest_connection_specific_smtp_edit_window_get_settings):
4178 Return a struct instance for temporarily remembering the entered data.
4180 * src/maemo/modest-connection-specific-smtp-window.h:
4181 * src/maemo/modest-connection-specific-smtp-window.c:
4182 (modest_connection_specific_smtp_window_finalize),
4183 (modest_connection_specific_smtp_window_fill_with_connections),
4185 (modest_connection_specific_smtp_window_save_server_accounts),
4186 (update_model_server_names): Do not actually save data until asked,
4187 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4189 (on_selection_changed),
4190 (modest_connection_specific_smtp_window_init): Disable the edit
4191 button when nothing is selected.
4193 * src/modest-account-mgr-helpers.c:
4194 * src/modest-account-mgr-helpers.h:
4195 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4198 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4200 * src/modest-account-mgr-helpers.h:
4201 * src/modest-account-mgr-helpers.c:
4202 (modest_account_mgr_get_unused_account_name),
4203 (modest_account_mgr_get_unused_account_display_name): Added these
4204 utility functions, to avoid code duplication.
4206 * src/maemo/easysetup/modest-easysetup-wizard.c:
4207 (create_page_account_details), (create_account):
4208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4209 (on_combo_security_changed),
4210 (modest_connection_specific_smtp_edit_window_init),
4211 (modest_connection_specific_smtp_edit_window_save_settings):
4212 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4213 * src/maemo/modest-connection-specific-smtp-window.c:
4214 (modest_connection_specific_smtp_window_finalize),
4215 (modest_connection_specific_smtp_window_fill_with_connections),
4216 (on_button_edit), (modest_connection_specific_smtp_window_init):
4217 * src/maemo/modest-connection-specific-smtp-window.h:
4218 Implementing saving of connection-specific server accounts.
4220 But I need to refactor this so we can save the data for each
4221 possible connection-specific account and only actually create the server accounts
4222 when the easysetup finished, or the OK button is pressed on the account settings
4225 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4227 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4228 (on_combo_security_changed):
4229 (modest_connection_specific_smtp_edit_window_init):
4230 Auto-fill the port number as in the account settings.
4232 (modest_connection_specific_smtp_edit_window_set_connection):
4233 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4234 * src/maemo/modest-connection-specific-smtp-window.c:
4235 (fill_with_connections), (on_button_edit),
4236 (modest_connection_specific_smtp_window_init):
4237 Turn the edit window into a dialog to simplify the code, and
4238 set a WM hint as in a GtkDialog, because only a popup can be on top of
4239 another window in Maemo, and popups usually have no WM decoration.
4241 * src/modest-defs.h:
4242 * src/modest-account-mgr-helpers.c:
4243 (modest_account_mgr_set_connection_specific_smtp),
4244 (modest_account_mgr_remove_connection_specific_smtp),
4245 (modest_account_mgr_get_connection_specific_smtp):
4246 * src/modest-account-mgr-helpers.h: Some functions to write the
4247 connection-specific SMTP server information. Not yet used.
4250 * src/widgets/modest-folder-view.c: (text_cell_data):
4251 Fix a warning about an uninitialized variable.
4252 (on_configuration_key_changed): Put an #ifdef around the use
4253 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4255 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4257 * src/maemo/modest-account-settings-dialog.h:
4258 * src/maemo/modest-account-settings-dialog.c:
4259 Added connect_for_modified() utility function to mark the new modified boolean.
4261 (create_page_account_details), (create_page_user_details),
4262 (create_page_incoming), (create_page_outgoing), (on_response),
4263 (modest_account_settings_dialog_init),
4264 (modest_account_settings_dialog_set_account_name):
4265 Only warn about unsaved changes when there are actually unsaved changes.
4267 * src/modest-account-mgr-helpers.c:
4268 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4269 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4270 to get the data from there in future.
4272 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4274 * src/modest-defs.h:
4276 * src/modest-account-mgr-helpers.h:
4277 * src/modest-account-mgr-helpers.c:
4278 Store the security account setting in a single conf key instead of using
4279 the options list, so that the list is left for just the to-be-removed camel hack,
4280 and because gconf_client_set_list() is failing for some reason.
4282 * src/modest-account-mgr.c:
4283 (modest_account_mgr_add_server_account):
4284 * src/maemo/modest-account-settings-dialog.c:
4285 (modest_account_settings_dialog_set_account_name),
4286 (save_configuration): Use the renamed functions.
4289 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4291 * src/widgets/Makefile.am:
4292 * src/widgets/modest-limit-retrieve-combo-box.c:
4293 * src/widgets/modest-limit-retrieve-combo-box.h:
4294 * src/widgets/modest-retrieve-combo-box.c:
4295 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4296 the account settings dialog.
4298 * src/modest-defs.h:
4299 * src/modest-account-mgr-helpers.h:
4300 * src/modest-account-mgr-helpers.c:
4301 (modest_server_account_get_option_secure_auth),
4302 (modest_server_account_set_option_secure_auth):
4303 * src/modest-account-mgr.c:
4304 (modest_account_mgr_add_server_account):
4305 Use the existing AUTH_MECH conf key for the secure-auth setting,
4306 instead of putting it in the list options, because this was actually used already.
4308 * src/maemo/modest-account-settings-dialog.c:
4309 (create_page_account_details),
4310 (modest_account_settings_dialog_set_account_name),
4311 (save_configuration):
4312 * src/maemo/modest-account-settings-dialog.h:
4313 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4314 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4316 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4318 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4319 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4320 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4322 * src/modest-defs.h:
4323 * src/maemo/modest-account-settings-dialog.c:
4324 (create_page_incoming), (on_combo_outgoing_security_changed),
4325 (on_combo_incoming_security_changed), (create_page_outgoing),
4326 (modest_account_settings_dialog_set_account_name),
4327 (save_configuration): Load/Save the port number, and change it when the
4328 security combo changes, to suitable defaults.
4330 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4332 * src/modest-account-mgr.c:
4333 (modest_account_mgr_add_server_account): Set the security and secure-auth
4334 options, and add a comment saying that the other camel-specific options should be
4337 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4339 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4341 * src/modest-tny-account-store.c: (account_list_free),
4342 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4343 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4346 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4348 * src/modest-protocol-info.c:
4349 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4350 is required by our UI spec. Maybe something in our implementation will use this eventually.
4351 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4352 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4353 instead of the previous 0 placeholder.
4355 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4356 secure-auth settings.
4357 * src/modest-account-mgr-helpers.h:
4358 * src/modest-account-mgr-helpers.c:
4359 (modest_server_account_data_get_option_secure_auth),
4360 (modest_server_account_set_option_secure_auth),
4361 (modest_server_account_data_get_option_security),
4362 (modest_server_account_set_option_security): Added this API for getting and setting the security
4363 and secure-auth settings.
4365 * src/maemo/modest-account-settings-dialog.h:
4366 * src/maemo/modest-account-settings-dialog.c:
4367 (modest_account_settings_dialog_finalize), (check_data),
4368 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4369 about changing titles.
4370 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4371 (save_configuration): Save the security and secure-auth settings.
4373 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4374 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4376 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4378 * src/modest-defs.h:
4379 * src/modest-account-mgr.c:
4380 (modest_account_mgr_add_server_account):
4381 Added and used defines for the options key and value pair strings,
4382 that are used so far, though they do not seem to correspond to anything in our
4383 UI specs or ModestProtocol enum.
4385 * src/modest-account-mgr-helpers.h:
4386 * src/modest-account-mgr-helpers.c:
4387 (compare_option_strings_for_name),
4388 (modest_server_account_data_get_option_value),
4389 (modest_server_account_data_get_option_bool),
4390 (modest_account_mgr_get_server_account_option):
4391 Added helper functions for parsing the options GSList.
4393 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4395 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4396 display name is based on the supplied account name.
4397 * src/modest-account-mgr.c:
4398 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4399 with an inefficient, but good-enough, implementation.
4401 * src/maemo/easysetup/modest-easysetup-wizard.c:
4402 (create_page_account_details), (on_before_next), (create_account):
4403 Check for existing display names rather than (non-user-visible) account names, and just
4404 create and set a unique account name at the end.
4406 * src/maemo/modest-account-settings-dialog.c:
4407 (modest_account_settings_dialog_init),
4408 (modest_account_settings_dialog_set_account_name),
4409 (create_page_incoming): Show the display name, instead of the account name.
4410 (on_response): Do some (not all) extra checks, as in the UI spec.
4411 (save_configuration): Save the display name if it was changed.
4413 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4415 * po/en_GB.po: Added needed logical ID and translation.
4416 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4417 (init_view): Made the is-default column clicking work.
4419 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4422 * src/maemo/easysetup/Makefile.am:
4423 * src/maemo/easysetup/modest-easysetup-wizard.c:
4424 (modest_easysetup_wizard_dialog_init):
4425 * src/maemo/easysetup/provider-data-test.keyfile:
4426 * src/maemo/easysetup/provider-data.keyfile:
4427 Moved the provider data file to the new modest-providers-data package and used it from there.
4429 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4431 * src/modest-local-folder-info.c:
4432 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4433 N_() was already used on the static strings, but this just marks it for translation without
4434 using the translation.
4436 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4438 * src/maemo/modest-account-settings-dialog.c:
4439 (create_page_incoming),
4440 (modest_account_settings_dialog_set_account_name):
4441 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4442 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4443 I will do this if nobody else gets there first.
4445 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4447 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4448 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4449 save the security stuff.
4451 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4453 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4454 Set the email address and user fullname, which I now see must be
4457 * src/maemo/modest-account-settings-dialog.h:
4458 * src/maemo/modest-account-settings-dialog.c:
4460 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4461 leave-on-server and authentication.
4462 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4465 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4468 * src/maemo/modest-account-settings-dialog.c:
4469 * src/maemo/modest-account-settings-dialog.h:
4470 Most (but not all) of the widgets are now present as specified by the UI spec.
4471 No changes are yet saved, and some details are not properly shown yet.
4473 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4475 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4477 * src/maemo/Makefile.am:
4478 * src/maemo/modest-account-settings-dialog.c:
4479 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4480 an existing account. Doesn't do much yet.
4482 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4483 Open the accounts settings dialog when Edit is clicked.
4485 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4487 * src/maemo/easysetup/Makefile.am:
4488 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4490 * src/maemo/easysetup/modest-easysetup-wizard.c:
4491 (modest_easysetup_wizard_dialog_init):
4492 Try to get the source directory from the build system,
4493 instead of hard-coding "./" into the source code, when opening our local
4494 copies of the configuration files.
4495 But this still fails when opening the wizard from the Accounts window,
4496 maybe because the working directory seems to change at runtime.
4497 So the wizard will fail the second time unless you copy the files into their
4498 proper locations - see the stdout warnings for the paths.
4500 (create_page_account_details),(on_before_next):
4501 Check for existing non-server accounts instead of server accounts,
4502 so the default account name is useful again, and to prevent trying to
4505 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4506 Show the wizard when New is clicked.
4508 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4509 (init_view): Show the column headers, and show the columns that are
4510 specified in the UI specs. However, something in Maemo's GTK+ prevents
4511 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4512 change the default account. This is despite unsetting the special properties.
4514 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4516 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4517 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4518 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4519 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4520 to make that clearer.
4521 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4523 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4525 * src/maemo/modest-account-view-window.c:
4526 (modest_account_view_window_init),
4527 (modest_account_view_window_new):
4528 Use the same buttons as specified in the
4529 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4530 the existing widgets, which never had a chance of working.
4531 Put the ModestAccountView treeview in a scrolled window.
4532 Do not repeat the initialization in both _init() and _new().
4534 * src/widgets/modest-account-view.c: (update_account_view):
4535 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4536 this widget and window shows no accounts.
4538 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4540 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4542 * src/maemo/easysetup/modest-easysetup-wizard.c:
4543 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4544 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4545 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4548 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4549 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4550 accounts exist yet, as in the UI spec.
4552 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4554 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4556 * src/maemo/Makefile.am:
4557 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4558 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4559 New window for editing connection-specific smtp details.
4560 Not fully implemented.
4562 * src/maemo/modest-connection-specific-smtp-window.c:
4563 (modest_connection_specific_smtp_window_finalize) :
4564 unref the tree model.
4565 (on_button_edit): Show the edit window.
4567 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4569 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4572 * src/maemo/Makefile.am:
4573 * src/maemo/modest-connection-specific-smtp-window.c:
4574 * src/maemo/modest-connection-specific-smtp-window.h:
4575 New window for showing the list of connections, for connection-specific
4576 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4577 * src/maemo/easysetup/modest-easysetup-wizard.c:
4578 (create_page_custom_outgoing): Show the new window when the button is clicked.
4580 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4582 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4583 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4584 * src/maemo/modest-msg-edit-window.c:
4585 (modest_msg_edit_window_insert_image):
4586 * src/modest-conf.c: (modest_conf_key_escape):
4587 * src/modest-mail-operation.c:
4588 (modest_mail_operation_send_new_mail):
4589 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4590 (modest_ui_actions_on_new_account):
4591 * src/widgets/modest-attachment-view.c: (update_filename_request):
4592 * src/widgets/modest-mail-header-view.c:
4593 Corrected warnings that were breaking the build, by commenting out unused variables,
4594 and a function, and by including a header.
4596 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4598 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4599 so we can #ifdef around platform-specific code when necessary.
4600 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4601 to allow this to build for the GNOME platform too.
4603 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4605 * src/maemo/easysetup/modest-easysetup-wizard.c:
4606 Added util_increment_name() and used it in create_page_account_details()
4607 to make sure that the default account name is always a new name.
4609 (modest_easysetup_wizard_dialog_init),
4610 (set_default_custom_servernames): Some minor memory management fixes.
4612 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4616 * src/modest-runtime.c: (init_i18n): Restored the translation
4617 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4618 are defined in config.h, and the translations are installed.
4620 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4621 is defined for translation.
4623 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4625 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4627 * src/maemo/easysetup/modest-easysetup-wizard.c:
4628 (modest_easysetup_wizard_dialog_init):
4629 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4630 Use realistic paths (though they should use $prefix generically) to the
4631 mcc_mapping and provider-data.keyfile files which might work when they
4632 are installed by the future version of the operator-wizard package,
4633 and then fallback to paths in our source code, with an explanatory
4636 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4640 * src/maemo/Makefile.am:
4641 * src/maemo/easysetup/: Added files from the previously-exernal
4642 osso-modest-easysetup.
4643 * src/maemo/modest-main-window-ui.h:
4644 * src/modest-ui-actions.c:
4645 * src/modest-ui-actions.h:
4646 Added modest_ui_actions_on_new_account() as a signal handler for the
4647 New Account menu item. It shows the easysetup wizard.
4648 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob