1 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-account-view.c:
4 * src/widgets/modest-account-view.h:
5 Added modest_account_view_select_account() which will be useful later
6 to asynchronously re-select the edited account.
8 2007-05-17 Murray Cumming <murrayc@murrayc.com>
10 * src/maemo/modest-account-settings-dialog.c:
11 (modest_account_settings_dialog_set_account_name):
12 Automatically choose the port numbers based on the secure authentication
13 methods, if they have not been chosen before.
14 This fixes projects.maemo.org bug NB#56273 .
16 2007-05-17 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/modest-main-window-ui.h:
19 * src/modest-ui-actions.c:
20 * src/modest-ui-actions.h:
21 Connect the Tools/SMTP Servers menu item to
22 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
23 SMTP servers dialog, as in the UI specification and saves changes when it
24 is closed. This fixed projects.maemo.org bug NB#56305 .
26 2007-05-17 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-connection-specific-smtp-window.c:
29 (modest_connection_specific_smtp_window_init):
30 Use gtk_window_set_default_size() to make this window big enough, so
31 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
33 2007-05-17 Murray Cumming <murrayc@murrayc.com>
35 * src/maemo/modest-connection-specific-smtp-edit-window.h:
36 * src/maemo/modest-connection-specific-smtp-edit-window.c:
37 (modest_connection_specific_smtp_edit_window_init),
38 Do not try to connect to a combobox signal before the combobox exists.
39 This fixes the cras in projects.maemo.org bug NB#56288 .
40 (modest_connection_specific_smtp_edit_window_get_settings):
41 Remove the server_account_name parameter which was being checked for NULL
42 though it was not used.
44 * src/maemo/modest-connection-specific-smtp-window.c:
45 (modest_connection_specific_smtp_window_fill_with_connections),
46 (on_button_edit), (modest_connection_specific_smtp_window_init):
47 Correct the number of treemodel columns to prevent a warning.
48 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
49 libconic does not work.
51 2007-05-16 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-tny-account.c:
54 (modest_tny_account_new_from_server_account):
55 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
56 SMTP when "None" was chosen by the user. However, with my SMTP server that
57 does not support ANONYMOUS, the emails do not leave the Outbox and I see
60 2007-05-16 Murray Cumming <murrayc@murrayc.com>
62 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
63 to explain the memory management issue with the ID in the ModestPair.
65 * src/gnome/modest-account-assistant.c: (add_receiving_page),
66 (add_sending_page), (modest_account_assistant_finalize):
67 * src/gnome/modest-gnome-global-settings-dialog.c:
68 (create_updating_page), (create_composing_page):
69 * src/gnome/modest-msg-edit-window.c: (get_transports),
70 (init_window), (modest_msg_edit_window_finalize),
71 (modest_msg_edit_window_get_msg_data):
72 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
73 * src/gnome/modest-transport-widget.c:
74 (modest_transport_widget_finalize), (smtp_configuration):
75 * src/maemo/modest-maemo-global-settings-dialog.c:
76 (create_updating_page), (create_composing_page):
77 * src/maemo/modest-msg-edit-window.c: (get_transports),
78 (init_window), (modest_msg_edit_window_finalize),
79 (modest_msg_edit_window_get_msg_data),
80 (modest_msg_edit_window_free_msg_data):
81 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
82 (modest_store_widget_finalize):
83 * src/maemo/modest-transport-widget.c:
84 (modest_transport_widget_finalize), (smtp_configuration):
85 * src/modest-main.c: (send_mail):
86 * src/widgets/modest-combo-box.h:
87 * src/widgets/modest-global-settings-dialog-priv.h:
88 * src/widgets/modest-global-settings-dialog.c:
89 (modest_global_settings_dialog_finalize):
90 * src/widgets/modest-msg-edit-window.h:
91 Whenever using modest_combo_box_new(), keep the ModestPairList alive
92 as long as the combo box, to prevent use of freed memory for the ID.
94 2007-05-15 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
97 get_accounts(), to make this clearer. Do not check for the enabled gconf
98 key, because we do not use this for server accounts (at least, not yet).
99 This allows us to send email again.
101 2007-05-15 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-platform.c:
104 (on_modest_conf_update_interval_changed), (modest_platform_init):
105 Only respond to this particular key change. All these strcmp()s cannot be
108 2007-05-15 Murray Cumming <murrayc@murrayc.com>
110 * src/maemo/modest-maemo-global-settings-dialog.c:
111 (current_connection): Prevent a crash in scratchbox when
112 ny_maemo_conic_device_get_current_iap_id() returns NULL.
113 * src/maemo/modest-platform.c:
114 (on_modest_conf_update_interval_changed), (modest_platform_init):
115 Get the update interval from gconf and reset it when the gconf key changes.
117 2007-05-15 Murray Cumming <murrayc@murrayc.com>
119 * src/modest-protocol-info.c:
120 * src/modest-protocol-info.h: Adde enum-specific get functions,
121 instead of using a ModestProtocolType enum parameter.
123 * src/gnome/modest-account-assistant.c:
124 * src/gnome/modest-store-widget.c:
125 * src/gnome/modest-store-widget.h:
126 * src/gnome/modest-transport-widget.c:
127 * src/gnome/modest-transport-widget.h:
128 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
129 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
130 * src/maemo/easysetup/modest-easysetup-wizard.c:
131 * src/maemo/modest-account-settings-dialog.c:
132 * src/maemo/modest-account-settings-dialog.h:
133 * src/maemo/modest-store-widget.c:
134 * src/maemo/modest-store-widget.h:
135 * src/maemo/modest-transport-widget.c:
136 * src/maemo/modest-transport-widget.h:
137 * src/modest-account-mgr-helpers.c:
138 * src/modest-account-mgr-helpers.h:
139 * src/modest-account-mgr.c:
140 * src/modest-account-mgr.h:
141 * src/modest-tny-account.c:
142 * src/modest-tny-folder.c:
143 * src/widgets/modest-account-view.c:
144 * src/widgets/modest-retrieve-combo-box.c:
145 * src/widgets/modest-retrieve-combo-box.h:
146 * src/widgets/modest-secureauth-combo-box.c:
147 * src/widgets/modest-serversecurity-combo-box.c:
148 * src/widgets/modest-serversecurity-combo-box.h:
149 * tests/check_account-mgr.c:
150 Use the specific functions, and use the re-renamed enum values for GNOME too.
152 2007-05-15 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
156 so we can get the second based on the first.
158 * src/maemo/modest-account-settings-dialog.h:
159 * src/maemo/modest-account-settings-dialog.c:
160 Added get_supported_secure_authentication_methods(), though it is mostly
161 commented-out for now until the necessary API is committed to tinymail.
162 (modest_account_settings_dialog_set_account_name),
163 (save_configuration): Request the supported authentication methods from the
164 server, so we can choose a working method.
166 * src/modest-tny-account-store.h:
167 * src/modest-tny-account-store.c:
168 (modest_tny_account_store_get_session): Rename from
169 tny_account_store_get_session().
171 2007-05-14 Murray Cumming <murrayc@murrayc.com>
173 * src/modest-protocol-info.h: Split the ModestProtocol enum
174 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
175 There was no need to have these unrelated values in one enum.
177 * src/: many files: Adapted to changed enum. This makes the code a bit
178 clearer, and the compiler could catch some errors.
180 2007-05-14 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
183 Show the detailed internal camel error message when an error happens
184 during the configuration, so that our testers can give us more clues.
185 For instance, in projects.maemo.org bug NB#56910 .
187 2007-05-14 Murray Cumming <murrayc@murrayc.com>
189 * src/modest-tny-account.c:
190 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
191 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
193 2007-05-14 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
196 * src/maemo/modest-account-settings-dialog.c:
197 (modest_account_settings_dialog_set_account_name),
198 (save_configuration): For the incoming secure authentication checkbox,
199 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
200 the UI specification. PLAIN does not seem to be supported for most IMAP
201 servers anyway, and I am not sure what it would mean.
202 However, we probably need to discover which of the secure-authentication
203 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
204 * src/modest-account-mgr-helpers.c:
205 (modest_account_mgr_get_server_account_data):
207 * src/modest-tny-account.c:
208 (modest_tny_account_new_from_server_account):
209 Use tny_account_set_mech() to set secure-authentication methods,
210 with some special-casing for IMAP, based on my observations of how
213 * src/modest-account-mgr-helpers.h:
214 * src/modest-account-mgr.c:
215 * src/modest-defs.h: Comment that the URI is only used for local folders.
217 2007-05-11 Murray Cumming <murrayc@murrayc.com>
219 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
220 parameter const, just to be neat.
221 * src/modest-text-utils.c: (modest_text_utils_inline):
222 End g_strconcat() with NULL, as its documentation says. This is almost
223 certainly the cause of my crash at startup on the device. Interestingly,
224 valgrind doesn't tell us about these errors.
226 2007-05-11 Murray Cumming <murrayc@murrayc.com>
228 * scripts/build-packages: Added more precise comments about how to use
229 this script, though I still get this error:
230 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
231 error building tinymail
233 2007-05-11 Murray Cumming <murrayc@murrayc.com>
235 * src/maemo/modest-main-window.c: (on_account_update):
236 Very slight cleanup, hoping to make it simpler to discover what causes
237 a crash here sometimes.
239 * src/modest-tny-account.c:
240 (modest_tny_account_new_from_server_account): Set the port. Added
241 comments about the options and a TODO comment because I need to find out
242 how to specify the secure authentication method.
244 2007-05-11 Marcus Bauer <marcusb@openismus.com>
246 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
247 changed CFlags paths form modest to libmodest
249 2007-05-10 Murray Cumming <murrayc@murrayc.com>
251 * src/modest-account-mgr-helpers.c:
252 (modest_account_mgr_get_server_account_data),
253 (modest_account_mgr_free_server_account_data):
254 * src/modest-account-mgr-helpers.h:
255 * src/modest-account-mgr.c:
256 (modest_account_mgr_add_server_account):
258 * src/modest-tny-account.c:
259 (modest_tny_account_new_from_server_account):
260 Determine the options for tny_camel_account_add_option() here,
261 based on the settings, rather than storing them directly in gconf.
263 2007-05-10 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
266 Show a more friendly error dialog now that we expect (from the tinymail
267 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
269 2007-05-10 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-main-window.c: (on_account_update): Check that
272 account_name is not NULL, to prevent a crash at startup that I am
273 seeing on the N800. I do wonder why it is NULL.
275 * src/maemo/easysetup/modest-easysetup-wizard.c:
276 (create_page_user_details):
277 * src/maemo/modest-account-settings-dialog.c:
278 (create_page_user_details), (create_page_outgoing):
279 * src/maemo/modest-connection-specific-smtp-edit-window.c:
280 (modest_connection_specific_smtp_edit_window_init):
281 * src/modest-ui-actions.c:
282 (modest_ui_actions_on_password_requested):
283 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
284 might do something useful with the on-screen keyboard.
286 2007-05-10 Murray Cumming <murrayc@murrayc.com>
288 * src/maemo/modest-main-window.c: (on_account_update):
289 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
290 NULL, to avoid lots of warnings. However, it probably should not be NULL.
292 2007-05-09 Murray Cumming <murrayc@murrayc.com>
294 * src/modest-tny-account-store.c: (on_account_changed):
295 Correct the signature of this signal handler.
297 2007-05-09 Murray Cumming <murrayc@murrayc.com>
299 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
300 Show a HildonNote instead of a GtkDialog for Maemo.
302 2007-05-09 Murray Cumming <murrayc@murrayc.com>
304 * src/widgets/modest-account-view.h:
305 * src/widgets/modest-account-view.c: (on_account_changed),
306 (on_account_removed). Added a boolean flag, set/unset by
307 modest_account_view_block_conf_updates(),
308 modest_account_view_unblock_conf_updates() to prevent unnecessary
309 updates, but this is not very useful because the gconf notifications are
310 so delays (maybe only on Maemo Bora).
311 So auto-updating is turned off, and these functions do an explicit
312 update when necessary.
313 However, something else is still doing too much work when adding/removing
314 accounts, probably in another part of the application.
316 * src/maemo/modest-account-view-window.c:
317 (on_delete_button_clicked), (on_edit_button_clicked),
318 (on_new_button_clicked): Use the new functions.
320 2007-05-09 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-account-mgr-helpers.c:
323 (modest_account_mgr_set_first_account_as_default):
324 Sort the list of names alphabetically-by-title, so we choose the first one
326 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
327 alphabetically by the title.
329 This fixes projects.maemo.org bug NB#56418 .
331 * src/modest-account-mgr-priv.c:
332 (_modest_account_mgr_account_from_key):
333 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
334 avoid a valgrind error, and possible random behaviour.
336 2007-05-09 Murray Cumming <murrayc@murrayc.com>
338 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
339 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
340 tinymail documentation to say that this can be expected.
341 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
342 pretty, and should not happen, but I would prefer to know when it does.
344 2007-05-09 Murray Cumming <murrayc@murrayc.com>
346 * configure.ac: When using the older hildon version, probably on Bora,
347 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
349 * src/widgets/modest-attachment-view.c:
350 (modest_attachment_view_set_part_default): Initialize variables, to fix the
353 2007-05-09 Marcus Bauer <marcusb@openismus.com>
355 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
356 Implemented the prototype. Can be tested with
357 tests/dbus_api/test_open_message:
359 2007-05-08 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-tny-account-store.c:
362 (modest_tny_account_store_instance_init), (get_password):
363 * src/modest-ui-actions.c:
364 (modest_ui_actions_on_password_requested):
365 Do not store the password in gconf, because this function is called
366 for non-remembered passwords. Actually use the cached (in the hash map)
367 password instead of releasing it.
368 The password will now not be remembered if it is asked via the protected
369 password dialog, as per the UI spec.
371 2007-05-08 Murray Cumming <murrayc@murrayc.com>
374 * src/modest-account-mgr-helpers.h:
375 * src/modest-account-mgr-helpers.c:
376 Added modest_server_account_get_username_has_succeeded(),
377 modest_server_account_set_username_has_succeeded().
378 (modest_server_account_set_username),
379 Reset the has-succeeded flag if the username changes.
381 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
382 * src/maemo/modest-connection-specific-smtp-window.c:
383 (modest_connection_specific_smtp_window_save_server_accounts):
384 Use modest_server_account_set_username() instead of using
385 modest_conf_set_string() directly, so that the has-succeeded flag is always
388 * src/modest-ui-actions.c:
389 (modest_ui_actions_on_password_requested): Dim the username entry if
390 the username has ever worked, as per the UI spec.
392 2007-05-08 Murray Cumming <murrayc@murrayc.com>
394 * src/modest-tny-account-store.c: (get_password):
395 * src/modest-ui-actions.c:
396 (modest_ui_actions_on_password_requested):
397 Allow the username to be changed too, though there is more work to
398 be done on exactly how this behaves.
400 2007-05-08 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-account-mgr-helpers.h:
403 * src/modest-account-mgr-helpers.c:
404 Added modest_account_mgr_get_display_name(),
405 modest_server_account_get_username(),
406 modest_server_account_set_username(),
407 modest_server_account_set_password(),
408 modest_server_account_get_hostname() functions so we do not need to
409 use the conf API directly.
411 * src/maemo/modest-main-window.c: (connect_signals):
412 Actually connect ot the ModestAccountStore::request-password signal,
413 so that we show the dialog when the password is requested by Tinymail,
414 for isntance if it is empty.
416 * src/modest-marshal.list:
417 * src/modest-tny-account-store.c:
418 (modest_tny_account_store_class_init), (get_password),
419 (modest_tny_account_store_alert):
420 * src/modest-tny-account-store.h:
421 * src/modest-ui-actions.h:
422 * src/modest-ui-actions.c:
423 (modest_ui_actions_on_password_requested):
424 Change the signal parameters, so it is obvious that we are providing
425 the non human-readable server name, and receiving both the username
426 and password, though changing of the username is not yet implemented.
427 Change the dialog UI to match the Maemo UI specifications, with #idfefing
428 for the GNOME version.
430 This should fix the projects.maemo.org bug NB#56209, though it does not
431 work on Bora, because the gconf_client_get() for the password fails
432 immediately after we save it with gconf_client_set().
434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
437 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
438 caused an undefined symbol error:
439 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
441 2007-05-08 Murray Cumming <murrayc@murrayc.com>
443 * src/modest-tny-account-store.c:
444 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
445 using a GError instead of a string message, so we can translate it in
448 2007-05-08 Murray Cumming <murrayc@murrayc.com>
450 * src/maemo/modest-address-book.c:
451 (modest_address_book_check_names):
452 * src/maemo/modest-msg-view-window.c:
453 (modest_msg_view_window_clipboard_owner_change):
454 * src/modest-init.c: (modest_init_init_ui):
455 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
456 (update_folders_cb), (modest_mail_operation_update_account):
457 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
458 (modest_ui_actions_on_msg_attachment_clicked),
459 (modest_ui_actions_on_msg_recpt_activated):
460 * src/widgets/modest-header-view.c: (drag_data_get_cb):
461 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
462 (modest_msg_view_search_next):
463 * src/widgets/modest-recpt-editor.c:
464 (modest_recpt_editor_on_button_release_event),
465 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
466 g_message(). At this point we should only be seeing interesting errors on
467 stdout. Debugging messages could be #ifdefed-out if they are still useful.
469 2007-05-07 Murray Cumming <murrayc@murrayc.com>
471 (modest_wizard_dialog_force_title_update):
472 * src/maemo/easysetup/modest-wizard-dialog.h:
473 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
474 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
475 can update the title when appropriate. Otherwise the title is wrong if the
476 pages are added after adding the notebook to the dialog.
477 This must be a problem in HildonWizardDialog too.
478 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
480 * src/maemo/easysetup/modest-easysetup-wizard.c:
481 (create_subsequent_customsetup_pages),
482 (create_subsequent_easysetup_pages):
483 Call modest_wizard_dialog_force_title_update() so that the title is
484 correct even with GTK+ < 2.10.
485 This fixes projects.maemo.org bug NB#56145 .
487 2007-05-07 Murray Cumming <murrayc@murrayc.com>
489 * src/maemo/modest-platform.c:
490 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
491 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
494 2007-05-07 Murray Cumming <murrayc@murrayc.com>
496 * src/widgets/modest-window.h:
497 * src/widgets/modest-window.c: Added a save_state_func vfunc,
498 and modest_window_save_state(), which invokes it.
500 * src/widgets/modest-window-mgr.h:
501 * src/widgets/modest-window-mgr.c:
502 Added modest_window_mgr_save_state_for_all_windows(), which calls
503 the save_state vfunc on all registered windows, if implemented.
505 * src/gnome/modest-msg-edit-window.c:
506 * src/gnome/modest-msg-view-window.c:
507 * src/maemo/modest-msg-edit-window.c:
508 * src/maemo/modest-msg-view-window.c:
509 * src/maemo/modest-main-window.c:
510 Specify the existing save_settings functions as implementations of
511 ModestWindow::save_state_func().
513 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
514 Call modest_window_mgr_save_state_for_all_windows(). This happens before
515 enabling hibernation, for instance.
517 We may need to do the same thing for restoring settings.
520 2007-05-07 Murray Cumming <murrayc@murrayc.com>
522 * src/widgets/modest-window-mgr.c:
523 * src/widgets/modest-window-mgr.h:
524 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
525 modest_window_mgr_get_hibernation_is_prevented().
527 * src/maemo/modest-main-window.c:
528 (on_hildon_program_is_topmost_notify): Prevent hibernation
529 (possible when the application goes to the background in the WM),
530 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
532 * src/maemo/easysetup/modest-easysetup-wizard.c:
533 (modest_easysetup_wizard_dialog_init):
534 * src/maemo/modest-account-settings-dialog.c:
535 (modest_account_settings_dialog_init):
536 * src/maemo/modest-connection-specific-smtp-edit-window.c:
537 (modest_connection_specific_smtp_edit_window_init):
538 * src/maemo/modest-connection-specific-smtp-window.c:
539 (modest_connection_specific_smtp_window_init):
540 * src/maemo/modest-signature-editor-dialog.c:
541 (modest_signature_editor_dialog_init):
542 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
543 prevent hibernation while any of these account settings dialogs are open.
545 2007-05-04 Murray Cumming <murrayc@murrayc.com>
547 * src/maemo/Makefile.am:
548 * src/maemo/modest-osso-state-saving.c:
549 * src/maemo/modest-osso-state-saving.h: Added
550 modest_osso_load_state() and modest_osso_save_state() though they do
551 nothing now. They should iterate through all the open windows and load/save
553 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
554 save state when closing.
556 * src/maemo/modest-main-window.c:
557 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
558 Add a notification handler for the HildonProgram::is-topmost property,
559 so we can allow hibernation when the application goes into the background.
560 But we still need to detect when the accounts setup windows are open so
561 we can stop hibernation when they are open.
562 To do this, I also added the main window the HildonProgram. This might have
563 other side-effects/benefits, and should maybe be done for other windows.
565 * src/maemo/modest-osso-autosave-callbacks.h:
566 * src/maemo/modest-osso-autosave-callbacks.c:
567 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
568 though it does not do anything yet, and we might never need this to do
569 anything. For instance, we already save drafts.
571 * src/maemo/modest-platform.c: (modest_platform_init):
572 Specify the libosso auto-save callback.
574 2007-05-03 Murray Cumming <murrayc@murrayc.com>
576 * src/maemo/modest-platform.c:
577 (modest_platform_set_update_interval):
578 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
579 aparently stays valid between application instances, so we can use this
580 to remove and reset it later. According to a maemo-developers email from
583 2007-05-03 Murray Cumming <murrayc@murrayc.com>
585 * configure.ac: Depend on libalarm for Maemo.
587 * src/dbus_api/modest-dbus-api.h:
588 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
589 (on_send_receive), (modest_dbus_req_handler):
590 Handle a SEND_RECEIVE D-Bus method.
592 * libmodest-dbus-client/libmodest-dbus-client.c:
593 (libmodest_dbus_client_send_and_receive):
594 * libmodest-dbus-client/libmodest-dbus-client.h:
595 Add C convenience functions for calling the new D-Bus method.
597 * src/modest-platform.h:
598 * src/gnome/modest-platform.c:
599 * src/maemo/modest-platform.c:
600 Added modest_platform_set_update_interval(), which uses the
602 (modest_platform_init),
603 Call modest_platform_set_update_interval(), using a hard-coded
604 interval for now (until the global settings dialog is implemented),
605 though I am not sure that this makes sense yet.
607 2007-05-02 Murray Cumming <murrayc@murrayc.com>
609 * src/dbus_api/modest-dbus-callbacks.c:
610 (modest_osso_cb_hw_state_handler):
611 * src/dbus_api/modest-dbus-callbacks.h:
612 * src/maemo/modest-platform.c: (modest_platform_init):
613 Registered (empty) callbacks for the osso hardware state D-Bus signals,
614 in case this has some effect on the ability for Maemo to ping the
617 2007-05-02 Murray Cumming <murrayc@murrayc.com>
619 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
620 Comment out an if() that checks a gchar for < 0, causing a build-breaking
621 warning. It is probably a logic error, but I need to fix the build.
623 2007-05-02 Murray Cumming <murrayc@murrayc.com>
625 * src/modest-account-mgr.h:
626 * src/modest-account-mgr.c:
627 (modest_account_mgr_account_names): Add a gboolean enabled_only
628 parameter, so we can get lists of onlt the enabled accounts.
630 (modest_account_mgr_add_account),,
631 (modest_account_mgr_account_with_display_name_exists):
632 * src/maemo/modest-msg-edit-window.c: (get_transports):
633 * src/modest-account-mgr-helpers.c:
634 (modest_account_mgr_set_first_account_as_default):
635 * src/modest-init.c: (init_default_account_maybe):
636 * src/modest-tny-account-store.c: (get_accounts):
637 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
638 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
639 * tests/check_account-mgr.c: (START_TEST):
640 Provide the extra parameter, as appropriate.
642 * src/widgets/modest-account-view.c: (update_account_view):
643 Do not show disabled accounts (meaning that there is no way to
644 enable/disable accounts in the UI (the feature is not in our UI
645 specification), so we can use this internally only to mark unfinished
646 or temporary account data.
648 * src/maemo/easysetup/modest-easysetup-wizard.c:
649 (create_account): Add boolean enable parameter, so we can specify FALSE
650 to create the temporary account.
651 (on_button_edit_advanced_settings): Create the temporary account as disabled.
652 (on_before_next): When finishing, when there is a temporary account, just
654 Also, use a timeout to delay the showing of the dialog until gconf is likely
655 to return correct information, due to a maemo gconf bug that is fixed in
656 osso 1.1, but not yet in Bora.
657 However, the dialog stays on screen after it is destroyed.
659 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
660 for invalid data when cancelling. Use a hildon note instead of a dialog
661 to complain about invalid data. Do not show the account-saved note if the
662 account is disabled (a temporary account that will not really be saved for use
665 2007-04-30 Murray Cumming <murrayc@murrayc.com>
667 * src/modest-account-mgr-helpers.h:
668 * src/modest-account-mgr-helpers.c:
669 Added modest_account_mgr_unset_default_account(),
670 Added modest_account_mgr_set_first_account_as_default().
672 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
673 If it was the default account, unset the default account name.
675 * src/maemo/modest-account-view-window.c:
676 (on_delete_button_clicked): If it was the default account,
677 set the first remaining account as the default instead.
679 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
680 a NULL account or a NULL default account, to prevent a crash. This should
681 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
684 2007-04-30 Murray Cumming <murrayc@murrayc.com>
686 * src/widgets/modest-recpt-editor.c:
687 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
688 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
689 TODO comment for this. This fixes the build.
691 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
692 be the best place for it. This will in future update all auto-update accounts,
693 rather than just the current/default account, when that gconf key exists.
694 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
695 if there are no accounts, before calling do_send_receive().
696 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
698 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
699 * src/maemo/modest-main-window-ui.h:
700 * src/maemo/modest-main-window.c: (on_connection_changed),
701 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
702 directly, becaue the signal handler does more.
704 2007-04-30 Murray Cumming <murrayc@murrayc.com>
706 * src/modest-account-mgr-helpers.c:
707 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
708 for the case that the account does not exist.
710 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
711 (equivalent to the modest account name) rather than the tinymail account name
712 (equivalent to the modest account title - human readable) to get the account data.
713 Check for null account data to prevent the crash, and add a TODO comment saying that
714 this needs fixing because it is using the server account name instead of the account name.
716 2007-04-29 Murray Cumming <murrayc@murrayc.com>
718 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
719 * src/maemo/modest-account-settings-dialog.c: (show_error),
721 Use hildon_note_new_information() for informative and error messages,
722 which seems to be expected for Maemo applications (no documentation that I know of
723 says this). I am surprised that there is no distinction between info and error
726 2007-04-29 Murray Cumming <murrayc@murrayc.com>
728 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
729 it is easy to find where this is used.
731 * src/maemo/easysetup/modest-easysetup-wizard.c:
732 (create_page_welcome), (create_page_account_details),
733 (create_page_user_details), (create_page_complete_easysetup),
734 (create_page_custom_incoming), (create_page_custom_outgoing),
735 (create_page_complete_custom):
736 * src/maemo/modest-account-settings-dialog.c:
737 (create_page_account_details), (create_page_user_details),
738 (create_page_incoming), (create_page_outgoing):
739 * src/maemo/modest-account-view-window.c: (window_vbox_new):
740 * src/maemo/modest-connection-specific-smtp-edit-window.c:
741 (modest_connection_specific_smtp_edit_window_init):
742 * src/maemo/modest-connection-specific-smtp-window.c:
743 (modest_connection_specific_smtp_window_init):
744 * src/maemo/modest-signature-editor-dialog.c:
745 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
746 and scrolling policy as per the Email Application Layout Guide, if I have
749 2007-04-27 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
752 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
753 which were empty, because these vfuncs have been removed from TnyAccountStore.
754 This fixes the build.
756 2007-04-27 Murray Cumming <murrayc@murrayc.com>
758 * src/maemo/modest-main-window.c:
759 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
760 showing/hiding it. Added TODO because it probably should not be NULL.
761 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
762 because unnecessary g_warnings() make degugging difficult.
764 2007-04-27 Murray Cumming <murrayc@murrayc.com>
766 * src/maemo/modest-msg-edit-window.c:
767 (modest_msg_edit_window_select_color),
768 (modest_msg_edit_window_select_background_color): 2 const corrections and
769 moving 2 #endifs before closing brackets, to fix the build.
771 2007-04-27 Murray Cumming <murrayc@murrayc.com>
773 * src/maemo/easysetup/modest-easysetup-wizard.h:
774 * src/maemo/easysetup/modest-easysetup-wizard.c:
775 (modest_easysetup_wizard_dialog_finalize),
776 (on_button_edit_advanced_settings), (create_page_complete_custom),
777 (on_response), (create_account):
778 Implement the Advanced Settings edit button, by saving the account information,
779 for the Advanded Settings dialog to use directly from gconf, and removing it
780 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
781 Bug #5533 in the projects.maemo.org bugzilla.
783 2007-04-27 Murray Cumming <murrayc@murrayc.com>
785 * src/maemo/modest-msg-view-window.c:
786 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
787 when opening a message window.
789 2007-04-27 Murray Cumming <murrayc@murrayc.com>
791 * src/maemo/easysetup/modest-easysetup-wizard.c:
792 (create_page_custom_outgoing): Correct the position of the horizontal separator to
795 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
796 before showing/hiding them, to avoid a crash when clicking on folders when there are no
797 gconf settings. I probably added more checks than necessary, but that is safer.
799 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
800 variable to fix the build, but this seems to be used when it is still NULL.
802 2007-04-27 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-platform.h:
805 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
806 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
807 * src/modest-main.c: Implement this function so we can avoid using
808 maemo-specific API from cross-platform code.
810 * src/modest-tny-account-store.c:
811 (get_smtp_specific_transport_account_for_open_connection):
812 * src/modest-ui-actions.c: (check_for_connection),
813 (modest_ui_actions_on_item_not_found):
814 Use modest_platform_connect_and_wait() and put #idefs around other
815 maemo-specific code, because only maemo currently has a way to
816 identify connection names.
818 2007-04-27 Murray Cumming <murrayc@murrayc.com>
820 * src/modest-tny-account-store.h:
821 * src/modest-tny-account-store.c:
822 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
823 the connection-specific SMTP server settings in the configuration.
825 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
827 * src/maemo/modest-main-window.c: (on_connection_changed),
829 * src/modest-main.c: (main), (start_ui), (send_mail):
830 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
831 that is what is intended.
833 * src/modest-ui-actions.c: (action_send), (action_receive),
834 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
835 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
836 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
837 SMTP server is used when it is specified.
839 (modest_ui_actions_on_send_receive):
840 Check that a connection is open before proceeding.
841 Receive and then send, instead of vice-versa, as per the specification.
843 2007-04-26 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-mail-operation.c:
846 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
847 though I guess it should be something other than NULL.
849 2007-04-26 Murray Cumming <murrayc@murrayc.com>
851 * src/maemo/easysetup/modest-easysetup-wizard.c:
852 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
853 combo twice, to avoid an g_warning and to make it visible again.
854 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
855 attached before detaching it, to avoid a g_warning, and add comment about the implicit
856 (already intended) dereference when detaching, because we then recreate the menu.
857 But I am not sure why the warning was happening, and it is possible that this is a memory
860 2007-04-25 Murray Cumming <murrayc@murrayc.com>
862 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
863 and uri_parse_mailto() utility functions.
864 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
866 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
868 2007-04-24 Murray Cumming <murrayc@murrayc.com>
870 * src/dbus_api/modest-dbus-api.h:
871 * src/dbus_api/modest-dbus-callbacks.c:
872 Use an idle callback to execute the modest code in the application's own thread.
873 Remove the helloworld example method.
874 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
875 parsed, and the open-message method is not implemented because this is not yet implemented in
877 * libmodest-dbus-client/libmodest-dbus-client.c:
878 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
879 (libmodest_dbus_client_open_message):
880 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
882 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
883 body without crashing.
885 * tests/dbus_api/Makefile.am:
886 * tests/dbus_api/test_mail_to.c:
887 * tests/dbus_api/test_open_message.c: New tests for the new methods.
889 2007-04-24 Murray Cumming <murrayc@murrayc.com>
891 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
892 Added file to fix the build. Sorry.
894 * src/dbus_api/Makefile.am:
895 * src/dbus_api/modest-dbus-api.h:
896 * src/dbus_api/modest-dbus-callbacks.h:
897 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
898 (modest_dbus_req_handler):
899 Put constants in a separate header so it can be reused by the
900 client library, without duplication
902 * libmodest-dbus-client/Makefile.am:
903 * libmodest-dbus-client/libmodest-dbus-client.c:
904 (libmodest_dbus_client_call_helloworld),
905 (libmodfest_dbus_client_send_mail),
906 (libmodfest_dbus_client_mailto),
907 (libmodfest_dbus_client_open_message):
908 * libmodest-dbus-client/libmodest-dbus-client.h:
909 (Partly) Implement a send_mail D-Bus method.
911 * tests/dbus_api/Makefile.am:
912 * tests/dbus_api/test_send_mail.c: (main): Added a test for
913 the send_email D-Bus method.
915 2007-04-24 Murray Cumming <murrayc@murrayc.com>
919 * libmodest-dbus-client/Makefile.am:
920 * libmodest-dbus-client/libmodest-dbus-client.c:
921 * libmodest-dbus-client/libmodest-dbus-client.h:
922 * tests/dbus_api/Makefile.am:
923 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
924 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
926 2007-04-24 Murray Cumming <murrayc@murrayc.com>
928 * src/maemo/easysetup/modest-easysetup-wizard.c:
929 (create_page_account_details):
930 * src/maemo/modest-account-settings-dialog.c:
931 (create_page_account_details): Explicitly set auto-capitalization mode for the title
932 widgets, because this might not be the default in future versions of the Maemo GTK+.
933 However, I can not not get capitalization to work even in a simple test case.
935 2007-04-24 Murray Cumming <murrayc@murrayc.com>
937 * src/maemo/easysetup/modest-easysetup-wizard.c:
938 (create_page_custom_incoming), (create_page_custom_outgoing):
939 * src/maemo/modest-account-settings-dialog.c:
940 (create_page_account_details), (create_page_incoming),
941 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
942 instead of using gtk_check_button_with_label(), so they are aligned like the other
943 widgets, as per the UI spec.
945 2007-04-24 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/easysetup/modest-easysetup-wizard.c:
948 * src/maemo/modest-connection-specific-smtp-edit-window.c:
949 * src/widgets/modest-validating-entry.c:
950 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
951 Modest prefix instead of an EasySetup prefix.
953 2007-04-23 Murray Cumming <murrayc@murrayc.com>
955 * src/widgets/modest-validating-entry.h:
956 * src/widgets/modest-validating-entry.c: (on_insert_text),
957 Added easysetup_validating_entry_set_max_func(), used to set a callback
958 to call when the max number of characters is reached. GtkEntry has a max-length
959 already but is silent about it.
961 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
962 (create_page_account_details), (create_page_user_details),
964 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
965 (create_page_account_details), (create_page_user_details),
966 (create_page_outgoing):
967 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
968 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
969 the UI spec, when the user tries to enter more than the max number of characters.
971 2007-04-23 Murray Cumming <murrayc@murrayc.com>
973 * src/maemo/easysetup/modest-easysetup-wizard.c:
974 (create_page_user_details), (create_page_custom_incoming),
975 (create_page_custom_outgoing):
976 * src/maemo/modest-account-settings-dialog.c:
977 (create_page_user_details), (create_page_incoming),
978 (create_page_outgoing):
979 * src/maemo/modest-connection-specific-smtp-edit-window.c:
980 (modest_connection_specific_smtp_edit_window_init):
981 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
982 not appropriate. Bad Maemo-specific defaults!.
984 2007-04-23 Murray Cumming <murrayc@murrayc.com>
986 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
987 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
988 (modest_signature_editor_dialog_set_settings):
989 Disable the label and textview when the checkbox is disabled, and use the
990 specified (UI spec) default signature text.
992 2007-04-23 Murray Cumming <murrayc@murrayc.com>
994 * src/maemo/modest-connection-specific-smtp-edit-window.c:
995 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
998 * src/modest-account-mgr-helpers.h:
999 * src/modest-account-mgr-helpers.c:
1000 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1002 * src/maemo/Makefile.am:
1003 * src/maemo/modest-signature-editor-dialog.c:
1004 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1007 * src/maemo/modest-account-settings-dialog.h:
1008 * src/maemo/modest-account-settings-dialog.c:
1009 (modest_account_settings_dialog_finalize), (on_button_signature),
1010 (save_configuration): Use the new dialog when the Edit button is pressed, and
1011 save the changes if necessary, as per the UI spec.
1013 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1015 * src/maemo/Makefile.am:
1016 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1017 based on maemo-develoers email from Dirk.
1019 * src/maemo/easysetup/modest-easysetup-wizard.c:
1020 (create_page_welcome), (create_page_account_details),
1021 (create_page_user_details), (create_page_complete_easysetup),
1022 (create_page_custom_incoming), (create_page_custom_outgoing),
1023 (create_page_complete_custom),
1024 (modest_easysetup_wizard_dialog_init):
1025 * src/maemo/modest-account-settings-dialog.c:
1026 (create_page_account_details), (create_page_user_details),
1027 (create_page_incoming), (create_page_outgoing),
1028 (modest_account_settings_dialog_init):
1029 * src/maemo/modest-connection-specific-smtp-window.c:
1030 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1032 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1034 * src/maemo/easysetup/modest-easysetup-wizard.c:
1035 (create_page_account_details), (create_page_custom_outgoing),
1036 (create_page_complete_custom):
1037 * src/maemo/modest-account-settings-dialog.c:
1038 (create_page_user_details), (create_page_incoming),
1039 (create_page_outgoing):
1040 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1041 (modest_connection_specific_smtp_edit_window_init):
1042 Use the correct (UI spec) port min/max, and use horizontal separators,
1045 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1047 * src/maemo/easysetup/modest-easysetup-wizard.c:
1048 (set_default_custom_servernames):
1049 * src/maemo/modest-account-settings-dialog.c:
1050 (create_page_incoming), (on_combo_outgoing_security_changed),
1051 (on_combo_incoming_security_changed), (create_page_outgoing),
1052 (modest_account_settings_dialog_set_account_name),
1053 (save_configuration):
1054 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1055 (on_combo_security_changed),
1056 (modest_connection_specific_smtp_edit_window_init),
1057 (modest_connection_specific_smtp_edit_window_set_connection),
1058 (modest_connection_specific_smtp_edit_window_get_settings):
1059 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1062 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1065 * src/maemo/easysetup/modest-easysetup-wizard.c:
1066 (create_page_custom_outgoing), (create_page_complete_custom):
1067 * src/maemo/modest-account-settings-dialog.c:
1068 (create_page_user_details), (create_page_outgoing):
1069 * src/maemo/modest-account-view-window.c: (button_box_new):
1070 Use changed logical IDs as per the most recent UI spec:
1071 mcen_bd_emailsetup_edit -> mcen_bd_edit
1072 mcen_bd_emailsetup_delete -> mcen_bd_delete
1073 mcen_bd_emailsetup_close -> mcen_bd_close
1075 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1079 * src/dbus_api/Makefile.am:
1080 * src/dbus_api/modest-dbus-callbacks.c:
1081 * src/dbus_api/modest-dbus-callbacks.h:
1082 * src/maemo/modest-platform.c: (modest_platform_init):
1083 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1085 * tests/Makefile.am:
1086 * tests/dbus_api/Makefile.am:
1087 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1089 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/modest-account-settings-dialog.c:
1092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1093 Removed unnecessary includes.
1095 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1097 * src/maemo/easysetup/modest-easysetup-wizard.c:
1098 * src/maemo/modest-account-settings-dialog.c:
1099 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1100 * src/widgets/Makefile.am:
1101 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1102 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1103 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1104 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1105 * src/widgets/modest-secureauth-combo-box.c:
1106 * src/widgets/modest-secureauth-combo-box.h:
1107 * src/widgets/modest-serversecurity-combo-box.c:
1108 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1109 made the GObject names more consistent with the rest of the Modest code.
1111 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1113 * src/maemo/easysetup/Makefile.am:
1114 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1115 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1116 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1117 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1118 * src/maemo/easysetup/modest-easysetup-wizard.c:
1119 * src/maemo/easysetup/modest-validating-entry.c:
1120 * src/maemo/easysetup/modest-validating-entry.h:
1121 * src/maemo/modest-account-settings-dialog.c:
1122 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1123 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1124 widgets/ because they are used outside of easysetup too. After checking in,
1125 svn will allow me to rename them too.
1127 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1129 * src/gnome/modest-msg-edit-window.c:
1130 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1131 linker error, to fix the build on the GNOME platform.
1132 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1133 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1134 ifdefed out to avoid a warning.
1136 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1138 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1139 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1140 some alternative for GTK+ 2.6.
1142 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1144 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1146 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1147 specified for EmailAccountsDialog in UI spec.
1149 * src/maemo/easysetup/modest-easysetup-wizard.c:
1150 * src/maemo/easysetup/modest-easysetup-wizard.h:
1151 * src/maemo/modest-account-settings-dialog.c:
1152 * src/maemo/modest-account-settings-dialog.h:
1153 Reuse a member window widget for the connection-specific SMTP server accounts,
1154 so we can tell it to create/save the accounts only if we actually save changes.
1156 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1157 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1158 (modest_connection_specific_smtp_edit_window_get_settings):
1159 Return a struct instance for temporarily remembering the entered data.
1161 * src/maemo/modest-connection-specific-smtp-window.h:
1162 * src/maemo/modest-connection-specific-smtp-window.c:
1163 (modest_connection_specific_smtp_window_finalize),
1164 (modest_connection_specific_smtp_window_fill_with_connections),
1166 (modest_connection_specific_smtp_window_save_server_accounts),
1167 (update_model_server_names): Do not actually save data until asked,
1168 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1170 (on_selection_changed),
1171 (modest_connection_specific_smtp_window_init): Disable the edit
1172 button when nothing is selected.
1174 * src/modest-account-mgr-helpers.c:
1175 * src/modest-account-mgr-helpers.h:
1176 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1179 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1181 * src/modest-account-mgr-helpers.h:
1182 * src/modest-account-mgr-helpers.c:
1183 (modest_account_mgr_get_unused_account_name),
1184 (modest_account_mgr_get_unused_account_display_name): Added these
1185 utility functions, to avoid code duplication.
1187 * src/maemo/easysetup/modest-easysetup-wizard.c:
1188 (create_page_account_details), (create_account):
1189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1190 (on_combo_security_changed),
1191 (modest_connection_specific_smtp_edit_window_init),
1192 (modest_connection_specific_smtp_edit_window_save_settings):
1193 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1194 * src/maemo/modest-connection-specific-smtp-window.c:
1195 (modest_connection_specific_smtp_window_finalize),
1196 (modest_connection_specific_smtp_window_fill_with_connections),
1197 (on_button_edit), (modest_connection_specific_smtp_window_init):
1198 * src/maemo/modest-connection-specific-smtp-window.h:
1199 Implementing saving of connection-specific server accounts.
1201 But I need to refactor this so we can save the data for each
1202 possible connection-specific account and only actually create the server accounts
1203 when the easysetup finished, or the OK button is pressed on the account settings
1206 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1209 (on_combo_security_changed):
1210 (modest_connection_specific_smtp_edit_window_init):
1211 Auto-fill the port number as in the account settings.
1213 (modest_connection_specific_smtp_edit_window_set_connection):
1214 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1215 * src/maemo/modest-connection-specific-smtp-window.c:
1216 (fill_with_connections), (on_button_edit),
1217 (modest_connection_specific_smtp_window_init):
1218 Turn the edit window into a dialog to simplify the code, and
1219 set a WM hint as in a GtkDialog, because only a popup can be on top of
1220 another window in Maemo, and popups usually have no WM decoration.
1222 * src/modest-defs.h:
1223 * src/modest-account-mgr-helpers.c:
1224 (modest_account_mgr_set_connection_specific_smtp),
1225 (modest_account_mgr_remove_connection_specific_smtp),
1226 (modest_account_mgr_get_connection_specific_smtp):
1227 * src/modest-account-mgr-helpers.h: Some functions to write the
1228 connection-specific SMTP server information. Not yet used.
1231 * src/widgets/modest-folder-view.c: (text_cell_data):
1232 Fix a warning about an uninitialized variable.
1233 (on_configuration_key_changed): Put an #ifdef around the use
1234 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1236 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1238 * src/maemo/modest-account-settings-dialog.h:
1239 * src/maemo/modest-account-settings-dialog.c:
1240 Added connect_for_modified() utility function to mark the new modified boolean.
1242 (create_page_account_details), (create_page_user_details),
1243 (create_page_incoming), (create_page_outgoing), (on_response),
1244 (modest_account_settings_dialog_init),
1245 (modest_account_settings_dialog_set_account_name):
1246 Only warn about unsaved changes when there are actually unsaved changes.
1248 * src/modest-account-mgr-helpers.c:
1249 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1250 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1251 to get the data from there in future.
1253 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1255 * src/modest-defs.h:
1257 * src/modest-account-mgr-helpers.h:
1258 * src/modest-account-mgr-helpers.c:
1259 Store the security account setting in a single conf key instead of using
1260 the options list, so that the list is left for just the to-be-removed camel hack,
1261 and because gconf_client_set_list() is failing for some reason.
1263 * src/modest-account-mgr.c:
1264 (modest_account_mgr_add_server_account):
1265 * src/maemo/modest-account-settings-dialog.c:
1266 (modest_account_settings_dialog_set_account_name),
1267 (save_configuration): Use the renamed functions.
1270 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1272 * src/widgets/Makefile.am:
1273 * src/widgets/modest-limit-retrieve-combo-box.c:
1274 * src/widgets/modest-limit-retrieve-combo-box.h:
1275 * src/widgets/modest-retrieve-combo-box.c:
1276 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1277 the account settings dialog.
1279 * src/modest-defs.h:
1280 * src/modest-account-mgr-helpers.h:
1281 * src/modest-account-mgr-helpers.c:
1282 (modest_server_account_get_option_secure_auth),
1283 (modest_server_account_set_option_secure_auth):
1284 * src/modest-account-mgr.c:
1285 (modest_account_mgr_add_server_account):
1286 Use the existing AUTH_MECH conf key for the secure-auth setting,
1287 instead of putting it in the list options, because this was actually used already.
1289 * src/maemo/modest-account-settings-dialog.c:
1290 (create_page_account_details),
1291 (modest_account_settings_dialog_set_account_name),
1292 (save_configuration):
1293 * src/maemo/modest-account-settings-dialog.h:
1294 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1295 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1297 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1299 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1300 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1301 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1303 * src/modest-defs.h:
1304 * src/maemo/modest-account-settings-dialog.c:
1305 (create_page_incoming), (on_combo_outgoing_security_changed),
1306 (on_combo_incoming_security_changed), (create_page_outgoing),
1307 (modest_account_settings_dialog_set_account_name),
1308 (save_configuration): Load/Save the port number, and change it when the
1309 security combo changes, to suitable defaults.
1311 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-account-mgr.c:
1314 (modest_account_mgr_add_server_account): Set the security and secure-auth
1315 options, and add a comment saying that the other camel-specific options should be
1318 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1322 * src/modest-tny-account-store.c: (account_list_free),
1323 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1324 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1327 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-protocol-info.c:
1330 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1331 is required by our UI spec. Maybe something in our implementation will use this eventually.
1332 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1333 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1334 instead of the previous 0 placeholder.
1336 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1337 secure-auth settings.
1338 * src/modest-account-mgr-helpers.h:
1339 * src/modest-account-mgr-helpers.c:
1340 (modest_server_account_data_get_option_secure_auth),
1341 (modest_server_account_set_option_secure_auth),
1342 (modest_server_account_data_get_option_security),
1343 (modest_server_account_set_option_security): Added this API for getting and setting the security
1344 and secure-auth settings.
1346 * src/maemo/modest-account-settings-dialog.h:
1347 * src/maemo/modest-account-settings-dialog.c:
1348 (modest_account_settings_dialog_finalize), (check_data),
1349 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1350 about changing titles.
1351 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1352 (save_configuration): Save the security and secure-auth settings.
1354 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1355 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1357 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1359 * src/modest-defs.h:
1360 * src/modest-account-mgr.c:
1361 (modest_account_mgr_add_server_account):
1362 Added and used defines for the options key and value pair strings,
1363 that are used so far, though they do not seem to correspond to anything in our
1364 UI specs or ModestProtocol enum.
1366 * src/modest-account-mgr-helpers.h:
1367 * src/modest-account-mgr-helpers.c:
1368 (compare_option_strings_for_name),
1369 (modest_server_account_data_get_option_value),
1370 (modest_server_account_data_get_option_bool),
1371 (modest_account_mgr_get_server_account_option):
1372 Added helper functions for parsing the options GSList.
1374 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1377 display name is based on the supplied account name.
1378 * src/modest-account-mgr.c:
1379 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1380 with an inefficient, but good-enough, implementation.
1382 * src/maemo/easysetup/modest-easysetup-wizard.c:
1383 (create_page_account_details), (on_before_next), (create_account):
1384 Check for existing display names rather than (non-user-visible) account names, and just
1385 create and set a unique account name at the end.
1387 * src/maemo/modest-account-settings-dialog.c:
1388 (modest_account_settings_dialog_init),
1389 (modest_account_settings_dialog_set_account_name),
1390 (create_page_incoming): Show the display name, instead of the account name.
1391 (on_response): Do some (not all) extra checks, as in the UI spec.
1392 (save_configuration): Save the display name if it was changed.
1394 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1396 * po/en_GB.po: Added needed logical ID and translation.
1397 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1398 (init_view): Made the is-default column clicking work.
1400 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/easysetup/Makefile.am:
1404 * src/maemo/easysetup/modest-easysetup-wizard.c:
1405 (modest_easysetup_wizard_dialog_init):
1406 * src/maemo/easysetup/provider-data-test.keyfile:
1407 * src/maemo/easysetup/provider-data.keyfile:
1408 Moved the provider data file to the new modest-providers-data package and used it from there.
1410 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-local-folder-info.c:
1413 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1414 N_() was already used on the static strings, but this just marks it for translation without
1415 using the translation.
1417 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1419 * src/maemo/modest-account-settings-dialog.c:
1420 (create_page_incoming),
1421 (modest_account_settings_dialog_set_account_name):
1422 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1423 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1424 I will do this if nobody else gets there first.
1426 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1428 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1429 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1430 save the security stuff.
1432 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1434 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1435 Set the email address and user fullname, which I now see must be
1438 * src/maemo/modest-account-settings-dialog.h:
1439 * src/maemo/modest-account-settings-dialog.c:
1441 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1442 leave-on-server and authentication.
1443 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1446 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1449 * src/maemo/modest-account-settings-dialog.c:
1450 * src/maemo/modest-account-settings-dialog.h:
1451 Most (but not all) of the widgets are now present as specified by the UI spec.
1452 No changes are yet saved, and some details are not properly shown yet.
1454 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1456 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/Makefile.am:
1459 * src/maemo/modest-account-settings-dialog.c:
1460 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1461 an existing account. Doesn't do much yet.
1463 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1464 Open the accounts settings dialog when Edit is clicked.
1466 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1468 * src/maemo/easysetup/Makefile.am:
1469 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1471 * src/maemo/easysetup/modest-easysetup-wizard.c:
1472 (modest_easysetup_wizard_dialog_init):
1473 Try to get the source directory from the build system,
1474 instead of hard-coding "./" into the source code, when opening our local
1475 copies of the configuration files.
1476 But this still fails when opening the wizard from the Accounts window,
1477 maybe because the working directory seems to change at runtime.
1478 So the wizard will fail the second time unless you copy the files into their
1479 proper locations - see the stdout warnings for the paths.
1481 (create_page_account_details),(on_before_next):
1482 Check for existing non-server accounts instead of server accounts,
1483 so the default account name is useful again, and to prevent trying to
1486 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1487 Show the wizard when New is clicked.
1489 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1490 (init_view): Show the column headers, and show the columns that are
1491 specified in the UI specs. However, something in Maemo's GTK+ prevents
1492 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1493 change the default account. This is despite unsetting the special properties.
1495 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1497 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1498 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1499 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1500 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1501 to make that clearer.
1502 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1504 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1506 * src/maemo/modest-account-view-window.c:
1507 (modest_account_view_window_init),
1508 (modest_account_view_window_new):
1509 Use the same buttons as specified in the
1510 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1511 the existing widgets, which never had a chance of working.
1512 Put the ModestAccountView treeview in a scrolled window.
1513 Do not repeat the initialization in both _init() and _new().
1515 * src/widgets/modest-account-view.c: (update_account_view):
1516 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1517 this widget and window shows no accounts.
1519 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1521 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1523 * src/maemo/easysetup/modest-easysetup-wizard.c:
1524 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1525 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1526 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1529 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1530 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1531 accounts exist yet, as in the UI spec.
1533 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1535 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/Makefile.am:
1538 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1539 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1540 New window for editing connection-specific smtp details.
1541 Not fully implemented.
1543 * src/maemo/modest-connection-specific-smtp-window.c:
1544 (modest_connection_specific_smtp_window_finalize) :
1545 unref the tree model.
1546 (on_button_edit): Show the edit window.
1548 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1550 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1553 * src/maemo/Makefile.am:
1554 * src/maemo/modest-connection-specific-smtp-window.c:
1555 * src/maemo/modest-connection-specific-smtp-window.h:
1556 New window for showing the list of connections, for connection-specific
1557 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1558 * src/maemo/easysetup/modest-easysetup-wizard.c:
1559 (create_page_custom_outgoing): Show the new window when the button is clicked.
1561 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1563 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1564 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1565 * src/maemo/modest-msg-edit-window.c:
1566 (modest_msg_edit_window_insert_image):
1567 * src/modest-conf.c: (modest_conf_key_escape):
1568 * src/modest-mail-operation.c:
1569 (modest_mail_operation_send_new_mail):
1570 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1571 (modest_ui_actions_on_new_account):
1572 * src/widgets/modest-attachment-view.c: (update_filename_request):
1573 * src/widgets/modest-mail-header-view.c:
1574 Corrected warnings that were breaking the build, by commenting out unused variables,
1575 and a function, and by including a header.
1577 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1579 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1580 so we can #ifdef around platform-specific code when necessary.
1581 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1582 to allow this to build for the GNOME platform too.
1584 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/easysetup/modest-easysetup-wizard.c:
1587 Added util_increment_name() and used it in create_page_account_details()
1588 to make sure that the default account name is always a new name.
1590 (modest_easysetup_wizard_dialog_init),
1591 (set_default_custom_servernames): Some minor memory management fixes.
1593 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-runtime.c: (init_i18n): Restored the translation
1598 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1599 are defined in config.h, and the translations are installed.
1601 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1602 is defined for translation.
1604 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1608 * src/maemo/easysetup/modest-easysetup-wizard.c:
1609 (modest_easysetup_wizard_dialog_init):
1610 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1611 Use realistic paths (though they should use $prefix generically) to the
1612 mcc_mapping and provider-data.keyfile files which might work when they
1613 are installed by the future version of the operator-wizard package,
1614 and then fallback to paths in our source code, with an explanatory
1617 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1621 * src/maemo/Makefile.am:
1622 * src/maemo/easysetup/: Added files from the previously-exernal
1623 osso-modest-easysetup.
1624 * src/maemo/modest-main-window-ui.h:
1625 * src/modest-ui-actions.c:
1626 * src/modest-ui-actions.h:
1627 Added modest_ui_actions_on_new_account() as a signal handler for the
1628 New Account menu item. It shows the easysetup wizard.
1629 * po/en_GB.po: Added additional needed logical IDs and translations.
1631 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1632 Apparently ChangeLog is not used for some vague Nokia legal reasons.