1 2007-06-22 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (get_password):
4 Remove the call to tny_account_set_user() because this actually crashes.
5 As mentioned in the last commit, it is known to not work anyway.
7 2007-06-22 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c: (get_password):
10 Use tny_account_set_username() to tell tinymail that the username might
11 have changed too. But tinymail ignores this: see projects.maemo.org
13 * src/modest-ui-actions.c:
14 (modest_ui_actions_on_password_requested): Remove the useless attempt to
15 reset the connection when changing the username, and improve the comments.
16 Save the changed username to gconf at least, so it is used when Modest is
19 2007-06-21 Murray Cumming <murrayc@murrayc.com>
21 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
22 Do not use a query, so that we get all folders, including for POP and
23 local-folders. They work as search criteria too.
24 This fixes projects.maemo.org bug NB#57740.
26 2007-06-21 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
29 Comment out the use of hildon_notification_set_sound() because it is
30 not declared, to fix the build. Warnings are serious, people.
32 2007-06-21 Armin Burgmeier <armin@openismus.com>
34 * src/maemo/modest-maemo-utils.h:
35 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
36 modest_maemo_utils_get_supported_secure_authentication_methods()
37 to query authentication methods for a specific user. This should fix
38 projects.maemo.org bug NB#61369.
40 * src/maemo/easysetup/modest-easysetup-wizard.c:
41 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
44 2007-06-21 Murray Cumming <murrayc@murrayc.com>
46 * libmodest-dbus-client/libmodest-dbus-client.h:
47 * libmodest-dbus-client/libmodest-dbus-client.c:
48 (modest_dbus_message_iter_get_search_hit),
49 (libmodest_dbus_client_search):
50 Reorganised and commented this.
51 Removed modest_search_hit_free() from the public API because it
54 Added libmodest_dbus_client_get_folders() and
55 modest_folder_result_list_free().
57 * src/dbus_api/modest-dbus-api.h:
58 * src/dbus_api/modest-dbus-callbacks.c:
59 (modest_dbus_req_filter): Commented. Moved most code to
60 on_dbus_method_search() and added on_dbus_method_get_folders().
62 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
63 of the extra D-Bus handler.
65 * tests/dbus_api/Makefile.am:
66 * tests/dbus_api/test_get_folders.c: New test for
67 libmodest_dbus_client_get_folders(). This seems to return an empty list
68 at the moment. That could be the same error that causes the message list
69 to be empty sometimes.
70 This should help with projects.maemo.org bug NB#57740.
72 2007-06-21 Armin Burgmeier <armin@openismus.com>
74 * src/modest-mail-operation.c: Do not call
75 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
76 notify the operation's end after having set the status to CANCELED for
77 the operation queue to listen on. This fixes a deadlock when there
78 were mail operations in the queue during its finalization.
80 * src/modest-singletons.c: Reordered uninitialization of the account
81 manager to happen after the mail operation queue was uninitialized
82 because the mail operation's in the queue might still try to access
83 the account manager (see modest_mail_operation_notify_end()). This
84 fixes a potential crash when terminating the application.
86 2007-06-21 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-search.c:
89 (search_mime_part_and_child_parts): Moved some code here so we
90 can search recursively in child folders.
91 (modest_search_folder): Search in the message as a mime part, instead
92 of just its child mime parts.
93 (read_chunk), (search_mime_part_ogs):
94 Check how many bytes were read, to prevent an endless loop.
95 Searching in message bodies now works. This finishes the fix for
96 projects.maemo.org bug NB#61007.
98 2007-06-20 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
101 Add a g_warning when the item is not a folder.
103 * src/modest-ui-dimming-rules.c:
104 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
105 when selected item is not a folder (for instance, an account), because
106 the UI spec only talks about folders.
107 I am not sure what the UI spec wants, so this might not totally fix
108 projects.maemo.org bug NB#60794.
110 2007-06-20 Murray Cumming <murrayc@murrayc.com>
112 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
113 (load_from_file): Sort the list. The unsorted list would be more noticeable
114 in non-English locales.
116 * src/maemo/modest-msg-edit-window.c:
117 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
118 warning and fix the build.
120 * src/maemo/modest-progress-bar-widget.c:
121 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
122 avoid a g_warning, and probably to avoid a crash.
124 2007-06-20 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-search.c: (modest_search_folder): Check for a GError
127 when calling tny_folder_get_headers(), to show that this is not the cause
130 2007-06-20 Murray Cumming <murrayc@murrayc.com>
132 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
133 Actually set the body query instead of the subject query.
135 * src/modest-search.c: (search_mime_part_ogs),
136 (search_mime_part_strcmp): Remove extra space from the text/* regex,
137 which would probably cause it to fail if we got this far.
139 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
140 to simplify the code.
141 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
142 be causing search-in-body to fail.
144 2007-06-20 Murray Cumming <murrayc@murrayc.com>
146 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
148 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
149 Better debug message when the folder cannot be found.
150 This should help with fixing projects.maemo.org bug #61287.
151 * src/modest-search.c: (add_hit): Do not leak the furl string.
153 2007-06-20 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-ui-actions.c:
156 (modest_ui_actions_on_folder_selection_changed):
157 Do not special-case TNY_MERGE_FOLDER here, because
158 modest_tny_folder_get_account() already does that. This fixes
159 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
160 shown when the Outbox was selected).
162 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
164 * libmodest-dbus-client/libmodest-dbus-client.c:
165 (_dbus_iter_get_string_or_null): Initialize the string variable in
166 case this helps with Dirk's crash.
168 2007-06-19 Murray Cumming <murrayc@murrayc.com>
170 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
171 though it is not implemented yet (this function is maybe not even used),
172 to avoid breaking ABI in future.
173 * libmodest-dbus-client/libmodest-dbus-client.c:
174 (get_attachments_string): Moved some code into this generic function.
175 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
176 sends email. It is maybe not used.
177 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
178 (on_send_mail): Use attachments.
180 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
181 * src/maemo/modest-msg-edit-window.c:
182 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
183 a filename before using it, to fix projects.maemo.org bug NB#58233.
185 2007-06-19 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
188 Initialize the continue_download variable to fix the build, and probably
189 to fix randome behaviour.
191 2007-06-18 Armin Burgmeier <armin@openismus.com>
193 * src/modest-tny-send-queue.h:
194 * src/modest-tny-send-queue.c: Keep track of the status of messages in
195 the queue so we can later show it in the UI. Replaced
196 modest_tny_send_queue_msg_is_being_sent() by
197 modest_tny_send_queue_get_msg_status().
199 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
201 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
202 gpointer. This probably was not harmful, but just to be sure.
204 2007-06-18 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
207 Fix the build, but leave the function broken on Bora, because
208 hildon_uri_action_get_service() does not exist.
209 osso_uri_action_get_service() does not exist either, it seems.
211 2007-06-18 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-tny-account.c:
214 (modest_tny_account_new_from_server_account):
215 Uncommented the url debug output again, because it is useful for
216 debugging, as I said in the comment.
218 2007-06-18 Murray Cumming <murrayc@murrayc.com>
220 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
222 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
223 for Mameo Bora, to fix the build.
225 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
228 Fixed build with hildon < 0.99
230 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
231 Check if the selected account is busy instead of checking all accounts
233 * src/modest-account-mgr-priv.h:
234 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
235 (modest_account_mgr_init), (compare_account_name),
236 (modest_account_mgr_set_account_busy),
237 (modest_account_mgr_account_is_busy):
238 * src/modest-account-mgr.h:
239 Added busy information to the account manager. It possible to
240 set an account to busy or not busy now.
242 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
243 (modest_mail_operation_update_account),
244 (modest_mail_operation_notify_end):
245 Set the account to busy/not busy depending on the operation state.
247 * src/widgets/modest-account-view.c:
248 (modest_account_view_finalize), (get_last_updated_string),
249 (update_account_view), (on_account_busy_changed), (init_view):
250 Show string "Refreshing..." if the account is currently busy.
252 All this fixes projects.maemo.org bug NB#59711
254 2007-06-14 Armin Burgmeier <armin@openismus.com>
256 * src/widgets/modest-attachments-view.h:
257 * src/widgets/modest-attachments-view.c: Added
258 modest_attachments_view_has_attachments() and fixed coordinate
259 transformation in get_att_view_at_coords(). This fixes attachment
262 * src/widgets/modest-msg-view.c: Make use of
263 modest_attachments_view_has_attachments() to decide whether to show
264 attachments in the header.
266 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
268 * src/maemo/modest-connection-specific-smtp-edit-window.c:
269 (on_change), (on_combo_security_changed),
270 (modest_connection_specific_smtp_edit_window_init),
271 (modest_connection_specific_smtp_edit_window_set_connection),
272 (modest_connection_specific_smtp_edit_window_is_dirty):
273 * src/maemo/modest-connection-specific-smtp-edit-window.h:
274 * src/maemo/modest-connection-specific-smtp-window.c:
277 Show an comfirmation dialog for the smpt-edit-window if there are
278 unsaved changes and the user hits cancel.
279 (projects.maemo.org bug NB#60479)
281 2007-06-14 Armin Burgmeier <armin@openismus.com>
283 * src/maemo/easysetup/modest-easysetup-wizard.c:
284 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
285 address" info in banner instead of node, and select all the text as
286 per UI spec. This fixes projects.maemo.org bug NB#60550.
288 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
290 reviewed by: <delete if not using a buddy>
292 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
293 * src/modest-ui-actions.c: (folder_refreshed_cb):
295 2007-06-14 Murray Cumming <murrayc@murrayc.com>
297 * src/widgets/modest-folder-view.c: (filter_row):
298 Explictly filter out the per-account outbox accounts. I don't know why
299 these only sometimes show up, but now they should never show up in the UI.
300 This should fix projects.maemo.org bug NB#60160.
302 2007-06-14 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
305 when the toolbar does not exist yet.
306 * src/modest-widget-memory.c: (save_settings_header_view):
307 Added g_warnings() to help us to discover when we are trying to set
308 an empty columns list in gconf.
310 2007-06-14 Murray Cumming <murrayc@murrayc.com>
314 Added modest_init_get_default_header_view_column_ids().
316 * src/modest-widget-memory.c: (restore_settings_header_view):
317 Use the new function to get defaults, if the gconf key is empty,
318 instead of not creating any columns. This seems to fix the
319 empty right-hand pane problems.
321 * src/widgets/modest-header-view.h: Improved documentation.
323 2007-06-13 Murray Cumming <murrayc@murrayc.com>
325 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
326 Revert the use of the display name as the account name, because this
327 is generally wrong and would break the code that follows.
329 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
331 * src/maemo/easysetup/modest-easysetup-wizard.c:
332 (check_for_supported_auth_methods), (on_before_next),
335 More correct fix for projects.maemo.org bug NB# 58991
336 Do not longer accept AUTH_PASSWORD as secure method and choose
337 correct method when creating the account.
339 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
341 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
342 Fixed projects.maemo.org bug NB# 58991
344 2007-06-13 Murray Cumming <murrayc@murrayc.com>
346 * src/modest-init.c: (modest_init_init_core),
347 (modest_init_local_folders): Fixed compilation errors.
349 2007-06-13 Murray Cumming <murrayc@murrayc.com>
351 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
352 Remove unnecessary lib/include, though it is good in principle when needed.
354 * src/modest-init.c: (modest_init_one_local_folder),
355 (modest_init_local_folders):
356 * src/modest-init.h: Initialize the .modest library for memory cards,
357 instead of just doing nothing for them. This should allow us to create
358 folders there, fixing projects.maemo.org bug NB#59297.
360 2007-06-13 Murray Cumming <murrayc@murrayc.com>
362 * libmodest-dbus-client/libmodest-dbus-client.c:
363 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
364 (libmodest_dbus_client_compose_mail),
365 (libmodest_dbus_client_open_message),
366 (libmodest_dbus_client_send_and_receive),
367 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
369 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
370 (on_idle_open_message), (modest_dbus_req_handler),
371 (search_result_to_message), (modest_dbus_req_filter):
372 * src/modest-search.c: (add_hit), (modest_search_folder),
373 (modest_search_all_accounts): Improved debug messages.
375 * tests/dbus_api/test_open_message.c: (main): Improved comments.
377 * src/modest-tny-account-store.c:
378 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
381 2007-06-13 Murray Cumming <murrayc@murrayc.com>
384 2007-06-12 Murray Cumming <murrayc@murrayc.com>
386 * src/modest-tny-account-store.c: (get_server_accounts):
387 Call modest_tny_local_folders_account_add_merged_outbox_folders()
388 even when there are no accounts, so that the Outbox folder is always
389 visible. This fixes projects.maemo.org bug NB#60158.
391 2007-06-12 Murray Cumming <murrayc@murrayc.com>
393 * src/maemo/modest-main-window.c: (create_details_widget):
394 Use the mcen_va_never logical ID.
396 2007-06-12 Murray Cumming <murrayc@murrayc.com>
398 * src/dbus_api/modest-dbus-api.h:
399 * src/dbus_api/modest-dbus-callbacks.c:
400 (on_idle_open_default_inbox), (on_open_default_inbox),
401 (modest_dbus_req_handler):
402 Added a new OpenDefaultInbox method.
404 * libmodest-dbus-client/libmodest-dbus-client.h:
405 * libmodest-dbus-client/libmodest-dbus-client.c:
406 Added libmodest_dbus_client_open_default_inbox() to call the new
407 dbus method. This should be useful to projects.maemo.org bug NB#57214,
408 though it should maybe be used by a new osso-email-interface function.
410 * tests/dbus_api/Makefile.am:
411 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
414 2007-06-12 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
417 NULL, so that the signals get all the keys. This should not actually
418 change any behaviour because we currently update everything when anything
421 2007-06-12 Murray Cumming <murrayc@murrayc.com>
423 * src/widgets/modest-folder-view.c: (text_cell_data),
424 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
425 (find_inbox_iter): If tinymail tells us that the folder is
426 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
427 This causes the inbox to be selected at startup, fixing part of
428 projects.maemo.org bug NB#56305.
430 * src/modest-ui-dimming-rules.c:
431 (modest_ui_dimming_rules_on_tools_smtp_servers):
432 * src/modest-ui-dimming-rules.h: Added a callback function to dim
433 the SMTP servers menu item.
434 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
435 that the SMTP Servers menu item is dimmed when there are no accounts,
436 as a future version of the UI spec will require. This fixes
437 projects.maemo.org bug NB#56305.
439 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
441 * src/maemo/modest-maemo-utils.c:
442 (modest_maemo_utils_get_supported_secure_authentication_methods):
443 Added label to dialog instead of unreadable title
445 * src/maemo/modest-main-window.c: (sync_accounts_cb),
446 (modest_main_window_new):
447 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
450 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
451 * src/modest-account-mgr.h:
452 Added method to avoid code duplication
454 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
455 (modest_ui_actions_on_send_receive):
456 Use modest_account_mgr_has_accounts
458 2007-06-11 Murray Cumming <murrayc@murrayc.com>
460 * src/maemo/easysetup/modest-presets.c:
461 (modest_presets_get_info_server_security): Do not report secure auth
463 * src/modest-protocol-info.c: Use the defines for the gconf key names
464 for secure authentication. This was not working because we were writing
465 Password and reading password, and the check was case sensitive.
466 With this, gmail now works for receiving and sending when created via
469 2007-06-11 Murray Cumming <murrayc@murrayc.com>
471 * src/maemo/easysetup/modest-presets.c:
472 (modest_presets_get_info_server_security): Correct the key name for
473 SecureSmtp, because it seems to be case-sensitive.
474 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
475 Do not try to get the 0th notebook page if there are 0 pages, to
478 2007-06-11 Murray Cumming <murrayc@murrayc.com>
480 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
481 Prevent use of the new notification feature for now, because it currently
482 shows one dialog for each new email, which is annoying.
484 2007-06-11 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
487 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
488 when no country was selected, so that we show the global ones.
489 * src/maemo/easysetup/modest-presets.c:
490 (modest_presets_get_providers): Return only the global providers, not
491 all providers when mmc=0 was requested.
493 2007-06-11 Murray Cumming <murrayc@murrayc.com>
495 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
496 (easysetup_provider_combo_box_fill): Remove debug code that showed the
497 provider ID in the combo.
499 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
500 Do not show the page numbers, because it would be confusing when we add
501 the 2 extra pages for the custom setup, when the user chooses the "Other"
502 provider. This fixes projects.maemo.org bug NB#59028
504 * src/modest-init.c: (modest_init_init_core),
505 (modest_init_local_folders):
507 * src/modest-tny-account.c:
508 (modest_tny_account_new_for_local_folders): Do not create default folders
509 for the memory card. This should fix projects.maemo.org bug NB#59328.
511 2007-06-11 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
514 Free the changed_conf_keys string items. They are already freed in the
515 idle handler if that runs first.
517 2007-06-11 Murray Cumming <murrayc@murrayc.com>
519 * src/modest-ui-actions.c:
520 (modest_ui_actions_on_password_requested): Check that the server name
521 is not NULL, because I just saw a password dialog with (null) as the
524 * src/modest-tny-folder.[h|c]: Added
525 modest_tny_folder_is_memory_card_folder().
526 * src/modest-ui-dimming-rules.c:
527 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
528 menu item for memory cards, as per the UI spec (section 7.4). This should
529 fix projects.maemo.org bug NB#59297.
531 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
533 * src/maemo/modest-main-window.c: (sync_accounts_cb):
534 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
535 is another problem with the code, see Murray's comment at line 772)
537 2007-06-08 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
540 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
541 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
542 (load_from_file), (easysetup_country_combo_box_init),
543 (easysetup_country_combo_box_get_active_country_ids),
544 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
545 instead of just one ID, to avoid duplicate country names in the UI.
547 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
548 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
549 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
550 a single ID, avoiding duplicate providers.
551 * src/maemo/easysetup/modest-easysetup-wizard.c:
552 (on_combo_account_country): Adapt to use a list.
554 2007-06-08 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
557 keys changed in the last X seconds.
559 * src/modest-account-mgr.h:
560 * src/modest-account-mgr.c: (on_timeout_notify_changes),
561 (on_key_change), (modest_account_mgr_class_init),
562 (modest_account_mgr_init), (modest_account_mgr_finalize):
563 As the keys are changed, save them in a GSList* and signal that GSList*
564 further every X seconds, to batch changes, to allow us to do just one
565 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
566 bug NB#56941 and other (UI-blocking) delays when changing account settings.
568 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
569 changed signal signature.
571 * src/modest-conf.c: (modest_conf_set_list),
572 (modest_conf_on_change): Reenable notification.
574 (modest_conf_maemo_fake_on_change): Comment out the hack that
575 notified immediately instead of asynchronously.
577 * src/widgets/modest-account-view.h:
578 * src/widgets/modest-account-view.c:
579 (update_account_view): Select the previously-selected account ID,
580 if possible. This fixes projects.maemo.org bug NB#56933.
582 (on_account_changed), (on_account_removed),
583 (modest_account_view_select_account):
585 Remove the block/unblock functions
586 because they were not useful.
588 * src/maemo/modest-account-view-window.c:
589 (on_delete_button_clicked), (on_edit_button_clicked),
590 (on_new_button_clicked): Remove the use of the non-working block/unblock.
592 2007-06-08 Murray Cumming <murrayc@murrayc.com>
594 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
595 Improve the error dialog to show Incorrect Account Settings, which seems
596 clearer, and say that the internal error message (to be removed from the
597 dialog later) is often misleading.
598 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
600 * src/modest-tny-account.c:
601 (modest_tny_account_new_from_server_account): Uncomment the printf of the
602 URL because this is so useful for debugging on the device.
604 * src/widgets/modest-serversecurity-combo-box.c:
605 (modest_serversecurity_combo_box_fill): Correct a logical ID.
607 2007-06-08 Murray Cumming <murrayc@murrayc.com>
609 * src/modest-mail-operation.c:
610 (modest_mail_operation_send_new_mail):
611 Added a comment about a nasty but apparently harmless message. Details
612 added to the wiki g_warnings() page.
614 2007-06-08 Murray Cumming <murrayc@murrayc.com>
616 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
617 (modest_tny_send_queue_class_init):
618 Do not use the priv struct because it is empty, to avoid g_warnings
619 about a non-existant priv struct.
621 * src/modest-tny-account-store.c:
622 (modest_tny_account_store_get_server_account),
623 (modest_tny_account_store_get_transport_account_for_open_connection
624 ): Do not try to get transport server accounts for local folders,
625 because they don't have any. This avoids a g_warning().
627 * src/maemo/modest-main-window.c:
628 (modest_main_window_notify_send_receive_initied),
629 (on_configuration_key_changed):
630 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
632 * src/modest-mail-operation.c:
633 (modest_mail_operation_update_account):
634 * src/modest-tny-account-store.h:
635 * src/modest-tny-account.c:
636 (modest_tny_account_get_special_folder),
637 (modest_tny_account_new_for_local_folders),
638 (modest_tny_account_new_for_per_account_local_outbox_folder):
639 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
640 * src/modest-tny-local-folders-account.c:
641 (add_account_folders_to_merged_folder):
642 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
643 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
644 (modest_ui_actions_on_send):
645 * src/widgets/modest-folder-view.c: (update_model):
646 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
647 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
648 modest_tny_account_store_get_tny_account_by_account() to
649 modest_tny_account_store_get_server_account() to make the code clearer.
651 2007-06-07 Marcus Bauer <marcusb@openismus.com>
653 * src/dbus_api/modest-dbus-api.h:
654 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
655 * src/maemo/modest-msg-edit-window.c:
656 (modest_msg_edit_window_attach_file_noninteractive):
657 added g_warning in case the file to be attached does not exist
658 * tests/dbus_api/test_compose_mail.c: (main):
659 removed obsolete comment, added generic files as test case
661 2007-06-07 Murray Cumming <murrayc@murrayc.com>
663 * src/modest-tny-account-store.c: (get_server_accounts):
664 Create the local folders account only once, not once for each outbox, and
665 not only when there are some outboxes.
667 2007-06-07 Murray Cumming <murrayc@murrayc.com>
669 * src/widgets/modest-folder-view.c: (update_model): Comment out some
670 code that is causing a crash at startup. Sergio says that he is fixing this.
672 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
674 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
675 * src/maemo/modest-account-settings-dialog.c:
676 (create_page_outgoing),
677 (modest_account_settings_dialog_set_account_name),
678 (save_configuration):
679 - Fixed handling of the "Use secure authentication" toggle to comply with
680 the ui specification. See also projects.maemo.org bug NB#58400
682 - Restore the Secure connection setting combo correctly when loading
685 * src/maemo/modest-maemo-utils.c:
686 (on_camel_account_get_supported_secure_authentication),
687 (modest_maemo_utils_get_supported_secure_authentication_methods):
688 Fixed a crasher if operation is canceled
690 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
691 (modest_protocol_info_auth_is_secure):
692 * src/modest-protocol-info.h:
694 Added two new methods to determine if a protocol/auth method is secure/encrypted in
695 the sense of the "Use secure authentication" toggle.
697 2007-06-07 Murray Cumming <murrayc@murrayc.com>
699 * src/modest-tny-account-store.h:
700 * src/modest-tny-account-store.c:
701 Added modest_tny_account_store_get_local_folders_account().
703 * src/modest-tny-folder.h:
704 * src/modest-tny-folder.c:
705 (modest_tny_folder_get_account):
706 Added this replacement for tny_folder_get_account() which returns
707 the local-folders account for TnyMergeFolders, to avoid the
708 warning about the unimplemented get_account_func() vfunc().
710 (modest_tny_folder_get_rules),
711 * src/modest-ui-actions.c:
712 (modest_ui_actions_on_folder_selection_changed):
713 * src/modest-mail-operation.c:
714 (modest_mail_operation_remove_folder),
715 (modest_mail_operation_xfer_folder),
716 (modest_mail_operation_rename_folder),
717 (modest_mail_operation_get_msg),
718 (modest_mail_operation_get_msgs_full),
719 (modest_mail_operation_remove_msg),
720 (modest_mail_operation_xfer_msgs),
721 (modest_mail_operation_refresh_folder):
722 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
724 2007-06-07 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
727 (modest_server_account_set_security):
728 * src/modest-defs.h: Add comments explaining that our
729 UI spec means TLS when it says Normal, so these do not look like errors.
731 * src/modest-tny-account.c:
732 (modest_tny_account_new_from_server_account): Use the new tinymail
733 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
734 for TLS. This should fix projects.maemo.org bug NB#58460.
736 2007-06-06 Murray Cumming <murrayc@murrayc.com>
738 * src/maemo/easysetup/modest-easysetup-wizard.c:
739 (create_account): Correct the position of the gconf sanity check warning.
740 (on_button_edit_advanced_settings): Show the dialog immediately, instead
741 of using the g_idle_add() hack, because this does not seem to be necessary
742 on osso 1.1. It might even work on Maemo Bora if the problems were actually
743 caused by something other than maemo's gconf.
744 This fixes projects.maemo.org bug #59022.
746 2007-06-06 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-account-mgr-helpers.c:
749 (modest_account_mgr_get_default_account): Do not check that the account
750 exists if there is no default account (NULL), to fix a runtime warning.
752 2007-06-06 Murray Cumming <murrayc@murrayc.com>
754 * src/widgets/modest-folder-view.c: (update_model):
755 Do not unref the treemodel before we have finished with it.
756 This prevents a valgrind warning and an occasional crash at startup.
758 2007-06-06 Marcus Bauer <marcusb@openismus.com>
760 * libmodest-dbus-client/libmodest-dbus-client.h:
761 added libmodest_dbus_client_compose_mail()
762 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
764 added functions needed for SendAsMail() functionality
765 * src/maemo/modest-msg-edit-window.c:
766 (modest_msg_edit_window_attach_file_noninteractive):
767 non interactively attaching files to message edit window
768 * src/widgets/modest-msg-edit-window.h:
769 * tests/dbus_api/Makefile.am:
770 added test_compose_mail.c
771 * tests/dbus_api/test_compose_mail.c: (main):
773 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
775 * src/modest-account-view.c:
776 Fixed bug projects.maemo.org bug NB#59307
778 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
780 * src/maemo/easysetup/modest-easysetup-wizard.c:
781 (get_serverport_incoming), (on_before_next), (create_account):
782 * src/maemo/modest-account-settings-dialog.c:
783 (modest_account_settings_dialog_set_account_name):
784 * src/maemo/modest-maemo-utils.c:
785 (on_camel_account_get_supported_secure_authentication_status),
786 (on_camel_account_get_supported_secure_authentication),
787 (on_secure_auth_cancel),
788 (modest_maemo_utils_get_supported_secure_authentication_methods):
790 Implemented security authentication for settings and easysetup.
792 2007-06-05 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/modest-main-window.c: (create_details_widget):
795 Show the total size for memory card accounts too, instead of showing
796 the name again. Fixes bug projects.maemo.org bug NB#59307.
798 2007-06-05 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-tny-simple-folder-store.c:
802 * src/modest-tny-simple-folder-store.h: Removed.
804 * src/modest-tny-local-folders-account.h
805 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
806 for the local-folders maildir, with an extra TnyMergedFolder containing
807 the folders of the per-account outbox store accounts.
808 * src/modest-tny-account-store.c: (get_server_accounts):
809 Add the outboxes to the special local folders account after creating it.
811 * src/modest-tny-account.c:
812 (modest_tny_account_new_for_local_folders): Create the derived
813 account when creating the main local-folders account.
815 * src/maemo/modest-main-window.c: (create_details_widget),
816 (modest_main_window_set_contents_style):
817 Adapted to the use of the derived account instead of the folder store.
819 * src/modest-ui-actions.c:
820 (modest_ui_actions_on_folder_selection_changed):
821 * src/modest-ui-dimming-rules.c:
822 (modest_ui_dimming_rules_on_new_folder):
823 * src/widgets/modest-folder-view.c: (text_cell_data),
824 (icon_cell_data), (filter_row), (update_model),
825 (get_cmp_rows_type_pos):
828 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
829 Do not get the priv struct, because no priv struct has been set,
830 to avoid a runtime warning.
832 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
833 #ifelse with #else, to fix a warning, to fix the build.
836 2007-06-05 Christian Kellner <ckellner@openismus.com>
838 * libmodest-dbus-client/libmodest-dbus-client.c:
839 Fix small typo in doc (why do you always see them
840 AFTER committing stuff?)
843 2007-06-05 Christian Kellner <ckellner@openismus.com>
845 * libmodest-dbus-client/libmodest-dbus-client.c:
846 (libmodest_dbus_client_search):
847 Initialize hit list with NULL. Also set folder list
848 to "" if NULL was supplied.
851 2007-06-03 Christian Kellner <ckellner@openismus.com>
853 * libmodest-dbus-client/libmodest-dbus-client.c:
854 (modest_search_hit_list_free):
855 Make it save to call it with NULL.
857 * src/dbus_api/modest-dbus-callbacks.c:
858 * src/modest-search.c:
859 Return full ModestSearchHits as the search result list not TnyHeader
860 since can't be around withouth the correspoding TnyFolder.
862 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
864 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
865 Added currently commented code to check for secure auth
867 * src/maemo/modest-account-settings-dialog.c: (on_response),
868 (save_configuration), (show_ok):
869 Fixed projects.maemo.org bugs NB #59248 and #59251
871 * src/maemo/modest-maemo-utils.c:
872 (on_camel_account_get_supported_secure_authentication_status),
873 (on_camel_account_get_supported_secure_authentication),
874 (modest_maemo_utils_get_supported_secure_authentication_methods):
875 * src/maemo/modest-maemo-utils.h:
876 Moved get_supported_secure_authentication() method here to be able
877 to use it from easysetup wizard.
879 * src/modest-pair.c: (on_pair_compare_as_string):
880 Should compare string with first part of pair and not
881 strcmp pairs which will crash.
883 * src/modest-protocol-info.c:
884 (modest_protocol_info_protocol_is_store):
885 * src/modest-protocol-info.h:
886 Added modest_protocol_info_get_auth_protocol_name()
888 2007-06-03 Armin Burgmeier <armin@openismus.com>
890 * src/modest-mail-operation.c:
891 (modest_mail_operation_get_msgs_full): Set priv->account also when
892 only retrieving a single message. This avoids a crash when canceling
895 (modest_mail_operation_notify_end): Do not explicitely remove the
896 operation from the queue but only emit the progress_changed signal.
897 The queue itself listens to that signal to remove the operation when
898 it is finished. This reduces coupling and removes a potential deadlock
899 when modest_mail_operation_notify_end() is called from the queue
900 itself. If that is a problem performance-wise, I would suggest to
901 implement a status-changed signal or something.
903 * src/modest-mail-operation-queue.c: Make sure to never call a
904 function from another file while the queue is locked. This (hopefully)
905 fixes another deadlock when exiting the application while retrieving
908 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
910 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
911 Fixed build if libogs is not available
913 2007-06-03 Christian Kellner <ckellner@openismus.com>
915 * libmodest-dbus-client/libmodest-dbus-client.h:
916 * libmodest-dbus-client/libmodest-dbus-client.c:
917 (libmodest_dbus_client_delete_message):
918 Implement deletion of messages (Client side).
920 (modest_search_hit_free),
921 (modest_search_hit_list_free):
922 Utility functions to free the result hits.
924 * src/dbus_api/modest-dbus-api.h:
925 * src/dbus_api/modest-dbus-callbacks.c:
927 (modest_dbus_req_handler):
928 Implement deletion of messages (Server side).
930 * tests/dbus_api/test_search.c: (main):
933 * tests/dbus_api/Makefile.am:
934 * tests/dbus_api/test_delete_message:
935 Add little test for the message deletion logic
937 2007-06-03 Armin Burgmeier <armin@openismus.com>
939 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
940 when the operation queue was not empty. projects.maemo.org bug
943 2007-06-03 Armin Burgmeier <armin@openismus.com>
945 * src/widgets/modest-account-view.c
946 (on_account_default_toggled): Toggle default account column
947 explicitely instead of waiting for gconf notification (which is
948 currently ignored). This should fix projects.maemo.org bug NB#56910
949 for now. It should probably be removed when gconf notifications are
952 2007-06-03 Christian Kellner <ckellner@openismus.com>
954 * libmodest-dbus-client/libmodest-dbus-client.c:
955 Removed debugging spew.
957 * src/dbus_api/modest-dbus-callbacks.c:
958 Added debugging info.
960 * src/modest-search.c:
961 (modest_search_all_accounts):
962 Use tny_account_store_get_accounts () on the account store
963 to get all accounts which is the way to get all accounts.
965 * tests/dbus_api/test_search.c: (main):
966 Make it possible to supply the search term on the command line.
968 2007-06-03 Christian Kellner <ckellner@openismus.com>
970 * libmodest-dbus-client/libmodest-dbus-client.c:
971 * libmodest-dbus-client/libmodest-dbus-client.h:
972 Implement searching for mesages over raw dbus. (Client side)
974 * src/dbus_api/Makefile.am:
975 * src/dbus_api/modest-dbus-api.h:
976 * src/dbus_api/modest-dbus-callbacks.c:
977 * src/dbus_api/modest-dbus-callbacks.h:
978 Search framework (Server side). Also implement on_idle_open_message().
980 * src/maemo/modest-platform.c: (modest_platform_init):
981 Prepare for raw dbus/osso rpc interaction.
983 * src/modest-search.h:
984 Changed minsize from unspecific guint to guint32.
986 * src/modest-search.c:
988 Added strange hack which magically made tnymail work.
990 (modest_search_folder),
991 (modest_search_account),
992 (modest_search_all_accounts):
993 Implement helper functions to search all accounts, specific account
996 * tests/dbus_api/Makefile.am:
997 * tests/dbus_api/test_open_message.c:
998 Read url to open from commandline.
1000 * tests/dbus_api/test_search.c:
1001 Implement small test for dbus search stuff
1003 2007-06-02 Armin Burgmeier <armin@openismus.com>
1005 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1006 include account type and account title. This fixes projects.maemo.org
1009 * src/maemo/modest-account-view-window.c: Set a title for the window.
1011 2007-06-02 Armin Burgmeier <armin@openismus.com>
1013 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1014 incoming and outgoing server name based on email address and server
1015 types as long as the names have not been edited manually. This fixes
1016 projects.maemo.org bug NB#58671.
1018 2007-06-02 Armin Burgmeier <armin@openismus.com>
1020 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1021 server type cannot be changed in future to the incoming details page
1022 when creating an account. This fixes projects.maemo.org bug NB#59029.
1024 2007-06-02 Armin Burgmeier <armin@openismus.com>
1026 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1027 and assigned max width chars so that they wrap instead of being
1028 truncated. Fixes projects.maemo.org bug NB#56126.
1030 2007-06-02 Armin Burgmeier <armin@openismus.com>
1032 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1033 introductory note to the connection specific smtp servers dialog, as
1034 section 8.12 of the email UI specification requires. This fixes
1035 projects.maemo.org bug NB#59212.
1037 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1039 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1040 Check for running mail operations, and offer to cancel them, as per the UI
1041 spec. This fixes projects.maemo.org bug NB#59041 .
1042 However, I suspect that tinymail may still use the network connection
1043 in ways that we cannot detect or cancel. But it should at least adapt to
1044 changes fairly well.
1046 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1048 * src/modest-tny-account-store.c: (recreate_all_accounts),
1049 (get_cached_accounts), (get_server_accounts): Do more sensible
1050 ref-counting of the temporarily-cached outbox accounts list. This seems
1051 to fix a crash when entering the password when the password was wrong.
1053 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1055 * src/gnome/modest-main-window.c: (connect_signals):
1056 * src/modest-tny-account-store.c: (get_password),
1057 (modest_tny_account_store_alert): Added comments and clues and
1058 commented-out code about how we currently fail to deal with connection
1059 errors and wrong passwords, and how we should.
1061 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1063 * src/widgets/modest-retrieve-combo-box.c:
1064 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1065 This fixes projects.maemo.org bug NB#58472 .
1067 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/easysetup/modest-easysetup-wizard.c:
1070 (create_page_complete_easysetup):
1071 (create_page_complete_custom): Correct the last commit,
1072 putting the correct sentences in the correct pages.
1074 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1076 * src/maemo/easysetup/modest-easysetup-wizard.c:
1077 (create_page_complete_custom): Show the second sentence of text
1078 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1081 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1084 Set the leave-on-server conf key by default. This fixes
1085 projects.maemo.org bug NB#59258 .
1087 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1089 * src/maemo/modest-account-view-window.c:
1090 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1091 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1094 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1096 * src/maemo/easysetup/modest-easysetup-wizard.c:
1097 (create_caption_new_with_asterisk):
1098 * src/maemo/modest-account-settings-dialog.c:
1099 (create_caption_new_with_asterisk):
1100 Uncomment the code to add the asterisk, because they are no longer in the
1101 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1102 (update_incoming_server_title): Add an asterisk here too.
1104 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-maemo-global-settings-dialog.c:
1107 (current_connection): Check that we are even connected before trying to
1108 get the current connection name, to prevent a warning.
1110 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1111 Change the comments because tny_maemo_conic_device_connect() is now meant to
1113 * src/modest-mail-operation.c:
1114 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1115 make sure we have a connection and fail if we can't connect.
1117 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-main-window.c:
1120 (on_account_store_connecting_finished): Do not try to get the
1121 connection ID if we are not really connected. I am surprised that
1122 this signal handler is called when we are not connected.
1124 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1126 * src/modest-error.h:
1127 * src/modest-ui-actions.c:
1128 (modest_ui_actions_get_msgs_full_error_handler):
1129 Renamed an enum, added comments, added an enum
1130 for retrieve-limit errors.
1132 * src/modest-mail-operation.c: (foreach_add_item),
1133 (internal_folder_observer_update), (update_account_thread),
1134 (modest_mail_operation_get_msgs_full):
1135 (modest_mail_operation_update_account),
1136 Added comments about how this works, and some code that should
1137 (but does not) check the retrieve-limit. See the TODO comment.
1139 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1142 Initialize help_id to fix the build. Warnings are good.
1144 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1146 * src/widgets/modest-hbox-cell-renderer.c:
1147 (modest_hbox_cell_renderer_append):
1148 * src/widgets/modest-vbox-cell-renderer.c:
1149 (modest_vbox_cell_renderer_append):
1150 Fix the last commit by doing an extra ref.
1152 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1154 * src/widgets/modest-hbox-cell-renderer.c:
1155 (modest_hbox_cell_renderer_append):
1156 * src/widgets/modest-vbox-cell-renderer.c:
1157 (modest_vbox_cell_renderer_append):
1158 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1159 to fix the build with Maemo Bora.
1160 However, there seems to be a remaining crash, probably due to reference
1163 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1165 * src/modest-tny-account.c:
1166 (modest_tny_account_new_for_local_folders):
1167 Use hildon_file_system_info_async_new() to get a better name for
1168 the memory card account, setting it as the account name.
1169 The timing seems to work, but this is probably
1170 not the best place to do this. See the TODO comment.
1171 * src/maemo/modest-main-window.c: (create_details_widget):
1172 * src/widgets/modest-folder-view.c: (text_cell_data):
1173 Use the tny account name instead of hardcoding a name.
1175 2007-05-30 Christian Kellner <ckellner@openismus.com>
1177 * src/modest-search.c: (modest_search):
1178 Correctly set part_search_func even if we have already parsed
1179 the query and thus a valid OgsTextSearcher object.
1181 2007-05-30 Christian Kellner <ckellner@openismus.com>
1184 Search and check for libogs.
1187 Incooparte the ogs build env.
1189 * src/modest-mime-part-search-stream.c:
1190 * src/modest-mime-part-search-stream.h:
1191 Removed since we do the real searching now in modest-search.c.
1193 * src/modest-search.c:
1194 * src/modest-search.h:
1195 Implement support for ogs. We use that if available and requested
1196 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1197 should now handle the corner case when the search term is spread
1198 across multiple reads.
1199 Also the logic in modest_search () was corrected to search all
1200 requested fields until one is found.
1202 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1204 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1206 * src/modest-init.h:
1207 * src/modest-init.c: Made modest_init_local_folders() take a
1208 path and be public so we can iniitialize maildir folders on
1211 * src/modest-local-folder-info.h:
1212 * src/modest-local-folder-info.c:
1213 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1215 * src/modest-tny-account.c:
1216 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1217 still means the standard local-folders path on the local volume.
1219 * src/modest-tny-account-store.c:
1220 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1221 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1222 all accounts when that happens.
1223 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1224 this too, so it shows up in the treeview.
1226 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1228 * src/maemo/modest-maemo-global-settings-dialog.c:
1229 (current_connection):
1230 * src/widgets/modest-global-settings-dialog.c:
1231 (current_connection_default):
1232 Use the enum values instead of 0, 1 and -1,
1233 to make the code clearer.
1235 * src/modest-account-mgr-helpers.c:
1236 (modest_account_mgr_get_connection_specific_smtp): Make this code
1239 * src/modest-runtime.h:
1240 * src/modest-runtime.c:
1241 Added modest_runtime_remove_all_send_queues().
1242 * src/maemo/modest-main-window.c:
1243 (on_account_store_connecting_finished): Recreate the send queues,
1244 using the appropriate transport accounts for this new connection.
1245 Some futher adapting might be needed if the old send queues are not
1246 automatically stopped at this point.
1248 * src/modest-tny-account-store.c: (get_server_accounts):
1249 Create the connection-specific transport accounts, so that they can
1250 be found later by their ID.
1252 * src/modest-tny-account.h:
1253 * src/modest-tny-account.c:
1254 Added modest_tny_account_new_from_server_account_name().
1255 modest_tny_account_new_from_server_account(): Do not create the
1256 send queues here, because they will be
1257 recreated anyway when the connection changes for the first time.
1259 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-local-folder-info.h:
1262 * src/modest-local-folder-info.c:
1263 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1264 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1265 tbox_folder): Take a modest account name instead of a server TnyAccount,
1266 so we can have per-modest-account rather than per-transport-account
1268 We must make sure that we change or recreate the exisitng send queues
1269 when the connection changes for connection-specific transport accounts.
1271 * src/modest-tny-account-store.c:
1272 (create_per_account_local_outbox_folders): Create outboxed per modest
1273 account, not per transport account.
1275 * src/modest-tny-account.h:
1276 * src/modest-tny-account.c:
1277 (modest_tny_account_get_special_folder): For outboxes, get the
1278 parent modest account name. The account is ignored for other folders.
1279 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1280 modest account name rather than a server TnyAccount.
1282 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1284 * src/modest-tny-account.c:
1285 (modest_tny_account_new_from_server_account):
1286 Call modest_runtime_get_send_queue() immediately after creating transport
1287 accounts, so that they start trying to send email from the outbox as soon
1288 as possible at startup. This is probably what we want.
1290 * src/modest-mail-operation.c: (update_account_thread):
1291 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1292 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1293 * src/modest-tny-send-queue.h:
1294 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1295 (modest_ui_actions_on_send):
1296 Added comments about how sending works, though it needs some more work.
1298 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1300 * src/modest-tny-account.c:
1301 (modest_tny_account_get_special_folder): Add TODO because this fails when
1302 the network is busy.
1303 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1304 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1305 Do not try to show this window when there is no active account. The UI
1306 specs does not tell us what to do in this case.
1308 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1312 * src/maemo/Makefile.am:
1313 * src/widgets/Makefile.am: Some dist fixes.
1315 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1317 * src/maemo/modest-connection-specific-smtp-window.c:
1318 (on_button_edit): Make the code clearer, to prevent a double free.
1320 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1322 * src/maemo/modest-account-settings-dialog.c:
1323 (modest_account_settings_dialog_set_account_name),
1324 Check the connection-specific smtp servers checkbox if there are any.
1326 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1327 (modest_connection_specific_smtp_edit_window_init):
1328 Start with a suitable port number.
1330 * src/modest-account-mgr-helpers.h:
1331 * src/modest-account-mgr-helpers.c: Added
1332 modest_account_mgr_get_has_connection_specific_smtp().
1334 (modest_account_mgr_set_connection_specific_smtp),
1335 (modest_account_mgr_remove_connection_specific_smtp),
1336 (modest_account_mgr_get_has_connection_specific_smtp),
1337 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1338 connection-specific smtp server accounts in the account, rather than
1339 the server account conf dir.
1341 This fixes bug projects.maemo.org bug NB#58263 .
1343 * src/modest-tny-account-store.c:
1344 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1345 if there are no server accounts yet, to prevent an infinite loop when there
1346 are no accounts. Document that one must be called before the other.
1348 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-account-mgr-helpers.c:
1351 (modest_account_mgr_get_default_account): Make sure that at least
1352 one account is always the default, if there are any enabled accounts.
1353 This is just a sanity check that shouldn't be necessary.
1355 * src/modest-account-mgr-priv.c:
1356 (_modest_account_mgr_account_from_key): Unescape the conf key to
1357 get the real account name. For instance, this is an issue if a space
1358 was in the account name, which can happen because the account name
1359 is generated from the display name.
1360 (_modest_account_mgr_get_account_keyname): Always escape the
1362 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1363 Unescape the conf keys to get the real account names.
1365 For instance, previously the is-default radio button in the accounts
1366 list was not checked for any accounts at first. This fixes that,
1367 and might fix several similar bugs.
1369 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1371 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1372 Removed some debug printfs.
1374 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1376 Modest on-disk outbox directories are now here, for instance:
1377 $HOME/.modest/outboxes/<account-id-1>/outbox
1378 $HOME/.modest/outboxes/<account-id-2>/outbox
1380 $HOME/.modest/local-folders/outbox
1381 so we can have a separate outbox for each account.
1382 But they are shown as one outbox in the GtkTreeView, by using a
1383 TnyMergeFolder in a ModestTnySimpleFolderStore.
1386 * src/modest-tny-simple-folder-store.c:
1387 * src/modest-tny-simple-folder-store.h:
1388 Added ModestTnySimpleFolderStore, used to contain folders from
1389 other folder stores, such as other accounts.
1391 * src/modest-tny-outbox-account.h:
1392 * src/modest-tny-outbox-account.c:
1393 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1394 used for the per-account local outbox folders.
1396 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1397 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1398 only use this (internally) now for the non-outbox local folders.
1400 * src/modest-init.h:
1401 * src/modest-init.c: Added modest_init_one_local_folder(), for
1402 setting up the directory structure for each local folder.
1404 * src/modest-local-folder-info.c:
1405 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1406 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1408 * src/modest-local-folder-info.h:
1409 * src/modest-tny-account-store.c: (on_account_removed),
1410 (on_account_changed), (create_per_account_local_outbox_folders),
1411 (get_server_accounts), (modest_tny_account_store_get_accounts),
1412 (modest_tny_account_store_get_tny_account_by_account),
1413 (modest_tny_folder_store_is_virtual_local_folders):
1415 * src/modest-tny-account.h:
1416 * src/modest-tny-account.c:
1417 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1418 to create an on-disk per-account local outbox folder for each
1420 (create_per_account_local_outbox_folders): Create a local outbox folder
1421 for each transport account.
1422 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1423 for all local folders.
1425 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1426 instead of using g_object_get/set() directly. It is clearer.
1428 (modest_tny_folder_store_get_message_count),
1429 (modest_tny_folder_store_get_local_size
1430 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1431 because we now use these with non-acount folder stores.
1433 (modest_tny_account_get_special_folder),
1434 (modest_tny_account_new_from_server_account),
1435 (modest_tny_account_new_from_account):
1436 (recurse_folders): Adjust to the new outbox system.
1438 * src/modest-tny-folder.h:
1439 * src/modest-tny-folder.c:
1440 (modest_tny_folder_is_local_folder),
1441 (modest_tny_folder_get_local_folder_type),
1442 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1444 * src/widgets/modest-main-window.h:
1445 * src/maemo/modest-main-window.c: (create_details_widget),
1446 (modest_main_window_set_contents_style): Show details for any folder store,
1449 (modest_tny_folder_get_rules):
1450 Remove the const. C does not support constness enough for this.
1452 * src/modest-ui-actions.c:
1453 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1454 make all outboxes appear as one, in the usual local-folders tree node.
1456 (set_active_account_from_tny_account),
1457 (modest_ui_actions_on_folder_selection_changed):
1458 * src/widgets/modest-folder-view.c: (text_cell_data),
1459 (icon_cell_data), (filter_row),
1460 (add_account_folders_to_merged_folder),
1461 (add_account_folders_to_simple_folder_store), (),
1462 (get_cmp_rows_type_pos), (cmp_rows),
1463 (modest_folder_view_set_account_id_of_visible_server_account):
1464 Adjust to the new outbox system, using generic folder stores and folders
1465 in the GtkTreeModel.
1467 2007-05-23 Christian Kellner <ckellner@openismus.com>
1469 * src/modest-mail-operation.c:
1470 (modest_mail_operation_update_account):
1471 Use info->max_size instead of unintialized local var [small
1472 build fix]. (Added TODO to review that change since I don't
1475 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1477 * libmodest-dbus-client/libmodest-dbus-client.c:
1478 (libmodest_dbus_client_compose_mail): function added
1479 * src/dbus_api/modest-dbus-api.h:
1480 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1481 (on_compose_mail): Implementation of the SendAsMail functionality
1483 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1485 * src/modest-account-mgr.c:
1486 (modest_account_mgr_add_server_account): Set the secure-connection
1487 conf key for transport accounts as well as store accounts. I don't know
1488 why the if was there. For instance, this makes sure that we use SSL
1489 for the gmail preset from the easysetup wizard.
1491 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1493 * src/gnome/modest-main-window.c:
1494 (on_account_store_connecting_finished), (connect_signals):
1495 * src/maemo/modest-main-window.c:
1496 (on_account_store_connecting_finished), (connect_signals),
1497 (modest_main_window_new):
1498 Handle TnyAccountStore::connecting-finished instead of
1499 TnyDevice::connection-changed, because we cannot actually perform
1500 operations on accounts until TnyAccountStore has itself responded to
1501 the TnyDevice::connection-changed signal. This prevents a GError from
1503 Do not try to update at startup, because we (at least on scratchbox)
1504 already do an update at startup when the device goes online.
1505 This prevents a GError from tinymail.
1506 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1507 Added TODO about stopping simultaneous operations.
1509 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1511 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1512 * src/modest-mail-operation-queue.c:
1513 (modest_mail_operation_queue_remove):
1514 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1515 about where they happened.
1517 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-ui-actions.c:
1520 (modest_ui_actions_on_password_requested): Make sure that the remember
1521 output parameter is always TRUE.
1523 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1525 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1526 Show a OK/Cancel dialog if the error is a question, though we still do not
1527 know anything more about what we are asking the user.
1528 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1529 Fix an uninitialized variable (helper). This is a logic error, however.
1531 2007-05-21 Christian Kellner <ckellner@openismus.com>
1533 * src/modest-search.h:
1534 Correct bit shifting in the ModestSearchFlags enum.
1536 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1538 * src/modest-tny-account.c:
1539 (modest_tny_account_new_from_server_account): Do not use the lsub and
1540 check-all hard-coded IMAP options when using POP.
1542 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account.c:
1545 (modest_tny_account_new_from_server_account):
1546 Use NULL for the secure-auth method for POP when Password auth has been
1547 specified by the user, as we already do for IMAP. "auth=Login" causes
1548 an error from camel or the server.
1550 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-account-settings-dialog.c:
1553 (create_page_account_details),
1554 (modest_account_settings_dialog_set_account_name):
1555 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1556 for the leave-on-server checkbox, rathr than just the checkbox, when
1557 the protocol is not POP.
1559 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1561 * src/widgets/modest-account-view.c:
1562 * src/widgets/modest-account-view.h:
1563 Added modest_account_view_select_account() which will be useful later
1564 to asynchronously re-select the edited account.
1566 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1568 * src/maemo/modest-account-settings-dialog.c:
1569 (modest_account_settings_dialog_set_account_name):
1570 Automatically choose the port numbers based on the secure authentication
1571 methods, if they have not been chosen before.
1572 This fixes projects.maemo.org bug NB#56273 .
1574 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/modest-main-window-ui.h:
1577 * src/modest-ui-actions.c:
1578 * src/modest-ui-actions.h:
1579 Connect the Tools/SMTP Servers menu item to
1580 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1581 SMTP servers dialog, as in the UI specification and saves changes when it
1582 is closed. This fixed projects.maemo.org bug NB#56305 .
1584 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1586 * src/maemo/modest-connection-specific-smtp-window.c:
1587 (modest_connection_specific_smtp_window_init):
1588 Use gtk_window_set_default_size() to make this window big enough, so
1589 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1591 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1594 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1595 (modest_connection_specific_smtp_edit_window_init),
1596 Do not try to connect to a combobox signal before the combobox exists.
1597 This fixes the cras in projects.maemo.org bug NB#56288 .
1598 (modest_connection_specific_smtp_edit_window_get_settings):
1599 Remove the server_account_name parameter which was being checked for NULL
1600 though it was not used.
1602 * src/maemo/modest-connection-specific-smtp-window.c:
1603 (modest_connection_specific_smtp_window_fill_with_connections),
1604 (on_button_edit), (modest_connection_specific_smtp_window_init):
1605 Correct the number of treemodel columns to prevent a warning.
1606 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1607 libconic does not work.
1609 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1611 * src/modest-tny-account.c:
1612 (modest_tny_account_new_from_server_account):
1613 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1614 SMTP when "None" was chosen by the user. However, with my SMTP server that
1615 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1618 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1620 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1621 to explain the memory management issue with the ID in the ModestPair.
1623 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1624 (add_sending_page), (modest_account_assistant_finalize):
1625 * src/gnome/modest-gnome-global-settings-dialog.c:
1626 (create_updating_page), (create_composing_page):
1627 * src/gnome/modest-msg-edit-window.c: (get_transports),
1628 (init_window), (modest_msg_edit_window_finalize),
1629 (modest_msg_edit_window_get_msg_data):
1630 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1631 * src/gnome/modest-transport-widget.c:
1632 (modest_transport_widget_finalize), (smtp_configuration):
1633 * src/maemo/modest-maemo-global-settings-dialog.c:
1634 (create_updating_page), (create_composing_page):
1635 * src/maemo/modest-msg-edit-window.c: (get_transports),
1636 (init_window), (modest_msg_edit_window_finalize),
1637 (modest_msg_edit_window_get_msg_data),
1638 (modest_msg_edit_window_free_msg_data):
1639 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1640 (modest_store_widget_finalize):
1641 * src/maemo/modest-transport-widget.c:
1642 (modest_transport_widget_finalize), (smtp_configuration):
1643 * src/modest-main.c: (send_mail):
1644 * src/widgets/modest-combo-box.h:
1645 * src/widgets/modest-global-settings-dialog-priv.h:
1646 * src/widgets/modest-global-settings-dialog.c:
1647 (modest_global_settings_dialog_finalize):
1648 * src/widgets/modest-msg-edit-window.h:
1649 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1650 as long as the combo box, to prevent use of freed memory for the ID.
1652 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1655 get_accounts(), to make this clearer. Do not check for the enabled gconf
1656 key, because we do not use this for server accounts (at least, not yet).
1657 This allows us to send email again.
1659 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1661 * src/maemo/modest-platform.c:
1662 (on_modest_conf_update_interval_changed), (modest_platform_init):
1663 Only respond to this particular key change. All these strcmp()s cannot be
1666 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1668 * src/maemo/modest-maemo-global-settings-dialog.c:
1669 (current_connection): Prevent a crash in scratchbox when
1670 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1671 * src/maemo/modest-platform.c:
1672 (on_modest_conf_update_interval_changed), (modest_platform_init):
1673 Get the update interval from gconf and reset it when the gconf key changes.
1675 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1677 * src/modest-protocol-info.c:
1678 * src/modest-protocol-info.h: Adde enum-specific get functions,
1679 instead of using a ModestProtocolType enum parameter.
1681 * src/gnome/modest-account-assistant.c:
1682 * src/gnome/modest-store-widget.c:
1683 * src/gnome/modest-store-widget.h:
1684 * src/gnome/modest-transport-widget.c:
1685 * src/gnome/modest-transport-widget.h:
1686 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1687 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1688 * src/maemo/easysetup/modest-easysetup-wizard.c:
1689 * src/maemo/modest-account-settings-dialog.c:
1690 * src/maemo/modest-account-settings-dialog.h:
1691 * src/maemo/modest-store-widget.c:
1692 * src/maemo/modest-store-widget.h:
1693 * src/maemo/modest-transport-widget.c:
1694 * src/maemo/modest-transport-widget.h:
1695 * src/modest-account-mgr-helpers.c:
1696 * src/modest-account-mgr-helpers.h:
1697 * src/modest-account-mgr.c:
1698 * src/modest-account-mgr.h:
1699 * src/modest-tny-account.c:
1700 * src/modest-tny-folder.c:
1701 * src/widgets/modest-account-view.c:
1702 * src/widgets/modest-retrieve-combo-box.c:
1703 * src/widgets/modest-retrieve-combo-box.h:
1704 * src/widgets/modest-secureauth-combo-box.c:
1705 * src/widgets/modest-serversecurity-combo-box.c:
1706 * src/widgets/modest-serversecurity-combo-box.h:
1707 * tests/check_account-mgr.c:
1708 Use the specific functions, and use the re-renamed enum values for GNOME too.
1710 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1712 * src/modest-pair.h:
1713 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1714 so we can get the second based on the first.
1716 * src/maemo/modest-account-settings-dialog.h:
1717 * src/maemo/modest-account-settings-dialog.c:
1718 Added get_supported_secure_authentication_methods(), though it is mostly
1719 commented-out for now until the necessary API is committed to tinymail.
1720 (modest_account_settings_dialog_set_account_name),
1721 (save_configuration): Request the supported authentication methods from the
1722 server, so we can choose a working method.
1724 * src/modest-tny-account-store.h:
1725 * src/modest-tny-account-store.c:
1726 (modest_tny_account_store_get_session): Rename from
1727 tny_account_store_get_session().
1729 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1731 * src/modest-protocol-info.h: Split the ModestProtocol enum
1732 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1733 There was no need to have these unrelated values in one enum.
1735 * src/: many files: Adapted to changed enum. This makes the code a bit
1736 clearer, and the compiler could catch some errors.
1738 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1740 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1741 Show the detailed internal camel error message when an error happens
1742 during the configuration, so that our testers can give us more clues.
1743 For instance, in projects.maemo.org bug NB#56910 .
1745 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1747 * src/modest-tny-account.c:
1748 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1749 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1751 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1753 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1754 * src/maemo/modest-account-settings-dialog.c:
1755 (modest_account_settings_dialog_set_account_name),
1756 (save_configuration): For the incoming secure authentication checkbox,
1757 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1758 the UI specification. PLAIN does not seem to be supported for most IMAP
1759 servers anyway, and I am not sure what it would mean.
1760 However, we probably need to discover which of the secure-authentication
1761 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1762 * src/modest-account-mgr-helpers.c:
1763 (modest_account_mgr_get_server_account_data):
1765 * src/modest-tny-account.c:
1766 (modest_tny_account_new_from_server_account):
1767 Use tny_account_set_mech() to set secure-authentication methods,
1768 with some special-casing for IMAP, based on my observations of how
1771 * src/modest-account-mgr-helpers.h:
1772 * src/modest-account-mgr.c:
1773 * src/modest-defs.h: Comment that the URI is only used for local folders.
1775 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1778 parameter const, just to be neat.
1779 * src/modest-text-utils.c: (modest_text_utils_inline):
1780 End g_strconcat() with NULL, as its documentation says. This is almost
1781 certainly the cause of my crash at startup on the device. Interestingly,
1782 valgrind doesn't tell us about these errors.
1784 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1786 * scripts/build-packages: Added more precise comments about how to use
1787 this script, though I still get this error:
1788 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1789 error building tinymail
1791 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/modest-main-window.c: (on_account_update):
1794 Very slight cleanup, hoping to make it simpler to discover what causes
1795 a crash here sometimes.
1797 * src/modest-tny-account.c:
1798 (modest_tny_account_new_from_server_account): Set the port. Added
1799 comments about the options and a TODO comment because I need to find out
1800 how to specify the secure authentication method.
1802 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1804 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1805 changed CFlags paths form modest to libmodest
1807 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-account-mgr-helpers.c:
1810 (modest_account_mgr_get_server_account_data),
1811 (modest_account_mgr_free_server_account_data):
1812 * src/modest-account-mgr-helpers.h:
1813 * src/modest-account-mgr.c:
1814 (modest_account_mgr_add_server_account):
1815 * src/modest-defs.h:
1816 * src/modest-tny-account.c:
1817 (modest_tny_account_new_from_server_account):
1818 Determine the options for tny_camel_account_add_option() here,
1819 based on the settings, rather than storing them directly in gconf.
1821 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1823 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1824 Show a more friendly error dialog now that we expect (from the tinymail
1825 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1827 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1829 * src/maemo/modest-main-window.c: (on_account_update): Check that
1830 account_name is not NULL, to prevent a crash at startup that I am
1831 seeing on the N800. I do wonder why it is NULL.
1833 * src/maemo/easysetup/modest-easysetup-wizard.c:
1834 (create_page_user_details):
1835 * src/maemo/modest-account-settings-dialog.c:
1836 (create_page_user_details), (create_page_outgoing):
1837 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1838 (modest_connection_specific_smtp_edit_window_init):
1839 * src/modest-ui-actions.c:
1840 (modest_ui_actions_on_password_requested):
1841 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1842 might do something useful with the on-screen keyboard.
1844 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1846 * src/maemo/modest-main-window.c: (on_account_update):
1847 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1848 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1850 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1852 * src/modest-tny-account-store.c: (on_account_changed):
1853 Correct the signature of this signal handler.
1855 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1857 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1858 Show a HildonNote instead of a GtkDialog for Maemo.
1860 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1862 * src/widgets/modest-account-view.h:
1863 * src/widgets/modest-account-view.c: (on_account_changed),
1864 (on_account_removed). Added a boolean flag, set/unset by
1865 modest_account_view_block_conf_updates(),
1866 modest_account_view_unblock_conf_updates() to prevent unnecessary
1867 updates, but this is not very useful because the gconf notifications are
1868 so delays (maybe only on Maemo Bora).
1869 So auto-updating is turned off, and these functions do an explicit
1870 update when necessary.
1871 However, something else is still doing too much work when adding/removing
1872 accounts, probably in another part of the application.
1874 * src/maemo/modest-account-view-window.c:
1875 (on_delete_button_clicked), (on_edit_button_clicked),
1876 (on_new_button_clicked): Use the new functions.
1878 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1880 * src/modest-account-mgr-helpers.c:
1881 (modest_account_mgr_set_first_account_as_default):
1882 Sort the list of names alphabetically-by-title, so we choose the first one
1884 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1885 alphabetically by the title.
1887 This fixes projects.maemo.org bug NB#56418 .
1889 * src/modest-account-mgr-priv.c:
1890 (_modest_account_mgr_account_from_key):
1891 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1892 avoid a valgrind error, and possible random behaviour.
1894 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1896 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1897 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1898 tinymail documentation to say that this can be expected.
1899 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1900 pretty, and should not happen, but I would prefer to know when it does.
1902 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1904 * configure.ac: When using the older hildon version, probably on Bora,
1905 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1907 * src/widgets/modest-attachment-view.c:
1908 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1911 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1913 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1914 Implemented the prototype. Can be tested with
1915 tests/dbus_api/test_open_message:
1917 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1919 * src/modest-tny-account-store.c:
1920 (modest_tny_account_store_instance_init), (get_password):
1921 * src/modest-ui-actions.c:
1922 (modest_ui_actions_on_password_requested):
1923 Do not store the password in gconf, because this function is called
1924 for non-remembered passwords. Actually use the cached (in the hash map)
1925 password instead of releasing it.
1926 The password will now not be remembered if it is asked via the protected
1927 password dialog, as per the UI spec.
1929 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1931 * src/modest-defs.h:
1932 * src/modest-account-mgr-helpers.h:
1933 * src/modest-account-mgr-helpers.c:
1934 Added modest_server_account_get_username_has_succeeded(),
1935 modest_server_account_set_username_has_succeeded().
1936 (modest_server_account_set_username),
1937 Reset the has-succeeded flag if the username changes.
1939 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1940 * src/maemo/modest-connection-specific-smtp-window.c:
1941 (modest_connection_specific_smtp_window_save_server_accounts):
1942 Use modest_server_account_set_username() instead of using
1943 modest_conf_set_string() directly, so that the has-succeeded flag is always
1946 * src/modest-ui-actions.c:
1947 (modest_ui_actions_on_password_requested): Dim the username entry if
1948 the username has ever worked, as per the UI spec.
1950 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1952 * src/modest-tny-account-store.c: (get_password):
1953 * src/modest-ui-actions.c:
1954 (modest_ui_actions_on_password_requested):
1955 Allow the username to be changed too, though there is more work to
1956 be done on exactly how this behaves.
1958 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-account-mgr-helpers.h:
1961 * src/modest-account-mgr-helpers.c:
1962 Added modest_account_mgr_get_display_name(),
1963 modest_server_account_get_username(),
1964 modest_server_account_set_username(),
1965 modest_server_account_set_password(),
1966 modest_server_account_get_hostname() functions so we do not need to
1967 use the conf API directly.
1969 * src/maemo/modest-main-window.c: (connect_signals):
1970 Actually connect ot the ModestAccountStore::request-password signal,
1971 so that we show the dialog when the password is requested by Tinymail,
1972 for isntance if it is empty.
1974 * src/modest-marshal.list:
1975 * src/modest-tny-account-store.c:
1976 (modest_tny_account_store_class_init), (get_password),
1977 (modest_tny_account_store_alert):
1978 * src/modest-tny-account-store.h:
1979 * src/modest-ui-actions.h:
1980 * src/modest-ui-actions.c:
1981 (modest_ui_actions_on_password_requested):
1982 Change the signal parameters, so it is obvious that we are providing
1983 the non human-readable server name, and receiving both the username
1984 and password, though changing of the username is not yet implemented.
1985 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1986 for the GNOME version.
1988 This should fix the projects.maemo.org bug NB#56209, though it does not
1989 work on Bora, because the gconf_client_get() for the password fails
1990 immediately after we save it with gconf_client_set().
1992 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1995 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1996 caused an undefined symbol error:
1997 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1999 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2001 * src/modest-tny-account-store.c:
2002 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2003 using a GError instead of a string message, so we can translate it in
2006 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2008 * src/maemo/modest-address-book.c:
2009 (modest_address_book_check_names):
2010 * src/maemo/modest-msg-view-window.c:
2011 (modest_msg_view_window_clipboard_owner_change):
2012 * src/modest-init.c: (modest_init_init_ui):
2013 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2014 (update_folders_cb), (modest_mail_operation_update_account):
2015 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2016 (modest_ui_actions_on_msg_attachment_clicked),
2017 (modest_ui_actions_on_msg_recpt_activated):
2018 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2019 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2020 (modest_msg_view_search_next):
2021 * src/widgets/modest-recpt-editor.c:
2022 (modest_recpt_editor_on_button_release_event),
2023 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2024 g_message(). At this point we should only be seeing interesting errors on
2025 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2027 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2029 (modest_wizard_dialog_force_title_update):
2030 * src/maemo/easysetup/modest-wizard-dialog.h:
2031 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2032 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2033 can update the title when appropriate. Otherwise the title is wrong if the
2034 pages are added after adding the notebook to the dialog.
2035 This must be a problem in HildonWizardDialog too.
2036 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2038 * src/maemo/easysetup/modest-easysetup-wizard.c:
2039 (create_subsequent_customsetup_pages),
2040 (create_subsequent_easysetup_pages):
2041 Call modest_wizard_dialog_force_title_update() so that the title is
2042 correct even with GTK+ < 2.10.
2043 This fixes projects.maemo.org bug NB#56145 .
2045 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2047 * src/maemo/modest-platform.c:
2048 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2049 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2052 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2054 * src/widgets/modest-window.h:
2055 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2056 and modest_window_save_state(), which invokes it.
2058 * src/widgets/modest-window-mgr.h:
2059 * src/widgets/modest-window-mgr.c:
2060 Added modest_window_mgr_save_state_for_all_windows(), which calls
2061 the save_state vfunc on all registered windows, if implemented.
2063 * src/gnome/modest-msg-edit-window.c:
2064 * src/gnome/modest-msg-view-window.c:
2065 * src/maemo/modest-msg-edit-window.c:
2066 * src/maemo/modest-msg-view-window.c:
2067 * src/maemo/modest-main-window.c:
2068 Specify the existing save_settings functions as implementations of
2069 ModestWindow::save_state_func().
2071 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2072 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2073 enabling hibernation, for instance.
2075 We may need to do the same thing for restoring settings.
2078 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2080 * src/widgets/modest-window-mgr.c:
2081 * src/widgets/modest-window-mgr.h:
2082 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2083 modest_window_mgr_get_hibernation_is_prevented().
2085 * src/maemo/modest-main-window.c:
2086 (on_hildon_program_is_topmost_notify): Prevent hibernation
2087 (possible when the application goes to the background in the WM),
2088 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2090 * src/maemo/easysetup/modest-easysetup-wizard.c:
2091 (modest_easysetup_wizard_dialog_init):
2092 * src/maemo/modest-account-settings-dialog.c:
2093 (modest_account_settings_dialog_init):
2094 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2095 (modest_connection_specific_smtp_edit_window_init):
2096 * src/maemo/modest-connection-specific-smtp-window.c:
2097 (modest_connection_specific_smtp_window_init):
2098 * src/maemo/modest-signature-editor-dialog.c:
2099 (modest_signature_editor_dialog_init):
2100 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2101 prevent hibernation while any of these account settings dialogs are open.
2103 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/Makefile.am:
2106 * src/maemo/modest-osso-state-saving.c:
2107 * src/maemo/modest-osso-state-saving.h: Added
2108 modest_osso_load_state() and modest_osso_save_state() though they do
2109 nothing now. They should iterate through all the open windows and load/save
2111 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2112 save state when closing.
2114 * src/maemo/modest-main-window.c:
2115 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2116 Add a notification handler for the HildonProgram::is-topmost property,
2117 so we can allow hibernation when the application goes into the background.
2118 But we still need to detect when the accounts setup windows are open so
2119 we can stop hibernation when they are open.
2120 To do this, I also added the main window the HildonProgram. This might have
2121 other side-effects/benefits, and should maybe be done for other windows.
2123 * src/maemo/modest-osso-autosave-callbacks.h:
2124 * src/maemo/modest-osso-autosave-callbacks.c:
2125 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2126 though it does not do anything yet, and we might never need this to do
2127 anything. For instance, we already save drafts.
2129 * src/maemo/modest-platform.c: (modest_platform_init):
2130 Specify the libosso auto-save callback.
2132 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2134 * src/maemo/modest-platform.c:
2135 (modest_platform_set_update_interval):
2136 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2137 aparently stays valid between application instances, so we can use this
2138 to remove and reset it later. According to a maemo-developers email from
2141 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2143 * configure.ac: Depend on libalarm for Maemo.
2145 * src/dbus_api/modest-dbus-api.h:
2146 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2147 (on_send_receive), (modest_dbus_req_handler):
2148 Handle a SEND_RECEIVE D-Bus method.
2150 * libmodest-dbus-client/libmodest-dbus-client.c:
2151 (libmodest_dbus_client_send_and_receive):
2152 * libmodest-dbus-client/libmodest-dbus-client.h:
2153 Add C convenience functions for calling the new D-Bus method.
2155 * src/modest-platform.h:
2156 * src/gnome/modest-platform.c:
2157 * src/maemo/modest-platform.c:
2158 Added modest_platform_set_update_interval(), which uses the
2159 alarmd API on Maemo.
2160 (modest_platform_init),
2161 Call modest_platform_set_update_interval(), using a hard-coded
2162 interval for now (until the global settings dialog is implemented),
2163 though I am not sure that this makes sense yet.
2165 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2167 * src/dbus_api/modest-dbus-callbacks.c:
2168 (modest_osso_cb_hw_state_handler):
2169 * src/dbus_api/modest-dbus-callbacks.h:
2170 * src/maemo/modest-platform.c: (modest_platform_init):
2171 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2172 in case this has some effect on the ability for Maemo to ping the
2175 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2177 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2178 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2179 warning. It is probably a logic error, but I need to fix the build.
2181 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-account-mgr.h:
2184 * src/modest-account-mgr.c:
2185 (modest_account_mgr_account_names): Add a gboolean enabled_only
2186 parameter, so we can get lists of onlt the enabled accounts.
2188 (modest_account_mgr_add_account),,
2189 (modest_account_mgr_account_with_display_name_exists):
2190 * src/maemo/modest-msg-edit-window.c: (get_transports):
2191 * src/modest-account-mgr-helpers.c:
2192 (modest_account_mgr_set_first_account_as_default):
2193 * src/modest-init.c: (init_default_account_maybe):
2194 * src/modest-tny-account-store.c: (get_accounts):
2195 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2196 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2197 * tests/check_account-mgr.c: (START_TEST):
2198 Provide the extra parameter, as appropriate.
2200 * src/widgets/modest-account-view.c: (update_account_view):
2201 Do not show disabled accounts (meaning that there is no way to
2202 enable/disable accounts in the UI (the feature is not in our UI
2203 specification), so we can use this internally only to mark unfinished
2204 or temporary account data.
2206 * src/maemo/easysetup/modest-easysetup-wizard.c:
2207 (create_account): Add boolean enable parameter, so we can specify FALSE
2208 to create the temporary account.
2209 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2210 (on_before_next): When finishing, when there is a temporary account, just
2212 Also, use a timeout to delay the showing of the dialog until gconf is likely
2213 to return correct information, due to a maemo gconf bug that is fixed in
2214 osso 1.1, but not yet in Bora.
2215 However, the dialog stays on screen after it is destroyed.
2217 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2218 for invalid data when cancelling. Use a hildon note instead of a dialog
2219 to complain about invalid data. Do not show the account-saved note if the
2220 account is disabled (a temporary account that will not really be saved for use
2223 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2225 * src/modest-account-mgr-helpers.h:
2226 * src/modest-account-mgr-helpers.c:
2227 Added modest_account_mgr_unset_default_account(),
2228 Added modest_account_mgr_set_first_account_as_default().
2230 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2231 If it was the default account, unset the default account name.
2233 * src/maemo/modest-account-view-window.c:
2234 (on_delete_button_clicked): If it was the default account,
2235 set the first remaining account as the default instead.
2237 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2238 a NULL account or a NULL default account, to prevent a crash. This should
2239 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2242 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2244 * src/widgets/modest-recpt-editor.c:
2245 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2246 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2247 TODO comment for this. This fixes the build.
2249 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2250 be the best place for it. This will in future update all auto-update accounts,
2251 rather than just the current/default account, when that gconf key exists.
2252 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2253 if there are no accounts, before calling do_send_receive().
2254 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2256 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2257 * src/maemo/modest-main-window-ui.h:
2258 * src/maemo/modest-main-window.c: (on_connection_changed),
2259 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2260 directly, becaue the signal handler does more.
2262 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2264 * src/modest-account-mgr-helpers.c:
2265 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2266 for the case that the account does not exist.
2268 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2269 (equivalent to the modest account name) rather than the tinymail account name
2270 (equivalent to the modest account title - human readable) to get the account data.
2271 Check for null account data to prevent the crash, and add a TODO comment saying that
2272 this needs fixing because it is using the server account name instead of the account name.
2274 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2276 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2277 * src/maemo/modest-account-settings-dialog.c: (show_error),
2279 Use hildon_note_new_information() for informative and error messages,
2280 which seems to be expected for Maemo applications (no documentation that I know of
2281 says this). I am surprised that there is no distinction between info and error
2284 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2286 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2287 it is easy to find where this is used.
2289 * src/maemo/easysetup/modest-easysetup-wizard.c:
2290 (create_page_welcome), (create_page_account_details),
2291 (create_page_user_details), (create_page_complete_easysetup),
2292 (create_page_custom_incoming), (create_page_custom_outgoing),
2293 (create_page_complete_custom):
2294 * src/maemo/modest-account-settings-dialog.c:
2295 (create_page_account_details), (create_page_user_details),
2296 (create_page_incoming), (create_page_outgoing):
2297 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2299 (modest_connection_specific_smtp_edit_window_init):
2300 * src/maemo/modest-connection-specific-smtp-window.c:
2301 (modest_connection_specific_smtp_window_init):
2302 * src/maemo/modest-signature-editor-dialog.c:
2303 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2304 and scrolling policy as per the Email Application Layout Guide, if I have
2307 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2309 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2310 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2311 which were empty, because these vfuncs have been removed from TnyAccountStore.
2312 This fixes the build.
2314 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2316 * src/maemo/modest-main-window.c:
2317 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2318 showing/hiding it. Added TODO because it probably should not be NULL.
2319 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2320 because unnecessary g_warnings() make degugging difficult.
2322 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2324 * src/maemo/modest-msg-edit-window.c:
2325 (modest_msg_edit_window_select_color),
2326 (modest_msg_edit_window_select_background_color): 2 const corrections and
2327 moving 2 #endifs before closing brackets, to fix the build.
2329 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2331 * src/maemo/easysetup/modest-easysetup-wizard.h:
2332 * src/maemo/easysetup/modest-easysetup-wizard.c:
2333 (modest_easysetup_wizard_dialog_finalize),
2334 (on_button_edit_advanced_settings), (create_page_complete_custom),
2335 (on_response), (create_account):
2336 Implement the Advanced Settings edit button, by saving the account information,
2337 for the Advanded Settings dialog to use directly from gconf, and removing it
2338 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2339 Bug #5533 in the projects.maemo.org bugzilla.
2341 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/modest-msg-view-window.c:
2344 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2345 when opening a message window.
2347 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2349 * src/maemo/easysetup/modest-easysetup-wizard.c:
2350 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2353 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2354 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2355 gconf settings. I probably added more checks than necessary, but that is safer.
2357 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2358 variable to fix the build, but this seems to be used when it is still NULL.
2360 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2362 * src/modest-platform.h:
2363 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2364 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2365 * src/modest-main.c: Implement this function so we can avoid using
2366 maemo-specific API from cross-platform code.
2368 * src/modest-tny-account-store.c:
2369 (get_smtp_specific_transport_account_for_open_connection):
2370 * src/modest-ui-actions.c: (check_for_connection),
2371 (modest_ui_actions_on_item_not_found):
2372 Use modest_platform_connect_and_wait() and put #idefs around other
2373 maemo-specific code, because only maemo currently has a way to
2374 identify connection names.
2376 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2378 * src/modest-tny-account-store.h:
2379 * src/modest-tny-account-store.c:
2380 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2381 the connection-specific SMTP server settings in the configuration.
2383 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2385 * src/maemo/modest-main-window.c: (on_connection_changed),
2387 * src/modest-main.c: (main), (start_ui), (send_mail):
2388 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2389 that is what is intended.
2391 * src/modest-ui-actions.c: (action_send), (action_receive),
2392 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2393 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2394 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2395 SMTP server is used when it is specified.
2397 (modest_ui_actions_on_send_receive):
2398 Check that a connection is open before proceeding.
2399 Receive and then send, instead of vice-versa, as per the specification.
2401 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-mail-operation.c:
2404 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2405 though I guess it should be something other than NULL.
2407 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/easysetup/modest-easysetup-wizard.c:
2410 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2411 combo twice, to avoid an g_warning and to make it visible again.
2412 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2413 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2414 (already intended) dereference when detaching, because we then recreate the menu.
2415 But I am not sure why the warning was happening, and it is possible that this is a memory
2418 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2420 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2421 and uri_parse_mailto() utility functions.
2422 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2424 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2426 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2428 * src/dbus_api/modest-dbus-api.h:
2429 * src/dbus_api/modest-dbus-callbacks.c:
2430 Use an idle callback to execute the modest code in the application's own thread.
2431 Remove the helloworld example method.
2432 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2433 parsed, and the open-message method is not implemented because this is not yet implemented in
2435 * libmodest-dbus-client/libmodest-dbus-client.c:
2436 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2437 (libmodest_dbus_client_open_message):
2438 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2440 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2441 body without crashing.
2443 * tests/dbus_api/Makefile.am:
2444 * tests/dbus_api/test_mail_to.c:
2445 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2447 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2449 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2450 Added file to fix the build. Sorry.
2452 * src/dbus_api/Makefile.am:
2453 * src/dbus_api/modest-dbus-api.h:
2454 * src/dbus_api/modest-dbus-callbacks.h:
2455 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2456 (modest_dbus_req_handler):
2457 Put constants in a separate header so it can be reused by the
2458 client library, without duplication
2460 * libmodest-dbus-client/Makefile.am:
2461 * libmodest-dbus-client/libmodest-dbus-client.c:
2462 (libmodest_dbus_client_call_helloworld),
2463 (libmodfest_dbus_client_send_mail),
2464 (libmodfest_dbus_client_mailto),
2465 (libmodfest_dbus_client_open_message):
2466 * libmodest-dbus-client/libmodest-dbus-client.h:
2467 (Partly) Implement a send_mail D-Bus method.
2469 * tests/dbus_api/Makefile.am:
2470 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2471 the send_email D-Bus method.
2473 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2477 * libmodest-dbus-client/Makefile.am:
2478 * libmodest-dbus-client/libmodest-dbus-client.c:
2479 * libmodest-dbus-client/libmodest-dbus-client.h:
2480 * tests/dbus_api/Makefile.am:
2481 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2482 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2484 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2486 * src/maemo/easysetup/modest-easysetup-wizard.c:
2487 (create_page_account_details):
2488 * src/maemo/modest-account-settings-dialog.c:
2489 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2490 widgets, because this might not be the default in future versions of the Maemo GTK+.
2491 However, I can not not get capitalization to work even in a simple test case.
2493 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/easysetup/modest-easysetup-wizard.c:
2496 (create_page_custom_incoming), (create_page_custom_outgoing):
2497 * src/maemo/modest-account-settings-dialog.c:
2498 (create_page_account_details), (create_page_incoming),
2499 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2500 instead of using gtk_check_button_with_label(), so they are aligned like the other
2501 widgets, as per the UI spec.
2503 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2505 * src/maemo/easysetup/modest-easysetup-wizard.c:
2506 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2507 * src/widgets/modest-validating-entry.c:
2508 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2509 Modest prefix instead of an EasySetup prefix.
2511 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2513 * src/widgets/modest-validating-entry.h:
2514 * src/widgets/modest-validating-entry.c: (on_insert_text),
2515 Added easysetup_validating_entry_set_max_func(), used to set a callback
2516 to call when the max number of characters is reached. GtkEntry has a max-length
2517 already but is silent about it.
2519 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2520 (create_page_account_details), (create_page_user_details),
2522 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2523 (create_page_account_details), (create_page_user_details),
2524 (create_page_outgoing):
2525 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2526 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2527 the UI spec, when the user tries to enter more than the max number of characters.
2529 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/easysetup/modest-easysetup-wizard.c:
2532 (create_page_user_details), (create_page_custom_incoming),
2533 (create_page_custom_outgoing):
2534 * src/maemo/modest-account-settings-dialog.c:
2535 (create_page_user_details), (create_page_incoming),
2536 (create_page_outgoing):
2537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2538 (modest_connection_specific_smtp_edit_window_init):
2539 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2540 not appropriate. Bad Maemo-specific defaults!.
2542 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2544 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2545 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2546 (modest_signature_editor_dialog_set_settings):
2547 Disable the label and textview when the checkbox is disabled, and use the
2548 specified (UI spec) default signature text.
2550 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2552 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2553 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2555 * src/modest-defs.h:
2556 * src/modest-account-mgr-helpers.h:
2557 * src/modest-account-mgr-helpers.c:
2558 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2560 * src/maemo/Makefile.am:
2561 * src/maemo/modest-signature-editor-dialog.c:
2562 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2565 * src/maemo/modest-account-settings-dialog.h:
2566 * src/maemo/modest-account-settings-dialog.c:
2567 (modest_account_settings_dialog_finalize), (on_button_signature),
2568 (save_configuration): Use the new dialog when the Edit button is pressed, and
2569 save the changes if necessary, as per the UI spec.
2571 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/Makefile.am:
2574 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2575 based on maemo-develoers email from Dirk.
2577 * src/maemo/easysetup/modest-easysetup-wizard.c:
2578 (create_page_welcome), (create_page_account_details),
2579 (create_page_user_details), (create_page_complete_easysetup),
2580 (create_page_custom_incoming), (create_page_custom_outgoing),
2581 (create_page_complete_custom),
2582 (modest_easysetup_wizard_dialog_init):
2583 * src/maemo/modest-account-settings-dialog.c:
2584 (create_page_account_details), (create_page_user_details),
2585 (create_page_incoming), (create_page_outgoing),
2586 (modest_account_settings_dialog_init):
2587 * src/maemo/modest-connection-specific-smtp-window.c:
2588 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2590 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/easysetup/modest-easysetup-wizard.c:
2593 (create_page_account_details), (create_page_custom_outgoing),
2594 (create_page_complete_custom):
2595 * src/maemo/modest-account-settings-dialog.c:
2596 (create_page_user_details), (create_page_incoming),
2597 (create_page_outgoing):
2598 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2599 (modest_connection_specific_smtp_edit_window_init):
2600 Use the correct (UI spec) port min/max, and use horizontal separators,
2603 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2605 * src/maemo/easysetup/modest-easysetup-wizard.c:
2606 (set_default_custom_servernames):
2607 * src/maemo/modest-account-settings-dialog.c:
2608 (create_page_incoming), (on_combo_outgoing_security_changed),
2609 (on_combo_incoming_security_changed), (create_page_outgoing),
2610 (modest_account_settings_dialog_set_account_name),
2611 (save_configuration):
2612 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2613 (on_combo_security_changed),
2614 (modest_connection_specific_smtp_edit_window_init),
2615 (modest_connection_specific_smtp_edit_window_set_connection),
2616 (modest_connection_specific_smtp_edit_window_get_settings):
2617 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2620 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2623 * src/maemo/easysetup/modest-easysetup-wizard.c:
2624 (create_page_custom_outgoing), (create_page_complete_custom):
2625 * src/maemo/modest-account-settings-dialog.c:
2626 (create_page_user_details), (create_page_outgoing):
2627 * src/maemo/modest-account-view-window.c: (button_box_new):
2628 Use changed logical IDs as per the most recent UI spec:
2629 mcen_bd_emailsetup_edit -> mcen_bd_edit
2630 mcen_bd_emailsetup_delete -> mcen_bd_delete
2631 mcen_bd_emailsetup_close -> mcen_bd_close
2633 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2637 * src/dbus_api/Makefile.am:
2638 * src/dbus_api/modest-dbus-callbacks.c:
2639 * src/dbus_api/modest-dbus-callbacks.h:
2640 * src/maemo/modest-platform.c: (modest_platform_init):
2641 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2643 * tests/Makefile.am:
2644 * tests/dbus_api/Makefile.am:
2645 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2647 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2649 * src/maemo/modest-account-settings-dialog.c:
2650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2651 Removed unnecessary includes.
2653 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2655 * src/maemo/easysetup/modest-easysetup-wizard.c:
2656 * src/maemo/modest-account-settings-dialog.c:
2657 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2658 * src/widgets/Makefile.am:
2659 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2660 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2661 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2662 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2663 * src/widgets/modest-secureauth-combo-box.c:
2664 * src/widgets/modest-secureauth-combo-box.h:
2665 * src/widgets/modest-serversecurity-combo-box.c:
2666 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2667 made the GObject names more consistent with the rest of the Modest code.
2669 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2671 * src/maemo/easysetup/Makefile.am:
2672 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2673 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2674 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2675 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2676 * src/maemo/easysetup/modest-easysetup-wizard.c:
2677 * src/maemo/easysetup/modest-validating-entry.c:
2678 * src/maemo/easysetup/modest-validating-entry.h:
2679 * src/maemo/modest-account-settings-dialog.c:
2680 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2681 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2682 widgets/ because they are used outside of easysetup too. After checking in,
2683 svn will allow me to rename them too.
2685 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2687 * src/gnome/modest-msg-edit-window.c:
2688 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2689 linker error, to fix the build on the GNOME platform.
2690 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2691 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2692 ifdefed out to avoid a warning.
2694 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2696 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2697 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2698 some alternative for GTK+ 2.6.
2700 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2702 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2704 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2705 specified for EmailAccountsDialog in UI spec.
2707 * src/maemo/easysetup/modest-easysetup-wizard.c:
2708 * src/maemo/easysetup/modest-easysetup-wizard.h:
2709 * src/maemo/modest-account-settings-dialog.c:
2710 * src/maemo/modest-account-settings-dialog.h:
2711 Reuse a member window widget for the connection-specific SMTP server accounts,
2712 so we can tell it to create/save the accounts only if we actually save changes.
2714 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2715 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2716 (modest_connection_specific_smtp_edit_window_get_settings):
2717 Return a struct instance for temporarily remembering the entered data.
2719 * src/maemo/modest-connection-specific-smtp-window.h:
2720 * src/maemo/modest-connection-specific-smtp-window.c:
2721 (modest_connection_specific_smtp_window_finalize),
2722 (modest_connection_specific_smtp_window_fill_with_connections),
2724 (modest_connection_specific_smtp_window_save_server_accounts),
2725 (update_model_server_names): Do not actually save data until asked,
2726 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2728 (on_selection_changed),
2729 (modest_connection_specific_smtp_window_init): Disable the edit
2730 button when nothing is selected.
2732 * src/modest-account-mgr-helpers.c:
2733 * src/modest-account-mgr-helpers.h:
2734 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2737 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2739 * src/modest-account-mgr-helpers.h:
2740 * src/modest-account-mgr-helpers.c:
2741 (modest_account_mgr_get_unused_account_name),
2742 (modest_account_mgr_get_unused_account_display_name): Added these
2743 utility functions, to avoid code duplication.
2745 * src/maemo/easysetup/modest-easysetup-wizard.c:
2746 (create_page_account_details), (create_account):
2747 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2748 (on_combo_security_changed),
2749 (modest_connection_specific_smtp_edit_window_init),
2750 (modest_connection_specific_smtp_edit_window_save_settings):
2751 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2752 * src/maemo/modest-connection-specific-smtp-window.c:
2753 (modest_connection_specific_smtp_window_finalize),
2754 (modest_connection_specific_smtp_window_fill_with_connections),
2755 (on_button_edit), (modest_connection_specific_smtp_window_init):
2756 * src/maemo/modest-connection-specific-smtp-window.h:
2757 Implementing saving of connection-specific server accounts.
2759 But I need to refactor this so we can save the data for each
2760 possible connection-specific account and only actually create the server accounts
2761 when the easysetup finished, or the OK button is pressed on the account settings
2764 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2767 (on_combo_security_changed):
2768 (modest_connection_specific_smtp_edit_window_init):
2769 Auto-fill the port number as in the account settings.
2771 (modest_connection_specific_smtp_edit_window_set_connection):
2772 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2773 * src/maemo/modest-connection-specific-smtp-window.c:
2774 (fill_with_connections), (on_button_edit),
2775 (modest_connection_specific_smtp_window_init):
2776 Turn the edit window into a dialog to simplify the code, and
2777 set a WM hint as in a GtkDialog, because only a popup can be on top of
2778 another window in Maemo, and popups usually have no WM decoration.
2780 * src/modest-defs.h:
2781 * src/modest-account-mgr-helpers.c:
2782 (modest_account_mgr_set_connection_specific_smtp),
2783 (modest_account_mgr_remove_connection_specific_smtp),
2784 (modest_account_mgr_get_connection_specific_smtp):
2785 * src/modest-account-mgr-helpers.h: Some functions to write the
2786 connection-specific SMTP server information. Not yet used.
2789 * src/widgets/modest-folder-view.c: (text_cell_data):
2790 Fix a warning about an uninitialized variable.
2791 (on_configuration_key_changed): Put an #ifdef around the use
2792 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2794 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2796 * src/maemo/modest-account-settings-dialog.h:
2797 * src/maemo/modest-account-settings-dialog.c:
2798 Added connect_for_modified() utility function to mark the new modified boolean.
2800 (create_page_account_details), (create_page_user_details),
2801 (create_page_incoming), (create_page_outgoing), (on_response),
2802 (modest_account_settings_dialog_init),
2803 (modest_account_settings_dialog_set_account_name):
2804 Only warn about unsaved changes when there are actually unsaved changes.
2806 * src/modest-account-mgr-helpers.c:
2807 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2808 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2809 to get the data from there in future.
2811 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2813 * src/modest-defs.h:
2815 * src/modest-account-mgr-helpers.h:
2816 * src/modest-account-mgr-helpers.c:
2817 Store the security account setting in a single conf key instead of using
2818 the options list, so that the list is left for just the to-be-removed camel hack,
2819 and because gconf_client_set_list() is failing for some reason.
2821 * src/modest-account-mgr.c:
2822 (modest_account_mgr_add_server_account):
2823 * src/maemo/modest-account-settings-dialog.c:
2824 (modest_account_settings_dialog_set_account_name),
2825 (save_configuration): Use the renamed functions.
2828 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2830 * src/widgets/Makefile.am:
2831 * src/widgets/modest-limit-retrieve-combo-box.c:
2832 * src/widgets/modest-limit-retrieve-combo-box.h:
2833 * src/widgets/modest-retrieve-combo-box.c:
2834 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2835 the account settings dialog.
2837 * src/modest-defs.h:
2838 * src/modest-account-mgr-helpers.h:
2839 * src/modest-account-mgr-helpers.c:
2840 (modest_server_account_get_option_secure_auth),
2841 (modest_server_account_set_option_secure_auth):
2842 * src/modest-account-mgr.c:
2843 (modest_account_mgr_add_server_account):
2844 Use the existing AUTH_MECH conf key for the secure-auth setting,
2845 instead of putting it in the list options, because this was actually used already.
2847 * src/maemo/modest-account-settings-dialog.c:
2848 (create_page_account_details),
2849 (modest_account_settings_dialog_set_account_name),
2850 (save_configuration):
2851 * src/maemo/modest-account-settings-dialog.h:
2852 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2853 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2855 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2857 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2858 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2859 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2861 * src/modest-defs.h:
2862 * src/maemo/modest-account-settings-dialog.c:
2863 (create_page_incoming), (on_combo_outgoing_security_changed),
2864 (on_combo_incoming_security_changed), (create_page_outgoing),
2865 (modest_account_settings_dialog_set_account_name),
2866 (save_configuration): Load/Save the port number, and change it when the
2867 security combo changes, to suitable defaults.
2869 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2871 * src/modest-account-mgr.c:
2872 (modest_account_mgr_add_server_account): Set the security and secure-auth
2873 options, and add a comment saying that the other camel-specific options should be
2876 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2880 * src/modest-tny-account-store.c: (account_list_free),
2881 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2882 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2885 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2887 * src/modest-protocol-info.c:
2888 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2889 is required by our UI spec. Maybe something in our implementation will use this eventually.
2890 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2891 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2892 instead of the previous 0 placeholder.
2894 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2895 secure-auth settings.
2896 * src/modest-account-mgr-helpers.h:
2897 * src/modest-account-mgr-helpers.c:
2898 (modest_server_account_data_get_option_secure_auth),
2899 (modest_server_account_set_option_secure_auth),
2900 (modest_server_account_data_get_option_security),
2901 (modest_server_account_set_option_security): Added this API for getting and setting the security
2902 and secure-auth settings.
2904 * src/maemo/modest-account-settings-dialog.h:
2905 * src/maemo/modest-account-settings-dialog.c:
2906 (modest_account_settings_dialog_finalize), (check_data),
2907 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2908 about changing titles.
2909 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2910 (save_configuration): Save the security and secure-auth settings.
2912 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2913 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2915 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2917 * src/modest-defs.h:
2918 * src/modest-account-mgr.c:
2919 (modest_account_mgr_add_server_account):
2920 Added and used defines for the options key and value pair strings,
2921 that are used so far, though they do not seem to correspond to anything in our
2922 UI specs or ModestProtocol enum.
2924 * src/modest-account-mgr-helpers.h:
2925 * src/modest-account-mgr-helpers.c:
2926 (compare_option_strings_for_name),
2927 (modest_server_account_data_get_option_value),
2928 (modest_server_account_data_get_option_bool),
2929 (modest_account_mgr_get_server_account_option):
2930 Added helper functions for parsing the options GSList.
2932 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2934 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2935 display name is based on the supplied account name.
2936 * src/modest-account-mgr.c:
2937 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2938 with an inefficient, but good-enough, implementation.
2940 * src/maemo/easysetup/modest-easysetup-wizard.c:
2941 (create_page_account_details), (on_before_next), (create_account):
2942 Check for existing display names rather than (non-user-visible) account names, and just
2943 create and set a unique account name at the end.
2945 * src/maemo/modest-account-settings-dialog.c:
2946 (modest_account_settings_dialog_init),
2947 (modest_account_settings_dialog_set_account_name),
2948 (create_page_incoming): Show the display name, instead of the account name.
2949 (on_response): Do some (not all) extra checks, as in the UI spec.
2950 (save_configuration): Save the display name if it was changed.
2952 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2954 * po/en_GB.po: Added needed logical ID and translation.
2955 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2956 (init_view): Made the is-default column clicking work.
2958 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2961 * src/maemo/easysetup/Makefile.am:
2962 * src/maemo/easysetup/modest-easysetup-wizard.c:
2963 (modest_easysetup_wizard_dialog_init):
2964 * src/maemo/easysetup/provider-data-test.keyfile:
2965 * src/maemo/easysetup/provider-data.keyfile:
2966 Moved the provider data file to the new modest-providers-data package and used it from there.
2968 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2970 * src/modest-local-folder-info.c:
2971 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2972 N_() was already used on the static strings, but this just marks it for translation without
2973 using the translation.
2975 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2977 * src/maemo/modest-account-settings-dialog.c:
2978 (create_page_incoming),
2979 (modest_account_settings_dialog_set_account_name):
2980 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2981 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2982 I will do this if nobody else gets there first.
2984 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2986 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2987 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2988 save the security stuff.
2990 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2992 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2993 Set the email address and user fullname, which I now see must be
2996 * src/maemo/modest-account-settings-dialog.h:
2997 * src/maemo/modest-account-settings-dialog.c:
2999 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3000 leave-on-server and authentication.
3001 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3004 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3007 * src/maemo/modest-account-settings-dialog.c:
3008 * src/maemo/modest-account-settings-dialog.h:
3009 Most (but not all) of the widgets are now present as specified by the UI spec.
3010 No changes are yet saved, and some details are not properly shown yet.
3012 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3014 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/Makefile.am:
3017 * src/maemo/modest-account-settings-dialog.c:
3018 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3019 an existing account. Doesn't do much yet.
3021 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3022 Open the accounts settings dialog when Edit is clicked.
3024 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3026 * src/maemo/easysetup/Makefile.am:
3027 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3029 * src/maemo/easysetup/modest-easysetup-wizard.c:
3030 (modest_easysetup_wizard_dialog_init):
3031 Try to get the source directory from the build system,
3032 instead of hard-coding "./" into the source code, when opening our local
3033 copies of the configuration files.
3034 But this still fails when opening the wizard from the Accounts window,
3035 maybe because the working directory seems to change at runtime.
3036 So the wizard will fail the second time unless you copy the files into their
3037 proper locations - see the stdout warnings for the paths.
3039 (create_page_account_details),(on_before_next):
3040 Check for existing non-server accounts instead of server accounts,
3041 so the default account name is useful again, and to prevent trying to
3044 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3045 Show the wizard when New is clicked.
3047 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3048 (init_view): Show the column headers, and show the columns that are
3049 specified in the UI specs. However, something in Maemo's GTK+ prevents
3050 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3051 change the default account. This is despite unsetting the special properties.
3053 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3055 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3056 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3057 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3058 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3059 to make that clearer.
3060 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3062 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3064 * src/maemo/modest-account-view-window.c:
3065 (modest_account_view_window_init),
3066 (modest_account_view_window_new):
3067 Use the same buttons as specified in the
3068 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3069 the existing widgets, which never had a chance of working.
3070 Put the ModestAccountView treeview in a scrolled window.
3071 Do not repeat the initialization in both _init() and _new().
3073 * src/widgets/modest-account-view.c: (update_account_view):
3074 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3075 this widget and window shows no accounts.
3077 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3079 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3081 * src/maemo/easysetup/modest-easysetup-wizard.c:
3082 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3083 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3084 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3087 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3088 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3089 accounts exist yet, as in the UI spec.
3091 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3093 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3095 * src/maemo/Makefile.am:
3096 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3097 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3098 New window for editing connection-specific smtp details.
3099 Not fully implemented.
3101 * src/maemo/modest-connection-specific-smtp-window.c:
3102 (modest_connection_specific_smtp_window_finalize) :
3103 unref the tree model.
3104 (on_button_edit): Show the edit window.
3106 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3108 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3111 * src/maemo/Makefile.am:
3112 * src/maemo/modest-connection-specific-smtp-window.c:
3113 * src/maemo/modest-connection-specific-smtp-window.h:
3114 New window for showing the list of connections, for connection-specific
3115 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3116 * src/maemo/easysetup/modest-easysetup-wizard.c:
3117 (create_page_custom_outgoing): Show the new window when the button is clicked.
3119 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3121 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3122 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3123 * src/maemo/modest-msg-edit-window.c:
3124 (modest_msg_edit_window_insert_image):
3125 * src/modest-conf.c: (modest_conf_key_escape):
3126 * src/modest-mail-operation.c:
3127 (modest_mail_operation_send_new_mail):
3128 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3129 (modest_ui_actions_on_new_account):
3130 * src/widgets/modest-attachment-view.c: (update_filename_request):
3131 * src/widgets/modest-mail-header-view.c:
3132 Corrected warnings that were breaking the build, by commenting out unused variables,
3133 and a function, and by including a header.
3135 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3137 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3138 so we can #ifdef around platform-specific code when necessary.
3139 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3140 to allow this to build for the GNOME platform too.
3142 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3144 * src/maemo/easysetup/modest-easysetup-wizard.c:
3145 Added util_increment_name() and used it in create_page_account_details()
3146 to make sure that the default account name is always a new name.
3148 (modest_easysetup_wizard_dialog_init),
3149 (set_default_custom_servernames): Some minor memory management fixes.
3151 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3155 * src/modest-runtime.c: (init_i18n): Restored the translation
3156 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3157 are defined in config.h, and the translations are installed.
3159 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3160 is defined for translation.
3162 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3164 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3166 * src/maemo/easysetup/modest-easysetup-wizard.c:
3167 (modest_easysetup_wizard_dialog_init):
3168 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3169 Use realistic paths (though they should use $prefix generically) to the
3170 mcc_mapping and provider-data.keyfile files which might work when they
3171 are installed by the future version of the operator-wizard package,
3172 and then fallback to paths in our source code, with an explanatory
3175 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3179 * src/maemo/Makefile.am:
3180 * src/maemo/easysetup/: Added files from the previously-exernal
3181 osso-modest-easysetup.
3182 * src/maemo/modest-main-window-ui.h:
3183 * src/modest-ui-actions.c:
3184 * src/modest-ui-actions.h:
3185 Added modest_ui_actions_on_new_account() as a signal handler for the
3186 New Account menu item. It shows the easysetup wizard.
3187 * po/en_GB.po: Added additional needed logical IDs and translations.