1 2007-08-17 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
4 Check for NULLs to prevent a crash when opening an email that is
5 an attachment in another email, fixing projects.maemo.org bug
8 2007-08-17 Murray Cumming <murrayc@murrayc.com>
10 * src/modest-ui-dimming-rules.c:
11 (modest_ui_dimming_rules_on_view_window_move_to):
12 Enable the Move To toolbar button for search results, fixing the
13 last part of projects.maemo.org bug NB#63807.
15 2007-08-17 Murray Cumming <murrayc@murrayc.com>
17 * src/dbus_api/modest-dbus-callbacks.c:
18 (check_and_offer_account_creation): Use gdk_thread_enter/leave(),
19 because this is called from idle handlers, to fix hangs afte the
21 (find_message_by_url): Added a TODO comment about a crash that
22 happens when tinymail was built with DBC checks.
24 2007-08-16 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-search.c: (modest_search_folder):
27 * src/modest-search.h: Rename ModestSearch::before to start_date
28 and after to end_date, using the same names as the libogs struct
30 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
31 The start_date and end_date were swapped in the check. This
32 fixes date range searches, fixing projects.maemo.org bug NB#63407.
34 2007-08-16 Murray Cumming <murrayc@murrayc.com>
36 * src/maemo/modest-account-view-window.c:
37 Added (check_for_active_acount).
38 (on_delete_button_clicked), (on_edit_button_clicked):
39 When an account is doing something (such as refreshing),
40 show the same warning for account deletion as for account
41 editing, to fix projects.maemo.org bug NB#64588.
43 2007-08-16 Murray Cumming <murrayc@murrayc.com>
45 * src/widgets/modest-msg-view-window.h:
46 * src/gnome/modest-msg-view-window.c:
47 * src/maemo/modest-msg-view-window.c:
48 Added modest_msg_view_window_construct().
49 (modest_msg_view_window_new_with_header_model),
50 Added modest_msg_view_window_new_for_search_result),
51 Renamed modest_msg_view_window_new() to
52 modest_msg_view_window_new_for_attachment(),
53 and modest_msg_view_window_is_search_result(),
54 so we can explicitly know that the window is for an
55 attachment or a search result or a message from the list.
57 (modest_msg_view_window_view_attachment):
58 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
59 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
60 Use modest_msg_view_window_new_for_search_result().
62 * src/modest-ui-dimming-rules.c:
63 (modest_ui_dimming_rules_on_delete_msg): Enable the delete button
64 for search results, fixing projects.maemo.org bug NB#63811.
66 2007-08-16 Armin Burgmeier <armin@openismus.com>
68 * src/modest-ui-actions.c: Show a banner instead of a dialog when
69 renaming a folder fails, to stay consistent with what happens when
70 creating a folder fails.
72 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
73 slightly country loading from the mmc_mappings file, fixed a memory
76 2007-08-16 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account-store.c: (volume_path_is_mounted):
79 Check the GnomeVFSVolume activation path instead of the device path,
80 so that the memory card is really really shown in the UI.
82 2007-08-16 Murray Cumming <murrayc@murrayc.com>
84 * src/maemo/easysetup/modest-easysetup-wizard.c:
85 (get_entered_account_title), (on_before_next), (entry_is_empty),
87 * src/maemo/modest-account-settings-dialog.c:
88 (get_entered_account_title), (on_button_signature), (check_data),
89 (save_configuration), (entry_is_empty):
90 Strip the account title of whitespace at the start and end before
91 using it or checking it. This means that an all-whitespace title
92 is not allowed, fixing projects.maemo.org bug NB#64977.
94 2007-08-15 Murray Cumming <murrayc@murrayc.com>
96 * src/modest-ui-actions.h:
97 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
98 to modest_run_account_setup_wizard() and made it public.
99 * src/dbus_api/modest-dbus-callbacks.c:
100 (check_and_offer_account_creation), (on_idle_mail_to),
101 (on_idle_compose_mail), (on_idle_open_default_inbox):
102 Offer account creation if necessary, fixing projects.maemo.org
105 2007-08-15 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-ui-actions.c: (run_account_setup_wizard):
108 Return a gboolean to indicate success.
109 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
110 (modest_ui_actions_on_send): When offering account creation, only
111 give up (return) if account creation failed. Otherwise continue
112 with the original request. This fixed projects.maemo.org bug
115 2007-08-15 Murray Cumming <murrayc@murrayc.com>
117 * src/widgets/modest-recpt-editor.c:
118 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
119 to fix projects.maemo.org bug NB#63789.
121 2007-08-15 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
124 (modest_tny_account_store_new): Properly detect the memory card at
125 startup, and add an account for it.
127 2007-08-14 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
130 Commented out the MMC code again because it mistakenly detects
131 the card even when it isn't inserted.
133 2007-08-14 Murray Cumming <murrayc@murrayc.com>
135 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
136 Renabled the call to add_mmc_account() because I do not believe
137 it could be the cause of the mentioned hang (in scratchbox, where
138 there is no memory card), and because I have tested that it works
141 2007-08-14 Murray Cumming <murrayc@murrayc.com>
143 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
144 Comment out part of the last commit because it apparently causes
147 2007-08-14 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-tny-account-store.c: Added the add_mmc_account()
150 function to save some copy/pasting.
151 (modest_tny_account_store_new): If the memory card is mounted,
152 create an account for it at the start, instead of waiting for the
153 user to unmount it and mount it.
155 2007-08-13 Murray Cumming <murrayc@murrayc.com>
157 * src/widgets/modest-account-view.c: (on_account_changed):
158 Do not try to use the human-readable TnyAccount name instead of the
159 ID of the modest account to get the transport account. And unref
160 the transport account. This prevents a g_warning(), and a possible
163 2007-08-13 Murray Cumming <murrayc@murrayc.com>
165 * src/maemo/modest-platform.c:
166 (modest_platform_set_update_interval): Handle the new
167 alarmd error to warn when alarmd is not running, as is the case in
168 scratchbox for me now because
169 "Module /usr/lib/alarmd/libretu.so initialization failed"
171 2007-08-13 Murray Cumming <murrayc@murrayc.com>
173 * src/widgets/modest-header-view-render.c:
174 (_modest_header_view_compact_header_cell_data):
175 NULL some strings after freeing them, trying to deal with
176 the double deletion found in projects.maemo.org bug 64183,
177 probably having no effect.
179 2007-08-13 Murray Cumming <murrayc@murrayc.com>
181 * src/maemo/modest-account-settings-dialog.c:
182 (create_page_incoming), (create_page_outgoing): Use a define
183 for the min and max port numbers.
185 (check_hildon_number_editor_and_warn_value_not_in_range),
186 (check_data): Do an extra check for an invalid port number, as needed
187 in projects.maemo.org bug #64275, when the number is cleared, but this
188 does not work due to bugs.maemo.org bug #1806.
190 2007-08-13 Murray Cumming <murrayc@murrayc.com>
192 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
193 Comment out the debug warning about the unexpected D-Bus methods.
194 They are just annoying now.
195 * src/maemo/modest-platform.c:
196 (modest_platform_set_update_interval): Correct the D-Bus path, instead
197 of using a file path, though it did not seem to break things before.
198 It might be needed now:
199 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
200 modest is not already running. This is the behaviour of the old client, and
201 Mox says it is what we should do for modest.
202 This closes projects.maemo.org bug NB#64327.
204 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
206 * src/modest-text-utils.c:
207 Fixed invalid jump due to incorrect string/pointer
209 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
212 2007-08-01 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-account-mgr-helpers.h:
215 * src/modest-account-mgr-helpers.c:
216 Added modest_account_mgr_get_first_account_name(),
217 using code from modest_account_mgr_set_first_account_as_default().
219 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
220 (account_number_changed): Call set_at_least_one_account_visible() so that
221 the first account is visible when first added, without the user having to
223 I do wonder how this worked before.
225 2007-08-01 Murray Cumming <murrayc@murrayc.com>
227 * src/modest-tny-account-store.c: (show_password_warning_only),
228 (show_wrong_password), (request_password_and_wait), (get_password),
229 (modest_tny_account_store_alert): Remove the (incomplete anyway)
230 attempts to show UI only in the main context, which used g_idle_add()
231 and mainloops, because tinymail now guarantees that it only calls these
232 callbacks in the mainloop with the gdk lock. This makes everything much
235 2007-08-01 Murray Cumming <murrayc@murrayc.com>
237 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
238 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
239 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
240 error dialog, instead of ignoring it.
242 2007-08-01 Murray Cumming <murrayc@murrayc.com>
244 * src/maemo/modest-msg-view-window.c:
245 (modest_msg_view_window_get_header),
246 (modest_msg_view_window_last_message_selected):
247 Added comments to explain the use of priv->header_model.
248 * src/modest-ui-dimming-rules.c:
249 (modest_ui_dimming_rules_on_open_msg),
250 (modest_ui_dimming_rules_on_mark_as_read_msg),
251 (modest_ui_dimming_rules_on_mark_as_unread_msg),
252 (modest_ui_dimming_rules_on_remove_attachments),
253 (_invalid_attach_selected), (_selected_msg_marked_as):
254 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
255 and changed the parameter to a ModestMainWindow to make it clearer that
256 it never uses any other kind of window.
257 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
258 instead of the selected message.
259 I notice that much of the dimming code and the ModestMsgViewWindow code
260 hard-codes the assumption that the viewed message is always selected in
261 the header view. This does not seem wise or simple.
263 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
264 examine the actual message instead of whatever might be selected
265 in the header view. This stops the delete toolbar button and menu item
266 from being dimmed when opening a message view the search UI,
267 partially fixing projects.maemo.org bug NB#63811.
269 However, when actually deleting, I now get this warning:
270 "tny_header_set_flags: This is a header instance for a new message.
271 Only priority and attachment flags are supported"
273 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
275 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
277 Show account wizard if no accounts are defined while sending
278 (automatic sending after the account wizard finished does not
279 work because it takes some time until the account manager
280 synchronizes everything. (projects.maemo.org NB#62792)
282 2007-07-30 Murray Cumming <murrayc@murrayc.com>
284 * src/modest-tny-account-store.c: (on_account_removed),
285 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
286 account is removed from the View menu. We have TnyAccountStore
287 and ModestTnyAccountStore signals that seem very similar, but this
288 seems to work for now.
290 * src/maemo/modest-main-window.c:
291 (on_show_account_action_activated): Prevent dereference
292 of a NULL if the accoutn does not really exist, though that
293 should not happen anymore.
295 This fixes projects.maemo.org bug NB#64606.
297 2007-07-30 Murray Cumming <murrayc@murrayc.com>
299 * src/modest-ui-actions.c: (run_account_setup_wizard),
300 (modest_ui_actions_on_accounts): Revert a change that set these
301 to modal dialogs, freezing the UI when they show secondary dialogs.
302 This fixed projects.maemo.org bug NB#64519.
304 2007-07-27 Murray Cumming <murrayc@murrayc.com>
306 * src/widgets/modest-header-view-render.c:
307 (_modest_header_view_compact_header_cell_data):
308 Some checks and initialization to try to deal with a crash,
309 probably ineffective.
311 2007-07-27 Murray Cumming <murrayc@murrayc.com>
313 * src/maemo/modest-maemo-utils.c:
314 (modest_maemo_utils_get_supported_secure_authentication_methods):
315 Make sure that we have a connection, asking the user for one
317 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
318 Check for a connection before showing the wizard, because
319 the wizard needs a connection to check for server capabilities.
321 2007-07-27 Murray Cumming <murrayc@murrayc.com>
323 * src/maemo/modest-account-view-window.c:
324 (on_new_button_clicked): Remember the wizard dialog instance,
325 so we can just present it again if necessary. This prevents
326 multiple windows from appearing if you click again quickly on the
327 New button before the dialog appears, fixing projects.maemo.org
330 2007-07-27 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
333 Offer a connection dialog if there is no connection when
334 starting modest. This should fix projects.maemo.org bug NB#61134.
336 2007-07-27 Murray Cumming <murrayc@murrayc.com>
338 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
339 Reverted my last commit. I was able to fix the build by doing
340 apt-get install wpeditor0 (replacing other wpeditor packages) and
341 an explicit apt-get install wpeditor-dev to upgrade the -dev
344 2007-07-27 Murray Cumming <murrayc@murrayc.com>
346 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
347 Commented out the use of wp_text_buffer_replace_image()
348 because it does not exist, to break the build. Added a TODO for it.
350 2007-07-26 Murray Cumming <murrayc@murrayc.com>
352 * src/modest-tny-account-store.c: (recreate_all_accounts):
353 Recreate them even if they were NULL before. I guess something
354 else was already creating them before, or this would never
356 (modest_tny_account_store_get_server_account): Make sure that
357 the tny accounts have been created before trying to find one.
358 This allows libmodest_dbus_client_compose_mail() to work
359 when the UI is not yet visible.
360 This is probably useful in other cases too.
362 (get_password): When the password is wrong after it is entered
363 in the protected password dialog, show an info banner (in an
364 idle handler) before showing the protected password dialog
367 2007-07-26 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-ui-actions.h:
370 * src/modest-ui-actions.c: Added
371 modest_do_refresh_current_folder() containing some code from
372 modest_ui_actions_on_send_receive().
373 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
374 Call modest_do_refresh_current_folder() before refreshing the
375 requested account, as in modest_ui_actions_on_send_receive().
376 This is strange, but seems to be necessary to show new mails.
377 Now new emails are finally visible in the UI when downloaded
378 via the automatic update interval, fixing bug NB#57458.
379 This also works because bug NB#57458 has been fixed somehow.
381 2007-07-26 Murray Cumming <murrayc@murrayc.com>
383 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
384 printf more details when we get unhandled D-Bus methods, because
387 * src/modest-mail-operation.c: (update_account_thread):
388 Comment out the tny_camel_pop_store_account_reconnect(), because this
389 is apparently no longer needed, and it did not work before anyway.
390 See the comment in the code.
392 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
393 by checking the header flags. This fixes projects.maemo.org bug
396 2007-07-25 Murray Cumming <murrayc@murrayc.com>
398 * src/maemo/modest-maemo-utils.h:
399 * src/maemo/modest-maemo-utils.c: Added
400 modest_maemo_show_information_note_in_main_context_and_forget().
401 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
402 Use the new function to show simple error dialogs in the main
403 context, though question dialogs are still in the current context,
404 which is unfortunately usually not the main context. This should
407 2007-07-25 Murray Cumming <murrayc@murrayc.com>
409 * src/modest-tny-account-store.c: (get_password):
410 Never save the entered username and password in gconf,
411 because the UI spec says we should not. This helps
412 slightly with projects.maemo.org bug NB#63671.
414 2007-07-25 Murray Cumming <murrayc@murrayc.com>
416 * src/widgets/modest-msg-edit-window.h:
417 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
418 Moved some code here to make it simpler.
419 (modest_msg_edit_window_attach_file_one): Renamed from
420 modest_msg_edit_window_attach_file_interactive().
421 (modest_msg_edit_window_offer_attach_file): Renamed from
422 modest_msg_edit_window_attach_file() and used
423 modest_msg_edit_window_attach_file_one() instead of
424 copy/pasting the code. The old code for one was not using
425 GnomeVFS. This allows use of smb:// URLs when using send-as
426 from external applications, fixing bug NB#63741.
428 (modest_msg_edit_window_insert_image),
429 (modest_msg_edit_window_add_attachment_clicked):
430 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
431 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
432 Adapted to the new function names.
434 2007-07-25 Murray Cumming <murrayc@murrayc.com>
436 (modest_platform_set_update_interval): Set the alarm recurrence
437 fields so that auto-update does not just happen the first time.
438 This should have fixed projects.maemo.org bug NB#63938.
440 When this happens you can see a printf when the D-Bus method is
442 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
444 However, I do not actually seem to get new POP messages even when
445 clicking the refresh button manually. A restart gets them.
446 This might be a problem in today's tinymail only.
448 2007-07-24 Murray Cumming <murrayc@murrayc.com>
450 * src/maemo/modest-maemo-global-settings-dialog.c:
451 (current_connection):
452 Avoid a crash (probably only in scratchbox) when strcmp()ing a
453 NULL when closing the dialog.
455 2007-07-24 Murray Cumming <murrayc@murrayc.com>
457 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
458 Remove the hacky send/receive that didn't work, and instead
459 refilter the treemodel to make the deleted email really vanish from
460 the UI (though the delete-from-menu code does has commented out
461 the code that does that). This fixes projects.maemo.org bug
464 2007-07-24 Murray Cumming <murrayc@murrayc.com>
466 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
467 Try a couple of tricks to force the treeview to update (
468 poke the folder, and do a send/receive refresh), but the deleted
469 email still appears with a strike-through instead of really being
472 2007-07-23 Murray Cumming <murrayc@murrayc.com>
474 * src/dbus_api/modest-dbus-callbacks.c:
475 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
476 because their ID is not human-readable (see the comment about
477 improvements needed to the osso-email-interface API) and
478 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
480 2007-07-23 Murray Cumming <murrayc@murrayc.com>
482 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
483 (add_folders_to_list), (on_dbus_method_get_folders),
484 (modest_dbus_req_filter):
485 * src/maemo/modest-maemo-utils.c:
486 (on_camel_account_get_supported_secure_authentication):
487 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
488 (on_header_view_focus_in):
489 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
490 * src/modest-formatter.c: (modest_formatter_create_body_part):
491 * src/modest-mail-operation.c: (recurse_folders),
492 (update_account_thread), (get_msgs_full_thread),
493 (modest_mail_operation_get_msgs_full),
494 (modest_mail_operation_xfer_msgs):
495 * src/modest-search.c: (search_mime_part_and_child_parts),
496 (modest_search_account), (modest_search_all_accounts):
497 * src/modest-tny-account.c:
498 (modest_tny_account_get_special_folder), (recurse_folders):
499 * src/modest-tny-local-folders-account.c:
500 (modest_tny_local_folders_account_query_passes):
501 * src/modest-tny-msg.c: (copy_mime_part),
502 (modest_tny_msg_find_body_part_from_mime_part):
503 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
504 (modest_tny_send_queue_try_to_send):
505 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
506 (_modest_ui_actions_open), (download_uncached_messages),
507 (reply_forward), (modest_ui_actions_on_copy),
508 (modest_ui_actions_on_details), (has_retrieved_msgs),
509 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
511 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
512 (_selected_msg_marked_as), (_msg_download_completed),
513 (_selected_msg_sent_in_progress):
514 * src/widgets/modest-attachments-view.c:
515 (modest_attachments_view_set_message):
516 * src/widgets/modest-msg-view.c: (find_cid_image):
517 * tests/check_folder-transfer.c: (find_folders):
518 * tests/check_update-account.c: (func):
519 * tests/dbus_api/test_get_folders.c: (main):
520 Checked all uses of tny_iterator_get_current(), making sure
521 that the object is unreferenced (3 or 4 places did not),
522 and adding checks for NULL.
524 2007-07-23 Murray Cumming <murrayc@murrayc.com>
526 * src/dbus_api/modest-dbus-callbacks.c:
527 (on_idle_open_default_inbox): Make sure that the application UI is
529 * src/maemo/easysetup/modest-easysetup-wizard.c:
530 (on_entry_invalid_character): Show the word whitespace instead
531 of (null) in the banner when whitespace was entered.
532 (show_error): Add a comment that this does not work in
533 Maemo Bora, though we do not know why.
535 2007-07-23 Murray Cumming <murrayc@murrayc.com>
537 * src/modest-tny-account.c:
538 (modest_tny_account_get_special_folder): Use an if instead of
539 an assert for when the parent account name is NULL, because this
540 might be causing a crash in projects.maemo.org bug 63192.
541 * src/modest-mail-operation.c:
542 (modest_mail_operation_send_new_mail_cb),
543 (modest_mail_operation_remove_folder): unref the folder that is
544 returned from modest_tny_account_get_special_folder().
546 2007-07-23 Murray Cumming <murrayc@murrayc.com>
548 * src/modest-ui-actions.c:
549 (modest_ui_actions_on_password_requested):
550 Show mail_ib_login_cancelled info banner when the user cancels
551 the protected password dialog, to fix projects.maemo.org
554 2007-07-23 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/modest-account-settings-dialog.c:
557 (create_page_outgoing): Put this page in a GtkScrolledWindow,
558 matching the UI mock-up in the UI spec, and allowing access
559 to all widgets even when the on-screen keyboard is active.
561 2007-07-23 Murray Cumming <murrayc@murrayc.com>
563 Reverted this previous commit from Johannes,
564 because the scrollbars are always visible and because
565 I think we only need it on onepage of the account
566 settings, not the account wizard.
567 (I wrote the wrong instructions in the bug.)
569 * src/maemo/easysetup/modest-easysetup-wizard.c:
570 Added scrollbars to account wizard dialog.
571 Fixed projects.maemo.org NB #62744
573 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
575 * src/maemo/easysetup/modest-easysetup-wizard.c:
576 (create_page_user_details):
577 Use auto-cap for name (projects.maemo.org NB#63716)
578 * src/widgets/modest-account-view.c: (on_account_busy_changed):
580 2007-07-22 Armin Burgmeier <armin@openismus.com>
582 * src/maemo/modest-ui-actions.c: Use current account instead of
583 default account for creating viewer windows, so that the viewer
584 window knows to which account the viewed message belongs.
586 * src/maemo/modest-msg-view-window.c: Destroy the window when the
587 corresponding account is deleted. This fixes projects.maemo.org bug
590 2007-07-18 Armin Burgmeier <armin@openismus.com>
592 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
593 the dialog close after entering an invalid port number and clicking
594 OK. This fixes projects.maemo.org bug NB#63602.
596 2007-07-18 Armin Burgmeier <armin@openismus.com>
598 * src/modest-tny-account-store.c:
599 (get_server_accounts): Set parent modest account name for each
600 connection-specific transport account so that special folders of such
601 an account can be looked up. This fixes a crash when changing account
602 settings. This might also be related to projects.maemo.org bug
605 2007-07-16 Armin Burgmeier <armin@openismus.com>
607 * src/modest-ui-actions.c: Added a button to create a folder to the
608 move-to dialog. This fixes projects.maemo.org bug NB#59863.
610 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
612 * src/maemo/easysetup/modest-easysetup-wizard.c:
613 Added scrollbars to account wizard dialog.
614 Fixed projects.maemo.org NB #62744
616 2007-07-16 Murray Cumming <murrayc@murrayc.com>
618 * src/widgets/modest-msg-view.h:
619 * src/widgets/modest-msg-view.c:
620 Added modest_msg_view_get_message_is_empty() but this needs
622 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
623 Check if there is any text in the message yet.
624 But this needs to be implemented properly.
625 (modest_msg_edit_window_toggle_find_toolbar):
626 * src/maemo/modest-msg-view-window.c:
627 (modest_msg_view_window_toggle_find_toolbar):
628 Show a banner warning if there is no text to search, when
629 trying to start a search. This partially fixes
630 projects.maemo.org bug NB#62350.
632 2007-07-13 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-mail-operation.c: (update_account_thread):
635 Initialized num_new_headers to fix the build.
637 2007-07-13 Murray Cumming <murrayc@murrayc.com>
639 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
640 Ignore modest accounts whose server accounts don't exist in gconf.
641 This prevents us trying to create TnyAccount instances for those
642 server accounts when the server account has been removed from gconf,
643 but the parent modest account has not yet been removed from modest.
644 I don't know why this is only noticeable now. It was probably just
645 a harmeless g_warning() anyway.
647 2007-07-13 Murray Cumming <murrayc@murrayc.com>
649 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
650 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
652 2007-07-12 Armin Burgmeier <armin@openismus.com>
654 * src/maemo/modest-main-window.c: Make default account appear bold
655 in view, tools/send & receive and toolbar/send & receive SCM menus.
656 This fixes projects.maemo.org bug NB#59010.
658 2007-07-12 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
661 Add a short-cut, by checking if the folder store is an account.
662 This ensures that the Sort menu item and toolbar is dimmed for
663 the local-folders account root item, fixing
664 projects.maemo.org bug NB#62545.
666 2007-07-12 Murray Cumming <murrayc@murrayc.com>
668 * src/modest-tny-account-store.c: (get_password):
669 Show the password dialog (via the signal) only in the mainloop, via
670 an idle handler that we wait for. This could theoretically prevent
671 hangs, though I worry that it could introduce some too.
673 2007-07-12 Murray Cumming <murrayc@murrayc.com>
675 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
676 * src/maemo/modest-platform.c:
677 (modest_platform_connect_and_wait):
678 Take a TnyAccount* parameter and try to set it to online
679 (a TnyCamel-only API), because tinymail sets accounts to offline
680 when the user cancels a password dialog, and doesn't ask again until
681 it has been set to online.
682 However, this is commented out because it causes a hang now.
684 (modest_platform_connect_and_wait_if_network_account):
685 * src/modest-mail-operation.c:
686 (modest_mail_operation_update_account):
687 * src/modest-platform.h:
688 * src/modest-ui-actions.c: (_modest_ui_actions_open),
689 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
691 2007-07-12 Armin Burgmeier <armin@openismus.com>
693 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
695 * src/modest-mail-operation.c:
696 * src/modest-ui-actions.c: Check for already existing folder before
697 querying the server, show error message from camel if the request
698 still fails. This fixes projects.maemo.org bug NB#58701.
700 2007-07-12 Murray Cumming <murrayc@murrayc.com>
702 * src/modest-tny-account-store.h:
703 * src/modest-tny-account-store.c:
704 Added modest_tny_account_store_forget_password_in_memory(),
705 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
706 when creating a new account, so that new passwords will be used, instead of
707 us thinking that it's a second request as a result of a failed password again.
709 2007-07-12 Murray Cumming <murrayc@murrayc.com>
711 * src/dbus_api/modest-dbus-callbacks.c:
712 (on_idle_open_message): If the message is in drafts then open it
713 in an edit window instead of a view window. This fixes
714 projects.maemo.org bug NB#63005.
716 2007-07-12 Murray Cumming <murrayc@murrayc.com>
718 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
719 Avoided a harmless g_warning().
721 2007-07-12 Murray Cumming <murrayc@murrayc.com>
723 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
724 Pass the modest account name, not the TnyAccount display name to
725 modest_msg_view_window_new() so that the reply feature works,
726 fixing projects.maemo.org bug NB#62892.
728 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
729 (modest_msg_view_window_new_with_header_model):
730 * src/maemo/modest-msg-view-window.c:
731 (modest_msg_view_window_new_with_header_model),
732 (modest_msg_view_window_new):
733 * src/modest-ui-actions.c: (reply_forward):
734 * src/widgets/modest-msg-view-window.h:
735 * src/widgets/modest-window.c: (modest_window_set_active_account):
736 Rename an account parameter to modest_account_name to make this clearer.
738 2007-07-11 Murray Cumming <murrayc@murrayc.com>
740 * src/modest-ui-actions.h:
741 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
742 modest_do_message_delete().
743 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
744 Call modest_do_message_delete(), hoping that this would cause messages
745 to be really deleted from search instead of just marked with strike through.
746 Does not seem to help.
748 2007-07-11 Armin Burgmeier <armin@openismus.com>
750 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
751 priv->reselect to FALSE prior to calling
752 modest_folder_view_select_first_inbox_or_local() to prevent endless
753 recursion and thus a crash on startup.
755 2007-07-11 Armin Burgmeier <armin@openismus.com>
757 * src/maemo/modest-account-settings-dialog.h: Include
758 <gtk/gtknotebook.h> to fix the build (at least for me).
760 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
761 Use "New FolderN" as default suggested name if "New folder" already
762 exists, with N being the first free number, though never exceed "New
763 folder99" in which case we just fall back to "New Folder" even though
764 it already exists. This fixes projects.maemo.org bug NB#58663.
766 2007-07-11 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
769 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
770 projects.maemo.org bug NB#62778.
772 2007-07-11 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
775 Ignore the wrong (for now) secure-smtp setting in the presets -
776 just default to requiring secure authentication for SMTP, because
779 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
781 * src/widgets/modest-folder-view.c: (filter_row)
782 Do not show drafts folder (see UI specs)
784 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
786 * src/modest-ui-actions.c:
787 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
788 place and also not necessary.
790 * src/widgets/modest-folder-view.c: (filter_row)
791 Guess folder type and hide Sent & Outbox if necessary.
792 Fixed project.maemo.org NB#57328
794 2007-07-11 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-ui-actions.h:
797 * src/modest-ui-actions.c:
798 (modest_ui_actions_on_delete_message):
799 Move some code into a new
800 modest_ui_actions_refresh_message_window_after_delete()
801 function so we can use it from elsewhere.
803 * src/dbus_api/modest-dbus-callbacks.c:
804 (on_idle_delete_message), (on_delete_message): Used an idle
805 handler, as we do for the other D-Bus method handlers.
806 Call modest_ui_actions_refresh_message_window_after_delete()
807 if the deleted message was open in a window. This fixed
808 projects.maemo.org bug NB#62862.
810 2007-07-11 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-main.c: (main): Only show the UI at the start if
813 the showui command line option was given. For instance,
814 run-standalone src/modest showui
815 Otherwise, we wait for the top_application D-Bus method to
816 be sent by hildon-desktop when the application is selected
818 This allows us to run without a UI when osso-global-search
819 uses our D-Bus methods.
821 2007-07-11 Murray Cumming <murrayc@murrayc.com>
823 * src/dbus_api/modest-dbus-api.h: Added a define for a
824 top-application D-Bus method.
825 * src/dbus_api/modest-dbus-callbacks.c:
826 (on_top_application),
827 (modest_dbus_req_handler): Handle the top-application D-Bus
828 method, which might be an undocumented D-Bus signal sent by
829 hildon-desktop when it starts the application from the menu.
830 But I am not sure and I need to test it on the device, because
831 my scratchbox does not have the application in the menu now.
832 This method shows the main window, so that it can be invisible
833 when started, for instance, just for email searching from
836 * src/maemo/modest-main-window.c: (restore_settings),
837 (modest_main_window_new): Do not show the window immediately
838 upon creation. We show it later.
839 * src/modest-widget-memory.c: (save_settings_paned):
840 Try (unsuccessfully) to avoid saving the paned position when
841 it is not even visible.
842 (restore_settings_paned): Do not allow a silly paned position.
843 This seems necessary when not showing the window at first.
845 * tests/dbus_api/Makefile.am:
846 * tests/dbus_api/test_top_application.c: (main): Test for the
849 2007-07-10 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-ui-dimming-rules.c:
852 (modest_ui_dimming_rules_on_new_msg),
853 (modest_ui_dimming_rules_on_reply_msg),
854 (modest_ui_dimming_rules_on_delete_msg),
855 (modest_ui_dimming_rules_on_details),
856 (modest_ui_dimming_rules_on_view_window_move_to),
857 (modest_ui_dimming_rules_on_view_previous),
858 (modest_ui_dimming_rules_on_view_next),
859 (_invalid_folder_for_purge): Added checks before
860 casting the window. This looks like an actual
861 logic error in _invalid_folder_for_purge(), because it
862 tries to use a ModestMainWindow as a message window.
864 2007-07-10 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/modest-account-settings-dialog.c:
867 (show_error): Use the same implementation as in
868 modest-easysetup-wizard.c:
869 (on_entry_invalid_character): The logical ID contains a %s.
870 Guessed what it should be.
871 (on_entry_max), (check_data), (on_response): Adapt to
872 changed show_error().
873 (create_page_account_details): Really call
874 modest_validating_entry_set_func() on the correct widgets.
875 * src/maemo/easysetup/modest-easysetup-wizard.c:
876 (on_entry_invalid_character): Fix the logical ID here too.
877 (create_page_account_details),
878 (create_page_user_details):
880 modest_validating_entry_set_func() on the correct widgets.
882 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
883 Do not try to use the account if it is NULL.
885 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
887 * src/modest-ui-actions.c: (create_move_to_dialog),
888 (modest_ui_actions_on_main_window_move_to),
889 (modest_ui_actions_on_msg_view_window_move_to):
890 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
891 (filter_row), (modest_folder_view_show_non_move_folders):
892 * src/widgets/modest-folder-view.h:
894 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
895 the Sent folder yet as it does not report the correct folder type.
897 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
899 * src/maemo/modest-msg-edit-window.c: (init_window):
902 2007-07-10 Murray Cumming <murrayc@murrayc.com>
904 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
905 Take a parent widget instead of a parent window, and
906 implement this with hildon_banner_show_information() instead.
907 Non-Maemo builds can just ifdef that there.
908 This fixed projects.maemo.org bug NB#62766.
910 (on_entry_invalid_character): Use show_error() again instead
911 of using hildon directly, and use the _CS() macro to use the correct
913 (create_account), (check_for_supported_auth_methods), (on_entry_max):
914 Pass a widget instead od a window to show_error().
916 2007-07-10 Murray Cumming <murrayc@murrayc.com>
918 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
919 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
920 This allows us to show the server name in the error message, fixing
921 projects.maemo.org bug NB#62904.
922 Also, use the appropriate logical ID message for the account protocol.
924 2007-07-10 Murray Cumming <murrayc@murrayc.com>
926 * src/modest-tny-account-store.c: (on_idle_wrong_password):
927 A compilation fix, though the build wasn't broken for me.
929 2007-07-09 Murray Cumming <murrayc@murrayc.com>
931 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
932 Do not try to unref a NULL folder store, to avoid a runtime warning.
933 This seems to happen sometimes when changing accounts settings.
935 2007-07-09 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-tny-account-store.c:
938 (modest_tny_account_store_instance_init),
939 (modest_tny_account_store_finalize),
940 (on_account_settings_hide), (on_idle_wrong_password):
941 Use a GHashTable to ensure that we only show one account settings
942 dialog per modest account. This avoids us having a dialog open for
943 both the store and transport accounts, or due to repeated get_password()
944 calls that shouldn't happen anyway.
946 2007-07-09 Murray Cumming <murrayc@murrayc.com>
948 * src/maemo/modest-maemo-utils.c: (on_hide),
949 (modest_maemo_show_dialog_and_forget): Handle the response, because
950 the window is not even hidden by default.
952 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
953 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
954 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
955 which seems to prevent some modality problems.
957 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
958 Ignore user cancellation errors.
960 * src/modest-account-mgr-helpers.h:
961 * src/modest-account-mgr-helpers.c:
962 Added modest_server_account_get_password() and
963 modest_server_account_get_has_password() to avoid direct use of
966 * src/maemo/modest-account-settings-dialog.h:
967 * src/maemo/modest-account-settings-dialog.c:
968 (modest_account_settings_dialog_init): Store the notebook so we can
970 Added modest_account_settings_dialog_switch_to_user_info().
972 * src/modest-tny-account-store.c:
973 (get_password): When the password in the account settings is wrong (we think),
974 show the relevant page of the account settings dialog, in the mainloop.
975 However, we currently get many of these at once because cancel does not
977 (forget_password): Do not forget the password
978 from the account settings, because this causes side-effects when
979 tinymail seems to call it at strange time, maybe because of how we
980 are cancelling get_password().
981 (modest_tny_account_store_alert): Ignore user cancellations.
983 2007-07-09 Murray Cumming <murrayc@murrayc.com>
985 * src/maemo/modest-maemo-utils.h:
986 * src/maemo/modest-maemo-utils.c:
987 Added modest_maemo_show_information_note_and_forget() for use instead of
988 gtk_dialog_run() when the response is not needed, to avoid an extra
989 mainloop which could cause a hang.
991 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
992 Use the logical IDs for the error message, though they are not
993 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
994 because gtk_dialog_run() caused a hang here (the window did not close).
995 This fixes projects.maemo.org bug NB#62646.
997 2007-07-09 Murray Cumming <murrayc@murrayc.com>
999 * src/modest-account-mgr-helpers.h:
1000 * src/modest-account-mgr-helpers.c:
1001 Added modest_account_mgr_get_store_protocol().
1003 * src/maemo/modest-account-view-window.c:
1004 (on_delete_button_clicked): Show different warning text depending on
1005 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
1006 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
1009 2007-07-09 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-msg-edit-window.c:
1012 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
1013 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
1015 2007-07-07 Armin Burgmeier <armin@openismus.com>
1017 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
1018 ckdg_ib_maximum_characters_reached from correct package.
1020 * src/modest-ui-actions.c: Show an error message when a folder could
1021 not be created. Tinymail does not give us specific error codes about
1022 what has gone wrong, so we assume that a folder with that name
1023 already exists, though there might be other reasons.
1025 2007-07-06 Murray Cumming <murrayc@murrayc.com>
1027 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1028 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
1029 give a more exact error message that can be partly translated.
1031 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1033 * src/maemo/modest-address-book.c:
1034 (select_email_addrs_for_contact): Specify a default window size for the
1035 select-email-address dialog, so that it is probably big enough for the
1036 title. This should fix projects.maemo.org bug NB#62277.
1038 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/easysetup/modest-easysetup-wizard.c:
1041 (create_page_complete_easysetup): Use
1042 gtk_widget_set_size() request to ensure that the text wraps
1045 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1047 * src/maemo/easysetup/modest-easysetup-wizard.c:
1048 (on_entry_invalid_character), (create_page_account_details),
1049 (create_page_user_details):
1050 Use new API of ModestValidatingEntry. But for some reason the banner is
1051 not shown. I will have to investigate that further.
1053 * src/widgets/modest-validating-entry.c: (on_insert_text),
1054 (modest_validating_entry_set_func):
1055 * src/widgets/modest-validating-entry.h:
1056 Added a new callback function to be able to react to prevented
1057 characters whitespaces to e.g show a banner.
1059 2007-07-05 Armin Burgmeier <armin@openismus.com>
1061 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1062 notification of HildonNumberEditor instead of remembering the port
1063 number. Thanks to Johannes for pointing this out.
1065 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1067 * src/maemo/easysetup/modest-easysetup-wizard.c:
1068 Check if there are any user changes before showing a confirmation
1069 dialog (projects.maemo.org NB#60946)
1071 2007-07-05 Armin Burgmeier <armin@openismus.com>
1073 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1074 number at the beginning of the dialog and set the modified flag at the
1075 end if the port number has changed. This is necessary because
1076 HildonNumberEditor does not support notification when the value has
1079 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1081 * src/modest-ui-actions.c:
1082 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1083 a connection before asking anything else. Correct the check for the destination
1084 folder so that it succeeds when online.
1085 This fixed projects.maemo.org bug NB#61645.
1087 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1089 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1090 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1091 to fix projects.maemo.org bug NB#62439.
1093 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-tny-account.c: (on_connection_status_changed):
1096 Really do not use tny_device_force_offline() here. See the previous comment.
1098 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1100 * src/modest-tny-account.c: (on_connection_status_changed):
1101 Do not use tny_device_force_offline() when tinymail says that something
1102 went wrong with the connection. It seems to report this unnecessarily.
1104 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/modest-connection-specific-smtp-window.c:
1107 (modest_connection_specific_smtp_window_init):
1108 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1109 does not seem to have any effect in osso 1.1 (though it works in
1110 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1112 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1114 * src/maemo/modest-connection-specific-smtp-window.c:
1115 Fix UI specification problems with projects.meamo.org NB#60479
1117 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1119 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1120 clue when this has failed, because the error dialog is not always shown
1121 (at least in earlier version).
1123 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1124 GError message, because the generic error dialog is not helpful.
1126 'This message is not currently available (can't let a new connection go online)'
1127 when trying to open an IMAP message.
1129 (_modest_ui_actions_open): Offer a connection when some messages would
1130 have to be downloaded and we are offline.
1132 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1134 * src/widgets/modest-folder-view.c:
1135 Don't check for MERGE type anymore as we use the correct type
1137 NOTE: For the last two changes you need to update your tinymail copy
1138 because of API changes!
1140 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1142 * src/modest-tny-local-folders-account.c:
1143 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1144 (see projects.maemo.org NB#61580)
1146 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-tny-account.c: (on_connection_status_changed):
1149 Commented out the call to modest_platform_connect_and_wait() because this
1150 seems to always hang, and I would like to know if this is the only thing
1151 that causes a hang when showing the connection dialog.
1152 It is not very useful anyway.
1154 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1156 * src/maemo/modest-msg-view-window.c:
1157 (modest_msg_view_window_select_next_message):
1159 * src/modest-platform.h:
1160 * src/maemo/modest-platform.c:
1161 Added modest_platform_connect_and_wait(), which calls
1162 tny_maemo_conic_device_connect() always in the main thread, by calling it
1163 in an idle handler and waiting for the idle handler to run. It should be
1164 in the main thread because it uses GTK+ UI code. It just returns TRUE
1165 if the device is already online.
1167 There is some nasty code to ensure that subsequent calls to
1168 modest_platform_connect_and_wait() just wait for the first one to finish,
1169 by checking repeatedly in another idle handler. This is necessary,
1170 because other threads (or even the main thread, via another idle handler)
1171 can call modest_platform_connect_and_wait() while
1172 modest_platform_connect_and_wait() is running.
1174 (modest_platform_connect_and_wait_if_network_account),
1175 (modest_platform_connect_and_wait_if_network_folderstore):
1176 Convenience functions that calls modest_platform_connect_and_wait() if
1177 the account or folder might want network access.
1179 * src/modest-mail-operation.c:
1180 (modest_mail_operation_update_account):
1181 * src/modest-ui-actions.c: (download_uncached_messages),
1182 (modest_ui_actions_on_rename_folder), (delete_folder),
1183 (modest_ui_actions_on_main_window_move_to),
1184 (modest_ui_actions_on_msg_view_window_move_to):
1185 * src/widgets/modest-folder-view.c:
1186 (drag_and_drop_from_folder_view):
1187 Offer a connection if we are offline.
1189 * src/modest-tny-account.c: (on_connection_status_changed):
1190 Document this as only handling errors during network operations in progress,
1191 and replace the idle code with a simple call to
1192 modest_platform_connect_and_wait(), which does this instead.
1194 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1196 * src/modest-tny-account.c:
1197 (modest_tny_account_get_special_folder): (util_on_idle),
1198 Handle the GError so we can see when tny_folder_store_get_folders()
1199 fails, as it currently does while something else is connecting.
1201 Added util_run_in_main_thread_and_wait()
1202 which uses an idlen handler and mainloop to ensure that the function
1203 is called in the main thread.
1204 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1205 to make sure that we call attempt the connection in the mainloop only,
1206 which might solve some hangs.
1208 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1210 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1211 be found by their display name. This is never useful.
1212 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1213 by its ID, instead of trying to use its ID as its display name.
1215 * src/modest-tny-account-store.h:
1216 * src/modest-tny-account.c:
1217 (modest_tny_account_get_special_folder): Add a g_warning() when
1218 tny_folder_store_get_folders() returns an empty list for the maildir.
1220 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1221 Add a g_warning() when this returns NULL, because that it not allowed
1224 2007-07-02 Armin Burgmeier <armin@openismus.com>
1226 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1227 note when trying to cancel the wizard. This fixes projects.maemo.org
1230 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-tny-account.h:
1233 * src/modest-tny-account.c:
1234 (modest_tny_account_new_from_server_account),
1235 (modest_tny_account_new_from_server_account_name),
1236 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1237 because this must now be set before setting the proto. This is usd in
1238 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1239 warning in camel_session_get_service() caused by
1240 tny_camel_transport_account_prepare().
1242 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1245 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1247 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1249 (modest_connection_specific_smtp_edit_window_init):
1251 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1252 of "changed" for now
1254 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1256 * src/modest-tny-account.c:
1257 (modest_tny_account_new_from_server_account):
1258 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1259 now uses to request a connection when it needs one, and which it uses
1260 to tell us that something is wrong with the connection, so we can force
1261 the accounts offline to prevent further problems.
1263 * src/modest-defs.h:
1264 * src/modest-init.c: (init_default_settings):
1265 * src/modest-mail-operation.c:
1266 (modest_mail_operation_update_account):
1267 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1268 This should not be necessary anymore. Do not set the conf key that
1269 determined this (it was always TRUE and not set anywhere else).
1271 * src/modest-ui-actions.h: Remove unused and unimplemented
1272 modest_ui_actions_on_online_toggle_toggled().
1274 2007-06-29 Murray Cumming <murrayc@murrayc.com
1276 * src/maemo/modest-main-window.c: (connect_signals):
1277 Don't connect to delete_event twice. Maybe this was harmless.
1279 2007-06-29 Murray Cumming <murrayc@murrayc.com
1281 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1282 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1283 Debug output to give some more clue when a folder move is not allowed.
1285 2007-06-28 Murray Cumming <murrayc@murrayc.com
1287 * src/modest-tny-account.c: (on_modest_file_system_info),
1288 (modest_tny_account_get_mmc_account_name):
1289 Always call the callback, without checking whether the name has changed.
1290 * src/widgets/modest-folder-view.c: (strings_are_equal),
1291 (on_model_foreach_set_name), (on_get_mmc_account_name),
1292 (text_cell_data): Compare the name here, and use the name from
1293 the account rather than from the
1294 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1295 if the name was changed after the account was added to the model.
1296 That's a tinymail bug but not one that I want to fix now.
1298 This finally fixes projects.maemo.org bug NB#59301.
1300 2007-06-27 Armin Burgmeier <armin@openismus.com>
1302 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1305 2007-06-27 Murray Cumming <murrayc@murrayc.com
1307 * src/modest-tny-account.h:
1308 * src/modest-tny-account.c:
1309 Added modest_tny_account_get_mmc_account_name(), to set the memory
1310 card name asynchronously for the given account and then notify.
1311 (modest_tny_account_new_for_local_folders): Use this new function instead
1312 of using hildon_file_system_info_async_new() directly.
1314 * src/widgets/modest-folder-view.c: (text_cell_data):
1315 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1316 gtk_tree_model_row_changed() when it is available.
1318 This should fix projects.maemo.org bug NB#59301.
1320 2007-06-27 Murray Cumming <murrayc@murrayc.com
1322 * src/modest-mail-operation.c: (update_account_thread),
1323 (get_msgs_full_thread): Fix typo failures in the revert
1326 2007-06-27 Murray Cumming <murrayc@murrayc.com
1328 * src/maemo/modest-maemo-global-settings-dialog.c:
1329 (idle_select_default_focus):
1330 * src/modest-mail-operation.c: (idle_notify_progress),
1331 (idle_notify_progress_once), (set_last_updated_idle),
1332 (update_account_thread), (get_msgs_full_thread):
1333 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1334 * src/widgets/modest-header-view.c:
1335 (idle_notify_headers_count_changed_destroy),
1336 (idle_notify_headers_count_changed):
1337 Reverted the additions of gdk_threads_enter/leave(), in case this
1338 helps with a startup hang on the device.
1340 2007-06-26 Armin Burgmeier <armin@openismus.com>
1342 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1343 for supported secure authentication methods from server by
1344 gtk_dialog_run(), saving CPU time and a potential race condition.
1346 2007-06-26 Armin Burgmeier <armin@openismus.com>
1348 * src/maemo/modest-maemo-utils.h:
1349 * src/maemo/modest-maemo-utils.c: Added a
1350 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1351 only error code to tell the calling code when the user canceled the
1354 * src/maemo/modest-account-settings-dialog.h:
1355 * src/maemo/modest-account-settings-dialog.c:
1356 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1357 message if the retrieval of secure authentication methods was canceled
1358 by the user. Perform the check before saving anything to configuration
1359 to not end up with half-committed configuration changes, do not show
1360 a "Saving to configuration failed" note when authentication methods
1361 could not be retrieved.
1363 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1366 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1368 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1369 Only return the first level of folders under accounts, because the
1370 osso-global-search UI spec doesn't want the rest.
1371 This fixed projects.maemo.org bug NB#61811.
1373 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1375 * src/modest-tny-account-store.c:
1376 * src/modest-tny-account-store.h:
1377 Added modest_tny_account_is_memory_card_account().
1378 * src/maemo/modest-main-window.c: (create_details_widget):
1379 Show the same information items for the memory card as we show for the
1380 local-folders, to fix projects.maemo.org bug NB#59307.
1382 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-tny-account-store.c: (get_password):
1385 Added some checks for NULL to maybe prevent crashes, though I think
1386 it was Philip's last commit that actually prevented the crash here
1387 when creating a first new account.
1388 But the new account is still not usable (no messages are shown)
1389 until a restart of the application.
1391 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1393 * src/maemo/modest-maemo-global-settings-dialog.c:
1394 (idle_select_default_focus):
1395 * src/modest-mail-operation.c: (idle_notify_progress),
1396 (idle_notify_progress_once), (idle_notify_update_account_queue),
1397 (set_last_updated_idle), (update_account_thread),
1398 (notify_get_msgs_full), (get_msgs_full_destroyer),
1399 (get_msgs_full_thread):
1400 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1401 * src/widgets/modest-header-view.c:
1402 (idle_notify_headers_count_changed_destroy),
1403 (idle_notify_headers_count_changed):
1404 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1405 all idle handlers, because some other thread could be blocking
1406 the GDK lock, so that it can do GUI stuff.
1408 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1410 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1411 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1412 (on_idle_send_receive), (on_idle_open_default_inbox):
1413 * src/maemo/modest-msg-edit-window.c:
1414 (modest_msg_edit_window_attach_file_noninteractive):
1415 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1416 to prevent a hang. I don't quite understand why these are necessary,
1417 beause we should already be in the main loop. I guess something outside
1418 of the main loop is taking the lock.
1420 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1421 we are really using URIs, and use files that are more likely to exist.
1423 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1425 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1426 necessary because configure.ac now defines different variables.
1428 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1430 * libmodest-dbus-client/libmodest-dbus-client.c:
1431 * libmodest-dbus-client/libmodest-dbus-client.h:
1432 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1433 libmodest_dbus_client_compose_mail() is what things actually use.
1435 * src/dbus_api/modest-dbus-api.h:
1436 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1437 * tests/dbus_api/Makefile.am:
1438 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1441 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-init.c: (modest_init_local_folders):
1444 For memory-card (or other non local-folders) maildir accounts,
1445 always create an Archive folder, so that there is somewhere to put
1446 messages. This should be less confusing, because the user does not need
1447 to guess that the need to create a folder.
1449 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1451 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1452 Fixed icon size by using (50, 50) which is the same as defined by
1455 2007-06-25 Armin Burgmeier <armin@openismus.com>
1457 * src/widgets/modest-window-mgr.c:
1458 * src/modest-init.c:
1459 * configure.ac: Correctly recognize hildon-notify presence and fixed
1460 the build without it being installed.
1462 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1464 * libmodest-dbus-client/libmodest-dbus-client.c:
1465 (libmodest_dbus_client_search): Fix the build. Sorry.
1466 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1467 (reply_forward_cb): Initialize variables to fix the build.
1469 * src/modest-tny-account-store.c:
1470 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1471 comparison (a silly typo) so that email search results can be opened
1472 when there are more than one account.
1474 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1476 * libmodest-dbus-client/libmodest-dbus-client.c:
1477 (libmodest_dbus_client_search),
1478 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1479 instead of 1 second, because the search gets folders and messages from
1480 the server, which can take a long time. When it times out,
1481 osso-global-search will report no results.
1483 We need to specify whether we should search only cached information
1484 (maybe with a user preference), and the osso-email-search-plugin
1485 API should really be improved to allow that option, and to allow results
1486 to be delivered asynchronously in batches.
1488 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1490 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1491 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1492 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1494 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1496 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1497 that is an empty string. D-Bus seems to give us these instead of NULL.
1499 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1501 * src/dbus_api/modest-dbus-callbacks.c:
1502 * src/maemo/easysetup/modest-easysetup-wizard.h:
1503 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1504 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1505 (modest_connection_specific_smtp_edit_window_init):
1506 * src/maemo/modest-maemo-global-settings-dialog.c:
1508 * src/maemo/modest-maemo-utils.c:
1509 (modest_maemo_utils_setup_images_filechooser):
1510 * src/maemo/modest-main-window.c: (create_details_widget):
1511 * src/maemo/modest-msg-edit-window.c:
1512 (modest_msg_edit_window_attach_file_noninteractive),
1513 (modest_msg_edit_window_color_button_change),
1514 (modest_msg_edit_window_set_zoom):
1515 * src/modest-mail-operation.c: (update_account_thread):
1516 * src/modest-tny-account-store.c:
1517 * src/modest-tny-account.c:
1518 * src/widgets/modest-global-settings-dialog.c:
1519 * src/widgets/modest-window.h:
1521 Fixed build on bora!
1523 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1525 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1526 * src/modest-search.c: (modest_search_folder),
1527 (modest_search_all_accounts): Actually search only in the specified folder,
1528 doing a simple match on the folder ID.
1529 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1530 and added some documentation.
1532 2007-06-22 Armin Burgmeier <armin@openismus.com>
1534 * src/maemo/modest-maemo-utils.h:
1535 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1536 modest_maemo_utils_get_supported_secure_authentication_methods.
1538 * src/maemo/easysetup/modest-easysetup-wizard.c:
1539 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1540 one occured, not just "Server does not support secure authentication".
1542 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-tny-account-store.c: (get_password):
1545 Restored the call to tny_account_set_user() because Philip seems to have
1546 stopped this from crashing (by not using the freed string). It still does
1547 not work, but now we can test it.
1549 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/modest-msg-edit-window.c: (init_window):
1552 Comment out use of an uninitialzed GtkScrolledWindow variable,
1553 to fix the build and stop a crash. Yet again.
1555 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1557 * src/modest-tny-account-store.c: (get_password):
1558 Remove the call to tny_account_set_user() because this actually crashes.
1559 As mentioned in the last commit, it is known to not work anyway.
1561 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1563 * src/modest-tny-account-store.c: (get_password):
1564 Use tny_account_set_username() to tell tinymail that the username might
1565 have changed too. But tinymail ignores this: see projects.maemo.org
1567 * src/modest-ui-actions.c:
1568 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1569 reset the connection when changing the username, and improve the comments.
1570 Save the changed username to gconf at least, so it is used when Modest is
1573 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1575 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1576 Do not use a query, so that we get all folders, including for POP and
1577 local-folders. They work as search criteria too.
1578 This fixes projects.maemo.org bug NB#57740.
1580 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1582 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1583 Comment out the use of hildon_notification_set_sound() because it is
1584 not declared, to fix the build. Warnings are serious, people.
1586 2007-06-21 Armin Burgmeier <armin@openismus.com>
1588 * src/maemo/modest-maemo-utils.h:
1589 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1590 modest_maemo_utils_get_supported_secure_authentication_methods()
1591 to query authentication methods for a specific user. This should fix
1592 projects.maemo.org bug NB#61369.
1594 * src/maemo/easysetup/modest-easysetup-wizard.c:
1595 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1598 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1600 * libmodest-dbus-client/libmodest-dbus-client.h:
1601 * libmodest-dbus-client/libmodest-dbus-client.c:
1602 (modest_dbus_message_iter_get_search_hit),
1603 (libmodest_dbus_client_search):
1604 Reorganised and commented this.
1605 Removed modest_search_hit_free() from the public API because it
1608 Added libmodest_dbus_client_get_folders() and
1609 modest_folder_result_list_free().
1611 * src/dbus_api/modest-dbus-api.h:
1612 * src/dbus_api/modest-dbus-callbacks.c:
1613 (modest_dbus_req_filter): Commented. Moved most code to
1614 on_dbus_method_search() and added on_dbus_method_get_folders().
1616 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1617 of the extra D-Bus handler.
1619 * tests/dbus_api/Makefile.am:
1620 * tests/dbus_api/test_get_folders.c: New test for
1621 libmodest_dbus_client_get_folders(). This seems to return an empty list
1622 at the moment. That could be the same error that causes the message list
1623 to be empty sometimes.
1624 This should help with projects.maemo.org bug NB#57740.
1626 2007-06-21 Armin Burgmeier <armin@openismus.com>
1628 * src/modest-mail-operation.c: Do not call
1629 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1630 notify the operation's end after having set the status to CANCELED for
1631 the operation queue to listen on. This fixes a deadlock when there
1632 were mail operations in the queue during its finalization.
1634 * src/modest-singletons.c: Reordered uninitialization of the account
1635 manager to happen after the mail operation queue was uninitialized
1636 because the mail operation's in the queue might still try to access
1637 the account manager (see modest_mail_operation_notify_end()). This
1638 fixes a potential crash when terminating the application.
1640 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1642 * src/modest-search.c:
1643 (search_mime_part_and_child_parts): Moved some code here so we
1644 can search recursively in child folders.
1645 (modest_search_folder): Search in the message as a mime part, instead
1646 of just its child mime parts.
1647 (read_chunk), (search_mime_part_ogs):
1648 Check how many bytes were read, to prevent an endless loop.
1649 Searching in message bodies now works. This finishes the fix for
1650 projects.maemo.org bug NB#61007.
1652 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1655 Add a g_warning when the item is not a folder.
1657 * src/modest-ui-dimming-rules.c:
1658 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1659 when selected item is not a folder (for instance, an account), because
1660 the UI spec only talks about folders.
1661 I am not sure what the UI spec wants, so this might not totally fix
1662 projects.maemo.org bug NB#60794.
1664 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1667 (load_from_file): Sort the list. The unsorted list would be more noticeable
1668 in non-English locales.
1670 * src/maemo/modest-msg-edit-window.c:
1671 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1672 warning and fix the build.
1674 * src/maemo/modest-progress-bar-widget.c:
1675 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1676 avoid a g_warning, and probably to avoid a crash.
1678 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1680 * src/modest-search.c: (modest_search_folder): Check for a GError
1681 when calling tny_folder_get_headers(), to show that this is not the cause
1684 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1686 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1687 Actually set the body query instead of the subject query.
1689 * src/modest-search.c: (search_mime_part_ogs),
1690 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1691 which would probably cause it to fail if we got this far.
1693 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1694 to simplify the code.
1695 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1696 be causing search-in-body to fail.
1698 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1700 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1702 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1703 Better debug message when the folder cannot be found.
1704 This should help with fixing projects.maemo.org bug #61287.
1705 * src/modest-search.c: (add_hit): Do not leak the furl string.
1707 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-ui-actions.c:
1710 (modest_ui_actions_on_folder_selection_changed):
1711 Do not special-case TNY_MERGE_FOLDER here, because
1712 modest_tny_folder_get_account() already does that. This fixes
1713 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1714 shown when the Outbox was selected).
1716 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1718 * libmodest-dbus-client/libmodest-dbus-client.c:
1719 (_dbus_iter_get_string_or_null): Initialize the string variable in
1720 case this helps with Dirk's crash.
1722 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1724 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1725 though it is not implemented yet (this function is maybe not even used),
1726 to avoid breaking ABI in future.
1727 * libmodest-dbus-client/libmodest-dbus-client.c:
1728 (get_attachments_string): Moved some code into this generic function.
1729 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1730 sends email. It is maybe not used.
1731 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1732 (on_send_mail): Use attachments.
1734 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1735 * src/maemo/modest-msg-edit-window.c:
1736 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1737 a filename before using it, to fix projects.maemo.org bug NB#58233.
1739 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1741 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1742 Initialize the continue_download variable to fix the build, and probably
1743 to fix randome behaviour.
1745 2007-06-18 Armin Burgmeier <armin@openismus.com>
1747 * src/modest-tny-send-queue.h:
1748 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1749 the queue so we can later show it in the UI. Replaced
1750 modest_tny_send_queue_msg_is_being_sent() by
1751 modest_tny_send_queue_get_msg_status().
1753 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1755 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1756 gpointer. This probably was not harmful, but just to be sure.
1758 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1760 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1761 Fix the build, but leave the function broken on Bora, because
1762 hildon_uri_action_get_service() does not exist.
1763 osso_uri_action_get_service() does not exist either, it seems.
1765 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-tny-account.c:
1768 (modest_tny_account_new_from_server_account):
1769 Uncommented the url debug output again, because it is useful for
1770 debugging, as I said in the comment.
1772 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1774 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1776 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1777 for Mameo Bora, to fix the build.
1779 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1782 Fixed build with hildon < 0.99
1784 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1785 Check if the selected account is busy instead of checking all accounts
1787 * src/modest-account-mgr-priv.h:
1788 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1789 (modest_account_mgr_init), (compare_account_name),
1790 (modest_account_mgr_set_account_busy),
1791 (modest_account_mgr_account_is_busy):
1792 * src/modest-account-mgr.h:
1793 Added busy information to the account manager. It possible to
1794 set an account to busy or not busy now.
1796 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1797 (modest_mail_operation_update_account),
1798 (modest_mail_operation_notify_end):
1799 Set the account to busy/not busy depending on the operation state.
1801 * src/widgets/modest-account-view.c:
1802 (modest_account_view_finalize), (get_last_updated_string),
1803 (update_account_view), (on_account_busy_changed), (init_view):
1804 Show string "Refreshing..." if the account is currently busy.
1806 All this fixes projects.maemo.org bug NB#59711
1808 2007-06-14 Armin Burgmeier <armin@openismus.com>
1810 * src/widgets/modest-attachments-view.h:
1811 * src/widgets/modest-attachments-view.c: Added
1812 modest_attachments_view_has_attachments() and fixed coordinate
1813 transformation in get_att_view_at_coords(). This fixes attachment
1816 * src/widgets/modest-msg-view.c: Make use of
1817 modest_attachments_view_has_attachments() to decide whether to show
1818 attachments in the header.
1820 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1823 (on_change), (on_combo_security_changed),
1824 (modest_connection_specific_smtp_edit_window_init),
1825 (modest_connection_specific_smtp_edit_window_set_connection),
1826 (modest_connection_specific_smtp_edit_window_is_dirty):
1827 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1828 * src/maemo/modest-connection-specific-smtp-window.c:
1831 Show an comfirmation dialog for the smpt-edit-window if there are
1832 unsaved changes and the user hits cancel.
1833 (projects.maemo.org bug NB#60479)
1835 2007-06-14 Armin Burgmeier <armin@openismus.com>
1837 * src/maemo/easysetup/modest-easysetup-wizard.c:
1838 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1839 address" info in banner instead of node, and select all the text as
1840 per UI spec. This fixes projects.maemo.org bug NB#60550.
1842 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1844 reviewed by: <delete if not using a buddy>
1846 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1847 * src/modest-ui-actions.c: (folder_refreshed_cb):
1849 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1851 * src/widgets/modest-folder-view.c: (filter_row):
1852 Explictly filter out the per-account outbox accounts. I don't know why
1853 these only sometimes show up, but now they should never show up in the UI.
1854 This should fix projects.maemo.org bug NB#60160.
1856 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1858 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1859 when the toolbar does not exist yet.
1860 * src/modest-widget-memory.c: (save_settings_header_view):
1861 Added g_warnings() to help us to discover when we are trying to set
1862 an empty columns list in gconf.
1864 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1866 * src/modest-init.h:
1867 * src/modest-init.c:
1868 Added modest_init_get_default_header_view_column_ids().
1870 * src/modest-widget-memory.c: (restore_settings_header_view):
1871 Use the new function to get defaults, if the gconf key is empty,
1872 instead of not creating any columns. This seems to fix the
1873 empty right-hand pane problems.
1875 * src/widgets/modest-header-view.h: Improved documentation.
1877 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1880 Revert the use of the display name as the account name, because this
1881 is generally wrong and would break the code that follows.
1883 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1885 * src/maemo/easysetup/modest-easysetup-wizard.c:
1886 (check_for_supported_auth_methods), (on_before_next),
1889 More correct fix for projects.maemo.org bug NB# 58991
1890 Do not longer accept AUTH_PASSWORD as secure method and choose
1891 correct method when creating the account.
1893 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1895 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1896 Fixed projects.maemo.org bug NB# 58991
1898 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1900 * src/modest-init.c: (modest_init_init_core),
1901 (modest_init_local_folders): Fixed compilation errors.
1903 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1905 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1906 Remove unnecessary lib/include, though it is good in principle when needed.
1908 * src/modest-init.c: (modest_init_one_local_folder),
1909 (modest_init_local_folders):
1910 * src/modest-init.h: Initialize the .modest library for memory cards,
1911 instead of just doing nothing for them. This should allow us to create
1912 folders there, fixing projects.maemo.org bug NB#59297.
1914 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1916 * libmodest-dbus-client/libmodest-dbus-client.c:
1917 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1918 (libmodest_dbus_client_compose_mail),
1919 (libmodest_dbus_client_open_message),
1920 (libmodest_dbus_client_send_and_receive),
1921 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1923 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1924 (on_idle_open_message), (modest_dbus_req_handler),
1925 (search_result_to_message), (modest_dbus_req_filter):
1926 * src/modest-search.c: (add_hit), (modest_search_folder),
1927 (modest_search_all_accounts): Improved debug messages.
1929 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1931 * src/modest-tny-account-store.c:
1932 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1935 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1938 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1940 * src/modest-tny-account-store.c: (get_server_accounts):
1941 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1942 even when there are no accounts, so that the Outbox folder is always
1943 visible. This fixes projects.maemo.org bug NB#60158.
1945 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1947 * src/maemo/modest-main-window.c: (create_details_widget):
1948 Use the mcen_va_never logical ID.
1950 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1952 * src/dbus_api/modest-dbus-api.h:
1953 * src/dbus_api/modest-dbus-callbacks.c:
1954 (on_idle_open_default_inbox), (on_open_default_inbox),
1955 (modest_dbus_req_handler):
1956 Added a new OpenDefaultInbox method.
1958 * libmodest-dbus-client/libmodest-dbus-client.h:
1959 * libmodest-dbus-client/libmodest-dbus-client.c:
1960 Added libmodest_dbus_client_open_default_inbox() to call the new
1961 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1962 though it should maybe be used by a new osso-email-interface function.
1964 * tests/dbus_api/Makefile.am:
1965 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1968 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1970 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1971 NULL, so that the signals get all the keys. This should not actually
1972 change any behaviour because we currently update everything when anything
1975 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1977 * src/widgets/modest-folder-view.c: (text_cell_data),
1978 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1979 (find_inbox_iter): If tinymail tells us that the folder is
1980 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1981 This causes the inbox to be selected at startup, fixing part of
1982 projects.maemo.org bug NB#56305.
1984 * src/modest-ui-dimming-rules.c:
1985 (modest_ui_dimming_rules_on_tools_smtp_servers):
1986 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1987 the SMTP servers menu item.
1988 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1989 that the SMTP Servers menu item is dimmed when there are no accounts,
1990 as a future version of the UI spec will require. This fixes
1991 projects.maemo.org bug NB#56305.
1993 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1995 * src/maemo/modest-maemo-utils.c:
1996 (modest_maemo_utils_get_supported_secure_authentication_methods):
1997 Added label to dialog instead of unreadable title
1999 * src/maemo/modest-main-window.c: (sync_accounts_cb),
2000 (modest_main_window_new):
2001 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
2004 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
2005 * src/modest-account-mgr.h:
2006 Added method to avoid code duplication
2008 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2009 (modest_ui_actions_on_send_receive):
2010 Use modest_account_mgr_has_accounts
2012 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2014 * src/maemo/easysetup/modest-presets.c:
2015 (modest_presets_get_info_server_security): Do not report secure auth
2017 * src/modest-protocol-info.c: Use the defines for the gconf key names
2018 for secure authentication. This was not working because we were writing
2019 Password and reading password, and the check was case sensitive.
2020 With this, gmail now works for receiving and sending when created via
2023 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2025 * src/maemo/easysetup/modest-presets.c:
2026 (modest_presets_get_info_server_security): Correct the key name for
2027 SecureSmtp, because it seems to be case-sensitive.
2028 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2029 Do not try to get the 0th notebook page if there are 0 pages, to
2030 avoid a g_warning().
2032 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
2035 Prevent use of the new notification feature for now, because it currently
2036 shows one dialog for each new email, which is annoying.
2038 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2040 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2041 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2042 when no country was selected, so that we show the global ones.
2043 * src/maemo/easysetup/modest-presets.c:
2044 (modest_presets_get_providers): Return only the global providers, not
2045 all providers when mmc=0 was requested.
2047 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2049 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2050 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2051 provider ID in the combo.
2053 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2054 Do not show the page numbers, because it would be confusing when we add
2055 the 2 extra pages for the custom setup, when the user chooses the "Other"
2056 provider. This fixes projects.maemo.org bug NB#59028
2058 * src/modest-init.c: (modest_init_init_core),
2059 (modest_init_local_folders):
2060 * src/modest-init.h:
2061 * src/modest-tny-account.c:
2062 (modest_tny_account_new_for_local_folders): Do not create default folders
2063 for the memory card. This should fix projects.maemo.org bug NB#59328.
2065 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2067 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2068 Free the changed_conf_keys string items. They are already freed in the
2069 idle handler if that runs first.
2071 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2073 * src/modest-ui-actions.c:
2074 (modest_ui_actions_on_password_requested): Check that the server name
2075 is not NULL, because I just saw a password dialog with (null) as the
2078 * src/modest-tny-folder.[h|c]: Added
2079 modest_tny_folder_is_memory_card_folder().
2080 * src/modest-ui-dimming-rules.c:
2081 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2082 menu item for memory cards, as per the UI spec (section 7.4). This should
2083 fix projects.maemo.org bug NB#59297.
2085 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2087 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2088 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2089 is another problem with the code, see Murray's comment at line 772)
2091 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2093 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2094 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2095 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2096 (load_from_file), (easysetup_country_combo_box_init),
2097 (easysetup_country_combo_box_get_active_country_ids),
2098 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2099 instead of just one ID, to avoid duplicate country names in the UI.
2101 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2102 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2103 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2104 a single ID, avoiding duplicate providers.
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (on_combo_account_country): Adapt to use a list.
2108 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2111 keys changed in the last X seconds.
2113 * src/modest-account-mgr.h:
2114 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2115 (on_key_change), (modest_account_mgr_class_init),
2116 (modest_account_mgr_init), (modest_account_mgr_finalize):
2117 As the keys are changed, save them in a GSList* and signal that GSList*
2118 further every X seconds, to batch changes, to allow us to do just one
2119 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2120 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2122 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2123 changed signal signature.
2125 * src/modest-conf.c: (modest_conf_set_list),
2126 (modest_conf_on_change): Reenable notification.
2128 (modest_conf_maemo_fake_on_change): Comment out the hack that
2129 notified immediately instead of asynchronously.
2131 * src/widgets/modest-account-view.h:
2132 * src/widgets/modest-account-view.c:
2133 (update_account_view): Select the previously-selected account ID,
2134 if possible. This fixes projects.maemo.org bug NB#56933.
2136 (on_account_changed), (on_account_removed),
2137 (modest_account_view_select_account):
2139 Remove the block/unblock functions
2140 because they were not useful.
2142 * src/maemo/modest-account-view-window.c:
2143 (on_delete_button_clicked), (on_edit_button_clicked),
2144 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2146 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2149 Improve the error dialog to show Incorrect Account Settings, which seems
2150 clearer, and say that the internal error message (to be removed from the
2151 dialog later) is often misleading.
2152 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2154 * src/modest-tny-account.c:
2155 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2156 URL because this is so useful for debugging on the device.
2158 * src/widgets/modest-serversecurity-combo-box.c:
2159 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2161 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2163 * src/modest-mail-operation.c:
2164 (modest_mail_operation_send_new_mail):
2165 Added a comment about a nasty but apparently harmless message. Details
2166 added to the wiki g_warnings() page.
2168 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2170 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2171 (modest_tny_send_queue_class_init):
2172 Do not use the priv struct because it is empty, to avoid g_warnings
2173 about a non-existant priv struct.
2175 * src/modest-tny-account-store.c:
2176 (modest_tny_account_store_get_server_account),
2177 (modest_tny_account_store_get_transport_account_for_open_connection
2178 ): Do not try to get transport server accounts for local folders,
2179 because they don't have any. This avoids a g_warning().
2181 * src/maemo/modest-main-window.c:
2182 (modest_main_window_notify_send_receive_initied),
2183 (on_configuration_key_changed):
2184 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2185 * src/modest-defs.h:
2186 * src/modest-mail-operation.c:
2187 (modest_mail_operation_update_account):
2188 * src/modest-tny-account-store.h:
2189 * src/modest-tny-account.c:
2190 (modest_tny_account_get_special_folder),
2191 (modest_tny_account_new_for_local_folders),
2192 (modest_tny_account_new_for_per_account_local_outbox_folder):
2193 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2194 * src/modest-tny-local-folders-account.c:
2195 (add_account_folders_to_merged_folder):
2196 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2197 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2198 (modest_ui_actions_on_send):
2199 * src/widgets/modest-folder-view.c: (update_model):
2200 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2201 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2202 modest_tny_account_store_get_tny_account_by_account() to
2203 modest_tny_account_store_get_server_account() to make the code clearer.
2205 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2207 * src/dbus_api/modest-dbus-api.h:
2208 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2209 * src/maemo/modest-msg-edit-window.c:
2210 (modest_msg_edit_window_attach_file_noninteractive):
2211 added g_warning in case the file to be attached does not exist
2212 * tests/dbus_api/test_compose_mail.c: (main):
2213 removed obsolete comment, added generic files as test case
2215 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2217 * src/modest-tny-account-store.c: (get_server_accounts):
2218 Create the local folders account only once, not once for each outbox, and
2219 not only when there are some outboxes.
2221 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2223 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2224 code that is causing a crash at startup. Sergio says that he is fixing this.
2226 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2228 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2229 * src/maemo/modest-account-settings-dialog.c:
2230 (create_page_outgoing),
2231 (modest_account_settings_dialog_set_account_name),
2232 (save_configuration):
2233 - Fixed handling of the "Use secure authentication" toggle to comply with
2234 the ui specification. See also projects.maemo.org bug NB#58400
2236 - Restore the Secure connection setting combo correctly when loading
2239 * src/maemo/modest-maemo-utils.c:
2240 (on_camel_account_get_supported_secure_authentication),
2241 (modest_maemo_utils_get_supported_secure_authentication_methods):
2242 Fixed a crasher if operation is canceled
2244 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2245 (modest_protocol_info_auth_is_secure):
2246 * src/modest-protocol-info.h:
2248 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2249 the sense of the "Use secure authentication" toggle.
2251 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-tny-account-store.h:
2254 * src/modest-tny-account-store.c:
2255 Added modest_tny_account_store_get_local_folders_account().
2257 * src/modest-tny-folder.h:
2258 * src/modest-tny-folder.c:
2259 (modest_tny_folder_get_account):
2260 Added this replacement for tny_folder_get_account() which returns
2261 the local-folders account for TnyMergeFolders, to avoid the
2262 warning about the unimplemented get_account_func() vfunc().
2264 (modest_tny_folder_get_rules),
2265 * src/modest-ui-actions.c:
2266 (modest_ui_actions_on_folder_selection_changed):
2267 * src/modest-mail-operation.c:
2268 (modest_mail_operation_remove_folder),
2269 (modest_mail_operation_xfer_folder),
2270 (modest_mail_operation_rename_folder),
2271 (modest_mail_operation_get_msg),
2272 (modest_mail_operation_get_msgs_full),
2273 (modest_mail_operation_remove_msg),
2274 (modest_mail_operation_xfer_msgs),
2275 (modest_mail_operation_refresh_folder):
2276 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2278 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2280 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2281 (modest_server_account_set_security):
2282 * src/modest-defs.h: Add comments explaining that our
2283 UI spec means TLS when it says Normal, so these do not look like errors.
2285 * src/modest-tny-account.c:
2286 (modest_tny_account_new_from_server_account): Use the new tinymail
2287 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2288 for TLS. This should fix projects.maemo.org bug NB#58460.
2290 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2292 * src/maemo/easysetup/modest-easysetup-wizard.c:
2293 (create_account): Correct the position of the gconf sanity check warning.
2294 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2295 of using the g_idle_add() hack, because this does not seem to be necessary
2296 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2297 caused by something other than maemo's gconf.
2298 This fixes projects.maemo.org bug #59022.
2300 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-account-mgr-helpers.c:
2303 (modest_account_mgr_get_default_account): Do not check that the account
2304 exists if there is no default account (NULL), to fix a runtime warning.
2306 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2308 * src/widgets/modest-folder-view.c: (update_model):
2309 Do not unref the treemodel before we have finished with it.
2310 This prevents a valgrind warning and an occasional crash at startup.
2312 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2314 * libmodest-dbus-client/libmodest-dbus-client.h:
2315 added libmodest_dbus_client_compose_mail()
2316 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2318 added functions needed for SendAsMail() functionality
2319 * src/maemo/modest-msg-edit-window.c:
2320 (modest_msg_edit_window_attach_file_noninteractive):
2321 non interactively attaching files to message edit window
2322 * src/widgets/modest-msg-edit-window.h:
2323 * tests/dbus_api/Makefile.am:
2324 added test_compose_mail.c
2325 * tests/dbus_api/test_compose_mail.c: (main):
2327 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2329 * src/modest-account-view.c:
2330 Fixed bug projects.maemo.org bug NB#59307
2332 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2334 * src/maemo/easysetup/modest-easysetup-wizard.c:
2335 (get_serverport_incoming), (on_before_next), (create_account):
2336 * src/maemo/modest-account-settings-dialog.c:
2337 (modest_account_settings_dialog_set_account_name):
2338 * src/maemo/modest-maemo-utils.c:
2339 (on_camel_account_get_supported_secure_authentication_status),
2340 (on_camel_account_get_supported_secure_authentication),
2341 (on_secure_auth_cancel),
2342 (modest_maemo_utils_get_supported_secure_authentication_methods):
2344 Implemented security authentication for settings and easysetup.
2346 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2348 * src/maemo/modest-main-window.c: (create_details_widget):
2349 Show the total size for memory card accounts too, instead of showing
2350 the name again. Fixes bug projects.maemo.org bug NB#59307.
2352 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2355 * src/modest-tny-simple-folder-store.c:
2356 * src/modest-tny-simple-folder-store.h: Removed.
2358 * src/modest-tny-local-folders-account.h
2359 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2360 for the local-folders maildir, with an extra TnyMergedFolder containing
2361 the folders of the per-account outbox store accounts.
2362 * src/modest-tny-account-store.c: (get_server_accounts):
2363 Add the outboxes to the special local folders account after creating it.
2365 * src/modest-tny-account.c:
2366 (modest_tny_account_new_for_local_folders): Create the derived
2367 account when creating the main local-folders account.
2369 * src/maemo/modest-main-window.c: (create_details_widget),
2370 (modest_main_window_set_contents_style):
2371 Adapted to the use of the derived account instead of the folder store.
2373 * src/modest-ui-actions.c:
2374 (modest_ui_actions_on_folder_selection_changed):
2375 * src/modest-ui-dimming-rules.c:
2376 (modest_ui_dimming_rules_on_new_folder):
2377 * src/widgets/modest-folder-view.c: (text_cell_data),
2378 (icon_cell_data), (filter_row), (update_model),
2379 (get_cmp_rows_type_pos):
2382 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2383 Do not get the priv struct, because no priv struct has been set,
2384 to avoid a runtime warning.
2386 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2387 #ifelse with #else, to fix a warning, to fix the build.
2390 2007-06-05 Christian Kellner <ckellner@openismus.com>
2392 * libmodest-dbus-client/libmodest-dbus-client.c:
2393 Fix small typo in doc (why do you always see them
2394 AFTER committing stuff?)
2397 2007-06-05 Christian Kellner <ckellner@openismus.com>
2399 * libmodest-dbus-client/libmodest-dbus-client.c:
2400 (libmodest_dbus_client_search):
2401 Initialize hit list with NULL. Also set folder list
2402 to "" if NULL was supplied.
2405 2007-06-03 Christian Kellner <ckellner@openismus.com>
2407 * libmodest-dbus-client/libmodest-dbus-client.c:
2408 (modest_search_hit_list_free):
2409 Make it save to call it with NULL.
2411 * src/dbus_api/modest-dbus-callbacks.c:
2412 * src/modest-search.c:
2413 Return full ModestSearchHits as the search result list not TnyHeader
2414 since can't be around withouth the correspoding TnyFolder.
2416 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2418 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2419 Added currently commented code to check for secure auth
2421 * src/maemo/modest-account-settings-dialog.c: (on_response),
2422 (save_configuration), (show_ok):
2423 Fixed projects.maemo.org bugs NB #59248 and #59251
2425 * src/maemo/modest-maemo-utils.c:
2426 (on_camel_account_get_supported_secure_authentication_status),
2427 (on_camel_account_get_supported_secure_authentication),
2428 (modest_maemo_utils_get_supported_secure_authentication_methods):
2429 * src/maemo/modest-maemo-utils.h:
2430 Moved get_supported_secure_authentication() method here to be able
2431 to use it from easysetup wizard.
2433 * src/modest-pair.c: (on_pair_compare_as_string):
2434 Should compare string with first part of pair and not
2435 strcmp pairs which will crash.
2437 * src/modest-protocol-info.c:
2438 (modest_protocol_info_protocol_is_store):
2439 * src/modest-protocol-info.h:
2440 Added modest_protocol_info_get_auth_protocol_name()
2442 2007-06-03 Armin Burgmeier <armin@openismus.com>
2444 * src/modest-mail-operation.c:
2445 (modest_mail_operation_get_msgs_full): Set priv->account also when
2446 only retrieving a single message. This avoids a crash when canceling
2449 (modest_mail_operation_notify_end): Do not explicitely remove the
2450 operation from the queue but only emit the progress_changed signal.
2451 The queue itself listens to that signal to remove the operation when
2452 it is finished. This reduces coupling and removes a potential deadlock
2453 when modest_mail_operation_notify_end() is called from the queue
2454 itself. If that is a problem performance-wise, I would suggest to
2455 implement a status-changed signal or something.
2457 * src/modest-mail-operation-queue.c: Make sure to never call a
2458 function from another file while the queue is locked. This (hopefully)
2459 fixes another deadlock when exiting the application while retrieving
2462 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2464 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2465 Fixed build if libogs is not available
2467 2007-06-03 Christian Kellner <ckellner@openismus.com>
2469 * libmodest-dbus-client/libmodest-dbus-client.h:
2470 * libmodest-dbus-client/libmodest-dbus-client.c:
2471 (libmodest_dbus_client_delete_message):
2472 Implement deletion of messages (Client side).
2474 (modest_search_hit_free),
2475 (modest_search_hit_list_free):
2476 Utility functions to free the result hits.
2478 * src/dbus_api/modest-dbus-api.h:
2479 * src/dbus_api/modest-dbus-callbacks.c:
2480 (on_delete_message),
2481 (modest_dbus_req_handler):
2482 Implement deletion of messages (Server side).
2484 * tests/dbus_api/test_search.c: (main):
2487 * tests/dbus_api/Makefile.am:
2488 * tests/dbus_api/test_delete_message:
2489 Add little test for the message deletion logic
2491 2007-06-03 Armin Burgmeier <armin@openismus.com>
2493 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2494 when the operation queue was not empty. projects.maemo.org bug
2497 2007-06-03 Armin Burgmeier <armin@openismus.com>
2499 * src/widgets/modest-account-view.c
2500 (on_account_default_toggled): Toggle default account column
2501 explicitely instead of waiting for gconf notification (which is
2502 currently ignored). This should fix projects.maemo.org bug NB#56910
2503 for now. It should probably be removed when gconf notifications are
2506 2007-06-03 Christian Kellner <ckellner@openismus.com>
2508 * libmodest-dbus-client/libmodest-dbus-client.c:
2509 Removed debugging spew.
2511 * src/dbus_api/modest-dbus-callbacks.c:
2512 Added debugging info.
2514 * src/modest-search.c:
2515 (modest_search_all_accounts):
2516 Use tny_account_store_get_accounts () on the account store
2517 to get all accounts which is the way to get all accounts.
2519 * tests/dbus_api/test_search.c: (main):
2520 Make it possible to supply the search term on the command line.
2522 2007-06-03 Christian Kellner <ckellner@openismus.com>
2524 * libmodest-dbus-client/libmodest-dbus-client.c:
2525 * libmodest-dbus-client/libmodest-dbus-client.h:
2526 Implement searching for mesages over raw dbus. (Client side)
2528 * src/dbus_api/Makefile.am:
2529 * src/dbus_api/modest-dbus-api.h:
2530 * src/dbus_api/modest-dbus-callbacks.c:
2531 * src/dbus_api/modest-dbus-callbacks.h:
2532 Search framework (Server side). Also implement on_idle_open_message().
2534 * src/maemo/modest-platform.c: (modest_platform_init):
2535 Prepare for raw dbus/osso rpc interaction.
2537 * src/modest-search.h:
2538 Changed minsize from unspecific guint to guint32.
2540 * src/modest-search.c:
2542 Added strange hack which magically made tnymail work.
2544 (modest_search_folder),
2545 (modest_search_account),
2546 (modest_search_all_accounts):
2547 Implement helper functions to search all accounts, specific account
2550 * tests/dbus_api/Makefile.am:
2551 * tests/dbus_api/test_open_message.c:
2552 Read url to open from commandline.
2554 * tests/dbus_api/test_search.c:
2555 Implement small test for dbus search stuff
2557 2007-06-02 Armin Burgmeier <armin@openismus.com>
2559 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2560 include account type and account title. This fixes projects.maemo.org
2563 * src/maemo/modest-account-view-window.c: Set a title for the window.
2565 2007-06-02 Armin Burgmeier <armin@openismus.com>
2567 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2568 incoming and outgoing server name based on email address and server
2569 types as long as the names have not been edited manually. This fixes
2570 projects.maemo.org bug NB#58671.
2572 2007-06-02 Armin Burgmeier <armin@openismus.com>
2574 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2575 server type cannot be changed in future to the incoming details page
2576 when creating an account. This fixes projects.maemo.org bug NB#59029.
2578 2007-06-02 Armin Burgmeier <armin@openismus.com>
2580 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2581 and assigned max width chars so that they wrap instead of being
2582 truncated. Fixes projects.maemo.org bug NB#56126.
2584 2007-06-02 Armin Burgmeier <armin@openismus.com>
2586 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2587 introductory note to the connection specific smtp servers dialog, as
2588 section 8.12 of the email UI specification requires. This fixes
2589 projects.maemo.org bug NB#59212.
2591 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2593 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2594 Check for running mail operations, and offer to cancel them, as per the UI
2595 spec. This fixes projects.maemo.org bug NB#59041 .
2596 However, I suspect that tinymail may still use the network connection
2597 in ways that we cannot detect or cancel. But it should at least adapt to
2598 changes fairly well.
2600 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2602 * src/modest-tny-account-store.c: (recreate_all_accounts),
2603 (get_cached_accounts), (get_server_accounts): Do more sensible
2604 ref-counting of the temporarily-cached outbox accounts list. This seems
2605 to fix a crash when entering the password when the password was wrong.
2607 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2609 * src/gnome/modest-main-window.c: (connect_signals):
2610 * src/modest-tny-account-store.c: (get_password),
2611 (modest_tny_account_store_alert): Added comments and clues and
2612 commented-out code about how we currently fail to deal with connection
2613 errors and wrong passwords, and how we should.
2615 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2617 * src/widgets/modest-retrieve-combo-box.c:
2618 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2619 This fixes projects.maemo.org bug NB#58472 .
2621 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2623 * src/maemo/easysetup/modest-easysetup-wizard.c:
2624 (create_page_complete_easysetup):
2625 (create_page_complete_custom): Correct the last commit,
2626 putting the correct sentences in the correct pages.
2628 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2630 * src/maemo/easysetup/modest-easysetup-wizard.c:
2631 (create_page_complete_custom): Show the second sentence of text
2632 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2635 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2637 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2638 Set the leave-on-server conf key by default. This fixes
2639 projects.maemo.org bug NB#59258 .
2641 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2643 * src/maemo/modest-account-view-window.c:
2644 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2645 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2648 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/easysetup/modest-easysetup-wizard.c:
2651 (create_caption_new_with_asterisk):
2652 * src/maemo/modest-account-settings-dialog.c:
2653 (create_caption_new_with_asterisk):
2654 Uncomment the code to add the asterisk, because they are no longer in the
2655 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2656 (update_incoming_server_title): Add an asterisk here too.
2658 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2660 * src/maemo/modest-maemo-global-settings-dialog.c:
2661 (current_connection): Check that we are even connected before trying to
2662 get the current connection name, to prevent a warning.
2664 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2665 Change the comments because tny_maemo_conic_device_connect() is now meant to
2667 * src/modest-mail-operation.c:
2668 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2669 make sure we have a connection and fail if we can't connect.
2671 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2673 * src/maemo/modest-main-window.c:
2674 (on_account_store_connecting_finished): Do not try to get the
2675 connection ID if we are not really connected. I am surprised that
2676 this signal handler is called when we are not connected.
2678 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2680 * src/modest-error.h:
2681 * src/modest-ui-actions.c:
2682 (modest_ui_actions_get_msgs_full_error_handler):
2683 Renamed an enum, added comments, added an enum
2684 for retrieve-limit errors.
2686 * src/modest-mail-operation.c: (foreach_add_item),
2687 (internal_folder_observer_update), (update_account_thread),
2688 (modest_mail_operation_get_msgs_full):
2689 (modest_mail_operation_update_account),
2690 Added comments about how this works, and some code that should
2691 (but does not) check the retrieve-limit. See the TODO comment.
2693 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2695 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2696 Initialize help_id to fix the build. Warnings are good.
2698 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2700 * src/widgets/modest-hbox-cell-renderer.c:
2701 (modest_hbox_cell_renderer_append):
2702 * src/widgets/modest-vbox-cell-renderer.c:
2703 (modest_vbox_cell_renderer_append):
2704 Fix the last commit by doing an extra ref.
2706 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2708 * src/widgets/modest-hbox-cell-renderer.c:
2709 (modest_hbox_cell_renderer_append):
2710 * src/widgets/modest-vbox-cell-renderer.c:
2711 (modest_vbox_cell_renderer_append):
2712 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2713 to fix the build with Maemo Bora.
2714 However, there seems to be a remaining crash, probably due to reference
2717 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2719 * src/modest-tny-account.c:
2720 (modest_tny_account_new_for_local_folders):
2721 Use hildon_file_system_info_async_new() to get a better name for
2722 the memory card account, setting it as the account name.
2723 The timing seems to work, but this is probably
2724 not the best place to do this. See the TODO comment.
2725 * src/maemo/modest-main-window.c: (create_details_widget):
2726 * src/widgets/modest-folder-view.c: (text_cell_data):
2727 Use the tny account name instead of hardcoding a name.
2729 2007-05-30 Christian Kellner <ckellner@openismus.com>
2731 * src/modest-search.c: (modest_search):
2732 Correctly set part_search_func even if we have already parsed
2733 the query and thus a valid OgsTextSearcher object.
2735 2007-05-30 Christian Kellner <ckellner@openismus.com>
2738 Search and check for libogs.
2741 Incooparte the ogs build env.
2743 * src/modest-mime-part-search-stream.c:
2744 * src/modest-mime-part-search-stream.h:
2745 Removed since we do the real searching now in modest-search.c.
2747 * src/modest-search.c:
2748 * src/modest-search.h:
2749 Implement support for ogs. We use that if available and requested
2750 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2751 should now handle the corner case when the search term is spread
2752 across multiple reads.
2753 Also the logic in modest_search () was corrected to search all
2754 requested fields until one is found.
2756 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2758 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2760 * src/modest-init.h:
2761 * src/modest-init.c: Made modest_init_local_folders() take a
2762 path and be public so we can iniitialize maildir folders on
2765 * src/modest-local-folder-info.h:
2766 * src/modest-local-folder-info.c:
2767 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2769 * src/modest-tny-account.c:
2770 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2771 still means the standard local-folders path on the local volume.
2773 * src/modest-tny-account-store.c:
2774 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2775 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2776 all accounts when that happens.
2777 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2778 this too, so it shows up in the treeview.
2780 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/modest-maemo-global-settings-dialog.c:
2783 (current_connection):
2784 * src/widgets/modest-global-settings-dialog.c:
2785 (current_connection_default):
2786 Use the enum values instead of 0, 1 and -1,
2787 to make the code clearer.
2789 * src/modest-account-mgr-helpers.c:
2790 (modest_account_mgr_get_connection_specific_smtp): Make this code
2793 * src/modest-runtime.h:
2794 * src/modest-runtime.c:
2795 Added modest_runtime_remove_all_send_queues().
2796 * src/maemo/modest-main-window.c:
2797 (on_account_store_connecting_finished): Recreate the send queues,
2798 using the appropriate transport accounts for this new connection.
2799 Some futher adapting might be needed if the old send queues are not
2800 automatically stopped at this point.
2802 * src/modest-tny-account-store.c: (get_server_accounts):
2803 Create the connection-specific transport accounts, so that they can
2804 be found later by their ID.
2806 * src/modest-tny-account.h:
2807 * src/modest-tny-account.c:
2808 Added modest_tny_account_new_from_server_account_name().
2809 modest_tny_account_new_from_server_account(): Do not create the
2810 send queues here, because they will be
2811 recreated anyway when the connection changes for the first time.
2813 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2815 * src/modest-local-folder-info.h:
2816 * src/modest-local-folder-info.c:
2817 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2818 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2819 tbox_folder): Take a modest account name instead of a server TnyAccount,
2820 so we can have per-modest-account rather than per-transport-account
2822 We must make sure that we change or recreate the exisitng send queues
2823 when the connection changes for connection-specific transport accounts.
2825 * src/modest-tny-account-store.c:
2826 (create_per_account_local_outbox_folders): Create outboxed per modest
2827 account, not per transport account.
2829 * src/modest-tny-account.h:
2830 * src/modest-tny-account.c:
2831 (modest_tny_account_get_special_folder): For outboxes, get the
2832 parent modest account name. The account is ignored for other folders.
2833 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2834 modest account name rather than a server TnyAccount.
2836 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2838 * src/modest-tny-account.c:
2839 (modest_tny_account_new_from_server_account):
2840 Call modest_runtime_get_send_queue() immediately after creating transport
2841 accounts, so that they start trying to send email from the outbox as soon
2842 as possible at startup. This is probably what we want.
2844 * src/modest-mail-operation.c: (update_account_thread):
2845 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2846 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2847 * src/modest-tny-send-queue.h:
2848 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2849 (modest_ui_actions_on_send):
2850 Added comments about how sending works, though it needs some more work.
2852 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-tny-account.c:
2855 (modest_tny_account_get_special_folder): Add TODO because this fails when
2856 the network is busy.
2857 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2858 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2859 Do not try to show this window when there is no active account. The UI
2860 specs does not tell us what to do in this case.
2862 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/Makefile.am:
2867 * src/widgets/Makefile.am: Some dist fixes.
2869 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2871 * src/maemo/modest-connection-specific-smtp-window.c:
2872 (on_button_edit): Make the code clearer, to prevent a double free.
2874 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2876 * src/maemo/modest-account-settings-dialog.c:
2877 (modest_account_settings_dialog_set_account_name),
2878 Check the connection-specific smtp servers checkbox if there are any.
2880 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2881 (modest_connection_specific_smtp_edit_window_init):
2882 Start with a suitable port number.
2884 * src/modest-account-mgr-helpers.h:
2885 * src/modest-account-mgr-helpers.c: Added
2886 modest_account_mgr_get_has_connection_specific_smtp().
2888 (modest_account_mgr_set_connection_specific_smtp),
2889 (modest_account_mgr_remove_connection_specific_smtp),
2890 (modest_account_mgr_get_has_connection_specific_smtp),
2891 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2892 connection-specific smtp server accounts in the account, rather than
2893 the server account conf dir.
2895 This fixes bug projects.maemo.org bug NB#58263 .
2897 * src/modest-tny-account-store.c:
2898 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2899 if there are no server accounts yet, to prevent an infinite loop when there
2900 are no accounts. Document that one must be called before the other.
2902 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2904 * src/modest-account-mgr-helpers.c:
2905 (modest_account_mgr_get_default_account): Make sure that at least
2906 one account is always the default, if there are any enabled accounts.
2907 This is just a sanity check that shouldn't be necessary.
2909 * src/modest-account-mgr-priv.c:
2910 (_modest_account_mgr_account_from_key): Unescape the conf key to
2911 get the real account name. For instance, this is an issue if a space
2912 was in the account name, which can happen because the account name
2913 is generated from the display name.
2914 (_modest_account_mgr_get_account_keyname): Always escape the
2916 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2917 Unescape the conf keys to get the real account names.
2919 For instance, previously the is-default radio button in the accounts
2920 list was not checked for any accounts at first. This fixes that,
2921 and might fix several similar bugs.
2923 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2925 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2926 Removed some debug printfs.
2928 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2930 Modest on-disk outbox directories are now here, for instance:
2931 $HOME/.modest/outboxes/<account-id-1>/outbox
2932 $HOME/.modest/outboxes/<account-id-2>/outbox
2934 $HOME/.modest/local-folders/outbox
2935 so we can have a separate outbox for each account.
2936 But they are shown as one outbox in the GtkTreeView, by using a
2937 TnyMergeFolder in a ModestTnySimpleFolderStore.
2940 * src/modest-tny-simple-folder-store.c:
2941 * src/modest-tny-simple-folder-store.h:
2942 Added ModestTnySimpleFolderStore, used to contain folders from
2943 other folder stores, such as other accounts.
2945 * src/modest-tny-outbox-account.h:
2946 * src/modest-tny-outbox-account.c:
2947 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2948 used for the per-account local outbox folders.
2950 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2951 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2952 only use this (internally) now for the non-outbox local folders.
2954 * src/modest-init.h:
2955 * src/modest-init.c: Added modest_init_one_local_folder(), for
2956 setting up the directory structure for each local folder.
2958 * src/modest-local-folder-info.c:
2959 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2960 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2962 * src/modest-local-folder-info.h:
2963 * src/modest-tny-account-store.c: (on_account_removed),
2964 (on_account_changed), (create_per_account_local_outbox_folders),
2965 (get_server_accounts), (modest_tny_account_store_get_accounts),
2966 (modest_tny_account_store_get_tny_account_by_account),
2967 (modest_tny_folder_store_is_virtual_local_folders):
2969 * src/modest-tny-account.h:
2970 * src/modest-tny-account.c:
2971 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2972 to create an on-disk per-account local outbox folder for each
2974 (create_per_account_local_outbox_folders): Create a local outbox folder
2975 for each transport account.
2976 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2977 for all local folders.
2979 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2980 instead of using g_object_get/set() directly. It is clearer.
2982 (modest_tny_folder_store_get_message_count),
2983 (modest_tny_folder_store_get_local_size
2984 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2985 because we now use these with non-acount folder stores.
2987 (modest_tny_account_get_special_folder),
2988 (modest_tny_account_new_from_server_account),
2989 (modest_tny_account_new_from_account):
2990 (recurse_folders): Adjust to the new outbox system.
2992 * src/modest-tny-folder.h:
2993 * src/modest-tny-folder.c:
2994 (modest_tny_folder_is_local_folder),
2995 (modest_tny_folder_get_local_folder_type),
2996 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2998 * src/widgets/modest-main-window.h:
2999 * src/maemo/modest-main-window.c: (create_details_widget),
3000 (modest_main_window_set_contents_style): Show details for any folder store,
3003 (modest_tny_folder_get_rules):
3004 Remove the const. C does not support constness enough for this.
3006 * src/modest-ui-actions.c:
3007 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
3008 make all outboxes appear as one, in the usual local-folders tree node.
3010 (set_active_account_from_tny_account),
3011 (modest_ui_actions_on_folder_selection_changed):
3012 * src/widgets/modest-folder-view.c: (text_cell_data),
3013 (icon_cell_data), (filter_row),
3014 (add_account_folders_to_merged_folder),
3015 (add_account_folders_to_simple_folder_store), (),
3016 (get_cmp_rows_type_pos), (cmp_rows),
3017 (modest_folder_view_set_account_id_of_visible_server_account):
3018 Adjust to the new outbox system, using generic folder stores and folders
3019 in the GtkTreeModel.
3021 2007-05-23 Christian Kellner <ckellner@openismus.com>
3023 * src/modest-mail-operation.c:
3024 (modest_mail_operation_update_account):
3025 Use info->max_size instead of unintialized local var [small
3026 build fix]. (Added TODO to review that change since I don't
3029 2007-05-23 Marcus Bauer <marcusb@openismus.com>
3031 * libmodest-dbus-client/libmodest-dbus-client.c:
3032 (libmodest_dbus_client_compose_mail): function added
3033 * src/dbus_api/modest-dbus-api.h:
3034 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
3035 (on_compose_mail): Implementation of the SendAsMail functionality
3037 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3039 * src/modest-account-mgr.c:
3040 (modest_account_mgr_add_server_account): Set the secure-connection
3041 conf key for transport accounts as well as store accounts. I don't know
3042 why the if was there. For instance, this makes sure that we use SSL
3043 for the gmail preset from the easysetup wizard.
3045 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3047 * src/gnome/modest-main-window.c:
3048 (on_account_store_connecting_finished), (connect_signals):
3049 * src/maemo/modest-main-window.c:
3050 (on_account_store_connecting_finished), (connect_signals),
3051 (modest_main_window_new):
3052 Handle TnyAccountStore::connecting-finished instead of
3053 TnyDevice::connection-changed, because we cannot actually perform
3054 operations on accounts until TnyAccountStore has itself responded to
3055 the TnyDevice::connection-changed signal. This prevents a GError from
3057 Do not try to update at startup, because we (at least on scratchbox)
3058 already do an update at startup when the device goes online.
3059 This prevents a GError from tinymail.
3060 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3061 Added TODO about stopping simultaneous operations.
3063 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3065 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3066 * src/modest-mail-operation-queue.c:
3067 (modest_mail_operation_queue_remove):
3068 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3069 about where they happened.
3071 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3073 * src/modest-ui-actions.c:
3074 (modest_ui_actions_on_password_requested): Make sure that the remember
3075 output parameter is always TRUE.
3077 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3079 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3080 Show a OK/Cancel dialog if the error is a question, though we still do not
3081 know anything more about what we are asking the user.
3082 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3083 Fix an uninitialized variable (helper). This is a logic error, however.
3085 2007-05-21 Christian Kellner <ckellner@openismus.com>
3087 * src/modest-search.h:
3088 Correct bit shifting in the ModestSearchFlags enum.
3090 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3092 * src/modest-tny-account.c:
3093 (modest_tny_account_new_from_server_account): Do not use the lsub and
3094 check-all hard-coded IMAP options when using POP.
3096 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3098 * src/modest-tny-account.c:
3099 (modest_tny_account_new_from_server_account):
3100 Use NULL for the secure-auth method for POP when Password auth has been
3101 specified by the user, as we already do for IMAP. "auth=Login" causes
3102 an error from camel or the server.
3104 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3106 * src/maemo/modest-account-settings-dialog.c:
3107 (create_page_account_details),
3108 (modest_account_settings_dialog_set_account_name):
3109 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3110 for the leave-on-server checkbox, rathr than just the checkbox, when
3111 the protocol is not POP.
3113 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3115 * src/widgets/modest-account-view.c:
3116 * src/widgets/modest-account-view.h:
3117 Added modest_account_view_select_account() which will be useful later
3118 to asynchronously re-select the edited account.
3120 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/modest-account-settings-dialog.c:
3123 (modest_account_settings_dialog_set_account_name):
3124 Automatically choose the port numbers based on the secure authentication
3125 methods, if they have not been chosen before.
3126 This fixes projects.maemo.org bug NB#56273 .
3128 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3130 * src/maemo/modest-main-window-ui.h:
3131 * src/modest-ui-actions.c:
3132 * src/modest-ui-actions.h:
3133 Connect the Tools/SMTP Servers menu item to
3134 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3135 SMTP servers dialog, as in the UI specification and saves changes when it
3136 is closed. This fixed projects.maemo.org bug NB#56305 .
3138 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3140 * src/maemo/modest-connection-specific-smtp-window.c:
3141 (modest_connection_specific_smtp_window_init):
3142 Use gtk_window_set_default_size() to make this window big enough, so
3143 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3145 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3147 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3148 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3149 (modest_connection_specific_smtp_edit_window_init),
3150 Do not try to connect to a combobox signal before the combobox exists.
3151 This fixes the cras in projects.maemo.org bug NB#56288 .
3152 (modest_connection_specific_smtp_edit_window_get_settings):
3153 Remove the server_account_name parameter which was being checked for NULL
3154 though it was not used.
3156 * src/maemo/modest-connection-specific-smtp-window.c:
3157 (modest_connection_specific_smtp_window_fill_with_connections),
3158 (on_button_edit), (modest_connection_specific_smtp_window_init):
3159 Correct the number of treemodel columns to prevent a warning.
3160 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3161 libconic does not work.
3163 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3165 * src/modest-tny-account.c:
3166 (modest_tny_account_new_from_server_account):
3167 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3168 SMTP when "None" was chosen by the user. However, with my SMTP server that
3169 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3172 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3174 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3175 to explain the memory management issue with the ID in the ModestPair.
3177 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3178 (add_sending_page), (modest_account_assistant_finalize):
3179 * src/gnome/modest-gnome-global-settings-dialog.c:
3180 (create_updating_page), (create_composing_page):
3181 * src/gnome/modest-msg-edit-window.c: (get_transports),
3182 (init_window), (modest_msg_edit_window_finalize),
3183 (modest_msg_edit_window_get_msg_data):
3184 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3185 * src/gnome/modest-transport-widget.c:
3186 (modest_transport_widget_finalize), (smtp_configuration):
3187 * src/maemo/modest-maemo-global-settings-dialog.c:
3188 (create_updating_page), (create_composing_page):
3189 * src/maemo/modest-msg-edit-window.c: (get_transports),
3190 (init_window), (modest_msg_edit_window_finalize),
3191 (modest_msg_edit_window_get_msg_data),
3192 (modest_msg_edit_window_free_msg_data):
3193 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3194 (modest_store_widget_finalize):
3195 * src/maemo/modest-transport-widget.c:
3196 (modest_transport_widget_finalize), (smtp_configuration):
3197 * src/modest-main.c: (send_mail):
3198 * src/widgets/modest-combo-box.h:
3199 * src/widgets/modest-global-settings-dialog-priv.h:
3200 * src/widgets/modest-global-settings-dialog.c:
3201 (modest_global_settings_dialog_finalize):
3202 * src/widgets/modest-msg-edit-window.h:
3203 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3204 as long as the combo box, to prevent use of freed memory for the ID.
3206 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3208 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3209 get_accounts(), to make this clearer. Do not check for the enabled gconf
3210 key, because we do not use this for server accounts (at least, not yet).
3211 This allows us to send email again.
3213 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3215 * src/maemo/modest-platform.c:
3216 (on_modest_conf_update_interval_changed), (modest_platform_init):
3217 Only respond to this particular key change. All these strcmp()s cannot be
3220 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3222 * src/maemo/modest-maemo-global-settings-dialog.c:
3223 (current_connection): Prevent a crash in scratchbox when
3224 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3225 * src/maemo/modest-platform.c:
3226 (on_modest_conf_update_interval_changed), (modest_platform_init):
3227 Get the update interval from gconf and reset it when the gconf key changes.
3229 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3231 * src/modest-protocol-info.c:
3232 * src/modest-protocol-info.h: Adde enum-specific get functions,
3233 instead of using a ModestProtocolType enum parameter.
3235 * src/gnome/modest-account-assistant.c:
3236 * src/gnome/modest-store-widget.c:
3237 * src/gnome/modest-store-widget.h:
3238 * src/gnome/modest-transport-widget.c:
3239 * src/gnome/modest-transport-widget.h:
3240 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3241 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3242 * src/maemo/easysetup/modest-easysetup-wizard.c:
3243 * src/maemo/modest-account-settings-dialog.c:
3244 * src/maemo/modest-account-settings-dialog.h:
3245 * src/maemo/modest-store-widget.c:
3246 * src/maemo/modest-store-widget.h:
3247 * src/maemo/modest-transport-widget.c:
3248 * src/maemo/modest-transport-widget.h:
3249 * src/modest-account-mgr-helpers.c:
3250 * src/modest-account-mgr-helpers.h:
3251 * src/modest-account-mgr.c:
3252 * src/modest-account-mgr.h:
3253 * src/modest-tny-account.c:
3254 * src/modest-tny-folder.c:
3255 * src/widgets/modest-account-view.c:
3256 * src/widgets/modest-retrieve-combo-box.c:
3257 * src/widgets/modest-retrieve-combo-box.h:
3258 * src/widgets/modest-secureauth-combo-box.c:
3259 * src/widgets/modest-serversecurity-combo-box.c:
3260 * src/widgets/modest-serversecurity-combo-box.h:
3261 * tests/check_account-mgr.c:
3262 Use the specific functions, and use the re-renamed enum values for GNOME too.
3264 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3266 * src/modest-pair.h:
3267 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3268 so we can get the second based on the first.
3270 * src/maemo/modest-account-settings-dialog.h:
3271 * src/maemo/modest-account-settings-dialog.c:
3272 Added get_supported_secure_authentication_methods(), though it is mostly
3273 commented-out for now until the necessary API is committed to tinymail.
3274 (modest_account_settings_dialog_set_account_name),
3275 (save_configuration): Request the supported authentication methods from the
3276 server, so we can choose a working method.
3278 * src/modest-tny-account-store.h:
3279 * src/modest-tny-account-store.c:
3280 (modest_tny_account_store_get_session): Rename from
3281 tny_account_store_get_session().
3283 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3285 * src/modest-protocol-info.h: Split the ModestProtocol enum
3286 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3287 There was no need to have these unrelated values in one enum.
3289 * src/: many files: Adapted to changed enum. This makes the code a bit
3290 clearer, and the compiler could catch some errors.
3292 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3294 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3295 Show the detailed internal camel error message when an error happens
3296 during the configuration, so that our testers can give us more clues.
3297 For instance, in projects.maemo.org bug NB#56910 .
3299 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3301 * src/modest-tny-account.c:
3302 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3303 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3305 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3307 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3308 * src/maemo/modest-account-settings-dialog.c:
3309 (modest_account_settings_dialog_set_account_name),
3310 (save_configuration): For the incoming secure authentication checkbox,
3311 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3312 the UI specification. PLAIN does not seem to be supported for most IMAP
3313 servers anyway, and I am not sure what it would mean.
3314 However, we probably need to discover which of the secure-authentication
3315 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3316 * src/modest-account-mgr-helpers.c:
3317 (modest_account_mgr_get_server_account_data):
3319 * src/modest-tny-account.c:
3320 (modest_tny_account_new_from_server_account):
3321 Use tny_account_set_mech() to set secure-authentication methods,
3322 with some special-casing for IMAP, based on my observations of how
3325 * src/modest-account-mgr-helpers.h:
3326 * src/modest-account-mgr.c:
3327 * src/modest-defs.h: Comment that the URI is only used for local folders.
3329 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3331 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3332 parameter const, just to be neat.
3333 * src/modest-text-utils.c: (modest_text_utils_inline):
3334 End g_strconcat() with NULL, as its documentation says. This is almost
3335 certainly the cause of my crash at startup on the device. Interestingly,
3336 valgrind doesn't tell us about these errors.
3338 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3340 * scripts/build-packages: Added more precise comments about how to use
3341 this script, though I still get this error:
3342 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3343 error building tinymail
3345 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3347 * src/maemo/modest-main-window.c: (on_account_update):
3348 Very slight cleanup, hoping to make it simpler to discover what causes
3349 a crash here sometimes.
3351 * src/modest-tny-account.c:
3352 (modest_tny_account_new_from_server_account): Set the port. Added
3353 comments about the options and a TODO comment because I need to find out
3354 how to specify the secure authentication method.
3356 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3358 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3359 changed CFlags paths form modest to libmodest
3361 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3363 * src/modest-account-mgr-helpers.c:
3364 (modest_account_mgr_get_server_account_data),
3365 (modest_account_mgr_free_server_account_data):
3366 * src/modest-account-mgr-helpers.h:
3367 * src/modest-account-mgr.c:
3368 (modest_account_mgr_add_server_account):
3369 * src/modest-defs.h:
3370 * src/modest-tny-account.c:
3371 (modest_tny_account_new_from_server_account):
3372 Determine the options for tny_camel_account_add_option() here,
3373 based on the settings, rather than storing them directly in gconf.
3375 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3377 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3378 Show a more friendly error dialog now that we expect (from the tinymail
3379 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3381 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3383 * src/maemo/modest-main-window.c: (on_account_update): Check that
3384 account_name is not NULL, to prevent a crash at startup that I am
3385 seeing on the N800. I do wonder why it is NULL.
3387 * src/maemo/easysetup/modest-easysetup-wizard.c:
3388 (create_page_user_details):
3389 * src/maemo/modest-account-settings-dialog.c:
3390 (create_page_user_details), (create_page_outgoing):
3391 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3392 (modest_connection_specific_smtp_edit_window_init):
3393 * src/modest-ui-actions.c:
3394 (modest_ui_actions_on_password_requested):
3395 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3396 might do something useful with the on-screen keyboard.
3398 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3400 * src/maemo/modest-main-window.c: (on_account_update):
3401 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3402 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3404 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3406 * src/modest-tny-account-store.c: (on_account_changed):
3407 Correct the signature of this signal handler.
3409 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3411 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3412 Show a HildonNote instead of a GtkDialog for Maemo.
3414 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3416 * src/widgets/modest-account-view.h:
3417 * src/widgets/modest-account-view.c: (on_account_changed),
3418 (on_account_removed). Added a boolean flag, set/unset by
3419 modest_account_view_block_conf_updates(),
3420 modest_account_view_unblock_conf_updates() to prevent unnecessary
3421 updates, but this is not very useful because the gconf notifications are
3422 so delays (maybe only on Maemo Bora).
3423 So auto-updating is turned off, and these functions do an explicit
3424 update when necessary.
3425 However, something else is still doing too much work when adding/removing
3426 accounts, probably in another part of the application.
3428 * src/maemo/modest-account-view-window.c:
3429 (on_delete_button_clicked), (on_edit_button_clicked),
3430 (on_new_button_clicked): Use the new functions.
3432 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3434 * src/modest-account-mgr-helpers.c:
3435 (modest_account_mgr_set_first_account_as_default):
3436 Sort the list of names alphabetically-by-title, so we choose the first one
3438 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3439 alphabetically by the title.
3441 This fixes projects.maemo.org bug NB#56418 .
3443 * src/modest-account-mgr-priv.c:
3444 (_modest_account_mgr_account_from_key):
3445 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3446 avoid a valgrind error, and possible random behaviour.
3448 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3450 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3451 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3452 tinymail documentation to say that this can be expected.
3453 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3454 pretty, and should not happen, but I would prefer to know when it does.
3456 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3458 * configure.ac: When using the older hildon version, probably on Bora,
3459 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3461 * src/widgets/modest-attachment-view.c:
3462 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3465 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3467 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3468 Implemented the prototype. Can be tested with
3469 tests/dbus_api/test_open_message:
3471 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3473 * src/modest-tny-account-store.c:
3474 (modest_tny_account_store_instance_init), (get_password):
3475 * src/modest-ui-actions.c:
3476 (modest_ui_actions_on_password_requested):
3477 Do not store the password in gconf, because this function is called
3478 for non-remembered passwords. Actually use the cached (in the hash map)
3479 password instead of releasing it.
3480 The password will now not be remembered if it is asked via the protected
3481 password dialog, as per the UI spec.
3483 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3485 * src/modest-defs.h:
3486 * src/modest-account-mgr-helpers.h:
3487 * src/modest-account-mgr-helpers.c:
3488 Added modest_server_account_get_username_has_succeeded(),
3489 modest_server_account_set_username_has_succeeded().
3490 (modest_server_account_set_username),
3491 Reset the has-succeeded flag if the username changes.
3493 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3494 * src/maemo/modest-connection-specific-smtp-window.c:
3495 (modest_connection_specific_smtp_window_save_server_accounts):
3496 Use modest_server_account_set_username() instead of using
3497 modest_conf_set_string() directly, so that the has-succeeded flag is always
3500 * src/modest-ui-actions.c:
3501 (modest_ui_actions_on_password_requested): Dim the username entry if
3502 the username has ever worked, as per the UI spec.
3504 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3506 * src/modest-tny-account-store.c: (get_password):
3507 * src/modest-ui-actions.c:
3508 (modest_ui_actions_on_password_requested):
3509 Allow the username to be changed too, though there is more work to
3510 be done on exactly how this behaves.
3512 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3514 * src/modest-account-mgr-helpers.h:
3515 * src/modest-account-mgr-helpers.c:
3516 Added modest_account_mgr_get_display_name(),
3517 modest_server_account_get_username(),
3518 modest_server_account_set_username(),
3519 modest_server_account_set_password(),
3520 modest_server_account_get_hostname() functions so we do not need to
3521 use the conf API directly.
3523 * src/maemo/modest-main-window.c: (connect_signals):
3524 Actually connect ot the ModestAccountStore::request-password signal,
3525 so that we show the dialog when the password is requested by Tinymail,
3526 for isntance if it is empty.
3528 * src/modest-marshal.list:
3529 * src/modest-tny-account-store.c:
3530 (modest_tny_account_store_class_init), (get_password),
3531 (modest_tny_account_store_alert):
3532 * src/modest-tny-account-store.h:
3533 * src/modest-ui-actions.h:
3534 * src/modest-ui-actions.c:
3535 (modest_ui_actions_on_password_requested):
3536 Change the signal parameters, so it is obvious that we are providing
3537 the non human-readable server name, and receiving both the username
3538 and password, though changing of the username is not yet implemented.
3539 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3540 for the GNOME version.
3542 This should fix the projects.maemo.org bug NB#56209, though it does not
3543 work on Bora, because the gconf_client_get() for the password fails
3544 immediately after we save it with gconf_client_set().
3546 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3549 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3550 caused an undefined symbol error:
3551 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3553 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3555 * src/modest-tny-account-store.c:
3556 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3557 using a GError instead of a string message, so we can translate it in
3560 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3562 * src/maemo/modest-address-book.c:
3563 (modest_address_book_check_names):
3564 * src/maemo/modest-msg-view-window.c:
3565 (modest_msg_view_window_clipboard_owner_change):
3566 * src/modest-init.c: (modest_init_init_ui):
3567 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3568 (update_folders_cb), (modest_mail_operation_update_account):
3569 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3570 (modest_ui_actions_on_msg_attachment_clicked),
3571 (modest_ui_actions_on_msg_recpt_activated):
3572 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3573 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3574 (modest_msg_view_search_next):
3575 * src/widgets/modest-recpt-editor.c:
3576 (modest_recpt_editor_on_button_release_event),
3577 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3578 g_message(). At this point we should only be seeing interesting errors on
3579 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3581 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3583 (modest_wizard_dialog_force_title_update):
3584 * src/maemo/easysetup/modest-wizard-dialog.h:
3585 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3586 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3587 can update the title when appropriate. Otherwise the title is wrong if the
3588 pages are added after adding the notebook to the dialog.
3589 This must be a problem in HildonWizardDialog too.
3590 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3592 * src/maemo/easysetup/modest-easysetup-wizard.c:
3593 (create_subsequent_customsetup_pages),
3594 (create_subsequent_easysetup_pages):
3595 Call modest_wizard_dialog_force_title_update() so that the title is
3596 correct even with GTK+ < 2.10.
3597 This fixes projects.maemo.org bug NB#56145 .
3599 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3601 * src/maemo/modest-platform.c:
3602 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3603 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3606 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3608 * src/widgets/modest-window.h:
3609 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3610 and modest_window_save_state(), which invokes it.
3612 * src/widgets/modest-window-mgr.h:
3613 * src/widgets/modest-window-mgr.c:
3614 Added modest_window_mgr_save_state_for_all_windows(), which calls
3615 the save_state vfunc on all registered windows, if implemented.
3617 * src/gnome/modest-msg-edit-window.c:
3618 * src/gnome/modest-msg-view-window.c:
3619 * src/maemo/modest-msg-edit-window.c:
3620 * src/maemo/modest-msg-view-window.c:
3621 * src/maemo/modest-main-window.c:
3622 Specify the existing save_settings functions as implementations of
3623 ModestWindow::save_state_func().
3625 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3626 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3627 enabling hibernation, for instance.
3629 We may need to do the same thing for restoring settings.
3632 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3634 * src/widgets/modest-window-mgr.c:
3635 * src/widgets/modest-window-mgr.h:
3636 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3637 modest_window_mgr_get_hibernation_is_prevented().
3639 * src/maemo/modest-main-window.c:
3640 (on_hildon_program_is_topmost_notify): Prevent hibernation
3641 (possible when the application goes to the background in the WM),
3642 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3644 * src/maemo/easysetup/modest-easysetup-wizard.c:
3645 (modest_easysetup_wizard_dialog_init):
3646 * src/maemo/modest-account-settings-dialog.c:
3647 (modest_account_settings_dialog_init):
3648 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3649 (modest_connection_specific_smtp_edit_window_init):
3650 * src/maemo/modest-connection-specific-smtp-window.c:
3651 (modest_connection_specific_smtp_window_init):
3652 * src/maemo/modest-signature-editor-dialog.c:
3653 (modest_signature_editor_dialog_init):
3654 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3655 prevent hibernation while any of these account settings dialogs are open.
3657 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3659 * src/maemo/Makefile.am:
3660 * src/maemo/modest-osso-state-saving.c:
3661 * src/maemo/modest-osso-state-saving.h: Added
3662 modest_osso_load_state() and modest_osso_save_state() though they do
3663 nothing now. They should iterate through all the open windows and load/save
3665 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3666 save state when closing.
3668 * src/maemo/modest-main-window.c:
3669 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3670 Add a notification handler for the HildonProgram::is-topmost property,
3671 so we can allow hibernation when the application goes into the background.
3672 But we still need to detect when the accounts setup windows are open so
3673 we can stop hibernation when they are open.
3674 To do this, I also added the main window the HildonProgram. This might have
3675 other side-effects/benefits, and should maybe be done for other windows.
3677 * src/maemo/modest-osso-autosave-callbacks.h:
3678 * src/maemo/modest-osso-autosave-callbacks.c:
3679 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3680 though it does not do anything yet, and we might never need this to do
3681 anything. For instance, we already save drafts.
3683 * src/maemo/modest-platform.c: (modest_platform_init):
3684 Specify the libosso auto-save callback.
3686 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3688 * src/maemo/modest-platform.c:
3689 (modest_platform_set_update_interval):
3690 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3691 aparently stays valid between application instances, so we can use this
3692 to remove and reset it later. According to a maemo-developers email from
3695 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3697 * configure.ac: Depend on libalarm for Maemo.
3699 * src/dbus_api/modest-dbus-api.h:
3700 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3701 (on_send_receive), (modest_dbus_req_handler):
3702 Handle a SEND_RECEIVE D-Bus method.
3704 * libmodest-dbus-client/libmodest-dbus-client.c:
3705 (libmodest_dbus_client_send_and_receive):
3706 * libmodest-dbus-client/libmodest-dbus-client.h:
3707 Add C convenience functions for calling the new D-Bus method.
3709 * src/modest-platform.h:
3710 * src/gnome/modest-platform.c:
3711 * src/maemo/modest-platform.c:
3712 Added modest_platform_set_update_interval(), which uses the
3713 alarmd API on Maemo.
3714 (modest_platform_init),
3715 Call modest_platform_set_update_interval(), using a hard-coded
3716 interval for now (until the global settings dialog is implemented),
3717 though I am not sure that this makes sense yet.
3719 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3721 * src/dbus_api/modest-dbus-callbacks.c:
3722 (modest_osso_cb_hw_state_handler):
3723 * src/dbus_api/modest-dbus-callbacks.h:
3724 * src/maemo/modest-platform.c: (modest_platform_init):
3725 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3726 in case this has some effect on the ability for Maemo to ping the
3729 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3731 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3732 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3733 warning. It is probably a logic error, but I need to fix the build.
3735 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3737 * src/modest-account-mgr.h:
3738 * src/modest-account-mgr.c:
3739 (modest_account_mgr_account_names): Add a gboolean enabled_only
3740 parameter, so we can get lists of onlt the enabled accounts.
3742 (modest_account_mgr_add_account),,
3743 (modest_account_mgr_account_with_display_name_exists):
3744 * src/maemo/modest-msg-edit-window.c: (get_transports):
3745 * src/modest-account-mgr-helpers.c:
3746 (modest_account_mgr_set_first_account_as_default):
3747 * src/modest-init.c: (init_default_account_maybe):
3748 * src/modest-tny-account-store.c: (get_accounts):
3749 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3750 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3751 * tests/check_account-mgr.c: (START_TEST):
3752 Provide the extra parameter, as appropriate.
3754 * src/widgets/modest-account-view.c: (update_account_view):
3755 Do not show disabled accounts (meaning that there is no way to
3756 enable/disable accounts in the UI (the feature is not in our UI
3757 specification), so we can use this internally only to mark unfinished
3758 or temporary account data.
3760 * src/maemo/easysetup/modest-easysetup-wizard.c:
3761 (create_account): Add boolean enable parameter, so we can specify FALSE
3762 to create the temporary account.
3763 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3764 (on_before_next): When finishing, when there is a temporary account, just
3766 Also, use a timeout to delay the showing of the dialog until gconf is likely
3767 to return correct information, due to a maemo gconf bug that is fixed in
3768 osso 1.1, but not yet in Bora.
3769 However, the dialog stays on screen after it is destroyed.
3771 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3772 for invalid data when cancelling. Use a hildon note instead of a dialog
3773 to complain about invalid data. Do not show the account-saved note if the
3774 account is disabled (a temporary account that will not really be saved for use
3777 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3779 * src/modest-account-mgr-helpers.h:
3780 * src/modest-account-mgr-helpers.c:
3781 Added modest_account_mgr_unset_default_account(),
3782 Added modest_account_mgr_set_first_account_as_default().
3784 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3785 If it was the default account, unset the default account name.
3787 * src/maemo/modest-account-view-window.c:
3788 (on_delete_button_clicked): If it was the default account,
3789 set the first remaining account as the default instead.
3791 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3792 a NULL account or a NULL default account, to prevent a crash. This should
3793 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3796 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3798 * src/widgets/modest-recpt-editor.c:
3799 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3800 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3801 TODO comment for this. This fixes the build.
3803 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3804 be the best place for it. This will in future update all auto-update accounts,
3805 rather than just the current/default account, when that gconf key exists.
3806 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3807 if there are no accounts, before calling do_send_receive().
3808 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3810 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3811 * src/maemo/modest-main-window-ui.h:
3812 * src/maemo/modest-main-window.c: (on_connection_changed),
3813 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3814 directly, becaue the signal handler does more.
3816 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3818 * src/modest-account-mgr-helpers.c:
3819 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3820 for the case that the account does not exist.
3822 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3823 (equivalent to the modest account name) rather than the tinymail account name
3824 (equivalent to the modest account title - human readable) to get the account data.
3825 Check for null account data to prevent the crash, and add a TODO comment saying that
3826 this needs fixing because it is using the server account name instead of the account name.
3828 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3830 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3831 * src/maemo/modest-account-settings-dialog.c: (show_error),
3833 Use hildon_note_new_information() for informative and error messages,
3834 which seems to be expected for Maemo applications (no documentation that I know of
3835 says this). I am surprised that there is no distinction between info and error
3838 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3840 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3841 it is easy to find where this is used.
3843 * src/maemo/easysetup/modest-easysetup-wizard.c:
3844 (create_page_welcome), (create_page_account_details),
3845 (create_page_user_details), (create_page_complete_easysetup),
3846 (create_page_custom_incoming), (create_page_custom_outgoing),
3847 (create_page_complete_custom):
3848 * src/maemo/modest-account-settings-dialog.c:
3849 (create_page_account_details), (create_page_user_details),
3850 (create_page_incoming), (create_page_outgoing):
3851 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3852 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3853 (modest_connection_specific_smtp_edit_window_init):
3854 * src/maemo/modest-connection-specific-smtp-window.c:
3855 (modest_connection_specific_smtp_window_init):
3856 * src/maemo/modest-signature-editor-dialog.c:
3857 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3858 and scrolling policy as per the Email Application Layout Guide, if I have
3861 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3863 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3864 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3865 which were empty, because these vfuncs have been removed from TnyAccountStore.
3866 This fixes the build.
3868 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/modest-main-window.c:
3871 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3872 showing/hiding it. Added TODO because it probably should not be NULL.
3873 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3874 because unnecessary g_warnings() make degugging difficult.
3876 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3878 * src/maemo/modest-msg-edit-window.c:
3879 (modest_msg_edit_window_select_color),
3880 (modest_msg_edit_window_select_background_color): 2 const corrections and
3881 moving 2 #endifs before closing brackets, to fix the build.
3883 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3885 * src/maemo/easysetup/modest-easysetup-wizard.h:
3886 * src/maemo/easysetup/modest-easysetup-wizard.c:
3887 (modest_easysetup_wizard_dialog_finalize),
3888 (on_button_edit_advanced_settings), (create_page_complete_custom),
3889 (on_response), (create_account):
3890 Implement the Advanced Settings edit button, by saving the account information,
3891 for the Advanded Settings dialog to use directly from gconf, and removing it
3892 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3893 Bug #5533 in the projects.maemo.org bugzilla.
3895 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3897 * src/maemo/modest-msg-view-window.c:
3898 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3899 when opening a message window.
3901 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3903 * src/maemo/easysetup/modest-easysetup-wizard.c:
3904 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3907 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3908 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3909 gconf settings. I probably added more checks than necessary, but that is safer.
3911 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3912 variable to fix the build, but this seems to be used when it is still NULL.
3914 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3916 * src/modest-platform.h:
3917 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3918 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3919 * src/modest-main.c: Implement this function so we can avoid using
3920 maemo-specific API from cross-platform code.
3922 * src/modest-tny-account-store.c:
3923 (get_smtp_specific_transport_account_for_open_connection):
3924 * src/modest-ui-actions.c: (check_for_connection),
3925 (modest_ui_actions_on_item_not_found):
3926 Use modest_platform_connect_and_wait() and put #idefs around other
3927 maemo-specific code, because only maemo currently has a way to
3928 identify connection names.
3930 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3932 * src/modest-tny-account-store.h:
3933 * src/modest-tny-account-store.c:
3934 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3935 the connection-specific SMTP server settings in the configuration.
3937 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3939 * src/maemo/modest-main-window.c: (on_connection_changed),
3941 * src/modest-main.c: (main), (start_ui), (send_mail):
3942 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3943 that is what is intended.
3945 * src/modest-ui-actions.c: (action_send), (action_receive),
3946 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3947 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3948 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3949 SMTP server is used when it is specified.
3951 (modest_ui_actions_on_send_receive):
3952 Check that a connection is open before proceeding.
3953 Receive and then send, instead of vice-versa, as per the specification.
3955 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3957 * src/modest-mail-operation.c:
3958 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3959 though I guess it should be something other than NULL.
3961 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3963 * src/maemo/easysetup/modest-easysetup-wizard.c:
3964 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3965 combo twice, to avoid an g_warning and to make it visible again.
3966 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3967 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3968 (already intended) dereference when detaching, because we then recreate the menu.
3969 But I am not sure why the warning was happening, and it is possible that this is a memory
3972 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3974 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3975 and uri_parse_mailto() utility functions.
3976 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3978 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3980 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3982 * src/dbus_api/modest-dbus-api.h:
3983 * src/dbus_api/modest-dbus-callbacks.c:
3984 Use an idle callback to execute the modest code in the application's own thread.
3985 Remove the helloworld example method.
3986 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3987 parsed, and the open-message method is not implemented because this is not yet implemented in
3989 * libmodest-dbus-client/libmodest-dbus-client.c:
3990 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3991 (libmodest_dbus_client_open_message):
3992 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3994 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3995 body without crashing.
3997 * tests/dbus_api/Makefile.am:
3998 * tests/dbus_api/test_mail_to.c:
3999 * tests/dbus_api/test_open_message.c: New tests for the new methods.
4001 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4003 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
4004 Added file to fix the build. Sorry.
4006 * src/dbus_api/Makefile.am:
4007 * src/dbus_api/modest-dbus-api.h:
4008 * src/dbus_api/modest-dbus-callbacks.h:
4009 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
4010 (modest_dbus_req_handler):
4011 Put constants in a separate header so it can be reused by the
4012 client library, without duplication
4014 * libmodest-dbus-client/Makefile.am:
4015 * libmodest-dbus-client/libmodest-dbus-client.c:
4016 (libmodest_dbus_client_call_helloworld),
4017 (libmodfest_dbus_client_send_mail),
4018 (libmodfest_dbus_client_mailto),
4019 (libmodfest_dbus_client_open_message):
4020 * libmodest-dbus-client/libmodest-dbus-client.h:
4021 (Partly) Implement a send_mail D-Bus method.
4023 * tests/dbus_api/Makefile.am:
4024 * tests/dbus_api/test_send_mail.c: (main): Added a test for
4025 the send_email D-Bus method.
4027 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4031 * libmodest-dbus-client/Makefile.am:
4032 * libmodest-dbus-client/libmodest-dbus-client.c:
4033 * libmodest-dbus-client/libmodest-dbus-client.h:
4034 * tests/dbus_api/Makefile.am:
4035 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
4036 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
4038 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4040 * src/maemo/easysetup/modest-easysetup-wizard.c:
4041 (create_page_account_details):
4042 * src/maemo/modest-account-settings-dialog.c:
4043 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4044 widgets, because this might not be the default in future versions of the Maemo GTK+.
4045 However, I can not not get capitalization to work even in a simple test case.
4047 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4049 * src/maemo/easysetup/modest-easysetup-wizard.c:
4050 (create_page_custom_incoming), (create_page_custom_outgoing):
4051 * src/maemo/modest-account-settings-dialog.c:
4052 (create_page_account_details), (create_page_incoming),
4053 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4054 instead of using gtk_check_button_with_label(), so they are aligned like the other
4055 widgets, as per the UI spec.
4057 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4059 * src/maemo/easysetup/modest-easysetup-wizard.c:
4060 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4061 * src/widgets/modest-validating-entry.c:
4062 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4063 Modest prefix instead of an EasySetup prefix.
4065 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4067 * src/widgets/modest-validating-entry.h:
4068 * src/widgets/modest-validating-entry.c: (on_insert_text),
4069 Added easysetup_validating_entry_set_max_func(), used to set a callback
4070 to call when the max number of characters is reached. GtkEntry has a max-length
4071 already but is silent about it.
4073 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4074 (create_page_account_details), (create_page_user_details),
4076 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4077 (create_page_account_details), (create_page_user_details),
4078 (create_page_outgoing):
4079 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4080 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4081 the UI spec, when the user tries to enter more than the max number of characters.
4083 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4085 * src/maemo/easysetup/modest-easysetup-wizard.c:
4086 (create_page_user_details), (create_page_custom_incoming),
4087 (create_page_custom_outgoing):
4088 * src/maemo/modest-account-settings-dialog.c:
4089 (create_page_user_details), (create_page_incoming),
4090 (create_page_outgoing):
4091 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4092 (modest_connection_specific_smtp_edit_window_init):
4093 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4094 not appropriate. Bad Maemo-specific defaults!.
4096 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4098 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4099 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4100 (modest_signature_editor_dialog_set_settings):
4101 Disable the label and textview when the checkbox is disabled, and use the
4102 specified (UI spec) default signature text.
4104 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4106 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4107 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4109 * src/modest-defs.h:
4110 * src/modest-account-mgr-helpers.h:
4111 * src/modest-account-mgr-helpers.c:
4112 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4114 * src/maemo/Makefile.am:
4115 * src/maemo/modest-signature-editor-dialog.c:
4116 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4119 * src/maemo/modest-account-settings-dialog.h:
4120 * src/maemo/modest-account-settings-dialog.c:
4121 (modest_account_settings_dialog_finalize), (on_button_signature),
4122 (save_configuration): Use the new dialog when the Edit button is pressed, and
4123 save the changes if necessary, as per the UI spec.
4125 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4127 * src/maemo/Makefile.am:
4128 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4129 based on maemo-develoers email from Dirk.
4131 * src/maemo/easysetup/modest-easysetup-wizard.c:
4132 (create_page_welcome), (create_page_account_details),
4133 (create_page_user_details), (create_page_complete_easysetup),
4134 (create_page_custom_incoming), (create_page_custom_outgoing),
4135 (create_page_complete_custom),
4136 (modest_easysetup_wizard_dialog_init):
4137 * src/maemo/modest-account-settings-dialog.c:
4138 (create_page_account_details), (create_page_user_details),
4139 (create_page_incoming), (create_page_outgoing),
4140 (modest_account_settings_dialog_init):
4141 * src/maemo/modest-connection-specific-smtp-window.c:
4142 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4144 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4146 * src/maemo/easysetup/modest-easysetup-wizard.c:
4147 (create_page_account_details), (create_page_custom_outgoing),
4148 (create_page_complete_custom):
4149 * src/maemo/modest-account-settings-dialog.c:
4150 (create_page_user_details), (create_page_incoming),
4151 (create_page_outgoing):
4152 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4153 (modest_connection_specific_smtp_edit_window_init):
4154 Use the correct (UI spec) port min/max, and use horizontal separators,
4157 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4159 * src/maemo/easysetup/modest-easysetup-wizard.c:
4160 (set_default_custom_servernames):
4161 * src/maemo/modest-account-settings-dialog.c:
4162 (create_page_incoming), (on_combo_outgoing_security_changed),
4163 (on_combo_incoming_security_changed), (create_page_outgoing),
4164 (modest_account_settings_dialog_set_account_name),
4165 (save_configuration):
4166 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4167 (on_combo_security_changed),
4168 (modest_connection_specific_smtp_edit_window_init),
4169 (modest_connection_specific_smtp_edit_window_set_connection),
4170 (modest_connection_specific_smtp_edit_window_get_settings):
4171 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4174 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4177 * src/maemo/easysetup/modest-easysetup-wizard.c:
4178 (create_page_custom_outgoing), (create_page_complete_custom):
4179 * src/maemo/modest-account-settings-dialog.c:
4180 (create_page_user_details), (create_page_outgoing):
4181 * src/maemo/modest-account-view-window.c: (button_box_new):
4182 Use changed logical IDs as per the most recent UI spec:
4183 mcen_bd_emailsetup_edit -> mcen_bd_edit
4184 mcen_bd_emailsetup_delete -> mcen_bd_delete
4185 mcen_bd_emailsetup_close -> mcen_bd_close
4187 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4191 * src/dbus_api/Makefile.am:
4192 * src/dbus_api/modest-dbus-callbacks.c:
4193 * src/dbus_api/modest-dbus-callbacks.h:
4194 * src/maemo/modest-platform.c: (modest_platform_init):
4195 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4197 * tests/Makefile.am:
4198 * tests/dbus_api/Makefile.am:
4199 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4201 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4203 * src/maemo/modest-account-settings-dialog.c:
4204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4205 Removed unnecessary includes.
4207 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4209 * src/maemo/easysetup/modest-easysetup-wizard.c:
4210 * src/maemo/modest-account-settings-dialog.c:
4211 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4212 * src/widgets/Makefile.am:
4213 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4214 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4215 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4216 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4217 * src/widgets/modest-secureauth-combo-box.c:
4218 * src/widgets/modest-secureauth-combo-box.h:
4219 * src/widgets/modest-serversecurity-combo-box.c:
4220 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4221 made the GObject names more consistent with the rest of the Modest code.
4223 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4225 * src/maemo/easysetup/Makefile.am:
4226 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4227 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4228 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4229 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4230 * src/maemo/easysetup/modest-easysetup-wizard.c:
4231 * src/maemo/easysetup/modest-validating-entry.c:
4232 * src/maemo/easysetup/modest-validating-entry.h:
4233 * src/maemo/modest-account-settings-dialog.c:
4234 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4235 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4236 widgets/ because they are used outside of easysetup too. After checking in,
4237 svn will allow me to rename them too.
4239 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4241 * src/gnome/modest-msg-edit-window.c:
4242 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4243 linker error, to fix the build on the GNOME platform.
4244 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4245 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4246 ifdefed out to avoid a warning.
4248 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4250 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4251 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4252 some alternative for GTK+ 2.6.
4254 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4256 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4258 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4259 specified for EmailAccountsDialog in UI spec.
4261 * src/maemo/easysetup/modest-easysetup-wizard.c:
4262 * src/maemo/easysetup/modest-easysetup-wizard.h:
4263 * src/maemo/modest-account-settings-dialog.c:
4264 * src/maemo/modest-account-settings-dialog.h:
4265 Reuse a member window widget for the connection-specific SMTP server accounts,
4266 so we can tell it to create/save the accounts only if we actually save changes.
4268 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4269 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4270 (modest_connection_specific_smtp_edit_window_get_settings):
4271 Return a struct instance for temporarily remembering the entered data.
4273 * src/maemo/modest-connection-specific-smtp-window.h:
4274 * src/maemo/modest-connection-specific-smtp-window.c:
4275 (modest_connection_specific_smtp_window_finalize),
4276 (modest_connection_specific_smtp_window_fill_with_connections),
4278 (modest_connection_specific_smtp_window_save_server_accounts),
4279 (update_model_server_names): Do not actually save data until asked,
4280 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4282 (on_selection_changed),
4283 (modest_connection_specific_smtp_window_init): Disable the edit
4284 button when nothing is selected.
4286 * src/modest-account-mgr-helpers.c:
4287 * src/modest-account-mgr-helpers.h:
4288 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4291 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4293 * src/modest-account-mgr-helpers.h:
4294 * src/modest-account-mgr-helpers.c:
4295 (modest_account_mgr_get_unused_account_name),
4296 (modest_account_mgr_get_unused_account_display_name): Added these
4297 utility functions, to avoid code duplication.
4299 * src/maemo/easysetup/modest-easysetup-wizard.c:
4300 (create_page_account_details), (create_account):
4301 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4302 (on_combo_security_changed),
4303 (modest_connection_specific_smtp_edit_window_init),
4304 (modest_connection_specific_smtp_edit_window_save_settings):
4305 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4306 * src/maemo/modest-connection-specific-smtp-window.c:
4307 (modest_connection_specific_smtp_window_finalize),
4308 (modest_connection_specific_smtp_window_fill_with_connections),
4309 (on_button_edit), (modest_connection_specific_smtp_window_init):
4310 * src/maemo/modest-connection-specific-smtp-window.h:
4311 Implementing saving of connection-specific server accounts.
4313 But I need to refactor this so we can save the data for each
4314 possible connection-specific account and only actually create the server accounts
4315 when the easysetup finished, or the OK button is pressed on the account settings
4318 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4321 (on_combo_security_changed):
4322 (modest_connection_specific_smtp_edit_window_init):
4323 Auto-fill the port number as in the account settings.
4325 (modest_connection_specific_smtp_edit_window_set_connection):
4326 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4327 * src/maemo/modest-connection-specific-smtp-window.c:
4328 (fill_with_connections), (on_button_edit),
4329 (modest_connection_specific_smtp_window_init):
4330 Turn the edit window into a dialog to simplify the code, and
4331 set a WM hint as in a GtkDialog, because only a popup can be on top of
4332 another window in Maemo, and popups usually have no WM decoration.
4334 * src/modest-defs.h:
4335 * src/modest-account-mgr-helpers.c:
4336 (modest_account_mgr_set_connection_specific_smtp),
4337 (modest_account_mgr_remove_connection_specific_smtp),
4338 (modest_account_mgr_get_connection_specific_smtp):
4339 * src/modest-account-mgr-helpers.h: Some functions to write the
4340 connection-specific SMTP server information. Not yet used.
4343 * src/widgets/modest-folder-view.c: (text_cell_data):
4344 Fix a warning about an uninitialized variable.
4345 (on_configuration_key_changed): Put an #ifdef around the use
4346 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4348 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4350 * src/maemo/modest-account-settings-dialog.h:
4351 * src/maemo/modest-account-settings-dialog.c:
4352 Added connect_for_modified() utility function to mark the new modified boolean.
4354 (create_page_account_details), (create_page_user_details),
4355 (create_page_incoming), (create_page_outgoing), (on_response),
4356 (modest_account_settings_dialog_init),
4357 (modest_account_settings_dialog_set_account_name):
4358 Only warn about unsaved changes when there are actually unsaved changes.
4360 * src/modest-account-mgr-helpers.c:
4361 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4362 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4363 to get the data from there in future.
4365 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4367 * src/modest-defs.h:
4369 * src/modest-account-mgr-helpers.h:
4370 * src/modest-account-mgr-helpers.c:
4371 Store the security account setting in a single conf key instead of using
4372 the options list, so that the list is left for just the to-be-removed camel hack,
4373 and because gconf_client_set_list() is failing for some reason.
4375 * src/modest-account-mgr.c:
4376 (modest_account_mgr_add_server_account):
4377 * src/maemo/modest-account-settings-dialog.c:
4378 (modest_account_settings_dialog_set_account_name),
4379 (save_configuration): Use the renamed functions.
4382 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4384 * src/widgets/Makefile.am:
4385 * src/widgets/modest-limit-retrieve-combo-box.c:
4386 * src/widgets/modest-limit-retrieve-combo-box.h:
4387 * src/widgets/modest-retrieve-combo-box.c:
4388 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4389 the account settings dialog.
4391 * src/modest-defs.h:
4392 * src/modest-account-mgr-helpers.h:
4393 * src/modest-account-mgr-helpers.c:
4394 (modest_server_account_get_option_secure_auth),
4395 (modest_server_account_set_option_secure_auth):
4396 * src/modest-account-mgr.c:
4397 (modest_account_mgr_add_server_account):
4398 Use the existing AUTH_MECH conf key for the secure-auth setting,
4399 instead of putting it in the list options, because this was actually used already.
4401 * src/maemo/modest-account-settings-dialog.c:
4402 (create_page_account_details),
4403 (modest_account_settings_dialog_set_account_name),
4404 (save_configuration):
4405 * src/maemo/modest-account-settings-dialog.h:
4406 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4407 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4409 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4411 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4412 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4413 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4415 * src/modest-defs.h:
4416 * src/maemo/modest-account-settings-dialog.c:
4417 (create_page_incoming), (on_combo_outgoing_security_changed),
4418 (on_combo_incoming_security_changed), (create_page_outgoing),
4419 (modest_account_settings_dialog_set_account_name),
4420 (save_configuration): Load/Save the port number, and change it when the
4421 security combo changes, to suitable defaults.
4423 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4425 * src/modest-account-mgr.c:
4426 (modest_account_mgr_add_server_account): Set the security and secure-auth
4427 options, and add a comment saying that the other camel-specific options should be
4430 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4432 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4434 * src/modest-tny-account-store.c: (account_list_free),
4435 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4436 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4439 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4441 * src/modest-protocol-info.c:
4442 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4443 is required by our UI spec. Maybe something in our implementation will use this eventually.
4444 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4445 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4446 instead of the previous 0 placeholder.
4448 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4449 secure-auth settings.
4450 * src/modest-account-mgr-helpers.h:
4451 * src/modest-account-mgr-helpers.c:
4452 (modest_server_account_data_get_option_secure_auth),
4453 (modest_server_account_set_option_secure_auth),
4454 (modest_server_account_data_get_option_security),
4455 (modest_server_account_set_option_security): Added this API for getting and setting the security
4456 and secure-auth settings.
4458 * src/maemo/modest-account-settings-dialog.h:
4459 * src/maemo/modest-account-settings-dialog.c:
4460 (modest_account_settings_dialog_finalize), (check_data),
4461 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4462 about changing titles.
4463 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4464 (save_configuration): Save the security and secure-auth settings.
4466 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4467 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4469 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4471 * src/modest-defs.h:
4472 * src/modest-account-mgr.c:
4473 (modest_account_mgr_add_server_account):
4474 Added and used defines for the options key and value pair strings,
4475 that are used so far, though they do not seem to correspond to anything in our
4476 UI specs or ModestProtocol enum.
4478 * src/modest-account-mgr-helpers.h:
4479 * src/modest-account-mgr-helpers.c:
4480 (compare_option_strings_for_name),
4481 (modest_server_account_data_get_option_value),
4482 (modest_server_account_data_get_option_bool),
4483 (modest_account_mgr_get_server_account_option):
4484 Added helper functions for parsing the options GSList.
4486 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4488 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4489 display name is based on the supplied account name.
4490 * src/modest-account-mgr.c:
4491 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4492 with an inefficient, but good-enough, implementation.
4494 * src/maemo/easysetup/modest-easysetup-wizard.c:
4495 (create_page_account_details), (on_before_next), (create_account):
4496 Check for existing display names rather than (non-user-visible) account names, and just
4497 create and set a unique account name at the end.
4499 * src/maemo/modest-account-settings-dialog.c:
4500 (modest_account_settings_dialog_init),
4501 (modest_account_settings_dialog_set_account_name),
4502 (create_page_incoming): Show the display name, instead of the account name.
4503 (on_response): Do some (not all) extra checks, as in the UI spec.
4504 (save_configuration): Save the display name if it was changed.
4506 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4508 * po/en_GB.po: Added needed logical ID and translation.
4509 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4510 (init_view): Made the is-default column clicking work.
4512 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4515 * src/maemo/easysetup/Makefile.am:
4516 * src/maemo/easysetup/modest-easysetup-wizard.c:
4517 (modest_easysetup_wizard_dialog_init):
4518 * src/maemo/easysetup/provider-data-test.keyfile:
4519 * src/maemo/easysetup/provider-data.keyfile:
4520 Moved the provider data file to the new modest-providers-data package and used it from there.
4522 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4524 * src/modest-local-folder-info.c:
4525 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4526 N_() was already used on the static strings, but this just marks it for translation without
4527 using the translation.
4529 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4531 * src/maemo/modest-account-settings-dialog.c:
4532 (create_page_incoming),
4533 (modest_account_settings_dialog_set_account_name):
4534 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4535 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4536 I will do this if nobody else gets there first.
4538 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4540 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4541 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4542 save the security stuff.
4544 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4546 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4547 Set the email address and user fullname, which I now see must be
4550 * src/maemo/modest-account-settings-dialog.h:
4551 * src/maemo/modest-account-settings-dialog.c:
4553 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4554 leave-on-server and authentication.
4555 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4558 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4561 * src/maemo/modest-account-settings-dialog.c:
4562 * src/maemo/modest-account-settings-dialog.h:
4563 Most (but not all) of the widgets are now present as specified by the UI spec.
4564 No changes are yet saved, and some details are not properly shown yet.
4566 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4568 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4570 * src/maemo/Makefile.am:
4571 * src/maemo/modest-account-settings-dialog.c:
4572 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4573 an existing account. Doesn't do much yet.
4575 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4576 Open the accounts settings dialog when Edit is clicked.
4578 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4580 * src/maemo/easysetup/Makefile.am:
4581 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4583 * src/maemo/easysetup/modest-easysetup-wizard.c:
4584 (modest_easysetup_wizard_dialog_init):
4585 Try to get the source directory from the build system,
4586 instead of hard-coding "./" into the source code, when opening our local
4587 copies of the configuration files.
4588 But this still fails when opening the wizard from the Accounts window,
4589 maybe because the working directory seems to change at runtime.
4590 So the wizard will fail the second time unless you copy the files into their
4591 proper locations - see the stdout warnings for the paths.
4593 (create_page_account_details),(on_before_next):
4594 Check for existing non-server accounts instead of server accounts,
4595 so the default account name is useful again, and to prevent trying to
4598 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4599 Show the wizard when New is clicked.
4601 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4602 (init_view): Show the column headers, and show the columns that are
4603 specified in the UI specs. However, something in Maemo's GTK+ prevents
4604 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4605 change the default account. This is despite unsetting the special properties.
4607 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4609 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4610 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4611 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4612 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4613 to make that clearer.
4614 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4616 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4618 * src/maemo/modest-account-view-window.c:
4619 (modest_account_view_window_init),
4620 (modest_account_view_window_new):
4621 Use the same buttons as specified in the
4622 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4623 the existing widgets, which never had a chance of working.
4624 Put the ModestAccountView treeview in a scrolled window.
4625 Do not repeat the initialization in both _init() and _new().
4627 * src/widgets/modest-account-view.c: (update_account_view):
4628 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4629 this widget and window shows no accounts.
4631 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4633 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4635 * src/maemo/easysetup/modest-easysetup-wizard.c:
4636 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4637 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4638 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4641 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4642 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4643 accounts exist yet, as in the UI spec.
4645 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4647 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4649 * src/maemo/Makefile.am:
4650 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4651 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4652 New window for editing connection-specific smtp details.
4653 Not fully implemented.
4655 * src/maemo/modest-connection-specific-smtp-window.c:
4656 (modest_connection_specific_smtp_window_finalize) :
4657 unref the tree model.
4658 (on_button_edit): Show the edit window.
4660 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4662 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4665 * src/maemo/Makefile.am:
4666 * src/maemo/modest-connection-specific-smtp-window.c:
4667 * src/maemo/modest-connection-specific-smtp-window.h:
4668 New window for showing the list of connections, for connection-specific
4669 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4670 * src/maemo/easysetup/modest-easysetup-wizard.c:
4671 (create_page_custom_outgoing): Show the new window when the button is clicked.
4673 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4675 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4676 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4677 * src/maemo/modest-msg-edit-window.c:
4678 (modest_msg_edit_window_insert_image):
4679 * src/modest-conf.c: (modest_conf_key_escape):
4680 * src/modest-mail-operation.c:
4681 (modest_mail_operation_send_new_mail):
4682 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4683 (modest_ui_actions_on_new_account):
4684 * src/widgets/modest-attachment-view.c: (update_filename_request):
4685 * src/widgets/modest-mail-header-view.c:
4686 Corrected warnings that were breaking the build, by commenting out unused variables,
4687 and a function, and by including a header.
4689 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4691 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4692 so we can #ifdef around platform-specific code when necessary.
4693 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4694 to allow this to build for the GNOME platform too.
4696 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4698 * src/maemo/easysetup/modest-easysetup-wizard.c:
4699 Added util_increment_name() and used it in create_page_account_details()
4700 to make sure that the default account name is always a new name.
4702 (modest_easysetup_wizard_dialog_init),
4703 (set_default_custom_servernames): Some minor memory management fixes.
4705 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4709 * src/modest-runtime.c: (init_i18n): Restored the translation
4710 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4711 are defined in config.h, and the translations are installed.
4713 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4714 is defined for translation.
4716 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4718 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4720 * src/maemo/easysetup/modest-easysetup-wizard.c:
4721 (modest_easysetup_wizard_dialog_init):
4722 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4723 Use realistic paths (though they should use $prefix generically) to the
4724 mcc_mapping and provider-data.keyfile files which might work when they
4725 are installed by the future version of the operator-wizard package,
4726 and then fallback to paths in our source code, with an explanatory
4729 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4733 * src/maemo/Makefile.am:
4734 * src/maemo/easysetup/: Added files from the previously-exernal
4735 osso-modest-easysetup.
4736 * src/maemo/modest-main-window-ui.h:
4737 * src/modest-ui-actions.c:
4738 * src/modest-ui-actions.h:
4739 Added modest_ui_actions_on_new_account() as a signal handler for the
4740 New Account menu item. It shows the easysetup wizard.
4741 * po/en_GB.po: Added additional needed logical IDs and translations.