1 2007-07-06 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
4 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
5 give a more exact error message that can be partly translated.
7 2007-07-05 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/modest-address-book.c:
10 (select_email_addrs_for_contact): Specify a default window size for the
11 select-email-address dialog, so that it is probably big enough for the
12 title. This should fix projects.maemo.org bug NB#62277.
14 2007-07-05 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/easysetup/modest-easysetup-wizard.c:
17 (create_page_complete_easysetup): Use
18 gtk_widget_set_size() request to ensure that the text wraps
21 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
23 * src/maemo/easysetup/modest-easysetup-wizard.c:
24 (on_entry_invalid_character), (create_page_account_details),
25 (create_page_user_details):
26 Use new API of ModestValidatingEntry. But for some reason the banner is
27 not shown. I will have to investigate that further.
29 * src/widgets/modest-validating-entry.c: (on_insert_text),
30 (modest_validating_entry_set_func):
31 * src/widgets/modest-validating-entry.h:
32 Added a new callback function to be able to react to prevented
33 characters whitespaces to e.g show a banner.
35 2007-07-05 Armin Burgmeier <armin@openismus.com>
37 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
38 notification of HildonNumberEditor instead of remembering the port
39 number. Thanks to Johannes for pointing this out.
41 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
43 * src/maemo/easysetup/modest-easysetup-wizard.c:
44 Check if there are any user changes before showing a confirmation
45 dialog (projects.maemo.org NB#60946)
47 2007-07-05 Armin Burgmeier <armin@openismus.com>
49 * src/maemo/modest-account-settings-dialog.c: Remember custom port
50 number at the beginning of the dialog and set the modified flag at the
51 end if the port number has changed. This is necessary because
52 HildonNumberEditor does not support notification when the value has
55 2007-07-05 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-ui-actions.c:
58 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
59 a connection before asking anything else. Correct the check for the destination
60 folder so that it succeeds when online.
61 This fixed projects.maemo.org bug NB#61645.
63 2007-07-05 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
66 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
67 to fix projects.maemo.org bug NB#62439.
69 2007-07-05 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-tny-account.c: (on_connection_status_changed):
72 Really do not use tny_device_force_offline() here. See the previous comment.
74 2007-07-04 Murray Cumming <murrayc@murrayc.com>
76 * src/modest-tny-account.c: (on_connection_status_changed):
77 Do not use tny_device_force_offline() when tinymail says that something
78 went wrong with the connection. It seems to report this unnecessarily.
80 2007-07-04 Murray Cumming <murrayc@murrayc.com>
82 * src/maemo/modest-connection-specific-smtp-window.c:
83 (modest_connection_specific_smtp_window_init):
84 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
85 does not seem to have any effect in osso 1.1 (though it works in
86 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
88 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
90 * src/maemo/modest-connection-specific-smtp-window.c:
91 Fix UI specification problems with projects.meamo.org NB#60479
93 2007-07-04 Murray Cumming <murrayc@murrayc.com>
95 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
96 clue when this has failed, because the error dialog is not always shown
97 (at least in earlier version).
99 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
100 GError message, because the generic error dialog is not helpful.
102 'This message is not currently available (can't let a new connection go online)'
103 when trying to open an IMAP message.
105 (_modest_ui_actions_open): Offer a connection when some messages would
106 have to be downloaded and we are offline.
108 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
110 * src/widgets/modest-folder-view.c:
111 Don't check for MERGE type anymore as we use the correct type
113 NOTE: For the last two changes you need to update your tinymail copy
114 because of API changes!
116 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
118 * src/modest-tny-local-folders-account.c:
119 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
120 (see projects.maemo.org NB#61580)
122 2007-07-04 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-tny-account.c: (on_connection_status_changed):
125 Commented out the call to modest_platform_connect_and_wait() because this
126 seems to always hang, and I would like to know if this is the only thing
127 that causes a hang when showing the connection dialog.
128 It is not very useful anyway.
130 2007-07-04 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/modest-msg-view-window.c:
133 (modest_msg_view_window_select_next_message):
135 * src/modest-platform.h:
136 * src/maemo/modest-platform.c:
137 Added modest_platform_connect_and_wait(), which calls
138 tny_maemo_conic_device_connect() always in the main thread, by calling it
139 in an idle handler and waiting for the idle handler to run. It should be
140 in the main thread because it uses GTK+ UI code. It just returns TRUE
141 if the device is already online.
143 There is some nasty code to ensure that subsequent calls to
144 modest_platform_connect_and_wait() just wait for the first one to finish,
145 by checking repeatedly in another idle handler. This is necessary,
146 because other threads (or even the main thread, via another idle handler)
147 can call modest_platform_connect_and_wait() while
148 modest_platform_connect_and_wait() is running.
150 (modest_platform_connect_and_wait_if_network_account),
151 (modest_platform_connect_and_wait_if_network_folderstore):
152 Convenience functions that calls modest_platform_connect_and_wait() if
153 the account or folder might want network access.
155 * src/modest-mail-operation.c:
156 (modest_mail_operation_update_account):
157 * src/modest-ui-actions.c: (download_uncached_messages),
158 (modest_ui_actions_on_rename_folder), (delete_folder),
159 (modest_ui_actions_on_main_window_move_to),
160 (modest_ui_actions_on_msg_view_window_move_to):
161 * src/widgets/modest-folder-view.c:
162 (drag_and_drop_from_folder_view):
163 Offer a connection if we are offline.
165 * src/modest-tny-account.c: (on_connection_status_changed):
166 Document this as only handling errors during network operations in progress,
167 and replace the idle code with a simple call to
168 modest_platform_connect_and_wait(), which does this instead.
170 2007-07-03 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account.c:
173 (modest_tny_account_get_special_folder): (util_on_idle),
174 Handle the GError so we can see when tny_folder_store_get_folders()
175 fails, as it currently does while something else is connecting.
177 Added util_run_in_main_thread_and_wait()
178 which uses an idlen handler and mainloop to ensure that the function
179 is called in the main thread.
180 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
181 to make sure that we call attempt the connection in the mainloop only,
182 which might solve some hangs.
184 2007-07-03 Murray Cumming <murrayc@murrayc.com>
186 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
187 be found by their display name. This is never useful.
188 * src/modest-tny-account-store.c: (on_account_removed): Find the account
189 by its ID, instead of trying to use its ID as its display name.
191 * src/modest-tny-account-store.h:
192 * src/modest-tny-account.c:
193 (modest_tny_account_get_special_folder): Add a g_warning() when
194 tny_folder_store_get_folders() returns an empty list for the maildir.
196 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
197 Add a g_warning() when this returns NULL, because that it not allowed
200 2007-07-02 Armin Burgmeier <armin@openismus.com>
202 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
203 note when trying to cancel the wizard. This fixes projects.maemo.org
206 2007-07-02 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-tny-account.h:
209 * src/modest-tny-account.c:
210 (modest_tny_account_new_from_server_account),
211 (modest_tny_account_new_from_server_account_name),
212 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
213 because this must now be set before setting the proto. This is usd in
214 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
215 warning in camel_session_get_service() caused by
216 tny_camel_transport_account_prepare().
218 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
221 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
223 * src/maemo/modest-connection-specific-smtp-edit-window.c:
225 (modest_connection_specific_smtp_edit_window_init):
227 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
230 2007-06-29 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-tny-account.c:
233 (modest_tny_account_new_from_server_account):
234 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
235 now uses to request a connection when it needs one, and which it uses
236 to tell us that something is wrong with the connection, so we can force
237 the accounts offline to prevent further problems.
240 * src/modest-init.c: (init_default_settings):
241 * src/modest-mail-operation.c:
242 (modest_mail_operation_update_account):
243 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
244 This should not be necessary anymore. Do not set the conf key that
245 determined this (it was always TRUE and not set anywhere else).
247 * src/modest-ui-actions.h: Remove unused and unimplemented
248 modest_ui_actions_on_online_toggle_toggled().
250 2007-06-29 Murray Cumming <murrayc@murrayc.com
252 * src/maemo/modest-main-window.c: (connect_signals):
253 Don't connect to delete_event twice. Maybe this was harmless.
255 2007-06-29 Murray Cumming <murrayc@murrayc.com
257 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
258 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
259 Debug output to give some more clue when a folder move is not allowed.
261 2007-06-28 Murray Cumming <murrayc@murrayc.com
263 * src/modest-tny-account.c: (on_modest_file_system_info),
264 (modest_tny_account_get_mmc_account_name):
265 Always call the callback, without checking whether the name has changed.
266 * src/widgets/modest-folder-view.c: (strings_are_equal),
267 (on_model_foreach_set_name), (on_get_mmc_account_name),
268 (text_cell_data): Compare the name here, and use the name from
269 the account rather than from the
270 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
271 if the name was changed after the account was added to the model.
272 That's a tinymail bug but not one that I want to fix now.
274 This finally fixes projects.maemo.org bug NB#59301.
276 2007-06-27 Armin Burgmeier <armin@openismus.com>
278 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
281 2007-06-27 Murray Cumming <murrayc@murrayc.com
283 * src/modest-tny-account.h:
284 * src/modest-tny-account.c:
285 Added modest_tny_account_get_mmc_account_name(), to set the memory
286 card name asynchronously for the given account and then notify.
287 (modest_tny_account_new_for_local_folders): Use this new function instead
288 of using hildon_file_system_info_async_new() directly.
290 * src/widgets/modest-folder-view.c: (text_cell_data):
291 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
292 gtk_tree_model_row_changed() when it is available.
294 This should fix projects.maemo.org bug NB#59301.
296 2007-06-27 Murray Cumming <murrayc@murrayc.com
298 * src/modest-mail-operation.c: (update_account_thread),
299 (get_msgs_full_thread): Fix typo failures in the revert
302 2007-06-27 Murray Cumming <murrayc@murrayc.com
304 * src/maemo/modest-maemo-global-settings-dialog.c:
305 (idle_select_default_focus):
306 * src/modest-mail-operation.c: (idle_notify_progress),
307 (idle_notify_progress_once), (set_last_updated_idle),
308 (update_account_thread), (get_msgs_full_thread):
309 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
310 * src/widgets/modest-header-view.c:
311 (idle_notify_headers_count_changed_destroy),
312 (idle_notify_headers_count_changed):
313 Reverted the additions of gdk_threads_enter/leave(), in case this
314 helps with a startup hang on the device.
316 2007-06-26 Armin Burgmeier <armin@openismus.com>
318 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
319 for supported secure authentication methods from server by
320 gtk_dialog_run(), saving CPU time and a potential race condition.
322 2007-06-26 Armin Burgmeier <armin@openismus.com>
324 * src/maemo/modest-maemo-utils.h:
325 * src/maemo/modest-maemo-utils.c: Added a
326 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
327 only error code to tell the calling code when the user canceled the
330 * src/maemo/modest-account-settings-dialog.h:
331 * src/maemo/modest-account-settings-dialog.c:
332 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
333 message if the retrieval of secure authentication methods was canceled
334 by the user. Perform the check before saving anything to configuration
335 to not end up with half-committed configuration changes, do not show
336 a "Saving to configuration failed" note when authentication methods
337 could not be retrieved.
339 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
342 2007-06-26 Murray Cumming <murrayc@murrayc.com>
344 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
345 Only return the first level of folders under accounts, because the
346 osso-global-search UI spec doesn't want the rest.
347 This fixed projects.maemo.org bug NB#61811.
349 2007-06-26 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-tny-account-store.c:
352 * src/modest-tny-account-store.h:
353 Added modest_tny_account_is_memory_card_account().
354 * src/maemo/modest-main-window.c: (create_details_widget):
355 Show the same information items for the memory card as we show for the
356 local-folders, to fix projects.maemo.org bug NB#59307.
358 2007-06-26 Murray Cumming <murrayc@murrayc.com>
360 * src/modest-tny-account-store.c: (get_password):
361 Added some checks for NULL to maybe prevent crashes, though I think
362 it was Philip's last commit that actually prevented the crash here
363 when creating a first new account.
364 But the new account is still not usable (no messages are shown)
365 until a restart of the application.
367 2007-06-26 Murray Cumming <murrayc@murrayc.com>
369 * src/maemo/modest-maemo-global-settings-dialog.c:
370 (idle_select_default_focus):
371 * src/modest-mail-operation.c: (idle_notify_progress),
372 (idle_notify_progress_once), (idle_notify_update_account_queue),
373 (set_last_updated_idle), (update_account_thread),
374 (notify_get_msgs_full), (get_msgs_full_destroyer),
375 (get_msgs_full_thread):
376 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
377 * src/widgets/modest-header-view.c:
378 (idle_notify_headers_count_changed_destroy),
379 (idle_notify_headers_count_changed):
380 Use gdk_threads_enter() and gdk_threads_enter_leave() in
381 all idle handlers, because some other thread could be blocking
382 the GDK lock, so that it can do GUI stuff.
384 2007-06-26 Murray Cumming <murrayc@murrayc.com>
386 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
387 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
388 (on_idle_send_receive), (on_idle_open_default_inbox):
389 * src/maemo/modest-msg-edit-window.c:
390 (modest_msg_edit_window_attach_file_noninteractive):
391 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
392 to prevent a hang. I don't quite understand why these are necessary,
393 beause we should already be in the main loop. I guess something outside
394 of the main loop is taking the lock.
396 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
397 we are really using URIs, and use files that are more likely to exist.
399 2007-06-26 Murray Cumming <murrayc@murrayc.com>
401 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
402 necessary because configure.ac now defines different variables.
404 2007-06-26 Murray Cumming <murrayc@murrayc.com>
406 * libmodest-dbus-client/libmodest-dbus-client.c:
407 * libmodest-dbus-client/libmodest-dbus-client.h:
408 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
409 libmodest_dbus_client_compose_mail() is what things actually use.
411 * src/dbus_api/modest-dbus-api.h:
412 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
413 * tests/dbus_api/Makefile.am:
414 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
417 2007-06-26 Murray Cumming <murrayc@murrayc.com>
419 * src/modest-init.c: (modest_init_local_folders):
420 For memory-card (or other non local-folders) maildir accounts,
421 always create an Archive folder, so that there is somewhere to put
422 messages. This should be less confusing, because the user does not need
423 to guess that the need to create a folder.
425 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
427 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
428 Fixed icon size by using (50, 50) which is the same as defined by
431 2007-06-25 Armin Burgmeier <armin@openismus.com>
433 * src/widgets/modest-window-mgr.c:
435 * configure.ac: Correctly recognize hildon-notify presence and fixed
436 the build without it being installed.
438 2007-06-25 Murray Cumming <murrayc@murrayc.com>
440 * libmodest-dbus-client/libmodest-dbus-client.c:
441 (libmodest_dbus_client_search): Fix the build. Sorry.
442 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
443 (reply_forward_cb): Initialize variables to fix the build.
445 * src/modest-tny-account-store.c:
446 (modest_tny_account_store_get_tny_account_by): Fix the account URI
447 comparison (a silly typo) so that email search results can be opened
448 when there are more than one account.
450 2007-06-25 Murray Cumming <murrayc@murrayc.com>
452 * libmodest-dbus-client/libmodest-dbus-client.c:
453 (libmodest_dbus_client_search),
454 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
455 instead of 1 second, because the search gets folders and messages from
456 the server, which can take a long time. When it times out,
457 osso-global-search will report no results.
459 We need to specify whether we should search only cached information
460 (maybe with a user preference), and the osso-email-search-plugin
461 API should really be improved to allow that option, and to allow results
462 to be delivered asynchronously in batches.
464 2007-06-25 Murray Cumming <murrayc@murrayc.com>
466 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
467 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
468 GTK_ICON_SIZE_DIALOG is probably the wrong size.
470 2007-06-25 Murray Cumming <murrayc@murrayc.com>
472 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
473 that is an empty string. D-Bus seems to give us these instead of NULL.
475 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
477 * src/dbus_api/modest-dbus-callbacks.c:
478 * src/maemo/easysetup/modest-easysetup-wizard.h:
479 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
480 * src/maemo/modest-connection-specific-smtp-edit-window.c:
481 (modest_connection_specific_smtp_edit_window_init):
482 * src/maemo/modest-maemo-global-settings-dialog.c:
484 * src/maemo/modest-maemo-utils.c:
485 (modest_maemo_utils_setup_images_filechooser):
486 * src/maemo/modest-main-window.c: (create_details_widget):
487 * src/maemo/modest-msg-edit-window.c:
488 (modest_msg_edit_window_attach_file_noninteractive),
489 (modest_msg_edit_window_color_button_change),
490 (modest_msg_edit_window_set_zoom):
491 * src/modest-mail-operation.c: (update_account_thread):
492 * src/modest-tny-account-store.c:
493 * src/modest-tny-account.c:
494 * src/widgets/modest-global-settings-dialog.c:
495 * src/widgets/modest-window.h:
499 2007-06-25 Murray Cumming <murrayc@murrayc.com>
501 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
502 * src/modest-search.c: (modest_search_folder),
503 (modest_search_all_accounts): Actually search only in the specified folder,
504 doing a simple match on the folder ID.
505 * src/modest-search.h: Added a folder field to the ModestSearch struct,
506 and added some documentation.
508 2007-06-22 Armin Burgmeier <armin@openismus.com>
510 * src/maemo/modest-maemo-utils.h:
511 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
512 modest_maemo_utils_get_supported_secure_authentication_methods.
514 * src/maemo/easysetup/modest-easysetup-wizard.c:
515 * src/maemo/modest-account-settings-dialog.c: Show correct error if
516 one occured, not just "Server does not support secure authentication".
518 2007-06-22 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-tny-account-store.c: (get_password):
521 Restored the call to tny_account_set_user() because Philip seems to have
522 stopped this from crashing (by not using the freed string). It still does
523 not work, but now we can test it.
525 2007-06-22 Murray Cumming <murrayc@murrayc.com>
527 * src/maemo/modest-msg-edit-window.c: (init_window):
528 Comment out use of an uninitialzed GtkScrolledWindow variable,
529 to fix the build and stop a crash. Yet again.
531 2007-06-22 Murray Cumming <murrayc@murrayc.com>
533 * src/modest-tny-account-store.c: (get_password):
534 Remove the call to tny_account_set_user() because this actually crashes.
535 As mentioned in the last commit, it is known to not work anyway.
537 2007-06-22 Murray Cumming <murrayc@murrayc.com>
539 * src/modest-tny-account-store.c: (get_password):
540 Use tny_account_set_username() to tell tinymail that the username might
541 have changed too. But tinymail ignores this: see projects.maemo.org
543 * src/modest-ui-actions.c:
544 (modest_ui_actions_on_password_requested): Remove the useless attempt to
545 reset the connection when changing the username, and improve the comments.
546 Save the changed username to gconf at least, so it is used when Modest is
549 2007-06-21 Murray Cumming <murrayc@murrayc.com>
551 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
552 Do not use a query, so that we get all folders, including for POP and
553 local-folders. They work as search criteria too.
554 This fixes projects.maemo.org bug NB#57740.
556 2007-06-21 Murray Cumming <murrayc@murrayc.com>
558 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
559 Comment out the use of hildon_notification_set_sound() because it is
560 not declared, to fix the build. Warnings are serious, people.
562 2007-06-21 Armin Burgmeier <armin@openismus.com>
564 * src/maemo/modest-maemo-utils.h:
565 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
566 modest_maemo_utils_get_supported_secure_authentication_methods()
567 to query authentication methods for a specific user. This should fix
568 projects.maemo.org bug NB#61369.
570 * src/maemo/easysetup/modest-easysetup-wizard.c:
571 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
574 2007-06-21 Murray Cumming <murrayc@murrayc.com>
576 * libmodest-dbus-client/libmodest-dbus-client.h:
577 * libmodest-dbus-client/libmodest-dbus-client.c:
578 (modest_dbus_message_iter_get_search_hit),
579 (libmodest_dbus_client_search):
580 Reorganised and commented this.
581 Removed modest_search_hit_free() from the public API because it
584 Added libmodest_dbus_client_get_folders() and
585 modest_folder_result_list_free().
587 * src/dbus_api/modest-dbus-api.h:
588 * src/dbus_api/modest-dbus-callbacks.c:
589 (modest_dbus_req_filter): Commented. Moved most code to
590 on_dbus_method_search() and added on_dbus_method_get_folders().
592 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
593 of the extra D-Bus handler.
595 * tests/dbus_api/Makefile.am:
596 * tests/dbus_api/test_get_folders.c: New test for
597 libmodest_dbus_client_get_folders(). This seems to return an empty list
598 at the moment. That could be the same error that causes the message list
599 to be empty sometimes.
600 This should help with projects.maemo.org bug NB#57740.
602 2007-06-21 Armin Burgmeier <armin@openismus.com>
604 * src/modest-mail-operation.c: Do not call
605 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
606 notify the operation's end after having set the status to CANCELED for
607 the operation queue to listen on. This fixes a deadlock when there
608 were mail operations in the queue during its finalization.
610 * src/modest-singletons.c: Reordered uninitialization of the account
611 manager to happen after the mail operation queue was uninitialized
612 because the mail operation's in the queue might still try to access
613 the account manager (see modest_mail_operation_notify_end()). This
614 fixes a potential crash when terminating the application.
616 2007-06-21 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-search.c:
619 (search_mime_part_and_child_parts): Moved some code here so we
620 can search recursively in child folders.
621 (modest_search_folder): Search in the message as a mime part, instead
622 of just its child mime parts.
623 (read_chunk), (search_mime_part_ogs):
624 Check how many bytes were read, to prevent an endless loop.
625 Searching in message bodies now works. This finishes the fix for
626 projects.maemo.org bug NB#61007.
628 2007-06-20 Murray Cumming <murrayc@murrayc.com>
630 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
631 Add a g_warning when the item is not a folder.
633 * src/modest-ui-dimming-rules.c:
634 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
635 when selected item is not a folder (for instance, an account), because
636 the UI spec only talks about folders.
637 I am not sure what the UI spec wants, so this might not totally fix
638 projects.maemo.org bug NB#60794.
640 2007-06-20 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
643 (load_from_file): Sort the list. The unsorted list would be more noticeable
644 in non-English locales.
646 * src/maemo/modest-msg-edit-window.c:
647 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
648 warning and fix the build.
650 * src/maemo/modest-progress-bar-widget.c:
651 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
652 avoid a g_warning, and probably to avoid a crash.
654 2007-06-20 Murray Cumming <murrayc@murrayc.com>
656 * src/modest-search.c: (modest_search_folder): Check for a GError
657 when calling tny_folder_get_headers(), to show that this is not the cause
660 2007-06-20 Murray Cumming <murrayc@murrayc.com>
662 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
663 Actually set the body query instead of the subject query.
665 * src/modest-search.c: (search_mime_part_ogs),
666 (search_mime_part_strcmp): Remove extra space from the text/* regex,
667 which would probably cause it to fail if we got this far.
669 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
670 to simplify the code.
671 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
672 be causing search-in-body to fail.
674 2007-06-20 Murray Cumming <murrayc@murrayc.com>
676 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
678 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
679 Better debug message when the folder cannot be found.
680 This should help with fixing projects.maemo.org bug #61287.
681 * src/modest-search.c: (add_hit): Do not leak the furl string.
683 2007-06-20 Murray Cumming <murrayc@murrayc.com>
685 * src/modest-ui-actions.c:
686 (modest_ui_actions_on_folder_selection_changed):
687 Do not special-case TNY_MERGE_FOLDER here, because
688 modest_tny_folder_get_account() already does that. This fixes
689 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
690 shown when the Outbox was selected).
692 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
694 * libmodest-dbus-client/libmodest-dbus-client.c:
695 (_dbus_iter_get_string_or_null): Initialize the string variable in
696 case this helps with Dirk's crash.
698 2007-06-19 Murray Cumming <murrayc@murrayc.com>
700 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
701 though it is not implemented yet (this function is maybe not even used),
702 to avoid breaking ABI in future.
703 * libmodest-dbus-client/libmodest-dbus-client.c:
704 (get_attachments_string): Moved some code into this generic function.
705 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
706 sends email. It is maybe not used.
707 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
708 (on_send_mail): Use attachments.
710 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
711 * src/maemo/modest-msg-edit-window.c:
712 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
713 a filename before using it, to fix projects.maemo.org bug NB#58233.
715 2007-06-19 Murray Cumming <murrayc@murrayc.com>
717 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
718 Initialize the continue_download variable to fix the build, and probably
719 to fix randome behaviour.
721 2007-06-18 Armin Burgmeier <armin@openismus.com>
723 * src/modest-tny-send-queue.h:
724 * src/modest-tny-send-queue.c: Keep track of the status of messages in
725 the queue so we can later show it in the UI. Replaced
726 modest_tny_send_queue_msg_is_being_sent() by
727 modest_tny_send_queue_get_msg_status().
729 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
731 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
732 gpointer. This probably was not harmful, but just to be sure.
734 2007-06-18 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
737 Fix the build, but leave the function broken on Bora, because
738 hildon_uri_action_get_service() does not exist.
739 osso_uri_action_get_service() does not exist either, it seems.
741 2007-06-18 Murray Cumming <murrayc@murrayc.com>
743 * src/modest-tny-account.c:
744 (modest_tny_account_new_from_server_account):
745 Uncommented the url debug output again, because it is useful for
746 debugging, as I said in the comment.
748 2007-06-18 Murray Cumming <murrayc@murrayc.com>
750 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
752 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
753 for Mameo Bora, to fix the build.
755 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
758 Fixed build with hildon < 0.99
760 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
761 Check if the selected account is busy instead of checking all accounts
763 * src/modest-account-mgr-priv.h:
764 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
765 (modest_account_mgr_init), (compare_account_name),
766 (modest_account_mgr_set_account_busy),
767 (modest_account_mgr_account_is_busy):
768 * src/modest-account-mgr.h:
769 Added busy information to the account manager. It possible to
770 set an account to busy or not busy now.
772 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
773 (modest_mail_operation_update_account),
774 (modest_mail_operation_notify_end):
775 Set the account to busy/not busy depending on the operation state.
777 * src/widgets/modest-account-view.c:
778 (modest_account_view_finalize), (get_last_updated_string),
779 (update_account_view), (on_account_busy_changed), (init_view):
780 Show string "Refreshing..." if the account is currently busy.
782 All this fixes projects.maemo.org bug NB#59711
784 2007-06-14 Armin Burgmeier <armin@openismus.com>
786 * src/widgets/modest-attachments-view.h:
787 * src/widgets/modest-attachments-view.c: Added
788 modest_attachments_view_has_attachments() and fixed coordinate
789 transformation in get_att_view_at_coords(). This fixes attachment
792 * src/widgets/modest-msg-view.c: Make use of
793 modest_attachments_view_has_attachments() to decide whether to show
794 attachments in the header.
796 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
798 * src/maemo/modest-connection-specific-smtp-edit-window.c:
799 (on_change), (on_combo_security_changed),
800 (modest_connection_specific_smtp_edit_window_init),
801 (modest_connection_specific_smtp_edit_window_set_connection),
802 (modest_connection_specific_smtp_edit_window_is_dirty):
803 * src/maemo/modest-connection-specific-smtp-edit-window.h:
804 * src/maemo/modest-connection-specific-smtp-window.c:
807 Show an comfirmation dialog for the smpt-edit-window if there are
808 unsaved changes and the user hits cancel.
809 (projects.maemo.org bug NB#60479)
811 2007-06-14 Armin Burgmeier <armin@openismus.com>
813 * src/maemo/easysetup/modest-easysetup-wizard.c:
814 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
815 address" info in banner instead of node, and select all the text as
816 per UI spec. This fixes projects.maemo.org bug NB#60550.
818 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
820 reviewed by: <delete if not using a buddy>
822 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
823 * src/modest-ui-actions.c: (folder_refreshed_cb):
825 2007-06-14 Murray Cumming <murrayc@murrayc.com>
827 * src/widgets/modest-folder-view.c: (filter_row):
828 Explictly filter out the per-account outbox accounts. I don't know why
829 these only sometimes show up, but now they should never show up in the UI.
830 This should fix projects.maemo.org bug NB#60160.
832 2007-06-14 Murray Cumming <murrayc@murrayc.com>
834 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
835 when the toolbar does not exist yet.
836 * src/modest-widget-memory.c: (save_settings_header_view):
837 Added g_warnings() to help us to discover when we are trying to set
838 an empty columns list in gconf.
840 2007-06-14 Murray Cumming <murrayc@murrayc.com>
844 Added modest_init_get_default_header_view_column_ids().
846 * src/modest-widget-memory.c: (restore_settings_header_view):
847 Use the new function to get defaults, if the gconf key is empty,
848 instead of not creating any columns. This seems to fix the
849 empty right-hand pane problems.
851 * src/widgets/modest-header-view.h: Improved documentation.
853 2007-06-13 Murray Cumming <murrayc@murrayc.com>
855 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
856 Revert the use of the display name as the account name, because this
857 is generally wrong and would break the code that follows.
859 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
861 * src/maemo/easysetup/modest-easysetup-wizard.c:
862 (check_for_supported_auth_methods), (on_before_next),
865 More correct fix for projects.maemo.org bug NB# 58991
866 Do not longer accept AUTH_PASSWORD as secure method and choose
867 correct method when creating the account.
869 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
871 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
872 Fixed projects.maemo.org bug NB# 58991
874 2007-06-13 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-init.c: (modest_init_init_core),
877 (modest_init_local_folders): Fixed compilation errors.
879 2007-06-13 Murray Cumming <murrayc@murrayc.com>
881 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
882 Remove unnecessary lib/include, though it is good in principle when needed.
884 * src/modest-init.c: (modest_init_one_local_folder),
885 (modest_init_local_folders):
886 * src/modest-init.h: Initialize the .modest library for memory cards,
887 instead of just doing nothing for them. This should allow us to create
888 folders there, fixing projects.maemo.org bug NB#59297.
890 2007-06-13 Murray Cumming <murrayc@murrayc.com>
892 * libmodest-dbus-client/libmodest-dbus-client.c:
893 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
894 (libmodest_dbus_client_compose_mail),
895 (libmodest_dbus_client_open_message),
896 (libmodest_dbus_client_send_and_receive),
897 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
899 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
900 (on_idle_open_message), (modest_dbus_req_handler),
901 (search_result_to_message), (modest_dbus_req_filter):
902 * src/modest-search.c: (add_hit), (modest_search_folder),
903 (modest_search_all_accounts): Improved debug messages.
905 * tests/dbus_api/test_open_message.c: (main): Improved comments.
907 * src/modest-tny-account-store.c:
908 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
911 2007-06-13 Murray Cumming <murrayc@murrayc.com>
914 2007-06-12 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-tny-account-store.c: (get_server_accounts):
917 Call modest_tny_local_folders_account_add_merged_outbox_folders()
918 even when there are no accounts, so that the Outbox folder is always
919 visible. This fixes projects.maemo.org bug NB#60158.
921 2007-06-12 Murray Cumming <murrayc@murrayc.com>
923 * src/maemo/modest-main-window.c: (create_details_widget):
924 Use the mcen_va_never logical ID.
926 2007-06-12 Murray Cumming <murrayc@murrayc.com>
928 * src/dbus_api/modest-dbus-api.h:
929 * src/dbus_api/modest-dbus-callbacks.c:
930 (on_idle_open_default_inbox), (on_open_default_inbox),
931 (modest_dbus_req_handler):
932 Added a new OpenDefaultInbox method.
934 * libmodest-dbus-client/libmodest-dbus-client.h:
935 * libmodest-dbus-client/libmodest-dbus-client.c:
936 Added libmodest_dbus_client_open_default_inbox() to call the new
937 dbus method. This should be useful to projects.maemo.org bug NB#57214,
938 though it should maybe be used by a new osso-email-interface function.
940 * tests/dbus_api/Makefile.am:
941 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
944 2007-06-12 Murray Cumming <murrayc@murrayc.com>
946 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
947 NULL, so that the signals get all the keys. This should not actually
948 change any behaviour because we currently update everything when anything
951 2007-06-12 Murray Cumming <murrayc@murrayc.com>
953 * src/widgets/modest-folder-view.c: (text_cell_data),
954 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
955 (find_inbox_iter): If tinymail tells us that the folder is
956 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
957 This causes the inbox to be selected at startup, fixing part of
958 projects.maemo.org bug NB#56305.
960 * src/modest-ui-dimming-rules.c:
961 (modest_ui_dimming_rules_on_tools_smtp_servers):
962 * src/modest-ui-dimming-rules.h: Added a callback function to dim
963 the SMTP servers menu item.
964 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
965 that the SMTP Servers menu item is dimmed when there are no accounts,
966 as a future version of the UI spec will require. This fixes
967 projects.maemo.org bug NB#56305.
969 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
971 * src/maemo/modest-maemo-utils.c:
972 (modest_maemo_utils_get_supported_secure_authentication_methods):
973 Added label to dialog instead of unreadable title
975 * src/maemo/modest-main-window.c: (sync_accounts_cb),
976 (modest_main_window_new):
977 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
980 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
981 * src/modest-account-mgr.h:
982 Added method to avoid code duplication
984 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
985 (modest_ui_actions_on_send_receive):
986 Use modest_account_mgr_has_accounts
988 2007-06-11 Murray Cumming <murrayc@murrayc.com>
990 * src/maemo/easysetup/modest-presets.c:
991 (modest_presets_get_info_server_security): Do not report secure auth
993 * src/modest-protocol-info.c: Use the defines for the gconf key names
994 for secure authentication. This was not working because we were writing
995 Password and reading password, and the check was case sensitive.
996 With this, gmail now works for receiving and sending when created via
999 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/easysetup/modest-presets.c:
1002 (modest_presets_get_info_server_security): Correct the key name for
1003 SecureSmtp, because it seems to be case-sensitive.
1004 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1005 Do not try to get the 0th notebook page if there are 0 pages, to
1006 avoid a g_warning().
1008 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1010 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1011 Prevent use of the new notification feature for now, because it currently
1012 shows one dialog for each new email, which is annoying.
1014 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1016 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1017 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1018 when no country was selected, so that we show the global ones.
1019 * src/maemo/easysetup/modest-presets.c:
1020 (modest_presets_get_providers): Return only the global providers, not
1021 all providers when mmc=0 was requested.
1023 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1025 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1026 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1027 provider ID in the combo.
1029 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1030 Do not show the page numbers, because it would be confusing when we add
1031 the 2 extra pages for the custom setup, when the user chooses the "Other"
1032 provider. This fixes projects.maemo.org bug NB#59028
1034 * src/modest-init.c: (modest_init_init_core),
1035 (modest_init_local_folders):
1036 * src/modest-init.h:
1037 * src/modest-tny-account.c:
1038 (modest_tny_account_new_for_local_folders): Do not create default folders
1039 for the memory card. This should fix projects.maemo.org bug NB#59328.
1041 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1044 Free the changed_conf_keys string items. They are already freed in the
1045 idle handler if that runs first.
1047 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1049 * src/modest-ui-actions.c:
1050 (modest_ui_actions_on_password_requested): Check that the server name
1051 is not NULL, because I just saw a password dialog with (null) as the
1054 * src/modest-tny-folder.[h|c]: Added
1055 modest_tny_folder_is_memory_card_folder().
1056 * src/modest-ui-dimming-rules.c:
1057 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1058 menu item for memory cards, as per the UI spec (section 7.4). This should
1059 fix projects.maemo.org bug NB#59297.
1061 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1063 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1064 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1065 is another problem with the code, see Murray's comment at line 772)
1067 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1070 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1071 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1072 (load_from_file), (easysetup_country_combo_box_init),
1073 (easysetup_country_combo_box_get_active_country_ids),
1074 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1075 instead of just one ID, to avoid duplicate country names in the UI.
1077 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1078 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1079 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1080 a single ID, avoiding duplicate providers.
1081 * src/maemo/easysetup/modest-easysetup-wizard.c:
1082 (on_combo_account_country): Adapt to use a list.
1084 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1087 keys changed in the last X seconds.
1089 * src/modest-account-mgr.h:
1090 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1091 (on_key_change), (modest_account_mgr_class_init),
1092 (modest_account_mgr_init), (modest_account_mgr_finalize):
1093 As the keys are changed, save them in a GSList* and signal that GSList*
1094 further every X seconds, to batch changes, to allow us to do just one
1095 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1096 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1098 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1099 changed signal signature.
1101 * src/modest-conf.c: (modest_conf_set_list),
1102 (modest_conf_on_change): Reenable notification.
1104 (modest_conf_maemo_fake_on_change): Comment out the hack that
1105 notified immediately instead of asynchronously.
1107 * src/widgets/modest-account-view.h:
1108 * src/widgets/modest-account-view.c:
1109 (update_account_view): Select the previously-selected account ID,
1110 if possible. This fixes projects.maemo.org bug NB#56933.
1112 (on_account_changed), (on_account_removed),
1113 (modest_account_view_select_account):
1115 Remove the block/unblock functions
1116 because they were not useful.
1118 * src/maemo/modest-account-view-window.c:
1119 (on_delete_button_clicked), (on_edit_button_clicked),
1120 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1122 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1124 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1125 Improve the error dialog to show Incorrect Account Settings, which seems
1126 clearer, and say that the internal error message (to be removed from the
1127 dialog later) is often misleading.
1128 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1130 * src/modest-tny-account.c:
1131 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1132 URL because this is so useful for debugging on the device.
1134 * src/widgets/modest-serversecurity-combo-box.c:
1135 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1137 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1139 * src/modest-mail-operation.c:
1140 (modest_mail_operation_send_new_mail):
1141 Added a comment about a nasty but apparently harmless message. Details
1142 added to the wiki g_warnings() page.
1144 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1146 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1147 (modest_tny_send_queue_class_init):
1148 Do not use the priv struct because it is empty, to avoid g_warnings
1149 about a non-existant priv struct.
1151 * src/modest-tny-account-store.c:
1152 (modest_tny_account_store_get_server_account),
1153 (modest_tny_account_store_get_transport_account_for_open_connection
1154 ): Do not try to get transport server accounts for local folders,
1155 because they don't have any. This avoids a g_warning().
1157 * src/maemo/modest-main-window.c:
1158 (modest_main_window_notify_send_receive_initied),
1159 (on_configuration_key_changed):
1160 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1161 * src/modest-defs.h:
1162 * src/modest-mail-operation.c:
1163 (modest_mail_operation_update_account):
1164 * src/modest-tny-account-store.h:
1165 * src/modest-tny-account.c:
1166 (modest_tny_account_get_special_folder),
1167 (modest_tny_account_new_for_local_folders),
1168 (modest_tny_account_new_for_per_account_local_outbox_folder):
1169 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1170 * src/modest-tny-local-folders-account.c:
1171 (add_account_folders_to_merged_folder):
1172 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1173 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1174 (modest_ui_actions_on_send):
1175 * src/widgets/modest-folder-view.c: (update_model):
1176 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1177 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1178 modest_tny_account_store_get_tny_account_by_account() to
1179 modest_tny_account_store_get_server_account() to make the code clearer.
1181 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1183 * src/dbus_api/modest-dbus-api.h:
1184 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1185 * src/maemo/modest-msg-edit-window.c:
1186 (modest_msg_edit_window_attach_file_noninteractive):
1187 added g_warning in case the file to be attached does not exist
1188 * tests/dbus_api/test_compose_mail.c: (main):
1189 removed obsolete comment, added generic files as test case
1191 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1193 * src/modest-tny-account-store.c: (get_server_accounts):
1194 Create the local folders account only once, not once for each outbox, and
1195 not only when there are some outboxes.
1197 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1199 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1200 code that is causing a crash at startup. Sergio says that he is fixing this.
1202 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1204 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1205 * src/maemo/modest-account-settings-dialog.c:
1206 (create_page_outgoing),
1207 (modest_account_settings_dialog_set_account_name),
1208 (save_configuration):
1209 - Fixed handling of the "Use secure authentication" toggle to comply with
1210 the ui specification. See also projects.maemo.org bug NB#58400
1212 - Restore the Secure connection setting combo correctly when loading
1215 * src/maemo/modest-maemo-utils.c:
1216 (on_camel_account_get_supported_secure_authentication),
1217 (modest_maemo_utils_get_supported_secure_authentication_methods):
1218 Fixed a crasher if operation is canceled
1220 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1221 (modest_protocol_info_auth_is_secure):
1222 * src/modest-protocol-info.h:
1224 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1225 the sense of the "Use secure authentication" toggle.
1227 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account-store.h:
1230 * src/modest-tny-account-store.c:
1231 Added modest_tny_account_store_get_local_folders_account().
1233 * src/modest-tny-folder.h:
1234 * src/modest-tny-folder.c:
1235 (modest_tny_folder_get_account):
1236 Added this replacement for tny_folder_get_account() which returns
1237 the local-folders account for TnyMergeFolders, to avoid the
1238 warning about the unimplemented get_account_func() vfunc().
1240 (modest_tny_folder_get_rules),
1241 * src/modest-ui-actions.c:
1242 (modest_ui_actions_on_folder_selection_changed):
1243 * src/modest-mail-operation.c:
1244 (modest_mail_operation_remove_folder),
1245 (modest_mail_operation_xfer_folder),
1246 (modest_mail_operation_rename_folder),
1247 (modest_mail_operation_get_msg),
1248 (modest_mail_operation_get_msgs_full),
1249 (modest_mail_operation_remove_msg),
1250 (modest_mail_operation_xfer_msgs),
1251 (modest_mail_operation_refresh_folder):
1252 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1254 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1256 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1257 (modest_server_account_set_security):
1258 * src/modest-defs.h: Add comments explaining that our
1259 UI spec means TLS when it says Normal, so these do not look like errors.
1261 * src/modest-tny-account.c:
1262 (modest_tny_account_new_from_server_account): Use the new tinymail
1263 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1264 for TLS. This should fix projects.maemo.org bug NB#58460.
1266 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1268 * src/maemo/easysetup/modest-easysetup-wizard.c:
1269 (create_account): Correct the position of the gconf sanity check warning.
1270 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1271 of using the g_idle_add() hack, because this does not seem to be necessary
1272 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1273 caused by something other than maemo's gconf.
1274 This fixes projects.maemo.org bug #59022.
1276 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1278 * src/modest-account-mgr-helpers.c:
1279 (modest_account_mgr_get_default_account): Do not check that the account
1280 exists if there is no default account (NULL), to fix a runtime warning.
1282 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1284 * src/widgets/modest-folder-view.c: (update_model):
1285 Do not unref the treemodel before we have finished with it.
1286 This prevents a valgrind warning and an occasional crash at startup.
1288 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1290 * libmodest-dbus-client/libmodest-dbus-client.h:
1291 added libmodest_dbus_client_compose_mail()
1292 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1294 added functions needed for SendAsMail() functionality
1295 * src/maemo/modest-msg-edit-window.c:
1296 (modest_msg_edit_window_attach_file_noninteractive):
1297 non interactively attaching files to message edit window
1298 * src/widgets/modest-msg-edit-window.h:
1299 * tests/dbus_api/Makefile.am:
1300 added test_compose_mail.c
1301 * tests/dbus_api/test_compose_mail.c: (main):
1303 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1305 * src/modest-account-view.c:
1306 Fixed bug projects.maemo.org bug NB#59307
1308 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1310 * src/maemo/easysetup/modest-easysetup-wizard.c:
1311 (get_serverport_incoming), (on_before_next), (create_account):
1312 * src/maemo/modest-account-settings-dialog.c:
1313 (modest_account_settings_dialog_set_account_name):
1314 * src/maemo/modest-maemo-utils.c:
1315 (on_camel_account_get_supported_secure_authentication_status),
1316 (on_camel_account_get_supported_secure_authentication),
1317 (on_secure_auth_cancel),
1318 (modest_maemo_utils_get_supported_secure_authentication_methods):
1320 Implemented security authentication for settings and easysetup.
1322 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/modest-main-window.c: (create_details_widget):
1325 Show the total size for memory card accounts too, instead of showing
1326 the name again. Fixes bug projects.maemo.org bug NB#59307.
1328 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1331 * src/modest-tny-simple-folder-store.c:
1332 * src/modest-tny-simple-folder-store.h: Removed.
1334 * src/modest-tny-local-folders-account.h
1335 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1336 for the local-folders maildir, with an extra TnyMergedFolder containing
1337 the folders of the per-account outbox store accounts.
1338 * src/modest-tny-account-store.c: (get_server_accounts):
1339 Add the outboxes to the special local folders account after creating it.
1341 * src/modest-tny-account.c:
1342 (modest_tny_account_new_for_local_folders): Create the derived
1343 account when creating the main local-folders account.
1345 * src/maemo/modest-main-window.c: (create_details_widget),
1346 (modest_main_window_set_contents_style):
1347 Adapted to the use of the derived account instead of the folder store.
1349 * src/modest-ui-actions.c:
1350 (modest_ui_actions_on_folder_selection_changed):
1351 * src/modest-ui-dimming-rules.c:
1352 (modest_ui_dimming_rules_on_new_folder):
1353 * src/widgets/modest-folder-view.c: (text_cell_data),
1354 (icon_cell_data), (filter_row), (update_model),
1355 (get_cmp_rows_type_pos):
1358 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1359 Do not get the priv struct, because no priv struct has been set,
1360 to avoid a runtime warning.
1362 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1363 #ifelse with #else, to fix a warning, to fix the build.
1366 2007-06-05 Christian Kellner <ckellner@openismus.com>
1368 * libmodest-dbus-client/libmodest-dbus-client.c:
1369 Fix small typo in doc (why do you always see them
1370 AFTER committing stuff?)
1373 2007-06-05 Christian Kellner <ckellner@openismus.com>
1375 * libmodest-dbus-client/libmodest-dbus-client.c:
1376 (libmodest_dbus_client_search):
1377 Initialize hit list with NULL. Also set folder list
1378 to "" if NULL was supplied.
1381 2007-06-03 Christian Kellner <ckellner@openismus.com>
1383 * libmodest-dbus-client/libmodest-dbus-client.c:
1384 (modest_search_hit_list_free):
1385 Make it save to call it with NULL.
1387 * src/dbus_api/modest-dbus-callbacks.c:
1388 * src/modest-search.c:
1389 Return full ModestSearchHits as the search result list not TnyHeader
1390 since can't be around withouth the correspoding TnyFolder.
1392 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1394 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1395 Added currently commented code to check for secure auth
1397 * src/maemo/modest-account-settings-dialog.c: (on_response),
1398 (save_configuration), (show_ok):
1399 Fixed projects.maemo.org bugs NB #59248 and #59251
1401 * src/maemo/modest-maemo-utils.c:
1402 (on_camel_account_get_supported_secure_authentication_status),
1403 (on_camel_account_get_supported_secure_authentication),
1404 (modest_maemo_utils_get_supported_secure_authentication_methods):
1405 * src/maemo/modest-maemo-utils.h:
1406 Moved get_supported_secure_authentication() method here to be able
1407 to use it from easysetup wizard.
1409 * src/modest-pair.c: (on_pair_compare_as_string):
1410 Should compare string with first part of pair and not
1411 strcmp pairs which will crash.
1413 * src/modest-protocol-info.c:
1414 (modest_protocol_info_protocol_is_store):
1415 * src/modest-protocol-info.h:
1416 Added modest_protocol_info_get_auth_protocol_name()
1418 2007-06-03 Armin Burgmeier <armin@openismus.com>
1420 * src/modest-mail-operation.c:
1421 (modest_mail_operation_get_msgs_full): Set priv->account also when
1422 only retrieving a single message. This avoids a crash when canceling
1425 (modest_mail_operation_notify_end): Do not explicitely remove the
1426 operation from the queue but only emit the progress_changed signal.
1427 The queue itself listens to that signal to remove the operation when
1428 it is finished. This reduces coupling and removes a potential deadlock
1429 when modest_mail_operation_notify_end() is called from the queue
1430 itself. If that is a problem performance-wise, I would suggest to
1431 implement a status-changed signal or something.
1433 * src/modest-mail-operation-queue.c: Make sure to never call a
1434 function from another file while the queue is locked. This (hopefully)
1435 fixes another deadlock when exiting the application while retrieving
1438 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1440 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1441 Fixed build if libogs is not available
1443 2007-06-03 Christian Kellner <ckellner@openismus.com>
1445 * libmodest-dbus-client/libmodest-dbus-client.h:
1446 * libmodest-dbus-client/libmodest-dbus-client.c:
1447 (libmodest_dbus_client_delete_message):
1448 Implement deletion of messages (Client side).
1450 (modest_search_hit_free),
1451 (modest_search_hit_list_free):
1452 Utility functions to free the result hits.
1454 * src/dbus_api/modest-dbus-api.h:
1455 * src/dbus_api/modest-dbus-callbacks.c:
1456 (on_delete_message),
1457 (modest_dbus_req_handler):
1458 Implement deletion of messages (Server side).
1460 * tests/dbus_api/test_search.c: (main):
1463 * tests/dbus_api/Makefile.am:
1464 * tests/dbus_api/test_delete_message:
1465 Add little test for the message deletion logic
1467 2007-06-03 Armin Burgmeier <armin@openismus.com>
1469 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1470 when the operation queue was not empty. projects.maemo.org bug
1473 2007-06-03 Armin Burgmeier <armin@openismus.com>
1475 * src/widgets/modest-account-view.c
1476 (on_account_default_toggled): Toggle default account column
1477 explicitely instead of waiting for gconf notification (which is
1478 currently ignored). This should fix projects.maemo.org bug NB#56910
1479 for now. It should probably be removed when gconf notifications are
1482 2007-06-03 Christian Kellner <ckellner@openismus.com>
1484 * libmodest-dbus-client/libmodest-dbus-client.c:
1485 Removed debugging spew.
1487 * src/dbus_api/modest-dbus-callbacks.c:
1488 Added debugging info.
1490 * src/modest-search.c:
1491 (modest_search_all_accounts):
1492 Use tny_account_store_get_accounts () on the account store
1493 to get all accounts which is the way to get all accounts.
1495 * tests/dbus_api/test_search.c: (main):
1496 Make it possible to supply the search term on the command line.
1498 2007-06-03 Christian Kellner <ckellner@openismus.com>
1500 * libmodest-dbus-client/libmodest-dbus-client.c:
1501 * libmodest-dbus-client/libmodest-dbus-client.h:
1502 Implement searching for mesages over raw dbus. (Client side)
1504 * src/dbus_api/Makefile.am:
1505 * src/dbus_api/modest-dbus-api.h:
1506 * src/dbus_api/modest-dbus-callbacks.c:
1507 * src/dbus_api/modest-dbus-callbacks.h:
1508 Search framework (Server side). Also implement on_idle_open_message().
1510 * src/maemo/modest-platform.c: (modest_platform_init):
1511 Prepare for raw dbus/osso rpc interaction.
1513 * src/modest-search.h:
1514 Changed minsize from unspecific guint to guint32.
1516 * src/modest-search.c:
1518 Added strange hack which magically made tnymail work.
1520 (modest_search_folder),
1521 (modest_search_account),
1522 (modest_search_all_accounts):
1523 Implement helper functions to search all accounts, specific account
1526 * tests/dbus_api/Makefile.am:
1527 * tests/dbus_api/test_open_message.c:
1528 Read url to open from commandline.
1530 * tests/dbus_api/test_search.c:
1531 Implement small test for dbus search stuff
1533 2007-06-02 Armin Burgmeier <armin@openismus.com>
1535 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1536 include account type and account title. This fixes projects.maemo.org
1539 * src/maemo/modest-account-view-window.c: Set a title for the window.
1541 2007-06-02 Armin Burgmeier <armin@openismus.com>
1543 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1544 incoming and outgoing server name based on email address and server
1545 types as long as the names have not been edited manually. This fixes
1546 projects.maemo.org bug NB#58671.
1548 2007-06-02 Armin Burgmeier <armin@openismus.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1551 server type cannot be changed in future to the incoming details page
1552 when creating an account. This fixes projects.maemo.org bug NB#59029.
1554 2007-06-02 Armin Burgmeier <armin@openismus.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1557 and assigned max width chars so that they wrap instead of being
1558 truncated. Fixes projects.maemo.org bug NB#56126.
1560 2007-06-02 Armin Burgmeier <armin@openismus.com>
1562 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1563 introductory note to the connection specific smtp servers dialog, as
1564 section 8.12 of the email UI specification requires. This fixes
1565 projects.maemo.org bug NB#59212.
1567 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1569 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1570 Check for running mail operations, and offer to cancel them, as per the UI
1571 spec. This fixes projects.maemo.org bug NB#59041 .
1572 However, I suspect that tinymail may still use the network connection
1573 in ways that we cannot detect or cancel. But it should at least adapt to
1574 changes fairly well.
1576 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1578 * src/modest-tny-account-store.c: (recreate_all_accounts),
1579 (get_cached_accounts), (get_server_accounts): Do more sensible
1580 ref-counting of the temporarily-cached outbox accounts list. This seems
1581 to fix a crash when entering the password when the password was wrong.
1583 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1585 * src/gnome/modest-main-window.c: (connect_signals):
1586 * src/modest-tny-account-store.c: (get_password),
1587 (modest_tny_account_store_alert): Added comments and clues and
1588 commented-out code about how we currently fail to deal with connection
1589 errors and wrong passwords, and how we should.
1591 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1593 * src/widgets/modest-retrieve-combo-box.c:
1594 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1595 This fixes projects.maemo.org bug NB#58472 .
1597 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/easysetup/modest-easysetup-wizard.c:
1600 (create_page_complete_easysetup):
1601 (create_page_complete_custom): Correct the last commit,
1602 putting the correct sentences in the correct pages.
1604 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1606 * src/maemo/easysetup/modest-easysetup-wizard.c:
1607 (create_page_complete_custom): Show the second sentence of text
1608 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1611 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1614 Set the leave-on-server conf key by default. This fixes
1615 projects.maemo.org bug NB#59258 .
1617 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/modest-account-view-window.c:
1620 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1621 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1624 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 (create_caption_new_with_asterisk):
1628 * src/maemo/modest-account-settings-dialog.c:
1629 (create_caption_new_with_asterisk):
1630 Uncomment the code to add the asterisk, because they are no longer in the
1631 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1632 (update_incoming_server_title): Add an asterisk here too.
1634 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/modest-maemo-global-settings-dialog.c:
1637 (current_connection): Check that we are even connected before trying to
1638 get the current connection name, to prevent a warning.
1640 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1641 Change the comments because tny_maemo_conic_device_connect() is now meant to
1643 * src/modest-mail-operation.c:
1644 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1645 make sure we have a connection and fail if we can't connect.
1647 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1649 * src/maemo/modest-main-window.c:
1650 (on_account_store_connecting_finished): Do not try to get the
1651 connection ID if we are not really connected. I am surprised that
1652 this signal handler is called when we are not connected.
1654 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1656 * src/modest-error.h:
1657 * src/modest-ui-actions.c:
1658 (modest_ui_actions_get_msgs_full_error_handler):
1659 Renamed an enum, added comments, added an enum
1660 for retrieve-limit errors.
1662 * src/modest-mail-operation.c: (foreach_add_item),
1663 (internal_folder_observer_update), (update_account_thread),
1664 (modest_mail_operation_get_msgs_full):
1665 (modest_mail_operation_update_account),
1666 Added comments about how this works, and some code that should
1667 (but does not) check the retrieve-limit. See the TODO comment.
1669 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1671 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1672 Initialize help_id to fix the build. Warnings are good.
1674 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1676 * src/widgets/modest-hbox-cell-renderer.c:
1677 (modest_hbox_cell_renderer_append):
1678 * src/widgets/modest-vbox-cell-renderer.c:
1679 (modest_vbox_cell_renderer_append):
1680 Fix the last commit by doing an extra ref.
1682 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1684 * src/widgets/modest-hbox-cell-renderer.c:
1685 (modest_hbox_cell_renderer_append):
1686 * src/widgets/modest-vbox-cell-renderer.c:
1687 (modest_vbox_cell_renderer_append):
1688 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1689 to fix the build with Maemo Bora.
1690 However, there seems to be a remaining crash, probably due to reference
1693 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1695 * src/modest-tny-account.c:
1696 (modest_tny_account_new_for_local_folders):
1697 Use hildon_file_system_info_async_new() to get a better name for
1698 the memory card account, setting it as the account name.
1699 The timing seems to work, but this is probably
1700 not the best place to do this. See the TODO comment.
1701 * src/maemo/modest-main-window.c: (create_details_widget):
1702 * src/widgets/modest-folder-view.c: (text_cell_data):
1703 Use the tny account name instead of hardcoding a name.
1705 2007-05-30 Christian Kellner <ckellner@openismus.com>
1707 * src/modest-search.c: (modest_search):
1708 Correctly set part_search_func even if we have already parsed
1709 the query and thus a valid OgsTextSearcher object.
1711 2007-05-30 Christian Kellner <ckellner@openismus.com>
1714 Search and check for libogs.
1717 Incooparte the ogs build env.
1719 * src/modest-mime-part-search-stream.c:
1720 * src/modest-mime-part-search-stream.h:
1721 Removed since we do the real searching now in modest-search.c.
1723 * src/modest-search.c:
1724 * src/modest-search.h:
1725 Implement support for ogs. We use that if available and requested
1726 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1727 should now handle the corner case when the search term is spread
1728 across multiple reads.
1729 Also the logic in modest_search () was corrected to search all
1730 requested fields until one is found.
1732 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1734 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1736 * src/modest-init.h:
1737 * src/modest-init.c: Made modest_init_local_folders() take a
1738 path and be public so we can iniitialize maildir folders on
1741 * src/modest-local-folder-info.h:
1742 * src/modest-local-folder-info.c:
1743 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1745 * src/modest-tny-account.c:
1746 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1747 still means the standard local-folders path on the local volume.
1749 * src/modest-tny-account-store.c:
1750 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1751 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1752 all accounts when that happens.
1753 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1754 this too, so it shows up in the treeview.
1756 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/modest-maemo-global-settings-dialog.c:
1759 (current_connection):
1760 * src/widgets/modest-global-settings-dialog.c:
1761 (current_connection_default):
1762 Use the enum values instead of 0, 1 and -1,
1763 to make the code clearer.
1765 * src/modest-account-mgr-helpers.c:
1766 (modest_account_mgr_get_connection_specific_smtp): Make this code
1769 * src/modest-runtime.h:
1770 * src/modest-runtime.c:
1771 Added modest_runtime_remove_all_send_queues().
1772 * src/maemo/modest-main-window.c:
1773 (on_account_store_connecting_finished): Recreate the send queues,
1774 using the appropriate transport accounts for this new connection.
1775 Some futher adapting might be needed if the old send queues are not
1776 automatically stopped at this point.
1778 * src/modest-tny-account-store.c: (get_server_accounts):
1779 Create the connection-specific transport accounts, so that they can
1780 be found later by their ID.
1782 * src/modest-tny-account.h:
1783 * src/modest-tny-account.c:
1784 Added modest_tny_account_new_from_server_account_name().
1785 modest_tny_account_new_from_server_account(): Do not create the
1786 send queues here, because they will be
1787 recreated anyway when the connection changes for the first time.
1789 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-local-folder-info.h:
1792 * src/modest-local-folder-info.c:
1793 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1794 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1795 tbox_folder): Take a modest account name instead of a server TnyAccount,
1796 so we can have per-modest-account rather than per-transport-account
1798 We must make sure that we change or recreate the exisitng send queues
1799 when the connection changes for connection-specific transport accounts.
1801 * src/modest-tny-account-store.c:
1802 (create_per_account_local_outbox_folders): Create outboxed per modest
1803 account, not per transport account.
1805 * src/modest-tny-account.h:
1806 * src/modest-tny-account.c:
1807 (modest_tny_account_get_special_folder): For outboxes, get the
1808 parent modest account name. The account is ignored for other folders.
1809 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1810 modest account name rather than a server TnyAccount.
1812 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1814 * src/modest-tny-account.c:
1815 (modest_tny_account_new_from_server_account):
1816 Call modest_runtime_get_send_queue() immediately after creating transport
1817 accounts, so that they start trying to send email from the outbox as soon
1818 as possible at startup. This is probably what we want.
1820 * src/modest-mail-operation.c: (update_account_thread):
1821 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1822 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1823 * src/modest-tny-send-queue.h:
1824 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1825 (modest_ui_actions_on_send):
1826 Added comments about how sending works, though it needs some more work.
1828 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1830 * src/modest-tny-account.c:
1831 (modest_tny_account_get_special_folder): Add TODO because this fails when
1832 the network is busy.
1833 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1834 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1835 Do not try to show this window when there is no active account. The UI
1836 specs does not tell us what to do in this case.
1838 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1842 * src/maemo/Makefile.am:
1843 * src/widgets/Makefile.am: Some dist fixes.
1845 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1847 * src/maemo/modest-connection-specific-smtp-window.c:
1848 (on_button_edit): Make the code clearer, to prevent a double free.
1850 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1852 * src/maemo/modest-account-settings-dialog.c:
1853 (modest_account_settings_dialog_set_account_name),
1854 Check the connection-specific smtp servers checkbox if there are any.
1856 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1857 (modest_connection_specific_smtp_edit_window_init):
1858 Start with a suitable port number.
1860 * src/modest-account-mgr-helpers.h:
1861 * src/modest-account-mgr-helpers.c: Added
1862 modest_account_mgr_get_has_connection_specific_smtp().
1864 (modest_account_mgr_set_connection_specific_smtp),
1865 (modest_account_mgr_remove_connection_specific_smtp),
1866 (modest_account_mgr_get_has_connection_specific_smtp),
1867 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1868 connection-specific smtp server accounts in the account, rather than
1869 the server account conf dir.
1871 This fixes bug projects.maemo.org bug NB#58263 .
1873 * src/modest-tny-account-store.c:
1874 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1875 if there are no server accounts yet, to prevent an infinite loop when there
1876 are no accounts. Document that one must be called before the other.
1878 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1880 * src/modest-account-mgr-helpers.c:
1881 (modest_account_mgr_get_default_account): Make sure that at least
1882 one account is always the default, if there are any enabled accounts.
1883 This is just a sanity check that shouldn't be necessary.
1885 * src/modest-account-mgr-priv.c:
1886 (_modest_account_mgr_account_from_key): Unescape the conf key to
1887 get the real account name. For instance, this is an issue if a space
1888 was in the account name, which can happen because the account name
1889 is generated from the display name.
1890 (_modest_account_mgr_get_account_keyname): Always escape the
1892 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1893 Unescape the conf keys to get the real account names.
1895 For instance, previously the is-default radio button in the accounts
1896 list was not checked for any accounts at first. This fixes that,
1897 and might fix several similar bugs.
1899 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1901 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1902 Removed some debug printfs.
1904 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1906 Modest on-disk outbox directories are now here, for instance:
1907 $HOME/.modest/outboxes/<account-id-1>/outbox
1908 $HOME/.modest/outboxes/<account-id-2>/outbox
1910 $HOME/.modest/local-folders/outbox
1911 so we can have a separate outbox for each account.
1912 But they are shown as one outbox in the GtkTreeView, by using a
1913 TnyMergeFolder in a ModestTnySimpleFolderStore.
1916 * src/modest-tny-simple-folder-store.c:
1917 * src/modest-tny-simple-folder-store.h:
1918 Added ModestTnySimpleFolderStore, used to contain folders from
1919 other folder stores, such as other accounts.
1921 * src/modest-tny-outbox-account.h:
1922 * src/modest-tny-outbox-account.c:
1923 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1924 used for the per-account local outbox folders.
1926 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1927 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1928 only use this (internally) now for the non-outbox local folders.
1930 * src/modest-init.h:
1931 * src/modest-init.c: Added modest_init_one_local_folder(), for
1932 setting up the directory structure for each local folder.
1934 * src/modest-local-folder-info.c:
1935 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1936 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1938 * src/modest-local-folder-info.h:
1939 * src/modest-tny-account-store.c: (on_account_removed),
1940 (on_account_changed), (create_per_account_local_outbox_folders),
1941 (get_server_accounts), (modest_tny_account_store_get_accounts),
1942 (modest_tny_account_store_get_tny_account_by_account),
1943 (modest_tny_folder_store_is_virtual_local_folders):
1945 * src/modest-tny-account.h:
1946 * src/modest-tny-account.c:
1947 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1948 to create an on-disk per-account local outbox folder for each
1950 (create_per_account_local_outbox_folders): Create a local outbox folder
1951 for each transport account.
1952 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1953 for all local folders.
1955 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1956 instead of using g_object_get/set() directly. It is clearer.
1958 (modest_tny_folder_store_get_message_count),
1959 (modest_tny_folder_store_get_local_size
1960 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1961 because we now use these with non-acount folder stores.
1963 (modest_tny_account_get_special_folder),
1964 (modest_tny_account_new_from_server_account),
1965 (modest_tny_account_new_from_account):
1966 (recurse_folders): Adjust to the new outbox system.
1968 * src/modest-tny-folder.h:
1969 * src/modest-tny-folder.c:
1970 (modest_tny_folder_is_local_folder),
1971 (modest_tny_folder_get_local_folder_type),
1972 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1974 * src/widgets/modest-main-window.h:
1975 * src/maemo/modest-main-window.c: (create_details_widget),
1976 (modest_main_window_set_contents_style): Show details for any folder store,
1979 (modest_tny_folder_get_rules):
1980 Remove the const. C does not support constness enough for this.
1982 * src/modest-ui-actions.c:
1983 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1984 make all outboxes appear as one, in the usual local-folders tree node.
1986 (set_active_account_from_tny_account),
1987 (modest_ui_actions_on_folder_selection_changed):
1988 * src/widgets/modest-folder-view.c: (text_cell_data),
1989 (icon_cell_data), (filter_row),
1990 (add_account_folders_to_merged_folder),
1991 (add_account_folders_to_simple_folder_store), (),
1992 (get_cmp_rows_type_pos), (cmp_rows),
1993 (modest_folder_view_set_account_id_of_visible_server_account):
1994 Adjust to the new outbox system, using generic folder stores and folders
1995 in the GtkTreeModel.
1997 2007-05-23 Christian Kellner <ckellner@openismus.com>
1999 * src/modest-mail-operation.c:
2000 (modest_mail_operation_update_account):
2001 Use info->max_size instead of unintialized local var [small
2002 build fix]. (Added TODO to review that change since I don't
2005 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2007 * libmodest-dbus-client/libmodest-dbus-client.c:
2008 (libmodest_dbus_client_compose_mail): function added
2009 * src/dbus_api/modest-dbus-api.h:
2010 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2011 (on_compose_mail): Implementation of the SendAsMail functionality
2013 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2015 * src/modest-account-mgr.c:
2016 (modest_account_mgr_add_server_account): Set the secure-connection
2017 conf key for transport accounts as well as store accounts. I don't know
2018 why the if was there. For instance, this makes sure that we use SSL
2019 for the gmail preset from the easysetup wizard.
2021 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2023 * src/gnome/modest-main-window.c:
2024 (on_account_store_connecting_finished), (connect_signals):
2025 * src/maemo/modest-main-window.c:
2026 (on_account_store_connecting_finished), (connect_signals),
2027 (modest_main_window_new):
2028 Handle TnyAccountStore::connecting-finished instead of
2029 TnyDevice::connection-changed, because we cannot actually perform
2030 operations on accounts until TnyAccountStore has itself responded to
2031 the TnyDevice::connection-changed signal. This prevents a GError from
2033 Do not try to update at startup, because we (at least on scratchbox)
2034 already do an update at startup when the device goes online.
2035 This prevents a GError from tinymail.
2036 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2037 Added TODO about stopping simultaneous operations.
2039 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2041 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2042 * src/modest-mail-operation-queue.c:
2043 (modest_mail_operation_queue_remove):
2044 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2045 about where they happened.
2047 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2049 * src/modest-ui-actions.c:
2050 (modest_ui_actions_on_password_requested): Make sure that the remember
2051 output parameter is always TRUE.
2053 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2055 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2056 Show a OK/Cancel dialog if the error is a question, though we still do not
2057 know anything more about what we are asking the user.
2058 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2059 Fix an uninitialized variable (helper). This is a logic error, however.
2061 2007-05-21 Christian Kellner <ckellner@openismus.com>
2063 * src/modest-search.h:
2064 Correct bit shifting in the ModestSearchFlags enum.
2066 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-tny-account.c:
2069 (modest_tny_account_new_from_server_account): Do not use the lsub and
2070 check-all hard-coded IMAP options when using POP.
2072 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2074 * src/modest-tny-account.c:
2075 (modest_tny_account_new_from_server_account):
2076 Use NULL for the secure-auth method for POP when Password auth has been
2077 specified by the user, as we already do for IMAP. "auth=Login" causes
2078 an error from camel or the server.
2080 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2082 * src/maemo/modest-account-settings-dialog.c:
2083 (create_page_account_details),
2084 (modest_account_settings_dialog_set_account_name):
2085 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2086 for the leave-on-server checkbox, rathr than just the checkbox, when
2087 the protocol is not POP.
2089 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2091 * src/widgets/modest-account-view.c:
2092 * src/widgets/modest-account-view.h:
2093 Added modest_account_view_select_account() which will be useful later
2094 to asynchronously re-select the edited account.
2096 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2098 * src/maemo/modest-account-settings-dialog.c:
2099 (modest_account_settings_dialog_set_account_name):
2100 Automatically choose the port numbers based on the secure authentication
2101 methods, if they have not been chosen before.
2102 This fixes projects.maemo.org bug NB#56273 .
2104 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-main-window-ui.h:
2107 * src/modest-ui-actions.c:
2108 * src/modest-ui-actions.h:
2109 Connect the Tools/SMTP Servers menu item to
2110 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2111 SMTP servers dialog, as in the UI specification and saves changes when it
2112 is closed. This fixed projects.maemo.org bug NB#56305 .
2114 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2116 * src/maemo/modest-connection-specific-smtp-window.c:
2117 (modest_connection_specific_smtp_window_init):
2118 Use gtk_window_set_default_size() to make this window big enough, so
2119 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2121 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2123 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2125 (modest_connection_specific_smtp_edit_window_init),
2126 Do not try to connect to a combobox signal before the combobox exists.
2127 This fixes the cras in projects.maemo.org bug NB#56288 .
2128 (modest_connection_specific_smtp_edit_window_get_settings):
2129 Remove the server_account_name parameter which was being checked for NULL
2130 though it was not used.
2132 * src/maemo/modest-connection-specific-smtp-window.c:
2133 (modest_connection_specific_smtp_window_fill_with_connections),
2134 (on_button_edit), (modest_connection_specific_smtp_window_init):
2135 Correct the number of treemodel columns to prevent a warning.
2136 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2137 libconic does not work.
2139 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2141 * src/modest-tny-account.c:
2142 (modest_tny_account_new_from_server_account):
2143 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2144 SMTP when "None" was chosen by the user. However, with my SMTP server that
2145 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2148 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2150 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2151 to explain the memory management issue with the ID in the ModestPair.
2153 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2154 (add_sending_page), (modest_account_assistant_finalize):
2155 * src/gnome/modest-gnome-global-settings-dialog.c:
2156 (create_updating_page), (create_composing_page):
2157 * src/gnome/modest-msg-edit-window.c: (get_transports),
2158 (init_window), (modest_msg_edit_window_finalize),
2159 (modest_msg_edit_window_get_msg_data):
2160 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2161 * src/gnome/modest-transport-widget.c:
2162 (modest_transport_widget_finalize), (smtp_configuration):
2163 * src/maemo/modest-maemo-global-settings-dialog.c:
2164 (create_updating_page), (create_composing_page):
2165 * src/maemo/modest-msg-edit-window.c: (get_transports),
2166 (init_window), (modest_msg_edit_window_finalize),
2167 (modest_msg_edit_window_get_msg_data),
2168 (modest_msg_edit_window_free_msg_data):
2169 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2170 (modest_store_widget_finalize):
2171 * src/maemo/modest-transport-widget.c:
2172 (modest_transport_widget_finalize), (smtp_configuration):
2173 * src/modest-main.c: (send_mail):
2174 * src/widgets/modest-combo-box.h:
2175 * src/widgets/modest-global-settings-dialog-priv.h:
2176 * src/widgets/modest-global-settings-dialog.c:
2177 (modest_global_settings_dialog_finalize):
2178 * src/widgets/modest-msg-edit-window.h:
2179 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2180 as long as the combo box, to prevent use of freed memory for the ID.
2182 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2184 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2185 get_accounts(), to make this clearer. Do not check for the enabled gconf
2186 key, because we do not use this for server accounts (at least, not yet).
2187 This allows us to send email again.
2189 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2191 * src/maemo/modest-platform.c:
2192 (on_modest_conf_update_interval_changed), (modest_platform_init):
2193 Only respond to this particular key change. All these strcmp()s cannot be
2196 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2198 * src/maemo/modest-maemo-global-settings-dialog.c:
2199 (current_connection): Prevent a crash in scratchbox when
2200 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2201 * src/maemo/modest-platform.c:
2202 (on_modest_conf_update_interval_changed), (modest_platform_init):
2203 Get the update interval from gconf and reset it when the gconf key changes.
2205 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2207 * src/modest-protocol-info.c:
2208 * src/modest-protocol-info.h: Adde enum-specific get functions,
2209 instead of using a ModestProtocolType enum parameter.
2211 * src/gnome/modest-account-assistant.c:
2212 * src/gnome/modest-store-widget.c:
2213 * src/gnome/modest-store-widget.h:
2214 * src/gnome/modest-transport-widget.c:
2215 * src/gnome/modest-transport-widget.h:
2216 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2217 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2218 * src/maemo/easysetup/modest-easysetup-wizard.c:
2219 * src/maemo/modest-account-settings-dialog.c:
2220 * src/maemo/modest-account-settings-dialog.h:
2221 * src/maemo/modest-store-widget.c:
2222 * src/maemo/modest-store-widget.h:
2223 * src/maemo/modest-transport-widget.c:
2224 * src/maemo/modest-transport-widget.h:
2225 * src/modest-account-mgr-helpers.c:
2226 * src/modest-account-mgr-helpers.h:
2227 * src/modest-account-mgr.c:
2228 * src/modest-account-mgr.h:
2229 * src/modest-tny-account.c:
2230 * src/modest-tny-folder.c:
2231 * src/widgets/modest-account-view.c:
2232 * src/widgets/modest-retrieve-combo-box.c:
2233 * src/widgets/modest-retrieve-combo-box.h:
2234 * src/widgets/modest-secureauth-combo-box.c:
2235 * src/widgets/modest-serversecurity-combo-box.c:
2236 * src/widgets/modest-serversecurity-combo-box.h:
2237 * tests/check_account-mgr.c:
2238 Use the specific functions, and use the re-renamed enum values for GNOME too.
2240 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2242 * src/modest-pair.h:
2243 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2244 so we can get the second based on the first.
2246 * src/maemo/modest-account-settings-dialog.h:
2247 * src/maemo/modest-account-settings-dialog.c:
2248 Added get_supported_secure_authentication_methods(), though it is mostly
2249 commented-out for now until the necessary API is committed to tinymail.
2250 (modest_account_settings_dialog_set_account_name),
2251 (save_configuration): Request the supported authentication methods from the
2252 server, so we can choose a working method.
2254 * src/modest-tny-account-store.h:
2255 * src/modest-tny-account-store.c:
2256 (modest_tny_account_store_get_session): Rename from
2257 tny_account_store_get_session().
2259 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2261 * src/modest-protocol-info.h: Split the ModestProtocol enum
2262 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2263 There was no need to have these unrelated values in one enum.
2265 * src/: many files: Adapted to changed enum. This makes the code a bit
2266 clearer, and the compiler could catch some errors.
2268 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2270 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2271 Show the detailed internal camel error message when an error happens
2272 during the configuration, so that our testers can give us more clues.
2273 For instance, in projects.maemo.org bug NB#56910 .
2275 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2277 * src/modest-tny-account.c:
2278 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2279 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2281 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2284 * src/maemo/modest-account-settings-dialog.c:
2285 (modest_account_settings_dialog_set_account_name),
2286 (save_configuration): For the incoming secure authentication checkbox,
2287 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2288 the UI specification. PLAIN does not seem to be supported for most IMAP
2289 servers anyway, and I am not sure what it would mean.
2290 However, we probably need to discover which of the secure-authentication
2291 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2292 * src/modest-account-mgr-helpers.c:
2293 (modest_account_mgr_get_server_account_data):
2295 * src/modest-tny-account.c:
2296 (modest_tny_account_new_from_server_account):
2297 Use tny_account_set_mech() to set secure-authentication methods,
2298 with some special-casing for IMAP, based on my observations of how
2301 * src/modest-account-mgr-helpers.h:
2302 * src/modest-account-mgr.c:
2303 * src/modest-defs.h: Comment that the URI is only used for local folders.
2305 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2307 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2308 parameter const, just to be neat.
2309 * src/modest-text-utils.c: (modest_text_utils_inline):
2310 End g_strconcat() with NULL, as its documentation says. This is almost
2311 certainly the cause of my crash at startup on the device. Interestingly,
2312 valgrind doesn't tell us about these errors.
2314 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2316 * scripts/build-packages: Added more precise comments about how to use
2317 this script, though I still get this error:
2318 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2319 error building tinymail
2321 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2323 * src/maemo/modest-main-window.c: (on_account_update):
2324 Very slight cleanup, hoping to make it simpler to discover what causes
2325 a crash here sometimes.
2327 * src/modest-tny-account.c:
2328 (modest_tny_account_new_from_server_account): Set the port. Added
2329 comments about the options and a TODO comment because I need to find out
2330 how to specify the secure authentication method.
2332 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2334 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2335 changed CFlags paths form modest to libmodest
2337 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2339 * src/modest-account-mgr-helpers.c:
2340 (modest_account_mgr_get_server_account_data),
2341 (modest_account_mgr_free_server_account_data):
2342 * src/modest-account-mgr-helpers.h:
2343 * src/modest-account-mgr.c:
2344 (modest_account_mgr_add_server_account):
2345 * src/modest-defs.h:
2346 * src/modest-tny-account.c:
2347 (modest_tny_account_new_from_server_account):
2348 Determine the options for tny_camel_account_add_option() here,
2349 based on the settings, rather than storing them directly in gconf.
2351 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2353 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2354 Show a more friendly error dialog now that we expect (from the tinymail
2355 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2357 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2359 * src/maemo/modest-main-window.c: (on_account_update): Check that
2360 account_name is not NULL, to prevent a crash at startup that I am
2361 seeing on the N800. I do wonder why it is NULL.
2363 * src/maemo/easysetup/modest-easysetup-wizard.c:
2364 (create_page_user_details):
2365 * src/maemo/modest-account-settings-dialog.c:
2366 (create_page_user_details), (create_page_outgoing):
2367 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2368 (modest_connection_specific_smtp_edit_window_init):
2369 * src/modest-ui-actions.c:
2370 (modest_ui_actions_on_password_requested):
2371 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2372 might do something useful with the on-screen keyboard.
2374 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2376 * src/maemo/modest-main-window.c: (on_account_update):
2377 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2378 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2380 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2382 * src/modest-tny-account-store.c: (on_account_changed):
2383 Correct the signature of this signal handler.
2385 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2387 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2388 Show a HildonNote instead of a GtkDialog for Maemo.
2390 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2392 * src/widgets/modest-account-view.h:
2393 * src/widgets/modest-account-view.c: (on_account_changed),
2394 (on_account_removed). Added a boolean flag, set/unset by
2395 modest_account_view_block_conf_updates(),
2396 modest_account_view_unblock_conf_updates() to prevent unnecessary
2397 updates, but this is not very useful because the gconf notifications are
2398 so delays (maybe only on Maemo Bora).
2399 So auto-updating is turned off, and these functions do an explicit
2400 update when necessary.
2401 However, something else is still doing too much work when adding/removing
2402 accounts, probably in another part of the application.
2404 * src/maemo/modest-account-view-window.c:
2405 (on_delete_button_clicked), (on_edit_button_clicked),
2406 (on_new_button_clicked): Use the new functions.
2408 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2410 * src/modest-account-mgr-helpers.c:
2411 (modest_account_mgr_set_first_account_as_default):
2412 Sort the list of names alphabetically-by-title, so we choose the first one
2414 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2415 alphabetically by the title.
2417 This fixes projects.maemo.org bug NB#56418 .
2419 * src/modest-account-mgr-priv.c:
2420 (_modest_account_mgr_account_from_key):
2421 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2422 avoid a valgrind error, and possible random behaviour.
2424 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2426 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2427 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2428 tinymail documentation to say that this can be expected.
2429 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2430 pretty, and should not happen, but I would prefer to know when it does.
2432 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2434 * configure.ac: When using the older hildon version, probably on Bora,
2435 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2437 * src/widgets/modest-attachment-view.c:
2438 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2441 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2443 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2444 Implemented the prototype. Can be tested with
2445 tests/dbus_api/test_open_message:
2447 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-tny-account-store.c:
2450 (modest_tny_account_store_instance_init), (get_password):
2451 * src/modest-ui-actions.c:
2452 (modest_ui_actions_on_password_requested):
2453 Do not store the password in gconf, because this function is called
2454 for non-remembered passwords. Actually use the cached (in the hash map)
2455 password instead of releasing it.
2456 The password will now not be remembered if it is asked via the protected
2457 password dialog, as per the UI spec.
2459 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2461 * src/modest-defs.h:
2462 * src/modest-account-mgr-helpers.h:
2463 * src/modest-account-mgr-helpers.c:
2464 Added modest_server_account_get_username_has_succeeded(),
2465 modest_server_account_set_username_has_succeeded().
2466 (modest_server_account_set_username),
2467 Reset the has-succeeded flag if the username changes.
2469 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2470 * src/maemo/modest-connection-specific-smtp-window.c:
2471 (modest_connection_specific_smtp_window_save_server_accounts):
2472 Use modest_server_account_set_username() instead of using
2473 modest_conf_set_string() directly, so that the has-succeeded flag is always
2476 * src/modest-ui-actions.c:
2477 (modest_ui_actions_on_password_requested): Dim the username entry if
2478 the username has ever worked, as per the UI spec.
2480 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2482 * src/modest-tny-account-store.c: (get_password):
2483 * src/modest-ui-actions.c:
2484 (modest_ui_actions_on_password_requested):
2485 Allow the username to be changed too, though there is more work to
2486 be done on exactly how this behaves.
2488 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2490 * src/modest-account-mgr-helpers.h:
2491 * src/modest-account-mgr-helpers.c:
2492 Added modest_account_mgr_get_display_name(),
2493 modest_server_account_get_username(),
2494 modest_server_account_set_username(),
2495 modest_server_account_set_password(),
2496 modest_server_account_get_hostname() functions so we do not need to
2497 use the conf API directly.
2499 * src/maemo/modest-main-window.c: (connect_signals):
2500 Actually connect ot the ModestAccountStore::request-password signal,
2501 so that we show the dialog when the password is requested by Tinymail,
2502 for isntance if it is empty.
2504 * src/modest-marshal.list:
2505 * src/modest-tny-account-store.c:
2506 (modest_tny_account_store_class_init), (get_password),
2507 (modest_tny_account_store_alert):
2508 * src/modest-tny-account-store.h:
2509 * src/modest-ui-actions.h:
2510 * src/modest-ui-actions.c:
2511 (modest_ui_actions_on_password_requested):
2512 Change the signal parameters, so it is obvious that we are providing
2513 the non human-readable server name, and receiving both the username
2514 and password, though changing of the username is not yet implemented.
2515 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2516 for the GNOME version.
2518 This should fix the projects.maemo.org bug NB#56209, though it does not
2519 work on Bora, because the gconf_client_get() for the password fails
2520 immediately after we save it with gconf_client_set().
2522 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2525 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2526 caused an undefined symbol error:
2527 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2529 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2531 * src/modest-tny-account-store.c:
2532 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2533 using a GError instead of a string message, so we can translate it in
2536 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2538 * src/maemo/modest-address-book.c:
2539 (modest_address_book_check_names):
2540 * src/maemo/modest-msg-view-window.c:
2541 (modest_msg_view_window_clipboard_owner_change):
2542 * src/modest-init.c: (modest_init_init_ui):
2543 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2544 (update_folders_cb), (modest_mail_operation_update_account):
2545 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2546 (modest_ui_actions_on_msg_attachment_clicked),
2547 (modest_ui_actions_on_msg_recpt_activated):
2548 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2549 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2550 (modest_msg_view_search_next):
2551 * src/widgets/modest-recpt-editor.c:
2552 (modest_recpt_editor_on_button_release_event),
2553 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2554 g_message(). At this point we should only be seeing interesting errors on
2555 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2557 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2559 (modest_wizard_dialog_force_title_update):
2560 * src/maemo/easysetup/modest-wizard-dialog.h:
2561 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2562 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2563 can update the title when appropriate. Otherwise the title is wrong if the
2564 pages are added after adding the notebook to the dialog.
2565 This must be a problem in HildonWizardDialog too.
2566 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2568 * src/maemo/easysetup/modest-easysetup-wizard.c:
2569 (create_subsequent_customsetup_pages),
2570 (create_subsequent_easysetup_pages):
2571 Call modest_wizard_dialog_force_title_update() so that the title is
2572 correct even with GTK+ < 2.10.
2573 This fixes projects.maemo.org bug NB#56145 .
2575 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2577 * src/maemo/modest-platform.c:
2578 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2579 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2582 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2584 * src/widgets/modest-window.h:
2585 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2586 and modest_window_save_state(), which invokes it.
2588 * src/widgets/modest-window-mgr.h:
2589 * src/widgets/modest-window-mgr.c:
2590 Added modest_window_mgr_save_state_for_all_windows(), which calls
2591 the save_state vfunc on all registered windows, if implemented.
2593 * src/gnome/modest-msg-edit-window.c:
2594 * src/gnome/modest-msg-view-window.c:
2595 * src/maemo/modest-msg-edit-window.c:
2596 * src/maemo/modest-msg-view-window.c:
2597 * src/maemo/modest-main-window.c:
2598 Specify the existing save_settings functions as implementations of
2599 ModestWindow::save_state_func().
2601 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2602 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2603 enabling hibernation, for instance.
2605 We may need to do the same thing for restoring settings.
2608 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2610 * src/widgets/modest-window-mgr.c:
2611 * src/widgets/modest-window-mgr.h:
2612 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2613 modest_window_mgr_get_hibernation_is_prevented().
2615 * src/maemo/modest-main-window.c:
2616 (on_hildon_program_is_topmost_notify): Prevent hibernation
2617 (possible when the application goes to the background in the WM),
2618 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2620 * src/maemo/easysetup/modest-easysetup-wizard.c:
2621 (modest_easysetup_wizard_dialog_init):
2622 * src/maemo/modest-account-settings-dialog.c:
2623 (modest_account_settings_dialog_init):
2624 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2625 (modest_connection_specific_smtp_edit_window_init):
2626 * src/maemo/modest-connection-specific-smtp-window.c:
2627 (modest_connection_specific_smtp_window_init):
2628 * src/maemo/modest-signature-editor-dialog.c:
2629 (modest_signature_editor_dialog_init):
2630 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2631 prevent hibernation while any of these account settings dialogs are open.
2633 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/Makefile.am:
2636 * src/maemo/modest-osso-state-saving.c:
2637 * src/maemo/modest-osso-state-saving.h: Added
2638 modest_osso_load_state() and modest_osso_save_state() though they do
2639 nothing now. They should iterate through all the open windows and load/save
2641 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2642 save state when closing.
2644 * src/maemo/modest-main-window.c:
2645 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2646 Add a notification handler for the HildonProgram::is-topmost property,
2647 so we can allow hibernation when the application goes into the background.
2648 But we still need to detect when the accounts setup windows are open so
2649 we can stop hibernation when they are open.
2650 To do this, I also added the main window the HildonProgram. This might have
2651 other side-effects/benefits, and should maybe be done for other windows.
2653 * src/maemo/modest-osso-autosave-callbacks.h:
2654 * src/maemo/modest-osso-autosave-callbacks.c:
2655 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2656 though it does not do anything yet, and we might never need this to do
2657 anything. For instance, we already save drafts.
2659 * src/maemo/modest-platform.c: (modest_platform_init):
2660 Specify the libosso auto-save callback.
2662 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2664 * src/maemo/modest-platform.c:
2665 (modest_platform_set_update_interval):
2666 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2667 aparently stays valid between application instances, so we can use this
2668 to remove and reset it later. According to a maemo-developers email from
2671 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2673 * configure.ac: Depend on libalarm for Maemo.
2675 * src/dbus_api/modest-dbus-api.h:
2676 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2677 (on_send_receive), (modest_dbus_req_handler):
2678 Handle a SEND_RECEIVE D-Bus method.
2680 * libmodest-dbus-client/libmodest-dbus-client.c:
2681 (libmodest_dbus_client_send_and_receive):
2682 * libmodest-dbus-client/libmodest-dbus-client.h:
2683 Add C convenience functions for calling the new D-Bus method.
2685 * src/modest-platform.h:
2686 * src/gnome/modest-platform.c:
2687 * src/maemo/modest-platform.c:
2688 Added modest_platform_set_update_interval(), which uses the
2689 alarmd API on Maemo.
2690 (modest_platform_init),
2691 Call modest_platform_set_update_interval(), using a hard-coded
2692 interval for now (until the global settings dialog is implemented),
2693 though I am not sure that this makes sense yet.
2695 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2697 * src/dbus_api/modest-dbus-callbacks.c:
2698 (modest_osso_cb_hw_state_handler):
2699 * src/dbus_api/modest-dbus-callbacks.h:
2700 * src/maemo/modest-platform.c: (modest_platform_init):
2701 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2702 in case this has some effect on the ability for Maemo to ping the
2705 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2708 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2709 warning. It is probably a logic error, but I need to fix the build.
2711 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2713 * src/modest-account-mgr.h:
2714 * src/modest-account-mgr.c:
2715 (modest_account_mgr_account_names): Add a gboolean enabled_only
2716 parameter, so we can get lists of onlt the enabled accounts.
2718 (modest_account_mgr_add_account),,
2719 (modest_account_mgr_account_with_display_name_exists):
2720 * src/maemo/modest-msg-edit-window.c: (get_transports):
2721 * src/modest-account-mgr-helpers.c:
2722 (modest_account_mgr_set_first_account_as_default):
2723 * src/modest-init.c: (init_default_account_maybe):
2724 * src/modest-tny-account-store.c: (get_accounts):
2725 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2726 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2727 * tests/check_account-mgr.c: (START_TEST):
2728 Provide the extra parameter, as appropriate.
2730 * src/widgets/modest-account-view.c: (update_account_view):
2731 Do not show disabled accounts (meaning that there is no way to
2732 enable/disable accounts in the UI (the feature is not in our UI
2733 specification), so we can use this internally only to mark unfinished
2734 or temporary account data.
2736 * src/maemo/easysetup/modest-easysetup-wizard.c:
2737 (create_account): Add boolean enable parameter, so we can specify FALSE
2738 to create the temporary account.
2739 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2740 (on_before_next): When finishing, when there is a temporary account, just
2742 Also, use a timeout to delay the showing of the dialog until gconf is likely
2743 to return correct information, due to a maemo gconf bug that is fixed in
2744 osso 1.1, but not yet in Bora.
2745 However, the dialog stays on screen after it is destroyed.
2747 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2748 for invalid data when cancelling. Use a hildon note instead of a dialog
2749 to complain about invalid data. Do not show the account-saved note if the
2750 account is disabled (a temporary account that will not really be saved for use
2753 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-account-mgr-helpers.h:
2756 * src/modest-account-mgr-helpers.c:
2757 Added modest_account_mgr_unset_default_account(),
2758 Added modest_account_mgr_set_first_account_as_default().
2760 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2761 If it was the default account, unset the default account name.
2763 * src/maemo/modest-account-view-window.c:
2764 (on_delete_button_clicked): If it was the default account,
2765 set the first remaining account as the default instead.
2767 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2768 a NULL account or a NULL default account, to prevent a crash. This should
2769 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2772 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2774 * src/widgets/modest-recpt-editor.c:
2775 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2776 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2777 TODO comment for this. This fixes the build.
2779 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2780 be the best place for it. This will in future update all auto-update accounts,
2781 rather than just the current/default account, when that gconf key exists.
2782 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2783 if there are no accounts, before calling do_send_receive().
2784 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2786 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2787 * src/maemo/modest-main-window-ui.h:
2788 * src/maemo/modest-main-window.c: (on_connection_changed),
2789 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2790 directly, becaue the signal handler does more.
2792 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2794 * src/modest-account-mgr-helpers.c:
2795 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2796 for the case that the account does not exist.
2798 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2799 (equivalent to the modest account name) rather than the tinymail account name
2800 (equivalent to the modest account title - human readable) to get the account data.
2801 Check for null account data to prevent the crash, and add a TODO comment saying that
2802 this needs fixing because it is using the server account name instead of the account name.
2804 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2806 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2807 * src/maemo/modest-account-settings-dialog.c: (show_error),
2809 Use hildon_note_new_information() for informative and error messages,
2810 which seems to be expected for Maemo applications (no documentation that I know of
2811 says this). I am surprised that there is no distinction between info and error
2814 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2817 it is easy to find where this is used.
2819 * src/maemo/easysetup/modest-easysetup-wizard.c:
2820 (create_page_welcome), (create_page_account_details),
2821 (create_page_user_details), (create_page_complete_easysetup),
2822 (create_page_custom_incoming), (create_page_custom_outgoing),
2823 (create_page_complete_custom):
2824 * src/maemo/modest-account-settings-dialog.c:
2825 (create_page_account_details), (create_page_user_details),
2826 (create_page_incoming), (create_page_outgoing):
2827 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2828 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2829 (modest_connection_specific_smtp_edit_window_init):
2830 * src/maemo/modest-connection-specific-smtp-window.c:
2831 (modest_connection_specific_smtp_window_init):
2832 * src/maemo/modest-signature-editor-dialog.c:
2833 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2834 and scrolling policy as per the Email Application Layout Guide, if I have
2837 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2840 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2841 which were empty, because these vfuncs have been removed from TnyAccountStore.
2842 This fixes the build.
2844 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2846 * src/maemo/modest-main-window.c:
2847 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2848 showing/hiding it. Added TODO because it probably should not be NULL.
2849 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2850 because unnecessary g_warnings() make degugging difficult.
2852 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/modest-msg-edit-window.c:
2855 (modest_msg_edit_window_select_color),
2856 (modest_msg_edit_window_select_background_color): 2 const corrections and
2857 moving 2 #endifs before closing brackets, to fix the build.
2859 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2861 * src/maemo/easysetup/modest-easysetup-wizard.h:
2862 * src/maemo/easysetup/modest-easysetup-wizard.c:
2863 (modest_easysetup_wizard_dialog_finalize),
2864 (on_button_edit_advanced_settings), (create_page_complete_custom),
2865 (on_response), (create_account):
2866 Implement the Advanced Settings edit button, by saving the account information,
2867 for the Advanded Settings dialog to use directly from gconf, and removing it
2868 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2869 Bug #5533 in the projects.maemo.org bugzilla.
2871 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/modest-msg-view-window.c:
2874 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2875 when opening a message window.
2877 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2879 * src/maemo/easysetup/modest-easysetup-wizard.c:
2880 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2883 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2884 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2885 gconf settings. I probably added more checks than necessary, but that is safer.
2887 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2888 variable to fix the build, but this seems to be used when it is still NULL.
2890 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2892 * src/modest-platform.h:
2893 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2894 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2895 * src/modest-main.c: Implement this function so we can avoid using
2896 maemo-specific API from cross-platform code.
2898 * src/modest-tny-account-store.c:
2899 (get_smtp_specific_transport_account_for_open_connection):
2900 * src/modest-ui-actions.c: (check_for_connection),
2901 (modest_ui_actions_on_item_not_found):
2902 Use modest_platform_connect_and_wait() and put #idefs around other
2903 maemo-specific code, because only maemo currently has a way to
2904 identify connection names.
2906 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2908 * src/modest-tny-account-store.h:
2909 * src/modest-tny-account-store.c:
2910 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2911 the connection-specific SMTP server settings in the configuration.
2913 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2915 * src/maemo/modest-main-window.c: (on_connection_changed),
2917 * src/modest-main.c: (main), (start_ui), (send_mail):
2918 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2919 that is what is intended.
2921 * src/modest-ui-actions.c: (action_send), (action_receive),
2922 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2923 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2924 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2925 SMTP server is used when it is specified.
2927 (modest_ui_actions_on_send_receive):
2928 Check that a connection is open before proceeding.
2929 Receive and then send, instead of vice-versa, as per the specification.
2931 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2933 * src/modest-mail-operation.c:
2934 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2935 though I guess it should be something other than NULL.
2937 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2939 * src/maemo/easysetup/modest-easysetup-wizard.c:
2940 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2941 combo twice, to avoid an g_warning and to make it visible again.
2942 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2943 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2944 (already intended) dereference when detaching, because we then recreate the menu.
2945 But I am not sure why the warning was happening, and it is possible that this is a memory
2948 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2950 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2951 and uri_parse_mailto() utility functions.
2952 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2954 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2956 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2958 * src/dbus_api/modest-dbus-api.h:
2959 * src/dbus_api/modest-dbus-callbacks.c:
2960 Use an idle callback to execute the modest code in the application's own thread.
2961 Remove the helloworld example method.
2962 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2963 parsed, and the open-message method is not implemented because this is not yet implemented in
2965 * libmodest-dbus-client/libmodest-dbus-client.c:
2966 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2967 (libmodest_dbus_client_open_message):
2968 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2970 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2971 body without crashing.
2973 * tests/dbus_api/Makefile.am:
2974 * tests/dbus_api/test_mail_to.c:
2975 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2977 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2979 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2980 Added file to fix the build. Sorry.
2982 * src/dbus_api/Makefile.am:
2983 * src/dbus_api/modest-dbus-api.h:
2984 * src/dbus_api/modest-dbus-callbacks.h:
2985 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2986 (modest_dbus_req_handler):
2987 Put constants in a separate header so it can be reused by the
2988 client library, without duplication
2990 * libmodest-dbus-client/Makefile.am:
2991 * libmodest-dbus-client/libmodest-dbus-client.c:
2992 (libmodest_dbus_client_call_helloworld),
2993 (libmodfest_dbus_client_send_mail),
2994 (libmodfest_dbus_client_mailto),
2995 (libmodfest_dbus_client_open_message):
2996 * libmodest-dbus-client/libmodest-dbus-client.h:
2997 (Partly) Implement a send_mail D-Bus method.
2999 * tests/dbus_api/Makefile.am:
3000 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3001 the send_email D-Bus method.
3003 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3007 * libmodest-dbus-client/Makefile.am:
3008 * libmodest-dbus-client/libmodest-dbus-client.c:
3009 * libmodest-dbus-client/libmodest-dbus-client.h:
3010 * tests/dbus_api/Makefile.am:
3011 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3012 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3014 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/easysetup/modest-easysetup-wizard.c:
3017 (create_page_account_details):
3018 * src/maemo/modest-account-settings-dialog.c:
3019 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3020 widgets, because this might not be the default in future versions of the Maemo GTK+.
3021 However, I can not not get capitalization to work even in a simple test case.
3023 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3025 * src/maemo/easysetup/modest-easysetup-wizard.c:
3026 (create_page_custom_incoming), (create_page_custom_outgoing):
3027 * src/maemo/modest-account-settings-dialog.c:
3028 (create_page_account_details), (create_page_incoming),
3029 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3030 instead of using gtk_check_button_with_label(), so they are aligned like the other
3031 widgets, as per the UI spec.
3033 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3035 * src/maemo/easysetup/modest-easysetup-wizard.c:
3036 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3037 * src/widgets/modest-validating-entry.c:
3038 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3039 Modest prefix instead of an EasySetup prefix.
3041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3043 * src/widgets/modest-validating-entry.h:
3044 * src/widgets/modest-validating-entry.c: (on_insert_text),
3045 Added easysetup_validating_entry_set_max_func(), used to set a callback
3046 to call when the max number of characters is reached. GtkEntry has a max-length
3047 already but is silent about it.
3049 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3050 (create_page_account_details), (create_page_user_details),
3052 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3053 (create_page_account_details), (create_page_user_details),
3054 (create_page_outgoing):
3055 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3056 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3057 the UI spec, when the user tries to enter more than the max number of characters.
3059 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3061 * src/maemo/easysetup/modest-easysetup-wizard.c:
3062 (create_page_user_details), (create_page_custom_incoming),
3063 (create_page_custom_outgoing):
3064 * src/maemo/modest-account-settings-dialog.c:
3065 (create_page_user_details), (create_page_incoming),
3066 (create_page_outgoing):
3067 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3068 (modest_connection_specific_smtp_edit_window_init):
3069 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3070 not appropriate. Bad Maemo-specific defaults!.
3072 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3074 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3075 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3076 (modest_signature_editor_dialog_set_settings):
3077 Disable the label and textview when the checkbox is disabled, and use the
3078 specified (UI spec) default signature text.
3080 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3083 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3085 * src/modest-defs.h:
3086 * src/modest-account-mgr-helpers.h:
3087 * src/modest-account-mgr-helpers.c:
3088 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3090 * src/maemo/Makefile.am:
3091 * src/maemo/modest-signature-editor-dialog.c:
3092 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3095 * src/maemo/modest-account-settings-dialog.h:
3096 * src/maemo/modest-account-settings-dialog.c:
3097 (modest_account_settings_dialog_finalize), (on_button_signature),
3098 (save_configuration): Use the new dialog when the Edit button is pressed, and
3099 save the changes if necessary, as per the UI spec.
3101 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3103 * src/maemo/Makefile.am:
3104 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3105 based on maemo-develoers email from Dirk.
3107 * src/maemo/easysetup/modest-easysetup-wizard.c:
3108 (create_page_welcome), (create_page_account_details),
3109 (create_page_user_details), (create_page_complete_easysetup),
3110 (create_page_custom_incoming), (create_page_custom_outgoing),
3111 (create_page_complete_custom),
3112 (modest_easysetup_wizard_dialog_init):
3113 * src/maemo/modest-account-settings-dialog.c:
3114 (create_page_account_details), (create_page_user_details),
3115 (create_page_incoming), (create_page_outgoing),
3116 (modest_account_settings_dialog_init):
3117 * src/maemo/modest-connection-specific-smtp-window.c:
3118 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3120 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3122 * src/maemo/easysetup/modest-easysetup-wizard.c:
3123 (create_page_account_details), (create_page_custom_outgoing),
3124 (create_page_complete_custom):
3125 * src/maemo/modest-account-settings-dialog.c:
3126 (create_page_user_details), (create_page_incoming),
3127 (create_page_outgoing):
3128 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3129 (modest_connection_specific_smtp_edit_window_init):
3130 Use the correct (UI spec) port min/max, and use horizontal separators,
3133 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3135 * src/maemo/easysetup/modest-easysetup-wizard.c:
3136 (set_default_custom_servernames):
3137 * src/maemo/modest-account-settings-dialog.c:
3138 (create_page_incoming), (on_combo_outgoing_security_changed),
3139 (on_combo_incoming_security_changed), (create_page_outgoing),
3140 (modest_account_settings_dialog_set_account_name),
3141 (save_configuration):
3142 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3143 (on_combo_security_changed),
3144 (modest_connection_specific_smtp_edit_window_init),
3145 (modest_connection_specific_smtp_edit_window_set_connection),
3146 (modest_connection_specific_smtp_edit_window_get_settings):
3147 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3150 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3153 * src/maemo/easysetup/modest-easysetup-wizard.c:
3154 (create_page_custom_outgoing), (create_page_complete_custom):
3155 * src/maemo/modest-account-settings-dialog.c:
3156 (create_page_user_details), (create_page_outgoing):
3157 * src/maemo/modest-account-view-window.c: (button_box_new):
3158 Use changed logical IDs as per the most recent UI spec:
3159 mcen_bd_emailsetup_edit -> mcen_bd_edit
3160 mcen_bd_emailsetup_delete -> mcen_bd_delete
3161 mcen_bd_emailsetup_close -> mcen_bd_close
3163 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3167 * src/dbus_api/Makefile.am:
3168 * src/dbus_api/modest-dbus-callbacks.c:
3169 * src/dbus_api/modest-dbus-callbacks.h:
3170 * src/maemo/modest-platform.c: (modest_platform_init):
3171 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3173 * tests/Makefile.am:
3174 * tests/dbus_api/Makefile.am:
3175 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3177 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3179 * src/maemo/modest-account-settings-dialog.c:
3180 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3181 Removed unnecessary includes.
3183 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3185 * src/maemo/easysetup/modest-easysetup-wizard.c:
3186 * src/maemo/modest-account-settings-dialog.c:
3187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3188 * src/widgets/Makefile.am:
3189 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3190 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3191 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3192 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3193 * src/widgets/modest-secureauth-combo-box.c:
3194 * src/widgets/modest-secureauth-combo-box.h:
3195 * src/widgets/modest-serversecurity-combo-box.c:
3196 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3197 made the GObject names more consistent with the rest of the Modest code.
3199 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3201 * src/maemo/easysetup/Makefile.am:
3202 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3203 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3204 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3205 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3206 * src/maemo/easysetup/modest-easysetup-wizard.c:
3207 * src/maemo/easysetup/modest-validating-entry.c:
3208 * src/maemo/easysetup/modest-validating-entry.h:
3209 * src/maemo/modest-account-settings-dialog.c:
3210 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3211 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3212 widgets/ because they are used outside of easysetup too. After checking in,
3213 svn will allow me to rename them too.
3215 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3217 * src/gnome/modest-msg-edit-window.c:
3218 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3219 linker error, to fix the build on the GNOME platform.
3220 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3221 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3222 ifdefed out to avoid a warning.
3224 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3226 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3227 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3228 some alternative for GTK+ 2.6.
3230 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3232 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3234 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3235 specified for EmailAccountsDialog in UI spec.
3237 * src/maemo/easysetup/modest-easysetup-wizard.c:
3238 * src/maemo/easysetup/modest-easysetup-wizard.h:
3239 * src/maemo/modest-account-settings-dialog.c:
3240 * src/maemo/modest-account-settings-dialog.h:
3241 Reuse a member window widget for the connection-specific SMTP server accounts,
3242 so we can tell it to create/save the accounts only if we actually save changes.
3244 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3245 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3246 (modest_connection_specific_smtp_edit_window_get_settings):
3247 Return a struct instance for temporarily remembering the entered data.
3249 * src/maemo/modest-connection-specific-smtp-window.h:
3250 * src/maemo/modest-connection-specific-smtp-window.c:
3251 (modest_connection_specific_smtp_window_finalize),
3252 (modest_connection_specific_smtp_window_fill_with_connections),
3254 (modest_connection_specific_smtp_window_save_server_accounts),
3255 (update_model_server_names): Do not actually save data until asked,
3256 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3258 (on_selection_changed),
3259 (modest_connection_specific_smtp_window_init): Disable the edit
3260 button when nothing is selected.
3262 * src/modest-account-mgr-helpers.c:
3263 * src/modest-account-mgr-helpers.h:
3264 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3267 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3269 * src/modest-account-mgr-helpers.h:
3270 * src/modest-account-mgr-helpers.c:
3271 (modest_account_mgr_get_unused_account_name),
3272 (modest_account_mgr_get_unused_account_display_name): Added these
3273 utility functions, to avoid code duplication.
3275 * src/maemo/easysetup/modest-easysetup-wizard.c:
3276 (create_page_account_details), (create_account):
3277 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3278 (on_combo_security_changed),
3279 (modest_connection_specific_smtp_edit_window_init),
3280 (modest_connection_specific_smtp_edit_window_save_settings):
3281 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3282 * src/maemo/modest-connection-specific-smtp-window.c:
3283 (modest_connection_specific_smtp_window_finalize),
3284 (modest_connection_specific_smtp_window_fill_with_connections),
3285 (on_button_edit), (modest_connection_specific_smtp_window_init):
3286 * src/maemo/modest-connection-specific-smtp-window.h:
3287 Implementing saving of connection-specific server accounts.
3289 But I need to refactor this so we can save the data for each
3290 possible connection-specific account and only actually create the server accounts
3291 when the easysetup finished, or the OK button is pressed on the account settings
3294 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3296 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3297 (on_combo_security_changed):
3298 (modest_connection_specific_smtp_edit_window_init):
3299 Auto-fill the port number as in the account settings.
3301 (modest_connection_specific_smtp_edit_window_set_connection):
3302 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3303 * src/maemo/modest-connection-specific-smtp-window.c:
3304 (fill_with_connections), (on_button_edit),
3305 (modest_connection_specific_smtp_window_init):
3306 Turn the edit window into a dialog to simplify the code, and
3307 set a WM hint as in a GtkDialog, because only a popup can be on top of
3308 another window in Maemo, and popups usually have no WM decoration.
3310 * src/modest-defs.h:
3311 * src/modest-account-mgr-helpers.c:
3312 (modest_account_mgr_set_connection_specific_smtp),
3313 (modest_account_mgr_remove_connection_specific_smtp),
3314 (modest_account_mgr_get_connection_specific_smtp):
3315 * src/modest-account-mgr-helpers.h: Some functions to write the
3316 connection-specific SMTP server information. Not yet used.
3319 * src/widgets/modest-folder-view.c: (text_cell_data):
3320 Fix a warning about an uninitialized variable.
3321 (on_configuration_key_changed): Put an #ifdef around the use
3322 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3324 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3326 * src/maemo/modest-account-settings-dialog.h:
3327 * src/maemo/modest-account-settings-dialog.c:
3328 Added connect_for_modified() utility function to mark the new modified boolean.
3330 (create_page_account_details), (create_page_user_details),
3331 (create_page_incoming), (create_page_outgoing), (on_response),
3332 (modest_account_settings_dialog_init),
3333 (modest_account_settings_dialog_set_account_name):
3334 Only warn about unsaved changes when there are actually unsaved changes.
3336 * src/modest-account-mgr-helpers.c:
3337 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3338 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3339 to get the data from there in future.
3341 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3343 * src/modest-defs.h:
3345 * src/modest-account-mgr-helpers.h:
3346 * src/modest-account-mgr-helpers.c:
3347 Store the security account setting in a single conf key instead of using
3348 the options list, so that the list is left for just the to-be-removed camel hack,
3349 and because gconf_client_set_list() is failing for some reason.
3351 * src/modest-account-mgr.c:
3352 (modest_account_mgr_add_server_account):
3353 * src/maemo/modest-account-settings-dialog.c:
3354 (modest_account_settings_dialog_set_account_name),
3355 (save_configuration): Use the renamed functions.
3358 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3360 * src/widgets/Makefile.am:
3361 * src/widgets/modest-limit-retrieve-combo-box.c:
3362 * src/widgets/modest-limit-retrieve-combo-box.h:
3363 * src/widgets/modest-retrieve-combo-box.c:
3364 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3365 the account settings dialog.
3367 * src/modest-defs.h:
3368 * src/modest-account-mgr-helpers.h:
3369 * src/modest-account-mgr-helpers.c:
3370 (modest_server_account_get_option_secure_auth),
3371 (modest_server_account_set_option_secure_auth):
3372 * src/modest-account-mgr.c:
3373 (modest_account_mgr_add_server_account):
3374 Use the existing AUTH_MECH conf key for the secure-auth setting,
3375 instead of putting it in the list options, because this was actually used already.
3377 * src/maemo/modest-account-settings-dialog.c:
3378 (create_page_account_details),
3379 (modest_account_settings_dialog_set_account_name),
3380 (save_configuration):
3381 * src/maemo/modest-account-settings-dialog.h:
3382 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3383 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3385 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3387 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3388 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3389 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3391 * src/modest-defs.h:
3392 * src/maemo/modest-account-settings-dialog.c:
3393 (create_page_incoming), (on_combo_outgoing_security_changed),
3394 (on_combo_incoming_security_changed), (create_page_outgoing),
3395 (modest_account_settings_dialog_set_account_name),
3396 (save_configuration): Load/Save the port number, and change it when the
3397 security combo changes, to suitable defaults.
3399 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3401 * src/modest-account-mgr.c:
3402 (modest_account_mgr_add_server_account): Set the security and secure-auth
3403 options, and add a comment saying that the other camel-specific options should be
3406 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3410 * src/modest-tny-account-store.c: (account_list_free),
3411 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3412 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3415 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3417 * src/modest-protocol-info.c:
3418 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3419 is required by our UI spec. Maybe something in our implementation will use this eventually.
3420 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3421 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3422 instead of the previous 0 placeholder.
3424 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3425 secure-auth settings.
3426 * src/modest-account-mgr-helpers.h:
3427 * src/modest-account-mgr-helpers.c:
3428 (modest_server_account_data_get_option_secure_auth),
3429 (modest_server_account_set_option_secure_auth),
3430 (modest_server_account_data_get_option_security),
3431 (modest_server_account_set_option_security): Added this API for getting and setting the security
3432 and secure-auth settings.
3434 * src/maemo/modest-account-settings-dialog.h:
3435 * src/maemo/modest-account-settings-dialog.c:
3436 (modest_account_settings_dialog_finalize), (check_data),
3437 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3438 about changing titles.
3439 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3440 (save_configuration): Save the security and secure-auth settings.
3442 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3443 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3445 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3447 * src/modest-defs.h:
3448 * src/modest-account-mgr.c:
3449 (modest_account_mgr_add_server_account):
3450 Added and used defines for the options key and value pair strings,
3451 that are used so far, though they do not seem to correspond to anything in our
3452 UI specs or ModestProtocol enum.
3454 * src/modest-account-mgr-helpers.h:
3455 * src/modest-account-mgr-helpers.c:
3456 (compare_option_strings_for_name),
3457 (modest_server_account_data_get_option_value),
3458 (modest_server_account_data_get_option_bool),
3459 (modest_account_mgr_get_server_account_option):
3460 Added helper functions for parsing the options GSList.
3462 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3464 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3465 display name is based on the supplied account name.
3466 * src/modest-account-mgr.c:
3467 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3468 with an inefficient, but good-enough, implementation.
3470 * src/maemo/easysetup/modest-easysetup-wizard.c:
3471 (create_page_account_details), (on_before_next), (create_account):
3472 Check for existing display names rather than (non-user-visible) account names, and just
3473 create and set a unique account name at the end.
3475 * src/maemo/modest-account-settings-dialog.c:
3476 (modest_account_settings_dialog_init),
3477 (modest_account_settings_dialog_set_account_name),
3478 (create_page_incoming): Show the display name, instead of the account name.
3479 (on_response): Do some (not all) extra checks, as in the UI spec.
3480 (save_configuration): Save the display name if it was changed.
3482 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3484 * po/en_GB.po: Added needed logical ID and translation.
3485 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3486 (init_view): Made the is-default column clicking work.
3488 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3491 * src/maemo/easysetup/Makefile.am:
3492 * src/maemo/easysetup/modest-easysetup-wizard.c:
3493 (modest_easysetup_wizard_dialog_init):
3494 * src/maemo/easysetup/provider-data-test.keyfile:
3495 * src/maemo/easysetup/provider-data.keyfile:
3496 Moved the provider data file to the new modest-providers-data package and used it from there.
3498 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3500 * src/modest-local-folder-info.c:
3501 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3502 N_() was already used on the static strings, but this just marks it for translation without
3503 using the translation.
3505 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3507 * src/maemo/modest-account-settings-dialog.c:
3508 (create_page_incoming),
3509 (modest_account_settings_dialog_set_account_name):
3510 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3511 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3512 I will do this if nobody else gets there first.
3514 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3516 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3517 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3518 save the security stuff.
3520 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3522 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3523 Set the email address and user fullname, which I now see must be
3526 * src/maemo/modest-account-settings-dialog.h:
3527 * src/maemo/modest-account-settings-dialog.c:
3529 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3530 leave-on-server and authentication.
3531 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3534 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3537 * src/maemo/modest-account-settings-dialog.c:
3538 * src/maemo/modest-account-settings-dialog.h:
3539 Most (but not all) of the widgets are now present as specified by the UI spec.
3540 No changes are yet saved, and some details are not properly shown yet.
3542 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3544 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3546 * src/maemo/Makefile.am:
3547 * src/maemo/modest-account-settings-dialog.c:
3548 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3549 an existing account. Doesn't do much yet.
3551 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3552 Open the accounts settings dialog when Edit is clicked.
3554 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3556 * src/maemo/easysetup/Makefile.am:
3557 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3559 * src/maemo/easysetup/modest-easysetup-wizard.c:
3560 (modest_easysetup_wizard_dialog_init):
3561 Try to get the source directory from the build system,
3562 instead of hard-coding "./" into the source code, when opening our local
3563 copies of the configuration files.
3564 But this still fails when opening the wizard from the Accounts window,
3565 maybe because the working directory seems to change at runtime.
3566 So the wizard will fail the second time unless you copy the files into their
3567 proper locations - see the stdout warnings for the paths.
3569 (create_page_account_details),(on_before_next):
3570 Check for existing non-server accounts instead of server accounts,
3571 so the default account name is useful again, and to prevent trying to
3574 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3575 Show the wizard when New is clicked.
3577 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3578 (init_view): Show the column headers, and show the columns that are
3579 specified in the UI specs. However, something in Maemo's GTK+ prevents
3580 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3581 change the default account. This is despite unsetting the special properties.
3583 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3585 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3586 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3587 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3588 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3589 to make that clearer.
3590 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3592 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/modest-account-view-window.c:
3595 (modest_account_view_window_init),
3596 (modest_account_view_window_new):
3597 Use the same buttons as specified in the
3598 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3599 the existing widgets, which never had a chance of working.
3600 Put the ModestAccountView treeview in a scrolled window.
3601 Do not repeat the initialization in both _init() and _new().
3603 * src/widgets/modest-account-view.c: (update_account_view):
3604 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3605 this widget and window shows no accounts.
3607 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3609 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3611 * src/maemo/easysetup/modest-easysetup-wizard.c:
3612 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3613 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3614 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3617 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3618 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3619 accounts exist yet, as in the UI spec.
3621 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3623 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3625 * src/maemo/Makefile.am:
3626 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3627 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3628 New window for editing connection-specific smtp details.
3629 Not fully implemented.
3631 * src/maemo/modest-connection-specific-smtp-window.c:
3632 (modest_connection_specific_smtp_window_finalize) :
3633 unref the tree model.
3634 (on_button_edit): Show the edit window.
3636 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3638 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3641 * src/maemo/Makefile.am:
3642 * src/maemo/modest-connection-specific-smtp-window.c:
3643 * src/maemo/modest-connection-specific-smtp-window.h:
3644 New window for showing the list of connections, for connection-specific
3645 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3646 * src/maemo/easysetup/modest-easysetup-wizard.c:
3647 (create_page_custom_outgoing): Show the new window when the button is clicked.
3649 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3651 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3652 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3653 * src/maemo/modest-msg-edit-window.c:
3654 (modest_msg_edit_window_insert_image):
3655 * src/modest-conf.c: (modest_conf_key_escape):
3656 * src/modest-mail-operation.c:
3657 (modest_mail_operation_send_new_mail):
3658 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3659 (modest_ui_actions_on_new_account):
3660 * src/widgets/modest-attachment-view.c: (update_filename_request):
3661 * src/widgets/modest-mail-header-view.c:
3662 Corrected warnings that were breaking the build, by commenting out unused variables,
3663 and a function, and by including a header.
3665 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3667 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3668 so we can #ifdef around platform-specific code when necessary.
3669 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3670 to allow this to build for the GNOME platform too.
3672 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3674 * src/maemo/easysetup/modest-easysetup-wizard.c:
3675 Added util_increment_name() and used it in create_page_account_details()
3676 to make sure that the default account name is always a new name.
3678 (modest_easysetup_wizard_dialog_init),
3679 (set_default_custom_servernames): Some minor memory management fixes.
3681 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3685 * src/modest-runtime.c: (init_i18n): Restored the translation
3686 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3687 are defined in config.h, and the translations are installed.
3689 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3690 is defined for translation.
3692 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3694 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3696 * src/maemo/easysetup/modest-easysetup-wizard.c:
3697 (modest_easysetup_wizard_dialog_init):
3698 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3699 Use realistic paths (though they should use $prefix generically) to the
3700 mcc_mapping and provider-data.keyfile files which might work when they
3701 are installed by the future version of the operator-wizard package,
3702 and then fallback to paths in our source code, with an explanatory
3705 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3709 * src/maemo/Makefile.am:
3710 * src/maemo/easysetup/: Added files from the previously-exernal
3711 osso-modest-easysetup.
3712 * src/maemo/modest-main-window-ui.h:
3713 * src/modest-ui-actions.c:
3714 * src/modest-ui-actions.h:
3715 Added modest_ui_actions_on_new_account() as a signal handler for the
3716 New Account menu item. It shows the easysetup wizard.
3717 * po/en_GB.po: Added additional needed logical IDs and translations.
projects / modest / blob