1 2007-06-03 Christian Kellner <ckellner@openismus.com>
3 * libmodest-dbus-client/libmodest-dbus-client.c:
4 Removed debugging spew.
6 * src/dbus_api/modest-dbus-callbacks.c:
10 (modest_search_all_accounts):
11 Use tny_account_store_get_accounts () on the account store
12 to get all accounts which is the way to get all accounts.
14 * tests/dbus_api/test_search.c: (main):
15 Make it possible to supply the search term on the command line.
17 2007-06-03 Christian Kellner <ckellner@openismus.com>
19 * libmodest-dbus-client/libmodest-dbus-client.c:
20 * libmodest-dbus-client/libmodest-dbus-client.h:
21 Implement searching for mesages over raw dbus. (Client side)
23 * src/dbus_api/Makefile.am:
24 * src/dbus_api/modest-dbus-api.h:
25 * src/dbus_api/modest-dbus-callbacks.c:
26 * src/dbus_api/modest-dbus-callbacks.h:
27 Search framework (Server side). Also implement on_idle_open_message().
29 * src/maemo/modest-platform.c: (modest_platform_init):
30 Prepare for raw dbus/osso rpc interaction.
32 * src/modest-search.h:
33 Changed minsize from unspecific guint to guint32.
35 * src/modest-search.c:
37 Added strange hack which magically made tnymail work.
39 (modest_search_folder),
40 (modest_search_account),
41 (modest_search_all_accounts):
42 Implement helper functions to search all accounts, specific account
45 * tests/dbus_api/Makefile.am:
46 * tests/dbus_api/test_open_message.c:
47 Read url to open from commandline.
49 * tests/dbus_api/test_search.c:
50 Implement small test for dbus search stuff
52 2007-06-02 Armin Burgmeier <armin@openismus.com>
54 * src/maemo/modest-account-settings-dialog.c: Changed window title to
55 include account type and account title. This fixes projects.maemo.org
58 * src/maemo/modest-account-view-window.c: Set a title for the window.
60 2007-06-02 Armin Burgmeier <armin@openismus.com>
62 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
63 incoming and outgoing server name based on email address and server
64 types as long as the names have not been edited manually. This fixes
65 projects.maemo.org bug NB#58671.
67 2007-06-02 Armin Burgmeier <armin@openismus.com>
69 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
70 server type cannot be changed in future to the incoming details page
71 when creating an account. This fixes projects.maemo.org bug NB#59029.
73 2007-06-02 Armin Burgmeier <armin@openismus.com>
75 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
76 and assigned max width chars so that they wrap instead of being
77 truncated. Fixes projects.maemo.org bug NB#56126.
79 2007-06-02 Armin Burgmeier <armin@openismus.com>
81 * src/maemo/modest-connection-specific-smtp-window.c: Add an
82 introductory note to the connection specific smtp servers dialog, as
83 section 8.12 of the email UI specification requires. This fixes
84 projects.maemo.org bug NB#59212.
86 2007-06-01 Murray Cumming <murrayc@murrayc.com>
88 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
89 Check for running mail operations, and offer to cancel them, as per the UI
90 spec. This fixes projects.maemo.org bug NB#59041 .
91 However, I suspect that tinymail may still use the network connection
92 in ways that we cannot detect or cancel. But it should at least adapt to
95 2007-06-01 Murray Cumming <murrayc@murrayc.com>
97 * src/modest-tny-account-store.c: (recreate_all_accounts),
98 (get_cached_accounts), (get_server_accounts): Do more sensible
99 ref-counting of the temporarily-cached outbox accounts list. This seems
100 to fix a crash when entering the password when the password was wrong.
102 2007-06-01 Murray Cumming <murrayc@murrayc.com>
104 * src/gnome/modest-main-window.c: (connect_signals):
105 * src/modest-tny-account-store.c: (get_password),
106 (modest_tny_account_store_alert): Added comments and clues and
107 commented-out code about how we currently fail to deal with connection
108 errors and wrong passwords, and how we should.
110 2007-06-01 Murray Cumming <murrayc@murrayc.com>
112 * src/widgets/modest-retrieve-combo-box.c:
113 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
114 This fixes projects.maemo.org bug NB#58472 .
116 2007-06-01 Murray Cumming <murrayc@murrayc.com>
118 * src/maemo/easysetup/modest-easysetup-wizard.c:
119 (create_page_complete_easysetup):
120 (create_page_complete_custom): Correct the last commit,
121 putting the correct sentences in the correct pages.
123 2007-06-01 Murray Cumming <murrayc@murrayc.com>
125 * src/maemo/easysetup/modest-easysetup-wizard.c:
126 (create_page_complete_custom): Show the second sentence of text
127 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
130 2007-06-01 Murray Cumming <murrayc@murrayc.com>
132 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
133 Set the leave-on-server conf key by default. This fixes
134 projects.maemo.org bug NB#59258 .
136 2007-06-01 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/modest-account-view-window.c:
139 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
140 logical ID for the confirmation messages. Fixed projects.maemo.org bug
143 2007-06-01 Murray Cumming <murrayc@murrayc.com>
145 * src/maemo/easysetup/modest-easysetup-wizard.c:
146 (create_caption_new_with_asterisk):
147 * src/maemo/modest-account-settings-dialog.c:
148 (create_caption_new_with_asterisk):
149 Uncomment the code to add the asterisk, because they are no longer in the
150 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
151 (update_incoming_server_title): Add an asterisk here too.
153 2007-06-01 Murray Cumming <murrayc@murrayc.com>
155 * src/maemo/modest-maemo-global-settings-dialog.c:
156 (current_connection): Check that we are even connected before trying to
157 get the current connection name, to prevent a warning.
159 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
160 Change the comments because tny_maemo_conic_device_connect() is now meant to
162 * src/modest-mail-operation.c:
163 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
164 make sure we have a connection and fail if we can't connect.
166 2007-05-31 Murray Cumming <murrayc@murrayc.com>
168 * src/maemo/modest-main-window.c:
169 (on_account_store_connecting_finished): Do not try to get the
170 connection ID if we are not really connected. I am surprised that
171 this signal handler is called when we are not connected.
173 2007-05-31 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-error.h:
176 * src/modest-ui-actions.c:
177 (modest_ui_actions_get_msgs_full_error_handler):
178 Renamed an enum, added comments, added an enum
179 for retrieve-limit errors.
181 * src/modest-mail-operation.c: (foreach_add_item),
182 (internal_folder_observer_update), (update_account_thread),
183 (modest_mail_operation_get_msgs_full):
184 (modest_mail_operation_update_account),
185 Added comments about how this works, and some code that should
186 (but does not) check the retrieve-limit. See the TODO comment.
188 2007-05-31 Murray Cumming <murrayc@murrayc.com>
190 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
191 Initialize help_id to fix the build. Warnings are good.
193 2007-05-31 Murray Cumming <murrayc@murrayc.com>
195 * src/widgets/modest-hbox-cell-renderer.c:
196 (modest_hbox_cell_renderer_append):
197 * src/widgets/modest-vbox-cell-renderer.c:
198 (modest_vbox_cell_renderer_append):
199 Fix the last commit by doing an extra ref.
201 2007-05-31 Murray Cumming <murrayc@murrayc.com>
203 * src/widgets/modest-hbox-cell-renderer.c:
204 (modest_hbox_cell_renderer_append):
205 * src/widgets/modest-vbox-cell-renderer.c:
206 (modest_vbox_cell_renderer_append):
207 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
208 to fix the build with Maemo Bora.
209 However, there seems to be a remaining crash, probably due to reference
212 2007-05-30 Murray Cumming <murrayc@murrayc.com>
214 * src/modest-tny-account.c:
215 (modest_tny_account_new_for_local_folders):
216 Use hildon_file_system_info_async_new() to get a better name for
217 the memory card account, setting it as the account name.
218 The timing seems to work, but this is probably
219 not the best place to do this. See the TODO comment.
220 * src/maemo/modest-main-window.c: (create_details_widget):
221 * src/widgets/modest-folder-view.c: (text_cell_data):
222 Use the tny account name instead of hardcoding a name.
224 2007-05-30 Christian Kellner <ckellner@openismus.com>
226 * src/modest-search.c: (modest_search):
227 Correctly set part_search_func even if we have already parsed
228 the query and thus a valid OgsTextSearcher object.
230 2007-05-30 Christian Kellner <ckellner@openismus.com>
233 Search and check for libogs.
236 Incooparte the ogs build env.
238 * src/modest-mime-part-search-stream.c:
239 * src/modest-mime-part-search-stream.h:
240 Removed since we do the real searching now in modest-search.c.
242 * src/modest-search.c:
243 * src/modest-search.h:
244 Implement support for ogs. We use that if available and requested
245 and fall back to modest_text_utils_utf8_strcmp (). The search logic
246 should now handle the corner case when the search term is spread
247 across multiple reads.
248 Also the logic in modest_search () was corrected to search all
249 requested fields until one is found.
251 2007-05-30 Murray Cumming <murrayc@murrayc.com>
253 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
256 * src/modest-init.c: Made modest_init_local_folders() take a
257 path and be public so we can iniitialize maildir folders on
260 * src/modest-local-folder-info.h:
261 * src/modest-local-folder-info.c:
262 (modest_local_folder_info_get_maildir_path): Add a path parameter.
264 * src/modest-tny-account.c:
265 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
266 still means the standard local-folders path on the local volume.
268 * src/modest-tny-account-store.c:
269 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
270 signal so we can detect mount/unmount of the MMC1 card, and do an update of
271 all accounts when that happens.
272 (get_server_accounts): If the MMC1 card is mounted, create a store account for
273 this too, so it shows up in the treeview.
275 2007-05-28 Murray Cumming <murrayc@murrayc.com>
277 * src/maemo/modest-maemo-global-settings-dialog.c:
278 (current_connection):
279 * src/widgets/modest-global-settings-dialog.c:
280 (current_connection_default):
281 Use the enum values instead of 0, 1 and -1,
282 to make the code clearer.
284 * src/modest-account-mgr-helpers.c:
285 (modest_account_mgr_get_connection_specific_smtp): Make this code
288 * src/modest-runtime.h:
289 * src/modest-runtime.c:
290 Added modest_runtime_remove_all_send_queues().
291 * src/maemo/modest-main-window.c:
292 (on_account_store_connecting_finished): Recreate the send queues,
293 using the appropriate transport accounts for this new connection.
294 Some futher adapting might be needed if the old send queues are not
295 automatically stopped at this point.
297 * src/modest-tny-account-store.c: (get_server_accounts):
298 Create the connection-specific transport accounts, so that they can
299 be found later by their ID.
301 * src/modest-tny-account.h:
302 * src/modest-tny-account.c:
303 Added modest_tny_account_new_from_server_account_name().
304 modest_tny_account_new_from_server_account(): Do not create the
305 send queues here, because they will be
306 recreated anyway when the connection changes for the first time.
308 2007-05-28 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-local-folder-info.h:
311 * src/modest-local-folder-info.c:
312 (modest_per_account_local_outbox_folder_info_get_maildir_path),
313 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
314 tbox_folder): Take a modest account name instead of a server TnyAccount,
315 so we can have per-modest-account rather than per-transport-account
317 We must make sure that we change or recreate the exisitng send queues
318 when the connection changes for connection-specific transport accounts.
320 * src/modest-tny-account-store.c:
321 (create_per_account_local_outbox_folders): Create outboxed per modest
322 account, not per transport account.
324 * src/modest-tny-account.h:
325 * src/modest-tny-account.c:
326 (modest_tny_account_get_special_folder): For outboxes, get the
327 parent modest account name. The account is ignored for other folders.
328 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
329 modest account name rather than a server TnyAccount.
331 2007-05-25 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account.c:
334 (modest_tny_account_new_from_server_account):
335 Call modest_runtime_get_send_queue() immediately after creating transport
336 accounts, so that they start trying to send email from the outbox as soon
337 as possible at startup. This is probably what we want.
339 * src/modest-mail-operation.c: (update_account_thread):
340 * src/modest-runtime.c: (modest_runtime_get_send_queue):
341 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
342 * src/modest-tny-send-queue.h:
343 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
344 (modest_ui_actions_on_send):
345 Added comments about how sending works, though it needs some more work.
347 2007-05-25 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-tny-account.c:
350 (modest_tny_account_get_special_folder): Add TODO because this fails when
352 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
353 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
354 Do not try to show this window when there is no active account. The UI
355 specs does not tell us what to do in this case.
357 2007-05-24 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/Makefile.am:
362 * src/widgets/Makefile.am: Some dist fixes.
364 2007-05-24 Murray Cumming <murrayc@murrayc.com>
366 * src/maemo/modest-connection-specific-smtp-window.c:
367 (on_button_edit): Make the code clearer, to prevent a double free.
369 2007-05-24 Murray Cumming <murrayc@murrayc.com>
371 * src/maemo/modest-account-settings-dialog.c:
372 (modest_account_settings_dialog_set_account_name),
373 Check the connection-specific smtp servers checkbox if there are any.
375 * src/maemo/modest-connection-specific-smtp-edit-window.c:
376 (modest_connection_specific_smtp_edit_window_init):
377 Start with a suitable port number.
379 * src/modest-account-mgr-helpers.h:
380 * src/modest-account-mgr-helpers.c: Added
381 modest_account_mgr_get_has_connection_specific_smtp().
383 (modest_account_mgr_set_connection_specific_smtp),
384 (modest_account_mgr_remove_connection_specific_smtp),
385 (modest_account_mgr_get_has_connection_specific_smtp),
386 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
387 connection-specific smtp server accounts in the account, rather than
388 the server account conf dir.
390 This fixes bug projects.maemo.org bug NB#58263 .
392 * src/modest-tny-account-store.c:
393 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
394 if there are no server accounts yet, to prevent an infinite loop when there
395 are no accounts. Document that one must be called before the other.
397 2007-05-24 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-account-mgr-helpers.c:
400 (modest_account_mgr_get_default_account): Make sure that at least
401 one account is always the default, if there are any enabled accounts.
402 This is just a sanity check that shouldn't be necessary.
404 * src/modest-account-mgr-priv.c:
405 (_modest_account_mgr_account_from_key): Unescape the conf key to
406 get the real account name. For instance, this is an issue if a space
407 was in the account name, which can happen because the account name
408 is generated from the display name.
409 (_modest_account_mgr_get_account_keyname): Always escape the
411 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
412 Unescape the conf keys to get the real account names.
414 For instance, previously the is-default radio button in the accounts
415 list was not checked for any accounts at first. This fixes that,
416 and might fix several similar bugs.
418 2007-05-23 Murray Cumming <murrayc@murrayc.com>
420 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
421 Removed some debug printfs.
423 2007-05-23 Murray Cumming <murrayc@murrayc.com>
425 Modest on-disk outbox directories are now here, for instance:
426 $HOME/.modest/outboxes/<account-id-1>/outbox
427 $HOME/.modest/outboxes/<account-id-2>/outbox
429 $HOME/.modest/local-folders/outbox
430 so we can have a separate outbox for each account.
431 But they are shown as one outbox in the GtkTreeView, by using a
432 TnyMergeFolder in a ModestTnySimpleFolderStore.
435 * src/modest-tny-simple-folder-store.c:
436 * src/modest-tny-simple-folder-store.h:
437 Added ModestTnySimpleFolderStore, used to contain folders from
438 other folder stores, such as other accounts.
440 * src/modest-tny-outbox-account.h:
441 * src/modest-tny-outbox-account.c:
442 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
443 used for the per-account local outbox folders.
445 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
446 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
447 only use this (internally) now for the non-outbox local folders.
450 * src/modest-init.c: Added modest_init_one_local_folder(), for
451 setting up the directory structure for each local folder.
453 * src/modest-local-folder-info.c:
454 (modest_per_account_local_outbox_folder_info_get_maildir_path),
455 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
457 * src/modest-local-folder-info.h:
458 * src/modest-tny-account-store.c: (on_account_removed),
459 (on_account_changed), (create_per_account_local_outbox_folders),
460 (get_server_accounts), (modest_tny_account_store_get_accounts),
461 (modest_tny_account_store_get_tny_account_by_account),
462 (modest_tny_folder_store_is_virtual_local_folders):
464 * src/modest-tny-account.h:
465 * src/modest-tny-account.c:
466 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
467 to create an on-disk per-account local outbox folder for each
469 (create_per_account_local_outbox_folders): Create a local outbox folder
470 for each transport account.
471 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
472 for all local folders.
474 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
475 instead of using g_object_get/set() directly. It is clearer.
477 (modest_tny_folder_store_get_message_count),
478 (modest_tny_folder_store_get_local_size
479 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
480 because we now use these with non-acount folder stores.
482 (modest_tny_account_get_special_folder),
483 (modest_tny_account_new_from_server_account),
484 (modest_tny_account_new_from_account):
485 (recurse_folders): Adjust to the new outbox system.
487 * src/modest-tny-folder.h:
488 * src/modest-tny-folder.c:
489 (modest_tny_folder_is_local_folder),
490 (modest_tny_folder_get_local_folder_type),
491 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
493 * src/widgets/modest-main-window.h:
494 * src/maemo/modest-main-window.c: (create_details_widget),
495 (modest_main_window_set_contents_style): Show details for any folder store,
498 (modest_tny_folder_get_rules):
499 Remove the const. C does not support constness enough for this.
501 * src/modest-ui-actions.c:
502 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
503 make all outboxes appear as one, in the usual local-folders tree node.
505 (set_active_account_from_tny_account),
506 (modest_ui_actions_on_folder_selection_changed):
507 * src/widgets/modest-folder-view.c: (text_cell_data),
508 (icon_cell_data), (filter_row),
509 (add_account_folders_to_merged_folder),
510 (add_account_folders_to_simple_folder_store), (),
511 (get_cmp_rows_type_pos), (cmp_rows),
512 (modest_folder_view_set_account_id_of_visible_server_account):
513 Adjust to the new outbox system, using generic folder stores and folders
516 2007-05-23 Christian Kellner <ckellner@openismus.com>
518 * src/modest-mail-operation.c:
519 (modest_mail_operation_update_account):
520 Use info->max_size instead of unintialized local var [small
521 build fix]. (Added TODO to review that change since I don't
524 2007-05-23 Marcus Bauer <marcusb@openismus.com>
526 * libmodest-dbus-client/libmodest-dbus-client.c:
527 (libmodest_dbus_client_compose_mail): function added
528 * src/dbus_api/modest-dbus-api.h:
529 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
530 (on_compose_mail): Implementation of the SendAsMail functionality
532 2007-05-22 Murray Cumming <murrayc@murrayc.com>
534 * src/modest-account-mgr.c:
535 (modest_account_mgr_add_server_account): Set the secure-connection
536 conf key for transport accounts as well as store accounts. I don't know
537 why the if was there. For instance, this makes sure that we use SSL
538 for the gmail preset from the easysetup wizard.
540 2007-05-22 Murray Cumming <murrayc@murrayc.com>
542 * src/gnome/modest-main-window.c:
543 (on_account_store_connecting_finished), (connect_signals):
544 * src/maemo/modest-main-window.c:
545 (on_account_store_connecting_finished), (connect_signals),
546 (modest_main_window_new):
547 Handle TnyAccountStore::connecting-finished instead of
548 TnyDevice::connection-changed, because we cannot actually perform
549 operations on accounts until TnyAccountStore has itself responded to
550 the TnyDevice::connection-changed signal. This prevents a GError from
552 Do not try to update at startup, because we (at least on scratchbox)
553 already do an update at startup when the device goes online.
554 This prevents a GError from tinymail.
555 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
556 Added TODO about stopping simultaneous operations.
558 2007-05-21 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
561 * src/modest-mail-operation-queue.c:
562 (modest_mail_operation_queue_remove):
563 * src/modest-tny-account-store.c: When GErrors happen, give more clues
564 about where they happened.
566 2007-05-21 Murray Cumming <murrayc@murrayc.com>
568 * src/modest-ui-actions.c:
569 (modest_ui_actions_on_password_requested): Make sure that the remember
570 output parameter is always TRUE.
572 2007-05-21 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
575 Show a OK/Cancel dialog if the error is a question, though we still do not
576 know anything more about what we are asking the user.
577 * src/widgets/modest-folder-view.c: (on_drag_data_received):
578 Fix an uninitialized variable (helper). This is a logic error, however.
580 2007-05-21 Christian Kellner <ckellner@openismus.com>
582 * src/modest-search.h:
583 Correct bit shifting in the ModestSearchFlags enum.
585 2007-05-21 Murray Cumming <murrayc@murrayc.com>
587 * src/modest-tny-account.c:
588 (modest_tny_account_new_from_server_account): Do not use the lsub and
589 check-all hard-coded IMAP options when using POP.
591 2007-05-21 Murray Cumming <murrayc@murrayc.com>
593 * src/modest-tny-account.c:
594 (modest_tny_account_new_from_server_account):
595 Use NULL for the secure-auth method for POP when Password auth has been
596 specified by the user, as we already do for IMAP. "auth=Login" causes
597 an error from camel or the server.
599 2007-05-17 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/modest-account-settings-dialog.c:
602 (create_page_account_details),
603 (modest_account_settings_dialog_set_account_name):
604 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
605 for the leave-on-server checkbox, rathr than just the checkbox, when
606 the protocol is not POP.
608 2007-05-17 Murray Cumming <murrayc@murrayc.com>
610 * src/widgets/modest-account-view.c:
611 * src/widgets/modest-account-view.h:
612 Added modest_account_view_select_account() which will be useful later
613 to asynchronously re-select the edited account.
615 2007-05-17 Murray Cumming <murrayc@murrayc.com>
617 * src/maemo/modest-account-settings-dialog.c:
618 (modest_account_settings_dialog_set_account_name):
619 Automatically choose the port numbers based on the secure authentication
620 methods, if they have not been chosen before.
621 This fixes projects.maemo.org bug NB#56273 .
623 2007-05-17 Murray Cumming <murrayc@murrayc.com>
625 * src/maemo/modest-main-window-ui.h:
626 * src/modest-ui-actions.c:
627 * src/modest-ui-actions.h:
628 Connect the Tools/SMTP Servers menu item to
629 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
630 SMTP servers dialog, as in the UI specification and saves changes when it
631 is closed. This fixed projects.maemo.org bug NB#56305 .
633 2007-05-17 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/modest-connection-specific-smtp-window.c:
636 (modest_connection_specific_smtp_window_init):
637 Use gtk_window_set_default_size() to make this window big enough, so
638 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
640 2007-05-17 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/modest-connection-specific-smtp-edit-window.h:
643 * src/maemo/modest-connection-specific-smtp-edit-window.c:
644 (modest_connection_specific_smtp_edit_window_init),
645 Do not try to connect to a combobox signal before the combobox exists.
646 This fixes the cras in projects.maemo.org bug NB#56288 .
647 (modest_connection_specific_smtp_edit_window_get_settings):
648 Remove the server_account_name parameter which was being checked for NULL
649 though it was not used.
651 * src/maemo/modest-connection-specific-smtp-window.c:
652 (modest_connection_specific_smtp_window_fill_with_connections),
653 (on_button_edit), (modest_connection_specific_smtp_window_init):
654 Correct the number of treemodel columns to prevent a warning.
655 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
656 libconic does not work.
658 2007-05-16 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-tny-account.c:
661 (modest_tny_account_new_from_server_account):
662 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
663 SMTP when "None" was chosen by the user. However, with my SMTP server that
664 does not support ANONYMOUS, the emails do not leave the Outbox and I see
667 2007-05-16 Murray Cumming <murrayc@murrayc.com>
669 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
670 to explain the memory management issue with the ID in the ModestPair.
672 * src/gnome/modest-account-assistant.c: (add_receiving_page),
673 (add_sending_page), (modest_account_assistant_finalize):
674 * src/gnome/modest-gnome-global-settings-dialog.c:
675 (create_updating_page), (create_composing_page):
676 * src/gnome/modest-msg-edit-window.c: (get_transports),
677 (init_window), (modest_msg_edit_window_finalize),
678 (modest_msg_edit_window_get_msg_data):
679 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
680 * src/gnome/modest-transport-widget.c:
681 (modest_transport_widget_finalize), (smtp_configuration):
682 * src/maemo/modest-maemo-global-settings-dialog.c:
683 (create_updating_page), (create_composing_page):
684 * src/maemo/modest-msg-edit-window.c: (get_transports),
685 (init_window), (modest_msg_edit_window_finalize),
686 (modest_msg_edit_window_get_msg_data),
687 (modest_msg_edit_window_free_msg_data):
688 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
689 (modest_store_widget_finalize):
690 * src/maemo/modest-transport-widget.c:
691 (modest_transport_widget_finalize), (smtp_configuration):
692 * src/modest-main.c: (send_mail):
693 * src/widgets/modest-combo-box.h:
694 * src/widgets/modest-global-settings-dialog-priv.h:
695 * src/widgets/modest-global-settings-dialog.c:
696 (modest_global_settings_dialog_finalize):
697 * src/widgets/modest-msg-edit-window.h:
698 Whenever using modest_combo_box_new(), keep the ModestPairList alive
699 as long as the combo box, to prevent use of freed memory for the ID.
701 2007-05-15 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
704 get_accounts(), to make this clearer. Do not check for the enabled gconf
705 key, because we do not use this for server accounts (at least, not yet).
706 This allows us to send email again.
708 2007-05-15 Murray Cumming <murrayc@murrayc.com>
710 * src/maemo/modest-platform.c:
711 (on_modest_conf_update_interval_changed), (modest_platform_init):
712 Only respond to this particular key change. All these strcmp()s cannot be
715 2007-05-15 Murray Cumming <murrayc@murrayc.com>
717 * src/maemo/modest-maemo-global-settings-dialog.c:
718 (current_connection): Prevent a crash in scratchbox when
719 ny_maemo_conic_device_get_current_iap_id() returns NULL.
720 * src/maemo/modest-platform.c:
721 (on_modest_conf_update_interval_changed), (modest_platform_init):
722 Get the update interval from gconf and reset it when the gconf key changes.
724 2007-05-15 Murray Cumming <murrayc@murrayc.com>
726 * src/modest-protocol-info.c:
727 * src/modest-protocol-info.h: Adde enum-specific get functions,
728 instead of using a ModestProtocolType enum parameter.
730 * src/gnome/modest-account-assistant.c:
731 * src/gnome/modest-store-widget.c:
732 * src/gnome/modest-store-widget.h:
733 * src/gnome/modest-transport-widget.c:
734 * src/gnome/modest-transport-widget.h:
735 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
736 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
737 * src/maemo/easysetup/modest-easysetup-wizard.c:
738 * src/maemo/modest-account-settings-dialog.c:
739 * src/maemo/modest-account-settings-dialog.h:
740 * src/maemo/modest-store-widget.c:
741 * src/maemo/modest-store-widget.h:
742 * src/maemo/modest-transport-widget.c:
743 * src/maemo/modest-transport-widget.h:
744 * src/modest-account-mgr-helpers.c:
745 * src/modest-account-mgr-helpers.h:
746 * src/modest-account-mgr.c:
747 * src/modest-account-mgr.h:
748 * src/modest-tny-account.c:
749 * src/modest-tny-folder.c:
750 * src/widgets/modest-account-view.c:
751 * src/widgets/modest-retrieve-combo-box.c:
752 * src/widgets/modest-retrieve-combo-box.h:
753 * src/widgets/modest-secureauth-combo-box.c:
754 * src/widgets/modest-serversecurity-combo-box.c:
755 * src/widgets/modest-serversecurity-combo-box.h:
756 * tests/check_account-mgr.c:
757 Use the specific functions, and use the re-renamed enum values for GNOME too.
759 2007-05-15 Murray Cumming <murrayc@murrayc.com>
762 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
763 so we can get the second based on the first.
765 * src/maemo/modest-account-settings-dialog.h:
766 * src/maemo/modest-account-settings-dialog.c:
767 Added get_supported_secure_authentication_methods(), though it is mostly
768 commented-out for now until the necessary API is committed to tinymail.
769 (modest_account_settings_dialog_set_account_name),
770 (save_configuration): Request the supported authentication methods from the
771 server, so we can choose a working method.
773 * src/modest-tny-account-store.h:
774 * src/modest-tny-account-store.c:
775 (modest_tny_account_store_get_session): Rename from
776 tny_account_store_get_session().
778 2007-05-14 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-protocol-info.h: Split the ModestProtocol enum
781 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
782 There was no need to have these unrelated values in one enum.
784 * src/: many files: Adapted to changed enum. This makes the code a bit
785 clearer, and the compiler could catch some errors.
787 2007-05-14 Murray Cumming <murrayc@murrayc.com>
789 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
790 Show the detailed internal camel error message when an error happens
791 during the configuration, so that our testers can give us more clues.
792 For instance, in projects.maemo.org bug NB#56910 .
794 2007-05-14 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-tny-account.c:
797 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
798 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
800 2007-05-14 Murray Cumming <murrayc@murrayc.com>
802 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
803 * src/maemo/modest-account-settings-dialog.c:
804 (modest_account_settings_dialog_set_account_name),
805 (save_configuration): For the incoming secure authentication checkbox,
806 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
807 the UI specification. PLAIN does not seem to be supported for most IMAP
808 servers anyway, and I am not sure what it would mean.
809 However, we probably need to discover which of the secure-authentication
810 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
811 * src/modest-account-mgr-helpers.c:
812 (modest_account_mgr_get_server_account_data):
814 * src/modest-tny-account.c:
815 (modest_tny_account_new_from_server_account):
816 Use tny_account_set_mech() to set secure-authentication methods,
817 with some special-casing for IMAP, based on my observations of how
820 * src/modest-account-mgr-helpers.h:
821 * src/modest-account-mgr.c:
822 * src/modest-defs.h: Comment that the URI is only used for local folders.
824 2007-05-11 Murray Cumming <murrayc@murrayc.com>
826 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
827 parameter const, just to be neat.
828 * src/modest-text-utils.c: (modest_text_utils_inline):
829 End g_strconcat() with NULL, as its documentation says. This is almost
830 certainly the cause of my crash at startup on the device. Interestingly,
831 valgrind doesn't tell us about these errors.
833 2007-05-11 Murray Cumming <murrayc@murrayc.com>
835 * scripts/build-packages: Added more precise comments about how to use
836 this script, though I still get this error:
837 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
838 error building tinymail
840 2007-05-11 Murray Cumming <murrayc@murrayc.com>
842 * src/maemo/modest-main-window.c: (on_account_update):
843 Very slight cleanup, hoping to make it simpler to discover what causes
844 a crash here sometimes.
846 * src/modest-tny-account.c:
847 (modest_tny_account_new_from_server_account): Set the port. Added
848 comments about the options and a TODO comment because I need to find out
849 how to specify the secure authentication method.
851 2007-05-11 Marcus Bauer <marcusb@openismus.com>
853 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
854 changed CFlags paths form modest to libmodest
856 2007-05-10 Murray Cumming <murrayc@murrayc.com>
858 * src/modest-account-mgr-helpers.c:
859 (modest_account_mgr_get_server_account_data),
860 (modest_account_mgr_free_server_account_data):
861 * src/modest-account-mgr-helpers.h:
862 * src/modest-account-mgr.c:
863 (modest_account_mgr_add_server_account):
865 * src/modest-tny-account.c:
866 (modest_tny_account_new_from_server_account):
867 Determine the options for tny_camel_account_add_option() here,
868 based on the settings, rather than storing them directly in gconf.
870 2007-05-10 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
873 Show a more friendly error dialog now that we expect (from the tinymail
874 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
876 2007-05-10 Murray Cumming <murrayc@murrayc.com>
878 * src/maemo/modest-main-window.c: (on_account_update): Check that
879 account_name is not NULL, to prevent a crash at startup that I am
880 seeing on the N800. I do wonder why it is NULL.
882 * src/maemo/easysetup/modest-easysetup-wizard.c:
883 (create_page_user_details):
884 * src/maemo/modest-account-settings-dialog.c:
885 (create_page_user_details), (create_page_outgoing):
886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
887 (modest_connection_specific_smtp_edit_window_init):
888 * src/modest-ui-actions.c:
889 (modest_ui_actions_on_password_requested):
890 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
891 might do something useful with the on-screen keyboard.
893 2007-05-10 Murray Cumming <murrayc@murrayc.com>
895 * src/maemo/modest-main-window.c: (on_account_update):
896 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
897 NULL, to avoid lots of warnings. However, it probably should not be NULL.
899 2007-05-09 Murray Cumming <murrayc@murrayc.com>
901 * src/modest-tny-account-store.c: (on_account_changed):
902 Correct the signature of this signal handler.
904 2007-05-09 Murray Cumming <murrayc@murrayc.com>
906 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
907 Show a HildonNote instead of a GtkDialog for Maemo.
909 2007-05-09 Murray Cumming <murrayc@murrayc.com>
911 * src/widgets/modest-account-view.h:
912 * src/widgets/modest-account-view.c: (on_account_changed),
913 (on_account_removed). Added a boolean flag, set/unset by
914 modest_account_view_block_conf_updates(),
915 modest_account_view_unblock_conf_updates() to prevent unnecessary
916 updates, but this is not very useful because the gconf notifications are
917 so delays (maybe only on Maemo Bora).
918 So auto-updating is turned off, and these functions do an explicit
919 update when necessary.
920 However, something else is still doing too much work when adding/removing
921 accounts, probably in another part of the application.
923 * src/maemo/modest-account-view-window.c:
924 (on_delete_button_clicked), (on_edit_button_clicked),
925 (on_new_button_clicked): Use the new functions.
927 2007-05-09 Murray Cumming <murrayc@murrayc.com>
929 * src/modest-account-mgr-helpers.c:
930 (modest_account_mgr_set_first_account_as_default):
931 Sort the list of names alphabetically-by-title, so we choose the first one
933 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
934 alphabetically by the title.
936 This fixes projects.maemo.org bug NB#56418 .
938 * src/modest-account-mgr-priv.c:
939 (_modest_account_mgr_account_from_key):
940 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
941 avoid a valgrind error, and possible random behaviour.
943 2007-05-09 Murray Cumming <murrayc@murrayc.com>
945 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
946 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
947 tinymail documentation to say that this can be expected.
948 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
949 pretty, and should not happen, but I would prefer to know when it does.
951 2007-05-09 Murray Cumming <murrayc@murrayc.com>
953 * configure.ac: When using the older hildon version, probably on Bora,
954 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
956 * src/widgets/modest-attachment-view.c:
957 (modest_attachment_view_set_part_default): Initialize variables, to fix the
960 2007-05-09 Marcus Bauer <marcusb@openismus.com>
962 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
963 Implemented the prototype. Can be tested with
964 tests/dbus_api/test_open_message:
966 2007-05-08 Murray Cumming <murrayc@murrayc.com>
968 * src/modest-tny-account-store.c:
969 (modest_tny_account_store_instance_init), (get_password):
970 * src/modest-ui-actions.c:
971 (modest_ui_actions_on_password_requested):
972 Do not store the password in gconf, because this function is called
973 for non-remembered passwords. Actually use the cached (in the hash map)
974 password instead of releasing it.
975 The password will now not be remembered if it is asked via the protected
976 password dialog, as per the UI spec.
978 2007-05-08 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-account-mgr-helpers.h:
982 * src/modest-account-mgr-helpers.c:
983 Added modest_server_account_get_username_has_succeeded(),
984 modest_server_account_set_username_has_succeeded().
985 (modest_server_account_set_username),
986 Reset the has-succeeded flag if the username changes.
988 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
989 * src/maemo/modest-connection-specific-smtp-window.c:
990 (modest_connection_specific_smtp_window_save_server_accounts):
991 Use modest_server_account_set_username() instead of using
992 modest_conf_set_string() directly, so that the has-succeeded flag is always
995 * src/modest-ui-actions.c:
996 (modest_ui_actions_on_password_requested): Dim the username entry if
997 the username has ever worked, as per the UI spec.
999 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1001 * src/modest-tny-account-store.c: (get_password):
1002 * src/modest-ui-actions.c:
1003 (modest_ui_actions_on_password_requested):
1004 Allow the username to be changed too, though there is more work to
1005 be done on exactly how this behaves.
1007 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1009 * src/modest-account-mgr-helpers.h:
1010 * src/modest-account-mgr-helpers.c:
1011 Added modest_account_mgr_get_display_name(),
1012 modest_server_account_get_username(),
1013 modest_server_account_set_username(),
1014 modest_server_account_set_password(),
1015 modest_server_account_get_hostname() functions so we do not need to
1016 use the conf API directly.
1018 * src/maemo/modest-main-window.c: (connect_signals):
1019 Actually connect ot the ModestAccountStore::request-password signal,
1020 so that we show the dialog when the password is requested by Tinymail,
1021 for isntance if it is empty.
1023 * src/modest-marshal.list:
1024 * src/modest-tny-account-store.c:
1025 (modest_tny_account_store_class_init), (get_password),
1026 (modest_tny_account_store_alert):
1027 * src/modest-tny-account-store.h:
1028 * src/modest-ui-actions.h:
1029 * src/modest-ui-actions.c:
1030 (modest_ui_actions_on_password_requested):
1031 Change the signal parameters, so it is obvious that we are providing
1032 the non human-readable server name, and receiving both the username
1033 and password, though changing of the username is not yet implemented.
1034 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1035 for the GNOME version.
1037 This should fix the projects.maemo.org bug NB#56209, though it does not
1038 work on Bora, because the gconf_client_get() for the password fails
1039 immediately after we save it with gconf_client_set().
1041 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1044 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1045 caused an undefined symbol error:
1046 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1048 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1050 * src/modest-tny-account-store.c:
1051 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1052 using a GError instead of a string message, so we can translate it in
1055 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/modest-address-book.c:
1058 (modest_address_book_check_names):
1059 * src/maemo/modest-msg-view-window.c:
1060 (modest_msg_view_window_clipboard_owner_change):
1061 * src/modest-init.c: (modest_init_init_ui):
1062 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1063 (update_folders_cb), (modest_mail_operation_update_account):
1064 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1065 (modest_ui_actions_on_msg_attachment_clicked),
1066 (modest_ui_actions_on_msg_recpt_activated):
1067 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1068 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1069 (modest_msg_view_search_next):
1070 * src/widgets/modest-recpt-editor.c:
1071 (modest_recpt_editor_on_button_release_event),
1072 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1073 g_message(). At this point we should only be seeing interesting errors on
1074 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1076 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1078 (modest_wizard_dialog_force_title_update):
1079 * src/maemo/easysetup/modest-wizard-dialog.h:
1080 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1081 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1082 can update the title when appropriate. Otherwise the title is wrong if the
1083 pages are added after adding the notebook to the dialog.
1084 This must be a problem in HildonWizardDialog too.
1085 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1087 * src/maemo/easysetup/modest-easysetup-wizard.c:
1088 (create_subsequent_customsetup_pages),
1089 (create_subsequent_easysetup_pages):
1090 Call modest_wizard_dialog_force_title_update() so that the title is
1091 correct even with GTK+ < 2.10.
1092 This fixes projects.maemo.org bug NB#56145 .
1094 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1096 * src/maemo/modest-platform.c:
1097 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1098 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1101 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1103 * src/widgets/modest-window.h:
1104 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1105 and modest_window_save_state(), which invokes it.
1107 * src/widgets/modest-window-mgr.h:
1108 * src/widgets/modest-window-mgr.c:
1109 Added modest_window_mgr_save_state_for_all_windows(), which calls
1110 the save_state vfunc on all registered windows, if implemented.
1112 * src/gnome/modest-msg-edit-window.c:
1113 * src/gnome/modest-msg-view-window.c:
1114 * src/maemo/modest-msg-edit-window.c:
1115 * src/maemo/modest-msg-view-window.c:
1116 * src/maemo/modest-main-window.c:
1117 Specify the existing save_settings functions as implementations of
1118 ModestWindow::save_state_func().
1120 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1121 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1122 enabling hibernation, for instance.
1124 We may need to do the same thing for restoring settings.
1127 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1129 * src/widgets/modest-window-mgr.c:
1130 * src/widgets/modest-window-mgr.h:
1131 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1132 modest_window_mgr_get_hibernation_is_prevented().
1134 * src/maemo/modest-main-window.c:
1135 (on_hildon_program_is_topmost_notify): Prevent hibernation
1136 (possible when the application goes to the background in the WM),
1137 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1139 * src/maemo/easysetup/modest-easysetup-wizard.c:
1140 (modest_easysetup_wizard_dialog_init):
1141 * src/maemo/modest-account-settings-dialog.c:
1142 (modest_account_settings_dialog_init):
1143 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1144 (modest_connection_specific_smtp_edit_window_init):
1145 * src/maemo/modest-connection-specific-smtp-window.c:
1146 (modest_connection_specific_smtp_window_init):
1147 * src/maemo/modest-signature-editor-dialog.c:
1148 (modest_signature_editor_dialog_init):
1149 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1150 prevent hibernation while any of these account settings dialogs are open.
1152 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1154 * src/maemo/Makefile.am:
1155 * src/maemo/modest-osso-state-saving.c:
1156 * src/maemo/modest-osso-state-saving.h: Added
1157 modest_osso_load_state() and modest_osso_save_state() though they do
1158 nothing now. They should iterate through all the open windows and load/save
1160 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1161 save state when closing.
1163 * src/maemo/modest-main-window.c:
1164 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1165 Add a notification handler for the HildonProgram::is-topmost property,
1166 so we can allow hibernation when the application goes into the background.
1167 But we still need to detect when the accounts setup windows are open so
1168 we can stop hibernation when they are open.
1169 To do this, I also added the main window the HildonProgram. This might have
1170 other side-effects/benefits, and should maybe be done for other windows.
1172 * src/maemo/modest-osso-autosave-callbacks.h:
1173 * src/maemo/modest-osso-autosave-callbacks.c:
1174 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1175 though it does not do anything yet, and we might never need this to do
1176 anything. For instance, we already save drafts.
1178 * src/maemo/modest-platform.c: (modest_platform_init):
1179 Specify the libosso auto-save callback.
1181 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1183 * src/maemo/modest-platform.c:
1184 (modest_platform_set_update_interval):
1185 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1186 aparently stays valid between application instances, so we can use this
1187 to remove and reset it later. According to a maemo-developers email from
1190 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1192 * configure.ac: Depend on libalarm for Maemo.
1194 * src/dbus_api/modest-dbus-api.h:
1195 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1196 (on_send_receive), (modest_dbus_req_handler):
1197 Handle a SEND_RECEIVE D-Bus method.
1199 * libmodest-dbus-client/libmodest-dbus-client.c:
1200 (libmodest_dbus_client_send_and_receive):
1201 * libmodest-dbus-client/libmodest-dbus-client.h:
1202 Add C convenience functions for calling the new D-Bus method.
1204 * src/modest-platform.h:
1205 * src/gnome/modest-platform.c:
1206 * src/maemo/modest-platform.c:
1207 Added modest_platform_set_update_interval(), which uses the
1208 alarmd API on Maemo.
1209 (modest_platform_init),
1210 Call modest_platform_set_update_interval(), using a hard-coded
1211 interval for now (until the global settings dialog is implemented),
1212 though I am not sure that this makes sense yet.
1214 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1216 * src/dbus_api/modest-dbus-callbacks.c:
1217 (modest_osso_cb_hw_state_handler):
1218 * src/dbus_api/modest-dbus-callbacks.h:
1219 * src/maemo/modest-platform.c: (modest_platform_init):
1220 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1221 in case this has some effect on the ability for Maemo to ping the
1224 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1226 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1227 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1228 warning. It is probably a logic error, but I need to fix the build.
1230 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1232 * src/modest-account-mgr.h:
1233 * src/modest-account-mgr.c:
1234 (modest_account_mgr_account_names): Add a gboolean enabled_only
1235 parameter, so we can get lists of onlt the enabled accounts.
1237 (modest_account_mgr_add_account),,
1238 (modest_account_mgr_account_with_display_name_exists):
1239 * src/maemo/modest-msg-edit-window.c: (get_transports):
1240 * src/modest-account-mgr-helpers.c:
1241 (modest_account_mgr_set_first_account_as_default):
1242 * src/modest-init.c: (init_default_account_maybe):
1243 * src/modest-tny-account-store.c: (get_accounts):
1244 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1245 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1246 * tests/check_account-mgr.c: (START_TEST):
1247 Provide the extra parameter, as appropriate.
1249 * src/widgets/modest-account-view.c: (update_account_view):
1250 Do not show disabled accounts (meaning that there is no way to
1251 enable/disable accounts in the UI (the feature is not in our UI
1252 specification), so we can use this internally only to mark unfinished
1253 or temporary account data.
1255 * src/maemo/easysetup/modest-easysetup-wizard.c:
1256 (create_account): Add boolean enable parameter, so we can specify FALSE
1257 to create the temporary account.
1258 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1259 (on_before_next): When finishing, when there is a temporary account, just
1261 Also, use a timeout to delay the showing of the dialog until gconf is likely
1262 to return correct information, due to a maemo gconf bug that is fixed in
1263 osso 1.1, but not yet in Bora.
1264 However, the dialog stays on screen after it is destroyed.
1266 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1267 for invalid data when cancelling. Use a hildon note instead of a dialog
1268 to complain about invalid data. Do not show the account-saved note if the
1269 account is disabled (a temporary account that will not really be saved for use
1272 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1274 * src/modest-account-mgr-helpers.h:
1275 * src/modest-account-mgr-helpers.c:
1276 Added modest_account_mgr_unset_default_account(),
1277 Added modest_account_mgr_set_first_account_as_default().
1279 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1280 If it was the default account, unset the default account name.
1282 * src/maemo/modest-account-view-window.c:
1283 (on_delete_button_clicked): If it was the default account,
1284 set the first remaining account as the default instead.
1286 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1287 a NULL account or a NULL default account, to prevent a crash. This should
1288 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1291 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1293 * src/widgets/modest-recpt-editor.c:
1294 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1295 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1296 TODO comment for this. This fixes the build.
1298 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1299 be the best place for it. This will in future update all auto-update accounts,
1300 rather than just the current/default account, when that gconf key exists.
1301 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1302 if there are no accounts, before calling do_send_receive().
1303 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1305 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1306 * src/maemo/modest-main-window-ui.h:
1307 * src/maemo/modest-main-window.c: (on_connection_changed),
1308 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1309 directly, becaue the signal handler does more.
1311 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1313 * src/modest-account-mgr-helpers.c:
1314 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1315 for the case that the account does not exist.
1317 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1318 (equivalent to the modest account name) rather than the tinymail account name
1319 (equivalent to the modest account title - human readable) to get the account data.
1320 Check for null account data to prevent the crash, and add a TODO comment saying that
1321 this needs fixing because it is using the server account name instead of the account name.
1323 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1326 * src/maemo/modest-account-settings-dialog.c: (show_error),
1328 Use hildon_note_new_information() for informative and error messages,
1329 which seems to be expected for Maemo applications (no documentation that I know of
1330 says this). I am surprised that there is no distinction between info and error
1333 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1336 it is easy to find where this is used.
1338 * src/maemo/easysetup/modest-easysetup-wizard.c:
1339 (create_page_welcome), (create_page_account_details),
1340 (create_page_user_details), (create_page_complete_easysetup),
1341 (create_page_custom_incoming), (create_page_custom_outgoing),
1342 (create_page_complete_custom):
1343 * src/maemo/modest-account-settings-dialog.c:
1344 (create_page_account_details), (create_page_user_details),
1345 (create_page_incoming), (create_page_outgoing):
1346 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1347 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1348 (modest_connection_specific_smtp_edit_window_init):
1349 * src/maemo/modest-connection-specific-smtp-window.c:
1350 (modest_connection_specific_smtp_window_init):
1351 * src/maemo/modest-signature-editor-dialog.c:
1352 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1353 and scrolling policy as per the Email Application Layout Guide, if I have
1356 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1358 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1359 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1360 which were empty, because these vfuncs have been removed from TnyAccountStore.
1361 This fixes the build.
1363 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1365 * src/maemo/modest-main-window.c:
1366 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1367 showing/hiding it. Added TODO because it probably should not be NULL.
1368 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1369 because unnecessary g_warnings() make degugging difficult.
1371 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1373 * src/maemo/modest-msg-edit-window.c:
1374 (modest_msg_edit_window_select_color),
1375 (modest_msg_edit_window_select_background_color): 2 const corrections and
1376 moving 2 #endifs before closing brackets, to fix the build.
1378 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1380 * src/maemo/easysetup/modest-easysetup-wizard.h:
1381 * src/maemo/easysetup/modest-easysetup-wizard.c:
1382 (modest_easysetup_wizard_dialog_finalize),
1383 (on_button_edit_advanced_settings), (create_page_complete_custom),
1384 (on_response), (create_account):
1385 Implement the Advanced Settings edit button, by saving the account information,
1386 for the Advanded Settings dialog to use directly from gconf, and removing it
1387 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1388 Bug #5533 in the projects.maemo.org bugzilla.
1390 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1392 * src/maemo/modest-msg-view-window.c:
1393 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1394 when opening a message window.
1396 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1398 * src/maemo/easysetup/modest-easysetup-wizard.c:
1399 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1402 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1403 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1404 gconf settings. I probably added more checks than necessary, but that is safer.
1406 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1407 variable to fix the build, but this seems to be used when it is still NULL.
1409 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-platform.h:
1412 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1413 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1414 * src/modest-main.c: Implement this function so we can avoid using
1415 maemo-specific API from cross-platform code.
1417 * src/modest-tny-account-store.c:
1418 (get_smtp_specific_transport_account_for_open_connection):
1419 * src/modest-ui-actions.c: (check_for_connection),
1420 (modest_ui_actions_on_item_not_found):
1421 Use modest_platform_connect_and_wait() and put #idefs around other
1422 maemo-specific code, because only maemo currently has a way to
1423 identify connection names.
1425 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1427 * src/modest-tny-account-store.h:
1428 * src/modest-tny-account-store.c:
1429 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1430 the connection-specific SMTP server settings in the configuration.
1432 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1434 * src/maemo/modest-main-window.c: (on_connection_changed),
1436 * src/modest-main.c: (main), (start_ui), (send_mail):
1437 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1438 that is what is intended.
1440 * src/modest-ui-actions.c: (action_send), (action_receive),
1441 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1442 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1443 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1444 SMTP server is used when it is specified.
1446 (modest_ui_actions_on_send_receive):
1447 Check that a connection is open before proceeding.
1448 Receive and then send, instead of vice-versa, as per the specification.
1450 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1452 * src/modest-mail-operation.c:
1453 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1454 though I guess it should be something other than NULL.
1456 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/easysetup/modest-easysetup-wizard.c:
1459 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1460 combo twice, to avoid an g_warning and to make it visible again.
1461 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1462 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1463 (already intended) dereference when detaching, because we then recreate the menu.
1464 But I am not sure why the warning was happening, and it is possible that this is a memory
1467 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1469 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1470 and uri_parse_mailto() utility functions.
1471 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1473 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1475 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1477 * src/dbus_api/modest-dbus-api.h:
1478 * src/dbus_api/modest-dbus-callbacks.c:
1479 Use an idle callback to execute the modest code in the application's own thread.
1480 Remove the helloworld example method.
1481 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1482 parsed, and the open-message method is not implemented because this is not yet implemented in
1484 * libmodest-dbus-client/libmodest-dbus-client.c:
1485 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1486 (libmodest_dbus_client_open_message):
1487 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1489 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1490 body without crashing.
1492 * tests/dbus_api/Makefile.am:
1493 * tests/dbus_api/test_mail_to.c:
1494 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1496 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1498 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1499 Added file to fix the build. Sorry.
1501 * src/dbus_api/Makefile.am:
1502 * src/dbus_api/modest-dbus-api.h:
1503 * src/dbus_api/modest-dbus-callbacks.h:
1504 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1505 (modest_dbus_req_handler):
1506 Put constants in a separate header so it can be reused by the
1507 client library, without duplication
1509 * libmodest-dbus-client/Makefile.am:
1510 * libmodest-dbus-client/libmodest-dbus-client.c:
1511 (libmodest_dbus_client_call_helloworld),
1512 (libmodfest_dbus_client_send_mail),
1513 (libmodfest_dbus_client_mailto),
1514 (libmodfest_dbus_client_open_message):
1515 * libmodest-dbus-client/libmodest-dbus-client.h:
1516 (Partly) Implement a send_mail D-Bus method.
1518 * tests/dbus_api/Makefile.am:
1519 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1520 the send_email D-Bus method.
1522 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1526 * libmodest-dbus-client/Makefile.am:
1527 * libmodest-dbus-client/libmodest-dbus-client.c:
1528 * libmodest-dbus-client/libmodest-dbus-client.h:
1529 * tests/dbus_api/Makefile.am:
1530 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1531 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
1533 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1535 * src/maemo/easysetup/modest-easysetup-wizard.c:
1536 (create_page_account_details):
1537 * src/maemo/modest-account-settings-dialog.c:
1538 (create_page_account_details): Explicitly set auto-capitalization mode for the title
1539 widgets, because this might not be the default in future versions of the Maemo GTK+.
1540 However, I can not not get capitalization to work even in a simple test case.
1542 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/easysetup/modest-easysetup-wizard.c:
1545 (create_page_custom_incoming), (create_page_custom_outgoing):
1546 * src/maemo/modest-account-settings-dialog.c:
1547 (create_page_account_details), (create_page_incoming),
1548 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
1549 instead of using gtk_check_button_with_label(), so they are aligned like the other
1550 widgets, as per the UI spec.
1552 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1554 * src/maemo/easysetup/modest-easysetup-wizard.c:
1555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1556 * src/widgets/modest-validating-entry.c:
1557 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
1558 Modest prefix instead of an EasySetup prefix.
1560 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1562 * src/widgets/modest-validating-entry.h:
1563 * src/widgets/modest-validating-entry.c: (on_insert_text),
1564 Added easysetup_validating_entry_set_max_func(), used to set a callback
1565 to call when the max number of characters is reached. GtkEntry has a max-length
1566 already but is silent about it.
1568 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
1569 (create_page_account_details), (create_page_user_details),
1571 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
1572 (create_page_account_details), (create_page_user_details),
1573 (create_page_outgoing):
1574 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1575 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
1576 the UI spec, when the user tries to enter more than the max number of characters.
1578 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1580 * src/maemo/easysetup/modest-easysetup-wizard.c:
1581 (create_page_user_details), (create_page_custom_incoming),
1582 (create_page_custom_outgoing):
1583 * src/maemo/modest-account-settings-dialog.c:
1584 (create_page_user_details), (create_page_incoming),
1585 (create_page_outgoing):
1586 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1587 (modest_connection_specific_smtp_edit_window_init):
1588 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1589 not appropriate. Bad Maemo-specific defaults!.
1591 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1594 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1595 (modest_signature_editor_dialog_set_settings):
1596 Disable the label and textview when the checkbox is disabled, and use the
1597 specified (UI spec) default signature text.
1599 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1601 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1602 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1604 * src/modest-defs.h:
1605 * src/modest-account-mgr-helpers.h:
1606 * src/modest-account-mgr-helpers.c:
1607 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1609 * src/maemo/Makefile.am:
1610 * src/maemo/modest-signature-editor-dialog.c:
1611 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1614 * src/maemo/modest-account-settings-dialog.h:
1615 * src/maemo/modest-account-settings-dialog.c:
1616 (modest_account_settings_dialog_finalize), (on_button_signature),
1617 (save_configuration): Use the new dialog when the Edit button is pressed, and
1618 save the changes if necessary, as per the UI spec.
1620 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/Makefile.am:
1623 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1624 based on maemo-develoers email from Dirk.
1626 * src/maemo/easysetup/modest-easysetup-wizard.c:
1627 (create_page_welcome), (create_page_account_details),
1628 (create_page_user_details), (create_page_complete_easysetup),
1629 (create_page_custom_incoming), (create_page_custom_outgoing),
1630 (create_page_complete_custom),
1631 (modest_easysetup_wizard_dialog_init):
1632 * src/maemo/modest-account-settings-dialog.c:
1633 (create_page_account_details), (create_page_user_details),
1634 (create_page_incoming), (create_page_outgoing),
1635 (modest_account_settings_dialog_init):
1636 * src/maemo/modest-connection-specific-smtp-window.c:
1637 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1639 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1641 * src/maemo/easysetup/modest-easysetup-wizard.c:
1642 (create_page_account_details), (create_page_custom_outgoing),
1643 (create_page_complete_custom):
1644 * src/maemo/modest-account-settings-dialog.c:
1645 (create_page_user_details), (create_page_incoming),
1646 (create_page_outgoing):
1647 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1648 (modest_connection_specific_smtp_edit_window_init):
1649 Use the correct (UI spec) port min/max, and use horizontal separators,
1652 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1654 * src/maemo/easysetup/modest-easysetup-wizard.c:
1655 (set_default_custom_servernames):
1656 * src/maemo/modest-account-settings-dialog.c:
1657 (create_page_incoming), (on_combo_outgoing_security_changed),
1658 (on_combo_incoming_security_changed), (create_page_outgoing),
1659 (modest_account_settings_dialog_set_account_name),
1660 (save_configuration):
1661 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1662 (on_combo_security_changed),
1663 (modest_connection_specific_smtp_edit_window_init),
1664 (modest_connection_specific_smtp_edit_window_set_connection),
1665 (modest_connection_specific_smtp_edit_window_get_settings):
1666 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1669 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1672 * src/maemo/easysetup/modest-easysetup-wizard.c:
1673 (create_page_custom_outgoing), (create_page_complete_custom):
1674 * src/maemo/modest-account-settings-dialog.c:
1675 (create_page_user_details), (create_page_outgoing):
1676 * src/maemo/modest-account-view-window.c: (button_box_new):
1677 Use changed logical IDs as per the most recent UI spec:
1678 mcen_bd_emailsetup_edit -> mcen_bd_edit
1679 mcen_bd_emailsetup_delete -> mcen_bd_delete
1680 mcen_bd_emailsetup_close -> mcen_bd_close
1682 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1686 * src/dbus_api/Makefile.am:
1687 * src/dbus_api/modest-dbus-callbacks.c:
1688 * src/dbus_api/modest-dbus-callbacks.h:
1689 * src/maemo/modest-platform.c: (modest_platform_init):
1690 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1692 * tests/Makefile.am:
1693 * tests/dbus_api/Makefile.am:
1694 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1696 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1698 * src/maemo/modest-account-settings-dialog.c:
1699 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1700 Removed unnecessary includes.
1702 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1704 * src/maemo/easysetup/modest-easysetup-wizard.c:
1705 * src/maemo/modest-account-settings-dialog.c:
1706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1707 * src/widgets/Makefile.am:
1708 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1709 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1710 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1711 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1712 * src/widgets/modest-secureauth-combo-box.c:
1713 * src/widgets/modest-secureauth-combo-box.h:
1714 * src/widgets/modest-serversecurity-combo-box.c:
1715 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1716 made the GObject names more consistent with the rest of the Modest code.
1718 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1720 * src/maemo/easysetup/Makefile.am:
1721 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1722 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1723 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1724 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1725 * src/maemo/easysetup/modest-easysetup-wizard.c:
1726 * src/maemo/easysetup/modest-validating-entry.c:
1727 * src/maemo/easysetup/modest-validating-entry.h:
1728 * src/maemo/modest-account-settings-dialog.c:
1729 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1730 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1731 widgets/ because they are used outside of easysetup too. After checking in,
1732 svn will allow me to rename them too.
1734 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1736 * src/gnome/modest-msg-edit-window.c:
1737 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1738 linker error, to fix the build on the GNOME platform.
1739 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1740 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1741 ifdefed out to avoid a warning.
1743 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1745 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1746 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1747 some alternative for GTK+ 2.6.
1749 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1751 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1753 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1754 specified for EmailAccountsDialog in UI spec.
1756 * src/maemo/easysetup/modest-easysetup-wizard.c:
1757 * src/maemo/easysetup/modest-easysetup-wizard.h:
1758 * src/maemo/modest-account-settings-dialog.c:
1759 * src/maemo/modest-account-settings-dialog.h:
1760 Reuse a member window widget for the connection-specific SMTP server accounts,
1761 so we can tell it to create/save the accounts only if we actually save changes.
1763 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1765 (modest_connection_specific_smtp_edit_window_get_settings):
1766 Return a struct instance for temporarily remembering the entered data.
1768 * src/maemo/modest-connection-specific-smtp-window.h:
1769 * src/maemo/modest-connection-specific-smtp-window.c:
1770 (modest_connection_specific_smtp_window_finalize),
1771 (modest_connection_specific_smtp_window_fill_with_connections),
1773 (modest_connection_specific_smtp_window_save_server_accounts),
1774 (update_model_server_names): Do not actually save data until asked,
1775 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1777 (on_selection_changed),
1778 (modest_connection_specific_smtp_window_init): Disable the edit
1779 button when nothing is selected.
1781 * src/modest-account-mgr-helpers.c:
1782 * src/modest-account-mgr-helpers.h:
1783 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1786 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1788 * src/modest-account-mgr-helpers.h:
1789 * src/modest-account-mgr-helpers.c:
1790 (modest_account_mgr_get_unused_account_name),
1791 (modest_account_mgr_get_unused_account_display_name): Added these
1792 utility functions, to avoid code duplication.
1794 * src/maemo/easysetup/modest-easysetup-wizard.c:
1795 (create_page_account_details), (create_account):
1796 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1797 (on_combo_security_changed),
1798 (modest_connection_specific_smtp_edit_window_init),
1799 (modest_connection_specific_smtp_edit_window_save_settings):
1800 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1801 * src/maemo/modest-connection-specific-smtp-window.c:
1802 (modest_connection_specific_smtp_window_finalize),
1803 (modest_connection_specific_smtp_window_fill_with_connections),
1804 (on_button_edit), (modest_connection_specific_smtp_window_init):
1805 * src/maemo/modest-connection-specific-smtp-window.h:
1806 Implementing saving of connection-specific server accounts.
1808 But I need to refactor this so we can save the data for each
1809 possible connection-specific account and only actually create the server accounts
1810 when the easysetup finished, or the OK button is pressed on the account settings
1813 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1816 (on_combo_security_changed):
1817 (modest_connection_specific_smtp_edit_window_init):
1818 Auto-fill the port number as in the account settings.
1820 (modest_connection_specific_smtp_edit_window_set_connection):
1821 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1822 * src/maemo/modest-connection-specific-smtp-window.c:
1823 (fill_with_connections), (on_button_edit),
1824 (modest_connection_specific_smtp_window_init):
1825 Turn the edit window into a dialog to simplify the code, and
1826 set a WM hint as in a GtkDialog, because only a popup can be on top of
1827 another window in Maemo, and popups usually have no WM decoration.
1829 * src/modest-defs.h:
1830 * src/modest-account-mgr-helpers.c:
1831 (modest_account_mgr_set_connection_specific_smtp),
1832 (modest_account_mgr_remove_connection_specific_smtp),
1833 (modest_account_mgr_get_connection_specific_smtp):
1834 * src/modest-account-mgr-helpers.h: Some functions to write the
1835 connection-specific SMTP server information. Not yet used.
1838 * src/widgets/modest-folder-view.c: (text_cell_data):
1839 Fix a warning about an uninitialized variable.
1840 (on_configuration_key_changed): Put an #ifdef around the use
1841 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1843 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/modest-account-settings-dialog.h:
1846 * src/maemo/modest-account-settings-dialog.c:
1847 Added connect_for_modified() utility function to mark the new modified boolean.
1849 (create_page_account_details), (create_page_user_details),
1850 (create_page_incoming), (create_page_outgoing), (on_response),
1851 (modest_account_settings_dialog_init),
1852 (modest_account_settings_dialog_set_account_name):
1853 Only warn about unsaved changes when there are actually unsaved changes.
1855 * src/modest-account-mgr-helpers.c:
1856 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1857 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1858 to get the data from there in future.
1860 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1862 * src/modest-defs.h:
1864 * src/modest-account-mgr-helpers.h:
1865 * src/modest-account-mgr-helpers.c:
1866 Store the security account setting in a single conf key instead of using
1867 the options list, so that the list is left for just the to-be-removed camel hack,
1868 and because gconf_client_set_list() is failing for some reason.
1870 * src/modest-account-mgr.c:
1871 (modest_account_mgr_add_server_account):
1872 * src/maemo/modest-account-settings-dialog.c:
1873 (modest_account_settings_dialog_set_account_name),
1874 (save_configuration): Use the renamed functions.
1877 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1879 * src/widgets/Makefile.am:
1880 * src/widgets/modest-limit-retrieve-combo-box.c:
1881 * src/widgets/modest-limit-retrieve-combo-box.h:
1882 * src/widgets/modest-retrieve-combo-box.c:
1883 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1884 the account settings dialog.
1886 * src/modest-defs.h:
1887 * src/modest-account-mgr-helpers.h:
1888 * src/modest-account-mgr-helpers.c:
1889 (modest_server_account_get_option_secure_auth),
1890 (modest_server_account_set_option_secure_auth):
1891 * src/modest-account-mgr.c:
1892 (modest_account_mgr_add_server_account):
1893 Use the existing AUTH_MECH conf key for the secure-auth setting,
1894 instead of putting it in the list options, because this was actually used already.
1896 * src/maemo/modest-account-settings-dialog.c:
1897 (create_page_account_details),
1898 (modest_account_settings_dialog_set_account_name),
1899 (save_configuration):
1900 * src/maemo/modest-account-settings-dialog.h:
1901 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1902 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1904 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1906 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1907 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1908 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1910 * src/modest-defs.h:
1911 * src/maemo/modest-account-settings-dialog.c:
1912 (create_page_incoming), (on_combo_outgoing_security_changed),
1913 (on_combo_incoming_security_changed), (create_page_outgoing),
1914 (modest_account_settings_dialog_set_account_name),
1915 (save_configuration): Load/Save the port number, and change it when the
1916 security combo changes, to suitable defaults.
1918 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-account-mgr.c:
1921 (modest_account_mgr_add_server_account): Set the security and secure-auth
1922 options, and add a comment saying that the other camel-specific options should be
1925 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1927 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1929 * src/modest-tny-account-store.c: (account_list_free),
1930 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1931 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1934 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1936 * src/modest-protocol-info.c:
1937 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1938 is required by our UI spec. Maybe something in our implementation will use this eventually.
1939 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1940 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1941 instead of the previous 0 placeholder.
1943 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1944 secure-auth settings.
1945 * src/modest-account-mgr-helpers.h:
1946 * src/modest-account-mgr-helpers.c:
1947 (modest_server_account_data_get_option_secure_auth),
1948 (modest_server_account_set_option_secure_auth),
1949 (modest_server_account_data_get_option_security),
1950 (modest_server_account_set_option_security): Added this API for getting and setting the security
1951 and secure-auth settings.
1953 * src/maemo/modest-account-settings-dialog.h:
1954 * src/maemo/modest-account-settings-dialog.c:
1955 (modest_account_settings_dialog_finalize), (check_data),
1956 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1957 about changing titles.
1958 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1959 (save_configuration): Save the security and secure-auth settings.
1961 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1962 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1964 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-defs.h:
1967 * src/modest-account-mgr.c:
1968 (modest_account_mgr_add_server_account):
1969 Added and used defines for the options key and value pair strings,
1970 that are used so far, though they do not seem to correspond to anything in our
1971 UI specs or ModestProtocol enum.
1973 * src/modest-account-mgr-helpers.h:
1974 * src/modest-account-mgr-helpers.c:
1975 (compare_option_strings_for_name),
1976 (modest_server_account_data_get_option_value),
1977 (modest_server_account_data_get_option_bool),
1978 (modest_account_mgr_get_server_account_option):
1979 Added helper functions for parsing the options GSList.
1981 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1983 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1984 display name is based on the supplied account name.
1985 * src/modest-account-mgr.c:
1986 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1987 with an inefficient, but good-enough, implementation.
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 (create_page_account_details), (on_before_next), (create_account):
1991 Check for existing display names rather than (non-user-visible) account names, and just
1992 create and set a unique account name at the end.
1994 * src/maemo/modest-account-settings-dialog.c:
1995 (modest_account_settings_dialog_init),
1996 (modest_account_settings_dialog_set_account_name),
1997 (create_page_incoming): Show the display name, instead of the account name.
1998 (on_response): Do some (not all) extra checks, as in the UI spec.
1999 (save_configuration): Save the display name if it was changed.
2001 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2003 * po/en_GB.po: Added needed logical ID and translation.
2004 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2005 (init_view): Made the is-default column clicking work.
2007 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2010 * src/maemo/easysetup/Makefile.am:
2011 * src/maemo/easysetup/modest-easysetup-wizard.c:
2012 (modest_easysetup_wizard_dialog_init):
2013 * src/maemo/easysetup/provider-data-test.keyfile:
2014 * src/maemo/easysetup/provider-data.keyfile:
2015 Moved the provider data file to the new modest-providers-data package and used it from there.
2017 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2019 * src/modest-local-folder-info.c:
2020 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2021 N_() was already used on the static strings, but this just marks it for translation without
2022 using the translation.
2024 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2026 * src/maemo/modest-account-settings-dialog.c:
2027 (create_page_incoming),
2028 (modest_account_settings_dialog_set_account_name):
2029 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2030 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2031 I will do this if nobody else gets there first.
2033 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2035 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2036 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2037 save the security stuff.
2039 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2041 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2042 Set the email address and user fullname, which I now see must be
2045 * src/maemo/modest-account-settings-dialog.h:
2046 * src/maemo/modest-account-settings-dialog.c:
2048 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2049 leave-on-server and authentication.
2050 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2053 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2056 * src/maemo/modest-account-settings-dialog.c:
2057 * src/maemo/modest-account-settings-dialog.h:
2058 Most (but not all) of the widgets are now present as specified by the UI spec.
2059 No changes are yet saved, and some details are not properly shown yet.
2061 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2063 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2065 * src/maemo/Makefile.am:
2066 * src/maemo/modest-account-settings-dialog.c:
2067 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2068 an existing account. Doesn't do much yet.
2070 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2071 Open the accounts settings dialog when Edit is clicked.
2073 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2075 * src/maemo/easysetup/Makefile.am:
2076 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2078 * src/maemo/easysetup/modest-easysetup-wizard.c:
2079 (modest_easysetup_wizard_dialog_init):
2080 Try to get the source directory from the build system,
2081 instead of hard-coding "./" into the source code, when opening our local
2082 copies of the configuration files.
2083 But this still fails when opening the wizard from the Accounts window,
2084 maybe because the working directory seems to change at runtime.
2085 So the wizard will fail the second time unless you copy the files into their
2086 proper locations - see the stdout warnings for the paths.
2088 (create_page_account_details),(on_before_next):
2089 Check for existing non-server accounts instead of server accounts,
2090 so the default account name is useful again, and to prevent trying to
2093 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2094 Show the wizard when New is clicked.
2096 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2097 (init_view): Show the column headers, and show the columns that are
2098 specified in the UI specs. However, something in Maemo's GTK+ prevents
2099 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2100 change the default account. This is despite unsetting the special properties.
2102 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2104 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2105 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2106 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2107 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2108 to make that clearer.
2109 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2111 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2113 * src/maemo/modest-account-view-window.c:
2114 (modest_account_view_window_init),
2115 (modest_account_view_window_new):
2116 Use the same buttons as specified in the
2117 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2118 the existing widgets, which never had a chance of working.
2119 Put the ModestAccountView treeview in a scrolled window.
2120 Do not repeat the initialization in both _init() and _new().
2122 * src/widgets/modest-account-view.c: (update_account_view):
2123 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2124 this widget and window shows no accounts.
2126 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2128 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2130 * src/maemo/easysetup/modest-easysetup-wizard.c:
2131 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2132 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2133 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2136 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2137 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2138 accounts exist yet, as in the UI spec.
2140 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2142 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/Makefile.am:
2145 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2146 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2147 New window for editing connection-specific smtp details.
2148 Not fully implemented.
2150 * src/maemo/modest-connection-specific-smtp-window.c:
2151 (modest_connection_specific_smtp_window_finalize) :
2152 unref the tree model.
2153 (on_button_edit): Show the edit window.
2155 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2157 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2160 * src/maemo/Makefile.am:
2161 * src/maemo/modest-connection-specific-smtp-window.c:
2162 * src/maemo/modest-connection-specific-smtp-window.h:
2163 New window for showing the list of connections, for connection-specific
2164 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2165 * src/maemo/easysetup/modest-easysetup-wizard.c:
2166 (create_page_custom_outgoing): Show the new window when the button is clicked.
2168 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2170 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2171 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2172 * src/maemo/modest-msg-edit-window.c:
2173 (modest_msg_edit_window_insert_image):
2174 * src/modest-conf.c: (modest_conf_key_escape):
2175 * src/modest-mail-operation.c:
2176 (modest_mail_operation_send_new_mail):
2177 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2178 (modest_ui_actions_on_new_account):
2179 * src/widgets/modest-attachment-view.c: (update_filename_request):
2180 * src/widgets/modest-mail-header-view.c:
2181 Corrected warnings that were breaking the build, by commenting out unused variables,
2182 and a function, and by including a header.
2184 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2186 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2187 so we can #ifdef around platform-specific code when necessary.
2188 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2189 to allow this to build for the GNOME platform too.
2191 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2193 * src/maemo/easysetup/modest-easysetup-wizard.c:
2194 Added util_increment_name() and used it in create_page_account_details()
2195 to make sure that the default account name is always a new name.
2197 (modest_easysetup_wizard_dialog_init),
2198 (set_default_custom_servernames): Some minor memory management fixes.
2200 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2204 * src/modest-runtime.c: (init_i18n): Restored the translation
2205 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2206 are defined in config.h, and the translations are installed.
2208 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2209 is defined for translation.
2211 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2213 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2215 * src/maemo/easysetup/modest-easysetup-wizard.c:
2216 (modest_easysetup_wizard_dialog_init):
2217 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2218 Use realistic paths (though they should use $prefix generically) to the
2219 mcc_mapping and provider-data.keyfile files which might work when they
2220 are installed by the future version of the operator-wizard package,
2221 and then fallback to paths in our source code, with an explanatory
2224 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2228 * src/maemo/Makefile.am:
2229 * src/maemo/easysetup/: Added files from the previously-exernal
2230 osso-modest-easysetup.
2231 * src/maemo/modest-main-window-ui.h:
2232 * src/modest-ui-actions.c:
2233 * src/modest-ui-actions.h:
2234 Added modest_ui_actions_on_new_account() as a signal handler for the
2235 New Account menu item. It shows the easysetup wizard.
2236 * po/en_GB.po: Added additional needed logical IDs and translations.
2238 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2239 Apparently ChangeLog is not used for some vague Nokia legal reasons.