1 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c: (on_account_changed):
4 Correct the signature of this signal handler.
6 2007-05-09 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
9 Show a HildonNote instead of a GtkDialog for Maemo.
11 2007-05-09 Murray Cumming <murrayc@murrayc.com>
13 * src/widgets/modest-account-view.h:
14 * src/widgets/modest-account-view.c: (on_account_changed),
15 (on_account_removed). Added a boolean flag, set/unset by
16 modest_account_view_block_conf_updates(),
17 modest_account_view_unblock_conf_updates() to prevent unnecessary
18 updates, but this is not very useful because the gconf notifications are
19 so delays (maybe only on Maemo Bora).
20 So auto-updating is turned off, and these functions do an explicit
21 update when necessary.
22 However, something else is still doing too much work when adding/removing
23 accounts, probably in another part of the application.
25 * src/maemo/modest-account-view-window.c:
26 (on_delete_button_clicked), (on_edit_button_clicked),
27 (on_new_button_clicked): Use the new functions.
29 2007-05-09 Murray Cumming <murrayc@murrayc.com>
31 * src/modest-account-mgr-helpers.c:
32 (modest_account_mgr_set_first_account_as_default):
33 Sort the list of names alphabetically-by-title, so we choose the first one
35 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
36 alphabetically by the title.
38 This fixes projects.maemo.org bug NB#56418 .
40 * src/modest-account-mgr-priv.c:
41 (_modest_account_mgr_account_from_key):
42 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
43 avoid a valgrind error, and possible random behaviour.
45 2007-05-09 Murray Cumming <murrayc@murrayc.com>
47 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
48 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
49 tinymail documentation to say that this can be expected.
50 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
51 pretty, and should not happen, but I would prefer to know when it does.
53 2007-05-09 Murray Cumming <murrayc@murrayc.com>
55 * configure.ac: When using the older hildon version, probably on Bora,
56 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
58 * src/widgets/modest-attachment-view.c:
59 (modest_attachment_view_set_part_default): Initialize variables, to fix the
62 2007-05-09 Marcus Bauer <marcusb@openismus.com>
64 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
65 Implemented the prototype. Can be tested with
66 tests/dbus_api/test_open_message:
68 2007-05-08 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account-store.c:
71 (modest_tny_account_store_instance_init), (get_password):
72 * src/modest-ui-actions.c:
73 (modest_ui_actions_on_password_requested):
74 Do not store the password in gconf, because this function is called
75 for non-remembered passwords. Actually use the cached (in the hash map)
76 password instead of releasing it.
77 The password will now not be remembered if it is asked via the protected
78 password dialog, as per the UI spec.
80 2007-05-08 Murray Cumming <murrayc@murrayc.com>
83 * src/modest-account-mgr-helpers.h:
84 * src/modest-account-mgr-helpers.c:
85 Added modest_server_account_get_username_has_succeeded(),
86 modest_server_account_set_username_has_succeeded().
87 (modest_server_account_set_username),
88 Reset the has-succeeded flag if the username changes.
90 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
91 * src/maemo/modest-connection-specific-smtp-window.c:
92 (modest_connection_specific_smtp_window_save_server_accounts):
93 Use modest_server_account_set_username() instead of using
94 modest_conf_set_string() directly, so that the has-succeeded flag is always
97 * src/modest-ui-actions.c:
98 (modest_ui_actions_on_password_requested): Dim the username entry if
99 the username has ever worked, as per the UI spec.
101 2007-05-08 Murray Cumming <murrayc@murrayc.com>
103 * src/modest-tny-account-store.c: (get_password):
104 * src/modest-ui-actions.c:
105 (modest_ui_actions_on_password_requested):
106 Allow the username to be changed too, though there is more work to
107 be done on exactly how this behaves.
109 2007-05-08 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-account-mgr-helpers.h:
112 * src/modest-account-mgr-helpers.c:
113 Added modest_account_mgr_get_display_name(),
114 modest_server_account_get_username(),
115 modest_server_account_set_username(),
116 modest_server_account_set_password(),
117 modest_server_account_get_hostname() functions so we do not need to
118 use the conf API directly.
120 * src/maemo/modest-main-window.c: (connect_signals):
121 Actually connect ot the ModestAccountStore::request-password signal,
122 so that we show the dialog when the password is requested by Tinymail,
123 for isntance if it is empty.
125 * src/modest-marshal.list:
126 * src/modest-tny-account-store.c:
127 (modest_tny_account_store_class_init), (get_password),
128 (modest_tny_account_store_alert):
129 * src/modest-tny-account-store.h:
130 * src/modest-ui-actions.h:
131 * src/modest-ui-actions.c:
132 (modest_ui_actions_on_password_requested):
133 Change the signal parameters, so it is obvious that we are providing
134 the non human-readable server name, and receiving both the username
135 and password, though changing of the username is not yet implemented.
136 Change the dialog UI to match the Maemo UI specifications, with #idfefing
137 for the GNOME version.
139 This should fix the projects.maemo.org bug NB#56209, though it does not
140 work on Bora, because the gconf_client_get() for the password fails
141 immediately after we save it with gconf_client_set().
143 2007-05-08 Murray Cumming <murrayc@murrayc.com>
146 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
147 caused an undefined symbol error:
148 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
150 2007-05-08 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account-store.c:
153 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
154 using a GError instead of a string message, so we can translate it in
157 2007-05-08 Murray Cumming <murrayc@murrayc.com>
159 * src/maemo/modest-address-book.c:
160 (modest_address_book_check_names):
161 * src/maemo/modest-msg-view-window.c:
162 (modest_msg_view_window_clipboard_owner_change):
163 * src/modest-init.c: (modest_init_init_ui):
164 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
165 (update_folders_cb), (modest_mail_operation_update_account):
166 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
167 (modest_ui_actions_on_msg_attachment_clicked),
168 (modest_ui_actions_on_msg_recpt_activated):
169 * src/widgets/modest-header-view.c: (drag_data_get_cb):
170 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
171 (modest_msg_view_search_next):
172 * src/widgets/modest-recpt-editor.c:
173 (modest_recpt_editor_on_button_release_event),
174 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
175 g_message(). At this point we should only be seeing interesting errors on
176 stdout. Debugging messages could be #ifdefed-out if they are still useful.
178 2007-05-07 Murray Cumming <murrayc@murrayc.com>
180 (modest_wizard_dialog_force_title_update):
181 * src/maemo/easysetup/modest-wizard-dialog.h:
182 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
183 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
184 can update the title when appropriate. Otherwise the title is wrong if the
185 pages are added after adding the notebook to the dialog.
186 This must be a problem in HildonWizardDialog too.
187 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
189 * src/maemo/easysetup/modest-easysetup-wizard.c:
190 (create_subsequent_customsetup_pages),
191 (create_subsequent_easysetup_pages):
192 Call modest_wizard_dialog_force_title_update() so that the title is
193 correct even with GTK+ < 2.10.
194 This fixes projects.maemo.org bug NB#56145 .
196 2007-05-07 Murray Cumming <murrayc@murrayc.com>
198 * src/maemo/modest-platform.c:
199 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
200 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
203 2007-05-07 Murray Cumming <murrayc@murrayc.com>
205 * src/widgets/modest-window.h:
206 * src/widgets/modest-window.c: Added a save_state_func vfunc,
207 and modest_window_save_state(), which invokes it.
209 * src/widgets/modest-window-mgr.h:
210 * src/widgets/modest-window-mgr.c:
211 Added modest_window_mgr_save_state_for_all_windows(), which calls
212 the save_state vfunc on all registered windows, if implemented.
214 * src/gnome/modest-msg-edit-window.c:
215 * src/gnome/modest-msg-view-window.c:
216 * src/maemo/modest-msg-edit-window.c:
217 * src/maemo/modest-msg-view-window.c:
218 * src/maemo/modest-main-window.c:
219 Specify the existing save_settings functions as implementations of
220 ModestWindow::save_state_func().
222 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
223 Call modest_window_mgr_save_state_for_all_windows(). This happens before
224 enabling hibernation, for instance.
226 We may need to do the same thing for restoring settings.
229 2007-05-07 Murray Cumming <murrayc@murrayc.com>
231 * src/widgets/modest-window-mgr.c:
232 * src/widgets/modest-window-mgr.h:
233 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
234 modest_window_mgr_get_hibernation_is_prevented().
236 * src/maemo/modest-main-window.c:
237 (on_hildon_program_is_topmost_notify): Prevent hibernation
238 (possible when the application goes to the background in the WM),
239 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
241 * src/maemo/easysetup/modest-easysetup-wizard.c:
242 (modest_easysetup_wizard_dialog_init):
243 * src/maemo/modest-account-settings-dialog.c:
244 (modest_account_settings_dialog_init):
245 * src/maemo/modest-connection-specific-smtp-edit-window.c:
246 (modest_connection_specific_smtp_edit_window_init):
247 * src/maemo/modest-connection-specific-smtp-window.c:
248 (modest_connection_specific_smtp_window_init):
249 * src/maemo/modest-signature-editor-dialog.c:
250 (modest_signature_editor_dialog_init):
251 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
252 prevent hibernation while any of these account settings dialogs are open.
254 2007-05-04 Murray Cumming <murrayc@murrayc.com>
256 * src/maemo/Makefile.am:
257 * src/maemo/modest-osso-state-saving.c:
258 * src/maemo/modest-osso-state-saving.h: Added
259 modest_osso_load_state() and modest_osso_save_state() though they do
260 nothing now. They should iterate through all the open windows and load/save
262 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
263 save state when closing.
265 * src/maemo/modest-main-window.c:
266 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
267 Add a notification handler for the HildonProgram::is-topmost property,
268 so we can allow hibernation when the application goes into the background.
269 But we still need to detect when the accounts setup windows are open so
270 we can stop hibernation when they are open.
271 To do this, I also added the main window the HildonProgram. This might have
272 other side-effects/benefits, and should maybe be done for other windows.
274 * src/maemo/modest-osso-autosave-callbacks.h:
275 * src/maemo/modest-osso-autosave-callbacks.c:
276 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
277 though it does not do anything yet, and we might never need this to do
278 anything. For instance, we already save drafts.
280 * src/maemo/modest-platform.c: (modest_platform_init):
281 Specify the libosso auto-save callback.
283 2007-05-03 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/modest-platform.c:
286 (modest_platform_set_update_interval):
287 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
288 aparently stays valid between application instances, so we can use this
289 to remove and reset it later. According to a maemo-developers email from
292 2007-05-03 Murray Cumming <murrayc@murrayc.com>
294 * configure.ac: Depend on libalarm for Maemo.
296 * src/dbus_api/modest-dbus-api.h:
297 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
298 (on_send_receive), (modest_dbus_req_handler):
299 Handle a SEND_RECEIVE D-Bus method.
301 * libmodest-dbus-client/libmodest-dbus-client.c:
302 (libmodest_dbus_client_send_and_receive):
303 * libmodest-dbus-client/libmodest-dbus-client.h:
304 Add C convenience functions for calling the new D-Bus method.
306 * src/modest-platform.h:
307 * src/gnome/modest-platform.c:
308 * src/maemo/modest-platform.c:
309 Added modest_platform_set_update_interval(), which uses the
311 (modest_platform_init),
312 Call modest_platform_set_update_interval(), using a hard-coded
313 interval for now (until the global settings dialog is implemented),
314 though I am not sure that this makes sense yet.
316 2007-05-02 Murray Cumming <murrayc@murrayc.com>
318 * src/dbus_api/modest-dbus-callbacks.c:
319 (modest_osso_cb_hw_state_handler):
320 * src/dbus_api/modest-dbus-callbacks.h:
321 * src/maemo/modest-platform.c: (modest_platform_init):
322 Registered (empty) callbacks for the osso hardware state D-Bus signals,
323 in case this has some effect on the ability for Maemo to ping the
326 2007-05-02 Murray Cumming <murrayc@murrayc.com>
328 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
329 Comment out an if() that checks a gchar for < 0, causing a build-breaking
330 warning. It is probably a logic error, but I need to fix the build.
332 2007-05-02 Murray Cumming <murrayc@murrayc.com>
334 * src/modest-account-mgr.h:
335 * src/modest-account-mgr.c:
336 (modest_account_mgr_account_names): Add a gboolean enabled_only
337 parameter, so we can get lists of onlt the enabled accounts.
339 (modest_account_mgr_add_account),,
340 (modest_account_mgr_account_with_display_name_exists):
341 * src/maemo/modest-msg-edit-window.c: (get_transports):
342 * src/modest-account-mgr-helpers.c:
343 (modest_account_mgr_set_first_account_as_default):
344 * src/modest-init.c: (init_default_account_maybe):
345 * src/modest-tny-account-store.c: (get_accounts):
346 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
347 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
348 * tests/check_account-mgr.c: (START_TEST):
349 Provide the extra parameter, as appropriate.
351 * src/widgets/modest-account-view.c: (update_account_view):
352 Do not show disabled accounts (meaning that there is no way to
353 enable/disable accounts in the UI (the feature is not in our UI
354 specification), so we can use this internally only to mark unfinished
355 or temporary account data.
357 * src/maemo/easysetup/modest-easysetup-wizard.c:
358 (create_account): Add boolean enable parameter, so we can specify FALSE
359 to create the temporary account.
360 (on_button_edit_advanced_settings): Create the temporary account as disabled.
361 (on_before_next): When finishing, when there is a temporary account, just
363 Also, use a timeout to delay the showing of the dialog until gconf is likely
364 to return correct information, due to a maemo gconf bug that is fixed in
365 osso 1.1, but not yet in Bora.
366 However, the dialog stays on screen after it is destroyed.
368 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
369 for invalid data when cancelling. Use a hildon note instead of a dialog
370 to complain about invalid data. Do not show the account-saved note if the
371 account is disabled (a temporary account that will not really be saved for use
374 2007-04-30 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-account-mgr-helpers.h:
377 * src/modest-account-mgr-helpers.c:
378 Added modest_account_mgr_unset_default_account(),
379 Added modest_account_mgr_set_first_account_as_default().
381 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
382 If it was the default account, unset the default account name.
384 * src/maemo/modest-account-view-window.c:
385 (on_delete_button_clicked): If it was the default account,
386 set the first remaining account as the default instead.
388 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
389 a NULL account or a NULL default account, to prevent a crash. This should
390 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
393 2007-04-30 Murray Cumming <murrayc@murrayc.com>
395 * src/widgets/modest-recpt-editor.c:
396 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
397 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
398 TODO comment for this. This fixes the build.
400 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
401 be the best place for it. This will in future update all auto-update accounts,
402 rather than just the current/default account, when that gconf key exists.
403 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
404 if there are no accounts, before calling do_send_receive().
405 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
407 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
408 * src/maemo/modest-main-window-ui.h:
409 * src/maemo/modest-main-window.c: (on_connection_changed),
410 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
411 directly, becaue the signal handler does more.
413 2007-04-30 Murray Cumming <murrayc@murrayc.com>
415 * src/modest-account-mgr-helpers.c:
416 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
417 for the case that the account does not exist.
419 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
420 (equivalent to the modest account name) rather than the tinymail account name
421 (equivalent to the modest account title - human readable) to get the account data.
422 Check for null account data to prevent the crash, and add a TODO comment saying that
423 this needs fixing because it is using the server account name instead of the account name.
425 2007-04-29 Murray Cumming <murrayc@murrayc.com>
427 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
428 * src/maemo/modest-account-settings-dialog.c: (show_error),
430 Use hildon_note_new_information() for informative and error messages,
431 which seems to be expected for Maemo applications (no documentation that I know of
432 says this). I am surprised that there is no distinction between info and error
435 2007-04-29 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
438 it is easy to find where this is used.
440 * src/maemo/easysetup/modest-easysetup-wizard.c:
441 (create_page_welcome), (create_page_account_details),
442 (create_page_user_details), (create_page_complete_easysetup),
443 (create_page_custom_incoming), (create_page_custom_outgoing),
444 (create_page_complete_custom):
445 * src/maemo/modest-account-settings-dialog.c:
446 (create_page_account_details), (create_page_user_details),
447 (create_page_incoming), (create_page_outgoing):
448 * src/maemo/modest-account-view-window.c: (window_vbox_new):
449 * src/maemo/modest-connection-specific-smtp-edit-window.c:
450 (modest_connection_specific_smtp_edit_window_init):
451 * src/maemo/modest-connection-specific-smtp-window.c:
452 (modest_connection_specific_smtp_window_init):
453 * src/maemo/modest-signature-editor-dialog.c:
454 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
455 and scrolling policy as per the Email Application Layout Guide, if I have
458 2007-04-27 Murray Cumming <murrayc@murrayc.com>
460 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
461 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
462 which were empty, because these vfuncs have been removed from TnyAccountStore.
463 This fixes the build.
465 2007-04-27 Murray Cumming <murrayc@murrayc.com>
467 * src/maemo/modest-main-window.c:
468 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
469 showing/hiding it. Added TODO because it probably should not be NULL.
470 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
471 because unnecessary g_warnings() make degugging difficult.
473 2007-04-27 Murray Cumming <murrayc@murrayc.com>
475 * src/maemo/modest-msg-edit-window.c:
476 (modest_msg_edit_window_select_color),
477 (modest_msg_edit_window_select_background_color): 2 const corrections and
478 moving 2 #endifs before closing brackets, to fix the build.
480 2007-04-27 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/easysetup/modest-easysetup-wizard.h:
483 * src/maemo/easysetup/modest-easysetup-wizard.c:
484 (modest_easysetup_wizard_dialog_finalize),
485 (on_button_edit_advanced_settings), (create_page_complete_custom),
486 (on_response), (create_account):
487 Implement the Advanced Settings edit button, by saving the account information,
488 for the Advanded Settings dialog to use directly from gconf, and removing it
489 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
490 Bug #5533 in the projects.maemo.org bugzilla.
492 2007-04-27 Murray Cumming <murrayc@murrayc.com>
494 * src/maemo/modest-msg-view-window.c:
495 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
496 when opening a message window.
498 2007-04-27 Murray Cumming <murrayc@murrayc.com>
500 * src/maemo/easysetup/modest-easysetup-wizard.c:
501 (create_page_custom_outgoing): Correct the position of the horizontal separator to
504 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
505 before showing/hiding them, to avoid a crash when clicking on folders when there are no
506 gconf settings. I probably added more checks than necessary, but that is safer.
508 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
509 variable to fix the build, but this seems to be used when it is still NULL.
511 2007-04-27 Murray Cumming <murrayc@murrayc.com>
513 * src/modest-platform.h:
514 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
515 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
516 * src/modest-main.c: Implement this function so we can avoid using
517 maemo-specific API from cross-platform code.
519 * src/modest-tny-account-store.c:
520 (get_smtp_specific_transport_account_for_open_connection):
521 * src/modest-ui-actions.c: (check_for_connection),
522 (modest_ui_actions_on_item_not_found):
523 Use modest_platform_connect_and_wait() and put #idefs around other
524 maemo-specific code, because only maemo currently has a way to
525 identify connection names.
527 2007-04-27 Murray Cumming <murrayc@murrayc.com>
529 * src/modest-tny-account-store.h:
530 * src/modest-tny-account-store.c:
531 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
532 the connection-specific SMTP server settings in the configuration.
534 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
536 * src/maemo/modest-main-window.c: (on_connection_changed),
538 * src/modest-main.c: (main), (start_ui), (send_mail):
539 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
540 that is what is intended.
542 * src/modest-ui-actions.c: (action_send), (action_receive),
543 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
544 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
545 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
546 SMTP server is used when it is specified.
548 (modest_ui_actions_on_send_receive):
549 Check that a connection is open before proceeding.
550 Receive and then send, instead of vice-versa, as per the specification.
552 2007-04-26 Murray Cumming <murrayc@murrayc.com>
554 * src/modest-mail-operation.c:
555 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
556 though I guess it should be something other than NULL.
558 2007-04-26 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/easysetup/modest-easysetup-wizard.c:
561 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
562 combo twice, to avoid an g_warning and to make it visible again.
563 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
564 attached before detaching it, to avoid a g_warning, and add comment about the implicit
565 (already intended) dereference when detaching, because we then recreate the menu.
566 But I am not sure why the warning was happening, and it is possible that this is a memory
569 2007-04-25 Murray Cumming <murrayc@murrayc.com>
571 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
572 and uri_parse_mailto() utility functions.
573 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
575 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
577 2007-04-24 Murray Cumming <murrayc@murrayc.com>
579 * src/dbus_api/modest-dbus-api.h:
580 * src/dbus_api/modest-dbus-callbacks.c:
581 Use an idle callback to execute the modest code in the application's own thread.
582 Remove the helloworld example method.
583 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
584 parsed, and the open-message method is not implemented because this is not yet implemented in
586 * libmodest-dbus-client/libmodest-dbus-client.c:
587 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
588 (libmodest_dbus_client_open_message):
589 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
591 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
592 body without crashing.
594 * tests/dbus_api/Makefile.am:
595 * tests/dbus_api/test_mail_to.c:
596 * tests/dbus_api/test_open_message.c: New tests for the new methods.
598 2007-04-24 Murray Cumming <murrayc@murrayc.com>
600 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
601 Added file to fix the build. Sorry.
603 * src/dbus_api/Makefile.am:
604 * src/dbus_api/modest-dbus-api.h:
605 * src/dbus_api/modest-dbus-callbacks.h:
606 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
607 (modest_dbus_req_handler):
608 Put constants in a separate header so it can be reused by the
609 client library, without duplication
611 * libmodest-dbus-client/Makefile.am:
612 * libmodest-dbus-client/libmodest-dbus-client.c:
613 (libmodest_dbus_client_call_helloworld),
614 (libmodfest_dbus_client_send_mail),
615 (libmodfest_dbus_client_mailto),
616 (libmodfest_dbus_client_open_message):
617 * libmodest-dbus-client/libmodest-dbus-client.h:
618 (Partly) Implement a send_mail D-Bus method.
620 * tests/dbus_api/Makefile.am:
621 * tests/dbus_api/test_send_mail.c: (main): Added a test for
622 the send_email D-Bus method.
624 2007-04-24 Murray Cumming <murrayc@murrayc.com>
628 * libmodest-dbus-client/Makefile.am:
629 * libmodest-dbus-client/libmodest-dbus-client.c:
630 * libmodest-dbus-client/libmodest-dbus-client.h:
631 * tests/dbus_api/Makefile.am:
632 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
633 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
635 2007-04-24 Murray Cumming <murrayc@murrayc.com>
637 * src/maemo/easysetup/modest-easysetup-wizard.c:
638 (create_page_account_details):
639 * src/maemo/modest-account-settings-dialog.c:
640 (create_page_account_details): Explicitly set auto-capitalization mode for the title
641 widgets, because this might not be the default in future versions of the Maemo GTK+.
642 However, I can not not get capitalization to work even in a simple test case.
644 2007-04-24 Murray Cumming <murrayc@murrayc.com>
646 * src/maemo/easysetup/modest-easysetup-wizard.c:
647 (create_page_custom_incoming), (create_page_custom_outgoing):
648 * src/maemo/modest-account-settings-dialog.c:
649 (create_page_account_details), (create_page_incoming),
650 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
651 instead of using gtk_check_button_with_label(), so they are aligned like the other
652 widgets, as per the UI spec.
654 2007-04-24 Murray Cumming <murrayc@murrayc.com>
656 * src/maemo/easysetup/modest-easysetup-wizard.c:
657 * src/maemo/modest-connection-specific-smtp-edit-window.c:
658 * src/widgets/modest-validating-entry.c:
659 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
660 Modest prefix instead of an EasySetup prefix.
662 2007-04-23 Murray Cumming <murrayc@murrayc.com>
664 * src/widgets/modest-validating-entry.h:
665 * src/widgets/modest-validating-entry.c: (on_insert_text),
666 Added easysetup_validating_entry_set_max_func(), used to set a callback
667 to call when the max number of characters is reached. GtkEntry has a max-length
668 already but is silent about it.
670 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
671 (create_page_account_details), (create_page_user_details),
673 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
674 (create_page_account_details), (create_page_user_details),
675 (create_page_outgoing):
676 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
677 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
678 the UI spec, when the user tries to enter more than the max number of characters.
680 2007-04-23 Murray Cumming <murrayc@murrayc.com>
682 * src/maemo/easysetup/modest-easysetup-wizard.c:
683 (create_page_user_details), (create_page_custom_incoming),
684 (create_page_custom_outgoing):
685 * src/maemo/modest-account-settings-dialog.c:
686 (create_page_user_details), (create_page_incoming),
687 (create_page_outgoing):
688 * src/maemo/modest-connection-specific-smtp-edit-window.c:
689 (modest_connection_specific_smtp_edit_window_init):
690 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
691 not appropriate. Bad Maemo-specific defaults!.
693 2007-04-23 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
696 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
697 (modest_signature_editor_dialog_set_settings):
698 Disable the label and textview when the checkbox is disabled, and use the
699 specified (UI spec) default signature text.
701 2007-04-23 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-connection-specific-smtp-edit-window.c:
704 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
707 * src/modest-account-mgr-helpers.h:
708 * src/modest-account-mgr-helpers.c:
709 Added modest_account_mgr_get/set_signature(), using new gconf keys.
711 * src/maemo/Makefile.am:
712 * src/maemo/modest-signature-editor-dialog.c:
713 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
716 * src/maemo/modest-account-settings-dialog.h:
717 * src/maemo/modest-account-settings-dialog.c:
718 (modest_account_settings_dialog_finalize), (on_button_signature),
719 (save_configuration): Use the new dialog when the Edit button is pressed, and
720 save the changes if necessary, as per the UI spec.
722 2007-04-23 Murray Cumming <murrayc@murrayc.com>
724 * src/maemo/Makefile.am:
725 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
726 based on maemo-develoers email from Dirk.
728 * src/maemo/easysetup/modest-easysetup-wizard.c:
729 (create_page_welcome), (create_page_account_details),
730 (create_page_user_details), (create_page_complete_easysetup),
731 (create_page_custom_incoming), (create_page_custom_outgoing),
732 (create_page_complete_custom),
733 (modest_easysetup_wizard_dialog_init):
734 * src/maemo/modest-account-settings-dialog.c:
735 (create_page_account_details), (create_page_user_details),
736 (create_page_incoming), (create_page_outgoing),
737 (modest_account_settings_dialog_init):
738 * src/maemo/modest-connection-specific-smtp-window.c:
739 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
741 2007-04-23 Murray Cumming <murrayc@murrayc.com>
743 * src/maemo/easysetup/modest-easysetup-wizard.c:
744 (create_page_account_details), (create_page_custom_outgoing),
745 (create_page_complete_custom):
746 * src/maemo/modest-account-settings-dialog.c:
747 (create_page_user_details), (create_page_incoming),
748 (create_page_outgoing):
749 * src/maemo/modest-connection-specific-smtp-edit-window.c:
750 (modest_connection_specific_smtp_edit_window_init):
751 Use the correct (UI spec) port min/max, and use horizontal separators,
754 2007-04-23 Murray Cumming <murrayc@murrayc.com>
756 * src/maemo/easysetup/modest-easysetup-wizard.c:
757 (set_default_custom_servernames):
758 * src/maemo/modest-account-settings-dialog.c:
759 (create_page_incoming), (on_combo_outgoing_security_changed),
760 (on_combo_incoming_security_changed), (create_page_outgoing),
761 (modest_account_settings_dialog_set_account_name),
762 (save_configuration):
763 * src/maemo/modest-connection-specific-smtp-edit-window.c:
764 (on_combo_security_changed),
765 (modest_connection_specific_smtp_edit_window_init),
766 (modest_connection_specific_smtp_edit_window_set_connection),
767 (modest_connection_specific_smtp_edit_window_get_settings):
768 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
771 2007-04-20 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/easysetup/modest-easysetup-wizard.c:
775 (create_page_custom_outgoing), (create_page_complete_custom):
776 * src/maemo/modest-account-settings-dialog.c:
777 (create_page_user_details), (create_page_outgoing):
778 * src/maemo/modest-account-view-window.c: (button_box_new):
779 Use changed logical IDs as per the most recent UI spec:
780 mcen_bd_emailsetup_edit -> mcen_bd_edit
781 mcen_bd_emailsetup_delete -> mcen_bd_delete
782 mcen_bd_emailsetup_close -> mcen_bd_close
784 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
788 * src/dbus_api/Makefile.am:
789 * src/dbus_api/modest-dbus-callbacks.c:
790 * src/dbus_api/modest-dbus-callbacks.h:
791 * src/maemo/modest-platform.c: (modest_platform_init):
792 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
795 * tests/dbus_api/Makefile.am:
796 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
798 2007-04-20 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-account-settings-dialog.c:
801 * src/maemo/modest-connection-specific-smtp-edit-window.c:
802 Removed unnecessary includes.
804 2007-04-20 Murray Cumming <murrayc@murrayc.com>
806 * src/maemo/easysetup/modest-easysetup-wizard.c:
807 * src/maemo/modest-account-settings-dialog.c:
808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
809 * src/widgets/Makefile.am:
810 * src/widgets/modest-easysetup-secureauth-combo-box.c:
811 * src/widgets/modest-easysetup-secureauth-combo-box.h:
812 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
813 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
814 * src/widgets/modest-secureauth-combo-box.c:
815 * src/widgets/modest-secureauth-combo-box.h:
816 * src/widgets/modest-serversecurity-combo-box.c:
817 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
818 made the GObject names more consistent with the rest of the Modest code.
820 2007-04-20 Murray Cumming <murrayc@murrayc.com>
822 * src/maemo/easysetup/Makefile.am:
823 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
824 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
825 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
826 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
827 * src/maemo/easysetup/modest-easysetup-wizard.c:
828 * src/maemo/easysetup/modest-validating-entry.c:
829 * src/maemo/easysetup/modest-validating-entry.h:
830 * src/maemo/modest-account-settings-dialog.c:
831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
832 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
833 widgets/ because they are used outside of easysetup too. After checking in,
834 svn will allow me to rename them too.
836 2007-04-20 Murray Cumming <murrayc@murrayc.com>
838 * src/gnome/modest-msg-edit-window.c:
839 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
840 linker error, to fix the build on the GNOME platform.
841 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
842 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
843 ifdefed out to avoid a warning.
845 2007-04-20 Murray Cumming <murrayc@murrayc.com>
847 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
848 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
849 some alternative for GTK+ 2.6.
851 2007-04-19 Murray Cumming <murrayc@murrayc.com>
853 * src/maemo/modest-address-book.c: Added include to avoid a warning.
855 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
856 specified for EmailAccountsDialog in UI spec.
858 * src/maemo/easysetup/modest-easysetup-wizard.c:
859 * src/maemo/easysetup/modest-easysetup-wizard.h:
860 * src/maemo/modest-account-settings-dialog.c:
861 * src/maemo/modest-account-settings-dialog.h:
862 Reuse a member window widget for the connection-specific SMTP server accounts,
863 so we can tell it to create/save the accounts only if we actually save changes.
865 * src/maemo/modest-connection-specific-smtp-edit-window.h:
866 * src/maemo/modest-connection-specific-smtp-edit-window.c:
867 (modest_connection_specific_smtp_edit_window_get_settings):
868 Return a struct instance for temporarily remembering the entered data.
870 * src/maemo/modest-connection-specific-smtp-window.h:
871 * src/maemo/modest-connection-specific-smtp-window.c:
872 (modest_connection_specific_smtp_window_finalize),
873 (modest_connection_specific_smtp_window_fill_with_connections),
875 (modest_connection_specific_smtp_window_save_server_accounts),
876 (update_model_server_names): Do not actually save data until asked,
877 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
879 (on_selection_changed),
880 (modest_connection_specific_smtp_window_init): Disable the edit
881 button when nothing is selected.
883 * src/modest-account-mgr-helpers.c:
884 * src/modest-account-mgr-helpers.h:
885 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
888 2007-04-19 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-account-mgr-helpers.h:
891 * src/modest-account-mgr-helpers.c:
892 (modest_account_mgr_get_unused_account_name),
893 (modest_account_mgr_get_unused_account_display_name): Added these
894 utility functions, to avoid code duplication.
896 * src/maemo/easysetup/modest-easysetup-wizard.c:
897 (create_page_account_details), (create_account):
898 * src/maemo/modest-connection-specific-smtp-edit-window.c:
899 (on_combo_security_changed),
900 (modest_connection_specific_smtp_edit_window_init),
901 (modest_connection_specific_smtp_edit_window_save_settings):
902 * src/maemo/modest-connection-specific-smtp-edit-window.h:
903 * src/maemo/modest-connection-specific-smtp-window.c:
904 (modest_connection_specific_smtp_window_finalize),
905 (modest_connection_specific_smtp_window_fill_with_connections),
906 (on_button_edit), (modest_connection_specific_smtp_window_init):
907 * src/maemo/modest-connection-specific-smtp-window.h:
908 Implementing saving of connection-specific server accounts.
910 But I need to refactor this so we can save the data for each
911 possible connection-specific account and only actually create the server accounts
912 when the easysetup finished, or the OK button is pressed on the account settings
915 2007-04-18 Murray Cumming <murrayc@murrayc.com>
917 * src/maemo/modest-connection-specific-smtp-edit-window.c:
918 (on_combo_security_changed):
919 (modest_connection_specific_smtp_edit_window_init):
920 Auto-fill the port number as in the account settings.
922 (modest_connection_specific_smtp_edit_window_set_connection):
923 * src/maemo/modest-connection-specific-smtp-edit-window.h:
924 * src/maemo/modest-connection-specific-smtp-window.c:
925 (fill_with_connections), (on_button_edit),
926 (modest_connection_specific_smtp_window_init):
927 Turn the edit window into a dialog to simplify the code, and
928 set a WM hint as in a GtkDialog, because only a popup can be on top of
929 another window in Maemo, and popups usually have no WM decoration.
932 * src/modest-account-mgr-helpers.c:
933 (modest_account_mgr_set_connection_specific_smtp),
934 (modest_account_mgr_remove_connection_specific_smtp),
935 (modest_account_mgr_get_connection_specific_smtp):
936 * src/modest-account-mgr-helpers.h: Some functions to write the
937 connection-specific SMTP server information. Not yet used.
940 * src/widgets/modest-folder-view.c: (text_cell_data):
941 Fix a warning about an uninitialized variable.
942 (on_configuration_key_changed): Put an #ifdef around the use
943 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
945 2007-04-18 Murray Cumming <murrayc@murrayc.com>
947 * src/maemo/modest-account-settings-dialog.h:
948 * src/maemo/modest-account-settings-dialog.c:
949 Added connect_for_modified() utility function to mark the new modified boolean.
951 (create_page_account_details), (create_page_user_details),
952 (create_page_incoming), (create_page_outgoing), (on_response),
953 (modest_account_settings_dialog_init),
954 (modest_account_settings_dialog_set_account_name):
955 Only warn about unsaved changes when there are actually unsaved changes.
957 * src/modest-account-mgr-helpers.c:
958 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
959 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
960 to get the data from there in future.
962 2007-04-18 Murray Cumming <murrayc@murrayc.com>
966 * src/modest-account-mgr-helpers.h:
967 * src/modest-account-mgr-helpers.c:
968 Store the security account setting in a single conf key instead of using
969 the options list, so that the list is left for just the to-be-removed camel hack,
970 and because gconf_client_set_list() is failing for some reason.
972 * src/modest-account-mgr.c:
973 (modest_account_mgr_add_server_account):
974 * src/maemo/modest-account-settings-dialog.c:
975 (modest_account_settings_dialog_set_account_name),
976 (save_configuration): Use the renamed functions.
979 2007-04-18 Murray Cumming <murrayc@murrayc.com>
981 * src/widgets/Makefile.am:
982 * src/widgets/modest-limit-retrieve-combo-box.c:
983 * src/widgets/modest-limit-retrieve-combo-box.h:
984 * src/widgets/modest-retrieve-combo-box.c:
985 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
986 the account settings dialog.
989 * src/modest-account-mgr-helpers.h:
990 * src/modest-account-mgr-helpers.c:
991 (modest_server_account_get_option_secure_auth),
992 (modest_server_account_set_option_secure_auth):
993 * src/modest-account-mgr.c:
994 (modest_account_mgr_add_server_account):
995 Use the existing AUTH_MECH conf key for the secure-auth setting,
996 instead of putting it in the list options, because this was actually used already.
998 * src/maemo/modest-account-settings-dialog.c:
999 (create_page_account_details),
1000 (modest_account_settings_dialog_set_account_name),
1001 (save_configuration):
1002 * src/maemo/modest-account-settings-dialog.h:
1003 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1004 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1006 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1008 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1009 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1010 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1012 * src/modest-defs.h:
1013 * src/maemo/modest-account-settings-dialog.c:
1014 (create_page_incoming), (on_combo_outgoing_security_changed),
1015 (on_combo_incoming_security_changed), (create_page_outgoing),
1016 (modest_account_settings_dialog_set_account_name),
1017 (save_configuration): Load/Save the port number, and change it when the
1018 security combo changes, to suitable defaults.
1020 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-account-mgr.c:
1023 (modest_account_mgr_add_server_account): Set the security and secure-auth
1024 options, and add a comment saying that the other camel-specific options should be
1027 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1029 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1031 * src/modest-tny-account-store.c: (account_list_free),
1032 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1033 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1036 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1038 * src/modest-protocol-info.c:
1039 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1040 is required by our UI spec. Maybe something in our implementation will use this eventually.
1041 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1042 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1043 instead of the previous 0 placeholder.
1045 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1046 secure-auth settings.
1047 * src/modest-account-mgr-helpers.h:
1048 * src/modest-account-mgr-helpers.c:
1049 (modest_server_account_data_get_option_secure_auth),
1050 (modest_server_account_set_option_secure_auth),
1051 (modest_server_account_data_get_option_security),
1052 (modest_server_account_set_option_security): Added this API for getting and setting the security
1053 and secure-auth settings.
1055 * src/maemo/modest-account-settings-dialog.h:
1056 * src/maemo/modest-account-settings-dialog.c:
1057 (modest_account_settings_dialog_finalize), (check_data),
1058 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1059 about changing titles.
1060 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1061 (save_configuration): Save the security and secure-auth settings.
1063 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1064 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1066 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1068 * src/modest-defs.h:
1069 * src/modest-account-mgr.c:
1070 (modest_account_mgr_add_server_account):
1071 Added and used defines for the options key and value pair strings,
1072 that are used so far, though they do not seem to correspond to anything in our
1073 UI specs or ModestProtocol enum.
1075 * src/modest-account-mgr-helpers.h:
1076 * src/modest-account-mgr-helpers.c:
1077 (compare_option_strings_for_name),
1078 (modest_server_account_data_get_option_value),
1079 (modest_server_account_data_get_option_bool),
1080 (modest_account_mgr_get_server_account_option):
1081 Added helper functions for parsing the options GSList.
1083 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1085 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1086 display name is based on the supplied account name.
1087 * src/modest-account-mgr.c:
1088 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1089 with an inefficient, but good-enough, implementation.
1091 * src/maemo/easysetup/modest-easysetup-wizard.c:
1092 (create_page_account_details), (on_before_next), (create_account):
1093 Check for existing display names rather than (non-user-visible) account names, and just
1094 create and set a unique account name at the end.
1096 * src/maemo/modest-account-settings-dialog.c:
1097 (modest_account_settings_dialog_init),
1098 (modest_account_settings_dialog_set_account_name),
1099 (create_page_incoming): Show the display name, instead of the account name.
1100 (on_response): Do some (not all) extra checks, as in the UI spec.
1101 (save_configuration): Save the display name if it was changed.
1103 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1105 * po/en_GB.po: Added needed logical ID and translation.
1106 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1107 (init_view): Made the is-default column clicking work.
1109 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/easysetup/Makefile.am:
1113 * src/maemo/easysetup/modest-easysetup-wizard.c:
1114 (modest_easysetup_wizard_dialog_init):
1115 * src/maemo/easysetup/provider-data-test.keyfile:
1116 * src/maemo/easysetup/provider-data.keyfile:
1117 Moved the provider data file to the new modest-providers-data package and used it from there.
1119 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1121 * src/modest-local-folder-info.c:
1122 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1123 N_() was already used on the static strings, but this just marks it for translation without
1124 using the translation.
1126 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1128 * src/maemo/modest-account-settings-dialog.c:
1129 (create_page_incoming),
1130 (modest_account_settings_dialog_set_account_name):
1131 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1132 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1133 I will do this if nobody else gets there first.
1135 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1137 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1138 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1139 save the security stuff.
1141 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1143 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1144 Set the email address and user fullname, which I now see must be
1147 * src/maemo/modest-account-settings-dialog.h:
1148 * src/maemo/modest-account-settings-dialog.c:
1150 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1151 leave-on-server and authentication.
1152 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1155 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1158 * src/maemo/modest-account-settings-dialog.c:
1159 * src/maemo/modest-account-settings-dialog.h:
1160 Most (but not all) of the widgets are now present as specified by the UI spec.
1161 No changes are yet saved, and some details are not properly shown yet.
1163 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1165 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1167 * src/maemo/Makefile.am:
1168 * src/maemo/modest-account-settings-dialog.c:
1169 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1170 an existing account. Doesn't do much yet.
1172 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1173 Open the accounts settings dialog when Edit is clicked.
1175 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1177 * src/maemo/easysetup/Makefile.am:
1178 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1180 * src/maemo/easysetup/modest-easysetup-wizard.c:
1181 (modest_easysetup_wizard_dialog_init):
1182 Try to get the source directory from the build system,
1183 instead of hard-coding "./" into the source code, when opening our local
1184 copies of the configuration files.
1185 But this still fails when opening the wizard from the Accounts window,
1186 maybe because the working directory seems to change at runtime.
1187 So the wizard will fail the second time unless you copy the files into their
1188 proper locations - see the stdout warnings for the paths.
1190 (create_page_account_details),(on_before_next):
1191 Check for existing non-server accounts instead of server accounts,
1192 so the default account name is useful again, and to prevent trying to
1195 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1196 Show the wizard when New is clicked.
1198 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1199 (init_view): Show the column headers, and show the columns that are
1200 specified in the UI specs. However, something in Maemo's GTK+ prevents
1201 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1202 change the default account. This is despite unsetting the special properties.
1204 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1206 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1207 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1208 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1209 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1210 to make that clearer.
1211 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1213 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1215 * src/maemo/modest-account-view-window.c:
1216 (modest_account_view_window_init),
1217 (modest_account_view_window_new):
1218 Use the same buttons as specified in the
1219 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1220 the existing widgets, which never had a chance of working.
1221 Put the ModestAccountView treeview in a scrolled window.
1222 Do not repeat the initialization in both _init() and _new().
1224 * src/widgets/modest-account-view.c: (update_account_view):
1225 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1226 this widget and window shows no accounts.
1228 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1230 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1232 * src/maemo/easysetup/modest-easysetup-wizard.c:
1233 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1234 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1235 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1238 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1239 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1240 accounts exist yet, as in the UI spec.
1242 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1244 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1246 * src/maemo/Makefile.am:
1247 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1248 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1249 New window for editing connection-specific smtp details.
1250 Not fully implemented.
1252 * src/maemo/modest-connection-specific-smtp-window.c:
1253 (modest_connection_specific_smtp_window_finalize) :
1254 unref the tree model.
1255 (on_button_edit): Show the edit window.
1257 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1259 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1262 * src/maemo/Makefile.am:
1263 * src/maemo/modest-connection-specific-smtp-window.c:
1264 * src/maemo/modest-connection-specific-smtp-window.h:
1265 New window for showing the list of connections, for connection-specific
1266 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1267 * src/maemo/easysetup/modest-easysetup-wizard.c:
1268 (create_page_custom_outgoing): Show the new window when the button is clicked.
1270 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1272 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1273 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1274 * src/maemo/modest-msg-edit-window.c:
1275 (modest_msg_edit_window_insert_image):
1276 * src/modest-conf.c: (modest_conf_key_escape):
1277 * src/modest-mail-operation.c:
1278 (modest_mail_operation_send_new_mail):
1279 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1280 (modest_ui_actions_on_new_account):
1281 * src/widgets/modest-attachment-view.c: (update_filename_request):
1282 * src/widgets/modest-mail-header-view.c:
1283 Corrected warnings that were breaking the build, by commenting out unused variables,
1284 and a function, and by including a header.
1286 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1288 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1289 so we can #ifdef around platform-specific code when necessary.
1290 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1291 to allow this to build for the GNOME platform too.
1293 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1295 * src/maemo/easysetup/modest-easysetup-wizard.c:
1296 Added util_increment_name() and used it in create_page_account_details()
1297 to make sure that the default account name is always a new name.
1299 (modest_easysetup_wizard_dialog_init),
1300 (set_default_custom_servernames): Some minor memory management fixes.
1302 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1306 * src/modest-runtime.c: (init_i18n): Restored the translation
1307 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1308 are defined in config.h, and the translations are installed.
1310 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1311 is defined for translation.
1313 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1315 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1317 * src/maemo/easysetup/modest-easysetup-wizard.c:
1318 (modest_easysetup_wizard_dialog_init):
1319 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1320 Use realistic paths (though they should use $prefix generically) to the
1321 mcc_mapping and provider-data.keyfile files which might work when they
1322 are installed by the future version of the operator-wizard package,
1323 and then fallback to paths in our source code, with an explanatory
1326 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1330 * src/maemo/Makefile.am:
1331 * src/maemo/easysetup/: Added files from the previously-exernal
1332 osso-modest-easysetup.
1333 * src/maemo/modest-main-window-ui.h:
1334 * src/modest-ui-actions.c:
1335 * src/modest-ui-actions.h:
1336 Added modest_ui_actions_on_new_account() as a signal handler for the
1337 New Account menu item. It shows the easysetup wizard.
1338 * po/en_GB.po: Added additional needed logical IDs and translations.
1340 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1341 Apparently ChangeLog is not used for some vague Nokia legal reasons.