1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-presets.c:
4 (modest_presets_get_info_server_security): Correct the key name for
5 SecureSmtp, because it seems to be case-sensitive.
6 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
7 Do not try to get the 0th notebook page if there are 0 pages, to
10 2007-06-11 Murray Cumming <murrayc@murrayc.com>
12 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
13 Prevent use of the new notification feature for now, because it currently
14 shows one dialog for each new email, which is annoying.
16 2007-06-11 Murray Cumming <murrayc@murrayc.com>
18 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
19 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
20 when no country was selected, so that we show the global ones.
21 * src/maemo/easysetup/modest-presets.c:
22 (modest_presets_get_providers): Return only the global providers, not
23 all providers when mmc=0 was requested.
25 2007-06-11 Murray Cumming <murrayc@murrayc.com>
27 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
28 (easysetup_provider_combo_box_fill): Remove debug code that showed the
29 provider ID in the combo.
31 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
32 Do not show the page numbers, because it would be confusing when we add
33 the 2 extra pages for the custom setup, when the user chooses the "Other"
34 provider. This fixes projects.maemo.org bug NB#59028
36 * src/modest-init.c: (modest_init_init_core),
37 (modest_init_local_folders):
39 * src/modest-tny-account.c:
40 (modest_tny_account_new_for_local_folders): Do not create default folders
41 for the memory card. This should fix projects.maemo.org bug NB#59328.
43 2007-06-11 Murray Cumming <murrayc@murrayc.com>
45 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
46 Free the changed_conf_keys string items. They are already freed in the
47 idle handler if that runs first.
49 2007-06-11 Murray Cumming <murrayc@murrayc.com>
51 * src/modest-ui-actions.c:
52 (modest_ui_actions_on_password_requested): Check that the server name
53 is not NULL, because I just saw a password dialog with (null) as the
56 * src/modest-tny-folder.[h|c]: Added
57 modest_tny_folder_is_memory_card_folder().
58 * src/modest-ui-dimming-rules.c:
59 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
60 menu item for memory cards, as per the UI spec (section 7.4). This should
61 fix projects.maemo.org bug NB#59297.
63 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
65 * src/maemo/modest-main-window.c: (sync_accounts_cb):
66 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
67 is another problem with the code, see Murray's comment at line 772)
69 2007-06-08 Murray Cumming <murrayc@murrayc.com>
71 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
72 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
73 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
74 (load_from_file), (easysetup_country_combo_box_init),
75 (easysetup_country_combo_box_get_active_country_ids),
76 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
77 instead of just one ID, to avoid duplicate country names in the UI.
79 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
80 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
81 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
82 a single ID, avoiding duplicate providers.
83 * src/maemo/easysetup/modest-easysetup-wizard.c:
84 (on_combo_account_country): Adapt to use a list.
86 2007-06-08 Murray Cumming <murrayc@murrayc.com>
88 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
89 keys changed in the last X seconds.
91 * src/modest-account-mgr.h:
92 * src/modest-account-mgr.c: (on_timeout_notify_changes),
93 (on_key_change), (modest_account_mgr_class_init),
94 (modest_account_mgr_init), (modest_account_mgr_finalize):
95 As the keys are changed, save them in a GSList* and signal that GSList*
96 further every X seconds, to batch changes, to allow us to do just one
97 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
98 bug NB#56941 and other (UI-blocking) delays when changing account settings.
100 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
101 changed signal signature.
103 * src/modest-conf.c: (modest_conf_set_list),
104 (modest_conf_on_change): Reenable notification.
106 (modest_conf_maemo_fake_on_change): Comment out the hack that
107 notified immediately instead of asynchronously.
109 * src/widgets/modest-account-view.h:
110 * src/widgets/modest-account-view.c:
111 (update_account_view): Select the previously-selected account ID,
112 if possible. This fixes projects.maemo.org bug NB#56933.
114 (on_account_changed), (on_account_removed),
115 (modest_account_view_select_account):
117 Remove the block/unblock functions
118 because they were not useful.
120 * src/maemo/modest-account-view-window.c:
121 (on_delete_button_clicked), (on_edit_button_clicked),
122 (on_new_button_clicked): Remove the use of the non-working block/unblock.
124 2007-06-08 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
127 Improve the error dialog to show Incorrect Account Settings, which seems
128 clearer, and say that the internal error message (to be removed from the
129 dialog later) is often misleading.
130 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
132 * src/modest-tny-account.c:
133 (modest_tny_account_new_from_server_account): Uncomment the printf of the
134 URL because this is so useful for debugging on the device.
136 * src/widgets/modest-serversecurity-combo-box.c:
137 (modest_serversecurity_combo_box_fill): Correct a logical ID.
139 2007-06-08 Murray Cumming <murrayc@murrayc.com>
141 * src/modest-mail-operation.c:
142 (modest_mail_operation_send_new_mail):
143 Added a comment about a nasty but apparently harmless message. Details
144 added to the wiki g_warnings() page.
146 2007-06-08 Murray Cumming <murrayc@murrayc.com>
148 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
149 (modest_tny_send_queue_class_init):
150 Do not use the priv struct because it is empty, to avoid g_warnings
151 about a non-existant priv struct.
153 * src/modest-tny-account-store.c:
154 (modest_tny_account_store_get_server_account),
155 (modest_tny_account_store_get_transport_account_for_open_connection
156 ): Do not try to get transport server accounts for local folders,
157 because they don't have any. This avoids a g_warning().
159 * src/maemo/modest-main-window.c:
160 (modest_main_window_notify_send_receive_initied),
161 (on_configuration_key_changed):
162 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
164 * src/modest-mail-operation.c:
165 (modest_mail_operation_update_account):
166 * src/modest-tny-account-store.h:
167 * src/modest-tny-account.c:
168 (modest_tny_account_get_special_folder),
169 (modest_tny_account_new_for_local_folders),
170 (modest_tny_account_new_for_per_account_local_outbox_folder):
171 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
172 * src/modest-tny-local-folders-account.c:
173 (add_account_folders_to_merged_folder):
174 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
175 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
176 (modest_ui_actions_on_send):
177 * src/widgets/modest-folder-view.c: (update_model):
178 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
179 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
180 modest_tny_account_store_get_tny_account_by_account() to
181 modest_tny_account_store_get_server_account() to make the code clearer.
183 2007-06-07 Marcus Bauer <marcusb@openismus.com>
185 * src/dbus_api/modest-dbus-api.h:
186 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
187 * src/maemo/modest-msg-edit-window.c:
188 (modest_msg_edit_window_attach_file_noninteractive):
189 added g_warning in case the file to be attached does not exist
190 * tests/dbus_api/test_compose_mail.c: (main):
191 removed obsolete comment, added generic files as test case
193 2007-06-07 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-tny-account-store.c: (get_server_accounts):
196 Create the local folders account only once, not once for each outbox, and
197 not only when there are some outboxes.
199 2007-06-07 Murray Cumming <murrayc@murrayc.com>
201 * src/widgets/modest-folder-view.c: (update_model): Comment out some
202 code that is causing a crash at startup. Sergio says that he is fixing this.
204 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
206 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
207 * src/maemo/modest-account-settings-dialog.c:
208 (create_page_outgoing),
209 (modest_account_settings_dialog_set_account_name),
210 (save_configuration):
211 - Fixed handling of the "Use secure authentication" toggle to comply with
212 the ui specification. See also projects.maemo.org bug NB#58400
214 - Restore the Secure connection setting combo correctly when loading
217 * src/maemo/modest-maemo-utils.c:
218 (on_camel_account_get_supported_secure_authentication),
219 (modest_maemo_utils_get_supported_secure_authentication_methods):
220 Fixed a crasher if operation is canceled
222 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
223 (modest_protocol_info_auth_is_secure):
224 * src/modest-protocol-info.h:
226 Added two new methods to determine if a protocol/auth method is secure/encrypted in
227 the sense of the "Use secure authentication" toggle.
229 2007-06-07 Murray Cumming <murrayc@murrayc.com>
231 * src/modest-tny-account-store.h:
232 * src/modest-tny-account-store.c:
233 Added modest_tny_account_store_get_local_folders_account().
235 * src/modest-tny-folder.h:
236 * src/modest-tny-folder.c:
237 (modest_tny_folder_get_account):
238 Added this replacement for tny_folder_get_account() which returns
239 the local-folders account for TnyMergeFolders, to avoid the
240 warning about the unimplemented get_account_func() vfunc().
242 (modest_tny_folder_get_rules),
243 * src/modest-ui-actions.c:
244 (modest_ui_actions_on_folder_selection_changed):
245 * src/modest-mail-operation.c:
246 (modest_mail_operation_remove_folder),
247 (modest_mail_operation_xfer_folder),
248 (modest_mail_operation_rename_folder),
249 (modest_mail_operation_get_msg),
250 (modest_mail_operation_get_msgs_full),
251 (modest_mail_operation_remove_msg),
252 (modest_mail_operation_xfer_msgs),
253 (modest_mail_operation_refresh_folder):
254 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
256 2007-06-07 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
259 (modest_server_account_set_security):
260 * src/modest-defs.h: Add comments explaining that our
261 UI spec means TLS when it says Normal, so these do not look like errors.
263 * src/modest-tny-account.c:
264 (modest_tny_account_new_from_server_account): Use the new tinymail
265 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
266 for TLS. This should fix projects.maemo.org bug NB#58460.
268 2007-06-06 Murray Cumming <murrayc@murrayc.com>
270 * src/maemo/easysetup/modest-easysetup-wizard.c:
271 (create_account): Correct the position of the gconf sanity check warning.
272 (on_button_edit_advanced_settings): Show the dialog immediately, instead
273 of using the g_idle_add() hack, because this does not seem to be necessary
274 on osso 1.1. It might even work on Maemo Bora if the problems were actually
275 caused by something other than maemo's gconf.
276 This fixes projects.maemo.org bug #59022.
278 2007-06-06 Murray Cumming <murrayc@murrayc.com>
280 * src/modest-account-mgr-helpers.c:
281 (modest_account_mgr_get_default_account): Do not check that the account
282 exists if there is no default account (NULL), to fix a runtime warning.
284 2007-06-06 Murray Cumming <murrayc@murrayc.com>
286 * src/widgets/modest-folder-view.c: (update_model):
287 Do not unref the treemodel before we have finished with it.
288 This prevents a valgrind warning and an occasional crash at startup.
290 2007-06-06 Marcus Bauer <marcusb@openismus.com>
292 * libmodest-dbus-client/libmodest-dbus-client.h:
293 added libmodest_dbus_client_compose_mail()
294 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
296 added functions needed for SendAsMail() functionality
297 * src/maemo/modest-msg-edit-window.c:
298 (modest_msg_edit_window_attach_file_noninteractive):
299 non interactively attaching files to message edit window
300 * src/widgets/modest-msg-edit-window.h:
301 * tests/dbus_api/Makefile.am:
302 added test_compose_mail.c
303 * tests/dbus_api/test_compose_mail.c: (main):
305 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
307 * src/modest-account-view.c:
308 Fixed bug projects.maemo.org bug NB#59307
310 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
312 * src/maemo/easysetup/modest-easysetup-wizard.c:
313 (get_serverport_incoming), (on_before_next), (create_account):
314 * src/maemo/modest-account-settings-dialog.c:
315 (modest_account_settings_dialog_set_account_name):
316 * src/maemo/modest-maemo-utils.c:
317 (on_camel_account_get_supported_secure_authentication_status),
318 (on_camel_account_get_supported_secure_authentication),
319 (on_secure_auth_cancel),
320 (modest_maemo_utils_get_supported_secure_authentication_methods):
322 Implemented security authentication for settings and easysetup.
324 2007-06-05 Murray Cumming <murrayc@murrayc.com>
326 * src/maemo/modest-main-window.c: (create_details_widget):
327 Show the total size for memory card accounts too, instead of showing
328 the name again. Fixes bug projects.maemo.org bug NB#59307.
330 2007-06-05 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-simple-folder-store.c:
334 * src/modest-tny-simple-folder-store.h: Removed.
336 * src/modest-tny-local-folders-account.h
337 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
338 for the local-folders maildir, with an extra TnyMergedFolder containing
339 the folders of the per-account outbox store accounts.
340 * src/modest-tny-account-store.c: (get_server_accounts):
341 Add the outboxes to the special local folders account after creating it.
343 * src/modest-tny-account.c:
344 (modest_tny_account_new_for_local_folders): Create the derived
345 account when creating the main local-folders account.
347 * src/maemo/modest-main-window.c: (create_details_widget),
348 (modest_main_window_set_contents_style):
349 Adapted to the use of the derived account instead of the folder store.
351 * src/modest-ui-actions.c:
352 (modest_ui_actions_on_folder_selection_changed):
353 * src/modest-ui-dimming-rules.c:
354 (modest_ui_dimming_rules_on_new_folder):
355 * src/widgets/modest-folder-view.c: (text_cell_data),
356 (icon_cell_data), (filter_row), (update_model),
357 (get_cmp_rows_type_pos):
360 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
361 Do not get the priv struct, because no priv struct has been set,
362 to avoid a runtime warning.
364 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
365 #ifelse with #else, to fix a warning, to fix the build.
368 2007-06-05 Christian Kellner <ckellner@openismus.com>
370 * libmodest-dbus-client/libmodest-dbus-client.c:
371 Fix small typo in doc (why do you always see them
372 AFTER committing stuff?)
375 2007-06-05 Christian Kellner <ckellner@openismus.com>
377 * libmodest-dbus-client/libmodest-dbus-client.c:
378 (libmodest_dbus_client_search):
379 Initialize hit list with NULL. Also set folder list
380 to "" if NULL was supplied.
383 2007-06-03 Christian Kellner <ckellner@openismus.com>
385 * libmodest-dbus-client/libmodest-dbus-client.c:
386 (modest_search_hit_list_free):
387 Make it save to call it with NULL.
389 * src/dbus_api/modest-dbus-callbacks.c:
390 * src/modest-search.c:
391 Return full ModestSearchHits as the search result list not TnyHeader
392 since can't be around withouth the correspoding TnyFolder.
394 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
396 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
397 Added currently commented code to check for secure auth
399 * src/maemo/modest-account-settings-dialog.c: (on_response),
400 (save_configuration), (show_ok):
401 Fixed projects.maemo.org bugs NB #59248 and #59251
403 * src/maemo/modest-maemo-utils.c:
404 (on_camel_account_get_supported_secure_authentication_status),
405 (on_camel_account_get_supported_secure_authentication),
406 (modest_maemo_utils_get_supported_secure_authentication_methods):
407 * src/maemo/modest-maemo-utils.h:
408 Moved get_supported_secure_authentication() method here to be able
409 to use it from easysetup wizard.
411 * src/modest-pair.c: (on_pair_compare_as_string):
412 Should compare string with first part of pair and not
413 strcmp pairs which will crash.
415 * src/modest-protocol-info.c:
416 (modest_protocol_info_protocol_is_store):
417 * src/modest-protocol-info.h:
418 Added modest_protocol_info_get_auth_protocol_name()
420 2007-06-03 Armin Burgmeier <armin@openismus.com>
422 * src/modest-mail-operation.c:
423 (modest_mail_operation_get_msgs_full): Set priv->account also when
424 only retrieving a single message. This avoids a crash when canceling
427 (modest_mail_operation_notify_end): Do not explicitely remove the
428 operation from the queue but only emit the progress_changed signal.
429 The queue itself listens to that signal to remove the operation when
430 it is finished. This reduces coupling and removes a potential deadlock
431 when modest_mail_operation_notify_end() is called from the queue
432 itself. If that is a problem performance-wise, I would suggest to
433 implement a status-changed signal or something.
435 * src/modest-mail-operation-queue.c: Make sure to never call a
436 function from another file while the queue is locked. This (hopefully)
437 fixes another deadlock when exiting the application while retrieving
440 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
442 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
443 Fixed build if libogs is not available
445 2007-06-03 Christian Kellner <ckellner@openismus.com>
447 * libmodest-dbus-client/libmodest-dbus-client.h:
448 * libmodest-dbus-client/libmodest-dbus-client.c:
449 (libmodest_dbus_client_delete_message):
450 Implement deletion of messages (Client side).
452 (modest_search_hit_free),
453 (modest_search_hit_list_free):
454 Utility functions to free the result hits.
456 * src/dbus_api/modest-dbus-api.h:
457 * src/dbus_api/modest-dbus-callbacks.c:
459 (modest_dbus_req_handler):
460 Implement deletion of messages (Server side).
462 * tests/dbus_api/test_search.c: (main):
465 * tests/dbus_api/Makefile.am:
466 * tests/dbus_api/test_delete_message:
467 Add little test for the message deletion logic
469 2007-06-03 Armin Burgmeier <armin@openismus.com>
471 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
472 when the operation queue was not empty. projects.maemo.org bug
475 2007-06-03 Armin Burgmeier <armin@openismus.com>
477 * src/widgets/modest-account-view.c
478 (on_account_default_toggled): Toggle default account column
479 explicitely instead of waiting for gconf notification (which is
480 currently ignored). This should fix projects.maemo.org bug NB#56910
481 for now. It should probably be removed when gconf notifications are
484 2007-06-03 Christian Kellner <ckellner@openismus.com>
486 * libmodest-dbus-client/libmodest-dbus-client.c:
487 Removed debugging spew.
489 * src/dbus_api/modest-dbus-callbacks.c:
490 Added debugging info.
492 * src/modest-search.c:
493 (modest_search_all_accounts):
494 Use tny_account_store_get_accounts () on the account store
495 to get all accounts which is the way to get all accounts.
497 * tests/dbus_api/test_search.c: (main):
498 Make it possible to supply the search term on the command line.
500 2007-06-03 Christian Kellner <ckellner@openismus.com>
502 * libmodest-dbus-client/libmodest-dbus-client.c:
503 * libmodest-dbus-client/libmodest-dbus-client.h:
504 Implement searching for mesages over raw dbus. (Client side)
506 * src/dbus_api/Makefile.am:
507 * src/dbus_api/modest-dbus-api.h:
508 * src/dbus_api/modest-dbus-callbacks.c:
509 * src/dbus_api/modest-dbus-callbacks.h:
510 Search framework (Server side). Also implement on_idle_open_message().
512 * src/maemo/modest-platform.c: (modest_platform_init):
513 Prepare for raw dbus/osso rpc interaction.
515 * src/modest-search.h:
516 Changed minsize from unspecific guint to guint32.
518 * src/modest-search.c:
520 Added strange hack which magically made tnymail work.
522 (modest_search_folder),
523 (modest_search_account),
524 (modest_search_all_accounts):
525 Implement helper functions to search all accounts, specific account
528 * tests/dbus_api/Makefile.am:
529 * tests/dbus_api/test_open_message.c:
530 Read url to open from commandline.
532 * tests/dbus_api/test_search.c:
533 Implement small test for dbus search stuff
535 2007-06-02 Armin Burgmeier <armin@openismus.com>
537 * src/maemo/modest-account-settings-dialog.c: Changed window title to
538 include account type and account title. This fixes projects.maemo.org
541 * src/maemo/modest-account-view-window.c: Set a title for the window.
543 2007-06-02 Armin Burgmeier <armin@openismus.com>
545 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
546 incoming and outgoing server name based on email address and server
547 types as long as the names have not been edited manually. This fixes
548 projects.maemo.org bug NB#58671.
550 2007-06-02 Armin Burgmeier <armin@openismus.com>
552 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
553 server type cannot be changed in future to the incoming details page
554 when creating an account. This fixes projects.maemo.org bug NB#59029.
556 2007-06-02 Armin Burgmeier <armin@openismus.com>
558 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
559 and assigned max width chars so that they wrap instead of being
560 truncated. Fixes projects.maemo.org bug NB#56126.
562 2007-06-02 Armin Burgmeier <armin@openismus.com>
564 * src/maemo/modest-connection-specific-smtp-window.c: Add an
565 introductory note to the connection specific smtp servers dialog, as
566 section 8.12 of the email UI specification requires. This fixes
567 projects.maemo.org bug NB#59212.
569 2007-06-01 Murray Cumming <murrayc@murrayc.com>
571 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
572 Check for running mail operations, and offer to cancel them, as per the UI
573 spec. This fixes projects.maemo.org bug NB#59041 .
574 However, I suspect that tinymail may still use the network connection
575 in ways that we cannot detect or cancel. But it should at least adapt to
578 2007-06-01 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-tny-account-store.c: (recreate_all_accounts),
581 (get_cached_accounts), (get_server_accounts): Do more sensible
582 ref-counting of the temporarily-cached outbox accounts list. This seems
583 to fix a crash when entering the password when the password was wrong.
585 2007-06-01 Murray Cumming <murrayc@murrayc.com>
587 * src/gnome/modest-main-window.c: (connect_signals):
588 * src/modest-tny-account-store.c: (get_password),
589 (modest_tny_account_store_alert): Added comments and clues and
590 commented-out code about how we currently fail to deal with connection
591 errors and wrong passwords, and how we should.
593 2007-06-01 Murray Cumming <murrayc@murrayc.com>
595 * src/widgets/modest-retrieve-combo-box.c:
596 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
597 This fixes projects.maemo.org bug NB#58472 .
599 2007-06-01 Murray Cumming <murrayc@murrayc.com>
601 * src/maemo/easysetup/modest-easysetup-wizard.c:
602 (create_page_complete_easysetup):
603 (create_page_complete_custom): Correct the last commit,
604 putting the correct sentences in the correct pages.
606 2007-06-01 Murray Cumming <murrayc@murrayc.com>
608 * src/maemo/easysetup/modest-easysetup-wizard.c:
609 (create_page_complete_custom): Show the second sentence of text
610 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
613 2007-06-01 Murray Cumming <murrayc@murrayc.com>
615 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
616 Set the leave-on-server conf key by default. This fixes
617 projects.maemo.org bug NB#59258 .
619 2007-06-01 Murray Cumming <murrayc@murrayc.com>
621 * src/maemo/modest-account-view-window.c:
622 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
623 logical ID for the confirmation messages. Fixed projects.maemo.org bug
626 2007-06-01 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/easysetup/modest-easysetup-wizard.c:
629 (create_caption_new_with_asterisk):
630 * src/maemo/modest-account-settings-dialog.c:
631 (create_caption_new_with_asterisk):
632 Uncomment the code to add the asterisk, because they are no longer in the
633 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
634 (update_incoming_server_title): Add an asterisk here too.
636 2007-06-01 Murray Cumming <murrayc@murrayc.com>
638 * src/maemo/modest-maemo-global-settings-dialog.c:
639 (current_connection): Check that we are even connected before trying to
640 get the current connection name, to prevent a warning.
642 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
643 Change the comments because tny_maemo_conic_device_connect() is now meant to
645 * src/modest-mail-operation.c:
646 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
647 make sure we have a connection and fail if we can't connect.
649 2007-05-31 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-main-window.c:
652 (on_account_store_connecting_finished): Do not try to get the
653 connection ID if we are not really connected. I am surprised that
654 this signal handler is called when we are not connected.
656 2007-05-31 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-error.h:
659 * src/modest-ui-actions.c:
660 (modest_ui_actions_get_msgs_full_error_handler):
661 Renamed an enum, added comments, added an enum
662 for retrieve-limit errors.
664 * src/modest-mail-operation.c: (foreach_add_item),
665 (internal_folder_observer_update), (update_account_thread),
666 (modest_mail_operation_get_msgs_full):
667 (modest_mail_operation_update_account),
668 Added comments about how this works, and some code that should
669 (but does not) check the retrieve-limit. See the TODO comment.
671 2007-05-31 Murray Cumming <murrayc@murrayc.com>
673 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
674 Initialize help_id to fix the build. Warnings are good.
676 2007-05-31 Murray Cumming <murrayc@murrayc.com>
678 * src/widgets/modest-hbox-cell-renderer.c:
679 (modest_hbox_cell_renderer_append):
680 * src/widgets/modest-vbox-cell-renderer.c:
681 (modest_vbox_cell_renderer_append):
682 Fix the last commit by doing an extra ref.
684 2007-05-31 Murray Cumming <murrayc@murrayc.com>
686 * src/widgets/modest-hbox-cell-renderer.c:
687 (modest_hbox_cell_renderer_append):
688 * src/widgets/modest-vbox-cell-renderer.c:
689 (modest_vbox_cell_renderer_append):
690 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
691 to fix the build with Maemo Bora.
692 However, there seems to be a remaining crash, probably due to reference
695 2007-05-30 Murray Cumming <murrayc@murrayc.com>
697 * src/modest-tny-account.c:
698 (modest_tny_account_new_for_local_folders):
699 Use hildon_file_system_info_async_new() to get a better name for
700 the memory card account, setting it as the account name.
701 The timing seems to work, but this is probably
702 not the best place to do this. See the TODO comment.
703 * src/maemo/modest-main-window.c: (create_details_widget):
704 * src/widgets/modest-folder-view.c: (text_cell_data):
705 Use the tny account name instead of hardcoding a name.
707 2007-05-30 Christian Kellner <ckellner@openismus.com>
709 * src/modest-search.c: (modest_search):
710 Correctly set part_search_func even if we have already parsed
711 the query and thus a valid OgsTextSearcher object.
713 2007-05-30 Christian Kellner <ckellner@openismus.com>
716 Search and check for libogs.
719 Incooparte the ogs build env.
721 * src/modest-mime-part-search-stream.c:
722 * src/modest-mime-part-search-stream.h:
723 Removed since we do the real searching now in modest-search.c.
725 * src/modest-search.c:
726 * src/modest-search.h:
727 Implement support for ogs. We use that if available and requested
728 and fall back to modest_text_utils_utf8_strcmp (). The search logic
729 should now handle the corner case when the search term is spread
730 across multiple reads.
731 Also the logic in modest_search () was corrected to search all
732 requested fields until one is found.
734 2007-05-30 Murray Cumming <murrayc@murrayc.com>
736 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
739 * src/modest-init.c: Made modest_init_local_folders() take a
740 path and be public so we can iniitialize maildir folders on
743 * src/modest-local-folder-info.h:
744 * src/modest-local-folder-info.c:
745 (modest_local_folder_info_get_maildir_path): Add a path parameter.
747 * src/modest-tny-account.c:
748 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
749 still means the standard local-folders path on the local volume.
751 * src/modest-tny-account-store.c:
752 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
753 signal so we can detect mount/unmount of the MMC1 card, and do an update of
754 all accounts when that happens.
755 (get_server_accounts): If the MMC1 card is mounted, create a store account for
756 this too, so it shows up in the treeview.
758 2007-05-28 Murray Cumming <murrayc@murrayc.com>
760 * src/maemo/modest-maemo-global-settings-dialog.c:
761 (current_connection):
762 * src/widgets/modest-global-settings-dialog.c:
763 (current_connection_default):
764 Use the enum values instead of 0, 1 and -1,
765 to make the code clearer.
767 * src/modest-account-mgr-helpers.c:
768 (modest_account_mgr_get_connection_specific_smtp): Make this code
771 * src/modest-runtime.h:
772 * src/modest-runtime.c:
773 Added modest_runtime_remove_all_send_queues().
774 * src/maemo/modest-main-window.c:
775 (on_account_store_connecting_finished): Recreate the send queues,
776 using the appropriate transport accounts for this new connection.
777 Some futher adapting might be needed if the old send queues are not
778 automatically stopped at this point.
780 * src/modest-tny-account-store.c: (get_server_accounts):
781 Create the connection-specific transport accounts, so that they can
782 be found later by their ID.
784 * src/modest-tny-account.h:
785 * src/modest-tny-account.c:
786 Added modest_tny_account_new_from_server_account_name().
787 modest_tny_account_new_from_server_account(): Do not create the
788 send queues here, because they will be
789 recreated anyway when the connection changes for the first time.
791 2007-05-28 Murray Cumming <murrayc@murrayc.com>
793 * src/modest-local-folder-info.h:
794 * src/modest-local-folder-info.c:
795 (modest_per_account_local_outbox_folder_info_get_maildir_path),
796 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
797 tbox_folder): Take a modest account name instead of a server TnyAccount,
798 so we can have per-modest-account rather than per-transport-account
800 We must make sure that we change or recreate the exisitng send queues
801 when the connection changes for connection-specific transport accounts.
803 * src/modest-tny-account-store.c:
804 (create_per_account_local_outbox_folders): Create outboxed per modest
805 account, not per transport account.
807 * src/modest-tny-account.h:
808 * src/modest-tny-account.c:
809 (modest_tny_account_get_special_folder): For outboxes, get the
810 parent modest account name. The account is ignored for other folders.
811 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
812 modest account name rather than a server TnyAccount.
814 2007-05-25 Murray Cumming <murrayc@murrayc.com>
816 * src/modest-tny-account.c:
817 (modest_tny_account_new_from_server_account):
818 Call modest_runtime_get_send_queue() immediately after creating transport
819 accounts, so that they start trying to send email from the outbox as soon
820 as possible at startup. This is probably what we want.
822 * src/modest-mail-operation.c: (update_account_thread):
823 * src/modest-runtime.c: (modest_runtime_get_send_queue):
824 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
825 * src/modest-tny-send-queue.h:
826 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
827 (modest_ui_actions_on_send):
828 Added comments about how sending works, though it needs some more work.
830 2007-05-25 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-tny-account.c:
833 (modest_tny_account_get_special_folder): Add TODO because this fails when
835 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
836 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
837 Do not try to show this window when there is no active account. The UI
838 specs does not tell us what to do in this case.
840 2007-05-24 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/Makefile.am:
845 * src/widgets/Makefile.am: Some dist fixes.
847 2007-05-24 Murray Cumming <murrayc@murrayc.com>
849 * src/maemo/modest-connection-specific-smtp-window.c:
850 (on_button_edit): Make the code clearer, to prevent a double free.
852 2007-05-24 Murray Cumming <murrayc@murrayc.com>
854 * src/maemo/modest-account-settings-dialog.c:
855 (modest_account_settings_dialog_set_account_name),
856 Check the connection-specific smtp servers checkbox if there are any.
858 * src/maemo/modest-connection-specific-smtp-edit-window.c:
859 (modest_connection_specific_smtp_edit_window_init):
860 Start with a suitable port number.
862 * src/modest-account-mgr-helpers.h:
863 * src/modest-account-mgr-helpers.c: Added
864 modest_account_mgr_get_has_connection_specific_smtp().
866 (modest_account_mgr_set_connection_specific_smtp),
867 (modest_account_mgr_remove_connection_specific_smtp),
868 (modest_account_mgr_get_has_connection_specific_smtp),
869 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
870 connection-specific smtp server accounts in the account, rather than
871 the server account conf dir.
873 This fixes bug projects.maemo.org bug NB#58263 .
875 * src/modest-tny-account-store.c:
876 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
877 if there are no server accounts yet, to prevent an infinite loop when there
878 are no accounts. Document that one must be called before the other.
880 2007-05-24 Murray Cumming <murrayc@murrayc.com>
882 * src/modest-account-mgr-helpers.c:
883 (modest_account_mgr_get_default_account): Make sure that at least
884 one account is always the default, if there are any enabled accounts.
885 This is just a sanity check that shouldn't be necessary.
887 * src/modest-account-mgr-priv.c:
888 (_modest_account_mgr_account_from_key): Unescape the conf key to
889 get the real account name. For instance, this is an issue if a space
890 was in the account name, which can happen because the account name
891 is generated from the display name.
892 (_modest_account_mgr_get_account_keyname): Always escape the
894 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
895 Unescape the conf keys to get the real account names.
897 For instance, previously the is-default radio button in the accounts
898 list was not checked for any accounts at first. This fixes that,
899 and might fix several similar bugs.
901 2007-05-23 Murray Cumming <murrayc@murrayc.com>
903 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
904 Removed some debug printfs.
906 2007-05-23 Murray Cumming <murrayc@murrayc.com>
908 Modest on-disk outbox directories are now here, for instance:
909 $HOME/.modest/outboxes/<account-id-1>/outbox
910 $HOME/.modest/outboxes/<account-id-2>/outbox
912 $HOME/.modest/local-folders/outbox
913 so we can have a separate outbox for each account.
914 But they are shown as one outbox in the GtkTreeView, by using a
915 TnyMergeFolder in a ModestTnySimpleFolderStore.
918 * src/modest-tny-simple-folder-store.c:
919 * src/modest-tny-simple-folder-store.h:
920 Added ModestTnySimpleFolderStore, used to contain folders from
921 other folder stores, such as other accounts.
923 * src/modest-tny-outbox-account.h:
924 * src/modest-tny-outbox-account.c:
925 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
926 used for the per-account local outbox folders.
928 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
929 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
930 only use this (internally) now for the non-outbox local folders.
933 * src/modest-init.c: Added modest_init_one_local_folder(), for
934 setting up the directory structure for each local folder.
936 * src/modest-local-folder-info.c:
937 (modest_per_account_local_outbox_folder_info_get_maildir_path),
938 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
940 * src/modest-local-folder-info.h:
941 * src/modest-tny-account-store.c: (on_account_removed),
942 (on_account_changed), (create_per_account_local_outbox_folders),
943 (get_server_accounts), (modest_tny_account_store_get_accounts),
944 (modest_tny_account_store_get_tny_account_by_account),
945 (modest_tny_folder_store_is_virtual_local_folders):
947 * src/modest-tny-account.h:
948 * src/modest-tny-account.c:
949 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
950 to create an on-disk per-account local outbox folder for each
952 (create_per_account_local_outbox_folders): Create a local outbox folder
953 for each transport account.
954 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
955 for all local folders.
957 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
958 instead of using g_object_get/set() directly. It is clearer.
960 (modest_tny_folder_store_get_message_count),
961 (modest_tny_folder_store_get_local_size
962 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
963 because we now use these with non-acount folder stores.
965 (modest_tny_account_get_special_folder),
966 (modest_tny_account_new_from_server_account),
967 (modest_tny_account_new_from_account):
968 (recurse_folders): Adjust to the new outbox system.
970 * src/modest-tny-folder.h:
971 * src/modest-tny-folder.c:
972 (modest_tny_folder_is_local_folder),
973 (modest_tny_folder_get_local_folder_type),
974 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
976 * src/widgets/modest-main-window.h:
977 * src/maemo/modest-main-window.c: (create_details_widget),
978 (modest_main_window_set_contents_style): Show details for any folder store,
981 (modest_tny_folder_get_rules):
982 Remove the const. C does not support constness enough for this.
984 * src/modest-ui-actions.c:
985 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
986 make all outboxes appear as one, in the usual local-folders tree node.
988 (set_active_account_from_tny_account),
989 (modest_ui_actions_on_folder_selection_changed):
990 * src/widgets/modest-folder-view.c: (text_cell_data),
991 (icon_cell_data), (filter_row),
992 (add_account_folders_to_merged_folder),
993 (add_account_folders_to_simple_folder_store), (),
994 (get_cmp_rows_type_pos), (cmp_rows),
995 (modest_folder_view_set_account_id_of_visible_server_account):
996 Adjust to the new outbox system, using generic folder stores and folders
999 2007-05-23 Christian Kellner <ckellner@openismus.com>
1001 * src/modest-mail-operation.c:
1002 (modest_mail_operation_update_account):
1003 Use info->max_size instead of unintialized local var [small
1004 build fix]. (Added TODO to review that change since I don't
1007 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1009 * libmodest-dbus-client/libmodest-dbus-client.c:
1010 (libmodest_dbus_client_compose_mail): function added
1011 * src/dbus_api/modest-dbus-api.h:
1012 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1013 (on_compose_mail): Implementation of the SendAsMail functionality
1015 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1017 * src/modest-account-mgr.c:
1018 (modest_account_mgr_add_server_account): Set the secure-connection
1019 conf key for transport accounts as well as store accounts. I don't know
1020 why the if was there. For instance, this makes sure that we use SSL
1021 for the gmail preset from the easysetup wizard.
1023 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1025 * src/gnome/modest-main-window.c:
1026 (on_account_store_connecting_finished), (connect_signals):
1027 * src/maemo/modest-main-window.c:
1028 (on_account_store_connecting_finished), (connect_signals),
1029 (modest_main_window_new):
1030 Handle TnyAccountStore::connecting-finished instead of
1031 TnyDevice::connection-changed, because we cannot actually perform
1032 operations on accounts until TnyAccountStore has itself responded to
1033 the TnyDevice::connection-changed signal. This prevents a GError from
1035 Do not try to update at startup, because we (at least on scratchbox)
1036 already do an update at startup when the device goes online.
1037 This prevents a GError from tinymail.
1038 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1039 Added TODO about stopping simultaneous operations.
1041 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1043 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1044 * src/modest-mail-operation-queue.c:
1045 (modest_mail_operation_queue_remove):
1046 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1047 about where they happened.
1049 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-ui-actions.c:
1052 (modest_ui_actions_on_password_requested): Make sure that the remember
1053 output parameter is always TRUE.
1055 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1057 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1058 Show a OK/Cancel dialog if the error is a question, though we still do not
1059 know anything more about what we are asking the user.
1060 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1061 Fix an uninitialized variable (helper). This is a logic error, however.
1063 2007-05-21 Christian Kellner <ckellner@openismus.com>
1065 * src/modest-search.h:
1066 Correct bit shifting in the ModestSearchFlags enum.
1068 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1070 * src/modest-tny-account.c:
1071 (modest_tny_account_new_from_server_account): Do not use the lsub and
1072 check-all hard-coded IMAP options when using POP.
1074 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1076 * src/modest-tny-account.c:
1077 (modest_tny_account_new_from_server_account):
1078 Use NULL for the secure-auth method for POP when Password auth has been
1079 specified by the user, as we already do for IMAP. "auth=Login" causes
1080 an error from camel or the server.
1082 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/modest-account-settings-dialog.c:
1085 (create_page_account_details),
1086 (modest_account_settings_dialog_set_account_name):
1087 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1088 for the leave-on-server checkbox, rathr than just the checkbox, when
1089 the protocol is not POP.
1091 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1093 * src/widgets/modest-account-view.c:
1094 * src/widgets/modest-account-view.h:
1095 Added modest_account_view_select_account() which will be useful later
1096 to asynchronously re-select the edited account.
1098 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1100 * src/maemo/modest-account-settings-dialog.c:
1101 (modest_account_settings_dialog_set_account_name):
1102 Automatically choose the port numbers based on the secure authentication
1103 methods, if they have not been chosen before.
1104 This fixes projects.maemo.org bug NB#56273 .
1106 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1108 * src/maemo/modest-main-window-ui.h:
1109 * src/modest-ui-actions.c:
1110 * src/modest-ui-actions.h:
1111 Connect the Tools/SMTP Servers menu item to
1112 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1113 SMTP servers dialog, as in the UI specification and saves changes when it
1114 is closed. This fixed projects.maemo.org bug NB#56305 .
1116 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1118 * src/maemo/modest-connection-specific-smtp-window.c:
1119 (modest_connection_specific_smtp_window_init):
1120 Use gtk_window_set_default_size() to make this window big enough, so
1121 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1123 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1126 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1127 (modest_connection_specific_smtp_edit_window_init),
1128 Do not try to connect to a combobox signal before the combobox exists.
1129 This fixes the cras in projects.maemo.org bug NB#56288 .
1130 (modest_connection_specific_smtp_edit_window_get_settings):
1131 Remove the server_account_name parameter which was being checked for NULL
1132 though it was not used.
1134 * src/maemo/modest-connection-specific-smtp-window.c:
1135 (modest_connection_specific_smtp_window_fill_with_connections),
1136 (on_button_edit), (modest_connection_specific_smtp_window_init):
1137 Correct the number of treemodel columns to prevent a warning.
1138 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1139 libconic does not work.
1141 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1143 * src/modest-tny-account.c:
1144 (modest_tny_account_new_from_server_account):
1145 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1146 SMTP when "None" was chosen by the user. However, with my SMTP server that
1147 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1150 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1152 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1153 to explain the memory management issue with the ID in the ModestPair.
1155 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1156 (add_sending_page), (modest_account_assistant_finalize):
1157 * src/gnome/modest-gnome-global-settings-dialog.c:
1158 (create_updating_page), (create_composing_page):
1159 * src/gnome/modest-msg-edit-window.c: (get_transports),
1160 (init_window), (modest_msg_edit_window_finalize),
1161 (modest_msg_edit_window_get_msg_data):
1162 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1163 * src/gnome/modest-transport-widget.c:
1164 (modest_transport_widget_finalize), (smtp_configuration):
1165 * src/maemo/modest-maemo-global-settings-dialog.c:
1166 (create_updating_page), (create_composing_page):
1167 * src/maemo/modest-msg-edit-window.c: (get_transports),
1168 (init_window), (modest_msg_edit_window_finalize),
1169 (modest_msg_edit_window_get_msg_data),
1170 (modest_msg_edit_window_free_msg_data):
1171 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1172 (modest_store_widget_finalize):
1173 * src/maemo/modest-transport-widget.c:
1174 (modest_transport_widget_finalize), (smtp_configuration):
1175 * src/modest-main.c: (send_mail):
1176 * src/widgets/modest-combo-box.h:
1177 * src/widgets/modest-global-settings-dialog-priv.h:
1178 * src/widgets/modest-global-settings-dialog.c:
1179 (modest_global_settings_dialog_finalize):
1180 * src/widgets/modest-msg-edit-window.h:
1181 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1182 as long as the combo box, to prevent use of freed memory for the ID.
1184 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1186 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1187 get_accounts(), to make this clearer. Do not check for the enabled gconf
1188 key, because we do not use this for server accounts (at least, not yet).
1189 This allows us to send email again.
1191 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1193 * src/maemo/modest-platform.c:
1194 (on_modest_conf_update_interval_changed), (modest_platform_init):
1195 Only respond to this particular key change. All these strcmp()s cannot be
1198 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1200 * src/maemo/modest-maemo-global-settings-dialog.c:
1201 (current_connection): Prevent a crash in scratchbox when
1202 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1203 * src/maemo/modest-platform.c:
1204 (on_modest_conf_update_interval_changed), (modest_platform_init):
1205 Get the update interval from gconf and reset it when the gconf key changes.
1207 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-protocol-info.c:
1210 * src/modest-protocol-info.h: Adde enum-specific get functions,
1211 instead of using a ModestProtocolType enum parameter.
1213 * src/gnome/modest-account-assistant.c:
1214 * src/gnome/modest-store-widget.c:
1215 * src/gnome/modest-store-widget.h:
1216 * src/gnome/modest-transport-widget.c:
1217 * src/gnome/modest-transport-widget.h:
1218 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1219 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1220 * src/maemo/easysetup/modest-easysetup-wizard.c:
1221 * src/maemo/modest-account-settings-dialog.c:
1222 * src/maemo/modest-account-settings-dialog.h:
1223 * src/maemo/modest-store-widget.c:
1224 * src/maemo/modest-store-widget.h:
1225 * src/maemo/modest-transport-widget.c:
1226 * src/maemo/modest-transport-widget.h:
1227 * src/modest-account-mgr-helpers.c:
1228 * src/modest-account-mgr-helpers.h:
1229 * src/modest-account-mgr.c:
1230 * src/modest-account-mgr.h:
1231 * src/modest-tny-account.c:
1232 * src/modest-tny-folder.c:
1233 * src/widgets/modest-account-view.c:
1234 * src/widgets/modest-retrieve-combo-box.c:
1235 * src/widgets/modest-retrieve-combo-box.h:
1236 * src/widgets/modest-secureauth-combo-box.c:
1237 * src/widgets/modest-serversecurity-combo-box.c:
1238 * src/widgets/modest-serversecurity-combo-box.h:
1239 * tests/check_account-mgr.c:
1240 Use the specific functions, and use the re-renamed enum values for GNOME too.
1242 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1244 * src/modest-pair.h:
1245 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1246 so we can get the second based on the first.
1248 * src/maemo/modest-account-settings-dialog.h:
1249 * src/maemo/modest-account-settings-dialog.c:
1250 Added get_supported_secure_authentication_methods(), though it is mostly
1251 commented-out for now until the necessary API is committed to tinymail.
1252 (modest_account_settings_dialog_set_account_name),
1253 (save_configuration): Request the supported authentication methods from the
1254 server, so we can choose a working method.
1256 * src/modest-tny-account-store.h:
1257 * src/modest-tny-account-store.c:
1258 (modest_tny_account_store_get_session): Rename from
1259 tny_account_store_get_session().
1261 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1263 * src/modest-protocol-info.h: Split the ModestProtocol enum
1264 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1265 There was no need to have these unrelated values in one enum.
1267 * src/: many files: Adapted to changed enum. This makes the code a bit
1268 clearer, and the compiler could catch some errors.
1270 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1272 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1273 Show the detailed internal camel error message when an error happens
1274 during the configuration, so that our testers can give us more clues.
1275 For instance, in projects.maemo.org bug NB#56910 .
1277 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-tny-account.c:
1280 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1281 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1283 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1285 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1286 * src/maemo/modest-account-settings-dialog.c:
1287 (modest_account_settings_dialog_set_account_name),
1288 (save_configuration): For the incoming secure authentication checkbox,
1289 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1290 the UI specification. PLAIN does not seem to be supported for most IMAP
1291 servers anyway, and I am not sure what it would mean.
1292 However, we probably need to discover which of the secure-authentication
1293 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1294 * src/modest-account-mgr-helpers.c:
1295 (modest_account_mgr_get_server_account_data):
1297 * src/modest-tny-account.c:
1298 (modest_tny_account_new_from_server_account):
1299 Use tny_account_set_mech() to set secure-authentication methods,
1300 with some special-casing for IMAP, based on my observations of how
1303 * src/modest-account-mgr-helpers.h:
1304 * src/modest-account-mgr.c:
1305 * src/modest-defs.h: Comment that the URI is only used for local folders.
1307 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1309 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1310 parameter const, just to be neat.
1311 * src/modest-text-utils.c: (modest_text_utils_inline):
1312 End g_strconcat() with NULL, as its documentation says. This is almost
1313 certainly the cause of my crash at startup on the device. Interestingly,
1314 valgrind doesn't tell us about these errors.
1316 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1318 * scripts/build-packages: Added more precise comments about how to use
1319 this script, though I still get this error:
1320 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1321 error building tinymail
1323 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/modest-main-window.c: (on_account_update):
1326 Very slight cleanup, hoping to make it simpler to discover what causes
1327 a crash here sometimes.
1329 * src/modest-tny-account.c:
1330 (modest_tny_account_new_from_server_account): Set the port. Added
1331 comments about the options and a TODO comment because I need to find out
1332 how to specify the secure authentication method.
1334 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1336 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1337 changed CFlags paths form modest to libmodest
1339 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-account-mgr-helpers.c:
1342 (modest_account_mgr_get_server_account_data),
1343 (modest_account_mgr_free_server_account_data):
1344 * src/modest-account-mgr-helpers.h:
1345 * src/modest-account-mgr.c:
1346 (modest_account_mgr_add_server_account):
1347 * src/modest-defs.h:
1348 * src/modest-tny-account.c:
1349 (modest_tny_account_new_from_server_account):
1350 Determine the options for tny_camel_account_add_option() here,
1351 based on the settings, rather than storing them directly in gconf.
1353 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1356 Show a more friendly error dialog now that we expect (from the tinymail
1357 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1359 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1361 * src/maemo/modest-main-window.c: (on_account_update): Check that
1362 account_name is not NULL, to prevent a crash at startup that I am
1363 seeing on the N800. I do wonder why it is NULL.
1365 * src/maemo/easysetup/modest-easysetup-wizard.c:
1366 (create_page_user_details):
1367 * src/maemo/modest-account-settings-dialog.c:
1368 (create_page_user_details), (create_page_outgoing):
1369 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1370 (modest_connection_specific_smtp_edit_window_init):
1371 * src/modest-ui-actions.c:
1372 (modest_ui_actions_on_password_requested):
1373 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1374 might do something useful with the on-screen keyboard.
1376 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1378 * src/maemo/modest-main-window.c: (on_account_update):
1379 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1380 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1382 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1384 * src/modest-tny-account-store.c: (on_account_changed):
1385 Correct the signature of this signal handler.
1387 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1389 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1390 Show a HildonNote instead of a GtkDialog for Maemo.
1392 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1394 * src/widgets/modest-account-view.h:
1395 * src/widgets/modest-account-view.c: (on_account_changed),
1396 (on_account_removed). Added a boolean flag, set/unset by
1397 modest_account_view_block_conf_updates(),
1398 modest_account_view_unblock_conf_updates() to prevent unnecessary
1399 updates, but this is not very useful because the gconf notifications are
1400 so delays (maybe only on Maemo Bora).
1401 So auto-updating is turned off, and these functions do an explicit
1402 update when necessary.
1403 However, something else is still doing too much work when adding/removing
1404 accounts, probably in another part of the application.
1406 * src/maemo/modest-account-view-window.c:
1407 (on_delete_button_clicked), (on_edit_button_clicked),
1408 (on_new_button_clicked): Use the new functions.
1410 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-account-mgr-helpers.c:
1413 (modest_account_mgr_set_first_account_as_default):
1414 Sort the list of names alphabetically-by-title, so we choose the first one
1416 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1417 alphabetically by the title.
1419 This fixes projects.maemo.org bug NB#56418 .
1421 * src/modest-account-mgr-priv.c:
1422 (_modest_account_mgr_account_from_key):
1423 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1424 avoid a valgrind error, and possible random behaviour.
1426 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1428 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1429 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1430 tinymail documentation to say that this can be expected.
1431 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1432 pretty, and should not happen, but I would prefer to know when it does.
1434 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1436 * configure.ac: When using the older hildon version, probably on Bora,
1437 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1439 * src/widgets/modest-attachment-view.c:
1440 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1443 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1445 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1446 Implemented the prototype. Can be tested with
1447 tests/dbus_api/test_open_message:
1449 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1451 * src/modest-tny-account-store.c:
1452 (modest_tny_account_store_instance_init), (get_password):
1453 * src/modest-ui-actions.c:
1454 (modest_ui_actions_on_password_requested):
1455 Do not store the password in gconf, because this function is called
1456 for non-remembered passwords. Actually use the cached (in the hash map)
1457 password instead of releasing it.
1458 The password will now not be remembered if it is asked via the protected
1459 password dialog, as per the UI spec.
1461 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1463 * src/modest-defs.h:
1464 * src/modest-account-mgr-helpers.h:
1465 * src/modest-account-mgr-helpers.c:
1466 Added modest_server_account_get_username_has_succeeded(),
1467 modest_server_account_set_username_has_succeeded().
1468 (modest_server_account_set_username),
1469 Reset the has-succeeded flag if the username changes.
1471 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1472 * src/maemo/modest-connection-specific-smtp-window.c:
1473 (modest_connection_specific_smtp_window_save_server_accounts):
1474 Use modest_server_account_set_username() instead of using
1475 modest_conf_set_string() directly, so that the has-succeeded flag is always
1478 * src/modest-ui-actions.c:
1479 (modest_ui_actions_on_password_requested): Dim the username entry if
1480 the username has ever worked, as per the UI spec.
1482 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1484 * src/modest-tny-account-store.c: (get_password):
1485 * src/modest-ui-actions.c:
1486 (modest_ui_actions_on_password_requested):
1487 Allow the username to be changed too, though there is more work to
1488 be done on exactly how this behaves.
1490 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-account-mgr-helpers.h:
1493 * src/modest-account-mgr-helpers.c:
1494 Added modest_account_mgr_get_display_name(),
1495 modest_server_account_get_username(),
1496 modest_server_account_set_username(),
1497 modest_server_account_set_password(),
1498 modest_server_account_get_hostname() functions so we do not need to
1499 use the conf API directly.
1501 * src/maemo/modest-main-window.c: (connect_signals):
1502 Actually connect ot the ModestAccountStore::request-password signal,
1503 so that we show the dialog when the password is requested by Tinymail,
1504 for isntance if it is empty.
1506 * src/modest-marshal.list:
1507 * src/modest-tny-account-store.c:
1508 (modest_tny_account_store_class_init), (get_password),
1509 (modest_tny_account_store_alert):
1510 * src/modest-tny-account-store.h:
1511 * src/modest-ui-actions.h:
1512 * src/modest-ui-actions.c:
1513 (modest_ui_actions_on_password_requested):
1514 Change the signal parameters, so it is obvious that we are providing
1515 the non human-readable server name, and receiving both the username
1516 and password, though changing of the username is not yet implemented.
1517 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1518 for the GNOME version.
1520 This should fix the projects.maemo.org bug NB#56209, though it does not
1521 work on Bora, because the gconf_client_get() for the password fails
1522 immediately after we save it with gconf_client_set().
1524 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1527 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1528 caused an undefined symbol error:
1529 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1531 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1533 * src/modest-tny-account-store.c:
1534 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1535 using a GError instead of a string message, so we can translate it in
1538 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/modest-address-book.c:
1541 (modest_address_book_check_names):
1542 * src/maemo/modest-msg-view-window.c:
1543 (modest_msg_view_window_clipboard_owner_change):
1544 * src/modest-init.c: (modest_init_init_ui):
1545 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1546 (update_folders_cb), (modest_mail_operation_update_account):
1547 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1548 (modest_ui_actions_on_msg_attachment_clicked),
1549 (modest_ui_actions_on_msg_recpt_activated):
1550 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1551 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1552 (modest_msg_view_search_next):
1553 * src/widgets/modest-recpt-editor.c:
1554 (modest_recpt_editor_on_button_release_event),
1555 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1556 g_message(). At this point we should only be seeing interesting errors on
1557 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1559 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1561 (modest_wizard_dialog_force_title_update):
1562 * src/maemo/easysetup/modest-wizard-dialog.h:
1563 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1564 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1565 can update the title when appropriate. Otherwise the title is wrong if the
1566 pages are added after adding the notebook to the dialog.
1567 This must be a problem in HildonWizardDialog too.
1568 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1570 * src/maemo/easysetup/modest-easysetup-wizard.c:
1571 (create_subsequent_customsetup_pages),
1572 (create_subsequent_easysetup_pages):
1573 Call modest_wizard_dialog_force_title_update() so that the title is
1574 correct even with GTK+ < 2.10.
1575 This fixes projects.maemo.org bug NB#56145 .
1577 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1579 * src/maemo/modest-platform.c:
1580 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1581 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1584 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1586 * src/widgets/modest-window.h:
1587 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1588 and modest_window_save_state(), which invokes it.
1590 * src/widgets/modest-window-mgr.h:
1591 * src/widgets/modest-window-mgr.c:
1592 Added modest_window_mgr_save_state_for_all_windows(), which calls
1593 the save_state vfunc on all registered windows, if implemented.
1595 * src/gnome/modest-msg-edit-window.c:
1596 * src/gnome/modest-msg-view-window.c:
1597 * src/maemo/modest-msg-edit-window.c:
1598 * src/maemo/modest-msg-view-window.c:
1599 * src/maemo/modest-main-window.c:
1600 Specify the existing save_settings functions as implementations of
1601 ModestWindow::save_state_func().
1603 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1604 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1605 enabling hibernation, for instance.
1607 We may need to do the same thing for restoring settings.
1610 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1612 * src/widgets/modest-window-mgr.c:
1613 * src/widgets/modest-window-mgr.h:
1614 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1615 modest_window_mgr_get_hibernation_is_prevented().
1617 * src/maemo/modest-main-window.c:
1618 (on_hildon_program_is_topmost_notify): Prevent hibernation
1619 (possible when the application goes to the background in the WM),
1620 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1622 * src/maemo/easysetup/modest-easysetup-wizard.c:
1623 (modest_easysetup_wizard_dialog_init):
1624 * src/maemo/modest-account-settings-dialog.c:
1625 (modest_account_settings_dialog_init):
1626 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1627 (modest_connection_specific_smtp_edit_window_init):
1628 * src/maemo/modest-connection-specific-smtp-window.c:
1629 (modest_connection_specific_smtp_window_init):
1630 * src/maemo/modest-signature-editor-dialog.c:
1631 (modest_signature_editor_dialog_init):
1632 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1633 prevent hibernation while any of these account settings dialogs are open.
1635 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1637 * src/maemo/Makefile.am:
1638 * src/maemo/modest-osso-state-saving.c:
1639 * src/maemo/modest-osso-state-saving.h: Added
1640 modest_osso_load_state() and modest_osso_save_state() though they do
1641 nothing now. They should iterate through all the open windows and load/save
1643 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1644 save state when closing.
1646 * src/maemo/modest-main-window.c:
1647 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1648 Add a notification handler for the HildonProgram::is-topmost property,
1649 so we can allow hibernation when the application goes into the background.
1650 But we still need to detect when the accounts setup windows are open so
1651 we can stop hibernation when they are open.
1652 To do this, I also added the main window the HildonProgram. This might have
1653 other side-effects/benefits, and should maybe be done for other windows.
1655 * src/maemo/modest-osso-autosave-callbacks.h:
1656 * src/maemo/modest-osso-autosave-callbacks.c:
1657 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1658 though it does not do anything yet, and we might never need this to do
1659 anything. For instance, we already save drafts.
1661 * src/maemo/modest-platform.c: (modest_platform_init):
1662 Specify the libosso auto-save callback.
1664 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1666 * src/maemo/modest-platform.c:
1667 (modest_platform_set_update_interval):
1668 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1669 aparently stays valid between application instances, so we can use this
1670 to remove and reset it later. According to a maemo-developers email from
1673 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1675 * configure.ac: Depend on libalarm for Maemo.
1677 * src/dbus_api/modest-dbus-api.h:
1678 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1679 (on_send_receive), (modest_dbus_req_handler):
1680 Handle a SEND_RECEIVE D-Bus method.
1682 * libmodest-dbus-client/libmodest-dbus-client.c:
1683 (libmodest_dbus_client_send_and_receive):
1684 * libmodest-dbus-client/libmodest-dbus-client.h:
1685 Add C convenience functions for calling the new D-Bus method.
1687 * src/modest-platform.h:
1688 * src/gnome/modest-platform.c:
1689 * src/maemo/modest-platform.c:
1690 Added modest_platform_set_update_interval(), which uses the
1691 alarmd API on Maemo.
1692 (modest_platform_init),
1693 Call modest_platform_set_update_interval(), using a hard-coded
1694 interval for now (until the global settings dialog is implemented),
1695 though I am not sure that this makes sense yet.
1697 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1699 * src/dbus_api/modest-dbus-callbacks.c:
1700 (modest_osso_cb_hw_state_handler):
1701 * src/dbus_api/modest-dbus-callbacks.h:
1702 * src/maemo/modest-platform.c: (modest_platform_init):
1703 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1704 in case this has some effect on the ability for Maemo to ping the
1707 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1710 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1711 warning. It is probably a logic error, but I need to fix the build.
1713 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1715 * src/modest-account-mgr.h:
1716 * src/modest-account-mgr.c:
1717 (modest_account_mgr_account_names): Add a gboolean enabled_only
1718 parameter, so we can get lists of onlt the enabled accounts.
1720 (modest_account_mgr_add_account),,
1721 (modest_account_mgr_account_with_display_name_exists):
1722 * src/maemo/modest-msg-edit-window.c: (get_transports):
1723 * src/modest-account-mgr-helpers.c:
1724 (modest_account_mgr_set_first_account_as_default):
1725 * src/modest-init.c: (init_default_account_maybe):
1726 * src/modest-tny-account-store.c: (get_accounts):
1727 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1728 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1729 * tests/check_account-mgr.c: (START_TEST):
1730 Provide the extra parameter, as appropriate.
1732 * src/widgets/modest-account-view.c: (update_account_view):
1733 Do not show disabled accounts (meaning that there is no way to
1734 enable/disable accounts in the UI (the feature is not in our UI
1735 specification), so we can use this internally only to mark unfinished
1736 or temporary account data.
1738 * src/maemo/easysetup/modest-easysetup-wizard.c:
1739 (create_account): Add boolean enable parameter, so we can specify FALSE
1740 to create the temporary account.
1741 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1742 (on_before_next): When finishing, when there is a temporary account, just
1744 Also, use a timeout to delay the showing of the dialog until gconf is likely
1745 to return correct information, due to a maemo gconf bug that is fixed in
1746 osso 1.1, but not yet in Bora.
1747 However, the dialog stays on screen after it is destroyed.
1749 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1750 for invalid data when cancelling. Use a hildon note instead of a dialog
1751 to complain about invalid data. Do not show the account-saved note if the
1752 account is disabled (a temporary account that will not really be saved for use
1755 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1757 * src/modest-account-mgr-helpers.h:
1758 * src/modest-account-mgr-helpers.c:
1759 Added modest_account_mgr_unset_default_account(),
1760 Added modest_account_mgr_set_first_account_as_default().
1762 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1763 If it was the default account, unset the default account name.
1765 * src/maemo/modest-account-view-window.c:
1766 (on_delete_button_clicked): If it was the default account,
1767 set the first remaining account as the default instead.
1769 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1770 a NULL account or a NULL default account, to prevent a crash. This should
1771 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1774 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1776 * src/widgets/modest-recpt-editor.c:
1777 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1778 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1779 TODO comment for this. This fixes the build.
1781 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1782 be the best place for it. This will in future update all auto-update accounts,
1783 rather than just the current/default account, when that gconf key exists.
1784 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1785 if there are no accounts, before calling do_send_receive().
1786 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1788 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1789 * src/maemo/modest-main-window-ui.h:
1790 * src/maemo/modest-main-window.c: (on_connection_changed),
1791 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1792 directly, becaue the signal handler does more.
1794 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1796 * src/modest-account-mgr-helpers.c:
1797 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1798 for the case that the account does not exist.
1800 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1801 (equivalent to the modest account name) rather than the tinymail account name
1802 (equivalent to the modest account title - human readable) to get the account data.
1803 Check for null account data to prevent the crash, and add a TODO comment saying that
1804 this needs fixing because it is using the server account name instead of the account name.
1806 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1808 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1809 * src/maemo/modest-account-settings-dialog.c: (show_error),
1811 Use hildon_note_new_information() for informative and error messages,
1812 which seems to be expected for Maemo applications (no documentation that I know of
1813 says this). I am surprised that there is no distinction between info and error
1816 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1818 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1819 it is easy to find where this is used.
1821 * src/maemo/easysetup/modest-easysetup-wizard.c:
1822 (create_page_welcome), (create_page_account_details),
1823 (create_page_user_details), (create_page_complete_easysetup),
1824 (create_page_custom_incoming), (create_page_custom_outgoing),
1825 (create_page_complete_custom):
1826 * src/maemo/modest-account-settings-dialog.c:
1827 (create_page_account_details), (create_page_user_details),
1828 (create_page_incoming), (create_page_outgoing):
1829 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1830 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1831 (modest_connection_specific_smtp_edit_window_init):
1832 * src/maemo/modest-connection-specific-smtp-window.c:
1833 (modest_connection_specific_smtp_window_init):
1834 * src/maemo/modest-signature-editor-dialog.c:
1835 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1836 and scrolling policy as per the Email Application Layout Guide, if I have
1839 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1841 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1842 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1843 which were empty, because these vfuncs have been removed from TnyAccountStore.
1844 This fixes the build.
1846 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/modest-main-window.c:
1849 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1850 showing/hiding it. Added TODO because it probably should not be NULL.
1851 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1852 because unnecessary g_warnings() make degugging difficult.
1854 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1856 * src/maemo/modest-msg-edit-window.c:
1857 (modest_msg_edit_window_select_color),
1858 (modest_msg_edit_window_select_background_color): 2 const corrections and
1859 moving 2 #endifs before closing brackets, to fix the build.
1861 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1863 * src/maemo/easysetup/modest-easysetup-wizard.h:
1864 * src/maemo/easysetup/modest-easysetup-wizard.c:
1865 (modest_easysetup_wizard_dialog_finalize),
1866 (on_button_edit_advanced_settings), (create_page_complete_custom),
1867 (on_response), (create_account):
1868 Implement the Advanced Settings edit button, by saving the account information,
1869 for the Advanded Settings dialog to use directly from gconf, and removing it
1870 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1871 Bug #5533 in the projects.maemo.org bugzilla.
1873 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1875 * src/maemo/modest-msg-view-window.c:
1876 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1877 when opening a message window.
1879 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1881 * src/maemo/easysetup/modest-easysetup-wizard.c:
1882 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1885 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1886 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1887 gconf settings. I probably added more checks than necessary, but that is safer.
1889 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1890 variable to fix the build, but this seems to be used when it is still NULL.
1892 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-platform.h:
1895 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1896 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1897 * src/modest-main.c: Implement this function so we can avoid using
1898 maemo-specific API from cross-platform code.
1900 * src/modest-tny-account-store.c:
1901 (get_smtp_specific_transport_account_for_open_connection):
1902 * src/modest-ui-actions.c: (check_for_connection),
1903 (modest_ui_actions_on_item_not_found):
1904 Use modest_platform_connect_and_wait() and put #idefs around other
1905 maemo-specific code, because only maemo currently has a way to
1906 identify connection names.
1908 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1910 * src/modest-tny-account-store.h:
1911 * src/modest-tny-account-store.c:
1912 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1913 the connection-specific SMTP server settings in the configuration.
1915 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1917 * src/maemo/modest-main-window.c: (on_connection_changed),
1919 * src/modest-main.c: (main), (start_ui), (send_mail):
1920 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1921 that is what is intended.
1923 * src/modest-ui-actions.c: (action_send), (action_receive),
1924 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1925 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1926 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1927 SMTP server is used when it is specified.
1929 (modest_ui_actions_on_send_receive):
1930 Check that a connection is open before proceeding.
1931 Receive and then send, instead of vice-versa, as per the specification.
1933 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1935 * src/modest-mail-operation.c:
1936 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1937 though I guess it should be something other than NULL.
1939 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/easysetup/modest-easysetup-wizard.c:
1942 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1943 combo twice, to avoid an g_warning and to make it visible again.
1944 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1945 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1946 (already intended) dereference when detaching, because we then recreate the menu.
1947 But I am not sure why the warning was happening, and it is possible that this is a memory
1950 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1952 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1953 and uri_parse_mailto() utility functions.
1954 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1956 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1958 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1960 * src/dbus_api/modest-dbus-api.h:
1961 * src/dbus_api/modest-dbus-callbacks.c:
1962 Use an idle callback to execute the modest code in the application's own thread.
1963 Remove the helloworld example method.
1964 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1965 parsed, and the open-message method is not implemented because this is not yet implemented in
1967 * libmodest-dbus-client/libmodest-dbus-client.c:
1968 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1969 (libmodest_dbus_client_open_message):
1970 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1972 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1973 body without crashing.
1975 * tests/dbus_api/Makefile.am:
1976 * tests/dbus_api/test_mail_to.c:
1977 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1979 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1981 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1982 Added file to fix the build. Sorry.
1984 * src/dbus_api/Makefile.am:
1985 * src/dbus_api/modest-dbus-api.h:
1986 * src/dbus_api/modest-dbus-callbacks.h:
1987 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1988 (modest_dbus_req_handler):
1989 Put constants in a separate header so it can be reused by the
1990 client library, without duplication
1992 * libmodest-dbus-client/Makefile.am:
1993 * libmodest-dbus-client/libmodest-dbus-client.c:
1994 (libmodest_dbus_client_call_helloworld),
1995 (libmodfest_dbus_client_send_mail),
1996 (libmodfest_dbus_client_mailto),
1997 (libmodfest_dbus_client_open_message):
1998 * libmodest-dbus-client/libmodest-dbus-client.h:
1999 (Partly) Implement a send_mail D-Bus method.
2001 * tests/dbus_api/Makefile.am:
2002 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2003 the send_email D-Bus method.
2005 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2009 * libmodest-dbus-client/Makefile.am:
2010 * libmodest-dbus-client/libmodest-dbus-client.c:
2011 * libmodest-dbus-client/libmodest-dbus-client.h:
2012 * tests/dbus_api/Makefile.am:
2013 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2014 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2016 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2018 * src/maemo/easysetup/modest-easysetup-wizard.c:
2019 (create_page_account_details):
2020 * src/maemo/modest-account-settings-dialog.c:
2021 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2022 widgets, because this might not be the default in future versions of the Maemo GTK+.
2023 However, I can not not get capitalization to work even in a simple test case.
2025 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2027 * src/maemo/easysetup/modest-easysetup-wizard.c:
2028 (create_page_custom_incoming), (create_page_custom_outgoing):
2029 * src/maemo/modest-account-settings-dialog.c:
2030 (create_page_account_details), (create_page_incoming),
2031 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2032 instead of using gtk_check_button_with_label(), so they are aligned like the other
2033 widgets, as per the UI spec.
2035 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2037 * src/maemo/easysetup/modest-easysetup-wizard.c:
2038 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2039 * src/widgets/modest-validating-entry.c:
2040 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2041 Modest prefix instead of an EasySetup prefix.
2043 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2045 * src/widgets/modest-validating-entry.h:
2046 * src/widgets/modest-validating-entry.c: (on_insert_text),
2047 Added easysetup_validating_entry_set_max_func(), used to set a callback
2048 to call when the max number of characters is reached. GtkEntry has a max-length
2049 already but is silent about it.
2051 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2052 (create_page_account_details), (create_page_user_details),
2054 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2055 (create_page_account_details), (create_page_user_details),
2056 (create_page_outgoing):
2057 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2058 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2059 the UI spec, when the user tries to enter more than the max number of characters.
2061 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2063 * src/maemo/easysetup/modest-easysetup-wizard.c:
2064 (create_page_user_details), (create_page_custom_incoming),
2065 (create_page_custom_outgoing):
2066 * src/maemo/modest-account-settings-dialog.c:
2067 (create_page_user_details), (create_page_incoming),
2068 (create_page_outgoing):
2069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2070 (modest_connection_specific_smtp_edit_window_init):
2071 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2072 not appropriate. Bad Maemo-specific defaults!.
2074 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2077 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2078 (modest_signature_editor_dialog_set_settings):
2079 Disable the label and textview when the checkbox is disabled, and use the
2080 specified (UI spec) default signature text.
2082 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2085 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2087 * src/modest-defs.h:
2088 * src/modest-account-mgr-helpers.h:
2089 * src/modest-account-mgr-helpers.c:
2090 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2092 * src/maemo/Makefile.am:
2093 * src/maemo/modest-signature-editor-dialog.c:
2094 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2097 * src/maemo/modest-account-settings-dialog.h:
2098 * src/maemo/modest-account-settings-dialog.c:
2099 (modest_account_settings_dialog_finalize), (on_button_signature),
2100 (save_configuration): Use the new dialog when the Edit button is pressed, and
2101 save the changes if necessary, as per the UI spec.
2103 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/Makefile.am:
2106 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2107 based on maemo-develoers email from Dirk.
2109 * src/maemo/easysetup/modest-easysetup-wizard.c:
2110 (create_page_welcome), (create_page_account_details),
2111 (create_page_user_details), (create_page_complete_easysetup),
2112 (create_page_custom_incoming), (create_page_custom_outgoing),
2113 (create_page_complete_custom),
2114 (modest_easysetup_wizard_dialog_init):
2115 * src/maemo/modest-account-settings-dialog.c:
2116 (create_page_account_details), (create_page_user_details),
2117 (create_page_incoming), (create_page_outgoing),
2118 (modest_account_settings_dialog_init):
2119 * src/maemo/modest-connection-specific-smtp-window.c:
2120 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2122 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2124 * src/maemo/easysetup/modest-easysetup-wizard.c:
2125 (create_page_account_details), (create_page_custom_outgoing),
2126 (create_page_complete_custom):
2127 * src/maemo/modest-account-settings-dialog.c:
2128 (create_page_user_details), (create_page_incoming),
2129 (create_page_outgoing):
2130 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2131 (modest_connection_specific_smtp_edit_window_init):
2132 Use the correct (UI spec) port min/max, and use horizontal separators,
2135 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2137 * src/maemo/easysetup/modest-easysetup-wizard.c:
2138 (set_default_custom_servernames):
2139 * src/maemo/modest-account-settings-dialog.c:
2140 (create_page_incoming), (on_combo_outgoing_security_changed),
2141 (on_combo_incoming_security_changed), (create_page_outgoing),
2142 (modest_account_settings_dialog_set_account_name),
2143 (save_configuration):
2144 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2145 (on_combo_security_changed),
2146 (modest_connection_specific_smtp_edit_window_init),
2147 (modest_connection_specific_smtp_edit_window_set_connection),
2148 (modest_connection_specific_smtp_edit_window_get_settings):
2149 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2152 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2155 * src/maemo/easysetup/modest-easysetup-wizard.c:
2156 (create_page_custom_outgoing), (create_page_complete_custom):
2157 * src/maemo/modest-account-settings-dialog.c:
2158 (create_page_user_details), (create_page_outgoing):
2159 * src/maemo/modest-account-view-window.c: (button_box_new):
2160 Use changed logical IDs as per the most recent UI spec:
2161 mcen_bd_emailsetup_edit -> mcen_bd_edit
2162 mcen_bd_emailsetup_delete -> mcen_bd_delete
2163 mcen_bd_emailsetup_close -> mcen_bd_close
2165 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2169 * src/dbus_api/Makefile.am:
2170 * src/dbus_api/modest-dbus-callbacks.c:
2171 * src/dbus_api/modest-dbus-callbacks.h:
2172 * src/maemo/modest-platform.c: (modest_platform_init):
2173 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2175 * tests/Makefile.am:
2176 * tests/dbus_api/Makefile.am:
2177 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2179 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/modest-account-settings-dialog.c:
2182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2183 Removed unnecessary includes.
2185 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2187 * src/maemo/easysetup/modest-easysetup-wizard.c:
2188 * src/maemo/modest-account-settings-dialog.c:
2189 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2190 * src/widgets/Makefile.am:
2191 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2192 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2193 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2194 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2195 * src/widgets/modest-secureauth-combo-box.c:
2196 * src/widgets/modest-secureauth-combo-box.h:
2197 * src/widgets/modest-serversecurity-combo-box.c:
2198 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2199 made the GObject names more consistent with the rest of the Modest code.
2201 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2203 * src/maemo/easysetup/Makefile.am:
2204 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2205 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2206 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2207 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2208 * src/maemo/easysetup/modest-easysetup-wizard.c:
2209 * src/maemo/easysetup/modest-validating-entry.c:
2210 * src/maemo/easysetup/modest-validating-entry.h:
2211 * src/maemo/modest-account-settings-dialog.c:
2212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2213 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2214 widgets/ because they are used outside of easysetup too. After checking in,
2215 svn will allow me to rename them too.
2217 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2219 * src/gnome/modest-msg-edit-window.c:
2220 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2221 linker error, to fix the build on the GNOME platform.
2222 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2223 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2224 ifdefed out to avoid a warning.
2226 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2228 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2229 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2230 some alternative for GTK+ 2.6.
2232 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2236 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2237 specified for EmailAccountsDialog in UI spec.
2239 * src/maemo/easysetup/modest-easysetup-wizard.c:
2240 * src/maemo/easysetup/modest-easysetup-wizard.h:
2241 * src/maemo/modest-account-settings-dialog.c:
2242 * src/maemo/modest-account-settings-dialog.h:
2243 Reuse a member window widget for the connection-specific SMTP server accounts,
2244 so we can tell it to create/save the accounts only if we actually save changes.
2246 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2247 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2248 (modest_connection_specific_smtp_edit_window_get_settings):
2249 Return a struct instance for temporarily remembering the entered data.
2251 * src/maemo/modest-connection-specific-smtp-window.h:
2252 * src/maemo/modest-connection-specific-smtp-window.c:
2253 (modest_connection_specific_smtp_window_finalize),
2254 (modest_connection_specific_smtp_window_fill_with_connections),
2256 (modest_connection_specific_smtp_window_save_server_accounts),
2257 (update_model_server_names): Do not actually save data until asked,
2258 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2260 (on_selection_changed),
2261 (modest_connection_specific_smtp_window_init): Disable the edit
2262 button when nothing is selected.
2264 * src/modest-account-mgr-helpers.c:
2265 * src/modest-account-mgr-helpers.h:
2266 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2269 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2271 * src/modest-account-mgr-helpers.h:
2272 * src/modest-account-mgr-helpers.c:
2273 (modest_account_mgr_get_unused_account_name),
2274 (modest_account_mgr_get_unused_account_display_name): Added these
2275 utility functions, to avoid code duplication.
2277 * src/maemo/easysetup/modest-easysetup-wizard.c:
2278 (create_page_account_details), (create_account):
2279 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2280 (on_combo_security_changed),
2281 (modest_connection_specific_smtp_edit_window_init),
2282 (modest_connection_specific_smtp_edit_window_save_settings):
2283 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2284 * src/maemo/modest-connection-specific-smtp-window.c:
2285 (modest_connection_specific_smtp_window_finalize),
2286 (modest_connection_specific_smtp_window_fill_with_connections),
2287 (on_button_edit), (modest_connection_specific_smtp_window_init):
2288 * src/maemo/modest-connection-specific-smtp-window.h:
2289 Implementing saving of connection-specific server accounts.
2291 But I need to refactor this so we can save the data for each
2292 possible connection-specific account and only actually create the server accounts
2293 when the easysetup finished, or the OK button is pressed on the account settings
2296 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2299 (on_combo_security_changed):
2300 (modest_connection_specific_smtp_edit_window_init):
2301 Auto-fill the port number as in the account settings.
2303 (modest_connection_specific_smtp_edit_window_set_connection):
2304 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2305 * src/maemo/modest-connection-specific-smtp-window.c:
2306 (fill_with_connections), (on_button_edit),
2307 (modest_connection_specific_smtp_window_init):
2308 Turn the edit window into a dialog to simplify the code, and
2309 set a WM hint as in a GtkDialog, because only a popup can be on top of
2310 another window in Maemo, and popups usually have no WM decoration.
2312 * src/modest-defs.h:
2313 * src/modest-account-mgr-helpers.c:
2314 (modest_account_mgr_set_connection_specific_smtp),
2315 (modest_account_mgr_remove_connection_specific_smtp),
2316 (modest_account_mgr_get_connection_specific_smtp):
2317 * src/modest-account-mgr-helpers.h: Some functions to write the
2318 connection-specific SMTP server information. Not yet used.
2321 * src/widgets/modest-folder-view.c: (text_cell_data):
2322 Fix a warning about an uninitialized variable.
2323 (on_configuration_key_changed): Put an #ifdef around the use
2324 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2326 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2328 * src/maemo/modest-account-settings-dialog.h:
2329 * src/maemo/modest-account-settings-dialog.c:
2330 Added connect_for_modified() utility function to mark the new modified boolean.
2332 (create_page_account_details), (create_page_user_details),
2333 (create_page_incoming), (create_page_outgoing), (on_response),
2334 (modest_account_settings_dialog_init),
2335 (modest_account_settings_dialog_set_account_name):
2336 Only warn about unsaved changes when there are actually unsaved changes.
2338 * src/modest-account-mgr-helpers.c:
2339 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2340 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2341 to get the data from there in future.
2343 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-defs.h:
2347 * src/modest-account-mgr-helpers.h:
2348 * src/modest-account-mgr-helpers.c:
2349 Store the security account setting in a single conf key instead of using
2350 the options list, so that the list is left for just the to-be-removed camel hack,
2351 and because gconf_client_set_list() is failing for some reason.
2353 * src/modest-account-mgr.c:
2354 (modest_account_mgr_add_server_account):
2355 * src/maemo/modest-account-settings-dialog.c:
2356 (modest_account_settings_dialog_set_account_name),
2357 (save_configuration): Use the renamed functions.
2360 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2362 * src/widgets/Makefile.am:
2363 * src/widgets/modest-limit-retrieve-combo-box.c:
2364 * src/widgets/modest-limit-retrieve-combo-box.h:
2365 * src/widgets/modest-retrieve-combo-box.c:
2366 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2367 the account settings dialog.
2369 * src/modest-defs.h:
2370 * src/modest-account-mgr-helpers.h:
2371 * src/modest-account-mgr-helpers.c:
2372 (modest_server_account_get_option_secure_auth),
2373 (modest_server_account_set_option_secure_auth):
2374 * src/modest-account-mgr.c:
2375 (modest_account_mgr_add_server_account):
2376 Use the existing AUTH_MECH conf key for the secure-auth setting,
2377 instead of putting it in the list options, because this was actually used already.
2379 * src/maemo/modest-account-settings-dialog.c:
2380 (create_page_account_details),
2381 (modest_account_settings_dialog_set_account_name),
2382 (save_configuration):
2383 * src/maemo/modest-account-settings-dialog.h:
2384 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2385 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2387 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2389 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2390 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2391 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2393 * src/modest-defs.h:
2394 * src/maemo/modest-account-settings-dialog.c:
2395 (create_page_incoming), (on_combo_outgoing_security_changed),
2396 (on_combo_incoming_security_changed), (create_page_outgoing),
2397 (modest_account_settings_dialog_set_account_name),
2398 (save_configuration): Load/Save the port number, and change it when the
2399 security combo changes, to suitable defaults.
2401 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2403 * src/modest-account-mgr.c:
2404 (modest_account_mgr_add_server_account): Set the security and secure-auth
2405 options, and add a comment saying that the other camel-specific options should be
2408 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2410 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2412 * src/modest-tny-account-store.c: (account_list_free),
2413 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2414 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2417 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2419 * src/modest-protocol-info.c:
2420 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2421 is required by our UI spec. Maybe something in our implementation will use this eventually.
2422 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2423 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2424 instead of the previous 0 placeholder.
2426 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2427 secure-auth settings.
2428 * src/modest-account-mgr-helpers.h:
2429 * src/modest-account-mgr-helpers.c:
2430 (modest_server_account_data_get_option_secure_auth),
2431 (modest_server_account_set_option_secure_auth),
2432 (modest_server_account_data_get_option_security),
2433 (modest_server_account_set_option_security): Added this API for getting and setting the security
2434 and secure-auth settings.
2436 * src/maemo/modest-account-settings-dialog.h:
2437 * src/maemo/modest-account-settings-dialog.c:
2438 (modest_account_settings_dialog_finalize), (check_data),
2439 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2440 about changing titles.
2441 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2442 (save_configuration): Save the security and secure-auth settings.
2444 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2445 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2447 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2449 * src/modest-defs.h:
2450 * src/modest-account-mgr.c:
2451 (modest_account_mgr_add_server_account):
2452 Added and used defines for the options key and value pair strings,
2453 that are used so far, though they do not seem to correspond to anything in our
2454 UI specs or ModestProtocol enum.
2456 * src/modest-account-mgr-helpers.h:
2457 * src/modest-account-mgr-helpers.c:
2458 (compare_option_strings_for_name),
2459 (modest_server_account_data_get_option_value),
2460 (modest_server_account_data_get_option_bool),
2461 (modest_account_mgr_get_server_account_option):
2462 Added helper functions for parsing the options GSList.
2464 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2466 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2467 display name is based on the supplied account name.
2468 * src/modest-account-mgr.c:
2469 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2470 with an inefficient, but good-enough, implementation.
2472 * src/maemo/easysetup/modest-easysetup-wizard.c:
2473 (create_page_account_details), (on_before_next), (create_account):
2474 Check for existing display names rather than (non-user-visible) account names, and just
2475 create and set a unique account name at the end.
2477 * src/maemo/modest-account-settings-dialog.c:
2478 (modest_account_settings_dialog_init),
2479 (modest_account_settings_dialog_set_account_name),
2480 (create_page_incoming): Show the display name, instead of the account name.
2481 (on_response): Do some (not all) extra checks, as in the UI spec.
2482 (save_configuration): Save the display name if it was changed.
2484 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2486 * po/en_GB.po: Added needed logical ID and translation.
2487 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2488 (init_view): Made the is-default column clicking work.
2490 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2493 * src/maemo/easysetup/Makefile.am:
2494 * src/maemo/easysetup/modest-easysetup-wizard.c:
2495 (modest_easysetup_wizard_dialog_init):
2496 * src/maemo/easysetup/provider-data-test.keyfile:
2497 * src/maemo/easysetup/provider-data.keyfile:
2498 Moved the provider data file to the new modest-providers-data package and used it from there.
2500 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-local-folder-info.c:
2503 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2504 N_() was already used on the static strings, but this just marks it for translation without
2505 using the translation.
2507 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/modest-account-settings-dialog.c:
2510 (create_page_incoming),
2511 (modest_account_settings_dialog_set_account_name):
2512 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2513 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2514 I will do this if nobody else gets there first.
2516 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2518 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2519 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2520 save the security stuff.
2522 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2524 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2525 Set the email address and user fullname, which I now see must be
2528 * src/maemo/modest-account-settings-dialog.h:
2529 * src/maemo/modest-account-settings-dialog.c:
2531 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2532 leave-on-server and authentication.
2533 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2536 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2539 * src/maemo/modest-account-settings-dialog.c:
2540 * src/maemo/modest-account-settings-dialog.h:
2541 Most (but not all) of the widgets are now present as specified by the UI spec.
2542 No changes are yet saved, and some details are not properly shown yet.
2544 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2546 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/Makefile.am:
2549 * src/maemo/modest-account-settings-dialog.c:
2550 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2551 an existing account. Doesn't do much yet.
2553 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2554 Open the accounts settings dialog when Edit is clicked.
2556 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/easysetup/Makefile.am:
2559 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2561 * src/maemo/easysetup/modest-easysetup-wizard.c:
2562 (modest_easysetup_wizard_dialog_init):
2563 Try to get the source directory from the build system,
2564 instead of hard-coding "./" into the source code, when opening our local
2565 copies of the configuration files.
2566 But this still fails when opening the wizard from the Accounts window,
2567 maybe because the working directory seems to change at runtime.
2568 So the wizard will fail the second time unless you copy the files into their
2569 proper locations - see the stdout warnings for the paths.
2571 (create_page_account_details),(on_before_next):
2572 Check for existing non-server accounts instead of server accounts,
2573 so the default account name is useful again, and to prevent trying to
2576 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2577 Show the wizard when New is clicked.
2579 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2580 (init_view): Show the column headers, and show the columns that are
2581 specified in the UI specs. However, something in Maemo's GTK+ prevents
2582 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2583 change the default account. This is despite unsetting the special properties.
2585 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2587 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2588 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2589 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2590 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2591 to make that clearer.
2592 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2594 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2596 * src/maemo/modest-account-view-window.c:
2597 (modest_account_view_window_init),
2598 (modest_account_view_window_new):
2599 Use the same buttons as specified in the
2600 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2601 the existing widgets, which never had a chance of working.
2602 Put the ModestAccountView treeview in a scrolled window.
2603 Do not repeat the initialization in both _init() and _new().
2605 * src/widgets/modest-account-view.c: (update_account_view):
2606 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2607 this widget and window shows no accounts.
2609 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2611 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/easysetup/modest-easysetup-wizard.c:
2614 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2615 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2616 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2619 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2620 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2621 accounts exist yet, as in the UI spec.
2623 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2625 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2627 * src/maemo/Makefile.am:
2628 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2629 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2630 New window for editing connection-specific smtp details.
2631 Not fully implemented.
2633 * src/maemo/modest-connection-specific-smtp-window.c:
2634 (modest_connection_specific_smtp_window_finalize) :
2635 unref the tree model.
2636 (on_button_edit): Show the edit window.
2638 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2640 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2643 * src/maemo/Makefile.am:
2644 * src/maemo/modest-connection-specific-smtp-window.c:
2645 * src/maemo/modest-connection-specific-smtp-window.h:
2646 New window for showing the list of connections, for connection-specific
2647 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2648 * src/maemo/easysetup/modest-easysetup-wizard.c:
2649 (create_page_custom_outgoing): Show the new window when the button is clicked.
2651 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2653 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2654 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2655 * src/maemo/modest-msg-edit-window.c:
2656 (modest_msg_edit_window_insert_image):
2657 * src/modest-conf.c: (modest_conf_key_escape):
2658 * src/modest-mail-operation.c:
2659 (modest_mail_operation_send_new_mail):
2660 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2661 (modest_ui_actions_on_new_account):
2662 * src/widgets/modest-attachment-view.c: (update_filename_request):
2663 * src/widgets/modest-mail-header-view.c:
2664 Corrected warnings that were breaking the build, by commenting out unused variables,
2665 and a function, and by including a header.
2667 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2669 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2670 so we can #ifdef around platform-specific code when necessary.
2671 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2672 to allow this to build for the GNOME platform too.
2674 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2676 * src/maemo/easysetup/modest-easysetup-wizard.c:
2677 Added util_increment_name() and used it in create_page_account_details()
2678 to make sure that the default account name is always a new name.
2680 (modest_easysetup_wizard_dialog_init),
2681 (set_default_custom_servernames): Some minor memory management fixes.
2683 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2687 * src/modest-runtime.c: (init_i18n): Restored the translation
2688 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2689 are defined in config.h, and the translations are installed.
2691 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2692 is defined for translation.
2694 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2698 * src/maemo/easysetup/modest-easysetup-wizard.c:
2699 (modest_easysetup_wizard_dialog_init):
2700 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2701 Use realistic paths (though they should use $prefix generically) to the
2702 mcc_mapping and provider-data.keyfile files which might work when they
2703 are installed by the future version of the operator-wizard package,
2704 and then fallback to paths in our source code, with an explanatory
2707 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/Makefile.am:
2712 * src/maemo/easysetup/: Added files from the previously-exernal
2713 osso-modest-easysetup.
2714 * src/maemo/modest-main-window-ui.h:
2715 * src/modest-ui-actions.c:
2716 * src/modest-ui-actions.h:
2717 Added modest_ui_actions_on_new_account() as a signal handler for the
2718 New Account menu item. It shows the easysetup wizard.
2719 * po/en_GB.po: Added additional needed logical IDs and translations.
2721 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2722 Apparently ChangeLog is not used for some vague Nokia legal reasons.