git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/widgets/modest-validating-entry.h:
   4         * src/widgets/modest-validating-entry.c: (on_insert_text),
   5         Added easysetup_validating_entry_set_max_func(), used to set a callback
   6         to call when the max number of characters is reached. GtkEntry has a max-length
   7         already but is silent about it.
   8
   9         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
  10         (create_page_account_details), (create_page_user_details),
  11         (create_account):
  12         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
  13         (create_page_account_details), (create_page_user_details),
  14         (create_page_outgoing):
  15         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
  16         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
  17         the UI spec, when the user tries to enter more than the max number of characters.
  18
  19 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  20
  21         * src/maemo/easysetup/modest-easysetup-wizard.c:
  22         (create_page_user_details), (create_page_custom_incoming),
  23         (create_page_custom_outgoing):
  24         * src/maemo/modest-account-settings-dialog.c:
  25         (create_page_user_details), (create_page_incoming),
  26         (create_page_outgoing):
  27         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  28         (modest_connection_specific_smtp_edit_window_init):
  29         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
  30         not appropriate. Bad Maemo-specific defaults!.
  31
  32 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  33
  34         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
  35         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
  36         (modest_signature_editor_dialog_set_settings):
  37         Disable the label and textview when the checkbox is disabled, and use the
  38         specified (UI spec) default signature text.
  39
  40 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  41
  42         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  43         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
  44
  45         * src/modest-defs.h:
  46         * src/modest-account-mgr-helpers.h:
  47         * src/modest-account-mgr-helpers.c:
  48         Added modest_account_mgr_get/set_signature(), using new gconf keys.
  49
  50         * src/maemo/Makefile.am:
  51         * src/maemo/modest-signature-editor-dialog.c:
  52         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
  53         as per the UI spec.
  54
  55         * src/maemo/modest-account-settings-dialog.h:
  56         * src/maemo/modest-account-settings-dialog.c:
  57         (modest_account_settings_dialog_finalize), (on_button_signature),
  58         (save_configuration): Use the new dialog when the Edit button is pressed, and
  59         save the changes if necessary, as per the UI spec.
  60
  61 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  62
  63         * src/maemo/Makefile.am:
  64         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
  65         based on maemo-develoers email from Dirk.
  66
  67         * src/maemo/easysetup/modest-easysetup-wizard.c:
  68         (create_page_welcome), (create_page_account_details),
  69         (create_page_user_details), (create_page_complete_easysetup),
  70         (create_page_custom_incoming), (create_page_custom_outgoing),
  71         (create_page_complete_custom),
  72         (modest_easysetup_wizard_dialog_init):
  73         * src/maemo/modest-account-settings-dialog.c:
  74         (create_page_account_details), (create_page_user_details),
  75         (create_page_incoming), (create_page_outgoing),
  76         (modest_account_settings_dialog_init):
  77         * src/maemo/modest-connection-specific-smtp-window.c:
  78         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
  79
  80 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  81
  82         * src/maemo/easysetup/modest-easysetup-wizard.c:
  83         (create_page_account_details), (create_page_custom_outgoing),
  84         (create_page_complete_custom):
  85         * src/maemo/modest-account-settings-dialog.c:
  86         (create_page_user_details), (create_page_incoming),
  87         (create_page_outgoing):
  88         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  89         (modest_connection_specific_smtp_edit_window_init):
  90         Use the correct (UI spec) port min/max, and use horizontal separators,
  91         as per the UI spec.
  92
  93 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  94
  95         * src/maemo/easysetup/modest-easysetup-wizard.c:
  96         (set_default_custom_servernames):
  97         * src/maemo/modest-account-settings-dialog.c:
  98         (create_page_incoming), (on_combo_outgoing_security_changed),
  99         (on_combo_incoming_security_changed), (create_page_outgoing),
 100         (modest_account_settings_dialog_set_account_name),
 101         (save_configuration):
 102         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 103         (on_combo_security_changed),
 104         (modest_connection_specific_smtp_edit_window_init),
 105         (modest_connection_specific_smtp_edit_window_set_connection),
 106         (modest_connection_specific_smtp_edit_window_get_settings):
 107         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 108         as per the UI spec.
 109
 110 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 111
 112         * po/en_GB.po:
 113         * src/maemo/easysetup/modest-easysetup-wizard.c:
 114         (create_page_custom_outgoing), (create_page_complete_custom):
 115         * src/maemo/modest-account-settings-dialog.c:
 116         (create_page_user_details), (create_page_outgoing):
 117         * src/maemo/modest-account-view-window.c: (button_box_new):
 118         Use changed logical IDs as per the most recent UI spec:
 119         mcen_bd_emailsetup_edit -> mcen_bd_edit
 120         mcen_bd_emailsetup_delete -> mcen_bd_delete
 121         mcen_bd_emailsetup_close -> mcen_bd_close
 122
 123 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 124
 125         * configure.ac:
 126         * src/Makefile.am:
 127         * src/dbus_api/Makefile.am:
 128         * src/dbus_api/modest-dbus-callbacks.c:
 129         * src/dbus_api/modest-dbus-callbacks.h:
 130         * src/maemo/modest-platform.c: (modest_platform_init):
 131         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 132         method.
 133         * tests/Makefile.am:
 134         * tests/dbus_api/Makefile.am:
 135         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 136
 137 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 138
 139         * src/maemo/modest-account-settings-dialog.c:
 140         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 141         Removed unnecessary includes.
 142
 143 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 144
 145         * src/maemo/easysetup/modest-easysetup-wizard.c:
 146         * src/maemo/modest-account-settings-dialog.c:
 147         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 148         * src/widgets/Makefile.am:
 149         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 150         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 151         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 152         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 153         * src/widgets/modest-secureauth-combo-box.c:
 154         * src/widgets/modest-secureauth-combo-box.h:
 155         * src/widgets/modest-serversecurity-combo-box.c:
 156         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 157         made the GObject names more consistent with the rest of the Modest code.
 158
 159 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 160
 161         * src/maemo/easysetup/Makefile.am:
 162         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 163         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 164         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 165         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 166         * src/maemo/easysetup/modest-easysetup-wizard.c:
 167         * src/maemo/easysetup/modest-validating-entry.c:
 168         * src/maemo/easysetup/modest-validating-entry.h:
 169         * src/maemo/modest-account-settings-dialog.c:
 170         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 171         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 172         widgets/ because they are used outside of easysetup too. After checking in,
 173         svn will allow me to rename them too.
 174
 175 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 176
 177         * src/gnome/modest-msg-edit-window.c:
 178         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 179         linker error, to fix the build on the GNOME platform.
 180         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 181         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 182         ifdefed out to avoid a warning.
 183
 184 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 185
 186         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 187         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 188         some alternative for GTK+ 2.6.
 189
 190 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 191
 192         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 193
 194         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 195         specified for EmailAccountsDialog in UI spec.
 196
 197         * src/maemo/easysetup/modest-easysetup-wizard.c:
 198         * src/maemo/easysetup/modest-easysetup-wizard.h:
 199         * src/maemo/modest-account-settings-dialog.c:
 200         * src/maemo/modest-account-settings-dialog.h:
 201         Reuse a member window widget for the connection-specific SMTP server accounts,
 202         so we can tell it to create/save the accounts only if we actually save changes.
 203
 204         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 205         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 206         (modest_connection_specific_smtp_edit_window_get_settings):
 207         Return a struct instance for temporarily remembering the entered data.
 208
 209         * src/maemo/modest-connection-specific-smtp-window.h:
 210         * src/maemo/modest-connection-specific-smtp-window.c:
 211         (modest_connection_specific_smtp_window_finalize),
 212         (modest_connection_specific_smtp_window_fill_with_connections),
 213         (on_button_edit),
 214         (modest_connection_specific_smtp_window_save_server_accounts),
 215         (update_model_server_names): Do not actually save data until asked,
 216         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 217
 218         (on_selection_changed),
 219         (modest_connection_specific_smtp_window_init): Disable the edit
 220         button when nothing is selected.
 221
 222         * src/modest-account-mgr-helpers.c:
 223         * src/modest-account-mgr-helpers.h:
 224         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 225         elsewhere.
 226
 227 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 228
 229         * src/modest-account-mgr-helpers.h:
 230         * src/modest-account-mgr-helpers.c:
 231         (modest_account_mgr_get_unused_account_name),
 232         (modest_account_mgr_get_unused_account_display_name): Added these
 233         utility functions, to avoid code duplication.
 234
 235         * src/maemo/easysetup/modest-easysetup-wizard.c:
 236         (create_page_account_details), (create_account):
 237         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 238         (on_combo_security_changed),
 239         (modest_connection_specific_smtp_edit_window_init),
 240         (modest_connection_specific_smtp_edit_window_save_settings):
 241         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 242         * src/maemo/modest-connection-specific-smtp-window.c:
 243         (modest_connection_specific_smtp_window_finalize),
 244         (modest_connection_specific_smtp_window_fill_with_connections),
 245         (on_button_edit), (modest_connection_specific_smtp_window_init):
 246         * src/maemo/modest-connection-specific-smtp-window.h:
 247         Implementing saving of connection-specific server accounts.
 248
 249         But I need to refactor this so we can save the data for each
 250         possible connection-specific account and only actually create the server accounts
 251         when the easysetup finished, or the OK button is pressed on the account settings
 252         dialog.
 253
 254 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 255
 256         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 257         (on_combo_security_changed):
 258         (modest_connection_specific_smtp_edit_window_init):
 259         Auto-fill the port number as in the account settings.
 260
 261         (modest_connection_specific_smtp_edit_window_set_connection):
 262         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 263         * src/maemo/modest-connection-specific-smtp-window.c:
 264         (fill_with_connections), (on_button_edit),
 265         (modest_connection_specific_smtp_window_init):
 266         Turn the edit window into a dialog to simplify the code, and
 267         set a WM hint as in a GtkDialog, because only a popup can be on top of
 268         another window in Maemo, and popups usually have no WM decoration.
 269
 270         * src/modest-defs.h:
 271         * src/modest-account-mgr-helpers.c:
 272         (modest_account_mgr_set_connection_specific_smtp),
 273         (modest_account_mgr_remove_connection_specific_smtp),
 274         (modest_account_mgr_get_connection_specific_smtp):
 275         * src/modest-account-mgr-helpers.h: Some functions to write the
 276         connection-specific SMTP server information. Not yet used.
 277
 278
 279         * src/widgets/modest-folder-view.c: (text_cell_data):
 280         Fix a warning about an uninitialized variable.
 281         (on_configuration_key_changed): Put an #ifdef around the use
 282         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 283
 284 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 285
 286         * src/maemo/modest-account-settings-dialog.h:
 287         * src/maemo/modest-account-settings-dialog.c:
 288         Added connect_for_modified() utility function to mark the new modified boolean.
 289
 290         (create_page_account_details), (create_page_user_details),
 291         (create_page_incoming), (create_page_outgoing), (on_response),
 292         (modest_account_settings_dialog_init),
 293         (modest_account_settings_dialog_set_account_name):
 294         Only warn about unsaved changes when there are actually unsaved changes.
 295
 296         * src/modest-account-mgr-helpers.c:
 297         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 298         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 299         to get the data from there in future.
 300
 301 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 302
 303         * src/modest-defs.h:
 304
 305         * src/modest-account-mgr-helpers.h:
 306         * src/modest-account-mgr-helpers.c:
 307         Store the security account setting in a single conf key instead of using
 308         the options list, so that the list is left for just the to-be-removed camel hack,
 309         and because gconf_client_set_list() is failing for some reason.
 310
 311         * src/modest-account-mgr.c:
 312         (modest_account_mgr_add_server_account):
 313         * src/maemo/modest-account-settings-dialog.c:
 314         (modest_account_settings_dialog_set_account_name),
 315         (save_configuration): Use the renamed functions.
 316
 317
 318 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 319
 320         * src/widgets/Makefile.am:
 321         * src/widgets/modest-limit-retrieve-combo-box.c:
 322         * src/widgets/modest-limit-retrieve-combo-box.h:
 323         * src/widgets/modest-retrieve-combo-box.c:
 324         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 325         the account settings dialog.
 326
 327         * src/modest-defs.h:
 328         * src/modest-account-mgr-helpers.h:
 329         * src/modest-account-mgr-helpers.c:
 330         (modest_server_account_get_option_secure_auth),
 331         (modest_server_account_set_option_secure_auth):
 332         * src/modest-account-mgr.c:
 333         (modest_account_mgr_add_server_account):
 334         Use the existing AUTH_MECH conf key for the secure-auth setting,
 335         instead of putting it in the list options, because this was actually used already.
 336
 337         * src/maemo/modest-account-settings-dialog.c:
 338         (create_page_account_details),
 339         (modest_account_settings_dialog_set_account_name),
 340         (save_configuration):
 341         * src/maemo/modest-account-settings-dialog.h:
 342         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 343         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 344
 345 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 346
 347         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 348         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 349         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 350
 351         * src/modest-defs.h:
 352         * src/maemo/modest-account-settings-dialog.c:
 353         (create_page_incoming), (on_combo_outgoing_security_changed),
 354         (on_combo_incoming_security_changed), (create_page_outgoing),
 355         (modest_account_settings_dialog_set_account_name),
 356         (save_configuration): Load/Save the port number, and change it when the
 357         security combo changes, to suitable defaults.
 358
 359 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 360
 361         * src/modest-account-mgr.c:
 362         (modest_account_mgr_add_server_account): Set the security and secure-auth
 363         options, and add a comment saying that the other camel-specific options should be
 364         removed in future.
 365
 366 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 367
 368         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 369         found by valgrind.
 370         * src/modest-tny-account-store.c: (account_list_free),
 371         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 372         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 373         easy to fix.
 374
 375 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 376
 377         * src/modest-protocol-info.c:
 378         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 379         is required by our UI spec. Maybe something in our implementation will use this eventually.
 380         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 381         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 382         instead of the previous 0 placeholder.
 383
 384         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 385         secure-auth settings.
 386         * src/modest-account-mgr-helpers.h:
 387         * src/modest-account-mgr-helpers.c:
 388         (modest_server_account_data_get_option_secure_auth),
 389         (modest_server_account_set_option_secure_auth),
 390         (modest_server_account_data_get_option_security),
 391         (modest_server_account_set_option_security): Added this API for getting and setting the security
 392         and secure-auth settings.
 393
 394         * src/maemo/modest-account-settings-dialog.h:
 395         * src/maemo/modest-account-settings-dialog.c:
 396         (modest_account_settings_dialog_finalize), (check_data),
 397         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 398         about changing titles.
 399         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 400         (save_configuration): Save the security and secure-auth settings.
 401
 402         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 403         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 404
 405 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 406
 407         * src/modest-defs.h:
 408         * src/modest-account-mgr.c:
 409         (modest_account_mgr_add_server_account):
 410         Added and used defines for the options key and value pair strings,
 411         that are used so far, though they do not seem to correspond to anything in our
 412         UI specs or ModestProtocol enum.
 413
 414         * src/modest-account-mgr-helpers.h:
 415         * src/modest-account-mgr-helpers.c:
 416         (compare_option_strings_for_name),
 417         (modest_server_account_data_get_option_value),
 418         (modest_server_account_data_get_option_bool),
 419         (modest_account_mgr_get_server_account_option):
 420         Added helper functions for parsing the options GSList.
 421
 422 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 423
 424         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 425         display name is based on the supplied account name.
 426         * src/modest-account-mgr.c:
 427         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 428         with an inefficient, but good-enough, implementation.
 429
 430         * src/maemo/easysetup/modest-easysetup-wizard.c:
 431         (create_page_account_details), (on_before_next), (create_account):
 432         Check for existing display names rather than (non-user-visible) account names, and just
 433         create and set a unique account name at the end.
 434
 435         * src/maemo/modest-account-settings-dialog.c:
 436         (modest_account_settings_dialog_init),
 437         (modest_account_settings_dialog_set_account_name),
 438         (create_page_incoming): Show the display name, instead of the account name.
 439         (on_response): Do some (not all) extra checks, as in the UI spec.
 440         (save_configuration): Save the display name if it was changed.
 441
 442 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 443
 444         * po/en_GB.po: Added needed logical ID and translation.
 445         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 446         (init_view): Made the is-default column clicking work.
 447
 448 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 449
 450         * configure.ac:
 451         * src/maemo/easysetup/Makefile.am:
 452         * src/maemo/easysetup/modest-easysetup-wizard.c:
 453         (modest_easysetup_wizard_dialog_init):
 454         * src/maemo/easysetup/provider-data-test.keyfile:
 455         * src/maemo/easysetup/provider-data.keyfile:
 456         Moved the provider data file to the new modest-providers-data package and used it from there.
 457
 458 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 459
 460         * src/modest-local-folder-info.c:
 461         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 462         N_() was already used on the static strings, but this just marks it for translation without
 463         using the translation.
 464
 465 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 466
 467         * src/maemo/modest-account-settings-dialog.c:
 468         (create_page_incoming),
 469         (modest_account_settings_dialog_set_account_name):
 470         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 471         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 472         I will do this if nobody else gets there first.
 473
 474 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 475
 476         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 477         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 478         save the security stuff.
 479
 480 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 481
 482         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 483         Set the email address and user fullname, which I now see must be
 484         done separately.
 485
 486         * src/maemo/modest-account-settings-dialog.h:
 487         * src/maemo/modest-account-settings-dialog.c:
 488          (on_response),
 489         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 490         leave-on-server and authentication.
 491         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 492         how to do the rest.
 493
 494 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 495
 496
 497         * src/maemo/modest-account-settings-dialog.c:
 498         * src/maemo/modest-account-settings-dialog.h:
 499         Most (but not all) of the widgets are now present as specified by the UI spec.
 500         No changes are yet saved, and some details are not properly shown yet.
 501
 502         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 503
 504 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 505
 506         * src/maemo/Makefile.am:
 507         * src/maemo/modest-account-settings-dialog.c:
 508         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 509         an existing account. Doesn't do much yet.
 510
 511         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 512         Open the accounts settings dialog when Edit is clicked.
 513
 514 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 515
 516         * src/maemo/easysetup/Makefile.am:
 517         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 518         (load_from_file):
 519         * src/maemo/easysetup/modest-easysetup-wizard.c:
 520         (modest_easysetup_wizard_dialog_init):
 521         Try to get the source directory from the build system,
 522         instead of hard-coding "./" into the source code, when opening our local
 523         copies of the configuration files.
 524         But this still fails when opening the wizard from the Accounts window,
 525         maybe because the working directory seems to change at runtime.
 526         So the wizard will fail the second time unless you copy the files into their
 527         proper locations - see the stdout warnings for the paths.
 528
 529         (create_page_account_details),(on_before_next):
 530         Check for existing non-server accounts instead of server accounts,
 531         so the default account name is useful again, and to prevent trying to
 532         recreate accounts.
 533
 534         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 535         Show the wizard when New is clicked.
 536
 537         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 538         (init_view): Show the column headers, and show the columns that are
 539         specified in the UI specs. However, something in Maemo's GTK+ prevents
 540         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 541         change the default account. This is despite unsetting the special properties.
 542
 543 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 544
 545         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 546         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 547         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 548         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 549         to make that clearer.
 550         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 551
 552 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 553
 554         * src/maemo/modest-account-view-window.c:
 555         (modest_account_view_window_init),
 556         (modest_account_view_window_new):
 557         Use the same buttons as specified in the
 558         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 559         the existing widgets, which never had a chance of working.
 560         Put the ModestAccountView treeview in a scrolled window.
 561         Do not repeat the initialization in both _init() and _new().
 562
 563         * src/widgets/modest-account-view.c: (update_account_view):
 564         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 565         this widget and window shows no accounts.
 566
 567         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 568
 569 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 570
 571         * src/maemo/easysetup/modest-easysetup-wizard.c:
 572         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 573         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 574         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 575         which seems wrong.
 576
 577         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 578         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 579         accounts exist yet, as in the UI spec.
 580
 581         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 582
 583 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 584
 585         * src/maemo/Makefile.am:
 586         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 587         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 588         New window for editing connection-specific smtp details.
 589         Not fully implemented.
 590
 591         * src/maemo/modest-connection-specific-smtp-window.c:
 592         (modest_connection_specific_smtp_window_finalize) :
 593         unref the tree model.
 594         (on_button_edit): Show the edit window.
 595
 596 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 597
 598         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 599         error for me.
 600
 601         * src/maemo/Makefile.am:
 602         * src/maemo/modest-connection-specific-smtp-window.c:
 603         * src/maemo/modest-connection-specific-smtp-window.h:
 604         New window for showing the list of connections, for connection-specific
 605         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 606         * src/maemo/easysetup/modest-easysetup-wizard.c:
 607         (create_page_custom_outgoing): Show the new window when the button is clicked.
 608
 609 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 610
 611         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 612         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 613         * src/maemo/modest-msg-edit-window.c:
 614         (modest_msg_edit_window_insert_image):
 615         * src/modest-conf.c: (modest_conf_key_escape):
 616         * src/modest-mail-operation.c:
 617         (modest_mail_operation_send_new_mail):
 618         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 619         (modest_ui_actions_on_new_account):
 620         * src/widgets/modest-attachment-view.c: (update_filename_request):
 621         * src/widgets/modest-mail-header-view.c:
 622         Corrected warnings that were breaking the build, by commenting out unused variables,
 623         and a function, and by including a header.
 624
 625 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 626
 627         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 628         so we can #ifdef around platform-specific code when necessary.
 629         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 630         to allow this to build for the GNOME platform too.
 631
 632 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 633
 634         * src/maemo/easysetup/modest-easysetup-wizard.c:
 635         Added util_increment_name() and used it in create_page_account_details()
 636         to make sure that the default account name is always a new name.
 637
 638         (modest_easysetup_wizard_dialog_init),
 639         (set_default_custom_servernames): Some minor memory management fixes.
 640
 641 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 642
 643         * Makefile.am:
 644         * configure.ac:
 645         * src/modest-runtime.c: (init_i18n): Restored the translation
 646         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 647         are defined in config.h, and the translations are installed.
 648
 649         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 650         is defined for translation.
 651
 652 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 653
 654         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 655         (load_from_file):
 656         * src/maemo/easysetup/modest-easysetup-wizard.c:
 657         (modest_easysetup_wizard_dialog_init):
 658         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 659         Use realistic paths (though they should use $prefix generically) to the
 660         mcc_mapping and provider-data.keyfile files which might work when they
 661         are installed by the future version of the operator-wizard package,
 662         and then fallback to paths in our source code, with an explanatory
 663         warning.
 664
 665 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 666
 667         * configure.ac:
 668         * src/Makefile.am:
 669         * src/maemo/Makefile.am:
 670         * src/maemo/easysetup/: Added files from the previously-exernal
 671         osso-modest-easysetup.
 672         * src/maemo/modest-main-window-ui.h:
 673         * src/modest-ui-actions.c:
 674         * src/modest-ui-actions.h:
 675         Added modest_ui_actions_on_new_account() as a signal handler for the
 676         New Account menu item. It shows the easysetup wizard.
 677         * po/en_GB.po: Added additional needed logical IDs and translations.
 678
 679 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 680 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 681