1 2007-08-16 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-msg-view-window.h:
4 * src/gnome/modest-msg-view-window.c:
5 * src/maemo/modest-msg-view-window.c:
6 Added modest_msg_view_window_construct().
7 (modest_msg_view_window_new_with_header_model),
8 Added modest_msg_view_window_new_for_search_result),
9 Renamed modest_msg_view_window_new() to
10 modest_msg_view_window_new_for_attachment(),
11 and modest_msg_view_window_is_search_result(),
12 so we can explicitly know that the window is for an
13 attachment or a search result or a message from the list.
15 (modest_msg_view_window_view_attachment):
16 * src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
17 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
18 Use modest_msg_view_window_new_for_search_result().
20 * src/modest-ui-dimming-rules.c:
21 (modest_ui_dimming_rules_on_delete_msg): Dim the delete button
22 for search results, fixing projects.maemo.org bug NB#63811.
24 2007-08-16 Armin Burgmeier <armin@openismus.com>
26 * src/modest-ui-actions.c: Show a banner instead of a dialog when
27 renaming a folder fails, to stay consistent with what happens when
28 creating a folder fails.
30 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
31 slightly country loading from the mmc_mappings file, fixed a memory
34 2007-08-16 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-tny-account-store.c: (volume_path_is_mounted):
37 Check the GnomeVFSVolume activation path instead of the device path,
38 so that the memory card is really really shown in the UI.
40 2007-08-16 Murray Cumming <murrayc@murrayc.com>
42 * src/maemo/easysetup/modest-easysetup-wizard.c:
43 (get_entered_account_title), (on_before_next), (entry_is_empty),
45 * src/maemo/modest-account-settings-dialog.c:
46 (get_entered_account_title), (on_button_signature), (check_data),
47 (save_configuration), (entry_is_empty):
48 Strip the account title of whitespace at the start and end before
49 using it or checking it. This means that an all-whitespace title
50 is not allowed, fixing projects.maemo.org bug NB#64977.
52 2007-08-15 Murray Cumming <murrayc@murrayc.com>
54 * src/modest-ui-actions.h:
55 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
56 to modest_run_account_setup_wizard() and made it public.
57 * src/dbus_api/modest-dbus-callbacks.c:
58 (check_and_offer_account_creation), (on_idle_mail_to),
59 (on_idle_compose_mail), (on_idle_open_default_inbox):
60 Offer account creation if necessary, fixing projects.maemo.org
63 2007-08-15 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-ui-actions.c: (run_account_setup_wizard):
66 Return a gboolean to indicate success.
67 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
68 (modest_ui_actions_on_send): When offering account creation, only
69 give up (return) if account creation failed. Otherwise continue
70 with the original request. This fixed projects.maemo.org bug
73 2007-08-15 Murray Cumming <murrayc@murrayc.com>
75 * src/widgets/modest-recpt-editor.c:
76 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
77 to fix projects.maemo.org bug NB#63789.
79 2007-08-15 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
82 (modest_tny_account_store_new): Properly detect the memory card at
83 startup, and add an account for it.
85 2007-08-14 Murray Cumming <murrayc@murrayc.com>
87 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
88 Commented out the MMC code again because it mistakenly detects
89 the card even when it isn't inserted.
91 2007-08-14 Murray Cumming <murrayc@murrayc.com>
93 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
94 Renabled the call to add_mmc_account() because I do not believe
95 it could be the cause of the mentioned hang (in scratchbox, where
96 there is no memory card), and because I have tested that it works
99 2007-08-14 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
102 Comment out part of the last commit because it apparently causes
105 2007-08-14 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-tny-account-store.c: Added the add_mmc_account()
108 function to save some copy/pasting.
109 (modest_tny_account_store_new): If the memory card is mounted,
110 create an account for it at the start, instead of waiting for the
111 user to unmount it and mount it.
113 2007-08-13 Murray Cumming <murrayc@murrayc.com>
115 * src/widgets/modest-account-view.c: (on_account_changed):
116 Do not try to use the human-readable TnyAccount name instead of the
117 ID of the modest account to get the transport account. And unref
118 the transport account. This prevents a g_warning(), and a possible
121 2007-08-13 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/modest-platform.c:
124 (modest_platform_set_update_interval): Handle the new
125 alarmd error to warn when alarmd is not running, as is the case in
126 scratchbox for me now because
127 "Module /usr/lib/alarmd/libretu.so initialization failed"
129 2007-08-13 Murray Cumming <murrayc@murrayc.com>
131 * src/widgets/modest-header-view-render.c:
132 (_modest_header_view_compact_header_cell_data):
133 NULL some strings after freeing them, trying to deal with
134 the double deletion found in projects.maemo.org bug 64183,
135 probably having no effect.
137 2007-08-13 Murray Cumming <murrayc@murrayc.com>
139 * src/maemo/modest-account-settings-dialog.c:
140 (create_page_incoming), (create_page_outgoing): Use a define
141 for the min and max port numbers.
143 (check_hildon_number_editor_and_warn_value_not_in_range),
144 (check_data): Do an extra check for an invalid port number, as needed
145 in projects.maemo.org bug #64275, when the number is cleared, but this
146 does not work due to bugs.maemo.org bug #1806.
148 2007-08-13 Murray Cumming <murrayc@murrayc.com>
150 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
151 Comment out the debug warning about the unexpected D-Bus methods.
152 They are just annoying now.
153 * src/maemo/modest-platform.c:
154 (modest_platform_set_update_interval): Correct the D-Bus path, instead
155 of using a file path, though it did not seem to break things before.
156 It might be needed now:
157 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
158 modest is not already running. This is the behaviour of the old client, and
159 Mox says it is what we should do for modest.
160 This closes projects.maemo.org bug NB#64327.
162 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
164 * src/modest-text-utils.c:
165 Fixed invalid jump due to incorrect string/pointer
167 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
170 2007-08-01 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-account-mgr-helpers.h:
173 * src/modest-account-mgr-helpers.c:
174 Added modest_account_mgr_get_first_account_name(),
175 using code from modest_account_mgr_set_first_account_as_default().
177 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
178 (account_number_changed): Call set_at_least_one_account_visible() so that
179 the first account is visible when first added, without the user having to
181 I do wonder how this worked before.
183 2007-08-01 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-tny-account-store.c: (show_password_warning_only),
186 (show_wrong_password), (request_password_and_wait), (get_password),
187 (modest_tny_account_store_alert): Remove the (incomplete anyway)
188 attempts to show UI only in the main context, which used g_idle_add()
189 and mainloops, because tinymail now guarantees that it only calls these
190 callbacks in the mainloop with the gdk lock. This makes everything much
193 2007-08-01 Murray Cumming <murrayc@murrayc.com>
195 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
196 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
197 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
198 error dialog, instead of ignoring it.
200 2007-08-01 Murray Cumming <murrayc@murrayc.com>
202 * src/maemo/modest-msg-view-window.c:
203 (modest_msg_view_window_get_header),
204 (modest_msg_view_window_last_message_selected):
205 Added comments to explain the use of priv->header_model.
206 * src/modest-ui-dimming-rules.c:
207 (modest_ui_dimming_rules_on_open_msg),
208 (modest_ui_dimming_rules_on_mark_as_read_msg),
209 (modest_ui_dimming_rules_on_mark_as_unread_msg),
210 (modest_ui_dimming_rules_on_remove_attachments),
211 (_invalid_attach_selected), (_selected_msg_marked_as):
212 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
213 and changed the parameter to a ModestMainWindow to make it clearer that
214 it never uses any other kind of window.
215 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
216 instead of the selected message.
217 I notice that much of the dimming code and the ModestMsgViewWindow code
218 hard-codes the assumption that the viewed message is always selected in
219 the header view. This does not seem wise or simple.
221 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
222 examine the actual message instead of whatever might be selected
223 in the header view. This stops the delete toolbar button and menu item
224 from being dimmed when opening a message view the search UI,
225 partially fixing projects.maemo.org bug NB#63811.
227 However, when actually deleting, I now get this warning:
228 "tny_header_set_flags: This is a header instance for a new message.
229 Only priority and attachment flags are supported"
231 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
233 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
235 Show account wizard if no accounts are defined while sending
236 (automatic sending after the account wizard finished does not
237 work because it takes some time until the account manager
238 synchronizes everything. (projects.maemo.org NB#62792)
240 2007-07-30 Murray Cumming <murrayc@murrayc.com>
242 * src/modest-tny-account-store.c: (on_account_removed),
243 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
244 account is removed from the View menu. We have TnyAccountStore
245 and ModestTnyAccountStore signals that seem very similar, but this
246 seems to work for now.
248 * src/maemo/modest-main-window.c:
249 (on_show_account_action_activated): Prevent dereference
250 of a NULL if the accoutn does not really exist, though that
251 should not happen anymore.
253 This fixes projects.maemo.org bug NB#64606.
255 2007-07-30 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-ui-actions.c: (run_account_setup_wizard),
258 (modest_ui_actions_on_accounts): Revert a change that set these
259 to modal dialogs, freezing the UI when they show secondary dialogs.
260 This fixed projects.maemo.org bug NB#64519.
262 2007-07-27 Murray Cumming <murrayc@murrayc.com>
264 * src/widgets/modest-header-view-render.c:
265 (_modest_header_view_compact_header_cell_data):
266 Some checks and initialization to try to deal with a crash,
267 probably ineffective.
269 2007-07-27 Murray Cumming <murrayc@murrayc.com>
271 * src/maemo/modest-maemo-utils.c:
272 (modest_maemo_utils_get_supported_secure_authentication_methods):
273 Make sure that we have a connection, asking the user for one
275 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
276 Check for a connection before showing the wizard, because
277 the wizard needs a connection to check for server capabilities.
279 2007-07-27 Murray Cumming <murrayc@murrayc.com>
281 * src/maemo/modest-account-view-window.c:
282 (on_new_button_clicked): Remember the wizard dialog instance,
283 so we can just present it again if necessary. This prevents
284 multiple windows from appearing if you click again quickly on the
285 New button before the dialog appears, fixing projects.maemo.org
288 2007-07-27 Murray Cumming <murrayc@murrayc.com>
290 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
291 Offer a connection dialog if there is no connection when
292 starting modest. This should fix projects.maemo.org bug NB#61134.
294 2007-07-27 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
297 Reverted my last commit. I was able to fix the build by doing
298 apt-get install wpeditor0 (replacing other wpeditor packages) and
299 an explicit apt-get install wpeditor-dev to upgrade the -dev
302 2007-07-27 Murray Cumming <murrayc@murrayc.com>
304 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
305 Commented out the use of wp_text_buffer_replace_image()
306 because it does not exist, to break the build. Added a TODO for it.
308 2007-07-26 Murray Cumming <murrayc@murrayc.com>
310 * src/modest-tny-account-store.c: (recreate_all_accounts):
311 Recreate them even if they were NULL before. I guess something
312 else was already creating them before, or this would never
314 (modest_tny_account_store_get_server_account): Make sure that
315 the tny accounts have been created before trying to find one.
316 This allows libmodest_dbus_client_compose_mail() to work
317 when the UI is not yet visible.
318 This is probably useful in other cases too.
320 (get_password): When the password is wrong after it is entered
321 in the protected password dialog, show an info banner (in an
322 idle handler) before showing the protected password dialog
325 2007-07-26 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-ui-actions.h:
328 * src/modest-ui-actions.c: Added
329 modest_do_refresh_current_folder() containing some code from
330 modest_ui_actions_on_send_receive().
331 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
332 Call modest_do_refresh_current_folder() before refreshing the
333 requested account, as in modest_ui_actions_on_send_receive().
334 This is strange, but seems to be necessary to show new mails.
335 Now new emails are finally visible in the UI when downloaded
336 via the automatic update interval, fixing bug NB#57458.
337 This also works because bug NB#57458 has been fixed somehow.
339 2007-07-26 Murray Cumming <murrayc@murrayc.com>
341 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
342 printf more details when we get unhandled D-Bus methods, because
345 * src/modest-mail-operation.c: (update_account_thread):
346 Comment out the tny_camel_pop_store_account_reconnect(), because this
347 is apparently no longer needed, and it did not work before anyway.
348 See the comment in the code.
350 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
351 by checking the header flags. This fixes projects.maemo.org bug
354 2007-07-25 Murray Cumming <murrayc@murrayc.com>
356 * src/maemo/modest-maemo-utils.h:
357 * src/maemo/modest-maemo-utils.c: Added
358 modest_maemo_show_information_note_in_main_context_and_forget().
359 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
360 Use the new function to show simple error dialogs in the main
361 context, though question dialogs are still in the current context,
362 which is unfortunately usually not the main context. This should
365 2007-07-25 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account-store.c: (get_password):
368 Never save the entered username and password in gconf,
369 because the UI spec says we should not. This helps
370 slightly with projects.maemo.org bug NB#63671.
372 2007-07-25 Murray Cumming <murrayc@murrayc.com>
374 * src/widgets/modest-msg-edit-window.h:
375 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
376 Moved some code here to make it simpler.
377 (modest_msg_edit_window_attach_file_one): Renamed from
378 modest_msg_edit_window_attach_file_interactive().
379 (modest_msg_edit_window_offer_attach_file): Renamed from
380 modest_msg_edit_window_attach_file() and used
381 modest_msg_edit_window_attach_file_one() instead of
382 copy/pasting the code. The old code for one was not using
383 GnomeVFS. This allows use of smb:// URLs when using send-as
384 from external applications, fixing bug NB#63741.
386 (modest_msg_edit_window_insert_image),
387 (modest_msg_edit_window_add_attachment_clicked):
388 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
389 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
390 Adapted to the new function names.
392 2007-07-25 Murray Cumming <murrayc@murrayc.com>
394 (modest_platform_set_update_interval): Set the alarm recurrence
395 fields so that auto-update does not just happen the first time.
396 This should have fixed projects.maemo.org bug NB#63938.
398 When this happens you can see a printf when the D-Bus method is
400 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
402 However, I do not actually seem to get new POP messages even when
403 clicking the refresh button manually. A restart gets them.
404 This might be a problem in today's tinymail only.
406 2007-07-24 Murray Cumming <murrayc@murrayc.com>
408 * src/maemo/modest-maemo-global-settings-dialog.c:
409 (current_connection):
410 Avoid a crash (probably only in scratchbox) when strcmp()ing a
411 NULL when closing the dialog.
413 2007-07-24 Murray Cumming <murrayc@murrayc.com>
415 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
416 Remove the hacky send/receive that didn't work, and instead
417 refilter the treemodel to make the deleted email really vanish from
418 the UI (though the delete-from-menu code does has commented out
419 the code that does that). This fixes projects.maemo.org bug
422 2007-07-24 Murray Cumming <murrayc@murrayc.com>
424 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
425 Try a couple of tricks to force the treeview to update (
426 poke the folder, and do a send/receive refresh), but the deleted
427 email still appears with a strike-through instead of really being
430 2007-07-23 Murray Cumming <murrayc@murrayc.com>
432 * src/dbus_api/modest-dbus-callbacks.c:
433 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
434 because their ID is not human-readable (see the comment about
435 improvements needed to the osso-email-interface API) and
436 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
438 2007-07-23 Murray Cumming <murrayc@murrayc.com>
440 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
441 (add_folders_to_list), (on_dbus_method_get_folders),
442 (modest_dbus_req_filter):
443 * src/maemo/modest-maemo-utils.c:
444 (on_camel_account_get_supported_secure_authentication):
445 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
446 (on_header_view_focus_in):
447 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
448 * src/modest-formatter.c: (modest_formatter_create_body_part):
449 * src/modest-mail-operation.c: (recurse_folders),
450 (update_account_thread), (get_msgs_full_thread),
451 (modest_mail_operation_get_msgs_full),
452 (modest_mail_operation_xfer_msgs):
453 * src/modest-search.c: (search_mime_part_and_child_parts),
454 (modest_search_account), (modest_search_all_accounts):
455 * src/modest-tny-account.c:
456 (modest_tny_account_get_special_folder), (recurse_folders):
457 * src/modest-tny-local-folders-account.c:
458 (modest_tny_local_folders_account_query_passes):
459 * src/modest-tny-msg.c: (copy_mime_part),
460 (modest_tny_msg_find_body_part_from_mime_part):
461 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
462 (modest_tny_send_queue_try_to_send):
463 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
464 (_modest_ui_actions_open), (download_uncached_messages),
465 (reply_forward), (modest_ui_actions_on_copy),
466 (modest_ui_actions_on_details), (has_retrieved_msgs),
467 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
469 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
470 (_selected_msg_marked_as), (_msg_download_completed),
471 (_selected_msg_sent_in_progress):
472 * src/widgets/modest-attachments-view.c:
473 (modest_attachments_view_set_message):
474 * src/widgets/modest-msg-view.c: (find_cid_image):
475 * tests/check_folder-transfer.c: (find_folders):
476 * tests/check_update-account.c: (func):
477 * tests/dbus_api/test_get_folders.c: (main):
478 Checked all uses of tny_iterator_get_current(), making sure
479 that the object is unreferenced (3 or 4 places did not),
480 and adding checks for NULL.
482 2007-07-23 Murray Cumming <murrayc@murrayc.com>
484 * src/dbus_api/modest-dbus-callbacks.c:
485 (on_idle_open_default_inbox): Make sure that the application UI is
487 * src/maemo/easysetup/modest-easysetup-wizard.c:
488 (on_entry_invalid_character): Show the word whitespace instead
489 of (null) in the banner when whitespace was entered.
490 (show_error): Add a comment that this does not work in
491 Maemo Bora, though we do not know why.
493 2007-07-23 Murray Cumming <murrayc@murrayc.com>
495 * src/modest-tny-account.c:
496 (modest_tny_account_get_special_folder): Use an if instead of
497 an assert for when the parent account name is NULL, because this
498 might be causing a crash in projects.maemo.org bug 63192.
499 * src/modest-mail-operation.c:
500 (modest_mail_operation_send_new_mail_cb),
501 (modest_mail_operation_remove_folder): unref the folder that is
502 returned from modest_tny_account_get_special_folder().
504 2007-07-23 Murray Cumming <murrayc@murrayc.com>
506 * src/modest-ui-actions.c:
507 (modest_ui_actions_on_password_requested):
508 Show mail_ib_login_cancelled info banner when the user cancels
509 the protected password dialog, to fix projects.maemo.org
512 2007-07-23 Murray Cumming <murrayc@murrayc.com>
514 * src/maemo/modest-account-settings-dialog.c:
515 (create_page_outgoing): Put this page in a GtkScrolledWindow,
516 matching the UI mock-up in the UI spec, and allowing access
517 to all widgets even when the on-screen keyboard is active.
519 2007-07-23 Murray Cumming <murrayc@murrayc.com>
521 Reverted this previous commit from Johannes,
522 because the scrollbars are always visible and because
523 I think we only need it on onepage of the account
524 settings, not the account wizard.
525 (I wrote the wrong instructions in the bug.)
527 * src/maemo/easysetup/modest-easysetup-wizard.c:
528 Added scrollbars to account wizard dialog.
529 Fixed projects.maemo.org NB #62744
531 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
533 * src/maemo/easysetup/modest-easysetup-wizard.c:
534 (create_page_user_details):
535 Use auto-cap for name (projects.maemo.org NB#63716)
536 * src/widgets/modest-account-view.c: (on_account_busy_changed):
538 2007-07-22 Armin Burgmeier <armin@openismus.com>
540 * src/maemo/modest-ui-actions.c: Use current account instead of
541 default account for creating viewer windows, so that the viewer
542 window knows to which account the viewed message belongs.
544 * src/maemo/modest-msg-view-window.c: Destroy the window when the
545 corresponding account is deleted. This fixes projects.maemo.org bug
548 2007-07-18 Armin Burgmeier <armin@openismus.com>
550 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
551 the dialog close after entering an invalid port number and clicking
552 OK. This fixes projects.maemo.org bug NB#63602.
554 2007-07-18 Armin Burgmeier <armin@openismus.com>
556 * src/modest-tny-account-store.c:
557 (get_server_accounts): Set parent modest account name for each
558 connection-specific transport account so that special folders of such
559 an account can be looked up. This fixes a crash when changing account
560 settings. This might also be related to projects.maemo.org bug
563 2007-07-16 Armin Burgmeier <armin@openismus.com>
565 * src/modest-ui-actions.c: Added a button to create a folder to the
566 move-to dialog. This fixes projects.maemo.org bug NB#59863.
568 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/maemo/easysetup/modest-easysetup-wizard.c:
571 Added scrollbars to account wizard dialog.
572 Fixed projects.maemo.org NB #62744
574 2007-07-16 Murray Cumming <murrayc@murrayc.com>
576 * src/widgets/modest-msg-view.h:
577 * src/widgets/modest-msg-view.c:
578 Added modest_msg_view_get_message_is_empty() but this needs
580 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
581 Check if there is any text in the message yet.
582 But this needs to be implemented properly.
583 (modest_msg_edit_window_toggle_find_toolbar):
584 * src/maemo/modest-msg-view-window.c:
585 (modest_msg_view_window_toggle_find_toolbar):
586 Show a banner warning if there is no text to search, when
587 trying to start a search. This partially fixes
588 projects.maemo.org bug NB#62350.
590 2007-07-13 Murray Cumming <murrayc@murrayc.com>
592 * src/modest-mail-operation.c: (update_account_thread):
593 Initialized num_new_headers to fix the build.
595 2007-07-13 Murray Cumming <murrayc@murrayc.com>
597 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
598 Ignore modest accounts whose server accounts don't exist in gconf.
599 This prevents us trying to create TnyAccount instances for those
600 server accounts when the server account has been removed from gconf,
601 but the parent modest account has not yet been removed from modest.
602 I don't know why this is only noticeable now. It was probably just
603 a harmeless g_warning() anyway.
605 2007-07-13 Murray Cumming <murrayc@murrayc.com>
607 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
608 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
610 2007-07-12 Armin Burgmeier <armin@openismus.com>
612 * src/maemo/modest-main-window.c: Make default account appear bold
613 in view, tools/send & receive and toolbar/send & receive SCM menus.
614 This fixes projects.maemo.org bug NB#59010.
616 2007-07-12 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
619 Add a short-cut, by checking if the folder store is an account.
620 This ensures that the Sort menu item and toolbar is dimmed for
621 the local-folders account root item, fixing
622 projects.maemo.org bug NB#62545.
624 2007-07-12 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-tny-account-store.c: (get_password):
627 Show the password dialog (via the signal) only in the mainloop, via
628 an idle handler that we wait for. This could theoretically prevent
629 hangs, though I worry that it could introduce some too.
631 2007-07-12 Murray Cumming <murrayc@murrayc.com>
633 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
634 * src/maemo/modest-platform.c:
635 (modest_platform_connect_and_wait):
636 Take a TnyAccount* parameter and try to set it to online
637 (a TnyCamel-only API), because tinymail sets accounts to offline
638 when the user cancels a password dialog, and doesn't ask again until
639 it has been set to online.
640 However, this is commented out because it causes a hang now.
642 (modest_platform_connect_and_wait_if_network_account):
643 * src/modest-mail-operation.c:
644 (modest_mail_operation_update_account):
645 * src/modest-platform.h:
646 * src/modest-ui-actions.c: (_modest_ui_actions_open),
647 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
649 2007-07-12 Armin Burgmeier <armin@openismus.com>
651 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
653 * src/modest-mail-operation.c:
654 * src/modest-ui-actions.c: Check for already existing folder before
655 querying the server, show error message from camel if the request
656 still fails. This fixes projects.maemo.org bug NB#58701.
658 2007-07-12 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-tny-account-store.h:
661 * src/modest-tny-account-store.c:
662 Added modest_tny_account_store_forget_password_in_memory(),
663 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
664 when creating a new account, so that new passwords will be used, instead of
665 us thinking that it's a second request as a result of a failed password again.
667 2007-07-12 Murray Cumming <murrayc@murrayc.com>
669 * src/dbus_api/modest-dbus-callbacks.c:
670 (on_idle_open_message): If the message is in drafts then open it
671 in an edit window instead of a view window. This fixes
672 projects.maemo.org bug NB#63005.
674 2007-07-12 Murray Cumming <murrayc@murrayc.com>
676 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
677 Avoided a harmless g_warning().
679 2007-07-12 Murray Cumming <murrayc@murrayc.com>
681 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
682 Pass the modest account name, not the TnyAccount display name to
683 modest_msg_view_window_new() so that the reply feature works,
684 fixing projects.maemo.org bug NB#62892.
686 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
687 (modest_msg_view_window_new_with_header_model):
688 * src/maemo/modest-msg-view-window.c:
689 (modest_msg_view_window_new_with_header_model),
690 (modest_msg_view_window_new):
691 * src/modest-ui-actions.c: (reply_forward):
692 * src/widgets/modest-msg-view-window.h:
693 * src/widgets/modest-window.c: (modest_window_set_active_account):
694 Rename an account parameter to modest_account_name to make this clearer.
696 2007-07-11 Murray Cumming <murrayc@murrayc.com>
698 * src/modest-ui-actions.h:
699 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
700 modest_do_message_delete().
701 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
702 Call modest_do_message_delete(), hoping that this would cause messages
703 to be really deleted from search instead of just marked with strike through.
704 Does not seem to help.
706 2007-07-11 Armin Burgmeier <armin@openismus.com>
708 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
709 priv->reselect to FALSE prior to calling
710 modest_folder_view_select_first_inbox_or_local() to prevent endless
711 recursion and thus a crash on startup.
713 2007-07-11 Armin Burgmeier <armin@openismus.com>
715 * src/maemo/modest-account-settings-dialog.h: Include
716 <gtk/gtknotebook.h> to fix the build (at least for me).
718 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
719 Use "New FolderN" as default suggested name if "New folder" already
720 exists, with N being the first free number, though never exceed "New
721 folder99" in which case we just fall back to "New Folder" even though
722 it already exists. This fixes projects.maemo.org bug NB#58663.
724 2007-07-11 Murray Cumming <murrayc@murrayc.com>
726 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
727 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
728 projects.maemo.org bug NB#62778.
730 2007-07-11 Murray Cumming <murrayc@murrayc.com>
732 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
733 Ignore the wrong (for now) secure-smtp setting in the presets -
734 just default to requiring secure authentication for SMTP, because
737 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
739 * src/widgets/modest-folder-view.c: (filter_row)
740 Do not show drafts folder (see UI specs)
742 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
744 * src/modest-ui-actions.c:
745 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
746 place and also not necessary.
748 * src/widgets/modest-folder-view.c: (filter_row)
749 Guess folder type and hide Sent & Outbox if necessary.
750 Fixed project.maemo.org NB#57328
752 2007-07-11 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-ui-actions.h:
755 * src/modest-ui-actions.c:
756 (modest_ui_actions_on_delete_message):
757 Move some code into a new
758 modest_ui_actions_refresh_message_window_after_delete()
759 function so we can use it from elsewhere.
761 * src/dbus_api/modest-dbus-callbacks.c:
762 (on_idle_delete_message), (on_delete_message): Used an idle
763 handler, as we do for the other D-Bus method handlers.
764 Call modest_ui_actions_refresh_message_window_after_delete()
765 if the deleted message was open in a window. This fixed
766 projects.maemo.org bug NB#62862.
768 2007-07-11 Murray Cumming <murrayc@murrayc.com>
770 * src/modest-main.c: (main): Only show the UI at the start if
771 the showui command line option was given. For instance,
772 run-standalone src/modest showui
773 Otherwise, we wait for the top_application D-Bus method to
774 be sent by hildon-desktop when the application is selected
776 This allows us to run without a UI when osso-global-search
777 uses our D-Bus methods.
779 2007-07-11 Murray Cumming <murrayc@murrayc.com>
781 * src/dbus_api/modest-dbus-api.h: Added a define for a
782 top-application D-Bus method.
783 * src/dbus_api/modest-dbus-callbacks.c:
784 (on_top_application),
785 (modest_dbus_req_handler): Handle the top-application D-Bus
786 method, which might be an undocumented D-Bus signal sent by
787 hildon-desktop when it starts the application from the menu.
788 But I am not sure and I need to test it on the device, because
789 my scratchbox does not have the application in the menu now.
790 This method shows the main window, so that it can be invisible
791 when started, for instance, just for email searching from
794 * src/maemo/modest-main-window.c: (restore_settings),
795 (modest_main_window_new): Do not show the window immediately
796 upon creation. We show it later.
797 * src/modest-widget-memory.c: (save_settings_paned):
798 Try (unsuccessfully) to avoid saving the paned position when
799 it is not even visible.
800 (restore_settings_paned): Do not allow a silly paned position.
801 This seems necessary when not showing the window at first.
803 * tests/dbus_api/Makefile.am:
804 * tests/dbus_api/test_top_application.c: (main): Test for the
807 2007-07-10 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-ui-dimming-rules.c:
810 (modest_ui_dimming_rules_on_new_msg),
811 (modest_ui_dimming_rules_on_reply_msg),
812 (modest_ui_dimming_rules_on_delete_msg),
813 (modest_ui_dimming_rules_on_details),
814 (modest_ui_dimming_rules_on_view_window_move_to),
815 (modest_ui_dimming_rules_on_view_previous),
816 (modest_ui_dimming_rules_on_view_next),
817 (_invalid_folder_for_purge): Added checks before
818 casting the window. This looks like an actual
819 logic error in _invalid_folder_for_purge(), because it
820 tries to use a ModestMainWindow as a message window.
822 2007-07-10 Murray Cumming <murrayc@murrayc.com>
824 * src/maemo/modest-account-settings-dialog.c:
825 (show_error): Use the same implementation as in
826 modest-easysetup-wizard.c:
827 (on_entry_invalid_character): The logical ID contains a %s.
828 Guessed what it should be.
829 (on_entry_max), (check_data), (on_response): Adapt to
830 changed show_error().
831 (create_page_account_details): Really call
832 modest_validating_entry_set_func() on the correct widgets.
833 * src/maemo/easysetup/modest-easysetup-wizard.c:
834 (on_entry_invalid_character): Fix the logical ID here too.
835 (create_page_account_details),
836 (create_page_user_details):
838 modest_validating_entry_set_func() on the correct widgets.
840 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
841 Do not try to use the account if it is NULL.
843 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
845 * src/modest-ui-actions.c: (create_move_to_dialog),
846 (modest_ui_actions_on_main_window_move_to),
847 (modest_ui_actions_on_msg_view_window_move_to):
848 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
849 (filter_row), (modest_folder_view_show_non_move_folders):
850 * src/widgets/modest-folder-view.h:
852 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
853 the Sent folder yet as it does not report the correct folder type.
855 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
857 * src/maemo/modest-msg-edit-window.c: (init_window):
860 2007-07-10 Murray Cumming <murrayc@murrayc.com>
862 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
863 Take a parent widget instead of a parent window, and
864 implement this with hildon_banner_show_information() instead.
865 Non-Maemo builds can just ifdef that there.
866 This fixed projects.maemo.org bug NB#62766.
868 (on_entry_invalid_character): Use show_error() again instead
869 of using hildon directly, and use the _CS() macro to use the correct
871 (create_account), (check_for_supported_auth_methods), (on_entry_max):
872 Pass a widget instead od a window to show_error().
874 2007-07-10 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
877 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
878 This allows us to show the server name in the error message, fixing
879 projects.maemo.org bug NB#62904.
880 Also, use the appropriate logical ID message for the account protocol.
882 2007-07-10 Murray Cumming <murrayc@murrayc.com>
884 * src/modest-tny-account-store.c: (on_idle_wrong_password):
885 A compilation fix, though the build wasn't broken for me.
887 2007-07-09 Murray Cumming <murrayc@murrayc.com>
889 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
890 Do not try to unref a NULL folder store, to avoid a runtime warning.
891 This seems to happen sometimes when changing accounts settings.
893 2007-07-09 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-tny-account-store.c:
896 (modest_tny_account_store_instance_init),
897 (modest_tny_account_store_finalize),
898 (on_account_settings_hide), (on_idle_wrong_password):
899 Use a GHashTable to ensure that we only show one account settings
900 dialog per modest account. This avoids us having a dialog open for
901 both the store and transport accounts, or due to repeated get_password()
902 calls that shouldn't happen anyway.
904 2007-07-09 Murray Cumming <murrayc@murrayc.com>
906 * src/maemo/modest-maemo-utils.c: (on_hide),
907 (modest_maemo_show_dialog_and_forget): Handle the response, because
908 the window is not even hidden by default.
910 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
911 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
912 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
913 which seems to prevent some modality problems.
915 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
916 Ignore user cancellation errors.
918 * src/modest-account-mgr-helpers.h:
919 * src/modest-account-mgr-helpers.c:
920 Added modest_server_account_get_password() and
921 modest_server_account_get_has_password() to avoid direct use of
924 * src/maemo/modest-account-settings-dialog.h:
925 * src/maemo/modest-account-settings-dialog.c:
926 (modest_account_settings_dialog_init): Store the notebook so we can
928 Added modest_account_settings_dialog_switch_to_user_info().
930 * src/modest-tny-account-store.c:
931 (get_password): When the password in the account settings is wrong (we think),
932 show the relevant page of the account settings dialog, in the mainloop.
933 However, we currently get many of these at once because cancel does not
935 (forget_password): Do not forget the password
936 from the account settings, because this causes side-effects when
937 tinymail seems to call it at strange time, maybe because of how we
938 are cancelling get_password().
939 (modest_tny_account_store_alert): Ignore user cancellations.
941 2007-07-09 Murray Cumming <murrayc@murrayc.com>
943 * src/maemo/modest-maemo-utils.h:
944 * src/maemo/modest-maemo-utils.c:
945 Added modest_maemo_show_information_note_and_forget() for use instead of
946 gtk_dialog_run() when the response is not needed, to avoid an extra
947 mainloop which could cause a hang.
949 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
950 Use the logical IDs for the error message, though they are not
951 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
952 because gtk_dialog_run() caused a hang here (the window did not close).
953 This fixes projects.maemo.org bug NB#62646.
955 2007-07-09 Murray Cumming <murrayc@murrayc.com>
957 * src/modest-account-mgr-helpers.h:
958 * src/modest-account-mgr-helpers.c:
959 Added modest_account_mgr_get_store_protocol().
961 * src/maemo/modest-account-view-window.c:
962 (on_delete_button_clicked): Show different warning text depending on
963 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
964 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
967 2007-07-09 Murray Cumming <murrayc@murrayc.com>
969 * src/maemo/modest-msg-edit-window.c:
970 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
971 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
973 2007-07-07 Armin Burgmeier <armin@openismus.com>
975 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
976 ckdg_ib_maximum_characters_reached from correct package.
978 * src/modest-ui-actions.c: Show an error message when a folder could
979 not be created. Tinymail does not give us specific error codes about
980 what has gone wrong, so we assume that a folder with that name
981 already exists, though there might be other reasons.
983 2007-07-06 Murray Cumming <murrayc@murrayc.com>
985 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
986 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
987 give a more exact error message that can be partly translated.
989 2007-07-05 Murray Cumming <murrayc@murrayc.com>
991 * src/maemo/modest-address-book.c:
992 (select_email_addrs_for_contact): Specify a default window size for the
993 select-email-address dialog, so that it is probably big enough for the
994 title. This should fix projects.maemo.org bug NB#62277.
996 2007-07-05 Murray Cumming <murrayc@murrayc.com>
998 * src/maemo/easysetup/modest-easysetup-wizard.c:
999 (create_page_complete_easysetup): Use
1000 gtk_widget_set_size() request to ensure that the text wraps
1003 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1005 * src/maemo/easysetup/modest-easysetup-wizard.c:
1006 (on_entry_invalid_character), (create_page_account_details),
1007 (create_page_user_details):
1008 Use new API of ModestValidatingEntry. But for some reason the banner is
1009 not shown. I will have to investigate that further.
1011 * src/widgets/modest-validating-entry.c: (on_insert_text),
1012 (modest_validating_entry_set_func):
1013 * src/widgets/modest-validating-entry.h:
1014 Added a new callback function to be able to react to prevented
1015 characters whitespaces to e.g show a banner.
1017 2007-07-05 Armin Burgmeier <armin@openismus.com>
1019 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
1020 notification of HildonNumberEditor instead of remembering the port
1021 number. Thanks to Johannes for pointing this out.
1023 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1025 * src/maemo/easysetup/modest-easysetup-wizard.c:
1026 Check if there are any user changes before showing a confirmation
1027 dialog (projects.maemo.org NB#60946)
1029 2007-07-05 Armin Burgmeier <armin@openismus.com>
1031 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1032 number at the beginning of the dialog and set the modified flag at the
1033 end if the port number has changed. This is necessary because
1034 HildonNumberEditor does not support notification when the value has
1037 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1039 * src/modest-ui-actions.c:
1040 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1041 a connection before asking anything else. Correct the check for the destination
1042 folder so that it succeeds when online.
1043 This fixed projects.maemo.org bug NB#61645.
1045 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1047 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1048 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1049 to fix projects.maemo.org bug NB#62439.
1051 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1053 * src/modest-tny-account.c: (on_connection_status_changed):
1054 Really do not use tny_device_force_offline() here. See the previous comment.
1056 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1058 * src/modest-tny-account.c: (on_connection_status_changed):
1059 Do not use tny_device_force_offline() when tinymail says that something
1060 went wrong with the connection. It seems to report this unnecessarily.
1062 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1064 * src/maemo/modest-connection-specific-smtp-window.c:
1065 (modest_connection_specific_smtp_window_init):
1066 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1067 does not seem to have any effect in osso 1.1 (though it works in
1068 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1070 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1072 * src/maemo/modest-connection-specific-smtp-window.c:
1073 Fix UI specification problems with projects.meamo.org NB#60479
1075 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1077 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1078 clue when this has failed, because the error dialog is not always shown
1079 (at least in earlier version).
1081 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1082 GError message, because the generic error dialog is not helpful.
1084 'This message is not currently available (can't let a new connection go online)'
1085 when trying to open an IMAP message.
1087 (_modest_ui_actions_open): Offer a connection when some messages would
1088 have to be downloaded and we are offline.
1090 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1092 * src/widgets/modest-folder-view.c:
1093 Don't check for MERGE type anymore as we use the correct type
1095 NOTE: For the last two changes you need to update your tinymail copy
1096 because of API changes!
1098 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1100 * src/modest-tny-local-folders-account.c:
1101 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1102 (see projects.maemo.org NB#61580)
1104 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-tny-account.c: (on_connection_status_changed):
1107 Commented out the call to modest_platform_connect_and_wait() because this
1108 seems to always hang, and I would like to know if this is the only thing
1109 that causes a hang when showing the connection dialog.
1110 It is not very useful anyway.
1112 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1114 * src/maemo/modest-msg-view-window.c:
1115 (modest_msg_view_window_select_next_message):
1117 * src/modest-platform.h:
1118 * src/maemo/modest-platform.c:
1119 Added modest_platform_connect_and_wait(), which calls
1120 tny_maemo_conic_device_connect() always in the main thread, by calling it
1121 in an idle handler and waiting for the idle handler to run. It should be
1122 in the main thread because it uses GTK+ UI code. It just returns TRUE
1123 if the device is already online.
1125 There is some nasty code to ensure that subsequent calls to
1126 modest_platform_connect_and_wait() just wait for the first one to finish,
1127 by checking repeatedly in another idle handler. This is necessary,
1128 because other threads (or even the main thread, via another idle handler)
1129 can call modest_platform_connect_and_wait() while
1130 modest_platform_connect_and_wait() is running.
1132 (modest_platform_connect_and_wait_if_network_account),
1133 (modest_platform_connect_and_wait_if_network_folderstore):
1134 Convenience functions that calls modest_platform_connect_and_wait() if
1135 the account or folder might want network access.
1137 * src/modest-mail-operation.c:
1138 (modest_mail_operation_update_account):
1139 * src/modest-ui-actions.c: (download_uncached_messages),
1140 (modest_ui_actions_on_rename_folder), (delete_folder),
1141 (modest_ui_actions_on_main_window_move_to),
1142 (modest_ui_actions_on_msg_view_window_move_to):
1143 * src/widgets/modest-folder-view.c:
1144 (drag_and_drop_from_folder_view):
1145 Offer a connection if we are offline.
1147 * src/modest-tny-account.c: (on_connection_status_changed):
1148 Document this as only handling errors during network operations in progress,
1149 and replace the idle code with a simple call to
1150 modest_platform_connect_and_wait(), which does this instead.
1152 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-tny-account.c:
1155 (modest_tny_account_get_special_folder): (util_on_idle),
1156 Handle the GError so we can see when tny_folder_store_get_folders()
1157 fails, as it currently does while something else is connecting.
1159 Added util_run_in_main_thread_and_wait()
1160 which uses an idlen handler and mainloop to ensure that the function
1161 is called in the main thread.
1162 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1163 to make sure that we call attempt the connection in the mainloop only,
1164 which might solve some hangs.
1166 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1168 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1169 be found by their display name. This is never useful.
1170 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1171 by its ID, instead of trying to use its ID as its display name.
1173 * src/modest-tny-account-store.h:
1174 * src/modest-tny-account.c:
1175 (modest_tny_account_get_special_folder): Add a g_warning() when
1176 tny_folder_store_get_folders() returns an empty list for the maildir.
1178 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1179 Add a g_warning() when this returns NULL, because that it not allowed
1182 2007-07-02 Armin Burgmeier <armin@openismus.com>
1184 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1185 note when trying to cancel the wizard. This fixes projects.maemo.org
1188 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-tny-account.h:
1191 * src/modest-tny-account.c:
1192 (modest_tny_account_new_from_server_account),
1193 (modest_tny_account_new_from_server_account_name),
1194 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1195 because this must now be set before setting the proto. This is usd in
1196 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1197 warning in camel_session_get_service() caused by
1198 tny_camel_transport_account_prepare().
1200 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1203 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1205 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1207 (modest_connection_specific_smtp_edit_window_init):
1209 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1210 of "changed" for now
1212 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1214 * src/modest-tny-account.c:
1215 (modest_tny_account_new_from_server_account):
1216 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1217 now uses to request a connection when it needs one, and which it uses
1218 to tell us that something is wrong with the connection, so we can force
1219 the accounts offline to prevent further problems.
1221 * src/modest-defs.h:
1222 * src/modest-init.c: (init_default_settings):
1223 * src/modest-mail-operation.c:
1224 (modest_mail_operation_update_account):
1225 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1226 This should not be necessary anymore. Do not set the conf key that
1227 determined this (it was always TRUE and not set anywhere else).
1229 * src/modest-ui-actions.h: Remove unused and unimplemented
1230 modest_ui_actions_on_online_toggle_toggled().
1232 2007-06-29 Murray Cumming <murrayc@murrayc.com
1234 * src/maemo/modest-main-window.c: (connect_signals):
1235 Don't connect to delete_event twice. Maybe this was harmless.
1237 2007-06-29 Murray Cumming <murrayc@murrayc.com
1239 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1240 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1241 Debug output to give some more clue when a folder move is not allowed.
1243 2007-06-28 Murray Cumming <murrayc@murrayc.com
1245 * src/modest-tny-account.c: (on_modest_file_system_info),
1246 (modest_tny_account_get_mmc_account_name):
1247 Always call the callback, without checking whether the name has changed.
1248 * src/widgets/modest-folder-view.c: (strings_are_equal),
1249 (on_model_foreach_set_name), (on_get_mmc_account_name),
1250 (text_cell_data): Compare the name here, and use the name from
1251 the account rather than from the
1252 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1253 if the name was changed after the account was added to the model.
1254 That's a tinymail bug but not one that I want to fix now.
1256 This finally fixes projects.maemo.org bug NB#59301.
1258 2007-06-27 Armin Burgmeier <armin@openismus.com>
1260 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1263 2007-06-27 Murray Cumming <murrayc@murrayc.com
1265 * src/modest-tny-account.h:
1266 * src/modest-tny-account.c:
1267 Added modest_tny_account_get_mmc_account_name(), to set the memory
1268 card name asynchronously for the given account and then notify.
1269 (modest_tny_account_new_for_local_folders): Use this new function instead
1270 of using hildon_file_system_info_async_new() directly.
1272 * src/widgets/modest-folder-view.c: (text_cell_data):
1273 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1274 gtk_tree_model_row_changed() when it is available.
1276 This should fix projects.maemo.org bug NB#59301.
1278 2007-06-27 Murray Cumming <murrayc@murrayc.com
1280 * src/modest-mail-operation.c: (update_account_thread),
1281 (get_msgs_full_thread): Fix typo failures in the revert
1284 2007-06-27 Murray Cumming <murrayc@murrayc.com
1286 * src/maemo/modest-maemo-global-settings-dialog.c:
1287 (idle_select_default_focus):
1288 * src/modest-mail-operation.c: (idle_notify_progress),
1289 (idle_notify_progress_once), (set_last_updated_idle),
1290 (update_account_thread), (get_msgs_full_thread):
1291 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1292 * src/widgets/modest-header-view.c:
1293 (idle_notify_headers_count_changed_destroy),
1294 (idle_notify_headers_count_changed):
1295 Reverted the additions of gdk_threads_enter/leave(), in case this
1296 helps with a startup hang on the device.
1298 2007-06-26 Armin Burgmeier <armin@openismus.com>
1300 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1301 for supported secure authentication methods from server by
1302 gtk_dialog_run(), saving CPU time and a potential race condition.
1304 2007-06-26 Armin Burgmeier <armin@openismus.com>
1306 * src/maemo/modest-maemo-utils.h:
1307 * src/maemo/modest-maemo-utils.c: Added a
1308 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1309 only error code to tell the calling code when the user canceled the
1312 * src/maemo/modest-account-settings-dialog.h:
1313 * src/maemo/modest-account-settings-dialog.c:
1314 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1315 message if the retrieval of secure authentication methods was canceled
1316 by the user. Perform the check before saving anything to configuration
1317 to not end up with half-committed configuration changes, do not show
1318 a "Saving to configuration failed" note when authentication methods
1319 could not be retrieved.
1321 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1324 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1326 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1327 Only return the first level of folders under accounts, because the
1328 osso-global-search UI spec doesn't want the rest.
1329 This fixed projects.maemo.org bug NB#61811.
1331 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1333 * src/modest-tny-account-store.c:
1334 * src/modest-tny-account-store.h:
1335 Added modest_tny_account_is_memory_card_account().
1336 * src/maemo/modest-main-window.c: (create_details_widget):
1337 Show the same information items for the memory card as we show for the
1338 local-folders, to fix projects.maemo.org bug NB#59307.
1340 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-tny-account-store.c: (get_password):
1343 Added some checks for NULL to maybe prevent crashes, though I think
1344 it was Philip's last commit that actually prevented the crash here
1345 when creating a first new account.
1346 But the new account is still not usable (no messages are shown)
1347 until a restart of the application.
1349 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/modest-maemo-global-settings-dialog.c:
1352 (idle_select_default_focus):
1353 * src/modest-mail-operation.c: (idle_notify_progress),
1354 (idle_notify_progress_once), (idle_notify_update_account_queue),
1355 (set_last_updated_idle), (update_account_thread),
1356 (notify_get_msgs_full), (get_msgs_full_destroyer),
1357 (get_msgs_full_thread):
1358 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1359 * src/widgets/modest-header-view.c:
1360 (idle_notify_headers_count_changed_destroy),
1361 (idle_notify_headers_count_changed):
1362 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1363 all idle handlers, because some other thread could be blocking
1364 the GDK lock, so that it can do GUI stuff.
1366 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1368 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1369 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1370 (on_idle_send_receive), (on_idle_open_default_inbox):
1371 * src/maemo/modest-msg-edit-window.c:
1372 (modest_msg_edit_window_attach_file_noninteractive):
1373 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1374 to prevent a hang. I don't quite understand why these are necessary,
1375 beause we should already be in the main loop. I guess something outside
1376 of the main loop is taking the lock.
1378 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1379 we are really using URIs, and use files that are more likely to exist.
1381 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1383 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1384 necessary because configure.ac now defines different variables.
1386 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1388 * libmodest-dbus-client/libmodest-dbus-client.c:
1389 * libmodest-dbus-client/libmodest-dbus-client.h:
1390 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1391 libmodest_dbus_client_compose_mail() is what things actually use.
1393 * src/dbus_api/modest-dbus-api.h:
1394 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1395 * tests/dbus_api/Makefile.am:
1396 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1399 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-init.c: (modest_init_local_folders):
1402 For memory-card (or other non local-folders) maildir accounts,
1403 always create an Archive folder, so that there is somewhere to put
1404 messages. This should be less confusing, because the user does not need
1405 to guess that the need to create a folder.
1407 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1409 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1410 Fixed icon size by using (50, 50) which is the same as defined by
1413 2007-06-25 Armin Burgmeier <armin@openismus.com>
1415 * src/widgets/modest-window-mgr.c:
1416 * src/modest-init.c:
1417 * configure.ac: Correctly recognize hildon-notify presence and fixed
1418 the build without it being installed.
1420 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1422 * libmodest-dbus-client/libmodest-dbus-client.c:
1423 (libmodest_dbus_client_search): Fix the build. Sorry.
1424 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1425 (reply_forward_cb): Initialize variables to fix the build.
1427 * src/modest-tny-account-store.c:
1428 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1429 comparison (a silly typo) so that email search results can be opened
1430 when there are more than one account.
1432 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1434 * libmodest-dbus-client/libmodest-dbus-client.c:
1435 (libmodest_dbus_client_search),
1436 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1437 instead of 1 second, because the search gets folders and messages from
1438 the server, which can take a long time. When it times out,
1439 osso-global-search will report no results.
1441 We need to specify whether we should search only cached information
1442 (maybe with a user preference), and the osso-email-search-plugin
1443 API should really be improved to allow that option, and to allow results
1444 to be delivered asynchronously in batches.
1446 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1448 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1449 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1450 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1452 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1454 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1455 that is an empty string. D-Bus seems to give us these instead of NULL.
1457 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1459 * src/dbus_api/modest-dbus-callbacks.c:
1460 * src/maemo/easysetup/modest-easysetup-wizard.h:
1461 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1462 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1463 (modest_connection_specific_smtp_edit_window_init):
1464 * src/maemo/modest-maemo-global-settings-dialog.c:
1466 * src/maemo/modest-maemo-utils.c:
1467 (modest_maemo_utils_setup_images_filechooser):
1468 * src/maemo/modest-main-window.c: (create_details_widget):
1469 * src/maemo/modest-msg-edit-window.c:
1470 (modest_msg_edit_window_attach_file_noninteractive),
1471 (modest_msg_edit_window_color_button_change),
1472 (modest_msg_edit_window_set_zoom):
1473 * src/modest-mail-operation.c: (update_account_thread):
1474 * src/modest-tny-account-store.c:
1475 * src/modest-tny-account.c:
1476 * src/widgets/modest-global-settings-dialog.c:
1477 * src/widgets/modest-window.h:
1479 Fixed build on bora!
1481 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1483 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1484 * src/modest-search.c: (modest_search_folder),
1485 (modest_search_all_accounts): Actually search only in the specified folder,
1486 doing a simple match on the folder ID.
1487 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1488 and added some documentation.
1490 2007-06-22 Armin Burgmeier <armin@openismus.com>
1492 * src/maemo/modest-maemo-utils.h:
1493 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1494 modest_maemo_utils_get_supported_secure_authentication_methods.
1496 * src/maemo/easysetup/modest-easysetup-wizard.c:
1497 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1498 one occured, not just "Server does not support secure authentication".
1500 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-tny-account-store.c: (get_password):
1503 Restored the call to tny_account_set_user() because Philip seems to have
1504 stopped this from crashing (by not using the freed string). It still does
1505 not work, but now we can test it.
1507 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1509 * src/maemo/modest-msg-edit-window.c: (init_window):
1510 Comment out use of an uninitialzed GtkScrolledWindow variable,
1511 to fix the build and stop a crash. Yet again.
1513 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1515 * src/modest-tny-account-store.c: (get_password):
1516 Remove the call to tny_account_set_user() because this actually crashes.
1517 As mentioned in the last commit, it is known to not work anyway.
1519 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1521 * src/modest-tny-account-store.c: (get_password):
1522 Use tny_account_set_username() to tell tinymail that the username might
1523 have changed too. But tinymail ignores this: see projects.maemo.org
1525 * src/modest-ui-actions.c:
1526 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1527 reset the connection when changing the username, and improve the comments.
1528 Save the changed username to gconf at least, so it is used when Modest is
1531 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1533 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1534 Do not use a query, so that we get all folders, including for POP and
1535 local-folders. They work as search criteria too.
1536 This fixes projects.maemo.org bug NB#57740.
1538 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1540 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1541 Comment out the use of hildon_notification_set_sound() because it is
1542 not declared, to fix the build. Warnings are serious, people.
1544 2007-06-21 Armin Burgmeier <armin@openismus.com>
1546 * src/maemo/modest-maemo-utils.h:
1547 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1548 modest_maemo_utils_get_supported_secure_authentication_methods()
1549 to query authentication methods for a specific user. This should fix
1550 projects.maemo.org bug NB#61369.
1552 * src/maemo/easysetup/modest-easysetup-wizard.c:
1553 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1556 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1558 * libmodest-dbus-client/libmodest-dbus-client.h:
1559 * libmodest-dbus-client/libmodest-dbus-client.c:
1560 (modest_dbus_message_iter_get_search_hit),
1561 (libmodest_dbus_client_search):
1562 Reorganised and commented this.
1563 Removed modest_search_hit_free() from the public API because it
1566 Added libmodest_dbus_client_get_folders() and
1567 modest_folder_result_list_free().
1569 * src/dbus_api/modest-dbus-api.h:
1570 * src/dbus_api/modest-dbus-callbacks.c:
1571 (modest_dbus_req_filter): Commented. Moved most code to
1572 on_dbus_method_search() and added on_dbus_method_get_folders().
1574 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1575 of the extra D-Bus handler.
1577 * tests/dbus_api/Makefile.am:
1578 * tests/dbus_api/test_get_folders.c: New test for
1579 libmodest_dbus_client_get_folders(). This seems to return an empty list
1580 at the moment. That could be the same error that causes the message list
1581 to be empty sometimes.
1582 This should help with projects.maemo.org bug NB#57740.
1584 2007-06-21 Armin Burgmeier <armin@openismus.com>
1586 * src/modest-mail-operation.c: Do not call
1587 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1588 notify the operation's end after having set the status to CANCELED for
1589 the operation queue to listen on. This fixes a deadlock when there
1590 were mail operations in the queue during its finalization.
1592 * src/modest-singletons.c: Reordered uninitialization of the account
1593 manager to happen after the mail operation queue was uninitialized
1594 because the mail operation's in the queue might still try to access
1595 the account manager (see modest_mail_operation_notify_end()). This
1596 fixes a potential crash when terminating the application.
1598 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-search.c:
1601 (search_mime_part_and_child_parts): Moved some code here so we
1602 can search recursively in child folders.
1603 (modest_search_folder): Search in the message as a mime part, instead
1604 of just its child mime parts.
1605 (read_chunk), (search_mime_part_ogs):
1606 Check how many bytes were read, to prevent an endless loop.
1607 Searching in message bodies now works. This finishes the fix for
1608 projects.maemo.org bug NB#61007.
1610 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1612 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1613 Add a g_warning when the item is not a folder.
1615 * src/modest-ui-dimming-rules.c:
1616 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1617 when selected item is not a folder (for instance, an account), because
1618 the UI spec only talks about folders.
1619 I am not sure what the UI spec wants, so this might not totally fix
1620 projects.maemo.org bug NB#60794.
1622 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1624 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1625 (load_from_file): Sort the list. The unsorted list would be more noticeable
1626 in non-English locales.
1628 * src/maemo/modest-msg-edit-window.c:
1629 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1630 warning and fix the build.
1632 * src/maemo/modest-progress-bar-widget.c:
1633 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1634 avoid a g_warning, and probably to avoid a crash.
1636 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1638 * src/modest-search.c: (modest_search_folder): Check for a GError
1639 when calling tny_folder_get_headers(), to show that this is not the cause
1642 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1644 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1645 Actually set the body query instead of the subject query.
1647 * src/modest-search.c: (search_mime_part_ogs),
1648 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1649 which would probably cause it to fail if we got this far.
1651 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1652 to simplify the code.
1653 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1654 be causing search-in-body to fail.
1656 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1658 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1660 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1661 Better debug message when the folder cannot be found.
1662 This should help with fixing projects.maemo.org bug #61287.
1663 * src/modest-search.c: (add_hit): Do not leak the furl string.
1665 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-ui-actions.c:
1668 (modest_ui_actions_on_folder_selection_changed):
1669 Do not special-case TNY_MERGE_FOLDER here, because
1670 modest_tny_folder_get_account() already does that. This fixes
1671 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1672 shown when the Outbox was selected).
1674 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1676 * libmodest-dbus-client/libmodest-dbus-client.c:
1677 (_dbus_iter_get_string_or_null): Initialize the string variable in
1678 case this helps with Dirk's crash.
1680 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1682 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1683 though it is not implemented yet (this function is maybe not even used),
1684 to avoid breaking ABI in future.
1685 * libmodest-dbus-client/libmodest-dbus-client.c:
1686 (get_attachments_string): Moved some code into this generic function.
1687 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1688 sends email. It is maybe not used.
1689 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1690 (on_send_mail): Use attachments.
1692 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1693 * src/maemo/modest-msg-edit-window.c:
1694 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1695 a filename before using it, to fix projects.maemo.org bug NB#58233.
1697 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1699 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1700 Initialize the continue_download variable to fix the build, and probably
1701 to fix randome behaviour.
1703 2007-06-18 Armin Burgmeier <armin@openismus.com>
1705 * src/modest-tny-send-queue.h:
1706 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1707 the queue so we can later show it in the UI. Replaced
1708 modest_tny_send_queue_msg_is_being_sent() by
1709 modest_tny_send_queue_get_msg_status().
1711 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1713 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1714 gpointer. This probably was not harmful, but just to be sure.
1716 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1718 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1719 Fix the build, but leave the function broken on Bora, because
1720 hildon_uri_action_get_service() does not exist.
1721 osso_uri_action_get_service() does not exist either, it seems.
1723 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1725 * src/modest-tny-account.c:
1726 (modest_tny_account_new_from_server_account):
1727 Uncommented the url debug output again, because it is useful for
1728 debugging, as I said in the comment.
1730 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1732 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1734 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1735 for Mameo Bora, to fix the build.
1737 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1740 Fixed build with hildon < 0.99
1742 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1743 Check if the selected account is busy instead of checking all accounts
1745 * src/modest-account-mgr-priv.h:
1746 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1747 (modest_account_mgr_init), (compare_account_name),
1748 (modest_account_mgr_set_account_busy),
1749 (modest_account_mgr_account_is_busy):
1750 * src/modest-account-mgr.h:
1751 Added busy information to the account manager. It possible to
1752 set an account to busy or not busy now.
1754 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1755 (modest_mail_operation_update_account),
1756 (modest_mail_operation_notify_end):
1757 Set the account to busy/not busy depending on the operation state.
1759 * src/widgets/modest-account-view.c:
1760 (modest_account_view_finalize), (get_last_updated_string),
1761 (update_account_view), (on_account_busy_changed), (init_view):
1762 Show string "Refreshing..." if the account is currently busy.
1764 All this fixes projects.maemo.org bug NB#59711
1766 2007-06-14 Armin Burgmeier <armin@openismus.com>
1768 * src/widgets/modest-attachments-view.h:
1769 * src/widgets/modest-attachments-view.c: Added
1770 modest_attachments_view_has_attachments() and fixed coordinate
1771 transformation in get_att_view_at_coords(). This fixes attachment
1774 * src/widgets/modest-msg-view.c: Make use of
1775 modest_attachments_view_has_attachments() to decide whether to show
1776 attachments in the header.
1778 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1780 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1781 (on_change), (on_combo_security_changed),
1782 (modest_connection_specific_smtp_edit_window_init),
1783 (modest_connection_specific_smtp_edit_window_set_connection),
1784 (modest_connection_specific_smtp_edit_window_is_dirty):
1785 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1786 * src/maemo/modest-connection-specific-smtp-window.c:
1789 Show an comfirmation dialog for the smpt-edit-window if there are
1790 unsaved changes and the user hits cancel.
1791 (projects.maemo.org bug NB#60479)
1793 2007-06-14 Armin Burgmeier <armin@openismus.com>
1795 * src/maemo/easysetup/modest-easysetup-wizard.c:
1796 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1797 address" info in banner instead of node, and select all the text as
1798 per UI spec. This fixes projects.maemo.org bug NB#60550.
1800 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1802 reviewed by: <delete if not using a buddy>
1804 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1805 * src/modest-ui-actions.c: (folder_refreshed_cb):
1807 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1809 * src/widgets/modest-folder-view.c: (filter_row):
1810 Explictly filter out the per-account outbox accounts. I don't know why
1811 these only sometimes show up, but now they should never show up in the UI.
1812 This should fix projects.maemo.org bug NB#60160.
1814 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1816 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1817 when the toolbar does not exist yet.
1818 * src/modest-widget-memory.c: (save_settings_header_view):
1819 Added g_warnings() to help us to discover when we are trying to set
1820 an empty columns list in gconf.
1822 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1824 * src/modest-init.h:
1825 * src/modest-init.c:
1826 Added modest_init_get_default_header_view_column_ids().
1828 * src/modest-widget-memory.c: (restore_settings_header_view):
1829 Use the new function to get defaults, if the gconf key is empty,
1830 instead of not creating any columns. This seems to fix the
1831 empty right-hand pane problems.
1833 * src/widgets/modest-header-view.h: Improved documentation.
1835 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1837 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1838 Revert the use of the display name as the account name, because this
1839 is generally wrong and would break the code that follows.
1841 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1843 * src/maemo/easysetup/modest-easysetup-wizard.c:
1844 (check_for_supported_auth_methods), (on_before_next),
1847 More correct fix for projects.maemo.org bug NB# 58991
1848 Do not longer accept AUTH_PASSWORD as secure method and choose
1849 correct method when creating the account.
1851 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1853 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1854 Fixed projects.maemo.org bug NB# 58991
1856 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-init.c: (modest_init_init_core),
1859 (modest_init_local_folders): Fixed compilation errors.
1861 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1863 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1864 Remove unnecessary lib/include, though it is good in principle when needed.
1866 * src/modest-init.c: (modest_init_one_local_folder),
1867 (modest_init_local_folders):
1868 * src/modest-init.h: Initialize the .modest library for memory cards,
1869 instead of just doing nothing for them. This should allow us to create
1870 folders there, fixing projects.maemo.org bug NB#59297.
1872 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1874 * libmodest-dbus-client/libmodest-dbus-client.c:
1875 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1876 (libmodest_dbus_client_compose_mail),
1877 (libmodest_dbus_client_open_message),
1878 (libmodest_dbus_client_send_and_receive),
1879 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1881 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1882 (on_idle_open_message), (modest_dbus_req_handler),
1883 (search_result_to_message), (modest_dbus_req_filter):
1884 * src/modest-search.c: (add_hit), (modest_search_folder),
1885 (modest_search_all_accounts): Improved debug messages.
1887 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1889 * src/modest-tny-account-store.c:
1890 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1893 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1896 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1898 * src/modest-tny-account-store.c: (get_server_accounts):
1899 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1900 even when there are no accounts, so that the Outbox folder is always
1901 visible. This fixes projects.maemo.org bug NB#60158.
1903 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1905 * src/maemo/modest-main-window.c: (create_details_widget):
1906 Use the mcen_va_never logical ID.
1908 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1910 * src/dbus_api/modest-dbus-api.h:
1911 * src/dbus_api/modest-dbus-callbacks.c:
1912 (on_idle_open_default_inbox), (on_open_default_inbox),
1913 (modest_dbus_req_handler):
1914 Added a new OpenDefaultInbox method.
1916 * libmodest-dbus-client/libmodest-dbus-client.h:
1917 * libmodest-dbus-client/libmodest-dbus-client.c:
1918 Added libmodest_dbus_client_open_default_inbox() to call the new
1919 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1920 though it should maybe be used by a new osso-email-interface function.
1922 * tests/dbus_api/Makefile.am:
1923 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1926 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1928 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1929 NULL, so that the signals get all the keys. This should not actually
1930 change any behaviour because we currently update everything when anything
1933 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1935 * src/widgets/modest-folder-view.c: (text_cell_data),
1936 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1937 (find_inbox_iter): If tinymail tells us that the folder is
1938 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1939 This causes the inbox to be selected at startup, fixing part of
1940 projects.maemo.org bug NB#56305.
1942 * src/modest-ui-dimming-rules.c:
1943 (modest_ui_dimming_rules_on_tools_smtp_servers):
1944 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1945 the SMTP servers menu item.
1946 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1947 that the SMTP Servers menu item is dimmed when there are no accounts,
1948 as a future version of the UI spec will require. This fixes
1949 projects.maemo.org bug NB#56305.
1951 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1953 * src/maemo/modest-maemo-utils.c:
1954 (modest_maemo_utils_get_supported_secure_authentication_methods):
1955 Added label to dialog instead of unreadable title
1957 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1958 (modest_main_window_new):
1959 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1962 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1963 * src/modest-account-mgr.h:
1964 Added method to avoid code duplication
1966 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1967 (modest_ui_actions_on_send_receive):
1968 Use modest_account_mgr_has_accounts
1970 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1972 * src/maemo/easysetup/modest-presets.c:
1973 (modest_presets_get_info_server_security): Do not report secure auth
1975 * src/modest-protocol-info.c: Use the defines for the gconf key names
1976 for secure authentication. This was not working because we were writing
1977 Password and reading password, and the check was case sensitive.
1978 With this, gmail now works for receiving and sending when created via
1981 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1983 * src/maemo/easysetup/modest-presets.c:
1984 (modest_presets_get_info_server_security): Correct the key name for
1985 SecureSmtp, because it seems to be case-sensitive.
1986 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1987 Do not try to get the 0th notebook page if there are 0 pages, to
1988 avoid a g_warning().
1990 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1992 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1993 Prevent use of the new notification feature for now, because it currently
1994 shows one dialog for each new email, which is annoying.
1996 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1998 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1999 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
2000 when no country was selected, so that we show the global ones.
2001 * src/maemo/easysetup/modest-presets.c:
2002 (modest_presets_get_providers): Return only the global providers, not
2003 all providers when mmc=0 was requested.
2005 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2007 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2008 (easysetup_provider_combo_box_fill): Remove debug code that showed the
2009 provider ID in the combo.
2011 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
2012 Do not show the page numbers, because it would be confusing when we add
2013 the 2 extra pages for the custom setup, when the user chooses the "Other"
2014 provider. This fixes projects.maemo.org bug NB#59028
2016 * src/modest-init.c: (modest_init_init_core),
2017 (modest_init_local_folders):
2018 * src/modest-init.h:
2019 * src/modest-tny-account.c:
2020 (modest_tny_account_new_for_local_folders): Do not create default folders
2021 for the memory card. This should fix projects.maemo.org bug NB#59328.
2023 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2025 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2026 Free the changed_conf_keys string items. They are already freed in the
2027 idle handler if that runs first.
2029 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2031 * src/modest-ui-actions.c:
2032 (modest_ui_actions_on_password_requested): Check that the server name
2033 is not NULL, because I just saw a password dialog with (null) as the
2036 * src/modest-tny-folder.[h|c]: Added
2037 modest_tny_folder_is_memory_card_folder().
2038 * src/modest-ui-dimming-rules.c:
2039 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2040 menu item for memory cards, as per the UI spec (section 7.4). This should
2041 fix projects.maemo.org bug NB#59297.
2043 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2045 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2046 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2047 is another problem with the code, see Murray's comment at line 772)
2049 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2052 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2053 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2054 (load_from_file), (easysetup_country_combo_box_init),
2055 (easysetup_country_combo_box_get_active_country_ids),
2056 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2057 instead of just one ID, to avoid duplicate country names in the UI.
2059 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2060 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2061 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2062 a single ID, avoiding duplicate providers.
2063 * src/maemo/easysetup/modest-easysetup-wizard.c:
2064 (on_combo_account_country): Adapt to use a list.
2066 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2068 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2069 keys changed in the last X seconds.
2071 * src/modest-account-mgr.h:
2072 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2073 (on_key_change), (modest_account_mgr_class_init),
2074 (modest_account_mgr_init), (modest_account_mgr_finalize):
2075 As the keys are changed, save them in a GSList* and signal that GSList*
2076 further every X seconds, to batch changes, to allow us to do just one
2077 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2078 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2080 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2081 changed signal signature.
2083 * src/modest-conf.c: (modest_conf_set_list),
2084 (modest_conf_on_change): Reenable notification.
2086 (modest_conf_maemo_fake_on_change): Comment out the hack that
2087 notified immediately instead of asynchronously.
2089 * src/widgets/modest-account-view.h:
2090 * src/widgets/modest-account-view.c:
2091 (update_account_view): Select the previously-selected account ID,
2092 if possible. This fixes projects.maemo.org bug NB#56933.
2094 (on_account_changed), (on_account_removed),
2095 (modest_account_view_select_account):
2097 Remove the block/unblock functions
2098 because they were not useful.
2100 * src/maemo/modest-account-view-window.c:
2101 (on_delete_button_clicked), (on_edit_button_clicked),
2102 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2104 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2106 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2107 Improve the error dialog to show Incorrect Account Settings, which seems
2108 clearer, and say that the internal error message (to be removed from the
2109 dialog later) is often misleading.
2110 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2112 * src/modest-tny-account.c:
2113 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2114 URL because this is so useful for debugging on the device.
2116 * src/widgets/modest-serversecurity-combo-box.c:
2117 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2119 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2121 * src/modest-mail-operation.c:
2122 (modest_mail_operation_send_new_mail):
2123 Added a comment about a nasty but apparently harmless message. Details
2124 added to the wiki g_warnings() page.
2126 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2128 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2129 (modest_tny_send_queue_class_init):
2130 Do not use the priv struct because it is empty, to avoid g_warnings
2131 about a non-existant priv struct.
2133 * src/modest-tny-account-store.c:
2134 (modest_tny_account_store_get_server_account),
2135 (modest_tny_account_store_get_transport_account_for_open_connection
2136 ): Do not try to get transport server accounts for local folders,
2137 because they don't have any. This avoids a g_warning().
2139 * src/maemo/modest-main-window.c:
2140 (modest_main_window_notify_send_receive_initied),
2141 (on_configuration_key_changed):
2142 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2143 * src/modest-defs.h:
2144 * src/modest-mail-operation.c:
2145 (modest_mail_operation_update_account):
2146 * src/modest-tny-account-store.h:
2147 * src/modest-tny-account.c:
2148 (modest_tny_account_get_special_folder),
2149 (modest_tny_account_new_for_local_folders),
2150 (modest_tny_account_new_for_per_account_local_outbox_folder):
2151 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2152 * src/modest-tny-local-folders-account.c:
2153 (add_account_folders_to_merged_folder):
2154 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2155 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2156 (modest_ui_actions_on_send):
2157 * src/widgets/modest-folder-view.c: (update_model):
2158 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2159 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2160 modest_tny_account_store_get_tny_account_by_account() to
2161 modest_tny_account_store_get_server_account() to make the code clearer.
2163 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2165 * src/dbus_api/modest-dbus-api.h:
2166 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2167 * src/maemo/modest-msg-edit-window.c:
2168 (modest_msg_edit_window_attach_file_noninteractive):
2169 added g_warning in case the file to be attached does not exist
2170 * tests/dbus_api/test_compose_mail.c: (main):
2171 removed obsolete comment, added generic files as test case
2173 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2175 * src/modest-tny-account-store.c: (get_server_accounts):
2176 Create the local folders account only once, not once for each outbox, and
2177 not only when there are some outboxes.
2179 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2181 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2182 code that is causing a crash at startup. Sergio says that he is fixing this.
2184 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2186 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2187 * src/maemo/modest-account-settings-dialog.c:
2188 (create_page_outgoing),
2189 (modest_account_settings_dialog_set_account_name),
2190 (save_configuration):
2191 - Fixed handling of the "Use secure authentication" toggle to comply with
2192 the ui specification. See also projects.maemo.org bug NB#58400
2194 - Restore the Secure connection setting combo correctly when loading
2197 * src/maemo/modest-maemo-utils.c:
2198 (on_camel_account_get_supported_secure_authentication),
2199 (modest_maemo_utils_get_supported_secure_authentication_methods):
2200 Fixed a crasher if operation is canceled
2202 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2203 (modest_protocol_info_auth_is_secure):
2204 * src/modest-protocol-info.h:
2206 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2207 the sense of the "Use secure authentication" toggle.
2209 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2211 * src/modest-tny-account-store.h:
2212 * src/modest-tny-account-store.c:
2213 Added modest_tny_account_store_get_local_folders_account().
2215 * src/modest-tny-folder.h:
2216 * src/modest-tny-folder.c:
2217 (modest_tny_folder_get_account):
2218 Added this replacement for tny_folder_get_account() which returns
2219 the local-folders account for TnyMergeFolders, to avoid the
2220 warning about the unimplemented get_account_func() vfunc().
2222 (modest_tny_folder_get_rules),
2223 * src/modest-ui-actions.c:
2224 (modest_ui_actions_on_folder_selection_changed):
2225 * src/modest-mail-operation.c:
2226 (modest_mail_operation_remove_folder),
2227 (modest_mail_operation_xfer_folder),
2228 (modest_mail_operation_rename_folder),
2229 (modest_mail_operation_get_msg),
2230 (modest_mail_operation_get_msgs_full),
2231 (modest_mail_operation_remove_msg),
2232 (modest_mail_operation_xfer_msgs),
2233 (modest_mail_operation_refresh_folder):
2234 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2236 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2238 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2239 (modest_server_account_set_security):
2240 * src/modest-defs.h: Add comments explaining that our
2241 UI spec means TLS when it says Normal, so these do not look like errors.
2243 * src/modest-tny-account.c:
2244 (modest_tny_account_new_from_server_account): Use the new tinymail
2245 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2246 for TLS. This should fix projects.maemo.org bug NB#58460.
2248 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2250 * src/maemo/easysetup/modest-easysetup-wizard.c:
2251 (create_account): Correct the position of the gconf sanity check warning.
2252 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2253 of using the g_idle_add() hack, because this does not seem to be necessary
2254 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2255 caused by something other than maemo's gconf.
2256 This fixes projects.maemo.org bug #59022.
2258 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2260 * src/modest-account-mgr-helpers.c:
2261 (modest_account_mgr_get_default_account): Do not check that the account
2262 exists if there is no default account (NULL), to fix a runtime warning.
2264 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2266 * src/widgets/modest-folder-view.c: (update_model):
2267 Do not unref the treemodel before we have finished with it.
2268 This prevents a valgrind warning and an occasional crash at startup.
2270 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2272 * libmodest-dbus-client/libmodest-dbus-client.h:
2273 added libmodest_dbus_client_compose_mail()
2274 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2276 added functions needed for SendAsMail() functionality
2277 * src/maemo/modest-msg-edit-window.c:
2278 (modest_msg_edit_window_attach_file_noninteractive):
2279 non interactively attaching files to message edit window
2280 * src/widgets/modest-msg-edit-window.h:
2281 * tests/dbus_api/Makefile.am:
2282 added test_compose_mail.c
2283 * tests/dbus_api/test_compose_mail.c: (main):
2285 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2287 * src/modest-account-view.c:
2288 Fixed bug projects.maemo.org bug NB#59307
2290 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2292 * src/maemo/easysetup/modest-easysetup-wizard.c:
2293 (get_serverport_incoming), (on_before_next), (create_account):
2294 * src/maemo/modest-account-settings-dialog.c:
2295 (modest_account_settings_dialog_set_account_name):
2296 * src/maemo/modest-maemo-utils.c:
2297 (on_camel_account_get_supported_secure_authentication_status),
2298 (on_camel_account_get_supported_secure_authentication),
2299 (on_secure_auth_cancel),
2300 (modest_maemo_utils_get_supported_secure_authentication_methods):
2302 Implemented security authentication for settings and easysetup.
2304 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2306 * src/maemo/modest-main-window.c: (create_details_widget):
2307 Show the total size for memory card accounts too, instead of showing
2308 the name again. Fixes bug projects.maemo.org bug NB#59307.
2310 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2313 * src/modest-tny-simple-folder-store.c:
2314 * src/modest-tny-simple-folder-store.h: Removed.
2316 * src/modest-tny-local-folders-account.h
2317 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2318 for the local-folders maildir, with an extra TnyMergedFolder containing
2319 the folders of the per-account outbox store accounts.
2320 * src/modest-tny-account-store.c: (get_server_accounts):
2321 Add the outboxes to the special local folders account after creating it.
2323 * src/modest-tny-account.c:
2324 (modest_tny_account_new_for_local_folders): Create the derived
2325 account when creating the main local-folders account.
2327 * src/maemo/modest-main-window.c: (create_details_widget),
2328 (modest_main_window_set_contents_style):
2329 Adapted to the use of the derived account instead of the folder store.
2331 * src/modest-ui-actions.c:
2332 (modest_ui_actions_on_folder_selection_changed):
2333 * src/modest-ui-dimming-rules.c:
2334 (modest_ui_dimming_rules_on_new_folder):
2335 * src/widgets/modest-folder-view.c: (text_cell_data),
2336 (icon_cell_data), (filter_row), (update_model),
2337 (get_cmp_rows_type_pos):
2340 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2341 Do not get the priv struct, because no priv struct has been set,
2342 to avoid a runtime warning.
2344 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2345 #ifelse with #else, to fix a warning, to fix the build.
2348 2007-06-05 Christian Kellner <ckellner@openismus.com>
2350 * libmodest-dbus-client/libmodest-dbus-client.c:
2351 Fix small typo in doc (why do you always see them
2352 AFTER committing stuff?)
2355 2007-06-05 Christian Kellner <ckellner@openismus.com>
2357 * libmodest-dbus-client/libmodest-dbus-client.c:
2358 (libmodest_dbus_client_search):
2359 Initialize hit list with NULL. Also set folder list
2360 to "" if NULL was supplied.
2363 2007-06-03 Christian Kellner <ckellner@openismus.com>
2365 * libmodest-dbus-client/libmodest-dbus-client.c:
2366 (modest_search_hit_list_free):
2367 Make it save to call it with NULL.
2369 * src/dbus_api/modest-dbus-callbacks.c:
2370 * src/modest-search.c:
2371 Return full ModestSearchHits as the search result list not TnyHeader
2372 since can't be around withouth the correspoding TnyFolder.
2374 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2376 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2377 Added currently commented code to check for secure auth
2379 * src/maemo/modest-account-settings-dialog.c: (on_response),
2380 (save_configuration), (show_ok):
2381 Fixed projects.maemo.org bugs NB #59248 and #59251
2383 * src/maemo/modest-maemo-utils.c:
2384 (on_camel_account_get_supported_secure_authentication_status),
2385 (on_camel_account_get_supported_secure_authentication),
2386 (modest_maemo_utils_get_supported_secure_authentication_methods):
2387 * src/maemo/modest-maemo-utils.h:
2388 Moved get_supported_secure_authentication() method here to be able
2389 to use it from easysetup wizard.
2391 * src/modest-pair.c: (on_pair_compare_as_string):
2392 Should compare string with first part of pair and not
2393 strcmp pairs which will crash.
2395 * src/modest-protocol-info.c:
2396 (modest_protocol_info_protocol_is_store):
2397 * src/modest-protocol-info.h:
2398 Added modest_protocol_info_get_auth_protocol_name()
2400 2007-06-03 Armin Burgmeier <armin@openismus.com>
2402 * src/modest-mail-operation.c:
2403 (modest_mail_operation_get_msgs_full): Set priv->account also when
2404 only retrieving a single message. This avoids a crash when canceling
2407 (modest_mail_operation_notify_end): Do not explicitely remove the
2408 operation from the queue but only emit the progress_changed signal.
2409 The queue itself listens to that signal to remove the operation when
2410 it is finished. This reduces coupling and removes a potential deadlock
2411 when modest_mail_operation_notify_end() is called from the queue
2412 itself. If that is a problem performance-wise, I would suggest to
2413 implement a status-changed signal or something.
2415 * src/modest-mail-operation-queue.c: Make sure to never call a
2416 function from another file while the queue is locked. This (hopefully)
2417 fixes another deadlock when exiting the application while retrieving
2420 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2422 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2423 Fixed build if libogs is not available
2425 2007-06-03 Christian Kellner <ckellner@openismus.com>
2427 * libmodest-dbus-client/libmodest-dbus-client.h:
2428 * libmodest-dbus-client/libmodest-dbus-client.c:
2429 (libmodest_dbus_client_delete_message):
2430 Implement deletion of messages (Client side).
2432 (modest_search_hit_free),
2433 (modest_search_hit_list_free):
2434 Utility functions to free the result hits.
2436 * src/dbus_api/modest-dbus-api.h:
2437 * src/dbus_api/modest-dbus-callbacks.c:
2438 (on_delete_message),
2439 (modest_dbus_req_handler):
2440 Implement deletion of messages (Server side).
2442 * tests/dbus_api/test_search.c: (main):
2445 * tests/dbus_api/Makefile.am:
2446 * tests/dbus_api/test_delete_message:
2447 Add little test for the message deletion logic
2449 2007-06-03 Armin Burgmeier <armin@openismus.com>
2451 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2452 when the operation queue was not empty. projects.maemo.org bug
2455 2007-06-03 Armin Burgmeier <armin@openismus.com>
2457 * src/widgets/modest-account-view.c
2458 (on_account_default_toggled): Toggle default account column
2459 explicitely instead of waiting for gconf notification (which is
2460 currently ignored). This should fix projects.maemo.org bug NB#56910
2461 for now. It should probably be removed when gconf notifications are
2464 2007-06-03 Christian Kellner <ckellner@openismus.com>
2466 * libmodest-dbus-client/libmodest-dbus-client.c:
2467 Removed debugging spew.
2469 * src/dbus_api/modest-dbus-callbacks.c:
2470 Added debugging info.
2472 * src/modest-search.c:
2473 (modest_search_all_accounts):
2474 Use tny_account_store_get_accounts () on the account store
2475 to get all accounts which is the way to get all accounts.
2477 * tests/dbus_api/test_search.c: (main):
2478 Make it possible to supply the search term on the command line.
2480 2007-06-03 Christian Kellner <ckellner@openismus.com>
2482 * libmodest-dbus-client/libmodest-dbus-client.c:
2483 * libmodest-dbus-client/libmodest-dbus-client.h:
2484 Implement searching for mesages over raw dbus. (Client side)
2486 * src/dbus_api/Makefile.am:
2487 * src/dbus_api/modest-dbus-api.h:
2488 * src/dbus_api/modest-dbus-callbacks.c:
2489 * src/dbus_api/modest-dbus-callbacks.h:
2490 Search framework (Server side). Also implement on_idle_open_message().
2492 * src/maemo/modest-platform.c: (modest_platform_init):
2493 Prepare for raw dbus/osso rpc interaction.
2495 * src/modest-search.h:
2496 Changed minsize from unspecific guint to guint32.
2498 * src/modest-search.c:
2500 Added strange hack which magically made tnymail work.
2502 (modest_search_folder),
2503 (modest_search_account),
2504 (modest_search_all_accounts):
2505 Implement helper functions to search all accounts, specific account
2508 * tests/dbus_api/Makefile.am:
2509 * tests/dbus_api/test_open_message.c:
2510 Read url to open from commandline.
2512 * tests/dbus_api/test_search.c:
2513 Implement small test for dbus search stuff
2515 2007-06-02 Armin Burgmeier <armin@openismus.com>
2517 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2518 include account type and account title. This fixes projects.maemo.org
2521 * src/maemo/modest-account-view-window.c: Set a title for the window.
2523 2007-06-02 Armin Burgmeier <armin@openismus.com>
2525 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2526 incoming and outgoing server name based on email address and server
2527 types as long as the names have not been edited manually. This fixes
2528 projects.maemo.org bug NB#58671.
2530 2007-06-02 Armin Burgmeier <armin@openismus.com>
2532 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2533 server type cannot be changed in future to the incoming details page
2534 when creating an account. This fixes projects.maemo.org bug NB#59029.
2536 2007-06-02 Armin Burgmeier <armin@openismus.com>
2538 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2539 and assigned max width chars so that they wrap instead of being
2540 truncated. Fixes projects.maemo.org bug NB#56126.
2542 2007-06-02 Armin Burgmeier <armin@openismus.com>
2544 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2545 introductory note to the connection specific smtp servers dialog, as
2546 section 8.12 of the email UI specification requires. This fixes
2547 projects.maemo.org bug NB#59212.
2549 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2552 Check for running mail operations, and offer to cancel them, as per the UI
2553 spec. This fixes projects.maemo.org bug NB#59041 .
2554 However, I suspect that tinymail may still use the network connection
2555 in ways that we cannot detect or cancel. But it should at least adapt to
2556 changes fairly well.
2558 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2560 * src/modest-tny-account-store.c: (recreate_all_accounts),
2561 (get_cached_accounts), (get_server_accounts): Do more sensible
2562 ref-counting of the temporarily-cached outbox accounts list. This seems
2563 to fix a crash when entering the password when the password was wrong.
2565 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2567 * src/gnome/modest-main-window.c: (connect_signals):
2568 * src/modest-tny-account-store.c: (get_password),
2569 (modest_tny_account_store_alert): Added comments and clues and
2570 commented-out code about how we currently fail to deal with connection
2571 errors and wrong passwords, and how we should.
2573 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2575 * src/widgets/modest-retrieve-combo-box.c:
2576 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2577 This fixes projects.maemo.org bug NB#58472 .
2579 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2581 * src/maemo/easysetup/modest-easysetup-wizard.c:
2582 (create_page_complete_easysetup):
2583 (create_page_complete_custom): Correct the last commit,
2584 putting the correct sentences in the correct pages.
2586 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2588 * src/maemo/easysetup/modest-easysetup-wizard.c:
2589 (create_page_complete_custom): Show the second sentence of text
2590 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2593 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2595 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2596 Set the leave-on-server conf key by default. This fixes
2597 projects.maemo.org bug NB#59258 .
2599 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2601 * src/maemo/modest-account-view-window.c:
2602 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2603 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2606 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2608 * src/maemo/easysetup/modest-easysetup-wizard.c:
2609 (create_caption_new_with_asterisk):
2610 * src/maemo/modest-account-settings-dialog.c:
2611 (create_caption_new_with_asterisk):
2612 Uncomment the code to add the asterisk, because they are no longer in the
2613 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2614 (update_incoming_server_title): Add an asterisk here too.
2616 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2618 * src/maemo/modest-maemo-global-settings-dialog.c:
2619 (current_connection): Check that we are even connected before trying to
2620 get the current connection name, to prevent a warning.
2622 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2623 Change the comments because tny_maemo_conic_device_connect() is now meant to
2625 * src/modest-mail-operation.c:
2626 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2627 make sure we have a connection and fail if we can't connect.
2629 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2631 * src/maemo/modest-main-window.c:
2632 (on_account_store_connecting_finished): Do not try to get the
2633 connection ID if we are not really connected. I am surprised that
2634 this signal handler is called when we are not connected.
2636 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2638 * src/modest-error.h:
2639 * src/modest-ui-actions.c:
2640 (modest_ui_actions_get_msgs_full_error_handler):
2641 Renamed an enum, added comments, added an enum
2642 for retrieve-limit errors.
2644 * src/modest-mail-operation.c: (foreach_add_item),
2645 (internal_folder_observer_update), (update_account_thread),
2646 (modest_mail_operation_get_msgs_full):
2647 (modest_mail_operation_update_account),
2648 Added comments about how this works, and some code that should
2649 (but does not) check the retrieve-limit. See the TODO comment.
2651 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2653 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2654 Initialize help_id to fix the build. Warnings are good.
2656 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2658 * src/widgets/modest-hbox-cell-renderer.c:
2659 (modest_hbox_cell_renderer_append):
2660 * src/widgets/modest-vbox-cell-renderer.c:
2661 (modest_vbox_cell_renderer_append):
2662 Fix the last commit by doing an extra ref.
2664 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2666 * src/widgets/modest-hbox-cell-renderer.c:
2667 (modest_hbox_cell_renderer_append):
2668 * src/widgets/modest-vbox-cell-renderer.c:
2669 (modest_vbox_cell_renderer_append):
2670 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2671 to fix the build with Maemo Bora.
2672 However, there seems to be a remaining crash, probably due to reference
2675 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2677 * src/modest-tny-account.c:
2678 (modest_tny_account_new_for_local_folders):
2679 Use hildon_file_system_info_async_new() to get a better name for
2680 the memory card account, setting it as the account name.
2681 The timing seems to work, but this is probably
2682 not the best place to do this. See the TODO comment.
2683 * src/maemo/modest-main-window.c: (create_details_widget):
2684 * src/widgets/modest-folder-view.c: (text_cell_data):
2685 Use the tny account name instead of hardcoding a name.
2687 2007-05-30 Christian Kellner <ckellner@openismus.com>
2689 * src/modest-search.c: (modest_search):
2690 Correctly set part_search_func even if we have already parsed
2691 the query and thus a valid OgsTextSearcher object.
2693 2007-05-30 Christian Kellner <ckellner@openismus.com>
2696 Search and check for libogs.
2699 Incooparte the ogs build env.
2701 * src/modest-mime-part-search-stream.c:
2702 * src/modest-mime-part-search-stream.h:
2703 Removed since we do the real searching now in modest-search.c.
2705 * src/modest-search.c:
2706 * src/modest-search.h:
2707 Implement support for ogs. We use that if available and requested
2708 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2709 should now handle the corner case when the search term is spread
2710 across multiple reads.
2711 Also the logic in modest_search () was corrected to search all
2712 requested fields until one is found.
2714 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2716 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2718 * src/modest-init.h:
2719 * src/modest-init.c: Made modest_init_local_folders() take a
2720 path and be public so we can iniitialize maildir folders on
2723 * src/modest-local-folder-info.h:
2724 * src/modest-local-folder-info.c:
2725 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2727 * src/modest-tny-account.c:
2728 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2729 still means the standard local-folders path on the local volume.
2731 * src/modest-tny-account-store.c:
2732 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2733 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2734 all accounts when that happens.
2735 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2736 this too, so it shows up in the treeview.
2738 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/modest-maemo-global-settings-dialog.c:
2741 (current_connection):
2742 * src/widgets/modest-global-settings-dialog.c:
2743 (current_connection_default):
2744 Use the enum values instead of 0, 1 and -1,
2745 to make the code clearer.
2747 * src/modest-account-mgr-helpers.c:
2748 (modest_account_mgr_get_connection_specific_smtp): Make this code
2751 * src/modest-runtime.h:
2752 * src/modest-runtime.c:
2753 Added modest_runtime_remove_all_send_queues().
2754 * src/maemo/modest-main-window.c:
2755 (on_account_store_connecting_finished): Recreate the send queues,
2756 using the appropriate transport accounts for this new connection.
2757 Some futher adapting might be needed if the old send queues are not
2758 automatically stopped at this point.
2760 * src/modest-tny-account-store.c: (get_server_accounts):
2761 Create the connection-specific transport accounts, so that they can
2762 be found later by their ID.
2764 * src/modest-tny-account.h:
2765 * src/modest-tny-account.c:
2766 Added modest_tny_account_new_from_server_account_name().
2767 modest_tny_account_new_from_server_account(): Do not create the
2768 send queues here, because they will be
2769 recreated anyway when the connection changes for the first time.
2771 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2773 * src/modest-local-folder-info.h:
2774 * src/modest-local-folder-info.c:
2775 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2776 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2777 tbox_folder): Take a modest account name instead of a server TnyAccount,
2778 so we can have per-modest-account rather than per-transport-account
2780 We must make sure that we change or recreate the exisitng send queues
2781 when the connection changes for connection-specific transport accounts.
2783 * src/modest-tny-account-store.c:
2784 (create_per_account_local_outbox_folders): Create outboxed per modest
2785 account, not per transport account.
2787 * src/modest-tny-account.h:
2788 * src/modest-tny-account.c:
2789 (modest_tny_account_get_special_folder): For outboxes, get the
2790 parent modest account name. The account is ignored for other folders.
2791 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2792 modest account name rather than a server TnyAccount.
2794 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2796 * src/modest-tny-account.c:
2797 (modest_tny_account_new_from_server_account):
2798 Call modest_runtime_get_send_queue() immediately after creating transport
2799 accounts, so that they start trying to send email from the outbox as soon
2800 as possible at startup. This is probably what we want.
2802 * src/modest-mail-operation.c: (update_account_thread):
2803 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2804 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2805 * src/modest-tny-send-queue.h:
2806 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2807 (modest_ui_actions_on_send):
2808 Added comments about how sending works, though it needs some more work.
2810 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2812 * src/modest-tny-account.c:
2813 (modest_tny_account_get_special_folder): Add TODO because this fails when
2814 the network is busy.
2815 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2816 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2817 Do not try to show this window when there is no active account. The UI
2818 specs does not tell us what to do in this case.
2820 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2824 * src/maemo/Makefile.am:
2825 * src/widgets/Makefile.am: Some dist fixes.
2827 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2829 * src/maemo/modest-connection-specific-smtp-window.c:
2830 (on_button_edit): Make the code clearer, to prevent a double free.
2832 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/modest-account-settings-dialog.c:
2835 (modest_account_settings_dialog_set_account_name),
2836 Check the connection-specific smtp servers checkbox if there are any.
2838 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2839 (modest_connection_specific_smtp_edit_window_init):
2840 Start with a suitable port number.
2842 * src/modest-account-mgr-helpers.h:
2843 * src/modest-account-mgr-helpers.c: Added
2844 modest_account_mgr_get_has_connection_specific_smtp().
2846 (modest_account_mgr_set_connection_specific_smtp),
2847 (modest_account_mgr_remove_connection_specific_smtp),
2848 (modest_account_mgr_get_has_connection_specific_smtp),
2849 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2850 connection-specific smtp server accounts in the account, rather than
2851 the server account conf dir.
2853 This fixes bug projects.maemo.org bug NB#58263 .
2855 * src/modest-tny-account-store.c:
2856 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2857 if there are no server accounts yet, to prevent an infinite loop when there
2858 are no accounts. Document that one must be called before the other.
2860 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2862 * src/modest-account-mgr-helpers.c:
2863 (modest_account_mgr_get_default_account): Make sure that at least
2864 one account is always the default, if there are any enabled accounts.
2865 This is just a sanity check that shouldn't be necessary.
2867 * src/modest-account-mgr-priv.c:
2868 (_modest_account_mgr_account_from_key): Unescape the conf key to
2869 get the real account name. For instance, this is an issue if a space
2870 was in the account name, which can happen because the account name
2871 is generated from the display name.
2872 (_modest_account_mgr_get_account_keyname): Always escape the
2874 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2875 Unescape the conf keys to get the real account names.
2877 For instance, previously the is-default radio button in the accounts
2878 list was not checked for any accounts at first. This fixes that,
2879 and might fix several similar bugs.
2881 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2884 Removed some debug printfs.
2886 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2888 Modest on-disk outbox directories are now here, for instance:
2889 $HOME/.modest/outboxes/<account-id-1>/outbox
2890 $HOME/.modest/outboxes/<account-id-2>/outbox
2892 $HOME/.modest/local-folders/outbox
2893 so we can have a separate outbox for each account.
2894 But they are shown as one outbox in the GtkTreeView, by using a
2895 TnyMergeFolder in a ModestTnySimpleFolderStore.
2898 * src/modest-tny-simple-folder-store.c:
2899 * src/modest-tny-simple-folder-store.h:
2900 Added ModestTnySimpleFolderStore, used to contain folders from
2901 other folder stores, such as other accounts.
2903 * src/modest-tny-outbox-account.h:
2904 * src/modest-tny-outbox-account.c:
2905 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2906 used for the per-account local outbox folders.
2908 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2909 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2910 only use this (internally) now for the non-outbox local folders.
2912 * src/modest-init.h:
2913 * src/modest-init.c: Added modest_init_one_local_folder(), for
2914 setting up the directory structure for each local folder.
2916 * src/modest-local-folder-info.c:
2917 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2918 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2920 * src/modest-local-folder-info.h:
2921 * src/modest-tny-account-store.c: (on_account_removed),
2922 (on_account_changed), (create_per_account_local_outbox_folders),
2923 (get_server_accounts), (modest_tny_account_store_get_accounts),
2924 (modest_tny_account_store_get_tny_account_by_account),
2925 (modest_tny_folder_store_is_virtual_local_folders):
2927 * src/modest-tny-account.h:
2928 * src/modest-tny-account.c:
2929 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2930 to create an on-disk per-account local outbox folder for each
2932 (create_per_account_local_outbox_folders): Create a local outbox folder
2933 for each transport account.
2934 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2935 for all local folders.
2937 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2938 instead of using g_object_get/set() directly. It is clearer.
2940 (modest_tny_folder_store_get_message_count),
2941 (modest_tny_folder_store_get_local_size
2942 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2943 because we now use these with non-acount folder stores.
2945 (modest_tny_account_get_special_folder),
2946 (modest_tny_account_new_from_server_account),
2947 (modest_tny_account_new_from_account):
2948 (recurse_folders): Adjust to the new outbox system.
2950 * src/modest-tny-folder.h:
2951 * src/modest-tny-folder.c:
2952 (modest_tny_folder_is_local_folder),
2953 (modest_tny_folder_get_local_folder_type),
2954 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2956 * src/widgets/modest-main-window.h:
2957 * src/maemo/modest-main-window.c: (create_details_widget),
2958 (modest_main_window_set_contents_style): Show details for any folder store,
2961 (modest_tny_folder_get_rules):
2962 Remove the const. C does not support constness enough for this.
2964 * src/modest-ui-actions.c:
2965 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2966 make all outboxes appear as one, in the usual local-folders tree node.
2968 (set_active_account_from_tny_account),
2969 (modest_ui_actions_on_folder_selection_changed):
2970 * src/widgets/modest-folder-view.c: (text_cell_data),
2971 (icon_cell_data), (filter_row),
2972 (add_account_folders_to_merged_folder),
2973 (add_account_folders_to_simple_folder_store), (),
2974 (get_cmp_rows_type_pos), (cmp_rows),
2975 (modest_folder_view_set_account_id_of_visible_server_account):
2976 Adjust to the new outbox system, using generic folder stores and folders
2977 in the GtkTreeModel.
2979 2007-05-23 Christian Kellner <ckellner@openismus.com>
2981 * src/modest-mail-operation.c:
2982 (modest_mail_operation_update_account):
2983 Use info->max_size instead of unintialized local var [small
2984 build fix]. (Added TODO to review that change since I don't
2987 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2989 * libmodest-dbus-client/libmodest-dbus-client.c:
2990 (libmodest_dbus_client_compose_mail): function added
2991 * src/dbus_api/modest-dbus-api.h:
2992 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2993 (on_compose_mail): Implementation of the SendAsMail functionality
2995 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2997 * src/modest-account-mgr.c:
2998 (modest_account_mgr_add_server_account): Set the secure-connection
2999 conf key for transport accounts as well as store accounts. I don't know
3000 why the if was there. For instance, this makes sure that we use SSL
3001 for the gmail preset from the easysetup wizard.
3003 2007-05-22 Murray Cumming <murrayc@murrayc.com>
3005 * src/gnome/modest-main-window.c:
3006 (on_account_store_connecting_finished), (connect_signals):
3007 * src/maemo/modest-main-window.c:
3008 (on_account_store_connecting_finished), (connect_signals),
3009 (modest_main_window_new):
3010 Handle TnyAccountStore::connecting-finished instead of
3011 TnyDevice::connection-changed, because we cannot actually perform
3012 operations on accounts until TnyAccountStore has itself responded to
3013 the TnyDevice::connection-changed signal. This prevents a GError from
3015 Do not try to update at startup, because we (at least on scratchbox)
3016 already do an update at startup when the device goes online.
3017 This prevents a GError from tinymail.
3018 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
3019 Added TODO about stopping simultaneous operations.
3021 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3023 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3024 * src/modest-mail-operation-queue.c:
3025 (modest_mail_operation_queue_remove):
3026 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3027 about where they happened.
3029 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3031 * src/modest-ui-actions.c:
3032 (modest_ui_actions_on_password_requested): Make sure that the remember
3033 output parameter is always TRUE.
3035 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3037 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3038 Show a OK/Cancel dialog if the error is a question, though we still do not
3039 know anything more about what we are asking the user.
3040 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3041 Fix an uninitialized variable (helper). This is a logic error, however.
3043 2007-05-21 Christian Kellner <ckellner@openismus.com>
3045 * src/modest-search.h:
3046 Correct bit shifting in the ModestSearchFlags enum.
3048 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3050 * src/modest-tny-account.c:
3051 (modest_tny_account_new_from_server_account): Do not use the lsub and
3052 check-all hard-coded IMAP options when using POP.
3054 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3056 * src/modest-tny-account.c:
3057 (modest_tny_account_new_from_server_account):
3058 Use NULL for the secure-auth method for POP when Password auth has been
3059 specified by the user, as we already do for IMAP. "auth=Login" causes
3060 an error from camel or the server.
3062 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3064 * src/maemo/modest-account-settings-dialog.c:
3065 (create_page_account_details),
3066 (modest_account_settings_dialog_set_account_name):
3067 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3068 for the leave-on-server checkbox, rathr than just the checkbox, when
3069 the protocol is not POP.
3071 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3073 * src/widgets/modest-account-view.c:
3074 * src/widgets/modest-account-view.h:
3075 Added modest_account_view_select_account() which will be useful later
3076 to asynchronously re-select the edited account.
3078 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3080 * src/maemo/modest-account-settings-dialog.c:
3081 (modest_account_settings_dialog_set_account_name):
3082 Automatically choose the port numbers based on the secure authentication
3083 methods, if they have not been chosen before.
3084 This fixes projects.maemo.org bug NB#56273 .
3086 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3088 * src/maemo/modest-main-window-ui.h:
3089 * src/modest-ui-actions.c:
3090 * src/modest-ui-actions.h:
3091 Connect the Tools/SMTP Servers menu item to
3092 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3093 SMTP servers dialog, as in the UI specification and saves changes when it
3094 is closed. This fixed projects.maemo.org bug NB#56305 .
3096 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3098 * src/maemo/modest-connection-specific-smtp-window.c:
3099 (modest_connection_specific_smtp_window_init):
3100 Use gtk_window_set_default_size() to make this window big enough, so
3101 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3103 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3105 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3106 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3107 (modest_connection_specific_smtp_edit_window_init),
3108 Do not try to connect to a combobox signal before the combobox exists.
3109 This fixes the cras in projects.maemo.org bug NB#56288 .
3110 (modest_connection_specific_smtp_edit_window_get_settings):
3111 Remove the server_account_name parameter which was being checked for NULL
3112 though it was not used.
3114 * src/maemo/modest-connection-specific-smtp-window.c:
3115 (modest_connection_specific_smtp_window_fill_with_connections),
3116 (on_button_edit), (modest_connection_specific_smtp_window_init):
3117 Correct the number of treemodel columns to prevent a warning.
3118 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3119 libconic does not work.
3121 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3123 * src/modest-tny-account.c:
3124 (modest_tny_account_new_from_server_account):
3125 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3126 SMTP when "None" was chosen by the user. However, with my SMTP server that
3127 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3130 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3132 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3133 to explain the memory management issue with the ID in the ModestPair.
3135 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3136 (add_sending_page), (modest_account_assistant_finalize):
3137 * src/gnome/modest-gnome-global-settings-dialog.c:
3138 (create_updating_page), (create_composing_page):
3139 * src/gnome/modest-msg-edit-window.c: (get_transports),
3140 (init_window), (modest_msg_edit_window_finalize),
3141 (modest_msg_edit_window_get_msg_data):
3142 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3143 * src/gnome/modest-transport-widget.c:
3144 (modest_transport_widget_finalize), (smtp_configuration):
3145 * src/maemo/modest-maemo-global-settings-dialog.c:
3146 (create_updating_page), (create_composing_page):
3147 * src/maemo/modest-msg-edit-window.c: (get_transports),
3148 (init_window), (modest_msg_edit_window_finalize),
3149 (modest_msg_edit_window_get_msg_data),
3150 (modest_msg_edit_window_free_msg_data):
3151 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3152 (modest_store_widget_finalize):
3153 * src/maemo/modest-transport-widget.c:
3154 (modest_transport_widget_finalize), (smtp_configuration):
3155 * src/modest-main.c: (send_mail):
3156 * src/widgets/modest-combo-box.h:
3157 * src/widgets/modest-global-settings-dialog-priv.h:
3158 * src/widgets/modest-global-settings-dialog.c:
3159 (modest_global_settings_dialog_finalize):
3160 * src/widgets/modest-msg-edit-window.h:
3161 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3162 as long as the combo box, to prevent use of freed memory for the ID.
3164 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3166 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3167 get_accounts(), to make this clearer. Do not check for the enabled gconf
3168 key, because we do not use this for server accounts (at least, not yet).
3169 This allows us to send email again.
3171 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3173 * src/maemo/modest-platform.c:
3174 (on_modest_conf_update_interval_changed), (modest_platform_init):
3175 Only respond to this particular key change. All these strcmp()s cannot be
3178 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3180 * src/maemo/modest-maemo-global-settings-dialog.c:
3181 (current_connection): Prevent a crash in scratchbox when
3182 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3183 * src/maemo/modest-platform.c:
3184 (on_modest_conf_update_interval_changed), (modest_platform_init):
3185 Get the update interval from gconf and reset it when the gconf key changes.
3187 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3189 * src/modest-protocol-info.c:
3190 * src/modest-protocol-info.h: Adde enum-specific get functions,
3191 instead of using a ModestProtocolType enum parameter.
3193 * src/gnome/modest-account-assistant.c:
3194 * src/gnome/modest-store-widget.c:
3195 * src/gnome/modest-store-widget.h:
3196 * src/gnome/modest-transport-widget.c:
3197 * src/gnome/modest-transport-widget.h:
3198 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3199 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3200 * src/maemo/easysetup/modest-easysetup-wizard.c:
3201 * src/maemo/modest-account-settings-dialog.c:
3202 * src/maemo/modest-account-settings-dialog.h:
3203 * src/maemo/modest-store-widget.c:
3204 * src/maemo/modest-store-widget.h:
3205 * src/maemo/modest-transport-widget.c:
3206 * src/maemo/modest-transport-widget.h:
3207 * src/modest-account-mgr-helpers.c:
3208 * src/modest-account-mgr-helpers.h:
3209 * src/modest-account-mgr.c:
3210 * src/modest-account-mgr.h:
3211 * src/modest-tny-account.c:
3212 * src/modest-tny-folder.c:
3213 * src/widgets/modest-account-view.c:
3214 * src/widgets/modest-retrieve-combo-box.c:
3215 * src/widgets/modest-retrieve-combo-box.h:
3216 * src/widgets/modest-secureauth-combo-box.c:
3217 * src/widgets/modest-serversecurity-combo-box.c:
3218 * src/widgets/modest-serversecurity-combo-box.h:
3219 * tests/check_account-mgr.c:
3220 Use the specific functions, and use the re-renamed enum values for GNOME too.
3222 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3224 * src/modest-pair.h:
3225 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3226 so we can get the second based on the first.
3228 * src/maemo/modest-account-settings-dialog.h:
3229 * src/maemo/modest-account-settings-dialog.c:
3230 Added get_supported_secure_authentication_methods(), though it is mostly
3231 commented-out for now until the necessary API is committed to tinymail.
3232 (modest_account_settings_dialog_set_account_name),
3233 (save_configuration): Request the supported authentication methods from the
3234 server, so we can choose a working method.
3236 * src/modest-tny-account-store.h:
3237 * src/modest-tny-account-store.c:
3238 (modest_tny_account_store_get_session): Rename from
3239 tny_account_store_get_session().
3241 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3243 * src/modest-protocol-info.h: Split the ModestProtocol enum
3244 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3245 There was no need to have these unrelated values in one enum.
3247 * src/: many files: Adapted to changed enum. This makes the code a bit
3248 clearer, and the compiler could catch some errors.
3250 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3252 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3253 Show the detailed internal camel error message when an error happens
3254 during the configuration, so that our testers can give us more clues.
3255 For instance, in projects.maemo.org bug NB#56910 .
3257 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3259 * src/modest-tny-account.c:
3260 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3261 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3263 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3265 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3266 * src/maemo/modest-account-settings-dialog.c:
3267 (modest_account_settings_dialog_set_account_name),
3268 (save_configuration): For the incoming secure authentication checkbox,
3269 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3270 the UI specification. PLAIN does not seem to be supported for most IMAP
3271 servers anyway, and I am not sure what it would mean.
3272 However, we probably need to discover which of the secure-authentication
3273 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3274 * src/modest-account-mgr-helpers.c:
3275 (modest_account_mgr_get_server_account_data):
3277 * src/modest-tny-account.c:
3278 (modest_tny_account_new_from_server_account):
3279 Use tny_account_set_mech() to set secure-authentication methods,
3280 with some special-casing for IMAP, based on my observations of how
3283 * src/modest-account-mgr-helpers.h:
3284 * src/modest-account-mgr.c:
3285 * src/modest-defs.h: Comment that the URI is only used for local folders.
3287 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3289 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3290 parameter const, just to be neat.
3291 * src/modest-text-utils.c: (modest_text_utils_inline):
3292 End g_strconcat() with NULL, as its documentation says. This is almost
3293 certainly the cause of my crash at startup on the device. Interestingly,
3294 valgrind doesn't tell us about these errors.
3296 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3298 * scripts/build-packages: Added more precise comments about how to use
3299 this script, though I still get this error:
3300 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3301 error building tinymail
3303 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3305 * src/maemo/modest-main-window.c: (on_account_update):
3306 Very slight cleanup, hoping to make it simpler to discover what causes
3307 a crash here sometimes.
3309 * src/modest-tny-account.c:
3310 (modest_tny_account_new_from_server_account): Set the port. Added
3311 comments about the options and a TODO comment because I need to find out
3312 how to specify the secure authentication method.
3314 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3316 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3317 changed CFlags paths form modest to libmodest
3319 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3321 * src/modest-account-mgr-helpers.c:
3322 (modest_account_mgr_get_server_account_data),
3323 (modest_account_mgr_free_server_account_data):
3324 * src/modest-account-mgr-helpers.h:
3325 * src/modest-account-mgr.c:
3326 (modest_account_mgr_add_server_account):
3327 * src/modest-defs.h:
3328 * src/modest-tny-account.c:
3329 (modest_tny_account_new_from_server_account):
3330 Determine the options for tny_camel_account_add_option() here,
3331 based on the settings, rather than storing them directly in gconf.
3333 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3335 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3336 Show a more friendly error dialog now that we expect (from the tinymail
3337 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3339 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3341 * src/maemo/modest-main-window.c: (on_account_update): Check that
3342 account_name is not NULL, to prevent a crash at startup that I am
3343 seeing on the N800. I do wonder why it is NULL.
3345 * src/maemo/easysetup/modest-easysetup-wizard.c:
3346 (create_page_user_details):
3347 * src/maemo/modest-account-settings-dialog.c:
3348 (create_page_user_details), (create_page_outgoing):
3349 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3350 (modest_connection_specific_smtp_edit_window_init):
3351 * src/modest-ui-actions.c:
3352 (modest_ui_actions_on_password_requested):
3353 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3354 might do something useful with the on-screen keyboard.
3356 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3358 * src/maemo/modest-main-window.c: (on_account_update):
3359 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3360 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3362 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3364 * src/modest-tny-account-store.c: (on_account_changed):
3365 Correct the signature of this signal handler.
3367 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3369 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3370 Show a HildonNote instead of a GtkDialog for Maemo.
3372 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3374 * src/widgets/modest-account-view.h:
3375 * src/widgets/modest-account-view.c: (on_account_changed),
3376 (on_account_removed). Added a boolean flag, set/unset by
3377 modest_account_view_block_conf_updates(),
3378 modest_account_view_unblock_conf_updates() to prevent unnecessary
3379 updates, but this is not very useful because the gconf notifications are
3380 so delays (maybe only on Maemo Bora).
3381 So auto-updating is turned off, and these functions do an explicit
3382 update when necessary.
3383 However, something else is still doing too much work when adding/removing
3384 accounts, probably in another part of the application.
3386 * src/maemo/modest-account-view-window.c:
3387 (on_delete_button_clicked), (on_edit_button_clicked),
3388 (on_new_button_clicked): Use the new functions.
3390 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-account-mgr-helpers.c:
3393 (modest_account_mgr_set_first_account_as_default):
3394 Sort the list of names alphabetically-by-title, so we choose the first one
3396 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3397 alphabetically by the title.
3399 This fixes projects.maemo.org bug NB#56418 .
3401 * src/modest-account-mgr-priv.c:
3402 (_modest_account_mgr_account_from_key):
3403 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3404 avoid a valgrind error, and possible random behaviour.
3406 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3408 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3409 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3410 tinymail documentation to say that this can be expected.
3411 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3412 pretty, and should not happen, but I would prefer to know when it does.
3414 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3416 * configure.ac: When using the older hildon version, probably on Bora,
3417 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3419 * src/widgets/modest-attachment-view.c:
3420 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3423 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3425 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3426 Implemented the prototype. Can be tested with
3427 tests/dbus_api/test_open_message:
3429 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3431 * src/modest-tny-account-store.c:
3432 (modest_tny_account_store_instance_init), (get_password):
3433 * src/modest-ui-actions.c:
3434 (modest_ui_actions_on_password_requested):
3435 Do not store the password in gconf, because this function is called
3436 for non-remembered passwords. Actually use the cached (in the hash map)
3437 password instead of releasing it.
3438 The password will now not be remembered if it is asked via the protected
3439 password dialog, as per the UI spec.
3441 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3443 * src/modest-defs.h:
3444 * src/modest-account-mgr-helpers.h:
3445 * src/modest-account-mgr-helpers.c:
3446 Added modest_server_account_get_username_has_succeeded(),
3447 modest_server_account_set_username_has_succeeded().
3448 (modest_server_account_set_username),
3449 Reset the has-succeeded flag if the username changes.
3451 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3452 * src/maemo/modest-connection-specific-smtp-window.c:
3453 (modest_connection_specific_smtp_window_save_server_accounts):
3454 Use modest_server_account_set_username() instead of using
3455 modest_conf_set_string() directly, so that the has-succeeded flag is always
3458 * src/modest-ui-actions.c:
3459 (modest_ui_actions_on_password_requested): Dim the username entry if
3460 the username has ever worked, as per the UI spec.
3462 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3464 * src/modest-tny-account-store.c: (get_password):
3465 * src/modest-ui-actions.c:
3466 (modest_ui_actions_on_password_requested):
3467 Allow the username to be changed too, though there is more work to
3468 be done on exactly how this behaves.
3470 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3472 * src/modest-account-mgr-helpers.h:
3473 * src/modest-account-mgr-helpers.c:
3474 Added modest_account_mgr_get_display_name(),
3475 modest_server_account_get_username(),
3476 modest_server_account_set_username(),
3477 modest_server_account_set_password(),
3478 modest_server_account_get_hostname() functions so we do not need to
3479 use the conf API directly.
3481 * src/maemo/modest-main-window.c: (connect_signals):
3482 Actually connect ot the ModestAccountStore::request-password signal,
3483 so that we show the dialog when the password is requested by Tinymail,
3484 for isntance if it is empty.
3486 * src/modest-marshal.list:
3487 * src/modest-tny-account-store.c:
3488 (modest_tny_account_store_class_init), (get_password),
3489 (modest_tny_account_store_alert):
3490 * src/modest-tny-account-store.h:
3491 * src/modest-ui-actions.h:
3492 * src/modest-ui-actions.c:
3493 (modest_ui_actions_on_password_requested):
3494 Change the signal parameters, so it is obvious that we are providing
3495 the non human-readable server name, and receiving both the username
3496 and password, though changing of the username is not yet implemented.
3497 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3498 for the GNOME version.
3500 This should fix the projects.maemo.org bug NB#56209, though it does not
3501 work on Bora, because the gconf_client_get() for the password fails
3502 immediately after we save it with gconf_client_set().
3504 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3507 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3508 caused an undefined symbol error:
3509 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3511 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3513 * src/modest-tny-account-store.c:
3514 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3515 using a GError instead of a string message, so we can translate it in
3518 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3520 * src/maemo/modest-address-book.c:
3521 (modest_address_book_check_names):
3522 * src/maemo/modest-msg-view-window.c:
3523 (modest_msg_view_window_clipboard_owner_change):
3524 * src/modest-init.c: (modest_init_init_ui):
3525 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3526 (update_folders_cb), (modest_mail_operation_update_account):
3527 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3528 (modest_ui_actions_on_msg_attachment_clicked),
3529 (modest_ui_actions_on_msg_recpt_activated):
3530 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3531 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3532 (modest_msg_view_search_next):
3533 * src/widgets/modest-recpt-editor.c:
3534 (modest_recpt_editor_on_button_release_event),
3535 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3536 g_message(). At this point we should only be seeing interesting errors on
3537 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3539 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3541 (modest_wizard_dialog_force_title_update):
3542 * src/maemo/easysetup/modest-wizard-dialog.h:
3543 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3544 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3545 can update the title when appropriate. Otherwise the title is wrong if the
3546 pages are added after adding the notebook to the dialog.
3547 This must be a problem in HildonWizardDialog too.
3548 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3550 * src/maemo/easysetup/modest-easysetup-wizard.c:
3551 (create_subsequent_customsetup_pages),
3552 (create_subsequent_easysetup_pages):
3553 Call modest_wizard_dialog_force_title_update() so that the title is
3554 correct even with GTK+ < 2.10.
3555 This fixes projects.maemo.org bug NB#56145 .
3557 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3559 * src/maemo/modest-platform.c:
3560 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3561 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3564 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3566 * src/widgets/modest-window.h:
3567 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3568 and modest_window_save_state(), which invokes it.
3570 * src/widgets/modest-window-mgr.h:
3571 * src/widgets/modest-window-mgr.c:
3572 Added modest_window_mgr_save_state_for_all_windows(), which calls
3573 the save_state vfunc on all registered windows, if implemented.
3575 * src/gnome/modest-msg-edit-window.c:
3576 * src/gnome/modest-msg-view-window.c:
3577 * src/maemo/modest-msg-edit-window.c:
3578 * src/maemo/modest-msg-view-window.c:
3579 * src/maemo/modest-main-window.c:
3580 Specify the existing save_settings functions as implementations of
3581 ModestWindow::save_state_func().
3583 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3584 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3585 enabling hibernation, for instance.
3587 We may need to do the same thing for restoring settings.
3590 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3592 * src/widgets/modest-window-mgr.c:
3593 * src/widgets/modest-window-mgr.h:
3594 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3595 modest_window_mgr_get_hibernation_is_prevented().
3597 * src/maemo/modest-main-window.c:
3598 (on_hildon_program_is_topmost_notify): Prevent hibernation
3599 (possible when the application goes to the background in the WM),
3600 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3602 * src/maemo/easysetup/modest-easysetup-wizard.c:
3603 (modest_easysetup_wizard_dialog_init):
3604 * src/maemo/modest-account-settings-dialog.c:
3605 (modest_account_settings_dialog_init):
3606 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3607 (modest_connection_specific_smtp_edit_window_init):
3608 * src/maemo/modest-connection-specific-smtp-window.c:
3609 (modest_connection_specific_smtp_window_init):
3610 * src/maemo/modest-signature-editor-dialog.c:
3611 (modest_signature_editor_dialog_init):
3612 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3613 prevent hibernation while any of these account settings dialogs are open.
3615 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3617 * src/maemo/Makefile.am:
3618 * src/maemo/modest-osso-state-saving.c:
3619 * src/maemo/modest-osso-state-saving.h: Added
3620 modest_osso_load_state() and modest_osso_save_state() though they do
3621 nothing now. They should iterate through all the open windows and load/save
3623 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3624 save state when closing.
3626 * src/maemo/modest-main-window.c:
3627 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3628 Add a notification handler for the HildonProgram::is-topmost property,
3629 so we can allow hibernation when the application goes into the background.
3630 But we still need to detect when the accounts setup windows are open so
3631 we can stop hibernation when they are open.
3632 To do this, I also added the main window the HildonProgram. This might have
3633 other side-effects/benefits, and should maybe be done for other windows.
3635 * src/maemo/modest-osso-autosave-callbacks.h:
3636 * src/maemo/modest-osso-autosave-callbacks.c:
3637 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3638 though it does not do anything yet, and we might never need this to do
3639 anything. For instance, we already save drafts.
3641 * src/maemo/modest-platform.c: (modest_platform_init):
3642 Specify the libosso auto-save callback.
3644 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3646 * src/maemo/modest-platform.c:
3647 (modest_platform_set_update_interval):
3648 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3649 aparently stays valid between application instances, so we can use this
3650 to remove and reset it later. According to a maemo-developers email from
3653 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3655 * configure.ac: Depend on libalarm for Maemo.
3657 * src/dbus_api/modest-dbus-api.h:
3658 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3659 (on_send_receive), (modest_dbus_req_handler):
3660 Handle a SEND_RECEIVE D-Bus method.
3662 * libmodest-dbus-client/libmodest-dbus-client.c:
3663 (libmodest_dbus_client_send_and_receive):
3664 * libmodest-dbus-client/libmodest-dbus-client.h:
3665 Add C convenience functions for calling the new D-Bus method.
3667 * src/modest-platform.h:
3668 * src/gnome/modest-platform.c:
3669 * src/maemo/modest-platform.c:
3670 Added modest_platform_set_update_interval(), which uses the
3671 alarmd API on Maemo.
3672 (modest_platform_init),
3673 Call modest_platform_set_update_interval(), using a hard-coded
3674 interval for now (until the global settings dialog is implemented),
3675 though I am not sure that this makes sense yet.
3677 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3679 * src/dbus_api/modest-dbus-callbacks.c:
3680 (modest_osso_cb_hw_state_handler):
3681 * src/dbus_api/modest-dbus-callbacks.h:
3682 * src/maemo/modest-platform.c: (modest_platform_init):
3683 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3684 in case this has some effect on the ability for Maemo to ping the
3687 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3689 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3690 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3691 warning. It is probably a logic error, but I need to fix the build.
3693 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3695 * src/modest-account-mgr.h:
3696 * src/modest-account-mgr.c:
3697 (modest_account_mgr_account_names): Add a gboolean enabled_only
3698 parameter, so we can get lists of onlt the enabled accounts.
3700 (modest_account_mgr_add_account),,
3701 (modest_account_mgr_account_with_display_name_exists):
3702 * src/maemo/modest-msg-edit-window.c: (get_transports):
3703 * src/modest-account-mgr-helpers.c:
3704 (modest_account_mgr_set_first_account_as_default):
3705 * src/modest-init.c: (init_default_account_maybe):
3706 * src/modest-tny-account-store.c: (get_accounts):
3707 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3708 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3709 * tests/check_account-mgr.c: (START_TEST):
3710 Provide the extra parameter, as appropriate.
3712 * src/widgets/modest-account-view.c: (update_account_view):
3713 Do not show disabled accounts (meaning that there is no way to
3714 enable/disable accounts in the UI (the feature is not in our UI
3715 specification), so we can use this internally only to mark unfinished
3716 or temporary account data.
3718 * src/maemo/easysetup/modest-easysetup-wizard.c:
3719 (create_account): Add boolean enable parameter, so we can specify FALSE
3720 to create the temporary account.
3721 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3722 (on_before_next): When finishing, when there is a temporary account, just
3724 Also, use a timeout to delay the showing of the dialog until gconf is likely
3725 to return correct information, due to a maemo gconf bug that is fixed in
3726 osso 1.1, but not yet in Bora.
3727 However, the dialog stays on screen after it is destroyed.
3729 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3730 for invalid data when cancelling. Use a hildon note instead of a dialog
3731 to complain about invalid data. Do not show the account-saved note if the
3732 account is disabled (a temporary account that will not really be saved for use
3735 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3737 * src/modest-account-mgr-helpers.h:
3738 * src/modest-account-mgr-helpers.c:
3739 Added modest_account_mgr_unset_default_account(),
3740 Added modest_account_mgr_set_first_account_as_default().
3742 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3743 If it was the default account, unset the default account name.
3745 * src/maemo/modest-account-view-window.c:
3746 (on_delete_button_clicked): If it was the default account,
3747 set the first remaining account as the default instead.
3749 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3750 a NULL account or a NULL default account, to prevent a crash. This should
3751 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3754 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3756 * src/widgets/modest-recpt-editor.c:
3757 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3758 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3759 TODO comment for this. This fixes the build.
3761 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3762 be the best place for it. This will in future update all auto-update accounts,
3763 rather than just the current/default account, when that gconf key exists.
3764 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3765 if there are no accounts, before calling do_send_receive().
3766 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3768 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3769 * src/maemo/modest-main-window-ui.h:
3770 * src/maemo/modest-main-window.c: (on_connection_changed),
3771 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3772 directly, becaue the signal handler does more.
3774 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3776 * src/modest-account-mgr-helpers.c:
3777 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3778 for the case that the account does not exist.
3780 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3781 (equivalent to the modest account name) rather than the tinymail account name
3782 (equivalent to the modest account title - human readable) to get the account data.
3783 Check for null account data to prevent the crash, and add a TODO comment saying that
3784 this needs fixing because it is using the server account name instead of the account name.
3786 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3788 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3789 * src/maemo/modest-account-settings-dialog.c: (show_error),
3791 Use hildon_note_new_information() for informative and error messages,
3792 which seems to be expected for Maemo applications (no documentation that I know of
3793 says this). I am surprised that there is no distinction between info and error
3796 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3798 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3799 it is easy to find where this is used.
3801 * src/maemo/easysetup/modest-easysetup-wizard.c:
3802 (create_page_welcome), (create_page_account_details),
3803 (create_page_user_details), (create_page_complete_easysetup),
3804 (create_page_custom_incoming), (create_page_custom_outgoing),
3805 (create_page_complete_custom):
3806 * src/maemo/modest-account-settings-dialog.c:
3807 (create_page_account_details), (create_page_user_details),
3808 (create_page_incoming), (create_page_outgoing):
3809 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3810 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3811 (modest_connection_specific_smtp_edit_window_init):
3812 * src/maemo/modest-connection-specific-smtp-window.c:
3813 (modest_connection_specific_smtp_window_init):
3814 * src/maemo/modest-signature-editor-dialog.c:
3815 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3816 and scrolling policy as per the Email Application Layout Guide, if I have
3819 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3821 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3822 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3823 which were empty, because these vfuncs have been removed from TnyAccountStore.
3824 This fixes the build.
3826 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3828 * src/maemo/modest-main-window.c:
3829 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3830 showing/hiding it. Added TODO because it probably should not be NULL.
3831 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3832 because unnecessary g_warnings() make degugging difficult.
3834 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3836 * src/maemo/modest-msg-edit-window.c:
3837 (modest_msg_edit_window_select_color),
3838 (modest_msg_edit_window_select_background_color): 2 const corrections and
3839 moving 2 #endifs before closing brackets, to fix the build.
3841 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/easysetup/modest-easysetup-wizard.h:
3844 * src/maemo/easysetup/modest-easysetup-wizard.c:
3845 (modest_easysetup_wizard_dialog_finalize),
3846 (on_button_edit_advanced_settings), (create_page_complete_custom),
3847 (on_response), (create_account):
3848 Implement the Advanced Settings edit button, by saving the account information,
3849 for the Advanded Settings dialog to use directly from gconf, and removing it
3850 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3851 Bug #5533 in the projects.maemo.org bugzilla.
3853 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3855 * src/maemo/modest-msg-view-window.c:
3856 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3857 when opening a message window.
3859 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3861 * src/maemo/easysetup/modest-easysetup-wizard.c:
3862 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3865 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3866 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3867 gconf settings. I probably added more checks than necessary, but that is safer.
3869 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3870 variable to fix the build, but this seems to be used when it is still NULL.
3872 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3874 * src/modest-platform.h:
3875 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3876 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3877 * src/modest-main.c: Implement this function so we can avoid using
3878 maemo-specific API from cross-platform code.
3880 * src/modest-tny-account-store.c:
3881 (get_smtp_specific_transport_account_for_open_connection):
3882 * src/modest-ui-actions.c: (check_for_connection),
3883 (modest_ui_actions_on_item_not_found):
3884 Use modest_platform_connect_and_wait() and put #idefs around other
3885 maemo-specific code, because only maemo currently has a way to
3886 identify connection names.
3888 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3890 * src/modest-tny-account-store.h:
3891 * src/modest-tny-account-store.c:
3892 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3893 the connection-specific SMTP server settings in the configuration.
3895 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3897 * src/maemo/modest-main-window.c: (on_connection_changed),
3899 * src/modest-main.c: (main), (start_ui), (send_mail):
3900 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3901 that is what is intended.
3903 * src/modest-ui-actions.c: (action_send), (action_receive),
3904 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3905 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3906 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3907 SMTP server is used when it is specified.
3909 (modest_ui_actions_on_send_receive):
3910 Check that a connection is open before proceeding.
3911 Receive and then send, instead of vice-versa, as per the specification.
3913 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3915 * src/modest-mail-operation.c:
3916 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3917 though I guess it should be something other than NULL.
3919 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3921 * src/maemo/easysetup/modest-easysetup-wizard.c:
3922 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3923 combo twice, to avoid an g_warning and to make it visible again.
3924 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3925 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3926 (already intended) dereference when detaching, because we then recreate the menu.
3927 But I am not sure why the warning was happening, and it is possible that this is a memory
3930 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3932 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3933 and uri_parse_mailto() utility functions.
3934 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3936 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3938 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3940 * src/dbus_api/modest-dbus-api.h:
3941 * src/dbus_api/modest-dbus-callbacks.c:
3942 Use an idle callback to execute the modest code in the application's own thread.
3943 Remove the helloworld example method.
3944 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3945 parsed, and the open-message method is not implemented because this is not yet implemented in
3947 * libmodest-dbus-client/libmodest-dbus-client.c:
3948 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3949 (libmodest_dbus_client_open_message):
3950 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3952 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3953 body without crashing.
3955 * tests/dbus_api/Makefile.am:
3956 * tests/dbus_api/test_mail_to.c:
3957 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3959 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3961 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3962 Added file to fix the build. Sorry.
3964 * src/dbus_api/Makefile.am:
3965 * src/dbus_api/modest-dbus-api.h:
3966 * src/dbus_api/modest-dbus-callbacks.h:
3967 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3968 (modest_dbus_req_handler):
3969 Put constants in a separate header so it can be reused by the
3970 client library, without duplication
3972 * libmodest-dbus-client/Makefile.am:
3973 * libmodest-dbus-client/libmodest-dbus-client.c:
3974 (libmodest_dbus_client_call_helloworld),
3975 (libmodfest_dbus_client_send_mail),
3976 (libmodfest_dbus_client_mailto),
3977 (libmodfest_dbus_client_open_message):
3978 * libmodest-dbus-client/libmodest-dbus-client.h:
3979 (Partly) Implement a send_mail D-Bus method.
3981 * tests/dbus_api/Makefile.am:
3982 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3983 the send_email D-Bus method.
3985 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3989 * libmodest-dbus-client/Makefile.am:
3990 * libmodest-dbus-client/libmodest-dbus-client.c:
3991 * libmodest-dbus-client/libmodest-dbus-client.h:
3992 * tests/dbus_api/Makefile.am:
3993 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3994 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3996 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3998 * src/maemo/easysetup/modest-easysetup-wizard.c:
3999 (create_page_account_details):
4000 * src/maemo/modest-account-settings-dialog.c:
4001 (create_page_account_details): Explicitly set auto-capitalization mode for the title
4002 widgets, because this might not be the default in future versions of the Maemo GTK+.
4003 However, I can not not get capitalization to work even in a simple test case.
4005 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4007 * src/maemo/easysetup/modest-easysetup-wizard.c:
4008 (create_page_custom_incoming), (create_page_custom_outgoing):
4009 * src/maemo/modest-account-settings-dialog.c:
4010 (create_page_account_details), (create_page_incoming),
4011 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
4012 instead of using gtk_check_button_with_label(), so they are aligned like the other
4013 widgets, as per the UI spec.
4015 2007-04-24 Murray Cumming <murrayc@murrayc.com>
4017 * src/maemo/easysetup/modest-easysetup-wizard.c:
4018 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4019 * src/widgets/modest-validating-entry.c:
4020 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
4021 Modest prefix instead of an EasySetup prefix.
4023 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4025 * src/widgets/modest-validating-entry.h:
4026 * src/widgets/modest-validating-entry.c: (on_insert_text),
4027 Added easysetup_validating_entry_set_max_func(), used to set a callback
4028 to call when the max number of characters is reached. GtkEntry has a max-length
4029 already but is silent about it.
4031 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4032 (create_page_account_details), (create_page_user_details),
4034 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4035 (create_page_account_details), (create_page_user_details),
4036 (create_page_outgoing):
4037 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4038 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4039 the UI spec, when the user tries to enter more than the max number of characters.
4041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4043 * src/maemo/easysetup/modest-easysetup-wizard.c:
4044 (create_page_user_details), (create_page_custom_incoming),
4045 (create_page_custom_outgoing):
4046 * src/maemo/modest-account-settings-dialog.c:
4047 (create_page_user_details), (create_page_incoming),
4048 (create_page_outgoing):
4049 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4050 (modest_connection_specific_smtp_edit_window_init):
4051 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4052 not appropriate. Bad Maemo-specific defaults!.
4054 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4056 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4057 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4058 (modest_signature_editor_dialog_set_settings):
4059 Disable the label and textview when the checkbox is disabled, and use the
4060 specified (UI spec) default signature text.
4062 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4064 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4065 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4067 * src/modest-defs.h:
4068 * src/modest-account-mgr-helpers.h:
4069 * src/modest-account-mgr-helpers.c:
4070 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4072 * src/maemo/Makefile.am:
4073 * src/maemo/modest-signature-editor-dialog.c:
4074 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4077 * src/maemo/modest-account-settings-dialog.h:
4078 * src/maemo/modest-account-settings-dialog.c:
4079 (modest_account_settings_dialog_finalize), (on_button_signature),
4080 (save_configuration): Use the new dialog when the Edit button is pressed, and
4081 save the changes if necessary, as per the UI spec.
4083 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4085 * src/maemo/Makefile.am:
4086 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4087 based on maemo-develoers email from Dirk.
4089 * src/maemo/easysetup/modest-easysetup-wizard.c:
4090 (create_page_welcome), (create_page_account_details),
4091 (create_page_user_details), (create_page_complete_easysetup),
4092 (create_page_custom_incoming), (create_page_custom_outgoing),
4093 (create_page_complete_custom),
4094 (modest_easysetup_wizard_dialog_init):
4095 * src/maemo/modest-account-settings-dialog.c:
4096 (create_page_account_details), (create_page_user_details),
4097 (create_page_incoming), (create_page_outgoing),
4098 (modest_account_settings_dialog_init):
4099 * src/maemo/modest-connection-specific-smtp-window.c:
4100 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4102 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4104 * src/maemo/easysetup/modest-easysetup-wizard.c:
4105 (create_page_account_details), (create_page_custom_outgoing),
4106 (create_page_complete_custom):
4107 * src/maemo/modest-account-settings-dialog.c:
4108 (create_page_user_details), (create_page_incoming),
4109 (create_page_outgoing):
4110 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4111 (modest_connection_specific_smtp_edit_window_init):
4112 Use the correct (UI spec) port min/max, and use horizontal separators,
4115 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4117 * src/maemo/easysetup/modest-easysetup-wizard.c:
4118 (set_default_custom_servernames):
4119 * src/maemo/modest-account-settings-dialog.c:
4120 (create_page_incoming), (on_combo_outgoing_security_changed),
4121 (on_combo_incoming_security_changed), (create_page_outgoing),
4122 (modest_account_settings_dialog_set_account_name),
4123 (save_configuration):
4124 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4125 (on_combo_security_changed),
4126 (modest_connection_specific_smtp_edit_window_init),
4127 (modest_connection_specific_smtp_edit_window_set_connection),
4128 (modest_connection_specific_smtp_edit_window_get_settings):
4129 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4132 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4135 * src/maemo/easysetup/modest-easysetup-wizard.c:
4136 (create_page_custom_outgoing), (create_page_complete_custom):
4137 * src/maemo/modest-account-settings-dialog.c:
4138 (create_page_user_details), (create_page_outgoing):
4139 * src/maemo/modest-account-view-window.c: (button_box_new):
4140 Use changed logical IDs as per the most recent UI spec:
4141 mcen_bd_emailsetup_edit -> mcen_bd_edit
4142 mcen_bd_emailsetup_delete -> mcen_bd_delete
4143 mcen_bd_emailsetup_close -> mcen_bd_close
4145 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4149 * src/dbus_api/Makefile.am:
4150 * src/dbus_api/modest-dbus-callbacks.c:
4151 * src/dbus_api/modest-dbus-callbacks.h:
4152 * src/maemo/modest-platform.c: (modest_platform_init):
4153 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4155 * tests/Makefile.am:
4156 * tests/dbus_api/Makefile.am:
4157 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4159 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4161 * src/maemo/modest-account-settings-dialog.c:
4162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4163 Removed unnecessary includes.
4165 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4167 * src/maemo/easysetup/modest-easysetup-wizard.c:
4168 * src/maemo/modest-account-settings-dialog.c:
4169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4170 * src/widgets/Makefile.am:
4171 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4172 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4173 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4174 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4175 * src/widgets/modest-secureauth-combo-box.c:
4176 * src/widgets/modest-secureauth-combo-box.h:
4177 * src/widgets/modest-serversecurity-combo-box.c:
4178 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4179 made the GObject names more consistent with the rest of the Modest code.
4181 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4183 * src/maemo/easysetup/Makefile.am:
4184 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4185 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4186 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4187 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4188 * src/maemo/easysetup/modest-easysetup-wizard.c:
4189 * src/maemo/easysetup/modest-validating-entry.c:
4190 * src/maemo/easysetup/modest-validating-entry.h:
4191 * src/maemo/modest-account-settings-dialog.c:
4192 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4193 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4194 widgets/ because they are used outside of easysetup too. After checking in,
4195 svn will allow me to rename them too.
4197 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4199 * src/gnome/modest-msg-edit-window.c:
4200 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4201 linker error, to fix the build on the GNOME platform.
4202 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4203 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4204 ifdefed out to avoid a warning.
4206 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4208 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4209 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4210 some alternative for GTK+ 2.6.
4212 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4214 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4216 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4217 specified for EmailAccountsDialog in UI spec.
4219 * src/maemo/easysetup/modest-easysetup-wizard.c:
4220 * src/maemo/easysetup/modest-easysetup-wizard.h:
4221 * src/maemo/modest-account-settings-dialog.c:
4222 * src/maemo/modest-account-settings-dialog.h:
4223 Reuse a member window widget for the connection-specific SMTP server accounts,
4224 so we can tell it to create/save the accounts only if we actually save changes.
4226 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4227 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4228 (modest_connection_specific_smtp_edit_window_get_settings):
4229 Return a struct instance for temporarily remembering the entered data.
4231 * src/maemo/modest-connection-specific-smtp-window.h:
4232 * src/maemo/modest-connection-specific-smtp-window.c:
4233 (modest_connection_specific_smtp_window_finalize),
4234 (modest_connection_specific_smtp_window_fill_with_connections),
4236 (modest_connection_specific_smtp_window_save_server_accounts),
4237 (update_model_server_names): Do not actually save data until asked,
4238 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4240 (on_selection_changed),
4241 (modest_connection_specific_smtp_window_init): Disable the edit
4242 button when nothing is selected.
4244 * src/modest-account-mgr-helpers.c:
4245 * src/modest-account-mgr-helpers.h:
4246 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4249 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4251 * src/modest-account-mgr-helpers.h:
4252 * src/modest-account-mgr-helpers.c:
4253 (modest_account_mgr_get_unused_account_name),
4254 (modest_account_mgr_get_unused_account_display_name): Added these
4255 utility functions, to avoid code duplication.
4257 * src/maemo/easysetup/modest-easysetup-wizard.c:
4258 (create_page_account_details), (create_account):
4259 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4260 (on_combo_security_changed),
4261 (modest_connection_specific_smtp_edit_window_init),
4262 (modest_connection_specific_smtp_edit_window_save_settings):
4263 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4264 * src/maemo/modest-connection-specific-smtp-window.c:
4265 (modest_connection_specific_smtp_window_finalize),
4266 (modest_connection_specific_smtp_window_fill_with_connections),
4267 (on_button_edit), (modest_connection_specific_smtp_window_init):
4268 * src/maemo/modest-connection-specific-smtp-window.h:
4269 Implementing saving of connection-specific server accounts.
4271 But I need to refactor this so we can save the data for each
4272 possible connection-specific account and only actually create the server accounts
4273 when the easysetup finished, or the OK button is pressed on the account settings
4276 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4278 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4279 (on_combo_security_changed):
4280 (modest_connection_specific_smtp_edit_window_init):
4281 Auto-fill the port number as in the account settings.
4283 (modest_connection_specific_smtp_edit_window_set_connection):
4284 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4285 * src/maemo/modest-connection-specific-smtp-window.c:
4286 (fill_with_connections), (on_button_edit),
4287 (modest_connection_specific_smtp_window_init):
4288 Turn the edit window into a dialog to simplify the code, and
4289 set a WM hint as in a GtkDialog, because only a popup can be on top of
4290 another window in Maemo, and popups usually have no WM decoration.
4292 * src/modest-defs.h:
4293 * src/modest-account-mgr-helpers.c:
4294 (modest_account_mgr_set_connection_specific_smtp),
4295 (modest_account_mgr_remove_connection_specific_smtp),
4296 (modest_account_mgr_get_connection_specific_smtp):
4297 * src/modest-account-mgr-helpers.h: Some functions to write the
4298 connection-specific SMTP server information. Not yet used.
4301 * src/widgets/modest-folder-view.c: (text_cell_data):
4302 Fix a warning about an uninitialized variable.
4303 (on_configuration_key_changed): Put an #ifdef around the use
4304 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4306 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4308 * src/maemo/modest-account-settings-dialog.h:
4309 * src/maemo/modest-account-settings-dialog.c:
4310 Added connect_for_modified() utility function to mark the new modified boolean.
4312 (create_page_account_details), (create_page_user_details),
4313 (create_page_incoming), (create_page_outgoing), (on_response),
4314 (modest_account_settings_dialog_init),
4315 (modest_account_settings_dialog_set_account_name):
4316 Only warn about unsaved changes when there are actually unsaved changes.
4318 * src/modest-account-mgr-helpers.c:
4319 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4320 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4321 to get the data from there in future.
4323 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4325 * src/modest-defs.h:
4327 * src/modest-account-mgr-helpers.h:
4328 * src/modest-account-mgr-helpers.c:
4329 Store the security account setting in a single conf key instead of using
4330 the options list, so that the list is left for just the to-be-removed camel hack,
4331 and because gconf_client_set_list() is failing for some reason.
4333 * src/modest-account-mgr.c:
4334 (modest_account_mgr_add_server_account):
4335 * src/maemo/modest-account-settings-dialog.c:
4336 (modest_account_settings_dialog_set_account_name),
4337 (save_configuration): Use the renamed functions.
4340 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4342 * src/widgets/Makefile.am:
4343 * src/widgets/modest-limit-retrieve-combo-box.c:
4344 * src/widgets/modest-limit-retrieve-combo-box.h:
4345 * src/widgets/modest-retrieve-combo-box.c:
4346 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4347 the account settings dialog.
4349 * src/modest-defs.h:
4350 * src/modest-account-mgr-helpers.h:
4351 * src/modest-account-mgr-helpers.c:
4352 (modest_server_account_get_option_secure_auth),
4353 (modest_server_account_set_option_secure_auth):
4354 * src/modest-account-mgr.c:
4355 (modest_account_mgr_add_server_account):
4356 Use the existing AUTH_MECH conf key for the secure-auth setting,
4357 instead of putting it in the list options, because this was actually used already.
4359 * src/maemo/modest-account-settings-dialog.c:
4360 (create_page_account_details),
4361 (modest_account_settings_dialog_set_account_name),
4362 (save_configuration):
4363 * src/maemo/modest-account-settings-dialog.h:
4364 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4365 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4367 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4369 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4370 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4371 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4373 * src/modest-defs.h:
4374 * src/maemo/modest-account-settings-dialog.c:
4375 (create_page_incoming), (on_combo_outgoing_security_changed),
4376 (on_combo_incoming_security_changed), (create_page_outgoing),
4377 (modest_account_settings_dialog_set_account_name),
4378 (save_configuration): Load/Save the port number, and change it when the
4379 security combo changes, to suitable defaults.
4381 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4383 * src/modest-account-mgr.c:
4384 (modest_account_mgr_add_server_account): Set the security and secure-auth
4385 options, and add a comment saying that the other camel-specific options should be
4388 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4390 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4392 * src/modest-tny-account-store.c: (account_list_free),
4393 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4394 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4397 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4399 * src/modest-protocol-info.c:
4400 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4401 is required by our UI spec. Maybe something in our implementation will use this eventually.
4402 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4403 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4404 instead of the previous 0 placeholder.
4406 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4407 secure-auth settings.
4408 * src/modest-account-mgr-helpers.h:
4409 * src/modest-account-mgr-helpers.c:
4410 (modest_server_account_data_get_option_secure_auth),
4411 (modest_server_account_set_option_secure_auth),
4412 (modest_server_account_data_get_option_security),
4413 (modest_server_account_set_option_security): Added this API for getting and setting the security
4414 and secure-auth settings.
4416 * src/maemo/modest-account-settings-dialog.h:
4417 * src/maemo/modest-account-settings-dialog.c:
4418 (modest_account_settings_dialog_finalize), (check_data),
4419 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4420 about changing titles.
4421 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4422 (save_configuration): Save the security and secure-auth settings.
4424 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4425 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4427 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4429 * src/modest-defs.h:
4430 * src/modest-account-mgr.c:
4431 (modest_account_mgr_add_server_account):
4432 Added and used defines for the options key and value pair strings,
4433 that are used so far, though they do not seem to correspond to anything in our
4434 UI specs or ModestProtocol enum.
4436 * src/modest-account-mgr-helpers.h:
4437 * src/modest-account-mgr-helpers.c:
4438 (compare_option_strings_for_name),
4439 (modest_server_account_data_get_option_value),
4440 (modest_server_account_data_get_option_bool),
4441 (modest_account_mgr_get_server_account_option):
4442 Added helper functions for parsing the options GSList.
4444 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4446 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4447 display name is based on the supplied account name.
4448 * src/modest-account-mgr.c:
4449 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4450 with an inefficient, but good-enough, implementation.
4452 * src/maemo/easysetup/modest-easysetup-wizard.c:
4453 (create_page_account_details), (on_before_next), (create_account):
4454 Check for existing display names rather than (non-user-visible) account names, and just
4455 create and set a unique account name at the end.
4457 * src/maemo/modest-account-settings-dialog.c:
4458 (modest_account_settings_dialog_init),
4459 (modest_account_settings_dialog_set_account_name),
4460 (create_page_incoming): Show the display name, instead of the account name.
4461 (on_response): Do some (not all) extra checks, as in the UI spec.
4462 (save_configuration): Save the display name if it was changed.
4464 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4466 * po/en_GB.po: Added needed logical ID and translation.
4467 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4468 (init_view): Made the is-default column clicking work.
4470 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4473 * src/maemo/easysetup/Makefile.am:
4474 * src/maemo/easysetup/modest-easysetup-wizard.c:
4475 (modest_easysetup_wizard_dialog_init):
4476 * src/maemo/easysetup/provider-data-test.keyfile:
4477 * src/maemo/easysetup/provider-data.keyfile:
4478 Moved the provider data file to the new modest-providers-data package and used it from there.
4480 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4482 * src/modest-local-folder-info.c:
4483 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4484 N_() was already used on the static strings, but this just marks it for translation without
4485 using the translation.
4487 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4489 * src/maemo/modest-account-settings-dialog.c:
4490 (create_page_incoming),
4491 (modest_account_settings_dialog_set_account_name):
4492 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4493 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4494 I will do this if nobody else gets there first.
4496 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4498 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4499 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4500 save the security stuff.
4502 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4504 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4505 Set the email address and user fullname, which I now see must be
4508 * src/maemo/modest-account-settings-dialog.h:
4509 * src/maemo/modest-account-settings-dialog.c:
4511 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4512 leave-on-server and authentication.
4513 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4516 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4519 * src/maemo/modest-account-settings-dialog.c:
4520 * src/maemo/modest-account-settings-dialog.h:
4521 Most (but not all) of the widgets are now present as specified by the UI spec.
4522 No changes are yet saved, and some details are not properly shown yet.
4524 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4526 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4528 * src/maemo/Makefile.am:
4529 * src/maemo/modest-account-settings-dialog.c:
4530 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4531 an existing account. Doesn't do much yet.
4533 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4534 Open the accounts settings dialog when Edit is clicked.
4536 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4538 * src/maemo/easysetup/Makefile.am:
4539 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4541 * src/maemo/easysetup/modest-easysetup-wizard.c:
4542 (modest_easysetup_wizard_dialog_init):
4543 Try to get the source directory from the build system,
4544 instead of hard-coding "./" into the source code, when opening our local
4545 copies of the configuration files.
4546 But this still fails when opening the wizard from the Accounts window,
4547 maybe because the working directory seems to change at runtime.
4548 So the wizard will fail the second time unless you copy the files into their
4549 proper locations - see the stdout warnings for the paths.
4551 (create_page_account_details),(on_before_next):
4552 Check for existing non-server accounts instead of server accounts,
4553 so the default account name is useful again, and to prevent trying to
4556 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4557 Show the wizard when New is clicked.
4559 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4560 (init_view): Show the column headers, and show the columns that are
4561 specified in the UI specs. However, something in Maemo's GTK+ prevents
4562 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4563 change the default account. This is despite unsetting the special properties.
4565 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4567 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4568 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4569 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4570 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4571 to make that clearer.
4572 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4574 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4576 * src/maemo/modest-account-view-window.c:
4577 (modest_account_view_window_init),
4578 (modest_account_view_window_new):
4579 Use the same buttons as specified in the
4580 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4581 the existing widgets, which never had a chance of working.
4582 Put the ModestAccountView treeview in a scrolled window.
4583 Do not repeat the initialization in both _init() and _new().
4585 * src/widgets/modest-account-view.c: (update_account_view):
4586 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4587 this widget and window shows no accounts.
4589 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4591 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4593 * src/maemo/easysetup/modest-easysetup-wizard.c:
4594 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4595 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4596 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4599 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4600 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4601 accounts exist yet, as in the UI spec.
4603 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4605 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4607 * src/maemo/Makefile.am:
4608 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4609 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4610 New window for editing connection-specific smtp details.
4611 Not fully implemented.
4613 * src/maemo/modest-connection-specific-smtp-window.c:
4614 (modest_connection_specific_smtp_window_finalize) :
4615 unref the tree model.
4616 (on_button_edit): Show the edit window.
4618 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4620 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4623 * src/maemo/Makefile.am:
4624 * src/maemo/modest-connection-specific-smtp-window.c:
4625 * src/maemo/modest-connection-specific-smtp-window.h:
4626 New window for showing the list of connections, for connection-specific
4627 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4628 * src/maemo/easysetup/modest-easysetup-wizard.c:
4629 (create_page_custom_outgoing): Show the new window when the button is clicked.
4631 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4633 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4634 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4635 * src/maemo/modest-msg-edit-window.c:
4636 (modest_msg_edit_window_insert_image):
4637 * src/modest-conf.c: (modest_conf_key_escape):
4638 * src/modest-mail-operation.c:
4639 (modest_mail_operation_send_new_mail):
4640 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4641 (modest_ui_actions_on_new_account):
4642 * src/widgets/modest-attachment-view.c: (update_filename_request):
4643 * src/widgets/modest-mail-header-view.c:
4644 Corrected warnings that were breaking the build, by commenting out unused variables,
4645 and a function, and by including a header.
4647 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4649 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4650 so we can #ifdef around platform-specific code when necessary.
4651 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4652 to allow this to build for the GNOME platform too.
4654 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4656 * src/maemo/easysetup/modest-easysetup-wizard.c:
4657 Added util_increment_name() and used it in create_page_account_details()
4658 to make sure that the default account name is always a new name.
4660 (modest_easysetup_wizard_dialog_init),
4661 (set_default_custom_servernames): Some minor memory management fixes.
4663 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4667 * src/modest-runtime.c: (init_i18n): Restored the translation
4668 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4669 are defined in config.h, and the translations are installed.
4671 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4672 is defined for translation.
4674 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4676 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4678 * src/maemo/easysetup/modest-easysetup-wizard.c:
4679 (modest_easysetup_wizard_dialog_init):
4680 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4681 Use realistic paths (though they should use $prefix generically) to the
4682 mcc_mapping and provider-data.keyfile files which might work when they
4683 are installed by the future version of the operator-wizard package,
4684 and then fallback to paths in our source code, with an explanatory
4687 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4691 * src/maemo/Makefile.am:
4692 * src/maemo/easysetup/: Added files from the previously-exernal
4693 osso-modest-easysetup.
4694 * src/maemo/modest-main-window-ui.h:
4695 * src/modest-ui-actions.c:
4696 * src/modest-ui-actions.h:
4697 Added modest_ui_actions_on_new_account() as a signal handler for the
4698 New Account menu item. It shows the easysetup wizard.
4699 * po/en_GB.po: Added additional needed logical IDs and translations.