1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-global-settings-dialog.c:
4 (idle_select_default_focus):
5 * src/modest-mail-operation.c: (idle_notify_progress),
6 (idle_notify_progress_once), (idle_notify_update_account_queue),
7 (set_last_updated_idle), (update_account_thread),
8 (notify_get_msgs_full), (get_msgs_full_destroyer),
9 (get_msgs_full_thread):
10 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
11 * src/widgets/modest-header-view.c:
12 (idle_notify_headers_count_changed_destroy),
13 (idle_notify_headers_count_changed):
14 Use gdk_threads_enter() and gdk_threads_enter_leave() in
15 all idle handlers, because some other thread could be blocking
16 the GDK lock, so that it can do GUI stuff.
18 2007-06-26 Murray Cumming <murrayc@murrayc.com>
20 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
21 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
22 (on_idle_send_receive), (on_idle_open_default_inbox):
23 * src/maemo/modest-msg-edit-window.c:
24 (modest_msg_edit_window_attach_file_noninteractive):
25 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
26 to prevent a hang. I don't quite understand why these are necessary,
27 beause we should already be in the main loop. I guess something outside
28 of the main loop is taking the lock.
30 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
31 we are really using URIs, and use files that are more likely to exist.
33 2007-06-26 Murray Cumming <murrayc@murrayc.com>
35 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
36 necessary because configure.ac now defines different variables.
38 2007-06-26 Murray Cumming <murrayc@murrayc.com>
40 * libmodest-dbus-client/libmodest-dbus-client.c:
41 * libmodest-dbus-client/libmodest-dbus-client.h:
42 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
43 libmodest_dbus_client_compose_mail() is what things actually use.
45 * src/dbus_api/modest-dbus-api.h:
46 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
47 * tests/dbus_api/Makefile.am:
48 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
51 2007-06-26 Murray Cumming <murrayc@murrayc.com>
53 * src/modest-init.c: (modest_init_local_folders):
54 For memory-card (or other non local-folders) maildir accounts,
55 always create an Archive folder, so that there is somewhere to put
56 messages. This should be less confusing, because the user does not need
57 to guess that the need to create a folder.
59 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
61 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
62 Fixed icon size by using (50, 50) which is the same as defined by
65 2007-06-25 Armin Burgmeier <armin@openismus.com>
67 * src/widgets/modest-window-mgr.c:
69 * configure.ac: Correctly recognize hildon-notify presence and fixed
70 the build without it being installed.
72 2007-06-25 Murray Cumming <murrayc@murrayc.com>
74 * libmodest-dbus-client/libmodest-dbus-client.c:
75 (libmodest_dbus_client_search): Fix the build. Sorry.
76 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
77 (reply_forward_cb): Initialize variables to fix the build.
79 * src/modest-tny-account-store.c:
80 (modest_tny_account_store_get_tny_account_by): Fix the account URI
81 comparison (a silly typo) so that email search results can be opened
82 when there are more than one account.
84 2007-06-25 Murray Cumming <murrayc@murrayc.com>
86 * libmodest-dbus-client/libmodest-dbus-client.c:
87 (libmodest_dbus_client_search),
88 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
89 instead of 1 second, because the search gets folders and messages from
90 the server, which can take a long time. When it times out,
91 osso-global-search will report no results.
93 We need to specify whether we should search only cached information
94 (maybe with a user preference), and the osso-email-search-plugin
95 API should really be improved to allow that option, and to allow results
96 to be delivered asynchronously in batches.
98 2007-06-25 Murray Cumming <murrayc@murrayc.com>
100 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
101 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
102 GTK_ICON_SIZE_DIALOG is probably the wrong size.
104 2007-06-25 Murray Cumming <murrayc@murrayc.com>
106 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
107 that is an empty string. D-Bus seems to give us these instead of NULL.
109 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
111 * src/dbus_api/modest-dbus-callbacks.c:
112 * src/maemo/easysetup/modest-easysetup-wizard.h:
113 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
114 * src/maemo/modest-connection-specific-smtp-edit-window.c:
115 (modest_connection_specific_smtp_edit_window_init):
116 * src/maemo/modest-maemo-global-settings-dialog.c:
118 * src/maemo/modest-maemo-utils.c:
119 (modest_maemo_utils_setup_images_filechooser):
120 * src/maemo/modest-main-window.c: (create_details_widget):
121 * src/maemo/modest-msg-edit-window.c:
122 (modest_msg_edit_window_attach_file_noninteractive),
123 (modest_msg_edit_window_color_button_change),
124 (modest_msg_edit_window_set_zoom):
125 * src/modest-mail-operation.c: (update_account_thread):
126 * src/modest-tny-account-store.c:
127 * src/modest-tny-account.c:
128 * src/widgets/modest-global-settings-dialog.c:
129 * src/widgets/modest-window.h:
133 2007-06-25 Murray Cumming <murrayc@murrayc.com>
135 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
136 * src/modest-search.c: (modest_search_folder),
137 (modest_search_all_accounts): Actually search only in the specified folder,
138 doing a simple match on the folder ID.
139 * src/modest-search.h: Added a folder field to the ModestSearch struct,
140 and added some documentation.
142 2007-06-22 Armin Burgmeier <armin@openismus.com>
144 * src/maemo/modest-maemo-utils.h:
145 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
146 modest_maemo_utils_get_supported_secure_authentication_methods.
148 * src/maemo/easysetup/modest-easysetup-wizard.c:
149 * src/maemo/modest-account-settings-dialog.c: Show correct error if
150 one occured, not just "Server does not support secure authentication".
152 2007-06-22 Murray Cumming <murrayc@murrayc.com>
154 * src/modest-tny-account-store.c: (get_password):
155 Restored the call to tny_account_set_user() because Philip seems to have
156 stopped this from crashing (by not using the freed string). It still does
157 not work, but now we can test it.
159 2007-06-22 Murray Cumming <murrayc@murrayc.com>
161 * src/maemo/modest-msg-edit-window.c: (init_window):
162 Comment out use of an uninitialzed GtkScrolledWindow variable,
163 to fix the build and stop a crash. Yet again.
165 2007-06-22 Murray Cumming <murrayc@murrayc.com>
167 * src/modest-tny-account-store.c: (get_password):
168 Remove the call to tny_account_set_user() because this actually crashes.
169 As mentioned in the last commit, it is known to not work anyway.
171 2007-06-22 Murray Cumming <murrayc@murrayc.com>
173 * src/modest-tny-account-store.c: (get_password):
174 Use tny_account_set_username() to tell tinymail that the username might
175 have changed too. But tinymail ignores this: see projects.maemo.org
177 * src/modest-ui-actions.c:
178 (modest_ui_actions_on_password_requested): Remove the useless attempt to
179 reset the connection when changing the username, and improve the comments.
180 Save the changed username to gconf at least, so it is used when Modest is
183 2007-06-21 Murray Cumming <murrayc@murrayc.com>
185 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
186 Do not use a query, so that we get all folders, including for POP and
187 local-folders. They work as search criteria too.
188 This fixes projects.maemo.org bug NB#57740.
190 2007-06-21 Murray Cumming <murrayc@murrayc.com>
192 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
193 Comment out the use of hildon_notification_set_sound() because it is
194 not declared, to fix the build. Warnings are serious, people.
196 2007-06-21 Armin Burgmeier <armin@openismus.com>
198 * src/maemo/modest-maemo-utils.h:
199 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
200 modest_maemo_utils_get_supported_secure_authentication_methods()
201 to query authentication methods for a specific user. This should fix
202 projects.maemo.org bug NB#61369.
204 * src/maemo/easysetup/modest-easysetup-wizard.c:
205 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
208 2007-06-21 Murray Cumming <murrayc@murrayc.com>
210 * libmodest-dbus-client/libmodest-dbus-client.h:
211 * libmodest-dbus-client/libmodest-dbus-client.c:
212 (modest_dbus_message_iter_get_search_hit),
213 (libmodest_dbus_client_search):
214 Reorganised and commented this.
215 Removed modest_search_hit_free() from the public API because it
218 Added libmodest_dbus_client_get_folders() and
219 modest_folder_result_list_free().
221 * src/dbus_api/modest-dbus-api.h:
222 * src/dbus_api/modest-dbus-callbacks.c:
223 (modest_dbus_req_filter): Commented. Moved most code to
224 on_dbus_method_search() and added on_dbus_method_get_folders().
226 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
227 of the extra D-Bus handler.
229 * tests/dbus_api/Makefile.am:
230 * tests/dbus_api/test_get_folders.c: New test for
231 libmodest_dbus_client_get_folders(). This seems to return an empty list
232 at the moment. That could be the same error that causes the message list
233 to be empty sometimes.
234 This should help with projects.maemo.org bug NB#57740.
236 2007-06-21 Armin Burgmeier <armin@openismus.com>
238 * src/modest-mail-operation.c: Do not call
239 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
240 notify the operation's end after having set the status to CANCELED for
241 the operation queue to listen on. This fixes a deadlock when there
242 were mail operations in the queue during its finalization.
244 * src/modest-singletons.c: Reordered uninitialization of the account
245 manager to happen after the mail operation queue was uninitialized
246 because the mail operation's in the queue might still try to access
247 the account manager (see modest_mail_operation_notify_end()). This
248 fixes a potential crash when terminating the application.
250 2007-06-21 Murray Cumming <murrayc@murrayc.com>
252 * src/modest-search.c:
253 (search_mime_part_and_child_parts): Moved some code here so we
254 can search recursively in child folders.
255 (modest_search_folder): Search in the message as a mime part, instead
256 of just its child mime parts.
257 (read_chunk), (search_mime_part_ogs):
258 Check how many bytes were read, to prevent an endless loop.
259 Searching in message bodies now works. This finishes the fix for
260 projects.maemo.org bug NB#61007.
262 2007-06-20 Murray Cumming <murrayc@murrayc.com>
264 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
265 Add a g_warning when the item is not a folder.
267 * src/modest-ui-dimming-rules.c:
268 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
269 when selected item is not a folder (for instance, an account), because
270 the UI spec only talks about folders.
271 I am not sure what the UI spec wants, so this might not totally fix
272 projects.maemo.org bug NB#60794.
274 2007-06-20 Murray Cumming <murrayc@murrayc.com>
276 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
277 (load_from_file): Sort the list. The unsorted list would be more noticeable
278 in non-English locales.
280 * src/maemo/modest-msg-edit-window.c:
281 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
282 warning and fix the build.
284 * src/maemo/modest-progress-bar-widget.c:
285 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
286 avoid a g_warning, and probably to avoid a crash.
288 2007-06-20 Murray Cumming <murrayc@murrayc.com>
290 * src/modest-search.c: (modest_search_folder): Check for a GError
291 when calling tny_folder_get_headers(), to show that this is not the cause
294 2007-06-20 Murray Cumming <murrayc@murrayc.com>
296 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
297 Actually set the body query instead of the subject query.
299 * src/modest-search.c: (search_mime_part_ogs),
300 (search_mime_part_strcmp): Remove extra space from the text/* regex,
301 which would probably cause it to fail if we got this far.
303 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
304 to simplify the code.
305 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
306 be causing search-in-body to fail.
308 2007-06-20 Murray Cumming <murrayc@murrayc.com>
310 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
312 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
313 Better debug message when the folder cannot be found.
314 This should help with fixing projects.maemo.org bug #61287.
315 * src/modest-search.c: (add_hit): Do not leak the furl string.
317 2007-06-20 Murray Cumming <murrayc@murrayc.com>
319 * src/modest-ui-actions.c:
320 (modest_ui_actions_on_folder_selection_changed):
321 Do not special-case TNY_MERGE_FOLDER here, because
322 modest_tny_folder_get_account() already does that. This fixes
323 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
324 shown when the Outbox was selected).
326 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
328 * libmodest-dbus-client/libmodest-dbus-client.c:
329 (_dbus_iter_get_string_or_null): Initialize the string variable in
330 case this helps with Dirk's crash.
332 2007-06-19 Murray Cumming <murrayc@murrayc.com>
334 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
335 though it is not implemented yet (this function is maybe not even used),
336 to avoid breaking ABI in future.
337 * libmodest-dbus-client/libmodest-dbus-client.c:
338 (get_attachments_string): Moved some code into this generic function.
339 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
340 sends email. It is maybe not used.
341 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
342 (on_send_mail): Use attachments.
344 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
345 * src/maemo/modest-msg-edit-window.c:
346 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
347 a filename before using it, to fix projects.maemo.org bug NB#58233.
349 2007-06-19 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
352 Initialize the continue_download variable to fix the build, and probably
353 to fix randome behaviour.
355 2007-06-18 Armin Burgmeier <armin@openismus.com>
357 * src/modest-tny-send-queue.h:
358 * src/modest-tny-send-queue.c: Keep track of the status of messages in
359 the queue so we can later show it in the UI. Replaced
360 modest_tny_send_queue_msg_is_being_sent() by
361 modest_tny_send_queue_get_msg_status().
363 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
365 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
366 gpointer. This probably was not harmful, but just to be sure.
368 2007-06-18 Murray Cumming <murrayc@murrayc.com>
370 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
371 Fix the build, but leave the function broken on Bora, because
372 hildon_uri_action_get_service() does not exist.
373 osso_uri_action_get_service() does not exist either, it seems.
375 2007-06-18 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account.c:
378 (modest_tny_account_new_from_server_account):
379 Uncommented the url debug output again, because it is useful for
380 debugging, as I said in the comment.
382 2007-06-18 Murray Cumming <murrayc@murrayc.com>
384 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
386 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
387 for Mameo Bora, to fix the build.
389 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
392 Fixed build with hildon < 0.99
394 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
395 Check if the selected account is busy instead of checking all accounts
397 * src/modest-account-mgr-priv.h:
398 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
399 (modest_account_mgr_init), (compare_account_name),
400 (modest_account_mgr_set_account_busy),
401 (modest_account_mgr_account_is_busy):
402 * src/modest-account-mgr.h:
403 Added busy information to the account manager. It possible to
404 set an account to busy or not busy now.
406 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
407 (modest_mail_operation_update_account),
408 (modest_mail_operation_notify_end):
409 Set the account to busy/not busy depending on the operation state.
411 * src/widgets/modest-account-view.c:
412 (modest_account_view_finalize), (get_last_updated_string),
413 (update_account_view), (on_account_busy_changed), (init_view):
414 Show string "Refreshing..." if the account is currently busy.
416 All this fixes projects.maemo.org bug NB#59711
418 2007-06-14 Armin Burgmeier <armin@openismus.com>
420 * src/widgets/modest-attachments-view.h:
421 * src/widgets/modest-attachments-view.c: Added
422 modest_attachments_view_has_attachments() and fixed coordinate
423 transformation in get_att_view_at_coords(). This fixes attachment
426 * src/widgets/modest-msg-view.c: Make use of
427 modest_attachments_view_has_attachments() to decide whether to show
428 attachments in the header.
430 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
432 * src/maemo/modest-connection-specific-smtp-edit-window.c:
433 (on_change), (on_combo_security_changed),
434 (modest_connection_specific_smtp_edit_window_init),
435 (modest_connection_specific_smtp_edit_window_set_connection),
436 (modest_connection_specific_smtp_edit_window_is_dirty):
437 * src/maemo/modest-connection-specific-smtp-edit-window.h:
438 * src/maemo/modest-connection-specific-smtp-window.c:
441 Show an comfirmation dialog for the smpt-edit-window if there are
442 unsaved changes and the user hits cancel.
443 (projects.maemo.org bug NB#60479)
445 2007-06-14 Armin Burgmeier <armin@openismus.com>
447 * src/maemo/easysetup/modest-easysetup-wizard.c:
448 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
449 address" info in banner instead of node, and select all the text as
450 per UI spec. This fixes projects.maemo.org bug NB#60550.
452 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
454 reviewed by: <delete if not using a buddy>
456 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
457 * src/modest-ui-actions.c: (folder_refreshed_cb):
459 2007-06-14 Murray Cumming <murrayc@murrayc.com>
461 * src/widgets/modest-folder-view.c: (filter_row):
462 Explictly filter out the per-account outbox accounts. I don't know why
463 these only sometimes show up, but now they should never show up in the UI.
464 This should fix projects.maemo.org bug NB#60160.
466 2007-06-14 Murray Cumming <murrayc@murrayc.com>
468 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
469 when the toolbar does not exist yet.
470 * src/modest-widget-memory.c: (save_settings_header_view):
471 Added g_warnings() to help us to discover when we are trying to set
472 an empty columns list in gconf.
474 2007-06-14 Murray Cumming <murrayc@murrayc.com>
478 Added modest_init_get_default_header_view_column_ids().
480 * src/modest-widget-memory.c: (restore_settings_header_view):
481 Use the new function to get defaults, if the gconf key is empty,
482 instead of not creating any columns. This seems to fix the
483 empty right-hand pane problems.
485 * src/widgets/modest-header-view.h: Improved documentation.
487 2007-06-13 Murray Cumming <murrayc@murrayc.com>
489 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
490 Revert the use of the display name as the account name, because this
491 is generally wrong and would break the code that follows.
493 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
495 * src/maemo/easysetup/modest-easysetup-wizard.c:
496 (check_for_supported_auth_methods), (on_before_next),
499 More correct fix for projects.maemo.org bug NB# 58991
500 Do not longer accept AUTH_PASSWORD as secure method and choose
501 correct method when creating the account.
503 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
505 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
506 Fixed projects.maemo.org bug NB# 58991
508 2007-06-13 Murray Cumming <murrayc@murrayc.com>
510 * src/modest-init.c: (modest_init_init_core),
511 (modest_init_local_folders): Fixed compilation errors.
513 2007-06-13 Murray Cumming <murrayc@murrayc.com>
515 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
516 Remove unnecessary lib/include, though it is good in principle when needed.
518 * src/modest-init.c: (modest_init_one_local_folder),
519 (modest_init_local_folders):
520 * src/modest-init.h: Initialize the .modest library for memory cards,
521 instead of just doing nothing for them. This should allow us to create
522 folders there, fixing projects.maemo.org bug NB#59297.
524 2007-06-13 Murray Cumming <murrayc@murrayc.com>
526 * libmodest-dbus-client/libmodest-dbus-client.c:
527 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
528 (libmodest_dbus_client_compose_mail),
529 (libmodest_dbus_client_open_message),
530 (libmodest_dbus_client_send_and_receive),
531 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
533 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
534 (on_idle_open_message), (modest_dbus_req_handler),
535 (search_result_to_message), (modest_dbus_req_filter):
536 * src/modest-search.c: (add_hit), (modest_search_folder),
537 (modest_search_all_accounts): Improved debug messages.
539 * tests/dbus_api/test_open_message.c: (main): Improved comments.
541 * src/modest-tny-account-store.c:
542 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
545 2007-06-13 Murray Cumming <murrayc@murrayc.com>
548 2007-06-12 Murray Cumming <murrayc@murrayc.com>
550 * src/modest-tny-account-store.c: (get_server_accounts):
551 Call modest_tny_local_folders_account_add_merged_outbox_folders()
552 even when there are no accounts, so that the Outbox folder is always
553 visible. This fixes projects.maemo.org bug NB#60158.
555 2007-06-12 Murray Cumming <murrayc@murrayc.com>
557 * src/maemo/modest-main-window.c: (create_details_widget):
558 Use the mcen_va_never logical ID.
560 2007-06-12 Murray Cumming <murrayc@murrayc.com>
562 * src/dbus_api/modest-dbus-api.h:
563 * src/dbus_api/modest-dbus-callbacks.c:
564 (on_idle_open_default_inbox), (on_open_default_inbox),
565 (modest_dbus_req_handler):
566 Added a new OpenDefaultInbox method.
568 * libmodest-dbus-client/libmodest-dbus-client.h:
569 * libmodest-dbus-client/libmodest-dbus-client.c:
570 Added libmodest_dbus_client_open_default_inbox() to call the new
571 dbus method. This should be useful to projects.maemo.org bug NB#57214,
572 though it should maybe be used by a new osso-email-interface function.
574 * tests/dbus_api/Makefile.am:
575 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
578 2007-06-12 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
581 NULL, so that the signals get all the keys. This should not actually
582 change any behaviour because we currently update everything when anything
585 2007-06-12 Murray Cumming <murrayc@murrayc.com>
587 * src/widgets/modest-folder-view.c: (text_cell_data),
588 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
589 (find_inbox_iter): If tinymail tells us that the folder is
590 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
591 This causes the inbox to be selected at startup, fixing part of
592 projects.maemo.org bug NB#56305.
594 * src/modest-ui-dimming-rules.c:
595 (modest_ui_dimming_rules_on_tools_smtp_servers):
596 * src/modest-ui-dimming-rules.h: Added a callback function to dim
597 the SMTP servers menu item.
598 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
599 that the SMTP Servers menu item is dimmed when there are no accounts,
600 as a future version of the UI spec will require. This fixes
601 projects.maemo.org bug NB#56305.
603 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
605 * src/maemo/modest-maemo-utils.c:
606 (modest_maemo_utils_get_supported_secure_authentication_methods):
607 Added label to dialog instead of unreadable title
609 * src/maemo/modest-main-window.c: (sync_accounts_cb),
610 (modest_main_window_new):
611 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
614 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
615 * src/modest-account-mgr.h:
616 Added method to avoid code duplication
618 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
619 (modest_ui_actions_on_send_receive):
620 Use modest_account_mgr_has_accounts
622 2007-06-11 Murray Cumming <murrayc@murrayc.com>
624 * src/maemo/easysetup/modest-presets.c:
625 (modest_presets_get_info_server_security): Do not report secure auth
627 * src/modest-protocol-info.c: Use the defines for the gconf key names
628 for secure authentication. This was not working because we were writing
629 Password and reading password, and the check was case sensitive.
630 With this, gmail now works for receiving and sending when created via
633 2007-06-11 Murray Cumming <murrayc@murrayc.com>
635 * src/maemo/easysetup/modest-presets.c:
636 (modest_presets_get_info_server_security): Correct the key name for
637 SecureSmtp, because it seems to be case-sensitive.
638 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
639 Do not try to get the 0th notebook page if there are 0 pages, to
642 2007-06-11 Murray Cumming <murrayc@murrayc.com>
644 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
645 Prevent use of the new notification feature for now, because it currently
646 shows one dialog for each new email, which is annoying.
648 2007-06-11 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
651 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
652 when no country was selected, so that we show the global ones.
653 * src/maemo/easysetup/modest-presets.c:
654 (modest_presets_get_providers): Return only the global providers, not
655 all providers when mmc=0 was requested.
657 2007-06-11 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
660 (easysetup_provider_combo_box_fill): Remove debug code that showed the
661 provider ID in the combo.
663 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
664 Do not show the page numbers, because it would be confusing when we add
665 the 2 extra pages for the custom setup, when the user chooses the "Other"
666 provider. This fixes projects.maemo.org bug NB#59028
668 * src/modest-init.c: (modest_init_init_core),
669 (modest_init_local_folders):
671 * src/modest-tny-account.c:
672 (modest_tny_account_new_for_local_folders): Do not create default folders
673 for the memory card. This should fix projects.maemo.org bug NB#59328.
675 2007-06-11 Murray Cumming <murrayc@murrayc.com>
677 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
678 Free the changed_conf_keys string items. They are already freed in the
679 idle handler if that runs first.
681 2007-06-11 Murray Cumming <murrayc@murrayc.com>
683 * src/modest-ui-actions.c:
684 (modest_ui_actions_on_password_requested): Check that the server name
685 is not NULL, because I just saw a password dialog with (null) as the
688 * src/modest-tny-folder.[h|c]: Added
689 modest_tny_folder_is_memory_card_folder().
690 * src/modest-ui-dimming-rules.c:
691 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
692 menu item for memory cards, as per the UI spec (section 7.4). This should
693 fix projects.maemo.org bug NB#59297.
695 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
697 * src/maemo/modest-main-window.c: (sync_accounts_cb):
698 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
699 is another problem with the code, see Murray's comment at line 772)
701 2007-06-08 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
704 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
705 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
706 (load_from_file), (easysetup_country_combo_box_init),
707 (easysetup_country_combo_box_get_active_country_ids),
708 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
709 instead of just one ID, to avoid duplicate country names in the UI.
711 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
712 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
713 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
714 a single ID, avoiding duplicate providers.
715 * src/maemo/easysetup/modest-easysetup-wizard.c:
716 (on_combo_account_country): Adapt to use a list.
718 2007-06-08 Murray Cumming <murrayc@murrayc.com>
720 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
721 keys changed in the last X seconds.
723 * src/modest-account-mgr.h:
724 * src/modest-account-mgr.c: (on_timeout_notify_changes),
725 (on_key_change), (modest_account_mgr_class_init),
726 (modest_account_mgr_init), (modest_account_mgr_finalize):
727 As the keys are changed, save them in a GSList* and signal that GSList*
728 further every X seconds, to batch changes, to allow us to do just one
729 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
730 bug NB#56941 and other (UI-blocking) delays when changing account settings.
732 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
733 changed signal signature.
735 * src/modest-conf.c: (modest_conf_set_list),
736 (modest_conf_on_change): Reenable notification.
738 (modest_conf_maemo_fake_on_change): Comment out the hack that
739 notified immediately instead of asynchronously.
741 * src/widgets/modest-account-view.h:
742 * src/widgets/modest-account-view.c:
743 (update_account_view): Select the previously-selected account ID,
744 if possible. This fixes projects.maemo.org bug NB#56933.
746 (on_account_changed), (on_account_removed),
747 (modest_account_view_select_account):
749 Remove the block/unblock functions
750 because they were not useful.
752 * src/maemo/modest-account-view-window.c:
753 (on_delete_button_clicked), (on_edit_button_clicked),
754 (on_new_button_clicked): Remove the use of the non-working block/unblock.
756 2007-06-08 Murray Cumming <murrayc@murrayc.com>
758 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
759 Improve the error dialog to show Incorrect Account Settings, which seems
760 clearer, and say that the internal error message (to be removed from the
761 dialog later) is often misleading.
762 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
764 * src/modest-tny-account.c:
765 (modest_tny_account_new_from_server_account): Uncomment the printf of the
766 URL because this is so useful for debugging on the device.
768 * src/widgets/modest-serversecurity-combo-box.c:
769 (modest_serversecurity_combo_box_fill): Correct a logical ID.
771 2007-06-08 Murray Cumming <murrayc@murrayc.com>
773 * src/modest-mail-operation.c:
774 (modest_mail_operation_send_new_mail):
775 Added a comment about a nasty but apparently harmless message. Details
776 added to the wiki g_warnings() page.
778 2007-06-08 Murray Cumming <murrayc@murrayc.com>
780 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
781 (modest_tny_send_queue_class_init):
782 Do not use the priv struct because it is empty, to avoid g_warnings
783 about a non-existant priv struct.
785 * src/modest-tny-account-store.c:
786 (modest_tny_account_store_get_server_account),
787 (modest_tny_account_store_get_transport_account_for_open_connection
788 ): Do not try to get transport server accounts for local folders,
789 because they don't have any. This avoids a g_warning().
791 * src/maemo/modest-main-window.c:
792 (modest_main_window_notify_send_receive_initied),
793 (on_configuration_key_changed):
794 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
796 * src/modest-mail-operation.c:
797 (modest_mail_operation_update_account):
798 * src/modest-tny-account-store.h:
799 * src/modest-tny-account.c:
800 (modest_tny_account_get_special_folder),
801 (modest_tny_account_new_for_local_folders),
802 (modest_tny_account_new_for_per_account_local_outbox_folder):
803 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
804 * src/modest-tny-local-folders-account.c:
805 (add_account_folders_to_merged_folder):
806 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
807 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
808 (modest_ui_actions_on_send):
809 * src/widgets/modest-folder-view.c: (update_model):
810 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
811 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
812 modest_tny_account_store_get_tny_account_by_account() to
813 modest_tny_account_store_get_server_account() to make the code clearer.
815 2007-06-07 Marcus Bauer <marcusb@openismus.com>
817 * src/dbus_api/modest-dbus-api.h:
818 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
819 * src/maemo/modest-msg-edit-window.c:
820 (modest_msg_edit_window_attach_file_noninteractive):
821 added g_warning in case the file to be attached does not exist
822 * tests/dbus_api/test_compose_mail.c: (main):
823 removed obsolete comment, added generic files as test case
825 2007-06-07 Murray Cumming <murrayc@murrayc.com>
827 * src/modest-tny-account-store.c: (get_server_accounts):
828 Create the local folders account only once, not once for each outbox, and
829 not only when there are some outboxes.
831 2007-06-07 Murray Cumming <murrayc@murrayc.com>
833 * src/widgets/modest-folder-view.c: (update_model): Comment out some
834 code that is causing a crash at startup. Sergio says that he is fixing this.
836 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
838 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
839 * src/maemo/modest-account-settings-dialog.c:
840 (create_page_outgoing),
841 (modest_account_settings_dialog_set_account_name),
842 (save_configuration):
843 - Fixed handling of the "Use secure authentication" toggle to comply with
844 the ui specification. See also projects.maemo.org bug NB#58400
846 - Restore the Secure connection setting combo correctly when loading
849 * src/maemo/modest-maemo-utils.c:
850 (on_camel_account_get_supported_secure_authentication),
851 (modest_maemo_utils_get_supported_secure_authentication_methods):
852 Fixed a crasher if operation is canceled
854 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
855 (modest_protocol_info_auth_is_secure):
856 * src/modest-protocol-info.h:
858 Added two new methods to determine if a protocol/auth method is secure/encrypted in
859 the sense of the "Use secure authentication" toggle.
861 2007-06-07 Murray Cumming <murrayc@murrayc.com>
863 * src/modest-tny-account-store.h:
864 * src/modest-tny-account-store.c:
865 Added modest_tny_account_store_get_local_folders_account().
867 * src/modest-tny-folder.h:
868 * src/modest-tny-folder.c:
869 (modest_tny_folder_get_account):
870 Added this replacement for tny_folder_get_account() which returns
871 the local-folders account for TnyMergeFolders, to avoid the
872 warning about the unimplemented get_account_func() vfunc().
874 (modest_tny_folder_get_rules),
875 * src/modest-ui-actions.c:
876 (modest_ui_actions_on_folder_selection_changed):
877 * src/modest-mail-operation.c:
878 (modest_mail_operation_remove_folder),
879 (modest_mail_operation_xfer_folder),
880 (modest_mail_operation_rename_folder),
881 (modest_mail_operation_get_msg),
882 (modest_mail_operation_get_msgs_full),
883 (modest_mail_operation_remove_msg),
884 (modest_mail_operation_xfer_msgs),
885 (modest_mail_operation_refresh_folder):
886 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
888 2007-06-07 Murray Cumming <murrayc@murrayc.com>
890 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
891 (modest_server_account_set_security):
892 * src/modest-defs.h: Add comments explaining that our
893 UI spec means TLS when it says Normal, so these do not look like errors.
895 * src/modest-tny-account.c:
896 (modest_tny_account_new_from_server_account): Use the new tinymail
897 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
898 for TLS. This should fix projects.maemo.org bug NB#58460.
900 2007-06-06 Murray Cumming <murrayc@murrayc.com>
902 * src/maemo/easysetup/modest-easysetup-wizard.c:
903 (create_account): Correct the position of the gconf sanity check warning.
904 (on_button_edit_advanced_settings): Show the dialog immediately, instead
905 of using the g_idle_add() hack, because this does not seem to be necessary
906 on osso 1.1. It might even work on Maemo Bora if the problems were actually
907 caused by something other than maemo's gconf.
908 This fixes projects.maemo.org bug #59022.
910 2007-06-06 Murray Cumming <murrayc@murrayc.com>
912 * src/modest-account-mgr-helpers.c:
913 (modest_account_mgr_get_default_account): Do not check that the account
914 exists if there is no default account (NULL), to fix a runtime warning.
916 2007-06-06 Murray Cumming <murrayc@murrayc.com>
918 * src/widgets/modest-folder-view.c: (update_model):
919 Do not unref the treemodel before we have finished with it.
920 This prevents a valgrind warning and an occasional crash at startup.
922 2007-06-06 Marcus Bauer <marcusb@openismus.com>
924 * libmodest-dbus-client/libmodest-dbus-client.h:
925 added libmodest_dbus_client_compose_mail()
926 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
928 added functions needed for SendAsMail() functionality
929 * src/maemo/modest-msg-edit-window.c:
930 (modest_msg_edit_window_attach_file_noninteractive):
931 non interactively attaching files to message edit window
932 * src/widgets/modest-msg-edit-window.h:
933 * tests/dbus_api/Makefile.am:
934 added test_compose_mail.c
935 * tests/dbus_api/test_compose_mail.c: (main):
937 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
939 * src/modest-account-view.c:
940 Fixed bug projects.maemo.org bug NB#59307
942 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
944 * src/maemo/easysetup/modest-easysetup-wizard.c:
945 (get_serverport_incoming), (on_before_next), (create_account):
946 * src/maemo/modest-account-settings-dialog.c:
947 (modest_account_settings_dialog_set_account_name):
948 * src/maemo/modest-maemo-utils.c:
949 (on_camel_account_get_supported_secure_authentication_status),
950 (on_camel_account_get_supported_secure_authentication),
951 (on_secure_auth_cancel),
952 (modest_maemo_utils_get_supported_secure_authentication_methods):
954 Implemented security authentication for settings and easysetup.
956 2007-06-05 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/modest-main-window.c: (create_details_widget):
959 Show the total size for memory card accounts too, instead of showing
960 the name again. Fixes bug projects.maemo.org bug NB#59307.
962 2007-06-05 Murray Cumming <murrayc@murrayc.com>
965 * src/modest-tny-simple-folder-store.c:
966 * src/modest-tny-simple-folder-store.h: Removed.
968 * src/modest-tny-local-folders-account.h
969 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
970 for the local-folders maildir, with an extra TnyMergedFolder containing
971 the folders of the per-account outbox store accounts.
972 * src/modest-tny-account-store.c: (get_server_accounts):
973 Add the outboxes to the special local folders account after creating it.
975 * src/modest-tny-account.c:
976 (modest_tny_account_new_for_local_folders): Create the derived
977 account when creating the main local-folders account.
979 * src/maemo/modest-main-window.c: (create_details_widget),
980 (modest_main_window_set_contents_style):
981 Adapted to the use of the derived account instead of the folder store.
983 * src/modest-ui-actions.c:
984 (modest_ui_actions_on_folder_selection_changed):
985 * src/modest-ui-dimming-rules.c:
986 (modest_ui_dimming_rules_on_new_folder):
987 * src/widgets/modest-folder-view.c: (text_cell_data),
988 (icon_cell_data), (filter_row), (update_model),
989 (get_cmp_rows_type_pos):
992 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
993 Do not get the priv struct, because no priv struct has been set,
994 to avoid a runtime warning.
996 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
997 #ifelse with #else, to fix a warning, to fix the build.
1000 2007-06-05 Christian Kellner <ckellner@openismus.com>
1002 * libmodest-dbus-client/libmodest-dbus-client.c:
1003 Fix small typo in doc (why do you always see them
1004 AFTER committing stuff?)
1007 2007-06-05 Christian Kellner <ckellner@openismus.com>
1009 * libmodest-dbus-client/libmodest-dbus-client.c:
1010 (libmodest_dbus_client_search):
1011 Initialize hit list with NULL. Also set folder list
1012 to "" if NULL was supplied.
1015 2007-06-03 Christian Kellner <ckellner@openismus.com>
1017 * libmodest-dbus-client/libmodest-dbus-client.c:
1018 (modest_search_hit_list_free):
1019 Make it save to call it with NULL.
1021 * src/dbus_api/modest-dbus-callbacks.c:
1022 * src/modest-search.c:
1023 Return full ModestSearchHits as the search result list not TnyHeader
1024 since can't be around withouth the correspoding TnyFolder.
1026 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1028 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1029 Added currently commented code to check for secure auth
1031 * src/maemo/modest-account-settings-dialog.c: (on_response),
1032 (save_configuration), (show_ok):
1033 Fixed projects.maemo.org bugs NB #59248 and #59251
1035 * src/maemo/modest-maemo-utils.c:
1036 (on_camel_account_get_supported_secure_authentication_status),
1037 (on_camel_account_get_supported_secure_authentication),
1038 (modest_maemo_utils_get_supported_secure_authentication_methods):
1039 * src/maemo/modest-maemo-utils.h:
1040 Moved get_supported_secure_authentication() method here to be able
1041 to use it from easysetup wizard.
1043 * src/modest-pair.c: (on_pair_compare_as_string):
1044 Should compare string with first part of pair and not
1045 strcmp pairs which will crash.
1047 * src/modest-protocol-info.c:
1048 (modest_protocol_info_protocol_is_store):
1049 * src/modest-protocol-info.h:
1050 Added modest_protocol_info_get_auth_protocol_name()
1052 2007-06-03 Armin Burgmeier <armin@openismus.com>
1054 * src/modest-mail-operation.c:
1055 (modest_mail_operation_get_msgs_full): Set priv->account also when
1056 only retrieving a single message. This avoids a crash when canceling
1059 (modest_mail_operation_notify_end): Do not explicitely remove the
1060 operation from the queue but only emit the progress_changed signal.
1061 The queue itself listens to that signal to remove the operation when
1062 it is finished. This reduces coupling and removes a potential deadlock
1063 when modest_mail_operation_notify_end() is called from the queue
1064 itself. If that is a problem performance-wise, I would suggest to
1065 implement a status-changed signal or something.
1067 * src/modest-mail-operation-queue.c: Make sure to never call a
1068 function from another file while the queue is locked. This (hopefully)
1069 fixes another deadlock when exiting the application while retrieving
1072 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1074 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1075 Fixed build if libogs is not available
1077 2007-06-03 Christian Kellner <ckellner@openismus.com>
1079 * libmodest-dbus-client/libmodest-dbus-client.h:
1080 * libmodest-dbus-client/libmodest-dbus-client.c:
1081 (libmodest_dbus_client_delete_message):
1082 Implement deletion of messages (Client side).
1084 (modest_search_hit_free),
1085 (modest_search_hit_list_free):
1086 Utility functions to free the result hits.
1088 * src/dbus_api/modest-dbus-api.h:
1089 * src/dbus_api/modest-dbus-callbacks.c:
1090 (on_delete_message),
1091 (modest_dbus_req_handler):
1092 Implement deletion of messages (Server side).
1094 * tests/dbus_api/test_search.c: (main):
1097 * tests/dbus_api/Makefile.am:
1098 * tests/dbus_api/test_delete_message:
1099 Add little test for the message deletion logic
1101 2007-06-03 Armin Burgmeier <armin@openismus.com>
1103 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1104 when the operation queue was not empty. projects.maemo.org bug
1107 2007-06-03 Armin Burgmeier <armin@openismus.com>
1109 * src/widgets/modest-account-view.c
1110 (on_account_default_toggled): Toggle default account column
1111 explicitely instead of waiting for gconf notification (which is
1112 currently ignored). This should fix projects.maemo.org bug NB#56910
1113 for now. It should probably be removed when gconf notifications are
1116 2007-06-03 Christian Kellner <ckellner@openismus.com>
1118 * libmodest-dbus-client/libmodest-dbus-client.c:
1119 Removed debugging spew.
1121 * src/dbus_api/modest-dbus-callbacks.c:
1122 Added debugging info.
1124 * src/modest-search.c:
1125 (modest_search_all_accounts):
1126 Use tny_account_store_get_accounts () on the account store
1127 to get all accounts which is the way to get all accounts.
1129 * tests/dbus_api/test_search.c: (main):
1130 Make it possible to supply the search term on the command line.
1132 2007-06-03 Christian Kellner <ckellner@openismus.com>
1134 * libmodest-dbus-client/libmodest-dbus-client.c:
1135 * libmodest-dbus-client/libmodest-dbus-client.h:
1136 Implement searching for mesages over raw dbus. (Client side)
1138 * src/dbus_api/Makefile.am:
1139 * src/dbus_api/modest-dbus-api.h:
1140 * src/dbus_api/modest-dbus-callbacks.c:
1141 * src/dbus_api/modest-dbus-callbacks.h:
1142 Search framework (Server side). Also implement on_idle_open_message().
1144 * src/maemo/modest-platform.c: (modest_platform_init):
1145 Prepare for raw dbus/osso rpc interaction.
1147 * src/modest-search.h:
1148 Changed minsize from unspecific guint to guint32.
1150 * src/modest-search.c:
1152 Added strange hack which magically made tnymail work.
1154 (modest_search_folder),
1155 (modest_search_account),
1156 (modest_search_all_accounts):
1157 Implement helper functions to search all accounts, specific account
1160 * tests/dbus_api/Makefile.am:
1161 * tests/dbus_api/test_open_message.c:
1162 Read url to open from commandline.
1164 * tests/dbus_api/test_search.c:
1165 Implement small test for dbus search stuff
1167 2007-06-02 Armin Burgmeier <armin@openismus.com>
1169 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1170 include account type and account title. This fixes projects.maemo.org
1173 * src/maemo/modest-account-view-window.c: Set a title for the window.
1175 2007-06-02 Armin Burgmeier <armin@openismus.com>
1177 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1178 incoming and outgoing server name based on email address and server
1179 types as long as the names have not been edited manually. This fixes
1180 projects.maemo.org bug NB#58671.
1182 2007-06-02 Armin Burgmeier <armin@openismus.com>
1184 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1185 server type cannot be changed in future to the incoming details page
1186 when creating an account. This fixes projects.maemo.org bug NB#59029.
1188 2007-06-02 Armin Burgmeier <armin@openismus.com>
1190 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1191 and assigned max width chars so that they wrap instead of being
1192 truncated. Fixes projects.maemo.org bug NB#56126.
1194 2007-06-02 Armin Burgmeier <armin@openismus.com>
1196 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1197 introductory note to the connection specific smtp servers dialog, as
1198 section 8.12 of the email UI specification requires. This fixes
1199 projects.maemo.org bug NB#59212.
1201 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1204 Check for running mail operations, and offer to cancel them, as per the UI
1205 spec. This fixes projects.maemo.org bug NB#59041 .
1206 However, I suspect that tinymail may still use the network connection
1207 in ways that we cannot detect or cancel. But it should at least adapt to
1208 changes fairly well.
1210 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1212 * src/modest-tny-account-store.c: (recreate_all_accounts),
1213 (get_cached_accounts), (get_server_accounts): Do more sensible
1214 ref-counting of the temporarily-cached outbox accounts list. This seems
1215 to fix a crash when entering the password when the password was wrong.
1217 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1219 * src/gnome/modest-main-window.c: (connect_signals):
1220 * src/modest-tny-account-store.c: (get_password),
1221 (modest_tny_account_store_alert): Added comments and clues and
1222 commented-out code about how we currently fail to deal with connection
1223 errors and wrong passwords, and how we should.
1225 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1227 * src/widgets/modest-retrieve-combo-box.c:
1228 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1229 This fixes projects.maemo.org bug NB#58472 .
1231 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/easysetup/modest-easysetup-wizard.c:
1234 (create_page_complete_easysetup):
1235 (create_page_complete_custom): Correct the last commit,
1236 putting the correct sentences in the correct pages.
1238 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1240 * src/maemo/easysetup/modest-easysetup-wizard.c:
1241 (create_page_complete_custom): Show the second sentence of text
1242 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1245 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1247 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1248 Set the leave-on-server conf key by default. This fixes
1249 projects.maemo.org bug NB#59258 .
1251 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1253 * src/maemo/modest-account-view-window.c:
1254 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1255 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1258 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1260 * src/maemo/easysetup/modest-easysetup-wizard.c:
1261 (create_caption_new_with_asterisk):
1262 * src/maemo/modest-account-settings-dialog.c:
1263 (create_caption_new_with_asterisk):
1264 Uncomment the code to add the asterisk, because they are no longer in the
1265 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1266 (update_incoming_server_title): Add an asterisk here too.
1268 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/modest-maemo-global-settings-dialog.c:
1271 (current_connection): Check that we are even connected before trying to
1272 get the current connection name, to prevent a warning.
1274 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1275 Change the comments because tny_maemo_conic_device_connect() is now meant to
1277 * src/modest-mail-operation.c:
1278 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1279 make sure we have a connection and fail if we can't connect.
1281 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1283 * src/maemo/modest-main-window.c:
1284 (on_account_store_connecting_finished): Do not try to get the
1285 connection ID if we are not really connected. I am surprised that
1286 this signal handler is called when we are not connected.
1288 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1290 * src/modest-error.h:
1291 * src/modest-ui-actions.c:
1292 (modest_ui_actions_get_msgs_full_error_handler):
1293 Renamed an enum, added comments, added an enum
1294 for retrieve-limit errors.
1296 * src/modest-mail-operation.c: (foreach_add_item),
1297 (internal_folder_observer_update), (update_account_thread),
1298 (modest_mail_operation_get_msgs_full):
1299 (modest_mail_operation_update_account),
1300 Added comments about how this works, and some code that should
1301 (but does not) check the retrieve-limit. See the TODO comment.
1303 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1305 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1306 Initialize help_id to fix the build. Warnings are good.
1308 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1310 * src/widgets/modest-hbox-cell-renderer.c:
1311 (modest_hbox_cell_renderer_append):
1312 * src/widgets/modest-vbox-cell-renderer.c:
1313 (modest_vbox_cell_renderer_append):
1314 Fix the last commit by doing an extra ref.
1316 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1318 * src/widgets/modest-hbox-cell-renderer.c:
1319 (modest_hbox_cell_renderer_append):
1320 * src/widgets/modest-vbox-cell-renderer.c:
1321 (modest_vbox_cell_renderer_append):
1322 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1323 to fix the build with Maemo Bora.
1324 However, there seems to be a remaining crash, probably due to reference
1327 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-tny-account.c:
1330 (modest_tny_account_new_for_local_folders):
1331 Use hildon_file_system_info_async_new() to get a better name for
1332 the memory card account, setting it as the account name.
1333 The timing seems to work, but this is probably
1334 not the best place to do this. See the TODO comment.
1335 * src/maemo/modest-main-window.c: (create_details_widget):
1336 * src/widgets/modest-folder-view.c: (text_cell_data):
1337 Use the tny account name instead of hardcoding a name.
1339 2007-05-30 Christian Kellner <ckellner@openismus.com>
1341 * src/modest-search.c: (modest_search):
1342 Correctly set part_search_func even if we have already parsed
1343 the query and thus a valid OgsTextSearcher object.
1345 2007-05-30 Christian Kellner <ckellner@openismus.com>
1348 Search and check for libogs.
1351 Incooparte the ogs build env.
1353 * src/modest-mime-part-search-stream.c:
1354 * src/modest-mime-part-search-stream.h:
1355 Removed since we do the real searching now in modest-search.c.
1357 * src/modest-search.c:
1358 * src/modest-search.h:
1359 Implement support for ogs. We use that if available and requested
1360 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1361 should now handle the corner case when the search term is spread
1362 across multiple reads.
1363 Also the logic in modest_search () was corrected to search all
1364 requested fields until one is found.
1366 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1370 * src/modest-init.h:
1371 * src/modest-init.c: Made modest_init_local_folders() take a
1372 path and be public so we can iniitialize maildir folders on
1375 * src/modest-local-folder-info.h:
1376 * src/modest-local-folder-info.c:
1377 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1379 * src/modest-tny-account.c:
1380 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1381 still means the standard local-folders path on the local volume.
1383 * src/modest-tny-account-store.c:
1384 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1385 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1386 all accounts when that happens.
1387 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1388 this too, so it shows up in the treeview.
1390 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1392 * src/maemo/modest-maemo-global-settings-dialog.c:
1393 (current_connection):
1394 * src/widgets/modest-global-settings-dialog.c:
1395 (current_connection_default):
1396 Use the enum values instead of 0, 1 and -1,
1397 to make the code clearer.
1399 * src/modest-account-mgr-helpers.c:
1400 (modest_account_mgr_get_connection_specific_smtp): Make this code
1403 * src/modest-runtime.h:
1404 * src/modest-runtime.c:
1405 Added modest_runtime_remove_all_send_queues().
1406 * src/maemo/modest-main-window.c:
1407 (on_account_store_connecting_finished): Recreate the send queues,
1408 using the appropriate transport accounts for this new connection.
1409 Some futher adapting might be needed if the old send queues are not
1410 automatically stopped at this point.
1412 * src/modest-tny-account-store.c: (get_server_accounts):
1413 Create the connection-specific transport accounts, so that they can
1414 be found later by their ID.
1416 * src/modest-tny-account.h:
1417 * src/modest-tny-account.c:
1418 Added modest_tny_account_new_from_server_account_name().
1419 modest_tny_account_new_from_server_account(): Do not create the
1420 send queues here, because they will be
1421 recreated anyway when the connection changes for the first time.
1423 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1425 * src/modest-local-folder-info.h:
1426 * src/modest-local-folder-info.c:
1427 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1428 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1429 tbox_folder): Take a modest account name instead of a server TnyAccount,
1430 so we can have per-modest-account rather than per-transport-account
1432 We must make sure that we change or recreate the exisitng send queues
1433 when the connection changes for connection-specific transport accounts.
1435 * src/modest-tny-account-store.c:
1436 (create_per_account_local_outbox_folders): Create outboxed per modest
1437 account, not per transport account.
1439 * src/modest-tny-account.h:
1440 * src/modest-tny-account.c:
1441 (modest_tny_account_get_special_folder): For outboxes, get the
1442 parent modest account name. The account is ignored for other folders.
1443 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1444 modest account name rather than a server TnyAccount.
1446 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-tny-account.c:
1449 (modest_tny_account_new_from_server_account):
1450 Call modest_runtime_get_send_queue() immediately after creating transport
1451 accounts, so that they start trying to send email from the outbox as soon
1452 as possible at startup. This is probably what we want.
1454 * src/modest-mail-operation.c: (update_account_thread):
1455 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1456 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1457 * src/modest-tny-send-queue.h:
1458 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1459 (modest_ui_actions_on_send):
1460 Added comments about how sending works, though it needs some more work.
1462 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1464 * src/modest-tny-account.c:
1465 (modest_tny_account_get_special_folder): Add TODO because this fails when
1466 the network is busy.
1467 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1468 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1469 Do not try to show this window when there is no active account. The UI
1470 specs does not tell us what to do in this case.
1472 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1476 * src/maemo/Makefile.am:
1477 * src/widgets/Makefile.am: Some dist fixes.
1479 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1481 * src/maemo/modest-connection-specific-smtp-window.c:
1482 (on_button_edit): Make the code clearer, to prevent a double free.
1484 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1486 * src/maemo/modest-account-settings-dialog.c:
1487 (modest_account_settings_dialog_set_account_name),
1488 Check the connection-specific smtp servers checkbox if there are any.
1490 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1491 (modest_connection_specific_smtp_edit_window_init):
1492 Start with a suitable port number.
1494 * src/modest-account-mgr-helpers.h:
1495 * src/modest-account-mgr-helpers.c: Added
1496 modest_account_mgr_get_has_connection_specific_smtp().
1498 (modest_account_mgr_set_connection_specific_smtp),
1499 (modest_account_mgr_remove_connection_specific_smtp),
1500 (modest_account_mgr_get_has_connection_specific_smtp),
1501 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1502 connection-specific smtp server accounts in the account, rather than
1503 the server account conf dir.
1505 This fixes bug projects.maemo.org bug NB#58263 .
1507 * src/modest-tny-account-store.c:
1508 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1509 if there are no server accounts yet, to prevent an infinite loop when there
1510 are no accounts. Document that one must be called before the other.
1512 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-account-mgr-helpers.c:
1515 (modest_account_mgr_get_default_account): Make sure that at least
1516 one account is always the default, if there are any enabled accounts.
1517 This is just a sanity check that shouldn't be necessary.
1519 * src/modest-account-mgr-priv.c:
1520 (_modest_account_mgr_account_from_key): Unescape the conf key to
1521 get the real account name. For instance, this is an issue if a space
1522 was in the account name, which can happen because the account name
1523 is generated from the display name.
1524 (_modest_account_mgr_get_account_keyname): Always escape the
1526 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1527 Unescape the conf keys to get the real account names.
1529 For instance, previously the is-default radio button in the accounts
1530 list was not checked for any accounts at first. This fixes that,
1531 and might fix several similar bugs.
1533 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1535 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1536 Removed some debug printfs.
1538 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1540 Modest on-disk outbox directories are now here, for instance:
1541 $HOME/.modest/outboxes/<account-id-1>/outbox
1542 $HOME/.modest/outboxes/<account-id-2>/outbox
1544 $HOME/.modest/local-folders/outbox
1545 so we can have a separate outbox for each account.
1546 But they are shown as one outbox in the GtkTreeView, by using a
1547 TnyMergeFolder in a ModestTnySimpleFolderStore.
1550 * src/modest-tny-simple-folder-store.c:
1551 * src/modest-tny-simple-folder-store.h:
1552 Added ModestTnySimpleFolderStore, used to contain folders from
1553 other folder stores, such as other accounts.
1555 * src/modest-tny-outbox-account.h:
1556 * src/modest-tny-outbox-account.c:
1557 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1558 used for the per-account local outbox folders.
1560 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1561 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1562 only use this (internally) now for the non-outbox local folders.
1564 * src/modest-init.h:
1565 * src/modest-init.c: Added modest_init_one_local_folder(), for
1566 setting up the directory structure for each local folder.
1568 * src/modest-local-folder-info.c:
1569 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1570 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1572 * src/modest-local-folder-info.h:
1573 * src/modest-tny-account-store.c: (on_account_removed),
1574 (on_account_changed), (create_per_account_local_outbox_folders),
1575 (get_server_accounts), (modest_tny_account_store_get_accounts),
1576 (modest_tny_account_store_get_tny_account_by_account),
1577 (modest_tny_folder_store_is_virtual_local_folders):
1579 * src/modest-tny-account.h:
1580 * src/modest-tny-account.c:
1581 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1582 to create an on-disk per-account local outbox folder for each
1584 (create_per_account_local_outbox_folders): Create a local outbox folder
1585 for each transport account.
1586 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1587 for all local folders.
1589 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1590 instead of using g_object_get/set() directly. It is clearer.
1592 (modest_tny_folder_store_get_message_count),
1593 (modest_tny_folder_store_get_local_size
1594 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1595 because we now use these with non-acount folder stores.
1597 (modest_tny_account_get_special_folder),
1598 (modest_tny_account_new_from_server_account),
1599 (modest_tny_account_new_from_account):
1600 (recurse_folders): Adjust to the new outbox system.
1602 * src/modest-tny-folder.h:
1603 * src/modest-tny-folder.c:
1604 (modest_tny_folder_is_local_folder),
1605 (modest_tny_folder_get_local_folder_type),
1606 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1608 * src/widgets/modest-main-window.h:
1609 * src/maemo/modest-main-window.c: (create_details_widget),
1610 (modest_main_window_set_contents_style): Show details for any folder store,
1613 (modest_tny_folder_get_rules):
1614 Remove the const. C does not support constness enough for this.
1616 * src/modest-ui-actions.c:
1617 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1618 make all outboxes appear as one, in the usual local-folders tree node.
1620 (set_active_account_from_tny_account),
1621 (modest_ui_actions_on_folder_selection_changed):
1622 * src/widgets/modest-folder-view.c: (text_cell_data),
1623 (icon_cell_data), (filter_row),
1624 (add_account_folders_to_merged_folder),
1625 (add_account_folders_to_simple_folder_store), (),
1626 (get_cmp_rows_type_pos), (cmp_rows),
1627 (modest_folder_view_set_account_id_of_visible_server_account):
1628 Adjust to the new outbox system, using generic folder stores and folders
1629 in the GtkTreeModel.
1631 2007-05-23 Christian Kellner <ckellner@openismus.com>
1633 * src/modest-mail-operation.c:
1634 (modest_mail_operation_update_account):
1635 Use info->max_size instead of unintialized local var [small
1636 build fix]. (Added TODO to review that change since I don't
1639 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1641 * libmodest-dbus-client/libmodest-dbus-client.c:
1642 (libmodest_dbus_client_compose_mail): function added
1643 * src/dbus_api/modest-dbus-api.h:
1644 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1645 (on_compose_mail): Implementation of the SendAsMail functionality
1647 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1649 * src/modest-account-mgr.c:
1650 (modest_account_mgr_add_server_account): Set the secure-connection
1651 conf key for transport accounts as well as store accounts. I don't know
1652 why the if was there. For instance, this makes sure that we use SSL
1653 for the gmail preset from the easysetup wizard.
1655 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1657 * src/gnome/modest-main-window.c:
1658 (on_account_store_connecting_finished), (connect_signals):
1659 * src/maemo/modest-main-window.c:
1660 (on_account_store_connecting_finished), (connect_signals),
1661 (modest_main_window_new):
1662 Handle TnyAccountStore::connecting-finished instead of
1663 TnyDevice::connection-changed, because we cannot actually perform
1664 operations on accounts until TnyAccountStore has itself responded to
1665 the TnyDevice::connection-changed signal. This prevents a GError from
1667 Do not try to update at startup, because we (at least on scratchbox)
1668 already do an update at startup when the device goes online.
1669 This prevents a GError from tinymail.
1670 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1671 Added TODO about stopping simultaneous operations.
1673 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1675 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1676 * src/modest-mail-operation-queue.c:
1677 (modest_mail_operation_queue_remove):
1678 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1679 about where they happened.
1681 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1683 * src/modest-ui-actions.c:
1684 (modest_ui_actions_on_password_requested): Make sure that the remember
1685 output parameter is always TRUE.
1687 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1689 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1690 Show a OK/Cancel dialog if the error is a question, though we still do not
1691 know anything more about what we are asking the user.
1692 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1693 Fix an uninitialized variable (helper). This is a logic error, however.
1695 2007-05-21 Christian Kellner <ckellner@openismus.com>
1697 * src/modest-search.h:
1698 Correct bit shifting in the ModestSearchFlags enum.
1700 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1702 * src/modest-tny-account.c:
1703 (modest_tny_account_new_from_server_account): Do not use the lsub and
1704 check-all hard-coded IMAP options when using POP.
1706 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1708 * src/modest-tny-account.c:
1709 (modest_tny_account_new_from_server_account):
1710 Use NULL for the secure-auth method for POP when Password auth has been
1711 specified by the user, as we already do for IMAP. "auth=Login" causes
1712 an error from camel or the server.
1714 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1716 * src/maemo/modest-account-settings-dialog.c:
1717 (create_page_account_details),
1718 (modest_account_settings_dialog_set_account_name):
1719 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1720 for the leave-on-server checkbox, rathr than just the checkbox, when
1721 the protocol is not POP.
1723 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1725 * src/widgets/modest-account-view.c:
1726 * src/widgets/modest-account-view.h:
1727 Added modest_account_view_select_account() which will be useful later
1728 to asynchronously re-select the edited account.
1730 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1732 * src/maemo/modest-account-settings-dialog.c:
1733 (modest_account_settings_dialog_set_account_name):
1734 Automatically choose the port numbers based on the secure authentication
1735 methods, if they have not been chosen before.
1736 This fixes projects.maemo.org bug NB#56273 .
1738 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1740 * src/maemo/modest-main-window-ui.h:
1741 * src/modest-ui-actions.c:
1742 * src/modest-ui-actions.h:
1743 Connect the Tools/SMTP Servers menu item to
1744 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1745 SMTP servers dialog, as in the UI specification and saves changes when it
1746 is closed. This fixed projects.maemo.org bug NB#56305 .
1748 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/modest-connection-specific-smtp-window.c:
1751 (modest_connection_specific_smtp_window_init):
1752 Use gtk_window_set_default_size() to make this window big enough, so
1753 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1755 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1757 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1758 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1759 (modest_connection_specific_smtp_edit_window_init),
1760 Do not try to connect to a combobox signal before the combobox exists.
1761 This fixes the cras in projects.maemo.org bug NB#56288 .
1762 (modest_connection_specific_smtp_edit_window_get_settings):
1763 Remove the server_account_name parameter which was being checked for NULL
1764 though it was not used.
1766 * src/maemo/modest-connection-specific-smtp-window.c:
1767 (modest_connection_specific_smtp_window_fill_with_connections),
1768 (on_button_edit), (modest_connection_specific_smtp_window_init):
1769 Correct the number of treemodel columns to prevent a warning.
1770 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1771 libconic does not work.
1773 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1775 * src/modest-tny-account.c:
1776 (modest_tny_account_new_from_server_account):
1777 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1778 SMTP when "None" was chosen by the user. However, with my SMTP server that
1779 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1782 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1785 to explain the memory management issue with the ID in the ModestPair.
1787 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1788 (add_sending_page), (modest_account_assistant_finalize):
1789 * src/gnome/modest-gnome-global-settings-dialog.c:
1790 (create_updating_page), (create_composing_page):
1791 * src/gnome/modest-msg-edit-window.c: (get_transports),
1792 (init_window), (modest_msg_edit_window_finalize),
1793 (modest_msg_edit_window_get_msg_data):
1794 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1795 * src/gnome/modest-transport-widget.c:
1796 (modest_transport_widget_finalize), (smtp_configuration):
1797 * src/maemo/modest-maemo-global-settings-dialog.c:
1798 (create_updating_page), (create_composing_page):
1799 * src/maemo/modest-msg-edit-window.c: (get_transports),
1800 (init_window), (modest_msg_edit_window_finalize),
1801 (modest_msg_edit_window_get_msg_data),
1802 (modest_msg_edit_window_free_msg_data):
1803 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1804 (modest_store_widget_finalize):
1805 * src/maemo/modest-transport-widget.c:
1806 (modest_transport_widget_finalize), (smtp_configuration):
1807 * src/modest-main.c: (send_mail):
1808 * src/widgets/modest-combo-box.h:
1809 * src/widgets/modest-global-settings-dialog-priv.h:
1810 * src/widgets/modest-global-settings-dialog.c:
1811 (modest_global_settings_dialog_finalize):
1812 * src/widgets/modest-msg-edit-window.h:
1813 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1814 as long as the combo box, to prevent use of freed memory for the ID.
1816 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1818 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1819 get_accounts(), to make this clearer. Do not check for the enabled gconf
1820 key, because we do not use this for server accounts (at least, not yet).
1821 This allows us to send email again.
1823 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/modest-platform.c:
1826 (on_modest_conf_update_interval_changed), (modest_platform_init):
1827 Only respond to this particular key change. All these strcmp()s cannot be
1830 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1832 * src/maemo/modest-maemo-global-settings-dialog.c:
1833 (current_connection): Prevent a crash in scratchbox when
1834 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1835 * src/maemo/modest-platform.c:
1836 (on_modest_conf_update_interval_changed), (modest_platform_init):
1837 Get the update interval from gconf and reset it when the gconf key changes.
1839 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1841 * src/modest-protocol-info.c:
1842 * src/modest-protocol-info.h: Adde enum-specific get functions,
1843 instead of using a ModestProtocolType enum parameter.
1845 * src/gnome/modest-account-assistant.c:
1846 * src/gnome/modest-store-widget.c:
1847 * src/gnome/modest-store-widget.h:
1848 * src/gnome/modest-transport-widget.c:
1849 * src/gnome/modest-transport-widget.h:
1850 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1851 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1852 * src/maemo/easysetup/modest-easysetup-wizard.c:
1853 * src/maemo/modest-account-settings-dialog.c:
1854 * src/maemo/modest-account-settings-dialog.h:
1855 * src/maemo/modest-store-widget.c:
1856 * src/maemo/modest-store-widget.h:
1857 * src/maemo/modest-transport-widget.c:
1858 * src/maemo/modest-transport-widget.h:
1859 * src/modest-account-mgr-helpers.c:
1860 * src/modest-account-mgr-helpers.h:
1861 * src/modest-account-mgr.c:
1862 * src/modest-account-mgr.h:
1863 * src/modest-tny-account.c:
1864 * src/modest-tny-folder.c:
1865 * src/widgets/modest-account-view.c:
1866 * src/widgets/modest-retrieve-combo-box.c:
1867 * src/widgets/modest-retrieve-combo-box.h:
1868 * src/widgets/modest-secureauth-combo-box.c:
1869 * src/widgets/modest-serversecurity-combo-box.c:
1870 * src/widgets/modest-serversecurity-combo-box.h:
1871 * tests/check_account-mgr.c:
1872 Use the specific functions, and use the re-renamed enum values for GNOME too.
1874 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1876 * src/modest-pair.h:
1877 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1878 so we can get the second based on the first.
1880 * src/maemo/modest-account-settings-dialog.h:
1881 * src/maemo/modest-account-settings-dialog.c:
1882 Added get_supported_secure_authentication_methods(), though it is mostly
1883 commented-out for now until the necessary API is committed to tinymail.
1884 (modest_account_settings_dialog_set_account_name),
1885 (save_configuration): Request the supported authentication methods from the
1886 server, so we can choose a working method.
1888 * src/modest-tny-account-store.h:
1889 * src/modest-tny-account-store.c:
1890 (modest_tny_account_store_get_session): Rename from
1891 tny_account_store_get_session().
1893 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-protocol-info.h: Split the ModestProtocol enum
1896 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1897 There was no need to have these unrelated values in one enum.
1899 * src/: many files: Adapted to changed enum. This makes the code a bit
1900 clearer, and the compiler could catch some errors.
1902 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1904 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1905 Show the detailed internal camel error message when an error happens
1906 during the configuration, so that our testers can give us more clues.
1907 For instance, in projects.maemo.org bug NB#56910 .
1909 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1911 * src/modest-tny-account.c:
1912 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1913 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1915 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1918 * src/maemo/modest-account-settings-dialog.c:
1919 (modest_account_settings_dialog_set_account_name),
1920 (save_configuration): For the incoming secure authentication checkbox,
1921 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1922 the UI specification. PLAIN does not seem to be supported for most IMAP
1923 servers anyway, and I am not sure what it would mean.
1924 However, we probably need to discover which of the secure-authentication
1925 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1926 * src/modest-account-mgr-helpers.c:
1927 (modest_account_mgr_get_server_account_data):
1929 * src/modest-tny-account.c:
1930 (modest_tny_account_new_from_server_account):
1931 Use tny_account_set_mech() to set secure-authentication methods,
1932 with some special-casing for IMAP, based on my observations of how
1935 * src/modest-account-mgr-helpers.h:
1936 * src/modest-account-mgr.c:
1937 * src/modest-defs.h: Comment that the URI is only used for local folders.
1939 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1942 parameter const, just to be neat.
1943 * src/modest-text-utils.c: (modest_text_utils_inline):
1944 End g_strconcat() with NULL, as its documentation says. This is almost
1945 certainly the cause of my crash at startup on the device. Interestingly,
1946 valgrind doesn't tell us about these errors.
1948 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1950 * scripts/build-packages: Added more precise comments about how to use
1951 this script, though I still get this error:
1952 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1953 error building tinymail
1955 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1957 * src/maemo/modest-main-window.c: (on_account_update):
1958 Very slight cleanup, hoping to make it simpler to discover what causes
1959 a crash here sometimes.
1961 * src/modest-tny-account.c:
1962 (modest_tny_account_new_from_server_account): Set the port. Added
1963 comments about the options and a TODO comment because I need to find out
1964 how to specify the secure authentication method.
1966 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1968 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1969 changed CFlags paths form modest to libmodest
1971 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1973 * src/modest-account-mgr-helpers.c:
1974 (modest_account_mgr_get_server_account_data),
1975 (modest_account_mgr_free_server_account_data):
1976 * src/modest-account-mgr-helpers.h:
1977 * src/modest-account-mgr.c:
1978 (modest_account_mgr_add_server_account):
1979 * src/modest-defs.h:
1980 * src/modest-tny-account.c:
1981 (modest_tny_account_new_from_server_account):
1982 Determine the options for tny_camel_account_add_option() here,
1983 based on the settings, rather than storing them directly in gconf.
1985 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1987 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1988 Show a more friendly error dialog now that we expect (from the tinymail
1989 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1991 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1993 * src/maemo/modest-main-window.c: (on_account_update): Check that
1994 account_name is not NULL, to prevent a crash at startup that I am
1995 seeing on the N800. I do wonder why it is NULL.
1997 * src/maemo/easysetup/modest-easysetup-wizard.c:
1998 (create_page_user_details):
1999 * src/maemo/modest-account-settings-dialog.c:
2000 (create_page_user_details), (create_page_outgoing):
2001 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2002 (modest_connection_specific_smtp_edit_window_init):
2003 * src/modest-ui-actions.c:
2004 (modest_ui_actions_on_password_requested):
2005 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2006 might do something useful with the on-screen keyboard.
2008 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2010 * src/maemo/modest-main-window.c: (on_account_update):
2011 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2012 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2014 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2016 * src/modest-tny-account-store.c: (on_account_changed):
2017 Correct the signature of this signal handler.
2019 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2021 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2022 Show a HildonNote instead of a GtkDialog for Maemo.
2024 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2026 * src/widgets/modest-account-view.h:
2027 * src/widgets/modest-account-view.c: (on_account_changed),
2028 (on_account_removed). Added a boolean flag, set/unset by
2029 modest_account_view_block_conf_updates(),
2030 modest_account_view_unblock_conf_updates() to prevent unnecessary
2031 updates, but this is not very useful because the gconf notifications are
2032 so delays (maybe only on Maemo Bora).
2033 So auto-updating is turned off, and these functions do an explicit
2034 update when necessary.
2035 However, something else is still doing too much work when adding/removing
2036 accounts, probably in another part of the application.
2038 * src/maemo/modest-account-view-window.c:
2039 (on_delete_button_clicked), (on_edit_button_clicked),
2040 (on_new_button_clicked): Use the new functions.
2042 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-account-mgr-helpers.c:
2045 (modest_account_mgr_set_first_account_as_default):
2046 Sort the list of names alphabetically-by-title, so we choose the first one
2048 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2049 alphabetically by the title.
2051 This fixes projects.maemo.org bug NB#56418 .
2053 * src/modest-account-mgr-priv.c:
2054 (_modest_account_mgr_account_from_key):
2055 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2056 avoid a valgrind error, and possible random behaviour.
2058 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2060 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2061 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2062 tinymail documentation to say that this can be expected.
2063 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2064 pretty, and should not happen, but I would prefer to know when it does.
2066 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2068 * configure.ac: When using the older hildon version, probably on Bora,
2069 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2071 * src/widgets/modest-attachment-view.c:
2072 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2075 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2077 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2078 Implemented the prototype. Can be tested with
2079 tests/dbus_api/test_open_message:
2081 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-account-store.c:
2084 (modest_tny_account_store_instance_init), (get_password):
2085 * src/modest-ui-actions.c:
2086 (modest_ui_actions_on_password_requested):
2087 Do not store the password in gconf, because this function is called
2088 for non-remembered passwords. Actually use the cached (in the hash map)
2089 password instead of releasing it.
2090 The password will now not be remembered if it is asked via the protected
2091 password dialog, as per the UI spec.
2093 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2095 * src/modest-defs.h:
2096 * src/modest-account-mgr-helpers.h:
2097 * src/modest-account-mgr-helpers.c:
2098 Added modest_server_account_get_username_has_succeeded(),
2099 modest_server_account_set_username_has_succeeded().
2100 (modest_server_account_set_username),
2101 Reset the has-succeeded flag if the username changes.
2103 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2104 * src/maemo/modest-connection-specific-smtp-window.c:
2105 (modest_connection_specific_smtp_window_save_server_accounts):
2106 Use modest_server_account_set_username() instead of using
2107 modest_conf_set_string() directly, so that the has-succeeded flag is always
2110 * src/modest-ui-actions.c:
2111 (modest_ui_actions_on_password_requested): Dim the username entry if
2112 the username has ever worked, as per the UI spec.
2114 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2116 * src/modest-tny-account-store.c: (get_password):
2117 * src/modest-ui-actions.c:
2118 (modest_ui_actions_on_password_requested):
2119 Allow the username to be changed too, though there is more work to
2120 be done on exactly how this behaves.
2122 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2124 * src/modest-account-mgr-helpers.h:
2125 * src/modest-account-mgr-helpers.c:
2126 Added modest_account_mgr_get_display_name(),
2127 modest_server_account_get_username(),
2128 modest_server_account_set_username(),
2129 modest_server_account_set_password(),
2130 modest_server_account_get_hostname() functions so we do not need to
2131 use the conf API directly.
2133 * src/maemo/modest-main-window.c: (connect_signals):
2134 Actually connect ot the ModestAccountStore::request-password signal,
2135 so that we show the dialog when the password is requested by Tinymail,
2136 for isntance if it is empty.
2138 * src/modest-marshal.list:
2139 * src/modest-tny-account-store.c:
2140 (modest_tny_account_store_class_init), (get_password),
2141 (modest_tny_account_store_alert):
2142 * src/modest-tny-account-store.h:
2143 * src/modest-ui-actions.h:
2144 * src/modest-ui-actions.c:
2145 (modest_ui_actions_on_password_requested):
2146 Change the signal parameters, so it is obvious that we are providing
2147 the non human-readable server name, and receiving both the username
2148 and password, though changing of the username is not yet implemented.
2149 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2150 for the GNOME version.
2152 This should fix the projects.maemo.org bug NB#56209, though it does not
2153 work on Bora, because the gconf_client_get() for the password fails
2154 immediately after we save it with gconf_client_set().
2156 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2159 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2160 caused an undefined symbol error:
2161 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2163 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2165 * src/modest-tny-account-store.c:
2166 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2167 using a GError instead of a string message, so we can translate it in
2170 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/modest-address-book.c:
2173 (modest_address_book_check_names):
2174 * src/maemo/modest-msg-view-window.c:
2175 (modest_msg_view_window_clipboard_owner_change):
2176 * src/modest-init.c: (modest_init_init_ui):
2177 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2178 (update_folders_cb), (modest_mail_operation_update_account):
2179 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2180 (modest_ui_actions_on_msg_attachment_clicked),
2181 (modest_ui_actions_on_msg_recpt_activated):
2182 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2183 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2184 (modest_msg_view_search_next):
2185 * src/widgets/modest-recpt-editor.c:
2186 (modest_recpt_editor_on_button_release_event),
2187 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2188 g_message(). At this point we should only be seeing interesting errors on
2189 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2191 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2193 (modest_wizard_dialog_force_title_update):
2194 * src/maemo/easysetup/modest-wizard-dialog.h:
2195 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2196 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2197 can update the title when appropriate. Otherwise the title is wrong if the
2198 pages are added after adding the notebook to the dialog.
2199 This must be a problem in HildonWizardDialog too.
2200 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2202 * src/maemo/easysetup/modest-easysetup-wizard.c:
2203 (create_subsequent_customsetup_pages),
2204 (create_subsequent_easysetup_pages):
2205 Call modest_wizard_dialog_force_title_update() so that the title is
2206 correct even with GTK+ < 2.10.
2207 This fixes projects.maemo.org bug NB#56145 .
2209 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2211 * src/maemo/modest-platform.c:
2212 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2213 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2216 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2218 * src/widgets/modest-window.h:
2219 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2220 and modest_window_save_state(), which invokes it.
2222 * src/widgets/modest-window-mgr.h:
2223 * src/widgets/modest-window-mgr.c:
2224 Added modest_window_mgr_save_state_for_all_windows(), which calls
2225 the save_state vfunc on all registered windows, if implemented.
2227 * src/gnome/modest-msg-edit-window.c:
2228 * src/gnome/modest-msg-view-window.c:
2229 * src/maemo/modest-msg-edit-window.c:
2230 * src/maemo/modest-msg-view-window.c:
2231 * src/maemo/modest-main-window.c:
2232 Specify the existing save_settings functions as implementations of
2233 ModestWindow::save_state_func().
2235 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2236 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2237 enabling hibernation, for instance.
2239 We may need to do the same thing for restoring settings.
2242 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2244 * src/widgets/modest-window-mgr.c:
2245 * src/widgets/modest-window-mgr.h:
2246 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2247 modest_window_mgr_get_hibernation_is_prevented().
2249 * src/maemo/modest-main-window.c:
2250 (on_hildon_program_is_topmost_notify): Prevent hibernation
2251 (possible when the application goes to the background in the WM),
2252 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2254 * src/maemo/easysetup/modest-easysetup-wizard.c:
2255 (modest_easysetup_wizard_dialog_init):
2256 * src/maemo/modest-account-settings-dialog.c:
2257 (modest_account_settings_dialog_init):
2258 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2259 (modest_connection_specific_smtp_edit_window_init):
2260 * src/maemo/modest-connection-specific-smtp-window.c:
2261 (modest_connection_specific_smtp_window_init):
2262 * src/maemo/modest-signature-editor-dialog.c:
2263 (modest_signature_editor_dialog_init):
2264 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2265 prevent hibernation while any of these account settings dialogs are open.
2267 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/Makefile.am:
2270 * src/maemo/modest-osso-state-saving.c:
2271 * src/maemo/modest-osso-state-saving.h: Added
2272 modest_osso_load_state() and modest_osso_save_state() though they do
2273 nothing now. They should iterate through all the open windows and load/save
2275 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2276 save state when closing.
2278 * src/maemo/modest-main-window.c:
2279 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2280 Add a notification handler for the HildonProgram::is-topmost property,
2281 so we can allow hibernation when the application goes into the background.
2282 But we still need to detect when the accounts setup windows are open so
2283 we can stop hibernation when they are open.
2284 To do this, I also added the main window the HildonProgram. This might have
2285 other side-effects/benefits, and should maybe be done for other windows.
2287 * src/maemo/modest-osso-autosave-callbacks.h:
2288 * src/maemo/modest-osso-autosave-callbacks.c:
2289 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2290 though it does not do anything yet, and we might never need this to do
2291 anything. For instance, we already save drafts.
2293 * src/maemo/modest-platform.c: (modest_platform_init):
2294 Specify the libosso auto-save callback.
2296 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2298 * src/maemo/modest-platform.c:
2299 (modest_platform_set_update_interval):
2300 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2301 aparently stays valid between application instances, so we can use this
2302 to remove and reset it later. According to a maemo-developers email from
2305 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2307 * configure.ac: Depend on libalarm for Maemo.
2309 * src/dbus_api/modest-dbus-api.h:
2310 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2311 (on_send_receive), (modest_dbus_req_handler):
2312 Handle a SEND_RECEIVE D-Bus method.
2314 * libmodest-dbus-client/libmodest-dbus-client.c:
2315 (libmodest_dbus_client_send_and_receive):
2316 * libmodest-dbus-client/libmodest-dbus-client.h:
2317 Add C convenience functions for calling the new D-Bus method.
2319 * src/modest-platform.h:
2320 * src/gnome/modest-platform.c:
2321 * src/maemo/modest-platform.c:
2322 Added modest_platform_set_update_interval(), which uses the
2323 alarmd API on Maemo.
2324 (modest_platform_init),
2325 Call modest_platform_set_update_interval(), using a hard-coded
2326 interval for now (until the global settings dialog is implemented),
2327 though I am not sure that this makes sense yet.
2329 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2331 * src/dbus_api/modest-dbus-callbacks.c:
2332 (modest_osso_cb_hw_state_handler):
2333 * src/dbus_api/modest-dbus-callbacks.h:
2334 * src/maemo/modest-platform.c: (modest_platform_init):
2335 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2336 in case this has some effect on the ability for Maemo to ping the
2339 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2341 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2342 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2343 warning. It is probably a logic error, but I need to fix the build.
2345 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2347 * src/modest-account-mgr.h:
2348 * src/modest-account-mgr.c:
2349 (modest_account_mgr_account_names): Add a gboolean enabled_only
2350 parameter, so we can get lists of onlt the enabled accounts.
2352 (modest_account_mgr_add_account),,
2353 (modest_account_mgr_account_with_display_name_exists):
2354 * src/maemo/modest-msg-edit-window.c: (get_transports):
2355 * src/modest-account-mgr-helpers.c:
2356 (modest_account_mgr_set_first_account_as_default):
2357 * src/modest-init.c: (init_default_account_maybe):
2358 * src/modest-tny-account-store.c: (get_accounts):
2359 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2360 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2361 * tests/check_account-mgr.c: (START_TEST):
2362 Provide the extra parameter, as appropriate.
2364 * src/widgets/modest-account-view.c: (update_account_view):
2365 Do not show disabled accounts (meaning that there is no way to
2366 enable/disable accounts in the UI (the feature is not in our UI
2367 specification), so we can use this internally only to mark unfinished
2368 or temporary account data.
2370 * src/maemo/easysetup/modest-easysetup-wizard.c:
2371 (create_account): Add boolean enable parameter, so we can specify FALSE
2372 to create the temporary account.
2373 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2374 (on_before_next): When finishing, when there is a temporary account, just
2376 Also, use a timeout to delay the showing of the dialog until gconf is likely
2377 to return correct information, due to a maemo gconf bug that is fixed in
2378 osso 1.1, but not yet in Bora.
2379 However, the dialog stays on screen after it is destroyed.
2381 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2382 for invalid data when cancelling. Use a hildon note instead of a dialog
2383 to complain about invalid data. Do not show the account-saved note if the
2384 account is disabled (a temporary account that will not really be saved for use
2387 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2389 * src/modest-account-mgr-helpers.h:
2390 * src/modest-account-mgr-helpers.c:
2391 Added modest_account_mgr_unset_default_account(),
2392 Added modest_account_mgr_set_first_account_as_default().
2394 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2395 If it was the default account, unset the default account name.
2397 * src/maemo/modest-account-view-window.c:
2398 (on_delete_button_clicked): If it was the default account,
2399 set the first remaining account as the default instead.
2401 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2402 a NULL account or a NULL default account, to prevent a crash. This should
2403 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2406 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2408 * src/widgets/modest-recpt-editor.c:
2409 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2410 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2411 TODO comment for this. This fixes the build.
2413 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2414 be the best place for it. This will in future update all auto-update accounts,
2415 rather than just the current/default account, when that gconf key exists.
2416 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2417 if there are no accounts, before calling do_send_receive().
2418 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2420 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2421 * src/maemo/modest-main-window-ui.h:
2422 * src/maemo/modest-main-window.c: (on_connection_changed),
2423 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2424 directly, becaue the signal handler does more.
2426 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2428 * src/modest-account-mgr-helpers.c:
2429 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2430 for the case that the account does not exist.
2432 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2433 (equivalent to the modest account name) rather than the tinymail account name
2434 (equivalent to the modest account title - human readable) to get the account data.
2435 Check for null account data to prevent the crash, and add a TODO comment saying that
2436 this needs fixing because it is using the server account name instead of the account name.
2438 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2440 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2441 * src/maemo/modest-account-settings-dialog.c: (show_error),
2443 Use hildon_note_new_information() for informative and error messages,
2444 which seems to be expected for Maemo applications (no documentation that I know of
2445 says this). I am surprised that there is no distinction between info and error
2448 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2451 it is easy to find where this is used.
2453 * src/maemo/easysetup/modest-easysetup-wizard.c:
2454 (create_page_welcome), (create_page_account_details),
2455 (create_page_user_details), (create_page_complete_easysetup),
2456 (create_page_custom_incoming), (create_page_custom_outgoing),
2457 (create_page_complete_custom):
2458 * src/maemo/modest-account-settings-dialog.c:
2459 (create_page_account_details), (create_page_user_details),
2460 (create_page_incoming), (create_page_outgoing):
2461 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2462 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2463 (modest_connection_specific_smtp_edit_window_init):
2464 * src/maemo/modest-connection-specific-smtp-window.c:
2465 (modest_connection_specific_smtp_window_init):
2466 * src/maemo/modest-signature-editor-dialog.c:
2467 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2468 and scrolling policy as per the Email Application Layout Guide, if I have
2471 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2473 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2474 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2475 which were empty, because these vfuncs have been removed from TnyAccountStore.
2476 This fixes the build.
2478 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2480 * src/maemo/modest-main-window.c:
2481 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2482 showing/hiding it. Added TODO because it probably should not be NULL.
2483 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2484 because unnecessary g_warnings() make degugging difficult.
2486 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2488 * src/maemo/modest-msg-edit-window.c:
2489 (modest_msg_edit_window_select_color),
2490 (modest_msg_edit_window_select_background_color): 2 const corrections and
2491 moving 2 #endifs before closing brackets, to fix the build.
2493 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2495 * src/maemo/easysetup/modest-easysetup-wizard.h:
2496 * src/maemo/easysetup/modest-easysetup-wizard.c:
2497 (modest_easysetup_wizard_dialog_finalize),
2498 (on_button_edit_advanced_settings), (create_page_complete_custom),
2499 (on_response), (create_account):
2500 Implement the Advanced Settings edit button, by saving the account information,
2501 for the Advanded Settings dialog to use directly from gconf, and removing it
2502 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2503 Bug #5533 in the projects.maemo.org bugzilla.
2505 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2507 * src/maemo/modest-msg-view-window.c:
2508 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2509 when opening a message window.
2511 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/easysetup/modest-easysetup-wizard.c:
2514 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2517 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2518 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2519 gconf settings. I probably added more checks than necessary, but that is safer.
2521 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2522 variable to fix the build, but this seems to be used when it is still NULL.
2524 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2526 * src/modest-platform.h:
2527 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2528 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2529 * src/modest-main.c: Implement this function so we can avoid using
2530 maemo-specific API from cross-platform code.
2532 * src/modest-tny-account-store.c:
2533 (get_smtp_specific_transport_account_for_open_connection):
2534 * src/modest-ui-actions.c: (check_for_connection),
2535 (modest_ui_actions_on_item_not_found):
2536 Use modest_platform_connect_and_wait() and put #idefs around other
2537 maemo-specific code, because only maemo currently has a way to
2538 identify connection names.
2540 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2542 * src/modest-tny-account-store.h:
2543 * src/modest-tny-account-store.c:
2544 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2545 the connection-specific SMTP server settings in the configuration.
2547 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2549 * src/maemo/modest-main-window.c: (on_connection_changed),
2551 * src/modest-main.c: (main), (start_ui), (send_mail):
2552 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2553 that is what is intended.
2555 * src/modest-ui-actions.c: (action_send), (action_receive),
2556 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2557 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2558 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2559 SMTP server is used when it is specified.
2561 (modest_ui_actions_on_send_receive):
2562 Check that a connection is open before proceeding.
2563 Receive and then send, instead of vice-versa, as per the specification.
2565 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2567 * src/modest-mail-operation.c:
2568 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2569 though I guess it should be something other than NULL.
2571 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2573 * src/maemo/easysetup/modest-easysetup-wizard.c:
2574 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2575 combo twice, to avoid an g_warning and to make it visible again.
2576 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2577 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2578 (already intended) dereference when detaching, because we then recreate the menu.
2579 But I am not sure why the warning was happening, and it is possible that this is a memory
2582 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2584 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2585 and uri_parse_mailto() utility functions.
2586 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2588 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2590 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2592 * src/dbus_api/modest-dbus-api.h:
2593 * src/dbus_api/modest-dbus-callbacks.c:
2594 Use an idle callback to execute the modest code in the application's own thread.
2595 Remove the helloworld example method.
2596 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2597 parsed, and the open-message method is not implemented because this is not yet implemented in
2599 * libmodest-dbus-client/libmodest-dbus-client.c:
2600 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2601 (libmodest_dbus_client_open_message):
2602 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2604 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2605 body without crashing.
2607 * tests/dbus_api/Makefile.am:
2608 * tests/dbus_api/test_mail_to.c:
2609 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2611 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2613 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2614 Added file to fix the build. Sorry.
2616 * src/dbus_api/Makefile.am:
2617 * src/dbus_api/modest-dbus-api.h:
2618 * src/dbus_api/modest-dbus-callbacks.h:
2619 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2620 (modest_dbus_req_handler):
2621 Put constants in a separate header so it can be reused by the
2622 client library, without duplication
2624 * libmodest-dbus-client/Makefile.am:
2625 * libmodest-dbus-client/libmodest-dbus-client.c:
2626 (libmodest_dbus_client_call_helloworld),
2627 (libmodfest_dbus_client_send_mail),
2628 (libmodfest_dbus_client_mailto),
2629 (libmodfest_dbus_client_open_message):
2630 * libmodest-dbus-client/libmodest-dbus-client.h:
2631 (Partly) Implement a send_mail D-Bus method.
2633 * tests/dbus_api/Makefile.am:
2634 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2635 the send_email D-Bus method.
2637 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2641 * libmodest-dbus-client/Makefile.am:
2642 * libmodest-dbus-client/libmodest-dbus-client.c:
2643 * libmodest-dbus-client/libmodest-dbus-client.h:
2644 * tests/dbus_api/Makefile.am:
2645 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2646 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2648 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2650 * src/maemo/easysetup/modest-easysetup-wizard.c:
2651 (create_page_account_details):
2652 * src/maemo/modest-account-settings-dialog.c:
2653 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2654 widgets, because this might not be the default in future versions of the Maemo GTK+.
2655 However, I can not not get capitalization to work even in a simple test case.
2657 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/easysetup/modest-easysetup-wizard.c:
2660 (create_page_custom_incoming), (create_page_custom_outgoing):
2661 * src/maemo/modest-account-settings-dialog.c:
2662 (create_page_account_details), (create_page_incoming),
2663 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2664 instead of using gtk_check_button_with_label(), so they are aligned like the other
2665 widgets, as per the UI spec.
2667 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2669 * src/maemo/easysetup/modest-easysetup-wizard.c:
2670 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2671 * src/widgets/modest-validating-entry.c:
2672 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2673 Modest prefix instead of an EasySetup prefix.
2675 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2677 * src/widgets/modest-validating-entry.h:
2678 * src/widgets/modest-validating-entry.c: (on_insert_text),
2679 Added easysetup_validating_entry_set_max_func(), used to set a callback
2680 to call when the max number of characters is reached. GtkEntry has a max-length
2681 already but is silent about it.
2683 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2684 (create_page_account_details), (create_page_user_details),
2686 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2687 (create_page_account_details), (create_page_user_details),
2688 (create_page_outgoing):
2689 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2690 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2691 the UI spec, when the user tries to enter more than the max number of characters.
2693 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2695 * src/maemo/easysetup/modest-easysetup-wizard.c:
2696 (create_page_user_details), (create_page_custom_incoming),
2697 (create_page_custom_outgoing):
2698 * src/maemo/modest-account-settings-dialog.c:
2699 (create_page_user_details), (create_page_incoming),
2700 (create_page_outgoing):
2701 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2702 (modest_connection_specific_smtp_edit_window_init):
2703 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2704 not appropriate. Bad Maemo-specific defaults!.
2706 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2708 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2709 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2710 (modest_signature_editor_dialog_set_settings):
2711 Disable the label and textview when the checkbox is disabled, and use the
2712 specified (UI spec) default signature text.
2714 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2716 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2717 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2719 * src/modest-defs.h:
2720 * src/modest-account-mgr-helpers.h:
2721 * src/modest-account-mgr-helpers.c:
2722 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2724 * src/maemo/Makefile.am:
2725 * src/maemo/modest-signature-editor-dialog.c:
2726 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2729 * src/maemo/modest-account-settings-dialog.h:
2730 * src/maemo/modest-account-settings-dialog.c:
2731 (modest_account_settings_dialog_finalize), (on_button_signature),
2732 (save_configuration): Use the new dialog when the Edit button is pressed, and
2733 save the changes if necessary, as per the UI spec.
2735 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2737 * src/maemo/Makefile.am:
2738 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2739 based on maemo-develoers email from Dirk.
2741 * src/maemo/easysetup/modest-easysetup-wizard.c:
2742 (create_page_welcome), (create_page_account_details),
2743 (create_page_user_details), (create_page_complete_easysetup),
2744 (create_page_custom_incoming), (create_page_custom_outgoing),
2745 (create_page_complete_custom),
2746 (modest_easysetup_wizard_dialog_init):
2747 * src/maemo/modest-account-settings-dialog.c:
2748 (create_page_account_details), (create_page_user_details),
2749 (create_page_incoming), (create_page_outgoing),
2750 (modest_account_settings_dialog_init):
2751 * src/maemo/modest-connection-specific-smtp-window.c:
2752 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2754 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2756 * src/maemo/easysetup/modest-easysetup-wizard.c:
2757 (create_page_account_details), (create_page_custom_outgoing),
2758 (create_page_complete_custom):
2759 * src/maemo/modest-account-settings-dialog.c:
2760 (create_page_user_details), (create_page_incoming),
2761 (create_page_outgoing):
2762 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2763 (modest_connection_specific_smtp_edit_window_init):
2764 Use the correct (UI spec) port min/max, and use horizontal separators,
2767 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/easysetup/modest-easysetup-wizard.c:
2770 (set_default_custom_servernames):
2771 * src/maemo/modest-account-settings-dialog.c:
2772 (create_page_incoming), (on_combo_outgoing_security_changed),
2773 (on_combo_incoming_security_changed), (create_page_outgoing),
2774 (modest_account_settings_dialog_set_account_name),
2775 (save_configuration):
2776 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2777 (on_combo_security_changed),
2778 (modest_connection_specific_smtp_edit_window_init),
2779 (modest_connection_specific_smtp_edit_window_set_connection),
2780 (modest_connection_specific_smtp_edit_window_get_settings):
2781 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2784 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c:
2788 (create_page_custom_outgoing), (create_page_complete_custom):
2789 * src/maemo/modest-account-settings-dialog.c:
2790 (create_page_user_details), (create_page_outgoing):
2791 * src/maemo/modest-account-view-window.c: (button_box_new):
2792 Use changed logical IDs as per the most recent UI spec:
2793 mcen_bd_emailsetup_edit -> mcen_bd_edit
2794 mcen_bd_emailsetup_delete -> mcen_bd_delete
2795 mcen_bd_emailsetup_close -> mcen_bd_close
2797 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2801 * src/dbus_api/Makefile.am:
2802 * src/dbus_api/modest-dbus-callbacks.c:
2803 * src/dbus_api/modest-dbus-callbacks.h:
2804 * src/maemo/modest-platform.c: (modest_platform_init):
2805 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2807 * tests/Makefile.am:
2808 * tests/dbus_api/Makefile.am:
2809 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2811 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2813 * src/maemo/modest-account-settings-dialog.c:
2814 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2815 Removed unnecessary includes.
2817 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2819 * src/maemo/easysetup/modest-easysetup-wizard.c:
2820 * src/maemo/modest-account-settings-dialog.c:
2821 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2822 * src/widgets/Makefile.am:
2823 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2824 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2825 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2826 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2827 * src/widgets/modest-secureauth-combo-box.c:
2828 * src/widgets/modest-secureauth-combo-box.h:
2829 * src/widgets/modest-serversecurity-combo-box.c:
2830 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2831 made the GObject names more consistent with the rest of the Modest code.
2833 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2835 * src/maemo/easysetup/Makefile.am:
2836 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2837 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2838 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2839 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2840 * src/maemo/easysetup/modest-easysetup-wizard.c:
2841 * src/maemo/easysetup/modest-validating-entry.c:
2842 * src/maemo/easysetup/modest-validating-entry.h:
2843 * src/maemo/modest-account-settings-dialog.c:
2844 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2845 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2846 widgets/ because they are used outside of easysetup too. After checking in,
2847 svn will allow me to rename them too.
2849 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2851 * src/gnome/modest-msg-edit-window.c:
2852 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2853 linker error, to fix the build on the GNOME platform.
2854 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2855 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2856 ifdefed out to avoid a warning.
2858 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2860 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2861 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2862 some alternative for GTK+ 2.6.
2864 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2866 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2868 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2869 specified for EmailAccountsDialog in UI spec.
2871 * src/maemo/easysetup/modest-easysetup-wizard.c:
2872 * src/maemo/easysetup/modest-easysetup-wizard.h:
2873 * src/maemo/modest-account-settings-dialog.c:
2874 * src/maemo/modest-account-settings-dialog.h:
2875 Reuse a member window widget for the connection-specific SMTP server accounts,
2876 so we can tell it to create/save the accounts only if we actually save changes.
2878 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2880 (modest_connection_specific_smtp_edit_window_get_settings):
2881 Return a struct instance for temporarily remembering the entered data.
2883 * src/maemo/modest-connection-specific-smtp-window.h:
2884 * src/maemo/modest-connection-specific-smtp-window.c:
2885 (modest_connection_specific_smtp_window_finalize),
2886 (modest_connection_specific_smtp_window_fill_with_connections),
2888 (modest_connection_specific_smtp_window_save_server_accounts),
2889 (update_model_server_names): Do not actually save data until asked,
2890 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2892 (on_selection_changed),
2893 (modest_connection_specific_smtp_window_init): Disable the edit
2894 button when nothing is selected.
2896 * src/modest-account-mgr-helpers.c:
2897 * src/modest-account-mgr-helpers.h:
2898 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2901 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2903 * src/modest-account-mgr-helpers.h:
2904 * src/modest-account-mgr-helpers.c:
2905 (modest_account_mgr_get_unused_account_name),
2906 (modest_account_mgr_get_unused_account_display_name): Added these
2907 utility functions, to avoid code duplication.
2909 * src/maemo/easysetup/modest-easysetup-wizard.c:
2910 (create_page_account_details), (create_account):
2911 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2912 (on_combo_security_changed),
2913 (modest_connection_specific_smtp_edit_window_init),
2914 (modest_connection_specific_smtp_edit_window_save_settings):
2915 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2916 * src/maemo/modest-connection-specific-smtp-window.c:
2917 (modest_connection_specific_smtp_window_finalize),
2918 (modest_connection_specific_smtp_window_fill_with_connections),
2919 (on_button_edit), (modest_connection_specific_smtp_window_init):
2920 * src/maemo/modest-connection-specific-smtp-window.h:
2921 Implementing saving of connection-specific server accounts.
2923 But I need to refactor this so we can save the data for each
2924 possible connection-specific account and only actually create the server accounts
2925 when the easysetup finished, or the OK button is pressed on the account settings
2928 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2930 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2931 (on_combo_security_changed):
2932 (modest_connection_specific_smtp_edit_window_init):
2933 Auto-fill the port number as in the account settings.
2935 (modest_connection_specific_smtp_edit_window_set_connection):
2936 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2937 * src/maemo/modest-connection-specific-smtp-window.c:
2938 (fill_with_connections), (on_button_edit),
2939 (modest_connection_specific_smtp_window_init):
2940 Turn the edit window into a dialog to simplify the code, and
2941 set a WM hint as in a GtkDialog, because only a popup can be on top of
2942 another window in Maemo, and popups usually have no WM decoration.
2944 * src/modest-defs.h:
2945 * src/modest-account-mgr-helpers.c:
2946 (modest_account_mgr_set_connection_specific_smtp),
2947 (modest_account_mgr_remove_connection_specific_smtp),
2948 (modest_account_mgr_get_connection_specific_smtp):
2949 * src/modest-account-mgr-helpers.h: Some functions to write the
2950 connection-specific SMTP server information. Not yet used.
2953 * src/widgets/modest-folder-view.c: (text_cell_data):
2954 Fix a warning about an uninitialized variable.
2955 (on_configuration_key_changed): Put an #ifdef around the use
2956 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2958 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2960 * src/maemo/modest-account-settings-dialog.h:
2961 * src/maemo/modest-account-settings-dialog.c:
2962 Added connect_for_modified() utility function to mark the new modified boolean.
2964 (create_page_account_details), (create_page_user_details),
2965 (create_page_incoming), (create_page_outgoing), (on_response),
2966 (modest_account_settings_dialog_init),
2967 (modest_account_settings_dialog_set_account_name):
2968 Only warn about unsaved changes when there are actually unsaved changes.
2970 * src/modest-account-mgr-helpers.c:
2971 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2972 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2973 to get the data from there in future.
2975 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2977 * src/modest-defs.h:
2979 * src/modest-account-mgr-helpers.h:
2980 * src/modest-account-mgr-helpers.c:
2981 Store the security account setting in a single conf key instead of using
2982 the options list, so that the list is left for just the to-be-removed camel hack,
2983 and because gconf_client_set_list() is failing for some reason.
2985 * src/modest-account-mgr.c:
2986 (modest_account_mgr_add_server_account):
2987 * src/maemo/modest-account-settings-dialog.c:
2988 (modest_account_settings_dialog_set_account_name),
2989 (save_configuration): Use the renamed functions.
2992 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2994 * src/widgets/Makefile.am:
2995 * src/widgets/modest-limit-retrieve-combo-box.c:
2996 * src/widgets/modest-limit-retrieve-combo-box.h:
2997 * src/widgets/modest-retrieve-combo-box.c:
2998 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2999 the account settings dialog.
3001 * src/modest-defs.h:
3002 * src/modest-account-mgr-helpers.h:
3003 * src/modest-account-mgr-helpers.c:
3004 (modest_server_account_get_option_secure_auth),
3005 (modest_server_account_set_option_secure_auth):
3006 * src/modest-account-mgr.c:
3007 (modest_account_mgr_add_server_account):
3008 Use the existing AUTH_MECH conf key for the secure-auth setting,
3009 instead of putting it in the list options, because this was actually used already.
3011 * src/maemo/modest-account-settings-dialog.c:
3012 (create_page_account_details),
3013 (modest_account_settings_dialog_set_account_name),
3014 (save_configuration):
3015 * src/maemo/modest-account-settings-dialog.h:
3016 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3017 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3019 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3022 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3023 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3025 * src/modest-defs.h:
3026 * src/maemo/modest-account-settings-dialog.c:
3027 (create_page_incoming), (on_combo_outgoing_security_changed),
3028 (on_combo_incoming_security_changed), (create_page_outgoing),
3029 (modest_account_settings_dialog_set_account_name),
3030 (save_configuration): Load/Save the port number, and change it when the
3031 security combo changes, to suitable defaults.
3033 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3035 * src/modest-account-mgr.c:
3036 (modest_account_mgr_add_server_account): Set the security and secure-auth
3037 options, and add a comment saying that the other camel-specific options should be
3040 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3042 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3044 * src/modest-tny-account-store.c: (account_list_free),
3045 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3046 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3049 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-protocol-info.c:
3052 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3053 is required by our UI spec. Maybe something in our implementation will use this eventually.
3054 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3055 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3056 instead of the previous 0 placeholder.
3058 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3059 secure-auth settings.
3060 * src/modest-account-mgr-helpers.h:
3061 * src/modest-account-mgr-helpers.c:
3062 (modest_server_account_data_get_option_secure_auth),
3063 (modest_server_account_set_option_secure_auth),
3064 (modest_server_account_data_get_option_security),
3065 (modest_server_account_set_option_security): Added this API for getting and setting the security
3066 and secure-auth settings.
3068 * src/maemo/modest-account-settings-dialog.h:
3069 * src/maemo/modest-account-settings-dialog.c:
3070 (modest_account_settings_dialog_finalize), (check_data),
3071 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3072 about changing titles.
3073 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3074 (save_configuration): Save the security and secure-auth settings.
3076 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3077 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3079 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3081 * src/modest-defs.h:
3082 * src/modest-account-mgr.c:
3083 (modest_account_mgr_add_server_account):
3084 Added and used defines for the options key and value pair strings,
3085 that are used so far, though they do not seem to correspond to anything in our
3086 UI specs or ModestProtocol enum.
3088 * src/modest-account-mgr-helpers.h:
3089 * src/modest-account-mgr-helpers.c:
3090 (compare_option_strings_for_name),
3091 (modest_server_account_data_get_option_value),
3092 (modest_server_account_data_get_option_bool),
3093 (modest_account_mgr_get_server_account_option):
3094 Added helper functions for parsing the options GSList.
3096 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3098 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3099 display name is based on the supplied account name.
3100 * src/modest-account-mgr.c:
3101 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3102 with an inefficient, but good-enough, implementation.
3104 * src/maemo/easysetup/modest-easysetup-wizard.c:
3105 (create_page_account_details), (on_before_next), (create_account):
3106 Check for existing display names rather than (non-user-visible) account names, and just
3107 create and set a unique account name at the end.
3109 * src/maemo/modest-account-settings-dialog.c:
3110 (modest_account_settings_dialog_init),
3111 (modest_account_settings_dialog_set_account_name),
3112 (create_page_incoming): Show the display name, instead of the account name.
3113 (on_response): Do some (not all) extra checks, as in the UI spec.
3114 (save_configuration): Save the display name if it was changed.
3116 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3118 * po/en_GB.po: Added needed logical ID and translation.
3119 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3120 (init_view): Made the is-default column clicking work.
3122 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3125 * src/maemo/easysetup/Makefile.am:
3126 * src/maemo/easysetup/modest-easysetup-wizard.c:
3127 (modest_easysetup_wizard_dialog_init):
3128 * src/maemo/easysetup/provider-data-test.keyfile:
3129 * src/maemo/easysetup/provider-data.keyfile:
3130 Moved the provider data file to the new modest-providers-data package and used it from there.
3132 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3134 * src/modest-local-folder-info.c:
3135 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3136 N_() was already used on the static strings, but this just marks it for translation without
3137 using the translation.
3139 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3141 * src/maemo/modest-account-settings-dialog.c:
3142 (create_page_incoming),
3143 (modest_account_settings_dialog_set_account_name):
3144 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3145 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3146 I will do this if nobody else gets there first.
3148 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3151 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3152 save the security stuff.
3154 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3156 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3157 Set the email address and user fullname, which I now see must be
3160 * src/maemo/modest-account-settings-dialog.h:
3161 * src/maemo/modest-account-settings-dialog.c:
3163 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3164 leave-on-server and authentication.
3165 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3168 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3171 * src/maemo/modest-account-settings-dialog.c:
3172 * src/maemo/modest-account-settings-dialog.h:
3173 Most (but not all) of the widgets are now present as specified by the UI spec.
3174 No changes are yet saved, and some details are not properly shown yet.
3176 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3178 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3180 * src/maemo/Makefile.am:
3181 * src/maemo/modest-account-settings-dialog.c:
3182 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3183 an existing account. Doesn't do much yet.
3185 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3186 Open the accounts settings dialog when Edit is clicked.
3188 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3190 * src/maemo/easysetup/Makefile.am:
3191 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3193 * src/maemo/easysetup/modest-easysetup-wizard.c:
3194 (modest_easysetup_wizard_dialog_init):
3195 Try to get the source directory from the build system,
3196 instead of hard-coding "./" into the source code, when opening our local
3197 copies of the configuration files.
3198 But this still fails when opening the wizard from the Accounts window,
3199 maybe because the working directory seems to change at runtime.
3200 So the wizard will fail the second time unless you copy the files into their
3201 proper locations - see the stdout warnings for the paths.
3203 (create_page_account_details),(on_before_next):
3204 Check for existing non-server accounts instead of server accounts,
3205 so the default account name is useful again, and to prevent trying to
3208 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3209 Show the wizard when New is clicked.
3211 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3212 (init_view): Show the column headers, and show the columns that are
3213 specified in the UI specs. However, something in Maemo's GTK+ prevents
3214 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3215 change the default account. This is despite unsetting the special properties.
3217 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3219 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3220 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3221 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3222 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3223 to make that clearer.
3224 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3226 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3228 * src/maemo/modest-account-view-window.c:
3229 (modest_account_view_window_init),
3230 (modest_account_view_window_new):
3231 Use the same buttons as specified in the
3232 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3233 the existing widgets, which never had a chance of working.
3234 Put the ModestAccountView treeview in a scrolled window.
3235 Do not repeat the initialization in both _init() and _new().
3237 * src/widgets/modest-account-view.c: (update_account_view):
3238 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3239 this widget and window shows no accounts.
3241 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3243 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3245 * src/maemo/easysetup/modest-easysetup-wizard.c:
3246 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3247 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3248 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3251 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3252 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3253 accounts exist yet, as in the UI spec.
3255 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3257 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3259 * src/maemo/Makefile.am:
3260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3261 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3262 New window for editing connection-specific smtp details.
3263 Not fully implemented.
3265 * src/maemo/modest-connection-specific-smtp-window.c:
3266 (modest_connection_specific_smtp_window_finalize) :
3267 unref the tree model.
3268 (on_button_edit): Show the edit window.
3270 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3272 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3275 * src/maemo/Makefile.am:
3276 * src/maemo/modest-connection-specific-smtp-window.c:
3277 * src/maemo/modest-connection-specific-smtp-window.h:
3278 New window for showing the list of connections, for connection-specific
3279 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3280 * src/maemo/easysetup/modest-easysetup-wizard.c:
3281 (create_page_custom_outgoing): Show the new window when the button is clicked.
3283 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3285 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3286 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3287 * src/maemo/modest-msg-edit-window.c:
3288 (modest_msg_edit_window_insert_image):
3289 * src/modest-conf.c: (modest_conf_key_escape):
3290 * src/modest-mail-operation.c:
3291 (modest_mail_operation_send_new_mail):
3292 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3293 (modest_ui_actions_on_new_account):
3294 * src/widgets/modest-attachment-view.c: (update_filename_request):
3295 * src/widgets/modest-mail-header-view.c:
3296 Corrected warnings that were breaking the build, by commenting out unused variables,
3297 and a function, and by including a header.
3299 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3301 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3302 so we can #ifdef around platform-specific code when necessary.
3303 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3304 to allow this to build for the GNOME platform too.
3306 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3308 * src/maemo/easysetup/modest-easysetup-wizard.c:
3309 Added util_increment_name() and used it in create_page_account_details()
3310 to make sure that the default account name is always a new name.
3312 (modest_easysetup_wizard_dialog_init),
3313 (set_default_custom_servernames): Some minor memory management fixes.
3315 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3319 * src/modest-runtime.c: (init_i18n): Restored the translation
3320 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3321 are defined in config.h, and the translations are installed.
3323 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3324 is defined for translation.
3326 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3328 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3330 * src/maemo/easysetup/modest-easysetup-wizard.c:
3331 (modest_easysetup_wizard_dialog_init):
3332 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3333 Use realistic paths (though they should use $prefix generically) to the
3334 mcc_mapping and provider-data.keyfile files which might work when they
3335 are installed by the future version of the operator-wizard package,
3336 and then fallback to paths in our source code, with an explanatory
3339 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3343 * src/maemo/Makefile.am:
3344 * src/maemo/easysetup/: Added files from the previously-exernal
3345 osso-modest-easysetup.
3346 * src/maemo/modest-main-window-ui.h:
3347 * src/modest-ui-actions.c:
3348 * src/modest-ui-actions.h:
3349 Added modest_ui_actions_on_new_account() as a signal handler for the
3350 New Account menu item. It shows the easysetup wizard.
3351 * po/en_GB.po: Added additional needed logical IDs and translations.