1 2007-06-20 Murray Cumming <murrayc@murrayc.com>
3 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
5 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
6 Better debug message when the folder cannot be found.
7 This should help with fixing projects.maemo.org bug #61287.
8 * src/modest-search.c: (add_hit): Do not leak the furl string.
10 2007-06-20 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-ui-actions.c:
13 (modest_ui_actions_on_folder_selection_changed):
14 Do not special-case TNY_MERGE_FOLDER here, because
15 modest_tny_folder_get_account() already does that. This fixes
16 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
17 shown when the Outbox was selected).
19 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
21 * libmodest-dbus-client/libmodest-dbus-client.c:
22 (_dbus_iter_get_string_or_null): Initialize the string variable in
23 case this helps with Dirk's crash.
25 2007-06-19 Murray Cumming <murrayc@murrayc.com>
27 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
28 though it is not implemented yet (this function is maybe not even used),
29 to avoid breaking ABI in future.
30 * libmodest-dbus-client/libmodest-dbus-client.c:
31 (get_attachments_string): Moved some code into this generic function.
32 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
33 sends email. It is maybe not used.
34 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
35 (on_send_mail): Use attachments.
37 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
38 * src/maemo/modest-msg-edit-window.c:
39 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
40 a filename before using it, to fix projects.maemo.org bug NB#58233.
42 2007-06-19 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
45 Initialize the continue_download variable to fix the build, and probably
46 to fix randome behaviour.
48 2007-06-18 Armin Burgmeier <armin@openismus.com>
50 * src/modest-tny-send-queue.h:
51 * src/modest-tny-send-queue.c: Keep track of the status of messages in
52 the queue so we can later show it in the UI. Replaced
53 modest_tny_send_queue_msg_is_being_sent() by
54 modest_tny_send_queue_get_msg_status().
56 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
58 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
59 gpointer. This probably was not harmful, but just to be sure.
61 2007-06-18 Murray Cumming <murrayc@murrayc.com>
63 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
64 Fix the build, but leave the function broken on Bora, because
65 hildon_uri_action_get_service() does not exist.
66 osso_uri_action_get_service() does not exist either, it seems.
68 2007-06-18 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account.c:
71 (modest_tny_account_new_from_server_account):
72 Uncommented the url debug output again, because it is useful for
73 debugging, as I said in the comment.
75 2007-06-18 Murray Cumming <murrayc@murrayc.com>
77 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
79 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
80 for Mameo Bora, to fix the build.
82 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
85 Fixed build with hildon < 0.99
87 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
88 Check if the selected account is busy instead of checking all accounts
90 * src/modest-account-mgr-priv.h:
91 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
92 (modest_account_mgr_init), (compare_account_name),
93 (modest_account_mgr_set_account_busy),
94 (modest_account_mgr_account_is_busy):
95 * src/modest-account-mgr.h:
96 Added busy information to the account manager. It possible to
97 set an account to busy or not busy now.
99 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
100 (modest_mail_operation_update_account),
101 (modest_mail_operation_notify_end):
102 Set the account to busy/not busy depending on the operation state.
104 * src/widgets/modest-account-view.c:
105 (modest_account_view_finalize), (get_last_updated_string),
106 (update_account_view), (on_account_busy_changed), (init_view):
107 Show string "Refreshing..." if the account is currently busy.
109 All this fixes projects.maemo.org bug NB#59711
111 2007-06-14 Armin Burgmeier <armin@openismus.com>
113 * src/widgets/modest-attachments-view.h:
114 * src/widgets/modest-attachments-view.c: Added
115 modest_attachments_view_has_attachments() and fixed coordinate
116 transformation in get_att_view_at_coords(). This fixes attachment
119 * src/widgets/modest-msg-view.c: Make use of
120 modest_attachments_view_has_attachments() to decide whether to show
121 attachments in the header.
123 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
125 * src/maemo/modest-connection-specific-smtp-edit-window.c:
126 (on_change), (on_combo_security_changed),
127 (modest_connection_specific_smtp_edit_window_init),
128 (modest_connection_specific_smtp_edit_window_set_connection),
129 (modest_connection_specific_smtp_edit_window_is_dirty):
130 * src/maemo/modest-connection-specific-smtp-edit-window.h:
131 * src/maemo/modest-connection-specific-smtp-window.c:
134 Show an comfirmation dialog for the smpt-edit-window if there are
135 unsaved changes and the user hits cancel.
136 (projects.maemo.org bug NB#60479)
138 2007-06-14 Armin Burgmeier <armin@openismus.com>
140 * src/maemo/easysetup/modest-easysetup-wizard.c:
141 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
142 address" info in banner instead of node, and select all the text as
143 per UI spec. This fixes projects.maemo.org bug NB#60550.
145 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
147 reviewed by: <delete if not using a buddy>
149 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
150 * src/modest-ui-actions.c: (folder_refreshed_cb):
152 2007-06-14 Murray Cumming <murrayc@murrayc.com>
154 * src/widgets/modest-folder-view.c: (filter_row):
155 Explictly filter out the per-account outbox accounts. I don't know why
156 these only sometimes show up, but now they should never show up in the UI.
157 This should fix projects.maemo.org bug NB#60160.
159 2007-06-14 Murray Cumming <murrayc@murrayc.com>
161 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
162 when the toolbar does not exist yet.
163 * src/modest-widget-memory.c: (save_settings_header_view):
164 Added g_warnings() to help us to discover when we are trying to set
165 an empty columns list in gconf.
167 2007-06-14 Murray Cumming <murrayc@murrayc.com>
171 Added modest_init_get_default_header_view_column_ids().
173 * src/modest-widget-memory.c: (restore_settings_header_view):
174 Use the new function to get defaults, if the gconf key is empty,
175 instead of not creating any columns. This seems to fix the
176 empty right-hand pane problems.
178 * src/widgets/modest-header-view.h: Improved documentation.
180 2007-06-13 Murray Cumming <murrayc@murrayc.com>
182 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
183 Revert the use of the display name as the account name, because this
184 is generally wrong and would break the code that follows.
186 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
188 * src/maemo/easysetup/modest-easysetup-wizard.c:
189 (check_for_supported_auth_methods), (on_before_next),
192 More correct fix for projects.maemo.org bug NB# 58991
193 Do not longer accept AUTH_PASSWORD as secure method and choose
194 correct method when creating the account.
196 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
198 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
199 Fixed projects.maemo.org bug NB# 58991
201 2007-06-13 Murray Cumming <murrayc@murrayc.com>
203 * src/modest-init.c: (modest_init_init_core),
204 (modest_init_local_folders): Fixed compilation errors.
206 2007-06-13 Murray Cumming <murrayc@murrayc.com>
208 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
209 Remove unnecessary lib/include, though it is good in principle when needed.
211 * src/modest-init.c: (modest_init_one_local_folder),
212 (modest_init_local_folders):
213 * src/modest-init.h: Initialize the .modest library for memory cards,
214 instead of just doing nothing for them. This should allow us to create
215 folders there, fixing projects.maemo.org bug NB#59297.
217 2007-06-13 Murray Cumming <murrayc@murrayc.com>
219 * libmodest-dbus-client/libmodest-dbus-client.c:
220 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
221 (libmodest_dbus_client_compose_mail),
222 (libmodest_dbus_client_open_message),
223 (libmodest_dbus_client_send_and_receive),
224 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
226 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
227 (on_idle_open_message), (modest_dbus_req_handler),
228 (search_result_to_message), (modest_dbus_req_filter):
229 * src/modest-search.c: (add_hit), (modest_search_folder),
230 (modest_search_all_accounts): Improved debug messages.
232 * tests/dbus_api/test_open_message.c: (main): Improved comments.
234 * src/modest-tny-account-store.c:
235 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
238 2007-06-13 Murray Cumming <murrayc@murrayc.com>
241 2007-06-12 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-tny-account-store.c: (get_server_accounts):
244 Call modest_tny_local_folders_account_add_merged_outbox_folders()
245 even when there are no accounts, so that the Outbox folder is always
246 visible. This fixes projects.maemo.org bug NB#60158.
248 2007-06-12 Murray Cumming <murrayc@murrayc.com>
250 * src/maemo/modest-main-window.c: (create_details_widget):
251 Use the mcen_va_never logical ID.
253 2007-06-12 Murray Cumming <murrayc@murrayc.com>
255 * src/dbus_api/modest-dbus-api.h:
256 * src/dbus_api/modest-dbus-callbacks.c:
257 (on_idle_open_default_inbox), (on_open_default_inbox),
258 (modest_dbus_req_handler):
259 Added a new OpenDefaultInbox method.
261 * libmodest-dbus-client/libmodest-dbus-client.h:
262 * libmodest-dbus-client/libmodest-dbus-client.c:
263 Added libmodest_dbus_client_open_default_inbox() to call the new
264 dbus method. This should be useful to projects.maemo.org bug NB#57214,
265 though it should maybe be used by a new osso-email-interface function.
267 * tests/dbus_api/Makefile.am:
268 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
271 2007-06-12 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
274 NULL, so that the signals get all the keys. This should not actually
275 change any behaviour because we currently update everything when anything
278 2007-06-12 Murray Cumming <murrayc@murrayc.com>
280 * src/widgets/modest-folder-view.c: (text_cell_data),
281 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
282 (find_inbox_iter): If tinymail tells us that the folder is
283 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
284 This causes the inbox to be selected at startup, fixing part of
285 projects.maemo.org bug NB#56305.
287 * src/modest-ui-dimming-rules.c:
288 (modest_ui_dimming_rules_on_tools_smtp_servers):
289 * src/modest-ui-dimming-rules.h: Added a callback function to dim
290 the SMTP servers menu item.
291 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
292 that the SMTP Servers menu item is dimmed when there are no accounts,
293 as a future version of the UI spec will require. This fixes
294 projects.maemo.org bug NB#56305.
296 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
298 * src/maemo/modest-maemo-utils.c:
299 (modest_maemo_utils_get_supported_secure_authentication_methods):
300 Added label to dialog instead of unreadable title
302 * src/maemo/modest-main-window.c: (sync_accounts_cb),
303 (modest_main_window_new):
304 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
307 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
308 * src/modest-account-mgr.h:
309 Added method to avoid code duplication
311 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
312 (modest_ui_actions_on_send_receive):
313 Use modest_account_mgr_has_accounts
315 2007-06-11 Murray Cumming <murrayc@murrayc.com>
317 * src/maemo/easysetup/modest-presets.c:
318 (modest_presets_get_info_server_security): Do not report secure auth
320 * src/modest-protocol-info.c: Use the defines for the gconf key names
321 for secure authentication. This was not working because we were writing
322 Password and reading password, and the check was case sensitive.
323 With this, gmail now works for receiving and sending when created via
326 2007-06-11 Murray Cumming <murrayc@murrayc.com>
328 * src/maemo/easysetup/modest-presets.c:
329 (modest_presets_get_info_server_security): Correct the key name for
330 SecureSmtp, because it seems to be case-sensitive.
331 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
332 Do not try to get the 0th notebook page if there are 0 pages, to
335 2007-06-11 Murray Cumming <murrayc@murrayc.com>
337 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
338 Prevent use of the new notification feature for now, because it currently
339 shows one dialog for each new email, which is annoying.
341 2007-06-11 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
344 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
345 when no country was selected, so that we show the global ones.
346 * src/maemo/easysetup/modest-presets.c:
347 (modest_presets_get_providers): Return only the global providers, not
348 all providers when mmc=0 was requested.
350 2007-06-11 Murray Cumming <murrayc@murrayc.com>
352 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
353 (easysetup_provider_combo_box_fill): Remove debug code that showed the
354 provider ID in the combo.
356 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
357 Do not show the page numbers, because it would be confusing when we add
358 the 2 extra pages for the custom setup, when the user chooses the "Other"
359 provider. This fixes projects.maemo.org bug NB#59028
361 * src/modest-init.c: (modest_init_init_core),
362 (modest_init_local_folders):
364 * src/modest-tny-account.c:
365 (modest_tny_account_new_for_local_folders): Do not create default folders
366 for the memory card. This should fix projects.maemo.org bug NB#59328.
368 2007-06-11 Murray Cumming <murrayc@murrayc.com>
370 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
371 Free the changed_conf_keys string items. They are already freed in the
372 idle handler if that runs first.
374 2007-06-11 Murray Cumming <murrayc@murrayc.com>
376 * src/modest-ui-actions.c:
377 (modest_ui_actions_on_password_requested): Check that the server name
378 is not NULL, because I just saw a password dialog with (null) as the
381 * src/modest-tny-folder.[h|c]: Added
382 modest_tny_folder_is_memory_card_folder().
383 * src/modest-ui-dimming-rules.c:
384 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
385 menu item for memory cards, as per the UI spec (section 7.4). This should
386 fix projects.maemo.org bug NB#59297.
388 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
390 * src/maemo/modest-main-window.c: (sync_accounts_cb):
391 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
392 is another problem with the code, see Murray's comment at line 772)
394 2007-06-08 Murray Cumming <murrayc@murrayc.com>
396 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
397 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
398 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
399 (load_from_file), (easysetup_country_combo_box_init),
400 (easysetup_country_combo_box_get_active_country_ids),
401 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
402 instead of just one ID, to avoid duplicate country names in the UI.
404 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
405 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
406 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
407 a single ID, avoiding duplicate providers.
408 * src/maemo/easysetup/modest-easysetup-wizard.c:
409 (on_combo_account_country): Adapt to use a list.
411 2007-06-08 Murray Cumming <murrayc@murrayc.com>
413 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
414 keys changed in the last X seconds.
416 * src/modest-account-mgr.h:
417 * src/modest-account-mgr.c: (on_timeout_notify_changes),
418 (on_key_change), (modest_account_mgr_class_init),
419 (modest_account_mgr_init), (modest_account_mgr_finalize):
420 As the keys are changed, save them in a GSList* and signal that GSList*
421 further every X seconds, to batch changes, to allow us to do just one
422 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
423 bug NB#56941 and other (UI-blocking) delays when changing account settings.
425 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
426 changed signal signature.
428 * src/modest-conf.c: (modest_conf_set_list),
429 (modest_conf_on_change): Reenable notification.
431 (modest_conf_maemo_fake_on_change): Comment out the hack that
432 notified immediately instead of asynchronously.
434 * src/widgets/modest-account-view.h:
435 * src/widgets/modest-account-view.c:
436 (update_account_view): Select the previously-selected account ID,
437 if possible. This fixes projects.maemo.org bug NB#56933.
439 (on_account_changed), (on_account_removed),
440 (modest_account_view_select_account):
442 Remove the block/unblock functions
443 because they were not useful.
445 * src/maemo/modest-account-view-window.c:
446 (on_delete_button_clicked), (on_edit_button_clicked),
447 (on_new_button_clicked): Remove the use of the non-working block/unblock.
449 2007-06-08 Murray Cumming <murrayc@murrayc.com>
451 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
452 Improve the error dialog to show Incorrect Account Settings, which seems
453 clearer, and say that the internal error message (to be removed from the
454 dialog later) is often misleading.
455 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
457 * src/modest-tny-account.c:
458 (modest_tny_account_new_from_server_account): Uncomment the printf of the
459 URL because this is so useful for debugging on the device.
461 * src/widgets/modest-serversecurity-combo-box.c:
462 (modest_serversecurity_combo_box_fill): Correct a logical ID.
464 2007-06-08 Murray Cumming <murrayc@murrayc.com>
466 * src/modest-mail-operation.c:
467 (modest_mail_operation_send_new_mail):
468 Added a comment about a nasty but apparently harmless message. Details
469 added to the wiki g_warnings() page.
471 2007-06-08 Murray Cumming <murrayc@murrayc.com>
473 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
474 (modest_tny_send_queue_class_init):
475 Do not use the priv struct because it is empty, to avoid g_warnings
476 about a non-existant priv struct.
478 * src/modest-tny-account-store.c:
479 (modest_tny_account_store_get_server_account),
480 (modest_tny_account_store_get_transport_account_for_open_connection
481 ): Do not try to get transport server accounts for local folders,
482 because they don't have any. This avoids a g_warning().
484 * src/maemo/modest-main-window.c:
485 (modest_main_window_notify_send_receive_initied),
486 (on_configuration_key_changed):
487 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
489 * src/modest-mail-operation.c:
490 (modest_mail_operation_update_account):
491 * src/modest-tny-account-store.h:
492 * src/modest-tny-account.c:
493 (modest_tny_account_get_special_folder),
494 (modest_tny_account_new_for_local_folders),
495 (modest_tny_account_new_for_per_account_local_outbox_folder):
496 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
497 * src/modest-tny-local-folders-account.c:
498 (add_account_folders_to_merged_folder):
499 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
500 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
501 (modest_ui_actions_on_send):
502 * src/widgets/modest-folder-view.c: (update_model):
503 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
504 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
505 modest_tny_account_store_get_tny_account_by_account() to
506 modest_tny_account_store_get_server_account() to make the code clearer.
508 2007-06-07 Marcus Bauer <marcusb@openismus.com>
510 * src/dbus_api/modest-dbus-api.h:
511 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
512 * src/maemo/modest-msg-edit-window.c:
513 (modest_msg_edit_window_attach_file_noninteractive):
514 added g_warning in case the file to be attached does not exist
515 * tests/dbus_api/test_compose_mail.c: (main):
516 removed obsolete comment, added generic files as test case
518 2007-06-07 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-tny-account-store.c: (get_server_accounts):
521 Create the local folders account only once, not once for each outbox, and
522 not only when there are some outboxes.
524 2007-06-07 Murray Cumming <murrayc@murrayc.com>
526 * src/widgets/modest-folder-view.c: (update_model): Comment out some
527 code that is causing a crash at startup. Sergio says that he is fixing this.
529 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
531 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
532 * src/maemo/modest-account-settings-dialog.c:
533 (create_page_outgoing),
534 (modest_account_settings_dialog_set_account_name),
535 (save_configuration):
536 - Fixed handling of the "Use secure authentication" toggle to comply with
537 the ui specification. See also projects.maemo.org bug NB#58400
539 - Restore the Secure connection setting combo correctly when loading
542 * src/maemo/modest-maemo-utils.c:
543 (on_camel_account_get_supported_secure_authentication),
544 (modest_maemo_utils_get_supported_secure_authentication_methods):
545 Fixed a crasher if operation is canceled
547 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
548 (modest_protocol_info_auth_is_secure):
549 * src/modest-protocol-info.h:
551 Added two new methods to determine if a protocol/auth method is secure/encrypted in
552 the sense of the "Use secure authentication" toggle.
554 2007-06-07 Murray Cumming <murrayc@murrayc.com>
556 * src/modest-tny-account-store.h:
557 * src/modest-tny-account-store.c:
558 Added modest_tny_account_store_get_local_folders_account().
560 * src/modest-tny-folder.h:
561 * src/modest-tny-folder.c:
562 (modest_tny_folder_get_account):
563 Added this replacement for tny_folder_get_account() which returns
564 the local-folders account for TnyMergeFolders, to avoid the
565 warning about the unimplemented get_account_func() vfunc().
567 (modest_tny_folder_get_rules),
568 * src/modest-ui-actions.c:
569 (modest_ui_actions_on_folder_selection_changed):
570 * src/modest-mail-operation.c:
571 (modest_mail_operation_remove_folder),
572 (modest_mail_operation_xfer_folder),
573 (modest_mail_operation_rename_folder),
574 (modest_mail_operation_get_msg),
575 (modest_mail_operation_get_msgs_full),
576 (modest_mail_operation_remove_msg),
577 (modest_mail_operation_xfer_msgs),
578 (modest_mail_operation_refresh_folder):
579 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
581 2007-06-07 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
584 (modest_server_account_set_security):
585 * src/modest-defs.h: Add comments explaining that our
586 UI spec means TLS when it says Normal, so these do not look like errors.
588 * src/modest-tny-account.c:
589 (modest_tny_account_new_from_server_account): Use the new tinymail
590 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
591 for TLS. This should fix projects.maemo.org bug NB#58460.
593 2007-06-06 Murray Cumming <murrayc@murrayc.com>
595 * src/maemo/easysetup/modest-easysetup-wizard.c:
596 (create_account): Correct the position of the gconf sanity check warning.
597 (on_button_edit_advanced_settings): Show the dialog immediately, instead
598 of using the g_idle_add() hack, because this does not seem to be necessary
599 on osso 1.1. It might even work on Maemo Bora if the problems were actually
600 caused by something other than maemo's gconf.
601 This fixes projects.maemo.org bug #59022.
603 2007-06-06 Murray Cumming <murrayc@murrayc.com>
605 * src/modest-account-mgr-helpers.c:
606 (modest_account_mgr_get_default_account): Do not check that the account
607 exists if there is no default account (NULL), to fix a runtime warning.
609 2007-06-06 Murray Cumming <murrayc@murrayc.com>
611 * src/widgets/modest-folder-view.c: (update_model):
612 Do not unref the treemodel before we have finished with it.
613 This prevents a valgrind warning and an occasional crash at startup.
615 2007-06-06 Marcus Bauer <marcusb@openismus.com>
617 * libmodest-dbus-client/libmodest-dbus-client.h:
618 added libmodest_dbus_client_compose_mail()
619 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
621 added functions needed for SendAsMail() functionality
622 * src/maemo/modest-msg-edit-window.c:
623 (modest_msg_edit_window_attach_file_noninteractive):
624 non interactively attaching files to message edit window
625 * src/widgets/modest-msg-edit-window.h:
626 * tests/dbus_api/Makefile.am:
627 added test_compose_mail.c
628 * tests/dbus_api/test_compose_mail.c: (main):
630 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
632 * src/modest-account-view.c:
633 Fixed bug projects.maemo.org bug NB#59307
635 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
637 * src/maemo/easysetup/modest-easysetup-wizard.c:
638 (get_serverport_incoming), (on_before_next), (create_account):
639 * src/maemo/modest-account-settings-dialog.c:
640 (modest_account_settings_dialog_set_account_name):
641 * src/maemo/modest-maemo-utils.c:
642 (on_camel_account_get_supported_secure_authentication_status),
643 (on_camel_account_get_supported_secure_authentication),
644 (on_secure_auth_cancel),
645 (modest_maemo_utils_get_supported_secure_authentication_methods):
647 Implemented security authentication for settings and easysetup.
649 2007-06-05 Murray Cumming <murrayc@murrayc.com>
651 * src/maemo/modest-main-window.c: (create_details_widget):
652 Show the total size for memory card accounts too, instead of showing
653 the name again. Fixes bug projects.maemo.org bug NB#59307.
655 2007-06-05 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-tny-simple-folder-store.c:
659 * src/modest-tny-simple-folder-store.h: Removed.
661 * src/modest-tny-local-folders-account.h
662 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
663 for the local-folders maildir, with an extra TnyMergedFolder containing
664 the folders of the per-account outbox store accounts.
665 * src/modest-tny-account-store.c: (get_server_accounts):
666 Add the outboxes to the special local folders account after creating it.
668 * src/modest-tny-account.c:
669 (modest_tny_account_new_for_local_folders): Create the derived
670 account when creating the main local-folders account.
672 * src/maemo/modest-main-window.c: (create_details_widget),
673 (modest_main_window_set_contents_style):
674 Adapted to the use of the derived account instead of the folder store.
676 * src/modest-ui-actions.c:
677 (modest_ui_actions_on_folder_selection_changed):
678 * src/modest-ui-dimming-rules.c:
679 (modest_ui_dimming_rules_on_new_folder):
680 * src/widgets/modest-folder-view.c: (text_cell_data),
681 (icon_cell_data), (filter_row), (update_model),
682 (get_cmp_rows_type_pos):
685 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
686 Do not get the priv struct, because no priv struct has been set,
687 to avoid a runtime warning.
689 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
690 #ifelse with #else, to fix a warning, to fix the build.
693 2007-06-05 Christian Kellner <ckellner@openismus.com>
695 * libmodest-dbus-client/libmodest-dbus-client.c:
696 Fix small typo in doc (why do you always see them
697 AFTER committing stuff?)
700 2007-06-05 Christian Kellner <ckellner@openismus.com>
702 * libmodest-dbus-client/libmodest-dbus-client.c:
703 (libmodest_dbus_client_search):
704 Initialize hit list with NULL. Also set folder list
705 to "" if NULL was supplied.
708 2007-06-03 Christian Kellner <ckellner@openismus.com>
710 * libmodest-dbus-client/libmodest-dbus-client.c:
711 (modest_search_hit_list_free):
712 Make it save to call it with NULL.
714 * src/dbus_api/modest-dbus-callbacks.c:
715 * src/modest-search.c:
716 Return full ModestSearchHits as the search result list not TnyHeader
717 since can't be around withouth the correspoding TnyFolder.
719 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
721 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
722 Added currently commented code to check for secure auth
724 * src/maemo/modest-account-settings-dialog.c: (on_response),
725 (save_configuration), (show_ok):
726 Fixed projects.maemo.org bugs NB #59248 and #59251
728 * src/maemo/modest-maemo-utils.c:
729 (on_camel_account_get_supported_secure_authentication_status),
730 (on_camel_account_get_supported_secure_authentication),
731 (modest_maemo_utils_get_supported_secure_authentication_methods):
732 * src/maemo/modest-maemo-utils.h:
733 Moved get_supported_secure_authentication() method here to be able
734 to use it from easysetup wizard.
736 * src/modest-pair.c: (on_pair_compare_as_string):
737 Should compare string with first part of pair and not
738 strcmp pairs which will crash.
740 * src/modest-protocol-info.c:
741 (modest_protocol_info_protocol_is_store):
742 * src/modest-protocol-info.h:
743 Added modest_protocol_info_get_auth_protocol_name()
745 2007-06-03 Armin Burgmeier <armin@openismus.com>
747 * src/modest-mail-operation.c:
748 (modest_mail_operation_get_msgs_full): Set priv->account also when
749 only retrieving a single message. This avoids a crash when canceling
752 (modest_mail_operation_notify_end): Do not explicitely remove the
753 operation from the queue but only emit the progress_changed signal.
754 The queue itself listens to that signal to remove the operation when
755 it is finished. This reduces coupling and removes a potential deadlock
756 when modest_mail_operation_notify_end() is called from the queue
757 itself. If that is a problem performance-wise, I would suggest to
758 implement a status-changed signal or something.
760 * src/modest-mail-operation-queue.c: Make sure to never call a
761 function from another file while the queue is locked. This (hopefully)
762 fixes another deadlock when exiting the application while retrieving
765 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
767 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
768 Fixed build if libogs is not available
770 2007-06-03 Christian Kellner <ckellner@openismus.com>
772 * libmodest-dbus-client/libmodest-dbus-client.h:
773 * libmodest-dbus-client/libmodest-dbus-client.c:
774 (libmodest_dbus_client_delete_message):
775 Implement deletion of messages (Client side).
777 (modest_search_hit_free),
778 (modest_search_hit_list_free):
779 Utility functions to free the result hits.
781 * src/dbus_api/modest-dbus-api.h:
782 * src/dbus_api/modest-dbus-callbacks.c:
784 (modest_dbus_req_handler):
785 Implement deletion of messages (Server side).
787 * tests/dbus_api/test_search.c: (main):
790 * tests/dbus_api/Makefile.am:
791 * tests/dbus_api/test_delete_message:
792 Add little test for the message deletion logic
794 2007-06-03 Armin Burgmeier <armin@openismus.com>
796 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
797 when the operation queue was not empty. projects.maemo.org bug
800 2007-06-03 Armin Burgmeier <armin@openismus.com>
802 * src/widgets/modest-account-view.c
803 (on_account_default_toggled): Toggle default account column
804 explicitely instead of waiting for gconf notification (which is
805 currently ignored). This should fix projects.maemo.org bug NB#56910
806 for now. It should probably be removed when gconf notifications are
809 2007-06-03 Christian Kellner <ckellner@openismus.com>
811 * libmodest-dbus-client/libmodest-dbus-client.c:
812 Removed debugging spew.
814 * src/dbus_api/modest-dbus-callbacks.c:
815 Added debugging info.
817 * src/modest-search.c:
818 (modest_search_all_accounts):
819 Use tny_account_store_get_accounts () on the account store
820 to get all accounts which is the way to get all accounts.
822 * tests/dbus_api/test_search.c: (main):
823 Make it possible to supply the search term on the command line.
825 2007-06-03 Christian Kellner <ckellner@openismus.com>
827 * libmodest-dbus-client/libmodest-dbus-client.c:
828 * libmodest-dbus-client/libmodest-dbus-client.h:
829 Implement searching for mesages over raw dbus. (Client side)
831 * src/dbus_api/Makefile.am:
832 * src/dbus_api/modest-dbus-api.h:
833 * src/dbus_api/modest-dbus-callbacks.c:
834 * src/dbus_api/modest-dbus-callbacks.h:
835 Search framework (Server side). Also implement on_idle_open_message().
837 * src/maemo/modest-platform.c: (modest_platform_init):
838 Prepare for raw dbus/osso rpc interaction.
840 * src/modest-search.h:
841 Changed minsize from unspecific guint to guint32.
843 * src/modest-search.c:
845 Added strange hack which magically made tnymail work.
847 (modest_search_folder),
848 (modest_search_account),
849 (modest_search_all_accounts):
850 Implement helper functions to search all accounts, specific account
853 * tests/dbus_api/Makefile.am:
854 * tests/dbus_api/test_open_message.c:
855 Read url to open from commandline.
857 * tests/dbus_api/test_search.c:
858 Implement small test for dbus search stuff
860 2007-06-02 Armin Burgmeier <armin@openismus.com>
862 * src/maemo/modest-account-settings-dialog.c: Changed window title to
863 include account type and account title. This fixes projects.maemo.org
866 * src/maemo/modest-account-view-window.c: Set a title for the window.
868 2007-06-02 Armin Burgmeier <armin@openismus.com>
870 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
871 incoming and outgoing server name based on email address and server
872 types as long as the names have not been edited manually. This fixes
873 projects.maemo.org bug NB#58671.
875 2007-06-02 Armin Burgmeier <armin@openismus.com>
877 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
878 server type cannot be changed in future to the incoming details page
879 when creating an account. This fixes projects.maemo.org bug NB#59029.
881 2007-06-02 Armin Burgmeier <armin@openismus.com>
883 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
884 and assigned max width chars so that they wrap instead of being
885 truncated. Fixes projects.maemo.org bug NB#56126.
887 2007-06-02 Armin Burgmeier <armin@openismus.com>
889 * src/maemo/modest-connection-specific-smtp-window.c: Add an
890 introductory note to the connection specific smtp servers dialog, as
891 section 8.12 of the email UI specification requires. This fixes
892 projects.maemo.org bug NB#59212.
894 2007-06-01 Murray Cumming <murrayc@murrayc.com>
896 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
897 Check for running mail operations, and offer to cancel them, as per the UI
898 spec. This fixes projects.maemo.org bug NB#59041 .
899 However, I suspect that tinymail may still use the network connection
900 in ways that we cannot detect or cancel. But it should at least adapt to
903 2007-06-01 Murray Cumming <murrayc@murrayc.com>
905 * src/modest-tny-account-store.c: (recreate_all_accounts),
906 (get_cached_accounts), (get_server_accounts): Do more sensible
907 ref-counting of the temporarily-cached outbox accounts list. This seems
908 to fix a crash when entering the password when the password was wrong.
910 2007-06-01 Murray Cumming <murrayc@murrayc.com>
912 * src/gnome/modest-main-window.c: (connect_signals):
913 * src/modest-tny-account-store.c: (get_password),
914 (modest_tny_account_store_alert): Added comments and clues and
915 commented-out code about how we currently fail to deal with connection
916 errors and wrong passwords, and how we should.
918 2007-06-01 Murray Cumming <murrayc@murrayc.com>
920 * src/widgets/modest-retrieve-combo-box.c:
921 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
922 This fixes projects.maemo.org bug NB#58472 .
924 2007-06-01 Murray Cumming <murrayc@murrayc.com>
926 * src/maemo/easysetup/modest-easysetup-wizard.c:
927 (create_page_complete_easysetup):
928 (create_page_complete_custom): Correct the last commit,
929 putting the correct sentences in the correct pages.
931 2007-06-01 Murray Cumming <murrayc@murrayc.com>
933 * src/maemo/easysetup/modest-easysetup-wizard.c:
934 (create_page_complete_custom): Show the second sentence of text
935 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
938 2007-06-01 Murray Cumming <murrayc@murrayc.com>
940 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
941 Set the leave-on-server conf key by default. This fixes
942 projects.maemo.org bug NB#59258 .
944 2007-06-01 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/modest-account-view-window.c:
947 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
948 logical ID for the confirmation messages. Fixed projects.maemo.org bug
951 2007-06-01 Murray Cumming <murrayc@murrayc.com>
953 * src/maemo/easysetup/modest-easysetup-wizard.c:
954 (create_caption_new_with_asterisk):
955 * src/maemo/modest-account-settings-dialog.c:
956 (create_caption_new_with_asterisk):
957 Uncomment the code to add the asterisk, because they are no longer in the
958 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
959 (update_incoming_server_title): Add an asterisk here too.
961 2007-06-01 Murray Cumming <murrayc@murrayc.com>
963 * src/maemo/modest-maemo-global-settings-dialog.c:
964 (current_connection): Check that we are even connected before trying to
965 get the current connection name, to prevent a warning.
967 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
968 Change the comments because tny_maemo_conic_device_connect() is now meant to
970 * src/modest-mail-operation.c:
971 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
972 make sure we have a connection and fail if we can't connect.
974 2007-05-31 Murray Cumming <murrayc@murrayc.com>
976 * src/maemo/modest-main-window.c:
977 (on_account_store_connecting_finished): Do not try to get the
978 connection ID if we are not really connected. I am surprised that
979 this signal handler is called when we are not connected.
981 2007-05-31 Murray Cumming <murrayc@murrayc.com>
983 * src/modest-error.h:
984 * src/modest-ui-actions.c:
985 (modest_ui_actions_get_msgs_full_error_handler):
986 Renamed an enum, added comments, added an enum
987 for retrieve-limit errors.
989 * src/modest-mail-operation.c: (foreach_add_item),
990 (internal_folder_observer_update), (update_account_thread),
991 (modest_mail_operation_get_msgs_full):
992 (modest_mail_operation_update_account),
993 Added comments about how this works, and some code that should
994 (but does not) check the retrieve-limit. See the TODO comment.
996 2007-05-31 Murray Cumming <murrayc@murrayc.com>
998 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
999 Initialize help_id to fix the build. Warnings are good.
1001 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1003 * src/widgets/modest-hbox-cell-renderer.c:
1004 (modest_hbox_cell_renderer_append):
1005 * src/widgets/modest-vbox-cell-renderer.c:
1006 (modest_vbox_cell_renderer_append):
1007 Fix the last commit by doing an extra ref.
1009 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1011 * src/widgets/modest-hbox-cell-renderer.c:
1012 (modest_hbox_cell_renderer_append):
1013 * src/widgets/modest-vbox-cell-renderer.c:
1014 (modest_vbox_cell_renderer_append):
1015 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1016 to fix the build with Maemo Bora.
1017 However, there seems to be a remaining crash, probably due to reference
1020 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1022 * src/modest-tny-account.c:
1023 (modest_tny_account_new_for_local_folders):
1024 Use hildon_file_system_info_async_new() to get a better name for
1025 the memory card account, setting it as the account name.
1026 The timing seems to work, but this is probably
1027 not the best place to do this. See the TODO comment.
1028 * src/maemo/modest-main-window.c: (create_details_widget):
1029 * src/widgets/modest-folder-view.c: (text_cell_data):
1030 Use the tny account name instead of hardcoding a name.
1032 2007-05-30 Christian Kellner <ckellner@openismus.com>
1034 * src/modest-search.c: (modest_search):
1035 Correctly set part_search_func even if we have already parsed
1036 the query and thus a valid OgsTextSearcher object.
1038 2007-05-30 Christian Kellner <ckellner@openismus.com>
1041 Search and check for libogs.
1044 Incooparte the ogs build env.
1046 * src/modest-mime-part-search-stream.c:
1047 * src/modest-mime-part-search-stream.h:
1048 Removed since we do the real searching now in modest-search.c.
1050 * src/modest-search.c:
1051 * src/modest-search.h:
1052 Implement support for ogs. We use that if available and requested
1053 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1054 should now handle the corner case when the search term is spread
1055 across multiple reads.
1056 Also the logic in modest_search () was corrected to search all
1057 requested fields until one is found.
1059 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1063 * src/modest-init.h:
1064 * src/modest-init.c: Made modest_init_local_folders() take a
1065 path and be public so we can iniitialize maildir folders on
1068 * src/modest-local-folder-info.h:
1069 * src/modest-local-folder-info.c:
1070 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1072 * src/modest-tny-account.c:
1073 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1074 still means the standard local-folders path on the local volume.
1076 * src/modest-tny-account-store.c:
1077 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1078 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1079 all accounts when that happens.
1080 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1081 this too, so it shows up in the treeview.
1083 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1085 * src/maemo/modest-maemo-global-settings-dialog.c:
1086 (current_connection):
1087 * src/widgets/modest-global-settings-dialog.c:
1088 (current_connection_default):
1089 Use the enum values instead of 0, 1 and -1,
1090 to make the code clearer.
1092 * src/modest-account-mgr-helpers.c:
1093 (modest_account_mgr_get_connection_specific_smtp): Make this code
1096 * src/modest-runtime.h:
1097 * src/modest-runtime.c:
1098 Added modest_runtime_remove_all_send_queues().
1099 * src/maemo/modest-main-window.c:
1100 (on_account_store_connecting_finished): Recreate the send queues,
1101 using the appropriate transport accounts for this new connection.
1102 Some futher adapting might be needed if the old send queues are not
1103 automatically stopped at this point.
1105 * src/modest-tny-account-store.c: (get_server_accounts):
1106 Create the connection-specific transport accounts, so that they can
1107 be found later by their ID.
1109 * src/modest-tny-account.h:
1110 * src/modest-tny-account.c:
1111 Added modest_tny_account_new_from_server_account_name().
1112 modest_tny_account_new_from_server_account(): Do not create the
1113 send queues here, because they will be
1114 recreated anyway when the connection changes for the first time.
1116 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-local-folder-info.h:
1119 * src/modest-local-folder-info.c:
1120 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1121 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1122 tbox_folder): Take a modest account name instead of a server TnyAccount,
1123 so we can have per-modest-account rather than per-transport-account
1125 We must make sure that we change or recreate the exisitng send queues
1126 when the connection changes for connection-specific transport accounts.
1128 * src/modest-tny-account-store.c:
1129 (create_per_account_local_outbox_folders): Create outboxed per modest
1130 account, not per transport account.
1132 * src/modest-tny-account.h:
1133 * src/modest-tny-account.c:
1134 (modest_tny_account_get_special_folder): For outboxes, get the
1135 parent modest account name. The account is ignored for other folders.
1136 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1137 modest account name rather than a server TnyAccount.
1139 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1141 * src/modest-tny-account.c:
1142 (modest_tny_account_new_from_server_account):
1143 Call modest_runtime_get_send_queue() immediately after creating transport
1144 accounts, so that they start trying to send email from the outbox as soon
1145 as possible at startup. This is probably what we want.
1147 * src/modest-mail-operation.c: (update_account_thread):
1148 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1149 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1150 * src/modest-tny-send-queue.h:
1151 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1152 (modest_ui_actions_on_send):
1153 Added comments about how sending works, though it needs some more work.
1155 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1157 * src/modest-tny-account.c:
1158 (modest_tny_account_get_special_folder): Add TODO because this fails when
1159 the network is busy.
1160 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1161 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1162 Do not try to show this window when there is no active account. The UI
1163 specs does not tell us what to do in this case.
1165 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1169 * src/maemo/Makefile.am:
1170 * src/widgets/Makefile.am: Some dist fixes.
1172 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1174 * src/maemo/modest-connection-specific-smtp-window.c:
1175 (on_button_edit): Make the code clearer, to prevent a double free.
1177 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1179 * src/maemo/modest-account-settings-dialog.c:
1180 (modest_account_settings_dialog_set_account_name),
1181 Check the connection-specific smtp servers checkbox if there are any.
1183 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1184 (modest_connection_specific_smtp_edit_window_init):
1185 Start with a suitable port number.
1187 * src/modest-account-mgr-helpers.h:
1188 * src/modest-account-mgr-helpers.c: Added
1189 modest_account_mgr_get_has_connection_specific_smtp().
1191 (modest_account_mgr_set_connection_specific_smtp),
1192 (modest_account_mgr_remove_connection_specific_smtp),
1193 (modest_account_mgr_get_has_connection_specific_smtp),
1194 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1195 connection-specific smtp server accounts in the account, rather than
1196 the server account conf dir.
1198 This fixes bug projects.maemo.org bug NB#58263 .
1200 * src/modest-tny-account-store.c:
1201 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1202 if there are no server accounts yet, to prevent an infinite loop when there
1203 are no accounts. Document that one must be called before the other.
1205 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-account-mgr-helpers.c:
1208 (modest_account_mgr_get_default_account): Make sure that at least
1209 one account is always the default, if there are any enabled accounts.
1210 This is just a sanity check that shouldn't be necessary.
1212 * src/modest-account-mgr-priv.c:
1213 (_modest_account_mgr_account_from_key): Unescape the conf key to
1214 get the real account name. For instance, this is an issue if a space
1215 was in the account name, which can happen because the account name
1216 is generated from the display name.
1217 (_modest_account_mgr_get_account_keyname): Always escape the
1219 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1220 Unescape the conf keys to get the real account names.
1222 For instance, previously the is-default radio button in the accounts
1223 list was not checked for any accounts at first. This fixes that,
1224 and might fix several similar bugs.
1226 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1229 Removed some debug printfs.
1231 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1233 Modest on-disk outbox directories are now here, for instance:
1234 $HOME/.modest/outboxes/<account-id-1>/outbox
1235 $HOME/.modest/outboxes/<account-id-2>/outbox
1237 $HOME/.modest/local-folders/outbox
1238 so we can have a separate outbox for each account.
1239 But they are shown as one outbox in the GtkTreeView, by using a
1240 TnyMergeFolder in a ModestTnySimpleFolderStore.
1243 * src/modest-tny-simple-folder-store.c:
1244 * src/modest-tny-simple-folder-store.h:
1245 Added ModestTnySimpleFolderStore, used to contain folders from
1246 other folder stores, such as other accounts.
1248 * src/modest-tny-outbox-account.h:
1249 * src/modest-tny-outbox-account.c:
1250 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1251 used for the per-account local outbox folders.
1253 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1254 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1255 only use this (internally) now for the non-outbox local folders.
1257 * src/modest-init.h:
1258 * src/modest-init.c: Added modest_init_one_local_folder(), for
1259 setting up the directory structure for each local folder.
1261 * src/modest-local-folder-info.c:
1262 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1263 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1265 * src/modest-local-folder-info.h:
1266 * src/modest-tny-account-store.c: (on_account_removed),
1267 (on_account_changed), (create_per_account_local_outbox_folders),
1268 (get_server_accounts), (modest_tny_account_store_get_accounts),
1269 (modest_tny_account_store_get_tny_account_by_account),
1270 (modest_tny_folder_store_is_virtual_local_folders):
1272 * src/modest-tny-account.h:
1273 * src/modest-tny-account.c:
1274 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1275 to create an on-disk per-account local outbox folder for each
1277 (create_per_account_local_outbox_folders): Create a local outbox folder
1278 for each transport account.
1279 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1280 for all local folders.
1282 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1283 instead of using g_object_get/set() directly. It is clearer.
1285 (modest_tny_folder_store_get_message_count),
1286 (modest_tny_folder_store_get_local_size
1287 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1288 because we now use these with non-acount folder stores.
1290 (modest_tny_account_get_special_folder),
1291 (modest_tny_account_new_from_server_account),
1292 (modest_tny_account_new_from_account):
1293 (recurse_folders): Adjust to the new outbox system.
1295 * src/modest-tny-folder.h:
1296 * src/modest-tny-folder.c:
1297 (modest_tny_folder_is_local_folder),
1298 (modest_tny_folder_get_local_folder_type),
1299 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1301 * src/widgets/modest-main-window.h:
1302 * src/maemo/modest-main-window.c: (create_details_widget),
1303 (modest_main_window_set_contents_style): Show details for any folder store,
1306 (modest_tny_folder_get_rules):
1307 Remove the const. C does not support constness enough for this.
1309 * src/modest-ui-actions.c:
1310 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1311 make all outboxes appear as one, in the usual local-folders tree node.
1313 (set_active_account_from_tny_account),
1314 (modest_ui_actions_on_folder_selection_changed):
1315 * src/widgets/modest-folder-view.c: (text_cell_data),
1316 (icon_cell_data), (filter_row),
1317 (add_account_folders_to_merged_folder),
1318 (add_account_folders_to_simple_folder_store), (),
1319 (get_cmp_rows_type_pos), (cmp_rows),
1320 (modest_folder_view_set_account_id_of_visible_server_account):
1321 Adjust to the new outbox system, using generic folder stores and folders
1322 in the GtkTreeModel.
1324 2007-05-23 Christian Kellner <ckellner@openismus.com>
1326 * src/modest-mail-operation.c:
1327 (modest_mail_operation_update_account):
1328 Use info->max_size instead of unintialized local var [small
1329 build fix]. (Added TODO to review that change since I don't
1332 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1334 * libmodest-dbus-client/libmodest-dbus-client.c:
1335 (libmodest_dbus_client_compose_mail): function added
1336 * src/dbus_api/modest-dbus-api.h:
1337 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1338 (on_compose_mail): Implementation of the SendAsMail functionality
1340 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1342 * src/modest-account-mgr.c:
1343 (modest_account_mgr_add_server_account): Set the secure-connection
1344 conf key for transport accounts as well as store accounts. I don't know
1345 why the if was there. For instance, this makes sure that we use SSL
1346 for the gmail preset from the easysetup wizard.
1348 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1350 * src/gnome/modest-main-window.c:
1351 (on_account_store_connecting_finished), (connect_signals):
1352 * src/maemo/modest-main-window.c:
1353 (on_account_store_connecting_finished), (connect_signals),
1354 (modest_main_window_new):
1355 Handle TnyAccountStore::connecting-finished instead of
1356 TnyDevice::connection-changed, because we cannot actually perform
1357 operations on accounts until TnyAccountStore has itself responded to
1358 the TnyDevice::connection-changed signal. This prevents a GError from
1360 Do not try to update at startup, because we (at least on scratchbox)
1361 already do an update at startup when the device goes online.
1362 This prevents a GError from tinymail.
1363 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1364 Added TODO about stopping simultaneous operations.
1366 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1369 * src/modest-mail-operation-queue.c:
1370 (modest_mail_operation_queue_remove):
1371 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1372 about where they happened.
1374 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-ui-actions.c:
1377 (modest_ui_actions_on_password_requested): Make sure that the remember
1378 output parameter is always TRUE.
1380 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1382 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1383 Show a OK/Cancel dialog if the error is a question, though we still do not
1384 know anything more about what we are asking the user.
1385 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1386 Fix an uninitialized variable (helper). This is a logic error, however.
1388 2007-05-21 Christian Kellner <ckellner@openismus.com>
1390 * src/modest-search.h:
1391 Correct bit shifting in the ModestSearchFlags enum.
1393 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-tny-account.c:
1396 (modest_tny_account_new_from_server_account): Do not use the lsub and
1397 check-all hard-coded IMAP options when using POP.
1399 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account.c:
1402 (modest_tny_account_new_from_server_account):
1403 Use NULL for the secure-auth method for POP when Password auth has been
1404 specified by the user, as we already do for IMAP. "auth=Login" causes
1405 an error from camel or the server.
1407 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1409 * src/maemo/modest-account-settings-dialog.c:
1410 (create_page_account_details),
1411 (modest_account_settings_dialog_set_account_name):
1412 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1413 for the leave-on-server checkbox, rathr than just the checkbox, when
1414 the protocol is not POP.
1416 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1418 * src/widgets/modest-account-view.c:
1419 * src/widgets/modest-account-view.h:
1420 Added modest_account_view_select_account() which will be useful later
1421 to asynchronously re-select the edited account.
1423 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-account-settings-dialog.c:
1426 (modest_account_settings_dialog_set_account_name):
1427 Automatically choose the port numbers based on the secure authentication
1428 methods, if they have not been chosen before.
1429 This fixes projects.maemo.org bug NB#56273 .
1431 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1433 * src/maemo/modest-main-window-ui.h:
1434 * src/modest-ui-actions.c:
1435 * src/modest-ui-actions.h:
1436 Connect the Tools/SMTP Servers menu item to
1437 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1438 SMTP servers dialog, as in the UI specification and saves changes when it
1439 is closed. This fixed projects.maemo.org bug NB#56305 .
1441 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1443 * src/maemo/modest-connection-specific-smtp-window.c:
1444 (modest_connection_specific_smtp_window_init):
1445 Use gtk_window_set_default_size() to make this window big enough, so
1446 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1448 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1450 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1451 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1452 (modest_connection_specific_smtp_edit_window_init),
1453 Do not try to connect to a combobox signal before the combobox exists.
1454 This fixes the cras in projects.maemo.org bug NB#56288 .
1455 (modest_connection_specific_smtp_edit_window_get_settings):
1456 Remove the server_account_name parameter which was being checked for NULL
1457 though it was not used.
1459 * src/maemo/modest-connection-specific-smtp-window.c:
1460 (modest_connection_specific_smtp_window_fill_with_connections),
1461 (on_button_edit), (modest_connection_specific_smtp_window_init):
1462 Correct the number of treemodel columns to prevent a warning.
1463 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1464 libconic does not work.
1466 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1468 * src/modest-tny-account.c:
1469 (modest_tny_account_new_from_server_account):
1470 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1471 SMTP when "None" was chosen by the user. However, with my SMTP server that
1472 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1475 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1477 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1478 to explain the memory management issue with the ID in the ModestPair.
1480 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1481 (add_sending_page), (modest_account_assistant_finalize):
1482 * src/gnome/modest-gnome-global-settings-dialog.c:
1483 (create_updating_page), (create_composing_page):
1484 * src/gnome/modest-msg-edit-window.c: (get_transports),
1485 (init_window), (modest_msg_edit_window_finalize),
1486 (modest_msg_edit_window_get_msg_data):
1487 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1488 * src/gnome/modest-transport-widget.c:
1489 (modest_transport_widget_finalize), (smtp_configuration):
1490 * src/maemo/modest-maemo-global-settings-dialog.c:
1491 (create_updating_page), (create_composing_page):
1492 * src/maemo/modest-msg-edit-window.c: (get_transports),
1493 (init_window), (modest_msg_edit_window_finalize),
1494 (modest_msg_edit_window_get_msg_data),
1495 (modest_msg_edit_window_free_msg_data):
1496 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1497 (modest_store_widget_finalize):
1498 * src/maemo/modest-transport-widget.c:
1499 (modest_transport_widget_finalize), (smtp_configuration):
1500 * src/modest-main.c: (send_mail):
1501 * src/widgets/modest-combo-box.h:
1502 * src/widgets/modest-global-settings-dialog-priv.h:
1503 * src/widgets/modest-global-settings-dialog.c:
1504 (modest_global_settings_dialog_finalize):
1505 * src/widgets/modest-msg-edit-window.h:
1506 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1507 as long as the combo box, to prevent use of freed memory for the ID.
1509 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1511 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1512 get_accounts(), to make this clearer. Do not check for the enabled gconf
1513 key, because we do not use this for server accounts (at least, not yet).
1514 This allows us to send email again.
1516 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1518 * src/maemo/modest-platform.c:
1519 (on_modest_conf_update_interval_changed), (modest_platform_init):
1520 Only respond to this particular key change. All these strcmp()s cannot be
1523 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1525 * src/maemo/modest-maemo-global-settings-dialog.c:
1526 (current_connection): Prevent a crash in scratchbox when
1527 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1528 * src/maemo/modest-platform.c:
1529 (on_modest_conf_update_interval_changed), (modest_platform_init):
1530 Get the update interval from gconf and reset it when the gconf key changes.
1532 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1534 * src/modest-protocol-info.c:
1535 * src/modest-protocol-info.h: Adde enum-specific get functions,
1536 instead of using a ModestProtocolType enum parameter.
1538 * src/gnome/modest-account-assistant.c:
1539 * src/gnome/modest-store-widget.c:
1540 * src/gnome/modest-store-widget.h:
1541 * src/gnome/modest-transport-widget.c:
1542 * src/gnome/modest-transport-widget.h:
1543 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1544 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1545 * src/maemo/easysetup/modest-easysetup-wizard.c:
1546 * src/maemo/modest-account-settings-dialog.c:
1547 * src/maemo/modest-account-settings-dialog.h:
1548 * src/maemo/modest-store-widget.c:
1549 * src/maemo/modest-store-widget.h:
1550 * src/maemo/modest-transport-widget.c:
1551 * src/maemo/modest-transport-widget.h:
1552 * src/modest-account-mgr-helpers.c:
1553 * src/modest-account-mgr-helpers.h:
1554 * src/modest-account-mgr.c:
1555 * src/modest-account-mgr.h:
1556 * src/modest-tny-account.c:
1557 * src/modest-tny-folder.c:
1558 * src/widgets/modest-account-view.c:
1559 * src/widgets/modest-retrieve-combo-box.c:
1560 * src/widgets/modest-retrieve-combo-box.h:
1561 * src/widgets/modest-secureauth-combo-box.c:
1562 * src/widgets/modest-serversecurity-combo-box.c:
1563 * src/widgets/modest-serversecurity-combo-box.h:
1564 * tests/check_account-mgr.c:
1565 Use the specific functions, and use the re-renamed enum values for GNOME too.
1567 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1569 * src/modest-pair.h:
1570 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1571 so we can get the second based on the first.
1573 * src/maemo/modest-account-settings-dialog.h:
1574 * src/maemo/modest-account-settings-dialog.c:
1575 Added get_supported_secure_authentication_methods(), though it is mostly
1576 commented-out for now until the necessary API is committed to tinymail.
1577 (modest_account_settings_dialog_set_account_name),
1578 (save_configuration): Request the supported authentication methods from the
1579 server, so we can choose a working method.
1581 * src/modest-tny-account-store.h:
1582 * src/modest-tny-account-store.c:
1583 (modest_tny_account_store_get_session): Rename from
1584 tny_account_store_get_session().
1586 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1588 * src/modest-protocol-info.h: Split the ModestProtocol enum
1589 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1590 There was no need to have these unrelated values in one enum.
1592 * src/: many files: Adapted to changed enum. This makes the code a bit
1593 clearer, and the compiler could catch some errors.
1595 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1598 Show the detailed internal camel error message when an error happens
1599 during the configuration, so that our testers can give us more clues.
1600 For instance, in projects.maemo.org bug NB#56910 .
1602 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1604 * src/modest-tny-account.c:
1605 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1606 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1608 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1610 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1611 * src/maemo/modest-account-settings-dialog.c:
1612 (modest_account_settings_dialog_set_account_name),
1613 (save_configuration): For the incoming secure authentication checkbox,
1614 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1615 the UI specification. PLAIN does not seem to be supported for most IMAP
1616 servers anyway, and I am not sure what it would mean.
1617 However, we probably need to discover which of the secure-authentication
1618 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1619 * src/modest-account-mgr-helpers.c:
1620 (modest_account_mgr_get_server_account_data):
1622 * src/modest-tny-account.c:
1623 (modest_tny_account_new_from_server_account):
1624 Use tny_account_set_mech() to set secure-authentication methods,
1625 with some special-casing for IMAP, based on my observations of how
1628 * src/modest-account-mgr-helpers.h:
1629 * src/modest-account-mgr.c:
1630 * src/modest-defs.h: Comment that the URI is only used for local folders.
1632 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1635 parameter const, just to be neat.
1636 * src/modest-text-utils.c: (modest_text_utils_inline):
1637 End g_strconcat() with NULL, as its documentation says. This is almost
1638 certainly the cause of my crash at startup on the device. Interestingly,
1639 valgrind doesn't tell us about these errors.
1641 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1643 * scripts/build-packages: Added more precise comments about how to use
1644 this script, though I still get this error:
1645 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1646 error building tinymail
1648 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1650 * src/maemo/modest-main-window.c: (on_account_update):
1651 Very slight cleanup, hoping to make it simpler to discover what causes
1652 a crash here sometimes.
1654 * src/modest-tny-account.c:
1655 (modest_tny_account_new_from_server_account): Set the port. Added
1656 comments about the options and a TODO comment because I need to find out
1657 how to specify the secure authentication method.
1659 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1661 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1662 changed CFlags paths form modest to libmodest
1664 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-account-mgr-helpers.c:
1667 (modest_account_mgr_get_server_account_data),
1668 (modest_account_mgr_free_server_account_data):
1669 * src/modest-account-mgr-helpers.h:
1670 * src/modest-account-mgr.c:
1671 (modest_account_mgr_add_server_account):
1672 * src/modest-defs.h:
1673 * src/modest-tny-account.c:
1674 (modest_tny_account_new_from_server_account):
1675 Determine the options for tny_camel_account_add_option() here,
1676 based on the settings, rather than storing them directly in gconf.
1678 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1680 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1681 Show a more friendly error dialog now that we expect (from the tinymail
1682 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1684 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1686 * src/maemo/modest-main-window.c: (on_account_update): Check that
1687 account_name is not NULL, to prevent a crash at startup that I am
1688 seeing on the N800. I do wonder why it is NULL.
1690 * src/maemo/easysetup/modest-easysetup-wizard.c:
1691 (create_page_user_details):
1692 * src/maemo/modest-account-settings-dialog.c:
1693 (create_page_user_details), (create_page_outgoing):
1694 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1695 (modest_connection_specific_smtp_edit_window_init):
1696 * src/modest-ui-actions.c:
1697 (modest_ui_actions_on_password_requested):
1698 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1699 might do something useful with the on-screen keyboard.
1701 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1703 * src/maemo/modest-main-window.c: (on_account_update):
1704 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1705 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1707 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-tny-account-store.c: (on_account_changed):
1710 Correct the signature of this signal handler.
1712 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1715 Show a HildonNote instead of a GtkDialog for Maemo.
1717 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1719 * src/widgets/modest-account-view.h:
1720 * src/widgets/modest-account-view.c: (on_account_changed),
1721 (on_account_removed). Added a boolean flag, set/unset by
1722 modest_account_view_block_conf_updates(),
1723 modest_account_view_unblock_conf_updates() to prevent unnecessary
1724 updates, but this is not very useful because the gconf notifications are
1725 so delays (maybe only on Maemo Bora).
1726 So auto-updating is turned off, and these functions do an explicit
1727 update when necessary.
1728 However, something else is still doing too much work when adding/removing
1729 accounts, probably in another part of the application.
1731 * src/maemo/modest-account-view-window.c:
1732 (on_delete_button_clicked), (on_edit_button_clicked),
1733 (on_new_button_clicked): Use the new functions.
1735 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1737 * src/modest-account-mgr-helpers.c:
1738 (modest_account_mgr_set_first_account_as_default):
1739 Sort the list of names alphabetically-by-title, so we choose the first one
1741 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1742 alphabetically by the title.
1744 This fixes projects.maemo.org bug NB#56418 .
1746 * src/modest-account-mgr-priv.c:
1747 (_modest_account_mgr_account_from_key):
1748 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1749 avoid a valgrind error, and possible random behaviour.
1751 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1753 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1754 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1755 tinymail documentation to say that this can be expected.
1756 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1757 pretty, and should not happen, but I would prefer to know when it does.
1759 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1761 * configure.ac: When using the older hildon version, probably on Bora,
1762 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1764 * src/widgets/modest-attachment-view.c:
1765 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1768 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1770 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1771 Implemented the prototype. Can be tested with
1772 tests/dbus_api/test_open_message:
1774 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1776 * src/modest-tny-account-store.c:
1777 (modest_tny_account_store_instance_init), (get_password):
1778 * src/modest-ui-actions.c:
1779 (modest_ui_actions_on_password_requested):
1780 Do not store the password in gconf, because this function is called
1781 for non-remembered passwords. Actually use the cached (in the hash map)
1782 password instead of releasing it.
1783 The password will now not be remembered if it is asked via the protected
1784 password dialog, as per the UI spec.
1786 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1788 * src/modest-defs.h:
1789 * src/modest-account-mgr-helpers.h:
1790 * src/modest-account-mgr-helpers.c:
1791 Added modest_server_account_get_username_has_succeeded(),
1792 modest_server_account_set_username_has_succeeded().
1793 (modest_server_account_set_username),
1794 Reset the has-succeeded flag if the username changes.
1796 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1797 * src/maemo/modest-connection-specific-smtp-window.c:
1798 (modest_connection_specific_smtp_window_save_server_accounts):
1799 Use modest_server_account_set_username() instead of using
1800 modest_conf_set_string() directly, so that the has-succeeded flag is always
1803 * src/modest-ui-actions.c:
1804 (modest_ui_actions_on_password_requested): Dim the username entry if
1805 the username has ever worked, as per the UI spec.
1807 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1809 * src/modest-tny-account-store.c: (get_password):
1810 * src/modest-ui-actions.c:
1811 (modest_ui_actions_on_password_requested):
1812 Allow the username to be changed too, though there is more work to
1813 be done on exactly how this behaves.
1815 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1817 * src/modest-account-mgr-helpers.h:
1818 * src/modest-account-mgr-helpers.c:
1819 Added modest_account_mgr_get_display_name(),
1820 modest_server_account_get_username(),
1821 modest_server_account_set_username(),
1822 modest_server_account_set_password(),
1823 modest_server_account_get_hostname() functions so we do not need to
1824 use the conf API directly.
1826 * src/maemo/modest-main-window.c: (connect_signals):
1827 Actually connect ot the ModestAccountStore::request-password signal,
1828 so that we show the dialog when the password is requested by Tinymail,
1829 for isntance if it is empty.
1831 * src/modest-marshal.list:
1832 * src/modest-tny-account-store.c:
1833 (modest_tny_account_store_class_init), (get_password),
1834 (modest_tny_account_store_alert):
1835 * src/modest-tny-account-store.h:
1836 * src/modest-ui-actions.h:
1837 * src/modest-ui-actions.c:
1838 (modest_ui_actions_on_password_requested):
1839 Change the signal parameters, so it is obvious that we are providing
1840 the non human-readable server name, and receiving both the username
1841 and password, though changing of the username is not yet implemented.
1842 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1843 for the GNOME version.
1845 This should fix the projects.maemo.org bug NB#56209, though it does not
1846 work on Bora, because the gconf_client_get() for the password fails
1847 immediately after we save it with gconf_client_set().
1849 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1852 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1853 caused an undefined symbol error:
1854 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1856 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1858 * src/modest-tny-account-store.c:
1859 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1860 using a GError instead of a string message, so we can translate it in
1863 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1865 * src/maemo/modest-address-book.c:
1866 (modest_address_book_check_names):
1867 * src/maemo/modest-msg-view-window.c:
1868 (modest_msg_view_window_clipboard_owner_change):
1869 * src/modest-init.c: (modest_init_init_ui):
1870 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1871 (update_folders_cb), (modest_mail_operation_update_account):
1872 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1873 (modest_ui_actions_on_msg_attachment_clicked),
1874 (modest_ui_actions_on_msg_recpt_activated):
1875 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1876 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1877 (modest_msg_view_search_next):
1878 * src/widgets/modest-recpt-editor.c:
1879 (modest_recpt_editor_on_button_release_event),
1880 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1881 g_message(). At this point we should only be seeing interesting errors on
1882 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1884 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1886 (modest_wizard_dialog_force_title_update):
1887 * src/maemo/easysetup/modest-wizard-dialog.h:
1888 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1889 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1890 can update the title when appropriate. Otherwise the title is wrong if the
1891 pages are added after adding the notebook to the dialog.
1892 This must be a problem in HildonWizardDialog too.
1893 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1895 * src/maemo/easysetup/modest-easysetup-wizard.c:
1896 (create_subsequent_customsetup_pages),
1897 (create_subsequent_easysetup_pages):
1898 Call modest_wizard_dialog_force_title_update() so that the title is
1899 correct even with GTK+ < 2.10.
1900 This fixes projects.maemo.org bug NB#56145 .
1902 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1904 * src/maemo/modest-platform.c:
1905 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1906 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1909 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1911 * src/widgets/modest-window.h:
1912 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1913 and modest_window_save_state(), which invokes it.
1915 * src/widgets/modest-window-mgr.h:
1916 * src/widgets/modest-window-mgr.c:
1917 Added modest_window_mgr_save_state_for_all_windows(), which calls
1918 the save_state vfunc on all registered windows, if implemented.
1920 * src/gnome/modest-msg-edit-window.c:
1921 * src/gnome/modest-msg-view-window.c:
1922 * src/maemo/modest-msg-edit-window.c:
1923 * src/maemo/modest-msg-view-window.c:
1924 * src/maemo/modest-main-window.c:
1925 Specify the existing save_settings functions as implementations of
1926 ModestWindow::save_state_func().
1928 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1929 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1930 enabling hibernation, for instance.
1932 We may need to do the same thing for restoring settings.
1935 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1937 * src/widgets/modest-window-mgr.c:
1938 * src/widgets/modest-window-mgr.h:
1939 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1940 modest_window_mgr_get_hibernation_is_prevented().
1942 * src/maemo/modest-main-window.c:
1943 (on_hildon_program_is_topmost_notify): Prevent hibernation
1944 (possible when the application goes to the background in the WM),
1945 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1947 * src/maemo/easysetup/modest-easysetup-wizard.c:
1948 (modest_easysetup_wizard_dialog_init):
1949 * src/maemo/modest-account-settings-dialog.c:
1950 (modest_account_settings_dialog_init):
1951 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1952 (modest_connection_specific_smtp_edit_window_init):
1953 * src/maemo/modest-connection-specific-smtp-window.c:
1954 (modest_connection_specific_smtp_window_init):
1955 * src/maemo/modest-signature-editor-dialog.c:
1956 (modest_signature_editor_dialog_init):
1957 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1958 prevent hibernation while any of these account settings dialogs are open.
1960 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1962 * src/maemo/Makefile.am:
1963 * src/maemo/modest-osso-state-saving.c:
1964 * src/maemo/modest-osso-state-saving.h: Added
1965 modest_osso_load_state() and modest_osso_save_state() though they do
1966 nothing now. They should iterate through all the open windows and load/save
1968 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1969 save state when closing.
1971 * src/maemo/modest-main-window.c:
1972 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1973 Add a notification handler for the HildonProgram::is-topmost property,
1974 so we can allow hibernation when the application goes into the background.
1975 But we still need to detect when the accounts setup windows are open so
1976 we can stop hibernation when they are open.
1977 To do this, I also added the main window the HildonProgram. This might have
1978 other side-effects/benefits, and should maybe be done for other windows.
1980 * src/maemo/modest-osso-autosave-callbacks.h:
1981 * src/maemo/modest-osso-autosave-callbacks.c:
1982 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1983 though it does not do anything yet, and we might never need this to do
1984 anything. For instance, we already save drafts.
1986 * src/maemo/modest-platform.c: (modest_platform_init):
1987 Specify the libosso auto-save callback.
1989 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1991 * src/maemo/modest-platform.c:
1992 (modest_platform_set_update_interval):
1993 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1994 aparently stays valid between application instances, so we can use this
1995 to remove and reset it later. According to a maemo-developers email from
1998 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2000 * configure.ac: Depend on libalarm for Maemo.
2002 * src/dbus_api/modest-dbus-api.h:
2003 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2004 (on_send_receive), (modest_dbus_req_handler):
2005 Handle a SEND_RECEIVE D-Bus method.
2007 * libmodest-dbus-client/libmodest-dbus-client.c:
2008 (libmodest_dbus_client_send_and_receive):
2009 * libmodest-dbus-client/libmodest-dbus-client.h:
2010 Add C convenience functions for calling the new D-Bus method.
2012 * src/modest-platform.h:
2013 * src/gnome/modest-platform.c:
2014 * src/maemo/modest-platform.c:
2015 Added modest_platform_set_update_interval(), which uses the
2016 alarmd API on Maemo.
2017 (modest_platform_init),
2018 Call modest_platform_set_update_interval(), using a hard-coded
2019 interval for now (until the global settings dialog is implemented),
2020 though I am not sure that this makes sense yet.
2022 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2024 * src/dbus_api/modest-dbus-callbacks.c:
2025 (modest_osso_cb_hw_state_handler):
2026 * src/dbus_api/modest-dbus-callbacks.h:
2027 * src/maemo/modest-platform.c: (modest_platform_init):
2028 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2029 in case this has some effect on the ability for Maemo to ping the
2032 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2035 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2036 warning. It is probably a logic error, but I need to fix the build.
2038 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2040 * src/modest-account-mgr.h:
2041 * src/modest-account-mgr.c:
2042 (modest_account_mgr_account_names): Add a gboolean enabled_only
2043 parameter, so we can get lists of onlt the enabled accounts.
2045 (modest_account_mgr_add_account),,
2046 (modest_account_mgr_account_with_display_name_exists):
2047 * src/maemo/modest-msg-edit-window.c: (get_transports):
2048 * src/modest-account-mgr-helpers.c:
2049 (modest_account_mgr_set_first_account_as_default):
2050 * src/modest-init.c: (init_default_account_maybe):
2051 * src/modest-tny-account-store.c: (get_accounts):
2052 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2053 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2054 * tests/check_account-mgr.c: (START_TEST):
2055 Provide the extra parameter, as appropriate.
2057 * src/widgets/modest-account-view.c: (update_account_view):
2058 Do not show disabled accounts (meaning that there is no way to
2059 enable/disable accounts in the UI (the feature is not in our UI
2060 specification), so we can use this internally only to mark unfinished
2061 or temporary account data.
2063 * src/maemo/easysetup/modest-easysetup-wizard.c:
2064 (create_account): Add boolean enable parameter, so we can specify FALSE
2065 to create the temporary account.
2066 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2067 (on_before_next): When finishing, when there is a temporary account, just
2069 Also, use a timeout to delay the showing of the dialog until gconf is likely
2070 to return correct information, due to a maemo gconf bug that is fixed in
2071 osso 1.1, but not yet in Bora.
2072 However, the dialog stays on screen after it is destroyed.
2074 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2075 for invalid data when cancelling. Use a hildon note instead of a dialog
2076 to complain about invalid data. Do not show the account-saved note if the
2077 account is disabled (a temporary account that will not really be saved for use
2080 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2082 * src/modest-account-mgr-helpers.h:
2083 * src/modest-account-mgr-helpers.c:
2084 Added modest_account_mgr_unset_default_account(),
2085 Added modest_account_mgr_set_first_account_as_default().
2087 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2088 If it was the default account, unset the default account name.
2090 * src/maemo/modest-account-view-window.c:
2091 (on_delete_button_clicked): If it was the default account,
2092 set the first remaining account as the default instead.
2094 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2095 a NULL account or a NULL default account, to prevent a crash. This should
2096 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2099 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2101 * src/widgets/modest-recpt-editor.c:
2102 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2103 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2104 TODO comment for this. This fixes the build.
2106 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2107 be the best place for it. This will in future update all auto-update accounts,
2108 rather than just the current/default account, when that gconf key exists.
2109 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2110 if there are no accounts, before calling do_send_receive().
2111 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2113 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2114 * src/maemo/modest-main-window-ui.h:
2115 * src/maemo/modest-main-window.c: (on_connection_changed),
2116 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2117 directly, becaue the signal handler does more.
2119 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2121 * src/modest-account-mgr-helpers.c:
2122 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2123 for the case that the account does not exist.
2125 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2126 (equivalent to the modest account name) rather than the tinymail account name
2127 (equivalent to the modest account title - human readable) to get the account data.
2128 Check for null account data to prevent the crash, and add a TODO comment saying that
2129 this needs fixing because it is using the server account name instead of the account name.
2131 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2133 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2134 * src/maemo/modest-account-settings-dialog.c: (show_error),
2136 Use hildon_note_new_information() for informative and error messages,
2137 which seems to be expected for Maemo applications (no documentation that I know of
2138 says this). I am surprised that there is no distinction between info and error
2141 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2143 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2144 it is easy to find where this is used.
2146 * src/maemo/easysetup/modest-easysetup-wizard.c:
2147 (create_page_welcome), (create_page_account_details),
2148 (create_page_user_details), (create_page_complete_easysetup),
2149 (create_page_custom_incoming), (create_page_custom_outgoing),
2150 (create_page_complete_custom):
2151 * src/maemo/modest-account-settings-dialog.c:
2152 (create_page_account_details), (create_page_user_details),
2153 (create_page_incoming), (create_page_outgoing):
2154 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2156 (modest_connection_specific_smtp_edit_window_init):
2157 * src/maemo/modest-connection-specific-smtp-window.c:
2158 (modest_connection_specific_smtp_window_init):
2159 * src/maemo/modest-signature-editor-dialog.c:
2160 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2161 and scrolling policy as per the Email Application Layout Guide, if I have
2164 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2167 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2168 which were empty, because these vfuncs have been removed from TnyAccountStore.
2169 This fixes the build.
2171 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2173 * src/maemo/modest-main-window.c:
2174 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2175 showing/hiding it. Added TODO because it probably should not be NULL.
2176 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2177 because unnecessary g_warnings() make degugging difficult.
2179 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2181 * src/maemo/modest-msg-edit-window.c:
2182 (modest_msg_edit_window_select_color),
2183 (modest_msg_edit_window_select_background_color): 2 const corrections and
2184 moving 2 #endifs before closing brackets, to fix the build.
2186 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/easysetup/modest-easysetup-wizard.h:
2189 * src/maemo/easysetup/modest-easysetup-wizard.c:
2190 (modest_easysetup_wizard_dialog_finalize),
2191 (on_button_edit_advanced_settings), (create_page_complete_custom),
2192 (on_response), (create_account):
2193 Implement the Advanced Settings edit button, by saving the account information,
2194 for the Advanded Settings dialog to use directly from gconf, and removing it
2195 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2196 Bug #5533 in the projects.maemo.org bugzilla.
2198 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2200 * src/maemo/modest-msg-view-window.c:
2201 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2202 when opening a message window.
2204 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2206 * src/maemo/easysetup/modest-easysetup-wizard.c:
2207 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2210 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2211 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2212 gconf settings. I probably added more checks than necessary, but that is safer.
2214 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2215 variable to fix the build, but this seems to be used when it is still NULL.
2217 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2219 * src/modest-platform.h:
2220 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2221 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2222 * src/modest-main.c: Implement this function so we can avoid using
2223 maemo-specific API from cross-platform code.
2225 * src/modest-tny-account-store.c:
2226 (get_smtp_specific_transport_account_for_open_connection):
2227 * src/modest-ui-actions.c: (check_for_connection),
2228 (modest_ui_actions_on_item_not_found):
2229 Use modest_platform_connect_and_wait() and put #idefs around other
2230 maemo-specific code, because only maemo currently has a way to
2231 identify connection names.
2233 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2235 * src/modest-tny-account-store.h:
2236 * src/modest-tny-account-store.c:
2237 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2238 the connection-specific SMTP server settings in the configuration.
2240 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2242 * src/maemo/modest-main-window.c: (on_connection_changed),
2244 * src/modest-main.c: (main), (start_ui), (send_mail):
2245 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2246 that is what is intended.
2248 * src/modest-ui-actions.c: (action_send), (action_receive),
2249 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2250 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2251 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2252 SMTP server is used when it is specified.
2254 (modest_ui_actions_on_send_receive):
2255 Check that a connection is open before proceeding.
2256 Receive and then send, instead of vice-versa, as per the specification.
2258 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2260 * src/modest-mail-operation.c:
2261 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2262 though I guess it should be something other than NULL.
2264 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2266 * src/maemo/easysetup/modest-easysetup-wizard.c:
2267 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2268 combo twice, to avoid an g_warning and to make it visible again.
2269 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2270 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2271 (already intended) dereference when detaching, because we then recreate the menu.
2272 But I am not sure why the warning was happening, and it is possible that this is a memory
2275 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2277 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2278 and uri_parse_mailto() utility functions.
2279 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2281 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2283 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2285 * src/dbus_api/modest-dbus-api.h:
2286 * src/dbus_api/modest-dbus-callbacks.c:
2287 Use an idle callback to execute the modest code in the application's own thread.
2288 Remove the helloworld example method.
2289 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2290 parsed, and the open-message method is not implemented because this is not yet implemented in
2292 * libmodest-dbus-client/libmodest-dbus-client.c:
2293 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2294 (libmodest_dbus_client_open_message):
2295 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2297 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2298 body without crashing.
2300 * tests/dbus_api/Makefile.am:
2301 * tests/dbus_api/test_mail_to.c:
2302 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2304 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2306 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2307 Added file to fix the build. Sorry.
2309 * src/dbus_api/Makefile.am:
2310 * src/dbus_api/modest-dbus-api.h:
2311 * src/dbus_api/modest-dbus-callbacks.h:
2312 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2313 (modest_dbus_req_handler):
2314 Put constants in a separate header so it can be reused by the
2315 client library, without duplication
2317 * libmodest-dbus-client/Makefile.am:
2318 * libmodest-dbus-client/libmodest-dbus-client.c:
2319 (libmodest_dbus_client_call_helloworld),
2320 (libmodfest_dbus_client_send_mail),
2321 (libmodfest_dbus_client_mailto),
2322 (libmodfest_dbus_client_open_message):
2323 * libmodest-dbus-client/libmodest-dbus-client.h:
2324 (Partly) Implement a send_mail D-Bus method.
2326 * tests/dbus_api/Makefile.am:
2327 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2328 the send_email D-Bus method.
2330 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2334 * libmodest-dbus-client/Makefile.am:
2335 * libmodest-dbus-client/libmodest-dbus-client.c:
2336 * libmodest-dbus-client/libmodest-dbus-client.h:
2337 * tests/dbus_api/Makefile.am:
2338 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2339 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2341 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2343 * src/maemo/easysetup/modest-easysetup-wizard.c:
2344 (create_page_account_details):
2345 * src/maemo/modest-account-settings-dialog.c:
2346 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2347 widgets, because this might not be the default in future versions of the Maemo GTK+.
2348 However, I can not not get capitalization to work even in a simple test case.
2350 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2352 * src/maemo/easysetup/modest-easysetup-wizard.c:
2353 (create_page_custom_incoming), (create_page_custom_outgoing):
2354 * src/maemo/modest-account-settings-dialog.c:
2355 (create_page_account_details), (create_page_incoming),
2356 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2357 instead of using gtk_check_button_with_label(), so they are aligned like the other
2358 widgets, as per the UI spec.
2360 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/easysetup/modest-easysetup-wizard.c:
2363 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2364 * src/widgets/modest-validating-entry.c:
2365 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2366 Modest prefix instead of an EasySetup prefix.
2368 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2370 * src/widgets/modest-validating-entry.h:
2371 * src/widgets/modest-validating-entry.c: (on_insert_text),
2372 Added easysetup_validating_entry_set_max_func(), used to set a callback
2373 to call when the max number of characters is reached. GtkEntry has a max-length
2374 already but is silent about it.
2376 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2377 (create_page_account_details), (create_page_user_details),
2379 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2380 (create_page_account_details), (create_page_user_details),
2381 (create_page_outgoing):
2382 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2383 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2384 the UI spec, when the user tries to enter more than the max number of characters.
2386 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2388 * src/maemo/easysetup/modest-easysetup-wizard.c:
2389 (create_page_user_details), (create_page_custom_incoming),
2390 (create_page_custom_outgoing):
2391 * src/maemo/modest-account-settings-dialog.c:
2392 (create_page_user_details), (create_page_incoming),
2393 (create_page_outgoing):
2394 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2395 (modest_connection_specific_smtp_edit_window_init):
2396 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2397 not appropriate. Bad Maemo-specific defaults!.
2399 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2401 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2402 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2403 (modest_signature_editor_dialog_set_settings):
2404 Disable the label and textview when the checkbox is disabled, and use the
2405 specified (UI spec) default signature text.
2407 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2409 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2410 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2412 * src/modest-defs.h:
2413 * src/modest-account-mgr-helpers.h:
2414 * src/modest-account-mgr-helpers.c:
2415 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2417 * src/maemo/Makefile.am:
2418 * src/maemo/modest-signature-editor-dialog.c:
2419 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2422 * src/maemo/modest-account-settings-dialog.h:
2423 * src/maemo/modest-account-settings-dialog.c:
2424 (modest_account_settings_dialog_finalize), (on_button_signature),
2425 (save_configuration): Use the new dialog when the Edit button is pressed, and
2426 save the changes if necessary, as per the UI spec.
2428 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2430 * src/maemo/Makefile.am:
2431 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2432 based on maemo-develoers email from Dirk.
2434 * src/maemo/easysetup/modest-easysetup-wizard.c:
2435 (create_page_welcome), (create_page_account_details),
2436 (create_page_user_details), (create_page_complete_easysetup),
2437 (create_page_custom_incoming), (create_page_custom_outgoing),
2438 (create_page_complete_custom),
2439 (modest_easysetup_wizard_dialog_init):
2440 * src/maemo/modest-account-settings-dialog.c:
2441 (create_page_account_details), (create_page_user_details),
2442 (create_page_incoming), (create_page_outgoing),
2443 (modest_account_settings_dialog_init):
2444 * src/maemo/modest-connection-specific-smtp-window.c:
2445 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2447 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2449 * src/maemo/easysetup/modest-easysetup-wizard.c:
2450 (create_page_account_details), (create_page_custom_outgoing),
2451 (create_page_complete_custom):
2452 * src/maemo/modest-account-settings-dialog.c:
2453 (create_page_user_details), (create_page_incoming),
2454 (create_page_outgoing):
2455 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2456 (modest_connection_specific_smtp_edit_window_init):
2457 Use the correct (UI spec) port min/max, and use horizontal separators,
2460 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2462 * src/maemo/easysetup/modest-easysetup-wizard.c:
2463 (set_default_custom_servernames):
2464 * src/maemo/modest-account-settings-dialog.c:
2465 (create_page_incoming), (on_combo_outgoing_security_changed),
2466 (on_combo_incoming_security_changed), (create_page_outgoing),
2467 (modest_account_settings_dialog_set_account_name),
2468 (save_configuration):
2469 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2470 (on_combo_security_changed),
2471 (modest_connection_specific_smtp_edit_window_init),
2472 (modest_connection_specific_smtp_edit_window_set_connection),
2473 (modest_connection_specific_smtp_edit_window_get_settings):
2474 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2477 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2480 * src/maemo/easysetup/modest-easysetup-wizard.c:
2481 (create_page_custom_outgoing), (create_page_complete_custom):
2482 * src/maemo/modest-account-settings-dialog.c:
2483 (create_page_user_details), (create_page_outgoing):
2484 * src/maemo/modest-account-view-window.c: (button_box_new):
2485 Use changed logical IDs as per the most recent UI spec:
2486 mcen_bd_emailsetup_edit -> mcen_bd_edit
2487 mcen_bd_emailsetup_delete -> mcen_bd_delete
2488 mcen_bd_emailsetup_close -> mcen_bd_close
2490 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2494 * src/dbus_api/Makefile.am:
2495 * src/dbus_api/modest-dbus-callbacks.c:
2496 * src/dbus_api/modest-dbus-callbacks.h:
2497 * src/maemo/modest-platform.c: (modest_platform_init):
2498 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2500 * tests/Makefile.am:
2501 * tests/dbus_api/Makefile.am:
2502 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2504 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/modest-account-settings-dialog.c:
2507 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2508 Removed unnecessary includes.
2510 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2512 * src/maemo/easysetup/modest-easysetup-wizard.c:
2513 * src/maemo/modest-account-settings-dialog.c:
2514 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2515 * src/widgets/Makefile.am:
2516 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2517 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2518 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2519 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2520 * src/widgets/modest-secureauth-combo-box.c:
2521 * src/widgets/modest-secureauth-combo-box.h:
2522 * src/widgets/modest-serversecurity-combo-box.c:
2523 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2524 made the GObject names more consistent with the rest of the Modest code.
2526 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/easysetup/Makefile.am:
2529 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2530 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2531 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2532 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2533 * src/maemo/easysetup/modest-easysetup-wizard.c:
2534 * src/maemo/easysetup/modest-validating-entry.c:
2535 * src/maemo/easysetup/modest-validating-entry.h:
2536 * src/maemo/modest-account-settings-dialog.c:
2537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2538 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2539 widgets/ because they are used outside of easysetup too. After checking in,
2540 svn will allow me to rename them too.
2542 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2544 * src/gnome/modest-msg-edit-window.c:
2545 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2546 linker error, to fix the build on the GNOME platform.
2547 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2548 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2549 ifdefed out to avoid a warning.
2551 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2553 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2554 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2555 some alternative for GTK+ 2.6.
2557 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2559 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2561 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2562 specified for EmailAccountsDialog in UI spec.
2564 * src/maemo/easysetup/modest-easysetup-wizard.c:
2565 * src/maemo/easysetup/modest-easysetup-wizard.h:
2566 * src/maemo/modest-account-settings-dialog.c:
2567 * src/maemo/modest-account-settings-dialog.h:
2568 Reuse a member window widget for the connection-specific SMTP server accounts,
2569 so we can tell it to create/save the accounts only if we actually save changes.
2571 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2572 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2573 (modest_connection_specific_smtp_edit_window_get_settings):
2574 Return a struct instance for temporarily remembering the entered data.
2576 * src/maemo/modest-connection-specific-smtp-window.h:
2577 * src/maemo/modest-connection-specific-smtp-window.c:
2578 (modest_connection_specific_smtp_window_finalize),
2579 (modest_connection_specific_smtp_window_fill_with_connections),
2581 (modest_connection_specific_smtp_window_save_server_accounts),
2582 (update_model_server_names): Do not actually save data until asked,
2583 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2585 (on_selection_changed),
2586 (modest_connection_specific_smtp_window_init): Disable the edit
2587 button when nothing is selected.
2589 * src/modest-account-mgr-helpers.c:
2590 * src/modest-account-mgr-helpers.h:
2591 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2594 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2596 * src/modest-account-mgr-helpers.h:
2597 * src/modest-account-mgr-helpers.c:
2598 (modest_account_mgr_get_unused_account_name),
2599 (modest_account_mgr_get_unused_account_display_name): Added these
2600 utility functions, to avoid code duplication.
2602 * src/maemo/easysetup/modest-easysetup-wizard.c:
2603 (create_page_account_details), (create_account):
2604 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2605 (on_combo_security_changed),
2606 (modest_connection_specific_smtp_edit_window_init),
2607 (modest_connection_specific_smtp_edit_window_save_settings):
2608 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2609 * src/maemo/modest-connection-specific-smtp-window.c:
2610 (modest_connection_specific_smtp_window_finalize),
2611 (modest_connection_specific_smtp_window_fill_with_connections),
2612 (on_button_edit), (modest_connection_specific_smtp_window_init):
2613 * src/maemo/modest-connection-specific-smtp-window.h:
2614 Implementing saving of connection-specific server accounts.
2616 But I need to refactor this so we can save the data for each
2617 possible connection-specific account and only actually create the server accounts
2618 when the easysetup finished, or the OK button is pressed on the account settings
2621 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2623 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2624 (on_combo_security_changed):
2625 (modest_connection_specific_smtp_edit_window_init):
2626 Auto-fill the port number as in the account settings.
2628 (modest_connection_specific_smtp_edit_window_set_connection):
2629 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2630 * src/maemo/modest-connection-specific-smtp-window.c:
2631 (fill_with_connections), (on_button_edit),
2632 (modest_connection_specific_smtp_window_init):
2633 Turn the edit window into a dialog to simplify the code, and
2634 set a WM hint as in a GtkDialog, because only a popup can be on top of
2635 another window in Maemo, and popups usually have no WM decoration.
2637 * src/modest-defs.h:
2638 * src/modest-account-mgr-helpers.c:
2639 (modest_account_mgr_set_connection_specific_smtp),
2640 (modest_account_mgr_remove_connection_specific_smtp),
2641 (modest_account_mgr_get_connection_specific_smtp):
2642 * src/modest-account-mgr-helpers.h: Some functions to write the
2643 connection-specific SMTP server information. Not yet used.
2646 * src/widgets/modest-folder-view.c: (text_cell_data):
2647 Fix a warning about an uninitialized variable.
2648 (on_configuration_key_changed): Put an #ifdef around the use
2649 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2651 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2653 * src/maemo/modest-account-settings-dialog.h:
2654 * src/maemo/modest-account-settings-dialog.c:
2655 Added connect_for_modified() utility function to mark the new modified boolean.
2657 (create_page_account_details), (create_page_user_details),
2658 (create_page_incoming), (create_page_outgoing), (on_response),
2659 (modest_account_settings_dialog_init),
2660 (modest_account_settings_dialog_set_account_name):
2661 Only warn about unsaved changes when there are actually unsaved changes.
2663 * src/modest-account-mgr-helpers.c:
2664 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2665 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2666 to get the data from there in future.
2668 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-defs.h:
2672 * src/modest-account-mgr-helpers.h:
2673 * src/modest-account-mgr-helpers.c:
2674 Store the security account setting in a single conf key instead of using
2675 the options list, so that the list is left for just the to-be-removed camel hack,
2676 and because gconf_client_set_list() is failing for some reason.
2678 * src/modest-account-mgr.c:
2679 (modest_account_mgr_add_server_account):
2680 * src/maemo/modest-account-settings-dialog.c:
2681 (modest_account_settings_dialog_set_account_name),
2682 (save_configuration): Use the renamed functions.
2685 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2687 * src/widgets/Makefile.am:
2688 * src/widgets/modest-limit-retrieve-combo-box.c:
2689 * src/widgets/modest-limit-retrieve-combo-box.h:
2690 * src/widgets/modest-retrieve-combo-box.c:
2691 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2692 the account settings dialog.
2694 * src/modest-defs.h:
2695 * src/modest-account-mgr-helpers.h:
2696 * src/modest-account-mgr-helpers.c:
2697 (modest_server_account_get_option_secure_auth),
2698 (modest_server_account_set_option_secure_auth):
2699 * src/modest-account-mgr.c:
2700 (modest_account_mgr_add_server_account):
2701 Use the existing AUTH_MECH conf key for the secure-auth setting,
2702 instead of putting it in the list options, because this was actually used already.
2704 * src/maemo/modest-account-settings-dialog.c:
2705 (create_page_account_details),
2706 (modest_account_settings_dialog_set_account_name),
2707 (save_configuration):
2708 * src/maemo/modest-account-settings-dialog.h:
2709 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2710 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2712 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2714 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2715 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2716 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2718 * src/modest-defs.h:
2719 * src/maemo/modest-account-settings-dialog.c:
2720 (create_page_incoming), (on_combo_outgoing_security_changed),
2721 (on_combo_incoming_security_changed), (create_page_outgoing),
2722 (modest_account_settings_dialog_set_account_name),
2723 (save_configuration): Load/Save the port number, and change it when the
2724 security combo changes, to suitable defaults.
2726 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2728 * src/modest-account-mgr.c:
2729 (modest_account_mgr_add_server_account): Set the security and secure-auth
2730 options, and add a comment saying that the other camel-specific options should be
2733 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2735 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2737 * src/modest-tny-account-store.c: (account_list_free),
2738 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2739 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2742 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2744 * src/modest-protocol-info.c:
2745 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2746 is required by our UI spec. Maybe something in our implementation will use this eventually.
2747 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2748 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2749 instead of the previous 0 placeholder.
2751 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2752 secure-auth settings.
2753 * src/modest-account-mgr-helpers.h:
2754 * src/modest-account-mgr-helpers.c:
2755 (modest_server_account_data_get_option_secure_auth),
2756 (modest_server_account_set_option_secure_auth),
2757 (modest_server_account_data_get_option_security),
2758 (modest_server_account_set_option_security): Added this API for getting and setting the security
2759 and secure-auth settings.
2761 * src/maemo/modest-account-settings-dialog.h:
2762 * src/maemo/modest-account-settings-dialog.c:
2763 (modest_account_settings_dialog_finalize), (check_data),
2764 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2765 about changing titles.
2766 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2767 (save_configuration): Save the security and secure-auth settings.
2769 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2770 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2772 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2774 * src/modest-defs.h:
2775 * src/modest-account-mgr.c:
2776 (modest_account_mgr_add_server_account):
2777 Added and used defines for the options key and value pair strings,
2778 that are used so far, though they do not seem to correspond to anything in our
2779 UI specs or ModestProtocol enum.
2781 * src/modest-account-mgr-helpers.h:
2782 * src/modest-account-mgr-helpers.c:
2783 (compare_option_strings_for_name),
2784 (modest_server_account_data_get_option_value),
2785 (modest_server_account_data_get_option_bool),
2786 (modest_account_mgr_get_server_account_option):
2787 Added helper functions for parsing the options GSList.
2789 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2791 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2792 display name is based on the supplied account name.
2793 * src/modest-account-mgr.c:
2794 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2795 with an inefficient, but good-enough, implementation.
2797 * src/maemo/easysetup/modest-easysetup-wizard.c:
2798 (create_page_account_details), (on_before_next), (create_account):
2799 Check for existing display names rather than (non-user-visible) account names, and just
2800 create and set a unique account name at the end.
2802 * src/maemo/modest-account-settings-dialog.c:
2803 (modest_account_settings_dialog_init),
2804 (modest_account_settings_dialog_set_account_name),
2805 (create_page_incoming): Show the display name, instead of the account name.
2806 (on_response): Do some (not all) extra checks, as in the UI spec.
2807 (save_configuration): Save the display name if it was changed.
2809 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2811 * po/en_GB.po: Added needed logical ID and translation.
2812 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2813 (init_view): Made the is-default column clicking work.
2815 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2818 * src/maemo/easysetup/Makefile.am:
2819 * src/maemo/easysetup/modest-easysetup-wizard.c:
2820 (modest_easysetup_wizard_dialog_init):
2821 * src/maemo/easysetup/provider-data-test.keyfile:
2822 * src/maemo/easysetup/provider-data.keyfile:
2823 Moved the provider data file to the new modest-providers-data package and used it from there.
2825 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2827 * src/modest-local-folder-info.c:
2828 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2829 N_() was already used on the static strings, but this just marks it for translation without
2830 using the translation.
2832 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/modest-account-settings-dialog.c:
2835 (create_page_incoming),
2836 (modest_account_settings_dialog_set_account_name):
2837 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2838 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2839 I will do this if nobody else gets there first.
2841 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2843 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2844 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2845 save the security stuff.
2847 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2849 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2850 Set the email address and user fullname, which I now see must be
2853 * src/maemo/modest-account-settings-dialog.h:
2854 * src/maemo/modest-account-settings-dialog.c:
2856 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2857 leave-on-server and authentication.
2858 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2861 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/modest-account-settings-dialog.c:
2865 * src/maemo/modest-account-settings-dialog.h:
2866 Most (but not all) of the widgets are now present as specified by the UI spec.
2867 No changes are yet saved, and some details are not properly shown yet.
2869 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2871 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2873 * src/maemo/Makefile.am:
2874 * src/maemo/modest-account-settings-dialog.c:
2875 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2876 an existing account. Doesn't do much yet.
2878 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2879 Open the accounts settings dialog when Edit is clicked.
2881 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2883 * src/maemo/easysetup/Makefile.am:
2884 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2886 * src/maemo/easysetup/modest-easysetup-wizard.c:
2887 (modest_easysetup_wizard_dialog_init):
2888 Try to get the source directory from the build system,
2889 instead of hard-coding "./" into the source code, when opening our local
2890 copies of the configuration files.
2891 But this still fails when opening the wizard from the Accounts window,
2892 maybe because the working directory seems to change at runtime.
2893 So the wizard will fail the second time unless you copy the files into their
2894 proper locations - see the stdout warnings for the paths.
2896 (create_page_account_details),(on_before_next):
2897 Check for existing non-server accounts instead of server accounts,
2898 so the default account name is useful again, and to prevent trying to
2901 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2902 Show the wizard when New is clicked.
2904 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2905 (init_view): Show the column headers, and show the columns that are
2906 specified in the UI specs. However, something in Maemo's GTK+ prevents
2907 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2908 change the default account. This is despite unsetting the special properties.
2910 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2912 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2913 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2914 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2915 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2916 to make that clearer.
2917 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2919 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2921 * src/maemo/modest-account-view-window.c:
2922 (modest_account_view_window_init),
2923 (modest_account_view_window_new):
2924 Use the same buttons as specified in the
2925 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2926 the existing widgets, which never had a chance of working.
2927 Put the ModestAccountView treeview in a scrolled window.
2928 Do not repeat the initialization in both _init() and _new().
2930 * src/widgets/modest-account-view.c: (update_account_view):
2931 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2932 this widget and window shows no accounts.
2934 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2936 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2938 * src/maemo/easysetup/modest-easysetup-wizard.c:
2939 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2940 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2941 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2944 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2945 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2946 accounts exist yet, as in the UI spec.
2948 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2950 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/Makefile.am:
2953 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2954 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2955 New window for editing connection-specific smtp details.
2956 Not fully implemented.
2958 * src/maemo/modest-connection-specific-smtp-window.c:
2959 (modest_connection_specific_smtp_window_finalize) :
2960 unref the tree model.
2961 (on_button_edit): Show the edit window.
2963 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2965 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2968 * src/maemo/Makefile.am:
2969 * src/maemo/modest-connection-specific-smtp-window.c:
2970 * src/maemo/modest-connection-specific-smtp-window.h:
2971 New window for showing the list of connections, for connection-specific
2972 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2973 * src/maemo/easysetup/modest-easysetup-wizard.c:
2974 (create_page_custom_outgoing): Show the new window when the button is clicked.
2976 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2978 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2979 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2980 * src/maemo/modest-msg-edit-window.c:
2981 (modest_msg_edit_window_insert_image):
2982 * src/modest-conf.c: (modest_conf_key_escape):
2983 * src/modest-mail-operation.c:
2984 (modest_mail_operation_send_new_mail):
2985 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2986 (modest_ui_actions_on_new_account):
2987 * src/widgets/modest-attachment-view.c: (update_filename_request):
2988 * src/widgets/modest-mail-header-view.c:
2989 Corrected warnings that were breaking the build, by commenting out unused variables,
2990 and a function, and by including a header.
2992 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2994 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2995 so we can #ifdef around platform-specific code when necessary.
2996 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2997 to allow this to build for the GNOME platform too.
2999 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/easysetup/modest-easysetup-wizard.c:
3002 Added util_increment_name() and used it in create_page_account_details()
3003 to make sure that the default account name is always a new name.
3005 (modest_easysetup_wizard_dialog_init),
3006 (set_default_custom_servernames): Some minor memory management fixes.
3008 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3012 * src/modest-runtime.c: (init_i18n): Restored the translation
3013 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3014 are defined in config.h, and the translations are installed.
3016 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3017 is defined for translation.
3019 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3021 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3023 * src/maemo/easysetup/modest-easysetup-wizard.c:
3024 (modest_easysetup_wizard_dialog_init):
3025 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3026 Use realistic paths (though they should use $prefix generically) to the
3027 mcc_mapping and provider-data.keyfile files which might work when they
3028 are installed by the future version of the operator-wizard package,
3029 and then fallback to paths in our source code, with an explanatory
3032 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3036 * src/maemo/Makefile.am:
3037 * src/maemo/easysetup/: Added files from the previously-exernal
3038 osso-modest-easysetup.
3039 * src/maemo/modest-main-window-ui.h:
3040 * src/modest-ui-actions.c:
3041 * src/modest-ui-actions.h:
3042 Added modest_ui_actions_on_new_account() as a signal handler for the
3043 New Account menu item. It shows the easysetup wizard.
3044 * po/en_GB.po: Added additional needed logical IDs and translations.
3046 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
3047 Apparently ChangeLog is not used for some vague Nokia legal reasons.