1 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c:
4 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
5 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
7 2007-05-14 Murray Cumming <murrayc@murrayc.com>
9 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
10 * src/maemo/modest-account-settings-dialog.c:
11 (modest_account_settings_dialog_set_account_name),
12 (save_configuration): For the incoming secure authentication checkbox,
13 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
14 the UI specification. PLAIN does not seem to be supported for most IMAP
15 servers anyway, and I am not sure what it would mean.
16 However, we probably need to discover which of the secure-authentication
17 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
18 * src/modest-account-mgr-helpers.c:
19 (modest_account_mgr_get_server_account_data):
21 * src/modest-tny-account.c:
22 (modest_tny_account_new_from_server_account):
23 Use tny_account_set_mech() to set secure-authentication methods,
24 with some special-casing for IMAP, based on my observations of how
27 * src/modest-account-mgr-helpers.h:
28 * src/modest-account-mgr.c:
29 * src/modest-defs.h: Comment that the URI is only used for local folders.
31 2007-05-11 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
34 parameter const, just to be neat.
35 * src/modest-text-utils.c: (modest_text_utils_inline):
36 End g_strconcat() with NULL, as its documentation says. This is almost
37 certainly the cause of my crash at startup on the device. Interestingly,
38 valgrind doesn't tell us about these errors.
40 2007-05-11 Murray Cumming <murrayc@murrayc.com>
42 * scripts/build-packages: Added more precise comments about how to use
43 this script, though I still get this error:
44 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
45 error building tinymail
47 2007-05-11 Murray Cumming <murrayc@murrayc.com>
49 * src/maemo/modest-main-window.c: (on_account_update):
50 Very slight cleanup, hoping to make it simpler to discover what causes
51 a crash here sometimes.
53 * src/modest-tny-account.c:
54 (modest_tny_account_new_from_server_account): Set the port. Added
55 comments about the options and a TODO comment because I need to find out
56 how to specify the secure authentication method.
58 2007-05-11 Marcus Bauer <marcusb@openismus.com>
60 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
61 changed CFlags paths form modest to libmodest
63 2007-05-10 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-account-mgr-helpers.c:
66 (modest_account_mgr_get_server_account_data),
67 (modest_account_mgr_free_server_account_data):
68 * src/modest-account-mgr-helpers.h:
69 * src/modest-account-mgr.c:
70 (modest_account_mgr_add_server_account):
72 * src/modest-tny-account.c:
73 (modest_tny_account_new_from_server_account):
74 Determine the options for tny_camel_account_add_option() here,
75 based on the settings, rather than storing them directly in gconf.
77 2007-05-10 Murray Cumming <murrayc@murrayc.com>
79 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
80 Show a more friendly error dialog now that we expect (from the tinymail
81 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
83 2007-05-10 Murray Cumming <murrayc@murrayc.com>
85 * src/maemo/modest-main-window.c: (on_account_update): Check that
86 account_name is not NULL, to prevent a crash at startup that I am
87 seeing on the N800. I do wonder why it is NULL.
89 * src/maemo/easysetup/modest-easysetup-wizard.c:
90 (create_page_user_details):
91 * src/maemo/modest-account-settings-dialog.c:
92 (create_page_user_details), (create_page_outgoing):
93 * src/maemo/modest-connection-specific-smtp-edit-window.c:
94 (modest_connection_specific_smtp_edit_window_init):
95 * src/modest-ui-actions.c:
96 (modest_ui_actions_on_password_requested):
97 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
98 might do something useful with the on-screen keyboard.
100 2007-05-10 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-main-window.c: (on_account_update):
103 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
104 NULL, to avoid lots of warnings. However, it probably should not be NULL.
106 2007-05-09 Murray Cumming <murrayc@murrayc.com>
108 * src/modest-tny-account-store.c: (on_account_changed):
109 Correct the signature of this signal handler.
111 2007-05-09 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
114 Show a HildonNote instead of a GtkDialog for Maemo.
116 2007-05-09 Murray Cumming <murrayc@murrayc.com>
118 * src/widgets/modest-account-view.h:
119 * src/widgets/modest-account-view.c: (on_account_changed),
120 (on_account_removed). Added a boolean flag, set/unset by
121 modest_account_view_block_conf_updates(),
122 modest_account_view_unblock_conf_updates() to prevent unnecessary
123 updates, but this is not very useful because the gconf notifications are
124 so delays (maybe only on Maemo Bora).
125 So auto-updating is turned off, and these functions do an explicit
126 update when necessary.
127 However, something else is still doing too much work when adding/removing
128 accounts, probably in another part of the application.
130 * src/maemo/modest-account-view-window.c:
131 (on_delete_button_clicked), (on_edit_button_clicked),
132 (on_new_button_clicked): Use the new functions.
134 2007-05-09 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-account-mgr-helpers.c:
137 (modest_account_mgr_set_first_account_as_default):
138 Sort the list of names alphabetically-by-title, so we choose the first one
140 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
141 alphabetically by the title.
143 This fixes projects.maemo.org bug NB#56418 .
145 * src/modest-account-mgr-priv.c:
146 (_modest_account_mgr_account_from_key):
147 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
148 avoid a valgrind error, and possible random behaviour.
150 2007-05-09 Murray Cumming <murrayc@murrayc.com>
152 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
153 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
154 tinymail documentation to say that this can be expected.
155 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
156 pretty, and should not happen, but I would prefer to know when it does.
158 2007-05-09 Murray Cumming <murrayc@murrayc.com>
160 * configure.ac: When using the older hildon version, probably on Bora,
161 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
163 * src/widgets/modest-attachment-view.c:
164 (modest_attachment_view_set_part_default): Initialize variables, to fix the
167 2007-05-09 Marcus Bauer <marcusb@openismus.com>
169 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
170 Implemented the prototype. Can be tested with
171 tests/dbus_api/test_open_message:
173 2007-05-08 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-tny-account-store.c:
176 (modest_tny_account_store_instance_init), (get_password):
177 * src/modest-ui-actions.c:
178 (modest_ui_actions_on_password_requested):
179 Do not store the password in gconf, because this function is called
180 for non-remembered passwords. Actually use the cached (in the hash map)
181 password instead of releasing it.
182 The password will now not be remembered if it is asked via the protected
183 password dialog, as per the UI spec.
185 2007-05-08 Murray Cumming <murrayc@murrayc.com>
188 * src/modest-account-mgr-helpers.h:
189 * src/modest-account-mgr-helpers.c:
190 Added modest_server_account_get_username_has_succeeded(),
191 modest_server_account_set_username_has_succeeded().
192 (modest_server_account_set_username),
193 Reset the has-succeeded flag if the username changes.
195 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
196 * src/maemo/modest-connection-specific-smtp-window.c:
197 (modest_connection_specific_smtp_window_save_server_accounts):
198 Use modest_server_account_set_username() instead of using
199 modest_conf_set_string() directly, so that the has-succeeded flag is always
202 * src/modest-ui-actions.c:
203 (modest_ui_actions_on_password_requested): Dim the username entry if
204 the username has ever worked, as per the UI spec.
206 2007-05-08 Murray Cumming <murrayc@murrayc.com>
208 * src/modest-tny-account-store.c: (get_password):
209 * src/modest-ui-actions.c:
210 (modest_ui_actions_on_password_requested):
211 Allow the username to be changed too, though there is more work to
212 be done on exactly how this behaves.
214 2007-05-08 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-account-mgr-helpers.h:
217 * src/modest-account-mgr-helpers.c:
218 Added modest_account_mgr_get_display_name(),
219 modest_server_account_get_username(),
220 modest_server_account_set_username(),
221 modest_server_account_set_password(),
222 modest_server_account_get_hostname() functions so we do not need to
223 use the conf API directly.
225 * src/maemo/modest-main-window.c: (connect_signals):
226 Actually connect ot the ModestAccountStore::request-password signal,
227 so that we show the dialog when the password is requested by Tinymail,
228 for isntance if it is empty.
230 * src/modest-marshal.list:
231 * src/modest-tny-account-store.c:
232 (modest_tny_account_store_class_init), (get_password),
233 (modest_tny_account_store_alert):
234 * src/modest-tny-account-store.h:
235 * src/modest-ui-actions.h:
236 * src/modest-ui-actions.c:
237 (modest_ui_actions_on_password_requested):
238 Change the signal parameters, so it is obvious that we are providing
239 the non human-readable server name, and receiving both the username
240 and password, though changing of the username is not yet implemented.
241 Change the dialog UI to match the Maemo UI specifications, with #idfefing
242 for the GNOME version.
244 This should fix the projects.maemo.org bug NB#56209, though it does not
245 work on Bora, because the gconf_client_get() for the password fails
246 immediately after we save it with gconf_client_set().
248 2007-05-08 Murray Cumming <murrayc@murrayc.com>
251 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
252 caused an undefined symbol error:
253 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
255 2007-05-08 Murray Cumming <murrayc@murrayc.com>
257 * src/modest-tny-account-store.c:
258 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
259 using a GError instead of a string message, so we can translate it in
262 2007-05-08 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-address-book.c:
265 (modest_address_book_check_names):
266 * src/maemo/modest-msg-view-window.c:
267 (modest_msg_view_window_clipboard_owner_change):
268 * src/modest-init.c: (modest_init_init_ui):
269 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
270 (update_folders_cb), (modest_mail_operation_update_account):
271 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
272 (modest_ui_actions_on_msg_attachment_clicked),
273 (modest_ui_actions_on_msg_recpt_activated):
274 * src/widgets/modest-header-view.c: (drag_data_get_cb):
275 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
276 (modest_msg_view_search_next):
277 * src/widgets/modest-recpt-editor.c:
278 (modest_recpt_editor_on_button_release_event),
279 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
280 g_message(). At this point we should only be seeing interesting errors on
281 stdout. Debugging messages could be #ifdefed-out if they are still useful.
283 2007-05-07 Murray Cumming <murrayc@murrayc.com>
285 (modest_wizard_dialog_force_title_update):
286 * src/maemo/easysetup/modest-wizard-dialog.h:
287 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
288 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
289 can update the title when appropriate. Otherwise the title is wrong if the
290 pages are added after adding the notebook to the dialog.
291 This must be a problem in HildonWizardDialog too.
292 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
294 * src/maemo/easysetup/modest-easysetup-wizard.c:
295 (create_subsequent_customsetup_pages),
296 (create_subsequent_easysetup_pages):
297 Call modest_wizard_dialog_force_title_update() so that the title is
298 correct even with GTK+ < 2.10.
299 This fixes projects.maemo.org bug NB#56145 .
301 2007-05-07 Murray Cumming <murrayc@murrayc.com>
303 * src/maemo/modest-platform.c:
304 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
305 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
308 2007-05-07 Murray Cumming <murrayc@murrayc.com>
310 * src/widgets/modest-window.h:
311 * src/widgets/modest-window.c: Added a save_state_func vfunc,
312 and modest_window_save_state(), which invokes it.
314 * src/widgets/modest-window-mgr.h:
315 * src/widgets/modest-window-mgr.c:
316 Added modest_window_mgr_save_state_for_all_windows(), which calls
317 the save_state vfunc on all registered windows, if implemented.
319 * src/gnome/modest-msg-edit-window.c:
320 * src/gnome/modest-msg-view-window.c:
321 * src/maemo/modest-msg-edit-window.c:
322 * src/maemo/modest-msg-view-window.c:
323 * src/maemo/modest-main-window.c:
324 Specify the existing save_settings functions as implementations of
325 ModestWindow::save_state_func().
327 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
328 Call modest_window_mgr_save_state_for_all_windows(). This happens before
329 enabling hibernation, for instance.
331 We may need to do the same thing for restoring settings.
334 2007-05-07 Murray Cumming <murrayc@murrayc.com>
336 * src/widgets/modest-window-mgr.c:
337 * src/widgets/modest-window-mgr.h:
338 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
339 modest_window_mgr_get_hibernation_is_prevented().
341 * src/maemo/modest-main-window.c:
342 (on_hildon_program_is_topmost_notify): Prevent hibernation
343 (possible when the application goes to the background in the WM),
344 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
346 * src/maemo/easysetup/modest-easysetup-wizard.c:
347 (modest_easysetup_wizard_dialog_init):
348 * src/maemo/modest-account-settings-dialog.c:
349 (modest_account_settings_dialog_init):
350 * src/maemo/modest-connection-specific-smtp-edit-window.c:
351 (modest_connection_specific_smtp_edit_window_init):
352 * src/maemo/modest-connection-specific-smtp-window.c:
353 (modest_connection_specific_smtp_window_init):
354 * src/maemo/modest-signature-editor-dialog.c:
355 (modest_signature_editor_dialog_init):
356 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
357 prevent hibernation while any of these account settings dialogs are open.
359 2007-05-04 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/Makefile.am:
362 * src/maemo/modest-osso-state-saving.c:
363 * src/maemo/modest-osso-state-saving.h: Added
364 modest_osso_load_state() and modest_osso_save_state() though they do
365 nothing now. They should iterate through all the open windows and load/save
367 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
368 save state when closing.
370 * src/maemo/modest-main-window.c:
371 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
372 Add a notification handler for the HildonProgram::is-topmost property,
373 so we can allow hibernation when the application goes into the background.
374 But we still need to detect when the accounts setup windows are open so
375 we can stop hibernation when they are open.
376 To do this, I also added the main window the HildonProgram. This might have
377 other side-effects/benefits, and should maybe be done for other windows.
379 * src/maemo/modest-osso-autosave-callbacks.h:
380 * src/maemo/modest-osso-autosave-callbacks.c:
381 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
382 though it does not do anything yet, and we might never need this to do
383 anything. For instance, we already save drafts.
385 * src/maemo/modest-platform.c: (modest_platform_init):
386 Specify the libosso auto-save callback.
388 2007-05-03 Murray Cumming <murrayc@murrayc.com>
390 * src/maemo/modest-platform.c:
391 (modest_platform_set_update_interval):
392 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
393 aparently stays valid between application instances, so we can use this
394 to remove and reset it later. According to a maemo-developers email from
397 2007-05-03 Murray Cumming <murrayc@murrayc.com>
399 * configure.ac: Depend on libalarm for Maemo.
401 * src/dbus_api/modest-dbus-api.h:
402 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
403 (on_send_receive), (modest_dbus_req_handler):
404 Handle a SEND_RECEIVE D-Bus method.
406 * libmodest-dbus-client/libmodest-dbus-client.c:
407 (libmodest_dbus_client_send_and_receive):
408 * libmodest-dbus-client/libmodest-dbus-client.h:
409 Add C convenience functions for calling the new D-Bus method.
411 * src/modest-platform.h:
412 * src/gnome/modest-platform.c:
413 * src/maemo/modest-platform.c:
414 Added modest_platform_set_update_interval(), which uses the
416 (modest_platform_init),
417 Call modest_platform_set_update_interval(), using a hard-coded
418 interval for now (until the global settings dialog is implemented),
419 though I am not sure that this makes sense yet.
421 2007-05-02 Murray Cumming <murrayc@murrayc.com>
423 * src/dbus_api/modest-dbus-callbacks.c:
424 (modest_osso_cb_hw_state_handler):
425 * src/dbus_api/modest-dbus-callbacks.h:
426 * src/maemo/modest-platform.c: (modest_platform_init):
427 Registered (empty) callbacks for the osso hardware state D-Bus signals,
428 in case this has some effect on the ability for Maemo to ping the
431 2007-05-02 Murray Cumming <murrayc@murrayc.com>
433 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
434 Comment out an if() that checks a gchar for < 0, causing a build-breaking
435 warning. It is probably a logic error, but I need to fix the build.
437 2007-05-02 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-account-mgr.h:
440 * src/modest-account-mgr.c:
441 (modest_account_mgr_account_names): Add a gboolean enabled_only
442 parameter, so we can get lists of onlt the enabled accounts.
444 (modest_account_mgr_add_account),,
445 (modest_account_mgr_account_with_display_name_exists):
446 * src/maemo/modest-msg-edit-window.c: (get_transports):
447 * src/modest-account-mgr-helpers.c:
448 (modest_account_mgr_set_first_account_as_default):
449 * src/modest-init.c: (init_default_account_maybe):
450 * src/modest-tny-account-store.c: (get_accounts):
451 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
452 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
453 * tests/check_account-mgr.c: (START_TEST):
454 Provide the extra parameter, as appropriate.
456 * src/widgets/modest-account-view.c: (update_account_view):
457 Do not show disabled accounts (meaning that there is no way to
458 enable/disable accounts in the UI (the feature is not in our UI
459 specification), so we can use this internally only to mark unfinished
460 or temporary account data.
462 * src/maemo/easysetup/modest-easysetup-wizard.c:
463 (create_account): Add boolean enable parameter, so we can specify FALSE
464 to create the temporary account.
465 (on_button_edit_advanced_settings): Create the temporary account as disabled.
466 (on_before_next): When finishing, when there is a temporary account, just
468 Also, use a timeout to delay the showing of the dialog until gconf is likely
469 to return correct information, due to a maemo gconf bug that is fixed in
470 osso 1.1, but not yet in Bora.
471 However, the dialog stays on screen after it is destroyed.
473 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
474 for invalid data when cancelling. Use a hildon note instead of a dialog
475 to complain about invalid data. Do not show the account-saved note if the
476 account is disabled (a temporary account that will not really be saved for use
479 2007-04-30 Murray Cumming <murrayc@murrayc.com>
481 * src/modest-account-mgr-helpers.h:
482 * src/modest-account-mgr-helpers.c:
483 Added modest_account_mgr_unset_default_account(),
484 Added modest_account_mgr_set_first_account_as_default().
486 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
487 If it was the default account, unset the default account name.
489 * src/maemo/modest-account-view-window.c:
490 (on_delete_button_clicked): If it was the default account,
491 set the first remaining account as the default instead.
493 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
494 a NULL account or a NULL default account, to prevent a crash. This should
495 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
498 2007-04-30 Murray Cumming <murrayc@murrayc.com>
500 * src/widgets/modest-recpt-editor.c:
501 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
502 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
503 TODO comment for this. This fixes the build.
505 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
506 be the best place for it. This will in future update all auto-update accounts,
507 rather than just the current/default account, when that gconf key exists.
508 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
509 if there are no accounts, before calling do_send_receive().
510 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
512 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
513 * src/maemo/modest-main-window-ui.h:
514 * src/maemo/modest-main-window.c: (on_connection_changed),
515 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
516 directly, becaue the signal handler does more.
518 2007-04-30 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-account-mgr-helpers.c:
521 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
522 for the case that the account does not exist.
524 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
525 (equivalent to the modest account name) rather than the tinymail account name
526 (equivalent to the modest account title - human readable) to get the account data.
527 Check for null account data to prevent the crash, and add a TODO comment saying that
528 this needs fixing because it is using the server account name instead of the account name.
530 2007-04-29 Murray Cumming <murrayc@murrayc.com>
532 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
533 * src/maemo/modest-account-settings-dialog.c: (show_error),
535 Use hildon_note_new_information() for informative and error messages,
536 which seems to be expected for Maemo applications (no documentation that I know of
537 says this). I am surprised that there is no distinction between info and error
540 2007-04-29 Murray Cumming <murrayc@murrayc.com>
542 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
543 it is easy to find where this is used.
545 * src/maemo/easysetup/modest-easysetup-wizard.c:
546 (create_page_welcome), (create_page_account_details),
547 (create_page_user_details), (create_page_complete_easysetup),
548 (create_page_custom_incoming), (create_page_custom_outgoing),
549 (create_page_complete_custom):
550 * src/maemo/modest-account-settings-dialog.c:
551 (create_page_account_details), (create_page_user_details),
552 (create_page_incoming), (create_page_outgoing):
553 * src/maemo/modest-account-view-window.c: (window_vbox_new):
554 * src/maemo/modest-connection-specific-smtp-edit-window.c:
555 (modest_connection_specific_smtp_edit_window_init):
556 * src/maemo/modest-connection-specific-smtp-window.c:
557 (modest_connection_specific_smtp_window_init):
558 * src/maemo/modest-signature-editor-dialog.c:
559 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
560 and scrolling policy as per the Email Application Layout Guide, if I have
563 2007-04-27 Murray Cumming <murrayc@murrayc.com>
565 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
566 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
567 which were empty, because these vfuncs have been removed from TnyAccountStore.
568 This fixes the build.
570 2007-04-27 Murray Cumming <murrayc@murrayc.com>
572 * src/maemo/modest-main-window.c:
573 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
574 showing/hiding it. Added TODO because it probably should not be NULL.
575 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
576 because unnecessary g_warnings() make degugging difficult.
578 2007-04-27 Murray Cumming <murrayc@murrayc.com>
580 * src/maemo/modest-msg-edit-window.c:
581 (modest_msg_edit_window_select_color),
582 (modest_msg_edit_window_select_background_color): 2 const corrections and
583 moving 2 #endifs before closing brackets, to fix the build.
585 2007-04-27 Murray Cumming <murrayc@murrayc.com>
587 * src/maemo/easysetup/modest-easysetup-wizard.h:
588 * src/maemo/easysetup/modest-easysetup-wizard.c:
589 (modest_easysetup_wizard_dialog_finalize),
590 (on_button_edit_advanced_settings), (create_page_complete_custom),
591 (on_response), (create_account):
592 Implement the Advanced Settings edit button, by saving the account information,
593 for the Advanded Settings dialog to use directly from gconf, and removing it
594 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
595 Bug #5533 in the projects.maemo.org bugzilla.
597 2007-04-27 Murray Cumming <murrayc@murrayc.com>
599 * src/maemo/modest-msg-view-window.c:
600 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
601 when opening a message window.
603 2007-04-27 Murray Cumming <murrayc@murrayc.com>
605 * src/maemo/easysetup/modest-easysetup-wizard.c:
606 (create_page_custom_outgoing): Correct the position of the horizontal separator to
609 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
610 before showing/hiding them, to avoid a crash when clicking on folders when there are no
611 gconf settings. I probably added more checks than necessary, but that is safer.
613 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
614 variable to fix the build, but this seems to be used when it is still NULL.
616 2007-04-27 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-platform.h:
619 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
620 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
621 * src/modest-main.c: Implement this function so we can avoid using
622 maemo-specific API from cross-platform code.
624 * src/modest-tny-account-store.c:
625 (get_smtp_specific_transport_account_for_open_connection):
626 * src/modest-ui-actions.c: (check_for_connection),
627 (modest_ui_actions_on_item_not_found):
628 Use modest_platform_connect_and_wait() and put #idefs around other
629 maemo-specific code, because only maemo currently has a way to
630 identify connection names.
632 2007-04-27 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-tny-account-store.h:
635 * src/modest-tny-account-store.c:
636 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
637 the connection-specific SMTP server settings in the configuration.
639 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
641 * src/maemo/modest-main-window.c: (on_connection_changed),
643 * src/modest-main.c: (main), (start_ui), (send_mail):
644 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
645 that is what is intended.
647 * src/modest-ui-actions.c: (action_send), (action_receive),
648 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
649 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
650 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
651 SMTP server is used when it is specified.
653 (modest_ui_actions_on_send_receive):
654 Check that a connection is open before proceeding.
655 Receive and then send, instead of vice-versa, as per the specification.
657 2007-04-26 Murray Cumming <murrayc@murrayc.com>
659 * src/modest-mail-operation.c:
660 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
661 though I guess it should be something other than NULL.
663 2007-04-26 Murray Cumming <murrayc@murrayc.com>
665 * src/maemo/easysetup/modest-easysetup-wizard.c:
666 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
667 combo twice, to avoid an g_warning and to make it visible again.
668 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
669 attached before detaching it, to avoid a g_warning, and add comment about the implicit
670 (already intended) dereference when detaching, because we then recreate the menu.
671 But I am not sure why the warning was happening, and it is possible that this is a memory
674 2007-04-25 Murray Cumming <murrayc@murrayc.com>
676 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
677 and uri_parse_mailto() utility functions.
678 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
680 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
682 2007-04-24 Murray Cumming <murrayc@murrayc.com>
684 * src/dbus_api/modest-dbus-api.h:
685 * src/dbus_api/modest-dbus-callbacks.c:
686 Use an idle callback to execute the modest code in the application's own thread.
687 Remove the helloworld example method.
688 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
689 parsed, and the open-message method is not implemented because this is not yet implemented in
691 * libmodest-dbus-client/libmodest-dbus-client.c:
692 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
693 (libmodest_dbus_client_open_message):
694 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
696 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
697 body without crashing.
699 * tests/dbus_api/Makefile.am:
700 * tests/dbus_api/test_mail_to.c:
701 * tests/dbus_api/test_open_message.c: New tests for the new methods.
703 2007-04-24 Murray Cumming <murrayc@murrayc.com>
705 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
706 Added file to fix the build. Sorry.
708 * src/dbus_api/Makefile.am:
709 * src/dbus_api/modest-dbus-api.h:
710 * src/dbus_api/modest-dbus-callbacks.h:
711 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
712 (modest_dbus_req_handler):
713 Put constants in a separate header so it can be reused by the
714 client library, without duplication
716 * libmodest-dbus-client/Makefile.am:
717 * libmodest-dbus-client/libmodest-dbus-client.c:
718 (libmodest_dbus_client_call_helloworld),
719 (libmodfest_dbus_client_send_mail),
720 (libmodfest_dbus_client_mailto),
721 (libmodfest_dbus_client_open_message):
722 * libmodest-dbus-client/libmodest-dbus-client.h:
723 (Partly) Implement a send_mail D-Bus method.
725 * tests/dbus_api/Makefile.am:
726 * tests/dbus_api/test_send_mail.c: (main): Added a test for
727 the send_email D-Bus method.
729 2007-04-24 Murray Cumming <murrayc@murrayc.com>
733 * libmodest-dbus-client/Makefile.am:
734 * libmodest-dbus-client/libmodest-dbus-client.c:
735 * libmodest-dbus-client/libmodest-dbus-client.h:
736 * tests/dbus_api/Makefile.am:
737 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
738 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
740 2007-04-24 Murray Cumming <murrayc@murrayc.com>
742 * src/maemo/easysetup/modest-easysetup-wizard.c:
743 (create_page_account_details):
744 * src/maemo/modest-account-settings-dialog.c:
745 (create_page_account_details): Explicitly set auto-capitalization mode for the title
746 widgets, because this might not be the default in future versions of the Maemo GTK+.
747 However, I can not not get capitalization to work even in a simple test case.
749 2007-04-24 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/easysetup/modest-easysetup-wizard.c:
752 (create_page_custom_incoming), (create_page_custom_outgoing):
753 * src/maemo/modest-account-settings-dialog.c:
754 (create_page_account_details), (create_page_incoming),
755 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
756 instead of using gtk_check_button_with_label(), so they are aligned like the other
757 widgets, as per the UI spec.
759 2007-04-24 Murray Cumming <murrayc@murrayc.com>
761 * src/maemo/easysetup/modest-easysetup-wizard.c:
762 * src/maemo/modest-connection-specific-smtp-edit-window.c:
763 * src/widgets/modest-validating-entry.c:
764 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
765 Modest prefix instead of an EasySetup prefix.
767 2007-04-23 Murray Cumming <murrayc@murrayc.com>
769 * src/widgets/modest-validating-entry.h:
770 * src/widgets/modest-validating-entry.c: (on_insert_text),
771 Added easysetup_validating_entry_set_max_func(), used to set a callback
772 to call when the max number of characters is reached. GtkEntry has a max-length
773 already but is silent about it.
775 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
776 (create_page_account_details), (create_page_user_details),
778 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
779 (create_page_account_details), (create_page_user_details),
780 (create_page_outgoing):
781 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
782 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
783 the UI spec, when the user tries to enter more than the max number of characters.
785 2007-04-23 Murray Cumming <murrayc@murrayc.com>
787 * src/maemo/easysetup/modest-easysetup-wizard.c:
788 (create_page_user_details), (create_page_custom_incoming),
789 (create_page_custom_outgoing):
790 * src/maemo/modest-account-settings-dialog.c:
791 (create_page_user_details), (create_page_incoming),
792 (create_page_outgoing):
793 * src/maemo/modest-connection-specific-smtp-edit-window.c:
794 (modest_connection_specific_smtp_edit_window_init):
795 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
796 not appropriate. Bad Maemo-specific defaults!.
798 2007-04-23 Murray Cumming <murrayc@murrayc.com>
800 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
801 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
802 (modest_signature_editor_dialog_set_settings):
803 Disable the label and textview when the checkbox is disabled, and use the
804 specified (UI spec) default signature text.
806 2007-04-23 Murray Cumming <murrayc@murrayc.com>
808 * src/maemo/modest-connection-specific-smtp-edit-window.c:
809 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
812 * src/modest-account-mgr-helpers.h:
813 * src/modest-account-mgr-helpers.c:
814 Added modest_account_mgr_get/set_signature(), using new gconf keys.
816 * src/maemo/Makefile.am:
817 * src/maemo/modest-signature-editor-dialog.c:
818 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
821 * src/maemo/modest-account-settings-dialog.h:
822 * src/maemo/modest-account-settings-dialog.c:
823 (modest_account_settings_dialog_finalize), (on_button_signature),
824 (save_configuration): Use the new dialog when the Edit button is pressed, and
825 save the changes if necessary, as per the UI spec.
827 2007-04-23 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/Makefile.am:
830 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
831 based on maemo-develoers email from Dirk.
833 * src/maemo/easysetup/modest-easysetup-wizard.c:
834 (create_page_welcome), (create_page_account_details),
835 (create_page_user_details), (create_page_complete_easysetup),
836 (create_page_custom_incoming), (create_page_custom_outgoing),
837 (create_page_complete_custom),
838 (modest_easysetup_wizard_dialog_init):
839 * src/maemo/modest-account-settings-dialog.c:
840 (create_page_account_details), (create_page_user_details),
841 (create_page_incoming), (create_page_outgoing),
842 (modest_account_settings_dialog_init):
843 * src/maemo/modest-connection-specific-smtp-window.c:
844 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
846 2007-04-23 Murray Cumming <murrayc@murrayc.com>
848 * src/maemo/easysetup/modest-easysetup-wizard.c:
849 (create_page_account_details), (create_page_custom_outgoing),
850 (create_page_complete_custom):
851 * src/maemo/modest-account-settings-dialog.c:
852 (create_page_user_details), (create_page_incoming),
853 (create_page_outgoing):
854 * src/maemo/modest-connection-specific-smtp-edit-window.c:
855 (modest_connection_specific_smtp_edit_window_init):
856 Use the correct (UI spec) port min/max, and use horizontal separators,
859 2007-04-23 Murray Cumming <murrayc@murrayc.com>
861 * src/maemo/easysetup/modest-easysetup-wizard.c:
862 (set_default_custom_servernames):
863 * src/maemo/modest-account-settings-dialog.c:
864 (create_page_incoming), (on_combo_outgoing_security_changed),
865 (on_combo_incoming_security_changed), (create_page_outgoing),
866 (modest_account_settings_dialog_set_account_name),
867 (save_configuration):
868 * src/maemo/modest-connection-specific-smtp-edit-window.c:
869 (on_combo_security_changed),
870 (modest_connection_specific_smtp_edit_window_init),
871 (modest_connection_specific_smtp_edit_window_set_connection),
872 (modest_connection_specific_smtp_edit_window_get_settings):
873 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
876 2007-04-20 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/easysetup/modest-easysetup-wizard.c:
880 (create_page_custom_outgoing), (create_page_complete_custom):
881 * src/maemo/modest-account-settings-dialog.c:
882 (create_page_user_details), (create_page_outgoing):
883 * src/maemo/modest-account-view-window.c: (button_box_new):
884 Use changed logical IDs as per the most recent UI spec:
885 mcen_bd_emailsetup_edit -> mcen_bd_edit
886 mcen_bd_emailsetup_delete -> mcen_bd_delete
887 mcen_bd_emailsetup_close -> mcen_bd_close
889 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
893 * src/dbus_api/Makefile.am:
894 * src/dbus_api/modest-dbus-callbacks.c:
895 * src/dbus_api/modest-dbus-callbacks.h:
896 * src/maemo/modest-platform.c: (modest_platform_init):
897 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
900 * tests/dbus_api/Makefile.am:
901 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
903 2007-04-20 Murray Cumming <murrayc@murrayc.com>
905 * src/maemo/modest-account-settings-dialog.c:
906 * src/maemo/modest-connection-specific-smtp-edit-window.c:
907 Removed unnecessary includes.
909 2007-04-20 Murray Cumming <murrayc@murrayc.com>
911 * src/maemo/easysetup/modest-easysetup-wizard.c:
912 * src/maemo/modest-account-settings-dialog.c:
913 * src/maemo/modest-connection-specific-smtp-edit-window.c:
914 * src/widgets/Makefile.am:
915 * src/widgets/modest-easysetup-secureauth-combo-box.c:
916 * src/widgets/modest-easysetup-secureauth-combo-box.h:
917 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
918 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
919 * src/widgets/modest-secureauth-combo-box.c:
920 * src/widgets/modest-secureauth-combo-box.h:
921 * src/widgets/modest-serversecurity-combo-box.c:
922 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
923 made the GObject names more consistent with the rest of the Modest code.
925 2007-04-20 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/easysetup/Makefile.am:
928 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
929 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
930 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
931 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
932 * src/maemo/easysetup/modest-easysetup-wizard.c:
933 * src/maemo/easysetup/modest-validating-entry.c:
934 * src/maemo/easysetup/modest-validating-entry.h:
935 * src/maemo/modest-account-settings-dialog.c:
936 * src/maemo/modest-connection-specific-smtp-edit-window.c:
937 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
938 widgets/ because they are used outside of easysetup too. After checking in,
939 svn will allow me to rename them too.
941 2007-04-20 Murray Cumming <murrayc@murrayc.com>
943 * src/gnome/modest-msg-edit-window.c:
944 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
945 linker error, to fix the build on the GNOME platform.
946 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
947 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
948 ifdefed out to avoid a warning.
950 2007-04-20 Murray Cumming <murrayc@murrayc.com>
952 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
953 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
954 some alternative for GTK+ 2.6.
956 2007-04-19 Murray Cumming <murrayc@murrayc.com>
958 * src/maemo/modest-address-book.c: Added include to avoid a warning.
960 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
961 specified for EmailAccountsDialog in UI spec.
963 * src/maemo/easysetup/modest-easysetup-wizard.c:
964 * src/maemo/easysetup/modest-easysetup-wizard.h:
965 * src/maemo/modest-account-settings-dialog.c:
966 * src/maemo/modest-account-settings-dialog.h:
967 Reuse a member window widget for the connection-specific SMTP server accounts,
968 so we can tell it to create/save the accounts only if we actually save changes.
970 * src/maemo/modest-connection-specific-smtp-edit-window.h:
971 * src/maemo/modest-connection-specific-smtp-edit-window.c:
972 (modest_connection_specific_smtp_edit_window_get_settings):
973 Return a struct instance for temporarily remembering the entered data.
975 * src/maemo/modest-connection-specific-smtp-window.h:
976 * src/maemo/modest-connection-specific-smtp-window.c:
977 (modest_connection_specific_smtp_window_finalize),
978 (modest_connection_specific_smtp_window_fill_with_connections),
980 (modest_connection_specific_smtp_window_save_server_accounts),
981 (update_model_server_names): Do not actually save data until asked,
982 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
984 (on_selection_changed),
985 (modest_connection_specific_smtp_window_init): Disable the edit
986 button when nothing is selected.
988 * src/modest-account-mgr-helpers.c:
989 * src/modest-account-mgr-helpers.h:
990 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
993 2007-04-19 Murray Cumming <murrayc@murrayc.com>
995 * src/modest-account-mgr-helpers.h:
996 * src/modest-account-mgr-helpers.c:
997 (modest_account_mgr_get_unused_account_name),
998 (modest_account_mgr_get_unused_account_display_name): Added these
999 utility functions, to avoid code duplication.
1001 * src/maemo/easysetup/modest-easysetup-wizard.c:
1002 (create_page_account_details), (create_account):
1003 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1004 (on_combo_security_changed),
1005 (modest_connection_specific_smtp_edit_window_init),
1006 (modest_connection_specific_smtp_edit_window_save_settings):
1007 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1008 * src/maemo/modest-connection-specific-smtp-window.c:
1009 (modest_connection_specific_smtp_window_finalize),
1010 (modest_connection_specific_smtp_window_fill_with_connections),
1011 (on_button_edit), (modest_connection_specific_smtp_window_init):
1012 * src/maemo/modest-connection-specific-smtp-window.h:
1013 Implementing saving of connection-specific server accounts.
1015 But I need to refactor this so we can save the data for each
1016 possible connection-specific account and only actually create the server accounts
1017 when the easysetup finished, or the OK button is pressed on the account settings
1020 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1022 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1023 (on_combo_security_changed):
1024 (modest_connection_specific_smtp_edit_window_init):
1025 Auto-fill the port number as in the account settings.
1027 (modest_connection_specific_smtp_edit_window_set_connection):
1028 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1029 * src/maemo/modest-connection-specific-smtp-window.c:
1030 (fill_with_connections), (on_button_edit),
1031 (modest_connection_specific_smtp_window_init):
1032 Turn the edit window into a dialog to simplify the code, and
1033 set a WM hint as in a GtkDialog, because only a popup can be on top of
1034 another window in Maemo, and popups usually have no WM decoration.
1036 * src/modest-defs.h:
1037 * src/modest-account-mgr-helpers.c:
1038 (modest_account_mgr_set_connection_specific_smtp),
1039 (modest_account_mgr_remove_connection_specific_smtp),
1040 (modest_account_mgr_get_connection_specific_smtp):
1041 * src/modest-account-mgr-helpers.h: Some functions to write the
1042 connection-specific SMTP server information. Not yet used.
1045 * src/widgets/modest-folder-view.c: (text_cell_data):
1046 Fix a warning about an uninitialized variable.
1047 (on_configuration_key_changed): Put an #ifdef around the use
1048 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1050 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-account-settings-dialog.h:
1053 * src/maemo/modest-account-settings-dialog.c:
1054 Added connect_for_modified() utility function to mark the new modified boolean.
1056 (create_page_account_details), (create_page_user_details),
1057 (create_page_incoming), (create_page_outgoing), (on_response),
1058 (modest_account_settings_dialog_init),
1059 (modest_account_settings_dialog_set_account_name):
1060 Only warn about unsaved changes when there are actually unsaved changes.
1062 * src/modest-account-mgr-helpers.c:
1063 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1064 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1065 to get the data from there in future.
1067 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1069 * src/modest-defs.h:
1071 * src/modest-account-mgr-helpers.h:
1072 * src/modest-account-mgr-helpers.c:
1073 Store the security account setting in a single conf key instead of using
1074 the options list, so that the list is left for just the to-be-removed camel hack,
1075 and because gconf_client_set_list() is failing for some reason.
1077 * src/modest-account-mgr.c:
1078 (modest_account_mgr_add_server_account):
1079 * src/maemo/modest-account-settings-dialog.c:
1080 (modest_account_settings_dialog_set_account_name),
1081 (save_configuration): Use the renamed functions.
1084 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1086 * src/widgets/Makefile.am:
1087 * src/widgets/modest-limit-retrieve-combo-box.c:
1088 * src/widgets/modest-limit-retrieve-combo-box.h:
1089 * src/widgets/modest-retrieve-combo-box.c:
1090 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1091 the account settings dialog.
1093 * src/modest-defs.h:
1094 * src/modest-account-mgr-helpers.h:
1095 * src/modest-account-mgr-helpers.c:
1096 (modest_server_account_get_option_secure_auth),
1097 (modest_server_account_set_option_secure_auth):
1098 * src/modest-account-mgr.c:
1099 (modest_account_mgr_add_server_account):
1100 Use the existing AUTH_MECH conf key for the secure-auth setting,
1101 instead of putting it in the list options, because this was actually used already.
1103 * src/maemo/modest-account-settings-dialog.c:
1104 (create_page_account_details),
1105 (modest_account_settings_dialog_set_account_name),
1106 (save_configuration):
1107 * src/maemo/modest-account-settings-dialog.h:
1108 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1109 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1111 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1113 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1114 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1115 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1117 * src/modest-defs.h:
1118 * src/maemo/modest-account-settings-dialog.c:
1119 (create_page_incoming), (on_combo_outgoing_security_changed),
1120 (on_combo_incoming_security_changed), (create_page_outgoing),
1121 (modest_account_settings_dialog_set_account_name),
1122 (save_configuration): Load/Save the port number, and change it when the
1123 security combo changes, to suitable defaults.
1125 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1127 * src/modest-account-mgr.c:
1128 (modest_account_mgr_add_server_account): Set the security and secure-auth
1129 options, and add a comment saying that the other camel-specific options should be
1132 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1134 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1136 * src/modest-tny-account-store.c: (account_list_free),
1137 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1138 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1141 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1143 * src/modest-protocol-info.c:
1144 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1145 is required by our UI spec. Maybe something in our implementation will use this eventually.
1146 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1147 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1148 instead of the previous 0 placeholder.
1150 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1151 secure-auth settings.
1152 * src/modest-account-mgr-helpers.h:
1153 * src/modest-account-mgr-helpers.c:
1154 (modest_server_account_data_get_option_secure_auth),
1155 (modest_server_account_set_option_secure_auth),
1156 (modest_server_account_data_get_option_security),
1157 (modest_server_account_set_option_security): Added this API for getting and setting the security
1158 and secure-auth settings.
1160 * src/maemo/modest-account-settings-dialog.h:
1161 * src/maemo/modest-account-settings-dialog.c:
1162 (modest_account_settings_dialog_finalize), (check_data),
1163 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1164 about changing titles.
1165 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1166 (save_configuration): Save the security and secure-auth settings.
1168 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1169 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1171 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1173 * src/modest-defs.h:
1174 * src/modest-account-mgr.c:
1175 (modest_account_mgr_add_server_account):
1176 Added and used defines for the options key and value pair strings,
1177 that are used so far, though they do not seem to correspond to anything in our
1178 UI specs or ModestProtocol enum.
1180 * src/modest-account-mgr-helpers.h:
1181 * src/modest-account-mgr-helpers.c:
1182 (compare_option_strings_for_name),
1183 (modest_server_account_data_get_option_value),
1184 (modest_server_account_data_get_option_bool),
1185 (modest_account_mgr_get_server_account_option):
1186 Added helper functions for parsing the options GSList.
1188 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1190 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1191 display name is based on the supplied account name.
1192 * src/modest-account-mgr.c:
1193 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1194 with an inefficient, but good-enough, implementation.
1196 * src/maemo/easysetup/modest-easysetup-wizard.c:
1197 (create_page_account_details), (on_before_next), (create_account):
1198 Check for existing display names rather than (non-user-visible) account names, and just
1199 create and set a unique account name at the end.
1201 * src/maemo/modest-account-settings-dialog.c:
1202 (modest_account_settings_dialog_init),
1203 (modest_account_settings_dialog_set_account_name),
1204 (create_page_incoming): Show the display name, instead of the account name.
1205 (on_response): Do some (not all) extra checks, as in the UI spec.
1206 (save_configuration): Save the display name if it was changed.
1208 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1210 * po/en_GB.po: Added needed logical ID and translation.
1211 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1212 (init_view): Made the is-default column clicking work.
1214 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1217 * src/maemo/easysetup/Makefile.am:
1218 * src/maemo/easysetup/modest-easysetup-wizard.c:
1219 (modest_easysetup_wizard_dialog_init):
1220 * src/maemo/easysetup/provider-data-test.keyfile:
1221 * src/maemo/easysetup/provider-data.keyfile:
1222 Moved the provider data file to the new modest-providers-data package and used it from there.
1224 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1226 * src/modest-local-folder-info.c:
1227 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1228 N_() was already used on the static strings, but this just marks it for translation without
1229 using the translation.
1231 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1233 * src/maemo/modest-account-settings-dialog.c:
1234 (create_page_incoming),
1235 (modest_account_settings_dialog_set_account_name):
1236 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1237 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1238 I will do this if nobody else gets there first.
1240 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1242 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1243 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1244 save the security stuff.
1246 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1248 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1249 Set the email address and user fullname, which I now see must be
1252 * src/maemo/modest-account-settings-dialog.h:
1253 * src/maemo/modest-account-settings-dialog.c:
1255 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1256 leave-on-server and authentication.
1257 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1260 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1263 * src/maemo/modest-account-settings-dialog.c:
1264 * src/maemo/modest-account-settings-dialog.h:
1265 Most (but not all) of the widgets are now present as specified by the UI spec.
1266 No changes are yet saved, and some details are not properly shown yet.
1268 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1270 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1272 * src/maemo/Makefile.am:
1273 * src/maemo/modest-account-settings-dialog.c:
1274 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1275 an existing account. Doesn't do much yet.
1277 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1278 Open the accounts settings dialog when Edit is clicked.
1280 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1282 * src/maemo/easysetup/Makefile.am:
1283 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1285 * src/maemo/easysetup/modest-easysetup-wizard.c:
1286 (modest_easysetup_wizard_dialog_init):
1287 Try to get the source directory from the build system,
1288 instead of hard-coding "./" into the source code, when opening our local
1289 copies of the configuration files.
1290 But this still fails when opening the wizard from the Accounts window,
1291 maybe because the working directory seems to change at runtime.
1292 So the wizard will fail the second time unless you copy the files into their
1293 proper locations - see the stdout warnings for the paths.
1295 (create_page_account_details),(on_before_next):
1296 Check for existing non-server accounts instead of server accounts,
1297 so the default account name is useful again, and to prevent trying to
1300 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1301 Show the wizard when New is clicked.
1303 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1304 (init_view): Show the column headers, and show the columns that are
1305 specified in the UI specs. However, something in Maemo's GTK+ prevents
1306 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1307 change the default account. This is despite unsetting the special properties.
1309 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1311 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1312 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1313 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1314 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1315 to make that clearer.
1316 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1318 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/modest-account-view-window.c:
1321 (modest_account_view_window_init),
1322 (modest_account_view_window_new):
1323 Use the same buttons as specified in the
1324 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1325 the existing widgets, which never had a chance of working.
1326 Put the ModestAccountView treeview in a scrolled window.
1327 Do not repeat the initialization in both _init() and _new().
1329 * src/widgets/modest-account-view.c: (update_account_view):
1330 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1331 this widget and window shows no accounts.
1333 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1335 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1337 * src/maemo/easysetup/modest-easysetup-wizard.c:
1338 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1339 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1340 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1343 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1344 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1345 accounts exist yet, as in the UI spec.
1347 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1349 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/Makefile.am:
1352 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1353 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1354 New window for editing connection-specific smtp details.
1355 Not fully implemented.
1357 * src/maemo/modest-connection-specific-smtp-window.c:
1358 (modest_connection_specific_smtp_window_finalize) :
1359 unref the tree model.
1360 (on_button_edit): Show the edit window.
1362 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1364 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1367 * src/maemo/Makefile.am:
1368 * src/maemo/modest-connection-specific-smtp-window.c:
1369 * src/maemo/modest-connection-specific-smtp-window.h:
1370 New window for showing the list of connections, for connection-specific
1371 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1372 * src/maemo/easysetup/modest-easysetup-wizard.c:
1373 (create_page_custom_outgoing): Show the new window when the button is clicked.
1375 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1377 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1378 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1379 * src/maemo/modest-msg-edit-window.c:
1380 (modest_msg_edit_window_insert_image):
1381 * src/modest-conf.c: (modest_conf_key_escape):
1382 * src/modest-mail-operation.c:
1383 (modest_mail_operation_send_new_mail):
1384 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1385 (modest_ui_actions_on_new_account):
1386 * src/widgets/modest-attachment-view.c: (update_filename_request):
1387 * src/widgets/modest-mail-header-view.c:
1388 Corrected warnings that were breaking the build, by commenting out unused variables,
1389 and a function, and by including a header.
1391 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1393 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1394 so we can #ifdef around platform-specific code when necessary.
1395 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1396 to allow this to build for the GNOME platform too.
1398 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1400 * src/maemo/easysetup/modest-easysetup-wizard.c:
1401 Added util_increment_name() and used it in create_page_account_details()
1402 to make sure that the default account name is always a new name.
1404 (modest_easysetup_wizard_dialog_init),
1405 (set_default_custom_servernames): Some minor memory management fixes.
1407 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1411 * src/modest-runtime.c: (init_i18n): Restored the translation
1412 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1413 are defined in config.h, and the translations are installed.
1415 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1416 is defined for translation.
1418 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1420 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1422 * src/maemo/easysetup/modest-easysetup-wizard.c:
1423 (modest_easysetup_wizard_dialog_init):
1424 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1425 Use realistic paths (though they should use $prefix generically) to the
1426 mcc_mapping and provider-data.keyfile files which might work when they
1427 are installed by the future version of the operator-wizard package,
1428 and then fallback to paths in our source code, with an explanatory
1431 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1435 * src/maemo/Makefile.am:
1436 * src/maemo/easysetup/: Added files from the previously-exernal
1437 osso-modest-easysetup.
1438 * src/maemo/modest-main-window-ui.h:
1439 * src/modest-ui-actions.c:
1440 * src/modest-ui-actions.h:
1441 Added modest_ui_actions_on_new_account() as a signal handler for the
1442 New Account menu item. It shows the easysetup wizard.
1443 * po/en_GB.po: Added additional needed logical IDs and translations.
1445 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1446 Apparently ChangeLog is not used for some vague Nokia legal reasons.