1 2007-08-13 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-header-view-render.c:
4 (_modest_header_view_compact_header_cell_data):
5 NULL some strings after freeing them, trying to deal with
6 the double deletion found in projects.maemo.org bug 64183,
7 probably having no effect.
9 2007-08-13 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-account-settings-dialog.c:
12 (create_page_incoming), (create_page_outgoing): Use a define
13 for the min and max port numbers.
15 (check_hildon_number_editor_and_warn_value_not_in_range),
16 (check_data): Do an extra check for an invalid port number, as needed
17 in projects.maemo.org bug #64275, when the number is cleared, but this
18 does not work due to bugs.maemo.org bug #1806.
20 2007-08-13 Murray Cumming <murrayc@murrayc.com>
22 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
23 Comment out the debug warning about the unexpected D-Bus methods.
24 They are just annoying now.
25 * src/maemo/modest-platform.c:
26 (modest_platform_set_update_interval): Correct the D-Bus path, instead
27 of using a file path, though it did not seem to break things before.
28 It might be needed now:
29 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
30 modest is not already running. This is the behaviour of the old client, and
31 Mox says it is what we should do for modest.
32 This closes projects.maemo.org bug NB#64327.
34 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
36 * src/modest-text-utils.c:
37 Fixed invalid jump due to incorrect string/pointer
39 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
42 2007-08-01 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-account-mgr-helpers.h:
45 * src/modest-account-mgr-helpers.c:
46 Added modest_account_mgr_get_first_account_name(),
47 using code from modest_account_mgr_set_first_account_as_default().
49 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
50 (account_number_changed): Call set_at_least_one_account_visible() so that
51 the first account is visible when first added, without the user having to
53 I do wonder how this worked before.
55 2007-08-01 Murray Cumming <murrayc@murrayc.com>
57 * src/modest-tny-account-store.c: (show_password_warning_only),
58 (show_wrong_password), (request_password_and_wait), (get_password),
59 (modest_tny_account_store_alert): Remove the (incomplete anyway)
60 attempts to show UI only in the main context, which used g_idle_add()
61 and mainloops, because tinymail now guarantees that it only calls these
62 callbacks in the mainloop with the gdk lock. This makes everything much
65 2007-08-01 Murray Cumming <murrayc@murrayc.com>
67 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
68 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
69 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
70 error dialog, instead of ignoring it.
72 2007-08-01 Murray Cumming <murrayc@murrayc.com>
74 * src/maemo/modest-msg-view-window.c:
75 (modest_msg_view_window_get_header),
76 (modest_msg_view_window_last_message_selected):
77 Added comments to explain the use of priv->header_model.
78 * src/modest-ui-dimming-rules.c:
79 (modest_ui_dimming_rules_on_open_msg),
80 (modest_ui_dimming_rules_on_mark_as_read_msg),
81 (modest_ui_dimming_rules_on_mark_as_unread_msg),
82 (modest_ui_dimming_rules_on_remove_attachments),
83 (_invalid_attach_selected), (_selected_msg_marked_as):
84 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
85 and changed the parameter to a ModestMainWindow to make it clearer that
86 it never uses any other kind of window.
87 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
88 instead of the selected message.
89 I notice that much of the dimming code and the ModestMsgViewWindow code
90 hard-codes the assumption that the viewed message is always selected in
91 the header view. This does not seem wise or simple.
93 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
94 examine the actual message instead of whatever might be selected
95 in the header view. This stops the delete toolbar button and menu item
96 from being dimmed when opening a message view the search UI,
97 partially fixing projects.maemo.org bug NB#63811.
99 However, when actually deleting, I now get this warning:
100 "tny_header_set_flags: This is a header instance for a new message.
101 Only priority and attachment flags are supported"
103 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
105 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
107 Show account wizard if no accounts are defined while sending
108 (automatic sending after the account wizard finished does not
109 work because it takes some time until the account manager
110 synchronizes everything. (projects.maemo.org NB#62792)
112 2007-07-30 Murray Cumming <murrayc@murrayc.com>
114 * src/modest-tny-account-store.c: (on_account_removed),
115 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
116 account is removed from the View menu. We have TnyAccountStore
117 and ModestTnyAccountStore signals that seem very similar, but this
118 seems to work for now.
120 * src/maemo/modest-main-window.c:
121 (on_show_account_action_activated): Prevent dereference
122 of a NULL if the accoutn does not really exist, though that
123 should not happen anymore.
125 This fixes projects.maemo.org bug NB#64606.
127 2007-07-30 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-ui-actions.c: (run_account_setup_wizard),
130 (modest_ui_actions_on_accounts): Revert a change that set these
131 to modal dialogs, freezing the UI when they show secondary dialogs.
132 This fixed projects.maemo.org bug NB#64519.
134 2007-07-27 Murray Cumming <murrayc@murrayc.com>
136 * src/widgets/modest-header-view-render.c:
137 (_modest_header_view_compact_header_cell_data):
138 Some checks and initialization to try to deal with a crash,
139 probably ineffective.
141 2007-07-27 Murray Cumming <murrayc@murrayc.com>
143 * src/maemo/modest-maemo-utils.c:
144 (modest_maemo_utils_get_supported_secure_authentication_methods):
145 Make sure that we have a connection, asking the user for one
147 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
148 Check for a connection before showing the wizard, because
149 the wizard needs a connection to check for server capabilities.
151 2007-07-27 Murray Cumming <murrayc@murrayc.com>
153 * src/maemo/modest-account-view-window.c:
154 (on_new_button_clicked): Remember the wizard dialog instance,
155 so we can just present it again if necessary. This prevents
156 multiple windows from appearing if you click again quickly on the
157 New button before the dialog appears, fixing projects.maemo.org
160 2007-07-27 Murray Cumming <murrayc@murrayc.com>
162 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
163 Offer a connection dialog if there is no connection when
164 starting modest. This should fix projects.maemo.org bug NB#61134.
166 2007-07-27 Murray Cumming <murrayc@murrayc.com>
168 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
169 Reverted my last commit. I was able to fix the build by doing
170 apt-get install wpeditor0 (replacing other wpeditor packages) and
171 an explicit apt-get install wpeditor-dev to upgrade the -dev
174 2007-07-27 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
177 Commented out the use of wp_text_buffer_replace_image()
178 because it does not exist, to break the build. Added a TODO for it.
180 2007-07-26 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account-store.c: (recreate_all_accounts):
183 Recreate them even if they were NULL before. I guess something
184 else was already creating them before, or this would never
186 (modest_tny_account_store_get_server_account): Make sure that
187 the tny accounts have been created before trying to find one.
188 This allows libmodest_dbus_client_compose_mail() to work
189 when the UI is not yet visible.
190 This is probably useful in other cases too.
192 (get_password): When the password is wrong after it is entered
193 in the protected password dialog, show an info banner (in an
194 idle handler) before showing the protected password dialog
197 2007-07-26 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-ui-actions.h:
200 * src/modest-ui-actions.c: Added
201 modest_do_refresh_current_folder() containing some code from
202 modest_ui_actions_on_send_receive().
203 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
204 Call modest_do_refresh_current_folder() before refreshing the
205 requested account, as in modest_ui_actions_on_send_receive().
206 This is strange, but seems to be necessary to show new mails.
207 Now new emails are finally visible in the UI when downloaded
208 via the automatic update interval, fixing bug NB#57458.
209 This also works because bug NB#57458 has been fixed somehow.
211 2007-07-26 Murray Cumming <murrayc@murrayc.com>
213 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
214 printf more details when we get unhandled D-Bus methods, because
217 * src/modest-mail-operation.c: (update_account_thread):
218 Comment out the tny_camel_pop_store_account_reconnect(), because this
219 is apparently no longer needed, and it did not work before anyway.
220 See the comment in the code.
222 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
223 by checking the header flags. This fixes projects.maemo.org bug
226 2007-07-25 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/modest-maemo-utils.h:
229 * src/maemo/modest-maemo-utils.c: Added
230 modest_maemo_show_information_note_in_main_context_and_forget().
231 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
232 Use the new function to show simple error dialogs in the main
233 context, though question dialogs are still in the current context,
234 which is unfortunately usually not the main context. This should
237 2007-07-25 Murray Cumming <murrayc@murrayc.com>
239 * src/modest-tny-account-store.c: (get_password):
240 Never save the entered username and password in gconf,
241 because the UI spec says we should not. This helps
242 slightly with projects.maemo.org bug NB#63671.
244 2007-07-25 Murray Cumming <murrayc@murrayc.com>
246 * src/widgets/modest-msg-edit-window.h:
247 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
248 Moved some code here to make it simpler.
249 (modest_msg_edit_window_attach_file_one): Renamed from
250 modest_msg_edit_window_attach_file_interactive().
251 (modest_msg_edit_window_offer_attach_file): Renamed from
252 modest_msg_edit_window_attach_file() and used
253 modest_msg_edit_window_attach_file_one() instead of
254 copy/pasting the code. The old code for one was not using
255 GnomeVFS. This allows use of smb:// URLs when using send-as
256 from external applications, fixing bug NB#63741.
258 (modest_msg_edit_window_insert_image),
259 (modest_msg_edit_window_add_attachment_clicked):
260 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
261 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
262 Adapted to the new function names.
264 2007-07-25 Murray Cumming <murrayc@murrayc.com>
266 (modest_platform_set_update_interval): Set the alarm recurrence
267 fields so that auto-update does not just happen the first time.
268 This should have fixed projects.maemo.org bug NB#63938.
270 When this happens you can see a printf when the D-Bus method is
272 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
274 However, I do not actually seem to get new POP messages even when
275 clicking the refresh button manually. A restart gets them.
276 This might be a problem in today's tinymail only.
278 2007-07-24 Murray Cumming <murrayc@murrayc.com>
280 * src/maemo/modest-maemo-global-settings-dialog.c:
281 (current_connection):
282 Avoid a crash (probably only in scratchbox) when strcmp()ing a
283 NULL when closing the dialog.
285 2007-07-24 Murray Cumming <murrayc@murrayc.com>
287 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
288 Remove the hacky send/receive that didn't work, and instead
289 refilter the treemodel to make the deleted email really vanish from
290 the UI (though the delete-from-menu code does has commented out
291 the code that does that). This fixes projects.maemo.org bug
294 2007-07-24 Murray Cumming <murrayc@murrayc.com>
296 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
297 Try a couple of tricks to force the treeview to update (
298 poke the folder, and do a send/receive refresh), but the deleted
299 email still appears with a strike-through instead of really being
302 2007-07-23 Murray Cumming <murrayc@murrayc.com>
304 * src/dbus_api/modest-dbus-callbacks.c:
305 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
306 because their ID is not human-readable (see the comment about
307 improvements needed to the osso-email-interface API) and
308 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
310 2007-07-23 Murray Cumming <murrayc@murrayc.com>
312 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
313 (add_folders_to_list), (on_dbus_method_get_folders),
314 (modest_dbus_req_filter):
315 * src/maemo/modest-maemo-utils.c:
316 (on_camel_account_get_supported_secure_authentication):
317 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
318 (on_header_view_focus_in):
319 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
320 * src/modest-formatter.c: (modest_formatter_create_body_part):
321 * src/modest-mail-operation.c: (recurse_folders),
322 (update_account_thread), (get_msgs_full_thread),
323 (modest_mail_operation_get_msgs_full),
324 (modest_mail_operation_xfer_msgs):
325 * src/modest-search.c: (search_mime_part_and_child_parts),
326 (modest_search_account), (modest_search_all_accounts):
327 * src/modest-tny-account.c:
328 (modest_tny_account_get_special_folder), (recurse_folders):
329 * src/modest-tny-local-folders-account.c:
330 (modest_tny_local_folders_account_query_passes):
331 * src/modest-tny-msg.c: (copy_mime_part),
332 (modest_tny_msg_find_body_part_from_mime_part):
333 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
334 (modest_tny_send_queue_try_to_send):
335 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
336 (_modest_ui_actions_open), (download_uncached_messages),
337 (reply_forward), (modest_ui_actions_on_copy),
338 (modest_ui_actions_on_details), (has_retrieved_msgs),
339 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
341 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
342 (_selected_msg_marked_as), (_msg_download_completed),
343 (_selected_msg_sent_in_progress):
344 * src/widgets/modest-attachments-view.c:
345 (modest_attachments_view_set_message):
346 * src/widgets/modest-msg-view.c: (find_cid_image):
347 * tests/check_folder-transfer.c: (find_folders):
348 * tests/check_update-account.c: (func):
349 * tests/dbus_api/test_get_folders.c: (main):
350 Checked all uses of tny_iterator_get_current(), making sure
351 that the object is unreferenced (3 or 4 places did not),
352 and adding checks for NULL.
354 2007-07-23 Murray Cumming <murrayc@murrayc.com>
356 * src/dbus_api/modest-dbus-callbacks.c:
357 (on_idle_open_default_inbox): Make sure that the application UI is
359 * src/maemo/easysetup/modest-easysetup-wizard.c:
360 (on_entry_invalid_character): Show the word whitespace instead
361 of (null) in the banner when whitespace was entered.
362 (show_error): Add a comment that this does not work in
363 Maemo Bora, though we do not know why.
365 2007-07-23 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account.c:
368 (modest_tny_account_get_special_folder): Use an if instead of
369 an assert for when the parent account name is NULL, because this
370 might be causing a crash in projects.maemo.org bug 63192.
371 * src/modest-mail-operation.c:
372 (modest_mail_operation_send_new_mail_cb),
373 (modest_mail_operation_remove_folder): unref the folder that is
374 returned from modest_tny_account_get_special_folder().
376 2007-07-23 Murray Cumming <murrayc@murrayc.com>
378 * src/modest-ui-actions.c:
379 (modest_ui_actions_on_password_requested):
380 Show mail_ib_login_cancelled info banner when the user cancels
381 the protected password dialog, to fix projects.maemo.org
384 2007-07-23 Murray Cumming <murrayc@murrayc.com>
386 * src/maemo/modest-account-settings-dialog.c:
387 (create_page_outgoing): Put this page in a GtkScrolledWindow,
388 matching the UI mock-up in the UI spec, and allowing access
389 to all widgets even when the on-screen keyboard is active.
391 2007-07-23 Murray Cumming <murrayc@murrayc.com>
393 Reverted this previous commit from Johannes,
394 because the scrollbars are always visible and because
395 I think we only need it on onepage of the account
396 settings, not the account wizard.
397 (I wrote the wrong instructions in the bug.)
399 * src/maemo/easysetup/modest-easysetup-wizard.c:
400 Added scrollbars to account wizard dialog.
401 Fixed projects.maemo.org NB #62744
403 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
405 * src/maemo/easysetup/modest-easysetup-wizard.c:
406 (create_page_user_details):
407 Use auto-cap for name (projects.maemo.org NB#63716)
408 * src/widgets/modest-account-view.c: (on_account_busy_changed):
410 2007-07-22 Armin Burgmeier <armin@openismus.com>
412 * src/maemo/modest-ui-actions.c: Use current account instead of
413 default account for creating viewer windows, so that the viewer
414 window knows to which account the viewed message belongs.
416 * src/maemo/modest-msg-view-window.c: Destroy the window when the
417 corresponding account is deleted. This fixes projects.maemo.org bug
420 2007-07-18 Armin Burgmeier <armin@openismus.com>
422 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
423 the dialog close after entering an invalid port number and clicking
424 OK. This fixes projects.maemo.org bug NB#63602.
426 2007-07-18 Armin Burgmeier <armin@openismus.com>
428 * src/modest-tny-account-store.c:
429 (get_server_accounts): Set parent modest account name for each
430 connection-specific transport account so that special folders of such
431 an account can be looked up. This fixes a crash when changing account
432 settings. This might also be related to projects.maemo.org bug
435 2007-07-16 Armin Burgmeier <armin@openismus.com>
437 * src/modest-ui-actions.c: Added a button to create a folder to the
438 move-to dialog. This fixes projects.maemo.org bug NB#.
440 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
442 * src/maemo/easysetup/modest-easysetup-wizard.c:
443 Added scrollbars to account wizard dialog.
444 Fixed projects.maemo.org NB #62744
446 2007-07-16 Murray Cumming <murrayc@murrayc.com>
448 * src/widgets/modest-msg-view.h:
449 * src/widgets/modest-msg-view.c:
450 Added modest_msg_view_get_message_is_empty() but this needs
452 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
453 Check if there is any text in the message yet.
454 But this needs to be implemented properly.
455 (modest_msg_edit_window_toggle_find_toolbar):
456 * src/maemo/modest-msg-view-window.c:
457 (modest_msg_view_window_toggle_find_toolbar):
458 Show a banner warning if there is no text to search, when
459 trying to start a search. This partially fixes
460 projects.maemo.org bug NB#62350.
462 2007-07-13 Murray Cumming <murrayc@murrayc.com>
464 * src/modest-mail-operation.c: (update_account_thread):
465 Initialized num_new_headers to fix the build.
467 2007-07-13 Murray Cumming <murrayc@murrayc.com>
469 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
470 Ignore modest accounts whose server accounts don't exist in gconf.
471 This prevents us trying to create TnyAccount instances for those
472 server accounts when the server account has been removed from gconf,
473 but the parent modest account has not yet been removed from modest.
474 I don't know why this is only noticeable now. It was probably just
475 a harmeless g_warning() anyway.
477 2007-07-13 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
480 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
482 2007-07-12 Armin Burgmeier <armin@openismus.com>
484 * src/maemo/modest-main-window.c: Make default account appear bold
485 in view, tools/send & receive and toolbar/send & receive SCM menus.
486 This fixes projects.maemo.org bug NB#59010.
488 2007-07-12 Murray Cumming <murrayc@murrayc.com>
490 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
491 Add a short-cut, by checking if the folder store is an account.
492 This ensures that the Sort menu item and toolbar is dimmed for
493 the local-folders account root item, fixing
494 projects.maemo.org bug NB#62545.
496 2007-07-12 Murray Cumming <murrayc@murrayc.com>
498 * src/modest-tny-account-store.c: (get_password):
499 Show the password dialog (via the signal) only in the mainloop, via
500 an idle handler that we wait for. This could theoretically prevent
501 hangs, though I worry that it could introduce some too.
503 2007-07-12 Murray Cumming <murrayc@murrayc.com>
505 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
506 * src/maemo/modest-platform.c:
507 (modest_platform_connect_and_wait):
508 Take a TnyAccount* parameter and try to set it to online
509 (a TnyCamel-only API), because tinymail sets accounts to offline
510 when the user cancels a password dialog, and doesn't ask again until
511 it has been set to online.
512 However, this is commented out because it causes a hang now.
514 (modest_platform_connect_and_wait_if_network_account):
515 * src/modest-mail-operation.c:
516 (modest_mail_operation_update_account):
517 * src/modest-platform.h:
518 * src/modest-ui-actions.c: (_modest_ui_actions_open),
519 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
521 2007-07-12 Armin Burgmeier <armin@openismus.com>
523 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
525 * src/modest-mail-operation.c:
526 * src/modest-ui-actions.c: Check for already existing folder before
527 querying the server, show error message from camel if the request
528 still fails. This fixes projects.maemo.org bug NB#58701.
530 2007-07-12 Murray Cumming <murrayc@murrayc.com>
532 * src/modest-tny-account-store.h:
533 * src/modest-tny-account-store.c:
534 Added modest_tny_account_store_forget_password_in_memory(),
535 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
536 when creating a new account, so that new passwords will be used, instead of
537 us thinking that it's a second request as a result of a failed password again.
539 2007-07-12 Murray Cumming <murrayc@murrayc.com>
541 * src/dbus_api/modest-dbus-callbacks.c:
542 (on_idle_open_message): If the message is in drafts then open it
543 in an edit window instead of a view window. This fixes
544 projects.maemo.org bug NB#63005.
546 2007-07-12 Murray Cumming <murrayc@murrayc.com>
548 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
549 Avoided a harmless g_warning().
551 2007-07-12 Murray Cumming <murrayc@murrayc.com>
553 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
554 Pass the modest account name, not the TnyAccount display name to
555 modest_msg_view_window_new() so that the reply feature works,
556 fixing projects.maemo.org bug NB#62892.
558 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
559 (modest_msg_view_window_new_with_header_model):
560 * src/maemo/modest-msg-view-window.c:
561 (modest_msg_view_window_new_with_header_model),
562 (modest_msg_view_window_new):
563 * src/modest-ui-actions.c: (reply_forward):
564 * src/widgets/modest-msg-view-window.h:
565 * src/widgets/modest-window.c: (modest_window_set_active_account):
566 Rename an account parameter to modest_account_name to make this clearer.
568 2007-07-11 Murray Cumming <murrayc@murrayc.com>
570 * src/modest-ui-actions.h:
571 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
572 modest_do_message_delete().
573 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
574 Call modest_do_message_delete(), hoping that this would cause messages
575 to be really deleted from search instead of just marked with strike through.
576 Does not seem to help.
578 2007-07-11 Armin Burgmeier <armin@openismus.com>
580 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
581 priv->reselect to FALSE prior to calling
582 modest_folder_view_select_first_inbox_or_local() to prevent endless
583 recursion and thus a crash on startup.
585 2007-07-11 Armin Burgmeier <armin@openismus.com>
587 * src/maemo/modest-account-settings-dialog.h: Include
588 <gtk/gtknotebook.h> to fix the build (at least for me).
590 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
591 Use "New FolderN" as default suggested name if "New folder" already
592 exists, with N being the first free number, though never exceed "New
593 folder99" in which case we just fall back to "New Folder" even though
594 it already exists. This fixes projects.maemo.org bug NB#58663.
596 2007-07-11 Murray Cumming <murrayc@murrayc.com>
598 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
599 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
600 projects.maemo.org bug NB#62778.
602 2007-07-11 Murray Cumming <murrayc@murrayc.com>
604 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
605 Ignore the wrong (for now) secure-smtp setting in the presets -
606 just default to requiring secure authentication for SMTP, because
609 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
611 * src/widgets/modest-folder-view.c: (filter_row)
612 Do not show drafts folder (see UI specs)
614 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
616 * src/modest-ui-actions.c:
617 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
618 place and also not necessary.
620 * src/widgets/modest-folder-view.c: (filter_row)
621 Guess folder type and hide Sent & Outbox if necessary.
622 Fixed project.maemo.org NB#57328
624 2007-07-11 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-ui-actions.h:
627 * src/modest-ui-actions.c:
628 (modest_ui_actions_on_delete_message):
629 Move some code into a new
630 modest_ui_actions_refresh_message_window_after_delete()
631 function so we can use it from elsewhere.
633 * src/dbus_api/modest-dbus-callbacks.c:
634 (on_idle_delete_message), (on_delete_message): Used an idle
635 handler, as we do for the other D-Bus method handlers.
636 Call modest_ui_actions_refresh_message_window_after_delete()
637 if the deleted message was open in a window. This fixed
638 projects.maemo.org bug NB#62862.
640 2007-07-11 Murray Cumming <murrayc@murrayc.com>
642 * src/modest-main.c: (main): Only show the UI at the start if
643 the showui command line option was given. For instance,
644 run-standalone src/modest showui
645 Otherwise, we wait for the top_application D-Bus method to
646 be sent by hildon-desktop when the application is selected
648 This allows us to run without a UI when osso-global-search
649 uses our D-Bus methods.
651 2007-07-11 Murray Cumming <murrayc@murrayc.com>
653 * src/dbus_api/modest-dbus-api.h: Added a define for a
654 top-application D-Bus method.
655 * src/dbus_api/modest-dbus-callbacks.c:
656 (on_top_application),
657 (modest_dbus_req_handler): Handle the top-application D-Bus
658 method, which might be an undocumented D-Bus signal sent by
659 hildon-desktop when it starts the application from the menu.
660 But I am not sure and I need to test it on the device, because
661 my scratchbox does not have the application in the menu now.
662 This method shows the main window, so that it can be invisible
663 when started, for instance, just for email searching from
666 * src/maemo/modest-main-window.c: (restore_settings),
667 (modest_main_window_new): Do not show the window immediately
668 upon creation. We show it later.
669 * src/modest-widget-memory.c: (save_settings_paned):
670 Try (unsuccessfully) to avoid saving the paned position when
671 it is not even visible.
672 (restore_settings_paned): Do not allow a silly paned position.
673 This seems necessary when not showing the window at first.
675 * tests/dbus_api/Makefile.am:
676 * tests/dbus_api/test_top_application.c: (main): Test for the
679 2007-07-10 Murray Cumming <murrayc@murrayc.com>
681 * src/modest-ui-dimming-rules.c:
682 (modest_ui_dimming_rules_on_new_msg),
683 (modest_ui_dimming_rules_on_reply_msg),
684 (modest_ui_dimming_rules_on_delete_msg),
685 (modest_ui_dimming_rules_on_details),
686 (modest_ui_dimming_rules_on_view_window_move_to),
687 (modest_ui_dimming_rules_on_view_previous),
688 (modest_ui_dimming_rules_on_view_next),
689 (_invalid_folder_for_purge): Added checks before
690 casting the window. This looks like an actual
691 logic error in _invalid_folder_for_purge(), because it
692 tries to use a ModestMainWindow as a message window.
694 2007-07-10 Murray Cumming <murrayc@murrayc.com>
696 * src/maemo/modest-account-settings-dialog.c:
697 (show_error): Use the same implementation as in
698 modest-easysetup-wizard.c:
699 (on_entry_invalid_character): The logical ID contains a %s.
700 Guessed what it should be.
701 (on_entry_max), (check_data), (on_response): Adapt to
702 changed show_error().
703 (create_page_account_details): Really call
704 modest_validating_entry_set_func() on the correct widgets.
705 * src/maemo/easysetup/modest-easysetup-wizard.c:
706 (on_entry_invalid_character): Fix the logical ID here too.
707 (create_page_account_details),
708 (create_page_user_details):
710 modest_validating_entry_set_func() on the correct widgets.
712 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
713 Do not try to use the account if it is NULL.
715 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
717 * src/modest-ui-actions.c: (create_move_to_dialog),
718 (modest_ui_actions_on_main_window_move_to),
719 (modest_ui_actions_on_msg_view_window_move_to):
720 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
721 (filter_row), (modest_folder_view_show_non_move_folders):
722 * src/widgets/modest-folder-view.h:
724 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
725 the Sent folder yet as it does not report the correct folder type.
727 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
729 * src/maemo/modest-msg-edit-window.c: (init_window):
732 2007-07-10 Murray Cumming <murrayc@murrayc.com>
734 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
735 Take a parent widget instead of a parent window, and
736 implement this with hildon_banner_show_information() instead.
737 Non-Maemo builds can just ifdef that there.
738 This fixed projects.maemo.org bug NB#62766.
740 (on_entry_invalid_character): Use show_error() again instead
741 of using hildon directly, and use the _CS() macro to use the correct
743 (create_account), (check_for_supported_auth_methods), (on_entry_max):
744 Pass a widget instead od a window to show_error().
746 2007-07-10 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
749 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
750 This allows us to show the server name in the error message, fixing
751 projects.maemo.org bug NB#62904.
752 Also, use the appropriate logical ID message for the account protocol.
754 2007-07-10 Murray Cumming <murrayc@murrayc.com>
756 * src/modest-tny-account-store.c: (on_idle_wrong_password):
757 A compilation fix, though the build wasn't broken for me.
759 2007-07-09 Murray Cumming <murrayc@murrayc.com>
761 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
762 Do not try to unref a NULL folder store, to avoid a runtime warning.
763 This seems to happen sometimes when changing accounts settings.
765 2007-07-09 Murray Cumming <murrayc@murrayc.com>
767 * src/modest-tny-account-store.c:
768 (modest_tny_account_store_instance_init),
769 (modest_tny_account_store_finalize),
770 (on_account_settings_hide), (on_idle_wrong_password):
771 Use a GHashTable to ensure that we only show one account settings
772 dialog per modest account. This avoids us having a dialog open for
773 both the store and transport accounts, or due to repeated get_password()
774 calls that shouldn't happen anyway.
776 2007-07-09 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-maemo-utils.c: (on_hide),
779 (modest_maemo_show_dialog_and_forget): Handle the response, because
780 the window is not even hidden by default.
782 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
783 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
784 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
785 which seems to prevent some modality problems.
787 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
788 Ignore user cancellation errors.
790 * src/modest-account-mgr-helpers.h:
791 * src/modest-account-mgr-helpers.c:
792 Added modest_server_account_get_password() and
793 modest_server_account_get_has_password() to avoid direct use of
796 * src/maemo/modest-account-settings-dialog.h:
797 * src/maemo/modest-account-settings-dialog.c:
798 (modest_account_settings_dialog_init): Store the notebook so we can
800 Added modest_account_settings_dialog_switch_to_user_info().
802 * src/modest-tny-account-store.c:
803 (get_password): When the password in the account settings is wrong (we think),
804 show the relevant page of the account settings dialog, in the mainloop.
805 However, we currently get many of these at once because cancel does not
807 (forget_password): Do not forget the password
808 from the account settings, because this causes side-effects when
809 tinymail seems to call it at strange time, maybe because of how we
810 are cancelling get_password().
811 (modest_tny_account_store_alert): Ignore user cancellations.
813 2007-07-09 Murray Cumming <murrayc@murrayc.com>
815 * src/maemo/modest-maemo-utils.h:
816 * src/maemo/modest-maemo-utils.c:
817 Added modest_maemo_show_information_note_and_forget() for use instead of
818 gtk_dialog_run() when the response is not needed, to avoid an extra
819 mainloop which could cause a hang.
821 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
822 Use the logical IDs for the error message, though they are not
823 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
824 because gtk_dialog_run() caused a hang here (the window did not close).
825 This fixes projects.maemo.org bug NB#62646.
827 2007-07-09 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-account-mgr-helpers.h:
830 * src/modest-account-mgr-helpers.c:
831 Added modest_account_mgr_get_store_protocol().
833 * src/maemo/modest-account-view-window.c:
834 (on_delete_button_clicked): Show different warning text depending on
835 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
836 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
839 2007-07-09 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/modest-msg-edit-window.c:
842 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
843 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
845 2007-07-07 Armin Burgmeier <armin@openismus.com>
847 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
848 ckdg_ib_maximum_characters_reached from correct package.
850 * src/modest-ui-actions.c: Show an error message when a folder could
851 not be created. Tinymail does not give us specific error codes about
852 what has gone wrong, so we assume that a folder with that name
853 already exists, though there might be other reasons.
855 2007-07-06 Murray Cumming <murrayc@murrayc.com>
857 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
858 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
859 give a more exact error message that can be partly translated.
861 2007-07-05 Murray Cumming <murrayc@murrayc.com>
863 * src/maemo/modest-address-book.c:
864 (select_email_addrs_for_contact): Specify a default window size for the
865 select-email-address dialog, so that it is probably big enough for the
866 title. This should fix projects.maemo.org bug NB#62277.
868 2007-07-05 Murray Cumming <murrayc@murrayc.com>
870 * src/maemo/easysetup/modest-easysetup-wizard.c:
871 (create_page_complete_easysetup): Use
872 gtk_widget_set_size() request to ensure that the text wraps
875 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
877 * src/maemo/easysetup/modest-easysetup-wizard.c:
878 (on_entry_invalid_character), (create_page_account_details),
879 (create_page_user_details):
880 Use new API of ModestValidatingEntry. But for some reason the banner is
881 not shown. I will have to investigate that further.
883 * src/widgets/modest-validating-entry.c: (on_insert_text),
884 (modest_validating_entry_set_func):
885 * src/widgets/modest-validating-entry.h:
886 Added a new callback function to be able to react to prevented
887 characters whitespaces to e.g show a banner.
889 2007-07-05 Armin Burgmeier <armin@openismus.com>
891 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
892 notification of HildonNumberEditor instead of remembering the port
893 number. Thanks to Johannes for pointing this out.
895 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
897 * src/maemo/easysetup/modest-easysetup-wizard.c:
898 Check if there are any user changes before showing a confirmation
899 dialog (projects.maemo.org NB#60946)
901 2007-07-05 Armin Burgmeier <armin@openismus.com>
903 * src/maemo/modest-account-settings-dialog.c: Remember custom port
904 number at the beginning of the dialog and set the modified flag at the
905 end if the port number has changed. This is necessary because
906 HildonNumberEditor does not support notification when the value has
909 2007-07-05 Murray Cumming <murrayc@murrayc.com>
911 * src/modest-ui-actions.c:
912 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
913 a connection before asking anything else. Correct the check for the destination
914 folder so that it succeeds when online.
915 This fixed projects.maemo.org bug NB#61645.
917 2007-07-05 Murray Cumming <murrayc@murrayc.com>
919 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
920 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
921 to fix projects.maemo.org bug NB#62439.
923 2007-07-05 Murray Cumming <murrayc@murrayc.com>
925 * src/modest-tny-account.c: (on_connection_status_changed):
926 Really do not use tny_device_force_offline() here. See the previous comment.
928 2007-07-04 Murray Cumming <murrayc@murrayc.com>
930 * src/modest-tny-account.c: (on_connection_status_changed):
931 Do not use tny_device_force_offline() when tinymail says that something
932 went wrong with the connection. It seems to report this unnecessarily.
934 2007-07-04 Murray Cumming <murrayc@murrayc.com>
936 * src/maemo/modest-connection-specific-smtp-window.c:
937 (modest_connection_specific_smtp_window_init):
938 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
939 does not seem to have any effect in osso 1.1 (though it works in
940 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
942 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
944 * src/maemo/modest-connection-specific-smtp-window.c:
945 Fix UI specification problems with projects.meamo.org NB#60479
947 2007-07-04 Murray Cumming <murrayc@murrayc.com>
949 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
950 clue when this has failed, because the error dialog is not always shown
951 (at least in earlier version).
953 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
954 GError message, because the generic error dialog is not helpful.
956 'This message is not currently available (can't let a new connection go online)'
957 when trying to open an IMAP message.
959 (_modest_ui_actions_open): Offer a connection when some messages would
960 have to be downloaded and we are offline.
962 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
964 * src/widgets/modest-folder-view.c:
965 Don't check for MERGE type anymore as we use the correct type
967 NOTE: For the last two changes you need to update your tinymail copy
968 because of API changes!
970 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
972 * src/modest-tny-local-folders-account.c:
973 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
974 (see projects.maemo.org NB#61580)
976 2007-07-04 Murray Cumming <murrayc@murrayc.com>
978 * src/modest-tny-account.c: (on_connection_status_changed):
979 Commented out the call to modest_platform_connect_and_wait() because this
980 seems to always hang, and I would like to know if this is the only thing
981 that causes a hang when showing the connection dialog.
982 It is not very useful anyway.
984 2007-07-04 Murray Cumming <murrayc@murrayc.com>
986 * src/maemo/modest-msg-view-window.c:
987 (modest_msg_view_window_select_next_message):
989 * src/modest-platform.h:
990 * src/maemo/modest-platform.c:
991 Added modest_platform_connect_and_wait(), which calls
992 tny_maemo_conic_device_connect() always in the main thread, by calling it
993 in an idle handler and waiting for the idle handler to run. It should be
994 in the main thread because it uses GTK+ UI code. It just returns TRUE
995 if the device is already online.
997 There is some nasty code to ensure that subsequent calls to
998 modest_platform_connect_and_wait() just wait for the first one to finish,
999 by checking repeatedly in another idle handler. This is necessary,
1000 because other threads (or even the main thread, via another idle handler)
1001 can call modest_platform_connect_and_wait() while
1002 modest_platform_connect_and_wait() is running.
1004 (modest_platform_connect_and_wait_if_network_account),
1005 (modest_platform_connect_and_wait_if_network_folderstore):
1006 Convenience functions that calls modest_platform_connect_and_wait() if
1007 the account or folder might want network access.
1009 * src/modest-mail-operation.c:
1010 (modest_mail_operation_update_account):
1011 * src/modest-ui-actions.c: (download_uncached_messages),
1012 (modest_ui_actions_on_rename_folder), (delete_folder),
1013 (modest_ui_actions_on_main_window_move_to),
1014 (modest_ui_actions_on_msg_view_window_move_to):
1015 * src/widgets/modest-folder-view.c:
1016 (drag_and_drop_from_folder_view):
1017 Offer a connection if we are offline.
1019 * src/modest-tny-account.c: (on_connection_status_changed):
1020 Document this as only handling errors during network operations in progress,
1021 and replace the idle code with a simple call to
1022 modest_platform_connect_and_wait(), which does this instead.
1024 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1026 * src/modest-tny-account.c:
1027 (modest_tny_account_get_special_folder): (util_on_idle),
1028 Handle the GError so we can see when tny_folder_store_get_folders()
1029 fails, as it currently does while something else is connecting.
1031 Added util_run_in_main_thread_and_wait()
1032 which uses an idlen handler and mainloop to ensure that the function
1033 is called in the main thread.
1034 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1035 to make sure that we call attempt the connection in the mainloop only,
1036 which might solve some hangs.
1038 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1040 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1041 be found by their display name. This is never useful.
1042 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1043 by its ID, instead of trying to use its ID as its display name.
1045 * src/modest-tny-account-store.h:
1046 * src/modest-tny-account.c:
1047 (modest_tny_account_get_special_folder): Add a g_warning() when
1048 tny_folder_store_get_folders() returns an empty list for the maildir.
1050 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1051 Add a g_warning() when this returns NULL, because that it not allowed
1054 2007-07-02 Armin Burgmeier <armin@openismus.com>
1056 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1057 note when trying to cancel the wizard. This fixes projects.maemo.org
1060 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1062 * src/modest-tny-account.h:
1063 * src/modest-tny-account.c:
1064 (modest_tny_account_new_from_server_account),
1065 (modest_tny_account_new_from_server_account_name),
1066 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1067 because this must now be set before setting the proto. This is usd in
1068 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1069 warning in camel_session_get_service() caused by
1070 tny_camel_transport_account_prepare().
1072 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1075 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1077 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1079 (modest_connection_specific_smtp_edit_window_init):
1081 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1082 of "changed" for now
1084 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1086 * src/modest-tny-account.c:
1087 (modest_tny_account_new_from_server_account):
1088 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1089 now uses to request a connection when it needs one, and which it uses
1090 to tell us that something is wrong with the connection, so we can force
1091 the accounts offline to prevent further problems.
1093 * src/modest-defs.h:
1094 * src/modest-init.c: (init_default_settings):
1095 * src/modest-mail-operation.c:
1096 (modest_mail_operation_update_account):
1097 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1098 This should not be necessary anymore. Do not set the conf key that
1099 determined this (it was always TRUE and not set anywhere else).
1101 * src/modest-ui-actions.h: Remove unused and unimplemented
1102 modest_ui_actions_on_online_toggle_toggled().
1104 2007-06-29 Murray Cumming <murrayc@murrayc.com
1106 * src/maemo/modest-main-window.c: (connect_signals):
1107 Don't connect to delete_event twice. Maybe this was harmless.
1109 2007-06-29 Murray Cumming <murrayc@murrayc.com
1111 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1112 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1113 Debug output to give some more clue when a folder move is not allowed.
1115 2007-06-28 Murray Cumming <murrayc@murrayc.com
1117 * src/modest-tny-account.c: (on_modest_file_system_info),
1118 (modest_tny_account_get_mmc_account_name):
1119 Always call the callback, without checking whether the name has changed.
1120 * src/widgets/modest-folder-view.c: (strings_are_equal),
1121 (on_model_foreach_set_name), (on_get_mmc_account_name),
1122 (text_cell_data): Compare the name here, and use the name from
1123 the account rather than from the
1124 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1125 if the name was changed after the account was added to the model.
1126 That's a tinymail bug but not one that I want to fix now.
1128 This finally fixes projects.maemo.org bug NB#59301.
1130 2007-06-27 Armin Burgmeier <armin@openismus.com>
1132 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1135 2007-06-27 Murray Cumming <murrayc@murrayc.com
1137 * src/modest-tny-account.h:
1138 * src/modest-tny-account.c:
1139 Added modest_tny_account_get_mmc_account_name(), to set the memory
1140 card name asynchronously for the given account and then notify.
1141 (modest_tny_account_new_for_local_folders): Use this new function instead
1142 of using hildon_file_system_info_async_new() directly.
1144 * src/widgets/modest-folder-view.c: (text_cell_data):
1145 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1146 gtk_tree_model_row_changed() when it is available.
1148 This should fix projects.maemo.org bug NB#59301.
1150 2007-06-27 Murray Cumming <murrayc@murrayc.com
1152 * src/modest-mail-operation.c: (update_account_thread),
1153 (get_msgs_full_thread): Fix typo failures in the revert
1156 2007-06-27 Murray Cumming <murrayc@murrayc.com
1158 * src/maemo/modest-maemo-global-settings-dialog.c:
1159 (idle_select_default_focus):
1160 * src/modest-mail-operation.c: (idle_notify_progress),
1161 (idle_notify_progress_once), (set_last_updated_idle),
1162 (update_account_thread), (get_msgs_full_thread):
1163 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1164 * src/widgets/modest-header-view.c:
1165 (idle_notify_headers_count_changed_destroy),
1166 (idle_notify_headers_count_changed):
1167 Reverted the additions of gdk_threads_enter/leave(), in case this
1168 helps with a startup hang on the device.
1170 2007-06-26 Armin Burgmeier <armin@openismus.com>
1172 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1173 for supported secure authentication methods from server by
1174 gtk_dialog_run(), saving CPU time and a potential race condition.
1176 2007-06-26 Armin Burgmeier <armin@openismus.com>
1178 * src/maemo/modest-maemo-utils.h:
1179 * src/maemo/modest-maemo-utils.c: Added a
1180 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1181 only error code to tell the calling code when the user canceled the
1184 * src/maemo/modest-account-settings-dialog.h:
1185 * src/maemo/modest-account-settings-dialog.c:
1186 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1187 message if the retrieval of secure authentication methods was canceled
1188 by the user. Perform the check before saving anything to configuration
1189 to not end up with half-committed configuration changes, do not show
1190 a "Saving to configuration failed" note when authentication methods
1191 could not be retrieved.
1193 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1196 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1198 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1199 Only return the first level of folders under accounts, because the
1200 osso-global-search UI spec doesn't want the rest.
1201 This fixed projects.maemo.org bug NB#61811.
1203 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1205 * src/modest-tny-account-store.c:
1206 * src/modest-tny-account-store.h:
1207 Added modest_tny_account_is_memory_card_account().
1208 * src/maemo/modest-main-window.c: (create_details_widget):
1209 Show the same information items for the memory card as we show for the
1210 local-folders, to fix projects.maemo.org bug NB#59307.
1212 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1214 * src/modest-tny-account-store.c: (get_password):
1215 Added some checks for NULL to maybe prevent crashes, though I think
1216 it was Philip's last commit that actually prevented the crash here
1217 when creating a first new account.
1218 But the new account is still not usable (no messages are shown)
1219 until a restart of the application.
1221 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1223 * src/maemo/modest-maemo-global-settings-dialog.c:
1224 (idle_select_default_focus):
1225 * src/modest-mail-operation.c: (idle_notify_progress),
1226 (idle_notify_progress_once), (idle_notify_update_account_queue),
1227 (set_last_updated_idle), (update_account_thread),
1228 (notify_get_msgs_full), (get_msgs_full_destroyer),
1229 (get_msgs_full_thread):
1230 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1231 * src/widgets/modest-header-view.c:
1232 (idle_notify_headers_count_changed_destroy),
1233 (idle_notify_headers_count_changed):
1234 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1235 all idle handlers, because some other thread could be blocking
1236 the GDK lock, so that it can do GUI stuff.
1238 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1240 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1241 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1242 (on_idle_send_receive), (on_idle_open_default_inbox):
1243 * src/maemo/modest-msg-edit-window.c:
1244 (modest_msg_edit_window_attach_file_noninteractive):
1245 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1246 to prevent a hang. I don't quite understand why these are necessary,
1247 beause we should already be in the main loop. I guess something outside
1248 of the main loop is taking the lock.
1250 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1251 we are really using URIs, and use files that are more likely to exist.
1253 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1255 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1256 necessary because configure.ac now defines different variables.
1258 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1260 * libmodest-dbus-client/libmodest-dbus-client.c:
1261 * libmodest-dbus-client/libmodest-dbus-client.h:
1262 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1263 libmodest_dbus_client_compose_mail() is what things actually use.
1265 * src/dbus_api/modest-dbus-api.h:
1266 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1267 * tests/dbus_api/Makefile.am:
1268 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1271 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-init.c: (modest_init_local_folders):
1274 For memory-card (or other non local-folders) maildir accounts,
1275 always create an Archive folder, so that there is somewhere to put
1276 messages. This should be less confusing, because the user does not need
1277 to guess that the need to create a folder.
1279 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1281 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1282 Fixed icon size by using (50, 50) which is the same as defined by
1285 2007-06-25 Armin Burgmeier <armin@openismus.com>
1287 * src/widgets/modest-window-mgr.c:
1288 * src/modest-init.c:
1289 * configure.ac: Correctly recognize hildon-notify presence and fixed
1290 the build without it being installed.
1292 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1294 * libmodest-dbus-client/libmodest-dbus-client.c:
1295 (libmodest_dbus_client_search): Fix the build. Sorry.
1296 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1297 (reply_forward_cb): Initialize variables to fix the build.
1299 * src/modest-tny-account-store.c:
1300 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1301 comparison (a silly typo) so that email search results can be opened
1302 when there are more than one account.
1304 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1306 * libmodest-dbus-client/libmodest-dbus-client.c:
1307 (libmodest_dbus_client_search),
1308 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1309 instead of 1 second, because the search gets folders and messages from
1310 the server, which can take a long time. When it times out,
1311 osso-global-search will report no results.
1313 We need to specify whether we should search only cached information
1314 (maybe with a user preference), and the osso-email-search-plugin
1315 API should really be improved to allow that option, and to allow results
1316 to be delivered asynchronously in batches.
1318 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1320 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1321 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1322 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1324 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1326 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1327 that is an empty string. D-Bus seems to give us these instead of NULL.
1329 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1331 * src/dbus_api/modest-dbus-callbacks.c:
1332 * src/maemo/easysetup/modest-easysetup-wizard.h:
1333 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1334 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1335 (modest_connection_specific_smtp_edit_window_init):
1336 * src/maemo/modest-maemo-global-settings-dialog.c:
1338 * src/maemo/modest-maemo-utils.c:
1339 (modest_maemo_utils_setup_images_filechooser):
1340 * src/maemo/modest-main-window.c: (create_details_widget):
1341 * src/maemo/modest-msg-edit-window.c:
1342 (modest_msg_edit_window_attach_file_noninteractive),
1343 (modest_msg_edit_window_color_button_change),
1344 (modest_msg_edit_window_set_zoom):
1345 * src/modest-mail-operation.c: (update_account_thread):
1346 * src/modest-tny-account-store.c:
1347 * src/modest-tny-account.c:
1348 * src/widgets/modest-global-settings-dialog.c:
1349 * src/widgets/modest-window.h:
1351 Fixed build on bora!
1353 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1355 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1356 * src/modest-search.c: (modest_search_folder),
1357 (modest_search_all_accounts): Actually search only in the specified folder,
1358 doing a simple match on the folder ID.
1359 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1360 and added some documentation.
1362 2007-06-22 Armin Burgmeier <armin@openismus.com>
1364 * src/maemo/modest-maemo-utils.h:
1365 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1366 modest_maemo_utils_get_supported_secure_authentication_methods.
1368 * src/maemo/easysetup/modest-easysetup-wizard.c:
1369 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1370 one occured, not just "Server does not support secure authentication".
1372 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-tny-account-store.c: (get_password):
1375 Restored the call to tny_account_set_user() because Philip seems to have
1376 stopped this from crashing (by not using the freed string). It still does
1377 not work, but now we can test it.
1379 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1381 * src/maemo/modest-msg-edit-window.c: (init_window):
1382 Comment out use of an uninitialzed GtkScrolledWindow variable,
1383 to fix the build and stop a crash. Yet again.
1385 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-tny-account-store.c: (get_password):
1388 Remove the call to tny_account_set_user() because this actually crashes.
1389 As mentioned in the last commit, it is known to not work anyway.
1391 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1393 * src/modest-tny-account-store.c: (get_password):
1394 Use tny_account_set_username() to tell tinymail that the username might
1395 have changed too. But tinymail ignores this: see projects.maemo.org
1397 * src/modest-ui-actions.c:
1398 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1399 reset the connection when changing the username, and improve the comments.
1400 Save the changed username to gconf at least, so it is used when Modest is
1403 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1405 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1406 Do not use a query, so that we get all folders, including for POP and
1407 local-folders. They work as search criteria too.
1408 This fixes projects.maemo.org bug NB#57740.
1410 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1413 Comment out the use of hildon_notification_set_sound() because it is
1414 not declared, to fix the build. Warnings are serious, people.
1416 2007-06-21 Armin Burgmeier <armin@openismus.com>
1418 * src/maemo/modest-maemo-utils.h:
1419 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1420 modest_maemo_utils_get_supported_secure_authentication_methods()
1421 to query authentication methods for a specific user. This should fix
1422 projects.maemo.org bug NB#61369.
1424 * src/maemo/easysetup/modest-easysetup-wizard.c:
1425 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1428 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1430 * libmodest-dbus-client/libmodest-dbus-client.h:
1431 * libmodest-dbus-client/libmodest-dbus-client.c:
1432 (modest_dbus_message_iter_get_search_hit),
1433 (libmodest_dbus_client_search):
1434 Reorganised and commented this.
1435 Removed modest_search_hit_free() from the public API because it
1438 Added libmodest_dbus_client_get_folders() and
1439 modest_folder_result_list_free().
1441 * src/dbus_api/modest-dbus-api.h:
1442 * src/dbus_api/modest-dbus-callbacks.c:
1443 (modest_dbus_req_filter): Commented. Moved most code to
1444 on_dbus_method_search() and added on_dbus_method_get_folders().
1446 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1447 of the extra D-Bus handler.
1449 * tests/dbus_api/Makefile.am:
1450 * tests/dbus_api/test_get_folders.c: New test for
1451 libmodest_dbus_client_get_folders(). This seems to return an empty list
1452 at the moment. That could be the same error that causes the message list
1453 to be empty sometimes.
1454 This should help with projects.maemo.org bug NB#57740.
1456 2007-06-21 Armin Burgmeier <armin@openismus.com>
1458 * src/modest-mail-operation.c: Do not call
1459 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1460 notify the operation's end after having set the status to CANCELED for
1461 the operation queue to listen on. This fixes a deadlock when there
1462 were mail operations in the queue during its finalization.
1464 * src/modest-singletons.c: Reordered uninitialization of the account
1465 manager to happen after the mail operation queue was uninitialized
1466 because the mail operation's in the queue might still try to access
1467 the account manager (see modest_mail_operation_notify_end()). This
1468 fixes a potential crash when terminating the application.
1470 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1472 * src/modest-search.c:
1473 (search_mime_part_and_child_parts): Moved some code here so we
1474 can search recursively in child folders.
1475 (modest_search_folder): Search in the message as a mime part, instead
1476 of just its child mime parts.
1477 (read_chunk), (search_mime_part_ogs):
1478 Check how many bytes were read, to prevent an endless loop.
1479 Searching in message bodies now works. This finishes the fix for
1480 projects.maemo.org bug NB#61007.
1482 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1484 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1485 Add a g_warning when the item is not a folder.
1487 * src/modest-ui-dimming-rules.c:
1488 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1489 when selected item is not a folder (for instance, an account), because
1490 the UI spec only talks about folders.
1491 I am not sure what the UI spec wants, so this might not totally fix
1492 projects.maemo.org bug NB#60794.
1494 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1496 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1497 (load_from_file): Sort the list. The unsorted list would be more noticeable
1498 in non-English locales.
1500 * src/maemo/modest-msg-edit-window.c:
1501 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1502 warning and fix the build.
1504 * src/maemo/modest-progress-bar-widget.c:
1505 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1506 avoid a g_warning, and probably to avoid a crash.
1508 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1510 * src/modest-search.c: (modest_search_folder): Check for a GError
1511 when calling tny_folder_get_headers(), to show that this is not the cause
1514 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1516 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1517 Actually set the body query instead of the subject query.
1519 * src/modest-search.c: (search_mime_part_ogs),
1520 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1521 which would probably cause it to fail if we got this far.
1523 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1524 to simplify the code.
1525 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1526 be causing search-in-body to fail.
1528 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1530 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1532 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1533 Better debug message when the folder cannot be found.
1534 This should help with fixing projects.maemo.org bug #61287.
1535 * src/modest-search.c: (add_hit): Do not leak the furl string.
1537 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1539 * src/modest-ui-actions.c:
1540 (modest_ui_actions_on_folder_selection_changed):
1541 Do not special-case TNY_MERGE_FOLDER here, because
1542 modest_tny_folder_get_account() already does that. This fixes
1543 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1544 shown when the Outbox was selected).
1546 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1548 * libmodest-dbus-client/libmodest-dbus-client.c:
1549 (_dbus_iter_get_string_or_null): Initialize the string variable in
1550 case this helps with Dirk's crash.
1552 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1554 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1555 though it is not implemented yet (this function is maybe not even used),
1556 to avoid breaking ABI in future.
1557 * libmodest-dbus-client/libmodest-dbus-client.c:
1558 (get_attachments_string): Moved some code into this generic function.
1559 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1560 sends email. It is maybe not used.
1561 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1562 (on_send_mail): Use attachments.
1564 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1565 * src/maemo/modest-msg-edit-window.c:
1566 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1567 a filename before using it, to fix projects.maemo.org bug NB#58233.
1569 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1572 Initialize the continue_download variable to fix the build, and probably
1573 to fix randome behaviour.
1575 2007-06-18 Armin Burgmeier <armin@openismus.com>
1577 * src/modest-tny-send-queue.h:
1578 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1579 the queue so we can later show it in the UI. Replaced
1580 modest_tny_send_queue_msg_is_being_sent() by
1581 modest_tny_send_queue_get_msg_status().
1583 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1585 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1586 gpointer. This probably was not harmful, but just to be sure.
1588 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1590 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1591 Fix the build, but leave the function broken on Bora, because
1592 hildon_uri_action_get_service() does not exist.
1593 osso_uri_action_get_service() does not exist either, it seems.
1595 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1597 * src/modest-tny-account.c:
1598 (modest_tny_account_new_from_server_account):
1599 Uncommented the url debug output again, because it is useful for
1600 debugging, as I said in the comment.
1602 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1604 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1606 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1607 for Mameo Bora, to fix the build.
1609 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1612 Fixed build with hildon < 0.99
1614 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1615 Check if the selected account is busy instead of checking all accounts
1617 * src/modest-account-mgr-priv.h:
1618 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1619 (modest_account_mgr_init), (compare_account_name),
1620 (modest_account_mgr_set_account_busy),
1621 (modest_account_mgr_account_is_busy):
1622 * src/modest-account-mgr.h:
1623 Added busy information to the account manager. It possible to
1624 set an account to busy or not busy now.
1626 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1627 (modest_mail_operation_update_account),
1628 (modest_mail_operation_notify_end):
1629 Set the account to busy/not busy depending on the operation state.
1631 * src/widgets/modest-account-view.c:
1632 (modest_account_view_finalize), (get_last_updated_string),
1633 (update_account_view), (on_account_busy_changed), (init_view):
1634 Show string "Refreshing..." if the account is currently busy.
1636 All this fixes projects.maemo.org bug NB#59711
1638 2007-06-14 Armin Burgmeier <armin@openismus.com>
1640 * src/widgets/modest-attachments-view.h:
1641 * src/widgets/modest-attachments-view.c: Added
1642 modest_attachments_view_has_attachments() and fixed coordinate
1643 transformation in get_att_view_at_coords(). This fixes attachment
1646 * src/widgets/modest-msg-view.c: Make use of
1647 modest_attachments_view_has_attachments() to decide whether to show
1648 attachments in the header.
1650 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1652 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1653 (on_change), (on_combo_security_changed),
1654 (modest_connection_specific_smtp_edit_window_init),
1655 (modest_connection_specific_smtp_edit_window_set_connection),
1656 (modest_connection_specific_smtp_edit_window_is_dirty):
1657 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1658 * src/maemo/modest-connection-specific-smtp-window.c:
1661 Show an comfirmation dialog for the smpt-edit-window if there are
1662 unsaved changes and the user hits cancel.
1663 (projects.maemo.org bug NB#60479)
1665 2007-06-14 Armin Burgmeier <armin@openismus.com>
1667 * src/maemo/easysetup/modest-easysetup-wizard.c:
1668 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1669 address" info in banner instead of node, and select all the text as
1670 per UI spec. This fixes projects.maemo.org bug NB#60550.
1672 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1674 reviewed by: <delete if not using a buddy>
1676 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1677 * src/modest-ui-actions.c: (folder_refreshed_cb):
1679 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1681 * src/widgets/modest-folder-view.c: (filter_row):
1682 Explictly filter out the per-account outbox accounts. I don't know why
1683 these only sometimes show up, but now they should never show up in the UI.
1684 This should fix projects.maemo.org bug NB#60160.
1686 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1688 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1689 when the toolbar does not exist yet.
1690 * src/modest-widget-memory.c: (save_settings_header_view):
1691 Added g_warnings() to help us to discover when we are trying to set
1692 an empty columns list in gconf.
1694 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1696 * src/modest-init.h:
1697 * src/modest-init.c:
1698 Added modest_init_get_default_header_view_column_ids().
1700 * src/modest-widget-memory.c: (restore_settings_header_view):
1701 Use the new function to get defaults, if the gconf key is empty,
1702 instead of not creating any columns. This seems to fix the
1703 empty right-hand pane problems.
1705 * src/widgets/modest-header-view.h: Improved documentation.
1707 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1709 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1710 Revert the use of the display name as the account name, because this
1711 is generally wrong and would break the code that follows.
1713 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1715 * src/maemo/easysetup/modest-easysetup-wizard.c:
1716 (check_for_supported_auth_methods), (on_before_next),
1719 More correct fix for projects.maemo.org bug NB# 58991
1720 Do not longer accept AUTH_PASSWORD as secure method and choose
1721 correct method when creating the account.
1723 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1725 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1726 Fixed projects.maemo.org bug NB# 58991
1728 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1730 * src/modest-init.c: (modest_init_init_core),
1731 (modest_init_local_folders): Fixed compilation errors.
1733 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1735 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1736 Remove unnecessary lib/include, though it is good in principle when needed.
1738 * src/modest-init.c: (modest_init_one_local_folder),
1739 (modest_init_local_folders):
1740 * src/modest-init.h: Initialize the .modest library for memory cards,
1741 instead of just doing nothing for them. This should allow us to create
1742 folders there, fixing projects.maemo.org bug NB#59297.
1744 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1746 * libmodest-dbus-client/libmodest-dbus-client.c:
1747 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1748 (libmodest_dbus_client_compose_mail),
1749 (libmodest_dbus_client_open_message),
1750 (libmodest_dbus_client_send_and_receive),
1751 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1753 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1754 (on_idle_open_message), (modest_dbus_req_handler),
1755 (search_result_to_message), (modest_dbus_req_filter):
1756 * src/modest-search.c: (add_hit), (modest_search_folder),
1757 (modest_search_all_accounts): Improved debug messages.
1759 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1761 * src/modest-tny-account-store.c:
1762 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1765 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1768 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-tny-account-store.c: (get_server_accounts):
1771 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1772 even when there are no accounts, so that the Outbox folder is always
1773 visible. This fixes projects.maemo.org bug NB#60158.
1775 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1777 * src/maemo/modest-main-window.c: (create_details_widget):
1778 Use the mcen_va_never logical ID.
1780 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1782 * src/dbus_api/modest-dbus-api.h:
1783 * src/dbus_api/modest-dbus-callbacks.c:
1784 (on_idle_open_default_inbox), (on_open_default_inbox),
1785 (modest_dbus_req_handler):
1786 Added a new OpenDefaultInbox method.
1788 * libmodest-dbus-client/libmodest-dbus-client.h:
1789 * libmodest-dbus-client/libmodest-dbus-client.c:
1790 Added libmodest_dbus_client_open_default_inbox() to call the new
1791 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1792 though it should maybe be used by a new osso-email-interface function.
1794 * tests/dbus_api/Makefile.am:
1795 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1798 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1800 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1801 NULL, so that the signals get all the keys. This should not actually
1802 change any behaviour because we currently update everything when anything
1805 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1807 * src/widgets/modest-folder-view.c: (text_cell_data),
1808 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1809 (find_inbox_iter): If tinymail tells us that the folder is
1810 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1811 This causes the inbox to be selected at startup, fixing part of
1812 projects.maemo.org bug NB#56305.
1814 * src/modest-ui-dimming-rules.c:
1815 (modest_ui_dimming_rules_on_tools_smtp_servers):
1816 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1817 the SMTP servers menu item.
1818 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1819 that the SMTP Servers menu item is dimmed when there are no accounts,
1820 as a future version of the UI spec will require. This fixes
1821 projects.maemo.org bug NB#56305.
1823 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1825 * src/maemo/modest-maemo-utils.c:
1826 (modest_maemo_utils_get_supported_secure_authentication_methods):
1827 Added label to dialog instead of unreadable title
1829 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1830 (modest_main_window_new):
1831 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1834 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1835 * src/modest-account-mgr.h:
1836 Added method to avoid code duplication
1838 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1839 (modest_ui_actions_on_send_receive):
1840 Use modest_account_mgr_has_accounts
1842 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1844 * src/maemo/easysetup/modest-presets.c:
1845 (modest_presets_get_info_server_security): Do not report secure auth
1847 * src/modest-protocol-info.c: Use the defines for the gconf key names
1848 for secure authentication. This was not working because we were writing
1849 Password and reading password, and the check was case sensitive.
1850 With this, gmail now works for receiving and sending when created via
1853 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1855 * src/maemo/easysetup/modest-presets.c:
1856 (modest_presets_get_info_server_security): Correct the key name for
1857 SecureSmtp, because it seems to be case-sensitive.
1858 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1859 Do not try to get the 0th notebook page if there are 0 pages, to
1860 avoid a g_warning().
1862 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1864 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1865 Prevent use of the new notification feature for now, because it currently
1866 shows one dialog for each new email, which is annoying.
1868 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1870 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1871 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1872 when no country was selected, so that we show the global ones.
1873 * src/maemo/easysetup/modest-presets.c:
1874 (modest_presets_get_providers): Return only the global providers, not
1875 all providers when mmc=0 was requested.
1877 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1879 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1880 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1881 provider ID in the combo.
1883 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1884 Do not show the page numbers, because it would be confusing when we add
1885 the 2 extra pages for the custom setup, when the user chooses the "Other"
1886 provider. This fixes projects.maemo.org bug NB#59028
1888 * src/modest-init.c: (modest_init_init_core),
1889 (modest_init_local_folders):
1890 * src/modest-init.h:
1891 * src/modest-tny-account.c:
1892 (modest_tny_account_new_for_local_folders): Do not create default folders
1893 for the memory card. This should fix projects.maemo.org bug NB#59328.
1895 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1897 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1898 Free the changed_conf_keys string items. They are already freed in the
1899 idle handler if that runs first.
1901 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1903 * src/modest-ui-actions.c:
1904 (modest_ui_actions_on_password_requested): Check that the server name
1905 is not NULL, because I just saw a password dialog with (null) as the
1908 * src/modest-tny-folder.[h|c]: Added
1909 modest_tny_folder_is_memory_card_folder().
1910 * src/modest-ui-dimming-rules.c:
1911 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1912 menu item for memory cards, as per the UI spec (section 7.4). This should
1913 fix projects.maemo.org bug NB#59297.
1915 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1917 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1918 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1919 is another problem with the code, see Murray's comment at line 772)
1921 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1923 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1924 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1925 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1926 (load_from_file), (easysetup_country_combo_box_init),
1927 (easysetup_country_combo_box_get_active_country_ids),
1928 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1929 instead of just one ID, to avoid duplicate country names in the UI.
1931 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1932 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1933 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1934 a single ID, avoiding duplicate providers.
1935 * src/maemo/easysetup/modest-easysetup-wizard.c:
1936 (on_combo_account_country): Adapt to use a list.
1938 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1940 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1941 keys changed in the last X seconds.
1943 * src/modest-account-mgr.h:
1944 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1945 (on_key_change), (modest_account_mgr_class_init),
1946 (modest_account_mgr_init), (modest_account_mgr_finalize):
1947 As the keys are changed, save them in a GSList* and signal that GSList*
1948 further every X seconds, to batch changes, to allow us to do just one
1949 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1950 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1952 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1953 changed signal signature.
1955 * src/modest-conf.c: (modest_conf_set_list),
1956 (modest_conf_on_change): Reenable notification.
1958 (modest_conf_maemo_fake_on_change): Comment out the hack that
1959 notified immediately instead of asynchronously.
1961 * src/widgets/modest-account-view.h:
1962 * src/widgets/modest-account-view.c:
1963 (update_account_view): Select the previously-selected account ID,
1964 if possible. This fixes projects.maemo.org bug NB#56933.
1966 (on_account_changed), (on_account_removed),
1967 (modest_account_view_select_account):
1969 Remove the block/unblock functions
1970 because they were not useful.
1972 * src/maemo/modest-account-view-window.c:
1973 (on_delete_button_clicked), (on_edit_button_clicked),
1974 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1976 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1978 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1979 Improve the error dialog to show Incorrect Account Settings, which seems
1980 clearer, and say that the internal error message (to be removed from the
1981 dialog later) is often misleading.
1982 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1984 * src/modest-tny-account.c:
1985 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1986 URL because this is so useful for debugging on the device.
1988 * src/widgets/modest-serversecurity-combo-box.c:
1989 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1991 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1993 * src/modest-mail-operation.c:
1994 (modest_mail_operation_send_new_mail):
1995 Added a comment about a nasty but apparently harmless message. Details
1996 added to the wiki g_warnings() page.
1998 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2000 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2001 (modest_tny_send_queue_class_init):
2002 Do not use the priv struct because it is empty, to avoid g_warnings
2003 about a non-existant priv struct.
2005 * src/modest-tny-account-store.c:
2006 (modest_tny_account_store_get_server_account),
2007 (modest_tny_account_store_get_transport_account_for_open_connection
2008 ): Do not try to get transport server accounts for local folders,
2009 because they don't have any. This avoids a g_warning().
2011 * src/maemo/modest-main-window.c:
2012 (modest_main_window_notify_send_receive_initied),
2013 (on_configuration_key_changed):
2014 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2015 * src/modest-defs.h:
2016 * src/modest-mail-operation.c:
2017 (modest_mail_operation_update_account):
2018 * src/modest-tny-account-store.h:
2019 * src/modest-tny-account.c:
2020 (modest_tny_account_get_special_folder),
2021 (modest_tny_account_new_for_local_folders),
2022 (modest_tny_account_new_for_per_account_local_outbox_folder):
2023 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2024 * src/modest-tny-local-folders-account.c:
2025 (add_account_folders_to_merged_folder):
2026 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2027 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2028 (modest_ui_actions_on_send):
2029 * src/widgets/modest-folder-view.c: (update_model):
2030 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2031 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2032 modest_tny_account_store_get_tny_account_by_account() to
2033 modest_tny_account_store_get_server_account() to make the code clearer.
2035 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2037 * src/dbus_api/modest-dbus-api.h:
2038 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2039 * src/maemo/modest-msg-edit-window.c:
2040 (modest_msg_edit_window_attach_file_noninteractive):
2041 added g_warning in case the file to be attached does not exist
2042 * tests/dbus_api/test_compose_mail.c: (main):
2043 removed obsolete comment, added generic files as test case
2045 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2047 * src/modest-tny-account-store.c: (get_server_accounts):
2048 Create the local folders account only once, not once for each outbox, and
2049 not only when there are some outboxes.
2051 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2053 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2054 code that is causing a crash at startup. Sergio says that he is fixing this.
2056 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2058 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2059 * src/maemo/modest-account-settings-dialog.c:
2060 (create_page_outgoing),
2061 (modest_account_settings_dialog_set_account_name),
2062 (save_configuration):
2063 - Fixed handling of the "Use secure authentication" toggle to comply with
2064 the ui specification. See also projects.maemo.org bug NB#58400
2066 - Restore the Secure connection setting combo correctly when loading
2069 * src/maemo/modest-maemo-utils.c:
2070 (on_camel_account_get_supported_secure_authentication),
2071 (modest_maemo_utils_get_supported_secure_authentication_methods):
2072 Fixed a crasher if operation is canceled
2074 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2075 (modest_protocol_info_auth_is_secure):
2076 * src/modest-protocol-info.h:
2078 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2079 the sense of the "Use secure authentication" toggle.
2081 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-account-store.h:
2084 * src/modest-tny-account-store.c:
2085 Added modest_tny_account_store_get_local_folders_account().
2087 * src/modest-tny-folder.h:
2088 * src/modest-tny-folder.c:
2089 (modest_tny_folder_get_account):
2090 Added this replacement for tny_folder_get_account() which returns
2091 the local-folders account for TnyMergeFolders, to avoid the
2092 warning about the unimplemented get_account_func() vfunc().
2094 (modest_tny_folder_get_rules),
2095 * src/modest-ui-actions.c:
2096 (modest_ui_actions_on_folder_selection_changed):
2097 * src/modest-mail-operation.c:
2098 (modest_mail_operation_remove_folder),
2099 (modest_mail_operation_xfer_folder),
2100 (modest_mail_operation_rename_folder),
2101 (modest_mail_operation_get_msg),
2102 (modest_mail_operation_get_msgs_full),
2103 (modest_mail_operation_remove_msg),
2104 (modest_mail_operation_xfer_msgs),
2105 (modest_mail_operation_refresh_folder):
2106 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2108 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2110 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2111 (modest_server_account_set_security):
2112 * src/modest-defs.h: Add comments explaining that our
2113 UI spec means TLS when it says Normal, so these do not look like errors.
2115 * src/modest-tny-account.c:
2116 (modest_tny_account_new_from_server_account): Use the new tinymail
2117 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2118 for TLS. This should fix projects.maemo.org bug NB#58460.
2120 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 (create_account): Correct the position of the gconf sanity check warning.
2124 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2125 of using the g_idle_add() hack, because this does not seem to be necessary
2126 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2127 caused by something other than maemo's gconf.
2128 This fixes projects.maemo.org bug #59022.
2130 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2132 * src/modest-account-mgr-helpers.c:
2133 (modest_account_mgr_get_default_account): Do not check that the account
2134 exists if there is no default account (NULL), to fix a runtime warning.
2136 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2138 * src/widgets/modest-folder-view.c: (update_model):
2139 Do not unref the treemodel before we have finished with it.
2140 This prevents a valgrind warning and an occasional crash at startup.
2142 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2144 * libmodest-dbus-client/libmodest-dbus-client.h:
2145 added libmodest_dbus_client_compose_mail()
2146 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2148 added functions needed for SendAsMail() functionality
2149 * src/maemo/modest-msg-edit-window.c:
2150 (modest_msg_edit_window_attach_file_noninteractive):
2151 non interactively attaching files to message edit window
2152 * src/widgets/modest-msg-edit-window.h:
2153 * tests/dbus_api/Makefile.am:
2154 added test_compose_mail.c
2155 * tests/dbus_api/test_compose_mail.c: (main):
2157 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2159 * src/modest-account-view.c:
2160 Fixed bug projects.maemo.org bug NB#59307
2162 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2164 * src/maemo/easysetup/modest-easysetup-wizard.c:
2165 (get_serverport_incoming), (on_before_next), (create_account):
2166 * src/maemo/modest-account-settings-dialog.c:
2167 (modest_account_settings_dialog_set_account_name):
2168 * src/maemo/modest-maemo-utils.c:
2169 (on_camel_account_get_supported_secure_authentication_status),
2170 (on_camel_account_get_supported_secure_authentication),
2171 (on_secure_auth_cancel),
2172 (modest_maemo_utils_get_supported_secure_authentication_methods):
2174 Implemented security authentication for settings and easysetup.
2176 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/modest-main-window.c: (create_details_widget):
2179 Show the total size for memory card accounts too, instead of showing
2180 the name again. Fixes bug projects.maemo.org bug NB#59307.
2182 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2185 * src/modest-tny-simple-folder-store.c:
2186 * src/modest-tny-simple-folder-store.h: Removed.
2188 * src/modest-tny-local-folders-account.h
2189 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2190 for the local-folders maildir, with an extra TnyMergedFolder containing
2191 the folders of the per-account outbox store accounts.
2192 * src/modest-tny-account-store.c: (get_server_accounts):
2193 Add the outboxes to the special local folders account after creating it.
2195 * src/modest-tny-account.c:
2196 (modest_tny_account_new_for_local_folders): Create the derived
2197 account when creating the main local-folders account.
2199 * src/maemo/modest-main-window.c: (create_details_widget),
2200 (modest_main_window_set_contents_style):
2201 Adapted to the use of the derived account instead of the folder store.
2203 * src/modest-ui-actions.c:
2204 (modest_ui_actions_on_folder_selection_changed):
2205 * src/modest-ui-dimming-rules.c:
2206 (modest_ui_dimming_rules_on_new_folder):
2207 * src/widgets/modest-folder-view.c: (text_cell_data),
2208 (icon_cell_data), (filter_row), (update_model),
2209 (get_cmp_rows_type_pos):
2212 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2213 Do not get the priv struct, because no priv struct has been set,
2214 to avoid a runtime warning.
2216 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2217 #ifelse with #else, to fix a warning, to fix the build.
2220 2007-06-05 Christian Kellner <ckellner@openismus.com>
2222 * libmodest-dbus-client/libmodest-dbus-client.c:
2223 Fix small typo in doc (why do you always see them
2224 AFTER committing stuff?)
2227 2007-06-05 Christian Kellner <ckellner@openismus.com>
2229 * libmodest-dbus-client/libmodest-dbus-client.c:
2230 (libmodest_dbus_client_search):
2231 Initialize hit list with NULL. Also set folder list
2232 to "" if NULL was supplied.
2235 2007-06-03 Christian Kellner <ckellner@openismus.com>
2237 * libmodest-dbus-client/libmodest-dbus-client.c:
2238 (modest_search_hit_list_free):
2239 Make it save to call it with NULL.
2241 * src/dbus_api/modest-dbus-callbacks.c:
2242 * src/modest-search.c:
2243 Return full ModestSearchHits as the search result list not TnyHeader
2244 since can't be around withouth the correspoding TnyFolder.
2246 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2248 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2249 Added currently commented code to check for secure auth
2251 * src/maemo/modest-account-settings-dialog.c: (on_response),
2252 (save_configuration), (show_ok):
2253 Fixed projects.maemo.org bugs NB #59248 and #59251
2255 * src/maemo/modest-maemo-utils.c:
2256 (on_camel_account_get_supported_secure_authentication_status),
2257 (on_camel_account_get_supported_secure_authentication),
2258 (modest_maemo_utils_get_supported_secure_authentication_methods):
2259 * src/maemo/modest-maemo-utils.h:
2260 Moved get_supported_secure_authentication() method here to be able
2261 to use it from easysetup wizard.
2263 * src/modest-pair.c: (on_pair_compare_as_string):
2264 Should compare string with first part of pair and not
2265 strcmp pairs which will crash.
2267 * src/modest-protocol-info.c:
2268 (modest_protocol_info_protocol_is_store):
2269 * src/modest-protocol-info.h:
2270 Added modest_protocol_info_get_auth_protocol_name()
2272 2007-06-03 Armin Burgmeier <armin@openismus.com>
2274 * src/modest-mail-operation.c:
2275 (modest_mail_operation_get_msgs_full): Set priv->account also when
2276 only retrieving a single message. This avoids a crash when canceling
2279 (modest_mail_operation_notify_end): Do not explicitely remove the
2280 operation from the queue but only emit the progress_changed signal.
2281 The queue itself listens to that signal to remove the operation when
2282 it is finished. This reduces coupling and removes a potential deadlock
2283 when modest_mail_operation_notify_end() is called from the queue
2284 itself. If that is a problem performance-wise, I would suggest to
2285 implement a status-changed signal or something.
2287 * src/modest-mail-operation-queue.c: Make sure to never call a
2288 function from another file while the queue is locked. This (hopefully)
2289 fixes another deadlock when exiting the application while retrieving
2292 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2294 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2295 Fixed build if libogs is not available
2297 2007-06-03 Christian Kellner <ckellner@openismus.com>
2299 * libmodest-dbus-client/libmodest-dbus-client.h:
2300 * libmodest-dbus-client/libmodest-dbus-client.c:
2301 (libmodest_dbus_client_delete_message):
2302 Implement deletion of messages (Client side).
2304 (modest_search_hit_free),
2305 (modest_search_hit_list_free):
2306 Utility functions to free the result hits.
2308 * src/dbus_api/modest-dbus-api.h:
2309 * src/dbus_api/modest-dbus-callbacks.c:
2310 (on_delete_message),
2311 (modest_dbus_req_handler):
2312 Implement deletion of messages (Server side).
2314 * tests/dbus_api/test_search.c: (main):
2317 * tests/dbus_api/Makefile.am:
2318 * tests/dbus_api/test_delete_message:
2319 Add little test for the message deletion logic
2321 2007-06-03 Armin Burgmeier <armin@openismus.com>
2323 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2324 when the operation queue was not empty. projects.maemo.org bug
2327 2007-06-03 Armin Burgmeier <armin@openismus.com>
2329 * src/widgets/modest-account-view.c
2330 (on_account_default_toggled): Toggle default account column
2331 explicitely instead of waiting for gconf notification (which is
2332 currently ignored). This should fix projects.maemo.org bug NB#56910
2333 for now. It should probably be removed when gconf notifications are
2336 2007-06-03 Christian Kellner <ckellner@openismus.com>
2338 * libmodest-dbus-client/libmodest-dbus-client.c:
2339 Removed debugging spew.
2341 * src/dbus_api/modest-dbus-callbacks.c:
2342 Added debugging info.
2344 * src/modest-search.c:
2345 (modest_search_all_accounts):
2346 Use tny_account_store_get_accounts () on the account store
2347 to get all accounts which is the way to get all accounts.
2349 * tests/dbus_api/test_search.c: (main):
2350 Make it possible to supply the search term on the command line.
2352 2007-06-03 Christian Kellner <ckellner@openismus.com>
2354 * libmodest-dbus-client/libmodest-dbus-client.c:
2355 * libmodest-dbus-client/libmodest-dbus-client.h:
2356 Implement searching for mesages over raw dbus. (Client side)
2358 * src/dbus_api/Makefile.am:
2359 * src/dbus_api/modest-dbus-api.h:
2360 * src/dbus_api/modest-dbus-callbacks.c:
2361 * src/dbus_api/modest-dbus-callbacks.h:
2362 Search framework (Server side). Also implement on_idle_open_message().
2364 * src/maemo/modest-platform.c: (modest_platform_init):
2365 Prepare for raw dbus/osso rpc interaction.
2367 * src/modest-search.h:
2368 Changed minsize from unspecific guint to guint32.
2370 * src/modest-search.c:
2372 Added strange hack which magically made tnymail work.
2374 (modest_search_folder),
2375 (modest_search_account),
2376 (modest_search_all_accounts):
2377 Implement helper functions to search all accounts, specific account
2380 * tests/dbus_api/Makefile.am:
2381 * tests/dbus_api/test_open_message.c:
2382 Read url to open from commandline.
2384 * tests/dbus_api/test_search.c:
2385 Implement small test for dbus search stuff
2387 2007-06-02 Armin Burgmeier <armin@openismus.com>
2389 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2390 include account type and account title. This fixes projects.maemo.org
2393 * src/maemo/modest-account-view-window.c: Set a title for the window.
2395 2007-06-02 Armin Burgmeier <armin@openismus.com>
2397 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2398 incoming and outgoing server name based on email address and server
2399 types as long as the names have not been edited manually. This fixes
2400 projects.maemo.org bug NB#58671.
2402 2007-06-02 Armin Burgmeier <armin@openismus.com>
2404 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2405 server type cannot be changed in future to the incoming details page
2406 when creating an account. This fixes projects.maemo.org bug NB#59029.
2408 2007-06-02 Armin Burgmeier <armin@openismus.com>
2410 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2411 and assigned max width chars so that they wrap instead of being
2412 truncated. Fixes projects.maemo.org bug NB#56126.
2414 2007-06-02 Armin Burgmeier <armin@openismus.com>
2416 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2417 introductory note to the connection specific smtp servers dialog, as
2418 section 8.12 of the email UI specification requires. This fixes
2419 projects.maemo.org bug NB#59212.
2421 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2423 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2424 Check for running mail operations, and offer to cancel them, as per the UI
2425 spec. This fixes projects.maemo.org bug NB#59041 .
2426 However, I suspect that tinymail may still use the network connection
2427 in ways that we cannot detect or cancel. But it should at least adapt to
2428 changes fairly well.
2430 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2432 * src/modest-tny-account-store.c: (recreate_all_accounts),
2433 (get_cached_accounts), (get_server_accounts): Do more sensible
2434 ref-counting of the temporarily-cached outbox accounts list. This seems
2435 to fix a crash when entering the password when the password was wrong.
2437 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2439 * src/gnome/modest-main-window.c: (connect_signals):
2440 * src/modest-tny-account-store.c: (get_password),
2441 (modest_tny_account_store_alert): Added comments and clues and
2442 commented-out code about how we currently fail to deal with connection
2443 errors and wrong passwords, and how we should.
2445 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2447 * src/widgets/modest-retrieve-combo-box.c:
2448 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2449 This fixes projects.maemo.org bug NB#58472 .
2451 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2453 * src/maemo/easysetup/modest-easysetup-wizard.c:
2454 (create_page_complete_easysetup):
2455 (create_page_complete_custom): Correct the last commit,
2456 putting the correct sentences in the correct pages.
2458 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2460 * src/maemo/easysetup/modest-easysetup-wizard.c:
2461 (create_page_complete_custom): Show the second sentence of text
2462 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2465 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2467 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2468 Set the leave-on-server conf key by default. This fixes
2469 projects.maemo.org bug NB#59258 .
2471 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2473 * src/maemo/modest-account-view-window.c:
2474 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2475 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2478 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2480 * src/maemo/easysetup/modest-easysetup-wizard.c:
2481 (create_caption_new_with_asterisk):
2482 * src/maemo/modest-account-settings-dialog.c:
2483 (create_caption_new_with_asterisk):
2484 Uncomment the code to add the asterisk, because they are no longer in the
2485 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2486 (update_incoming_server_title): Add an asterisk here too.
2488 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2490 * src/maemo/modest-maemo-global-settings-dialog.c:
2491 (current_connection): Check that we are even connected before trying to
2492 get the current connection name, to prevent a warning.
2494 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2495 Change the comments because tny_maemo_conic_device_connect() is now meant to
2497 * src/modest-mail-operation.c:
2498 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2499 make sure we have a connection and fail if we can't connect.
2501 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2503 * src/maemo/modest-main-window.c:
2504 (on_account_store_connecting_finished): Do not try to get the
2505 connection ID if we are not really connected. I am surprised that
2506 this signal handler is called when we are not connected.
2508 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2510 * src/modest-error.h:
2511 * src/modest-ui-actions.c:
2512 (modest_ui_actions_get_msgs_full_error_handler):
2513 Renamed an enum, added comments, added an enum
2514 for retrieve-limit errors.
2516 * src/modest-mail-operation.c: (foreach_add_item),
2517 (internal_folder_observer_update), (update_account_thread),
2518 (modest_mail_operation_get_msgs_full):
2519 (modest_mail_operation_update_account),
2520 Added comments about how this works, and some code that should
2521 (but does not) check the retrieve-limit. See the TODO comment.
2523 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2525 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2526 Initialize help_id to fix the build. Warnings are good.
2528 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2530 * src/widgets/modest-hbox-cell-renderer.c:
2531 (modest_hbox_cell_renderer_append):
2532 * src/widgets/modest-vbox-cell-renderer.c:
2533 (modest_vbox_cell_renderer_append):
2534 Fix the last commit by doing an extra ref.
2536 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2538 * src/widgets/modest-hbox-cell-renderer.c:
2539 (modest_hbox_cell_renderer_append):
2540 * src/widgets/modest-vbox-cell-renderer.c:
2541 (modest_vbox_cell_renderer_append):
2542 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2543 to fix the build with Maemo Bora.
2544 However, there seems to be a remaining crash, probably due to reference
2547 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2549 * src/modest-tny-account.c:
2550 (modest_tny_account_new_for_local_folders):
2551 Use hildon_file_system_info_async_new() to get a better name for
2552 the memory card account, setting it as the account name.
2553 The timing seems to work, but this is probably
2554 not the best place to do this. See the TODO comment.
2555 * src/maemo/modest-main-window.c: (create_details_widget):
2556 * src/widgets/modest-folder-view.c: (text_cell_data):
2557 Use the tny account name instead of hardcoding a name.
2559 2007-05-30 Christian Kellner <ckellner@openismus.com>
2561 * src/modest-search.c: (modest_search):
2562 Correctly set part_search_func even if we have already parsed
2563 the query and thus a valid OgsTextSearcher object.
2565 2007-05-30 Christian Kellner <ckellner@openismus.com>
2568 Search and check for libogs.
2571 Incooparte the ogs build env.
2573 * src/modest-mime-part-search-stream.c:
2574 * src/modest-mime-part-search-stream.h:
2575 Removed since we do the real searching now in modest-search.c.
2577 * src/modest-search.c:
2578 * src/modest-search.h:
2579 Implement support for ogs. We use that if available and requested
2580 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2581 should now handle the corner case when the search term is spread
2582 across multiple reads.
2583 Also the logic in modest_search () was corrected to search all
2584 requested fields until one is found.
2586 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2588 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2590 * src/modest-init.h:
2591 * src/modest-init.c: Made modest_init_local_folders() take a
2592 path and be public so we can iniitialize maildir folders on
2595 * src/modest-local-folder-info.h:
2596 * src/modest-local-folder-info.c:
2597 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2599 * src/modest-tny-account.c:
2600 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2601 still means the standard local-folders path on the local volume.
2603 * src/modest-tny-account-store.c:
2604 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2605 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2606 all accounts when that happens.
2607 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2608 this too, so it shows up in the treeview.
2610 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/modest-maemo-global-settings-dialog.c:
2613 (current_connection):
2614 * src/widgets/modest-global-settings-dialog.c:
2615 (current_connection_default):
2616 Use the enum values instead of 0, 1 and -1,
2617 to make the code clearer.
2619 * src/modest-account-mgr-helpers.c:
2620 (modest_account_mgr_get_connection_specific_smtp): Make this code
2623 * src/modest-runtime.h:
2624 * src/modest-runtime.c:
2625 Added modest_runtime_remove_all_send_queues().
2626 * src/maemo/modest-main-window.c:
2627 (on_account_store_connecting_finished): Recreate the send queues,
2628 using the appropriate transport accounts for this new connection.
2629 Some futher adapting might be needed if the old send queues are not
2630 automatically stopped at this point.
2632 * src/modest-tny-account-store.c: (get_server_accounts):
2633 Create the connection-specific transport accounts, so that they can
2634 be found later by their ID.
2636 * src/modest-tny-account.h:
2637 * src/modest-tny-account.c:
2638 Added modest_tny_account_new_from_server_account_name().
2639 modest_tny_account_new_from_server_account(): Do not create the
2640 send queues here, because they will be
2641 recreated anyway when the connection changes for the first time.
2643 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2645 * src/modest-local-folder-info.h:
2646 * src/modest-local-folder-info.c:
2647 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2648 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2649 tbox_folder): Take a modest account name instead of a server TnyAccount,
2650 so we can have per-modest-account rather than per-transport-account
2652 We must make sure that we change or recreate the exisitng send queues
2653 when the connection changes for connection-specific transport accounts.
2655 * src/modest-tny-account-store.c:
2656 (create_per_account_local_outbox_folders): Create outboxed per modest
2657 account, not per transport account.
2659 * src/modest-tny-account.h:
2660 * src/modest-tny-account.c:
2661 (modest_tny_account_get_special_folder): For outboxes, get the
2662 parent modest account name. The account is ignored for other folders.
2663 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2664 modest account name rather than a server TnyAccount.
2666 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2668 * src/modest-tny-account.c:
2669 (modest_tny_account_new_from_server_account):
2670 Call modest_runtime_get_send_queue() immediately after creating transport
2671 accounts, so that they start trying to send email from the outbox as soon
2672 as possible at startup. This is probably what we want.
2674 * src/modest-mail-operation.c: (update_account_thread):
2675 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2676 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2677 * src/modest-tny-send-queue.h:
2678 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2679 (modest_ui_actions_on_send):
2680 Added comments about how sending works, though it needs some more work.
2682 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2684 * src/modest-tny-account.c:
2685 (modest_tny_account_get_special_folder): Add TODO because this fails when
2686 the network is busy.
2687 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2688 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2689 Do not try to show this window when there is no active account. The UI
2690 specs does not tell us what to do in this case.
2692 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/Makefile.am:
2697 * src/widgets/Makefile.am: Some dist fixes.
2699 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2701 * src/maemo/modest-connection-specific-smtp-window.c:
2702 (on_button_edit): Make the code clearer, to prevent a double free.
2704 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2706 * src/maemo/modest-account-settings-dialog.c:
2707 (modest_account_settings_dialog_set_account_name),
2708 Check the connection-specific smtp servers checkbox if there are any.
2710 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2711 (modest_connection_specific_smtp_edit_window_init):
2712 Start with a suitable port number.
2714 * src/modest-account-mgr-helpers.h:
2715 * src/modest-account-mgr-helpers.c: Added
2716 modest_account_mgr_get_has_connection_specific_smtp().
2718 (modest_account_mgr_set_connection_specific_smtp),
2719 (modest_account_mgr_remove_connection_specific_smtp),
2720 (modest_account_mgr_get_has_connection_specific_smtp),
2721 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2722 connection-specific smtp server accounts in the account, rather than
2723 the server account conf dir.
2725 This fixes bug projects.maemo.org bug NB#58263 .
2727 * src/modest-tny-account-store.c:
2728 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2729 if there are no server accounts yet, to prevent an infinite loop when there
2730 are no accounts. Document that one must be called before the other.
2732 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2734 * src/modest-account-mgr-helpers.c:
2735 (modest_account_mgr_get_default_account): Make sure that at least
2736 one account is always the default, if there are any enabled accounts.
2737 This is just a sanity check that shouldn't be necessary.
2739 * src/modest-account-mgr-priv.c:
2740 (_modest_account_mgr_account_from_key): Unescape the conf key to
2741 get the real account name. For instance, this is an issue if a space
2742 was in the account name, which can happen because the account name
2743 is generated from the display name.
2744 (_modest_account_mgr_get_account_keyname): Always escape the
2746 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2747 Unescape the conf keys to get the real account names.
2749 For instance, previously the is-default radio button in the accounts
2750 list was not checked for any accounts at first. This fixes that,
2751 and might fix several similar bugs.
2753 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2755 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2756 Removed some debug printfs.
2758 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2760 Modest on-disk outbox directories are now here, for instance:
2761 $HOME/.modest/outboxes/<account-id-1>/outbox
2762 $HOME/.modest/outboxes/<account-id-2>/outbox
2764 $HOME/.modest/local-folders/outbox
2765 so we can have a separate outbox for each account.
2766 But they are shown as one outbox in the GtkTreeView, by using a
2767 TnyMergeFolder in a ModestTnySimpleFolderStore.
2770 * src/modest-tny-simple-folder-store.c:
2771 * src/modest-tny-simple-folder-store.h:
2772 Added ModestTnySimpleFolderStore, used to contain folders from
2773 other folder stores, such as other accounts.
2775 * src/modest-tny-outbox-account.h:
2776 * src/modest-tny-outbox-account.c:
2777 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2778 used for the per-account local outbox folders.
2780 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2781 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2782 only use this (internally) now for the non-outbox local folders.
2784 * src/modest-init.h:
2785 * src/modest-init.c: Added modest_init_one_local_folder(), for
2786 setting up the directory structure for each local folder.
2788 * src/modest-local-folder-info.c:
2789 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2790 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2792 * src/modest-local-folder-info.h:
2793 * src/modest-tny-account-store.c: (on_account_removed),
2794 (on_account_changed), (create_per_account_local_outbox_folders),
2795 (get_server_accounts), (modest_tny_account_store_get_accounts),
2796 (modest_tny_account_store_get_tny_account_by_account),
2797 (modest_tny_folder_store_is_virtual_local_folders):
2799 * src/modest-tny-account.h:
2800 * src/modest-tny-account.c:
2801 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2802 to create an on-disk per-account local outbox folder for each
2804 (create_per_account_local_outbox_folders): Create a local outbox folder
2805 for each transport account.
2806 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2807 for all local folders.
2809 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2810 instead of using g_object_get/set() directly. It is clearer.
2812 (modest_tny_folder_store_get_message_count),
2813 (modest_tny_folder_store_get_local_size
2814 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2815 because we now use these with non-acount folder stores.
2817 (modest_tny_account_get_special_folder),
2818 (modest_tny_account_new_from_server_account),
2819 (modest_tny_account_new_from_account):
2820 (recurse_folders): Adjust to the new outbox system.
2822 * src/modest-tny-folder.h:
2823 * src/modest-tny-folder.c:
2824 (modest_tny_folder_is_local_folder),
2825 (modest_tny_folder_get_local_folder_type),
2826 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2828 * src/widgets/modest-main-window.h:
2829 * src/maemo/modest-main-window.c: (create_details_widget),
2830 (modest_main_window_set_contents_style): Show details for any folder store,
2833 (modest_tny_folder_get_rules):
2834 Remove the const. C does not support constness enough for this.
2836 * src/modest-ui-actions.c:
2837 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2838 make all outboxes appear as one, in the usual local-folders tree node.
2840 (set_active_account_from_tny_account),
2841 (modest_ui_actions_on_folder_selection_changed):
2842 * src/widgets/modest-folder-view.c: (text_cell_data),
2843 (icon_cell_data), (filter_row),
2844 (add_account_folders_to_merged_folder),
2845 (add_account_folders_to_simple_folder_store), (),
2846 (get_cmp_rows_type_pos), (cmp_rows),
2847 (modest_folder_view_set_account_id_of_visible_server_account):
2848 Adjust to the new outbox system, using generic folder stores and folders
2849 in the GtkTreeModel.
2851 2007-05-23 Christian Kellner <ckellner@openismus.com>
2853 * src/modest-mail-operation.c:
2854 (modest_mail_operation_update_account):
2855 Use info->max_size instead of unintialized local var [small
2856 build fix]. (Added TODO to review that change since I don't
2859 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2861 * libmodest-dbus-client/libmodest-dbus-client.c:
2862 (libmodest_dbus_client_compose_mail): function added
2863 * src/dbus_api/modest-dbus-api.h:
2864 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2865 (on_compose_mail): Implementation of the SendAsMail functionality
2867 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2869 * src/modest-account-mgr.c:
2870 (modest_account_mgr_add_server_account): Set the secure-connection
2871 conf key for transport accounts as well as store accounts. I don't know
2872 why the if was there. For instance, this makes sure that we use SSL
2873 for the gmail preset from the easysetup wizard.
2875 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2877 * src/gnome/modest-main-window.c:
2878 (on_account_store_connecting_finished), (connect_signals):
2879 * src/maemo/modest-main-window.c:
2880 (on_account_store_connecting_finished), (connect_signals),
2881 (modest_main_window_new):
2882 Handle TnyAccountStore::connecting-finished instead of
2883 TnyDevice::connection-changed, because we cannot actually perform
2884 operations on accounts until TnyAccountStore has itself responded to
2885 the TnyDevice::connection-changed signal. This prevents a GError from
2887 Do not try to update at startup, because we (at least on scratchbox)
2888 already do an update at startup when the device goes online.
2889 This prevents a GError from tinymail.
2890 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2891 Added TODO about stopping simultaneous operations.
2893 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2895 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2896 * src/modest-mail-operation-queue.c:
2897 (modest_mail_operation_queue_remove):
2898 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2899 about where they happened.
2901 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2903 * src/modest-ui-actions.c:
2904 (modest_ui_actions_on_password_requested): Make sure that the remember
2905 output parameter is always TRUE.
2907 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2909 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2910 Show a OK/Cancel dialog if the error is a question, though we still do not
2911 know anything more about what we are asking the user.
2912 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2913 Fix an uninitialized variable (helper). This is a logic error, however.
2915 2007-05-21 Christian Kellner <ckellner@openismus.com>
2917 * src/modest-search.h:
2918 Correct bit shifting in the ModestSearchFlags enum.
2920 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2922 * src/modest-tny-account.c:
2923 (modest_tny_account_new_from_server_account): Do not use the lsub and
2924 check-all hard-coded IMAP options when using POP.
2926 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2928 * src/modest-tny-account.c:
2929 (modest_tny_account_new_from_server_account):
2930 Use NULL for the secure-auth method for POP when Password auth has been
2931 specified by the user, as we already do for IMAP. "auth=Login" causes
2932 an error from camel or the server.
2934 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-account-settings-dialog.c:
2937 (create_page_account_details),
2938 (modest_account_settings_dialog_set_account_name):
2939 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2940 for the leave-on-server checkbox, rathr than just the checkbox, when
2941 the protocol is not POP.
2943 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2945 * src/widgets/modest-account-view.c:
2946 * src/widgets/modest-account-view.h:
2947 Added modest_account_view_select_account() which will be useful later
2948 to asynchronously re-select the edited account.
2950 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2952 * src/maemo/modest-account-settings-dialog.c:
2953 (modest_account_settings_dialog_set_account_name):
2954 Automatically choose the port numbers based on the secure authentication
2955 methods, if they have not been chosen before.
2956 This fixes projects.maemo.org bug NB#56273 .
2958 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2960 * src/maemo/modest-main-window-ui.h:
2961 * src/modest-ui-actions.c:
2962 * src/modest-ui-actions.h:
2963 Connect the Tools/SMTP Servers menu item to
2964 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2965 SMTP servers dialog, as in the UI specification and saves changes when it
2966 is closed. This fixed projects.maemo.org bug NB#56305 .
2968 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2970 * src/maemo/modest-connection-specific-smtp-window.c:
2971 (modest_connection_specific_smtp_window_init):
2972 Use gtk_window_set_default_size() to make this window big enough, so
2973 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2975 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2977 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2978 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2979 (modest_connection_specific_smtp_edit_window_init),
2980 Do not try to connect to a combobox signal before the combobox exists.
2981 This fixes the cras in projects.maemo.org bug NB#56288 .
2982 (modest_connection_specific_smtp_edit_window_get_settings):
2983 Remove the server_account_name parameter which was being checked for NULL
2984 though it was not used.
2986 * src/maemo/modest-connection-specific-smtp-window.c:
2987 (modest_connection_specific_smtp_window_fill_with_connections),
2988 (on_button_edit), (modest_connection_specific_smtp_window_init):
2989 Correct the number of treemodel columns to prevent a warning.
2990 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2991 libconic does not work.
2993 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2995 * src/modest-tny-account.c:
2996 (modest_tny_account_new_from_server_account):
2997 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2998 SMTP when "None" was chosen by the user. However, with my SMTP server that
2999 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3002 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3004 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3005 to explain the memory management issue with the ID in the ModestPair.
3007 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3008 (add_sending_page), (modest_account_assistant_finalize):
3009 * src/gnome/modest-gnome-global-settings-dialog.c:
3010 (create_updating_page), (create_composing_page):
3011 * src/gnome/modest-msg-edit-window.c: (get_transports),
3012 (init_window), (modest_msg_edit_window_finalize),
3013 (modest_msg_edit_window_get_msg_data):
3014 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3015 * src/gnome/modest-transport-widget.c:
3016 (modest_transport_widget_finalize), (smtp_configuration):
3017 * src/maemo/modest-maemo-global-settings-dialog.c:
3018 (create_updating_page), (create_composing_page):
3019 * src/maemo/modest-msg-edit-window.c: (get_transports),
3020 (init_window), (modest_msg_edit_window_finalize),
3021 (modest_msg_edit_window_get_msg_data),
3022 (modest_msg_edit_window_free_msg_data):
3023 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3024 (modest_store_widget_finalize):
3025 * src/maemo/modest-transport-widget.c:
3026 (modest_transport_widget_finalize), (smtp_configuration):
3027 * src/modest-main.c: (send_mail):
3028 * src/widgets/modest-combo-box.h:
3029 * src/widgets/modest-global-settings-dialog-priv.h:
3030 * src/widgets/modest-global-settings-dialog.c:
3031 (modest_global_settings_dialog_finalize):
3032 * src/widgets/modest-msg-edit-window.h:
3033 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3034 as long as the combo box, to prevent use of freed memory for the ID.
3036 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3038 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3039 get_accounts(), to make this clearer. Do not check for the enabled gconf
3040 key, because we do not use this for server accounts (at least, not yet).
3041 This allows us to send email again.
3043 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3045 * src/maemo/modest-platform.c:
3046 (on_modest_conf_update_interval_changed), (modest_platform_init):
3047 Only respond to this particular key change. All these strcmp()s cannot be
3050 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3052 * src/maemo/modest-maemo-global-settings-dialog.c:
3053 (current_connection): Prevent a crash in scratchbox when
3054 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3055 * src/maemo/modest-platform.c:
3056 (on_modest_conf_update_interval_changed), (modest_platform_init):
3057 Get the update interval from gconf and reset it when the gconf key changes.
3059 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3061 * src/modest-protocol-info.c:
3062 * src/modest-protocol-info.h: Adde enum-specific get functions,
3063 instead of using a ModestProtocolType enum parameter.
3065 * src/gnome/modest-account-assistant.c:
3066 * src/gnome/modest-store-widget.c:
3067 * src/gnome/modest-store-widget.h:
3068 * src/gnome/modest-transport-widget.c:
3069 * src/gnome/modest-transport-widget.h:
3070 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3071 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3072 * src/maemo/easysetup/modest-easysetup-wizard.c:
3073 * src/maemo/modest-account-settings-dialog.c:
3074 * src/maemo/modest-account-settings-dialog.h:
3075 * src/maemo/modest-store-widget.c:
3076 * src/maemo/modest-store-widget.h:
3077 * src/maemo/modest-transport-widget.c:
3078 * src/maemo/modest-transport-widget.h:
3079 * src/modest-account-mgr-helpers.c:
3080 * src/modest-account-mgr-helpers.h:
3081 * src/modest-account-mgr.c:
3082 * src/modest-account-mgr.h:
3083 * src/modest-tny-account.c:
3084 * src/modest-tny-folder.c:
3085 * src/widgets/modest-account-view.c:
3086 * src/widgets/modest-retrieve-combo-box.c:
3087 * src/widgets/modest-retrieve-combo-box.h:
3088 * src/widgets/modest-secureauth-combo-box.c:
3089 * src/widgets/modest-serversecurity-combo-box.c:
3090 * src/widgets/modest-serversecurity-combo-box.h:
3091 * tests/check_account-mgr.c:
3092 Use the specific functions, and use the re-renamed enum values for GNOME too.
3094 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3096 * src/modest-pair.h:
3097 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3098 so we can get the second based on the first.
3100 * src/maemo/modest-account-settings-dialog.h:
3101 * src/maemo/modest-account-settings-dialog.c:
3102 Added get_supported_secure_authentication_methods(), though it is mostly
3103 commented-out for now until the necessary API is committed to tinymail.
3104 (modest_account_settings_dialog_set_account_name),
3105 (save_configuration): Request the supported authentication methods from the
3106 server, so we can choose a working method.
3108 * src/modest-tny-account-store.h:
3109 * src/modest-tny-account-store.c:
3110 (modest_tny_account_store_get_session): Rename from
3111 tny_account_store_get_session().
3113 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3115 * src/modest-protocol-info.h: Split the ModestProtocol enum
3116 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3117 There was no need to have these unrelated values in one enum.
3119 * src/: many files: Adapted to changed enum. This makes the code a bit
3120 clearer, and the compiler could catch some errors.
3122 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3124 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3125 Show the detailed internal camel error message when an error happens
3126 during the configuration, so that our testers can give us more clues.
3127 For instance, in projects.maemo.org bug NB#56910 .
3129 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3131 * src/modest-tny-account.c:
3132 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3133 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3135 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3137 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3138 * src/maemo/modest-account-settings-dialog.c:
3139 (modest_account_settings_dialog_set_account_name),
3140 (save_configuration): For the incoming secure authentication checkbox,
3141 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3142 the UI specification. PLAIN does not seem to be supported for most IMAP
3143 servers anyway, and I am not sure what it would mean.
3144 However, we probably need to discover which of the secure-authentication
3145 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3146 * src/modest-account-mgr-helpers.c:
3147 (modest_account_mgr_get_server_account_data):
3149 * src/modest-tny-account.c:
3150 (modest_tny_account_new_from_server_account):
3151 Use tny_account_set_mech() to set secure-authentication methods,
3152 with some special-casing for IMAP, based on my observations of how
3155 * src/modest-account-mgr-helpers.h:
3156 * src/modest-account-mgr.c:
3157 * src/modest-defs.h: Comment that the URI is only used for local folders.
3159 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3161 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3162 parameter const, just to be neat.
3163 * src/modest-text-utils.c: (modest_text_utils_inline):
3164 End g_strconcat() with NULL, as its documentation says. This is almost
3165 certainly the cause of my crash at startup on the device. Interestingly,
3166 valgrind doesn't tell us about these errors.
3168 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3170 * scripts/build-packages: Added more precise comments about how to use
3171 this script, though I still get this error:
3172 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3173 error building tinymail
3175 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3177 * src/maemo/modest-main-window.c: (on_account_update):
3178 Very slight cleanup, hoping to make it simpler to discover what causes
3179 a crash here sometimes.
3181 * src/modest-tny-account.c:
3182 (modest_tny_account_new_from_server_account): Set the port. Added
3183 comments about the options and a TODO comment because I need to find out
3184 how to specify the secure authentication method.
3186 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3188 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3189 changed CFlags paths form modest to libmodest
3191 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3193 * src/modest-account-mgr-helpers.c:
3194 (modest_account_mgr_get_server_account_data),
3195 (modest_account_mgr_free_server_account_data):
3196 * src/modest-account-mgr-helpers.h:
3197 * src/modest-account-mgr.c:
3198 (modest_account_mgr_add_server_account):
3199 * src/modest-defs.h:
3200 * src/modest-tny-account.c:
3201 (modest_tny_account_new_from_server_account):
3202 Determine the options for tny_camel_account_add_option() here,
3203 based on the settings, rather than storing them directly in gconf.
3205 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3207 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3208 Show a more friendly error dialog now that we expect (from the tinymail
3209 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3211 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/modest-main-window.c: (on_account_update): Check that
3214 account_name is not NULL, to prevent a crash at startup that I am
3215 seeing on the N800. I do wonder why it is NULL.
3217 * src/maemo/easysetup/modest-easysetup-wizard.c:
3218 (create_page_user_details):
3219 * src/maemo/modest-account-settings-dialog.c:
3220 (create_page_user_details), (create_page_outgoing):
3221 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3222 (modest_connection_specific_smtp_edit_window_init):
3223 * src/modest-ui-actions.c:
3224 (modest_ui_actions_on_password_requested):
3225 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3226 might do something useful with the on-screen keyboard.
3228 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3230 * src/maemo/modest-main-window.c: (on_account_update):
3231 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3232 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3234 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3236 * src/modest-tny-account-store.c: (on_account_changed):
3237 Correct the signature of this signal handler.
3239 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3241 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3242 Show a HildonNote instead of a GtkDialog for Maemo.
3244 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3246 * src/widgets/modest-account-view.h:
3247 * src/widgets/modest-account-view.c: (on_account_changed),
3248 (on_account_removed). Added a boolean flag, set/unset by
3249 modest_account_view_block_conf_updates(),
3250 modest_account_view_unblock_conf_updates() to prevent unnecessary
3251 updates, but this is not very useful because the gconf notifications are
3252 so delays (maybe only on Maemo Bora).
3253 So auto-updating is turned off, and these functions do an explicit
3254 update when necessary.
3255 However, something else is still doing too much work when adding/removing
3256 accounts, probably in another part of the application.
3258 * src/maemo/modest-account-view-window.c:
3259 (on_delete_button_clicked), (on_edit_button_clicked),
3260 (on_new_button_clicked): Use the new functions.
3262 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3264 * src/modest-account-mgr-helpers.c:
3265 (modest_account_mgr_set_first_account_as_default):
3266 Sort the list of names alphabetically-by-title, so we choose the first one
3268 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3269 alphabetically by the title.
3271 This fixes projects.maemo.org bug NB#56418 .
3273 * src/modest-account-mgr-priv.c:
3274 (_modest_account_mgr_account_from_key):
3275 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3276 avoid a valgrind error, and possible random behaviour.
3278 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3280 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3281 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3282 tinymail documentation to say that this can be expected.
3283 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3284 pretty, and should not happen, but I would prefer to know when it does.
3286 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3288 * configure.ac: When using the older hildon version, probably on Bora,
3289 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3291 * src/widgets/modest-attachment-view.c:
3292 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3295 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3297 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3298 Implemented the prototype. Can be tested with
3299 tests/dbus_api/test_open_message:
3301 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3303 * src/modest-tny-account-store.c:
3304 (modest_tny_account_store_instance_init), (get_password):
3305 * src/modest-ui-actions.c:
3306 (modest_ui_actions_on_password_requested):
3307 Do not store the password in gconf, because this function is called
3308 for non-remembered passwords. Actually use the cached (in the hash map)
3309 password instead of releasing it.
3310 The password will now not be remembered if it is asked via the protected
3311 password dialog, as per the UI spec.
3313 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3315 * src/modest-defs.h:
3316 * src/modest-account-mgr-helpers.h:
3317 * src/modest-account-mgr-helpers.c:
3318 Added modest_server_account_get_username_has_succeeded(),
3319 modest_server_account_set_username_has_succeeded().
3320 (modest_server_account_set_username),
3321 Reset the has-succeeded flag if the username changes.
3323 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3324 * src/maemo/modest-connection-specific-smtp-window.c:
3325 (modest_connection_specific_smtp_window_save_server_accounts):
3326 Use modest_server_account_set_username() instead of using
3327 modest_conf_set_string() directly, so that the has-succeeded flag is always
3330 * src/modest-ui-actions.c:
3331 (modest_ui_actions_on_password_requested): Dim the username entry if
3332 the username has ever worked, as per the UI spec.
3334 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-tny-account-store.c: (get_password):
3337 * src/modest-ui-actions.c:
3338 (modest_ui_actions_on_password_requested):
3339 Allow the username to be changed too, though there is more work to
3340 be done on exactly how this behaves.
3342 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3344 * src/modest-account-mgr-helpers.h:
3345 * src/modest-account-mgr-helpers.c:
3346 Added modest_account_mgr_get_display_name(),
3347 modest_server_account_get_username(),
3348 modest_server_account_set_username(),
3349 modest_server_account_set_password(),
3350 modest_server_account_get_hostname() functions so we do not need to
3351 use the conf API directly.
3353 * src/maemo/modest-main-window.c: (connect_signals):
3354 Actually connect ot the ModestAccountStore::request-password signal,
3355 so that we show the dialog when the password is requested by Tinymail,
3356 for isntance if it is empty.
3358 * src/modest-marshal.list:
3359 * src/modest-tny-account-store.c:
3360 (modest_tny_account_store_class_init), (get_password),
3361 (modest_tny_account_store_alert):
3362 * src/modest-tny-account-store.h:
3363 * src/modest-ui-actions.h:
3364 * src/modest-ui-actions.c:
3365 (modest_ui_actions_on_password_requested):
3366 Change the signal parameters, so it is obvious that we are providing
3367 the non human-readable server name, and receiving both the username
3368 and password, though changing of the username is not yet implemented.
3369 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3370 for the GNOME version.
3372 This should fix the projects.maemo.org bug NB#56209, though it does not
3373 work on Bora, because the gconf_client_get() for the password fails
3374 immediately after we save it with gconf_client_set().
3376 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3379 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3380 caused an undefined symbol error:
3381 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3383 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-tny-account-store.c:
3386 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3387 using a GError instead of a string message, so we can translate it in
3390 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3392 * src/maemo/modest-address-book.c:
3393 (modest_address_book_check_names):
3394 * src/maemo/modest-msg-view-window.c:
3395 (modest_msg_view_window_clipboard_owner_change):
3396 * src/modest-init.c: (modest_init_init_ui):
3397 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3398 (update_folders_cb), (modest_mail_operation_update_account):
3399 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3400 (modest_ui_actions_on_msg_attachment_clicked),
3401 (modest_ui_actions_on_msg_recpt_activated):
3402 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3403 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3404 (modest_msg_view_search_next):
3405 * src/widgets/modest-recpt-editor.c:
3406 (modest_recpt_editor_on_button_release_event),
3407 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3408 g_message(). At this point we should only be seeing interesting errors on
3409 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3411 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3413 (modest_wizard_dialog_force_title_update):
3414 * src/maemo/easysetup/modest-wizard-dialog.h:
3415 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3416 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3417 can update the title when appropriate. Otherwise the title is wrong if the
3418 pages are added after adding the notebook to the dialog.
3419 This must be a problem in HildonWizardDialog too.
3420 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3422 * src/maemo/easysetup/modest-easysetup-wizard.c:
3423 (create_subsequent_customsetup_pages),
3424 (create_subsequent_easysetup_pages):
3425 Call modest_wizard_dialog_force_title_update() so that the title is
3426 correct even with GTK+ < 2.10.
3427 This fixes projects.maemo.org bug NB#56145 .
3429 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/modest-platform.c:
3432 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3433 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3436 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3438 * src/widgets/modest-window.h:
3439 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3440 and modest_window_save_state(), which invokes it.
3442 * src/widgets/modest-window-mgr.h:
3443 * src/widgets/modest-window-mgr.c:
3444 Added modest_window_mgr_save_state_for_all_windows(), which calls
3445 the save_state vfunc on all registered windows, if implemented.
3447 * src/gnome/modest-msg-edit-window.c:
3448 * src/gnome/modest-msg-view-window.c:
3449 * src/maemo/modest-msg-edit-window.c:
3450 * src/maemo/modest-msg-view-window.c:
3451 * src/maemo/modest-main-window.c:
3452 Specify the existing save_settings functions as implementations of
3453 ModestWindow::save_state_func().
3455 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3456 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3457 enabling hibernation, for instance.
3459 We may need to do the same thing for restoring settings.
3462 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3464 * src/widgets/modest-window-mgr.c:
3465 * src/widgets/modest-window-mgr.h:
3466 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3467 modest_window_mgr_get_hibernation_is_prevented().
3469 * src/maemo/modest-main-window.c:
3470 (on_hildon_program_is_topmost_notify): Prevent hibernation
3471 (possible when the application goes to the background in the WM),
3472 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3474 * src/maemo/easysetup/modest-easysetup-wizard.c:
3475 (modest_easysetup_wizard_dialog_init):
3476 * src/maemo/modest-account-settings-dialog.c:
3477 (modest_account_settings_dialog_init):
3478 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3479 (modest_connection_specific_smtp_edit_window_init):
3480 * src/maemo/modest-connection-specific-smtp-window.c:
3481 (modest_connection_specific_smtp_window_init):
3482 * src/maemo/modest-signature-editor-dialog.c:
3483 (modest_signature_editor_dialog_init):
3484 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3485 prevent hibernation while any of these account settings dialogs are open.
3487 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3489 * src/maemo/Makefile.am:
3490 * src/maemo/modest-osso-state-saving.c:
3491 * src/maemo/modest-osso-state-saving.h: Added
3492 modest_osso_load_state() and modest_osso_save_state() though they do
3493 nothing now. They should iterate through all the open windows and load/save
3495 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3496 save state when closing.
3498 * src/maemo/modest-main-window.c:
3499 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3500 Add a notification handler for the HildonProgram::is-topmost property,
3501 so we can allow hibernation when the application goes into the background.
3502 But we still need to detect when the accounts setup windows are open so
3503 we can stop hibernation when they are open.
3504 To do this, I also added the main window the HildonProgram. This might have
3505 other side-effects/benefits, and should maybe be done for other windows.
3507 * src/maemo/modest-osso-autosave-callbacks.h:
3508 * src/maemo/modest-osso-autosave-callbacks.c:
3509 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3510 though it does not do anything yet, and we might never need this to do
3511 anything. For instance, we already save drafts.
3513 * src/maemo/modest-platform.c: (modest_platform_init):
3514 Specify the libosso auto-save callback.
3516 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3518 * src/maemo/modest-platform.c:
3519 (modest_platform_set_update_interval):
3520 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3521 aparently stays valid between application instances, so we can use this
3522 to remove and reset it later. According to a maemo-developers email from
3525 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3527 * configure.ac: Depend on libalarm for Maemo.
3529 * src/dbus_api/modest-dbus-api.h:
3530 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3531 (on_send_receive), (modest_dbus_req_handler):
3532 Handle a SEND_RECEIVE D-Bus method.
3534 * libmodest-dbus-client/libmodest-dbus-client.c:
3535 (libmodest_dbus_client_send_and_receive):
3536 * libmodest-dbus-client/libmodest-dbus-client.h:
3537 Add C convenience functions for calling the new D-Bus method.
3539 * src/modest-platform.h:
3540 * src/gnome/modest-platform.c:
3541 * src/maemo/modest-platform.c:
3542 Added modest_platform_set_update_interval(), which uses the
3543 alarmd API on Maemo.
3544 (modest_platform_init),
3545 Call modest_platform_set_update_interval(), using a hard-coded
3546 interval for now (until the global settings dialog is implemented),
3547 though I am not sure that this makes sense yet.
3549 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3551 * src/dbus_api/modest-dbus-callbacks.c:
3552 (modest_osso_cb_hw_state_handler):
3553 * src/dbus_api/modest-dbus-callbacks.h:
3554 * src/maemo/modest-platform.c: (modest_platform_init):
3555 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3556 in case this has some effect on the ability for Maemo to ping the
3559 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3561 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3562 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3563 warning. It is probably a logic error, but I need to fix the build.
3565 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3567 * src/modest-account-mgr.h:
3568 * src/modest-account-mgr.c:
3569 (modest_account_mgr_account_names): Add a gboolean enabled_only
3570 parameter, so we can get lists of onlt the enabled accounts.
3572 (modest_account_mgr_add_account),,
3573 (modest_account_mgr_account_with_display_name_exists):
3574 * src/maemo/modest-msg-edit-window.c: (get_transports):
3575 * src/modest-account-mgr-helpers.c:
3576 (modest_account_mgr_set_first_account_as_default):
3577 * src/modest-init.c: (init_default_account_maybe):
3578 * src/modest-tny-account-store.c: (get_accounts):
3579 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3580 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3581 * tests/check_account-mgr.c: (START_TEST):
3582 Provide the extra parameter, as appropriate.
3584 * src/widgets/modest-account-view.c: (update_account_view):
3585 Do not show disabled accounts (meaning that there is no way to
3586 enable/disable accounts in the UI (the feature is not in our UI
3587 specification), so we can use this internally only to mark unfinished
3588 or temporary account data.
3590 * src/maemo/easysetup/modest-easysetup-wizard.c:
3591 (create_account): Add boolean enable parameter, so we can specify FALSE
3592 to create the temporary account.
3593 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3594 (on_before_next): When finishing, when there is a temporary account, just
3596 Also, use a timeout to delay the showing of the dialog until gconf is likely
3597 to return correct information, due to a maemo gconf bug that is fixed in
3598 osso 1.1, but not yet in Bora.
3599 However, the dialog stays on screen after it is destroyed.
3601 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3602 for invalid data when cancelling. Use a hildon note instead of a dialog
3603 to complain about invalid data. Do not show the account-saved note if the
3604 account is disabled (a temporary account that will not really be saved for use
3607 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3609 * src/modest-account-mgr-helpers.h:
3610 * src/modest-account-mgr-helpers.c:
3611 Added modest_account_mgr_unset_default_account(),
3612 Added modest_account_mgr_set_first_account_as_default().
3614 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3615 If it was the default account, unset the default account name.
3617 * src/maemo/modest-account-view-window.c:
3618 (on_delete_button_clicked): If it was the default account,
3619 set the first remaining account as the default instead.
3621 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3622 a NULL account or a NULL default account, to prevent a crash. This should
3623 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3626 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3628 * src/widgets/modest-recpt-editor.c:
3629 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3630 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3631 TODO comment for this. This fixes the build.
3633 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3634 be the best place for it. This will in future update all auto-update accounts,
3635 rather than just the current/default account, when that gconf key exists.
3636 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3637 if there are no accounts, before calling do_send_receive().
3638 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3640 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3641 * src/maemo/modest-main-window-ui.h:
3642 * src/maemo/modest-main-window.c: (on_connection_changed),
3643 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3644 directly, becaue the signal handler does more.
3646 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3648 * src/modest-account-mgr-helpers.c:
3649 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3650 for the case that the account does not exist.
3652 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3653 (equivalent to the modest account name) rather than the tinymail account name
3654 (equivalent to the modest account title - human readable) to get the account data.
3655 Check for null account data to prevent the crash, and add a TODO comment saying that
3656 this needs fixing because it is using the server account name instead of the account name.
3658 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3660 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3661 * src/maemo/modest-account-settings-dialog.c: (show_error),
3663 Use hildon_note_new_information() for informative and error messages,
3664 which seems to be expected for Maemo applications (no documentation that I know of
3665 says this). I am surprised that there is no distinction between info and error
3668 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3670 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3671 it is easy to find where this is used.
3673 * src/maemo/easysetup/modest-easysetup-wizard.c:
3674 (create_page_welcome), (create_page_account_details),
3675 (create_page_user_details), (create_page_complete_easysetup),
3676 (create_page_custom_incoming), (create_page_custom_outgoing),
3677 (create_page_complete_custom):
3678 * src/maemo/modest-account-settings-dialog.c:
3679 (create_page_account_details), (create_page_user_details),
3680 (create_page_incoming), (create_page_outgoing):
3681 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3682 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3683 (modest_connection_specific_smtp_edit_window_init):
3684 * src/maemo/modest-connection-specific-smtp-window.c:
3685 (modest_connection_specific_smtp_window_init):
3686 * src/maemo/modest-signature-editor-dialog.c:
3687 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3688 and scrolling policy as per the Email Application Layout Guide, if I have
3691 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3693 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3694 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3695 which were empty, because these vfuncs have been removed from TnyAccountStore.
3696 This fixes the build.
3698 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3700 * src/maemo/modest-main-window.c:
3701 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3702 showing/hiding it. Added TODO because it probably should not be NULL.
3703 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3704 because unnecessary g_warnings() make degugging difficult.
3706 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3708 * src/maemo/modest-msg-edit-window.c:
3709 (modest_msg_edit_window_select_color),
3710 (modest_msg_edit_window_select_background_color): 2 const corrections and
3711 moving 2 #endifs before closing brackets, to fix the build.
3713 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3715 * src/maemo/easysetup/modest-easysetup-wizard.h:
3716 * src/maemo/easysetup/modest-easysetup-wizard.c:
3717 (modest_easysetup_wizard_dialog_finalize),
3718 (on_button_edit_advanced_settings), (create_page_complete_custom),
3719 (on_response), (create_account):
3720 Implement the Advanced Settings edit button, by saving the account information,
3721 for the Advanded Settings dialog to use directly from gconf, and removing it
3722 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3723 Bug #5533 in the projects.maemo.org bugzilla.
3725 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3727 * src/maemo/modest-msg-view-window.c:
3728 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3729 when opening a message window.
3731 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3733 * src/maemo/easysetup/modest-easysetup-wizard.c:
3734 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3737 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3738 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3739 gconf settings. I probably added more checks than necessary, but that is safer.
3741 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3742 variable to fix the build, but this seems to be used when it is still NULL.
3744 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3746 * src/modest-platform.h:
3747 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3748 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3749 * src/modest-main.c: Implement this function so we can avoid using
3750 maemo-specific API from cross-platform code.
3752 * src/modest-tny-account-store.c:
3753 (get_smtp_specific_transport_account_for_open_connection):
3754 * src/modest-ui-actions.c: (check_for_connection),
3755 (modest_ui_actions_on_item_not_found):
3756 Use modest_platform_connect_and_wait() and put #idefs around other
3757 maemo-specific code, because only maemo currently has a way to
3758 identify connection names.
3760 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3762 * src/modest-tny-account-store.h:
3763 * src/modest-tny-account-store.c:
3764 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3765 the connection-specific SMTP server settings in the configuration.
3767 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3769 * src/maemo/modest-main-window.c: (on_connection_changed),
3771 * src/modest-main.c: (main), (start_ui), (send_mail):
3772 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3773 that is what is intended.
3775 * src/modest-ui-actions.c: (action_send), (action_receive),
3776 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3777 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3778 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3779 SMTP server is used when it is specified.
3781 (modest_ui_actions_on_send_receive):
3782 Check that a connection is open before proceeding.
3783 Receive and then send, instead of vice-versa, as per the specification.
3785 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3787 * src/modest-mail-operation.c:
3788 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3789 though I guess it should be something other than NULL.
3791 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3793 * src/maemo/easysetup/modest-easysetup-wizard.c:
3794 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3795 combo twice, to avoid an g_warning and to make it visible again.
3796 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3797 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3798 (already intended) dereference when detaching, because we then recreate the menu.
3799 But I am not sure why the warning was happening, and it is possible that this is a memory
3802 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3804 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3805 and uri_parse_mailto() utility functions.
3806 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3808 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3810 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3812 * src/dbus_api/modest-dbus-api.h:
3813 * src/dbus_api/modest-dbus-callbacks.c:
3814 Use an idle callback to execute the modest code in the application's own thread.
3815 Remove the helloworld example method.
3816 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3817 parsed, and the open-message method is not implemented because this is not yet implemented in
3819 * libmodest-dbus-client/libmodest-dbus-client.c:
3820 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3821 (libmodest_dbus_client_open_message):
3822 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3824 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3825 body without crashing.
3827 * tests/dbus_api/Makefile.am:
3828 * tests/dbus_api/test_mail_to.c:
3829 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3831 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3833 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3834 Added file to fix the build. Sorry.
3836 * src/dbus_api/Makefile.am:
3837 * src/dbus_api/modest-dbus-api.h:
3838 * src/dbus_api/modest-dbus-callbacks.h:
3839 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3840 (modest_dbus_req_handler):
3841 Put constants in a separate header so it can be reused by the
3842 client library, without duplication
3844 * libmodest-dbus-client/Makefile.am:
3845 * libmodest-dbus-client/libmodest-dbus-client.c:
3846 (libmodest_dbus_client_call_helloworld),
3847 (libmodfest_dbus_client_send_mail),
3848 (libmodfest_dbus_client_mailto),
3849 (libmodfest_dbus_client_open_message):
3850 * libmodest-dbus-client/libmodest-dbus-client.h:
3851 (Partly) Implement a send_mail D-Bus method.
3853 * tests/dbus_api/Makefile.am:
3854 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3855 the send_email D-Bus method.
3857 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3861 * libmodest-dbus-client/Makefile.am:
3862 * libmodest-dbus-client/libmodest-dbus-client.c:
3863 * libmodest-dbus-client/libmodest-dbus-client.h:
3864 * tests/dbus_api/Makefile.am:
3865 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3866 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3868 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3870 * src/maemo/easysetup/modest-easysetup-wizard.c:
3871 (create_page_account_details):
3872 * src/maemo/modest-account-settings-dialog.c:
3873 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3874 widgets, because this might not be the default in future versions of the Maemo GTK+.
3875 However, I can not not get capitalization to work even in a simple test case.
3877 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3879 * src/maemo/easysetup/modest-easysetup-wizard.c:
3880 (create_page_custom_incoming), (create_page_custom_outgoing):
3881 * src/maemo/modest-account-settings-dialog.c:
3882 (create_page_account_details), (create_page_incoming),
3883 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3884 instead of using gtk_check_button_with_label(), so they are aligned like the other
3885 widgets, as per the UI spec.
3887 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3889 * src/maemo/easysetup/modest-easysetup-wizard.c:
3890 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3891 * src/widgets/modest-validating-entry.c:
3892 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3893 Modest prefix instead of an EasySetup prefix.
3895 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3897 * src/widgets/modest-validating-entry.h:
3898 * src/widgets/modest-validating-entry.c: (on_insert_text),
3899 Added easysetup_validating_entry_set_max_func(), used to set a callback
3900 to call when the max number of characters is reached. GtkEntry has a max-length
3901 already but is silent about it.
3903 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3904 (create_page_account_details), (create_page_user_details),
3906 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3907 (create_page_account_details), (create_page_user_details),
3908 (create_page_outgoing):
3909 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3910 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3911 the UI spec, when the user tries to enter more than the max number of characters.
3913 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3915 * src/maemo/easysetup/modest-easysetup-wizard.c:
3916 (create_page_user_details), (create_page_custom_incoming),
3917 (create_page_custom_outgoing):
3918 * src/maemo/modest-account-settings-dialog.c:
3919 (create_page_user_details), (create_page_incoming),
3920 (create_page_outgoing):
3921 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3922 (modest_connection_specific_smtp_edit_window_init):
3923 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3924 not appropriate. Bad Maemo-specific defaults!.
3926 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3928 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3929 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3930 (modest_signature_editor_dialog_set_settings):
3931 Disable the label and textview when the checkbox is disabled, and use the
3932 specified (UI spec) default signature text.
3934 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3936 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3937 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3939 * src/modest-defs.h:
3940 * src/modest-account-mgr-helpers.h:
3941 * src/modest-account-mgr-helpers.c:
3942 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3944 * src/maemo/Makefile.am:
3945 * src/maemo/modest-signature-editor-dialog.c:
3946 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3949 * src/maemo/modest-account-settings-dialog.h:
3950 * src/maemo/modest-account-settings-dialog.c:
3951 (modest_account_settings_dialog_finalize), (on_button_signature),
3952 (save_configuration): Use the new dialog when the Edit button is pressed, and
3953 save the changes if necessary, as per the UI spec.
3955 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3957 * src/maemo/Makefile.am:
3958 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3959 based on maemo-develoers email from Dirk.
3961 * src/maemo/easysetup/modest-easysetup-wizard.c:
3962 (create_page_welcome), (create_page_account_details),
3963 (create_page_user_details), (create_page_complete_easysetup),
3964 (create_page_custom_incoming), (create_page_custom_outgoing),
3965 (create_page_complete_custom),
3966 (modest_easysetup_wizard_dialog_init):
3967 * src/maemo/modest-account-settings-dialog.c:
3968 (create_page_account_details), (create_page_user_details),
3969 (create_page_incoming), (create_page_outgoing),
3970 (modest_account_settings_dialog_init):
3971 * src/maemo/modest-connection-specific-smtp-window.c:
3972 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3974 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3976 * src/maemo/easysetup/modest-easysetup-wizard.c:
3977 (create_page_account_details), (create_page_custom_outgoing),
3978 (create_page_complete_custom):
3979 * src/maemo/modest-account-settings-dialog.c:
3980 (create_page_user_details), (create_page_incoming),
3981 (create_page_outgoing):
3982 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3983 (modest_connection_specific_smtp_edit_window_init):
3984 Use the correct (UI spec) port min/max, and use horizontal separators,
3987 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3989 * src/maemo/easysetup/modest-easysetup-wizard.c:
3990 (set_default_custom_servernames):
3991 * src/maemo/modest-account-settings-dialog.c:
3992 (create_page_incoming), (on_combo_outgoing_security_changed),
3993 (on_combo_incoming_security_changed), (create_page_outgoing),
3994 (modest_account_settings_dialog_set_account_name),
3995 (save_configuration):
3996 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3997 (on_combo_security_changed),
3998 (modest_connection_specific_smtp_edit_window_init),
3999 (modest_connection_specific_smtp_edit_window_set_connection),
4000 (modest_connection_specific_smtp_edit_window_get_settings):
4001 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4004 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4007 * src/maemo/easysetup/modest-easysetup-wizard.c:
4008 (create_page_custom_outgoing), (create_page_complete_custom):
4009 * src/maemo/modest-account-settings-dialog.c:
4010 (create_page_user_details), (create_page_outgoing):
4011 * src/maemo/modest-account-view-window.c: (button_box_new):
4012 Use changed logical IDs as per the most recent UI spec:
4013 mcen_bd_emailsetup_edit -> mcen_bd_edit
4014 mcen_bd_emailsetup_delete -> mcen_bd_delete
4015 mcen_bd_emailsetup_close -> mcen_bd_close
4017 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4021 * src/dbus_api/Makefile.am:
4022 * src/dbus_api/modest-dbus-callbacks.c:
4023 * src/dbus_api/modest-dbus-callbacks.h:
4024 * src/maemo/modest-platform.c: (modest_platform_init):
4025 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4027 * tests/Makefile.am:
4028 * tests/dbus_api/Makefile.am:
4029 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4031 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4033 * src/maemo/modest-account-settings-dialog.c:
4034 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4035 Removed unnecessary includes.
4037 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4039 * src/maemo/easysetup/modest-easysetup-wizard.c:
4040 * src/maemo/modest-account-settings-dialog.c:
4041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4042 * src/widgets/Makefile.am:
4043 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4044 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4045 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4046 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4047 * src/widgets/modest-secureauth-combo-box.c:
4048 * src/widgets/modest-secureauth-combo-box.h:
4049 * src/widgets/modest-serversecurity-combo-box.c:
4050 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4051 made the GObject names more consistent with the rest of the Modest code.
4053 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4055 * src/maemo/easysetup/Makefile.am:
4056 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4057 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4058 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4059 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4060 * src/maemo/easysetup/modest-easysetup-wizard.c:
4061 * src/maemo/easysetup/modest-validating-entry.c:
4062 * src/maemo/easysetup/modest-validating-entry.h:
4063 * src/maemo/modest-account-settings-dialog.c:
4064 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4065 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4066 widgets/ because they are used outside of easysetup too. After checking in,
4067 svn will allow me to rename them too.
4069 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4071 * src/gnome/modest-msg-edit-window.c:
4072 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4073 linker error, to fix the build on the GNOME platform.
4074 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4075 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4076 ifdefed out to avoid a warning.
4078 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4080 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4081 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4082 some alternative for GTK+ 2.6.
4084 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4086 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4088 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4089 specified for EmailAccountsDialog in UI spec.
4091 * src/maemo/easysetup/modest-easysetup-wizard.c:
4092 * src/maemo/easysetup/modest-easysetup-wizard.h:
4093 * src/maemo/modest-account-settings-dialog.c:
4094 * src/maemo/modest-account-settings-dialog.h:
4095 Reuse a member window widget for the connection-specific SMTP server accounts,
4096 so we can tell it to create/save the accounts only if we actually save changes.
4098 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4099 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4100 (modest_connection_specific_smtp_edit_window_get_settings):
4101 Return a struct instance for temporarily remembering the entered data.
4103 * src/maemo/modest-connection-specific-smtp-window.h:
4104 * src/maemo/modest-connection-specific-smtp-window.c:
4105 (modest_connection_specific_smtp_window_finalize),
4106 (modest_connection_specific_smtp_window_fill_with_connections),
4108 (modest_connection_specific_smtp_window_save_server_accounts),
4109 (update_model_server_names): Do not actually save data until asked,
4110 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4112 (on_selection_changed),
4113 (modest_connection_specific_smtp_window_init): Disable the edit
4114 button when nothing is selected.
4116 * src/modest-account-mgr-helpers.c:
4117 * src/modest-account-mgr-helpers.h:
4118 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4121 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4123 * src/modest-account-mgr-helpers.h:
4124 * src/modest-account-mgr-helpers.c:
4125 (modest_account_mgr_get_unused_account_name),
4126 (modest_account_mgr_get_unused_account_display_name): Added these
4127 utility functions, to avoid code duplication.
4129 * src/maemo/easysetup/modest-easysetup-wizard.c:
4130 (create_page_account_details), (create_account):
4131 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4132 (on_combo_security_changed),
4133 (modest_connection_specific_smtp_edit_window_init),
4134 (modest_connection_specific_smtp_edit_window_save_settings):
4135 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4136 * src/maemo/modest-connection-specific-smtp-window.c:
4137 (modest_connection_specific_smtp_window_finalize),
4138 (modest_connection_specific_smtp_window_fill_with_connections),
4139 (on_button_edit), (modest_connection_specific_smtp_window_init):
4140 * src/maemo/modest-connection-specific-smtp-window.h:
4141 Implementing saving of connection-specific server accounts.
4143 But I need to refactor this so we can save the data for each
4144 possible connection-specific account and only actually create the server accounts
4145 when the easysetup finished, or the OK button is pressed on the account settings
4148 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4151 (on_combo_security_changed):
4152 (modest_connection_specific_smtp_edit_window_init):
4153 Auto-fill the port number as in the account settings.
4155 (modest_connection_specific_smtp_edit_window_set_connection):
4156 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4157 * src/maemo/modest-connection-specific-smtp-window.c:
4158 (fill_with_connections), (on_button_edit),
4159 (modest_connection_specific_smtp_window_init):
4160 Turn the edit window into a dialog to simplify the code, and
4161 set a WM hint as in a GtkDialog, because only a popup can be on top of
4162 another window in Maemo, and popups usually have no WM decoration.
4164 * src/modest-defs.h:
4165 * src/modest-account-mgr-helpers.c:
4166 (modest_account_mgr_set_connection_specific_smtp),
4167 (modest_account_mgr_remove_connection_specific_smtp),
4168 (modest_account_mgr_get_connection_specific_smtp):
4169 * src/modest-account-mgr-helpers.h: Some functions to write the
4170 connection-specific SMTP server information. Not yet used.
4173 * src/widgets/modest-folder-view.c: (text_cell_data):
4174 Fix a warning about an uninitialized variable.
4175 (on_configuration_key_changed): Put an #ifdef around the use
4176 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4178 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4180 * src/maemo/modest-account-settings-dialog.h:
4181 * src/maemo/modest-account-settings-dialog.c:
4182 Added connect_for_modified() utility function to mark the new modified boolean.
4184 (create_page_account_details), (create_page_user_details),
4185 (create_page_incoming), (create_page_outgoing), (on_response),
4186 (modest_account_settings_dialog_init),
4187 (modest_account_settings_dialog_set_account_name):
4188 Only warn about unsaved changes when there are actually unsaved changes.
4190 * src/modest-account-mgr-helpers.c:
4191 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4192 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4193 to get the data from there in future.
4195 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4197 * src/modest-defs.h:
4199 * src/modest-account-mgr-helpers.h:
4200 * src/modest-account-mgr-helpers.c:
4201 Store the security account setting in a single conf key instead of using
4202 the options list, so that the list is left for just the to-be-removed camel hack,
4203 and because gconf_client_set_list() is failing for some reason.
4205 * src/modest-account-mgr.c:
4206 (modest_account_mgr_add_server_account):
4207 * src/maemo/modest-account-settings-dialog.c:
4208 (modest_account_settings_dialog_set_account_name),
4209 (save_configuration): Use the renamed functions.
4212 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4214 * src/widgets/Makefile.am:
4215 * src/widgets/modest-limit-retrieve-combo-box.c:
4216 * src/widgets/modest-limit-retrieve-combo-box.h:
4217 * src/widgets/modest-retrieve-combo-box.c:
4218 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4219 the account settings dialog.
4221 * src/modest-defs.h:
4222 * src/modest-account-mgr-helpers.h:
4223 * src/modest-account-mgr-helpers.c:
4224 (modest_server_account_get_option_secure_auth),
4225 (modest_server_account_set_option_secure_auth):
4226 * src/modest-account-mgr.c:
4227 (modest_account_mgr_add_server_account):
4228 Use the existing AUTH_MECH conf key for the secure-auth setting,
4229 instead of putting it in the list options, because this was actually used already.
4231 * src/maemo/modest-account-settings-dialog.c:
4232 (create_page_account_details),
4233 (modest_account_settings_dialog_set_account_name),
4234 (save_configuration):
4235 * src/maemo/modest-account-settings-dialog.h:
4236 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4237 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4239 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4241 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4242 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4243 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4245 * src/modest-defs.h:
4246 * src/maemo/modest-account-settings-dialog.c:
4247 (create_page_incoming), (on_combo_outgoing_security_changed),
4248 (on_combo_incoming_security_changed), (create_page_outgoing),
4249 (modest_account_settings_dialog_set_account_name),
4250 (save_configuration): Load/Save the port number, and change it when the
4251 security combo changes, to suitable defaults.
4253 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4255 * src/modest-account-mgr.c:
4256 (modest_account_mgr_add_server_account): Set the security and secure-auth
4257 options, and add a comment saying that the other camel-specific options should be
4260 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4262 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4264 * src/modest-tny-account-store.c: (account_list_free),
4265 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4266 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4269 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4271 * src/modest-protocol-info.c:
4272 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4273 is required by our UI spec. Maybe something in our implementation will use this eventually.
4274 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4275 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4276 instead of the previous 0 placeholder.
4278 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4279 secure-auth settings.
4280 * src/modest-account-mgr-helpers.h:
4281 * src/modest-account-mgr-helpers.c:
4282 (modest_server_account_data_get_option_secure_auth),
4283 (modest_server_account_set_option_secure_auth),
4284 (modest_server_account_data_get_option_security),
4285 (modest_server_account_set_option_security): Added this API for getting and setting the security
4286 and secure-auth settings.
4288 * src/maemo/modest-account-settings-dialog.h:
4289 * src/maemo/modest-account-settings-dialog.c:
4290 (modest_account_settings_dialog_finalize), (check_data),
4291 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4292 about changing titles.
4293 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4294 (save_configuration): Save the security and secure-auth settings.
4296 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4297 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4299 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4301 * src/modest-defs.h:
4302 * src/modest-account-mgr.c:
4303 (modest_account_mgr_add_server_account):
4304 Added and used defines for the options key and value pair strings,
4305 that are used so far, though they do not seem to correspond to anything in our
4306 UI specs or ModestProtocol enum.
4308 * src/modest-account-mgr-helpers.h:
4309 * src/modest-account-mgr-helpers.c:
4310 (compare_option_strings_for_name),
4311 (modest_server_account_data_get_option_value),
4312 (modest_server_account_data_get_option_bool),
4313 (modest_account_mgr_get_server_account_option):
4314 Added helper functions for parsing the options GSList.
4316 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4318 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4319 display name is based on the supplied account name.
4320 * src/modest-account-mgr.c:
4321 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4322 with an inefficient, but good-enough, implementation.
4324 * src/maemo/easysetup/modest-easysetup-wizard.c:
4325 (create_page_account_details), (on_before_next), (create_account):
4326 Check for existing display names rather than (non-user-visible) account names, and just
4327 create and set a unique account name at the end.
4329 * src/maemo/modest-account-settings-dialog.c:
4330 (modest_account_settings_dialog_init),
4331 (modest_account_settings_dialog_set_account_name),
4332 (create_page_incoming): Show the display name, instead of the account name.
4333 (on_response): Do some (not all) extra checks, as in the UI spec.
4334 (save_configuration): Save the display name if it was changed.
4336 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4338 * po/en_GB.po: Added needed logical ID and translation.
4339 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4340 (init_view): Made the is-default column clicking work.
4342 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4345 * src/maemo/easysetup/Makefile.am:
4346 * src/maemo/easysetup/modest-easysetup-wizard.c:
4347 (modest_easysetup_wizard_dialog_init):
4348 * src/maemo/easysetup/provider-data-test.keyfile:
4349 * src/maemo/easysetup/provider-data.keyfile:
4350 Moved the provider data file to the new modest-providers-data package and used it from there.
4352 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4354 * src/modest-local-folder-info.c:
4355 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4356 N_() was already used on the static strings, but this just marks it for translation without
4357 using the translation.
4359 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4361 * src/maemo/modest-account-settings-dialog.c:
4362 (create_page_incoming),
4363 (modest_account_settings_dialog_set_account_name):
4364 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4365 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4366 I will do this if nobody else gets there first.
4368 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4370 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4371 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4372 save the security stuff.
4374 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4376 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4377 Set the email address and user fullname, which I now see must be
4380 * src/maemo/modest-account-settings-dialog.h:
4381 * src/maemo/modest-account-settings-dialog.c:
4383 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4384 leave-on-server and authentication.
4385 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4388 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4391 * src/maemo/modest-account-settings-dialog.c:
4392 * src/maemo/modest-account-settings-dialog.h:
4393 Most (but not all) of the widgets are now present as specified by the UI spec.
4394 No changes are yet saved, and some details are not properly shown yet.
4396 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4398 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4400 * src/maemo/Makefile.am:
4401 * src/maemo/modest-account-settings-dialog.c:
4402 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4403 an existing account. Doesn't do much yet.
4405 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4406 Open the accounts settings dialog when Edit is clicked.
4408 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4410 * src/maemo/easysetup/Makefile.am:
4411 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4413 * src/maemo/easysetup/modest-easysetup-wizard.c:
4414 (modest_easysetup_wizard_dialog_init):
4415 Try to get the source directory from the build system,
4416 instead of hard-coding "./" into the source code, when opening our local
4417 copies of the configuration files.
4418 But this still fails when opening the wizard from the Accounts window,
4419 maybe because the working directory seems to change at runtime.
4420 So the wizard will fail the second time unless you copy the files into their
4421 proper locations - see the stdout warnings for the paths.
4423 (create_page_account_details),(on_before_next):
4424 Check for existing non-server accounts instead of server accounts,
4425 so the default account name is useful again, and to prevent trying to
4428 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4429 Show the wizard when New is clicked.
4431 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4432 (init_view): Show the column headers, and show the columns that are
4433 specified in the UI specs. However, something in Maemo's GTK+ prevents
4434 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4435 change the default account. This is despite unsetting the special properties.
4437 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4439 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4440 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4441 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4442 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4443 to make that clearer.
4444 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4446 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4448 * src/maemo/modest-account-view-window.c:
4449 (modest_account_view_window_init),
4450 (modest_account_view_window_new):
4451 Use the same buttons as specified in the
4452 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4453 the existing widgets, which never had a chance of working.
4454 Put the ModestAccountView treeview in a scrolled window.
4455 Do not repeat the initialization in both _init() and _new().
4457 * src/widgets/modest-account-view.c: (update_account_view):
4458 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4459 this widget and window shows no accounts.
4461 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4463 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4465 * src/maemo/easysetup/modest-easysetup-wizard.c:
4466 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4467 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4468 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4471 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4472 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4473 accounts exist yet, as in the UI spec.
4475 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4477 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4479 * src/maemo/Makefile.am:
4480 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4481 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4482 New window for editing connection-specific smtp details.
4483 Not fully implemented.
4485 * src/maemo/modest-connection-specific-smtp-window.c:
4486 (modest_connection_specific_smtp_window_finalize) :
4487 unref the tree model.
4488 (on_button_edit): Show the edit window.
4490 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4492 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4495 * src/maemo/Makefile.am:
4496 * src/maemo/modest-connection-specific-smtp-window.c:
4497 * src/maemo/modest-connection-specific-smtp-window.h:
4498 New window for showing the list of connections, for connection-specific
4499 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4500 * src/maemo/easysetup/modest-easysetup-wizard.c:
4501 (create_page_custom_outgoing): Show the new window when the button is clicked.
4503 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4505 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4506 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4507 * src/maemo/modest-msg-edit-window.c:
4508 (modest_msg_edit_window_insert_image):
4509 * src/modest-conf.c: (modest_conf_key_escape):
4510 * src/modest-mail-operation.c:
4511 (modest_mail_operation_send_new_mail):
4512 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4513 (modest_ui_actions_on_new_account):
4514 * src/widgets/modest-attachment-view.c: (update_filename_request):
4515 * src/widgets/modest-mail-header-view.c:
4516 Corrected warnings that were breaking the build, by commenting out unused variables,
4517 and a function, and by including a header.
4519 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4521 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4522 so we can #ifdef around platform-specific code when necessary.
4523 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4524 to allow this to build for the GNOME platform too.
4526 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4528 * src/maemo/easysetup/modest-easysetup-wizard.c:
4529 Added util_increment_name() and used it in create_page_account_details()
4530 to make sure that the default account name is always a new name.
4532 (modest_easysetup_wizard_dialog_init),
4533 (set_default_custom_servernames): Some minor memory management fixes.
4535 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4539 * src/modest-runtime.c: (init_i18n): Restored the translation
4540 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4541 are defined in config.h, and the translations are installed.
4543 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4544 is defined for translation.
4546 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4548 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4550 * src/maemo/easysetup/modest-easysetup-wizard.c:
4551 (modest_easysetup_wizard_dialog_init):
4552 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4553 Use realistic paths (though they should use $prefix generically) to the
4554 mcc_mapping and provider-data.keyfile files which might work when they
4555 are installed by the future version of the operator-wizard package,
4556 and then fallback to paths in our source code, with an explanatory
4559 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4563 * src/maemo/Makefile.am:
4564 * src/maemo/easysetup/: Added files from the previously-exernal
4565 osso-modest-easysetup.
4566 * src/maemo/modest-main-window-ui.h:
4567 * src/modest-ui-actions.c:
4568 * src/modest-ui-actions.h:
4569 Added modest_ui_actions_on_new_account() as a signal handler for the
4570 New Account menu item. It shows the easysetup wizard.
4571 * po/en_GB.po: Added additional needed logical IDs and translations.