git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-main-window.c:
   4         (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
   5         showing/hiding it. Added TODO because it probably should not be NULL.
   6         * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
   7         because unnecessary g_warnings() make degugging difficult.
   8
   9 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  10
  11         * src/maemo/modest-msg-edit-window.c:
  12         (modest_msg_edit_window_select_color),
  13         (modest_msg_edit_window_select_background_color): 2 const corrections and
  14         moving 2 #endifs before closing brackets, to fix the build.
  15
  16 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  17
  18         * src/maemo/easysetup/modest-easysetup-wizard.h:
  19         * src/maemo/easysetup/modest-easysetup-wizard.c:
  20         (modest_easysetup_wizard_dialog_finalize),
  21         (on_button_edit_advanced_settings), (create_page_complete_custom),
  22         (on_response), (create_account):
  23         Implement the Advanced Settings edit button, by saving the account information,
  24         for the Advanded Settings dialog to use directly from gconf, and removing it
  25         if Finish is never clicked. There is still some UI strangeness, so this is not finished.
  26         Bug #5533 in the projects.maemo.org bugzilla.
  27
  28 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  29
  30         * src/maemo/modest-msg-view-window.c:
  31         (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
  32         when opening a message window.
  33
  34 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  35
  36         * src/maemo/easysetup/modest-easysetup-wizard.c:
  37         (create_page_custom_outgoing): Correct the position of the horizontal separator to
  38         match the UI spec.
  39
  40         * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
  41         before showing/hiding them, to avoid a crash when clicking on folders when there are no
  42         gconf settings. I probably added more checks than necessary, but that is safer.
  43
  44         * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
  45         variable to fix the build, but this seems to be used when it is still NULL.
  46
  47 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  48
  49         * src/modest-platform.h:
  50         * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
  51         * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
  52         * src/modest-main.c: Implement this function so we can avoid using
  53         maemo-specific API from cross-platform code.
  54         (main):
  55         * src/modest-tny-account-store.c:
  56         (get_smtp_specific_transport_account_for_open_connection):
  57         * src/modest-ui-actions.c: (check_for_connection),
  58         (modest_ui_actions_on_item_not_found):
  59         Use modest_platform_connect_and_wait() and put #idefs around other
  60         maemo-specific code, because only maemo currently has a way to
  61         identify connection names.
  62
  63 2007-04-27  Murray Cumming  <murrayc@murrayc.com>
  64
  65         * src/modest-tny-account-store.h:
  66         * src/modest-tny-account-store.c:
  67         Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
  68         the connection-specific SMTP server settings in the configuration.
  69
  70         * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
  71         (on_idle_mail_to):
  72         * src/maemo/modest-main-window.c: (on_connection_changed),
  73         (connect_signals):
  74         * src/modest-main.c: (main), (start_ui), (send_mail):
  75         Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
  76         that is what is intended.
  77
  78         * src/modest-ui-actions.c: (action_send), (action_receive),
  79         (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
  80         Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
  81         modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
  82         SMTP server is used when it is specified.
  83
  84         (modest_ui_actions_on_send_receive):
  85         Check that a connection is open before proceeding.
  86         Receive and then send, instead of vice-versa, as per the specification.
  87
  88 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  89
  90         * src/modest-mail-operation.c:
  91         (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
  92         though I guess it should be something other than NULL.
  93
  94 2007-04-26  Murray Cumming  <murrayc@murrayc.com>
  95
  96         * src/maemo/easysetup/modest-easysetup-wizard.c:
  97         (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
  98         combo twice, to avoid an g_warning and to make it visible again.
  99         * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
 100         attached before detaching it, to avoid a g_warning, and add comment about the implicit
 101         (already intended) dereference when detaching, because we then recreate the menu.
 102         But I am not sure why the warning was happening, and it is possible that this is a memory
 103         leak.
 104
 105 2007-04-25  Murray Cumming  <murrayc@murrayc.com>
 106
 107         * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
 108         and uri_parse_mailto() utility functions.
 109         (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
 110         the mailto URI.
 111         * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
 112
 113 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 114
 115         * src/dbus_api/modest-dbus-api.h:
 116         * src/dbus_api/modest-dbus-callbacks.c:
 117         Use an idle callback to execute the modest code in the application's own thread.
 118         Remove the helloworld example method.
 119         Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
 120         parsed, and the open-message method is not implemented because this is not yet implemented in
 121         modest itself.
 122         * libmodest-dbus-client/libmodest-dbus-client.c:
 123         (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
 124         (libmodest_dbus_client_open_message):
 125         * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
 126
 127         * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
 128         body without crashing.
 129
 130         * tests/dbus_api/Makefile.am:
 131         * tests/dbus_api/test_mail_to.c:
 132         * tests/dbus_api/test_open_message.c: New tests for the new methods.
 133
 134 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 135
 136         * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
 137         Added file to fix the build. Sorry.
 138
 139         * src/dbus_api/Makefile.am:
 140         * src/dbus_api/modest-dbus-api.h:
 141         * src/dbus_api/modest-dbus-callbacks.h:
 142         * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
 143         (modest_dbus_req_handler):
 144         Put constants in a separate header so it can be reused by the
 145         client library, without duplication
 146
 147         * libmodest-dbus-client/Makefile.am:
 148         * libmodest-dbus-client/libmodest-dbus-client.c:
 149         (libmodest_dbus_client_call_helloworld),
 150         (libmodfest_dbus_client_send_mail),
 151         (libmodfest_dbus_client_mailto),
 152         (libmodfest_dbus_client_open_message):
 153         * libmodest-dbus-client/libmodest-dbus-client.h:
 154         (Partly) Implement a send_mail D-Bus method.
 155
 156         * tests/dbus_api/Makefile.am:
 157         * tests/dbus_api/test_send_mail.c: (main): Added a test for
 158         the send_email D-Bus method.
 159
 160 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 161
 162         * Makefile.am:
 163         * configure.ac:
 164         * libmodest-dbus-client/Makefile.am:
 165         * libmodest-dbus-client/libmodest-dbus-client.c:
 166         * libmodest-dbus-client/libmodest-dbus-client.h:
 167         * tests/dbus_api/Makefile.am:
 168         * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
 169         for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
 170
 171 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 172
 173         * src/maemo/easysetup/modest-easysetup-wizard.c:
 174         (create_page_account_details):
 175         * src/maemo/modest-account-settings-dialog.c:
 176         (create_page_account_details): Explicitly set auto-capitalization mode for the title
 177         widgets, because this might not be the default in future versions of the Maemo GTK+.
 178         However, I can not not get capitalization to work even in a simple test case.
 179
 180 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 181
 182         * src/maemo/easysetup/modest-easysetup-wizard.c:
 183         (create_page_custom_incoming), (create_page_custom_outgoing):
 184         * src/maemo/modest-account-settings-dialog.c:
 185         (create_page_account_details), (create_page_incoming),
 186         (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
 187         instead of using gtk_check_button_with_label(), so they are aligned like the other
 188         widgets, as per the UI spec.
 189
 190 2007-04-24  Murray Cumming  <murrayc@murrayc.com>
 191
 192         * src/maemo/easysetup/modest-easysetup-wizard.c:
 193         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 194         * src/widgets/modest-validating-entry.c:
 195         * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
 196         Modest prefix instead of an EasySetup prefix.
 197
 198 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 199
 200         * src/widgets/modest-validating-entry.h:
 201         * src/widgets/modest-validating-entry.c: (on_insert_text),
 202         Added easysetup_validating_entry_set_max_func(), used to set a callback
 203         to call when the max number of characters is reached. GtkEntry has a max-length
 204         already but is silent about it.
 205
 206         * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
 207         (create_page_account_details), (create_page_user_details),
 208         (create_account):
 209         * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
 210         (create_page_account_details), (create_page_user_details),
 211         (create_page_outgoing):
 212         * src/modest-ui-actions.c: (modest_ui_actions_on_details):
 213         Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
 214         the UI spec, when the user tries to enter more than the max number of characters.
 215
 216 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/maemo/easysetup/modest-easysetup-wizard.c:
 219         (create_page_user_details), (create_page_custom_incoming),
 220         (create_page_custom_outgoing):
 221         * src/maemo/modest-account-settings-dialog.c:
 222         (create_page_user_details), (create_page_incoming),
 223         (create_page_outgoing):
 224         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 225         (modest_connection_specific_smtp_edit_window_init):
 226         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
 227         not appropriate. Bad Maemo-specific defaults!.
 228
 229 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 230
 231         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
 232         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
 233         (modest_signature_editor_dialog_set_settings):
 234         Disable the label and textview when the checkbox is disabled, and use the
 235         specified (UI spec) default signature text.
 236
 237 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 238
 239         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 240         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
 241
 242         * src/modest-defs.h:
 243         * src/modest-account-mgr-helpers.h:
 244         * src/modest-account-mgr-helpers.c:
 245         Added modest_account_mgr_get/set_signature(), using new gconf keys.
 246
 247         * src/maemo/Makefile.am:
 248         * src/maemo/modest-signature-editor-dialog.c:
 249         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
 250         as per the UI spec.
 251
 252         * src/maemo/modest-account-settings-dialog.h:
 253         * src/maemo/modest-account-settings-dialog.c:
 254         (modest_account_settings_dialog_finalize), (on_button_signature),
 255         (save_configuration): Use the new dialog when the Edit button is pressed, and
 256         save the changes if necessary, as per the UI spec.
 257
 258 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 259
 260         * src/maemo/Makefile.am:
 261         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
 262         based on maemo-develoers email from Dirk.
 263
 264         * src/maemo/easysetup/modest-easysetup-wizard.c:
 265         (create_page_welcome), (create_page_account_details),
 266         (create_page_user_details), (create_page_complete_easysetup),
 267         (create_page_custom_incoming), (create_page_custom_outgoing),
 268         (create_page_complete_custom),
 269         (modest_easysetup_wizard_dialog_init):
 270         * src/maemo/modest-account-settings-dialog.c:
 271         (create_page_account_details), (create_page_user_details),
 272         (create_page_incoming), (create_page_outgoing),
 273         (modest_account_settings_dialog_init):
 274         * src/maemo/modest-connection-specific-smtp-window.c:
 275         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
 276
 277 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 278
 279         * src/maemo/easysetup/modest-easysetup-wizard.c:
 280         (create_page_account_details), (create_page_custom_outgoing),
 281         (create_page_complete_custom):
 282         * src/maemo/modest-account-settings-dialog.c:
 283         (create_page_user_details), (create_page_incoming),
 284         (create_page_outgoing):
 285         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 286         (modest_connection_specific_smtp_edit_window_init):
 287         Use the correct (UI spec) port min/max, and use horizontal separators,
 288         as per the UI spec.
 289
 290 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
 291
 292         * src/maemo/easysetup/modest-easysetup-wizard.c:
 293         (set_default_custom_servernames):
 294         * src/maemo/modest-account-settings-dialog.c:
 295         (create_page_incoming), (on_combo_outgoing_security_changed),
 296         (on_combo_incoming_security_changed), (create_page_outgoing),
 297         (modest_account_settings_dialog_set_account_name),
 298         (save_configuration):
 299         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 300         (on_combo_security_changed),
 301         (modest_connection_specific_smtp_edit_window_init),
 302         (modest_connection_specific_smtp_edit_window_set_connection),
 303         (modest_connection_specific_smtp_edit_window_get_settings):
 304         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
 305         as per the UI spec.
 306
 307 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 308
 309         * po/en_GB.po:
 310         * src/maemo/easysetup/modest-easysetup-wizard.c:
 311         (create_page_custom_outgoing), (create_page_complete_custom):
 312         * src/maemo/modest-account-settings-dialog.c:
 313         (create_page_user_details), (create_page_outgoing):
 314         * src/maemo/modest-account-view-window.c: (button_box_new):
 315         Use changed logical IDs as per the most recent UI spec:
 316         mcen_bd_emailsetup_edit -> mcen_bd_edit
 317         mcen_bd_emailsetup_delete -> mcen_bd_delete
 318         mcen_bd_emailsetup_close -> mcen_bd_close
 319
 320 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 321
 322         * configure.ac:
 323         * src/Makefile.am:
 324         * src/dbus_api/Makefile.am:
 325         * src/dbus_api/modest-dbus-callbacks.c:
 326         * src/dbus_api/modest-dbus-callbacks.h:
 327         * src/maemo/modest-platform.c: (modest_platform_init):
 328         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 329         method.
 330         * tests/Makefile.am:
 331         * tests/dbus_api/Makefile.am:
 332         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 333
 334 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 335
 336         * src/maemo/modest-account-settings-dialog.c:
 337         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 338         Removed unnecessary includes.
 339
 340 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 341
 342         * src/maemo/easysetup/modest-easysetup-wizard.c:
 343         * src/maemo/modest-account-settings-dialog.c:
 344         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 345         * src/widgets/Makefile.am:
 346         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 347         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 348         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 349         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 350         * src/widgets/modest-secureauth-combo-box.c:
 351         * src/widgets/modest-secureauth-combo-box.h:
 352         * src/widgets/modest-serversecurity-combo-box.c:
 353         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 354         made the GObject names more consistent with the rest of the Modest code.
 355
 356 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 357
 358         * src/maemo/easysetup/Makefile.am:
 359         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 360         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 361         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 362         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 363         * src/maemo/easysetup/modest-easysetup-wizard.c:
 364         * src/maemo/easysetup/modest-validating-entry.c:
 365         * src/maemo/easysetup/modest-validating-entry.h:
 366         * src/maemo/modest-account-settings-dialog.c:
 367         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 368         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 369         widgets/ because they are used outside of easysetup too. After checking in,
 370         svn will allow me to rename them too.
 371
 372 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 373
 374         * src/gnome/modest-msg-edit-window.c:
 375         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 376         linker error, to fix the build on the GNOME platform.
 377         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 378         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 379         ifdefed out to avoid a warning.
 380
 381 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 382
 383         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 384         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 385         some alternative for GTK+ 2.6.
 386
 387 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 388
 389         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 390
 391         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 392         specified for EmailAccountsDialog in UI spec.
 393
 394         * src/maemo/easysetup/modest-easysetup-wizard.c:
 395         * src/maemo/easysetup/modest-easysetup-wizard.h:
 396         * src/maemo/modest-account-settings-dialog.c:
 397         * src/maemo/modest-account-settings-dialog.h:
 398         Reuse a member window widget for the connection-specific SMTP server accounts,
 399         so we can tell it to create/save the accounts only if we actually save changes.
 400
 401         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 402         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 403         (modest_connection_specific_smtp_edit_window_get_settings):
 404         Return a struct instance for temporarily remembering the entered data.
 405
 406         * src/maemo/modest-connection-specific-smtp-window.h:
 407         * src/maemo/modest-connection-specific-smtp-window.c:
 408         (modest_connection_specific_smtp_window_finalize),
 409         (modest_connection_specific_smtp_window_fill_with_connections),
 410         (on_button_edit),
 411         (modest_connection_specific_smtp_window_save_server_accounts),
 412         (update_model_server_names): Do not actually save data until asked,
 413         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 414
 415         (on_selection_changed),
 416         (modest_connection_specific_smtp_window_init): Disable the edit
 417         button when nothing is selected.
 418
 419         * src/modest-account-mgr-helpers.c:
 420         * src/modest-account-mgr-helpers.h:
 421         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 422         elsewhere.
 423
 424 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 425
 426         * src/modest-account-mgr-helpers.h:
 427         * src/modest-account-mgr-helpers.c:
 428         (modest_account_mgr_get_unused_account_name),
 429         (modest_account_mgr_get_unused_account_display_name): Added these
 430         utility functions, to avoid code duplication.
 431
 432         * src/maemo/easysetup/modest-easysetup-wizard.c:
 433         (create_page_account_details), (create_account):
 434         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 435         (on_combo_security_changed),
 436         (modest_connection_specific_smtp_edit_window_init),
 437         (modest_connection_specific_smtp_edit_window_save_settings):
 438         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 439         * src/maemo/modest-connection-specific-smtp-window.c:
 440         (modest_connection_specific_smtp_window_finalize),
 441         (modest_connection_specific_smtp_window_fill_with_connections),
 442         (on_button_edit), (modest_connection_specific_smtp_window_init):
 443         * src/maemo/modest-connection-specific-smtp-window.h:
 444         Implementing saving of connection-specific server accounts.
 445
 446         But I need to refactor this so we can save the data for each
 447         possible connection-specific account and only actually create the server accounts
 448         when the easysetup finished, or the OK button is pressed on the account settings
 449         dialog.
 450
 451 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 452
 453         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 454         (on_combo_security_changed):
 455         (modest_connection_specific_smtp_edit_window_init):
 456         Auto-fill the port number as in the account settings.
 457
 458         (modest_connection_specific_smtp_edit_window_set_connection):
 459         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 460         * src/maemo/modest-connection-specific-smtp-window.c:
 461         (fill_with_connections), (on_button_edit),
 462         (modest_connection_specific_smtp_window_init):
 463         Turn the edit window into a dialog to simplify the code, and
 464         set a WM hint as in a GtkDialog, because only a popup can be on top of
 465         another window in Maemo, and popups usually have no WM decoration.
 466
 467         * src/modest-defs.h:
 468         * src/modest-account-mgr-helpers.c:
 469         (modest_account_mgr_set_connection_specific_smtp),
 470         (modest_account_mgr_remove_connection_specific_smtp),
 471         (modest_account_mgr_get_connection_specific_smtp):
 472         * src/modest-account-mgr-helpers.h: Some functions to write the
 473         connection-specific SMTP server information. Not yet used.
 474
 475
 476         * src/widgets/modest-folder-view.c: (text_cell_data):
 477         Fix a warning about an uninitialized variable.
 478         (on_configuration_key_changed): Put an #ifdef around the use
 479         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 480
 481 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 482
 483         * src/maemo/modest-account-settings-dialog.h:
 484         * src/maemo/modest-account-settings-dialog.c:
 485         Added connect_for_modified() utility function to mark the new modified boolean.
 486
 487         (create_page_account_details), (create_page_user_details),
 488         (create_page_incoming), (create_page_outgoing), (on_response),
 489         (modest_account_settings_dialog_init),
 490         (modest_account_settings_dialog_set_account_name):
 491         Only warn about unsaved changes when there are actually unsaved changes.
 492
 493         * src/modest-account-mgr-helpers.c:
 494         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 495         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 496         to get the data from there in future.
 497
 498 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 499
 500         * src/modest-defs.h:
 501
 502         * src/modest-account-mgr-helpers.h:
 503         * src/modest-account-mgr-helpers.c:
 504         Store the security account setting in a single conf key instead of using
 505         the options list, so that the list is left for just the to-be-removed camel hack,
 506         and because gconf_client_set_list() is failing for some reason.
 507
 508         * src/modest-account-mgr.c:
 509         (modest_account_mgr_add_server_account):
 510         * src/maemo/modest-account-settings-dialog.c:
 511         (modest_account_settings_dialog_set_account_name),
 512         (save_configuration): Use the renamed functions.
 513
 514
 515 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 516
 517         * src/widgets/Makefile.am:
 518         * src/widgets/modest-limit-retrieve-combo-box.c:
 519         * src/widgets/modest-limit-retrieve-combo-box.h:
 520         * src/widgets/modest-retrieve-combo-box.c:
 521         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 522         the account settings dialog.
 523
 524         * src/modest-defs.h:
 525         * src/modest-account-mgr-helpers.h:
 526         * src/modest-account-mgr-helpers.c:
 527         (modest_server_account_get_option_secure_auth),
 528         (modest_server_account_set_option_secure_auth):
 529         * src/modest-account-mgr.c:
 530         (modest_account_mgr_add_server_account):
 531         Use the existing AUTH_MECH conf key for the secure-auth setting,
 532         instead of putting it in the list options, because this was actually used already.
 533
 534         * src/maemo/modest-account-settings-dialog.c:
 535         (create_page_account_details),
 536         (modest_account_settings_dialog_set_account_name),
 537         (save_configuration):
 538         * src/maemo/modest-account-settings-dialog.h:
 539         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 540         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 541
 542 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 543
 544         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 545         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 546         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 547
 548         * src/modest-defs.h:
 549         * src/maemo/modest-account-settings-dialog.c:
 550         (create_page_incoming), (on_combo_outgoing_security_changed),
 551         (on_combo_incoming_security_changed), (create_page_outgoing),
 552         (modest_account_settings_dialog_set_account_name),
 553         (save_configuration): Load/Save the port number, and change it when the
 554         security combo changes, to suitable defaults.
 555
 556 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 557
 558         * src/modest-account-mgr.c:
 559         (modest_account_mgr_add_server_account): Set the security and secure-auth
 560         options, and add a comment saying that the other camel-specific options should be
 561         removed in future.
 562
 563 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 564
 565         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 566         found by valgrind.
 567         * src/modest-tny-account-store.c: (account_list_free),
 568         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 569         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 570         easy to fix.
 571
 572 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 573
 574         * src/modest-protocol-info.c:
 575         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 576         is required by our UI spec. Maybe something in our implementation will use this eventually.
 577         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 578         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 579         instead of the previous 0 placeholder.
 580
 581         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 582         secure-auth settings.
 583         * src/modest-account-mgr-helpers.h:
 584         * src/modest-account-mgr-helpers.c:
 585         (modest_server_account_data_get_option_secure_auth),
 586         (modest_server_account_set_option_secure_auth),
 587         (modest_server_account_data_get_option_security),
 588         (modest_server_account_set_option_security): Added this API for getting and setting the security
 589         and secure-auth settings.
 590
 591         * src/maemo/modest-account-settings-dialog.h:
 592         * src/maemo/modest-account-settings-dialog.c:
 593         (modest_account_settings_dialog_finalize), (check_data),
 594         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 595         about changing titles.
 596         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 597         (save_configuration): Save the security and secure-auth settings.
 598
 599         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 600         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 601
 602 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 603
 604         * src/modest-defs.h:
 605         * src/modest-account-mgr.c:
 606         (modest_account_mgr_add_server_account):
 607         Added and used defines for the options key and value pair strings,
 608         that are used so far, though they do not seem to correspond to anything in our
 609         UI specs or ModestProtocol enum.
 610
 611         * src/modest-account-mgr-helpers.h:
 612         * src/modest-account-mgr-helpers.c:
 613         (compare_option_strings_for_name),
 614         (modest_server_account_data_get_option_value),
 615         (modest_server_account_data_get_option_bool),
 616         (modest_account_mgr_get_server_account_option):
 617         Added helper functions for parsing the options GSList.
 618
 619 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 620
 621         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 622         display name is based on the supplied account name.
 623         * src/modest-account-mgr.c:
 624         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 625         with an inefficient, but good-enough, implementation.
 626
 627         * src/maemo/easysetup/modest-easysetup-wizard.c:
 628         (create_page_account_details), (on_before_next), (create_account):
 629         Check for existing display names rather than (non-user-visible) account names, and just
 630         create and set a unique account name at the end.
 631
 632         * src/maemo/modest-account-settings-dialog.c:
 633         (modest_account_settings_dialog_init),
 634         (modest_account_settings_dialog_set_account_name),
 635         (create_page_incoming): Show the display name, instead of the account name.
 636         (on_response): Do some (not all) extra checks, as in the UI spec.
 637         (save_configuration): Save the display name if it was changed.
 638
 639 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 640
 641         * po/en_GB.po: Added needed logical ID and translation.
 642         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 643         (init_view): Made the is-default column clicking work.
 644
 645 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 646
 647         * configure.ac:
 648         * src/maemo/easysetup/Makefile.am:
 649         * src/maemo/easysetup/modest-easysetup-wizard.c:
 650         (modest_easysetup_wizard_dialog_init):
 651         * src/maemo/easysetup/provider-data-test.keyfile:
 652         * src/maemo/easysetup/provider-data.keyfile:
 653         Moved the provider data file to the new modest-providers-data package and used it from there.
 654
 655 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 656
 657         * src/modest-local-folder-info.c:
 658         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 659         N_() was already used on the static strings, but this just marks it for translation without
 660         using the translation.
 661
 662 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 663
 664         * src/maemo/modest-account-settings-dialog.c:
 665         (create_page_incoming),
 666         (modest_account_settings_dialog_set_account_name):
 667         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 668         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 669         I will do this if nobody else gets there first.
 670
 671 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 672
 673         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 674         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 675         save the security stuff.
 676
 677 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 678
 679         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 680         Set the email address and user fullname, which I now see must be
 681         done separately.
 682
 683         * src/maemo/modest-account-settings-dialog.h:
 684         * src/maemo/modest-account-settings-dialog.c:
 685          (on_response),
 686         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 687         leave-on-server and authentication.
 688         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 689         how to do the rest.
 690
 691 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 692
 693
 694         * src/maemo/modest-account-settings-dialog.c:
 695         * src/maemo/modest-account-settings-dialog.h:
 696         Most (but not all) of the widgets are now present as specified by the UI spec.
 697         No changes are yet saved, and some details are not properly shown yet.
 698
 699         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 700
 701 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 702
 703         * src/maemo/Makefile.am:
 704         * src/maemo/modest-account-settings-dialog.c:
 705         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 706         an existing account. Doesn't do much yet.
 707
 708         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 709         Open the accounts settings dialog when Edit is clicked.
 710
 711 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 712
 713         * src/maemo/easysetup/Makefile.am:
 714         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 715         (load_from_file):
 716         * src/maemo/easysetup/modest-easysetup-wizard.c:
 717         (modest_easysetup_wizard_dialog_init):
 718         Try to get the source directory from the build system,
 719         instead of hard-coding "./" into the source code, when opening our local
 720         copies of the configuration files.
 721         But this still fails when opening the wizard from the Accounts window,
 722         maybe because the working directory seems to change at runtime.
 723         So the wizard will fail the second time unless you copy the files into their
 724         proper locations - see the stdout warnings for the paths.
 725
 726         (create_page_account_details),(on_before_next):
 727         Check for existing non-server accounts instead of server accounts,
 728         so the default account name is useful again, and to prevent trying to
 729         recreate accounts.
 730
 731         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 732         Show the wizard when New is clicked.
 733
 734         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 735         (init_view): Show the column headers, and show the columns that are
 736         specified in the UI specs. However, something in Maemo's GTK+ prevents
 737         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 738         change the default account. This is despite unsetting the special properties.
 739
 740 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 741
 742         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 743         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 744         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 745         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 746         to make that clearer.
 747         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 748
 749 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 750
 751         * src/maemo/modest-account-view-window.c:
 752         (modest_account_view_window_init),
 753         (modest_account_view_window_new):
 754         Use the same buttons as specified in the
 755         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 756         the existing widgets, which never had a chance of working.
 757         Put the ModestAccountView treeview in a scrolled window.
 758         Do not repeat the initialization in both _init() and _new().
 759
 760         * src/widgets/modest-account-view.c: (update_account_view):
 761         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 762         this widget and window shows no accounts.
 763
 764         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 765
 766 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 767
 768         * src/maemo/easysetup/modest-easysetup-wizard.c:
 769         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 770         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 771         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 772         which seems wrong.
 773
 774         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 775         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 776         accounts exist yet, as in the UI spec.
 777
 778         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 779
 780 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 781
 782         * src/maemo/Makefile.am:
 783         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 784         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 785         New window for editing connection-specific smtp details.
 786         Not fully implemented.
 787
 788         * src/maemo/modest-connection-specific-smtp-window.c:
 789         (modest_connection_specific_smtp_window_finalize) :
 790         unref the tree model.
 791         (on_button_edit): Show the edit window.
 792
 793 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 794
 795         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 796         error for me.
 797
 798         * src/maemo/Makefile.am:
 799         * src/maemo/modest-connection-specific-smtp-window.c:
 800         * src/maemo/modest-connection-specific-smtp-window.h:
 801         New window for showing the list of connections, for connection-specific
 802         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 803         * src/maemo/easysetup/modest-easysetup-wizard.c:
 804         (create_page_custom_outgoing): Show the new window when the button is clicked.
 805
 806 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 807
 808         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 809         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 810         * src/maemo/modest-msg-edit-window.c:
 811         (modest_msg_edit_window_insert_image):
 812         * src/modest-conf.c: (modest_conf_key_escape):
 813         * src/modest-mail-operation.c:
 814         (modest_mail_operation_send_new_mail):
 815         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 816         (modest_ui_actions_on_new_account):
 817         * src/widgets/modest-attachment-view.c: (update_filename_request):
 818         * src/widgets/modest-mail-header-view.c:
 819         Corrected warnings that were breaking the build, by commenting out unused variables,
 820         and a function, and by including a header.
 821
 822 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 823
 824         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 825         so we can #ifdef around platform-specific code when necessary.
 826         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 827         to allow this to build for the GNOME platform too.
 828
 829 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 830
 831         * src/maemo/easysetup/modest-easysetup-wizard.c:
 832         Added util_increment_name() and used it in create_page_account_details()
 833         to make sure that the default account name is always a new name.
 834
 835         (modest_easysetup_wizard_dialog_init),
 836         (set_default_custom_servernames): Some minor memory management fixes.
 837
 838 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 839
 840         * Makefile.am:
 841         * configure.ac:
 842         * src/modest-runtime.c: (init_i18n): Restored the translation
 843         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 844         are defined in config.h, and the translations are installed.
 845
 846         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 847         is defined for translation.
 848
 849 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 850
 851         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 852         (load_from_file):
 853         * src/maemo/easysetup/modest-easysetup-wizard.c:
 854         (modest_easysetup_wizard_dialog_init):
 855         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 856         Use realistic paths (though they should use $prefix generically) to the
 857         mcc_mapping and provider-data.keyfile files which might work when they
 858         are installed by the future version of the operator-wizard package,
 859         and then fallback to paths in our source code, with an explanatory
 860         warning.
 861
 862 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 863
 864         * configure.ac:
 865         * src/Makefile.am:
 866         * src/maemo/Makefile.am:
 867         * src/maemo/easysetup/: Added files from the previously-exernal
 868         osso-modest-easysetup.
 869         * src/maemo/modest-main-window-ui.h:
 870         * src/modest-ui-actions.c:
 871         * src/modest-ui-actions.h:
 872         Added modest_ui_actions_on_new_account() as a signal handler for the
 873         New Account menu item. It shows the easysetup wizard.
 874         * po/en_GB.po: Added additional needed logical IDs and translations.
 875
 876 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 877 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 878