git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/easysetup/modest-easysetup-wizard.c:
   4         (create_page_user_details), (create_page_custom_incoming),
   5         (create_page_custom_outgoing):
   6         * src/maemo/modest-account-settings-dialog.c:
   7         (create_page_user_details), (create_page_incoming),
   8         (create_page_outgoing):
   9         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  10         (modest_connection_specific_smtp_edit_window_init):
  11         Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
  12         not appropriate. Bad Maemo-specific defaults!.
  13
  14 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  15
  16         * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
  17         (on_toggle_button_changed), (modest_signature_editor_dialog_init),
  18         (modest_signature_editor_dialog_set_settings):
  19         Disable the label and textview when the checkbox is disabled, and use the
  20         specified (UI spec) default signature text.
  21
  22 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  23
  24         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  25         (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
  26
  27         * src/modest-defs.h:
  28         * src/modest-account-mgr-helpers.h:
  29         * src/modest-account-mgr-helpers.c:
  30         Added modest_account_mgr_get/set_signature(), using new gconf keys.
  31
  32         * src/maemo/Makefile.am:
  33         * src/maemo/modest-signature-editor-dialog.c:
  34         * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
  35         as per the UI spec.
  36
  37         * src/maemo/modest-account-settings-dialog.h:
  38         * src/maemo/modest-account-settings-dialog.c:
  39         (modest_account_settings_dialog_finalize), (on_button_signature),
  40         (save_configuration): Use the new dialog when the Edit button is pressed, and
  41         save the changes if necessary, as per the UI spec.
  42
  43 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  44
  45         * src/maemo/Makefile.am:
  46         * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
  47         based on maemo-develoers email from Dirk.
  48
  49         * src/maemo/easysetup/modest-easysetup-wizard.c:
  50         (create_page_welcome), (create_page_account_details),
  51         (create_page_user_details), (create_page_complete_easysetup),
  52         (create_page_custom_incoming), (create_page_custom_outgoing),
  53         (create_page_complete_custom),
  54         (modest_easysetup_wizard_dialog_init):
  55         * src/maemo/modest-account-settings-dialog.c:
  56         (create_page_account_details), (create_page_user_details),
  57         (create_page_incoming), (create_page_outgoing),
  58         (modest_account_settings_dialog_init):
  59         * src/maemo/modest-connection-specific-smtp-window.c:
  60         (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
  61
  62 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  63
  64         * src/maemo/easysetup/modest-easysetup-wizard.c:
  65         (create_page_account_details), (create_page_custom_outgoing),
  66         (create_page_complete_custom):
  67         * src/maemo/modest-account-settings-dialog.c:
  68         (create_page_user_details), (create_page_incoming),
  69         (create_page_outgoing):
  70         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  71         (modest_connection_specific_smtp_edit_window_init):
  72         Use the correct (UI spec) port min/max, and use horizontal separators,
  73         as per the UI spec.
  74
  75 2007-04-23  Murray Cumming  <murrayc@murrayc.com>
  76
  77         * src/maemo/easysetup/modest-easysetup-wizard.c:
  78         (set_default_custom_servernames):
  79         * src/maemo/modest-account-settings-dialog.c:
  80         (create_page_incoming), (on_combo_outgoing_security_changed),
  81         (on_combo_incoming_security_changed), (create_page_outgoing),
  82         (modest_account_settings_dialog_set_account_name),
  83         (save_configuration):
  84         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  85         (on_combo_security_changed),
  86         (modest_connection_specific_smtp_edit_window_init),
  87         (modest_connection_specific_smtp_edit_window_set_connection),
  88         (modest_connection_specific_smtp_edit_window_get_settings):
  89         Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
  90         as per the UI spec.
  91
  92 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
  93
  94         * po/en_GB.po:
  95         * src/maemo/easysetup/modest-easysetup-wizard.c:
  96         (create_page_custom_outgoing), (create_page_complete_custom):
  97         * src/maemo/modest-account-settings-dialog.c:
  98         (create_page_user_details), (create_page_outgoing):
  99         * src/maemo/modest-account-view-window.c: (button_box_new):
 100         Use changed logical IDs as per the most recent UI spec:
 101         mcen_bd_emailsetup_edit -> mcen_bd_edit
 102         mcen_bd_emailsetup_delete -> mcen_bd_delete
 103         mcen_bd_emailsetup_close -> mcen_bd_close
 104
 105 2007-04-20  2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 106
 107         * configure.ac:
 108         * src/Makefile.am:
 109         * src/dbus_api/Makefile.am:
 110         * src/dbus_api/modest-dbus-callbacks.c:
 111         * src/dbus_api/modest-dbus-callbacks.h:
 112         * src/maemo/modest-platform.c: (modest_platform_init):
 113         Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
 114         method.
 115         * tests/Makefile.am:
 116         * tests/dbus_api/Makefile.am:
 117         * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
 118
 119 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 120
 121         * src/maemo/modest-account-settings-dialog.c:
 122         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 123         Removed unnecessary includes.
 124
 125 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 126
 127         * src/maemo/easysetup/modest-easysetup-wizard.c:
 128         * src/maemo/modest-account-settings-dialog.c:
 129         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 130         * src/widgets/Makefile.am:
 131         * src/widgets/modest-easysetup-secureauth-combo-box.c:
 132         * src/widgets/modest-easysetup-secureauth-combo-box.h:
 133         * src/widgets/modest-easysetup-serversecurity-combo-box.c:
 134         * src/widgets/modest-easysetup-serversecurity-combo-box.h:
 135         * src/widgets/modest-secureauth-combo-box.c:
 136         * src/widgets/modest-secureauth-combo-box.h:
 137         * src/widgets/modest-serversecurity-combo-box.c:
 138         * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
 139         made the GObject names more consistent with the rest of the Modest code.
 140
 141 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 142
 143         * src/maemo/easysetup/Makefile.am:
 144         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 145         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
 146         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 147         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 148         * src/maemo/easysetup/modest-easysetup-wizard.c:
 149         * src/maemo/easysetup/modest-validating-entry.c:
 150         * src/maemo/easysetup/modest-validating-entry.h:
 151         * src/maemo/modest-account-settings-dialog.c:
 152         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 153         * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
 154         widgets/ because they are used outside of easysetup too. After checking in,
 155         svn will allow me to rename them too.
 156
 157 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 158
 159         * src/gnome/modest-msg-edit-window.c:
 160         (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
 161         linker error, to fix the build on the GNOME platform.
 162         modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
 163         modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
 164         ifdefed out to avoid a warning.
 165
 166 2007-04-20  Murray Cumming  <murrayc@murrayc.com>
 167
 168         * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
 169         use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
 170         some alternative for GTK+ 2.6.
 171
 172 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 173
 174         * src/maemo/modest-address-book.c: Added include to avoid a warning.
 175
 176         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
 177         specified for EmailAccountsDialog in UI spec.
 178
 179         * src/maemo/easysetup/modest-easysetup-wizard.c:
 180         * src/maemo/easysetup/modest-easysetup-wizard.h:
 181         * src/maemo/modest-account-settings-dialog.c:
 182         * src/maemo/modest-account-settings-dialog.h:
 183         Reuse a member window widget for the connection-specific SMTP server accounts,
 184         so we can tell it to create/save the accounts only if we actually save changes.
 185
 186         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 187         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 188         (modest_connection_specific_smtp_edit_window_get_settings):
 189         Return a struct instance for temporarily remembering the entered data.
 190
 191         * src/maemo/modest-connection-specific-smtp-window.h:
 192         * src/maemo/modest-connection-specific-smtp-window.c:
 193         (modest_connection_specific_smtp_window_finalize),
 194         (modest_connection_specific_smtp_window_fill_with_connections),
 195         (on_button_edit),
 196         (modest_connection_specific_smtp_window_save_server_accounts),
 197         (update_model_server_names): Do not actually save data until asked,
 198         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
 199
 200         (on_selection_changed),
 201         (modest_connection_specific_smtp_window_init): Disable the edit
 202         button when nothing is selected.
 203
 204         * src/modest-account-mgr-helpers.c:
 205         * src/modest-account-mgr-helpers.h:
 206         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
 207         elsewhere.
 208
 209 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
 210
 211         * src/modest-account-mgr-helpers.h:
 212         * src/modest-account-mgr-helpers.c:
 213         (modest_account_mgr_get_unused_account_name),
 214         (modest_account_mgr_get_unused_account_display_name): Added these
 215         utility functions, to avoid code duplication.
 216
 217         * src/maemo/easysetup/modest-easysetup-wizard.c:
 218         (create_page_account_details), (create_account):
 219         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 220         (on_combo_security_changed),
 221         (modest_connection_specific_smtp_edit_window_init),
 222         (modest_connection_specific_smtp_edit_window_save_settings):
 223         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 224         * src/maemo/modest-connection-specific-smtp-window.c:
 225         (modest_connection_specific_smtp_window_finalize),
 226         (modest_connection_specific_smtp_window_fill_with_connections),
 227         (on_button_edit), (modest_connection_specific_smtp_window_init):
 228         * src/maemo/modest-connection-specific-smtp-window.h:
 229         Implementing saving of connection-specific server accounts.
 230
 231         But I need to refactor this so we can save the data for each
 232         possible connection-specific account and only actually create the server accounts
 233         when the easysetup finished, or the OK button is pressed on the account settings
 234         dialog.
 235
 236 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 237
 238         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 239         (on_combo_security_changed):
 240         (modest_connection_specific_smtp_edit_window_init):
 241         Auto-fill the port number as in the account settings.
 242
 243         (modest_connection_specific_smtp_edit_window_set_connection):
 244         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 245         * src/maemo/modest-connection-specific-smtp-window.c:
 246         (fill_with_connections), (on_button_edit),
 247         (modest_connection_specific_smtp_window_init):
 248         Turn the edit window into a dialog to simplify the code, and
 249         set a WM hint as in a GtkDialog, because only a popup can be on top of
 250         another window in Maemo, and popups usually have no WM decoration.
 251
 252         * src/modest-defs.h:
 253         * src/modest-account-mgr-helpers.c:
 254         (modest_account_mgr_set_connection_specific_smtp),
 255         (modest_account_mgr_remove_connection_specific_smtp),
 256         (modest_account_mgr_get_connection_specific_smtp):
 257         * src/modest-account-mgr-helpers.h: Some functions to write the
 258         connection-specific SMTP server information. Not yet used.
 259
 260
 261         * src/widgets/modest-folder-view.c: (text_cell_data):
 262         Fix a warning about an uninitialized variable.
 263         (on_configuration_key_changed): Put an #ifdef around the use
 264         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
 265
 266 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 267
 268         * src/maemo/modest-account-settings-dialog.h:
 269         * src/maemo/modest-account-settings-dialog.c:
 270         Added connect_for_modified() utility function to mark the new modified boolean.
 271
 272         (create_page_account_details), (create_page_user_details),
 273         (create_page_incoming), (create_page_outgoing), (on_response),
 274         (modest_account_settings_dialog_init),
 275         (modest_account_settings_dialog_set_account_name):
 276         Only warn about unsaved changes when there are actually unsaved changes.
 277
 278         * src/modest-account-mgr-helpers.c:
 279         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 280         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 281         to get the data from there in future.
 282
 283 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 284
 285         * src/modest-defs.h:
 286
 287         * src/modest-account-mgr-helpers.h:
 288         * src/modest-account-mgr-helpers.c:
 289         Store the security account setting in a single conf key instead of using
 290         the options list, so that the list is left for just the to-be-removed camel hack,
 291         and because gconf_client_set_list() is failing for some reason.
 292
 293         * src/modest-account-mgr.c:
 294         (modest_account_mgr_add_server_account):
 295         * src/maemo/modest-account-settings-dialog.c:
 296         (modest_account_settings_dialog_set_account_name),
 297         (save_configuration): Use the renamed functions.
 298
 299
 300 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 301
 302         * src/widgets/Makefile.am:
 303         * src/widgets/modest-limit-retrieve-combo-box.c:
 304         * src/widgets/modest-limit-retrieve-combo-box.h:
 305         * src/widgets/modest-retrieve-combo-box.c:
 306         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 307         the account settings dialog.
 308
 309         * src/modest-defs.h:
 310         * src/modest-account-mgr-helpers.h:
 311         * src/modest-account-mgr-helpers.c:
 312         (modest_server_account_get_option_secure_auth),
 313         (modest_server_account_set_option_secure_auth):
 314         * src/modest-account-mgr.c:
 315         (modest_account_mgr_add_server_account):
 316         Use the existing AUTH_MECH conf key for the secure-auth setting,
 317         instead of putting it in the list options, because this was actually used already.
 318
 319         * src/maemo/modest-account-settings-dialog.c:
 320         (create_page_account_details),
 321         (modest_account_settings_dialog_set_account_name),
 322         (save_configuration):
 323         * src/maemo/modest-account-settings-dialog.h:
 324         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 325         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 326
 327 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 328
 329         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 330         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 331         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 332
 333         * src/modest-defs.h:
 334         * src/maemo/modest-account-settings-dialog.c:
 335         (create_page_incoming), (on_combo_outgoing_security_changed),
 336         (on_combo_incoming_security_changed), (create_page_outgoing),
 337         (modest_account_settings_dialog_set_account_name),
 338         (save_configuration): Load/Save the port number, and change it when the
 339         security combo changes, to suitable defaults.
 340
 341 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 342
 343         * src/modest-account-mgr.c:
 344         (modest_account_mgr_add_server_account): Set the security and secure-auth
 345         options, and add a comment saying that the other camel-specific options should be
 346         removed in future.
 347
 348 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 349
 350         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 351         found by valgrind.
 352         * src/modest-tny-account-store.c: (account_list_free),
 353         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 354         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 355         easy to fix.
 356
 357 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 358
 359         * src/modest-protocol-info.c:
 360         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 361         is required by our UI spec. Maybe something in our implementation will use this eventually.
 362         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 363         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 364         instead of the previous 0 placeholder.
 365
 366         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 367         secure-auth settings.
 368         * src/modest-account-mgr-helpers.h:
 369         * src/modest-account-mgr-helpers.c:
 370         (modest_server_account_data_get_option_secure_auth),
 371         (modest_server_account_set_option_secure_auth),
 372         (modest_server_account_data_get_option_security),
 373         (modest_server_account_set_option_security): Added this API for getting and setting the security
 374         and secure-auth settings.
 375
 376         * src/maemo/modest-account-settings-dialog.h:
 377         * src/maemo/modest-account-settings-dialog.c:
 378         (modest_account_settings_dialog_finalize), (check_data),
 379         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 380         about changing titles.
 381         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 382         (save_configuration): Save the security and secure-auth settings.
 383
 384         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 385         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 386
 387 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 388
 389         * src/modest-defs.h:
 390         * src/modest-account-mgr.c:
 391         (modest_account_mgr_add_server_account):
 392         Added and used defines for the options key and value pair strings,
 393         that are used so far, though they do not seem to correspond to anything in our
 394         UI specs or ModestProtocol enum.
 395
 396         * src/modest-account-mgr-helpers.h:
 397         * src/modest-account-mgr-helpers.c:
 398         (compare_option_strings_for_name),
 399         (modest_server_account_data_get_option_value),
 400         (modest_server_account_data_get_option_bool),
 401         (modest_account_mgr_get_server_account_option):
 402         Added helper functions for parsing the options GSList.
 403
 404 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 405
 406         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 407         display name is based on the supplied account name.
 408         * src/modest-account-mgr.c:
 409         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 410         with an inefficient, but good-enough, implementation.
 411
 412         * src/maemo/easysetup/modest-easysetup-wizard.c:
 413         (create_page_account_details), (on_before_next), (create_account):
 414         Check for existing display names rather than (non-user-visible) account names, and just
 415         create and set a unique account name at the end.
 416
 417         * src/maemo/modest-account-settings-dialog.c:
 418         (modest_account_settings_dialog_init),
 419         (modest_account_settings_dialog_set_account_name),
 420         (create_page_incoming): Show the display name, instead of the account name.
 421         (on_response): Do some (not all) extra checks, as in the UI spec.
 422         (save_configuration): Save the display name if it was changed.
 423
 424 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 425
 426         * po/en_GB.po: Added needed logical ID and translation.
 427         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 428         (init_view): Made the is-default column clicking work.
 429
 430 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 431
 432         * configure.ac:
 433         * src/maemo/easysetup/Makefile.am:
 434         * src/maemo/easysetup/modest-easysetup-wizard.c:
 435         (modest_easysetup_wizard_dialog_init):
 436         * src/maemo/easysetup/provider-data-test.keyfile:
 437         * src/maemo/easysetup/provider-data.keyfile:
 438         Moved the provider data file to the new modest-providers-data package and used it from there.
 439
 440 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 441
 442         * src/modest-local-folder-info.c:
 443         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 444         N_() was already used on the static strings, but this just marks it for translation without
 445         using the translation.
 446
 447 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 448
 449         * src/maemo/modest-account-settings-dialog.c:
 450         (create_page_incoming),
 451         (modest_account_settings_dialog_set_account_name):
 452         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 453         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 454         I will do this if nobody else gets there first.
 455
 456 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 457
 458         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 459         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 460         save the security stuff.
 461
 462 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 463
 464         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 465         Set the email address and user fullname, which I now see must be
 466         done separately.
 467
 468         * src/maemo/modest-account-settings-dialog.h:
 469         * src/maemo/modest-account-settings-dialog.c:
 470          (on_response),
 471         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 472         leave-on-server and authentication.
 473         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 474         how to do the rest.
 475
 476 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 477
 478
 479         * src/maemo/modest-account-settings-dialog.c:
 480         * src/maemo/modest-account-settings-dialog.h:
 481         Most (but not all) of the widgets are now present as specified by the UI spec.
 482         No changes are yet saved, and some details are not properly shown yet.
 483
 484         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 485
 486 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 487
 488         * src/maemo/Makefile.am:
 489         * src/maemo/modest-account-settings-dialog.c:
 490         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 491         an existing account. Doesn't do much yet.
 492
 493         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 494         Open the accounts settings dialog when Edit is clicked.
 495
 496 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 497
 498         * src/maemo/easysetup/Makefile.am:
 499         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 500         (load_from_file):
 501         * src/maemo/easysetup/modest-easysetup-wizard.c:
 502         (modest_easysetup_wizard_dialog_init):
 503         Try to get the source directory from the build system,
 504         instead of hard-coding "./" into the source code, when opening our local
 505         copies of the configuration files.
 506         But this still fails when opening the wizard from the Accounts window,
 507         maybe because the working directory seems to change at runtime.
 508         So the wizard will fail the second time unless you copy the files into their
 509         proper locations - see the stdout warnings for the paths.
 510
 511         (create_page_account_details),(on_before_next):
 512         Check for existing non-server accounts instead of server accounts,
 513         so the default account name is useful again, and to prevent trying to
 514         recreate accounts.
 515
 516         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 517         Show the wizard when New is clicked.
 518
 519         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 520         (init_view): Show the column headers, and show the columns that are
 521         specified in the UI specs. However, something in Maemo's GTK+ prevents
 522         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 523         change the default account. This is despite unsetting the special properties.
 524
 525 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 526
 527         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 528         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 529         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 530         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 531         to make that clearer.
 532         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 533
 534 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 535
 536         * src/maemo/modest-account-view-window.c:
 537         (modest_account_view_window_init),
 538         (modest_account_view_window_new):
 539         Use the same buttons as specified in the
 540         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 541         the existing widgets, which never had a chance of working.
 542         Put the ModestAccountView treeview in a scrolled window.
 543         Do not repeat the initialization in both _init() and _new().
 544
 545         * src/widgets/modest-account-view.c: (update_account_view):
 546         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 547         this widget and window shows no accounts.
 548
 549         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 550
 551 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 552
 553         * src/maemo/easysetup/modest-easysetup-wizard.c:
 554         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 555         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 556         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 557         which seems wrong.
 558
 559         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 560         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 561         accounts exist yet, as in the UI spec.
 562
 563         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 564
 565 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 566
 567         * src/maemo/Makefile.am:
 568         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 569         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 570         New window for editing connection-specific smtp details.
 571         Not fully implemented.
 572
 573         * src/maemo/modest-connection-specific-smtp-window.c:
 574         (modest_connection_specific_smtp_window_finalize) :
 575         unref the tree model.
 576         (on_button_edit): Show the edit window.
 577
 578 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 579
 580         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 581         error for me.
 582
 583         * src/maemo/Makefile.am:
 584         * src/maemo/modest-connection-specific-smtp-window.c:
 585         * src/maemo/modest-connection-specific-smtp-window.h:
 586         New window for showing the list of connections, for connection-specific
 587         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 588         * src/maemo/easysetup/modest-easysetup-wizard.c:
 589         (create_page_custom_outgoing): Show the new window when the button is clicked.
 590
 591 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 592
 593         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 594         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 595         * src/maemo/modest-msg-edit-window.c:
 596         (modest_msg_edit_window_insert_image):
 597         * src/modest-conf.c: (modest_conf_key_escape):
 598         * src/modest-mail-operation.c:
 599         (modest_mail_operation_send_new_mail):
 600         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 601         (modest_ui_actions_on_new_account):
 602         * src/widgets/modest-attachment-view.c: (update_filename_request):
 603         * src/widgets/modest-mail-header-view.c:
 604         Corrected warnings that were breaking the build, by commenting out unused variables,
 605         and a function, and by including a header.
 606
 607 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 608
 609         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 610         so we can #ifdef around platform-specific code when necessary.
 611         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 612         to allow this to build for the GNOME platform too.
 613
 614 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 615
 616         * src/maemo/easysetup/modest-easysetup-wizard.c:
 617         Added util_increment_name() and used it in create_page_account_details()
 618         to make sure that the default account name is always a new name.
 619
 620         (modest_easysetup_wizard_dialog_init),
 621         (set_default_custom_servernames): Some minor memory management fixes.
 622
 623 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 624
 625         * Makefile.am:
 626         * configure.ac:
 627         * src/modest-runtime.c: (init_i18n): Restored the translation
 628         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 629         are defined in config.h, and the translations are installed.
 630
 631         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 632         is defined for translation.
 633
 634 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 635
 636         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 637         (load_from_file):
 638         * src/maemo/easysetup/modest-easysetup-wizard.c:
 639         (modest_easysetup_wizard_dialog_init):
 640         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 641         Use realistic paths (though they should use $prefix generically) to the
 642         mcc_mapping and provider-data.keyfile files which might work when they
 643         are installed by the future version of the operator-wizard package,
 644         and then fallback to paths in our source code, with an explanatory
 645         warning.
 646
 647 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 648
 649         * configure.ac:
 650         * src/Makefile.am:
 651         * src/maemo/Makefile.am:
 652         * src/maemo/easysetup/: Added files from the previously-exernal
 653         osso-modest-easysetup.
 654         * src/maemo/modest-main-window-ui.h:
 655         * src/modest-ui-actions.c:
 656         * src/modest-ui-actions.h:
 657         Added modest_ui_actions_on_new_account() as a signal handler for the
 658         New Account menu item. It shows the easysetup wizard.
 659         * po/en_GB.po: Added additional needed logical IDs and translations.
 660
 661 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 662 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 663