1 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-protocol-info.c:
4 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
5 is required by our UI spec. Maybe something in our implementation will use this eventually.
6 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
7 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
8 instead of the previous 0 placeholder.
10 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
12 * src/modest-account-mgr-helpers.h:
13 * src/modest-account-mgr-helpers.c:
14 (modest_server_account_data_get_option_secure_auth),
15 (modest_server_account_set_option_secure_auth),
16 (modest_server_account_data_get_option_security),
17 (modest_server_account_set_option_security): Added this API for getting and setting the security
18 and secure-auth settings.
20 * src/maemo/modest-account-settings-dialog.h:
21 * src/maemo/modest-account-settings-dialog.c:
22 (modest_account_settings_dialog_finalize), (check_data),
23 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
24 about changing titles.
25 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
26 (save_configuration): Save the security and secure-auth settings.
28 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
29 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
31 2007-04-17 Murray Cumming <murrayc@murrayc.com>
34 * src/modest-account-mgr.c:
35 (modest_account_mgr_add_server_account):
36 Added and used defines for the options key and value pair strings,
37 that are used so far, though they do not seem to correspond to anything in our
38 UI specs or ModestProtocol enum.
40 * src/modest-account-mgr-helpers.h:
41 * src/modest-account-mgr-helpers.c:
42 (compare_option_strings_for_name),
43 (modest_server_account_data_get_option_value),
44 (modest_server_account_data_get_option_bool),
45 (modest_account_mgr_get_server_account_option):
46 Added helper functions for parsing the options GSList.
48 2007-04-16 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
51 display name is based on the supplied account name.
52 * src/modest-account-mgr.c:
53 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
54 with an inefficient, but good-enough, implementation.
56 * src/maemo/easysetup/modest-easysetup-wizard.c:
57 (create_page_account_details), (on_before_next), (create_account):
58 Check for existing display names rather than (non-user-visible) account names, and just
59 create and set a unique account name at the end.
61 * src/maemo/modest-account-settings-dialog.c:
62 (modest_account_settings_dialog_init),
63 (modest_account_settings_dialog_set_account_name),
64 (create_page_incoming): Show the display name, instead of the account name.
65 (on_response): Do some (not all) extra checks, as in the UI spec.
66 (save_configuration): Save the display name if it was changed.
68 2007-04-16 Murray Cumming <murrayc@murrayc.com>
70 * po/en_GB.po: Added needed logical ID and translation.
71 * src/widgets/modest-account-view.c: (on_account_default_toggled),
72 (init_view): Made the is-default column clicking work.
74 2007-04-16 Murray Cumming <murrayc@murrayc.com>
77 * src/maemo/easysetup/Makefile.am:
78 * src/maemo/easysetup/modest-easysetup-wizard.c:
79 (modest_easysetup_wizard_dialog_init):
80 * src/maemo/easysetup/provider-data-test.keyfile:
81 * src/maemo/easysetup/provider-data.keyfile:
82 Moved the provider data file to the new modest-providers-data package and used it from there.
84 2007-04-16 Murray Cumming <murrayc@murrayc.com>
86 * src/modest-local-folder-info.c:
87 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
88 N_() was already used on the static strings, but this just marks it for translation without
89 using the translation.
91 2007-04-06 Murray Cumming <murrayc@murrayc.com>
93 * src/maemo/modest-account-settings-dialog.c:
94 (create_page_incoming),
95 (modest_account_settings_dialog_set_account_name):
96 Added comments about the need for new API in ModestAccountMgr to handle the authentication
97 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
98 I will do this if nobody else gets there first.
100 2007-04-06 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
103 Saved much of the incoming and outgoing data too, though I cannot yet see how to
104 save the security stuff.
106 2007-04-06 Murray Cumming <murrayc@murrayc.com>
108 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
109 Set the email address and user fullname, which I now see must be
112 * src/maemo/modest-account-settings-dialog.h:
113 * src/maemo/modest-account-settings-dialog.c:
115 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
116 leave-on-server and authentication.
117 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
120 2007-04-06 Murray Cumming <murrayc@murrayc.com>
123 * src/maemo/modest-account-settings-dialog.c:
124 * src/maemo/modest-account-settings-dialog.h:
125 Most (but not all) of the widgets are now present as specified by the UI spec.
126 No changes are yet saved, and some details are not properly shown yet.
128 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
130 2007-04-06 Murray Cumming <murrayc@murrayc.com>
132 * src/maemo/Makefile.am:
133 * src/maemo/modest-account-settings-dialog.c:
134 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
135 an existing account. Doesn't do much yet.
137 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
138 Open the accounts settings dialog when Edit is clicked.
140 2007-04-05 Murray Cumming <murrayc@murrayc.com>
142 * src/maemo/easysetup/Makefile.am:
143 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
145 * src/maemo/easysetup/modest-easysetup-wizard.c:
146 (modest_easysetup_wizard_dialog_init):
147 Try to get the source directory from the build system,
148 instead of hard-coding "./" into the source code, when opening our local
149 copies of the configuration files.
150 But this still fails when opening the wizard from the Accounts window,
151 maybe because the working directory seems to change at runtime.
152 So the wizard will fail the second time unless you copy the files into their
153 proper locations - see the stdout warnings for the paths.
155 (create_page_account_details),(on_before_next):
156 Check for existing non-server accounts instead of server accounts,
157 so the default account name is useful again, and to prevent trying to
160 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
161 Show the wizard when New is clicked.
163 * src/widgets/modest-account-view.c: (on_account_default_toggled),
164 (init_view): Show the column headers, and show the columns that are
165 specified in the UI specs. However, something in Maemo's GTK+ prevents
166 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
167 change the default account. This is despite unsetting the special properties.
169 2007-04-05 Murray Cumming <murrayc@murrayc.com>
171 * docs/reference/modest-design.sgml: Corrected spelling mistake.
172 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
173 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
174 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
175 to make that clearer.
176 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
178 2007-04-05 Murray Cumming <murrayc@murrayc.com>
180 * src/maemo/modest-account-view-window.c:
181 (modest_account_view_window_init),
182 (modest_account_view_window_new):
183 Use the same buttons as specified in the
184 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
185 the existing widgets, which never had a chance of working.
186 Put the ModestAccountView treeview in a scrolled window.
187 Do not repeat the initialization in both _init() and _new().
189 * src/widgets/modest-account-view.c: (update_account_view):
190 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
191 this widget and window shows no accounts.
193 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
195 2007-04-05 Murray Cumming <murrayc@murrayc.com>
197 * src/maemo/easysetup/modest-easysetup-wizard.c:
198 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
199 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
200 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
203 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
204 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
205 accounts exist yet, as in the UI spec.
207 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
209 2007-04-05 Murray Cumming <murrayc@murrayc.com>
211 * src/maemo/Makefile.am:
212 * src/maemo/modest-connection-specific-smtp-edit-window.c:
213 * src/maemo/modest-connection-specific-smtp-edit-window.h:
214 New window for editing connection-specific smtp details.
215 Not fully implemented.
217 * src/maemo/modest-connection-specific-smtp-window.c:
218 (modest_connection_specific_smtp_window_finalize) :
219 unref the tree model.
220 (on_button_edit): Show the edit window.
222 2007-04-05 Murray Cumming <murrayc@murrayc.com>
224 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
227 * src/maemo/Makefile.am:
228 * src/maemo/modest-connection-specific-smtp-window.c:
229 * src/maemo/modest-connection-specific-smtp-window.h:
230 New window for showing the list of connections, for connection-specific
231 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
232 * src/maemo/easysetup/modest-easysetup-wizard.c:
233 (create_page_custom_outgoing): Show the new window when the button is clicked.
235 2007-04-04 Murray Cumming <murrayc@murrayc.com>
237 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
238 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
239 * src/maemo/modest-msg-edit-window.c:
240 (modest_msg_edit_window_insert_image):
241 * src/modest-conf.c: (modest_conf_key_escape):
242 * src/modest-mail-operation.c:
243 (modest_mail_operation_send_new_mail):
244 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
245 (modest_ui_actions_on_new_account):
246 * src/widgets/modest-attachment-view.c: (update_filename_request):
247 * src/widgets/modest-mail-header-view.c:
248 Corrected warnings that were breaking the build, by commenting out unused variables,
249 and a function, and by including a header.
251 2007-04-04 Murray Cumming <murrayc@murrayc.com>
253 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
254 so we can #ifdef around platform-specific code when necessary.
255 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
256 to allow this to build for the GNOME platform too.
258 2007-04-04 Murray Cumming <murrayc@murrayc.com>
260 * src/maemo/easysetup/modest-easysetup-wizard.c:
261 Added util_increment_name() and used it in create_page_account_details()
262 to make sure that the default account name is always a new name.
264 (modest_easysetup_wizard_dialog_init),
265 (set_default_custom_servernames): Some minor memory management fixes.
267 2007-04-04 Murray Cumming <murrayc@murrayc.com>
271 * src/modest-runtime.c: (init_i18n): Restored the translation
272 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
273 are defined in config.h, and the translations are installed.
275 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
276 is defined for translation.
278 2007-04-03 Murray Cumming <murrayc@murrayc.com>
280 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
282 * src/maemo/easysetup/modest-easysetup-wizard.c:
283 (modest_easysetup_wizard_dialog_init):
284 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
285 Use realistic paths (though they should use $prefix generically) to the
286 mcc_mapping and provider-data.keyfile files which might work when they
287 are installed by the future version of the operator-wizard package,
288 and then fallback to paths in our source code, with an explanatory
291 2007-04-03 Murray Cumming <murrayc@murrayc.com>
295 * src/maemo/Makefile.am:
296 * src/maemo/easysetup/: Added files from the previously-exernal
297 osso-modest-easysetup.
298 * src/maemo/modest-main-window-ui.h:
299 * src/modest-ui-actions.c:
300 * src/modest-ui-actions.h:
301 Added modest_ui_actions_on_new_account() as a signal handler for the
302 New Account menu item. It shows the easysetup wizard.
303 * po/en_GB.po: Added additional needed logical IDs and translations.
305 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
306 Apparently ChangeLog is not used for some vague Nokia legal reasons.