1 2007-06-18 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account.c:
4 (modest_tny_account_new_from_server_account):
5 Uncommented the url debug output again, because it is useful for
6 debugging, as I said in the comment.
8 2007-06-18 Murray Cumming <murrayc@murrayc.com>
10 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
12 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
13 for Mameo Bora, to fix the build.
15 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
18 Fixed build with hildon < 0.99
20 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
21 Check if the selected account is busy instead of checking all accounts
23 * src/modest-account-mgr-priv.h:
24 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
25 (modest_account_mgr_init), (compare_account_name),
26 (modest_account_mgr_set_account_busy),
27 (modest_account_mgr_account_is_busy):
28 * src/modest-account-mgr.h:
29 Added busy information to the account manager. It possible to
30 set an account to busy or not busy now.
32 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
33 (modest_mail_operation_update_account),
34 (modest_mail_operation_notify_end):
35 Set the account to busy/not busy depending on the operation state.
37 * src/widgets/modest-account-view.c:
38 (modest_account_view_finalize), (get_last_updated_string),
39 (update_account_view), (on_account_busy_changed), (init_view):
40 Show string "Refreshing..." if the account is currently busy.
42 All this fixes projects.maemo.org bug NB#59711
44 2007-06-14 Armin Burgmeier <armin@openismus.com>
46 * src/widgets/modest-attachments-view.h:
47 * src/widgets/modest-attachments-view.c: Added
48 modest_attachments_view_has_attachments() and fixed coordinate
49 transformation in get_att_view_at_coords(). This fixes attachment
52 * src/widgets/modest-msg-view.c: Make use of
53 modest_attachments_view_has_attachments() to decide whether to show
54 attachments in the header.
56 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
58 * src/maemo/modest-connection-specific-smtp-edit-window.c:
59 (on_change), (on_combo_security_changed),
60 (modest_connection_specific_smtp_edit_window_init),
61 (modest_connection_specific_smtp_edit_window_set_connection),
62 (modest_connection_specific_smtp_edit_window_is_dirty):
63 * src/maemo/modest-connection-specific-smtp-edit-window.h:
64 * src/maemo/modest-connection-specific-smtp-window.c:
67 Show an comfirmation dialog for the smpt-edit-window if there are
68 unsaved changes and the user hits cancel.
69 (projects.maemo.org bug NB#60479)
71 2007-06-14 Armin Burgmeier <armin@openismus.com>
73 * src/maemo/easysetup/modest-easysetup-wizard.c:
74 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
75 address" info in banner instead of node, and select all the text as
76 per UI spec. This fixes projects.maemo.org bug NB#60550.
78 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
80 reviewed by: <delete if not using a buddy>
82 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
83 * src/modest-ui-actions.c: (folder_refreshed_cb):
85 2007-06-14 Murray Cumming <murrayc@murrayc.com>
87 * src/widgets/modest-folder-view.c: (filter_row):
88 Explictly filter out the per-account outbox accounts. I don't know why
89 these only sometimes show up, but now they should never show up in the UI.
90 This should fix projects.maemo.org bug NB#60160.
92 2007-06-14 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
95 when the toolbar does not exist yet.
96 * src/modest-widget-memory.c: (save_settings_header_view):
97 Added g_warnings() to help us to discover when we are trying to set
98 an empty columns list in gconf.
100 2007-06-14 Murray Cumming <murrayc@murrayc.com>
104 Added modest_init_get_default_header_view_column_ids().
106 * src/modest-widget-memory.c: (restore_settings_header_view):
107 Use the new function to get defaults, if the gconf key is empty,
108 instead of not creating any columns. This seems to fix the
109 empty right-hand pane problems.
111 * src/widgets/modest-header-view.h: Improved documentation.
113 2007-06-13 Murray Cumming <murrayc@murrayc.com>
115 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
116 Revert the use of the display name as the account name, because this
117 is generally wrong and would break the code that follows.
119 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
121 * src/maemo/easysetup/modest-easysetup-wizard.c:
122 (check_for_supported_auth_methods), (on_before_next),
125 More correct fix for projects.maemo.org bug NB# 58991
126 Do not longer accept AUTH_PASSWORD as secure method and choose
127 correct method when creating the account.
129 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
131 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
132 Fixed projects.maemo.org bug NB# 58991
134 2007-06-13 Murray Cumming <murrayc@murrayc.com>
136 * src/modest-init.c: (modest_init_init_core),
137 (modest_init_local_folders): Fixed compilation errors.
139 2007-06-13 Murray Cumming <murrayc@murrayc.com>
141 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
142 Remove unnecessary lib/include, though it is good in principle when needed.
144 * src/modest-init.c: (modest_init_one_local_folder),
145 (modest_init_local_folders):
146 * src/modest-init.h: Initialize the .modest library for memory cards,
147 instead of just doing nothing for them. This should allow us to create
148 folders there, fixing projects.maemo.org bug NB#59297.
150 2007-06-13 Murray Cumming <murrayc@murrayc.com>
152 * libmodest-dbus-client/libmodest-dbus-client.c:
153 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
154 (libmodest_dbus_client_compose_mail),
155 (libmodest_dbus_client_open_message),
156 (libmodest_dbus_client_send_and_receive),
157 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
159 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
160 (on_idle_open_message), (modest_dbus_req_handler),
161 (search_result_to_message), (modest_dbus_req_filter):
162 * src/modest-search.c: (add_hit), (modest_search_folder),
163 (modest_search_all_accounts): Improved debug messages.
165 * tests/dbus_api/test_open_message.c: (main): Improved comments.
167 * src/modest-tny-account-store.c:
168 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
171 2007-06-13 Murray Cumming <murrayc@murrayc.com>
174 2007-06-12 Murray Cumming <murrayc@murrayc.com>
176 * src/modest-tny-account-store.c: (get_server_accounts):
177 Call modest_tny_local_folders_account_add_merged_outbox_folders()
178 even when there are no accounts, so that the Outbox folder is always
179 visible. This fixes projects.maemo.org bug NB#60158.
181 2007-06-12 Murray Cumming <murrayc@murrayc.com>
183 * src/maemo/modest-main-window.c: (create_details_widget):
184 Use the mcen_va_never logical ID.
186 2007-06-12 Murray Cumming <murrayc@murrayc.com>
188 * src/dbus_api/modest-dbus-api.h:
189 * src/dbus_api/modest-dbus-callbacks.c:
190 (on_idle_open_default_inbox), (on_open_default_inbox),
191 (modest_dbus_req_handler):
192 Added a new OpenDefaultInbox method.
194 * libmodest-dbus-client/libmodest-dbus-client.h:
195 * libmodest-dbus-client/libmodest-dbus-client.c:
196 Added libmodest_dbus_client_open_default_inbox() to call the new
197 dbus method. This should be useful to projects.maemo.org bug NB#57214,
198 though it should maybe be used by a new osso-email-interface function.
200 * tests/dbus_api/Makefile.am:
201 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
204 2007-06-12 Murray Cumming <murrayc@murrayc.com>
206 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
207 NULL, so that the signals get all the keys. This should not actually
208 change any behaviour because we currently update everything when anything
211 2007-06-12 Murray Cumming <murrayc@murrayc.com>
213 * src/widgets/modest-folder-view.c: (text_cell_data),
214 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
215 (find_inbox_iter): If tinymail tells us that the folder is
216 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
217 This causes the inbox to be selected at startup, fixing part of
218 projects.maemo.org bug NB#56305.
220 * src/modest-ui-dimming-rules.c:
221 (modest_ui_dimming_rules_on_tools_smtp_servers):
222 * src/modest-ui-dimming-rules.h: Added a callback function to dim
223 the SMTP servers menu item.
224 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
225 that the SMTP Servers menu item is dimmed when there are no accounts,
226 as a future version of the UI spec will require. This fixes
227 projects.maemo.org bug NB#56305.
229 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
231 * src/maemo/modest-maemo-utils.c:
232 (modest_maemo_utils_get_supported_secure_authentication_methods):
233 Added label to dialog instead of unreadable title
235 * src/maemo/modest-main-window.c: (sync_accounts_cb),
236 (modest_main_window_new):
237 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
240 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
241 * src/modest-account-mgr.h:
242 Added method to avoid code duplication
244 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
245 (modest_ui_actions_on_send_receive):
246 Use modest_account_mgr_has_accounts
248 2007-06-11 Murray Cumming <murrayc@murrayc.com>
250 * src/maemo/easysetup/modest-presets.c:
251 (modest_presets_get_info_server_security): Do not report secure auth
253 * src/modest-protocol-info.c: Use the defines for the gconf key names
254 for secure authentication. This was not working because we were writing
255 Password and reading password, and the check was case sensitive.
256 With this, gmail now works for receiving and sending when created via
259 2007-06-11 Murray Cumming <murrayc@murrayc.com>
261 * src/maemo/easysetup/modest-presets.c:
262 (modest_presets_get_info_server_security): Correct the key name for
263 SecureSmtp, because it seems to be case-sensitive.
264 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
265 Do not try to get the 0th notebook page if there are 0 pages, to
268 2007-06-11 Murray Cumming <murrayc@murrayc.com>
270 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
271 Prevent use of the new notification feature for now, because it currently
272 shows one dialog for each new email, which is annoying.
274 2007-06-11 Murray Cumming <murrayc@murrayc.com>
276 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
277 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
278 when no country was selected, so that we show the global ones.
279 * src/maemo/easysetup/modest-presets.c:
280 (modest_presets_get_providers): Return only the global providers, not
281 all providers when mmc=0 was requested.
283 2007-06-11 Murray Cumming <murrayc@murrayc.com>
285 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
286 (easysetup_provider_combo_box_fill): Remove debug code that showed the
287 provider ID in the combo.
289 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
290 Do not show the page numbers, because it would be confusing when we add
291 the 2 extra pages for the custom setup, when the user chooses the "Other"
292 provider. This fixes projects.maemo.org bug NB#59028
294 * src/modest-init.c: (modest_init_init_core),
295 (modest_init_local_folders):
297 * src/modest-tny-account.c:
298 (modest_tny_account_new_for_local_folders): Do not create default folders
299 for the memory card. This should fix projects.maemo.org bug NB#59328.
301 2007-06-11 Murray Cumming <murrayc@murrayc.com>
303 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
304 Free the changed_conf_keys string items. They are already freed in the
305 idle handler if that runs first.
307 2007-06-11 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-ui-actions.c:
310 (modest_ui_actions_on_password_requested): Check that the server name
311 is not NULL, because I just saw a password dialog with (null) as the
314 * src/modest-tny-folder.[h|c]: Added
315 modest_tny_folder_is_memory_card_folder().
316 * src/modest-ui-dimming-rules.c:
317 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
318 menu item for memory cards, as per the UI spec (section 7.4). This should
319 fix projects.maemo.org bug NB#59297.
321 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
323 * src/maemo/modest-main-window.c: (sync_accounts_cb):
324 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
325 is another problem with the code, see Murray's comment at line 772)
327 2007-06-08 Murray Cumming <murrayc@murrayc.com>
329 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
330 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
331 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
332 (load_from_file), (easysetup_country_combo_box_init),
333 (easysetup_country_combo_box_get_active_country_ids),
334 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
335 instead of just one ID, to avoid duplicate country names in the UI.
337 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
338 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
339 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
340 a single ID, avoiding duplicate providers.
341 * src/maemo/easysetup/modest-easysetup-wizard.c:
342 (on_combo_account_country): Adapt to use a list.
344 2007-06-08 Murray Cumming <murrayc@murrayc.com>
346 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
347 keys changed in the last X seconds.
349 * src/modest-account-mgr.h:
350 * src/modest-account-mgr.c: (on_timeout_notify_changes),
351 (on_key_change), (modest_account_mgr_class_init),
352 (modest_account_mgr_init), (modest_account_mgr_finalize):
353 As the keys are changed, save them in a GSList* and signal that GSList*
354 further every X seconds, to batch changes, to allow us to do just one
355 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
356 bug NB#56941 and other (UI-blocking) delays when changing account settings.
358 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
359 changed signal signature.
361 * src/modest-conf.c: (modest_conf_set_list),
362 (modest_conf_on_change): Reenable notification.
364 (modest_conf_maemo_fake_on_change): Comment out the hack that
365 notified immediately instead of asynchronously.
367 * src/widgets/modest-account-view.h:
368 * src/widgets/modest-account-view.c:
369 (update_account_view): Select the previously-selected account ID,
370 if possible. This fixes projects.maemo.org bug NB#56933.
372 (on_account_changed), (on_account_removed),
373 (modest_account_view_select_account):
375 Remove the block/unblock functions
376 because they were not useful.
378 * src/maemo/modest-account-view-window.c:
379 (on_delete_button_clicked), (on_edit_button_clicked),
380 (on_new_button_clicked): Remove the use of the non-working block/unblock.
382 2007-06-08 Murray Cumming <murrayc@murrayc.com>
384 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
385 Improve the error dialog to show Incorrect Account Settings, which seems
386 clearer, and say that the internal error message (to be removed from the
387 dialog later) is often misleading.
388 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
390 * src/modest-tny-account.c:
391 (modest_tny_account_new_from_server_account): Uncomment the printf of the
392 URL because this is so useful for debugging on the device.
394 * src/widgets/modest-serversecurity-combo-box.c:
395 (modest_serversecurity_combo_box_fill): Correct a logical ID.
397 2007-06-08 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-mail-operation.c:
400 (modest_mail_operation_send_new_mail):
401 Added a comment about a nasty but apparently harmless message. Details
402 added to the wiki g_warnings() page.
404 2007-06-08 Murray Cumming <murrayc@murrayc.com>
406 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
407 (modest_tny_send_queue_class_init):
408 Do not use the priv struct because it is empty, to avoid g_warnings
409 about a non-existant priv struct.
411 * src/modest-tny-account-store.c:
412 (modest_tny_account_store_get_server_account),
413 (modest_tny_account_store_get_transport_account_for_open_connection
414 ): Do not try to get transport server accounts for local folders,
415 because they don't have any. This avoids a g_warning().
417 * src/maemo/modest-main-window.c:
418 (modest_main_window_notify_send_receive_initied),
419 (on_configuration_key_changed):
420 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
422 * src/modest-mail-operation.c:
423 (modest_mail_operation_update_account):
424 * src/modest-tny-account-store.h:
425 * src/modest-tny-account.c:
426 (modest_tny_account_get_special_folder),
427 (modest_tny_account_new_for_local_folders),
428 (modest_tny_account_new_for_per_account_local_outbox_folder):
429 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
430 * src/modest-tny-local-folders-account.c:
431 (add_account_folders_to_merged_folder):
432 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
433 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
434 (modest_ui_actions_on_send):
435 * src/widgets/modest-folder-view.c: (update_model):
436 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
437 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
438 modest_tny_account_store_get_tny_account_by_account() to
439 modest_tny_account_store_get_server_account() to make the code clearer.
441 2007-06-07 Marcus Bauer <marcusb@openismus.com>
443 * src/dbus_api/modest-dbus-api.h:
444 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
445 * src/maemo/modest-msg-edit-window.c:
446 (modest_msg_edit_window_attach_file_noninteractive):
447 added g_warning in case the file to be attached does not exist
448 * tests/dbus_api/test_compose_mail.c: (main):
449 removed obsolete comment, added generic files as test case
451 2007-06-07 Murray Cumming <murrayc@murrayc.com>
453 * src/modest-tny-account-store.c: (get_server_accounts):
454 Create the local folders account only once, not once for each outbox, and
455 not only when there are some outboxes.
457 2007-06-07 Murray Cumming <murrayc@murrayc.com>
459 * src/widgets/modest-folder-view.c: (update_model): Comment out some
460 code that is causing a crash at startup. Sergio says that he is fixing this.
462 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
464 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
465 * src/maemo/modest-account-settings-dialog.c:
466 (create_page_outgoing),
467 (modest_account_settings_dialog_set_account_name),
468 (save_configuration):
469 - Fixed handling of the "Use secure authentication" toggle to comply with
470 the ui specification. See also projects.maemo.org bug NB#58400
472 - Restore the Secure connection setting combo correctly when loading
475 * src/maemo/modest-maemo-utils.c:
476 (on_camel_account_get_supported_secure_authentication),
477 (modest_maemo_utils_get_supported_secure_authentication_methods):
478 Fixed a crasher if operation is canceled
480 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
481 (modest_protocol_info_auth_is_secure):
482 * src/modest-protocol-info.h:
484 Added two new methods to determine if a protocol/auth method is secure/encrypted in
485 the sense of the "Use secure authentication" toggle.
487 2007-06-07 Murray Cumming <murrayc@murrayc.com>
489 * src/modest-tny-account-store.h:
490 * src/modest-tny-account-store.c:
491 Added modest_tny_account_store_get_local_folders_account().
493 * src/modest-tny-folder.h:
494 * src/modest-tny-folder.c:
495 (modest_tny_folder_get_account):
496 Added this replacement for tny_folder_get_account() which returns
497 the local-folders account for TnyMergeFolders, to avoid the
498 warning about the unimplemented get_account_func() vfunc().
500 (modest_tny_folder_get_rules),
501 * src/modest-ui-actions.c:
502 (modest_ui_actions_on_folder_selection_changed):
503 * src/modest-mail-operation.c:
504 (modest_mail_operation_remove_folder),
505 (modest_mail_operation_xfer_folder),
506 (modest_mail_operation_rename_folder),
507 (modest_mail_operation_get_msg),
508 (modest_mail_operation_get_msgs_full),
509 (modest_mail_operation_remove_msg),
510 (modest_mail_operation_xfer_msgs),
511 (modest_mail_operation_refresh_folder):
512 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
514 2007-06-07 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
517 (modest_server_account_set_security):
518 * src/modest-defs.h: Add comments explaining that our
519 UI spec means TLS when it says Normal, so these do not look like errors.
521 * src/modest-tny-account.c:
522 (modest_tny_account_new_from_server_account): Use the new tinymail
523 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
524 for TLS. This should fix projects.maemo.org bug NB#58460.
526 2007-06-06 Murray Cumming <murrayc@murrayc.com>
528 * src/maemo/easysetup/modest-easysetup-wizard.c:
529 (create_account): Correct the position of the gconf sanity check warning.
530 (on_button_edit_advanced_settings): Show the dialog immediately, instead
531 of using the g_idle_add() hack, because this does not seem to be necessary
532 on osso 1.1. It might even work on Maemo Bora if the problems were actually
533 caused by something other than maemo's gconf.
534 This fixes projects.maemo.org bug #59022.
536 2007-06-06 Murray Cumming <murrayc@murrayc.com>
538 * src/modest-account-mgr-helpers.c:
539 (modest_account_mgr_get_default_account): Do not check that the account
540 exists if there is no default account (NULL), to fix a runtime warning.
542 2007-06-06 Murray Cumming <murrayc@murrayc.com>
544 * src/widgets/modest-folder-view.c: (update_model):
545 Do not unref the treemodel before we have finished with it.
546 This prevents a valgrind warning and an occasional crash at startup.
548 2007-06-06 Marcus Bauer <marcusb@openismus.com>
550 * libmodest-dbus-client/libmodest-dbus-client.h:
551 added libmodest_dbus_client_compose_mail()
552 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
554 added functions needed for SendAsMail() functionality
555 * src/maemo/modest-msg-edit-window.c:
556 (modest_msg_edit_window_attach_file_noninteractive):
557 non interactively attaching files to message edit window
558 * src/widgets/modest-msg-edit-window.h:
559 * tests/dbus_api/Makefile.am:
560 added test_compose_mail.c
561 * tests/dbus_api/test_compose_mail.c: (main):
563 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
565 * src/modest-account-view.c:
566 Fixed bug projects.maemo.org bug NB#59307
568 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/maemo/easysetup/modest-easysetup-wizard.c:
571 (get_serverport_incoming), (on_before_next), (create_account):
572 * src/maemo/modest-account-settings-dialog.c:
573 (modest_account_settings_dialog_set_account_name):
574 * src/maemo/modest-maemo-utils.c:
575 (on_camel_account_get_supported_secure_authentication_status),
576 (on_camel_account_get_supported_secure_authentication),
577 (on_secure_auth_cancel),
578 (modest_maemo_utils_get_supported_secure_authentication_methods):
580 Implemented security authentication for settings and easysetup.
582 2007-06-05 Murray Cumming <murrayc@murrayc.com>
584 * src/maemo/modest-main-window.c: (create_details_widget):
585 Show the total size for memory card accounts too, instead of showing
586 the name again. Fixes bug projects.maemo.org bug NB#59307.
588 2007-06-05 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-tny-simple-folder-store.c:
592 * src/modest-tny-simple-folder-store.h: Removed.
594 * src/modest-tny-local-folders-account.h
595 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
596 for the local-folders maildir, with an extra TnyMergedFolder containing
597 the folders of the per-account outbox store accounts.
598 * src/modest-tny-account-store.c: (get_server_accounts):
599 Add the outboxes to the special local folders account after creating it.
601 * src/modest-tny-account.c:
602 (modest_tny_account_new_for_local_folders): Create the derived
603 account when creating the main local-folders account.
605 * src/maemo/modest-main-window.c: (create_details_widget),
606 (modest_main_window_set_contents_style):
607 Adapted to the use of the derived account instead of the folder store.
609 * src/modest-ui-actions.c:
610 (modest_ui_actions_on_folder_selection_changed):
611 * src/modest-ui-dimming-rules.c:
612 (modest_ui_dimming_rules_on_new_folder):
613 * src/widgets/modest-folder-view.c: (text_cell_data),
614 (icon_cell_data), (filter_row), (update_model),
615 (get_cmp_rows_type_pos):
618 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
619 Do not get the priv struct, because no priv struct has been set,
620 to avoid a runtime warning.
622 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
623 #ifelse with #else, to fix a warning, to fix the build.
626 2007-06-05 Christian Kellner <ckellner@openismus.com>
628 * libmodest-dbus-client/libmodest-dbus-client.c:
629 Fix small typo in doc (why do you always see them
630 AFTER committing stuff?)
633 2007-06-05 Christian Kellner <ckellner@openismus.com>
635 * libmodest-dbus-client/libmodest-dbus-client.c:
636 (libmodest_dbus_client_search):
637 Initialize hit list with NULL. Also set folder list
638 to "" if NULL was supplied.
641 2007-06-03 Christian Kellner <ckellner@openismus.com>
643 * libmodest-dbus-client/libmodest-dbus-client.c:
644 (modest_search_hit_list_free):
645 Make it save to call it with NULL.
647 * src/dbus_api/modest-dbus-callbacks.c:
648 * src/modest-search.c:
649 Return full ModestSearchHits as the search result list not TnyHeader
650 since can't be around withouth the correspoding TnyFolder.
652 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
654 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
655 Added currently commented code to check for secure auth
657 * src/maemo/modest-account-settings-dialog.c: (on_response),
658 (save_configuration), (show_ok):
659 Fixed projects.maemo.org bugs NB #59248 and #59251
661 * src/maemo/modest-maemo-utils.c:
662 (on_camel_account_get_supported_secure_authentication_status),
663 (on_camel_account_get_supported_secure_authentication),
664 (modest_maemo_utils_get_supported_secure_authentication_methods):
665 * src/maemo/modest-maemo-utils.h:
666 Moved get_supported_secure_authentication() method here to be able
667 to use it from easysetup wizard.
669 * src/modest-pair.c: (on_pair_compare_as_string):
670 Should compare string with first part of pair and not
671 strcmp pairs which will crash.
673 * src/modest-protocol-info.c:
674 (modest_protocol_info_protocol_is_store):
675 * src/modest-protocol-info.h:
676 Added modest_protocol_info_get_auth_protocol_name()
678 2007-06-03 Armin Burgmeier <armin@openismus.com>
680 * src/modest-mail-operation.c:
681 (modest_mail_operation_get_msgs_full): Set priv->account also when
682 only retrieving a single message. This avoids a crash when canceling
685 (modest_mail_operation_notify_end): Do not explicitely remove the
686 operation from the queue but only emit the progress_changed signal.
687 The queue itself listens to that signal to remove the operation when
688 it is finished. This reduces coupling and removes a potential deadlock
689 when modest_mail_operation_notify_end() is called from the queue
690 itself. If that is a problem performance-wise, I would suggest to
691 implement a status-changed signal or something.
693 * src/modest-mail-operation-queue.c: Make sure to never call a
694 function from another file while the queue is locked. This (hopefully)
695 fixes another deadlock when exiting the application while retrieving
698 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
700 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
701 Fixed build if libogs is not available
703 2007-06-03 Christian Kellner <ckellner@openismus.com>
705 * libmodest-dbus-client/libmodest-dbus-client.h:
706 * libmodest-dbus-client/libmodest-dbus-client.c:
707 (libmodest_dbus_client_delete_message):
708 Implement deletion of messages (Client side).
710 (modest_search_hit_free),
711 (modest_search_hit_list_free):
712 Utility functions to free the result hits.
714 * src/dbus_api/modest-dbus-api.h:
715 * src/dbus_api/modest-dbus-callbacks.c:
717 (modest_dbus_req_handler):
718 Implement deletion of messages (Server side).
720 * tests/dbus_api/test_search.c: (main):
723 * tests/dbus_api/Makefile.am:
724 * tests/dbus_api/test_delete_message:
725 Add little test for the message deletion logic
727 2007-06-03 Armin Burgmeier <armin@openismus.com>
729 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
730 when the operation queue was not empty. projects.maemo.org bug
733 2007-06-03 Armin Burgmeier <armin@openismus.com>
735 * src/widgets/modest-account-view.c
736 (on_account_default_toggled): Toggle default account column
737 explicitely instead of waiting for gconf notification (which is
738 currently ignored). This should fix projects.maemo.org bug NB#56910
739 for now. It should probably be removed when gconf notifications are
742 2007-06-03 Christian Kellner <ckellner@openismus.com>
744 * libmodest-dbus-client/libmodest-dbus-client.c:
745 Removed debugging spew.
747 * src/dbus_api/modest-dbus-callbacks.c:
748 Added debugging info.
750 * src/modest-search.c:
751 (modest_search_all_accounts):
752 Use tny_account_store_get_accounts () on the account store
753 to get all accounts which is the way to get all accounts.
755 * tests/dbus_api/test_search.c: (main):
756 Make it possible to supply the search term on the command line.
758 2007-06-03 Christian Kellner <ckellner@openismus.com>
760 * libmodest-dbus-client/libmodest-dbus-client.c:
761 * libmodest-dbus-client/libmodest-dbus-client.h:
762 Implement searching for mesages over raw dbus. (Client side)
764 * src/dbus_api/Makefile.am:
765 * src/dbus_api/modest-dbus-api.h:
766 * src/dbus_api/modest-dbus-callbacks.c:
767 * src/dbus_api/modest-dbus-callbacks.h:
768 Search framework (Server side). Also implement on_idle_open_message().
770 * src/maemo/modest-platform.c: (modest_platform_init):
771 Prepare for raw dbus/osso rpc interaction.
773 * src/modest-search.h:
774 Changed minsize from unspecific guint to guint32.
776 * src/modest-search.c:
778 Added strange hack which magically made tnymail work.
780 (modest_search_folder),
781 (modest_search_account),
782 (modest_search_all_accounts):
783 Implement helper functions to search all accounts, specific account
786 * tests/dbus_api/Makefile.am:
787 * tests/dbus_api/test_open_message.c:
788 Read url to open from commandline.
790 * tests/dbus_api/test_search.c:
791 Implement small test for dbus search stuff
793 2007-06-02 Armin Burgmeier <armin@openismus.com>
795 * src/maemo/modest-account-settings-dialog.c: Changed window title to
796 include account type and account title. This fixes projects.maemo.org
799 * src/maemo/modest-account-view-window.c: Set a title for the window.
801 2007-06-02 Armin Burgmeier <armin@openismus.com>
803 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
804 incoming and outgoing server name based on email address and server
805 types as long as the names have not been edited manually. This fixes
806 projects.maemo.org bug NB#58671.
808 2007-06-02 Armin Burgmeier <armin@openismus.com>
810 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
811 server type cannot be changed in future to the incoming details page
812 when creating an account. This fixes projects.maemo.org bug NB#59029.
814 2007-06-02 Armin Burgmeier <armin@openismus.com>
816 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
817 and assigned max width chars so that they wrap instead of being
818 truncated. Fixes projects.maemo.org bug NB#56126.
820 2007-06-02 Armin Burgmeier <armin@openismus.com>
822 * src/maemo/modest-connection-specific-smtp-window.c: Add an
823 introductory note to the connection specific smtp servers dialog, as
824 section 8.12 of the email UI specification requires. This fixes
825 projects.maemo.org bug NB#59212.
827 2007-06-01 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
830 Check for running mail operations, and offer to cancel them, as per the UI
831 spec. This fixes projects.maemo.org bug NB#59041 .
832 However, I suspect that tinymail may still use the network connection
833 in ways that we cannot detect or cancel. But it should at least adapt to
836 2007-06-01 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-tny-account-store.c: (recreate_all_accounts),
839 (get_cached_accounts), (get_server_accounts): Do more sensible
840 ref-counting of the temporarily-cached outbox accounts list. This seems
841 to fix a crash when entering the password when the password was wrong.
843 2007-06-01 Murray Cumming <murrayc@murrayc.com>
845 * src/gnome/modest-main-window.c: (connect_signals):
846 * src/modest-tny-account-store.c: (get_password),
847 (modest_tny_account_store_alert): Added comments and clues and
848 commented-out code about how we currently fail to deal with connection
849 errors and wrong passwords, and how we should.
851 2007-06-01 Murray Cumming <murrayc@murrayc.com>
853 * src/widgets/modest-retrieve-combo-box.c:
854 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
855 This fixes projects.maemo.org bug NB#58472 .
857 2007-06-01 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/easysetup/modest-easysetup-wizard.c:
860 (create_page_complete_easysetup):
861 (create_page_complete_custom): Correct the last commit,
862 putting the correct sentences in the correct pages.
864 2007-06-01 Murray Cumming <murrayc@murrayc.com>
866 * src/maemo/easysetup/modest-easysetup-wizard.c:
867 (create_page_complete_custom): Show the second sentence of text
868 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
871 2007-06-01 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
874 Set the leave-on-server conf key by default. This fixes
875 projects.maemo.org bug NB#59258 .
877 2007-06-01 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-account-view-window.c:
880 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
881 logical ID for the confirmation messages. Fixed projects.maemo.org bug
884 2007-06-01 Murray Cumming <murrayc@murrayc.com>
886 * src/maemo/easysetup/modest-easysetup-wizard.c:
887 (create_caption_new_with_asterisk):
888 * src/maemo/modest-account-settings-dialog.c:
889 (create_caption_new_with_asterisk):
890 Uncomment the code to add the asterisk, because they are no longer in the
891 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
892 (update_incoming_server_title): Add an asterisk here too.
894 2007-06-01 Murray Cumming <murrayc@murrayc.com>
896 * src/maemo/modest-maemo-global-settings-dialog.c:
897 (current_connection): Check that we are even connected before trying to
898 get the current connection name, to prevent a warning.
900 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
901 Change the comments because tny_maemo_conic_device_connect() is now meant to
903 * src/modest-mail-operation.c:
904 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
905 make sure we have a connection and fail if we can't connect.
907 2007-05-31 Murray Cumming <murrayc@murrayc.com>
909 * src/maemo/modest-main-window.c:
910 (on_account_store_connecting_finished): Do not try to get the
911 connection ID if we are not really connected. I am surprised that
912 this signal handler is called when we are not connected.
914 2007-05-31 Murray Cumming <murrayc@murrayc.com>
916 * src/modest-error.h:
917 * src/modest-ui-actions.c:
918 (modest_ui_actions_get_msgs_full_error_handler):
919 Renamed an enum, added comments, added an enum
920 for retrieve-limit errors.
922 * src/modest-mail-operation.c: (foreach_add_item),
923 (internal_folder_observer_update), (update_account_thread),
924 (modest_mail_operation_get_msgs_full):
925 (modest_mail_operation_update_account),
926 Added comments about how this works, and some code that should
927 (but does not) check the retrieve-limit. See the TODO comment.
929 2007-05-31 Murray Cumming <murrayc@murrayc.com>
931 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
932 Initialize help_id to fix the build. Warnings are good.
934 2007-05-31 Murray Cumming <murrayc@murrayc.com>
936 * src/widgets/modest-hbox-cell-renderer.c:
937 (modest_hbox_cell_renderer_append):
938 * src/widgets/modest-vbox-cell-renderer.c:
939 (modest_vbox_cell_renderer_append):
940 Fix the last commit by doing an extra ref.
942 2007-05-31 Murray Cumming <murrayc@murrayc.com>
944 * src/widgets/modest-hbox-cell-renderer.c:
945 (modest_hbox_cell_renderer_append):
946 * src/widgets/modest-vbox-cell-renderer.c:
947 (modest_vbox_cell_renderer_append):
948 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
949 to fix the build with Maemo Bora.
950 However, there seems to be a remaining crash, probably due to reference
953 2007-05-30 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-tny-account.c:
956 (modest_tny_account_new_for_local_folders):
957 Use hildon_file_system_info_async_new() to get a better name for
958 the memory card account, setting it as the account name.
959 The timing seems to work, but this is probably
960 not the best place to do this. See the TODO comment.
961 * src/maemo/modest-main-window.c: (create_details_widget):
962 * src/widgets/modest-folder-view.c: (text_cell_data):
963 Use the tny account name instead of hardcoding a name.
965 2007-05-30 Christian Kellner <ckellner@openismus.com>
967 * src/modest-search.c: (modest_search):
968 Correctly set part_search_func even if we have already parsed
969 the query and thus a valid OgsTextSearcher object.
971 2007-05-30 Christian Kellner <ckellner@openismus.com>
974 Search and check for libogs.
977 Incooparte the ogs build env.
979 * src/modest-mime-part-search-stream.c:
980 * src/modest-mime-part-search-stream.h:
981 Removed since we do the real searching now in modest-search.c.
983 * src/modest-search.c:
984 * src/modest-search.h:
985 Implement support for ogs. We use that if available and requested
986 and fall back to modest_text_utils_utf8_strcmp (). The search logic
987 should now handle the corner case when the search term is spread
988 across multiple reads.
989 Also the logic in modest_search () was corrected to search all
990 requested fields until one is found.
992 2007-05-30 Murray Cumming <murrayc@murrayc.com>
994 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
997 * src/modest-init.c: Made modest_init_local_folders() take a
998 path and be public so we can iniitialize maildir folders on
1001 * src/modest-local-folder-info.h:
1002 * src/modest-local-folder-info.c:
1003 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1005 * src/modest-tny-account.c:
1006 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1007 still means the standard local-folders path on the local volume.
1009 * src/modest-tny-account-store.c:
1010 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1011 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1012 all accounts when that happens.
1013 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1014 this too, so it shows up in the treeview.
1016 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1018 * src/maemo/modest-maemo-global-settings-dialog.c:
1019 (current_connection):
1020 * src/widgets/modest-global-settings-dialog.c:
1021 (current_connection_default):
1022 Use the enum values instead of 0, 1 and -1,
1023 to make the code clearer.
1025 * src/modest-account-mgr-helpers.c:
1026 (modest_account_mgr_get_connection_specific_smtp): Make this code
1029 * src/modest-runtime.h:
1030 * src/modest-runtime.c:
1031 Added modest_runtime_remove_all_send_queues().
1032 * src/maemo/modest-main-window.c:
1033 (on_account_store_connecting_finished): Recreate the send queues,
1034 using the appropriate transport accounts for this new connection.
1035 Some futher adapting might be needed if the old send queues are not
1036 automatically stopped at this point.
1038 * src/modest-tny-account-store.c: (get_server_accounts):
1039 Create the connection-specific transport accounts, so that they can
1040 be found later by their ID.
1042 * src/modest-tny-account.h:
1043 * src/modest-tny-account.c:
1044 Added modest_tny_account_new_from_server_account_name().
1045 modest_tny_account_new_from_server_account(): Do not create the
1046 send queues here, because they will be
1047 recreated anyway when the connection changes for the first time.
1049 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1051 * src/modest-local-folder-info.h:
1052 * src/modest-local-folder-info.c:
1053 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1054 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1055 tbox_folder): Take a modest account name instead of a server TnyAccount,
1056 so we can have per-modest-account rather than per-transport-account
1058 We must make sure that we change or recreate the exisitng send queues
1059 when the connection changes for connection-specific transport accounts.
1061 * src/modest-tny-account-store.c:
1062 (create_per_account_local_outbox_folders): Create outboxed per modest
1063 account, not per transport account.
1065 * src/modest-tny-account.h:
1066 * src/modest-tny-account.c:
1067 (modest_tny_account_get_special_folder): For outboxes, get the
1068 parent modest account name. The account is ignored for other folders.
1069 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1070 modest account name rather than a server TnyAccount.
1072 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1074 * src/modest-tny-account.c:
1075 (modest_tny_account_new_from_server_account):
1076 Call modest_runtime_get_send_queue() immediately after creating transport
1077 accounts, so that they start trying to send email from the outbox as soon
1078 as possible at startup. This is probably what we want.
1080 * src/modest-mail-operation.c: (update_account_thread):
1081 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1082 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1083 * src/modest-tny-send-queue.h:
1084 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1085 (modest_ui_actions_on_send):
1086 Added comments about how sending works, though it needs some more work.
1088 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1090 * src/modest-tny-account.c:
1091 (modest_tny_account_get_special_folder): Add TODO because this fails when
1092 the network is busy.
1093 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1094 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1095 Do not try to show this window when there is no active account. The UI
1096 specs does not tell us what to do in this case.
1098 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1102 * src/maemo/Makefile.am:
1103 * src/widgets/Makefile.am: Some dist fixes.
1105 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1107 * src/maemo/modest-connection-specific-smtp-window.c:
1108 (on_button_edit): Make the code clearer, to prevent a double free.
1110 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1112 * src/maemo/modest-account-settings-dialog.c:
1113 (modest_account_settings_dialog_set_account_name),
1114 Check the connection-specific smtp servers checkbox if there are any.
1116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1117 (modest_connection_specific_smtp_edit_window_init):
1118 Start with a suitable port number.
1120 * src/modest-account-mgr-helpers.h:
1121 * src/modest-account-mgr-helpers.c: Added
1122 modest_account_mgr_get_has_connection_specific_smtp().
1124 (modest_account_mgr_set_connection_specific_smtp),
1125 (modest_account_mgr_remove_connection_specific_smtp),
1126 (modest_account_mgr_get_has_connection_specific_smtp),
1127 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1128 connection-specific smtp server accounts in the account, rather than
1129 the server account conf dir.
1131 This fixes bug projects.maemo.org bug NB#58263 .
1133 * src/modest-tny-account-store.c:
1134 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1135 if there are no server accounts yet, to prevent an infinite loop when there
1136 are no accounts. Document that one must be called before the other.
1138 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1140 * src/modest-account-mgr-helpers.c:
1141 (modest_account_mgr_get_default_account): Make sure that at least
1142 one account is always the default, if there are any enabled accounts.
1143 This is just a sanity check that shouldn't be necessary.
1145 * src/modest-account-mgr-priv.c:
1146 (_modest_account_mgr_account_from_key): Unescape the conf key to
1147 get the real account name. For instance, this is an issue if a space
1148 was in the account name, which can happen because the account name
1149 is generated from the display name.
1150 (_modest_account_mgr_get_account_keyname): Always escape the
1152 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1153 Unescape the conf keys to get the real account names.
1155 For instance, previously the is-default radio button in the accounts
1156 list was not checked for any accounts at first. This fixes that,
1157 and might fix several similar bugs.
1159 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1162 Removed some debug printfs.
1164 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1166 Modest on-disk outbox directories are now here, for instance:
1167 $HOME/.modest/outboxes/<account-id-1>/outbox
1168 $HOME/.modest/outboxes/<account-id-2>/outbox
1170 $HOME/.modest/local-folders/outbox
1171 so we can have a separate outbox for each account.
1172 But they are shown as one outbox in the GtkTreeView, by using a
1173 TnyMergeFolder in a ModestTnySimpleFolderStore.
1176 * src/modest-tny-simple-folder-store.c:
1177 * src/modest-tny-simple-folder-store.h:
1178 Added ModestTnySimpleFolderStore, used to contain folders from
1179 other folder stores, such as other accounts.
1181 * src/modest-tny-outbox-account.h:
1182 * src/modest-tny-outbox-account.c:
1183 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1184 used for the per-account local outbox folders.
1186 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1187 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1188 only use this (internally) now for the non-outbox local folders.
1190 * src/modest-init.h:
1191 * src/modest-init.c: Added modest_init_one_local_folder(), for
1192 setting up the directory structure for each local folder.
1194 * src/modest-local-folder-info.c:
1195 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1196 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1198 * src/modest-local-folder-info.h:
1199 * src/modest-tny-account-store.c: (on_account_removed),
1200 (on_account_changed), (create_per_account_local_outbox_folders),
1201 (get_server_accounts), (modest_tny_account_store_get_accounts),
1202 (modest_tny_account_store_get_tny_account_by_account),
1203 (modest_tny_folder_store_is_virtual_local_folders):
1205 * src/modest-tny-account.h:
1206 * src/modest-tny-account.c:
1207 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1208 to create an on-disk per-account local outbox folder for each
1210 (create_per_account_local_outbox_folders): Create a local outbox folder
1211 for each transport account.
1212 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1213 for all local folders.
1215 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1216 instead of using g_object_get/set() directly. It is clearer.
1218 (modest_tny_folder_store_get_message_count),
1219 (modest_tny_folder_store_get_local_size
1220 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1221 because we now use these with non-acount folder stores.
1223 (modest_tny_account_get_special_folder),
1224 (modest_tny_account_new_from_server_account),
1225 (modest_tny_account_new_from_account):
1226 (recurse_folders): Adjust to the new outbox system.
1228 * src/modest-tny-folder.h:
1229 * src/modest-tny-folder.c:
1230 (modest_tny_folder_is_local_folder),
1231 (modest_tny_folder_get_local_folder_type),
1232 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1234 * src/widgets/modest-main-window.h:
1235 * src/maemo/modest-main-window.c: (create_details_widget),
1236 (modest_main_window_set_contents_style): Show details for any folder store,
1239 (modest_tny_folder_get_rules):
1240 Remove the const. C does not support constness enough for this.
1242 * src/modest-ui-actions.c:
1243 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1244 make all outboxes appear as one, in the usual local-folders tree node.
1246 (set_active_account_from_tny_account),
1247 (modest_ui_actions_on_folder_selection_changed):
1248 * src/widgets/modest-folder-view.c: (text_cell_data),
1249 (icon_cell_data), (filter_row),
1250 (add_account_folders_to_merged_folder),
1251 (add_account_folders_to_simple_folder_store), (),
1252 (get_cmp_rows_type_pos), (cmp_rows),
1253 (modest_folder_view_set_account_id_of_visible_server_account):
1254 Adjust to the new outbox system, using generic folder stores and folders
1255 in the GtkTreeModel.
1257 2007-05-23 Christian Kellner <ckellner@openismus.com>
1259 * src/modest-mail-operation.c:
1260 (modest_mail_operation_update_account):
1261 Use info->max_size instead of unintialized local var [small
1262 build fix]. (Added TODO to review that change since I don't
1265 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1267 * libmodest-dbus-client/libmodest-dbus-client.c:
1268 (libmodest_dbus_client_compose_mail): function added
1269 * src/dbus_api/modest-dbus-api.h:
1270 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1271 (on_compose_mail): Implementation of the SendAsMail functionality
1273 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1275 * src/modest-account-mgr.c:
1276 (modest_account_mgr_add_server_account): Set the secure-connection
1277 conf key for transport accounts as well as store accounts. I don't know
1278 why the if was there. For instance, this makes sure that we use SSL
1279 for the gmail preset from the easysetup wizard.
1281 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1283 * src/gnome/modest-main-window.c:
1284 (on_account_store_connecting_finished), (connect_signals):
1285 * src/maemo/modest-main-window.c:
1286 (on_account_store_connecting_finished), (connect_signals),
1287 (modest_main_window_new):
1288 Handle TnyAccountStore::connecting-finished instead of
1289 TnyDevice::connection-changed, because we cannot actually perform
1290 operations on accounts until TnyAccountStore has itself responded to
1291 the TnyDevice::connection-changed signal. This prevents a GError from
1293 Do not try to update at startup, because we (at least on scratchbox)
1294 already do an update at startup when the device goes online.
1295 This prevents a GError from tinymail.
1296 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1297 Added TODO about stopping simultaneous operations.
1299 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1301 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1302 * src/modest-mail-operation-queue.c:
1303 (modest_mail_operation_queue_remove):
1304 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1305 about where they happened.
1307 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1309 * src/modest-ui-actions.c:
1310 (modest_ui_actions_on_password_requested): Make sure that the remember
1311 output parameter is always TRUE.
1313 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1315 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1316 Show a OK/Cancel dialog if the error is a question, though we still do not
1317 know anything more about what we are asking the user.
1318 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1319 Fix an uninitialized variable (helper). This is a logic error, however.
1321 2007-05-21 Christian Kellner <ckellner@openismus.com>
1323 * src/modest-search.h:
1324 Correct bit shifting in the ModestSearchFlags enum.
1326 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1328 * src/modest-tny-account.c:
1329 (modest_tny_account_new_from_server_account): Do not use the lsub and
1330 check-all hard-coded IMAP options when using POP.
1332 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1334 * src/modest-tny-account.c:
1335 (modest_tny_account_new_from_server_account):
1336 Use NULL for the secure-auth method for POP when Password auth has been
1337 specified by the user, as we already do for IMAP. "auth=Login" causes
1338 an error from camel or the server.
1340 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1342 * src/maemo/modest-account-settings-dialog.c:
1343 (create_page_account_details),
1344 (modest_account_settings_dialog_set_account_name):
1345 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1346 for the leave-on-server checkbox, rathr than just the checkbox, when
1347 the protocol is not POP.
1349 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1351 * src/widgets/modest-account-view.c:
1352 * src/widgets/modest-account-view.h:
1353 Added modest_account_view_select_account() which will be useful later
1354 to asynchronously re-select the edited account.
1356 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1358 * src/maemo/modest-account-settings-dialog.c:
1359 (modest_account_settings_dialog_set_account_name):
1360 Automatically choose the port numbers based on the secure authentication
1361 methods, if they have not been chosen before.
1362 This fixes projects.maemo.org bug NB#56273 .
1364 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1366 * src/maemo/modest-main-window-ui.h:
1367 * src/modest-ui-actions.c:
1368 * src/modest-ui-actions.h:
1369 Connect the Tools/SMTP Servers menu item to
1370 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1371 SMTP servers dialog, as in the UI specification and saves changes when it
1372 is closed. This fixed projects.maemo.org bug NB#56305 .
1374 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/modest-connection-specific-smtp-window.c:
1377 (modest_connection_specific_smtp_window_init):
1378 Use gtk_window_set_default_size() to make this window big enough, so
1379 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1381 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1383 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1384 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1385 (modest_connection_specific_smtp_edit_window_init),
1386 Do not try to connect to a combobox signal before the combobox exists.
1387 This fixes the cras in projects.maemo.org bug NB#56288 .
1388 (modest_connection_specific_smtp_edit_window_get_settings):
1389 Remove the server_account_name parameter which was being checked for NULL
1390 though it was not used.
1392 * src/maemo/modest-connection-specific-smtp-window.c:
1393 (modest_connection_specific_smtp_window_fill_with_connections),
1394 (on_button_edit), (modest_connection_specific_smtp_window_init):
1395 Correct the number of treemodel columns to prevent a warning.
1396 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1397 libconic does not work.
1399 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-tny-account.c:
1402 (modest_tny_account_new_from_server_account):
1403 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1404 SMTP when "None" was chosen by the user. However, with my SMTP server that
1405 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1408 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1410 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1411 to explain the memory management issue with the ID in the ModestPair.
1413 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1414 (add_sending_page), (modest_account_assistant_finalize):
1415 * src/gnome/modest-gnome-global-settings-dialog.c:
1416 (create_updating_page), (create_composing_page):
1417 * src/gnome/modest-msg-edit-window.c: (get_transports),
1418 (init_window), (modest_msg_edit_window_finalize),
1419 (modest_msg_edit_window_get_msg_data):
1420 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1421 * src/gnome/modest-transport-widget.c:
1422 (modest_transport_widget_finalize), (smtp_configuration):
1423 * src/maemo/modest-maemo-global-settings-dialog.c:
1424 (create_updating_page), (create_composing_page):
1425 * src/maemo/modest-msg-edit-window.c: (get_transports),
1426 (init_window), (modest_msg_edit_window_finalize),
1427 (modest_msg_edit_window_get_msg_data),
1428 (modest_msg_edit_window_free_msg_data):
1429 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1430 (modest_store_widget_finalize):
1431 * src/maemo/modest-transport-widget.c:
1432 (modest_transport_widget_finalize), (smtp_configuration):
1433 * src/modest-main.c: (send_mail):
1434 * src/widgets/modest-combo-box.h:
1435 * src/widgets/modest-global-settings-dialog-priv.h:
1436 * src/widgets/modest-global-settings-dialog.c:
1437 (modest_global_settings_dialog_finalize):
1438 * src/widgets/modest-msg-edit-window.h:
1439 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1440 as long as the combo box, to prevent use of freed memory for the ID.
1442 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1444 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1445 get_accounts(), to make this clearer. Do not check for the enabled gconf
1446 key, because we do not use this for server accounts (at least, not yet).
1447 This allows us to send email again.
1449 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/modest-platform.c:
1452 (on_modest_conf_update_interval_changed), (modest_platform_init):
1453 Only respond to this particular key change. All these strcmp()s cannot be
1456 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1458 * src/maemo/modest-maemo-global-settings-dialog.c:
1459 (current_connection): Prevent a crash in scratchbox when
1460 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1461 * src/maemo/modest-platform.c:
1462 (on_modest_conf_update_interval_changed), (modest_platform_init):
1463 Get the update interval from gconf and reset it when the gconf key changes.
1465 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-protocol-info.c:
1468 * src/modest-protocol-info.h: Adde enum-specific get functions,
1469 instead of using a ModestProtocolType enum parameter.
1471 * src/gnome/modest-account-assistant.c:
1472 * src/gnome/modest-store-widget.c:
1473 * src/gnome/modest-store-widget.h:
1474 * src/gnome/modest-transport-widget.c:
1475 * src/gnome/modest-transport-widget.h:
1476 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1477 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1478 * src/maemo/easysetup/modest-easysetup-wizard.c:
1479 * src/maemo/modest-account-settings-dialog.c:
1480 * src/maemo/modest-account-settings-dialog.h:
1481 * src/maemo/modest-store-widget.c:
1482 * src/maemo/modest-store-widget.h:
1483 * src/maemo/modest-transport-widget.c:
1484 * src/maemo/modest-transport-widget.h:
1485 * src/modest-account-mgr-helpers.c:
1486 * src/modest-account-mgr-helpers.h:
1487 * src/modest-account-mgr.c:
1488 * src/modest-account-mgr.h:
1489 * src/modest-tny-account.c:
1490 * src/modest-tny-folder.c:
1491 * src/widgets/modest-account-view.c:
1492 * src/widgets/modest-retrieve-combo-box.c:
1493 * src/widgets/modest-retrieve-combo-box.h:
1494 * src/widgets/modest-secureauth-combo-box.c:
1495 * src/widgets/modest-serversecurity-combo-box.c:
1496 * src/widgets/modest-serversecurity-combo-box.h:
1497 * tests/check_account-mgr.c:
1498 Use the specific functions, and use the re-renamed enum values for GNOME too.
1500 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1502 * src/modest-pair.h:
1503 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1504 so we can get the second based on the first.
1506 * src/maemo/modest-account-settings-dialog.h:
1507 * src/maemo/modest-account-settings-dialog.c:
1508 Added get_supported_secure_authentication_methods(), though it is mostly
1509 commented-out for now until the necessary API is committed to tinymail.
1510 (modest_account_settings_dialog_set_account_name),
1511 (save_configuration): Request the supported authentication methods from the
1512 server, so we can choose a working method.
1514 * src/modest-tny-account-store.h:
1515 * src/modest-tny-account-store.c:
1516 (modest_tny_account_store_get_session): Rename from
1517 tny_account_store_get_session().
1519 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1521 * src/modest-protocol-info.h: Split the ModestProtocol enum
1522 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1523 There was no need to have these unrelated values in one enum.
1525 * src/: many files: Adapted to changed enum. This makes the code a bit
1526 clearer, and the compiler could catch some errors.
1528 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1530 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1531 Show the detailed internal camel error message when an error happens
1532 during the configuration, so that our testers can give us more clues.
1533 For instance, in projects.maemo.org bug NB#56910 .
1535 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1537 * src/modest-tny-account.c:
1538 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1539 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1541 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1543 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1544 * src/maemo/modest-account-settings-dialog.c:
1545 (modest_account_settings_dialog_set_account_name),
1546 (save_configuration): For the incoming secure authentication checkbox,
1547 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1548 the UI specification. PLAIN does not seem to be supported for most IMAP
1549 servers anyway, and I am not sure what it would mean.
1550 However, we probably need to discover which of the secure-authentication
1551 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1552 * src/modest-account-mgr-helpers.c:
1553 (modest_account_mgr_get_server_account_data):
1555 * src/modest-tny-account.c:
1556 (modest_tny_account_new_from_server_account):
1557 Use tny_account_set_mech() to set secure-authentication methods,
1558 with some special-casing for IMAP, based on my observations of how
1561 * src/modest-account-mgr-helpers.h:
1562 * src/modest-account-mgr.c:
1563 * src/modest-defs.h: Comment that the URI is only used for local folders.
1565 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1568 parameter const, just to be neat.
1569 * src/modest-text-utils.c: (modest_text_utils_inline):
1570 End g_strconcat() with NULL, as its documentation says. This is almost
1571 certainly the cause of my crash at startup on the device. Interestingly,
1572 valgrind doesn't tell us about these errors.
1574 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1576 * scripts/build-packages: Added more precise comments about how to use
1577 this script, though I still get this error:
1578 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1579 error building tinymail
1581 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1583 * src/maemo/modest-main-window.c: (on_account_update):
1584 Very slight cleanup, hoping to make it simpler to discover what causes
1585 a crash here sometimes.
1587 * src/modest-tny-account.c:
1588 (modest_tny_account_new_from_server_account): Set the port. Added
1589 comments about the options and a TODO comment because I need to find out
1590 how to specify the secure authentication method.
1592 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1594 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1595 changed CFlags paths form modest to libmodest
1597 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1599 * src/modest-account-mgr-helpers.c:
1600 (modest_account_mgr_get_server_account_data),
1601 (modest_account_mgr_free_server_account_data):
1602 * src/modest-account-mgr-helpers.h:
1603 * src/modest-account-mgr.c:
1604 (modest_account_mgr_add_server_account):
1605 * src/modest-defs.h:
1606 * src/modest-tny-account.c:
1607 (modest_tny_account_new_from_server_account):
1608 Determine the options for tny_camel_account_add_option() here,
1609 based on the settings, rather than storing them directly in gconf.
1611 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1613 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1614 Show a more friendly error dialog now that we expect (from the tinymail
1615 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1617 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1619 * src/maemo/modest-main-window.c: (on_account_update): Check that
1620 account_name is not NULL, to prevent a crash at startup that I am
1621 seeing on the N800. I do wonder why it is NULL.
1623 * src/maemo/easysetup/modest-easysetup-wizard.c:
1624 (create_page_user_details):
1625 * src/maemo/modest-account-settings-dialog.c:
1626 (create_page_user_details), (create_page_outgoing):
1627 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1628 (modest_connection_specific_smtp_edit_window_init):
1629 * src/modest-ui-actions.c:
1630 (modest_ui_actions_on_password_requested):
1631 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1632 might do something useful with the on-screen keyboard.
1634 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1636 * src/maemo/modest-main-window.c: (on_account_update):
1637 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1638 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1640 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1642 * src/modest-tny-account-store.c: (on_account_changed):
1643 Correct the signature of this signal handler.
1645 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1647 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1648 Show a HildonNote instead of a GtkDialog for Maemo.
1650 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1652 * src/widgets/modest-account-view.h:
1653 * src/widgets/modest-account-view.c: (on_account_changed),
1654 (on_account_removed). Added a boolean flag, set/unset by
1655 modest_account_view_block_conf_updates(),
1656 modest_account_view_unblock_conf_updates() to prevent unnecessary
1657 updates, but this is not very useful because the gconf notifications are
1658 so delays (maybe only on Maemo Bora).
1659 So auto-updating is turned off, and these functions do an explicit
1660 update when necessary.
1661 However, something else is still doing too much work when adding/removing
1662 accounts, probably in another part of the application.
1664 * src/maemo/modest-account-view-window.c:
1665 (on_delete_button_clicked), (on_edit_button_clicked),
1666 (on_new_button_clicked): Use the new functions.
1668 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1670 * src/modest-account-mgr-helpers.c:
1671 (modest_account_mgr_set_first_account_as_default):
1672 Sort the list of names alphabetically-by-title, so we choose the first one
1674 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1675 alphabetically by the title.
1677 This fixes projects.maemo.org bug NB#56418 .
1679 * src/modest-account-mgr-priv.c:
1680 (_modest_account_mgr_account_from_key):
1681 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1682 avoid a valgrind error, and possible random behaviour.
1684 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1686 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1687 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1688 tinymail documentation to say that this can be expected.
1689 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1690 pretty, and should not happen, but I would prefer to know when it does.
1692 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1694 * configure.ac: When using the older hildon version, probably on Bora,
1695 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1697 * src/widgets/modest-attachment-view.c:
1698 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1701 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1703 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1704 Implemented the prototype. Can be tested with
1705 tests/dbus_api/test_open_message:
1707 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1709 * src/modest-tny-account-store.c:
1710 (modest_tny_account_store_instance_init), (get_password):
1711 * src/modest-ui-actions.c:
1712 (modest_ui_actions_on_password_requested):
1713 Do not store the password in gconf, because this function is called
1714 for non-remembered passwords. Actually use the cached (in the hash map)
1715 password instead of releasing it.
1716 The password will now not be remembered if it is asked via the protected
1717 password dialog, as per the UI spec.
1719 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1721 * src/modest-defs.h:
1722 * src/modest-account-mgr-helpers.h:
1723 * src/modest-account-mgr-helpers.c:
1724 Added modest_server_account_get_username_has_succeeded(),
1725 modest_server_account_set_username_has_succeeded().
1726 (modest_server_account_set_username),
1727 Reset the has-succeeded flag if the username changes.
1729 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1730 * src/maemo/modest-connection-specific-smtp-window.c:
1731 (modest_connection_specific_smtp_window_save_server_accounts):
1732 Use modest_server_account_set_username() instead of using
1733 modest_conf_set_string() directly, so that the has-succeeded flag is always
1736 * src/modest-ui-actions.c:
1737 (modest_ui_actions_on_password_requested): Dim the username entry if
1738 the username has ever worked, as per the UI spec.
1740 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1742 * src/modest-tny-account-store.c: (get_password):
1743 * src/modest-ui-actions.c:
1744 (modest_ui_actions_on_password_requested):
1745 Allow the username to be changed too, though there is more work to
1746 be done on exactly how this behaves.
1748 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1750 * src/modest-account-mgr-helpers.h:
1751 * src/modest-account-mgr-helpers.c:
1752 Added modest_account_mgr_get_display_name(),
1753 modest_server_account_get_username(),
1754 modest_server_account_set_username(),
1755 modest_server_account_set_password(),
1756 modest_server_account_get_hostname() functions so we do not need to
1757 use the conf API directly.
1759 * src/maemo/modest-main-window.c: (connect_signals):
1760 Actually connect ot the ModestAccountStore::request-password signal,
1761 so that we show the dialog when the password is requested by Tinymail,
1762 for isntance if it is empty.
1764 * src/modest-marshal.list:
1765 * src/modest-tny-account-store.c:
1766 (modest_tny_account_store_class_init), (get_password),
1767 (modest_tny_account_store_alert):
1768 * src/modest-tny-account-store.h:
1769 * src/modest-ui-actions.h:
1770 * src/modest-ui-actions.c:
1771 (modest_ui_actions_on_password_requested):
1772 Change the signal parameters, so it is obvious that we are providing
1773 the non human-readable server name, and receiving both the username
1774 and password, though changing of the username is not yet implemented.
1775 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1776 for the GNOME version.
1778 This should fix the projects.maemo.org bug NB#56209, though it does not
1779 work on Bora, because the gconf_client_get() for the password fails
1780 immediately after we save it with gconf_client_set().
1782 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1785 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1786 caused an undefined symbol error:
1787 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1789 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1791 * src/modest-tny-account-store.c:
1792 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1793 using a GError instead of a string message, so we can translate it in
1796 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1798 * src/maemo/modest-address-book.c:
1799 (modest_address_book_check_names):
1800 * src/maemo/modest-msg-view-window.c:
1801 (modest_msg_view_window_clipboard_owner_change):
1802 * src/modest-init.c: (modest_init_init_ui):
1803 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1804 (update_folders_cb), (modest_mail_operation_update_account):
1805 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1806 (modest_ui_actions_on_msg_attachment_clicked),
1807 (modest_ui_actions_on_msg_recpt_activated):
1808 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1809 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1810 (modest_msg_view_search_next):
1811 * src/widgets/modest-recpt-editor.c:
1812 (modest_recpt_editor_on_button_release_event),
1813 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1814 g_message(). At this point we should only be seeing interesting errors on
1815 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1817 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1819 (modest_wizard_dialog_force_title_update):
1820 * src/maemo/easysetup/modest-wizard-dialog.h:
1821 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1822 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1823 can update the title when appropriate. Otherwise the title is wrong if the
1824 pages are added after adding the notebook to the dialog.
1825 This must be a problem in HildonWizardDialog too.
1826 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1828 * src/maemo/easysetup/modest-easysetup-wizard.c:
1829 (create_subsequent_customsetup_pages),
1830 (create_subsequent_easysetup_pages):
1831 Call modest_wizard_dialog_force_title_update() so that the title is
1832 correct even with GTK+ < 2.10.
1833 This fixes projects.maemo.org bug NB#56145 .
1835 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1837 * src/maemo/modest-platform.c:
1838 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1839 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1842 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1844 * src/widgets/modest-window.h:
1845 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1846 and modest_window_save_state(), which invokes it.
1848 * src/widgets/modest-window-mgr.h:
1849 * src/widgets/modest-window-mgr.c:
1850 Added modest_window_mgr_save_state_for_all_windows(), which calls
1851 the save_state vfunc on all registered windows, if implemented.
1853 * src/gnome/modest-msg-edit-window.c:
1854 * src/gnome/modest-msg-view-window.c:
1855 * src/maemo/modest-msg-edit-window.c:
1856 * src/maemo/modest-msg-view-window.c:
1857 * src/maemo/modest-main-window.c:
1858 Specify the existing save_settings functions as implementations of
1859 ModestWindow::save_state_func().
1861 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1862 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1863 enabling hibernation, for instance.
1865 We may need to do the same thing for restoring settings.
1868 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1870 * src/widgets/modest-window-mgr.c:
1871 * src/widgets/modest-window-mgr.h:
1872 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1873 modest_window_mgr_get_hibernation_is_prevented().
1875 * src/maemo/modest-main-window.c:
1876 (on_hildon_program_is_topmost_notify): Prevent hibernation
1877 (possible when the application goes to the background in the WM),
1878 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1880 * src/maemo/easysetup/modest-easysetup-wizard.c:
1881 (modest_easysetup_wizard_dialog_init):
1882 * src/maemo/modest-account-settings-dialog.c:
1883 (modest_account_settings_dialog_init):
1884 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1885 (modest_connection_specific_smtp_edit_window_init):
1886 * src/maemo/modest-connection-specific-smtp-window.c:
1887 (modest_connection_specific_smtp_window_init):
1888 * src/maemo/modest-signature-editor-dialog.c:
1889 (modest_signature_editor_dialog_init):
1890 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1891 prevent hibernation while any of these account settings dialogs are open.
1893 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1895 * src/maemo/Makefile.am:
1896 * src/maemo/modest-osso-state-saving.c:
1897 * src/maemo/modest-osso-state-saving.h: Added
1898 modest_osso_load_state() and modest_osso_save_state() though they do
1899 nothing now. They should iterate through all the open windows and load/save
1901 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1902 save state when closing.
1904 * src/maemo/modest-main-window.c:
1905 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1906 Add a notification handler for the HildonProgram::is-topmost property,
1907 so we can allow hibernation when the application goes into the background.
1908 But we still need to detect when the accounts setup windows are open so
1909 we can stop hibernation when they are open.
1910 To do this, I also added the main window the HildonProgram. This might have
1911 other side-effects/benefits, and should maybe be done for other windows.
1913 * src/maemo/modest-osso-autosave-callbacks.h:
1914 * src/maemo/modest-osso-autosave-callbacks.c:
1915 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1916 though it does not do anything yet, and we might never need this to do
1917 anything. For instance, we already save drafts.
1919 * src/maemo/modest-platform.c: (modest_platform_init):
1920 Specify the libosso auto-save callback.
1922 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1924 * src/maemo/modest-platform.c:
1925 (modest_platform_set_update_interval):
1926 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1927 aparently stays valid between application instances, so we can use this
1928 to remove and reset it later. According to a maemo-developers email from
1931 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1933 * configure.ac: Depend on libalarm for Maemo.
1935 * src/dbus_api/modest-dbus-api.h:
1936 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1937 (on_send_receive), (modest_dbus_req_handler):
1938 Handle a SEND_RECEIVE D-Bus method.
1940 * libmodest-dbus-client/libmodest-dbus-client.c:
1941 (libmodest_dbus_client_send_and_receive):
1942 * libmodest-dbus-client/libmodest-dbus-client.h:
1943 Add C convenience functions for calling the new D-Bus method.
1945 * src/modest-platform.h:
1946 * src/gnome/modest-platform.c:
1947 * src/maemo/modest-platform.c:
1948 Added modest_platform_set_update_interval(), which uses the
1949 alarmd API on Maemo.
1950 (modest_platform_init),
1951 Call modest_platform_set_update_interval(), using a hard-coded
1952 interval for now (until the global settings dialog is implemented),
1953 though I am not sure that this makes sense yet.
1955 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1957 * src/dbus_api/modest-dbus-callbacks.c:
1958 (modest_osso_cb_hw_state_handler):
1959 * src/dbus_api/modest-dbus-callbacks.h:
1960 * src/maemo/modest-platform.c: (modest_platform_init):
1961 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1962 in case this has some effect on the ability for Maemo to ping the
1965 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1968 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1969 warning. It is probably a logic error, but I need to fix the build.
1971 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1973 * src/modest-account-mgr.h:
1974 * src/modest-account-mgr.c:
1975 (modest_account_mgr_account_names): Add a gboolean enabled_only
1976 parameter, so we can get lists of onlt the enabled accounts.
1978 (modest_account_mgr_add_account),,
1979 (modest_account_mgr_account_with_display_name_exists):
1980 * src/maemo/modest-msg-edit-window.c: (get_transports):
1981 * src/modest-account-mgr-helpers.c:
1982 (modest_account_mgr_set_first_account_as_default):
1983 * src/modest-init.c: (init_default_account_maybe):
1984 * src/modest-tny-account-store.c: (get_accounts):
1985 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1986 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1987 * tests/check_account-mgr.c: (START_TEST):
1988 Provide the extra parameter, as appropriate.
1990 * src/widgets/modest-account-view.c: (update_account_view):
1991 Do not show disabled accounts (meaning that there is no way to
1992 enable/disable accounts in the UI (the feature is not in our UI
1993 specification), so we can use this internally only to mark unfinished
1994 or temporary account data.
1996 * src/maemo/easysetup/modest-easysetup-wizard.c:
1997 (create_account): Add boolean enable parameter, so we can specify FALSE
1998 to create the temporary account.
1999 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2000 (on_before_next): When finishing, when there is a temporary account, just
2002 Also, use a timeout to delay the showing of the dialog until gconf is likely
2003 to return correct information, due to a maemo gconf bug that is fixed in
2004 osso 1.1, but not yet in Bora.
2005 However, the dialog stays on screen after it is destroyed.
2007 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2008 for invalid data when cancelling. Use a hildon note instead of a dialog
2009 to complain about invalid data. Do not show the account-saved note if the
2010 account is disabled (a temporary account that will not really be saved for use
2013 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2015 * src/modest-account-mgr-helpers.h:
2016 * src/modest-account-mgr-helpers.c:
2017 Added modest_account_mgr_unset_default_account(),
2018 Added modest_account_mgr_set_first_account_as_default().
2020 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2021 If it was the default account, unset the default account name.
2023 * src/maemo/modest-account-view-window.c:
2024 (on_delete_button_clicked): If it was the default account,
2025 set the first remaining account as the default instead.
2027 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2028 a NULL account or a NULL default account, to prevent a crash. This should
2029 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2032 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2034 * src/widgets/modest-recpt-editor.c:
2035 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2036 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2037 TODO comment for this. This fixes the build.
2039 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2040 be the best place for it. This will in future update all auto-update accounts,
2041 rather than just the current/default account, when that gconf key exists.
2042 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2043 if there are no accounts, before calling do_send_receive().
2044 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2046 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2047 * src/maemo/modest-main-window-ui.h:
2048 * src/maemo/modest-main-window.c: (on_connection_changed),
2049 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2050 directly, becaue the signal handler does more.
2052 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2054 * src/modest-account-mgr-helpers.c:
2055 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2056 for the case that the account does not exist.
2058 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2059 (equivalent to the modest account name) rather than the tinymail account name
2060 (equivalent to the modest account title - human readable) to get the account data.
2061 Check for null account data to prevent the crash, and add a TODO comment saying that
2062 this needs fixing because it is using the server account name instead of the account name.
2064 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2066 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2067 * src/maemo/modest-account-settings-dialog.c: (show_error),
2069 Use hildon_note_new_information() for informative and error messages,
2070 which seems to be expected for Maemo applications (no documentation that I know of
2071 says this). I am surprised that there is no distinction between info and error
2074 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2076 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2077 it is easy to find where this is used.
2079 * src/maemo/easysetup/modest-easysetup-wizard.c:
2080 (create_page_welcome), (create_page_account_details),
2081 (create_page_user_details), (create_page_complete_easysetup),
2082 (create_page_custom_incoming), (create_page_custom_outgoing),
2083 (create_page_complete_custom):
2084 * src/maemo/modest-account-settings-dialog.c:
2085 (create_page_account_details), (create_page_user_details),
2086 (create_page_incoming), (create_page_outgoing):
2087 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2088 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2089 (modest_connection_specific_smtp_edit_window_init):
2090 * src/maemo/modest-connection-specific-smtp-window.c:
2091 (modest_connection_specific_smtp_window_init):
2092 * src/maemo/modest-signature-editor-dialog.c:
2093 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2094 and scrolling policy as per the Email Application Layout Guide, if I have
2097 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2099 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2100 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2101 which were empty, because these vfuncs have been removed from TnyAccountStore.
2102 This fixes the build.
2104 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2106 * src/maemo/modest-main-window.c:
2107 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2108 showing/hiding it. Added TODO because it probably should not be NULL.
2109 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2110 because unnecessary g_warnings() make degugging difficult.
2112 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/modest-msg-edit-window.c:
2115 (modest_msg_edit_window_select_color),
2116 (modest_msg_edit_window_select_background_color): 2 const corrections and
2117 moving 2 #endifs before closing brackets, to fix the build.
2119 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2121 * src/maemo/easysetup/modest-easysetup-wizard.h:
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 (modest_easysetup_wizard_dialog_finalize),
2124 (on_button_edit_advanced_settings), (create_page_complete_custom),
2125 (on_response), (create_account):
2126 Implement the Advanced Settings edit button, by saving the account information,
2127 for the Advanded Settings dialog to use directly from gconf, and removing it
2128 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2129 Bug #5533 in the projects.maemo.org bugzilla.
2131 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2133 * src/maemo/modest-msg-view-window.c:
2134 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2135 when opening a message window.
2137 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2139 * src/maemo/easysetup/modest-easysetup-wizard.c:
2140 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2143 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2144 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2145 gconf settings. I probably added more checks than necessary, but that is safer.
2147 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2148 variable to fix the build, but this seems to be used when it is still NULL.
2150 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2152 * src/modest-platform.h:
2153 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2154 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2155 * src/modest-main.c: Implement this function so we can avoid using
2156 maemo-specific API from cross-platform code.
2158 * src/modest-tny-account-store.c:
2159 (get_smtp_specific_transport_account_for_open_connection):
2160 * src/modest-ui-actions.c: (check_for_connection),
2161 (modest_ui_actions_on_item_not_found):
2162 Use modest_platform_connect_and_wait() and put #idefs around other
2163 maemo-specific code, because only maemo currently has a way to
2164 identify connection names.
2166 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2168 * src/modest-tny-account-store.h:
2169 * src/modest-tny-account-store.c:
2170 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2171 the connection-specific SMTP server settings in the configuration.
2173 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2175 * src/maemo/modest-main-window.c: (on_connection_changed),
2177 * src/modest-main.c: (main), (start_ui), (send_mail):
2178 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2179 that is what is intended.
2181 * src/modest-ui-actions.c: (action_send), (action_receive),
2182 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2183 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2184 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2185 SMTP server is used when it is specified.
2187 (modest_ui_actions_on_send_receive):
2188 Check that a connection is open before proceeding.
2189 Receive and then send, instead of vice-versa, as per the specification.
2191 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2193 * src/modest-mail-operation.c:
2194 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2195 though I guess it should be something other than NULL.
2197 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2199 * src/maemo/easysetup/modest-easysetup-wizard.c:
2200 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2201 combo twice, to avoid an g_warning and to make it visible again.
2202 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2203 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2204 (already intended) dereference when detaching, because we then recreate the menu.
2205 But I am not sure why the warning was happening, and it is possible that this is a memory
2208 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2210 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2211 and uri_parse_mailto() utility functions.
2212 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2214 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2216 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2218 * src/dbus_api/modest-dbus-api.h:
2219 * src/dbus_api/modest-dbus-callbacks.c:
2220 Use an idle callback to execute the modest code in the application's own thread.
2221 Remove the helloworld example method.
2222 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2223 parsed, and the open-message method is not implemented because this is not yet implemented in
2225 * libmodest-dbus-client/libmodest-dbus-client.c:
2226 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2227 (libmodest_dbus_client_open_message):
2228 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2230 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2231 body without crashing.
2233 * tests/dbus_api/Makefile.am:
2234 * tests/dbus_api/test_mail_to.c:
2235 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2237 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2239 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2240 Added file to fix the build. Sorry.
2242 * src/dbus_api/Makefile.am:
2243 * src/dbus_api/modest-dbus-api.h:
2244 * src/dbus_api/modest-dbus-callbacks.h:
2245 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2246 (modest_dbus_req_handler):
2247 Put constants in a separate header so it can be reused by the
2248 client library, without duplication
2250 * libmodest-dbus-client/Makefile.am:
2251 * libmodest-dbus-client/libmodest-dbus-client.c:
2252 (libmodest_dbus_client_call_helloworld),
2253 (libmodfest_dbus_client_send_mail),
2254 (libmodfest_dbus_client_mailto),
2255 (libmodfest_dbus_client_open_message):
2256 * libmodest-dbus-client/libmodest-dbus-client.h:
2257 (Partly) Implement a send_mail D-Bus method.
2259 * tests/dbus_api/Makefile.am:
2260 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2261 the send_email D-Bus method.
2263 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2267 * libmodest-dbus-client/Makefile.am:
2268 * libmodest-dbus-client/libmodest-dbus-client.c:
2269 * libmodest-dbus-client/libmodest-dbus-client.h:
2270 * tests/dbus_api/Makefile.am:
2271 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2272 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2274 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2276 * src/maemo/easysetup/modest-easysetup-wizard.c:
2277 (create_page_account_details):
2278 * src/maemo/modest-account-settings-dialog.c:
2279 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2280 widgets, because this might not be the default in future versions of the Maemo GTK+.
2281 However, I can not not get capitalization to work even in a simple test case.
2283 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2285 * src/maemo/easysetup/modest-easysetup-wizard.c:
2286 (create_page_custom_incoming), (create_page_custom_outgoing):
2287 * src/maemo/modest-account-settings-dialog.c:
2288 (create_page_account_details), (create_page_incoming),
2289 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2290 instead of using gtk_check_button_with_label(), so they are aligned like the other
2291 widgets, as per the UI spec.
2293 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2295 * src/maemo/easysetup/modest-easysetup-wizard.c:
2296 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2297 * src/widgets/modest-validating-entry.c:
2298 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2299 Modest prefix instead of an EasySetup prefix.
2301 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2303 * src/widgets/modest-validating-entry.h:
2304 * src/widgets/modest-validating-entry.c: (on_insert_text),
2305 Added easysetup_validating_entry_set_max_func(), used to set a callback
2306 to call when the max number of characters is reached. GtkEntry has a max-length
2307 already but is silent about it.
2309 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2310 (create_page_account_details), (create_page_user_details),
2312 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2313 (create_page_account_details), (create_page_user_details),
2314 (create_page_outgoing):
2315 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2316 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2317 the UI spec, when the user tries to enter more than the max number of characters.
2319 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2321 * src/maemo/easysetup/modest-easysetup-wizard.c:
2322 (create_page_user_details), (create_page_custom_incoming),
2323 (create_page_custom_outgoing):
2324 * src/maemo/modest-account-settings-dialog.c:
2325 (create_page_user_details), (create_page_incoming),
2326 (create_page_outgoing):
2327 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2328 (modest_connection_specific_smtp_edit_window_init):
2329 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2330 not appropriate. Bad Maemo-specific defaults!.
2332 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2334 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2335 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2336 (modest_signature_editor_dialog_set_settings):
2337 Disable the label and textview when the checkbox is disabled, and use the
2338 specified (UI spec) default signature text.
2340 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2342 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2343 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2345 * src/modest-defs.h:
2346 * src/modest-account-mgr-helpers.h:
2347 * src/modest-account-mgr-helpers.c:
2348 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2350 * src/maemo/Makefile.am:
2351 * src/maemo/modest-signature-editor-dialog.c:
2352 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2355 * src/maemo/modest-account-settings-dialog.h:
2356 * src/maemo/modest-account-settings-dialog.c:
2357 (modest_account_settings_dialog_finalize), (on_button_signature),
2358 (save_configuration): Use the new dialog when the Edit button is pressed, and
2359 save the changes if necessary, as per the UI spec.
2361 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2363 * src/maemo/Makefile.am:
2364 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2365 based on maemo-develoers email from Dirk.
2367 * src/maemo/easysetup/modest-easysetup-wizard.c:
2368 (create_page_welcome), (create_page_account_details),
2369 (create_page_user_details), (create_page_complete_easysetup),
2370 (create_page_custom_incoming), (create_page_custom_outgoing),
2371 (create_page_complete_custom),
2372 (modest_easysetup_wizard_dialog_init):
2373 * src/maemo/modest-account-settings-dialog.c:
2374 (create_page_account_details), (create_page_user_details),
2375 (create_page_incoming), (create_page_outgoing),
2376 (modest_account_settings_dialog_init):
2377 * src/maemo/modest-connection-specific-smtp-window.c:
2378 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2380 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2382 * src/maemo/easysetup/modest-easysetup-wizard.c:
2383 (create_page_account_details), (create_page_custom_outgoing),
2384 (create_page_complete_custom):
2385 * src/maemo/modest-account-settings-dialog.c:
2386 (create_page_user_details), (create_page_incoming),
2387 (create_page_outgoing):
2388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2389 (modest_connection_specific_smtp_edit_window_init):
2390 Use the correct (UI spec) port min/max, and use horizontal separators,
2393 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2395 * src/maemo/easysetup/modest-easysetup-wizard.c:
2396 (set_default_custom_servernames):
2397 * src/maemo/modest-account-settings-dialog.c:
2398 (create_page_incoming), (on_combo_outgoing_security_changed),
2399 (on_combo_incoming_security_changed), (create_page_outgoing),
2400 (modest_account_settings_dialog_set_account_name),
2401 (save_configuration):
2402 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2403 (on_combo_security_changed),
2404 (modest_connection_specific_smtp_edit_window_init),
2405 (modest_connection_specific_smtp_edit_window_set_connection),
2406 (modest_connection_specific_smtp_edit_window_get_settings):
2407 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2410 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2413 * src/maemo/easysetup/modest-easysetup-wizard.c:
2414 (create_page_custom_outgoing), (create_page_complete_custom):
2415 * src/maemo/modest-account-settings-dialog.c:
2416 (create_page_user_details), (create_page_outgoing):
2417 * src/maemo/modest-account-view-window.c: (button_box_new):
2418 Use changed logical IDs as per the most recent UI spec:
2419 mcen_bd_emailsetup_edit -> mcen_bd_edit
2420 mcen_bd_emailsetup_delete -> mcen_bd_delete
2421 mcen_bd_emailsetup_close -> mcen_bd_close
2423 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2427 * src/dbus_api/Makefile.am:
2428 * src/dbus_api/modest-dbus-callbacks.c:
2429 * src/dbus_api/modest-dbus-callbacks.h:
2430 * src/maemo/modest-platform.c: (modest_platform_init):
2431 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2433 * tests/Makefile.am:
2434 * tests/dbus_api/Makefile.am:
2435 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2437 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2439 * src/maemo/modest-account-settings-dialog.c:
2440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2441 Removed unnecessary includes.
2443 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2445 * src/maemo/easysetup/modest-easysetup-wizard.c:
2446 * src/maemo/modest-account-settings-dialog.c:
2447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2448 * src/widgets/Makefile.am:
2449 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2450 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2451 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2452 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2453 * src/widgets/modest-secureauth-combo-box.c:
2454 * src/widgets/modest-secureauth-combo-box.h:
2455 * src/widgets/modest-serversecurity-combo-box.c:
2456 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2457 made the GObject names more consistent with the rest of the Modest code.
2459 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2461 * src/maemo/easysetup/Makefile.am:
2462 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2463 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2464 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2465 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2466 * src/maemo/easysetup/modest-easysetup-wizard.c:
2467 * src/maemo/easysetup/modest-validating-entry.c:
2468 * src/maemo/easysetup/modest-validating-entry.h:
2469 * src/maemo/modest-account-settings-dialog.c:
2470 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2471 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2472 widgets/ because they are used outside of easysetup too. After checking in,
2473 svn will allow me to rename them too.
2475 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2477 * src/gnome/modest-msg-edit-window.c:
2478 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2479 linker error, to fix the build on the GNOME platform.
2480 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2481 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2482 ifdefed out to avoid a warning.
2484 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2486 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2487 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2488 some alternative for GTK+ 2.6.
2490 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2492 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2494 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2495 specified for EmailAccountsDialog in UI spec.
2497 * src/maemo/easysetup/modest-easysetup-wizard.c:
2498 * src/maemo/easysetup/modest-easysetup-wizard.h:
2499 * src/maemo/modest-account-settings-dialog.c:
2500 * src/maemo/modest-account-settings-dialog.h:
2501 Reuse a member window widget for the connection-specific SMTP server accounts,
2502 so we can tell it to create/save the accounts only if we actually save changes.
2504 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2505 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2506 (modest_connection_specific_smtp_edit_window_get_settings):
2507 Return a struct instance for temporarily remembering the entered data.
2509 * src/maemo/modest-connection-specific-smtp-window.h:
2510 * src/maemo/modest-connection-specific-smtp-window.c:
2511 (modest_connection_specific_smtp_window_finalize),
2512 (modest_connection_specific_smtp_window_fill_with_connections),
2514 (modest_connection_specific_smtp_window_save_server_accounts),
2515 (update_model_server_names): Do not actually save data until asked,
2516 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2518 (on_selection_changed),
2519 (modest_connection_specific_smtp_window_init): Disable the edit
2520 button when nothing is selected.
2522 * src/modest-account-mgr-helpers.c:
2523 * src/modest-account-mgr-helpers.h:
2524 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2527 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2529 * src/modest-account-mgr-helpers.h:
2530 * src/modest-account-mgr-helpers.c:
2531 (modest_account_mgr_get_unused_account_name),
2532 (modest_account_mgr_get_unused_account_display_name): Added these
2533 utility functions, to avoid code duplication.
2535 * src/maemo/easysetup/modest-easysetup-wizard.c:
2536 (create_page_account_details), (create_account):
2537 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2538 (on_combo_security_changed),
2539 (modest_connection_specific_smtp_edit_window_init),
2540 (modest_connection_specific_smtp_edit_window_save_settings):
2541 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2542 * src/maemo/modest-connection-specific-smtp-window.c:
2543 (modest_connection_specific_smtp_window_finalize),
2544 (modest_connection_specific_smtp_window_fill_with_connections),
2545 (on_button_edit), (modest_connection_specific_smtp_window_init):
2546 * src/maemo/modest-connection-specific-smtp-window.h:
2547 Implementing saving of connection-specific server accounts.
2549 But I need to refactor this so we can save the data for each
2550 possible connection-specific account and only actually create the server accounts
2551 when the easysetup finished, or the OK button is pressed on the account settings
2554 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2556 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2557 (on_combo_security_changed):
2558 (modest_connection_specific_smtp_edit_window_init):
2559 Auto-fill the port number as in the account settings.
2561 (modest_connection_specific_smtp_edit_window_set_connection):
2562 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2563 * src/maemo/modest-connection-specific-smtp-window.c:
2564 (fill_with_connections), (on_button_edit),
2565 (modest_connection_specific_smtp_window_init):
2566 Turn the edit window into a dialog to simplify the code, and
2567 set a WM hint as in a GtkDialog, because only a popup can be on top of
2568 another window in Maemo, and popups usually have no WM decoration.
2570 * src/modest-defs.h:
2571 * src/modest-account-mgr-helpers.c:
2572 (modest_account_mgr_set_connection_specific_smtp),
2573 (modest_account_mgr_remove_connection_specific_smtp),
2574 (modest_account_mgr_get_connection_specific_smtp):
2575 * src/modest-account-mgr-helpers.h: Some functions to write the
2576 connection-specific SMTP server information. Not yet used.
2579 * src/widgets/modest-folder-view.c: (text_cell_data):
2580 Fix a warning about an uninitialized variable.
2581 (on_configuration_key_changed): Put an #ifdef around the use
2582 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2584 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2586 * src/maemo/modest-account-settings-dialog.h:
2587 * src/maemo/modest-account-settings-dialog.c:
2588 Added connect_for_modified() utility function to mark the new modified boolean.
2590 (create_page_account_details), (create_page_user_details),
2591 (create_page_incoming), (create_page_outgoing), (on_response),
2592 (modest_account_settings_dialog_init),
2593 (modest_account_settings_dialog_set_account_name):
2594 Only warn about unsaved changes when there are actually unsaved changes.
2596 * src/modest-account-mgr-helpers.c:
2597 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2598 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2599 to get the data from there in future.
2601 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2603 * src/modest-defs.h:
2605 * src/modest-account-mgr-helpers.h:
2606 * src/modest-account-mgr-helpers.c:
2607 Store the security account setting in a single conf key instead of using
2608 the options list, so that the list is left for just the to-be-removed camel hack,
2609 and because gconf_client_set_list() is failing for some reason.
2611 * src/modest-account-mgr.c:
2612 (modest_account_mgr_add_server_account):
2613 * src/maemo/modest-account-settings-dialog.c:
2614 (modest_account_settings_dialog_set_account_name),
2615 (save_configuration): Use the renamed functions.
2618 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2620 * src/widgets/Makefile.am:
2621 * src/widgets/modest-limit-retrieve-combo-box.c:
2622 * src/widgets/modest-limit-retrieve-combo-box.h:
2623 * src/widgets/modest-retrieve-combo-box.c:
2624 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2625 the account settings dialog.
2627 * src/modest-defs.h:
2628 * src/modest-account-mgr-helpers.h:
2629 * src/modest-account-mgr-helpers.c:
2630 (modest_server_account_get_option_secure_auth),
2631 (modest_server_account_set_option_secure_auth):
2632 * src/modest-account-mgr.c:
2633 (modest_account_mgr_add_server_account):
2634 Use the existing AUTH_MECH conf key for the secure-auth setting,
2635 instead of putting it in the list options, because this was actually used already.
2637 * src/maemo/modest-account-settings-dialog.c:
2638 (create_page_account_details),
2639 (modest_account_settings_dialog_set_account_name),
2640 (save_configuration):
2641 * src/maemo/modest-account-settings-dialog.h:
2642 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2643 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2645 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2647 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2648 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2649 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2651 * src/modest-defs.h:
2652 * src/maemo/modest-account-settings-dialog.c:
2653 (create_page_incoming), (on_combo_outgoing_security_changed),
2654 (on_combo_incoming_security_changed), (create_page_outgoing),
2655 (modest_account_settings_dialog_set_account_name),
2656 (save_configuration): Load/Save the port number, and change it when the
2657 security combo changes, to suitable defaults.
2659 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2661 * src/modest-account-mgr.c:
2662 (modest_account_mgr_add_server_account): Set the security and secure-auth
2663 options, and add a comment saying that the other camel-specific options should be
2666 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2670 * src/modest-tny-account-store.c: (account_list_free),
2671 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2672 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2675 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2677 * src/modest-protocol-info.c:
2678 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2679 is required by our UI spec. Maybe something in our implementation will use this eventually.
2680 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2681 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2682 instead of the previous 0 placeholder.
2684 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2685 secure-auth settings.
2686 * src/modest-account-mgr-helpers.h:
2687 * src/modest-account-mgr-helpers.c:
2688 (modest_server_account_data_get_option_secure_auth),
2689 (modest_server_account_set_option_secure_auth),
2690 (modest_server_account_data_get_option_security),
2691 (modest_server_account_set_option_security): Added this API for getting and setting the security
2692 and secure-auth settings.
2694 * src/maemo/modest-account-settings-dialog.h:
2695 * src/maemo/modest-account-settings-dialog.c:
2696 (modest_account_settings_dialog_finalize), (check_data),
2697 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2698 about changing titles.
2699 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2700 (save_configuration): Save the security and secure-auth settings.
2702 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2703 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2705 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2707 * src/modest-defs.h:
2708 * src/modest-account-mgr.c:
2709 (modest_account_mgr_add_server_account):
2710 Added and used defines for the options key and value pair strings,
2711 that are used so far, though they do not seem to correspond to anything in our
2712 UI specs or ModestProtocol enum.
2714 * src/modest-account-mgr-helpers.h:
2715 * src/modest-account-mgr-helpers.c:
2716 (compare_option_strings_for_name),
2717 (modest_server_account_data_get_option_value),
2718 (modest_server_account_data_get_option_bool),
2719 (modest_account_mgr_get_server_account_option):
2720 Added helper functions for parsing the options GSList.
2722 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2724 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2725 display name is based on the supplied account name.
2726 * src/modest-account-mgr.c:
2727 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2728 with an inefficient, but good-enough, implementation.
2730 * src/maemo/easysetup/modest-easysetup-wizard.c:
2731 (create_page_account_details), (on_before_next), (create_account):
2732 Check for existing display names rather than (non-user-visible) account names, and just
2733 create and set a unique account name at the end.
2735 * src/maemo/modest-account-settings-dialog.c:
2736 (modest_account_settings_dialog_init),
2737 (modest_account_settings_dialog_set_account_name),
2738 (create_page_incoming): Show the display name, instead of the account name.
2739 (on_response): Do some (not all) extra checks, as in the UI spec.
2740 (save_configuration): Save the display name if it was changed.
2742 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2744 * po/en_GB.po: Added needed logical ID and translation.
2745 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2746 (init_view): Made the is-default column clicking work.
2748 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2751 * src/maemo/easysetup/Makefile.am:
2752 * src/maemo/easysetup/modest-easysetup-wizard.c:
2753 (modest_easysetup_wizard_dialog_init):
2754 * src/maemo/easysetup/provider-data-test.keyfile:
2755 * src/maemo/easysetup/provider-data.keyfile:
2756 Moved the provider data file to the new modest-providers-data package and used it from there.
2758 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2760 * src/modest-local-folder-info.c:
2761 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2762 N_() was already used on the static strings, but this just marks it for translation without
2763 using the translation.
2765 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2767 * src/maemo/modest-account-settings-dialog.c:
2768 (create_page_incoming),
2769 (modest_account_settings_dialog_set_account_name):
2770 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2771 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2772 I will do this if nobody else gets there first.
2774 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2776 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2777 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2778 save the security stuff.
2780 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2782 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2783 Set the email address and user fullname, which I now see must be
2786 * src/maemo/modest-account-settings-dialog.h:
2787 * src/maemo/modest-account-settings-dialog.c:
2789 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2790 leave-on-server and authentication.
2791 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2794 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2797 * src/maemo/modest-account-settings-dialog.c:
2798 * src/maemo/modest-account-settings-dialog.h:
2799 Most (but not all) of the widgets are now present as specified by the UI spec.
2800 No changes are yet saved, and some details are not properly shown yet.
2802 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2804 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2806 * src/maemo/Makefile.am:
2807 * src/maemo/modest-account-settings-dialog.c:
2808 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2809 an existing account. Doesn't do much yet.
2811 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2812 Open the accounts settings dialog when Edit is clicked.
2814 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/easysetup/Makefile.am:
2817 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2819 * src/maemo/easysetup/modest-easysetup-wizard.c:
2820 (modest_easysetup_wizard_dialog_init):
2821 Try to get the source directory from the build system,
2822 instead of hard-coding "./" into the source code, when opening our local
2823 copies of the configuration files.
2824 But this still fails when opening the wizard from the Accounts window,
2825 maybe because the working directory seems to change at runtime.
2826 So the wizard will fail the second time unless you copy the files into their
2827 proper locations - see the stdout warnings for the paths.
2829 (create_page_account_details),(on_before_next):
2830 Check for existing non-server accounts instead of server accounts,
2831 so the default account name is useful again, and to prevent trying to
2834 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2835 Show the wizard when New is clicked.
2837 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2838 (init_view): Show the column headers, and show the columns that are
2839 specified in the UI specs. However, something in Maemo's GTK+ prevents
2840 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2841 change the default account. This is despite unsetting the special properties.
2843 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2845 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2846 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2847 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2848 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2849 to make that clearer.
2850 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2852 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2854 * src/maemo/modest-account-view-window.c:
2855 (modest_account_view_window_init),
2856 (modest_account_view_window_new):
2857 Use the same buttons as specified in the
2858 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2859 the existing widgets, which never had a chance of working.
2860 Put the ModestAccountView treeview in a scrolled window.
2861 Do not repeat the initialization in both _init() and _new().
2863 * src/widgets/modest-account-view.c: (update_account_view):
2864 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2865 this widget and window shows no accounts.
2867 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2869 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2871 * src/maemo/easysetup/modest-easysetup-wizard.c:
2872 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2873 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2874 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2877 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2878 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2879 accounts exist yet, as in the UI spec.
2881 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2883 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2885 * src/maemo/Makefile.am:
2886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2887 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2888 New window for editing connection-specific smtp details.
2889 Not fully implemented.
2891 * src/maemo/modest-connection-specific-smtp-window.c:
2892 (modest_connection_specific_smtp_window_finalize) :
2893 unref the tree model.
2894 (on_button_edit): Show the edit window.
2896 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2898 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2901 * src/maemo/Makefile.am:
2902 * src/maemo/modest-connection-specific-smtp-window.c:
2903 * src/maemo/modest-connection-specific-smtp-window.h:
2904 New window for showing the list of connections, for connection-specific
2905 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2906 * src/maemo/easysetup/modest-easysetup-wizard.c:
2907 (create_page_custom_outgoing): Show the new window when the button is clicked.
2909 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2911 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2912 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2913 * src/maemo/modest-msg-edit-window.c:
2914 (modest_msg_edit_window_insert_image):
2915 * src/modest-conf.c: (modest_conf_key_escape):
2916 * src/modest-mail-operation.c:
2917 (modest_mail_operation_send_new_mail):
2918 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2919 (modest_ui_actions_on_new_account):
2920 * src/widgets/modest-attachment-view.c: (update_filename_request):
2921 * src/widgets/modest-mail-header-view.c:
2922 Corrected warnings that were breaking the build, by commenting out unused variables,
2923 and a function, and by including a header.
2925 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2927 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2928 so we can #ifdef around platform-specific code when necessary.
2929 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2930 to allow this to build for the GNOME platform too.
2932 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2934 * src/maemo/easysetup/modest-easysetup-wizard.c:
2935 Added util_increment_name() and used it in create_page_account_details()
2936 to make sure that the default account name is always a new name.
2938 (modest_easysetup_wizard_dialog_init),
2939 (set_default_custom_servernames): Some minor memory management fixes.
2941 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2945 * src/modest-runtime.c: (init_i18n): Restored the translation
2946 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2947 are defined in config.h, and the translations are installed.
2949 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2950 is defined for translation.
2952 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2954 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2956 * src/maemo/easysetup/modest-easysetup-wizard.c:
2957 (modest_easysetup_wizard_dialog_init):
2958 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2959 Use realistic paths (though they should use $prefix generically) to the
2960 mcc_mapping and provider-data.keyfile files which might work when they
2961 are installed by the future version of the operator-wizard package,
2962 and then fallback to paths in our source code, with an explanatory
2965 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2969 * src/maemo/Makefile.am:
2970 * src/maemo/easysetup/: Added files from the previously-exernal
2971 osso-modest-easysetup.
2972 * src/maemo/modest-main-window-ui.h:
2973 * src/modest-ui-actions.c:
2974 * src/modest-ui-actions.h:
2975 Added modest_ui_actions_on_new_account() as a signal handler for the
2976 New Account menu item. It shows the easysetup wizard.
2977 * po/en_GB.po: Added additional needed logical IDs and translations.
2979 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2980 Apparently ChangeLog is not used for some vague Nokia legal reasons.