1 2007-06-26 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-tny-account-store.c:
4 * src/modest-tny-account-store.h:
5 Added modest_tny_account_is_memory_card_account().
6 * src/maemo/modest-main-window.c: (create_details_widget):
7 Show the same information items for the memory card as we show for the
8 local-folders, to fix projects.maemo.org bug NB#59307.
10 2007-06-26 Murray Cumming <murrayc@murrayc.com>
12 * src/modest-tny-account-store.c: (get_password):
13 Added some checks for NULL to maybe prevent crashes, though I think
14 it was Philip's last commit that actually prevented the crash here
15 when creating a first new account.
16 But the new account is still not usable (no messages are shown)
17 until a restart of the application.
19 2007-06-26 Murray Cumming <murrayc@murrayc.com>
21 * src/maemo/modest-maemo-global-settings-dialog.c:
22 (idle_select_default_focus):
23 * src/modest-mail-operation.c: (idle_notify_progress),
24 (idle_notify_progress_once), (idle_notify_update_account_queue),
25 (set_last_updated_idle), (update_account_thread),
26 (notify_get_msgs_full), (get_msgs_full_destroyer),
27 (get_msgs_full_thread):
28 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
29 * src/widgets/modest-header-view.c:
30 (idle_notify_headers_count_changed_destroy),
31 (idle_notify_headers_count_changed):
32 Use gdk_threads_enter() and gdk_threads_enter_leave() in
33 all idle handlers, because some other thread could be blocking
34 the GDK lock, so that it can do GUI stuff.
36 2007-06-26 Murray Cumming <murrayc@murrayc.com>
38 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
39 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
40 (on_idle_send_receive), (on_idle_open_default_inbox):
41 * src/maemo/modest-msg-edit-window.c:
42 (modest_msg_edit_window_attach_file_noninteractive):
43 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
44 to prevent a hang. I don't quite understand why these are necessary,
45 beause we should already be in the main loop. I guess something outside
46 of the main loop is taking the lock.
48 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
49 we are really using URIs, and use files that are more likely to exist.
51 2007-06-26 Murray Cumming <murrayc@murrayc.com>
53 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
54 necessary because configure.ac now defines different variables.
56 2007-06-26 Murray Cumming <murrayc@murrayc.com>
58 * libmodest-dbus-client/libmodest-dbus-client.c:
59 * libmodest-dbus-client/libmodest-dbus-client.h:
60 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
61 libmodest_dbus_client_compose_mail() is what things actually use.
63 * src/dbus_api/modest-dbus-api.h:
64 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
65 * tests/dbus_api/Makefile.am:
66 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
69 2007-06-26 Murray Cumming <murrayc@murrayc.com>
71 * src/modest-init.c: (modest_init_local_folders):
72 For memory-card (or other non local-folders) maildir accounts,
73 always create an Archive folder, so that there is somewhere to put
74 messages. This should be less confusing, because the user does not need
75 to guess that the need to create a folder.
77 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
79 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
80 Fixed icon size by using (50, 50) which is the same as defined by
83 2007-06-25 Armin Burgmeier <armin@openismus.com>
85 * src/widgets/modest-window-mgr.c:
87 * configure.ac: Correctly recognize hildon-notify presence and fixed
88 the build without it being installed.
90 2007-06-25 Murray Cumming <murrayc@murrayc.com>
92 * libmodest-dbus-client/libmodest-dbus-client.c:
93 (libmodest_dbus_client_search): Fix the build. Sorry.
94 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
95 (reply_forward_cb): Initialize variables to fix the build.
97 * src/modest-tny-account-store.c:
98 (modest_tny_account_store_get_tny_account_by): Fix the account URI
99 comparison (a silly typo) so that email search results can be opened
100 when there are more than one account.
102 2007-06-25 Murray Cumming <murrayc@murrayc.com>
104 * libmodest-dbus-client/libmodest-dbus-client.c:
105 (libmodest_dbus_client_search),
106 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
107 instead of 1 second, because the search gets folders and messages from
108 the server, which can take a long time. When it times out,
109 osso-global-search will report no results.
111 We need to specify whether we should search only cached information
112 (maybe with a user preference), and the osso-email-search-plugin
113 API should really be improved to allow that option, and to allow results
114 to be delivered asynchronously in batches.
116 2007-06-25 Murray Cumming <murrayc@murrayc.com>
118 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
119 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
120 GTK_ICON_SIZE_DIALOG is probably the wrong size.
122 2007-06-25 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
125 that is an empty string. D-Bus seems to give us these instead of NULL.
127 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
129 * src/dbus_api/modest-dbus-callbacks.c:
130 * src/maemo/easysetup/modest-easysetup-wizard.h:
131 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
132 * src/maemo/modest-connection-specific-smtp-edit-window.c:
133 (modest_connection_specific_smtp_edit_window_init):
134 * src/maemo/modest-maemo-global-settings-dialog.c:
136 * src/maemo/modest-maemo-utils.c:
137 (modest_maemo_utils_setup_images_filechooser):
138 * src/maemo/modest-main-window.c: (create_details_widget):
139 * src/maemo/modest-msg-edit-window.c:
140 (modest_msg_edit_window_attach_file_noninteractive),
141 (modest_msg_edit_window_color_button_change),
142 (modest_msg_edit_window_set_zoom):
143 * src/modest-mail-operation.c: (update_account_thread):
144 * src/modest-tny-account-store.c:
145 * src/modest-tny-account.c:
146 * src/widgets/modest-global-settings-dialog.c:
147 * src/widgets/modest-window.h:
151 2007-06-25 Murray Cumming <murrayc@murrayc.com>
153 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
154 * src/modest-search.c: (modest_search_folder),
155 (modest_search_all_accounts): Actually search only in the specified folder,
156 doing a simple match on the folder ID.
157 * src/modest-search.h: Added a folder field to the ModestSearch struct,
158 and added some documentation.
160 2007-06-22 Armin Burgmeier <armin@openismus.com>
162 * src/maemo/modest-maemo-utils.h:
163 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
164 modest_maemo_utils_get_supported_secure_authentication_methods.
166 * src/maemo/easysetup/modest-easysetup-wizard.c:
167 * src/maemo/modest-account-settings-dialog.c: Show correct error if
168 one occured, not just "Server does not support secure authentication".
170 2007-06-22 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account-store.c: (get_password):
173 Restored the call to tny_account_set_user() because Philip seems to have
174 stopped this from crashing (by not using the freed string). It still does
175 not work, but now we can test it.
177 2007-06-22 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/modest-msg-edit-window.c: (init_window):
180 Comment out use of an uninitialzed GtkScrolledWindow variable,
181 to fix the build and stop a crash. Yet again.
183 2007-06-22 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-tny-account-store.c: (get_password):
186 Remove the call to tny_account_set_user() because this actually crashes.
187 As mentioned in the last commit, it is known to not work anyway.
189 2007-06-22 Murray Cumming <murrayc@murrayc.com>
191 * src/modest-tny-account-store.c: (get_password):
192 Use tny_account_set_username() to tell tinymail that the username might
193 have changed too. But tinymail ignores this: see projects.maemo.org
195 * src/modest-ui-actions.c:
196 (modest_ui_actions_on_password_requested): Remove the useless attempt to
197 reset the connection when changing the username, and improve the comments.
198 Save the changed username to gconf at least, so it is used when Modest is
201 2007-06-21 Murray Cumming <murrayc@murrayc.com>
203 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
204 Do not use a query, so that we get all folders, including for POP and
205 local-folders. They work as search criteria too.
206 This fixes projects.maemo.org bug NB#57740.
208 2007-06-21 Murray Cumming <murrayc@murrayc.com>
210 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
211 Comment out the use of hildon_notification_set_sound() because it is
212 not declared, to fix the build. Warnings are serious, people.
214 2007-06-21 Armin Burgmeier <armin@openismus.com>
216 * src/maemo/modest-maemo-utils.h:
217 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
218 modest_maemo_utils_get_supported_secure_authentication_methods()
219 to query authentication methods for a specific user. This should fix
220 projects.maemo.org bug NB#61369.
222 * src/maemo/easysetup/modest-easysetup-wizard.c:
223 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
226 2007-06-21 Murray Cumming <murrayc@murrayc.com>
228 * libmodest-dbus-client/libmodest-dbus-client.h:
229 * libmodest-dbus-client/libmodest-dbus-client.c:
230 (modest_dbus_message_iter_get_search_hit),
231 (libmodest_dbus_client_search):
232 Reorganised and commented this.
233 Removed modest_search_hit_free() from the public API because it
236 Added libmodest_dbus_client_get_folders() and
237 modest_folder_result_list_free().
239 * src/dbus_api/modest-dbus-api.h:
240 * src/dbus_api/modest-dbus-callbacks.c:
241 (modest_dbus_req_filter): Commented. Moved most code to
242 on_dbus_method_search() and added on_dbus_method_get_folders().
244 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
245 of the extra D-Bus handler.
247 * tests/dbus_api/Makefile.am:
248 * tests/dbus_api/test_get_folders.c: New test for
249 libmodest_dbus_client_get_folders(). This seems to return an empty list
250 at the moment. That could be the same error that causes the message list
251 to be empty sometimes.
252 This should help with projects.maemo.org bug NB#57740.
254 2007-06-21 Armin Burgmeier <armin@openismus.com>
256 * src/modest-mail-operation.c: Do not call
257 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
258 notify the operation's end after having set the status to CANCELED for
259 the operation queue to listen on. This fixes a deadlock when there
260 were mail operations in the queue during its finalization.
262 * src/modest-singletons.c: Reordered uninitialization of the account
263 manager to happen after the mail operation queue was uninitialized
264 because the mail operation's in the queue might still try to access
265 the account manager (see modest_mail_operation_notify_end()). This
266 fixes a potential crash when terminating the application.
268 2007-06-21 Murray Cumming <murrayc@murrayc.com>
270 * src/modest-search.c:
271 (search_mime_part_and_child_parts): Moved some code here so we
272 can search recursively in child folders.
273 (modest_search_folder): Search in the message as a mime part, instead
274 of just its child mime parts.
275 (read_chunk), (search_mime_part_ogs):
276 Check how many bytes were read, to prevent an endless loop.
277 Searching in message bodies now works. This finishes the fix for
278 projects.maemo.org bug NB#61007.
280 2007-06-20 Murray Cumming <murrayc@murrayc.com>
282 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
283 Add a g_warning when the item is not a folder.
285 * src/modest-ui-dimming-rules.c:
286 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
287 when selected item is not a folder (for instance, an account), because
288 the UI spec only talks about folders.
289 I am not sure what the UI spec wants, so this might not totally fix
290 projects.maemo.org bug NB#60794.
292 2007-06-20 Murray Cumming <murrayc@murrayc.com>
294 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
295 (load_from_file): Sort the list. The unsorted list would be more noticeable
296 in non-English locales.
298 * src/maemo/modest-msg-edit-window.c:
299 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
300 warning and fix the build.
302 * src/maemo/modest-progress-bar-widget.c:
303 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
304 avoid a g_warning, and probably to avoid a crash.
306 2007-06-20 Murray Cumming <murrayc@murrayc.com>
308 * src/modest-search.c: (modest_search_folder): Check for a GError
309 when calling tny_folder_get_headers(), to show that this is not the cause
312 2007-06-20 Murray Cumming <murrayc@murrayc.com>
314 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
315 Actually set the body query instead of the subject query.
317 * src/modest-search.c: (search_mime_part_ogs),
318 (search_mime_part_strcmp): Remove extra space from the text/* regex,
319 which would probably cause it to fail if we got this far.
321 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
322 to simplify the code.
323 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
324 be causing search-in-body to fail.
326 2007-06-20 Murray Cumming <murrayc@murrayc.com>
328 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
330 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
331 Better debug message when the folder cannot be found.
332 This should help with fixing projects.maemo.org bug #61287.
333 * src/modest-search.c: (add_hit): Do not leak the furl string.
335 2007-06-20 Murray Cumming <murrayc@murrayc.com>
337 * src/modest-ui-actions.c:
338 (modest_ui_actions_on_folder_selection_changed):
339 Do not special-case TNY_MERGE_FOLDER here, because
340 modest_tny_folder_get_account() already does that. This fixes
341 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
342 shown when the Outbox was selected).
344 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
346 * libmodest-dbus-client/libmodest-dbus-client.c:
347 (_dbus_iter_get_string_or_null): Initialize the string variable in
348 case this helps with Dirk's crash.
350 2007-06-19 Murray Cumming <murrayc@murrayc.com>
352 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
353 though it is not implemented yet (this function is maybe not even used),
354 to avoid breaking ABI in future.
355 * libmodest-dbus-client/libmodest-dbus-client.c:
356 (get_attachments_string): Moved some code into this generic function.
357 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
358 sends email. It is maybe not used.
359 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
360 (on_send_mail): Use attachments.
362 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
363 * src/maemo/modest-msg-edit-window.c:
364 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
365 a filename before using it, to fix projects.maemo.org bug NB#58233.
367 2007-06-19 Murray Cumming <murrayc@murrayc.com>
369 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
370 Initialize the continue_download variable to fix the build, and probably
371 to fix randome behaviour.
373 2007-06-18 Armin Burgmeier <armin@openismus.com>
375 * src/modest-tny-send-queue.h:
376 * src/modest-tny-send-queue.c: Keep track of the status of messages in
377 the queue so we can later show it in the UI. Replaced
378 modest_tny_send_queue_msg_is_being_sent() by
379 modest_tny_send_queue_get_msg_status().
381 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
383 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
384 gpointer. This probably was not harmful, but just to be sure.
386 2007-06-18 Murray Cumming <murrayc@murrayc.com>
388 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
389 Fix the build, but leave the function broken on Bora, because
390 hildon_uri_action_get_service() does not exist.
391 osso_uri_action_get_service() does not exist either, it seems.
393 2007-06-18 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-tny-account.c:
396 (modest_tny_account_new_from_server_account):
397 Uncommented the url debug output again, because it is useful for
398 debugging, as I said in the comment.
400 2007-06-18 Murray Cumming <murrayc@murrayc.com>
402 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
404 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
405 for Mameo Bora, to fix the build.
407 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
410 Fixed build with hildon < 0.99
412 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
413 Check if the selected account is busy instead of checking all accounts
415 * src/modest-account-mgr-priv.h:
416 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
417 (modest_account_mgr_init), (compare_account_name),
418 (modest_account_mgr_set_account_busy),
419 (modest_account_mgr_account_is_busy):
420 * src/modest-account-mgr.h:
421 Added busy information to the account manager. It possible to
422 set an account to busy or not busy now.
424 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
425 (modest_mail_operation_update_account),
426 (modest_mail_operation_notify_end):
427 Set the account to busy/not busy depending on the operation state.
429 * src/widgets/modest-account-view.c:
430 (modest_account_view_finalize), (get_last_updated_string),
431 (update_account_view), (on_account_busy_changed), (init_view):
432 Show string "Refreshing..." if the account is currently busy.
434 All this fixes projects.maemo.org bug NB#59711
436 2007-06-14 Armin Burgmeier <armin@openismus.com>
438 * src/widgets/modest-attachments-view.h:
439 * src/widgets/modest-attachments-view.c: Added
440 modest_attachments_view_has_attachments() and fixed coordinate
441 transformation in get_att_view_at_coords(). This fixes attachment
444 * src/widgets/modest-msg-view.c: Make use of
445 modest_attachments_view_has_attachments() to decide whether to show
446 attachments in the header.
448 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
450 * src/maemo/modest-connection-specific-smtp-edit-window.c:
451 (on_change), (on_combo_security_changed),
452 (modest_connection_specific_smtp_edit_window_init),
453 (modest_connection_specific_smtp_edit_window_set_connection),
454 (modest_connection_specific_smtp_edit_window_is_dirty):
455 * src/maemo/modest-connection-specific-smtp-edit-window.h:
456 * src/maemo/modest-connection-specific-smtp-window.c:
459 Show an comfirmation dialog for the smpt-edit-window if there are
460 unsaved changes and the user hits cancel.
461 (projects.maemo.org bug NB#60479)
463 2007-06-14 Armin Burgmeier <armin@openismus.com>
465 * src/maemo/easysetup/modest-easysetup-wizard.c:
466 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
467 address" info in banner instead of node, and select all the text as
468 per UI spec. This fixes projects.maemo.org bug NB#60550.
470 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
472 reviewed by: <delete if not using a buddy>
474 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
475 * src/modest-ui-actions.c: (folder_refreshed_cb):
477 2007-06-14 Murray Cumming <murrayc@murrayc.com>
479 * src/widgets/modest-folder-view.c: (filter_row):
480 Explictly filter out the per-account outbox accounts. I don't know why
481 these only sometimes show up, but now they should never show up in the UI.
482 This should fix projects.maemo.org bug NB#60160.
484 2007-06-14 Murray Cumming <murrayc@murrayc.com>
486 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
487 when the toolbar does not exist yet.
488 * src/modest-widget-memory.c: (save_settings_header_view):
489 Added g_warnings() to help us to discover when we are trying to set
490 an empty columns list in gconf.
492 2007-06-14 Murray Cumming <murrayc@murrayc.com>
496 Added modest_init_get_default_header_view_column_ids().
498 * src/modest-widget-memory.c: (restore_settings_header_view):
499 Use the new function to get defaults, if the gconf key is empty,
500 instead of not creating any columns. This seems to fix the
501 empty right-hand pane problems.
503 * src/widgets/modest-header-view.h: Improved documentation.
505 2007-06-13 Murray Cumming <murrayc@murrayc.com>
507 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
508 Revert the use of the display name as the account name, because this
509 is generally wrong and would break the code that follows.
511 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
513 * src/maemo/easysetup/modest-easysetup-wizard.c:
514 (check_for_supported_auth_methods), (on_before_next),
517 More correct fix for projects.maemo.org bug NB# 58991
518 Do not longer accept AUTH_PASSWORD as secure method and choose
519 correct method when creating the account.
521 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
523 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
524 Fixed projects.maemo.org bug NB# 58991
526 2007-06-13 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-init.c: (modest_init_init_core),
529 (modest_init_local_folders): Fixed compilation errors.
531 2007-06-13 Murray Cumming <murrayc@murrayc.com>
533 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
534 Remove unnecessary lib/include, though it is good in principle when needed.
536 * src/modest-init.c: (modest_init_one_local_folder),
537 (modest_init_local_folders):
538 * src/modest-init.h: Initialize the .modest library for memory cards,
539 instead of just doing nothing for them. This should allow us to create
540 folders there, fixing projects.maemo.org bug NB#59297.
542 2007-06-13 Murray Cumming <murrayc@murrayc.com>
544 * libmodest-dbus-client/libmodest-dbus-client.c:
545 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
546 (libmodest_dbus_client_compose_mail),
547 (libmodest_dbus_client_open_message),
548 (libmodest_dbus_client_send_and_receive),
549 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
551 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
552 (on_idle_open_message), (modest_dbus_req_handler),
553 (search_result_to_message), (modest_dbus_req_filter):
554 * src/modest-search.c: (add_hit), (modest_search_folder),
555 (modest_search_all_accounts): Improved debug messages.
557 * tests/dbus_api/test_open_message.c: (main): Improved comments.
559 * src/modest-tny-account-store.c:
560 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
563 2007-06-13 Murray Cumming <murrayc@murrayc.com>
566 2007-06-12 Murray Cumming <murrayc@murrayc.com>
568 * src/modest-tny-account-store.c: (get_server_accounts):
569 Call modest_tny_local_folders_account_add_merged_outbox_folders()
570 even when there are no accounts, so that the Outbox folder is always
571 visible. This fixes projects.maemo.org bug NB#60158.
573 2007-06-12 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/modest-main-window.c: (create_details_widget):
576 Use the mcen_va_never logical ID.
578 2007-06-12 Murray Cumming <murrayc@murrayc.com>
580 * src/dbus_api/modest-dbus-api.h:
581 * src/dbus_api/modest-dbus-callbacks.c:
582 (on_idle_open_default_inbox), (on_open_default_inbox),
583 (modest_dbus_req_handler):
584 Added a new OpenDefaultInbox method.
586 * libmodest-dbus-client/libmodest-dbus-client.h:
587 * libmodest-dbus-client/libmodest-dbus-client.c:
588 Added libmodest_dbus_client_open_default_inbox() to call the new
589 dbus method. This should be useful to projects.maemo.org bug NB#57214,
590 though it should maybe be used by a new osso-email-interface function.
592 * tests/dbus_api/Makefile.am:
593 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
596 2007-06-12 Murray Cumming <murrayc@murrayc.com>
598 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
599 NULL, so that the signals get all the keys. This should not actually
600 change any behaviour because we currently update everything when anything
603 2007-06-12 Murray Cumming <murrayc@murrayc.com>
605 * src/widgets/modest-folder-view.c: (text_cell_data),
606 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
607 (find_inbox_iter): If tinymail tells us that the folder is
608 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
609 This causes the inbox to be selected at startup, fixing part of
610 projects.maemo.org bug NB#56305.
612 * src/modest-ui-dimming-rules.c:
613 (modest_ui_dimming_rules_on_tools_smtp_servers):
614 * src/modest-ui-dimming-rules.h: Added a callback function to dim
615 the SMTP servers menu item.
616 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
617 that the SMTP Servers menu item is dimmed when there are no accounts,
618 as a future version of the UI spec will require. This fixes
619 projects.maemo.org bug NB#56305.
621 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
623 * src/maemo/modest-maemo-utils.c:
624 (modest_maemo_utils_get_supported_secure_authentication_methods):
625 Added label to dialog instead of unreadable title
627 * src/maemo/modest-main-window.c: (sync_accounts_cb),
628 (modest_main_window_new):
629 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
632 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
633 * src/modest-account-mgr.h:
634 Added method to avoid code duplication
636 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
637 (modest_ui_actions_on_send_receive):
638 Use modest_account_mgr_has_accounts
640 2007-06-11 Murray Cumming <murrayc@murrayc.com>
642 * src/maemo/easysetup/modest-presets.c:
643 (modest_presets_get_info_server_security): Do not report secure auth
645 * src/modest-protocol-info.c: Use the defines for the gconf key names
646 for secure authentication. This was not working because we were writing
647 Password and reading password, and the check was case sensitive.
648 With this, gmail now works for receiving and sending when created via
651 2007-06-11 Murray Cumming <murrayc@murrayc.com>
653 * src/maemo/easysetup/modest-presets.c:
654 (modest_presets_get_info_server_security): Correct the key name for
655 SecureSmtp, because it seems to be case-sensitive.
656 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
657 Do not try to get the 0th notebook page if there are 0 pages, to
660 2007-06-11 Murray Cumming <murrayc@murrayc.com>
662 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
663 Prevent use of the new notification feature for now, because it currently
664 shows one dialog for each new email, which is annoying.
666 2007-06-11 Murray Cumming <murrayc@murrayc.com>
668 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
669 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
670 when no country was selected, so that we show the global ones.
671 * src/maemo/easysetup/modest-presets.c:
672 (modest_presets_get_providers): Return only the global providers, not
673 all providers when mmc=0 was requested.
675 2007-06-11 Murray Cumming <murrayc@murrayc.com>
677 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
678 (easysetup_provider_combo_box_fill): Remove debug code that showed the
679 provider ID in the combo.
681 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
682 Do not show the page numbers, because it would be confusing when we add
683 the 2 extra pages for the custom setup, when the user chooses the "Other"
684 provider. This fixes projects.maemo.org bug NB#59028
686 * src/modest-init.c: (modest_init_init_core),
687 (modest_init_local_folders):
689 * src/modest-tny-account.c:
690 (modest_tny_account_new_for_local_folders): Do not create default folders
691 for the memory card. This should fix projects.maemo.org bug NB#59328.
693 2007-06-11 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
696 Free the changed_conf_keys string items. They are already freed in the
697 idle handler if that runs first.
699 2007-06-11 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-ui-actions.c:
702 (modest_ui_actions_on_password_requested): Check that the server name
703 is not NULL, because I just saw a password dialog with (null) as the
706 * src/modest-tny-folder.[h|c]: Added
707 modest_tny_folder_is_memory_card_folder().
708 * src/modest-ui-dimming-rules.c:
709 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
710 menu item for memory cards, as per the UI spec (section 7.4). This should
711 fix projects.maemo.org bug NB#59297.
713 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
715 * src/maemo/modest-main-window.c: (sync_accounts_cb):
716 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
717 is another problem with the code, see Murray's comment at line 772)
719 2007-06-08 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
722 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
723 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
724 (load_from_file), (easysetup_country_combo_box_init),
725 (easysetup_country_combo_box_get_active_country_ids),
726 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
727 instead of just one ID, to avoid duplicate country names in the UI.
729 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
730 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
731 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
732 a single ID, avoiding duplicate providers.
733 * src/maemo/easysetup/modest-easysetup-wizard.c:
734 (on_combo_account_country): Adapt to use a list.
736 2007-06-08 Murray Cumming <murrayc@murrayc.com>
738 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
739 keys changed in the last X seconds.
741 * src/modest-account-mgr.h:
742 * src/modest-account-mgr.c: (on_timeout_notify_changes),
743 (on_key_change), (modest_account_mgr_class_init),
744 (modest_account_mgr_init), (modest_account_mgr_finalize):
745 As the keys are changed, save them in a GSList* and signal that GSList*
746 further every X seconds, to batch changes, to allow us to do just one
747 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
748 bug NB#56941 and other (UI-blocking) delays when changing account settings.
750 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
751 changed signal signature.
753 * src/modest-conf.c: (modest_conf_set_list),
754 (modest_conf_on_change): Reenable notification.
756 (modest_conf_maemo_fake_on_change): Comment out the hack that
757 notified immediately instead of asynchronously.
759 * src/widgets/modest-account-view.h:
760 * src/widgets/modest-account-view.c:
761 (update_account_view): Select the previously-selected account ID,
762 if possible. This fixes projects.maemo.org bug NB#56933.
764 (on_account_changed), (on_account_removed),
765 (modest_account_view_select_account):
767 Remove the block/unblock functions
768 because they were not useful.
770 * src/maemo/modest-account-view-window.c:
771 (on_delete_button_clicked), (on_edit_button_clicked),
772 (on_new_button_clicked): Remove the use of the non-working block/unblock.
774 2007-06-08 Murray Cumming <murrayc@murrayc.com>
776 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
777 Improve the error dialog to show Incorrect Account Settings, which seems
778 clearer, and say that the internal error message (to be removed from the
779 dialog later) is often misleading.
780 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
782 * src/modest-tny-account.c:
783 (modest_tny_account_new_from_server_account): Uncomment the printf of the
784 URL because this is so useful for debugging on the device.
786 * src/widgets/modest-serversecurity-combo-box.c:
787 (modest_serversecurity_combo_box_fill): Correct a logical ID.
789 2007-06-08 Murray Cumming <murrayc@murrayc.com>
791 * src/modest-mail-operation.c:
792 (modest_mail_operation_send_new_mail):
793 Added a comment about a nasty but apparently harmless message. Details
794 added to the wiki g_warnings() page.
796 2007-06-08 Murray Cumming <murrayc@murrayc.com>
798 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
799 (modest_tny_send_queue_class_init):
800 Do not use the priv struct because it is empty, to avoid g_warnings
801 about a non-existant priv struct.
803 * src/modest-tny-account-store.c:
804 (modest_tny_account_store_get_server_account),
805 (modest_tny_account_store_get_transport_account_for_open_connection
806 ): Do not try to get transport server accounts for local folders,
807 because they don't have any. This avoids a g_warning().
809 * src/maemo/modest-main-window.c:
810 (modest_main_window_notify_send_receive_initied),
811 (on_configuration_key_changed):
812 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
814 * src/modest-mail-operation.c:
815 (modest_mail_operation_update_account):
816 * src/modest-tny-account-store.h:
817 * src/modest-tny-account.c:
818 (modest_tny_account_get_special_folder),
819 (modest_tny_account_new_for_local_folders),
820 (modest_tny_account_new_for_per_account_local_outbox_folder):
821 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
822 * src/modest-tny-local-folders-account.c:
823 (add_account_folders_to_merged_folder):
824 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
825 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
826 (modest_ui_actions_on_send):
827 * src/widgets/modest-folder-view.c: (update_model):
828 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
829 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
830 modest_tny_account_store_get_tny_account_by_account() to
831 modest_tny_account_store_get_server_account() to make the code clearer.
833 2007-06-07 Marcus Bauer <marcusb@openismus.com>
835 * src/dbus_api/modest-dbus-api.h:
836 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
837 * src/maemo/modest-msg-edit-window.c:
838 (modest_msg_edit_window_attach_file_noninteractive):
839 added g_warning in case the file to be attached does not exist
840 * tests/dbus_api/test_compose_mail.c: (main):
841 removed obsolete comment, added generic files as test case
843 2007-06-07 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-tny-account-store.c: (get_server_accounts):
846 Create the local folders account only once, not once for each outbox, and
847 not only when there are some outboxes.
849 2007-06-07 Murray Cumming <murrayc@murrayc.com>
851 * src/widgets/modest-folder-view.c: (update_model): Comment out some
852 code that is causing a crash at startup. Sergio says that he is fixing this.
854 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
856 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
857 * src/maemo/modest-account-settings-dialog.c:
858 (create_page_outgoing),
859 (modest_account_settings_dialog_set_account_name),
860 (save_configuration):
861 - Fixed handling of the "Use secure authentication" toggle to comply with
862 the ui specification. See also projects.maemo.org bug NB#58400
864 - Restore the Secure connection setting combo correctly when loading
867 * src/maemo/modest-maemo-utils.c:
868 (on_camel_account_get_supported_secure_authentication),
869 (modest_maemo_utils_get_supported_secure_authentication_methods):
870 Fixed a crasher if operation is canceled
872 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
873 (modest_protocol_info_auth_is_secure):
874 * src/modest-protocol-info.h:
876 Added two new methods to determine if a protocol/auth method is secure/encrypted in
877 the sense of the "Use secure authentication" toggle.
879 2007-06-07 Murray Cumming <murrayc@murrayc.com>
881 * src/modest-tny-account-store.h:
882 * src/modest-tny-account-store.c:
883 Added modest_tny_account_store_get_local_folders_account().
885 * src/modest-tny-folder.h:
886 * src/modest-tny-folder.c:
887 (modest_tny_folder_get_account):
888 Added this replacement for tny_folder_get_account() which returns
889 the local-folders account for TnyMergeFolders, to avoid the
890 warning about the unimplemented get_account_func() vfunc().
892 (modest_tny_folder_get_rules),
893 * src/modest-ui-actions.c:
894 (modest_ui_actions_on_folder_selection_changed):
895 * src/modest-mail-operation.c:
896 (modest_mail_operation_remove_folder),
897 (modest_mail_operation_xfer_folder),
898 (modest_mail_operation_rename_folder),
899 (modest_mail_operation_get_msg),
900 (modest_mail_operation_get_msgs_full),
901 (modest_mail_operation_remove_msg),
902 (modest_mail_operation_xfer_msgs),
903 (modest_mail_operation_refresh_folder):
904 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
906 2007-06-07 Murray Cumming <murrayc@murrayc.com>
908 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
909 (modest_server_account_set_security):
910 * src/modest-defs.h: Add comments explaining that our
911 UI spec means TLS when it says Normal, so these do not look like errors.
913 * src/modest-tny-account.c:
914 (modest_tny_account_new_from_server_account): Use the new tinymail
915 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
916 for TLS. This should fix projects.maemo.org bug NB#58460.
918 2007-06-06 Murray Cumming <murrayc@murrayc.com>
920 * src/maemo/easysetup/modest-easysetup-wizard.c:
921 (create_account): Correct the position of the gconf sanity check warning.
922 (on_button_edit_advanced_settings): Show the dialog immediately, instead
923 of using the g_idle_add() hack, because this does not seem to be necessary
924 on osso 1.1. It might even work on Maemo Bora if the problems were actually
925 caused by something other than maemo's gconf.
926 This fixes projects.maemo.org bug #59022.
928 2007-06-06 Murray Cumming <murrayc@murrayc.com>
930 * src/modest-account-mgr-helpers.c:
931 (modest_account_mgr_get_default_account): Do not check that the account
932 exists if there is no default account (NULL), to fix a runtime warning.
934 2007-06-06 Murray Cumming <murrayc@murrayc.com>
936 * src/widgets/modest-folder-view.c: (update_model):
937 Do not unref the treemodel before we have finished with it.
938 This prevents a valgrind warning and an occasional crash at startup.
940 2007-06-06 Marcus Bauer <marcusb@openismus.com>
942 * libmodest-dbus-client/libmodest-dbus-client.h:
943 added libmodest_dbus_client_compose_mail()
944 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
946 added functions needed for SendAsMail() functionality
947 * src/maemo/modest-msg-edit-window.c:
948 (modest_msg_edit_window_attach_file_noninteractive):
949 non interactively attaching files to message edit window
950 * src/widgets/modest-msg-edit-window.h:
951 * tests/dbus_api/Makefile.am:
952 added test_compose_mail.c
953 * tests/dbus_api/test_compose_mail.c: (main):
955 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
957 * src/modest-account-view.c:
958 Fixed bug projects.maemo.org bug NB#59307
960 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
962 * src/maemo/easysetup/modest-easysetup-wizard.c:
963 (get_serverport_incoming), (on_before_next), (create_account):
964 * src/maemo/modest-account-settings-dialog.c:
965 (modest_account_settings_dialog_set_account_name):
966 * src/maemo/modest-maemo-utils.c:
967 (on_camel_account_get_supported_secure_authentication_status),
968 (on_camel_account_get_supported_secure_authentication),
969 (on_secure_auth_cancel),
970 (modest_maemo_utils_get_supported_secure_authentication_methods):
972 Implemented security authentication for settings and easysetup.
974 2007-06-05 Murray Cumming <murrayc@murrayc.com>
976 * src/maemo/modest-main-window.c: (create_details_widget):
977 Show the total size for memory card accounts too, instead of showing
978 the name again. Fixes bug projects.maemo.org bug NB#59307.
980 2007-06-05 Murray Cumming <murrayc@murrayc.com>
983 * src/modest-tny-simple-folder-store.c:
984 * src/modest-tny-simple-folder-store.h: Removed.
986 * src/modest-tny-local-folders-account.h
987 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
988 for the local-folders maildir, with an extra TnyMergedFolder containing
989 the folders of the per-account outbox store accounts.
990 * src/modest-tny-account-store.c: (get_server_accounts):
991 Add the outboxes to the special local folders account after creating it.
993 * src/modest-tny-account.c:
994 (modest_tny_account_new_for_local_folders): Create the derived
995 account when creating the main local-folders account.
997 * src/maemo/modest-main-window.c: (create_details_widget),
998 (modest_main_window_set_contents_style):
999 Adapted to the use of the derived account instead of the folder store.
1001 * src/modest-ui-actions.c:
1002 (modest_ui_actions_on_folder_selection_changed):
1003 * src/modest-ui-dimming-rules.c:
1004 (modest_ui_dimming_rules_on_new_folder):
1005 * src/widgets/modest-folder-view.c: (text_cell_data),
1006 (icon_cell_data), (filter_row), (update_model),
1007 (get_cmp_rows_type_pos):
1010 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1011 Do not get the priv struct, because no priv struct has been set,
1012 to avoid a runtime warning.
1014 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1015 #ifelse with #else, to fix a warning, to fix the build.
1018 2007-06-05 Christian Kellner <ckellner@openismus.com>
1020 * libmodest-dbus-client/libmodest-dbus-client.c:
1021 Fix small typo in doc (why do you always see them
1022 AFTER committing stuff?)
1025 2007-06-05 Christian Kellner <ckellner@openismus.com>
1027 * libmodest-dbus-client/libmodest-dbus-client.c:
1028 (libmodest_dbus_client_search):
1029 Initialize hit list with NULL. Also set folder list
1030 to "" if NULL was supplied.
1033 2007-06-03 Christian Kellner <ckellner@openismus.com>
1035 * libmodest-dbus-client/libmodest-dbus-client.c:
1036 (modest_search_hit_list_free):
1037 Make it save to call it with NULL.
1039 * src/dbus_api/modest-dbus-callbacks.c:
1040 * src/modest-search.c:
1041 Return full ModestSearchHits as the search result list not TnyHeader
1042 since can't be around withouth the correspoding TnyFolder.
1044 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1046 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1047 Added currently commented code to check for secure auth
1049 * src/maemo/modest-account-settings-dialog.c: (on_response),
1050 (save_configuration), (show_ok):
1051 Fixed projects.maemo.org bugs NB #59248 and #59251
1053 * src/maemo/modest-maemo-utils.c:
1054 (on_camel_account_get_supported_secure_authentication_status),
1055 (on_camel_account_get_supported_secure_authentication),
1056 (modest_maemo_utils_get_supported_secure_authentication_methods):
1057 * src/maemo/modest-maemo-utils.h:
1058 Moved get_supported_secure_authentication() method here to be able
1059 to use it from easysetup wizard.
1061 * src/modest-pair.c: (on_pair_compare_as_string):
1062 Should compare string with first part of pair and not
1063 strcmp pairs which will crash.
1065 * src/modest-protocol-info.c:
1066 (modest_protocol_info_protocol_is_store):
1067 * src/modest-protocol-info.h:
1068 Added modest_protocol_info_get_auth_protocol_name()
1070 2007-06-03 Armin Burgmeier <armin@openismus.com>
1072 * src/modest-mail-operation.c:
1073 (modest_mail_operation_get_msgs_full): Set priv->account also when
1074 only retrieving a single message. This avoids a crash when canceling
1077 (modest_mail_operation_notify_end): Do not explicitely remove the
1078 operation from the queue but only emit the progress_changed signal.
1079 The queue itself listens to that signal to remove the operation when
1080 it is finished. This reduces coupling and removes a potential deadlock
1081 when modest_mail_operation_notify_end() is called from the queue
1082 itself. If that is a problem performance-wise, I would suggest to
1083 implement a status-changed signal or something.
1085 * src/modest-mail-operation-queue.c: Make sure to never call a
1086 function from another file while the queue is locked. This (hopefully)
1087 fixes another deadlock when exiting the application while retrieving
1090 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1092 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1093 Fixed build if libogs is not available
1095 2007-06-03 Christian Kellner <ckellner@openismus.com>
1097 * libmodest-dbus-client/libmodest-dbus-client.h:
1098 * libmodest-dbus-client/libmodest-dbus-client.c:
1099 (libmodest_dbus_client_delete_message):
1100 Implement deletion of messages (Client side).
1102 (modest_search_hit_free),
1103 (modest_search_hit_list_free):
1104 Utility functions to free the result hits.
1106 * src/dbus_api/modest-dbus-api.h:
1107 * src/dbus_api/modest-dbus-callbacks.c:
1108 (on_delete_message),
1109 (modest_dbus_req_handler):
1110 Implement deletion of messages (Server side).
1112 * tests/dbus_api/test_search.c: (main):
1115 * tests/dbus_api/Makefile.am:
1116 * tests/dbus_api/test_delete_message:
1117 Add little test for the message deletion logic
1119 2007-06-03 Armin Burgmeier <armin@openismus.com>
1121 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1122 when the operation queue was not empty. projects.maemo.org bug
1125 2007-06-03 Armin Burgmeier <armin@openismus.com>
1127 * src/widgets/modest-account-view.c
1128 (on_account_default_toggled): Toggle default account column
1129 explicitely instead of waiting for gconf notification (which is
1130 currently ignored). This should fix projects.maemo.org bug NB#56910
1131 for now. It should probably be removed when gconf notifications are
1134 2007-06-03 Christian Kellner <ckellner@openismus.com>
1136 * libmodest-dbus-client/libmodest-dbus-client.c:
1137 Removed debugging spew.
1139 * src/dbus_api/modest-dbus-callbacks.c:
1140 Added debugging info.
1142 * src/modest-search.c:
1143 (modest_search_all_accounts):
1144 Use tny_account_store_get_accounts () on the account store
1145 to get all accounts which is the way to get all accounts.
1147 * tests/dbus_api/test_search.c: (main):
1148 Make it possible to supply the search term on the command line.
1150 2007-06-03 Christian Kellner <ckellner@openismus.com>
1152 * libmodest-dbus-client/libmodest-dbus-client.c:
1153 * libmodest-dbus-client/libmodest-dbus-client.h:
1154 Implement searching for mesages over raw dbus. (Client side)
1156 * src/dbus_api/Makefile.am:
1157 * src/dbus_api/modest-dbus-api.h:
1158 * src/dbus_api/modest-dbus-callbacks.c:
1159 * src/dbus_api/modest-dbus-callbacks.h:
1160 Search framework (Server side). Also implement on_idle_open_message().
1162 * src/maemo/modest-platform.c: (modest_platform_init):
1163 Prepare for raw dbus/osso rpc interaction.
1165 * src/modest-search.h:
1166 Changed minsize from unspecific guint to guint32.
1168 * src/modest-search.c:
1170 Added strange hack which magically made tnymail work.
1172 (modest_search_folder),
1173 (modest_search_account),
1174 (modest_search_all_accounts):
1175 Implement helper functions to search all accounts, specific account
1178 * tests/dbus_api/Makefile.am:
1179 * tests/dbus_api/test_open_message.c:
1180 Read url to open from commandline.
1182 * tests/dbus_api/test_search.c:
1183 Implement small test for dbus search stuff
1185 2007-06-02 Armin Burgmeier <armin@openismus.com>
1187 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1188 include account type and account title. This fixes projects.maemo.org
1191 * src/maemo/modest-account-view-window.c: Set a title for the window.
1193 2007-06-02 Armin Burgmeier <armin@openismus.com>
1195 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1196 incoming and outgoing server name based on email address and server
1197 types as long as the names have not been edited manually. This fixes
1198 projects.maemo.org bug NB#58671.
1200 2007-06-02 Armin Burgmeier <armin@openismus.com>
1202 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1203 server type cannot be changed in future to the incoming details page
1204 when creating an account. This fixes projects.maemo.org bug NB#59029.
1206 2007-06-02 Armin Burgmeier <armin@openismus.com>
1208 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1209 and assigned max width chars so that they wrap instead of being
1210 truncated. Fixes projects.maemo.org bug NB#56126.
1212 2007-06-02 Armin Burgmeier <armin@openismus.com>
1214 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1215 introductory note to the connection specific smtp servers dialog, as
1216 section 8.12 of the email UI specification requires. This fixes
1217 projects.maemo.org bug NB#59212.
1219 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1221 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1222 Check for running mail operations, and offer to cancel them, as per the UI
1223 spec. This fixes projects.maemo.org bug NB#59041 .
1224 However, I suspect that tinymail may still use the network connection
1225 in ways that we cannot detect or cancel. But it should at least adapt to
1226 changes fairly well.
1228 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-tny-account-store.c: (recreate_all_accounts),
1231 (get_cached_accounts), (get_server_accounts): Do more sensible
1232 ref-counting of the temporarily-cached outbox accounts list. This seems
1233 to fix a crash when entering the password when the password was wrong.
1235 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1237 * src/gnome/modest-main-window.c: (connect_signals):
1238 * src/modest-tny-account-store.c: (get_password),
1239 (modest_tny_account_store_alert): Added comments and clues and
1240 commented-out code about how we currently fail to deal with connection
1241 errors and wrong passwords, and how we should.
1243 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1245 * src/widgets/modest-retrieve-combo-box.c:
1246 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1247 This fixes projects.maemo.org bug NB#58472 .
1249 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1251 * src/maemo/easysetup/modest-easysetup-wizard.c:
1252 (create_page_complete_easysetup):
1253 (create_page_complete_custom): Correct the last commit,
1254 putting the correct sentences in the correct pages.
1256 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1258 * src/maemo/easysetup/modest-easysetup-wizard.c:
1259 (create_page_complete_custom): Show the second sentence of text
1260 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1263 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1265 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1266 Set the leave-on-server conf key by default. This fixes
1267 projects.maemo.org bug NB#59258 .
1269 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/modest-account-view-window.c:
1272 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1273 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1276 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/easysetup/modest-easysetup-wizard.c:
1279 (create_caption_new_with_asterisk):
1280 * src/maemo/modest-account-settings-dialog.c:
1281 (create_caption_new_with_asterisk):
1282 Uncomment the code to add the asterisk, because they are no longer in the
1283 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1284 (update_incoming_server_title): Add an asterisk here too.
1286 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1288 * src/maemo/modest-maemo-global-settings-dialog.c:
1289 (current_connection): Check that we are even connected before trying to
1290 get the current connection name, to prevent a warning.
1292 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1293 Change the comments because tny_maemo_conic_device_connect() is now meant to
1295 * src/modest-mail-operation.c:
1296 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1297 make sure we have a connection and fail if we can't connect.
1299 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1301 * src/maemo/modest-main-window.c:
1302 (on_account_store_connecting_finished): Do not try to get the
1303 connection ID if we are not really connected. I am surprised that
1304 this signal handler is called when we are not connected.
1306 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1308 * src/modest-error.h:
1309 * src/modest-ui-actions.c:
1310 (modest_ui_actions_get_msgs_full_error_handler):
1311 Renamed an enum, added comments, added an enum
1312 for retrieve-limit errors.
1314 * src/modest-mail-operation.c: (foreach_add_item),
1315 (internal_folder_observer_update), (update_account_thread),
1316 (modest_mail_operation_get_msgs_full):
1317 (modest_mail_operation_update_account),
1318 Added comments about how this works, and some code that should
1319 (but does not) check the retrieve-limit. See the TODO comment.
1321 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1323 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1324 Initialize help_id to fix the build. Warnings are good.
1326 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1328 * src/widgets/modest-hbox-cell-renderer.c:
1329 (modest_hbox_cell_renderer_append):
1330 * src/widgets/modest-vbox-cell-renderer.c:
1331 (modest_vbox_cell_renderer_append):
1332 Fix the last commit by doing an extra ref.
1334 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1336 * src/widgets/modest-hbox-cell-renderer.c:
1337 (modest_hbox_cell_renderer_append):
1338 * src/widgets/modest-vbox-cell-renderer.c:
1339 (modest_vbox_cell_renderer_append):
1340 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1341 to fix the build with Maemo Bora.
1342 However, there seems to be a remaining crash, probably due to reference
1345 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1347 * src/modest-tny-account.c:
1348 (modest_tny_account_new_for_local_folders):
1349 Use hildon_file_system_info_async_new() to get a better name for
1350 the memory card account, setting it as the account name.
1351 The timing seems to work, but this is probably
1352 not the best place to do this. See the TODO comment.
1353 * src/maemo/modest-main-window.c: (create_details_widget):
1354 * src/widgets/modest-folder-view.c: (text_cell_data):
1355 Use the tny account name instead of hardcoding a name.
1357 2007-05-30 Christian Kellner <ckellner@openismus.com>
1359 * src/modest-search.c: (modest_search):
1360 Correctly set part_search_func even if we have already parsed
1361 the query and thus a valid OgsTextSearcher object.
1363 2007-05-30 Christian Kellner <ckellner@openismus.com>
1366 Search and check for libogs.
1369 Incooparte the ogs build env.
1371 * src/modest-mime-part-search-stream.c:
1372 * src/modest-mime-part-search-stream.h:
1373 Removed since we do the real searching now in modest-search.c.
1375 * src/modest-search.c:
1376 * src/modest-search.h:
1377 Implement support for ogs. We use that if available and requested
1378 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1379 should now handle the corner case when the search term is spread
1380 across multiple reads.
1381 Also the logic in modest_search () was corrected to search all
1382 requested fields until one is found.
1384 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1386 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1388 * src/modest-init.h:
1389 * src/modest-init.c: Made modest_init_local_folders() take a
1390 path and be public so we can iniitialize maildir folders on
1393 * src/modest-local-folder-info.h:
1394 * src/modest-local-folder-info.c:
1395 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1397 * src/modest-tny-account.c:
1398 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1399 still means the standard local-folders path on the local volume.
1401 * src/modest-tny-account-store.c:
1402 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1403 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1404 all accounts when that happens.
1405 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1406 this too, so it shows up in the treeview.
1408 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1410 * src/maemo/modest-maemo-global-settings-dialog.c:
1411 (current_connection):
1412 * src/widgets/modest-global-settings-dialog.c:
1413 (current_connection_default):
1414 Use the enum values instead of 0, 1 and -1,
1415 to make the code clearer.
1417 * src/modest-account-mgr-helpers.c:
1418 (modest_account_mgr_get_connection_specific_smtp): Make this code
1421 * src/modest-runtime.h:
1422 * src/modest-runtime.c:
1423 Added modest_runtime_remove_all_send_queues().
1424 * src/maemo/modest-main-window.c:
1425 (on_account_store_connecting_finished): Recreate the send queues,
1426 using the appropriate transport accounts for this new connection.
1427 Some futher adapting might be needed if the old send queues are not
1428 automatically stopped at this point.
1430 * src/modest-tny-account-store.c: (get_server_accounts):
1431 Create the connection-specific transport accounts, so that they can
1432 be found later by their ID.
1434 * src/modest-tny-account.h:
1435 * src/modest-tny-account.c:
1436 Added modest_tny_account_new_from_server_account_name().
1437 modest_tny_account_new_from_server_account(): Do not create the
1438 send queues here, because they will be
1439 recreated anyway when the connection changes for the first time.
1441 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-local-folder-info.h:
1444 * src/modest-local-folder-info.c:
1445 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1446 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1447 tbox_folder): Take a modest account name instead of a server TnyAccount,
1448 so we can have per-modest-account rather than per-transport-account
1450 We must make sure that we change or recreate the exisitng send queues
1451 when the connection changes for connection-specific transport accounts.
1453 * src/modest-tny-account-store.c:
1454 (create_per_account_local_outbox_folders): Create outboxed per modest
1455 account, not per transport account.
1457 * src/modest-tny-account.h:
1458 * src/modest-tny-account.c:
1459 (modest_tny_account_get_special_folder): For outboxes, get the
1460 parent modest account name. The account is ignored for other folders.
1461 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1462 modest account name rather than a server TnyAccount.
1464 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-tny-account.c:
1467 (modest_tny_account_new_from_server_account):
1468 Call modest_runtime_get_send_queue() immediately after creating transport
1469 accounts, so that they start trying to send email from the outbox as soon
1470 as possible at startup. This is probably what we want.
1472 * src/modest-mail-operation.c: (update_account_thread):
1473 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1474 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1475 * src/modest-tny-send-queue.h:
1476 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1477 (modest_ui_actions_on_send):
1478 Added comments about how sending works, though it needs some more work.
1480 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-tny-account.c:
1483 (modest_tny_account_get_special_folder): Add TODO because this fails when
1484 the network is busy.
1485 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1486 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1487 Do not try to show this window when there is no active account. The UI
1488 specs does not tell us what to do in this case.
1490 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1494 * src/maemo/Makefile.am:
1495 * src/widgets/Makefile.am: Some dist fixes.
1497 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/modest-connection-specific-smtp-window.c:
1500 (on_button_edit): Make the code clearer, to prevent a double free.
1502 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1504 * src/maemo/modest-account-settings-dialog.c:
1505 (modest_account_settings_dialog_set_account_name),
1506 Check the connection-specific smtp servers checkbox if there are any.
1508 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1509 (modest_connection_specific_smtp_edit_window_init):
1510 Start with a suitable port number.
1512 * src/modest-account-mgr-helpers.h:
1513 * src/modest-account-mgr-helpers.c: Added
1514 modest_account_mgr_get_has_connection_specific_smtp().
1516 (modest_account_mgr_set_connection_specific_smtp),
1517 (modest_account_mgr_remove_connection_specific_smtp),
1518 (modest_account_mgr_get_has_connection_specific_smtp),
1519 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1520 connection-specific smtp server accounts in the account, rather than
1521 the server account conf dir.
1523 This fixes bug projects.maemo.org bug NB#58263 .
1525 * src/modest-tny-account-store.c:
1526 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1527 if there are no server accounts yet, to prevent an infinite loop when there
1528 are no accounts. Document that one must be called before the other.
1530 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1532 * src/modest-account-mgr-helpers.c:
1533 (modest_account_mgr_get_default_account): Make sure that at least
1534 one account is always the default, if there are any enabled accounts.
1535 This is just a sanity check that shouldn't be necessary.
1537 * src/modest-account-mgr-priv.c:
1538 (_modest_account_mgr_account_from_key): Unescape the conf key to
1539 get the real account name. For instance, this is an issue if a space
1540 was in the account name, which can happen because the account name
1541 is generated from the display name.
1542 (_modest_account_mgr_get_account_keyname): Always escape the
1544 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1545 Unescape the conf keys to get the real account names.
1547 For instance, previously the is-default radio button in the accounts
1548 list was not checked for any accounts at first. This fixes that,
1549 and might fix several similar bugs.
1551 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1553 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1554 Removed some debug printfs.
1556 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1558 Modest on-disk outbox directories are now here, for instance:
1559 $HOME/.modest/outboxes/<account-id-1>/outbox
1560 $HOME/.modest/outboxes/<account-id-2>/outbox
1562 $HOME/.modest/local-folders/outbox
1563 so we can have a separate outbox for each account.
1564 But they are shown as one outbox in the GtkTreeView, by using a
1565 TnyMergeFolder in a ModestTnySimpleFolderStore.
1568 * src/modest-tny-simple-folder-store.c:
1569 * src/modest-tny-simple-folder-store.h:
1570 Added ModestTnySimpleFolderStore, used to contain folders from
1571 other folder stores, such as other accounts.
1573 * src/modest-tny-outbox-account.h:
1574 * src/modest-tny-outbox-account.c:
1575 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1576 used for the per-account local outbox folders.
1578 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1579 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1580 only use this (internally) now for the non-outbox local folders.
1582 * src/modest-init.h:
1583 * src/modest-init.c: Added modest_init_one_local_folder(), for
1584 setting up the directory structure for each local folder.
1586 * src/modest-local-folder-info.c:
1587 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1588 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1590 * src/modest-local-folder-info.h:
1591 * src/modest-tny-account-store.c: (on_account_removed),
1592 (on_account_changed), (create_per_account_local_outbox_folders),
1593 (get_server_accounts), (modest_tny_account_store_get_accounts),
1594 (modest_tny_account_store_get_tny_account_by_account),
1595 (modest_tny_folder_store_is_virtual_local_folders):
1597 * src/modest-tny-account.h:
1598 * src/modest-tny-account.c:
1599 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1600 to create an on-disk per-account local outbox folder for each
1602 (create_per_account_local_outbox_folders): Create a local outbox folder
1603 for each transport account.
1604 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1605 for all local folders.
1607 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1608 instead of using g_object_get/set() directly. It is clearer.
1610 (modest_tny_folder_store_get_message_count),
1611 (modest_tny_folder_store_get_local_size
1612 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1613 because we now use these with non-acount folder stores.
1615 (modest_tny_account_get_special_folder),
1616 (modest_tny_account_new_from_server_account),
1617 (modest_tny_account_new_from_account):
1618 (recurse_folders): Adjust to the new outbox system.
1620 * src/modest-tny-folder.h:
1621 * src/modest-tny-folder.c:
1622 (modest_tny_folder_is_local_folder),
1623 (modest_tny_folder_get_local_folder_type),
1624 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1626 * src/widgets/modest-main-window.h:
1627 * src/maemo/modest-main-window.c: (create_details_widget),
1628 (modest_main_window_set_contents_style): Show details for any folder store,
1631 (modest_tny_folder_get_rules):
1632 Remove the const. C does not support constness enough for this.
1634 * src/modest-ui-actions.c:
1635 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1636 make all outboxes appear as one, in the usual local-folders tree node.
1638 (set_active_account_from_tny_account),
1639 (modest_ui_actions_on_folder_selection_changed):
1640 * src/widgets/modest-folder-view.c: (text_cell_data),
1641 (icon_cell_data), (filter_row),
1642 (add_account_folders_to_merged_folder),
1643 (add_account_folders_to_simple_folder_store), (),
1644 (get_cmp_rows_type_pos), (cmp_rows),
1645 (modest_folder_view_set_account_id_of_visible_server_account):
1646 Adjust to the new outbox system, using generic folder stores and folders
1647 in the GtkTreeModel.
1649 2007-05-23 Christian Kellner <ckellner@openismus.com>
1651 * src/modest-mail-operation.c:
1652 (modest_mail_operation_update_account):
1653 Use info->max_size instead of unintialized local var [small
1654 build fix]. (Added TODO to review that change since I don't
1657 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1659 * libmodest-dbus-client/libmodest-dbus-client.c:
1660 (libmodest_dbus_client_compose_mail): function added
1661 * src/dbus_api/modest-dbus-api.h:
1662 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1663 (on_compose_mail): Implementation of the SendAsMail functionality
1665 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1667 * src/modest-account-mgr.c:
1668 (modest_account_mgr_add_server_account): Set the secure-connection
1669 conf key for transport accounts as well as store accounts. I don't know
1670 why the if was there. For instance, this makes sure that we use SSL
1671 for the gmail preset from the easysetup wizard.
1673 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1675 * src/gnome/modest-main-window.c:
1676 (on_account_store_connecting_finished), (connect_signals):
1677 * src/maemo/modest-main-window.c:
1678 (on_account_store_connecting_finished), (connect_signals),
1679 (modest_main_window_new):
1680 Handle TnyAccountStore::connecting-finished instead of
1681 TnyDevice::connection-changed, because we cannot actually perform
1682 operations on accounts until TnyAccountStore has itself responded to
1683 the TnyDevice::connection-changed signal. This prevents a GError from
1685 Do not try to update at startup, because we (at least on scratchbox)
1686 already do an update at startup when the device goes online.
1687 This prevents a GError from tinymail.
1688 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1689 Added TODO about stopping simultaneous operations.
1691 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1693 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1694 * src/modest-mail-operation-queue.c:
1695 (modest_mail_operation_queue_remove):
1696 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1697 about where they happened.
1699 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1701 * src/modest-ui-actions.c:
1702 (modest_ui_actions_on_password_requested): Make sure that the remember
1703 output parameter is always TRUE.
1705 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1707 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1708 Show a OK/Cancel dialog if the error is a question, though we still do not
1709 know anything more about what we are asking the user.
1710 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1711 Fix an uninitialized variable (helper). This is a logic error, however.
1713 2007-05-21 Christian Kellner <ckellner@openismus.com>
1715 * src/modest-search.h:
1716 Correct bit shifting in the ModestSearchFlags enum.
1718 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-tny-account.c:
1721 (modest_tny_account_new_from_server_account): Do not use the lsub and
1722 check-all hard-coded IMAP options when using POP.
1724 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1726 * src/modest-tny-account.c:
1727 (modest_tny_account_new_from_server_account):
1728 Use NULL for the secure-auth method for POP when Password auth has been
1729 specified by the user, as we already do for IMAP. "auth=Login" causes
1730 an error from camel or the server.
1732 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1734 * src/maemo/modest-account-settings-dialog.c:
1735 (create_page_account_details),
1736 (modest_account_settings_dialog_set_account_name):
1737 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1738 for the leave-on-server checkbox, rathr than just the checkbox, when
1739 the protocol is not POP.
1741 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1743 * src/widgets/modest-account-view.c:
1744 * src/widgets/modest-account-view.h:
1745 Added modest_account_view_select_account() which will be useful later
1746 to asynchronously re-select the edited account.
1748 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1750 * src/maemo/modest-account-settings-dialog.c:
1751 (modest_account_settings_dialog_set_account_name):
1752 Automatically choose the port numbers based on the secure authentication
1753 methods, if they have not been chosen before.
1754 This fixes projects.maemo.org bug NB#56273 .
1756 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/modest-main-window-ui.h:
1759 * src/modest-ui-actions.c:
1760 * src/modest-ui-actions.h:
1761 Connect the Tools/SMTP Servers menu item to
1762 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1763 SMTP servers dialog, as in the UI specification and saves changes when it
1764 is closed. This fixed projects.maemo.org bug NB#56305 .
1766 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1768 * src/maemo/modest-connection-specific-smtp-window.c:
1769 (modest_connection_specific_smtp_window_init):
1770 Use gtk_window_set_default_size() to make this window big enough, so
1771 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1773 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1775 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1776 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1777 (modest_connection_specific_smtp_edit_window_init),
1778 Do not try to connect to a combobox signal before the combobox exists.
1779 This fixes the cras in projects.maemo.org bug NB#56288 .
1780 (modest_connection_specific_smtp_edit_window_get_settings):
1781 Remove the server_account_name parameter which was being checked for NULL
1782 though it was not used.
1784 * src/maemo/modest-connection-specific-smtp-window.c:
1785 (modest_connection_specific_smtp_window_fill_with_connections),
1786 (on_button_edit), (modest_connection_specific_smtp_window_init):
1787 Correct the number of treemodel columns to prevent a warning.
1788 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1789 libconic does not work.
1791 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-tny-account.c:
1794 (modest_tny_account_new_from_server_account):
1795 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1796 SMTP when "None" was chosen by the user. However, with my SMTP server that
1797 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1800 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1802 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1803 to explain the memory management issue with the ID in the ModestPair.
1805 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1806 (add_sending_page), (modest_account_assistant_finalize):
1807 * src/gnome/modest-gnome-global-settings-dialog.c:
1808 (create_updating_page), (create_composing_page):
1809 * src/gnome/modest-msg-edit-window.c: (get_transports),
1810 (init_window), (modest_msg_edit_window_finalize),
1811 (modest_msg_edit_window_get_msg_data):
1812 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1813 * src/gnome/modest-transport-widget.c:
1814 (modest_transport_widget_finalize), (smtp_configuration):
1815 * src/maemo/modest-maemo-global-settings-dialog.c:
1816 (create_updating_page), (create_composing_page):
1817 * src/maemo/modest-msg-edit-window.c: (get_transports),
1818 (init_window), (modest_msg_edit_window_finalize),
1819 (modest_msg_edit_window_get_msg_data),
1820 (modest_msg_edit_window_free_msg_data):
1821 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1822 (modest_store_widget_finalize):
1823 * src/maemo/modest-transport-widget.c:
1824 (modest_transport_widget_finalize), (smtp_configuration):
1825 * src/modest-main.c: (send_mail):
1826 * src/widgets/modest-combo-box.h:
1827 * src/widgets/modest-global-settings-dialog-priv.h:
1828 * src/widgets/modest-global-settings-dialog.c:
1829 (modest_global_settings_dialog_finalize):
1830 * src/widgets/modest-msg-edit-window.h:
1831 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1832 as long as the combo box, to prevent use of freed memory for the ID.
1834 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1836 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1837 get_accounts(), to make this clearer. Do not check for the enabled gconf
1838 key, because we do not use this for server accounts (at least, not yet).
1839 This allows us to send email again.
1841 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1843 * src/maemo/modest-platform.c:
1844 (on_modest_conf_update_interval_changed), (modest_platform_init):
1845 Only respond to this particular key change. All these strcmp()s cannot be
1848 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1850 * src/maemo/modest-maemo-global-settings-dialog.c:
1851 (current_connection): Prevent a crash in scratchbox when
1852 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1853 * src/maemo/modest-platform.c:
1854 (on_modest_conf_update_interval_changed), (modest_platform_init):
1855 Get the update interval from gconf and reset it when the gconf key changes.
1857 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1859 * src/modest-protocol-info.c:
1860 * src/modest-protocol-info.h: Adde enum-specific get functions,
1861 instead of using a ModestProtocolType enum parameter.
1863 * src/gnome/modest-account-assistant.c:
1864 * src/gnome/modest-store-widget.c:
1865 * src/gnome/modest-store-widget.h:
1866 * src/gnome/modest-transport-widget.c:
1867 * src/gnome/modest-transport-widget.h:
1868 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1869 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1870 * src/maemo/easysetup/modest-easysetup-wizard.c:
1871 * src/maemo/modest-account-settings-dialog.c:
1872 * src/maemo/modest-account-settings-dialog.h:
1873 * src/maemo/modest-store-widget.c:
1874 * src/maemo/modest-store-widget.h:
1875 * src/maemo/modest-transport-widget.c:
1876 * src/maemo/modest-transport-widget.h:
1877 * src/modest-account-mgr-helpers.c:
1878 * src/modest-account-mgr-helpers.h:
1879 * src/modest-account-mgr.c:
1880 * src/modest-account-mgr.h:
1881 * src/modest-tny-account.c:
1882 * src/modest-tny-folder.c:
1883 * src/widgets/modest-account-view.c:
1884 * src/widgets/modest-retrieve-combo-box.c:
1885 * src/widgets/modest-retrieve-combo-box.h:
1886 * src/widgets/modest-secureauth-combo-box.c:
1887 * src/widgets/modest-serversecurity-combo-box.c:
1888 * src/widgets/modest-serversecurity-combo-box.h:
1889 * tests/check_account-mgr.c:
1890 Use the specific functions, and use the re-renamed enum values for GNOME too.
1892 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1894 * src/modest-pair.h:
1895 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1896 so we can get the second based on the first.
1898 * src/maemo/modest-account-settings-dialog.h:
1899 * src/maemo/modest-account-settings-dialog.c:
1900 Added get_supported_secure_authentication_methods(), though it is mostly
1901 commented-out for now until the necessary API is committed to tinymail.
1902 (modest_account_settings_dialog_set_account_name),
1903 (save_configuration): Request the supported authentication methods from the
1904 server, so we can choose a working method.
1906 * src/modest-tny-account-store.h:
1907 * src/modest-tny-account-store.c:
1908 (modest_tny_account_store_get_session): Rename from
1909 tny_account_store_get_session().
1911 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1913 * src/modest-protocol-info.h: Split the ModestProtocol enum
1914 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1915 There was no need to have these unrelated values in one enum.
1917 * src/: many files: Adapted to changed enum. This makes the code a bit
1918 clearer, and the compiler could catch some errors.
1920 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1922 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1923 Show the detailed internal camel error message when an error happens
1924 during the configuration, so that our testers can give us more clues.
1925 For instance, in projects.maemo.org bug NB#56910 .
1927 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1929 * src/modest-tny-account.c:
1930 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1931 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1933 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1936 * src/maemo/modest-account-settings-dialog.c:
1937 (modest_account_settings_dialog_set_account_name),
1938 (save_configuration): For the incoming secure authentication checkbox,
1939 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1940 the UI specification. PLAIN does not seem to be supported for most IMAP
1941 servers anyway, and I am not sure what it would mean.
1942 However, we probably need to discover which of the secure-authentication
1943 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1944 * src/modest-account-mgr-helpers.c:
1945 (modest_account_mgr_get_server_account_data):
1947 * src/modest-tny-account.c:
1948 (modest_tny_account_new_from_server_account):
1949 Use tny_account_set_mech() to set secure-authentication methods,
1950 with some special-casing for IMAP, based on my observations of how
1953 * src/modest-account-mgr-helpers.h:
1954 * src/modest-account-mgr.c:
1955 * src/modest-defs.h: Comment that the URI is only used for local folders.
1957 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1960 parameter const, just to be neat.
1961 * src/modest-text-utils.c: (modest_text_utils_inline):
1962 End g_strconcat() with NULL, as its documentation says. This is almost
1963 certainly the cause of my crash at startup on the device. Interestingly,
1964 valgrind doesn't tell us about these errors.
1966 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1968 * scripts/build-packages: Added more precise comments about how to use
1969 this script, though I still get this error:
1970 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1971 error building tinymail
1973 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/modest-main-window.c: (on_account_update):
1976 Very slight cleanup, hoping to make it simpler to discover what causes
1977 a crash here sometimes.
1979 * src/modest-tny-account.c:
1980 (modest_tny_account_new_from_server_account): Set the port. Added
1981 comments about the options and a TODO comment because I need to find out
1982 how to specify the secure authentication method.
1984 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1986 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1987 changed CFlags paths form modest to libmodest
1989 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1991 * src/modest-account-mgr-helpers.c:
1992 (modest_account_mgr_get_server_account_data),
1993 (modest_account_mgr_free_server_account_data):
1994 * src/modest-account-mgr-helpers.h:
1995 * src/modest-account-mgr.c:
1996 (modest_account_mgr_add_server_account):
1997 * src/modest-defs.h:
1998 * src/modest-tny-account.c:
1999 (modest_tny_account_new_from_server_account):
2000 Determine the options for tny_camel_account_add_option() here,
2001 based on the settings, rather than storing them directly in gconf.
2003 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2005 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2006 Show a more friendly error dialog now that we expect (from the tinymail
2007 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2009 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/modest-main-window.c: (on_account_update): Check that
2012 account_name is not NULL, to prevent a crash at startup that I am
2013 seeing on the N800. I do wonder why it is NULL.
2015 * src/maemo/easysetup/modest-easysetup-wizard.c:
2016 (create_page_user_details):
2017 * src/maemo/modest-account-settings-dialog.c:
2018 (create_page_user_details), (create_page_outgoing):
2019 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2020 (modest_connection_specific_smtp_edit_window_init):
2021 * src/modest-ui-actions.c:
2022 (modest_ui_actions_on_password_requested):
2023 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2024 might do something useful with the on-screen keyboard.
2026 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-main-window.c: (on_account_update):
2029 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2030 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2032 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-tny-account-store.c: (on_account_changed):
2035 Correct the signature of this signal handler.
2037 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2039 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2040 Show a HildonNote instead of a GtkDialog for Maemo.
2042 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2044 * src/widgets/modest-account-view.h:
2045 * src/widgets/modest-account-view.c: (on_account_changed),
2046 (on_account_removed). Added a boolean flag, set/unset by
2047 modest_account_view_block_conf_updates(),
2048 modest_account_view_unblock_conf_updates() to prevent unnecessary
2049 updates, but this is not very useful because the gconf notifications are
2050 so delays (maybe only on Maemo Bora).
2051 So auto-updating is turned off, and these functions do an explicit
2052 update when necessary.
2053 However, something else is still doing too much work when adding/removing
2054 accounts, probably in another part of the application.
2056 * src/maemo/modest-account-view-window.c:
2057 (on_delete_button_clicked), (on_edit_button_clicked),
2058 (on_new_button_clicked): Use the new functions.
2060 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2062 * src/modest-account-mgr-helpers.c:
2063 (modest_account_mgr_set_first_account_as_default):
2064 Sort the list of names alphabetically-by-title, so we choose the first one
2066 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2067 alphabetically by the title.
2069 This fixes projects.maemo.org bug NB#56418 .
2071 * src/modest-account-mgr-priv.c:
2072 (_modest_account_mgr_account_from_key):
2073 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2074 avoid a valgrind error, and possible random behaviour.
2076 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2078 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2079 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2080 tinymail documentation to say that this can be expected.
2081 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2082 pretty, and should not happen, but I would prefer to know when it does.
2084 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2086 * configure.ac: When using the older hildon version, probably on Bora,
2087 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2089 * src/widgets/modest-attachment-view.c:
2090 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2093 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2095 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2096 Implemented the prototype. Can be tested with
2097 tests/dbus_api/test_open_message:
2099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2101 * src/modest-tny-account-store.c:
2102 (modest_tny_account_store_instance_init), (get_password):
2103 * src/modest-ui-actions.c:
2104 (modest_ui_actions_on_password_requested):
2105 Do not store the password in gconf, because this function is called
2106 for non-remembered passwords. Actually use the cached (in the hash map)
2107 password instead of releasing it.
2108 The password will now not be remembered if it is asked via the protected
2109 password dialog, as per the UI spec.
2111 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2113 * src/modest-defs.h:
2114 * src/modest-account-mgr-helpers.h:
2115 * src/modest-account-mgr-helpers.c:
2116 Added modest_server_account_get_username_has_succeeded(),
2117 modest_server_account_set_username_has_succeeded().
2118 (modest_server_account_set_username),
2119 Reset the has-succeeded flag if the username changes.
2121 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2122 * src/maemo/modest-connection-specific-smtp-window.c:
2123 (modest_connection_specific_smtp_window_save_server_accounts):
2124 Use modest_server_account_set_username() instead of using
2125 modest_conf_set_string() directly, so that the has-succeeded flag is always
2128 * src/modest-ui-actions.c:
2129 (modest_ui_actions_on_password_requested): Dim the username entry if
2130 the username has ever worked, as per the UI spec.
2132 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2134 * src/modest-tny-account-store.c: (get_password):
2135 * src/modest-ui-actions.c:
2136 (modest_ui_actions_on_password_requested):
2137 Allow the username to be changed too, though there is more work to
2138 be done on exactly how this behaves.
2140 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2142 * src/modest-account-mgr-helpers.h:
2143 * src/modest-account-mgr-helpers.c:
2144 Added modest_account_mgr_get_display_name(),
2145 modest_server_account_get_username(),
2146 modest_server_account_set_username(),
2147 modest_server_account_set_password(),
2148 modest_server_account_get_hostname() functions so we do not need to
2149 use the conf API directly.
2151 * src/maemo/modest-main-window.c: (connect_signals):
2152 Actually connect ot the ModestAccountStore::request-password signal,
2153 so that we show the dialog when the password is requested by Tinymail,
2154 for isntance if it is empty.
2156 * src/modest-marshal.list:
2157 * src/modest-tny-account-store.c:
2158 (modest_tny_account_store_class_init), (get_password),
2159 (modest_tny_account_store_alert):
2160 * src/modest-tny-account-store.h:
2161 * src/modest-ui-actions.h:
2162 * src/modest-ui-actions.c:
2163 (modest_ui_actions_on_password_requested):
2164 Change the signal parameters, so it is obvious that we are providing
2165 the non human-readable server name, and receiving both the username
2166 and password, though changing of the username is not yet implemented.
2167 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2168 for the GNOME version.
2170 This should fix the projects.maemo.org bug NB#56209, though it does not
2171 work on Bora, because the gconf_client_get() for the password fails
2172 immediately after we save it with gconf_client_set().
2174 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2177 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2178 caused an undefined symbol error:
2179 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2181 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2183 * src/modest-tny-account-store.c:
2184 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2185 using a GError instead of a string message, so we can translate it in
2188 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2190 * src/maemo/modest-address-book.c:
2191 (modest_address_book_check_names):
2192 * src/maemo/modest-msg-view-window.c:
2193 (modest_msg_view_window_clipboard_owner_change):
2194 * src/modest-init.c: (modest_init_init_ui):
2195 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2196 (update_folders_cb), (modest_mail_operation_update_account):
2197 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2198 (modest_ui_actions_on_msg_attachment_clicked),
2199 (modest_ui_actions_on_msg_recpt_activated):
2200 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2201 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2202 (modest_msg_view_search_next):
2203 * src/widgets/modest-recpt-editor.c:
2204 (modest_recpt_editor_on_button_release_event),
2205 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2206 g_message(). At this point we should only be seeing interesting errors on
2207 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2209 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2211 (modest_wizard_dialog_force_title_update):
2212 * src/maemo/easysetup/modest-wizard-dialog.h:
2213 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2214 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2215 can update the title when appropriate. Otherwise the title is wrong if the
2216 pages are added after adding the notebook to the dialog.
2217 This must be a problem in HildonWizardDialog too.
2218 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2220 * src/maemo/easysetup/modest-easysetup-wizard.c:
2221 (create_subsequent_customsetup_pages),
2222 (create_subsequent_easysetup_pages):
2223 Call modest_wizard_dialog_force_title_update() so that the title is
2224 correct even with GTK+ < 2.10.
2225 This fixes projects.maemo.org bug NB#56145 .
2227 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2229 * src/maemo/modest-platform.c:
2230 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2231 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2234 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2236 * src/widgets/modest-window.h:
2237 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2238 and modest_window_save_state(), which invokes it.
2240 * src/widgets/modest-window-mgr.h:
2241 * src/widgets/modest-window-mgr.c:
2242 Added modest_window_mgr_save_state_for_all_windows(), which calls
2243 the save_state vfunc on all registered windows, if implemented.
2245 * src/gnome/modest-msg-edit-window.c:
2246 * src/gnome/modest-msg-view-window.c:
2247 * src/maemo/modest-msg-edit-window.c:
2248 * src/maemo/modest-msg-view-window.c:
2249 * src/maemo/modest-main-window.c:
2250 Specify the existing save_settings functions as implementations of
2251 ModestWindow::save_state_func().
2253 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2254 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2255 enabling hibernation, for instance.
2257 We may need to do the same thing for restoring settings.
2260 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2262 * src/widgets/modest-window-mgr.c:
2263 * src/widgets/modest-window-mgr.h:
2264 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2265 modest_window_mgr_get_hibernation_is_prevented().
2267 * src/maemo/modest-main-window.c:
2268 (on_hildon_program_is_topmost_notify): Prevent hibernation
2269 (possible when the application goes to the background in the WM),
2270 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2272 * src/maemo/easysetup/modest-easysetup-wizard.c:
2273 (modest_easysetup_wizard_dialog_init):
2274 * src/maemo/modest-account-settings-dialog.c:
2275 (modest_account_settings_dialog_init):
2276 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2277 (modest_connection_specific_smtp_edit_window_init):
2278 * src/maemo/modest-connection-specific-smtp-window.c:
2279 (modest_connection_specific_smtp_window_init):
2280 * src/maemo/modest-signature-editor-dialog.c:
2281 (modest_signature_editor_dialog_init):
2282 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2283 prevent hibernation while any of these account settings dialogs are open.
2285 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/Makefile.am:
2288 * src/maemo/modest-osso-state-saving.c:
2289 * src/maemo/modest-osso-state-saving.h: Added
2290 modest_osso_load_state() and modest_osso_save_state() though they do
2291 nothing now. They should iterate through all the open windows and load/save
2293 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2294 save state when closing.
2296 * src/maemo/modest-main-window.c:
2297 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2298 Add a notification handler for the HildonProgram::is-topmost property,
2299 so we can allow hibernation when the application goes into the background.
2300 But we still need to detect when the accounts setup windows are open so
2301 we can stop hibernation when they are open.
2302 To do this, I also added the main window the HildonProgram. This might have
2303 other side-effects/benefits, and should maybe be done for other windows.
2305 * src/maemo/modest-osso-autosave-callbacks.h:
2306 * src/maemo/modest-osso-autosave-callbacks.c:
2307 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2308 though it does not do anything yet, and we might never need this to do
2309 anything. For instance, we already save drafts.
2311 * src/maemo/modest-platform.c: (modest_platform_init):
2312 Specify the libosso auto-save callback.
2314 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2316 * src/maemo/modest-platform.c:
2317 (modest_platform_set_update_interval):
2318 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2319 aparently stays valid between application instances, so we can use this
2320 to remove and reset it later. According to a maemo-developers email from
2323 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2325 * configure.ac: Depend on libalarm for Maemo.
2327 * src/dbus_api/modest-dbus-api.h:
2328 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2329 (on_send_receive), (modest_dbus_req_handler):
2330 Handle a SEND_RECEIVE D-Bus method.
2332 * libmodest-dbus-client/libmodest-dbus-client.c:
2333 (libmodest_dbus_client_send_and_receive):
2334 * libmodest-dbus-client/libmodest-dbus-client.h:
2335 Add C convenience functions for calling the new D-Bus method.
2337 * src/modest-platform.h:
2338 * src/gnome/modest-platform.c:
2339 * src/maemo/modest-platform.c:
2340 Added modest_platform_set_update_interval(), which uses the
2341 alarmd API on Maemo.
2342 (modest_platform_init),
2343 Call modest_platform_set_update_interval(), using a hard-coded
2344 interval for now (until the global settings dialog is implemented),
2345 though I am not sure that this makes sense yet.
2347 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2349 * src/dbus_api/modest-dbus-callbacks.c:
2350 (modest_osso_cb_hw_state_handler):
2351 * src/dbus_api/modest-dbus-callbacks.h:
2352 * src/maemo/modest-platform.c: (modest_platform_init):
2353 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2354 in case this has some effect on the ability for Maemo to ping the
2357 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2359 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2360 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2361 warning. It is probably a logic error, but I need to fix the build.
2363 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2365 * src/modest-account-mgr.h:
2366 * src/modest-account-mgr.c:
2367 (modest_account_mgr_account_names): Add a gboolean enabled_only
2368 parameter, so we can get lists of onlt the enabled accounts.
2370 (modest_account_mgr_add_account),,
2371 (modest_account_mgr_account_with_display_name_exists):
2372 * src/maemo/modest-msg-edit-window.c: (get_transports):
2373 * src/modest-account-mgr-helpers.c:
2374 (modest_account_mgr_set_first_account_as_default):
2375 * src/modest-init.c: (init_default_account_maybe):
2376 * src/modest-tny-account-store.c: (get_accounts):
2377 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2378 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2379 * tests/check_account-mgr.c: (START_TEST):
2380 Provide the extra parameter, as appropriate.
2382 * src/widgets/modest-account-view.c: (update_account_view):
2383 Do not show disabled accounts (meaning that there is no way to
2384 enable/disable accounts in the UI (the feature is not in our UI
2385 specification), so we can use this internally only to mark unfinished
2386 or temporary account data.
2388 * src/maemo/easysetup/modest-easysetup-wizard.c:
2389 (create_account): Add boolean enable parameter, so we can specify FALSE
2390 to create the temporary account.
2391 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2392 (on_before_next): When finishing, when there is a temporary account, just
2394 Also, use a timeout to delay the showing of the dialog until gconf is likely
2395 to return correct information, due to a maemo gconf bug that is fixed in
2396 osso 1.1, but not yet in Bora.
2397 However, the dialog stays on screen after it is destroyed.
2399 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2400 for invalid data when cancelling. Use a hildon note instead of a dialog
2401 to complain about invalid data. Do not show the account-saved note if the
2402 account is disabled (a temporary account that will not really be saved for use
2405 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2407 * src/modest-account-mgr-helpers.h:
2408 * src/modest-account-mgr-helpers.c:
2409 Added modest_account_mgr_unset_default_account(),
2410 Added modest_account_mgr_set_first_account_as_default().
2412 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2413 If it was the default account, unset the default account name.
2415 * src/maemo/modest-account-view-window.c:
2416 (on_delete_button_clicked): If it was the default account,
2417 set the first remaining account as the default instead.
2419 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2420 a NULL account or a NULL default account, to prevent a crash. This should
2421 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2424 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2426 * src/widgets/modest-recpt-editor.c:
2427 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2428 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2429 TODO comment for this. This fixes the build.
2431 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2432 be the best place for it. This will in future update all auto-update accounts,
2433 rather than just the current/default account, when that gconf key exists.
2434 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2435 if there are no accounts, before calling do_send_receive().
2436 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2438 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2439 * src/maemo/modest-main-window-ui.h:
2440 * src/maemo/modest-main-window.c: (on_connection_changed),
2441 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2442 directly, becaue the signal handler does more.
2444 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2446 * src/modest-account-mgr-helpers.c:
2447 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2448 for the case that the account does not exist.
2450 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2451 (equivalent to the modest account name) rather than the tinymail account name
2452 (equivalent to the modest account title - human readable) to get the account data.
2453 Check for null account data to prevent the crash, and add a TODO comment saying that
2454 this needs fixing because it is using the server account name instead of the account name.
2456 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2458 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2459 * src/maemo/modest-account-settings-dialog.c: (show_error),
2461 Use hildon_note_new_information() for informative and error messages,
2462 which seems to be expected for Maemo applications (no documentation that I know of
2463 says this). I am surprised that there is no distinction between info and error
2466 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2469 it is easy to find where this is used.
2471 * src/maemo/easysetup/modest-easysetup-wizard.c:
2472 (create_page_welcome), (create_page_account_details),
2473 (create_page_user_details), (create_page_complete_easysetup),
2474 (create_page_custom_incoming), (create_page_custom_outgoing),
2475 (create_page_complete_custom):
2476 * src/maemo/modest-account-settings-dialog.c:
2477 (create_page_account_details), (create_page_user_details),
2478 (create_page_incoming), (create_page_outgoing):
2479 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2480 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2481 (modest_connection_specific_smtp_edit_window_init):
2482 * src/maemo/modest-connection-specific-smtp-window.c:
2483 (modest_connection_specific_smtp_window_init):
2484 * src/maemo/modest-signature-editor-dialog.c:
2485 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2486 and scrolling policy as per the Email Application Layout Guide, if I have
2489 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2491 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2492 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2493 which were empty, because these vfuncs have been removed from TnyAccountStore.
2494 This fixes the build.
2496 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2498 * src/maemo/modest-main-window.c:
2499 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2500 showing/hiding it. Added TODO because it probably should not be NULL.
2501 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2502 because unnecessary g_warnings() make degugging difficult.
2504 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2506 * src/maemo/modest-msg-edit-window.c:
2507 (modest_msg_edit_window_select_color),
2508 (modest_msg_edit_window_select_background_color): 2 const corrections and
2509 moving 2 #endifs before closing brackets, to fix the build.
2511 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2513 * src/maemo/easysetup/modest-easysetup-wizard.h:
2514 * src/maemo/easysetup/modest-easysetup-wizard.c:
2515 (modest_easysetup_wizard_dialog_finalize),
2516 (on_button_edit_advanced_settings), (create_page_complete_custom),
2517 (on_response), (create_account):
2518 Implement the Advanced Settings edit button, by saving the account information,
2519 for the Advanded Settings dialog to use directly from gconf, and removing it
2520 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2521 Bug #5533 in the projects.maemo.org bugzilla.
2523 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2525 * src/maemo/modest-msg-view-window.c:
2526 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2527 when opening a message window.
2529 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/easysetup/modest-easysetup-wizard.c:
2532 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2535 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2536 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2537 gconf settings. I probably added more checks than necessary, but that is safer.
2539 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2540 variable to fix the build, but this seems to be used when it is still NULL.
2542 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-platform.h:
2545 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2546 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2547 * src/modest-main.c: Implement this function so we can avoid using
2548 maemo-specific API from cross-platform code.
2550 * src/modest-tny-account-store.c:
2551 (get_smtp_specific_transport_account_for_open_connection):
2552 * src/modest-ui-actions.c: (check_for_connection),
2553 (modest_ui_actions_on_item_not_found):
2554 Use modest_platform_connect_and_wait() and put #idefs around other
2555 maemo-specific code, because only maemo currently has a way to
2556 identify connection names.
2558 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2560 * src/modest-tny-account-store.h:
2561 * src/modest-tny-account-store.c:
2562 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2563 the connection-specific SMTP server settings in the configuration.
2565 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2567 * src/maemo/modest-main-window.c: (on_connection_changed),
2569 * src/modest-main.c: (main), (start_ui), (send_mail):
2570 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2571 that is what is intended.
2573 * src/modest-ui-actions.c: (action_send), (action_receive),
2574 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2575 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2576 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2577 SMTP server is used when it is specified.
2579 (modest_ui_actions_on_send_receive):
2580 Check that a connection is open before proceeding.
2581 Receive and then send, instead of vice-versa, as per the specification.
2583 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2585 * src/modest-mail-operation.c:
2586 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2587 though I guess it should be something other than NULL.
2589 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2591 * src/maemo/easysetup/modest-easysetup-wizard.c:
2592 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2593 combo twice, to avoid an g_warning and to make it visible again.
2594 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2595 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2596 (already intended) dereference when detaching, because we then recreate the menu.
2597 But I am not sure why the warning was happening, and it is possible that this is a memory
2600 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2602 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2603 and uri_parse_mailto() utility functions.
2604 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2606 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2608 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2610 * src/dbus_api/modest-dbus-api.h:
2611 * src/dbus_api/modest-dbus-callbacks.c:
2612 Use an idle callback to execute the modest code in the application's own thread.
2613 Remove the helloworld example method.
2614 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2615 parsed, and the open-message method is not implemented because this is not yet implemented in
2617 * libmodest-dbus-client/libmodest-dbus-client.c:
2618 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2619 (libmodest_dbus_client_open_message):
2620 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2622 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2623 body without crashing.
2625 * tests/dbus_api/Makefile.am:
2626 * tests/dbus_api/test_mail_to.c:
2627 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2629 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2631 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2632 Added file to fix the build. Sorry.
2634 * src/dbus_api/Makefile.am:
2635 * src/dbus_api/modest-dbus-api.h:
2636 * src/dbus_api/modest-dbus-callbacks.h:
2637 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2638 (modest_dbus_req_handler):
2639 Put constants in a separate header so it can be reused by the
2640 client library, without duplication
2642 * libmodest-dbus-client/Makefile.am:
2643 * libmodest-dbus-client/libmodest-dbus-client.c:
2644 (libmodest_dbus_client_call_helloworld),
2645 (libmodfest_dbus_client_send_mail),
2646 (libmodfest_dbus_client_mailto),
2647 (libmodfest_dbus_client_open_message):
2648 * libmodest-dbus-client/libmodest-dbus-client.h:
2649 (Partly) Implement a send_mail D-Bus method.
2651 * tests/dbus_api/Makefile.am:
2652 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2653 the send_email D-Bus method.
2655 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2659 * libmodest-dbus-client/Makefile.am:
2660 * libmodest-dbus-client/libmodest-dbus-client.c:
2661 * libmodest-dbus-client/libmodest-dbus-client.h:
2662 * tests/dbus_api/Makefile.am:
2663 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2664 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2666 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/easysetup/modest-easysetup-wizard.c:
2669 (create_page_account_details):
2670 * src/maemo/modest-account-settings-dialog.c:
2671 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2672 widgets, because this might not be the default in future versions of the Maemo GTK+.
2673 However, I can not not get capitalization to work even in a simple test case.
2675 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/easysetup/modest-easysetup-wizard.c:
2678 (create_page_custom_incoming), (create_page_custom_outgoing):
2679 * src/maemo/modest-account-settings-dialog.c:
2680 (create_page_account_details), (create_page_incoming),
2681 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2682 instead of using gtk_check_button_with_label(), so they are aligned like the other
2683 widgets, as per the UI spec.
2685 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2687 * src/maemo/easysetup/modest-easysetup-wizard.c:
2688 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2689 * src/widgets/modest-validating-entry.c:
2690 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2691 Modest prefix instead of an EasySetup prefix.
2693 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2695 * src/widgets/modest-validating-entry.h:
2696 * src/widgets/modest-validating-entry.c: (on_insert_text),
2697 Added easysetup_validating_entry_set_max_func(), used to set a callback
2698 to call when the max number of characters is reached. GtkEntry has a max-length
2699 already but is silent about it.
2701 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2702 (create_page_account_details), (create_page_user_details),
2704 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2705 (create_page_account_details), (create_page_user_details),
2706 (create_page_outgoing):
2707 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2708 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2709 the UI spec, when the user tries to enter more than the max number of characters.
2711 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2713 * src/maemo/easysetup/modest-easysetup-wizard.c:
2714 (create_page_user_details), (create_page_custom_incoming),
2715 (create_page_custom_outgoing):
2716 * src/maemo/modest-account-settings-dialog.c:
2717 (create_page_user_details), (create_page_incoming),
2718 (create_page_outgoing):
2719 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2720 (modest_connection_specific_smtp_edit_window_init):
2721 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2722 not appropriate. Bad Maemo-specific defaults!.
2724 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2726 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2727 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2728 (modest_signature_editor_dialog_set_settings):
2729 Disable the label and textview when the checkbox is disabled, and use the
2730 specified (UI spec) default signature text.
2732 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2735 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2737 * src/modest-defs.h:
2738 * src/modest-account-mgr-helpers.h:
2739 * src/modest-account-mgr-helpers.c:
2740 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2742 * src/maemo/Makefile.am:
2743 * src/maemo/modest-signature-editor-dialog.c:
2744 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2747 * src/maemo/modest-account-settings-dialog.h:
2748 * src/maemo/modest-account-settings-dialog.c:
2749 (modest_account_settings_dialog_finalize), (on_button_signature),
2750 (save_configuration): Use the new dialog when the Edit button is pressed, and
2751 save the changes if necessary, as per the UI spec.
2753 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/Makefile.am:
2756 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2757 based on maemo-develoers email from Dirk.
2759 * src/maemo/easysetup/modest-easysetup-wizard.c:
2760 (create_page_welcome), (create_page_account_details),
2761 (create_page_user_details), (create_page_complete_easysetup),
2762 (create_page_custom_incoming), (create_page_custom_outgoing),
2763 (create_page_complete_custom),
2764 (modest_easysetup_wizard_dialog_init):
2765 * src/maemo/modest-account-settings-dialog.c:
2766 (create_page_account_details), (create_page_user_details),
2767 (create_page_incoming), (create_page_outgoing),
2768 (modest_account_settings_dialog_init):
2769 * src/maemo/modest-connection-specific-smtp-window.c:
2770 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2772 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/easysetup/modest-easysetup-wizard.c:
2775 (create_page_account_details), (create_page_custom_outgoing),
2776 (create_page_complete_custom):
2777 * src/maemo/modest-account-settings-dialog.c:
2778 (create_page_user_details), (create_page_incoming),
2779 (create_page_outgoing):
2780 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2781 (modest_connection_specific_smtp_edit_window_init):
2782 Use the correct (UI spec) port min/max, and use horizontal separators,
2785 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/easysetup/modest-easysetup-wizard.c:
2788 (set_default_custom_servernames):
2789 * src/maemo/modest-account-settings-dialog.c:
2790 (create_page_incoming), (on_combo_outgoing_security_changed),
2791 (on_combo_incoming_security_changed), (create_page_outgoing),
2792 (modest_account_settings_dialog_set_account_name),
2793 (save_configuration):
2794 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2795 (on_combo_security_changed),
2796 (modest_connection_specific_smtp_edit_window_init),
2797 (modest_connection_specific_smtp_edit_window_set_connection),
2798 (modest_connection_specific_smtp_edit_window_get_settings):
2799 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2802 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/easysetup/modest-easysetup-wizard.c:
2806 (create_page_custom_outgoing), (create_page_complete_custom):
2807 * src/maemo/modest-account-settings-dialog.c:
2808 (create_page_user_details), (create_page_outgoing):
2809 * src/maemo/modest-account-view-window.c: (button_box_new):
2810 Use changed logical IDs as per the most recent UI spec:
2811 mcen_bd_emailsetup_edit -> mcen_bd_edit
2812 mcen_bd_emailsetup_delete -> mcen_bd_delete
2813 mcen_bd_emailsetup_close -> mcen_bd_close
2815 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2819 * src/dbus_api/Makefile.am:
2820 * src/dbus_api/modest-dbus-callbacks.c:
2821 * src/dbus_api/modest-dbus-callbacks.h:
2822 * src/maemo/modest-platform.c: (modest_platform_init):
2823 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2825 * tests/Makefile.am:
2826 * tests/dbus_api/Makefile.am:
2827 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2829 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2831 * src/maemo/modest-account-settings-dialog.c:
2832 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2833 Removed unnecessary includes.
2835 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2837 * src/maemo/easysetup/modest-easysetup-wizard.c:
2838 * src/maemo/modest-account-settings-dialog.c:
2839 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2840 * src/widgets/Makefile.am:
2841 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2842 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2843 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2844 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2845 * src/widgets/modest-secureauth-combo-box.c:
2846 * src/widgets/modest-secureauth-combo-box.h:
2847 * src/widgets/modest-serversecurity-combo-box.c:
2848 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2849 made the GObject names more consistent with the rest of the Modest code.
2851 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2853 * src/maemo/easysetup/Makefile.am:
2854 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2855 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2856 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2857 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2858 * src/maemo/easysetup/modest-easysetup-wizard.c:
2859 * src/maemo/easysetup/modest-validating-entry.c:
2860 * src/maemo/easysetup/modest-validating-entry.h:
2861 * src/maemo/modest-account-settings-dialog.c:
2862 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2863 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2864 widgets/ because they are used outside of easysetup too. After checking in,
2865 svn will allow me to rename them too.
2867 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2869 * src/gnome/modest-msg-edit-window.c:
2870 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2871 linker error, to fix the build on the GNOME platform.
2872 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2873 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2874 ifdefed out to avoid a warning.
2876 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2878 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2879 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2880 some alternative for GTK+ 2.6.
2882 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2886 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2887 specified for EmailAccountsDialog in UI spec.
2889 * src/maemo/easysetup/modest-easysetup-wizard.c:
2890 * src/maemo/easysetup/modest-easysetup-wizard.h:
2891 * src/maemo/modest-account-settings-dialog.c:
2892 * src/maemo/modest-account-settings-dialog.h:
2893 Reuse a member window widget for the connection-specific SMTP server accounts,
2894 so we can tell it to create/save the accounts only if we actually save changes.
2896 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2897 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2898 (modest_connection_specific_smtp_edit_window_get_settings):
2899 Return a struct instance for temporarily remembering the entered data.
2901 * src/maemo/modest-connection-specific-smtp-window.h:
2902 * src/maemo/modest-connection-specific-smtp-window.c:
2903 (modest_connection_specific_smtp_window_finalize),
2904 (modest_connection_specific_smtp_window_fill_with_connections),
2906 (modest_connection_specific_smtp_window_save_server_accounts),
2907 (update_model_server_names): Do not actually save data until asked,
2908 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2910 (on_selection_changed),
2911 (modest_connection_specific_smtp_window_init): Disable the edit
2912 button when nothing is selected.
2914 * src/modest-account-mgr-helpers.c:
2915 * src/modest-account-mgr-helpers.h:
2916 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2919 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2921 * src/modest-account-mgr-helpers.h:
2922 * src/modest-account-mgr-helpers.c:
2923 (modest_account_mgr_get_unused_account_name),
2924 (modest_account_mgr_get_unused_account_display_name): Added these
2925 utility functions, to avoid code duplication.
2927 * src/maemo/easysetup/modest-easysetup-wizard.c:
2928 (create_page_account_details), (create_account):
2929 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2930 (on_combo_security_changed),
2931 (modest_connection_specific_smtp_edit_window_init),
2932 (modest_connection_specific_smtp_edit_window_save_settings):
2933 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2934 * src/maemo/modest-connection-specific-smtp-window.c:
2935 (modest_connection_specific_smtp_window_finalize),
2936 (modest_connection_specific_smtp_window_fill_with_connections),
2937 (on_button_edit), (modest_connection_specific_smtp_window_init):
2938 * src/maemo/modest-connection-specific-smtp-window.h:
2939 Implementing saving of connection-specific server accounts.
2941 But I need to refactor this so we can save the data for each
2942 possible connection-specific account and only actually create the server accounts
2943 when the easysetup finished, or the OK button is pressed on the account settings
2946 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2948 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2949 (on_combo_security_changed):
2950 (modest_connection_specific_smtp_edit_window_init):
2951 Auto-fill the port number as in the account settings.
2953 (modest_connection_specific_smtp_edit_window_set_connection):
2954 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2955 * src/maemo/modest-connection-specific-smtp-window.c:
2956 (fill_with_connections), (on_button_edit),
2957 (modest_connection_specific_smtp_window_init):
2958 Turn the edit window into a dialog to simplify the code, and
2959 set a WM hint as in a GtkDialog, because only a popup can be on top of
2960 another window in Maemo, and popups usually have no WM decoration.
2962 * src/modest-defs.h:
2963 * src/modest-account-mgr-helpers.c:
2964 (modest_account_mgr_set_connection_specific_smtp),
2965 (modest_account_mgr_remove_connection_specific_smtp),
2966 (modest_account_mgr_get_connection_specific_smtp):
2967 * src/modest-account-mgr-helpers.h: Some functions to write the
2968 connection-specific SMTP server information. Not yet used.
2971 * src/widgets/modest-folder-view.c: (text_cell_data):
2972 Fix a warning about an uninitialized variable.
2973 (on_configuration_key_changed): Put an #ifdef around the use
2974 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2976 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2978 * src/maemo/modest-account-settings-dialog.h:
2979 * src/maemo/modest-account-settings-dialog.c:
2980 Added connect_for_modified() utility function to mark the new modified boolean.
2982 (create_page_account_details), (create_page_user_details),
2983 (create_page_incoming), (create_page_outgoing), (on_response),
2984 (modest_account_settings_dialog_init),
2985 (modest_account_settings_dialog_set_account_name):
2986 Only warn about unsaved changes when there are actually unsaved changes.
2988 * src/modest-account-mgr-helpers.c:
2989 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2990 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2991 to get the data from there in future.
2993 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2995 * src/modest-defs.h:
2997 * src/modest-account-mgr-helpers.h:
2998 * src/modest-account-mgr-helpers.c:
2999 Store the security account setting in a single conf key instead of using
3000 the options list, so that the list is left for just the to-be-removed camel hack,
3001 and because gconf_client_set_list() is failing for some reason.
3003 * src/modest-account-mgr.c:
3004 (modest_account_mgr_add_server_account):
3005 * src/maemo/modest-account-settings-dialog.c:
3006 (modest_account_settings_dialog_set_account_name),
3007 (save_configuration): Use the renamed functions.
3010 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3012 * src/widgets/Makefile.am:
3013 * src/widgets/modest-limit-retrieve-combo-box.c:
3014 * src/widgets/modest-limit-retrieve-combo-box.h:
3015 * src/widgets/modest-retrieve-combo-box.c:
3016 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3017 the account settings dialog.
3019 * src/modest-defs.h:
3020 * src/modest-account-mgr-helpers.h:
3021 * src/modest-account-mgr-helpers.c:
3022 (modest_server_account_get_option_secure_auth),
3023 (modest_server_account_set_option_secure_auth):
3024 * src/modest-account-mgr.c:
3025 (modest_account_mgr_add_server_account):
3026 Use the existing AUTH_MECH conf key for the secure-auth setting,
3027 instead of putting it in the list options, because this was actually used already.
3029 * src/maemo/modest-account-settings-dialog.c:
3030 (create_page_account_details),
3031 (modest_account_settings_dialog_set_account_name),
3032 (save_configuration):
3033 * src/maemo/modest-account-settings-dialog.h:
3034 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3035 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3037 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3039 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3040 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3041 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3043 * src/modest-defs.h:
3044 * src/maemo/modest-account-settings-dialog.c:
3045 (create_page_incoming), (on_combo_outgoing_security_changed),
3046 (on_combo_incoming_security_changed), (create_page_outgoing),
3047 (modest_account_settings_dialog_set_account_name),
3048 (save_configuration): Load/Save the port number, and change it when the
3049 security combo changes, to suitable defaults.
3051 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3053 * src/modest-account-mgr.c:
3054 (modest_account_mgr_add_server_account): Set the security and secure-auth
3055 options, and add a comment saying that the other camel-specific options should be
3058 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3060 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3062 * src/modest-tny-account-store.c: (account_list_free),
3063 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3064 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3067 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3069 * src/modest-protocol-info.c:
3070 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3071 is required by our UI spec. Maybe something in our implementation will use this eventually.
3072 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3073 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3074 instead of the previous 0 placeholder.
3076 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3077 secure-auth settings.
3078 * src/modest-account-mgr-helpers.h:
3079 * src/modest-account-mgr-helpers.c:
3080 (modest_server_account_data_get_option_secure_auth),
3081 (modest_server_account_set_option_secure_auth),
3082 (modest_server_account_data_get_option_security),
3083 (modest_server_account_set_option_security): Added this API for getting and setting the security
3084 and secure-auth settings.
3086 * src/maemo/modest-account-settings-dialog.h:
3087 * src/maemo/modest-account-settings-dialog.c:
3088 (modest_account_settings_dialog_finalize), (check_data),
3089 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3090 about changing titles.
3091 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3092 (save_configuration): Save the security and secure-auth settings.
3094 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3095 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3097 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3099 * src/modest-defs.h:
3100 * src/modest-account-mgr.c:
3101 (modest_account_mgr_add_server_account):
3102 Added and used defines for the options key and value pair strings,
3103 that are used so far, though they do not seem to correspond to anything in our
3104 UI specs or ModestProtocol enum.
3106 * src/modest-account-mgr-helpers.h:
3107 * src/modest-account-mgr-helpers.c:
3108 (compare_option_strings_for_name),
3109 (modest_server_account_data_get_option_value),
3110 (modest_server_account_data_get_option_bool),
3111 (modest_account_mgr_get_server_account_option):
3112 Added helper functions for parsing the options GSList.
3114 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3116 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3117 display name is based on the supplied account name.
3118 * src/modest-account-mgr.c:
3119 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3120 with an inefficient, but good-enough, implementation.
3122 * src/maemo/easysetup/modest-easysetup-wizard.c:
3123 (create_page_account_details), (on_before_next), (create_account):
3124 Check for existing display names rather than (non-user-visible) account names, and just
3125 create and set a unique account name at the end.
3127 * src/maemo/modest-account-settings-dialog.c:
3128 (modest_account_settings_dialog_init),
3129 (modest_account_settings_dialog_set_account_name),
3130 (create_page_incoming): Show the display name, instead of the account name.
3131 (on_response): Do some (not all) extra checks, as in the UI spec.
3132 (save_configuration): Save the display name if it was changed.
3134 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3136 * po/en_GB.po: Added needed logical ID and translation.
3137 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3138 (init_view): Made the is-default column clicking work.
3140 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3143 * src/maemo/easysetup/Makefile.am:
3144 * src/maemo/easysetup/modest-easysetup-wizard.c:
3145 (modest_easysetup_wizard_dialog_init):
3146 * src/maemo/easysetup/provider-data-test.keyfile:
3147 * src/maemo/easysetup/provider-data.keyfile:
3148 Moved the provider data file to the new modest-providers-data package and used it from there.
3150 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3152 * src/modest-local-folder-info.c:
3153 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3154 N_() was already used on the static strings, but this just marks it for translation without
3155 using the translation.
3157 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3159 * src/maemo/modest-account-settings-dialog.c:
3160 (create_page_incoming),
3161 (modest_account_settings_dialog_set_account_name):
3162 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3163 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3164 I will do this if nobody else gets there first.
3166 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3168 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3169 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3170 save the security stuff.
3172 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3174 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3175 Set the email address and user fullname, which I now see must be
3178 * src/maemo/modest-account-settings-dialog.h:
3179 * src/maemo/modest-account-settings-dialog.c:
3181 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3182 leave-on-server and authentication.
3183 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3186 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3189 * src/maemo/modest-account-settings-dialog.c:
3190 * src/maemo/modest-account-settings-dialog.h:
3191 Most (but not all) of the widgets are now present as specified by the UI spec.
3192 No changes are yet saved, and some details are not properly shown yet.
3194 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3196 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3198 * src/maemo/Makefile.am:
3199 * src/maemo/modest-account-settings-dialog.c:
3200 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3201 an existing account. Doesn't do much yet.
3203 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3204 Open the accounts settings dialog when Edit is clicked.
3206 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3208 * src/maemo/easysetup/Makefile.am:
3209 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3211 * src/maemo/easysetup/modest-easysetup-wizard.c:
3212 (modest_easysetup_wizard_dialog_init):
3213 Try to get the source directory from the build system,
3214 instead of hard-coding "./" into the source code, when opening our local
3215 copies of the configuration files.
3216 But this still fails when opening the wizard from the Accounts window,
3217 maybe because the working directory seems to change at runtime.
3218 So the wizard will fail the second time unless you copy the files into their
3219 proper locations - see the stdout warnings for the paths.
3221 (create_page_account_details),(on_before_next):
3222 Check for existing non-server accounts instead of server accounts,
3223 so the default account name is useful again, and to prevent trying to
3226 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3227 Show the wizard when New is clicked.
3229 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3230 (init_view): Show the column headers, and show the columns that are
3231 specified in the UI specs. However, something in Maemo's GTK+ prevents
3232 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3233 change the default account. This is despite unsetting the special properties.
3235 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3237 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3238 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3239 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3240 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3241 to make that clearer.
3242 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3244 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3246 * src/maemo/modest-account-view-window.c:
3247 (modest_account_view_window_init),
3248 (modest_account_view_window_new):
3249 Use the same buttons as specified in the
3250 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3251 the existing widgets, which never had a chance of working.
3252 Put the ModestAccountView treeview in a scrolled window.
3253 Do not repeat the initialization in both _init() and _new().
3255 * src/widgets/modest-account-view.c: (update_account_view):
3256 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3257 this widget and window shows no accounts.
3259 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3261 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3263 * src/maemo/easysetup/modest-easysetup-wizard.c:
3264 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3265 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3266 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3269 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3270 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3271 accounts exist yet, as in the UI spec.
3273 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3275 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3277 * src/maemo/Makefile.am:
3278 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3279 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3280 New window for editing connection-specific smtp details.
3281 Not fully implemented.
3283 * src/maemo/modest-connection-specific-smtp-window.c:
3284 (modest_connection_specific_smtp_window_finalize) :
3285 unref the tree model.
3286 (on_button_edit): Show the edit window.
3288 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3290 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3293 * src/maemo/Makefile.am:
3294 * src/maemo/modest-connection-specific-smtp-window.c:
3295 * src/maemo/modest-connection-specific-smtp-window.h:
3296 New window for showing the list of connections, for connection-specific
3297 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3298 * src/maemo/easysetup/modest-easysetup-wizard.c:
3299 (create_page_custom_outgoing): Show the new window when the button is clicked.
3301 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3303 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3304 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3305 * src/maemo/modest-msg-edit-window.c:
3306 (modest_msg_edit_window_insert_image):
3307 * src/modest-conf.c: (modest_conf_key_escape):
3308 * src/modest-mail-operation.c:
3309 (modest_mail_operation_send_new_mail):
3310 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3311 (modest_ui_actions_on_new_account):
3312 * src/widgets/modest-attachment-view.c: (update_filename_request):
3313 * src/widgets/modest-mail-header-view.c:
3314 Corrected warnings that were breaking the build, by commenting out unused variables,
3315 and a function, and by including a header.
3317 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3319 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3320 so we can #ifdef around platform-specific code when necessary.
3321 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3322 to allow this to build for the GNOME platform too.
3324 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3326 * src/maemo/easysetup/modest-easysetup-wizard.c:
3327 Added util_increment_name() and used it in create_page_account_details()
3328 to make sure that the default account name is always a new name.
3330 (modest_easysetup_wizard_dialog_init),
3331 (set_default_custom_servernames): Some minor memory management fixes.
3333 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3337 * src/modest-runtime.c: (init_i18n): Restored the translation
3338 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3339 are defined in config.h, and the translations are installed.
3341 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3342 is defined for translation.
3344 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3346 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3348 * src/maemo/easysetup/modest-easysetup-wizard.c:
3349 (modest_easysetup_wizard_dialog_init):
3350 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3351 Use realistic paths (though they should use $prefix generically) to the
3352 mcc_mapping and provider-data.keyfile files which might work when they
3353 are installed by the future version of the operator-wizard package,
3354 and then fallback to paths in our source code, with an explanatory
3357 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3361 * src/maemo/Makefile.am:
3362 * src/maemo/easysetup/: Added files from the previously-exernal
3363 osso-modest-easysetup.
3364 * src/maemo/modest-main-window-ui.h:
3365 * src/modest-ui-actions.c:
3366 * src/modest-ui-actions.h:
3367 Added modest_ui_actions_on_new_account() as a signal handler for the
3368 New Account menu item. It shows the easysetup wizard.
3369 * po/en_GB.po: Added additional needed logical IDs and translations.