1 2007-06-11 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
4 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
5 when no country was selected, so that we show the global ones.
6 * src/maemo/easysetup/modest-presets.c:
7 (modest_presets_get_providers): Return only the global providers, not
8 all providers when mmc=0 was requested.
10 2007-06-11 Murray Cumming <murrayc@murrayc.com>
12 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
13 (easysetup_provider_combo_box_fill): Remove debug code that showed the
14 provider ID in the combo.
16 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
17 Do not show the page numbers, because it would be confusing when we add
18 the 2 extra pages for the custom setup, when the user chooses the "Other"
19 provider. This fixes projects.maemo.org bug NB#59028
21 * src/modest-init.c: (modest_init_init_core),
22 (modest_init_local_folders):
24 * src/modest-tny-account.c:
25 (modest_tny_account_new_for_local_folders): Do not create default folders
26 for the memory card. This should fix projects.maemo.org bug NB#59328.
28 2007-06-11 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
31 Free the changed_conf_keys string items. They are already freed in the
32 idle handler if that runs first.
34 2007-06-11 Murray Cumming <murrayc@murrayc.com>
36 * src/modest-ui-actions.c:
37 (modest_ui_actions_on_password_requested): Check that the server name
38 is not NULL, because I just saw a password dialog with (null) as the
41 * src/modest-tny-folder.[h|c]: Added
42 modest_tny_folder_is_memory_card_folder().
43 * src/modest-ui-dimming-rules.c:
44 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
45 menu item for memory cards, as per the UI spec (section 7.4). This should
46 fix projects.maemo.org bug NB#59297.
48 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
50 * src/maemo/modest-main-window.c: (sync_accounts_cb):
51 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
52 is another problem with the code, see Murray's comment at line 772)
54 2007-06-08 Murray Cumming <murrayc@murrayc.com>
56 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
57 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
58 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
59 (load_from_file), (easysetup_country_combo_box_init),
60 (easysetup_country_combo_box_get_active_country_ids),
61 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
62 instead of just one ID, to avoid duplicate country names in the UI.
64 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
65 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
66 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
67 a single ID, avoiding duplicate providers.
68 * src/maemo/easysetup/modest-easysetup-wizard.c:
69 (on_combo_account_country): Adapt to use a list.
71 2007-06-08 Murray Cumming <murrayc@murrayc.com>
73 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
74 keys changed in the last X seconds.
76 * src/modest-account-mgr.h:
77 * src/modest-account-mgr.c: (on_timeout_notify_changes),
78 (on_key_change), (modest_account_mgr_class_init),
79 (modest_account_mgr_init), (modest_account_mgr_finalize):
80 As the keys are changed, save them in a GSList* and signal that GSList*
81 further every X seconds, to batch changes, to allow us to do just one
82 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
83 bug NB#56941 and other (UI-blocking) delays when changing account settings.
85 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
86 changed signal signature.
88 * src/modest-conf.c: (modest_conf_set_list),
89 (modest_conf_on_change): Reenable notification.
91 (modest_conf_maemo_fake_on_change): Comment out the hack that
92 notified immediately instead of asynchronously.
94 * src/widgets/modest-account-view.h:
95 * src/widgets/modest-account-view.c:
96 (update_account_view): Select the previously-selected account ID,
97 if possible. This fixes projects.maemo.org bug NB#56933.
99 (on_account_changed), (on_account_removed),
100 (modest_account_view_select_account):
102 Remove the block/unblock functions
103 because they were not useful.
105 * src/maemo/modest-account-view-window.c:
106 (on_delete_button_clicked), (on_edit_button_clicked),
107 (on_new_button_clicked): Remove the use of the non-working block/unblock.
109 2007-06-08 Murray Cumming <murrayc@murrayc.com>
111 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
112 Improve the error dialog to show Incorrect Account Settings, which seems
113 clearer, and say that the internal error message (to be removed from the
114 dialog later) is often misleading.
115 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
117 * src/modest-tny-account.c:
118 (modest_tny_account_new_from_server_account): Uncomment the printf of the
119 URL because this is so useful for debugging on the device.
121 * src/widgets/modest-serversecurity-combo-box.c:
122 (modest_serversecurity_combo_box_fill): Correct a logical ID.
124 2007-06-08 Murray Cumming <murrayc@murrayc.com>
126 * src/modest-mail-operation.c:
127 (modest_mail_operation_send_new_mail):
128 Added a comment about a nasty but apparently harmless message. Details
129 added to the wiki g_warnings() page.
131 2007-06-08 Murray Cumming <murrayc@murrayc.com>
133 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
134 (modest_tny_send_queue_class_init):
135 Do not use the priv struct because it is empty, to avoid g_warnings
136 about a non-existant priv struct.
138 * src/modest-tny-account-store.c:
139 (modest_tny_account_store_get_server_account),
140 (modest_tny_account_store_get_transport_account_for_open_connection
141 ): Do not try to get transport server accounts for local folders,
142 because they don't have any. This avoids a g_warning().
144 * src/maemo/modest-main-window.c:
145 (modest_main_window_notify_send_receive_initied),
146 (on_configuration_key_changed):
147 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
149 * src/modest-mail-operation.c:
150 (modest_mail_operation_update_account):
151 * src/modest-tny-account-store.h:
152 * src/modest-tny-account.c:
153 (modest_tny_account_get_special_folder),
154 (modest_tny_account_new_for_local_folders),
155 (modest_tny_account_new_for_per_account_local_outbox_folder):
156 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
157 * src/modest-tny-local-folders-account.c:
158 (add_account_folders_to_merged_folder):
159 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
160 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
161 (modest_ui_actions_on_send):
162 * src/widgets/modest-folder-view.c: (update_model):
163 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
164 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
165 modest_tny_account_store_get_tny_account_by_account() to
166 modest_tny_account_store_get_server_account() to make the code clearer.
168 2007-06-07 Marcus Bauer <marcusb@openismus.com>
170 * src/dbus_api/modest-dbus-api.h:
171 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
172 * src/maemo/modest-msg-edit-window.c:
173 (modest_msg_edit_window_attach_file_noninteractive):
174 added g_warning in case the file to be attached does not exist
175 * tests/dbus_api/test_compose_mail.c: (main):
176 removed obsolete comment, added generic files as test case
178 2007-06-07 Murray Cumming <murrayc@murrayc.com>
180 * src/modest-tny-account-store.c: (get_server_accounts):
181 Create the local folders account only once, not once for each outbox, and
182 not only when there are some outboxes.
184 2007-06-07 Murray Cumming <murrayc@murrayc.com>
186 * src/widgets/modest-folder-view.c: (update_model): Comment out some
187 code that is causing a crash at startup. Sergio says that he is fixing this.
189 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
191 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
192 * src/maemo/modest-account-settings-dialog.c:
193 (create_page_outgoing),
194 (modest_account_settings_dialog_set_account_name),
195 (save_configuration):
196 - Fixed handling of the "Use secure authentication" toggle to comply with
197 the ui specification. See also projects.maemo.org bug NB#58400
199 - Restore the Secure connection setting combo correctly when loading
202 * src/maemo/modest-maemo-utils.c:
203 (on_camel_account_get_supported_secure_authentication),
204 (modest_maemo_utils_get_supported_secure_authentication_methods):
205 Fixed a crasher if operation is canceled
207 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
208 (modest_protocol_info_auth_is_secure):
209 * src/modest-protocol-info.h:
211 Added two new methods to determine if a protocol/auth method is secure/encrypted in
212 the sense of the "Use secure authentication" toggle.
214 2007-06-07 Murray Cumming <murrayc@murrayc.com>
216 * src/modest-tny-account-store.h:
217 * src/modest-tny-account-store.c:
218 Added modest_tny_account_store_get_local_folders_account().
220 * src/modest-tny-folder.h:
221 * src/modest-tny-folder.c:
222 (modest_tny_folder_get_account):
223 Added this replacement for tny_folder_get_account() which returns
224 the local-folders account for TnyMergeFolders, to avoid the
225 warning about the unimplemented get_account_func() vfunc().
227 (modest_tny_folder_get_rules),
228 * src/modest-ui-actions.c:
229 (modest_ui_actions_on_folder_selection_changed):
230 * src/modest-mail-operation.c:
231 (modest_mail_operation_remove_folder),
232 (modest_mail_operation_xfer_folder),
233 (modest_mail_operation_rename_folder),
234 (modest_mail_operation_get_msg),
235 (modest_mail_operation_get_msgs_full),
236 (modest_mail_operation_remove_msg),
237 (modest_mail_operation_xfer_msgs),
238 (modest_mail_operation_refresh_folder):
239 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
241 2007-06-07 Murray Cumming <murrayc@murrayc.com>
243 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
244 (modest_server_account_set_security):
245 * src/modest-defs.h: Add comments explaining that our
246 UI spec means TLS when it says Normal, so these do not look like errors.
248 * src/modest-tny-account.c:
249 (modest_tny_account_new_from_server_account): Use the new tinymail
250 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
251 for TLS. This should fix projects.maemo.org bug NB#58460.
253 2007-06-06 Murray Cumming <murrayc@murrayc.com>
255 * src/maemo/easysetup/modest-easysetup-wizard.c:
256 (create_account): Correct the position of the gconf sanity check warning.
257 (on_button_edit_advanced_settings): Show the dialog immediately, instead
258 of using the g_idle_add() hack, because this does not seem to be necessary
259 on osso 1.1. It might even work on Maemo Bora if the problems were actually
260 caused by something other than maemo's gconf.
261 This fixes projects.maemo.org bug #59022.
263 2007-06-06 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-account-mgr-helpers.c:
266 (modest_account_mgr_get_default_account): Do not check that the account
267 exists if there is no default account (NULL), to fix a runtime warning.
269 2007-06-06 Murray Cumming <murrayc@murrayc.com>
271 * src/widgets/modest-folder-view.c: (update_model):
272 Do not unref the treemodel before we have finished with it.
273 This prevents a valgrind warning and an occasional crash at startup.
275 2007-06-06 Marcus Bauer <marcusb@openismus.com>
277 * libmodest-dbus-client/libmodest-dbus-client.h:
278 added libmodest_dbus_client_compose_mail()
279 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
281 added functions needed for SendAsMail() functionality
282 * src/maemo/modest-msg-edit-window.c:
283 (modest_msg_edit_window_attach_file_noninteractive):
284 non interactively attaching files to message edit window
285 * src/widgets/modest-msg-edit-window.h:
286 * tests/dbus_api/Makefile.am:
287 added test_compose_mail.c
288 * tests/dbus_api/test_compose_mail.c: (main):
290 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
292 * src/modest-account-view.c:
293 Fixed bug projects.maemo.org bug NB#59307
295 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
297 * src/maemo/easysetup/modest-easysetup-wizard.c:
298 (get_serverport_incoming), (on_before_next), (create_account):
299 * src/maemo/modest-account-settings-dialog.c:
300 (modest_account_settings_dialog_set_account_name):
301 * src/maemo/modest-maemo-utils.c:
302 (on_camel_account_get_supported_secure_authentication_status),
303 (on_camel_account_get_supported_secure_authentication),
304 (on_secure_auth_cancel),
305 (modest_maemo_utils_get_supported_secure_authentication_methods):
307 Implemented security authentication for settings and easysetup.
309 2007-06-05 Murray Cumming <murrayc@murrayc.com>
311 * src/maemo/modest-main-window.c: (create_details_widget):
312 Show the total size for memory card accounts too, instead of showing
313 the name again. Fixes bug projects.maemo.org bug NB#59307.
315 2007-06-05 Murray Cumming <murrayc@murrayc.com>
318 * src/modest-tny-simple-folder-store.c:
319 * src/modest-tny-simple-folder-store.h: Removed.
321 * src/modest-tny-local-folders-account.h
322 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
323 for the local-folders maildir, with an extra TnyMergedFolder containing
324 the folders of the per-account outbox store accounts.
325 * src/modest-tny-account-store.c: (get_server_accounts):
326 Add the outboxes to the special local folders account after creating it.
328 * src/modest-tny-account.c:
329 (modest_tny_account_new_for_local_folders): Create the derived
330 account when creating the main local-folders account.
332 * src/maemo/modest-main-window.c: (create_details_widget),
333 (modest_main_window_set_contents_style):
334 Adapted to the use of the derived account instead of the folder store.
336 * src/modest-ui-actions.c:
337 (modest_ui_actions_on_folder_selection_changed):
338 * src/modest-ui-dimming-rules.c:
339 (modest_ui_dimming_rules_on_new_folder):
340 * src/widgets/modest-folder-view.c: (text_cell_data),
341 (icon_cell_data), (filter_row), (update_model),
342 (get_cmp_rows_type_pos):
345 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
346 Do not get the priv struct, because no priv struct has been set,
347 to avoid a runtime warning.
349 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
350 #ifelse with #else, to fix a warning, to fix the build.
353 2007-06-05 Christian Kellner <ckellner@openismus.com>
355 * libmodest-dbus-client/libmodest-dbus-client.c:
356 Fix small typo in doc (why do you always see them
357 AFTER committing stuff?)
360 2007-06-05 Christian Kellner <ckellner@openismus.com>
362 * libmodest-dbus-client/libmodest-dbus-client.c:
363 (libmodest_dbus_client_search):
364 Initialize hit list with NULL. Also set folder list
365 to "" if NULL was supplied.
368 2007-06-03 Christian Kellner <ckellner@openismus.com>
370 * libmodest-dbus-client/libmodest-dbus-client.c:
371 (modest_search_hit_list_free):
372 Make it save to call it with NULL.
374 * src/dbus_api/modest-dbus-callbacks.c:
375 * src/modest-search.c:
376 Return full ModestSearchHits as the search result list not TnyHeader
377 since can't be around withouth the correspoding TnyFolder.
379 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
381 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
382 Added currently commented code to check for secure auth
384 * src/maemo/modest-account-settings-dialog.c: (on_response),
385 (save_configuration), (show_ok):
386 Fixed projects.maemo.org bugs NB #59248 and #59251
388 * src/maemo/modest-maemo-utils.c:
389 (on_camel_account_get_supported_secure_authentication_status),
390 (on_camel_account_get_supported_secure_authentication),
391 (modest_maemo_utils_get_supported_secure_authentication_methods):
392 * src/maemo/modest-maemo-utils.h:
393 Moved get_supported_secure_authentication() method here to be able
394 to use it from easysetup wizard.
396 * src/modest-pair.c: (on_pair_compare_as_string):
397 Should compare string with first part of pair and not
398 strcmp pairs which will crash.
400 * src/modest-protocol-info.c:
401 (modest_protocol_info_protocol_is_store):
402 * src/modest-protocol-info.h:
403 Added modest_protocol_info_get_auth_protocol_name()
405 2007-06-03 Armin Burgmeier <armin@openismus.com>
407 * src/modest-mail-operation.c:
408 (modest_mail_operation_get_msgs_full): Set priv->account also when
409 only retrieving a single message. This avoids a crash when canceling
412 (modest_mail_operation_notify_end): Do not explicitely remove the
413 operation from the queue but only emit the progress_changed signal.
414 The queue itself listens to that signal to remove the operation when
415 it is finished. This reduces coupling and removes a potential deadlock
416 when modest_mail_operation_notify_end() is called from the queue
417 itself. If that is a problem performance-wise, I would suggest to
418 implement a status-changed signal or something.
420 * src/modest-mail-operation-queue.c: Make sure to never call a
421 function from another file while the queue is locked. This (hopefully)
422 fixes another deadlock when exiting the application while retrieving
425 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
427 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
428 Fixed build if libogs is not available
430 2007-06-03 Christian Kellner <ckellner@openismus.com>
432 * libmodest-dbus-client/libmodest-dbus-client.h:
433 * libmodest-dbus-client/libmodest-dbus-client.c:
434 (libmodest_dbus_client_delete_message):
435 Implement deletion of messages (Client side).
437 (modest_search_hit_free),
438 (modest_search_hit_list_free):
439 Utility functions to free the result hits.
441 * src/dbus_api/modest-dbus-api.h:
442 * src/dbus_api/modest-dbus-callbacks.c:
444 (modest_dbus_req_handler):
445 Implement deletion of messages (Server side).
447 * tests/dbus_api/test_search.c: (main):
450 * tests/dbus_api/Makefile.am:
451 * tests/dbus_api/test_delete_message:
452 Add little test for the message deletion logic
454 2007-06-03 Armin Burgmeier <armin@openismus.com>
456 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
457 when the operation queue was not empty. projects.maemo.org bug
460 2007-06-03 Armin Burgmeier <armin@openismus.com>
462 * src/widgets/modest-account-view.c
463 (on_account_default_toggled): Toggle default account column
464 explicitely instead of waiting for gconf notification (which is
465 currently ignored). This should fix projects.maemo.org bug NB#56910
466 for now. It should probably be removed when gconf notifications are
469 2007-06-03 Christian Kellner <ckellner@openismus.com>
471 * libmodest-dbus-client/libmodest-dbus-client.c:
472 Removed debugging spew.
474 * src/dbus_api/modest-dbus-callbacks.c:
475 Added debugging info.
477 * src/modest-search.c:
478 (modest_search_all_accounts):
479 Use tny_account_store_get_accounts () on the account store
480 to get all accounts which is the way to get all accounts.
482 * tests/dbus_api/test_search.c: (main):
483 Make it possible to supply the search term on the command line.
485 2007-06-03 Christian Kellner <ckellner@openismus.com>
487 * libmodest-dbus-client/libmodest-dbus-client.c:
488 * libmodest-dbus-client/libmodest-dbus-client.h:
489 Implement searching for mesages over raw dbus. (Client side)
491 * src/dbus_api/Makefile.am:
492 * src/dbus_api/modest-dbus-api.h:
493 * src/dbus_api/modest-dbus-callbacks.c:
494 * src/dbus_api/modest-dbus-callbacks.h:
495 Search framework (Server side). Also implement on_idle_open_message().
497 * src/maemo/modest-platform.c: (modest_platform_init):
498 Prepare for raw dbus/osso rpc interaction.
500 * src/modest-search.h:
501 Changed minsize from unspecific guint to guint32.
503 * src/modest-search.c:
505 Added strange hack which magically made tnymail work.
507 (modest_search_folder),
508 (modest_search_account),
509 (modest_search_all_accounts):
510 Implement helper functions to search all accounts, specific account
513 * tests/dbus_api/Makefile.am:
514 * tests/dbus_api/test_open_message.c:
515 Read url to open from commandline.
517 * tests/dbus_api/test_search.c:
518 Implement small test for dbus search stuff
520 2007-06-02 Armin Burgmeier <armin@openismus.com>
522 * src/maemo/modest-account-settings-dialog.c: Changed window title to
523 include account type and account title. This fixes projects.maemo.org
526 * src/maemo/modest-account-view-window.c: Set a title for the window.
528 2007-06-02 Armin Burgmeier <armin@openismus.com>
530 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
531 incoming and outgoing server name based on email address and server
532 types as long as the names have not been edited manually. This fixes
533 projects.maemo.org bug NB#58671.
535 2007-06-02 Armin Burgmeier <armin@openismus.com>
537 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
538 server type cannot be changed in future to the incoming details page
539 when creating an account. This fixes projects.maemo.org bug NB#59029.
541 2007-06-02 Armin Burgmeier <armin@openismus.com>
543 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
544 and assigned max width chars so that they wrap instead of being
545 truncated. Fixes projects.maemo.org bug NB#56126.
547 2007-06-02 Armin Burgmeier <armin@openismus.com>
549 * src/maemo/modest-connection-specific-smtp-window.c: Add an
550 introductory note to the connection specific smtp servers dialog, as
551 section 8.12 of the email UI specification requires. This fixes
552 projects.maemo.org bug NB#59212.
554 2007-06-01 Murray Cumming <murrayc@murrayc.com>
556 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
557 Check for running mail operations, and offer to cancel them, as per the UI
558 spec. This fixes projects.maemo.org bug NB#59041 .
559 However, I suspect that tinymail may still use the network connection
560 in ways that we cannot detect or cancel. But it should at least adapt to
563 2007-06-01 Murray Cumming <murrayc@murrayc.com>
565 * src/modest-tny-account-store.c: (recreate_all_accounts),
566 (get_cached_accounts), (get_server_accounts): Do more sensible
567 ref-counting of the temporarily-cached outbox accounts list. This seems
568 to fix a crash when entering the password when the password was wrong.
570 2007-06-01 Murray Cumming <murrayc@murrayc.com>
572 * src/gnome/modest-main-window.c: (connect_signals):
573 * src/modest-tny-account-store.c: (get_password),
574 (modest_tny_account_store_alert): Added comments and clues and
575 commented-out code about how we currently fail to deal with connection
576 errors and wrong passwords, and how we should.
578 2007-06-01 Murray Cumming <murrayc@murrayc.com>
580 * src/widgets/modest-retrieve-combo-box.c:
581 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
582 This fixes projects.maemo.org bug NB#58472 .
584 2007-06-01 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/easysetup/modest-easysetup-wizard.c:
587 (create_page_complete_easysetup):
588 (create_page_complete_custom): Correct the last commit,
589 putting the correct sentences in the correct pages.
591 2007-06-01 Murray Cumming <murrayc@murrayc.com>
593 * src/maemo/easysetup/modest-easysetup-wizard.c:
594 (create_page_complete_custom): Show the second sentence of text
595 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
598 2007-06-01 Murray Cumming <murrayc@murrayc.com>
600 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
601 Set the leave-on-server conf key by default. This fixes
602 projects.maemo.org bug NB#59258 .
604 2007-06-01 Murray Cumming <murrayc@murrayc.com>
606 * src/maemo/modest-account-view-window.c:
607 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
608 logical ID for the confirmation messages. Fixed projects.maemo.org bug
611 2007-06-01 Murray Cumming <murrayc@murrayc.com>
613 * src/maemo/easysetup/modest-easysetup-wizard.c:
614 (create_caption_new_with_asterisk):
615 * src/maemo/modest-account-settings-dialog.c:
616 (create_caption_new_with_asterisk):
617 Uncomment the code to add the asterisk, because they are no longer in the
618 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
619 (update_incoming_server_title): Add an asterisk here too.
621 2007-06-01 Murray Cumming <murrayc@murrayc.com>
623 * src/maemo/modest-maemo-global-settings-dialog.c:
624 (current_connection): Check that we are even connected before trying to
625 get the current connection name, to prevent a warning.
627 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
628 Change the comments because tny_maemo_conic_device_connect() is now meant to
630 * src/modest-mail-operation.c:
631 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
632 make sure we have a connection and fail if we can't connect.
634 2007-05-31 Murray Cumming <murrayc@murrayc.com>
636 * src/maemo/modest-main-window.c:
637 (on_account_store_connecting_finished): Do not try to get the
638 connection ID if we are not really connected. I am surprised that
639 this signal handler is called when we are not connected.
641 2007-05-31 Murray Cumming <murrayc@murrayc.com>
643 * src/modest-error.h:
644 * src/modest-ui-actions.c:
645 (modest_ui_actions_get_msgs_full_error_handler):
646 Renamed an enum, added comments, added an enum
647 for retrieve-limit errors.
649 * src/modest-mail-operation.c: (foreach_add_item),
650 (internal_folder_observer_update), (update_account_thread),
651 (modest_mail_operation_get_msgs_full):
652 (modest_mail_operation_update_account),
653 Added comments about how this works, and some code that should
654 (but does not) check the retrieve-limit. See the TODO comment.
656 2007-05-31 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
659 Initialize help_id to fix the build. Warnings are good.
661 2007-05-31 Murray Cumming <murrayc@murrayc.com>
663 * src/widgets/modest-hbox-cell-renderer.c:
664 (modest_hbox_cell_renderer_append):
665 * src/widgets/modest-vbox-cell-renderer.c:
666 (modest_vbox_cell_renderer_append):
667 Fix the last commit by doing an extra ref.
669 2007-05-31 Murray Cumming <murrayc@murrayc.com>
671 * src/widgets/modest-hbox-cell-renderer.c:
672 (modest_hbox_cell_renderer_append):
673 * src/widgets/modest-vbox-cell-renderer.c:
674 (modest_vbox_cell_renderer_append):
675 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
676 to fix the build with Maemo Bora.
677 However, there seems to be a remaining crash, probably due to reference
680 2007-05-30 Murray Cumming <murrayc@murrayc.com>
682 * src/modest-tny-account.c:
683 (modest_tny_account_new_for_local_folders):
684 Use hildon_file_system_info_async_new() to get a better name for
685 the memory card account, setting it as the account name.
686 The timing seems to work, but this is probably
687 not the best place to do this. See the TODO comment.
688 * src/maemo/modest-main-window.c: (create_details_widget):
689 * src/widgets/modest-folder-view.c: (text_cell_data):
690 Use the tny account name instead of hardcoding a name.
692 2007-05-30 Christian Kellner <ckellner@openismus.com>
694 * src/modest-search.c: (modest_search):
695 Correctly set part_search_func even if we have already parsed
696 the query and thus a valid OgsTextSearcher object.
698 2007-05-30 Christian Kellner <ckellner@openismus.com>
701 Search and check for libogs.
704 Incooparte the ogs build env.
706 * src/modest-mime-part-search-stream.c:
707 * src/modest-mime-part-search-stream.h:
708 Removed since we do the real searching now in modest-search.c.
710 * src/modest-search.c:
711 * src/modest-search.h:
712 Implement support for ogs. We use that if available and requested
713 and fall back to modest_text_utils_utf8_strcmp (). The search logic
714 should now handle the corner case when the search term is spread
715 across multiple reads.
716 Also the logic in modest_search () was corrected to search all
717 requested fields until one is found.
719 2007-05-30 Murray Cumming <murrayc@murrayc.com>
721 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
724 * src/modest-init.c: Made modest_init_local_folders() take a
725 path and be public so we can iniitialize maildir folders on
728 * src/modest-local-folder-info.h:
729 * src/modest-local-folder-info.c:
730 (modest_local_folder_info_get_maildir_path): Add a path parameter.
732 * src/modest-tny-account.c:
733 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
734 still means the standard local-folders path on the local volume.
736 * src/modest-tny-account-store.c:
737 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
738 signal so we can detect mount/unmount of the MMC1 card, and do an update of
739 all accounts when that happens.
740 (get_server_accounts): If the MMC1 card is mounted, create a store account for
741 this too, so it shows up in the treeview.
743 2007-05-28 Murray Cumming <murrayc@murrayc.com>
745 * src/maemo/modest-maemo-global-settings-dialog.c:
746 (current_connection):
747 * src/widgets/modest-global-settings-dialog.c:
748 (current_connection_default):
749 Use the enum values instead of 0, 1 and -1,
750 to make the code clearer.
752 * src/modest-account-mgr-helpers.c:
753 (modest_account_mgr_get_connection_specific_smtp): Make this code
756 * src/modest-runtime.h:
757 * src/modest-runtime.c:
758 Added modest_runtime_remove_all_send_queues().
759 * src/maemo/modest-main-window.c:
760 (on_account_store_connecting_finished): Recreate the send queues,
761 using the appropriate transport accounts for this new connection.
762 Some futher adapting might be needed if the old send queues are not
763 automatically stopped at this point.
765 * src/modest-tny-account-store.c: (get_server_accounts):
766 Create the connection-specific transport accounts, so that they can
767 be found later by their ID.
769 * src/modest-tny-account.h:
770 * src/modest-tny-account.c:
771 Added modest_tny_account_new_from_server_account_name().
772 modest_tny_account_new_from_server_account(): Do not create the
773 send queues here, because they will be
774 recreated anyway when the connection changes for the first time.
776 2007-05-28 Murray Cumming <murrayc@murrayc.com>
778 * src/modest-local-folder-info.h:
779 * src/modest-local-folder-info.c:
780 (modest_per_account_local_outbox_folder_info_get_maildir_path),
781 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
782 tbox_folder): Take a modest account name instead of a server TnyAccount,
783 so we can have per-modest-account rather than per-transport-account
785 We must make sure that we change or recreate the exisitng send queues
786 when the connection changes for connection-specific transport accounts.
788 * src/modest-tny-account-store.c:
789 (create_per_account_local_outbox_folders): Create outboxed per modest
790 account, not per transport account.
792 * src/modest-tny-account.h:
793 * src/modest-tny-account.c:
794 (modest_tny_account_get_special_folder): For outboxes, get the
795 parent modest account name. The account is ignored for other folders.
796 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
797 modest account name rather than a server TnyAccount.
799 2007-05-25 Murray Cumming <murrayc@murrayc.com>
801 * src/modest-tny-account.c:
802 (modest_tny_account_new_from_server_account):
803 Call modest_runtime_get_send_queue() immediately after creating transport
804 accounts, so that they start trying to send email from the outbox as soon
805 as possible at startup. This is probably what we want.
807 * src/modest-mail-operation.c: (update_account_thread):
808 * src/modest-runtime.c: (modest_runtime_get_send_queue):
809 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
810 * src/modest-tny-send-queue.h:
811 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
812 (modest_ui_actions_on_send):
813 Added comments about how sending works, though it needs some more work.
815 2007-05-25 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-tny-account.c:
818 (modest_tny_account_get_special_folder): Add TODO because this fails when
820 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
821 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
822 Do not try to show this window when there is no active account. The UI
823 specs does not tell us what to do in this case.
825 2007-05-24 Murray Cumming <murrayc@murrayc.com>
829 * src/maemo/Makefile.am:
830 * src/widgets/Makefile.am: Some dist fixes.
832 2007-05-24 Murray Cumming <murrayc@murrayc.com>
834 * src/maemo/modest-connection-specific-smtp-window.c:
835 (on_button_edit): Make the code clearer, to prevent a double free.
837 2007-05-24 Murray Cumming <murrayc@murrayc.com>
839 * src/maemo/modest-account-settings-dialog.c:
840 (modest_account_settings_dialog_set_account_name),
841 Check the connection-specific smtp servers checkbox if there are any.
843 * src/maemo/modest-connection-specific-smtp-edit-window.c:
844 (modest_connection_specific_smtp_edit_window_init):
845 Start with a suitable port number.
847 * src/modest-account-mgr-helpers.h:
848 * src/modest-account-mgr-helpers.c: Added
849 modest_account_mgr_get_has_connection_specific_smtp().
851 (modest_account_mgr_set_connection_specific_smtp),
852 (modest_account_mgr_remove_connection_specific_smtp),
853 (modest_account_mgr_get_has_connection_specific_smtp),
854 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
855 connection-specific smtp server accounts in the account, rather than
856 the server account conf dir.
858 This fixes bug projects.maemo.org bug NB#58263 .
860 * src/modest-tny-account-store.c:
861 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
862 if there are no server accounts yet, to prevent an infinite loop when there
863 are no accounts. Document that one must be called before the other.
865 2007-05-24 Murray Cumming <murrayc@murrayc.com>
867 * src/modest-account-mgr-helpers.c:
868 (modest_account_mgr_get_default_account): Make sure that at least
869 one account is always the default, if there are any enabled accounts.
870 This is just a sanity check that shouldn't be necessary.
872 * src/modest-account-mgr-priv.c:
873 (_modest_account_mgr_account_from_key): Unescape the conf key to
874 get the real account name. For instance, this is an issue if a space
875 was in the account name, which can happen because the account name
876 is generated from the display name.
877 (_modest_account_mgr_get_account_keyname): Always escape the
879 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
880 Unescape the conf keys to get the real account names.
882 For instance, previously the is-default radio button in the accounts
883 list was not checked for any accounts at first. This fixes that,
884 and might fix several similar bugs.
886 2007-05-23 Murray Cumming <murrayc@murrayc.com>
888 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
889 Removed some debug printfs.
891 2007-05-23 Murray Cumming <murrayc@murrayc.com>
893 Modest on-disk outbox directories are now here, for instance:
894 $HOME/.modest/outboxes/<account-id-1>/outbox
895 $HOME/.modest/outboxes/<account-id-2>/outbox
897 $HOME/.modest/local-folders/outbox
898 so we can have a separate outbox for each account.
899 But they are shown as one outbox in the GtkTreeView, by using a
900 TnyMergeFolder in a ModestTnySimpleFolderStore.
903 * src/modest-tny-simple-folder-store.c:
904 * src/modest-tny-simple-folder-store.h:
905 Added ModestTnySimpleFolderStore, used to contain folders from
906 other folder stores, such as other accounts.
908 * src/modest-tny-outbox-account.h:
909 * src/modest-tny-outbox-account.c:
910 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
911 used for the per-account local outbox folders.
913 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
914 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
915 only use this (internally) now for the non-outbox local folders.
918 * src/modest-init.c: Added modest_init_one_local_folder(), for
919 setting up the directory structure for each local folder.
921 * src/modest-local-folder-info.c:
922 (modest_per_account_local_outbox_folder_info_get_maildir_path),
923 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
925 * src/modest-local-folder-info.h:
926 * src/modest-tny-account-store.c: (on_account_removed),
927 (on_account_changed), (create_per_account_local_outbox_folders),
928 (get_server_accounts), (modest_tny_account_store_get_accounts),
929 (modest_tny_account_store_get_tny_account_by_account),
930 (modest_tny_folder_store_is_virtual_local_folders):
932 * src/modest-tny-account.h:
933 * src/modest-tny-account.c:
934 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
935 to create an on-disk per-account local outbox folder for each
937 (create_per_account_local_outbox_folders): Create a local outbox folder
938 for each transport account.
939 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
940 for all local folders.
942 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
943 instead of using g_object_get/set() directly. It is clearer.
945 (modest_tny_folder_store_get_message_count),
946 (modest_tny_folder_store_get_local_size
947 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
948 because we now use these with non-acount folder stores.
950 (modest_tny_account_get_special_folder),
951 (modest_tny_account_new_from_server_account),
952 (modest_tny_account_new_from_account):
953 (recurse_folders): Adjust to the new outbox system.
955 * src/modest-tny-folder.h:
956 * src/modest-tny-folder.c:
957 (modest_tny_folder_is_local_folder),
958 (modest_tny_folder_get_local_folder_type),
959 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
961 * src/widgets/modest-main-window.h:
962 * src/maemo/modest-main-window.c: (create_details_widget),
963 (modest_main_window_set_contents_style): Show details for any folder store,
966 (modest_tny_folder_get_rules):
967 Remove the const. C does not support constness enough for this.
969 * src/modest-ui-actions.c:
970 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
971 make all outboxes appear as one, in the usual local-folders tree node.
973 (set_active_account_from_tny_account),
974 (modest_ui_actions_on_folder_selection_changed):
975 * src/widgets/modest-folder-view.c: (text_cell_data),
976 (icon_cell_data), (filter_row),
977 (add_account_folders_to_merged_folder),
978 (add_account_folders_to_simple_folder_store), (),
979 (get_cmp_rows_type_pos), (cmp_rows),
980 (modest_folder_view_set_account_id_of_visible_server_account):
981 Adjust to the new outbox system, using generic folder stores and folders
984 2007-05-23 Christian Kellner <ckellner@openismus.com>
986 * src/modest-mail-operation.c:
987 (modest_mail_operation_update_account):
988 Use info->max_size instead of unintialized local var [small
989 build fix]. (Added TODO to review that change since I don't
992 2007-05-23 Marcus Bauer <marcusb@openismus.com>
994 * libmodest-dbus-client/libmodest-dbus-client.c:
995 (libmodest_dbus_client_compose_mail): function added
996 * src/dbus_api/modest-dbus-api.h:
997 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
998 (on_compose_mail): Implementation of the SendAsMail functionality
1000 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1002 * src/modest-account-mgr.c:
1003 (modest_account_mgr_add_server_account): Set the secure-connection
1004 conf key for transport accounts as well as store accounts. I don't know
1005 why the if was there. For instance, this makes sure that we use SSL
1006 for the gmail preset from the easysetup wizard.
1008 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1010 * src/gnome/modest-main-window.c:
1011 (on_account_store_connecting_finished), (connect_signals):
1012 * src/maemo/modest-main-window.c:
1013 (on_account_store_connecting_finished), (connect_signals),
1014 (modest_main_window_new):
1015 Handle TnyAccountStore::connecting-finished instead of
1016 TnyDevice::connection-changed, because we cannot actually perform
1017 operations on accounts until TnyAccountStore has itself responded to
1018 the TnyDevice::connection-changed signal. This prevents a GError from
1020 Do not try to update at startup, because we (at least on scratchbox)
1021 already do an update at startup when the device goes online.
1022 This prevents a GError from tinymail.
1023 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1024 Added TODO about stopping simultaneous operations.
1026 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1028 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1029 * src/modest-mail-operation-queue.c:
1030 (modest_mail_operation_queue_remove):
1031 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1032 about where they happened.
1034 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1036 * src/modest-ui-actions.c:
1037 (modest_ui_actions_on_password_requested): Make sure that the remember
1038 output parameter is always TRUE.
1040 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1042 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1043 Show a OK/Cancel dialog if the error is a question, though we still do not
1044 know anything more about what we are asking the user.
1045 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1046 Fix an uninitialized variable (helper). This is a logic error, however.
1048 2007-05-21 Christian Kellner <ckellner@openismus.com>
1050 * src/modest-search.h:
1051 Correct bit shifting in the ModestSearchFlags enum.
1053 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1055 * src/modest-tny-account.c:
1056 (modest_tny_account_new_from_server_account): Do not use the lsub and
1057 check-all hard-coded IMAP options when using POP.
1059 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1061 * src/modest-tny-account.c:
1062 (modest_tny_account_new_from_server_account):
1063 Use NULL for the secure-auth method for POP when Password auth has been
1064 specified by the user, as we already do for IMAP. "auth=Login" causes
1065 an error from camel or the server.
1067 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1069 * src/maemo/modest-account-settings-dialog.c:
1070 (create_page_account_details),
1071 (modest_account_settings_dialog_set_account_name):
1072 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1073 for the leave-on-server checkbox, rathr than just the checkbox, when
1074 the protocol is not POP.
1076 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1078 * src/widgets/modest-account-view.c:
1079 * src/widgets/modest-account-view.h:
1080 Added modest_account_view_select_account() which will be useful later
1081 to asynchronously re-select the edited account.
1083 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1085 * src/maemo/modest-account-settings-dialog.c:
1086 (modest_account_settings_dialog_set_account_name):
1087 Automatically choose the port numbers based on the secure authentication
1088 methods, if they have not been chosen before.
1089 This fixes projects.maemo.org bug NB#56273 .
1091 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1093 * src/maemo/modest-main-window-ui.h:
1094 * src/modest-ui-actions.c:
1095 * src/modest-ui-actions.h:
1096 Connect the Tools/SMTP Servers menu item to
1097 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1098 SMTP servers dialog, as in the UI specification and saves changes when it
1099 is closed. This fixed projects.maemo.org bug NB#56305 .
1101 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1103 * src/maemo/modest-connection-specific-smtp-window.c:
1104 (modest_connection_specific_smtp_window_init):
1105 Use gtk_window_set_default_size() to make this window big enough, so
1106 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1108 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1110 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1111 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1112 (modest_connection_specific_smtp_edit_window_init),
1113 Do not try to connect to a combobox signal before the combobox exists.
1114 This fixes the cras in projects.maemo.org bug NB#56288 .
1115 (modest_connection_specific_smtp_edit_window_get_settings):
1116 Remove the server_account_name parameter which was being checked for NULL
1117 though it was not used.
1119 * src/maemo/modest-connection-specific-smtp-window.c:
1120 (modest_connection_specific_smtp_window_fill_with_connections),
1121 (on_button_edit), (modest_connection_specific_smtp_window_init):
1122 Correct the number of treemodel columns to prevent a warning.
1123 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1124 libconic does not work.
1126 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1128 * src/modest-tny-account.c:
1129 (modest_tny_account_new_from_server_account):
1130 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1131 SMTP when "None" was chosen by the user. However, with my SMTP server that
1132 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1135 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1137 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1138 to explain the memory management issue with the ID in the ModestPair.
1140 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1141 (add_sending_page), (modest_account_assistant_finalize):
1142 * src/gnome/modest-gnome-global-settings-dialog.c:
1143 (create_updating_page), (create_composing_page):
1144 * src/gnome/modest-msg-edit-window.c: (get_transports),
1145 (init_window), (modest_msg_edit_window_finalize),
1146 (modest_msg_edit_window_get_msg_data):
1147 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1148 * src/gnome/modest-transport-widget.c:
1149 (modest_transport_widget_finalize), (smtp_configuration):
1150 * src/maemo/modest-maemo-global-settings-dialog.c:
1151 (create_updating_page), (create_composing_page):
1152 * src/maemo/modest-msg-edit-window.c: (get_transports),
1153 (init_window), (modest_msg_edit_window_finalize),
1154 (modest_msg_edit_window_get_msg_data),
1155 (modest_msg_edit_window_free_msg_data):
1156 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1157 (modest_store_widget_finalize):
1158 * src/maemo/modest-transport-widget.c:
1159 (modest_transport_widget_finalize), (smtp_configuration):
1160 * src/modest-main.c: (send_mail):
1161 * src/widgets/modest-combo-box.h:
1162 * src/widgets/modest-global-settings-dialog-priv.h:
1163 * src/widgets/modest-global-settings-dialog.c:
1164 (modest_global_settings_dialog_finalize):
1165 * src/widgets/modest-msg-edit-window.h:
1166 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1167 as long as the combo box, to prevent use of freed memory for the ID.
1169 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1171 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1172 get_accounts(), to make this clearer. Do not check for the enabled gconf
1173 key, because we do not use this for server accounts (at least, not yet).
1174 This allows us to send email again.
1176 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1178 * src/maemo/modest-platform.c:
1179 (on_modest_conf_update_interval_changed), (modest_platform_init):
1180 Only respond to this particular key change. All these strcmp()s cannot be
1183 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1185 * src/maemo/modest-maemo-global-settings-dialog.c:
1186 (current_connection): Prevent a crash in scratchbox when
1187 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1188 * src/maemo/modest-platform.c:
1189 (on_modest_conf_update_interval_changed), (modest_platform_init):
1190 Get the update interval from gconf and reset it when the gconf key changes.
1192 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1194 * src/modest-protocol-info.c:
1195 * src/modest-protocol-info.h: Adde enum-specific get functions,
1196 instead of using a ModestProtocolType enum parameter.
1198 * src/gnome/modest-account-assistant.c:
1199 * src/gnome/modest-store-widget.c:
1200 * src/gnome/modest-store-widget.h:
1201 * src/gnome/modest-transport-widget.c:
1202 * src/gnome/modest-transport-widget.h:
1203 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1204 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1205 * src/maemo/easysetup/modest-easysetup-wizard.c:
1206 * src/maemo/modest-account-settings-dialog.c:
1207 * src/maemo/modest-account-settings-dialog.h:
1208 * src/maemo/modest-store-widget.c:
1209 * src/maemo/modest-store-widget.h:
1210 * src/maemo/modest-transport-widget.c:
1211 * src/maemo/modest-transport-widget.h:
1212 * src/modest-account-mgr-helpers.c:
1213 * src/modest-account-mgr-helpers.h:
1214 * src/modest-account-mgr.c:
1215 * src/modest-account-mgr.h:
1216 * src/modest-tny-account.c:
1217 * src/modest-tny-folder.c:
1218 * src/widgets/modest-account-view.c:
1219 * src/widgets/modest-retrieve-combo-box.c:
1220 * src/widgets/modest-retrieve-combo-box.h:
1221 * src/widgets/modest-secureauth-combo-box.c:
1222 * src/widgets/modest-serversecurity-combo-box.c:
1223 * src/widgets/modest-serversecurity-combo-box.h:
1224 * tests/check_account-mgr.c:
1225 Use the specific functions, and use the re-renamed enum values for GNOME too.
1227 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-pair.h:
1230 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1231 so we can get the second based on the first.
1233 * src/maemo/modest-account-settings-dialog.h:
1234 * src/maemo/modest-account-settings-dialog.c:
1235 Added get_supported_secure_authentication_methods(), though it is mostly
1236 commented-out for now until the necessary API is committed to tinymail.
1237 (modest_account_settings_dialog_set_account_name),
1238 (save_configuration): Request the supported authentication methods from the
1239 server, so we can choose a working method.
1241 * src/modest-tny-account-store.h:
1242 * src/modest-tny-account-store.c:
1243 (modest_tny_account_store_get_session): Rename from
1244 tny_account_store_get_session().
1246 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-protocol-info.h: Split the ModestProtocol enum
1249 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1250 There was no need to have these unrelated values in one enum.
1252 * src/: many files: Adapted to changed enum. This makes the code a bit
1253 clearer, and the compiler could catch some errors.
1255 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1257 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1258 Show the detailed internal camel error message when an error happens
1259 during the configuration, so that our testers can give us more clues.
1260 For instance, in projects.maemo.org bug NB#56910 .
1262 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-tny-account.c:
1265 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1266 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1268 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1270 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1271 * src/maemo/modest-account-settings-dialog.c:
1272 (modest_account_settings_dialog_set_account_name),
1273 (save_configuration): For the incoming secure authentication checkbox,
1274 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1275 the UI specification. PLAIN does not seem to be supported for most IMAP
1276 servers anyway, and I am not sure what it would mean.
1277 However, we probably need to discover which of the secure-authentication
1278 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1279 * src/modest-account-mgr-helpers.c:
1280 (modest_account_mgr_get_server_account_data):
1282 * src/modest-tny-account.c:
1283 (modest_tny_account_new_from_server_account):
1284 Use tny_account_set_mech() to set secure-authentication methods,
1285 with some special-casing for IMAP, based on my observations of how
1288 * src/modest-account-mgr-helpers.h:
1289 * src/modest-account-mgr.c:
1290 * src/modest-defs.h: Comment that the URI is only used for local folders.
1292 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1294 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1295 parameter const, just to be neat.
1296 * src/modest-text-utils.c: (modest_text_utils_inline):
1297 End g_strconcat() with NULL, as its documentation says. This is almost
1298 certainly the cause of my crash at startup on the device. Interestingly,
1299 valgrind doesn't tell us about these errors.
1301 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1303 * scripts/build-packages: Added more precise comments about how to use
1304 this script, though I still get this error:
1305 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1306 error building tinymail
1308 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1310 * src/maemo/modest-main-window.c: (on_account_update):
1311 Very slight cleanup, hoping to make it simpler to discover what causes
1312 a crash here sometimes.
1314 * src/modest-tny-account.c:
1315 (modest_tny_account_new_from_server_account): Set the port. Added
1316 comments about the options and a TODO comment because I need to find out
1317 how to specify the secure authentication method.
1319 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1321 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1322 changed CFlags paths form modest to libmodest
1324 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1326 * src/modest-account-mgr-helpers.c:
1327 (modest_account_mgr_get_server_account_data),
1328 (modest_account_mgr_free_server_account_data):
1329 * src/modest-account-mgr-helpers.h:
1330 * src/modest-account-mgr.c:
1331 (modest_account_mgr_add_server_account):
1332 * src/modest-defs.h:
1333 * src/modest-tny-account.c:
1334 (modest_tny_account_new_from_server_account):
1335 Determine the options for tny_camel_account_add_option() here,
1336 based on the settings, rather than storing them directly in gconf.
1338 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1340 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1341 Show a more friendly error dialog now that we expect (from the tinymail
1342 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1344 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1346 * src/maemo/modest-main-window.c: (on_account_update): Check that
1347 account_name is not NULL, to prevent a crash at startup that I am
1348 seeing on the N800. I do wonder why it is NULL.
1350 * src/maemo/easysetup/modest-easysetup-wizard.c:
1351 (create_page_user_details):
1352 * src/maemo/modest-account-settings-dialog.c:
1353 (create_page_user_details), (create_page_outgoing):
1354 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1355 (modest_connection_specific_smtp_edit_window_init):
1356 * src/modest-ui-actions.c:
1357 (modest_ui_actions_on_password_requested):
1358 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1359 might do something useful with the on-screen keyboard.
1361 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1363 * src/maemo/modest-main-window.c: (on_account_update):
1364 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1365 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1367 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-tny-account-store.c: (on_account_changed):
1370 Correct the signature of this signal handler.
1372 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1375 Show a HildonNote instead of a GtkDialog for Maemo.
1377 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1379 * src/widgets/modest-account-view.h:
1380 * src/widgets/modest-account-view.c: (on_account_changed),
1381 (on_account_removed). Added a boolean flag, set/unset by
1382 modest_account_view_block_conf_updates(),
1383 modest_account_view_unblock_conf_updates() to prevent unnecessary
1384 updates, but this is not very useful because the gconf notifications are
1385 so delays (maybe only on Maemo Bora).
1386 So auto-updating is turned off, and these functions do an explicit
1387 update when necessary.
1388 However, something else is still doing too much work when adding/removing
1389 accounts, probably in another part of the application.
1391 * src/maemo/modest-account-view-window.c:
1392 (on_delete_button_clicked), (on_edit_button_clicked),
1393 (on_new_button_clicked): Use the new functions.
1395 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1397 * src/modest-account-mgr-helpers.c:
1398 (modest_account_mgr_set_first_account_as_default):
1399 Sort the list of names alphabetically-by-title, so we choose the first one
1401 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1402 alphabetically by the title.
1404 This fixes projects.maemo.org bug NB#56418 .
1406 * src/modest-account-mgr-priv.c:
1407 (_modest_account_mgr_account_from_key):
1408 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1409 avoid a valgrind error, and possible random behaviour.
1411 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1413 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1414 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1415 tinymail documentation to say that this can be expected.
1416 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1417 pretty, and should not happen, but I would prefer to know when it does.
1419 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1421 * configure.ac: When using the older hildon version, probably on Bora,
1422 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1424 * src/widgets/modest-attachment-view.c:
1425 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1428 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1430 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1431 Implemented the prototype. Can be tested with
1432 tests/dbus_api/test_open_message:
1434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1436 * src/modest-tny-account-store.c:
1437 (modest_tny_account_store_instance_init), (get_password):
1438 * src/modest-ui-actions.c:
1439 (modest_ui_actions_on_password_requested):
1440 Do not store the password in gconf, because this function is called
1441 for non-remembered passwords. Actually use the cached (in the hash map)
1442 password instead of releasing it.
1443 The password will now not be remembered if it is asked via the protected
1444 password dialog, as per the UI spec.
1446 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1448 * src/modest-defs.h:
1449 * src/modest-account-mgr-helpers.h:
1450 * src/modest-account-mgr-helpers.c:
1451 Added modest_server_account_get_username_has_succeeded(),
1452 modest_server_account_set_username_has_succeeded().
1453 (modest_server_account_set_username),
1454 Reset the has-succeeded flag if the username changes.
1456 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1457 * src/maemo/modest-connection-specific-smtp-window.c:
1458 (modest_connection_specific_smtp_window_save_server_accounts):
1459 Use modest_server_account_set_username() instead of using
1460 modest_conf_set_string() directly, so that the has-succeeded flag is always
1463 * src/modest-ui-actions.c:
1464 (modest_ui_actions_on_password_requested): Dim the username entry if
1465 the username has ever worked, as per the UI spec.
1467 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1469 * src/modest-tny-account-store.c: (get_password):
1470 * src/modest-ui-actions.c:
1471 (modest_ui_actions_on_password_requested):
1472 Allow the username to be changed too, though there is more work to
1473 be done on exactly how this behaves.
1475 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1477 * src/modest-account-mgr-helpers.h:
1478 * src/modest-account-mgr-helpers.c:
1479 Added modest_account_mgr_get_display_name(),
1480 modest_server_account_get_username(),
1481 modest_server_account_set_username(),
1482 modest_server_account_set_password(),
1483 modest_server_account_get_hostname() functions so we do not need to
1484 use the conf API directly.
1486 * src/maemo/modest-main-window.c: (connect_signals):
1487 Actually connect ot the ModestAccountStore::request-password signal,
1488 so that we show the dialog when the password is requested by Tinymail,
1489 for isntance if it is empty.
1491 * src/modest-marshal.list:
1492 * src/modest-tny-account-store.c:
1493 (modest_tny_account_store_class_init), (get_password),
1494 (modest_tny_account_store_alert):
1495 * src/modest-tny-account-store.h:
1496 * src/modest-ui-actions.h:
1497 * src/modest-ui-actions.c:
1498 (modest_ui_actions_on_password_requested):
1499 Change the signal parameters, so it is obvious that we are providing
1500 the non human-readable server name, and receiving both the username
1501 and password, though changing of the username is not yet implemented.
1502 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1503 for the GNOME version.
1505 This should fix the projects.maemo.org bug NB#56209, though it does not
1506 work on Bora, because the gconf_client_get() for the password fails
1507 immediately after we save it with gconf_client_set().
1509 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1512 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1513 caused an undefined symbol error:
1514 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1516 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1518 * src/modest-tny-account-store.c:
1519 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1520 using a GError instead of a string message, so we can translate it in
1523 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1525 * src/maemo/modest-address-book.c:
1526 (modest_address_book_check_names):
1527 * src/maemo/modest-msg-view-window.c:
1528 (modest_msg_view_window_clipboard_owner_change):
1529 * src/modest-init.c: (modest_init_init_ui):
1530 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1531 (update_folders_cb), (modest_mail_operation_update_account):
1532 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1533 (modest_ui_actions_on_msg_attachment_clicked),
1534 (modest_ui_actions_on_msg_recpt_activated):
1535 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1536 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1537 (modest_msg_view_search_next):
1538 * src/widgets/modest-recpt-editor.c:
1539 (modest_recpt_editor_on_button_release_event),
1540 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1541 g_message(). At this point we should only be seeing interesting errors on
1542 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1544 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1546 (modest_wizard_dialog_force_title_update):
1547 * src/maemo/easysetup/modest-wizard-dialog.h:
1548 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1549 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1550 can update the title when appropriate. Otherwise the title is wrong if the
1551 pages are added after adding the notebook to the dialog.
1552 This must be a problem in HildonWizardDialog too.
1553 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1555 * src/maemo/easysetup/modest-easysetup-wizard.c:
1556 (create_subsequent_customsetup_pages),
1557 (create_subsequent_easysetup_pages):
1558 Call modest_wizard_dialog_force_title_update() so that the title is
1559 correct even with GTK+ < 2.10.
1560 This fixes projects.maemo.org bug NB#56145 .
1562 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1564 * src/maemo/modest-platform.c:
1565 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1566 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1569 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1571 * src/widgets/modest-window.h:
1572 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1573 and modest_window_save_state(), which invokes it.
1575 * src/widgets/modest-window-mgr.h:
1576 * src/widgets/modest-window-mgr.c:
1577 Added modest_window_mgr_save_state_for_all_windows(), which calls
1578 the save_state vfunc on all registered windows, if implemented.
1580 * src/gnome/modest-msg-edit-window.c:
1581 * src/gnome/modest-msg-view-window.c:
1582 * src/maemo/modest-msg-edit-window.c:
1583 * src/maemo/modest-msg-view-window.c:
1584 * src/maemo/modest-main-window.c:
1585 Specify the existing save_settings functions as implementations of
1586 ModestWindow::save_state_func().
1588 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1589 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1590 enabling hibernation, for instance.
1592 We may need to do the same thing for restoring settings.
1595 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1597 * src/widgets/modest-window-mgr.c:
1598 * src/widgets/modest-window-mgr.h:
1599 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1600 modest_window_mgr_get_hibernation_is_prevented().
1602 * src/maemo/modest-main-window.c:
1603 (on_hildon_program_is_topmost_notify): Prevent hibernation
1604 (possible when the application goes to the background in the WM),
1605 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1607 * src/maemo/easysetup/modest-easysetup-wizard.c:
1608 (modest_easysetup_wizard_dialog_init):
1609 * src/maemo/modest-account-settings-dialog.c:
1610 (modest_account_settings_dialog_init):
1611 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1612 (modest_connection_specific_smtp_edit_window_init):
1613 * src/maemo/modest-connection-specific-smtp-window.c:
1614 (modest_connection_specific_smtp_window_init):
1615 * src/maemo/modest-signature-editor-dialog.c:
1616 (modest_signature_editor_dialog_init):
1617 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1618 prevent hibernation while any of these account settings dialogs are open.
1620 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1622 * src/maemo/Makefile.am:
1623 * src/maemo/modest-osso-state-saving.c:
1624 * src/maemo/modest-osso-state-saving.h: Added
1625 modest_osso_load_state() and modest_osso_save_state() though they do
1626 nothing now. They should iterate through all the open windows and load/save
1628 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1629 save state when closing.
1631 * src/maemo/modest-main-window.c:
1632 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1633 Add a notification handler for the HildonProgram::is-topmost property,
1634 so we can allow hibernation when the application goes into the background.
1635 But we still need to detect when the accounts setup windows are open so
1636 we can stop hibernation when they are open.
1637 To do this, I also added the main window the HildonProgram. This might have
1638 other side-effects/benefits, and should maybe be done for other windows.
1640 * src/maemo/modest-osso-autosave-callbacks.h:
1641 * src/maemo/modest-osso-autosave-callbacks.c:
1642 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1643 though it does not do anything yet, and we might never need this to do
1644 anything. For instance, we already save drafts.
1646 * src/maemo/modest-platform.c: (modest_platform_init):
1647 Specify the libosso auto-save callback.
1649 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1651 * src/maemo/modest-platform.c:
1652 (modest_platform_set_update_interval):
1653 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1654 aparently stays valid between application instances, so we can use this
1655 to remove and reset it later. According to a maemo-developers email from
1658 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1660 * configure.ac: Depend on libalarm for Maemo.
1662 * src/dbus_api/modest-dbus-api.h:
1663 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1664 (on_send_receive), (modest_dbus_req_handler):
1665 Handle a SEND_RECEIVE D-Bus method.
1667 * libmodest-dbus-client/libmodest-dbus-client.c:
1668 (libmodest_dbus_client_send_and_receive):
1669 * libmodest-dbus-client/libmodest-dbus-client.h:
1670 Add C convenience functions for calling the new D-Bus method.
1672 * src/modest-platform.h:
1673 * src/gnome/modest-platform.c:
1674 * src/maemo/modest-platform.c:
1675 Added modest_platform_set_update_interval(), which uses the
1676 alarmd API on Maemo.
1677 (modest_platform_init),
1678 Call modest_platform_set_update_interval(), using a hard-coded
1679 interval for now (until the global settings dialog is implemented),
1680 though I am not sure that this makes sense yet.
1682 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1684 * src/dbus_api/modest-dbus-callbacks.c:
1685 (modest_osso_cb_hw_state_handler):
1686 * src/dbus_api/modest-dbus-callbacks.h:
1687 * src/maemo/modest-platform.c: (modest_platform_init):
1688 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1689 in case this has some effect on the ability for Maemo to ping the
1692 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1694 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1695 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1696 warning. It is probably a logic error, but I need to fix the build.
1698 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1700 * src/modest-account-mgr.h:
1701 * src/modest-account-mgr.c:
1702 (modest_account_mgr_account_names): Add a gboolean enabled_only
1703 parameter, so we can get lists of onlt the enabled accounts.
1705 (modest_account_mgr_add_account),,
1706 (modest_account_mgr_account_with_display_name_exists):
1707 * src/maemo/modest-msg-edit-window.c: (get_transports):
1708 * src/modest-account-mgr-helpers.c:
1709 (modest_account_mgr_set_first_account_as_default):
1710 * src/modest-init.c: (init_default_account_maybe):
1711 * src/modest-tny-account-store.c: (get_accounts):
1712 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1713 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1714 * tests/check_account-mgr.c: (START_TEST):
1715 Provide the extra parameter, as appropriate.
1717 * src/widgets/modest-account-view.c: (update_account_view):
1718 Do not show disabled accounts (meaning that there is no way to
1719 enable/disable accounts in the UI (the feature is not in our UI
1720 specification), so we can use this internally only to mark unfinished
1721 or temporary account data.
1723 * src/maemo/easysetup/modest-easysetup-wizard.c:
1724 (create_account): Add boolean enable parameter, so we can specify FALSE
1725 to create the temporary account.
1726 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1727 (on_before_next): When finishing, when there is a temporary account, just
1729 Also, use a timeout to delay the showing of the dialog until gconf is likely
1730 to return correct information, due to a maemo gconf bug that is fixed in
1731 osso 1.1, but not yet in Bora.
1732 However, the dialog stays on screen after it is destroyed.
1734 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1735 for invalid data when cancelling. Use a hildon note instead of a dialog
1736 to complain about invalid data. Do not show the account-saved note if the
1737 account is disabled (a temporary account that will not really be saved for use
1740 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1742 * src/modest-account-mgr-helpers.h:
1743 * src/modest-account-mgr-helpers.c:
1744 Added modest_account_mgr_unset_default_account(),
1745 Added modest_account_mgr_set_first_account_as_default().
1747 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1748 If it was the default account, unset the default account name.
1750 * src/maemo/modest-account-view-window.c:
1751 (on_delete_button_clicked): If it was the default account,
1752 set the first remaining account as the default instead.
1754 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1755 a NULL account or a NULL default account, to prevent a crash. This should
1756 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1759 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1761 * src/widgets/modest-recpt-editor.c:
1762 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1763 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1764 TODO comment for this. This fixes the build.
1766 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1767 be the best place for it. This will in future update all auto-update accounts,
1768 rather than just the current/default account, when that gconf key exists.
1769 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1770 if there are no accounts, before calling do_send_receive().
1771 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1773 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1774 * src/maemo/modest-main-window-ui.h:
1775 * src/maemo/modest-main-window.c: (on_connection_changed),
1776 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1777 directly, becaue the signal handler does more.
1779 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1781 * src/modest-account-mgr-helpers.c:
1782 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1783 for the case that the account does not exist.
1785 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1786 (equivalent to the modest account name) rather than the tinymail account name
1787 (equivalent to the modest account title - human readable) to get the account data.
1788 Check for null account data to prevent the crash, and add a TODO comment saying that
1789 this needs fixing because it is using the server account name instead of the account name.
1791 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1794 * src/maemo/modest-account-settings-dialog.c: (show_error),
1796 Use hildon_note_new_information() for informative and error messages,
1797 which seems to be expected for Maemo applications (no documentation that I know of
1798 says this). I am surprised that there is no distinction between info and error
1801 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1803 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1804 it is easy to find where this is used.
1806 * src/maemo/easysetup/modest-easysetup-wizard.c:
1807 (create_page_welcome), (create_page_account_details),
1808 (create_page_user_details), (create_page_complete_easysetup),
1809 (create_page_custom_incoming), (create_page_custom_outgoing),
1810 (create_page_complete_custom):
1811 * src/maemo/modest-account-settings-dialog.c:
1812 (create_page_account_details), (create_page_user_details),
1813 (create_page_incoming), (create_page_outgoing):
1814 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1816 (modest_connection_specific_smtp_edit_window_init):
1817 * src/maemo/modest-connection-specific-smtp-window.c:
1818 (modest_connection_specific_smtp_window_init):
1819 * src/maemo/modest-signature-editor-dialog.c:
1820 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1821 and scrolling policy as per the Email Application Layout Guide, if I have
1824 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1827 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1828 which were empty, because these vfuncs have been removed from TnyAccountStore.
1829 This fixes the build.
1831 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/modest-main-window.c:
1834 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1835 showing/hiding it. Added TODO because it probably should not be NULL.
1836 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1837 because unnecessary g_warnings() make degugging difficult.
1839 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1841 * src/maemo/modest-msg-edit-window.c:
1842 (modest_msg_edit_window_select_color),
1843 (modest_msg_edit_window_select_background_color): 2 const corrections and
1844 moving 2 #endifs before closing brackets, to fix the build.
1846 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1848 * src/maemo/easysetup/modest-easysetup-wizard.h:
1849 * src/maemo/easysetup/modest-easysetup-wizard.c:
1850 (modest_easysetup_wizard_dialog_finalize),
1851 (on_button_edit_advanced_settings), (create_page_complete_custom),
1852 (on_response), (create_account):
1853 Implement the Advanced Settings edit button, by saving the account information,
1854 for the Advanded Settings dialog to use directly from gconf, and removing it
1855 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1856 Bug #5533 in the projects.maemo.org bugzilla.
1858 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1860 * src/maemo/modest-msg-view-window.c:
1861 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1862 when opening a message window.
1864 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1866 * src/maemo/easysetup/modest-easysetup-wizard.c:
1867 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1870 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1871 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1872 gconf settings. I probably added more checks than necessary, but that is safer.
1874 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1875 variable to fix the build, but this seems to be used when it is still NULL.
1877 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1879 * src/modest-platform.h:
1880 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1881 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1882 * src/modest-main.c: Implement this function so we can avoid using
1883 maemo-specific API from cross-platform code.
1885 * src/modest-tny-account-store.c:
1886 (get_smtp_specific_transport_account_for_open_connection):
1887 * src/modest-ui-actions.c: (check_for_connection),
1888 (modest_ui_actions_on_item_not_found):
1889 Use modest_platform_connect_and_wait() and put #idefs around other
1890 maemo-specific code, because only maemo currently has a way to
1891 identify connection names.
1893 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1895 * src/modest-tny-account-store.h:
1896 * src/modest-tny-account-store.c:
1897 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1898 the connection-specific SMTP server settings in the configuration.
1900 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1902 * src/maemo/modest-main-window.c: (on_connection_changed),
1904 * src/modest-main.c: (main), (start_ui), (send_mail):
1905 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1906 that is what is intended.
1908 * src/modest-ui-actions.c: (action_send), (action_receive),
1909 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
1910 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
1911 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
1912 SMTP server is used when it is specified.
1914 (modest_ui_actions_on_send_receive):
1915 Check that a connection is open before proceeding.
1916 Receive and then send, instead of vice-versa, as per the specification.
1918 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1920 * src/modest-mail-operation.c:
1921 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
1922 though I guess it should be something other than NULL.
1924 2007-04-26 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/easysetup/modest-easysetup-wizard.c:
1927 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
1928 combo twice, to avoid an g_warning and to make it visible again.
1929 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
1930 attached before detaching it, to avoid a g_warning, and add comment about the implicit
1931 (already intended) dereference when detaching, because we then recreate the menu.
1932 But I am not sure why the warning was happening, and it is possible that this is a memory
1935 2007-04-25 Murray Cumming <murrayc@murrayc.com>
1937 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
1938 and uri_parse_mailto() utility functions.
1939 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
1941 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
1943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1945 * src/dbus_api/modest-dbus-api.h:
1946 * src/dbus_api/modest-dbus-callbacks.c:
1947 Use an idle callback to execute the modest code in the application's own thread.
1948 Remove the helloworld example method.
1949 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
1950 parsed, and the open-message method is not implemented because this is not yet implemented in
1952 * libmodest-dbus-client/libmodest-dbus-client.c:
1953 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1954 (libmodest_dbus_client_open_message):
1955 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
1957 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
1958 body without crashing.
1960 * tests/dbus_api/Makefile.am:
1961 * tests/dbus_api/test_mail_to.c:
1962 * tests/dbus_api/test_open_message.c: New tests for the new methods.
1964 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1966 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1967 Added file to fix the build. Sorry.
1969 * src/dbus_api/Makefile.am:
1970 * src/dbus_api/modest-dbus-api.h:
1971 * src/dbus_api/modest-dbus-callbacks.h:
1972 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
1973 (modest_dbus_req_handler):
1974 Put constants in a separate header so it can be reused by the
1975 client library, without duplication
1977 * libmodest-dbus-client/Makefile.am:
1978 * libmodest-dbus-client/libmodest-dbus-client.c:
1979 (libmodest_dbus_client_call_helloworld),
1980 (libmodfest_dbus_client_send_mail),
1981 (libmodfest_dbus_client_mailto),
1982 (libmodfest_dbus_client_open_message):
1983 * libmodest-dbus-client/libmodest-dbus-client.h:
1984 (Partly) Implement a send_mail D-Bus method.
1986 * tests/dbus_api/Makefile.am:
1987 * tests/dbus_api/test_send_mail.c: (main): Added a test for
1988 the send_email D-Bus method.
1990 2007-04-24 Murray Cumming <murrayc@murrayc.com>
1994 * libmodest-dbus-client/Makefile.am:
1995 * libmodest-dbus-client/libmodest-dbus-client.c:
1996 * libmodest-dbus-client/libmodest-dbus-client.h:
1997 * tests/dbus_api/Makefile.am:
1998 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
1999 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2001 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2003 * src/maemo/easysetup/modest-easysetup-wizard.c:
2004 (create_page_account_details):
2005 * src/maemo/modest-account-settings-dialog.c:
2006 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2007 widgets, because this might not be the default in future versions of the Maemo GTK+.
2008 However, I can not not get capitalization to work even in a simple test case.
2010 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2012 * src/maemo/easysetup/modest-easysetup-wizard.c:
2013 (create_page_custom_incoming), (create_page_custom_outgoing):
2014 * src/maemo/modest-account-settings-dialog.c:
2015 (create_page_account_details), (create_page_incoming),
2016 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2017 instead of using gtk_check_button_with_label(), so they are aligned like the other
2018 widgets, as per the UI spec.
2020 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/easysetup/modest-easysetup-wizard.c:
2023 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2024 * src/widgets/modest-validating-entry.c:
2025 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2026 Modest prefix instead of an EasySetup prefix.
2028 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2030 * src/widgets/modest-validating-entry.h:
2031 * src/widgets/modest-validating-entry.c: (on_insert_text),
2032 Added easysetup_validating_entry_set_max_func(), used to set a callback
2033 to call when the max number of characters is reached. GtkEntry has a max-length
2034 already but is silent about it.
2036 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2037 (create_page_account_details), (create_page_user_details),
2039 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2040 (create_page_account_details), (create_page_user_details),
2041 (create_page_outgoing):
2042 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2043 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2044 the UI spec, when the user tries to enter more than the max number of characters.
2046 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2048 * src/maemo/easysetup/modest-easysetup-wizard.c:
2049 (create_page_user_details), (create_page_custom_incoming),
2050 (create_page_custom_outgoing):
2051 * src/maemo/modest-account-settings-dialog.c:
2052 (create_page_user_details), (create_page_incoming),
2053 (create_page_outgoing):
2054 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2055 (modest_connection_specific_smtp_edit_window_init):
2056 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2057 not appropriate. Bad Maemo-specific defaults!.
2059 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2061 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2062 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2063 (modest_signature_editor_dialog_set_settings):
2064 Disable the label and textview when the checkbox is disabled, and use the
2065 specified (UI spec) default signature text.
2067 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2070 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2072 * src/modest-defs.h:
2073 * src/modest-account-mgr-helpers.h:
2074 * src/modest-account-mgr-helpers.c:
2075 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2077 * src/maemo/Makefile.am:
2078 * src/maemo/modest-signature-editor-dialog.c:
2079 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2082 * src/maemo/modest-account-settings-dialog.h:
2083 * src/maemo/modest-account-settings-dialog.c:
2084 (modest_account_settings_dialog_finalize), (on_button_signature),
2085 (save_configuration): Use the new dialog when the Edit button is pressed, and
2086 save the changes if necessary, as per the UI spec.
2088 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2090 * src/maemo/Makefile.am:
2091 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2092 based on maemo-develoers email from Dirk.
2094 * src/maemo/easysetup/modest-easysetup-wizard.c:
2095 (create_page_welcome), (create_page_account_details),
2096 (create_page_user_details), (create_page_complete_easysetup),
2097 (create_page_custom_incoming), (create_page_custom_outgoing),
2098 (create_page_complete_custom),
2099 (modest_easysetup_wizard_dialog_init):
2100 * src/maemo/modest-account-settings-dialog.c:
2101 (create_page_account_details), (create_page_user_details),
2102 (create_page_incoming), (create_page_outgoing),
2103 (modest_account_settings_dialog_init):
2104 * src/maemo/modest-connection-specific-smtp-window.c:
2105 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2107 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2109 * src/maemo/easysetup/modest-easysetup-wizard.c:
2110 (create_page_account_details), (create_page_custom_outgoing),
2111 (create_page_complete_custom):
2112 * src/maemo/modest-account-settings-dialog.c:
2113 (create_page_user_details), (create_page_incoming),
2114 (create_page_outgoing):
2115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2116 (modest_connection_specific_smtp_edit_window_init):
2117 Use the correct (UI spec) port min/max, and use horizontal separators,
2120 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2122 * src/maemo/easysetup/modest-easysetup-wizard.c:
2123 (set_default_custom_servernames):
2124 * src/maemo/modest-account-settings-dialog.c:
2125 (create_page_incoming), (on_combo_outgoing_security_changed),
2126 (on_combo_incoming_security_changed), (create_page_outgoing),
2127 (modest_account_settings_dialog_set_account_name),
2128 (save_configuration):
2129 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2130 (on_combo_security_changed),
2131 (modest_connection_specific_smtp_edit_window_init),
2132 (modest_connection_specific_smtp_edit_window_set_connection),
2133 (modest_connection_specific_smtp_edit_window_get_settings):
2134 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2137 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2140 * src/maemo/easysetup/modest-easysetup-wizard.c:
2141 (create_page_custom_outgoing), (create_page_complete_custom):
2142 * src/maemo/modest-account-settings-dialog.c:
2143 (create_page_user_details), (create_page_outgoing):
2144 * src/maemo/modest-account-view-window.c: (button_box_new):
2145 Use changed logical IDs as per the most recent UI spec:
2146 mcen_bd_emailsetup_edit -> mcen_bd_edit
2147 mcen_bd_emailsetup_delete -> mcen_bd_delete
2148 mcen_bd_emailsetup_close -> mcen_bd_close
2150 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2154 * src/dbus_api/Makefile.am:
2155 * src/dbus_api/modest-dbus-callbacks.c:
2156 * src/dbus_api/modest-dbus-callbacks.h:
2157 * src/maemo/modest-platform.c: (modest_platform_init):
2158 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2160 * tests/Makefile.am:
2161 * tests/dbus_api/Makefile.am:
2162 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2164 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2166 * src/maemo/modest-account-settings-dialog.c:
2167 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2168 Removed unnecessary includes.
2170 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2172 * src/maemo/easysetup/modest-easysetup-wizard.c:
2173 * src/maemo/modest-account-settings-dialog.c:
2174 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2175 * src/widgets/Makefile.am:
2176 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2177 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2178 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2179 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2180 * src/widgets/modest-secureauth-combo-box.c:
2181 * src/widgets/modest-secureauth-combo-box.h:
2182 * src/widgets/modest-serversecurity-combo-box.c:
2183 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2184 made the GObject names more consistent with the rest of the Modest code.
2186 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2188 * src/maemo/easysetup/Makefile.am:
2189 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2190 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2191 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2192 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2193 * src/maemo/easysetup/modest-easysetup-wizard.c:
2194 * src/maemo/easysetup/modest-validating-entry.c:
2195 * src/maemo/easysetup/modest-validating-entry.h:
2196 * src/maemo/modest-account-settings-dialog.c:
2197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2198 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2199 widgets/ because they are used outside of easysetup too. After checking in,
2200 svn will allow me to rename them too.
2202 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2204 * src/gnome/modest-msg-edit-window.c:
2205 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2206 linker error, to fix the build on the GNOME platform.
2207 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2208 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2209 ifdefed out to avoid a warning.
2211 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2213 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2214 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2215 some alternative for GTK+ 2.6.
2217 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2219 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2221 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2222 specified for EmailAccountsDialog in UI spec.
2224 * src/maemo/easysetup/modest-easysetup-wizard.c:
2225 * src/maemo/easysetup/modest-easysetup-wizard.h:
2226 * src/maemo/modest-account-settings-dialog.c:
2227 * src/maemo/modest-account-settings-dialog.h:
2228 Reuse a member window widget for the connection-specific SMTP server accounts,
2229 so we can tell it to create/save the accounts only if we actually save changes.
2231 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2232 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2233 (modest_connection_specific_smtp_edit_window_get_settings):
2234 Return a struct instance for temporarily remembering the entered data.
2236 * src/maemo/modest-connection-specific-smtp-window.h:
2237 * src/maemo/modest-connection-specific-smtp-window.c:
2238 (modest_connection_specific_smtp_window_finalize),
2239 (modest_connection_specific_smtp_window_fill_with_connections),
2241 (modest_connection_specific_smtp_window_save_server_accounts),
2242 (update_model_server_names): Do not actually save data until asked,
2243 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2245 (on_selection_changed),
2246 (modest_connection_specific_smtp_window_init): Disable the edit
2247 button when nothing is selected.
2249 * src/modest-account-mgr-helpers.c:
2250 * src/modest-account-mgr-helpers.h:
2251 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2254 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2256 * src/modest-account-mgr-helpers.h:
2257 * src/modest-account-mgr-helpers.c:
2258 (modest_account_mgr_get_unused_account_name),
2259 (modest_account_mgr_get_unused_account_display_name): Added these
2260 utility functions, to avoid code duplication.
2262 * src/maemo/easysetup/modest-easysetup-wizard.c:
2263 (create_page_account_details), (create_account):
2264 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2265 (on_combo_security_changed),
2266 (modest_connection_specific_smtp_edit_window_init),
2267 (modest_connection_specific_smtp_edit_window_save_settings):
2268 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2269 * src/maemo/modest-connection-specific-smtp-window.c:
2270 (modest_connection_specific_smtp_window_finalize),
2271 (modest_connection_specific_smtp_window_fill_with_connections),
2272 (on_button_edit), (modest_connection_specific_smtp_window_init):
2273 * src/maemo/modest-connection-specific-smtp-window.h:
2274 Implementing saving of connection-specific server accounts.
2276 But I need to refactor this so we can save the data for each
2277 possible connection-specific account and only actually create the server accounts
2278 when the easysetup finished, or the OK button is pressed on the account settings
2281 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2284 (on_combo_security_changed):
2285 (modest_connection_specific_smtp_edit_window_init):
2286 Auto-fill the port number as in the account settings.
2288 (modest_connection_specific_smtp_edit_window_set_connection):
2289 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2290 * src/maemo/modest-connection-specific-smtp-window.c:
2291 (fill_with_connections), (on_button_edit),
2292 (modest_connection_specific_smtp_window_init):
2293 Turn the edit window into a dialog to simplify the code, and
2294 set a WM hint as in a GtkDialog, because only a popup can be on top of
2295 another window in Maemo, and popups usually have no WM decoration.
2297 * src/modest-defs.h:
2298 * src/modest-account-mgr-helpers.c:
2299 (modest_account_mgr_set_connection_specific_smtp),
2300 (modest_account_mgr_remove_connection_specific_smtp),
2301 (modest_account_mgr_get_connection_specific_smtp):
2302 * src/modest-account-mgr-helpers.h: Some functions to write the
2303 connection-specific SMTP server information. Not yet used.
2306 * src/widgets/modest-folder-view.c: (text_cell_data):
2307 Fix a warning about an uninitialized variable.
2308 (on_configuration_key_changed): Put an #ifdef around the use
2309 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2311 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2313 * src/maemo/modest-account-settings-dialog.h:
2314 * src/maemo/modest-account-settings-dialog.c:
2315 Added connect_for_modified() utility function to mark the new modified boolean.
2317 (create_page_account_details), (create_page_user_details),
2318 (create_page_incoming), (create_page_outgoing), (on_response),
2319 (modest_account_settings_dialog_init),
2320 (modest_account_settings_dialog_set_account_name):
2321 Only warn about unsaved changes when there are actually unsaved changes.
2323 * src/modest-account-mgr-helpers.c:
2324 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2325 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2326 to get the data from there in future.
2328 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2330 * src/modest-defs.h:
2332 * src/modest-account-mgr-helpers.h:
2333 * src/modest-account-mgr-helpers.c:
2334 Store the security account setting in a single conf key instead of using
2335 the options list, so that the list is left for just the to-be-removed camel hack,
2336 and because gconf_client_set_list() is failing for some reason.
2338 * src/modest-account-mgr.c:
2339 (modest_account_mgr_add_server_account):
2340 * src/maemo/modest-account-settings-dialog.c:
2341 (modest_account_settings_dialog_set_account_name),
2342 (save_configuration): Use the renamed functions.
2345 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2347 * src/widgets/Makefile.am:
2348 * src/widgets/modest-limit-retrieve-combo-box.c:
2349 * src/widgets/modest-limit-retrieve-combo-box.h:
2350 * src/widgets/modest-retrieve-combo-box.c:
2351 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2352 the account settings dialog.
2354 * src/modest-defs.h:
2355 * src/modest-account-mgr-helpers.h:
2356 * src/modest-account-mgr-helpers.c:
2357 (modest_server_account_get_option_secure_auth),
2358 (modest_server_account_set_option_secure_auth):
2359 * src/modest-account-mgr.c:
2360 (modest_account_mgr_add_server_account):
2361 Use the existing AUTH_MECH conf key for the secure-auth setting,
2362 instead of putting it in the list options, because this was actually used already.
2364 * src/maemo/modest-account-settings-dialog.c:
2365 (create_page_account_details),
2366 (modest_account_settings_dialog_set_account_name),
2367 (save_configuration):
2368 * src/maemo/modest-account-settings-dialog.h:
2369 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2370 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2372 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2374 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2375 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2376 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2378 * src/modest-defs.h:
2379 * src/maemo/modest-account-settings-dialog.c:
2380 (create_page_incoming), (on_combo_outgoing_security_changed),
2381 (on_combo_incoming_security_changed), (create_page_outgoing),
2382 (modest_account_settings_dialog_set_account_name),
2383 (save_configuration): Load/Save the port number, and change it when the
2384 security combo changes, to suitable defaults.
2386 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2388 * src/modest-account-mgr.c:
2389 (modest_account_mgr_add_server_account): Set the security and secure-auth
2390 options, and add a comment saying that the other camel-specific options should be
2393 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2395 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2397 * src/modest-tny-account-store.c: (account_list_free),
2398 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2399 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2402 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2404 * src/modest-protocol-info.c:
2405 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2406 is required by our UI spec. Maybe something in our implementation will use this eventually.
2407 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2408 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2409 instead of the previous 0 placeholder.
2411 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2412 secure-auth settings.
2413 * src/modest-account-mgr-helpers.h:
2414 * src/modest-account-mgr-helpers.c:
2415 (modest_server_account_data_get_option_secure_auth),
2416 (modest_server_account_set_option_secure_auth),
2417 (modest_server_account_data_get_option_security),
2418 (modest_server_account_set_option_security): Added this API for getting and setting the security
2419 and secure-auth settings.
2421 * src/maemo/modest-account-settings-dialog.h:
2422 * src/maemo/modest-account-settings-dialog.c:
2423 (modest_account_settings_dialog_finalize), (check_data),
2424 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2425 about changing titles.
2426 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2427 (save_configuration): Save the security and secure-auth settings.
2429 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2430 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2432 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2434 * src/modest-defs.h:
2435 * src/modest-account-mgr.c:
2436 (modest_account_mgr_add_server_account):
2437 Added and used defines for the options key and value pair strings,
2438 that are used so far, though they do not seem to correspond to anything in our
2439 UI specs or ModestProtocol enum.
2441 * src/modest-account-mgr-helpers.h:
2442 * src/modest-account-mgr-helpers.c:
2443 (compare_option_strings_for_name),
2444 (modest_server_account_data_get_option_value),
2445 (modest_server_account_data_get_option_bool),
2446 (modest_account_mgr_get_server_account_option):
2447 Added helper functions for parsing the options GSList.
2449 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2451 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2452 display name is based on the supplied account name.
2453 * src/modest-account-mgr.c:
2454 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2455 with an inefficient, but good-enough, implementation.
2457 * src/maemo/easysetup/modest-easysetup-wizard.c:
2458 (create_page_account_details), (on_before_next), (create_account):
2459 Check for existing display names rather than (non-user-visible) account names, and just
2460 create and set a unique account name at the end.
2462 * src/maemo/modest-account-settings-dialog.c:
2463 (modest_account_settings_dialog_init),
2464 (modest_account_settings_dialog_set_account_name),
2465 (create_page_incoming): Show the display name, instead of the account name.
2466 (on_response): Do some (not all) extra checks, as in the UI spec.
2467 (save_configuration): Save the display name if it was changed.
2469 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2471 * po/en_GB.po: Added needed logical ID and translation.
2472 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2473 (init_view): Made the is-default column clicking work.
2475 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2478 * src/maemo/easysetup/Makefile.am:
2479 * src/maemo/easysetup/modest-easysetup-wizard.c:
2480 (modest_easysetup_wizard_dialog_init):
2481 * src/maemo/easysetup/provider-data-test.keyfile:
2482 * src/maemo/easysetup/provider-data.keyfile:
2483 Moved the provider data file to the new modest-providers-data package and used it from there.
2485 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2487 * src/modest-local-folder-info.c:
2488 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2489 N_() was already used on the static strings, but this just marks it for translation without
2490 using the translation.
2492 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2494 * src/maemo/modest-account-settings-dialog.c:
2495 (create_page_incoming),
2496 (modest_account_settings_dialog_set_account_name):
2497 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2498 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2499 I will do this if nobody else gets there first.
2501 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2503 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2504 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2505 save the security stuff.
2507 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2510 Set the email address and user fullname, which I now see must be
2513 * src/maemo/modest-account-settings-dialog.h:
2514 * src/maemo/modest-account-settings-dialog.c:
2516 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2517 leave-on-server and authentication.
2518 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2521 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2524 * src/maemo/modest-account-settings-dialog.c:
2525 * src/maemo/modest-account-settings-dialog.h:
2526 Most (but not all) of the widgets are now present as specified by the UI spec.
2527 No changes are yet saved, and some details are not properly shown yet.
2529 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2531 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2533 * src/maemo/Makefile.am:
2534 * src/maemo/modest-account-settings-dialog.c:
2535 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2536 an existing account. Doesn't do much yet.
2538 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2539 Open the accounts settings dialog when Edit is clicked.
2541 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/easysetup/Makefile.am:
2544 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2546 * src/maemo/easysetup/modest-easysetup-wizard.c:
2547 (modest_easysetup_wizard_dialog_init):
2548 Try to get the source directory from the build system,
2549 instead of hard-coding "./" into the source code, when opening our local
2550 copies of the configuration files.
2551 But this still fails when opening the wizard from the Accounts window,
2552 maybe because the working directory seems to change at runtime.
2553 So the wizard will fail the second time unless you copy the files into their
2554 proper locations - see the stdout warnings for the paths.
2556 (create_page_account_details),(on_before_next):
2557 Check for existing non-server accounts instead of server accounts,
2558 so the default account name is useful again, and to prevent trying to
2561 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2562 Show the wizard when New is clicked.
2564 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2565 (init_view): Show the column headers, and show the columns that are
2566 specified in the UI specs. However, something in Maemo's GTK+ prevents
2567 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2568 change the default account. This is despite unsetting the special properties.
2570 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2572 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2573 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2574 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2575 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2576 to make that clearer.
2577 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2579 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2581 * src/maemo/modest-account-view-window.c:
2582 (modest_account_view_window_init),
2583 (modest_account_view_window_new):
2584 Use the same buttons as specified in the
2585 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2586 the existing widgets, which never had a chance of working.
2587 Put the ModestAccountView treeview in a scrolled window.
2588 Do not repeat the initialization in both _init() and _new().
2590 * src/widgets/modest-account-view.c: (update_account_view):
2591 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2592 this widget and window shows no accounts.
2594 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2596 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2598 * src/maemo/easysetup/modest-easysetup-wizard.c:
2599 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2600 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2601 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2604 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2605 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2606 accounts exist yet, as in the UI spec.
2608 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2610 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2612 * src/maemo/Makefile.am:
2613 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2614 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2615 New window for editing connection-specific smtp details.
2616 Not fully implemented.
2618 * src/maemo/modest-connection-specific-smtp-window.c:
2619 (modest_connection_specific_smtp_window_finalize) :
2620 unref the tree model.
2621 (on_button_edit): Show the edit window.
2623 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2625 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2628 * src/maemo/Makefile.am:
2629 * src/maemo/modest-connection-specific-smtp-window.c:
2630 * src/maemo/modest-connection-specific-smtp-window.h:
2631 New window for showing the list of connections, for connection-specific
2632 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2633 * src/maemo/easysetup/modest-easysetup-wizard.c:
2634 (create_page_custom_outgoing): Show the new window when the button is clicked.
2636 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2638 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2639 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2640 * src/maemo/modest-msg-edit-window.c:
2641 (modest_msg_edit_window_insert_image):
2642 * src/modest-conf.c: (modest_conf_key_escape):
2643 * src/modest-mail-operation.c:
2644 (modest_mail_operation_send_new_mail):
2645 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2646 (modest_ui_actions_on_new_account):
2647 * src/widgets/modest-attachment-view.c: (update_filename_request):
2648 * src/widgets/modest-mail-header-view.c:
2649 Corrected warnings that were breaking the build, by commenting out unused variables,
2650 and a function, and by including a header.
2652 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2654 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2655 so we can #ifdef around platform-specific code when necessary.
2656 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2657 to allow this to build for the GNOME platform too.
2659 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2661 * src/maemo/easysetup/modest-easysetup-wizard.c:
2662 Added util_increment_name() and used it in create_page_account_details()
2663 to make sure that the default account name is always a new name.
2665 (modest_easysetup_wizard_dialog_init),
2666 (set_default_custom_servernames): Some minor memory management fixes.
2668 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2672 * src/modest-runtime.c: (init_i18n): Restored the translation
2673 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2674 are defined in config.h, and the translations are installed.
2676 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2677 is defined for translation.
2679 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2681 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2683 * src/maemo/easysetup/modest-easysetup-wizard.c:
2684 (modest_easysetup_wizard_dialog_init):
2685 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2686 Use realistic paths (though they should use $prefix generically) to the
2687 mcc_mapping and provider-data.keyfile files which might work when they
2688 are installed by the future version of the operator-wizard package,
2689 and then fallback to paths in our source code, with an explanatory
2692 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/Makefile.am:
2697 * src/maemo/easysetup/: Added files from the previously-exernal
2698 osso-modest-easysetup.
2699 * src/maemo/modest-main-window-ui.h:
2700 * src/modest-ui-actions.c:
2701 * src/modest-ui-actions.h:
2702 Added modest_ui_actions_on_new_account() as a signal handler for the
2703 New Account menu item. It shows the easysetup wizard.
2704 * po/en_GB.po: Added additional needed logical IDs and translations.
2706 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2707 Apparently ChangeLog is not used for some vague Nokia legal reasons.