1 2007-08-15 Murray Cumming <murrayc@murrayc.com>
3 * src/widgets/modest-recpt-editor.c:
4 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
5 to fix projects.maemo.org bug NB#63789.
7 2007-08-15 Murray Cumming <murrayc@murrayc.com>
9 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
10 (modest_tny_account_store_new): Properly detect the memory card at
11 startup, and add an account for it.
13 2007-08-14 Murray Cumming <murrayc@murrayc.com>
15 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
16 Commented out the MMC code again because it mistakenly detects
17 the card even when it isn't inserted.
19 2007-08-14 Murray Cumming <murrayc@murrayc.com>
21 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
22 Renabled the call to add_mmc_account() because I do not believe
23 it could be the cause of the mentioned hang (in scratchbox, where
24 there is no memory card), and because I have tested that it works
27 2007-08-14 Murray Cumming <murrayc@murrayc.com>
29 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
30 Comment out part of the last commit because it apparently causes
33 2007-08-14 Murray Cumming <murrayc@murrayc.com>
35 * src/modest-tny-account-store.c: Added the add_mmc_account()
36 function to save some copy/pasting.
37 (modest_tny_account_store_new): If the memory card is mounted,
38 create an account for it at the start, instead of waiting for the
39 user to unmount it and mount it.
41 2007-08-13 Murray Cumming <murrayc@murrayc.com>
43 * src/widgets/modest-account-view.c: (on_account_changed):
44 Do not try to use the human-readable TnyAccount name instead of the
45 ID of the modest account to get the transport account. And unref
46 the transport account. This prevents a g_warning(), and a possible
49 2007-08-13 Murray Cumming <murrayc@murrayc.com>
51 * src/maemo/modest-platform.c:
52 (modest_platform_set_update_interval): Handle the new
53 alarmd error to warn when alarmd is not running, as is the case in
54 scratchbox for me now because
55 "Module /usr/lib/alarmd/libretu.so initialization failed"
57 2007-08-13 Murray Cumming <murrayc@murrayc.com>
59 * src/widgets/modest-header-view-render.c:
60 (_modest_header_view_compact_header_cell_data):
61 NULL some strings after freeing them, trying to deal with
62 the double deletion found in projects.maemo.org bug 64183,
63 probably having no effect.
65 2007-08-13 Murray Cumming <murrayc@murrayc.com>
67 * src/maemo/modest-account-settings-dialog.c:
68 (create_page_incoming), (create_page_outgoing): Use a define
69 for the min and max port numbers.
71 (check_hildon_number_editor_and_warn_value_not_in_range),
72 (check_data): Do an extra check for an invalid port number, as needed
73 in projects.maemo.org bug #64275, when the number is cleared, but this
74 does not work due to bugs.maemo.org bug #1806.
76 2007-08-13 Murray Cumming <murrayc@murrayc.com>
78 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
79 Comment out the debug warning about the unexpected D-Bus methods.
80 They are just annoying now.
81 * src/maemo/modest-platform.c:
82 (modest_platform_set_update_interval): Correct the D-Bus path, instead
83 of using a file path, though it did not seem to break things before.
84 It might be needed now:
85 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
86 modest is not already running. This is the behaviour of the old client, and
87 Mox says it is what we should do for modest.
88 This closes projects.maemo.org bug NB#64327.
90 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
92 * src/modest-text-utils.c:
93 Fixed invalid jump due to incorrect string/pointer
95 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
98 2007-08-01 Murray Cumming <murrayc@murrayc.com>
100 * src/modest-account-mgr-helpers.h:
101 * src/modest-account-mgr-helpers.c:
102 Added modest_account_mgr_get_first_account_name(),
103 using code from modest_account_mgr_set_first_account_as_default().
105 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
106 (account_number_changed): Call set_at_least_one_account_visible() so that
107 the first account is visible when first added, without the user having to
109 I do wonder how this worked before.
111 2007-08-01 Murray Cumming <murrayc@murrayc.com>
113 * src/modest-tny-account-store.c: (show_password_warning_only),
114 (show_wrong_password), (request_password_and_wait), (get_password),
115 (modest_tny_account_store_alert): Remove the (incomplete anyway)
116 attempts to show UI only in the main context, which used g_idle_add()
117 and mainloops, because tinymail now guarantees that it only calls these
118 callbacks in the mainloop with the gdk lock. This makes everything much
121 2007-08-01 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
124 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
125 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
126 error dialog, instead of ignoring it.
128 2007-08-01 Murray Cumming <murrayc@murrayc.com>
130 * src/maemo/modest-msg-view-window.c:
131 (modest_msg_view_window_get_header),
132 (modest_msg_view_window_last_message_selected):
133 Added comments to explain the use of priv->header_model.
134 * src/modest-ui-dimming-rules.c:
135 (modest_ui_dimming_rules_on_open_msg),
136 (modest_ui_dimming_rules_on_mark_as_read_msg),
137 (modest_ui_dimming_rules_on_mark_as_unread_msg),
138 (modest_ui_dimming_rules_on_remove_attachments),
139 (_invalid_attach_selected), (_selected_msg_marked_as):
140 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
141 and changed the parameter to a ModestMainWindow to make it clearer that
142 it never uses any other kind of window.
143 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
144 instead of the selected message.
145 I notice that much of the dimming code and the ModestMsgViewWindow code
146 hard-codes the assumption that the viewed message is always selected in
147 the header view. This does not seem wise or simple.
149 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
150 examine the actual message instead of whatever might be selected
151 in the header view. This stops the delete toolbar button and menu item
152 from being dimmed when opening a message view the search UI,
153 partially fixing projects.maemo.org bug NB#63811.
155 However, when actually deleting, I now get this warning:
156 "tny_header_set_flags: This is a header instance for a new message.
157 Only priority and attachment flags are supported"
159 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
161 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
163 Show account wizard if no accounts are defined while sending
164 (automatic sending after the account wizard finished does not
165 work because it takes some time until the account manager
166 synchronizes everything. (projects.maemo.org NB#62792)
168 2007-07-30 Murray Cumming <murrayc@murrayc.com>
170 * src/modest-tny-account-store.c: (on_account_removed),
171 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
172 account is removed from the View menu. We have TnyAccountStore
173 and ModestTnyAccountStore signals that seem very similar, but this
174 seems to work for now.
176 * src/maemo/modest-main-window.c:
177 (on_show_account_action_activated): Prevent dereference
178 of a NULL if the accoutn does not really exist, though that
179 should not happen anymore.
181 This fixes projects.maemo.org bug NB#64606.
183 2007-07-30 Murray Cumming <murrayc@murrayc.com>
185 * src/modest-ui-actions.c: (run_account_setup_wizard),
186 (modest_ui_actions_on_accounts): Revert a change that set these
187 to modal dialogs, freezing the UI when they show secondary dialogs.
188 This fixed projects.maemo.org bug NB#64519.
190 2007-07-27 Murray Cumming <murrayc@murrayc.com>
192 * src/widgets/modest-header-view-render.c:
193 (_modest_header_view_compact_header_cell_data):
194 Some checks and initialization to try to deal with a crash,
195 probably ineffective.
197 2007-07-27 Murray Cumming <murrayc@murrayc.com>
199 * src/maemo/modest-maemo-utils.c:
200 (modest_maemo_utils_get_supported_secure_authentication_methods):
201 Make sure that we have a connection, asking the user for one
203 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
204 Check for a connection before showing the wizard, because
205 the wizard needs a connection to check for server capabilities.
207 2007-07-27 Murray Cumming <murrayc@murrayc.com>
209 * src/maemo/modest-account-view-window.c:
210 (on_new_button_clicked): Remember the wizard dialog instance,
211 so we can just present it again if necessary. This prevents
212 multiple windows from appearing if you click again quickly on the
213 New button before the dialog appears, fixing projects.maemo.org
216 2007-07-27 Murray Cumming <murrayc@murrayc.com>
218 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
219 Offer a connection dialog if there is no connection when
220 starting modest. This should fix projects.maemo.org bug NB#61134.
222 2007-07-27 Murray Cumming <murrayc@murrayc.com>
224 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
225 Reverted my last commit. I was able to fix the build by doing
226 apt-get install wpeditor0 (replacing other wpeditor packages) and
227 an explicit apt-get install wpeditor-dev to upgrade the -dev
230 2007-07-27 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
233 Commented out the use of wp_text_buffer_replace_image()
234 because it does not exist, to break the build. Added a TODO for it.
236 2007-07-26 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-tny-account-store.c: (recreate_all_accounts):
239 Recreate them even if they were NULL before. I guess something
240 else was already creating them before, or this would never
242 (modest_tny_account_store_get_server_account): Make sure that
243 the tny accounts have been created before trying to find one.
244 This allows libmodest_dbus_client_compose_mail() to work
245 when the UI is not yet visible.
246 This is probably useful in other cases too.
248 (get_password): When the password is wrong after it is entered
249 in the protected password dialog, show an info banner (in an
250 idle handler) before showing the protected password dialog
253 2007-07-26 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-ui-actions.h:
256 * src/modest-ui-actions.c: Added
257 modest_do_refresh_current_folder() containing some code from
258 modest_ui_actions_on_send_receive().
259 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
260 Call modest_do_refresh_current_folder() before refreshing the
261 requested account, as in modest_ui_actions_on_send_receive().
262 This is strange, but seems to be necessary to show new mails.
263 Now new emails are finally visible in the UI when downloaded
264 via the automatic update interval, fixing bug NB#57458.
265 This also works because bug NB#57458 has been fixed somehow.
267 2007-07-26 Murray Cumming <murrayc@murrayc.com>
269 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
270 printf more details when we get unhandled D-Bus methods, because
273 * src/modest-mail-operation.c: (update_account_thread):
274 Comment out the tny_camel_pop_store_account_reconnect(), because this
275 is apparently no longer needed, and it did not work before anyway.
276 See the comment in the code.
278 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
279 by checking the header flags. This fixes projects.maemo.org bug
282 2007-07-25 Murray Cumming <murrayc@murrayc.com>
284 * src/maemo/modest-maemo-utils.h:
285 * src/maemo/modest-maemo-utils.c: Added
286 modest_maemo_show_information_note_in_main_context_and_forget().
287 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
288 Use the new function to show simple error dialogs in the main
289 context, though question dialogs are still in the current context,
290 which is unfortunately usually not the main context. This should
293 2007-07-25 Murray Cumming <murrayc@murrayc.com>
295 * src/modest-tny-account-store.c: (get_password):
296 Never save the entered username and password in gconf,
297 because the UI spec says we should not. This helps
298 slightly with projects.maemo.org bug NB#63671.
300 2007-07-25 Murray Cumming <murrayc@murrayc.com>
302 * src/widgets/modest-msg-edit-window.h:
303 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
304 Moved some code here to make it simpler.
305 (modest_msg_edit_window_attach_file_one): Renamed from
306 modest_msg_edit_window_attach_file_interactive().
307 (modest_msg_edit_window_offer_attach_file): Renamed from
308 modest_msg_edit_window_attach_file() and used
309 modest_msg_edit_window_attach_file_one() instead of
310 copy/pasting the code. The old code for one was not using
311 GnomeVFS. This allows use of smb:// URLs when using send-as
312 from external applications, fixing bug NB#63741.
314 (modest_msg_edit_window_insert_image),
315 (modest_msg_edit_window_add_attachment_clicked):
316 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
317 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
318 Adapted to the new function names.
320 2007-07-25 Murray Cumming <murrayc@murrayc.com>
322 (modest_platform_set_update_interval): Set the alarm recurrence
323 fields so that auto-update does not just happen the first time.
324 This should have fixed projects.maemo.org bug NB#63938.
326 When this happens you can see a printf when the D-Bus method is
328 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
330 However, I do not actually seem to get new POP messages even when
331 clicking the refresh button manually. A restart gets them.
332 This might be a problem in today's tinymail only.
334 2007-07-24 Murray Cumming <murrayc@murrayc.com>
336 * src/maemo/modest-maemo-global-settings-dialog.c:
337 (current_connection):
338 Avoid a crash (probably only in scratchbox) when strcmp()ing a
339 NULL when closing the dialog.
341 2007-07-24 Murray Cumming <murrayc@murrayc.com>
343 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
344 Remove the hacky send/receive that didn't work, and instead
345 refilter the treemodel to make the deleted email really vanish from
346 the UI (though the delete-from-menu code does has commented out
347 the code that does that). This fixes projects.maemo.org bug
350 2007-07-24 Murray Cumming <murrayc@murrayc.com>
352 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
353 Try a couple of tricks to force the treeview to update (
354 poke the folder, and do a send/receive refresh), but the deleted
355 email still appears with a strike-through instead of really being
358 2007-07-23 Murray Cumming <murrayc@murrayc.com>
360 * src/dbus_api/modest-dbus-callbacks.c:
361 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
362 because their ID is not human-readable (see the comment about
363 improvements needed to the osso-email-interface API) and
364 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
366 2007-07-23 Murray Cumming <murrayc@murrayc.com>
368 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
369 (add_folders_to_list), (on_dbus_method_get_folders),
370 (modest_dbus_req_filter):
371 * src/maemo/modest-maemo-utils.c:
372 (on_camel_account_get_supported_secure_authentication):
373 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
374 (on_header_view_focus_in):
375 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
376 * src/modest-formatter.c: (modest_formatter_create_body_part):
377 * src/modest-mail-operation.c: (recurse_folders),
378 (update_account_thread), (get_msgs_full_thread),
379 (modest_mail_operation_get_msgs_full),
380 (modest_mail_operation_xfer_msgs):
381 * src/modest-search.c: (search_mime_part_and_child_parts),
382 (modest_search_account), (modest_search_all_accounts):
383 * src/modest-tny-account.c:
384 (modest_tny_account_get_special_folder), (recurse_folders):
385 * src/modest-tny-local-folders-account.c:
386 (modest_tny_local_folders_account_query_passes):
387 * src/modest-tny-msg.c: (copy_mime_part),
388 (modest_tny_msg_find_body_part_from_mime_part):
389 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
390 (modest_tny_send_queue_try_to_send):
391 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
392 (_modest_ui_actions_open), (download_uncached_messages),
393 (reply_forward), (modest_ui_actions_on_copy),
394 (modest_ui_actions_on_details), (has_retrieved_msgs),
395 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
397 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
398 (_selected_msg_marked_as), (_msg_download_completed),
399 (_selected_msg_sent_in_progress):
400 * src/widgets/modest-attachments-view.c:
401 (modest_attachments_view_set_message):
402 * src/widgets/modest-msg-view.c: (find_cid_image):
403 * tests/check_folder-transfer.c: (find_folders):
404 * tests/check_update-account.c: (func):
405 * tests/dbus_api/test_get_folders.c: (main):
406 Checked all uses of tny_iterator_get_current(), making sure
407 that the object is unreferenced (3 or 4 places did not),
408 and adding checks for NULL.
410 2007-07-23 Murray Cumming <murrayc@murrayc.com>
412 * src/dbus_api/modest-dbus-callbacks.c:
413 (on_idle_open_default_inbox): Make sure that the application UI is
415 * src/maemo/easysetup/modest-easysetup-wizard.c:
416 (on_entry_invalid_character): Show the word whitespace instead
417 of (null) in the banner when whitespace was entered.
418 (show_error): Add a comment that this does not work in
419 Maemo Bora, though we do not know why.
421 2007-07-23 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-tny-account.c:
424 (modest_tny_account_get_special_folder): Use an if instead of
425 an assert for when the parent account name is NULL, because this
426 might be causing a crash in projects.maemo.org bug 63192.
427 * src/modest-mail-operation.c:
428 (modest_mail_operation_send_new_mail_cb),
429 (modest_mail_operation_remove_folder): unref the folder that is
430 returned from modest_tny_account_get_special_folder().
432 2007-07-23 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-ui-actions.c:
435 (modest_ui_actions_on_password_requested):
436 Show mail_ib_login_cancelled info banner when the user cancels
437 the protected password dialog, to fix projects.maemo.org
440 2007-07-23 Murray Cumming <murrayc@murrayc.com>
442 * src/maemo/modest-account-settings-dialog.c:
443 (create_page_outgoing): Put this page in a GtkScrolledWindow,
444 matching the UI mock-up in the UI spec, and allowing access
445 to all widgets even when the on-screen keyboard is active.
447 2007-07-23 Murray Cumming <murrayc@murrayc.com>
449 Reverted this previous commit from Johannes,
450 because the scrollbars are always visible and because
451 I think we only need it on onepage of the account
452 settings, not the account wizard.
453 (I wrote the wrong instructions in the bug.)
455 * src/maemo/easysetup/modest-easysetup-wizard.c:
456 Added scrollbars to account wizard dialog.
457 Fixed projects.maemo.org NB #62744
459 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
461 * src/maemo/easysetup/modest-easysetup-wizard.c:
462 (create_page_user_details):
463 Use auto-cap for name (projects.maemo.org NB#63716)
464 * src/widgets/modest-account-view.c: (on_account_busy_changed):
466 2007-07-22 Armin Burgmeier <armin@openismus.com>
468 * src/maemo/modest-ui-actions.c: Use current account instead of
469 default account for creating viewer windows, so that the viewer
470 window knows to which account the viewed message belongs.
472 * src/maemo/modest-msg-view-window.c: Destroy the window when the
473 corresponding account is deleted. This fixes projects.maemo.org bug
476 2007-07-18 Armin Burgmeier <armin@openismus.com>
478 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
479 the dialog close after entering an invalid port number and clicking
480 OK. This fixes projects.maemo.org bug NB#63602.
482 2007-07-18 Armin Burgmeier <armin@openismus.com>
484 * src/modest-tny-account-store.c:
485 (get_server_accounts): Set parent modest account name for each
486 connection-specific transport account so that special folders of such
487 an account can be looked up. This fixes a crash when changing account
488 settings. This might also be related to projects.maemo.org bug
491 2007-07-16 Armin Burgmeier <armin@openismus.com>
493 * src/modest-ui-actions.c: Added a button to create a folder to the
494 move-to dialog. This fixes projects.maemo.org bug NB#.
496 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
498 * src/maemo/easysetup/modest-easysetup-wizard.c:
499 Added scrollbars to account wizard dialog.
500 Fixed projects.maemo.org NB #62744
502 2007-07-16 Murray Cumming <murrayc@murrayc.com>
504 * src/widgets/modest-msg-view.h:
505 * src/widgets/modest-msg-view.c:
506 Added modest_msg_view_get_message_is_empty() but this needs
508 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
509 Check if there is any text in the message yet.
510 But this needs to be implemented properly.
511 (modest_msg_edit_window_toggle_find_toolbar):
512 * src/maemo/modest-msg-view-window.c:
513 (modest_msg_view_window_toggle_find_toolbar):
514 Show a banner warning if there is no text to search, when
515 trying to start a search. This partially fixes
516 projects.maemo.org bug NB#62350.
518 2007-07-13 Murray Cumming <murrayc@murrayc.com>
520 * src/modest-mail-operation.c: (update_account_thread):
521 Initialized num_new_headers to fix the build.
523 2007-07-13 Murray Cumming <murrayc@murrayc.com>
525 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
526 Ignore modest accounts whose server accounts don't exist in gconf.
527 This prevents us trying to create TnyAccount instances for those
528 server accounts when the server account has been removed from gconf,
529 but the parent modest account has not yet been removed from modest.
530 I don't know why this is only noticeable now. It was probably just
531 a harmeless g_warning() anyway.
533 2007-07-13 Murray Cumming <murrayc@murrayc.com>
535 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
536 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
538 2007-07-12 Armin Burgmeier <armin@openismus.com>
540 * src/maemo/modest-main-window.c: Make default account appear bold
541 in view, tools/send & receive and toolbar/send & receive SCM menus.
542 This fixes projects.maemo.org bug NB#59010.
544 2007-07-12 Murray Cumming <murrayc@murrayc.com>
546 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
547 Add a short-cut, by checking if the folder store is an account.
548 This ensures that the Sort menu item and toolbar is dimmed for
549 the local-folders account root item, fixing
550 projects.maemo.org bug NB#62545.
552 2007-07-12 Murray Cumming <murrayc@murrayc.com>
554 * src/modest-tny-account-store.c: (get_password):
555 Show the password dialog (via the signal) only in the mainloop, via
556 an idle handler that we wait for. This could theoretically prevent
557 hangs, though I worry that it could introduce some too.
559 2007-07-12 Murray Cumming <murrayc@murrayc.com>
561 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
562 * src/maemo/modest-platform.c:
563 (modest_platform_connect_and_wait):
564 Take a TnyAccount* parameter and try to set it to online
565 (a TnyCamel-only API), because tinymail sets accounts to offline
566 when the user cancels a password dialog, and doesn't ask again until
567 it has been set to online.
568 However, this is commented out because it causes a hang now.
570 (modest_platform_connect_and_wait_if_network_account):
571 * src/modest-mail-operation.c:
572 (modest_mail_operation_update_account):
573 * src/modest-platform.h:
574 * src/modest-ui-actions.c: (_modest_ui_actions_open),
575 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
577 2007-07-12 Armin Burgmeier <armin@openismus.com>
579 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
581 * src/modest-mail-operation.c:
582 * src/modest-ui-actions.c: Check for already existing folder before
583 querying the server, show error message from camel if the request
584 still fails. This fixes projects.maemo.org bug NB#58701.
586 2007-07-12 Murray Cumming <murrayc@murrayc.com>
588 * src/modest-tny-account-store.h:
589 * src/modest-tny-account-store.c:
590 Added modest_tny_account_store_forget_password_in_memory(),
591 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
592 when creating a new account, so that new passwords will be used, instead of
593 us thinking that it's a second request as a result of a failed password again.
595 2007-07-12 Murray Cumming <murrayc@murrayc.com>
597 * src/dbus_api/modest-dbus-callbacks.c:
598 (on_idle_open_message): If the message is in drafts then open it
599 in an edit window instead of a view window. This fixes
600 projects.maemo.org bug NB#63005.
602 2007-07-12 Murray Cumming <murrayc@murrayc.com>
604 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
605 Avoided a harmless g_warning().
607 2007-07-12 Murray Cumming <murrayc@murrayc.com>
609 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
610 Pass the modest account name, not the TnyAccount display name to
611 modest_msg_view_window_new() so that the reply feature works,
612 fixing projects.maemo.org bug NB#62892.
614 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
615 (modest_msg_view_window_new_with_header_model):
616 * src/maemo/modest-msg-view-window.c:
617 (modest_msg_view_window_new_with_header_model),
618 (modest_msg_view_window_new):
619 * src/modest-ui-actions.c: (reply_forward):
620 * src/widgets/modest-msg-view-window.h:
621 * src/widgets/modest-window.c: (modest_window_set_active_account):
622 Rename an account parameter to modest_account_name to make this clearer.
624 2007-07-11 Murray Cumming <murrayc@murrayc.com>
626 * src/modest-ui-actions.h:
627 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
628 modest_do_message_delete().
629 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
630 Call modest_do_message_delete(), hoping that this would cause messages
631 to be really deleted from search instead of just marked with strike through.
632 Does not seem to help.
634 2007-07-11 Armin Burgmeier <armin@openismus.com>
636 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
637 priv->reselect to FALSE prior to calling
638 modest_folder_view_select_first_inbox_or_local() to prevent endless
639 recursion and thus a crash on startup.
641 2007-07-11 Armin Burgmeier <armin@openismus.com>
643 * src/maemo/modest-account-settings-dialog.h: Include
644 <gtk/gtknotebook.h> to fix the build (at least for me).
646 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
647 Use "New FolderN" as default suggested name if "New folder" already
648 exists, with N being the first free number, though never exceed "New
649 folder99" in which case we just fall back to "New Folder" even though
650 it already exists. This fixes projects.maemo.org bug NB#58663.
652 2007-07-11 Murray Cumming <murrayc@murrayc.com>
654 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
655 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
656 projects.maemo.org bug NB#62778.
658 2007-07-11 Murray Cumming <murrayc@murrayc.com>
660 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
661 Ignore the wrong (for now) secure-smtp setting in the presets -
662 just default to requiring secure authentication for SMTP, because
665 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
667 * src/widgets/modest-folder-view.c: (filter_row)
668 Do not show drafts folder (see UI specs)
670 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
672 * src/modest-ui-actions.c:
673 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
674 place and also not necessary.
676 * src/widgets/modest-folder-view.c: (filter_row)
677 Guess folder type and hide Sent & Outbox if necessary.
678 Fixed project.maemo.org NB#57328
680 2007-07-11 Murray Cumming <murrayc@murrayc.com>
682 * src/modest-ui-actions.h:
683 * src/modest-ui-actions.c:
684 (modest_ui_actions_on_delete_message):
685 Move some code into a new
686 modest_ui_actions_refresh_message_window_after_delete()
687 function so we can use it from elsewhere.
689 * src/dbus_api/modest-dbus-callbacks.c:
690 (on_idle_delete_message), (on_delete_message): Used an idle
691 handler, as we do for the other D-Bus method handlers.
692 Call modest_ui_actions_refresh_message_window_after_delete()
693 if the deleted message was open in a window. This fixed
694 projects.maemo.org bug NB#62862.
696 2007-07-11 Murray Cumming <murrayc@murrayc.com>
698 * src/modest-main.c: (main): Only show the UI at the start if
699 the showui command line option was given. For instance,
700 run-standalone src/modest showui
701 Otherwise, we wait for the top_application D-Bus method to
702 be sent by hildon-desktop when the application is selected
704 This allows us to run without a UI when osso-global-search
705 uses our D-Bus methods.
707 2007-07-11 Murray Cumming <murrayc@murrayc.com>
709 * src/dbus_api/modest-dbus-api.h: Added a define for a
710 top-application D-Bus method.
711 * src/dbus_api/modest-dbus-callbacks.c:
712 (on_top_application),
713 (modest_dbus_req_handler): Handle the top-application D-Bus
714 method, which might be an undocumented D-Bus signal sent by
715 hildon-desktop when it starts the application from the menu.
716 But I am not sure and I need to test it on the device, because
717 my scratchbox does not have the application in the menu now.
718 This method shows the main window, so that it can be invisible
719 when started, for instance, just for email searching from
722 * src/maemo/modest-main-window.c: (restore_settings),
723 (modest_main_window_new): Do not show the window immediately
724 upon creation. We show it later.
725 * src/modest-widget-memory.c: (save_settings_paned):
726 Try (unsuccessfully) to avoid saving the paned position when
727 it is not even visible.
728 (restore_settings_paned): Do not allow a silly paned position.
729 This seems necessary when not showing the window at first.
731 * tests/dbus_api/Makefile.am:
732 * tests/dbus_api/test_top_application.c: (main): Test for the
735 2007-07-10 Murray Cumming <murrayc@murrayc.com>
737 * src/modest-ui-dimming-rules.c:
738 (modest_ui_dimming_rules_on_new_msg),
739 (modest_ui_dimming_rules_on_reply_msg),
740 (modest_ui_dimming_rules_on_delete_msg),
741 (modest_ui_dimming_rules_on_details),
742 (modest_ui_dimming_rules_on_view_window_move_to),
743 (modest_ui_dimming_rules_on_view_previous),
744 (modest_ui_dimming_rules_on_view_next),
745 (_invalid_folder_for_purge): Added checks before
746 casting the window. This looks like an actual
747 logic error in _invalid_folder_for_purge(), because it
748 tries to use a ModestMainWindow as a message window.
750 2007-07-10 Murray Cumming <murrayc@murrayc.com>
752 * src/maemo/modest-account-settings-dialog.c:
753 (show_error): Use the same implementation as in
754 modest-easysetup-wizard.c:
755 (on_entry_invalid_character): The logical ID contains a %s.
756 Guessed what it should be.
757 (on_entry_max), (check_data), (on_response): Adapt to
758 changed show_error().
759 (create_page_account_details): Really call
760 modest_validating_entry_set_func() on the correct widgets.
761 * src/maemo/easysetup/modest-easysetup-wizard.c:
762 (on_entry_invalid_character): Fix the logical ID here too.
763 (create_page_account_details),
764 (create_page_user_details):
766 modest_validating_entry_set_func() on the correct widgets.
768 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
769 Do not try to use the account if it is NULL.
771 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
773 * src/modest-ui-actions.c: (create_move_to_dialog),
774 (modest_ui_actions_on_main_window_move_to),
775 (modest_ui_actions_on_msg_view_window_move_to):
776 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
777 (filter_row), (modest_folder_view_show_non_move_folders):
778 * src/widgets/modest-folder-view.h:
780 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
781 the Sent folder yet as it does not report the correct folder type.
783 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
785 * src/maemo/modest-msg-edit-window.c: (init_window):
788 2007-07-10 Murray Cumming <murrayc@murrayc.com>
790 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
791 Take a parent widget instead of a parent window, and
792 implement this with hildon_banner_show_information() instead.
793 Non-Maemo builds can just ifdef that there.
794 This fixed projects.maemo.org bug NB#62766.
796 (on_entry_invalid_character): Use show_error() again instead
797 of using hildon directly, and use the _CS() macro to use the correct
799 (create_account), (check_for_supported_auth_methods), (on_entry_max):
800 Pass a widget instead od a window to show_error().
802 2007-07-10 Murray Cumming <murrayc@murrayc.com>
804 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
805 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
806 This allows us to show the server name in the error message, fixing
807 projects.maemo.org bug NB#62904.
808 Also, use the appropriate logical ID message for the account protocol.
810 2007-07-10 Murray Cumming <murrayc@murrayc.com>
812 * src/modest-tny-account-store.c: (on_idle_wrong_password):
813 A compilation fix, though the build wasn't broken for me.
815 2007-07-09 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
818 Do not try to unref a NULL folder store, to avoid a runtime warning.
819 This seems to happen sometimes when changing accounts settings.
821 2007-07-09 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account-store.c:
824 (modest_tny_account_store_instance_init),
825 (modest_tny_account_store_finalize),
826 (on_account_settings_hide), (on_idle_wrong_password):
827 Use a GHashTable to ensure that we only show one account settings
828 dialog per modest account. This avoids us having a dialog open for
829 both the store and transport accounts, or due to repeated get_password()
830 calls that shouldn't happen anyway.
832 2007-07-09 Murray Cumming <murrayc@murrayc.com>
834 * src/maemo/modest-maemo-utils.c: (on_hide),
835 (modest_maemo_show_dialog_and_forget): Handle the response, because
836 the window is not even hidden by default.
838 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
839 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
840 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
841 which seems to prevent some modality problems.
843 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
844 Ignore user cancellation errors.
846 * src/modest-account-mgr-helpers.h:
847 * src/modest-account-mgr-helpers.c:
848 Added modest_server_account_get_password() and
849 modest_server_account_get_has_password() to avoid direct use of
852 * src/maemo/modest-account-settings-dialog.h:
853 * src/maemo/modest-account-settings-dialog.c:
854 (modest_account_settings_dialog_init): Store the notebook so we can
856 Added modest_account_settings_dialog_switch_to_user_info().
858 * src/modest-tny-account-store.c:
859 (get_password): When the password in the account settings is wrong (we think),
860 show the relevant page of the account settings dialog, in the mainloop.
861 However, we currently get many of these at once because cancel does not
863 (forget_password): Do not forget the password
864 from the account settings, because this causes side-effects when
865 tinymail seems to call it at strange time, maybe because of how we
866 are cancelling get_password().
867 (modest_tny_account_store_alert): Ignore user cancellations.
869 2007-07-09 Murray Cumming <murrayc@murrayc.com>
871 * src/maemo/modest-maemo-utils.h:
872 * src/maemo/modest-maemo-utils.c:
873 Added modest_maemo_show_information_note_and_forget() for use instead of
874 gtk_dialog_run() when the response is not needed, to avoid an extra
875 mainloop which could cause a hang.
877 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
878 Use the logical IDs for the error message, though they are not
879 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
880 because gtk_dialog_run() caused a hang here (the window did not close).
881 This fixes projects.maemo.org bug NB#62646.
883 2007-07-09 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-account-mgr-helpers.h:
886 * src/modest-account-mgr-helpers.c:
887 Added modest_account_mgr_get_store_protocol().
889 * src/maemo/modest-account-view-window.c:
890 (on_delete_button_clicked): Show different warning text depending on
891 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
892 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
895 2007-07-09 Murray Cumming <murrayc@murrayc.com>
897 * src/maemo/modest-msg-edit-window.c:
898 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
899 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
901 2007-07-07 Armin Burgmeier <armin@openismus.com>
903 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
904 ckdg_ib_maximum_characters_reached from correct package.
906 * src/modest-ui-actions.c: Show an error message when a folder could
907 not be created. Tinymail does not give us specific error codes about
908 what has gone wrong, so we assume that a folder with that name
909 already exists, though there might be other reasons.
911 2007-07-06 Murray Cumming <murrayc@murrayc.com>
913 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
914 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
915 give a more exact error message that can be partly translated.
917 2007-07-05 Murray Cumming <murrayc@murrayc.com>
919 * src/maemo/modest-address-book.c:
920 (select_email_addrs_for_contact): Specify a default window size for the
921 select-email-address dialog, so that it is probably big enough for the
922 title. This should fix projects.maemo.org bug NB#62277.
924 2007-07-05 Murray Cumming <murrayc@murrayc.com>
926 * src/maemo/easysetup/modest-easysetup-wizard.c:
927 (create_page_complete_easysetup): Use
928 gtk_widget_set_size() request to ensure that the text wraps
931 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
933 * src/maemo/easysetup/modest-easysetup-wizard.c:
934 (on_entry_invalid_character), (create_page_account_details),
935 (create_page_user_details):
936 Use new API of ModestValidatingEntry. But for some reason the banner is
937 not shown. I will have to investigate that further.
939 * src/widgets/modest-validating-entry.c: (on_insert_text),
940 (modest_validating_entry_set_func):
941 * src/widgets/modest-validating-entry.h:
942 Added a new callback function to be able to react to prevented
943 characters whitespaces to e.g show a banner.
945 2007-07-05 Armin Burgmeier <armin@openismus.com>
947 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
948 notification of HildonNumberEditor instead of remembering the port
949 number. Thanks to Johannes for pointing this out.
951 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
953 * src/maemo/easysetup/modest-easysetup-wizard.c:
954 Check if there are any user changes before showing a confirmation
955 dialog (projects.maemo.org NB#60946)
957 2007-07-05 Armin Burgmeier <armin@openismus.com>
959 * src/maemo/modest-account-settings-dialog.c: Remember custom port
960 number at the beginning of the dialog and set the modified flag at the
961 end if the port number has changed. This is necessary because
962 HildonNumberEditor does not support notification when the value has
965 2007-07-05 Murray Cumming <murrayc@murrayc.com>
967 * src/modest-ui-actions.c:
968 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
969 a connection before asking anything else. Correct the check for the destination
970 folder so that it succeeds when online.
971 This fixed projects.maemo.org bug NB#61645.
973 2007-07-05 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
976 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
977 to fix projects.maemo.org bug NB#62439.
979 2007-07-05 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-tny-account.c: (on_connection_status_changed):
982 Really do not use tny_device_force_offline() here. See the previous comment.
984 2007-07-04 Murray Cumming <murrayc@murrayc.com>
986 * src/modest-tny-account.c: (on_connection_status_changed):
987 Do not use tny_device_force_offline() when tinymail says that something
988 went wrong with the connection. It seems to report this unnecessarily.
990 2007-07-04 Murray Cumming <murrayc@murrayc.com>
992 * src/maemo/modest-connection-specific-smtp-window.c:
993 (modest_connection_specific_smtp_window_init):
994 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
995 does not seem to have any effect in osso 1.1 (though it works in
996 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
998 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1000 * src/maemo/modest-connection-specific-smtp-window.c:
1001 Fix UI specification problems with projects.meamo.org NB#60479
1003 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1005 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1006 clue when this has failed, because the error dialog is not always shown
1007 (at least in earlier version).
1009 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1010 GError message, because the generic error dialog is not helpful.
1012 'This message is not currently available (can't let a new connection go online)'
1013 when trying to open an IMAP message.
1015 (_modest_ui_actions_open): Offer a connection when some messages would
1016 have to be downloaded and we are offline.
1018 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1020 * src/widgets/modest-folder-view.c:
1021 Don't check for MERGE type anymore as we use the correct type
1023 NOTE: For the last two changes you need to update your tinymail copy
1024 because of API changes!
1026 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1028 * src/modest-tny-local-folders-account.c:
1029 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1030 (see projects.maemo.org NB#61580)
1032 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1034 * src/modest-tny-account.c: (on_connection_status_changed):
1035 Commented out the call to modest_platform_connect_and_wait() because this
1036 seems to always hang, and I would like to know if this is the only thing
1037 that causes a hang when showing the connection dialog.
1038 It is not very useful anyway.
1040 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1042 * src/maemo/modest-msg-view-window.c:
1043 (modest_msg_view_window_select_next_message):
1045 * src/modest-platform.h:
1046 * src/maemo/modest-platform.c:
1047 Added modest_platform_connect_and_wait(), which calls
1048 tny_maemo_conic_device_connect() always in the main thread, by calling it
1049 in an idle handler and waiting for the idle handler to run. It should be
1050 in the main thread because it uses GTK+ UI code. It just returns TRUE
1051 if the device is already online.
1053 There is some nasty code to ensure that subsequent calls to
1054 modest_platform_connect_and_wait() just wait for the first one to finish,
1055 by checking repeatedly in another idle handler. This is necessary,
1056 because other threads (or even the main thread, via another idle handler)
1057 can call modest_platform_connect_and_wait() while
1058 modest_platform_connect_and_wait() is running.
1060 (modest_platform_connect_and_wait_if_network_account),
1061 (modest_platform_connect_and_wait_if_network_folderstore):
1062 Convenience functions that calls modest_platform_connect_and_wait() if
1063 the account or folder might want network access.
1065 * src/modest-mail-operation.c:
1066 (modest_mail_operation_update_account):
1067 * src/modest-ui-actions.c: (download_uncached_messages),
1068 (modest_ui_actions_on_rename_folder), (delete_folder),
1069 (modest_ui_actions_on_main_window_move_to),
1070 (modest_ui_actions_on_msg_view_window_move_to):
1071 * src/widgets/modest-folder-view.c:
1072 (drag_and_drop_from_folder_view):
1073 Offer a connection if we are offline.
1075 * src/modest-tny-account.c: (on_connection_status_changed):
1076 Document this as only handling errors during network operations in progress,
1077 and replace the idle code with a simple call to
1078 modest_platform_connect_and_wait(), which does this instead.
1080 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1082 * src/modest-tny-account.c:
1083 (modest_tny_account_get_special_folder): (util_on_idle),
1084 Handle the GError so we can see when tny_folder_store_get_folders()
1085 fails, as it currently does while something else is connecting.
1087 Added util_run_in_main_thread_and_wait()
1088 which uses an idlen handler and mainloop to ensure that the function
1089 is called in the main thread.
1090 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1091 to make sure that we call attempt the connection in the mainloop only,
1092 which might solve some hangs.
1094 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1096 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1097 be found by their display name. This is never useful.
1098 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1099 by its ID, instead of trying to use its ID as its display name.
1101 * src/modest-tny-account-store.h:
1102 * src/modest-tny-account.c:
1103 (modest_tny_account_get_special_folder): Add a g_warning() when
1104 tny_folder_store_get_folders() returns an empty list for the maildir.
1106 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1107 Add a g_warning() when this returns NULL, because that it not allowed
1110 2007-07-02 Armin Burgmeier <armin@openismus.com>
1112 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1113 note when trying to cancel the wizard. This fixes projects.maemo.org
1116 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1118 * src/modest-tny-account.h:
1119 * src/modest-tny-account.c:
1120 (modest_tny_account_new_from_server_account),
1121 (modest_tny_account_new_from_server_account_name),
1122 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1123 because this must now be set before setting the proto. This is usd in
1124 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1125 warning in camel_session_get_service() caused by
1126 tny_camel_transport_account_prepare().
1128 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1131 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1133 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1135 (modest_connection_specific_smtp_edit_window_init):
1137 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1138 of "changed" for now
1140 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1142 * src/modest-tny-account.c:
1143 (modest_tny_account_new_from_server_account):
1144 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1145 now uses to request a connection when it needs one, and which it uses
1146 to tell us that something is wrong with the connection, so we can force
1147 the accounts offline to prevent further problems.
1149 * src/modest-defs.h:
1150 * src/modest-init.c: (init_default_settings):
1151 * src/modest-mail-operation.c:
1152 (modest_mail_operation_update_account):
1153 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1154 This should not be necessary anymore. Do not set the conf key that
1155 determined this (it was always TRUE and not set anywhere else).
1157 * src/modest-ui-actions.h: Remove unused and unimplemented
1158 modest_ui_actions_on_online_toggle_toggled().
1160 2007-06-29 Murray Cumming <murrayc@murrayc.com
1162 * src/maemo/modest-main-window.c: (connect_signals):
1163 Don't connect to delete_event twice. Maybe this was harmless.
1165 2007-06-29 Murray Cumming <murrayc@murrayc.com
1167 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1168 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1169 Debug output to give some more clue when a folder move is not allowed.
1171 2007-06-28 Murray Cumming <murrayc@murrayc.com
1173 * src/modest-tny-account.c: (on_modest_file_system_info),
1174 (modest_tny_account_get_mmc_account_name):
1175 Always call the callback, without checking whether the name has changed.
1176 * src/widgets/modest-folder-view.c: (strings_are_equal),
1177 (on_model_foreach_set_name), (on_get_mmc_account_name),
1178 (text_cell_data): Compare the name here, and use the name from
1179 the account rather than from the
1180 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1181 if the name was changed after the account was added to the model.
1182 That's a tinymail bug but not one that I want to fix now.
1184 This finally fixes projects.maemo.org bug NB#59301.
1186 2007-06-27 Armin Burgmeier <armin@openismus.com>
1188 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1191 2007-06-27 Murray Cumming <murrayc@murrayc.com
1193 * src/modest-tny-account.h:
1194 * src/modest-tny-account.c:
1195 Added modest_tny_account_get_mmc_account_name(), to set the memory
1196 card name asynchronously for the given account and then notify.
1197 (modest_tny_account_new_for_local_folders): Use this new function instead
1198 of using hildon_file_system_info_async_new() directly.
1200 * src/widgets/modest-folder-view.c: (text_cell_data):
1201 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1202 gtk_tree_model_row_changed() when it is available.
1204 This should fix projects.maemo.org bug NB#59301.
1206 2007-06-27 Murray Cumming <murrayc@murrayc.com
1208 * src/modest-mail-operation.c: (update_account_thread),
1209 (get_msgs_full_thread): Fix typo failures in the revert
1212 2007-06-27 Murray Cumming <murrayc@murrayc.com
1214 * src/maemo/modest-maemo-global-settings-dialog.c:
1215 (idle_select_default_focus):
1216 * src/modest-mail-operation.c: (idle_notify_progress),
1217 (idle_notify_progress_once), (set_last_updated_idle),
1218 (update_account_thread), (get_msgs_full_thread):
1219 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1220 * src/widgets/modest-header-view.c:
1221 (idle_notify_headers_count_changed_destroy),
1222 (idle_notify_headers_count_changed):
1223 Reverted the additions of gdk_threads_enter/leave(), in case this
1224 helps with a startup hang on the device.
1226 2007-06-26 Armin Burgmeier <armin@openismus.com>
1228 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1229 for supported secure authentication methods from server by
1230 gtk_dialog_run(), saving CPU time and a potential race condition.
1232 2007-06-26 Armin Burgmeier <armin@openismus.com>
1234 * src/maemo/modest-maemo-utils.h:
1235 * src/maemo/modest-maemo-utils.c: Added a
1236 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1237 only error code to tell the calling code when the user canceled the
1240 * src/maemo/modest-account-settings-dialog.h:
1241 * src/maemo/modest-account-settings-dialog.c:
1242 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1243 message if the retrieval of secure authentication methods was canceled
1244 by the user. Perform the check before saving anything to configuration
1245 to not end up with half-committed configuration changes, do not show
1246 a "Saving to configuration failed" note when authentication methods
1247 could not be retrieved.
1249 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1252 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1254 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1255 Only return the first level of folders under accounts, because the
1256 osso-global-search UI spec doesn't want the rest.
1257 This fixed projects.maemo.org bug NB#61811.
1259 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1261 * src/modest-tny-account-store.c:
1262 * src/modest-tny-account-store.h:
1263 Added modest_tny_account_is_memory_card_account().
1264 * src/maemo/modest-main-window.c: (create_details_widget):
1265 Show the same information items for the memory card as we show for the
1266 local-folders, to fix projects.maemo.org bug NB#59307.
1268 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1270 * src/modest-tny-account-store.c: (get_password):
1271 Added some checks for NULL to maybe prevent crashes, though I think
1272 it was Philip's last commit that actually prevented the crash here
1273 when creating a first new account.
1274 But the new account is still not usable (no messages are shown)
1275 until a restart of the application.
1277 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1279 * src/maemo/modest-maemo-global-settings-dialog.c:
1280 (idle_select_default_focus):
1281 * src/modest-mail-operation.c: (idle_notify_progress),
1282 (idle_notify_progress_once), (idle_notify_update_account_queue),
1283 (set_last_updated_idle), (update_account_thread),
1284 (notify_get_msgs_full), (get_msgs_full_destroyer),
1285 (get_msgs_full_thread):
1286 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1287 * src/widgets/modest-header-view.c:
1288 (idle_notify_headers_count_changed_destroy),
1289 (idle_notify_headers_count_changed):
1290 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1291 all idle handlers, because some other thread could be blocking
1292 the GDK lock, so that it can do GUI stuff.
1294 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1296 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1297 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1298 (on_idle_send_receive), (on_idle_open_default_inbox):
1299 * src/maemo/modest-msg-edit-window.c:
1300 (modest_msg_edit_window_attach_file_noninteractive):
1301 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1302 to prevent a hang. I don't quite understand why these are necessary,
1303 beause we should already be in the main loop. I guess something outside
1304 of the main loop is taking the lock.
1306 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1307 we are really using URIs, and use files that are more likely to exist.
1309 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1311 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1312 necessary because configure.ac now defines different variables.
1314 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1316 * libmodest-dbus-client/libmodest-dbus-client.c:
1317 * libmodest-dbus-client/libmodest-dbus-client.h:
1318 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1319 libmodest_dbus_client_compose_mail() is what things actually use.
1321 * src/dbus_api/modest-dbus-api.h:
1322 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1323 * tests/dbus_api/Makefile.am:
1324 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1327 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1329 * src/modest-init.c: (modest_init_local_folders):
1330 For memory-card (or other non local-folders) maildir accounts,
1331 always create an Archive folder, so that there is somewhere to put
1332 messages. This should be less confusing, because the user does not need
1333 to guess that the need to create a folder.
1335 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1337 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1338 Fixed icon size by using (50, 50) which is the same as defined by
1341 2007-06-25 Armin Burgmeier <armin@openismus.com>
1343 * src/widgets/modest-window-mgr.c:
1344 * src/modest-init.c:
1345 * configure.ac: Correctly recognize hildon-notify presence and fixed
1346 the build without it being installed.
1348 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1350 * libmodest-dbus-client/libmodest-dbus-client.c:
1351 (libmodest_dbus_client_search): Fix the build. Sorry.
1352 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1353 (reply_forward_cb): Initialize variables to fix the build.
1355 * src/modest-tny-account-store.c:
1356 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1357 comparison (a silly typo) so that email search results can be opened
1358 when there are more than one account.
1360 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1362 * libmodest-dbus-client/libmodest-dbus-client.c:
1363 (libmodest_dbus_client_search),
1364 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1365 instead of 1 second, because the search gets folders and messages from
1366 the server, which can take a long time. When it times out,
1367 osso-global-search will report no results.
1369 We need to specify whether we should search only cached information
1370 (maybe with a user preference), and the osso-email-search-plugin
1371 API should really be improved to allow that option, and to allow results
1372 to be delivered asynchronously in batches.
1374 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1377 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1378 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1380 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1382 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1383 that is an empty string. D-Bus seems to give us these instead of NULL.
1385 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1387 * src/dbus_api/modest-dbus-callbacks.c:
1388 * src/maemo/easysetup/modest-easysetup-wizard.h:
1389 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1390 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1391 (modest_connection_specific_smtp_edit_window_init):
1392 * src/maemo/modest-maemo-global-settings-dialog.c:
1394 * src/maemo/modest-maemo-utils.c:
1395 (modest_maemo_utils_setup_images_filechooser):
1396 * src/maemo/modest-main-window.c: (create_details_widget):
1397 * src/maemo/modest-msg-edit-window.c:
1398 (modest_msg_edit_window_attach_file_noninteractive),
1399 (modest_msg_edit_window_color_button_change),
1400 (modest_msg_edit_window_set_zoom):
1401 * src/modest-mail-operation.c: (update_account_thread):
1402 * src/modest-tny-account-store.c:
1403 * src/modest-tny-account.c:
1404 * src/widgets/modest-global-settings-dialog.c:
1405 * src/widgets/modest-window.h:
1407 Fixed build on bora!
1409 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1411 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1412 * src/modest-search.c: (modest_search_folder),
1413 (modest_search_all_accounts): Actually search only in the specified folder,
1414 doing a simple match on the folder ID.
1415 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1416 and added some documentation.
1418 2007-06-22 Armin Burgmeier <armin@openismus.com>
1420 * src/maemo/modest-maemo-utils.h:
1421 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1422 modest_maemo_utils_get_supported_secure_authentication_methods.
1424 * src/maemo/easysetup/modest-easysetup-wizard.c:
1425 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1426 one occured, not just "Server does not support secure authentication".
1428 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1430 * src/modest-tny-account-store.c: (get_password):
1431 Restored the call to tny_account_set_user() because Philip seems to have
1432 stopped this from crashing (by not using the freed string). It still does
1433 not work, but now we can test it.
1435 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1437 * src/maemo/modest-msg-edit-window.c: (init_window):
1438 Comment out use of an uninitialzed GtkScrolledWindow variable,
1439 to fix the build and stop a crash. Yet again.
1441 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1443 * src/modest-tny-account-store.c: (get_password):
1444 Remove the call to tny_account_set_user() because this actually crashes.
1445 As mentioned in the last commit, it is known to not work anyway.
1447 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1449 * src/modest-tny-account-store.c: (get_password):
1450 Use tny_account_set_username() to tell tinymail that the username might
1451 have changed too. But tinymail ignores this: see projects.maemo.org
1453 * src/modest-ui-actions.c:
1454 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1455 reset the connection when changing the username, and improve the comments.
1456 Save the changed username to gconf at least, so it is used when Modest is
1459 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1461 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1462 Do not use a query, so that we get all folders, including for POP and
1463 local-folders. They work as search criteria too.
1464 This fixes projects.maemo.org bug NB#57740.
1466 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1468 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1469 Comment out the use of hildon_notification_set_sound() because it is
1470 not declared, to fix the build. Warnings are serious, people.
1472 2007-06-21 Armin Burgmeier <armin@openismus.com>
1474 * src/maemo/modest-maemo-utils.h:
1475 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1476 modest_maemo_utils_get_supported_secure_authentication_methods()
1477 to query authentication methods for a specific user. This should fix
1478 projects.maemo.org bug NB#61369.
1480 * src/maemo/easysetup/modest-easysetup-wizard.c:
1481 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1484 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1486 * libmodest-dbus-client/libmodest-dbus-client.h:
1487 * libmodest-dbus-client/libmodest-dbus-client.c:
1488 (modest_dbus_message_iter_get_search_hit),
1489 (libmodest_dbus_client_search):
1490 Reorganised and commented this.
1491 Removed modest_search_hit_free() from the public API because it
1494 Added libmodest_dbus_client_get_folders() and
1495 modest_folder_result_list_free().
1497 * src/dbus_api/modest-dbus-api.h:
1498 * src/dbus_api/modest-dbus-callbacks.c:
1499 (modest_dbus_req_filter): Commented. Moved most code to
1500 on_dbus_method_search() and added on_dbus_method_get_folders().
1502 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1503 of the extra D-Bus handler.
1505 * tests/dbus_api/Makefile.am:
1506 * tests/dbus_api/test_get_folders.c: New test for
1507 libmodest_dbus_client_get_folders(). This seems to return an empty list
1508 at the moment. That could be the same error that causes the message list
1509 to be empty sometimes.
1510 This should help with projects.maemo.org bug NB#57740.
1512 2007-06-21 Armin Burgmeier <armin@openismus.com>
1514 * src/modest-mail-operation.c: Do not call
1515 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1516 notify the operation's end after having set the status to CANCELED for
1517 the operation queue to listen on. This fixes a deadlock when there
1518 were mail operations in the queue during its finalization.
1520 * src/modest-singletons.c: Reordered uninitialization of the account
1521 manager to happen after the mail operation queue was uninitialized
1522 because the mail operation's in the queue might still try to access
1523 the account manager (see modest_mail_operation_notify_end()). This
1524 fixes a potential crash when terminating the application.
1526 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1528 * src/modest-search.c:
1529 (search_mime_part_and_child_parts): Moved some code here so we
1530 can search recursively in child folders.
1531 (modest_search_folder): Search in the message as a mime part, instead
1532 of just its child mime parts.
1533 (read_chunk), (search_mime_part_ogs):
1534 Check how many bytes were read, to prevent an endless loop.
1535 Searching in message bodies now works. This finishes the fix for
1536 projects.maemo.org bug NB#61007.
1538 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1540 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1541 Add a g_warning when the item is not a folder.
1543 * src/modest-ui-dimming-rules.c:
1544 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1545 when selected item is not a folder (for instance, an account), because
1546 the UI spec only talks about folders.
1547 I am not sure what the UI spec wants, so this might not totally fix
1548 projects.maemo.org bug NB#60794.
1550 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1553 (load_from_file): Sort the list. The unsorted list would be more noticeable
1554 in non-English locales.
1556 * src/maemo/modest-msg-edit-window.c:
1557 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1558 warning and fix the build.
1560 * src/maemo/modest-progress-bar-widget.c:
1561 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1562 avoid a g_warning, and probably to avoid a crash.
1564 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1566 * src/modest-search.c: (modest_search_folder): Check for a GError
1567 when calling tny_folder_get_headers(), to show that this is not the cause
1570 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1572 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1573 Actually set the body query instead of the subject query.
1575 * src/modest-search.c: (search_mime_part_ogs),
1576 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1577 which would probably cause it to fail if we got this far.
1579 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1580 to simplify the code.
1581 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1582 be causing search-in-body to fail.
1584 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1586 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1588 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1589 Better debug message when the folder cannot be found.
1590 This should help with fixing projects.maemo.org bug #61287.
1591 * src/modest-search.c: (add_hit): Do not leak the furl string.
1593 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1595 * src/modest-ui-actions.c:
1596 (modest_ui_actions_on_folder_selection_changed):
1597 Do not special-case TNY_MERGE_FOLDER here, because
1598 modest_tny_folder_get_account() already does that. This fixes
1599 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1600 shown when the Outbox was selected).
1602 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1604 * libmodest-dbus-client/libmodest-dbus-client.c:
1605 (_dbus_iter_get_string_or_null): Initialize the string variable in
1606 case this helps with Dirk's crash.
1608 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1610 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1611 though it is not implemented yet (this function is maybe not even used),
1612 to avoid breaking ABI in future.
1613 * libmodest-dbus-client/libmodest-dbus-client.c:
1614 (get_attachments_string): Moved some code into this generic function.
1615 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1616 sends email. It is maybe not used.
1617 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1618 (on_send_mail): Use attachments.
1620 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1621 * src/maemo/modest-msg-edit-window.c:
1622 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1623 a filename before using it, to fix projects.maemo.org bug NB#58233.
1625 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1627 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1628 Initialize the continue_download variable to fix the build, and probably
1629 to fix randome behaviour.
1631 2007-06-18 Armin Burgmeier <armin@openismus.com>
1633 * src/modest-tny-send-queue.h:
1634 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1635 the queue so we can later show it in the UI. Replaced
1636 modest_tny_send_queue_msg_is_being_sent() by
1637 modest_tny_send_queue_get_msg_status().
1639 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1641 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1642 gpointer. This probably was not harmful, but just to be sure.
1644 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1646 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1647 Fix the build, but leave the function broken on Bora, because
1648 hildon_uri_action_get_service() does not exist.
1649 osso_uri_action_get_service() does not exist either, it seems.
1651 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1653 * src/modest-tny-account.c:
1654 (modest_tny_account_new_from_server_account):
1655 Uncommented the url debug output again, because it is useful for
1656 debugging, as I said in the comment.
1658 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1660 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1662 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1663 for Mameo Bora, to fix the build.
1665 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1668 Fixed build with hildon < 0.99
1670 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1671 Check if the selected account is busy instead of checking all accounts
1673 * src/modest-account-mgr-priv.h:
1674 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1675 (modest_account_mgr_init), (compare_account_name),
1676 (modest_account_mgr_set_account_busy),
1677 (modest_account_mgr_account_is_busy):
1678 * src/modest-account-mgr.h:
1679 Added busy information to the account manager. It possible to
1680 set an account to busy or not busy now.
1682 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1683 (modest_mail_operation_update_account),
1684 (modest_mail_operation_notify_end):
1685 Set the account to busy/not busy depending on the operation state.
1687 * src/widgets/modest-account-view.c:
1688 (modest_account_view_finalize), (get_last_updated_string),
1689 (update_account_view), (on_account_busy_changed), (init_view):
1690 Show string "Refreshing..." if the account is currently busy.
1692 All this fixes projects.maemo.org bug NB#59711
1694 2007-06-14 Armin Burgmeier <armin@openismus.com>
1696 * src/widgets/modest-attachments-view.h:
1697 * src/widgets/modest-attachments-view.c: Added
1698 modest_attachments_view_has_attachments() and fixed coordinate
1699 transformation in get_att_view_at_coords(). This fixes attachment
1702 * src/widgets/modest-msg-view.c: Make use of
1703 modest_attachments_view_has_attachments() to decide whether to show
1704 attachments in the header.
1706 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1708 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1709 (on_change), (on_combo_security_changed),
1710 (modest_connection_specific_smtp_edit_window_init),
1711 (modest_connection_specific_smtp_edit_window_set_connection),
1712 (modest_connection_specific_smtp_edit_window_is_dirty):
1713 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1714 * src/maemo/modest-connection-specific-smtp-window.c:
1717 Show an comfirmation dialog for the smpt-edit-window if there are
1718 unsaved changes and the user hits cancel.
1719 (projects.maemo.org bug NB#60479)
1721 2007-06-14 Armin Burgmeier <armin@openismus.com>
1723 * src/maemo/easysetup/modest-easysetup-wizard.c:
1724 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1725 address" info in banner instead of node, and select all the text as
1726 per UI spec. This fixes projects.maemo.org bug NB#60550.
1728 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1730 reviewed by: <delete if not using a buddy>
1732 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1733 * src/modest-ui-actions.c: (folder_refreshed_cb):
1735 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1737 * src/widgets/modest-folder-view.c: (filter_row):
1738 Explictly filter out the per-account outbox accounts. I don't know why
1739 these only sometimes show up, but now they should never show up in the UI.
1740 This should fix projects.maemo.org bug NB#60160.
1742 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1745 when the toolbar does not exist yet.
1746 * src/modest-widget-memory.c: (save_settings_header_view):
1747 Added g_warnings() to help us to discover when we are trying to set
1748 an empty columns list in gconf.
1750 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1752 * src/modest-init.h:
1753 * src/modest-init.c:
1754 Added modest_init_get_default_header_view_column_ids().
1756 * src/modest-widget-memory.c: (restore_settings_header_view):
1757 Use the new function to get defaults, if the gconf key is empty,
1758 instead of not creating any columns. This seems to fix the
1759 empty right-hand pane problems.
1761 * src/widgets/modest-header-view.h: Improved documentation.
1763 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1765 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1766 Revert the use of the display name as the account name, because this
1767 is generally wrong and would break the code that follows.
1769 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1771 * src/maemo/easysetup/modest-easysetup-wizard.c:
1772 (check_for_supported_auth_methods), (on_before_next),
1775 More correct fix for projects.maemo.org bug NB# 58991
1776 Do not longer accept AUTH_PASSWORD as secure method and choose
1777 correct method when creating the account.
1779 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1781 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1782 Fixed projects.maemo.org bug NB# 58991
1784 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1786 * src/modest-init.c: (modest_init_init_core),
1787 (modest_init_local_folders): Fixed compilation errors.
1789 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1791 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1792 Remove unnecessary lib/include, though it is good in principle when needed.
1794 * src/modest-init.c: (modest_init_one_local_folder),
1795 (modest_init_local_folders):
1796 * src/modest-init.h: Initialize the .modest library for memory cards,
1797 instead of just doing nothing for them. This should allow us to create
1798 folders there, fixing projects.maemo.org bug NB#59297.
1800 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1802 * libmodest-dbus-client/libmodest-dbus-client.c:
1803 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1804 (libmodest_dbus_client_compose_mail),
1805 (libmodest_dbus_client_open_message),
1806 (libmodest_dbus_client_send_and_receive),
1807 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1809 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1810 (on_idle_open_message), (modest_dbus_req_handler),
1811 (search_result_to_message), (modest_dbus_req_filter):
1812 * src/modest-search.c: (add_hit), (modest_search_folder),
1813 (modest_search_all_accounts): Improved debug messages.
1815 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1817 * src/modest-tny-account-store.c:
1818 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1821 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1824 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1826 * src/modest-tny-account-store.c: (get_server_accounts):
1827 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1828 even when there are no accounts, so that the Outbox folder is always
1829 visible. This fixes projects.maemo.org bug NB#60158.
1831 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1833 * src/maemo/modest-main-window.c: (create_details_widget):
1834 Use the mcen_va_never logical ID.
1836 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1838 * src/dbus_api/modest-dbus-api.h:
1839 * src/dbus_api/modest-dbus-callbacks.c:
1840 (on_idle_open_default_inbox), (on_open_default_inbox),
1841 (modest_dbus_req_handler):
1842 Added a new OpenDefaultInbox method.
1844 * libmodest-dbus-client/libmodest-dbus-client.h:
1845 * libmodest-dbus-client/libmodest-dbus-client.c:
1846 Added libmodest_dbus_client_open_default_inbox() to call the new
1847 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1848 though it should maybe be used by a new osso-email-interface function.
1850 * tests/dbus_api/Makefile.am:
1851 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1854 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1856 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1857 NULL, so that the signals get all the keys. This should not actually
1858 change any behaviour because we currently update everything when anything
1861 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1863 * src/widgets/modest-folder-view.c: (text_cell_data),
1864 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1865 (find_inbox_iter): If tinymail tells us that the folder is
1866 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1867 This causes the inbox to be selected at startup, fixing part of
1868 projects.maemo.org bug NB#56305.
1870 * src/modest-ui-dimming-rules.c:
1871 (modest_ui_dimming_rules_on_tools_smtp_servers):
1872 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1873 the SMTP servers menu item.
1874 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1875 that the SMTP Servers menu item is dimmed when there are no accounts,
1876 as a future version of the UI spec will require. This fixes
1877 projects.maemo.org bug NB#56305.
1879 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1881 * src/maemo/modest-maemo-utils.c:
1882 (modest_maemo_utils_get_supported_secure_authentication_methods):
1883 Added label to dialog instead of unreadable title
1885 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1886 (modest_main_window_new):
1887 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1890 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1891 * src/modest-account-mgr.h:
1892 Added method to avoid code duplication
1894 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1895 (modest_ui_actions_on_send_receive):
1896 Use modest_account_mgr_has_accounts
1898 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1900 * src/maemo/easysetup/modest-presets.c:
1901 (modest_presets_get_info_server_security): Do not report secure auth
1903 * src/modest-protocol-info.c: Use the defines for the gconf key names
1904 for secure authentication. This was not working because we were writing
1905 Password and reading password, and the check was case sensitive.
1906 With this, gmail now works for receiving and sending when created via
1909 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1911 * src/maemo/easysetup/modest-presets.c:
1912 (modest_presets_get_info_server_security): Correct the key name for
1913 SecureSmtp, because it seems to be case-sensitive.
1914 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1915 Do not try to get the 0th notebook page if there are 0 pages, to
1916 avoid a g_warning().
1918 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1920 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1921 Prevent use of the new notification feature for now, because it currently
1922 shows one dialog for each new email, which is annoying.
1924 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1927 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1928 when no country was selected, so that we show the global ones.
1929 * src/maemo/easysetup/modest-presets.c:
1930 (modest_presets_get_providers): Return only the global providers, not
1931 all providers when mmc=0 was requested.
1933 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1935 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1936 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1937 provider ID in the combo.
1939 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1940 Do not show the page numbers, because it would be confusing when we add
1941 the 2 extra pages for the custom setup, when the user chooses the "Other"
1942 provider. This fixes projects.maemo.org bug NB#59028
1944 * src/modest-init.c: (modest_init_init_core),
1945 (modest_init_local_folders):
1946 * src/modest-init.h:
1947 * src/modest-tny-account.c:
1948 (modest_tny_account_new_for_local_folders): Do not create default folders
1949 for the memory card. This should fix projects.maemo.org bug NB#59328.
1951 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1953 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1954 Free the changed_conf_keys string items. They are already freed in the
1955 idle handler if that runs first.
1957 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1959 * src/modest-ui-actions.c:
1960 (modest_ui_actions_on_password_requested): Check that the server name
1961 is not NULL, because I just saw a password dialog with (null) as the
1964 * src/modest-tny-folder.[h|c]: Added
1965 modest_tny_folder_is_memory_card_folder().
1966 * src/modest-ui-dimming-rules.c:
1967 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1968 menu item for memory cards, as per the UI spec (section 7.4). This should
1969 fix projects.maemo.org bug NB#59297.
1971 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1973 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1974 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1975 is another problem with the code, see Murray's comment at line 772)
1977 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1979 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1980 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1981 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1982 (load_from_file), (easysetup_country_combo_box_init),
1983 (easysetup_country_combo_box_get_active_country_ids),
1984 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1985 instead of just one ID, to avoid duplicate country names in the UI.
1987 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1988 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1989 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1990 a single ID, avoiding duplicate providers.
1991 * src/maemo/easysetup/modest-easysetup-wizard.c:
1992 (on_combo_account_country): Adapt to use a list.
1994 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1996 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1997 keys changed in the last X seconds.
1999 * src/modest-account-mgr.h:
2000 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2001 (on_key_change), (modest_account_mgr_class_init),
2002 (modest_account_mgr_init), (modest_account_mgr_finalize):
2003 As the keys are changed, save them in a GSList* and signal that GSList*
2004 further every X seconds, to batch changes, to allow us to do just one
2005 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2006 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2008 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2009 changed signal signature.
2011 * src/modest-conf.c: (modest_conf_set_list),
2012 (modest_conf_on_change): Reenable notification.
2014 (modest_conf_maemo_fake_on_change): Comment out the hack that
2015 notified immediately instead of asynchronously.
2017 * src/widgets/modest-account-view.h:
2018 * src/widgets/modest-account-view.c:
2019 (update_account_view): Select the previously-selected account ID,
2020 if possible. This fixes projects.maemo.org bug NB#56933.
2022 (on_account_changed), (on_account_removed),
2023 (modest_account_view_select_account):
2025 Remove the block/unblock functions
2026 because they were not useful.
2028 * src/maemo/modest-account-view-window.c:
2029 (on_delete_button_clicked), (on_edit_button_clicked),
2030 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2032 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2034 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2035 Improve the error dialog to show Incorrect Account Settings, which seems
2036 clearer, and say that the internal error message (to be removed from the
2037 dialog later) is often misleading.
2038 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2040 * src/modest-tny-account.c:
2041 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2042 URL because this is so useful for debugging on the device.
2044 * src/widgets/modest-serversecurity-combo-box.c:
2045 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2047 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2049 * src/modest-mail-operation.c:
2050 (modest_mail_operation_send_new_mail):
2051 Added a comment about a nasty but apparently harmless message. Details
2052 added to the wiki g_warnings() page.
2054 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2056 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2057 (modest_tny_send_queue_class_init):
2058 Do not use the priv struct because it is empty, to avoid g_warnings
2059 about a non-existant priv struct.
2061 * src/modest-tny-account-store.c:
2062 (modest_tny_account_store_get_server_account),
2063 (modest_tny_account_store_get_transport_account_for_open_connection
2064 ): Do not try to get transport server accounts for local folders,
2065 because they don't have any. This avoids a g_warning().
2067 * src/maemo/modest-main-window.c:
2068 (modest_main_window_notify_send_receive_initied),
2069 (on_configuration_key_changed):
2070 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2071 * src/modest-defs.h:
2072 * src/modest-mail-operation.c:
2073 (modest_mail_operation_update_account):
2074 * src/modest-tny-account-store.h:
2075 * src/modest-tny-account.c:
2076 (modest_tny_account_get_special_folder),
2077 (modest_tny_account_new_for_local_folders),
2078 (modest_tny_account_new_for_per_account_local_outbox_folder):
2079 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2080 * src/modest-tny-local-folders-account.c:
2081 (add_account_folders_to_merged_folder):
2082 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2083 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2084 (modest_ui_actions_on_send):
2085 * src/widgets/modest-folder-view.c: (update_model):
2086 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2087 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2088 modest_tny_account_store_get_tny_account_by_account() to
2089 modest_tny_account_store_get_server_account() to make the code clearer.
2091 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2093 * src/dbus_api/modest-dbus-api.h:
2094 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2095 * src/maemo/modest-msg-edit-window.c:
2096 (modest_msg_edit_window_attach_file_noninteractive):
2097 added g_warning in case the file to be attached does not exist
2098 * tests/dbus_api/test_compose_mail.c: (main):
2099 removed obsolete comment, added generic files as test case
2101 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2103 * src/modest-tny-account-store.c: (get_server_accounts):
2104 Create the local folders account only once, not once for each outbox, and
2105 not only when there are some outboxes.
2107 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2109 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2110 code that is causing a crash at startup. Sergio says that he is fixing this.
2112 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2114 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2115 * src/maemo/modest-account-settings-dialog.c:
2116 (create_page_outgoing),
2117 (modest_account_settings_dialog_set_account_name),
2118 (save_configuration):
2119 - Fixed handling of the "Use secure authentication" toggle to comply with
2120 the ui specification. See also projects.maemo.org bug NB#58400
2122 - Restore the Secure connection setting combo correctly when loading
2125 * src/maemo/modest-maemo-utils.c:
2126 (on_camel_account_get_supported_secure_authentication),
2127 (modest_maemo_utils_get_supported_secure_authentication_methods):
2128 Fixed a crasher if operation is canceled
2130 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2131 (modest_protocol_info_auth_is_secure):
2132 * src/modest-protocol-info.h:
2134 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2135 the sense of the "Use secure authentication" toggle.
2137 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2139 * src/modest-tny-account-store.h:
2140 * src/modest-tny-account-store.c:
2141 Added modest_tny_account_store_get_local_folders_account().
2143 * src/modest-tny-folder.h:
2144 * src/modest-tny-folder.c:
2145 (modest_tny_folder_get_account):
2146 Added this replacement for tny_folder_get_account() which returns
2147 the local-folders account for TnyMergeFolders, to avoid the
2148 warning about the unimplemented get_account_func() vfunc().
2150 (modest_tny_folder_get_rules),
2151 * src/modest-ui-actions.c:
2152 (modest_ui_actions_on_folder_selection_changed):
2153 * src/modest-mail-operation.c:
2154 (modest_mail_operation_remove_folder),
2155 (modest_mail_operation_xfer_folder),
2156 (modest_mail_operation_rename_folder),
2157 (modest_mail_operation_get_msg),
2158 (modest_mail_operation_get_msgs_full),
2159 (modest_mail_operation_remove_msg),
2160 (modest_mail_operation_xfer_msgs),
2161 (modest_mail_operation_refresh_folder):
2162 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2164 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2167 (modest_server_account_set_security):
2168 * src/modest-defs.h: Add comments explaining that our
2169 UI spec means TLS when it says Normal, so these do not look like errors.
2171 * src/modest-tny-account.c:
2172 (modest_tny_account_new_from_server_account): Use the new tinymail
2173 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2174 for TLS. This should fix projects.maemo.org bug NB#58460.
2176 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2178 * src/maemo/easysetup/modest-easysetup-wizard.c:
2179 (create_account): Correct the position of the gconf sanity check warning.
2180 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2181 of using the g_idle_add() hack, because this does not seem to be necessary
2182 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2183 caused by something other than maemo's gconf.
2184 This fixes projects.maemo.org bug #59022.
2186 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-account-mgr-helpers.c:
2189 (modest_account_mgr_get_default_account): Do not check that the account
2190 exists if there is no default account (NULL), to fix a runtime warning.
2192 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2194 * src/widgets/modest-folder-view.c: (update_model):
2195 Do not unref the treemodel before we have finished with it.
2196 This prevents a valgrind warning and an occasional crash at startup.
2198 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2200 * libmodest-dbus-client/libmodest-dbus-client.h:
2201 added libmodest_dbus_client_compose_mail()
2202 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2204 added functions needed for SendAsMail() functionality
2205 * src/maemo/modest-msg-edit-window.c:
2206 (modest_msg_edit_window_attach_file_noninteractive):
2207 non interactively attaching files to message edit window
2208 * src/widgets/modest-msg-edit-window.h:
2209 * tests/dbus_api/Makefile.am:
2210 added test_compose_mail.c
2211 * tests/dbus_api/test_compose_mail.c: (main):
2213 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2215 * src/modest-account-view.c:
2216 Fixed bug projects.maemo.org bug NB#59307
2218 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2220 * src/maemo/easysetup/modest-easysetup-wizard.c:
2221 (get_serverport_incoming), (on_before_next), (create_account):
2222 * src/maemo/modest-account-settings-dialog.c:
2223 (modest_account_settings_dialog_set_account_name):
2224 * src/maemo/modest-maemo-utils.c:
2225 (on_camel_account_get_supported_secure_authentication_status),
2226 (on_camel_account_get_supported_secure_authentication),
2227 (on_secure_auth_cancel),
2228 (modest_maemo_utils_get_supported_secure_authentication_methods):
2230 Implemented security authentication for settings and easysetup.
2232 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2234 * src/maemo/modest-main-window.c: (create_details_widget):
2235 Show the total size for memory card accounts too, instead of showing
2236 the name again. Fixes bug projects.maemo.org bug NB#59307.
2238 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2241 * src/modest-tny-simple-folder-store.c:
2242 * src/modest-tny-simple-folder-store.h: Removed.
2244 * src/modest-tny-local-folders-account.h
2245 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2246 for the local-folders maildir, with an extra TnyMergedFolder containing
2247 the folders of the per-account outbox store accounts.
2248 * src/modest-tny-account-store.c: (get_server_accounts):
2249 Add the outboxes to the special local folders account after creating it.
2251 * src/modest-tny-account.c:
2252 (modest_tny_account_new_for_local_folders): Create the derived
2253 account when creating the main local-folders account.
2255 * src/maemo/modest-main-window.c: (create_details_widget),
2256 (modest_main_window_set_contents_style):
2257 Adapted to the use of the derived account instead of the folder store.
2259 * src/modest-ui-actions.c:
2260 (modest_ui_actions_on_folder_selection_changed):
2261 * src/modest-ui-dimming-rules.c:
2262 (modest_ui_dimming_rules_on_new_folder):
2263 * src/widgets/modest-folder-view.c: (text_cell_data),
2264 (icon_cell_data), (filter_row), (update_model),
2265 (get_cmp_rows_type_pos):
2268 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2269 Do not get the priv struct, because no priv struct has been set,
2270 to avoid a runtime warning.
2272 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2273 #ifelse with #else, to fix a warning, to fix the build.
2276 2007-06-05 Christian Kellner <ckellner@openismus.com>
2278 * libmodest-dbus-client/libmodest-dbus-client.c:
2279 Fix small typo in doc (why do you always see them
2280 AFTER committing stuff?)
2283 2007-06-05 Christian Kellner <ckellner@openismus.com>
2285 * libmodest-dbus-client/libmodest-dbus-client.c:
2286 (libmodest_dbus_client_search):
2287 Initialize hit list with NULL. Also set folder list
2288 to "" if NULL was supplied.
2291 2007-06-03 Christian Kellner <ckellner@openismus.com>
2293 * libmodest-dbus-client/libmodest-dbus-client.c:
2294 (modest_search_hit_list_free):
2295 Make it save to call it with NULL.
2297 * src/dbus_api/modest-dbus-callbacks.c:
2298 * src/modest-search.c:
2299 Return full ModestSearchHits as the search result list not TnyHeader
2300 since can't be around withouth the correspoding TnyFolder.
2302 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2304 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2305 Added currently commented code to check for secure auth
2307 * src/maemo/modest-account-settings-dialog.c: (on_response),
2308 (save_configuration), (show_ok):
2309 Fixed projects.maemo.org bugs NB #59248 and #59251
2311 * src/maemo/modest-maemo-utils.c:
2312 (on_camel_account_get_supported_secure_authentication_status),
2313 (on_camel_account_get_supported_secure_authentication),
2314 (modest_maemo_utils_get_supported_secure_authentication_methods):
2315 * src/maemo/modest-maemo-utils.h:
2316 Moved get_supported_secure_authentication() method here to be able
2317 to use it from easysetup wizard.
2319 * src/modest-pair.c: (on_pair_compare_as_string):
2320 Should compare string with first part of pair and not
2321 strcmp pairs which will crash.
2323 * src/modest-protocol-info.c:
2324 (modest_protocol_info_protocol_is_store):
2325 * src/modest-protocol-info.h:
2326 Added modest_protocol_info_get_auth_protocol_name()
2328 2007-06-03 Armin Burgmeier <armin@openismus.com>
2330 * src/modest-mail-operation.c:
2331 (modest_mail_operation_get_msgs_full): Set priv->account also when
2332 only retrieving a single message. This avoids a crash when canceling
2335 (modest_mail_operation_notify_end): Do not explicitely remove the
2336 operation from the queue but only emit the progress_changed signal.
2337 The queue itself listens to that signal to remove the operation when
2338 it is finished. This reduces coupling and removes a potential deadlock
2339 when modest_mail_operation_notify_end() is called from the queue
2340 itself. If that is a problem performance-wise, I would suggest to
2341 implement a status-changed signal or something.
2343 * src/modest-mail-operation-queue.c: Make sure to never call a
2344 function from another file while the queue is locked. This (hopefully)
2345 fixes another deadlock when exiting the application while retrieving
2348 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2350 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2351 Fixed build if libogs is not available
2353 2007-06-03 Christian Kellner <ckellner@openismus.com>
2355 * libmodest-dbus-client/libmodest-dbus-client.h:
2356 * libmodest-dbus-client/libmodest-dbus-client.c:
2357 (libmodest_dbus_client_delete_message):
2358 Implement deletion of messages (Client side).
2360 (modest_search_hit_free),
2361 (modest_search_hit_list_free):
2362 Utility functions to free the result hits.
2364 * src/dbus_api/modest-dbus-api.h:
2365 * src/dbus_api/modest-dbus-callbacks.c:
2366 (on_delete_message),
2367 (modest_dbus_req_handler):
2368 Implement deletion of messages (Server side).
2370 * tests/dbus_api/test_search.c: (main):
2373 * tests/dbus_api/Makefile.am:
2374 * tests/dbus_api/test_delete_message:
2375 Add little test for the message deletion logic
2377 2007-06-03 Armin Burgmeier <armin@openismus.com>
2379 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2380 when the operation queue was not empty. projects.maemo.org bug
2383 2007-06-03 Armin Burgmeier <armin@openismus.com>
2385 * src/widgets/modest-account-view.c
2386 (on_account_default_toggled): Toggle default account column
2387 explicitely instead of waiting for gconf notification (which is
2388 currently ignored). This should fix projects.maemo.org bug NB#56910
2389 for now. It should probably be removed when gconf notifications are
2392 2007-06-03 Christian Kellner <ckellner@openismus.com>
2394 * libmodest-dbus-client/libmodest-dbus-client.c:
2395 Removed debugging spew.
2397 * src/dbus_api/modest-dbus-callbacks.c:
2398 Added debugging info.
2400 * src/modest-search.c:
2401 (modest_search_all_accounts):
2402 Use tny_account_store_get_accounts () on the account store
2403 to get all accounts which is the way to get all accounts.
2405 * tests/dbus_api/test_search.c: (main):
2406 Make it possible to supply the search term on the command line.
2408 2007-06-03 Christian Kellner <ckellner@openismus.com>
2410 * libmodest-dbus-client/libmodest-dbus-client.c:
2411 * libmodest-dbus-client/libmodest-dbus-client.h:
2412 Implement searching for mesages over raw dbus. (Client side)
2414 * src/dbus_api/Makefile.am:
2415 * src/dbus_api/modest-dbus-api.h:
2416 * src/dbus_api/modest-dbus-callbacks.c:
2417 * src/dbus_api/modest-dbus-callbacks.h:
2418 Search framework (Server side). Also implement on_idle_open_message().
2420 * src/maemo/modest-platform.c: (modest_platform_init):
2421 Prepare for raw dbus/osso rpc interaction.
2423 * src/modest-search.h:
2424 Changed minsize from unspecific guint to guint32.
2426 * src/modest-search.c:
2428 Added strange hack which magically made tnymail work.
2430 (modest_search_folder),
2431 (modest_search_account),
2432 (modest_search_all_accounts):
2433 Implement helper functions to search all accounts, specific account
2436 * tests/dbus_api/Makefile.am:
2437 * tests/dbus_api/test_open_message.c:
2438 Read url to open from commandline.
2440 * tests/dbus_api/test_search.c:
2441 Implement small test for dbus search stuff
2443 2007-06-02 Armin Burgmeier <armin@openismus.com>
2445 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2446 include account type and account title. This fixes projects.maemo.org
2449 * src/maemo/modest-account-view-window.c: Set a title for the window.
2451 2007-06-02 Armin Burgmeier <armin@openismus.com>
2453 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2454 incoming and outgoing server name based on email address and server
2455 types as long as the names have not been edited manually. This fixes
2456 projects.maemo.org bug NB#58671.
2458 2007-06-02 Armin Burgmeier <armin@openismus.com>
2460 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2461 server type cannot be changed in future to the incoming details page
2462 when creating an account. This fixes projects.maemo.org bug NB#59029.
2464 2007-06-02 Armin Burgmeier <armin@openismus.com>
2466 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2467 and assigned max width chars so that they wrap instead of being
2468 truncated. Fixes projects.maemo.org bug NB#56126.
2470 2007-06-02 Armin Burgmeier <armin@openismus.com>
2472 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2473 introductory note to the connection specific smtp servers dialog, as
2474 section 8.12 of the email UI specification requires. This fixes
2475 projects.maemo.org bug NB#59212.
2477 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2479 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2480 Check for running mail operations, and offer to cancel them, as per the UI
2481 spec. This fixes projects.maemo.org bug NB#59041 .
2482 However, I suspect that tinymail may still use the network connection
2483 in ways that we cannot detect or cancel. But it should at least adapt to
2484 changes fairly well.
2486 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2488 * src/modest-tny-account-store.c: (recreate_all_accounts),
2489 (get_cached_accounts), (get_server_accounts): Do more sensible
2490 ref-counting of the temporarily-cached outbox accounts list. This seems
2491 to fix a crash when entering the password when the password was wrong.
2493 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2495 * src/gnome/modest-main-window.c: (connect_signals):
2496 * src/modest-tny-account-store.c: (get_password),
2497 (modest_tny_account_store_alert): Added comments and clues and
2498 commented-out code about how we currently fail to deal with connection
2499 errors and wrong passwords, and how we should.
2501 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2503 * src/widgets/modest-retrieve-combo-box.c:
2504 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2505 This fixes projects.maemo.org bug NB#58472 .
2507 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2509 * src/maemo/easysetup/modest-easysetup-wizard.c:
2510 (create_page_complete_easysetup):
2511 (create_page_complete_custom): Correct the last commit,
2512 putting the correct sentences in the correct pages.
2514 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2516 * src/maemo/easysetup/modest-easysetup-wizard.c:
2517 (create_page_complete_custom): Show the second sentence of text
2518 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2521 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2523 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2524 Set the leave-on-server conf key by default. This fixes
2525 projects.maemo.org bug NB#59258 .
2527 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2529 * src/maemo/modest-account-view-window.c:
2530 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2531 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2534 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2536 * src/maemo/easysetup/modest-easysetup-wizard.c:
2537 (create_caption_new_with_asterisk):
2538 * src/maemo/modest-account-settings-dialog.c:
2539 (create_caption_new_with_asterisk):
2540 Uncomment the code to add the asterisk, because they are no longer in the
2541 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2542 (update_incoming_server_title): Add an asterisk here too.
2544 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2546 * src/maemo/modest-maemo-global-settings-dialog.c:
2547 (current_connection): Check that we are even connected before trying to
2548 get the current connection name, to prevent a warning.
2550 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2551 Change the comments because tny_maemo_conic_device_connect() is now meant to
2553 * src/modest-mail-operation.c:
2554 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2555 make sure we have a connection and fail if we can't connect.
2557 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2559 * src/maemo/modest-main-window.c:
2560 (on_account_store_connecting_finished): Do not try to get the
2561 connection ID if we are not really connected. I am surprised that
2562 this signal handler is called when we are not connected.
2564 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2566 * src/modest-error.h:
2567 * src/modest-ui-actions.c:
2568 (modest_ui_actions_get_msgs_full_error_handler):
2569 Renamed an enum, added comments, added an enum
2570 for retrieve-limit errors.
2572 * src/modest-mail-operation.c: (foreach_add_item),
2573 (internal_folder_observer_update), (update_account_thread),
2574 (modest_mail_operation_get_msgs_full):
2575 (modest_mail_operation_update_account),
2576 Added comments about how this works, and some code that should
2577 (but does not) check the retrieve-limit. See the TODO comment.
2579 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2581 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2582 Initialize help_id to fix the build. Warnings are good.
2584 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2586 * src/widgets/modest-hbox-cell-renderer.c:
2587 (modest_hbox_cell_renderer_append):
2588 * src/widgets/modest-vbox-cell-renderer.c:
2589 (modest_vbox_cell_renderer_append):
2590 Fix the last commit by doing an extra ref.
2592 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2594 * src/widgets/modest-hbox-cell-renderer.c:
2595 (modest_hbox_cell_renderer_append):
2596 * src/widgets/modest-vbox-cell-renderer.c:
2597 (modest_vbox_cell_renderer_append):
2598 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2599 to fix the build with Maemo Bora.
2600 However, there seems to be a remaining crash, probably due to reference
2603 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2605 * src/modest-tny-account.c:
2606 (modest_tny_account_new_for_local_folders):
2607 Use hildon_file_system_info_async_new() to get a better name for
2608 the memory card account, setting it as the account name.
2609 The timing seems to work, but this is probably
2610 not the best place to do this. See the TODO comment.
2611 * src/maemo/modest-main-window.c: (create_details_widget):
2612 * src/widgets/modest-folder-view.c: (text_cell_data):
2613 Use the tny account name instead of hardcoding a name.
2615 2007-05-30 Christian Kellner <ckellner@openismus.com>
2617 * src/modest-search.c: (modest_search):
2618 Correctly set part_search_func even if we have already parsed
2619 the query and thus a valid OgsTextSearcher object.
2621 2007-05-30 Christian Kellner <ckellner@openismus.com>
2624 Search and check for libogs.
2627 Incooparte the ogs build env.
2629 * src/modest-mime-part-search-stream.c:
2630 * src/modest-mime-part-search-stream.h:
2631 Removed since we do the real searching now in modest-search.c.
2633 * src/modest-search.c:
2634 * src/modest-search.h:
2635 Implement support for ogs. We use that if available and requested
2636 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2637 should now handle the corner case when the search term is spread
2638 across multiple reads.
2639 Also the logic in modest_search () was corrected to search all
2640 requested fields until one is found.
2642 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2644 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2646 * src/modest-init.h:
2647 * src/modest-init.c: Made modest_init_local_folders() take a
2648 path and be public so we can iniitialize maildir folders on
2651 * src/modest-local-folder-info.h:
2652 * src/modest-local-folder-info.c:
2653 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2655 * src/modest-tny-account.c:
2656 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2657 still means the standard local-folders path on the local volume.
2659 * src/modest-tny-account-store.c:
2660 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2661 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2662 all accounts when that happens.
2663 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2664 this too, so it shows up in the treeview.
2666 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-maemo-global-settings-dialog.c:
2669 (current_connection):
2670 * src/widgets/modest-global-settings-dialog.c:
2671 (current_connection_default):
2672 Use the enum values instead of 0, 1 and -1,
2673 to make the code clearer.
2675 * src/modest-account-mgr-helpers.c:
2676 (modest_account_mgr_get_connection_specific_smtp): Make this code
2679 * src/modest-runtime.h:
2680 * src/modest-runtime.c:
2681 Added modest_runtime_remove_all_send_queues().
2682 * src/maemo/modest-main-window.c:
2683 (on_account_store_connecting_finished): Recreate the send queues,
2684 using the appropriate transport accounts for this new connection.
2685 Some futher adapting might be needed if the old send queues are not
2686 automatically stopped at this point.
2688 * src/modest-tny-account-store.c: (get_server_accounts):
2689 Create the connection-specific transport accounts, so that they can
2690 be found later by their ID.
2692 * src/modest-tny-account.h:
2693 * src/modest-tny-account.c:
2694 Added modest_tny_account_new_from_server_account_name().
2695 modest_tny_account_new_from_server_account(): Do not create the
2696 send queues here, because they will be
2697 recreated anyway when the connection changes for the first time.
2699 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2701 * src/modest-local-folder-info.h:
2702 * src/modest-local-folder-info.c:
2703 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2704 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2705 tbox_folder): Take a modest account name instead of a server TnyAccount,
2706 so we can have per-modest-account rather than per-transport-account
2708 We must make sure that we change or recreate the exisitng send queues
2709 when the connection changes for connection-specific transport accounts.
2711 * src/modest-tny-account-store.c:
2712 (create_per_account_local_outbox_folders): Create outboxed per modest
2713 account, not per transport account.
2715 * src/modest-tny-account.h:
2716 * src/modest-tny-account.c:
2717 (modest_tny_account_get_special_folder): For outboxes, get the
2718 parent modest account name. The account is ignored for other folders.
2719 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2720 modest account name rather than a server TnyAccount.
2722 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2724 * src/modest-tny-account.c:
2725 (modest_tny_account_new_from_server_account):
2726 Call modest_runtime_get_send_queue() immediately after creating transport
2727 accounts, so that they start trying to send email from the outbox as soon
2728 as possible at startup. This is probably what we want.
2730 * src/modest-mail-operation.c: (update_account_thread):
2731 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2732 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2733 * src/modest-tny-send-queue.h:
2734 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2735 (modest_ui_actions_on_send):
2736 Added comments about how sending works, though it needs some more work.
2738 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2740 * src/modest-tny-account.c:
2741 (modest_tny_account_get_special_folder): Add TODO because this fails when
2742 the network is busy.
2743 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2744 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2745 Do not try to show this window when there is no active account. The UI
2746 specs does not tell us what to do in this case.
2748 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2752 * src/maemo/Makefile.am:
2753 * src/widgets/Makefile.am: Some dist fixes.
2755 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2757 * src/maemo/modest-connection-specific-smtp-window.c:
2758 (on_button_edit): Make the code clearer, to prevent a double free.
2760 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2762 * src/maemo/modest-account-settings-dialog.c:
2763 (modest_account_settings_dialog_set_account_name),
2764 Check the connection-specific smtp servers checkbox if there are any.
2766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2767 (modest_connection_specific_smtp_edit_window_init):
2768 Start with a suitable port number.
2770 * src/modest-account-mgr-helpers.h:
2771 * src/modest-account-mgr-helpers.c: Added
2772 modest_account_mgr_get_has_connection_specific_smtp().
2774 (modest_account_mgr_set_connection_specific_smtp),
2775 (modest_account_mgr_remove_connection_specific_smtp),
2776 (modest_account_mgr_get_has_connection_specific_smtp),
2777 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2778 connection-specific smtp server accounts in the account, rather than
2779 the server account conf dir.
2781 This fixes bug projects.maemo.org bug NB#58263 .
2783 * src/modest-tny-account-store.c:
2784 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2785 if there are no server accounts yet, to prevent an infinite loop when there
2786 are no accounts. Document that one must be called before the other.
2788 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2790 * src/modest-account-mgr-helpers.c:
2791 (modest_account_mgr_get_default_account): Make sure that at least
2792 one account is always the default, if there are any enabled accounts.
2793 This is just a sanity check that shouldn't be necessary.
2795 * src/modest-account-mgr-priv.c:
2796 (_modest_account_mgr_account_from_key): Unescape the conf key to
2797 get the real account name. For instance, this is an issue if a space
2798 was in the account name, which can happen because the account name
2799 is generated from the display name.
2800 (_modest_account_mgr_get_account_keyname): Always escape the
2802 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2803 Unescape the conf keys to get the real account names.
2805 For instance, previously the is-default radio button in the accounts
2806 list was not checked for any accounts at first. This fixes that,
2807 and might fix several similar bugs.
2809 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2811 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2812 Removed some debug printfs.
2814 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2816 Modest on-disk outbox directories are now here, for instance:
2817 $HOME/.modest/outboxes/<account-id-1>/outbox
2818 $HOME/.modest/outboxes/<account-id-2>/outbox
2820 $HOME/.modest/local-folders/outbox
2821 so we can have a separate outbox for each account.
2822 But they are shown as one outbox in the GtkTreeView, by using a
2823 TnyMergeFolder in a ModestTnySimpleFolderStore.
2826 * src/modest-tny-simple-folder-store.c:
2827 * src/modest-tny-simple-folder-store.h:
2828 Added ModestTnySimpleFolderStore, used to contain folders from
2829 other folder stores, such as other accounts.
2831 * src/modest-tny-outbox-account.h:
2832 * src/modest-tny-outbox-account.c:
2833 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2834 used for the per-account local outbox folders.
2836 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2837 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2838 only use this (internally) now for the non-outbox local folders.
2840 * src/modest-init.h:
2841 * src/modest-init.c: Added modest_init_one_local_folder(), for
2842 setting up the directory structure for each local folder.
2844 * src/modest-local-folder-info.c:
2845 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2846 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2848 * src/modest-local-folder-info.h:
2849 * src/modest-tny-account-store.c: (on_account_removed),
2850 (on_account_changed), (create_per_account_local_outbox_folders),
2851 (get_server_accounts), (modest_tny_account_store_get_accounts),
2852 (modest_tny_account_store_get_tny_account_by_account),
2853 (modest_tny_folder_store_is_virtual_local_folders):
2855 * src/modest-tny-account.h:
2856 * src/modest-tny-account.c:
2857 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2858 to create an on-disk per-account local outbox folder for each
2860 (create_per_account_local_outbox_folders): Create a local outbox folder
2861 for each transport account.
2862 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2863 for all local folders.
2865 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2866 instead of using g_object_get/set() directly. It is clearer.
2868 (modest_tny_folder_store_get_message_count),
2869 (modest_tny_folder_store_get_local_size
2870 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2871 because we now use these with non-acount folder stores.
2873 (modest_tny_account_get_special_folder),
2874 (modest_tny_account_new_from_server_account),
2875 (modest_tny_account_new_from_account):
2876 (recurse_folders): Adjust to the new outbox system.
2878 * src/modest-tny-folder.h:
2879 * src/modest-tny-folder.c:
2880 (modest_tny_folder_is_local_folder),
2881 (modest_tny_folder_get_local_folder_type),
2882 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2884 * src/widgets/modest-main-window.h:
2885 * src/maemo/modest-main-window.c: (create_details_widget),
2886 (modest_main_window_set_contents_style): Show details for any folder store,
2889 (modest_tny_folder_get_rules):
2890 Remove the const. C does not support constness enough for this.
2892 * src/modest-ui-actions.c:
2893 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2894 make all outboxes appear as one, in the usual local-folders tree node.
2896 (set_active_account_from_tny_account),
2897 (modest_ui_actions_on_folder_selection_changed):
2898 * src/widgets/modest-folder-view.c: (text_cell_data),
2899 (icon_cell_data), (filter_row),
2900 (add_account_folders_to_merged_folder),
2901 (add_account_folders_to_simple_folder_store), (),
2902 (get_cmp_rows_type_pos), (cmp_rows),
2903 (modest_folder_view_set_account_id_of_visible_server_account):
2904 Adjust to the new outbox system, using generic folder stores and folders
2905 in the GtkTreeModel.
2907 2007-05-23 Christian Kellner <ckellner@openismus.com>
2909 * src/modest-mail-operation.c:
2910 (modest_mail_operation_update_account):
2911 Use info->max_size instead of unintialized local var [small
2912 build fix]. (Added TODO to review that change since I don't
2915 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2917 * libmodest-dbus-client/libmodest-dbus-client.c:
2918 (libmodest_dbus_client_compose_mail): function added
2919 * src/dbus_api/modest-dbus-api.h:
2920 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2921 (on_compose_mail): Implementation of the SendAsMail functionality
2923 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2925 * src/modest-account-mgr.c:
2926 (modest_account_mgr_add_server_account): Set the secure-connection
2927 conf key for transport accounts as well as store accounts. I don't know
2928 why the if was there. For instance, this makes sure that we use SSL
2929 for the gmail preset from the easysetup wizard.
2931 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2933 * src/gnome/modest-main-window.c:
2934 (on_account_store_connecting_finished), (connect_signals):
2935 * src/maemo/modest-main-window.c:
2936 (on_account_store_connecting_finished), (connect_signals),
2937 (modest_main_window_new):
2938 Handle TnyAccountStore::connecting-finished instead of
2939 TnyDevice::connection-changed, because we cannot actually perform
2940 operations on accounts until TnyAccountStore has itself responded to
2941 the TnyDevice::connection-changed signal. This prevents a GError from
2943 Do not try to update at startup, because we (at least on scratchbox)
2944 already do an update at startup when the device goes online.
2945 This prevents a GError from tinymail.
2946 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2947 Added TODO about stopping simultaneous operations.
2949 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2951 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2952 * src/modest-mail-operation-queue.c:
2953 (modest_mail_operation_queue_remove):
2954 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2955 about where they happened.
2957 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2959 * src/modest-ui-actions.c:
2960 (modest_ui_actions_on_password_requested): Make sure that the remember
2961 output parameter is always TRUE.
2963 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2965 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2966 Show a OK/Cancel dialog if the error is a question, though we still do not
2967 know anything more about what we are asking the user.
2968 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2969 Fix an uninitialized variable (helper). This is a logic error, however.
2971 2007-05-21 Christian Kellner <ckellner@openismus.com>
2973 * src/modest-search.h:
2974 Correct bit shifting in the ModestSearchFlags enum.
2976 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2978 * src/modest-tny-account.c:
2979 (modest_tny_account_new_from_server_account): Do not use the lsub and
2980 check-all hard-coded IMAP options when using POP.
2982 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2984 * src/modest-tny-account.c:
2985 (modest_tny_account_new_from_server_account):
2986 Use NULL for the secure-auth method for POP when Password auth has been
2987 specified by the user, as we already do for IMAP. "auth=Login" causes
2988 an error from camel or the server.
2990 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2992 * src/maemo/modest-account-settings-dialog.c:
2993 (create_page_account_details),
2994 (modest_account_settings_dialog_set_account_name):
2995 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2996 for the leave-on-server checkbox, rathr than just the checkbox, when
2997 the protocol is not POP.
2999 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3001 * src/widgets/modest-account-view.c:
3002 * src/widgets/modest-account-view.h:
3003 Added modest_account_view_select_account() which will be useful later
3004 to asynchronously re-select the edited account.
3006 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3008 * src/maemo/modest-account-settings-dialog.c:
3009 (modest_account_settings_dialog_set_account_name):
3010 Automatically choose the port numbers based on the secure authentication
3011 methods, if they have not been chosen before.
3012 This fixes projects.maemo.org bug NB#56273 .
3014 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/modest-main-window-ui.h:
3017 * src/modest-ui-actions.c:
3018 * src/modest-ui-actions.h:
3019 Connect the Tools/SMTP Servers menu item to
3020 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3021 SMTP servers dialog, as in the UI specification and saves changes when it
3022 is closed. This fixed projects.maemo.org bug NB#56305 .
3024 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3026 * src/maemo/modest-connection-specific-smtp-window.c:
3027 (modest_connection_specific_smtp_window_init):
3028 Use gtk_window_set_default_size() to make this window big enough, so
3029 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3031 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3033 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3034 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3035 (modest_connection_specific_smtp_edit_window_init),
3036 Do not try to connect to a combobox signal before the combobox exists.
3037 This fixes the cras in projects.maemo.org bug NB#56288 .
3038 (modest_connection_specific_smtp_edit_window_get_settings):
3039 Remove the server_account_name parameter which was being checked for NULL
3040 though it was not used.
3042 * src/maemo/modest-connection-specific-smtp-window.c:
3043 (modest_connection_specific_smtp_window_fill_with_connections),
3044 (on_button_edit), (modest_connection_specific_smtp_window_init):
3045 Correct the number of treemodel columns to prevent a warning.
3046 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3047 libconic does not work.
3049 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3051 * src/modest-tny-account.c:
3052 (modest_tny_account_new_from_server_account):
3053 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3054 SMTP when "None" was chosen by the user. However, with my SMTP server that
3055 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3058 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3060 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3061 to explain the memory management issue with the ID in the ModestPair.
3063 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3064 (add_sending_page), (modest_account_assistant_finalize):
3065 * src/gnome/modest-gnome-global-settings-dialog.c:
3066 (create_updating_page), (create_composing_page):
3067 * src/gnome/modest-msg-edit-window.c: (get_transports),
3068 (init_window), (modest_msg_edit_window_finalize),
3069 (modest_msg_edit_window_get_msg_data):
3070 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3071 * src/gnome/modest-transport-widget.c:
3072 (modest_transport_widget_finalize), (smtp_configuration):
3073 * src/maemo/modest-maemo-global-settings-dialog.c:
3074 (create_updating_page), (create_composing_page):
3075 * src/maemo/modest-msg-edit-window.c: (get_transports),
3076 (init_window), (modest_msg_edit_window_finalize),
3077 (modest_msg_edit_window_get_msg_data),
3078 (modest_msg_edit_window_free_msg_data):
3079 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3080 (modest_store_widget_finalize):
3081 * src/maemo/modest-transport-widget.c:
3082 (modest_transport_widget_finalize), (smtp_configuration):
3083 * src/modest-main.c: (send_mail):
3084 * src/widgets/modest-combo-box.h:
3085 * src/widgets/modest-global-settings-dialog-priv.h:
3086 * src/widgets/modest-global-settings-dialog.c:
3087 (modest_global_settings_dialog_finalize):
3088 * src/widgets/modest-msg-edit-window.h:
3089 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3090 as long as the combo box, to prevent use of freed memory for the ID.
3092 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3094 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3095 get_accounts(), to make this clearer. Do not check for the enabled gconf
3096 key, because we do not use this for server accounts (at least, not yet).
3097 This allows us to send email again.
3099 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3101 * src/maemo/modest-platform.c:
3102 (on_modest_conf_update_interval_changed), (modest_platform_init):
3103 Only respond to this particular key change. All these strcmp()s cannot be
3106 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3108 * src/maemo/modest-maemo-global-settings-dialog.c:
3109 (current_connection): Prevent a crash in scratchbox when
3110 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3111 * src/maemo/modest-platform.c:
3112 (on_modest_conf_update_interval_changed), (modest_platform_init):
3113 Get the update interval from gconf and reset it when the gconf key changes.
3115 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3117 * src/modest-protocol-info.c:
3118 * src/modest-protocol-info.h: Adde enum-specific get functions,
3119 instead of using a ModestProtocolType enum parameter.
3121 * src/gnome/modest-account-assistant.c:
3122 * src/gnome/modest-store-widget.c:
3123 * src/gnome/modest-store-widget.h:
3124 * src/gnome/modest-transport-widget.c:
3125 * src/gnome/modest-transport-widget.h:
3126 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3127 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3128 * src/maemo/easysetup/modest-easysetup-wizard.c:
3129 * src/maemo/modest-account-settings-dialog.c:
3130 * src/maemo/modest-account-settings-dialog.h:
3131 * src/maemo/modest-store-widget.c:
3132 * src/maemo/modest-store-widget.h:
3133 * src/maemo/modest-transport-widget.c:
3134 * src/maemo/modest-transport-widget.h:
3135 * src/modest-account-mgr-helpers.c:
3136 * src/modest-account-mgr-helpers.h:
3137 * src/modest-account-mgr.c:
3138 * src/modest-account-mgr.h:
3139 * src/modest-tny-account.c:
3140 * src/modest-tny-folder.c:
3141 * src/widgets/modest-account-view.c:
3142 * src/widgets/modest-retrieve-combo-box.c:
3143 * src/widgets/modest-retrieve-combo-box.h:
3144 * src/widgets/modest-secureauth-combo-box.c:
3145 * src/widgets/modest-serversecurity-combo-box.c:
3146 * src/widgets/modest-serversecurity-combo-box.h:
3147 * tests/check_account-mgr.c:
3148 Use the specific functions, and use the re-renamed enum values for GNOME too.
3150 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3152 * src/modest-pair.h:
3153 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3154 so we can get the second based on the first.
3156 * src/maemo/modest-account-settings-dialog.h:
3157 * src/maemo/modest-account-settings-dialog.c:
3158 Added get_supported_secure_authentication_methods(), though it is mostly
3159 commented-out for now until the necessary API is committed to tinymail.
3160 (modest_account_settings_dialog_set_account_name),
3161 (save_configuration): Request the supported authentication methods from the
3162 server, so we can choose a working method.
3164 * src/modest-tny-account-store.h:
3165 * src/modest-tny-account-store.c:
3166 (modest_tny_account_store_get_session): Rename from
3167 tny_account_store_get_session().
3169 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3171 * src/modest-protocol-info.h: Split the ModestProtocol enum
3172 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3173 There was no need to have these unrelated values in one enum.
3175 * src/: many files: Adapted to changed enum. This makes the code a bit
3176 clearer, and the compiler could catch some errors.
3178 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3180 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3181 Show the detailed internal camel error message when an error happens
3182 during the configuration, so that our testers can give us more clues.
3183 For instance, in projects.maemo.org bug NB#56910 .
3185 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3187 * src/modest-tny-account.c:
3188 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3189 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3191 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3193 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3194 * src/maemo/modest-account-settings-dialog.c:
3195 (modest_account_settings_dialog_set_account_name),
3196 (save_configuration): For the incoming secure authentication checkbox,
3197 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3198 the UI specification. PLAIN does not seem to be supported for most IMAP
3199 servers anyway, and I am not sure what it would mean.
3200 However, we probably need to discover which of the secure-authentication
3201 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3202 * src/modest-account-mgr-helpers.c:
3203 (modest_account_mgr_get_server_account_data):
3205 * src/modest-tny-account.c:
3206 (modest_tny_account_new_from_server_account):
3207 Use tny_account_set_mech() to set secure-authentication methods,
3208 with some special-casing for IMAP, based on my observations of how
3211 * src/modest-account-mgr-helpers.h:
3212 * src/modest-account-mgr.c:
3213 * src/modest-defs.h: Comment that the URI is only used for local folders.
3215 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3217 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3218 parameter const, just to be neat.
3219 * src/modest-text-utils.c: (modest_text_utils_inline):
3220 End g_strconcat() with NULL, as its documentation says. This is almost
3221 certainly the cause of my crash at startup on the device. Interestingly,
3222 valgrind doesn't tell us about these errors.
3224 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3226 * scripts/build-packages: Added more precise comments about how to use
3227 this script, though I still get this error:
3228 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3229 error building tinymail
3231 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3233 * src/maemo/modest-main-window.c: (on_account_update):
3234 Very slight cleanup, hoping to make it simpler to discover what causes
3235 a crash here sometimes.
3237 * src/modest-tny-account.c:
3238 (modest_tny_account_new_from_server_account): Set the port. Added
3239 comments about the options and a TODO comment because I need to find out
3240 how to specify the secure authentication method.
3242 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3244 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3245 changed CFlags paths form modest to libmodest
3247 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3249 * src/modest-account-mgr-helpers.c:
3250 (modest_account_mgr_get_server_account_data),
3251 (modest_account_mgr_free_server_account_data):
3252 * src/modest-account-mgr-helpers.h:
3253 * src/modest-account-mgr.c:
3254 (modest_account_mgr_add_server_account):
3255 * src/modest-defs.h:
3256 * src/modest-tny-account.c:
3257 (modest_tny_account_new_from_server_account):
3258 Determine the options for tny_camel_account_add_option() here,
3259 based on the settings, rather than storing them directly in gconf.
3261 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3263 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3264 Show a more friendly error dialog now that we expect (from the tinymail
3265 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3267 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3269 * src/maemo/modest-main-window.c: (on_account_update): Check that
3270 account_name is not NULL, to prevent a crash at startup that I am
3271 seeing on the N800. I do wonder why it is NULL.
3273 * src/maemo/easysetup/modest-easysetup-wizard.c:
3274 (create_page_user_details):
3275 * src/maemo/modest-account-settings-dialog.c:
3276 (create_page_user_details), (create_page_outgoing):
3277 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3278 (modest_connection_specific_smtp_edit_window_init):
3279 * src/modest-ui-actions.c:
3280 (modest_ui_actions_on_password_requested):
3281 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3282 might do something useful with the on-screen keyboard.
3284 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3286 * src/maemo/modest-main-window.c: (on_account_update):
3287 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3288 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3290 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3292 * src/modest-tny-account-store.c: (on_account_changed):
3293 Correct the signature of this signal handler.
3295 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3297 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3298 Show a HildonNote instead of a GtkDialog for Maemo.
3300 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3302 * src/widgets/modest-account-view.h:
3303 * src/widgets/modest-account-view.c: (on_account_changed),
3304 (on_account_removed). Added a boolean flag, set/unset by
3305 modest_account_view_block_conf_updates(),
3306 modest_account_view_unblock_conf_updates() to prevent unnecessary
3307 updates, but this is not very useful because the gconf notifications are
3308 so delays (maybe only on Maemo Bora).
3309 So auto-updating is turned off, and these functions do an explicit
3310 update when necessary.
3311 However, something else is still doing too much work when adding/removing
3312 accounts, probably in another part of the application.
3314 * src/maemo/modest-account-view-window.c:
3315 (on_delete_button_clicked), (on_edit_button_clicked),
3316 (on_new_button_clicked): Use the new functions.
3318 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3320 * src/modest-account-mgr-helpers.c:
3321 (modest_account_mgr_set_first_account_as_default):
3322 Sort the list of names alphabetically-by-title, so we choose the first one
3324 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3325 alphabetically by the title.
3327 This fixes projects.maemo.org bug NB#56418 .
3329 * src/modest-account-mgr-priv.c:
3330 (_modest_account_mgr_account_from_key):
3331 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3332 avoid a valgrind error, and possible random behaviour.
3334 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3336 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3337 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3338 tinymail documentation to say that this can be expected.
3339 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3340 pretty, and should not happen, but I would prefer to know when it does.
3342 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3344 * configure.ac: When using the older hildon version, probably on Bora,
3345 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3347 * src/widgets/modest-attachment-view.c:
3348 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3351 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3353 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3354 Implemented the prototype. Can be tested with
3355 tests/dbus_api/test_open_message:
3357 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3359 * src/modest-tny-account-store.c:
3360 (modest_tny_account_store_instance_init), (get_password):
3361 * src/modest-ui-actions.c:
3362 (modest_ui_actions_on_password_requested):
3363 Do not store the password in gconf, because this function is called
3364 for non-remembered passwords. Actually use the cached (in the hash map)
3365 password instead of releasing it.
3366 The password will now not be remembered if it is asked via the protected
3367 password dialog, as per the UI spec.
3369 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-defs.h:
3372 * src/modest-account-mgr-helpers.h:
3373 * src/modest-account-mgr-helpers.c:
3374 Added modest_server_account_get_username_has_succeeded(),
3375 modest_server_account_set_username_has_succeeded().
3376 (modest_server_account_set_username),
3377 Reset the has-succeeded flag if the username changes.
3379 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3380 * src/maemo/modest-connection-specific-smtp-window.c:
3381 (modest_connection_specific_smtp_window_save_server_accounts):
3382 Use modest_server_account_set_username() instead of using
3383 modest_conf_set_string() directly, so that the has-succeeded flag is always
3386 * src/modest-ui-actions.c:
3387 (modest_ui_actions_on_password_requested): Dim the username entry if
3388 the username has ever worked, as per the UI spec.
3390 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3392 * src/modest-tny-account-store.c: (get_password):
3393 * src/modest-ui-actions.c:
3394 (modest_ui_actions_on_password_requested):
3395 Allow the username to be changed too, though there is more work to
3396 be done on exactly how this behaves.
3398 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3400 * src/modest-account-mgr-helpers.h:
3401 * src/modest-account-mgr-helpers.c:
3402 Added modest_account_mgr_get_display_name(),
3403 modest_server_account_get_username(),
3404 modest_server_account_set_username(),
3405 modest_server_account_set_password(),
3406 modest_server_account_get_hostname() functions so we do not need to
3407 use the conf API directly.
3409 * src/maemo/modest-main-window.c: (connect_signals):
3410 Actually connect ot the ModestAccountStore::request-password signal,
3411 so that we show the dialog when the password is requested by Tinymail,
3412 for isntance if it is empty.
3414 * src/modest-marshal.list:
3415 * src/modest-tny-account-store.c:
3416 (modest_tny_account_store_class_init), (get_password),
3417 (modest_tny_account_store_alert):
3418 * src/modest-tny-account-store.h:
3419 * src/modest-ui-actions.h:
3420 * src/modest-ui-actions.c:
3421 (modest_ui_actions_on_password_requested):
3422 Change the signal parameters, so it is obvious that we are providing
3423 the non human-readable server name, and receiving both the username
3424 and password, though changing of the username is not yet implemented.
3425 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3426 for the GNOME version.
3428 This should fix the projects.maemo.org bug NB#56209, though it does not
3429 work on Bora, because the gconf_client_get() for the password fails
3430 immediately after we save it with gconf_client_set().
3432 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3435 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3436 caused an undefined symbol error:
3437 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3439 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3441 * src/modest-tny-account-store.c:
3442 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3443 using a GError instead of a string message, so we can translate it in
3446 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3448 * src/maemo/modest-address-book.c:
3449 (modest_address_book_check_names):
3450 * src/maemo/modest-msg-view-window.c:
3451 (modest_msg_view_window_clipboard_owner_change):
3452 * src/modest-init.c: (modest_init_init_ui):
3453 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3454 (update_folders_cb), (modest_mail_operation_update_account):
3455 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3456 (modest_ui_actions_on_msg_attachment_clicked),
3457 (modest_ui_actions_on_msg_recpt_activated):
3458 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3459 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3460 (modest_msg_view_search_next):
3461 * src/widgets/modest-recpt-editor.c:
3462 (modest_recpt_editor_on_button_release_event),
3463 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3464 g_message(). At this point we should only be seeing interesting errors on
3465 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3467 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3469 (modest_wizard_dialog_force_title_update):
3470 * src/maemo/easysetup/modest-wizard-dialog.h:
3471 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3472 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3473 can update the title when appropriate. Otherwise the title is wrong if the
3474 pages are added after adding the notebook to the dialog.
3475 This must be a problem in HildonWizardDialog too.
3476 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3478 * src/maemo/easysetup/modest-easysetup-wizard.c:
3479 (create_subsequent_customsetup_pages),
3480 (create_subsequent_easysetup_pages):
3481 Call modest_wizard_dialog_force_title_update() so that the title is
3482 correct even with GTK+ < 2.10.
3483 This fixes projects.maemo.org bug NB#56145 .
3485 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/modest-platform.c:
3488 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3489 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3492 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3494 * src/widgets/modest-window.h:
3495 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3496 and modest_window_save_state(), which invokes it.
3498 * src/widgets/modest-window-mgr.h:
3499 * src/widgets/modest-window-mgr.c:
3500 Added modest_window_mgr_save_state_for_all_windows(), which calls
3501 the save_state vfunc on all registered windows, if implemented.
3503 * src/gnome/modest-msg-edit-window.c:
3504 * src/gnome/modest-msg-view-window.c:
3505 * src/maemo/modest-msg-edit-window.c:
3506 * src/maemo/modest-msg-view-window.c:
3507 * src/maemo/modest-main-window.c:
3508 Specify the existing save_settings functions as implementations of
3509 ModestWindow::save_state_func().
3511 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3512 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3513 enabling hibernation, for instance.
3515 We may need to do the same thing for restoring settings.
3518 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3520 * src/widgets/modest-window-mgr.c:
3521 * src/widgets/modest-window-mgr.h:
3522 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3523 modest_window_mgr_get_hibernation_is_prevented().
3525 * src/maemo/modest-main-window.c:
3526 (on_hildon_program_is_topmost_notify): Prevent hibernation
3527 (possible when the application goes to the background in the WM),
3528 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3530 * src/maemo/easysetup/modest-easysetup-wizard.c:
3531 (modest_easysetup_wizard_dialog_init):
3532 * src/maemo/modest-account-settings-dialog.c:
3533 (modest_account_settings_dialog_init):
3534 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3535 (modest_connection_specific_smtp_edit_window_init):
3536 * src/maemo/modest-connection-specific-smtp-window.c:
3537 (modest_connection_specific_smtp_window_init):
3538 * src/maemo/modest-signature-editor-dialog.c:
3539 (modest_signature_editor_dialog_init):
3540 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3541 prevent hibernation while any of these account settings dialogs are open.
3543 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3545 * src/maemo/Makefile.am:
3546 * src/maemo/modest-osso-state-saving.c:
3547 * src/maemo/modest-osso-state-saving.h: Added
3548 modest_osso_load_state() and modest_osso_save_state() though they do
3549 nothing now. They should iterate through all the open windows and load/save
3551 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3552 save state when closing.
3554 * src/maemo/modest-main-window.c:
3555 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3556 Add a notification handler for the HildonProgram::is-topmost property,
3557 so we can allow hibernation when the application goes into the background.
3558 But we still need to detect when the accounts setup windows are open so
3559 we can stop hibernation when they are open.
3560 To do this, I also added the main window the HildonProgram. This might have
3561 other side-effects/benefits, and should maybe be done for other windows.
3563 * src/maemo/modest-osso-autosave-callbacks.h:
3564 * src/maemo/modest-osso-autosave-callbacks.c:
3565 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3566 though it does not do anything yet, and we might never need this to do
3567 anything. For instance, we already save drafts.
3569 * src/maemo/modest-platform.c: (modest_platform_init):
3570 Specify the libosso auto-save callback.
3572 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3574 * src/maemo/modest-platform.c:
3575 (modest_platform_set_update_interval):
3576 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3577 aparently stays valid between application instances, so we can use this
3578 to remove and reset it later. According to a maemo-developers email from
3581 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3583 * configure.ac: Depend on libalarm for Maemo.
3585 * src/dbus_api/modest-dbus-api.h:
3586 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3587 (on_send_receive), (modest_dbus_req_handler):
3588 Handle a SEND_RECEIVE D-Bus method.
3590 * libmodest-dbus-client/libmodest-dbus-client.c:
3591 (libmodest_dbus_client_send_and_receive):
3592 * libmodest-dbus-client/libmodest-dbus-client.h:
3593 Add C convenience functions for calling the new D-Bus method.
3595 * src/modest-platform.h:
3596 * src/gnome/modest-platform.c:
3597 * src/maemo/modest-platform.c:
3598 Added modest_platform_set_update_interval(), which uses the
3599 alarmd API on Maemo.
3600 (modest_platform_init),
3601 Call modest_platform_set_update_interval(), using a hard-coded
3602 interval for now (until the global settings dialog is implemented),
3603 though I am not sure that this makes sense yet.
3605 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3607 * src/dbus_api/modest-dbus-callbacks.c:
3608 (modest_osso_cb_hw_state_handler):
3609 * src/dbus_api/modest-dbus-callbacks.h:
3610 * src/maemo/modest-platform.c: (modest_platform_init):
3611 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3612 in case this has some effect on the ability for Maemo to ping the
3615 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3617 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3618 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3619 warning. It is probably a logic error, but I need to fix the build.
3621 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3623 * src/modest-account-mgr.h:
3624 * src/modest-account-mgr.c:
3625 (modest_account_mgr_account_names): Add a gboolean enabled_only
3626 parameter, so we can get lists of onlt the enabled accounts.
3628 (modest_account_mgr_add_account),,
3629 (modest_account_mgr_account_with_display_name_exists):
3630 * src/maemo/modest-msg-edit-window.c: (get_transports):
3631 * src/modest-account-mgr-helpers.c:
3632 (modest_account_mgr_set_first_account_as_default):
3633 * src/modest-init.c: (init_default_account_maybe):
3634 * src/modest-tny-account-store.c: (get_accounts):
3635 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3636 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3637 * tests/check_account-mgr.c: (START_TEST):
3638 Provide the extra parameter, as appropriate.
3640 * src/widgets/modest-account-view.c: (update_account_view):
3641 Do not show disabled accounts (meaning that there is no way to
3642 enable/disable accounts in the UI (the feature is not in our UI
3643 specification), so we can use this internally only to mark unfinished
3644 or temporary account data.
3646 * src/maemo/easysetup/modest-easysetup-wizard.c:
3647 (create_account): Add boolean enable parameter, so we can specify FALSE
3648 to create the temporary account.
3649 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3650 (on_before_next): When finishing, when there is a temporary account, just
3652 Also, use a timeout to delay the showing of the dialog until gconf is likely
3653 to return correct information, due to a maemo gconf bug that is fixed in
3654 osso 1.1, but not yet in Bora.
3655 However, the dialog stays on screen after it is destroyed.
3657 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3658 for invalid data when cancelling. Use a hildon note instead of a dialog
3659 to complain about invalid data. Do not show the account-saved note if the
3660 account is disabled (a temporary account that will not really be saved for use
3663 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3665 * src/modest-account-mgr-helpers.h:
3666 * src/modest-account-mgr-helpers.c:
3667 Added modest_account_mgr_unset_default_account(),
3668 Added modest_account_mgr_set_first_account_as_default().
3670 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3671 If it was the default account, unset the default account name.
3673 * src/maemo/modest-account-view-window.c:
3674 (on_delete_button_clicked): If it was the default account,
3675 set the first remaining account as the default instead.
3677 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3678 a NULL account or a NULL default account, to prevent a crash. This should
3679 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3682 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3684 * src/widgets/modest-recpt-editor.c:
3685 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3686 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3687 TODO comment for this. This fixes the build.
3689 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3690 be the best place for it. This will in future update all auto-update accounts,
3691 rather than just the current/default account, when that gconf key exists.
3692 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3693 if there are no accounts, before calling do_send_receive().
3694 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3696 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3697 * src/maemo/modest-main-window-ui.h:
3698 * src/maemo/modest-main-window.c: (on_connection_changed),
3699 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3700 directly, becaue the signal handler does more.
3702 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3704 * src/modest-account-mgr-helpers.c:
3705 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3706 for the case that the account does not exist.
3708 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3709 (equivalent to the modest account name) rather than the tinymail account name
3710 (equivalent to the modest account title - human readable) to get the account data.
3711 Check for null account data to prevent the crash, and add a TODO comment saying that
3712 this needs fixing because it is using the server account name instead of the account name.
3714 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3716 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3717 * src/maemo/modest-account-settings-dialog.c: (show_error),
3719 Use hildon_note_new_information() for informative and error messages,
3720 which seems to be expected for Maemo applications (no documentation that I know of
3721 says this). I am surprised that there is no distinction between info and error
3724 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3726 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3727 it is easy to find where this is used.
3729 * src/maemo/easysetup/modest-easysetup-wizard.c:
3730 (create_page_welcome), (create_page_account_details),
3731 (create_page_user_details), (create_page_complete_easysetup),
3732 (create_page_custom_incoming), (create_page_custom_outgoing),
3733 (create_page_complete_custom):
3734 * src/maemo/modest-account-settings-dialog.c:
3735 (create_page_account_details), (create_page_user_details),
3736 (create_page_incoming), (create_page_outgoing):
3737 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3738 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3739 (modest_connection_specific_smtp_edit_window_init):
3740 * src/maemo/modest-connection-specific-smtp-window.c:
3741 (modest_connection_specific_smtp_window_init):
3742 * src/maemo/modest-signature-editor-dialog.c:
3743 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3744 and scrolling policy as per the Email Application Layout Guide, if I have
3747 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3749 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3750 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3751 which were empty, because these vfuncs have been removed from TnyAccountStore.
3752 This fixes the build.
3754 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3756 * src/maemo/modest-main-window.c:
3757 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3758 showing/hiding it. Added TODO because it probably should not be NULL.
3759 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3760 because unnecessary g_warnings() make degugging difficult.
3762 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3764 * src/maemo/modest-msg-edit-window.c:
3765 (modest_msg_edit_window_select_color),
3766 (modest_msg_edit_window_select_background_color): 2 const corrections and
3767 moving 2 #endifs before closing brackets, to fix the build.
3769 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/easysetup/modest-easysetup-wizard.h:
3772 * src/maemo/easysetup/modest-easysetup-wizard.c:
3773 (modest_easysetup_wizard_dialog_finalize),
3774 (on_button_edit_advanced_settings), (create_page_complete_custom),
3775 (on_response), (create_account):
3776 Implement the Advanced Settings edit button, by saving the account information,
3777 for the Advanded Settings dialog to use directly from gconf, and removing it
3778 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3779 Bug #5533 in the projects.maemo.org bugzilla.
3781 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3783 * src/maemo/modest-msg-view-window.c:
3784 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3785 when opening a message window.
3787 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3789 * src/maemo/easysetup/modest-easysetup-wizard.c:
3790 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3793 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3794 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3795 gconf settings. I probably added more checks than necessary, but that is safer.
3797 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3798 variable to fix the build, but this seems to be used when it is still NULL.
3800 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3802 * src/modest-platform.h:
3803 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3804 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3805 * src/modest-main.c: Implement this function so we can avoid using
3806 maemo-specific API from cross-platform code.
3808 * src/modest-tny-account-store.c:
3809 (get_smtp_specific_transport_account_for_open_connection):
3810 * src/modest-ui-actions.c: (check_for_connection),
3811 (modest_ui_actions_on_item_not_found):
3812 Use modest_platform_connect_and_wait() and put #idefs around other
3813 maemo-specific code, because only maemo currently has a way to
3814 identify connection names.
3816 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3818 * src/modest-tny-account-store.h:
3819 * src/modest-tny-account-store.c:
3820 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3821 the connection-specific SMTP server settings in the configuration.
3823 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3825 * src/maemo/modest-main-window.c: (on_connection_changed),
3827 * src/modest-main.c: (main), (start_ui), (send_mail):
3828 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3829 that is what is intended.
3831 * src/modest-ui-actions.c: (action_send), (action_receive),
3832 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3833 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3834 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3835 SMTP server is used when it is specified.
3837 (modest_ui_actions_on_send_receive):
3838 Check that a connection is open before proceeding.
3839 Receive and then send, instead of vice-versa, as per the specification.
3841 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3843 * src/modest-mail-operation.c:
3844 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3845 though I guess it should be something other than NULL.
3847 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3849 * src/maemo/easysetup/modest-easysetup-wizard.c:
3850 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3851 combo twice, to avoid an g_warning and to make it visible again.
3852 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3853 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3854 (already intended) dereference when detaching, because we then recreate the menu.
3855 But I am not sure why the warning was happening, and it is possible that this is a memory
3858 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3860 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3861 and uri_parse_mailto() utility functions.
3862 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3864 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3866 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3868 * src/dbus_api/modest-dbus-api.h:
3869 * src/dbus_api/modest-dbus-callbacks.c:
3870 Use an idle callback to execute the modest code in the application's own thread.
3871 Remove the helloworld example method.
3872 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3873 parsed, and the open-message method is not implemented because this is not yet implemented in
3875 * libmodest-dbus-client/libmodest-dbus-client.c:
3876 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3877 (libmodest_dbus_client_open_message):
3878 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3880 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3881 body without crashing.
3883 * tests/dbus_api/Makefile.am:
3884 * tests/dbus_api/test_mail_to.c:
3885 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3887 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3889 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3890 Added file to fix the build. Sorry.
3892 * src/dbus_api/Makefile.am:
3893 * src/dbus_api/modest-dbus-api.h:
3894 * src/dbus_api/modest-dbus-callbacks.h:
3895 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3896 (modest_dbus_req_handler):
3897 Put constants in a separate header so it can be reused by the
3898 client library, without duplication
3900 * libmodest-dbus-client/Makefile.am:
3901 * libmodest-dbus-client/libmodest-dbus-client.c:
3902 (libmodest_dbus_client_call_helloworld),
3903 (libmodfest_dbus_client_send_mail),
3904 (libmodfest_dbus_client_mailto),
3905 (libmodfest_dbus_client_open_message):
3906 * libmodest-dbus-client/libmodest-dbus-client.h:
3907 (Partly) Implement a send_mail D-Bus method.
3909 * tests/dbus_api/Makefile.am:
3910 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3911 the send_email D-Bus method.
3913 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3917 * libmodest-dbus-client/Makefile.am:
3918 * libmodest-dbus-client/libmodest-dbus-client.c:
3919 * libmodest-dbus-client/libmodest-dbus-client.h:
3920 * tests/dbus_api/Makefile.am:
3921 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3922 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3924 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3926 * src/maemo/easysetup/modest-easysetup-wizard.c:
3927 (create_page_account_details):
3928 * src/maemo/modest-account-settings-dialog.c:
3929 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3930 widgets, because this might not be the default in future versions of the Maemo GTK+.
3931 However, I can not not get capitalization to work even in a simple test case.
3933 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3935 * src/maemo/easysetup/modest-easysetup-wizard.c:
3936 (create_page_custom_incoming), (create_page_custom_outgoing):
3937 * src/maemo/modest-account-settings-dialog.c:
3938 (create_page_account_details), (create_page_incoming),
3939 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3940 instead of using gtk_check_button_with_label(), so they are aligned like the other
3941 widgets, as per the UI spec.
3943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3945 * src/maemo/easysetup/modest-easysetup-wizard.c:
3946 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3947 * src/widgets/modest-validating-entry.c:
3948 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3949 Modest prefix instead of an EasySetup prefix.
3951 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3953 * src/widgets/modest-validating-entry.h:
3954 * src/widgets/modest-validating-entry.c: (on_insert_text),
3955 Added easysetup_validating_entry_set_max_func(), used to set a callback
3956 to call when the max number of characters is reached. GtkEntry has a max-length
3957 already but is silent about it.
3959 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3960 (create_page_account_details), (create_page_user_details),
3962 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3963 (create_page_account_details), (create_page_user_details),
3964 (create_page_outgoing):
3965 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3966 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3967 the UI spec, when the user tries to enter more than the max number of characters.
3969 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3971 * src/maemo/easysetup/modest-easysetup-wizard.c:
3972 (create_page_user_details), (create_page_custom_incoming),
3973 (create_page_custom_outgoing):
3974 * src/maemo/modest-account-settings-dialog.c:
3975 (create_page_user_details), (create_page_incoming),
3976 (create_page_outgoing):
3977 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3978 (modest_connection_specific_smtp_edit_window_init):
3979 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3980 not appropriate. Bad Maemo-specific defaults!.
3982 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3985 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3986 (modest_signature_editor_dialog_set_settings):
3987 Disable the label and textview when the checkbox is disabled, and use the
3988 specified (UI spec) default signature text.
3990 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3992 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3993 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3995 * src/modest-defs.h:
3996 * src/modest-account-mgr-helpers.h:
3997 * src/modest-account-mgr-helpers.c:
3998 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4000 * src/maemo/Makefile.am:
4001 * src/maemo/modest-signature-editor-dialog.c:
4002 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4005 * src/maemo/modest-account-settings-dialog.h:
4006 * src/maemo/modest-account-settings-dialog.c:
4007 (modest_account_settings_dialog_finalize), (on_button_signature),
4008 (save_configuration): Use the new dialog when the Edit button is pressed, and
4009 save the changes if necessary, as per the UI spec.
4011 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4013 * src/maemo/Makefile.am:
4014 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4015 based on maemo-develoers email from Dirk.
4017 * src/maemo/easysetup/modest-easysetup-wizard.c:
4018 (create_page_welcome), (create_page_account_details),
4019 (create_page_user_details), (create_page_complete_easysetup),
4020 (create_page_custom_incoming), (create_page_custom_outgoing),
4021 (create_page_complete_custom),
4022 (modest_easysetup_wizard_dialog_init):
4023 * src/maemo/modest-account-settings-dialog.c:
4024 (create_page_account_details), (create_page_user_details),
4025 (create_page_incoming), (create_page_outgoing),
4026 (modest_account_settings_dialog_init):
4027 * src/maemo/modest-connection-specific-smtp-window.c:
4028 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4030 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4032 * src/maemo/easysetup/modest-easysetup-wizard.c:
4033 (create_page_account_details), (create_page_custom_outgoing),
4034 (create_page_complete_custom):
4035 * src/maemo/modest-account-settings-dialog.c:
4036 (create_page_user_details), (create_page_incoming),
4037 (create_page_outgoing):
4038 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4039 (modest_connection_specific_smtp_edit_window_init):
4040 Use the correct (UI spec) port min/max, and use horizontal separators,
4043 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4045 * src/maemo/easysetup/modest-easysetup-wizard.c:
4046 (set_default_custom_servernames):
4047 * src/maemo/modest-account-settings-dialog.c:
4048 (create_page_incoming), (on_combo_outgoing_security_changed),
4049 (on_combo_incoming_security_changed), (create_page_outgoing),
4050 (modest_account_settings_dialog_set_account_name),
4051 (save_configuration):
4052 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4053 (on_combo_security_changed),
4054 (modest_connection_specific_smtp_edit_window_init),
4055 (modest_connection_specific_smtp_edit_window_set_connection),
4056 (modest_connection_specific_smtp_edit_window_get_settings):
4057 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4060 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4063 * src/maemo/easysetup/modest-easysetup-wizard.c:
4064 (create_page_custom_outgoing), (create_page_complete_custom):
4065 * src/maemo/modest-account-settings-dialog.c:
4066 (create_page_user_details), (create_page_outgoing):
4067 * src/maemo/modest-account-view-window.c: (button_box_new):
4068 Use changed logical IDs as per the most recent UI spec:
4069 mcen_bd_emailsetup_edit -> mcen_bd_edit
4070 mcen_bd_emailsetup_delete -> mcen_bd_delete
4071 mcen_bd_emailsetup_close -> mcen_bd_close
4073 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4077 * src/dbus_api/Makefile.am:
4078 * src/dbus_api/modest-dbus-callbacks.c:
4079 * src/dbus_api/modest-dbus-callbacks.h:
4080 * src/maemo/modest-platform.c: (modest_platform_init):
4081 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4083 * tests/Makefile.am:
4084 * tests/dbus_api/Makefile.am:
4085 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4087 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4089 * src/maemo/modest-account-settings-dialog.c:
4090 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4091 Removed unnecessary includes.
4093 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4095 * src/maemo/easysetup/modest-easysetup-wizard.c:
4096 * src/maemo/modest-account-settings-dialog.c:
4097 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4098 * src/widgets/Makefile.am:
4099 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4100 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4101 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4102 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4103 * src/widgets/modest-secureauth-combo-box.c:
4104 * src/widgets/modest-secureauth-combo-box.h:
4105 * src/widgets/modest-serversecurity-combo-box.c:
4106 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4107 made the GObject names more consistent with the rest of the Modest code.
4109 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4111 * src/maemo/easysetup/Makefile.am:
4112 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4113 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4114 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4115 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4116 * src/maemo/easysetup/modest-easysetup-wizard.c:
4117 * src/maemo/easysetup/modest-validating-entry.c:
4118 * src/maemo/easysetup/modest-validating-entry.h:
4119 * src/maemo/modest-account-settings-dialog.c:
4120 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4121 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4122 widgets/ because they are used outside of easysetup too. After checking in,
4123 svn will allow me to rename them too.
4125 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4127 * src/gnome/modest-msg-edit-window.c:
4128 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4129 linker error, to fix the build on the GNOME platform.
4130 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4131 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4132 ifdefed out to avoid a warning.
4134 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4136 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4137 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4138 some alternative for GTK+ 2.6.
4140 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4142 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4144 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4145 specified for EmailAccountsDialog in UI spec.
4147 * src/maemo/easysetup/modest-easysetup-wizard.c:
4148 * src/maemo/easysetup/modest-easysetup-wizard.h:
4149 * src/maemo/modest-account-settings-dialog.c:
4150 * src/maemo/modest-account-settings-dialog.h:
4151 Reuse a member window widget for the connection-specific SMTP server accounts,
4152 so we can tell it to create/save the accounts only if we actually save changes.
4154 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4155 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4156 (modest_connection_specific_smtp_edit_window_get_settings):
4157 Return a struct instance for temporarily remembering the entered data.
4159 * src/maemo/modest-connection-specific-smtp-window.h:
4160 * src/maemo/modest-connection-specific-smtp-window.c:
4161 (modest_connection_specific_smtp_window_finalize),
4162 (modest_connection_specific_smtp_window_fill_with_connections),
4164 (modest_connection_specific_smtp_window_save_server_accounts),
4165 (update_model_server_names): Do not actually save data until asked,
4166 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4168 (on_selection_changed),
4169 (modest_connection_specific_smtp_window_init): Disable the edit
4170 button when nothing is selected.
4172 * src/modest-account-mgr-helpers.c:
4173 * src/modest-account-mgr-helpers.h:
4174 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4177 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4179 * src/modest-account-mgr-helpers.h:
4180 * src/modest-account-mgr-helpers.c:
4181 (modest_account_mgr_get_unused_account_name),
4182 (modest_account_mgr_get_unused_account_display_name): Added these
4183 utility functions, to avoid code duplication.
4185 * src/maemo/easysetup/modest-easysetup-wizard.c:
4186 (create_page_account_details), (create_account):
4187 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4188 (on_combo_security_changed),
4189 (modest_connection_specific_smtp_edit_window_init),
4190 (modest_connection_specific_smtp_edit_window_save_settings):
4191 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4192 * src/maemo/modest-connection-specific-smtp-window.c:
4193 (modest_connection_specific_smtp_window_finalize),
4194 (modest_connection_specific_smtp_window_fill_with_connections),
4195 (on_button_edit), (modest_connection_specific_smtp_window_init):
4196 * src/maemo/modest-connection-specific-smtp-window.h:
4197 Implementing saving of connection-specific server accounts.
4199 But I need to refactor this so we can save the data for each
4200 possible connection-specific account and only actually create the server accounts
4201 when the easysetup finished, or the OK button is pressed on the account settings
4204 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4206 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4207 (on_combo_security_changed):
4208 (modest_connection_specific_smtp_edit_window_init):
4209 Auto-fill the port number as in the account settings.
4211 (modest_connection_specific_smtp_edit_window_set_connection):
4212 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4213 * src/maemo/modest-connection-specific-smtp-window.c:
4214 (fill_with_connections), (on_button_edit),
4215 (modest_connection_specific_smtp_window_init):
4216 Turn the edit window into a dialog to simplify the code, and
4217 set a WM hint as in a GtkDialog, because only a popup can be on top of
4218 another window in Maemo, and popups usually have no WM decoration.
4220 * src/modest-defs.h:
4221 * src/modest-account-mgr-helpers.c:
4222 (modest_account_mgr_set_connection_specific_smtp),
4223 (modest_account_mgr_remove_connection_specific_smtp),
4224 (modest_account_mgr_get_connection_specific_smtp):
4225 * src/modest-account-mgr-helpers.h: Some functions to write the
4226 connection-specific SMTP server information. Not yet used.
4229 * src/widgets/modest-folder-view.c: (text_cell_data):
4230 Fix a warning about an uninitialized variable.
4231 (on_configuration_key_changed): Put an #ifdef around the use
4232 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4234 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4236 * src/maemo/modest-account-settings-dialog.h:
4237 * src/maemo/modest-account-settings-dialog.c:
4238 Added connect_for_modified() utility function to mark the new modified boolean.
4240 (create_page_account_details), (create_page_user_details),
4241 (create_page_incoming), (create_page_outgoing), (on_response),
4242 (modest_account_settings_dialog_init),
4243 (modest_account_settings_dialog_set_account_name):
4244 Only warn about unsaved changes when there are actually unsaved changes.
4246 * src/modest-account-mgr-helpers.c:
4247 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4248 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4249 to get the data from there in future.
4251 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4253 * src/modest-defs.h:
4255 * src/modest-account-mgr-helpers.h:
4256 * src/modest-account-mgr-helpers.c:
4257 Store the security account setting in a single conf key instead of using
4258 the options list, so that the list is left for just the to-be-removed camel hack,
4259 and because gconf_client_set_list() is failing for some reason.
4261 * src/modest-account-mgr.c:
4262 (modest_account_mgr_add_server_account):
4263 * src/maemo/modest-account-settings-dialog.c:
4264 (modest_account_settings_dialog_set_account_name),
4265 (save_configuration): Use the renamed functions.
4268 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4270 * src/widgets/Makefile.am:
4271 * src/widgets/modest-limit-retrieve-combo-box.c:
4272 * src/widgets/modest-limit-retrieve-combo-box.h:
4273 * src/widgets/modest-retrieve-combo-box.c:
4274 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4275 the account settings dialog.
4277 * src/modest-defs.h:
4278 * src/modest-account-mgr-helpers.h:
4279 * src/modest-account-mgr-helpers.c:
4280 (modest_server_account_get_option_secure_auth),
4281 (modest_server_account_set_option_secure_auth):
4282 * src/modest-account-mgr.c:
4283 (modest_account_mgr_add_server_account):
4284 Use the existing AUTH_MECH conf key for the secure-auth setting,
4285 instead of putting it in the list options, because this was actually used already.
4287 * src/maemo/modest-account-settings-dialog.c:
4288 (create_page_account_details),
4289 (modest_account_settings_dialog_set_account_name),
4290 (save_configuration):
4291 * src/maemo/modest-account-settings-dialog.h:
4292 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4293 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4295 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4297 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4298 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4299 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4301 * src/modest-defs.h:
4302 * src/maemo/modest-account-settings-dialog.c:
4303 (create_page_incoming), (on_combo_outgoing_security_changed),
4304 (on_combo_incoming_security_changed), (create_page_outgoing),
4305 (modest_account_settings_dialog_set_account_name),
4306 (save_configuration): Load/Save the port number, and change it when the
4307 security combo changes, to suitable defaults.
4309 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4311 * src/modest-account-mgr.c:
4312 (modest_account_mgr_add_server_account): Set the security and secure-auth
4313 options, and add a comment saying that the other camel-specific options should be
4316 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4318 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4320 * src/modest-tny-account-store.c: (account_list_free),
4321 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4322 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4325 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4327 * src/modest-protocol-info.c:
4328 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4329 is required by our UI spec. Maybe something in our implementation will use this eventually.
4330 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4331 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4332 instead of the previous 0 placeholder.
4334 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4335 secure-auth settings.
4336 * src/modest-account-mgr-helpers.h:
4337 * src/modest-account-mgr-helpers.c:
4338 (modest_server_account_data_get_option_secure_auth),
4339 (modest_server_account_set_option_secure_auth),
4340 (modest_server_account_data_get_option_security),
4341 (modest_server_account_set_option_security): Added this API for getting and setting the security
4342 and secure-auth settings.
4344 * src/maemo/modest-account-settings-dialog.h:
4345 * src/maemo/modest-account-settings-dialog.c:
4346 (modest_account_settings_dialog_finalize), (check_data),
4347 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4348 about changing titles.
4349 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4350 (save_configuration): Save the security and secure-auth settings.
4352 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4353 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4355 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4357 * src/modest-defs.h:
4358 * src/modest-account-mgr.c:
4359 (modest_account_mgr_add_server_account):
4360 Added and used defines for the options key and value pair strings,
4361 that are used so far, though they do not seem to correspond to anything in our
4362 UI specs or ModestProtocol enum.
4364 * src/modest-account-mgr-helpers.h:
4365 * src/modest-account-mgr-helpers.c:
4366 (compare_option_strings_for_name),
4367 (modest_server_account_data_get_option_value),
4368 (modest_server_account_data_get_option_bool),
4369 (modest_account_mgr_get_server_account_option):
4370 Added helper functions for parsing the options GSList.
4372 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4374 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4375 display name is based on the supplied account name.
4376 * src/modest-account-mgr.c:
4377 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4378 with an inefficient, but good-enough, implementation.
4380 * src/maemo/easysetup/modest-easysetup-wizard.c:
4381 (create_page_account_details), (on_before_next), (create_account):
4382 Check for existing display names rather than (non-user-visible) account names, and just
4383 create and set a unique account name at the end.
4385 * src/maemo/modest-account-settings-dialog.c:
4386 (modest_account_settings_dialog_init),
4387 (modest_account_settings_dialog_set_account_name),
4388 (create_page_incoming): Show the display name, instead of the account name.
4389 (on_response): Do some (not all) extra checks, as in the UI spec.
4390 (save_configuration): Save the display name if it was changed.
4392 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4394 * po/en_GB.po: Added needed logical ID and translation.
4395 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4396 (init_view): Made the is-default column clicking work.
4398 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4401 * src/maemo/easysetup/Makefile.am:
4402 * src/maemo/easysetup/modest-easysetup-wizard.c:
4403 (modest_easysetup_wizard_dialog_init):
4404 * src/maemo/easysetup/provider-data-test.keyfile:
4405 * src/maemo/easysetup/provider-data.keyfile:
4406 Moved the provider data file to the new modest-providers-data package and used it from there.
4408 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4410 * src/modest-local-folder-info.c:
4411 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4412 N_() was already used on the static strings, but this just marks it for translation without
4413 using the translation.
4415 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4417 * src/maemo/modest-account-settings-dialog.c:
4418 (create_page_incoming),
4419 (modest_account_settings_dialog_set_account_name):
4420 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4421 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4422 I will do this if nobody else gets there first.
4424 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4426 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4427 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4428 save the security stuff.
4430 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4432 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4433 Set the email address and user fullname, which I now see must be
4436 * src/maemo/modest-account-settings-dialog.h:
4437 * src/maemo/modest-account-settings-dialog.c:
4439 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4440 leave-on-server and authentication.
4441 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4444 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4447 * src/maemo/modest-account-settings-dialog.c:
4448 * src/maemo/modest-account-settings-dialog.h:
4449 Most (but not all) of the widgets are now present as specified by the UI spec.
4450 No changes are yet saved, and some details are not properly shown yet.
4452 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4454 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4456 * src/maemo/Makefile.am:
4457 * src/maemo/modest-account-settings-dialog.c:
4458 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4459 an existing account. Doesn't do much yet.
4461 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4462 Open the accounts settings dialog when Edit is clicked.
4464 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4466 * src/maemo/easysetup/Makefile.am:
4467 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4469 * src/maemo/easysetup/modest-easysetup-wizard.c:
4470 (modest_easysetup_wizard_dialog_init):
4471 Try to get the source directory from the build system,
4472 instead of hard-coding "./" into the source code, when opening our local
4473 copies of the configuration files.
4474 But this still fails when opening the wizard from the Accounts window,
4475 maybe because the working directory seems to change at runtime.
4476 So the wizard will fail the second time unless you copy the files into their
4477 proper locations - see the stdout warnings for the paths.
4479 (create_page_account_details),(on_before_next):
4480 Check for existing non-server accounts instead of server accounts,
4481 so the default account name is useful again, and to prevent trying to
4484 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4485 Show the wizard when New is clicked.
4487 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4488 (init_view): Show the column headers, and show the columns that are
4489 specified in the UI specs. However, something in Maemo's GTK+ prevents
4490 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4491 change the default account. This is despite unsetting the special properties.
4493 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4495 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4496 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4497 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4498 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4499 to make that clearer.
4500 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4502 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4504 * src/maemo/modest-account-view-window.c:
4505 (modest_account_view_window_init),
4506 (modest_account_view_window_new):
4507 Use the same buttons as specified in the
4508 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4509 the existing widgets, which never had a chance of working.
4510 Put the ModestAccountView treeview in a scrolled window.
4511 Do not repeat the initialization in both _init() and _new().
4513 * src/widgets/modest-account-view.c: (update_account_view):
4514 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4515 this widget and window shows no accounts.
4517 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4519 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4521 * src/maemo/easysetup/modest-easysetup-wizard.c:
4522 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4523 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4524 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4527 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4528 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4529 accounts exist yet, as in the UI spec.
4531 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4533 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4535 * src/maemo/Makefile.am:
4536 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4537 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4538 New window for editing connection-specific smtp details.
4539 Not fully implemented.
4541 * src/maemo/modest-connection-specific-smtp-window.c:
4542 (modest_connection_specific_smtp_window_finalize) :
4543 unref the tree model.
4544 (on_button_edit): Show the edit window.
4546 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4548 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4551 * src/maemo/Makefile.am:
4552 * src/maemo/modest-connection-specific-smtp-window.c:
4553 * src/maemo/modest-connection-specific-smtp-window.h:
4554 New window for showing the list of connections, for connection-specific
4555 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4556 * src/maemo/easysetup/modest-easysetup-wizard.c:
4557 (create_page_custom_outgoing): Show the new window when the button is clicked.
4559 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4561 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4562 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4563 * src/maemo/modest-msg-edit-window.c:
4564 (modest_msg_edit_window_insert_image):
4565 * src/modest-conf.c: (modest_conf_key_escape):
4566 * src/modest-mail-operation.c:
4567 (modest_mail_operation_send_new_mail):
4568 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4569 (modest_ui_actions_on_new_account):
4570 * src/widgets/modest-attachment-view.c: (update_filename_request):
4571 * src/widgets/modest-mail-header-view.c:
4572 Corrected warnings that were breaking the build, by commenting out unused variables,
4573 and a function, and by including a header.
4575 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4577 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4578 so we can #ifdef around platform-specific code when necessary.
4579 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4580 to allow this to build for the GNOME platform too.
4582 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4584 * src/maemo/easysetup/modest-easysetup-wizard.c:
4585 Added util_increment_name() and used it in create_page_account_details()
4586 to make sure that the default account name is always a new name.
4588 (modest_easysetup_wizard_dialog_init),
4589 (set_default_custom_servernames): Some minor memory management fixes.
4591 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4595 * src/modest-runtime.c: (init_i18n): Restored the translation
4596 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4597 are defined in config.h, and the translations are installed.
4599 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4600 is defined for translation.
4602 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4604 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4606 * src/maemo/easysetup/modest-easysetup-wizard.c:
4607 (modest_easysetup_wizard_dialog_init):
4608 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4609 Use realistic paths (though they should use $prefix generically) to the
4610 mcc_mapping and provider-data.keyfile files which might work when they
4611 are installed by the future version of the operator-wizard package,
4612 and then fallback to paths in our source code, with an explanatory
4615 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4619 * src/maemo/Makefile.am:
4620 * src/maemo/easysetup/: Added files from the previously-exernal
4621 osso-modest-easysetup.
4622 * src/maemo/modest-main-window-ui.h:
4623 * src/modest-ui-actions.c:
4624 * src/modest-ui-actions.h:
4625 Added modest_ui_actions_on_new_account() as a signal handler for the
4626 New Account menu item. It shows the easysetup wizard.
4627 * po/en_GB.po: Added additional needed logical IDs and translations.