1 2007-07-27 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
4 Reverted my last commit. I was able to fix the build by doing
5 apt-get install wpeditor0 (replacing other wpeditor packages) and
6 an explicit apt-get install wpeditor-dev to upgrade the -dev
9 2007-07-27 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
12 Commented out the use of wp_text_buffer_replace_image()
13 because it does not exist, to break the build. Added a TODO for it.
15 2007-07-26 Murray Cumming <murrayc@murrayc.com>
17 * src/modest-tny-account-store.c: (recreate_all_accounts):
18 Recreate them even if they were NULL before. I guess something
19 else was already creating them before, or this would never
21 (modest_tny_account_store_get_server_account): Make sure that
22 the tny accounts have been created before trying to find one.
23 This allows libmodest_dbus_client_compose_mail() to work
24 when the UI is not yet visible.
25 This is probably useful in other cases too.
27 (get_password): When the password is wrong after it is entered
28 in the protected password dialog, show an info banner (in an
29 idle handler) before showing the protected password dialog
32 2007-07-26 Murray Cumming <murrayc@murrayc.com>
34 * src/modest-ui-actions.h:
35 * src/modest-ui-actions.c: Added
36 modest_do_refresh_current_folder() containing some code from
37 modest_ui_actions_on_send_receive().
38 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
39 Call modest_do_refresh_current_folder() before refreshing the
40 requested account, as in modest_ui_actions_on_send_receive().
41 This is strange, but seems to be necessary to show new mails.
42 Now new emails are finally visible in the UI when downloaded
43 via the automatic update interval, fixing bug NB#57458.
44 This also works because bug NB#57458 has been fixed somehow.
46 2007-07-26 Murray Cumming <murrayc@murrayc.com>
48 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
49 printf more details when we get unhandled D-Bus methods, because
52 * src/modest-mail-operation.c: (update_account_thread):
53 Comment out the tny_camel_pop_store_account_reconnect(), because this
54 is apparently no longer needed, and it did not work before anyway.
55 See the comment in the code.
57 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
58 by checking the header flags. This fixes projects.maemo.org bug
61 2007-07-25 Murray Cumming <murrayc@murrayc.com>
63 * src/maemo/modest-maemo-utils.h:
64 * src/maemo/modest-maemo-utils.c: Added
65 modest_maemo_show_information_note_in_main_context_and_forget().
66 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
67 Use the new function to show simple error dialogs in the main
68 context, though question dialogs are still in the current context,
69 which is unfortunately usually not the main context. This should
72 2007-07-25 Murray Cumming <murrayc@murrayc.com>
74 * src/modest-tny-account-store.c: (get_password):
75 Never save the entered username and password in gconf,
76 because the UI spec says we should not. This helps
77 slightly with projects.maemo.org bug NB#63671.
79 2007-07-25 Murray Cumming <murrayc@murrayc.com>
81 * src/widgets/modest-msg-edit-window.h:
82 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
83 Moved some code here to make it simpler.
84 (modest_msg_edit_window_attach_file_one): Renamed from
85 modest_msg_edit_window_attach_file_interactive().
86 (modest_msg_edit_window_offer_attach_file): Renamed from
87 modest_msg_edit_window_attach_file() and used
88 modest_msg_edit_window_attach_file_one() instead of
89 copy/pasting the code. The old code for one was not using
90 GnomeVFS. This allows use of smb:// URLs when using send-as
91 from external applications, fixing bug NB#63741.
93 (modest_msg_edit_window_insert_image),
94 (modest_msg_edit_window_add_attachment_clicked):
95 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
96 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
97 Adapted to the new function names.
99 2007-07-25 Murray Cumming <murrayc@murrayc.com>
101 (modest_platform_set_update_interval): Set the alarm recurrence
102 fields so that auto-update does not just happen the first time.
103 This should have fixed projects.maemo.org bug NB#63938.
105 When this happens you can see a printf when the D-Bus method is
107 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
109 However, I do not actually seem to get new POP messages even when
110 clicking the refresh button manually. A restart gets them.
111 This might be a problem in today's tinymail only.
113 2007-07-24 Murray Cumming <murrayc@murrayc.com>
115 * src/maemo/modest-maemo-global-settings-dialog.c:
116 (current_connection):
117 Avoid a crash (probably only in scratchbox) when strcmp()ing a
118 NULL when closing the dialog.
120 2007-07-24 Murray Cumming <murrayc@murrayc.com>
122 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
123 Remove the hacky send/receive that didn't work, and instead
124 refilter the treemodel to make the deleted email really vanish from
125 the UI (though the delete-from-menu code does has commented out
126 the code that does that). This fixes projects.maemo.org bug
129 2007-07-24 Murray Cumming <murrayc@murrayc.com>
131 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
132 Try a couple of tricks to force the treeview to update (
133 poke the folder, and do a send/receive refresh), but the deleted
134 email still appears with a strike-through instead of really being
137 2007-07-23 Murray Cumming <murrayc@murrayc.com>
139 * src/dbus_api/modest-dbus-callbacks.c:
140 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
141 because their ID is not human-readable (see the comment about
142 improvements needed to the osso-email-interface API) and
143 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
145 2007-07-23 Murray Cumming <murrayc@murrayc.com>
147 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
148 (add_folders_to_list), (on_dbus_method_get_folders),
149 (modest_dbus_req_filter):
150 * src/maemo/modest-maemo-utils.c:
151 (on_camel_account_get_supported_secure_authentication):
152 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
153 (on_header_view_focus_in):
154 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
155 * src/modest-formatter.c: (modest_formatter_create_body_part):
156 * src/modest-mail-operation.c: (recurse_folders),
157 (update_account_thread), (get_msgs_full_thread),
158 (modest_mail_operation_get_msgs_full),
159 (modest_mail_operation_xfer_msgs):
160 * src/modest-search.c: (search_mime_part_and_child_parts),
161 (modest_search_account), (modest_search_all_accounts):
162 * src/modest-tny-account.c:
163 (modest_tny_account_get_special_folder), (recurse_folders):
164 * src/modest-tny-local-folders-account.c:
165 (modest_tny_local_folders_account_query_passes):
166 * src/modest-tny-msg.c: (copy_mime_part),
167 (modest_tny_msg_find_body_part_from_mime_part):
168 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
169 (modest_tny_send_queue_try_to_send):
170 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
171 (_modest_ui_actions_open), (download_uncached_messages),
172 (reply_forward), (modest_ui_actions_on_copy),
173 (modest_ui_actions_on_details), (has_retrieved_msgs),
174 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
176 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
177 (_selected_msg_marked_as), (_msg_download_completed),
178 (_selected_msg_sent_in_progress):
179 * src/widgets/modest-attachments-view.c:
180 (modest_attachments_view_set_message):
181 * src/widgets/modest-msg-view.c: (find_cid_image):
182 * tests/check_folder-transfer.c: (find_folders):
183 * tests/check_update-account.c: (func):
184 * tests/dbus_api/test_get_folders.c: (main):
185 Checked all uses of tny_iterator_get_current(), making sure
186 that the object is unreferenced (3 or 4 places did not),
187 and adding checks for NULL.
189 2007-07-23 Murray Cumming <murrayc@murrayc.com>
191 * src/dbus_api/modest-dbus-callbacks.c:
192 (on_idle_open_default_inbox): Make sure that the application UI is
194 * src/maemo/easysetup/modest-easysetup-wizard.c:
195 (on_entry_invalid_character): Show the word whitespace instead
196 of (null) in the banner when whitespace was entered.
197 (show_error): Add a comment that this does not work in
198 Maemo Bora, though we do not know why.
200 2007-07-23 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-tny-account.c:
203 (modest_tny_account_get_special_folder): Use an if instead of
204 an assert for when the parent account name is NULL, because this
205 might be causing a crash in projects.maemo.org bug 63192.
206 * src/modest-mail-operation.c:
207 (modest_mail_operation_send_new_mail_cb),
208 (modest_mail_operation_remove_folder): unref the folder that is
209 returned from modest_tny_account_get_special_folder().
211 2007-07-23 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-ui-actions.c:
214 (modest_ui_actions_on_password_requested):
215 Show mail_ib_login_cancelled info banner when the user cancels
216 the protected password dialog, to fix projects.maemo.org
219 2007-07-23 Murray Cumming <murrayc@murrayc.com>
221 * src/maemo/modest-account-settings-dialog.c:
222 (create_page_outgoing): Put this page in a GtkScrolledWindow,
223 matching the UI mock-up in the UI spec, and allowing access
224 to all widgets even when the on-screen keyboard is active.
226 2007-07-23 Murray Cumming <murrayc@murrayc.com>
228 Reverted this previous commit from Johannes,
229 because the scrollbars are always visible and because
230 I think we only need it on onepage of the account
231 settings, not the account wizard.
232 (I wrote the wrong instructions in the bug.)
234 * src/maemo/easysetup/modest-easysetup-wizard.c:
235 Added scrollbars to account wizard dialog.
236 Fixed projects.maemo.org NB #62744
238 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
240 * src/maemo/easysetup/modest-easysetup-wizard.c:
241 (create_page_user_details):
242 Use auto-cap for name (projects.maemo.org NB#63716)
243 * src/widgets/modest-account-view.c: (on_account_busy_changed):
245 2007-07-22 Armin Burgmeier <armin@openismus.com>
247 * src/maemo/modest-ui-actions.c: Use current account instead of
248 default account for creating viewer windows, so that the viewer
249 window knows to which account the viewed message belongs.
251 * src/maemo/modest-msg-view-window.c: Destroy the window when the
252 corresponding account is deleted. This fixes projects.maemo.org bug
255 2007-07-18 Armin Burgmeier <armin@openismus.com>
257 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
258 the dialog close after entering an invalid port number and clicking
259 OK. This fixes projects.maemo.org bug NB#63602.
261 2007-07-18 Armin Burgmeier <armin@openismus.com>
263 * src/modest-tny-account-store.c:
264 (get_server_accounts): Set parent modest account name for each
265 connection-specific transport account so that special folders of such
266 an account can be looked up. This fixes a crash when changing account
267 settings. This might also be related to projects.maemo.org bug
270 2007-07-16 Armin Burgmeier <armin@openismus.com>
272 * src/modest-ui-actions.c: Added a button to create a folder to the
273 move-to dialog. This fixes projects.maemo.org bug NB#.
275 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
277 * src/maemo/easysetup/modest-easysetup-wizard.c:
278 Added scrollbars to account wizard dialog.
279 Fixed projects.maemo.org NB #62744
281 2007-07-16 Murray Cumming <murrayc@murrayc.com>
283 * src/widgets/modest-msg-view.h:
284 * src/widgets/modest-msg-view.c:
285 Added modest_msg_view_get_message_is_empty() but this needs
287 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
288 Check if there is any text in the message yet.
289 But this needs to be implemented properly.
290 (modest_msg_edit_window_toggle_find_toolbar):
291 * src/maemo/modest-msg-view-window.c:
292 (modest_msg_view_window_toggle_find_toolbar):
293 Show a banner warning if there is no text to search, when
294 trying to start a search. This partially fixes
295 projects.maemo.org bug NB#62350.
297 2007-07-13 Murray Cumming <murrayc@murrayc.com>
299 * src/modest-mail-operation.c: (update_account_thread):
300 Initialized num_new_headers to fix the build.
302 2007-07-13 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
305 Ignore modest accounts whose server accounts don't exist in gconf.
306 This prevents us trying to create TnyAccount instances for those
307 server accounts when the server account has been removed from gconf,
308 but the parent modest account has not yet been removed from modest.
309 I don't know why this is only noticeable now. It was probably just
310 a harmeless g_warning() anyway.
312 2007-07-13 Murray Cumming <murrayc@murrayc.com>
314 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
315 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
317 2007-07-12 Armin Burgmeier <armin@openismus.com>
319 * src/maemo/modest-main-window.c: Make default account appear bold
320 in view, tools/send & receive and toolbar/send & receive SCM menus.
321 This fixes projects.maemo.org bug NB#59010.
323 2007-07-12 Murray Cumming <murrayc@murrayc.com>
325 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
326 Add a short-cut, by checking if the folder store is an account.
327 This ensures that the Sort menu item and toolbar is dimmed for
328 the local-folders account root item, fixing
329 projects.maemo.org bug NB#62545.
331 2007-07-12 Murray Cumming <murrayc@murrayc.com>
333 * src/modest-tny-account-store.c: (get_password):
334 Show the password dialog (via the signal) only in the mainloop, via
335 an idle handler that we wait for. This could theoretically prevent
336 hangs, though I worry that it could introduce some too.
338 2007-07-12 Murray Cumming <murrayc@murrayc.com>
340 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
341 * src/maemo/modest-platform.c:
342 (modest_platform_connect_and_wait):
343 Take a TnyAccount* parameter and try to set it to online
344 (a TnyCamel-only API), because tinymail sets accounts to offline
345 when the user cancels a password dialog, and doesn't ask again until
346 it has been set to online.
347 However, this is commented out because it causes a hang now.
349 (modest_platform_connect_and_wait_if_network_account):
350 * src/modest-mail-operation.c:
351 (modest_mail_operation_update_account):
352 * src/modest-platform.h:
353 * src/modest-ui-actions.c: (_modest_ui_actions_open),
354 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
356 2007-07-12 Armin Burgmeier <armin@openismus.com>
358 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
360 * src/modest-mail-operation.c:
361 * src/modest-ui-actions.c: Check for already existing folder before
362 querying the server, show error message from camel if the request
363 still fails. This fixes projects.maemo.org bug NB#58701.
365 2007-07-12 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-tny-account-store.h:
368 * src/modest-tny-account-store.c:
369 Added modest_tny_account_store_forget_password_in_memory(),
370 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
371 when creating a new account, so that new passwords will be used, instead of
372 us thinking that it's a second request as a result of a failed password again.
374 2007-07-12 Murray Cumming <murrayc@murrayc.com>
376 * src/dbus_api/modest-dbus-callbacks.c:
377 (on_idle_open_message): If the message is in drafts then open it
378 in an edit window instead of a view window. This fixes
379 projects.maemo.org bug NB#63005.
381 2007-07-12 Murray Cumming <murrayc@murrayc.com>
383 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
384 Avoided a harmless g_warning().
386 2007-07-12 Murray Cumming <murrayc@murrayc.com>
388 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
389 Pass the modest account name, not the TnyAccount display name to
390 modest_msg_view_window_new() so that the reply feature works,
391 fixing projects.maemo.org bug NB#62892.
393 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
394 (modest_msg_view_window_new_with_header_model):
395 * src/maemo/modest-msg-view-window.c:
396 (modest_msg_view_window_new_with_header_model),
397 (modest_msg_view_window_new):
398 * src/modest-ui-actions.c: (reply_forward):
399 * src/widgets/modest-msg-view-window.h:
400 * src/widgets/modest-window.c: (modest_window_set_active_account):
401 Rename an account parameter to modest_account_name to make this clearer.
403 2007-07-11 Murray Cumming <murrayc@murrayc.com>
405 * src/modest-ui-actions.h:
406 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
407 modest_do_message_delete().
408 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
409 Call modest_do_message_delete(), hoping that this would cause messages
410 to be really deleted from search instead of just marked with strike through.
411 Does not seem to help.
413 2007-07-11 Armin Burgmeier <armin@openismus.com>
415 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
416 priv->reselect to FALSE prior to calling
417 modest_folder_view_select_first_inbox_or_local() to prevent endless
418 recursion and thus a crash on startup.
420 2007-07-11 Armin Burgmeier <armin@openismus.com>
422 * src/maemo/modest-account-settings-dialog.h: Include
423 <gtk/gtknotebook.h> to fix the build (at least for me).
425 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
426 Use "New FolderN" as default suggested name if "New folder" already
427 exists, with N being the first free number, though never exceed "New
428 folder99" in which case we just fall back to "New Folder" even though
429 it already exists. This fixes projects.maemo.org bug NB#58663.
431 2007-07-11 Murray Cumming <murrayc@murrayc.com>
433 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
434 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
435 projects.maemo.org bug NB#62778.
437 2007-07-11 Murray Cumming <murrayc@murrayc.com>
439 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
440 Ignore the wrong (for now) secure-smtp setting in the presets -
441 just default to requiring secure authentication for SMTP, because
444 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
446 * src/widgets/modest-folder-view.c: (filter_row)
447 Do not show drafts folder (see UI specs)
449 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
451 * src/modest-ui-actions.c:
452 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
453 place and also not necessary.
455 * src/widgets/modest-folder-view.c: (filter_row)
456 Guess folder type and hide Sent & Outbox if necessary.
457 Fixed project.maemo.org NB#57328
459 2007-07-11 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-ui-actions.h:
462 * src/modest-ui-actions.c:
463 (modest_ui_actions_on_delete_message):
464 Move some code into a new
465 modest_ui_actions_refresh_message_window_after_delete()
466 function so we can use it from elsewhere.
468 * src/dbus_api/modest-dbus-callbacks.c:
469 (on_idle_delete_message), (on_delete_message): Used an idle
470 handler, as we do for the other D-Bus method handlers.
471 Call modest_ui_actions_refresh_message_window_after_delete()
472 if the deleted message was open in a window. This fixed
473 projects.maemo.org bug NB#62862.
475 2007-07-11 Murray Cumming <murrayc@murrayc.com>
477 * src/modest-main.c: (main): Only show the UI at the start if
478 the showui command line option was given. For instance,
479 run-standalone src/modest showui
480 Otherwise, we wait for the top_application D-Bus method to
481 be sent by hildon-desktop when the application is selected
483 This allows us to run without a UI when osso-global-search
484 uses our D-Bus methods.
486 2007-07-11 Murray Cumming <murrayc@murrayc.com>
488 * src/dbus_api/modest-dbus-api.h: Added a define for a
489 top-application D-Bus method.
490 * src/dbus_api/modest-dbus-callbacks.c:
491 (on_top_application),
492 (modest_dbus_req_handler): Handle the top-application D-Bus
493 method, which might be an undocumented D-Bus signal sent by
494 hildon-desktop when it starts the application from the menu.
495 But I am not sure and I need to test it on the device, because
496 my scratchbox does not have the application in the menu now.
497 This method shows the main window, so that it can be invisible
498 when started, for instance, just for email searching from
501 * src/maemo/modest-main-window.c: (restore_settings),
502 (modest_main_window_new): Do not show the window immediately
503 upon creation. We show it later.
504 * src/modest-widget-memory.c: (save_settings_paned):
505 Try (unsuccessfully) to avoid saving the paned position when
506 it is not even visible.
507 (restore_settings_paned): Do not allow a silly paned position.
508 This seems necessary when not showing the window at first.
510 * tests/dbus_api/Makefile.am:
511 * tests/dbus_api/test_top_application.c: (main): Test for the
514 2007-07-10 Murray Cumming <murrayc@murrayc.com>
516 * src/modest-ui-dimming-rules.c:
517 (modest_ui_dimming_rules_on_new_msg),
518 (modest_ui_dimming_rules_on_reply_msg),
519 (modest_ui_dimming_rules_on_delete_msg),
520 (modest_ui_dimming_rules_on_details),
521 (modest_ui_dimming_rules_on_view_window_move_to),
522 (modest_ui_dimming_rules_on_view_previous),
523 (modest_ui_dimming_rules_on_view_next),
524 (_invalid_folder_for_purge): Added checks before
525 casting the window. This looks like an actual
526 logic error in _invalid_folder_for_purge(), because it
527 tries to use a ModestMainWindow as a message window.
529 2007-07-10 Murray Cumming <murrayc@murrayc.com>
531 * src/maemo/modest-account-settings-dialog.c:
532 (show_error): Use the same implementation as in
533 modest-easysetup-wizard.c:
534 (on_entry_invalid_character): The logical ID contains a %s.
535 Guessed what it should be.
536 (on_entry_max), (check_data), (on_response): Adapt to
537 changed show_error().
538 (create_page_account_details): Really call
539 modest_validating_entry_set_func() on the correct widgets.
540 * src/maemo/easysetup/modest-easysetup-wizard.c:
541 (on_entry_invalid_character): Fix the logical ID here too.
542 (create_page_account_details),
543 (create_page_user_details):
545 modest_validating_entry_set_func() on the correct widgets.
547 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
548 Do not try to use the account if it is NULL.
550 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
552 * src/modest-ui-actions.c: (create_move_to_dialog),
553 (modest_ui_actions_on_main_window_move_to),
554 (modest_ui_actions_on_msg_view_window_move_to):
555 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
556 (filter_row), (modest_folder_view_show_non_move_folders):
557 * src/widgets/modest-folder-view.h:
559 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
560 the Sent folder yet as it does not report the correct folder type.
562 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
564 * src/maemo/modest-msg-edit-window.c: (init_window):
567 2007-07-10 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
570 Take a parent widget instead of a parent window, and
571 implement this with hildon_banner_show_information() instead.
572 Non-Maemo builds can just ifdef that there.
573 This fixed projects.maemo.org bug NB#62766.
575 (on_entry_invalid_character): Use show_error() again instead
576 of using hildon directly, and use the _CS() macro to use the correct
578 (create_account), (check_for_supported_auth_methods), (on_entry_max):
579 Pass a widget instead od a window to show_error().
581 2007-07-10 Murray Cumming <murrayc@murrayc.com>
583 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
584 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
585 This allows us to show the server name in the error message, fixing
586 projects.maemo.org bug NB#62904.
587 Also, use the appropriate logical ID message for the account protocol.
589 2007-07-10 Murray Cumming <murrayc@murrayc.com>
591 * src/modest-tny-account-store.c: (on_idle_wrong_password):
592 A compilation fix, though the build wasn't broken for me.
594 2007-07-09 Murray Cumming <murrayc@murrayc.com>
596 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
597 Do not try to unref a NULL folder store, to avoid a runtime warning.
598 This seems to happen sometimes when changing accounts settings.
600 2007-07-09 Murray Cumming <murrayc@murrayc.com>
602 * src/modest-tny-account-store.c:
603 (modest_tny_account_store_instance_init),
604 (modest_tny_account_store_finalize),
605 (on_account_settings_hide), (on_idle_wrong_password):
606 Use a GHashTable to ensure that we only show one account settings
607 dialog per modest account. This avoids us having a dialog open for
608 both the store and transport accounts, or due to repeated get_password()
609 calls that shouldn't happen anyway.
611 2007-07-09 Murray Cumming <murrayc@murrayc.com>
613 * src/maemo/modest-maemo-utils.c: (on_hide),
614 (modest_maemo_show_dialog_and_forget): Handle the response, because
615 the window is not even hidden by default.
617 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
618 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
619 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
620 which seems to prevent some modality problems.
622 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
623 Ignore user cancellation errors.
625 * src/modest-account-mgr-helpers.h:
626 * src/modest-account-mgr-helpers.c:
627 Added modest_server_account_get_password() and
628 modest_server_account_get_has_password() to avoid direct use of
631 * src/maemo/modest-account-settings-dialog.h:
632 * src/maemo/modest-account-settings-dialog.c:
633 (modest_account_settings_dialog_init): Store the notebook so we can
635 Added modest_account_settings_dialog_switch_to_user_info().
637 * src/modest-tny-account-store.c:
638 (get_password): When the password in the account settings is wrong (we think),
639 show the relevant page of the account settings dialog, in the mainloop.
640 However, we currently get many of these at once because cancel does not
642 (forget_password): Do not forget the password
643 from the account settings, because this causes side-effects when
644 tinymail seems to call it at strange time, maybe because of how we
645 are cancelling get_password().
646 (modest_tny_account_store_alert): Ignore user cancellations.
648 2007-07-09 Murray Cumming <murrayc@murrayc.com>
650 * src/maemo/modest-maemo-utils.h:
651 * src/maemo/modest-maemo-utils.c:
652 Added modest_maemo_show_information_note_and_forget() for use instead of
653 gtk_dialog_run() when the response is not needed, to avoid an extra
654 mainloop which could cause a hang.
656 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
657 Use the logical IDs for the error message, though they are not
658 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
659 because gtk_dialog_run() caused a hang here (the window did not close).
660 This fixes projects.maemo.org bug NB#62646.
662 2007-07-09 Murray Cumming <murrayc@murrayc.com>
664 * src/modest-account-mgr-helpers.h:
665 * src/modest-account-mgr-helpers.c:
666 Added modest_account_mgr_get_store_protocol().
668 * src/maemo/modest-account-view-window.c:
669 (on_delete_button_clicked): Show different warning text depending on
670 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
671 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
674 2007-07-09 Murray Cumming <murrayc@murrayc.com>
676 * src/maemo/modest-msg-edit-window.c:
677 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
678 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
680 2007-07-07 Armin Burgmeier <armin@openismus.com>
682 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
683 ckdg_ib_maximum_characters_reached from correct package.
685 * src/modest-ui-actions.c: Show an error message when a folder could
686 not be created. Tinymail does not give us specific error codes about
687 what has gone wrong, so we assume that a folder with that name
688 already exists, though there might be other reasons.
690 2007-07-06 Murray Cumming <murrayc@murrayc.com>
692 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
693 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
694 give a more exact error message that can be partly translated.
696 2007-07-05 Murray Cumming <murrayc@murrayc.com>
698 * src/maemo/modest-address-book.c:
699 (select_email_addrs_for_contact): Specify a default window size for the
700 select-email-address dialog, so that it is probably big enough for the
701 title. This should fix projects.maemo.org bug NB#62277.
703 2007-07-05 Murray Cumming <murrayc@murrayc.com>
705 * src/maemo/easysetup/modest-easysetup-wizard.c:
706 (create_page_complete_easysetup): Use
707 gtk_widget_set_size() request to ensure that the text wraps
710 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
712 * src/maemo/easysetup/modest-easysetup-wizard.c:
713 (on_entry_invalid_character), (create_page_account_details),
714 (create_page_user_details):
715 Use new API of ModestValidatingEntry. But for some reason the banner is
716 not shown. I will have to investigate that further.
718 * src/widgets/modest-validating-entry.c: (on_insert_text),
719 (modest_validating_entry_set_func):
720 * src/widgets/modest-validating-entry.h:
721 Added a new callback function to be able to react to prevented
722 characters whitespaces to e.g show a banner.
724 2007-07-05 Armin Burgmeier <armin@openismus.com>
726 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
727 notification of HildonNumberEditor instead of remembering the port
728 number. Thanks to Johannes for pointing this out.
730 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
732 * src/maemo/easysetup/modest-easysetup-wizard.c:
733 Check if there are any user changes before showing a confirmation
734 dialog (projects.maemo.org NB#60946)
736 2007-07-05 Armin Burgmeier <armin@openismus.com>
738 * src/maemo/modest-account-settings-dialog.c: Remember custom port
739 number at the beginning of the dialog and set the modified flag at the
740 end if the port number has changed. This is necessary because
741 HildonNumberEditor does not support notification when the value has
744 2007-07-05 Murray Cumming <murrayc@murrayc.com>
746 * src/modest-ui-actions.c:
747 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
748 a connection before asking anything else. Correct the check for the destination
749 folder so that it succeeds when online.
750 This fixed projects.maemo.org bug NB#61645.
752 2007-07-05 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
755 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
756 to fix projects.maemo.org bug NB#62439.
758 2007-07-05 Murray Cumming <murrayc@murrayc.com>
760 * src/modest-tny-account.c: (on_connection_status_changed):
761 Really do not use tny_device_force_offline() here. See the previous comment.
763 2007-07-04 Murray Cumming <murrayc@murrayc.com>
765 * src/modest-tny-account.c: (on_connection_status_changed):
766 Do not use tny_device_force_offline() when tinymail says that something
767 went wrong with the connection. It seems to report this unnecessarily.
769 2007-07-04 Murray Cumming <murrayc@murrayc.com>
771 * src/maemo/modest-connection-specific-smtp-window.c:
772 (modest_connection_specific_smtp_window_init):
773 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
774 does not seem to have any effect in osso 1.1 (though it works in
775 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
777 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
779 * src/maemo/modest-connection-specific-smtp-window.c:
780 Fix UI specification problems with projects.meamo.org NB#60479
782 2007-07-04 Murray Cumming <murrayc@murrayc.com>
784 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
785 clue when this has failed, because the error dialog is not always shown
786 (at least in earlier version).
788 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
789 GError message, because the generic error dialog is not helpful.
791 'This message is not currently available (can't let a new connection go online)'
792 when trying to open an IMAP message.
794 (_modest_ui_actions_open): Offer a connection when some messages would
795 have to be downloaded and we are offline.
797 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
799 * src/widgets/modest-folder-view.c:
800 Don't check for MERGE type anymore as we use the correct type
802 NOTE: For the last two changes you need to update your tinymail copy
803 because of API changes!
805 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
807 * src/modest-tny-local-folders-account.c:
808 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
809 (see projects.maemo.org NB#61580)
811 2007-07-04 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-tny-account.c: (on_connection_status_changed):
814 Commented out the call to modest_platform_connect_and_wait() because this
815 seems to always hang, and I would like to know if this is the only thing
816 that causes a hang when showing the connection dialog.
817 It is not very useful anyway.
819 2007-07-04 Murray Cumming <murrayc@murrayc.com>
821 * src/maemo/modest-msg-view-window.c:
822 (modest_msg_view_window_select_next_message):
824 * src/modest-platform.h:
825 * src/maemo/modest-platform.c:
826 Added modest_platform_connect_and_wait(), which calls
827 tny_maemo_conic_device_connect() always in the main thread, by calling it
828 in an idle handler and waiting for the idle handler to run. It should be
829 in the main thread because it uses GTK+ UI code. It just returns TRUE
830 if the device is already online.
832 There is some nasty code to ensure that subsequent calls to
833 modest_platform_connect_and_wait() just wait for the first one to finish,
834 by checking repeatedly in another idle handler. This is necessary,
835 because other threads (or even the main thread, via another idle handler)
836 can call modest_platform_connect_and_wait() while
837 modest_platform_connect_and_wait() is running.
839 (modest_platform_connect_and_wait_if_network_account),
840 (modest_platform_connect_and_wait_if_network_folderstore):
841 Convenience functions that calls modest_platform_connect_and_wait() if
842 the account or folder might want network access.
844 * src/modest-mail-operation.c:
845 (modest_mail_operation_update_account):
846 * src/modest-ui-actions.c: (download_uncached_messages),
847 (modest_ui_actions_on_rename_folder), (delete_folder),
848 (modest_ui_actions_on_main_window_move_to),
849 (modest_ui_actions_on_msg_view_window_move_to):
850 * src/widgets/modest-folder-view.c:
851 (drag_and_drop_from_folder_view):
852 Offer a connection if we are offline.
854 * src/modest-tny-account.c: (on_connection_status_changed):
855 Document this as only handling errors during network operations in progress,
856 and replace the idle code with a simple call to
857 modest_platform_connect_and_wait(), which does this instead.
859 2007-07-03 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-tny-account.c:
862 (modest_tny_account_get_special_folder): (util_on_idle),
863 Handle the GError so we can see when tny_folder_store_get_folders()
864 fails, as it currently does while something else is connecting.
866 Added util_run_in_main_thread_and_wait()
867 which uses an idlen handler and mainloop to ensure that the function
868 is called in the main thread.
869 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
870 to make sure that we call attempt the connection in the mainloop only,
871 which might solve some hangs.
873 2007-07-03 Murray Cumming <murrayc@murrayc.com>
875 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
876 be found by their display name. This is never useful.
877 * src/modest-tny-account-store.c: (on_account_removed): Find the account
878 by its ID, instead of trying to use its ID as its display name.
880 * src/modest-tny-account-store.h:
881 * src/modest-tny-account.c:
882 (modest_tny_account_get_special_folder): Add a g_warning() when
883 tny_folder_store_get_folders() returns an empty list for the maildir.
885 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
886 Add a g_warning() when this returns NULL, because that it not allowed
889 2007-07-02 Armin Burgmeier <armin@openismus.com>
891 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
892 note when trying to cancel the wizard. This fixes projects.maemo.org
895 2007-07-02 Murray Cumming <murrayc@murrayc.com>
897 * src/modest-tny-account.h:
898 * src/modest-tny-account.c:
899 (modest_tny_account_new_from_server_account),
900 (modest_tny_account_new_from_server_account_name),
901 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
902 because this must now be set before setting the proto. This is usd in
903 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
904 warning in camel_session_get_service() caused by
905 tny_camel_transport_account_prepare().
907 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
910 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
912 * src/maemo/modest-connection-specific-smtp-edit-window.c:
914 (modest_connection_specific_smtp_edit_window_init):
916 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
919 2007-06-29 Murray Cumming <murrayc@murrayc.com>
921 * src/modest-tny-account.c:
922 (modest_tny_account_new_from_server_account):
923 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
924 now uses to request a connection when it needs one, and which it uses
925 to tell us that something is wrong with the connection, so we can force
926 the accounts offline to prevent further problems.
929 * src/modest-init.c: (init_default_settings):
930 * src/modest-mail-operation.c:
931 (modest_mail_operation_update_account):
932 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
933 This should not be necessary anymore. Do not set the conf key that
934 determined this (it was always TRUE and not set anywhere else).
936 * src/modest-ui-actions.h: Remove unused and unimplemented
937 modest_ui_actions_on_online_toggle_toggled().
939 2007-06-29 Murray Cumming <murrayc@murrayc.com
941 * src/maemo/modest-main-window.c: (connect_signals):
942 Don't connect to delete_event twice. Maybe this was harmless.
944 2007-06-29 Murray Cumming <murrayc@murrayc.com
946 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
947 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
948 Debug output to give some more clue when a folder move is not allowed.
950 2007-06-28 Murray Cumming <murrayc@murrayc.com
952 * src/modest-tny-account.c: (on_modest_file_system_info),
953 (modest_tny_account_get_mmc_account_name):
954 Always call the callback, without checking whether the name has changed.
955 * src/widgets/modest-folder-view.c: (strings_are_equal),
956 (on_model_foreach_set_name), (on_get_mmc_account_name),
957 (text_cell_data): Compare the name here, and use the name from
958 the account rather than from the
959 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
960 if the name was changed after the account was added to the model.
961 That's a tinymail bug but not one that I want to fix now.
963 This finally fixes projects.maemo.org bug NB#59301.
965 2007-06-27 Armin Burgmeier <armin@openismus.com>
967 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
970 2007-06-27 Murray Cumming <murrayc@murrayc.com
972 * src/modest-tny-account.h:
973 * src/modest-tny-account.c:
974 Added modest_tny_account_get_mmc_account_name(), to set the memory
975 card name asynchronously for the given account and then notify.
976 (modest_tny_account_new_for_local_folders): Use this new function instead
977 of using hildon_file_system_info_async_new() directly.
979 * src/widgets/modest-folder-view.c: (text_cell_data):
980 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
981 gtk_tree_model_row_changed() when it is available.
983 This should fix projects.maemo.org bug NB#59301.
985 2007-06-27 Murray Cumming <murrayc@murrayc.com
987 * src/modest-mail-operation.c: (update_account_thread),
988 (get_msgs_full_thread): Fix typo failures in the revert
991 2007-06-27 Murray Cumming <murrayc@murrayc.com
993 * src/maemo/modest-maemo-global-settings-dialog.c:
994 (idle_select_default_focus):
995 * src/modest-mail-operation.c: (idle_notify_progress),
996 (idle_notify_progress_once), (set_last_updated_idle),
997 (update_account_thread), (get_msgs_full_thread):
998 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
999 * src/widgets/modest-header-view.c:
1000 (idle_notify_headers_count_changed_destroy),
1001 (idle_notify_headers_count_changed):
1002 Reverted the additions of gdk_threads_enter/leave(), in case this
1003 helps with a startup hang on the device.
1005 2007-06-26 Armin Burgmeier <armin@openismus.com>
1007 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1008 for supported secure authentication methods from server by
1009 gtk_dialog_run(), saving CPU time and a potential race condition.
1011 2007-06-26 Armin Burgmeier <armin@openismus.com>
1013 * src/maemo/modest-maemo-utils.h:
1014 * src/maemo/modest-maemo-utils.c: Added a
1015 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1016 only error code to tell the calling code when the user canceled the
1019 * src/maemo/modest-account-settings-dialog.h:
1020 * src/maemo/modest-account-settings-dialog.c:
1021 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1022 message if the retrieval of secure authentication methods was canceled
1023 by the user. Perform the check before saving anything to configuration
1024 to not end up with half-committed configuration changes, do not show
1025 a "Saving to configuration failed" note when authentication methods
1026 could not be retrieved.
1028 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1031 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1033 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1034 Only return the first level of folders under accounts, because the
1035 osso-global-search UI spec doesn't want the rest.
1036 This fixed projects.maemo.org bug NB#61811.
1038 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1040 * src/modest-tny-account-store.c:
1041 * src/modest-tny-account-store.h:
1042 Added modest_tny_account_is_memory_card_account().
1043 * src/maemo/modest-main-window.c: (create_details_widget):
1044 Show the same information items for the memory card as we show for the
1045 local-folders, to fix projects.maemo.org bug NB#59307.
1047 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1049 * src/modest-tny-account-store.c: (get_password):
1050 Added some checks for NULL to maybe prevent crashes, though I think
1051 it was Philip's last commit that actually prevented the crash here
1052 when creating a first new account.
1053 But the new account is still not usable (no messages are shown)
1054 until a restart of the application.
1056 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1058 * src/maemo/modest-maemo-global-settings-dialog.c:
1059 (idle_select_default_focus):
1060 * src/modest-mail-operation.c: (idle_notify_progress),
1061 (idle_notify_progress_once), (idle_notify_update_account_queue),
1062 (set_last_updated_idle), (update_account_thread),
1063 (notify_get_msgs_full), (get_msgs_full_destroyer),
1064 (get_msgs_full_thread):
1065 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1066 * src/widgets/modest-header-view.c:
1067 (idle_notify_headers_count_changed_destroy),
1068 (idle_notify_headers_count_changed):
1069 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1070 all idle handlers, because some other thread could be blocking
1071 the GDK lock, so that it can do GUI stuff.
1073 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1075 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1076 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1077 (on_idle_send_receive), (on_idle_open_default_inbox):
1078 * src/maemo/modest-msg-edit-window.c:
1079 (modest_msg_edit_window_attach_file_noninteractive):
1080 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1081 to prevent a hang. I don't quite understand why these are necessary,
1082 beause we should already be in the main loop. I guess something outside
1083 of the main loop is taking the lock.
1085 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1086 we are really using URIs, and use files that are more likely to exist.
1088 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1090 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1091 necessary because configure.ac now defines different variables.
1093 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1095 * libmodest-dbus-client/libmodest-dbus-client.c:
1096 * libmodest-dbus-client/libmodest-dbus-client.h:
1097 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1098 libmodest_dbus_client_compose_mail() is what things actually use.
1100 * src/dbus_api/modest-dbus-api.h:
1101 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1102 * tests/dbus_api/Makefile.am:
1103 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1106 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1108 * src/modest-init.c: (modest_init_local_folders):
1109 For memory-card (or other non local-folders) maildir accounts,
1110 always create an Archive folder, so that there is somewhere to put
1111 messages. This should be less confusing, because the user does not need
1112 to guess that the need to create a folder.
1114 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1116 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1117 Fixed icon size by using (50, 50) which is the same as defined by
1120 2007-06-25 Armin Burgmeier <armin@openismus.com>
1122 * src/widgets/modest-window-mgr.c:
1123 * src/modest-init.c:
1124 * configure.ac: Correctly recognize hildon-notify presence and fixed
1125 the build without it being installed.
1127 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1129 * libmodest-dbus-client/libmodest-dbus-client.c:
1130 (libmodest_dbus_client_search): Fix the build. Sorry.
1131 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1132 (reply_forward_cb): Initialize variables to fix the build.
1134 * src/modest-tny-account-store.c:
1135 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1136 comparison (a silly typo) so that email search results can be opened
1137 when there are more than one account.
1139 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1141 * libmodest-dbus-client/libmodest-dbus-client.c:
1142 (libmodest_dbus_client_search),
1143 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1144 instead of 1 second, because the search gets folders and messages from
1145 the server, which can take a long time. When it times out,
1146 osso-global-search will report no results.
1148 We need to specify whether we should search only cached information
1149 (maybe with a user preference), and the osso-email-search-plugin
1150 API should really be improved to allow that option, and to allow results
1151 to be delivered asynchronously in batches.
1153 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1155 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1156 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1157 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1159 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1161 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1162 that is an empty string. D-Bus seems to give us these instead of NULL.
1164 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1166 * src/dbus_api/modest-dbus-callbacks.c:
1167 * src/maemo/easysetup/modest-easysetup-wizard.h:
1168 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1170 (modest_connection_specific_smtp_edit_window_init):
1171 * src/maemo/modest-maemo-global-settings-dialog.c:
1173 * src/maemo/modest-maemo-utils.c:
1174 (modest_maemo_utils_setup_images_filechooser):
1175 * src/maemo/modest-main-window.c: (create_details_widget):
1176 * src/maemo/modest-msg-edit-window.c:
1177 (modest_msg_edit_window_attach_file_noninteractive),
1178 (modest_msg_edit_window_color_button_change),
1179 (modest_msg_edit_window_set_zoom):
1180 * src/modest-mail-operation.c: (update_account_thread):
1181 * src/modest-tny-account-store.c:
1182 * src/modest-tny-account.c:
1183 * src/widgets/modest-global-settings-dialog.c:
1184 * src/widgets/modest-window.h:
1186 Fixed build on bora!
1188 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1190 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1191 * src/modest-search.c: (modest_search_folder),
1192 (modest_search_all_accounts): Actually search only in the specified folder,
1193 doing a simple match on the folder ID.
1194 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1195 and added some documentation.
1197 2007-06-22 Armin Burgmeier <armin@openismus.com>
1199 * src/maemo/modest-maemo-utils.h:
1200 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1201 modest_maemo_utils_get_supported_secure_authentication_methods.
1203 * src/maemo/easysetup/modest-easysetup-wizard.c:
1204 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1205 one occured, not just "Server does not support secure authentication".
1207 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-tny-account-store.c: (get_password):
1210 Restored the call to tny_account_set_user() because Philip seems to have
1211 stopped this from crashing (by not using the freed string). It still does
1212 not work, but now we can test it.
1214 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1216 * src/maemo/modest-msg-edit-window.c: (init_window):
1217 Comment out use of an uninitialzed GtkScrolledWindow variable,
1218 to fix the build and stop a crash. Yet again.
1220 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1222 * src/modest-tny-account-store.c: (get_password):
1223 Remove the call to tny_account_set_user() because this actually crashes.
1224 As mentioned in the last commit, it is known to not work anyway.
1226 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-tny-account-store.c: (get_password):
1229 Use tny_account_set_username() to tell tinymail that the username might
1230 have changed too. But tinymail ignores this: see projects.maemo.org
1232 * src/modest-ui-actions.c:
1233 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1234 reset the connection when changing the username, and improve the comments.
1235 Save the changed username to gconf at least, so it is used when Modest is
1238 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1240 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1241 Do not use a query, so that we get all folders, including for POP and
1242 local-folders. They work as search criteria too.
1243 This fixes projects.maemo.org bug NB#57740.
1245 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1247 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1248 Comment out the use of hildon_notification_set_sound() because it is
1249 not declared, to fix the build. Warnings are serious, people.
1251 2007-06-21 Armin Burgmeier <armin@openismus.com>
1253 * src/maemo/modest-maemo-utils.h:
1254 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1255 modest_maemo_utils_get_supported_secure_authentication_methods()
1256 to query authentication methods for a specific user. This should fix
1257 projects.maemo.org bug NB#61369.
1259 * src/maemo/easysetup/modest-easysetup-wizard.c:
1260 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1263 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1265 * libmodest-dbus-client/libmodest-dbus-client.h:
1266 * libmodest-dbus-client/libmodest-dbus-client.c:
1267 (modest_dbus_message_iter_get_search_hit),
1268 (libmodest_dbus_client_search):
1269 Reorganised and commented this.
1270 Removed modest_search_hit_free() from the public API because it
1273 Added libmodest_dbus_client_get_folders() and
1274 modest_folder_result_list_free().
1276 * src/dbus_api/modest-dbus-api.h:
1277 * src/dbus_api/modest-dbus-callbacks.c:
1278 (modest_dbus_req_filter): Commented. Moved most code to
1279 on_dbus_method_search() and added on_dbus_method_get_folders().
1281 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1282 of the extra D-Bus handler.
1284 * tests/dbus_api/Makefile.am:
1285 * tests/dbus_api/test_get_folders.c: New test for
1286 libmodest_dbus_client_get_folders(). This seems to return an empty list
1287 at the moment. That could be the same error that causes the message list
1288 to be empty sometimes.
1289 This should help with projects.maemo.org bug NB#57740.
1291 2007-06-21 Armin Burgmeier <armin@openismus.com>
1293 * src/modest-mail-operation.c: Do not call
1294 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1295 notify the operation's end after having set the status to CANCELED for
1296 the operation queue to listen on. This fixes a deadlock when there
1297 were mail operations in the queue during its finalization.
1299 * src/modest-singletons.c: Reordered uninitialization of the account
1300 manager to happen after the mail operation queue was uninitialized
1301 because the mail operation's in the queue might still try to access
1302 the account manager (see modest_mail_operation_notify_end()). This
1303 fixes a potential crash when terminating the application.
1305 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1307 * src/modest-search.c:
1308 (search_mime_part_and_child_parts): Moved some code here so we
1309 can search recursively in child folders.
1310 (modest_search_folder): Search in the message as a mime part, instead
1311 of just its child mime parts.
1312 (read_chunk), (search_mime_part_ogs):
1313 Check how many bytes were read, to prevent an endless loop.
1314 Searching in message bodies now works. This finishes the fix for
1315 projects.maemo.org bug NB#61007.
1317 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1320 Add a g_warning when the item is not a folder.
1322 * src/modest-ui-dimming-rules.c:
1323 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1324 when selected item is not a folder (for instance, an account), because
1325 the UI spec only talks about folders.
1326 I am not sure what the UI spec wants, so this might not totally fix
1327 projects.maemo.org bug NB#60794.
1329 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1331 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1332 (load_from_file): Sort the list. The unsorted list would be more noticeable
1333 in non-English locales.
1335 * src/maemo/modest-msg-edit-window.c:
1336 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1337 warning and fix the build.
1339 * src/maemo/modest-progress-bar-widget.c:
1340 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1341 avoid a g_warning, and probably to avoid a crash.
1343 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-search.c: (modest_search_folder): Check for a GError
1346 when calling tny_folder_get_headers(), to show that this is not the cause
1349 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1351 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1352 Actually set the body query instead of the subject query.
1354 * src/modest-search.c: (search_mime_part_ogs),
1355 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1356 which would probably cause it to fail if we got this far.
1358 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1359 to simplify the code.
1360 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1361 be causing search-in-body to fail.
1363 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1365 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1367 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1368 Better debug message when the folder cannot be found.
1369 This should help with fixing projects.maemo.org bug #61287.
1370 * src/modest-search.c: (add_hit): Do not leak the furl string.
1372 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1374 * src/modest-ui-actions.c:
1375 (modest_ui_actions_on_folder_selection_changed):
1376 Do not special-case TNY_MERGE_FOLDER here, because
1377 modest_tny_folder_get_account() already does that. This fixes
1378 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1379 shown when the Outbox was selected).
1381 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1383 * libmodest-dbus-client/libmodest-dbus-client.c:
1384 (_dbus_iter_get_string_or_null): Initialize the string variable in
1385 case this helps with Dirk's crash.
1387 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1389 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1390 though it is not implemented yet (this function is maybe not even used),
1391 to avoid breaking ABI in future.
1392 * libmodest-dbus-client/libmodest-dbus-client.c:
1393 (get_attachments_string): Moved some code into this generic function.
1394 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1395 sends email. It is maybe not used.
1396 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1397 (on_send_mail): Use attachments.
1399 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1400 * src/maemo/modest-msg-edit-window.c:
1401 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1402 a filename before using it, to fix projects.maemo.org bug NB#58233.
1404 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1406 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1407 Initialize the continue_download variable to fix the build, and probably
1408 to fix randome behaviour.
1410 2007-06-18 Armin Burgmeier <armin@openismus.com>
1412 * src/modest-tny-send-queue.h:
1413 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1414 the queue so we can later show it in the UI. Replaced
1415 modest_tny_send_queue_msg_is_being_sent() by
1416 modest_tny_send_queue_get_msg_status().
1418 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1420 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1421 gpointer. This probably was not harmful, but just to be sure.
1423 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1426 Fix the build, but leave the function broken on Bora, because
1427 hildon_uri_action_get_service() does not exist.
1428 osso_uri_action_get_service() does not exist either, it seems.
1430 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1432 * src/modest-tny-account.c:
1433 (modest_tny_account_new_from_server_account):
1434 Uncommented the url debug output again, because it is useful for
1435 debugging, as I said in the comment.
1437 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1439 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1441 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1442 for Mameo Bora, to fix the build.
1444 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1447 Fixed build with hildon < 0.99
1449 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1450 Check if the selected account is busy instead of checking all accounts
1452 * src/modest-account-mgr-priv.h:
1453 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1454 (modest_account_mgr_init), (compare_account_name),
1455 (modest_account_mgr_set_account_busy),
1456 (modest_account_mgr_account_is_busy):
1457 * src/modest-account-mgr.h:
1458 Added busy information to the account manager. It possible to
1459 set an account to busy or not busy now.
1461 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1462 (modest_mail_operation_update_account),
1463 (modest_mail_operation_notify_end):
1464 Set the account to busy/not busy depending on the operation state.
1466 * src/widgets/modest-account-view.c:
1467 (modest_account_view_finalize), (get_last_updated_string),
1468 (update_account_view), (on_account_busy_changed), (init_view):
1469 Show string "Refreshing..." if the account is currently busy.
1471 All this fixes projects.maemo.org bug NB#59711
1473 2007-06-14 Armin Burgmeier <armin@openismus.com>
1475 * src/widgets/modest-attachments-view.h:
1476 * src/widgets/modest-attachments-view.c: Added
1477 modest_attachments_view_has_attachments() and fixed coordinate
1478 transformation in get_att_view_at_coords(). This fixes attachment
1481 * src/widgets/modest-msg-view.c: Make use of
1482 modest_attachments_view_has_attachments() to decide whether to show
1483 attachments in the header.
1485 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1487 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1488 (on_change), (on_combo_security_changed),
1489 (modest_connection_specific_smtp_edit_window_init),
1490 (modest_connection_specific_smtp_edit_window_set_connection),
1491 (modest_connection_specific_smtp_edit_window_is_dirty):
1492 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1493 * src/maemo/modest-connection-specific-smtp-window.c:
1496 Show an comfirmation dialog for the smpt-edit-window if there are
1497 unsaved changes and the user hits cancel.
1498 (projects.maemo.org bug NB#60479)
1500 2007-06-14 Armin Burgmeier <armin@openismus.com>
1502 * src/maemo/easysetup/modest-easysetup-wizard.c:
1503 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1504 address" info in banner instead of node, and select all the text as
1505 per UI spec. This fixes projects.maemo.org bug NB#60550.
1507 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1509 reviewed by: <delete if not using a buddy>
1511 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1512 * src/modest-ui-actions.c: (folder_refreshed_cb):
1514 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1516 * src/widgets/modest-folder-view.c: (filter_row):
1517 Explictly filter out the per-account outbox accounts. I don't know why
1518 these only sometimes show up, but now they should never show up in the UI.
1519 This should fix projects.maemo.org bug NB#60160.
1521 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1523 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1524 when the toolbar does not exist yet.
1525 * src/modest-widget-memory.c: (save_settings_header_view):
1526 Added g_warnings() to help us to discover when we are trying to set
1527 an empty columns list in gconf.
1529 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1531 * src/modest-init.h:
1532 * src/modest-init.c:
1533 Added modest_init_get_default_header_view_column_ids().
1535 * src/modest-widget-memory.c: (restore_settings_header_view):
1536 Use the new function to get defaults, if the gconf key is empty,
1537 instead of not creating any columns. This seems to fix the
1538 empty right-hand pane problems.
1540 * src/widgets/modest-header-view.h: Improved documentation.
1542 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1544 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1545 Revert the use of the display name as the account name, because this
1546 is generally wrong and would break the code that follows.
1548 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1550 * src/maemo/easysetup/modest-easysetup-wizard.c:
1551 (check_for_supported_auth_methods), (on_before_next),
1554 More correct fix for projects.maemo.org bug NB# 58991
1555 Do not longer accept AUTH_PASSWORD as secure method and choose
1556 correct method when creating the account.
1558 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1560 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1561 Fixed projects.maemo.org bug NB# 58991
1563 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1565 * src/modest-init.c: (modest_init_init_core),
1566 (modest_init_local_folders): Fixed compilation errors.
1568 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1570 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1571 Remove unnecessary lib/include, though it is good in principle when needed.
1573 * src/modest-init.c: (modest_init_one_local_folder),
1574 (modest_init_local_folders):
1575 * src/modest-init.h: Initialize the .modest library for memory cards,
1576 instead of just doing nothing for them. This should allow us to create
1577 folders there, fixing projects.maemo.org bug NB#59297.
1579 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1581 * libmodest-dbus-client/libmodest-dbus-client.c:
1582 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1583 (libmodest_dbus_client_compose_mail),
1584 (libmodest_dbus_client_open_message),
1585 (libmodest_dbus_client_send_and_receive),
1586 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1588 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1589 (on_idle_open_message), (modest_dbus_req_handler),
1590 (search_result_to_message), (modest_dbus_req_filter):
1591 * src/modest-search.c: (add_hit), (modest_search_folder),
1592 (modest_search_all_accounts): Improved debug messages.
1594 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1596 * src/modest-tny-account-store.c:
1597 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1600 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1603 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1605 * src/modest-tny-account-store.c: (get_server_accounts):
1606 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1607 even when there are no accounts, so that the Outbox folder is always
1608 visible. This fixes projects.maemo.org bug NB#60158.
1610 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1612 * src/maemo/modest-main-window.c: (create_details_widget):
1613 Use the mcen_va_never logical ID.
1615 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1617 * src/dbus_api/modest-dbus-api.h:
1618 * src/dbus_api/modest-dbus-callbacks.c:
1619 (on_idle_open_default_inbox), (on_open_default_inbox),
1620 (modest_dbus_req_handler):
1621 Added a new OpenDefaultInbox method.
1623 * libmodest-dbus-client/libmodest-dbus-client.h:
1624 * libmodest-dbus-client/libmodest-dbus-client.c:
1625 Added libmodest_dbus_client_open_default_inbox() to call the new
1626 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1627 though it should maybe be used by a new osso-email-interface function.
1629 * tests/dbus_api/Makefile.am:
1630 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1633 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1635 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1636 NULL, so that the signals get all the keys. This should not actually
1637 change any behaviour because we currently update everything when anything
1640 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1642 * src/widgets/modest-folder-view.c: (text_cell_data),
1643 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1644 (find_inbox_iter): If tinymail tells us that the folder is
1645 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1646 This causes the inbox to be selected at startup, fixing part of
1647 projects.maemo.org bug NB#56305.
1649 * src/modest-ui-dimming-rules.c:
1650 (modest_ui_dimming_rules_on_tools_smtp_servers):
1651 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1652 the SMTP servers menu item.
1653 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1654 that the SMTP Servers menu item is dimmed when there are no accounts,
1655 as a future version of the UI spec will require. This fixes
1656 projects.maemo.org bug NB#56305.
1658 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1660 * src/maemo/modest-maemo-utils.c:
1661 (modest_maemo_utils_get_supported_secure_authentication_methods):
1662 Added label to dialog instead of unreadable title
1664 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1665 (modest_main_window_new):
1666 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1669 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1670 * src/modest-account-mgr.h:
1671 Added method to avoid code duplication
1673 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1674 (modest_ui_actions_on_send_receive):
1675 Use modest_account_mgr_has_accounts
1677 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1679 * src/maemo/easysetup/modest-presets.c:
1680 (modest_presets_get_info_server_security): Do not report secure auth
1682 * src/modest-protocol-info.c: Use the defines for the gconf key names
1683 for secure authentication. This was not working because we were writing
1684 Password and reading password, and the check was case sensitive.
1685 With this, gmail now works for receiving and sending when created via
1688 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1690 * src/maemo/easysetup/modest-presets.c:
1691 (modest_presets_get_info_server_security): Correct the key name for
1692 SecureSmtp, because it seems to be case-sensitive.
1693 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1694 Do not try to get the 0th notebook page if there are 0 pages, to
1695 avoid a g_warning().
1697 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1700 Prevent use of the new notification feature for now, because it currently
1701 shows one dialog for each new email, which is annoying.
1703 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1705 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1706 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1707 when no country was selected, so that we show the global ones.
1708 * src/maemo/easysetup/modest-presets.c:
1709 (modest_presets_get_providers): Return only the global providers, not
1710 all providers when mmc=0 was requested.
1712 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1714 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1715 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1716 provider ID in the combo.
1718 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1719 Do not show the page numbers, because it would be confusing when we add
1720 the 2 extra pages for the custom setup, when the user chooses the "Other"
1721 provider. This fixes projects.maemo.org bug NB#59028
1723 * src/modest-init.c: (modest_init_init_core),
1724 (modest_init_local_folders):
1725 * src/modest-init.h:
1726 * src/modest-tny-account.c:
1727 (modest_tny_account_new_for_local_folders): Do not create default folders
1728 for the memory card. This should fix projects.maemo.org bug NB#59328.
1730 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1732 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1733 Free the changed_conf_keys string items. They are already freed in the
1734 idle handler if that runs first.
1736 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1738 * src/modest-ui-actions.c:
1739 (modest_ui_actions_on_password_requested): Check that the server name
1740 is not NULL, because I just saw a password dialog with (null) as the
1743 * src/modest-tny-folder.[h|c]: Added
1744 modest_tny_folder_is_memory_card_folder().
1745 * src/modest-ui-dimming-rules.c:
1746 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1747 menu item for memory cards, as per the UI spec (section 7.4). This should
1748 fix projects.maemo.org bug NB#59297.
1750 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1752 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1753 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1754 is another problem with the code, see Murray's comment at line 772)
1756 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1758 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1759 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1760 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1761 (load_from_file), (easysetup_country_combo_box_init),
1762 (easysetup_country_combo_box_get_active_country_ids),
1763 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1764 instead of just one ID, to avoid duplicate country names in the UI.
1766 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1767 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1768 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1769 a single ID, avoiding duplicate providers.
1770 * src/maemo/easysetup/modest-easysetup-wizard.c:
1771 (on_combo_account_country): Adapt to use a list.
1773 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1775 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1776 keys changed in the last X seconds.
1778 * src/modest-account-mgr.h:
1779 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1780 (on_key_change), (modest_account_mgr_class_init),
1781 (modest_account_mgr_init), (modest_account_mgr_finalize):
1782 As the keys are changed, save them in a GSList* and signal that GSList*
1783 further every X seconds, to batch changes, to allow us to do just one
1784 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1785 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1787 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1788 changed signal signature.
1790 * src/modest-conf.c: (modest_conf_set_list),
1791 (modest_conf_on_change): Reenable notification.
1793 (modest_conf_maemo_fake_on_change): Comment out the hack that
1794 notified immediately instead of asynchronously.
1796 * src/widgets/modest-account-view.h:
1797 * src/widgets/modest-account-view.c:
1798 (update_account_view): Select the previously-selected account ID,
1799 if possible. This fixes projects.maemo.org bug NB#56933.
1801 (on_account_changed), (on_account_removed),
1802 (modest_account_view_select_account):
1804 Remove the block/unblock functions
1805 because they were not useful.
1807 * src/maemo/modest-account-view-window.c:
1808 (on_delete_button_clicked), (on_edit_button_clicked),
1809 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1811 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1813 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1814 Improve the error dialog to show Incorrect Account Settings, which seems
1815 clearer, and say that the internal error message (to be removed from the
1816 dialog later) is often misleading.
1817 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1819 * src/modest-tny-account.c:
1820 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1821 URL because this is so useful for debugging on the device.
1823 * src/widgets/modest-serversecurity-combo-box.c:
1824 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1826 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1828 * src/modest-mail-operation.c:
1829 (modest_mail_operation_send_new_mail):
1830 Added a comment about a nasty but apparently harmless message. Details
1831 added to the wiki g_warnings() page.
1833 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1836 (modest_tny_send_queue_class_init):
1837 Do not use the priv struct because it is empty, to avoid g_warnings
1838 about a non-existant priv struct.
1840 * src/modest-tny-account-store.c:
1841 (modest_tny_account_store_get_server_account),
1842 (modest_tny_account_store_get_transport_account_for_open_connection
1843 ): Do not try to get transport server accounts for local folders,
1844 because they don't have any. This avoids a g_warning().
1846 * src/maemo/modest-main-window.c:
1847 (modest_main_window_notify_send_receive_initied),
1848 (on_configuration_key_changed):
1849 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1850 * src/modest-defs.h:
1851 * src/modest-mail-operation.c:
1852 (modest_mail_operation_update_account):
1853 * src/modest-tny-account-store.h:
1854 * src/modest-tny-account.c:
1855 (modest_tny_account_get_special_folder),
1856 (modest_tny_account_new_for_local_folders),
1857 (modest_tny_account_new_for_per_account_local_outbox_folder):
1858 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1859 * src/modest-tny-local-folders-account.c:
1860 (add_account_folders_to_merged_folder):
1861 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1862 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1863 (modest_ui_actions_on_send):
1864 * src/widgets/modest-folder-view.c: (update_model):
1865 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1866 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1867 modest_tny_account_store_get_tny_account_by_account() to
1868 modest_tny_account_store_get_server_account() to make the code clearer.
1870 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1872 * src/dbus_api/modest-dbus-api.h:
1873 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1874 * src/maemo/modest-msg-edit-window.c:
1875 (modest_msg_edit_window_attach_file_noninteractive):
1876 added g_warning in case the file to be attached does not exist
1877 * tests/dbus_api/test_compose_mail.c: (main):
1878 removed obsolete comment, added generic files as test case
1880 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1882 * src/modest-tny-account-store.c: (get_server_accounts):
1883 Create the local folders account only once, not once for each outbox, and
1884 not only when there are some outboxes.
1886 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1888 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1889 code that is causing a crash at startup. Sergio says that he is fixing this.
1891 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1893 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1894 * src/maemo/modest-account-settings-dialog.c:
1895 (create_page_outgoing),
1896 (modest_account_settings_dialog_set_account_name),
1897 (save_configuration):
1898 - Fixed handling of the "Use secure authentication" toggle to comply with
1899 the ui specification. See also projects.maemo.org bug NB#58400
1901 - Restore the Secure connection setting combo correctly when loading
1904 * src/maemo/modest-maemo-utils.c:
1905 (on_camel_account_get_supported_secure_authentication),
1906 (modest_maemo_utils_get_supported_secure_authentication_methods):
1907 Fixed a crasher if operation is canceled
1909 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1910 (modest_protocol_info_auth_is_secure):
1911 * src/modest-protocol-info.h:
1913 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1914 the sense of the "Use secure authentication" toggle.
1916 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1918 * src/modest-tny-account-store.h:
1919 * src/modest-tny-account-store.c:
1920 Added modest_tny_account_store_get_local_folders_account().
1922 * src/modest-tny-folder.h:
1923 * src/modest-tny-folder.c:
1924 (modest_tny_folder_get_account):
1925 Added this replacement for tny_folder_get_account() which returns
1926 the local-folders account for TnyMergeFolders, to avoid the
1927 warning about the unimplemented get_account_func() vfunc().
1929 (modest_tny_folder_get_rules),
1930 * src/modest-ui-actions.c:
1931 (modest_ui_actions_on_folder_selection_changed):
1932 * src/modest-mail-operation.c:
1933 (modest_mail_operation_remove_folder),
1934 (modest_mail_operation_xfer_folder),
1935 (modest_mail_operation_rename_folder),
1936 (modest_mail_operation_get_msg),
1937 (modest_mail_operation_get_msgs_full),
1938 (modest_mail_operation_remove_msg),
1939 (modest_mail_operation_xfer_msgs),
1940 (modest_mail_operation_refresh_folder):
1941 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1943 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1945 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1946 (modest_server_account_set_security):
1947 * src/modest-defs.h: Add comments explaining that our
1948 UI spec means TLS when it says Normal, so these do not look like errors.
1950 * src/modest-tny-account.c:
1951 (modest_tny_account_new_from_server_account): Use the new tinymail
1952 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1953 for TLS. This should fix projects.maemo.org bug NB#58460.
1955 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1957 * src/maemo/easysetup/modest-easysetup-wizard.c:
1958 (create_account): Correct the position of the gconf sanity check warning.
1959 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1960 of using the g_idle_add() hack, because this does not seem to be necessary
1961 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1962 caused by something other than maemo's gconf.
1963 This fixes projects.maemo.org bug #59022.
1965 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1967 * src/modest-account-mgr-helpers.c:
1968 (modest_account_mgr_get_default_account): Do not check that the account
1969 exists if there is no default account (NULL), to fix a runtime warning.
1971 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1973 * src/widgets/modest-folder-view.c: (update_model):
1974 Do not unref the treemodel before we have finished with it.
1975 This prevents a valgrind warning and an occasional crash at startup.
1977 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1979 * libmodest-dbus-client/libmodest-dbus-client.h:
1980 added libmodest_dbus_client_compose_mail()
1981 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1983 added functions needed for SendAsMail() functionality
1984 * src/maemo/modest-msg-edit-window.c:
1985 (modest_msg_edit_window_attach_file_noninteractive):
1986 non interactively attaching files to message edit window
1987 * src/widgets/modest-msg-edit-window.h:
1988 * tests/dbus_api/Makefile.am:
1989 added test_compose_mail.c
1990 * tests/dbus_api/test_compose_mail.c: (main):
1992 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1994 * src/modest-account-view.c:
1995 Fixed bug projects.maemo.org bug NB#59307
1997 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1999 * src/maemo/easysetup/modest-easysetup-wizard.c:
2000 (get_serverport_incoming), (on_before_next), (create_account):
2001 * src/maemo/modest-account-settings-dialog.c:
2002 (modest_account_settings_dialog_set_account_name):
2003 * src/maemo/modest-maemo-utils.c:
2004 (on_camel_account_get_supported_secure_authentication_status),
2005 (on_camel_account_get_supported_secure_authentication),
2006 (on_secure_auth_cancel),
2007 (modest_maemo_utils_get_supported_secure_authentication_methods):
2009 Implemented security authentication for settings and easysetup.
2011 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2013 * src/maemo/modest-main-window.c: (create_details_widget):
2014 Show the total size for memory card accounts too, instead of showing
2015 the name again. Fixes bug projects.maemo.org bug NB#59307.
2017 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2020 * src/modest-tny-simple-folder-store.c:
2021 * src/modest-tny-simple-folder-store.h: Removed.
2023 * src/modest-tny-local-folders-account.h
2024 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2025 for the local-folders maildir, with an extra TnyMergedFolder containing
2026 the folders of the per-account outbox store accounts.
2027 * src/modest-tny-account-store.c: (get_server_accounts):
2028 Add the outboxes to the special local folders account after creating it.
2030 * src/modest-tny-account.c:
2031 (modest_tny_account_new_for_local_folders): Create the derived
2032 account when creating the main local-folders account.
2034 * src/maemo/modest-main-window.c: (create_details_widget),
2035 (modest_main_window_set_contents_style):
2036 Adapted to the use of the derived account instead of the folder store.
2038 * src/modest-ui-actions.c:
2039 (modest_ui_actions_on_folder_selection_changed):
2040 * src/modest-ui-dimming-rules.c:
2041 (modest_ui_dimming_rules_on_new_folder):
2042 * src/widgets/modest-folder-view.c: (text_cell_data),
2043 (icon_cell_data), (filter_row), (update_model),
2044 (get_cmp_rows_type_pos):
2047 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2048 Do not get the priv struct, because no priv struct has been set,
2049 to avoid a runtime warning.
2051 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2052 #ifelse with #else, to fix a warning, to fix the build.
2055 2007-06-05 Christian Kellner <ckellner@openismus.com>
2057 * libmodest-dbus-client/libmodest-dbus-client.c:
2058 Fix small typo in doc (why do you always see them
2059 AFTER committing stuff?)
2062 2007-06-05 Christian Kellner <ckellner@openismus.com>
2064 * libmodest-dbus-client/libmodest-dbus-client.c:
2065 (libmodest_dbus_client_search):
2066 Initialize hit list with NULL. Also set folder list
2067 to "" if NULL was supplied.
2070 2007-06-03 Christian Kellner <ckellner@openismus.com>
2072 * libmodest-dbus-client/libmodest-dbus-client.c:
2073 (modest_search_hit_list_free):
2074 Make it save to call it with NULL.
2076 * src/dbus_api/modest-dbus-callbacks.c:
2077 * src/modest-search.c:
2078 Return full ModestSearchHits as the search result list not TnyHeader
2079 since can't be around withouth the correspoding TnyFolder.
2081 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2083 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2084 Added currently commented code to check for secure auth
2086 * src/maemo/modest-account-settings-dialog.c: (on_response),
2087 (save_configuration), (show_ok):
2088 Fixed projects.maemo.org bugs NB #59248 and #59251
2090 * src/maemo/modest-maemo-utils.c:
2091 (on_camel_account_get_supported_secure_authentication_status),
2092 (on_camel_account_get_supported_secure_authentication),
2093 (modest_maemo_utils_get_supported_secure_authentication_methods):
2094 * src/maemo/modest-maemo-utils.h:
2095 Moved get_supported_secure_authentication() method here to be able
2096 to use it from easysetup wizard.
2098 * src/modest-pair.c: (on_pair_compare_as_string):
2099 Should compare string with first part of pair and not
2100 strcmp pairs which will crash.
2102 * src/modest-protocol-info.c:
2103 (modest_protocol_info_protocol_is_store):
2104 * src/modest-protocol-info.h:
2105 Added modest_protocol_info_get_auth_protocol_name()
2107 2007-06-03 Armin Burgmeier <armin@openismus.com>
2109 * src/modest-mail-operation.c:
2110 (modest_mail_operation_get_msgs_full): Set priv->account also when
2111 only retrieving a single message. This avoids a crash when canceling
2114 (modest_mail_operation_notify_end): Do not explicitely remove the
2115 operation from the queue but only emit the progress_changed signal.
2116 The queue itself listens to that signal to remove the operation when
2117 it is finished. This reduces coupling and removes a potential deadlock
2118 when modest_mail_operation_notify_end() is called from the queue
2119 itself. If that is a problem performance-wise, I would suggest to
2120 implement a status-changed signal or something.
2122 * src/modest-mail-operation-queue.c: Make sure to never call a
2123 function from another file while the queue is locked. This (hopefully)
2124 fixes another deadlock when exiting the application while retrieving
2127 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2129 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2130 Fixed build if libogs is not available
2132 2007-06-03 Christian Kellner <ckellner@openismus.com>
2134 * libmodest-dbus-client/libmodest-dbus-client.h:
2135 * libmodest-dbus-client/libmodest-dbus-client.c:
2136 (libmodest_dbus_client_delete_message):
2137 Implement deletion of messages (Client side).
2139 (modest_search_hit_free),
2140 (modest_search_hit_list_free):
2141 Utility functions to free the result hits.
2143 * src/dbus_api/modest-dbus-api.h:
2144 * src/dbus_api/modest-dbus-callbacks.c:
2145 (on_delete_message),
2146 (modest_dbus_req_handler):
2147 Implement deletion of messages (Server side).
2149 * tests/dbus_api/test_search.c: (main):
2152 * tests/dbus_api/Makefile.am:
2153 * tests/dbus_api/test_delete_message:
2154 Add little test for the message deletion logic
2156 2007-06-03 Armin Burgmeier <armin@openismus.com>
2158 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2159 when the operation queue was not empty. projects.maemo.org bug
2162 2007-06-03 Armin Burgmeier <armin@openismus.com>
2164 * src/widgets/modest-account-view.c
2165 (on_account_default_toggled): Toggle default account column
2166 explicitely instead of waiting for gconf notification (which is
2167 currently ignored). This should fix projects.maemo.org bug NB#56910
2168 for now. It should probably be removed when gconf notifications are
2171 2007-06-03 Christian Kellner <ckellner@openismus.com>
2173 * libmodest-dbus-client/libmodest-dbus-client.c:
2174 Removed debugging spew.
2176 * src/dbus_api/modest-dbus-callbacks.c:
2177 Added debugging info.
2179 * src/modest-search.c:
2180 (modest_search_all_accounts):
2181 Use tny_account_store_get_accounts () on the account store
2182 to get all accounts which is the way to get all accounts.
2184 * tests/dbus_api/test_search.c: (main):
2185 Make it possible to supply the search term on the command line.
2187 2007-06-03 Christian Kellner <ckellner@openismus.com>
2189 * libmodest-dbus-client/libmodest-dbus-client.c:
2190 * libmodest-dbus-client/libmodest-dbus-client.h:
2191 Implement searching for mesages over raw dbus. (Client side)
2193 * src/dbus_api/Makefile.am:
2194 * src/dbus_api/modest-dbus-api.h:
2195 * src/dbus_api/modest-dbus-callbacks.c:
2196 * src/dbus_api/modest-dbus-callbacks.h:
2197 Search framework (Server side). Also implement on_idle_open_message().
2199 * src/maemo/modest-platform.c: (modest_platform_init):
2200 Prepare for raw dbus/osso rpc interaction.
2202 * src/modest-search.h:
2203 Changed minsize from unspecific guint to guint32.
2205 * src/modest-search.c:
2207 Added strange hack which magically made tnymail work.
2209 (modest_search_folder),
2210 (modest_search_account),
2211 (modest_search_all_accounts):
2212 Implement helper functions to search all accounts, specific account
2215 * tests/dbus_api/Makefile.am:
2216 * tests/dbus_api/test_open_message.c:
2217 Read url to open from commandline.
2219 * tests/dbus_api/test_search.c:
2220 Implement small test for dbus search stuff
2222 2007-06-02 Armin Burgmeier <armin@openismus.com>
2224 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2225 include account type and account title. This fixes projects.maemo.org
2228 * src/maemo/modest-account-view-window.c: Set a title for the window.
2230 2007-06-02 Armin Burgmeier <armin@openismus.com>
2232 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2233 incoming and outgoing server name based on email address and server
2234 types as long as the names have not been edited manually. This fixes
2235 projects.maemo.org bug NB#58671.
2237 2007-06-02 Armin Burgmeier <armin@openismus.com>
2239 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2240 server type cannot be changed in future to the incoming details page
2241 when creating an account. This fixes projects.maemo.org bug NB#59029.
2243 2007-06-02 Armin Burgmeier <armin@openismus.com>
2245 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2246 and assigned max width chars so that they wrap instead of being
2247 truncated. Fixes projects.maemo.org bug NB#56126.
2249 2007-06-02 Armin Burgmeier <armin@openismus.com>
2251 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2252 introductory note to the connection specific smtp servers dialog, as
2253 section 8.12 of the email UI specification requires. This fixes
2254 projects.maemo.org bug NB#59212.
2256 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2258 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2259 Check for running mail operations, and offer to cancel them, as per the UI
2260 spec. This fixes projects.maemo.org bug NB#59041 .
2261 However, I suspect that tinymail may still use the network connection
2262 in ways that we cannot detect or cancel. But it should at least adapt to
2263 changes fairly well.
2265 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2267 * src/modest-tny-account-store.c: (recreate_all_accounts),
2268 (get_cached_accounts), (get_server_accounts): Do more sensible
2269 ref-counting of the temporarily-cached outbox accounts list. This seems
2270 to fix a crash when entering the password when the password was wrong.
2272 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2274 * src/gnome/modest-main-window.c: (connect_signals):
2275 * src/modest-tny-account-store.c: (get_password),
2276 (modest_tny_account_store_alert): Added comments and clues and
2277 commented-out code about how we currently fail to deal with connection
2278 errors and wrong passwords, and how we should.
2280 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2282 * src/widgets/modest-retrieve-combo-box.c:
2283 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2284 This fixes projects.maemo.org bug NB#58472 .
2286 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2288 * src/maemo/easysetup/modest-easysetup-wizard.c:
2289 (create_page_complete_easysetup):
2290 (create_page_complete_custom): Correct the last commit,
2291 putting the correct sentences in the correct pages.
2293 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2295 * src/maemo/easysetup/modest-easysetup-wizard.c:
2296 (create_page_complete_custom): Show the second sentence of text
2297 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2300 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2302 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2303 Set the leave-on-server conf key by default. This fixes
2304 projects.maemo.org bug NB#59258 .
2306 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2308 * src/maemo/modest-account-view-window.c:
2309 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2310 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2313 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2315 * src/maemo/easysetup/modest-easysetup-wizard.c:
2316 (create_caption_new_with_asterisk):
2317 * src/maemo/modest-account-settings-dialog.c:
2318 (create_caption_new_with_asterisk):
2319 Uncomment the code to add the asterisk, because they are no longer in the
2320 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2321 (update_incoming_server_title): Add an asterisk here too.
2323 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2325 * src/maemo/modest-maemo-global-settings-dialog.c:
2326 (current_connection): Check that we are even connected before trying to
2327 get the current connection name, to prevent a warning.
2329 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2330 Change the comments because tny_maemo_conic_device_connect() is now meant to
2332 * src/modest-mail-operation.c:
2333 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2334 make sure we have a connection and fail if we can't connect.
2336 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2338 * src/maemo/modest-main-window.c:
2339 (on_account_store_connecting_finished): Do not try to get the
2340 connection ID if we are not really connected. I am surprised that
2341 this signal handler is called when we are not connected.
2343 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2345 * src/modest-error.h:
2346 * src/modest-ui-actions.c:
2347 (modest_ui_actions_get_msgs_full_error_handler):
2348 Renamed an enum, added comments, added an enum
2349 for retrieve-limit errors.
2351 * src/modest-mail-operation.c: (foreach_add_item),
2352 (internal_folder_observer_update), (update_account_thread),
2353 (modest_mail_operation_get_msgs_full):
2354 (modest_mail_operation_update_account),
2355 Added comments about how this works, and some code that should
2356 (but does not) check the retrieve-limit. See the TODO comment.
2358 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2360 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2361 Initialize help_id to fix the build. Warnings are good.
2363 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2365 * src/widgets/modest-hbox-cell-renderer.c:
2366 (modest_hbox_cell_renderer_append):
2367 * src/widgets/modest-vbox-cell-renderer.c:
2368 (modest_vbox_cell_renderer_append):
2369 Fix the last commit by doing an extra ref.
2371 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2373 * src/widgets/modest-hbox-cell-renderer.c:
2374 (modest_hbox_cell_renderer_append):
2375 * src/widgets/modest-vbox-cell-renderer.c:
2376 (modest_vbox_cell_renderer_append):
2377 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2378 to fix the build with Maemo Bora.
2379 However, there seems to be a remaining crash, probably due to reference
2382 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2384 * src/modest-tny-account.c:
2385 (modest_tny_account_new_for_local_folders):
2386 Use hildon_file_system_info_async_new() to get a better name for
2387 the memory card account, setting it as the account name.
2388 The timing seems to work, but this is probably
2389 not the best place to do this. See the TODO comment.
2390 * src/maemo/modest-main-window.c: (create_details_widget):
2391 * src/widgets/modest-folder-view.c: (text_cell_data):
2392 Use the tny account name instead of hardcoding a name.
2394 2007-05-30 Christian Kellner <ckellner@openismus.com>
2396 * src/modest-search.c: (modest_search):
2397 Correctly set part_search_func even if we have already parsed
2398 the query and thus a valid OgsTextSearcher object.
2400 2007-05-30 Christian Kellner <ckellner@openismus.com>
2403 Search and check for libogs.
2406 Incooparte the ogs build env.
2408 * src/modest-mime-part-search-stream.c:
2409 * src/modest-mime-part-search-stream.h:
2410 Removed since we do the real searching now in modest-search.c.
2412 * src/modest-search.c:
2413 * src/modest-search.h:
2414 Implement support for ogs. We use that if available and requested
2415 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2416 should now handle the corner case when the search term is spread
2417 across multiple reads.
2418 Also the logic in modest_search () was corrected to search all
2419 requested fields until one is found.
2421 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2425 * src/modest-init.h:
2426 * src/modest-init.c: Made modest_init_local_folders() take a
2427 path and be public so we can iniitialize maildir folders on
2430 * src/modest-local-folder-info.h:
2431 * src/modest-local-folder-info.c:
2432 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2434 * src/modest-tny-account.c:
2435 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2436 still means the standard local-folders path on the local volume.
2438 * src/modest-tny-account-store.c:
2439 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2440 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2441 all accounts when that happens.
2442 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2443 this too, so it shows up in the treeview.
2445 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2447 * src/maemo/modest-maemo-global-settings-dialog.c:
2448 (current_connection):
2449 * src/widgets/modest-global-settings-dialog.c:
2450 (current_connection_default):
2451 Use the enum values instead of 0, 1 and -1,
2452 to make the code clearer.
2454 * src/modest-account-mgr-helpers.c:
2455 (modest_account_mgr_get_connection_specific_smtp): Make this code
2458 * src/modest-runtime.h:
2459 * src/modest-runtime.c:
2460 Added modest_runtime_remove_all_send_queues().
2461 * src/maemo/modest-main-window.c:
2462 (on_account_store_connecting_finished): Recreate the send queues,
2463 using the appropriate transport accounts for this new connection.
2464 Some futher adapting might be needed if the old send queues are not
2465 automatically stopped at this point.
2467 * src/modest-tny-account-store.c: (get_server_accounts):
2468 Create the connection-specific transport accounts, so that they can
2469 be found later by their ID.
2471 * src/modest-tny-account.h:
2472 * src/modest-tny-account.c:
2473 Added modest_tny_account_new_from_server_account_name().
2474 modest_tny_account_new_from_server_account(): Do not create the
2475 send queues here, because they will be
2476 recreated anyway when the connection changes for the first time.
2478 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2480 * src/modest-local-folder-info.h:
2481 * src/modest-local-folder-info.c:
2482 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2483 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2484 tbox_folder): Take a modest account name instead of a server TnyAccount,
2485 so we can have per-modest-account rather than per-transport-account
2487 We must make sure that we change or recreate the exisitng send queues
2488 when the connection changes for connection-specific transport accounts.
2490 * src/modest-tny-account-store.c:
2491 (create_per_account_local_outbox_folders): Create outboxed per modest
2492 account, not per transport account.
2494 * src/modest-tny-account.h:
2495 * src/modest-tny-account.c:
2496 (modest_tny_account_get_special_folder): For outboxes, get the
2497 parent modest account name. The account is ignored for other folders.
2498 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2499 modest account name rather than a server TnyAccount.
2501 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2503 * src/modest-tny-account.c:
2504 (modest_tny_account_new_from_server_account):
2505 Call modest_runtime_get_send_queue() immediately after creating transport
2506 accounts, so that they start trying to send email from the outbox as soon
2507 as possible at startup. This is probably what we want.
2509 * src/modest-mail-operation.c: (update_account_thread):
2510 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2511 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2512 * src/modest-tny-send-queue.h:
2513 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2514 (modest_ui_actions_on_send):
2515 Added comments about how sending works, though it needs some more work.
2517 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2519 * src/modest-tny-account.c:
2520 (modest_tny_account_get_special_folder): Add TODO because this fails when
2521 the network is busy.
2522 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2523 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2524 Do not try to show this window when there is no active account. The UI
2525 specs does not tell us what to do in this case.
2527 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/Makefile.am:
2532 * src/widgets/Makefile.am: Some dist fixes.
2534 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2536 * src/maemo/modest-connection-specific-smtp-window.c:
2537 (on_button_edit): Make the code clearer, to prevent a double free.
2539 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2541 * src/maemo/modest-account-settings-dialog.c:
2542 (modest_account_settings_dialog_set_account_name),
2543 Check the connection-specific smtp servers checkbox if there are any.
2545 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2546 (modest_connection_specific_smtp_edit_window_init):
2547 Start with a suitable port number.
2549 * src/modest-account-mgr-helpers.h:
2550 * src/modest-account-mgr-helpers.c: Added
2551 modest_account_mgr_get_has_connection_specific_smtp().
2553 (modest_account_mgr_set_connection_specific_smtp),
2554 (modest_account_mgr_remove_connection_specific_smtp),
2555 (modest_account_mgr_get_has_connection_specific_smtp),
2556 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2557 connection-specific smtp server accounts in the account, rather than
2558 the server account conf dir.
2560 This fixes bug projects.maemo.org bug NB#58263 .
2562 * src/modest-tny-account-store.c:
2563 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2564 if there are no server accounts yet, to prevent an infinite loop when there
2565 are no accounts. Document that one must be called before the other.
2567 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2569 * src/modest-account-mgr-helpers.c:
2570 (modest_account_mgr_get_default_account): Make sure that at least
2571 one account is always the default, if there are any enabled accounts.
2572 This is just a sanity check that shouldn't be necessary.
2574 * src/modest-account-mgr-priv.c:
2575 (_modest_account_mgr_account_from_key): Unescape the conf key to
2576 get the real account name. For instance, this is an issue if a space
2577 was in the account name, which can happen because the account name
2578 is generated from the display name.
2579 (_modest_account_mgr_get_account_keyname): Always escape the
2581 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2582 Unescape the conf keys to get the real account names.
2584 For instance, previously the is-default radio button in the accounts
2585 list was not checked for any accounts at first. This fixes that,
2586 and might fix several similar bugs.
2588 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2590 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2591 Removed some debug printfs.
2593 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2595 Modest on-disk outbox directories are now here, for instance:
2596 $HOME/.modest/outboxes/<account-id-1>/outbox
2597 $HOME/.modest/outboxes/<account-id-2>/outbox
2599 $HOME/.modest/local-folders/outbox
2600 so we can have a separate outbox for each account.
2601 But they are shown as one outbox in the GtkTreeView, by using a
2602 TnyMergeFolder in a ModestTnySimpleFolderStore.
2605 * src/modest-tny-simple-folder-store.c:
2606 * src/modest-tny-simple-folder-store.h:
2607 Added ModestTnySimpleFolderStore, used to contain folders from
2608 other folder stores, such as other accounts.
2610 * src/modest-tny-outbox-account.h:
2611 * src/modest-tny-outbox-account.c:
2612 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2613 used for the per-account local outbox folders.
2615 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2616 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2617 only use this (internally) now for the non-outbox local folders.
2619 * src/modest-init.h:
2620 * src/modest-init.c: Added modest_init_one_local_folder(), for
2621 setting up the directory structure for each local folder.
2623 * src/modest-local-folder-info.c:
2624 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2625 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2627 * src/modest-local-folder-info.h:
2628 * src/modest-tny-account-store.c: (on_account_removed),
2629 (on_account_changed), (create_per_account_local_outbox_folders),
2630 (get_server_accounts), (modest_tny_account_store_get_accounts),
2631 (modest_tny_account_store_get_tny_account_by_account),
2632 (modest_tny_folder_store_is_virtual_local_folders):
2634 * src/modest-tny-account.h:
2635 * src/modest-tny-account.c:
2636 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2637 to create an on-disk per-account local outbox folder for each
2639 (create_per_account_local_outbox_folders): Create a local outbox folder
2640 for each transport account.
2641 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2642 for all local folders.
2644 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2645 instead of using g_object_get/set() directly. It is clearer.
2647 (modest_tny_folder_store_get_message_count),
2648 (modest_tny_folder_store_get_local_size
2649 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2650 because we now use these with non-acount folder stores.
2652 (modest_tny_account_get_special_folder),
2653 (modest_tny_account_new_from_server_account),
2654 (modest_tny_account_new_from_account):
2655 (recurse_folders): Adjust to the new outbox system.
2657 * src/modest-tny-folder.h:
2658 * src/modest-tny-folder.c:
2659 (modest_tny_folder_is_local_folder),
2660 (modest_tny_folder_get_local_folder_type),
2661 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2663 * src/widgets/modest-main-window.h:
2664 * src/maemo/modest-main-window.c: (create_details_widget),
2665 (modest_main_window_set_contents_style): Show details for any folder store,
2668 (modest_tny_folder_get_rules):
2669 Remove the const. C does not support constness enough for this.
2671 * src/modest-ui-actions.c:
2672 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2673 make all outboxes appear as one, in the usual local-folders tree node.
2675 (set_active_account_from_tny_account),
2676 (modest_ui_actions_on_folder_selection_changed):
2677 * src/widgets/modest-folder-view.c: (text_cell_data),
2678 (icon_cell_data), (filter_row),
2679 (add_account_folders_to_merged_folder),
2680 (add_account_folders_to_simple_folder_store), (),
2681 (get_cmp_rows_type_pos), (cmp_rows),
2682 (modest_folder_view_set_account_id_of_visible_server_account):
2683 Adjust to the new outbox system, using generic folder stores and folders
2684 in the GtkTreeModel.
2686 2007-05-23 Christian Kellner <ckellner@openismus.com>
2688 * src/modest-mail-operation.c:
2689 (modest_mail_operation_update_account):
2690 Use info->max_size instead of unintialized local var [small
2691 build fix]. (Added TODO to review that change since I don't
2694 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2696 * libmodest-dbus-client/libmodest-dbus-client.c:
2697 (libmodest_dbus_client_compose_mail): function added
2698 * src/dbus_api/modest-dbus-api.h:
2699 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2700 (on_compose_mail): Implementation of the SendAsMail functionality
2702 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2704 * src/modest-account-mgr.c:
2705 (modest_account_mgr_add_server_account): Set the secure-connection
2706 conf key for transport accounts as well as store accounts. I don't know
2707 why the if was there. For instance, this makes sure that we use SSL
2708 for the gmail preset from the easysetup wizard.
2710 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2712 * src/gnome/modest-main-window.c:
2713 (on_account_store_connecting_finished), (connect_signals):
2714 * src/maemo/modest-main-window.c:
2715 (on_account_store_connecting_finished), (connect_signals),
2716 (modest_main_window_new):
2717 Handle TnyAccountStore::connecting-finished instead of
2718 TnyDevice::connection-changed, because we cannot actually perform
2719 operations on accounts until TnyAccountStore has itself responded to
2720 the TnyDevice::connection-changed signal. This prevents a GError from
2722 Do not try to update at startup, because we (at least on scratchbox)
2723 already do an update at startup when the device goes online.
2724 This prevents a GError from tinymail.
2725 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2726 Added TODO about stopping simultaneous operations.
2728 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2730 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2731 * src/modest-mail-operation-queue.c:
2732 (modest_mail_operation_queue_remove):
2733 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2734 about where they happened.
2736 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2738 * src/modest-ui-actions.c:
2739 (modest_ui_actions_on_password_requested): Make sure that the remember
2740 output parameter is always TRUE.
2742 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2744 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2745 Show a OK/Cancel dialog if the error is a question, though we still do not
2746 know anything more about what we are asking the user.
2747 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2748 Fix an uninitialized variable (helper). This is a logic error, however.
2750 2007-05-21 Christian Kellner <ckellner@openismus.com>
2752 * src/modest-search.h:
2753 Correct bit shifting in the ModestSearchFlags enum.
2755 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2757 * src/modest-tny-account.c:
2758 (modest_tny_account_new_from_server_account): Do not use the lsub and
2759 check-all hard-coded IMAP options when using POP.
2761 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2763 * src/modest-tny-account.c:
2764 (modest_tny_account_new_from_server_account):
2765 Use NULL for the secure-auth method for POP when Password auth has been
2766 specified by the user, as we already do for IMAP. "auth=Login" causes
2767 an error from camel or the server.
2769 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2771 * src/maemo/modest-account-settings-dialog.c:
2772 (create_page_account_details),
2773 (modest_account_settings_dialog_set_account_name):
2774 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2775 for the leave-on-server checkbox, rathr than just the checkbox, when
2776 the protocol is not POP.
2778 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2780 * src/widgets/modest-account-view.c:
2781 * src/widgets/modest-account-view.h:
2782 Added modest_account_view_select_account() which will be useful later
2783 to asynchronously re-select the edited account.
2785 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/modest-account-settings-dialog.c:
2788 (modest_account_settings_dialog_set_account_name):
2789 Automatically choose the port numbers based on the secure authentication
2790 methods, if they have not been chosen before.
2791 This fixes projects.maemo.org bug NB#56273 .
2793 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2795 * src/maemo/modest-main-window-ui.h:
2796 * src/modest-ui-actions.c:
2797 * src/modest-ui-actions.h:
2798 Connect the Tools/SMTP Servers menu item to
2799 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2800 SMTP servers dialog, as in the UI specification and saves changes when it
2801 is closed. This fixed projects.maemo.org bug NB#56305 .
2803 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2805 * src/maemo/modest-connection-specific-smtp-window.c:
2806 (modest_connection_specific_smtp_window_init):
2807 Use gtk_window_set_default_size() to make this window big enough, so
2808 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2810 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2813 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2814 (modest_connection_specific_smtp_edit_window_init),
2815 Do not try to connect to a combobox signal before the combobox exists.
2816 This fixes the cras in projects.maemo.org bug NB#56288 .
2817 (modest_connection_specific_smtp_edit_window_get_settings):
2818 Remove the server_account_name parameter which was being checked for NULL
2819 though it was not used.
2821 * src/maemo/modest-connection-specific-smtp-window.c:
2822 (modest_connection_specific_smtp_window_fill_with_connections),
2823 (on_button_edit), (modest_connection_specific_smtp_window_init):
2824 Correct the number of treemodel columns to prevent a warning.
2825 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2826 libconic does not work.
2828 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2830 * src/modest-tny-account.c:
2831 (modest_tny_account_new_from_server_account):
2832 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2833 SMTP when "None" was chosen by the user. However, with my SMTP server that
2834 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2837 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2840 to explain the memory management issue with the ID in the ModestPair.
2842 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2843 (add_sending_page), (modest_account_assistant_finalize):
2844 * src/gnome/modest-gnome-global-settings-dialog.c:
2845 (create_updating_page), (create_composing_page):
2846 * src/gnome/modest-msg-edit-window.c: (get_transports),
2847 (init_window), (modest_msg_edit_window_finalize),
2848 (modest_msg_edit_window_get_msg_data):
2849 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2850 * src/gnome/modest-transport-widget.c:
2851 (modest_transport_widget_finalize), (smtp_configuration):
2852 * src/maemo/modest-maemo-global-settings-dialog.c:
2853 (create_updating_page), (create_composing_page):
2854 * src/maemo/modest-msg-edit-window.c: (get_transports),
2855 (init_window), (modest_msg_edit_window_finalize),
2856 (modest_msg_edit_window_get_msg_data),
2857 (modest_msg_edit_window_free_msg_data):
2858 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2859 (modest_store_widget_finalize):
2860 * src/maemo/modest-transport-widget.c:
2861 (modest_transport_widget_finalize), (smtp_configuration):
2862 * src/modest-main.c: (send_mail):
2863 * src/widgets/modest-combo-box.h:
2864 * src/widgets/modest-global-settings-dialog-priv.h:
2865 * src/widgets/modest-global-settings-dialog.c:
2866 (modest_global_settings_dialog_finalize):
2867 * src/widgets/modest-msg-edit-window.h:
2868 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2869 as long as the combo box, to prevent use of freed memory for the ID.
2871 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2873 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2874 get_accounts(), to make this clearer. Do not check for the enabled gconf
2875 key, because we do not use this for server accounts (at least, not yet).
2876 This allows us to send email again.
2878 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2880 * src/maemo/modest-platform.c:
2881 (on_modest_conf_update_interval_changed), (modest_platform_init):
2882 Only respond to this particular key change. All these strcmp()s cannot be
2885 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2887 * src/maemo/modest-maemo-global-settings-dialog.c:
2888 (current_connection): Prevent a crash in scratchbox when
2889 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2890 * src/maemo/modest-platform.c:
2891 (on_modest_conf_update_interval_changed), (modest_platform_init):
2892 Get the update interval from gconf and reset it when the gconf key changes.
2894 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2896 * src/modest-protocol-info.c:
2897 * src/modest-protocol-info.h: Adde enum-specific get functions,
2898 instead of using a ModestProtocolType enum parameter.
2900 * src/gnome/modest-account-assistant.c:
2901 * src/gnome/modest-store-widget.c:
2902 * src/gnome/modest-store-widget.h:
2903 * src/gnome/modest-transport-widget.c:
2904 * src/gnome/modest-transport-widget.h:
2905 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2906 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2907 * src/maemo/easysetup/modest-easysetup-wizard.c:
2908 * src/maemo/modest-account-settings-dialog.c:
2909 * src/maemo/modest-account-settings-dialog.h:
2910 * src/maemo/modest-store-widget.c:
2911 * src/maemo/modest-store-widget.h:
2912 * src/maemo/modest-transport-widget.c:
2913 * src/maemo/modest-transport-widget.h:
2914 * src/modest-account-mgr-helpers.c:
2915 * src/modest-account-mgr-helpers.h:
2916 * src/modest-account-mgr.c:
2917 * src/modest-account-mgr.h:
2918 * src/modest-tny-account.c:
2919 * src/modest-tny-folder.c:
2920 * src/widgets/modest-account-view.c:
2921 * src/widgets/modest-retrieve-combo-box.c:
2922 * src/widgets/modest-retrieve-combo-box.h:
2923 * src/widgets/modest-secureauth-combo-box.c:
2924 * src/widgets/modest-serversecurity-combo-box.c:
2925 * src/widgets/modest-serversecurity-combo-box.h:
2926 * tests/check_account-mgr.c:
2927 Use the specific functions, and use the re-renamed enum values for GNOME too.
2929 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2931 * src/modest-pair.h:
2932 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2933 so we can get the second based on the first.
2935 * src/maemo/modest-account-settings-dialog.h:
2936 * src/maemo/modest-account-settings-dialog.c:
2937 Added get_supported_secure_authentication_methods(), though it is mostly
2938 commented-out for now until the necessary API is committed to tinymail.
2939 (modest_account_settings_dialog_set_account_name),
2940 (save_configuration): Request the supported authentication methods from the
2941 server, so we can choose a working method.
2943 * src/modest-tny-account-store.h:
2944 * src/modest-tny-account-store.c:
2945 (modest_tny_account_store_get_session): Rename from
2946 tny_account_store_get_session().
2948 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2950 * src/modest-protocol-info.h: Split the ModestProtocol enum
2951 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2952 There was no need to have these unrelated values in one enum.
2954 * src/: many files: Adapted to changed enum. This makes the code a bit
2955 clearer, and the compiler could catch some errors.
2957 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2959 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2960 Show the detailed internal camel error message when an error happens
2961 during the configuration, so that our testers can give us more clues.
2962 For instance, in projects.maemo.org bug NB#56910 .
2964 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2966 * src/modest-tny-account.c:
2967 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2968 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2970 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2972 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2973 * src/maemo/modest-account-settings-dialog.c:
2974 (modest_account_settings_dialog_set_account_name),
2975 (save_configuration): For the incoming secure authentication checkbox,
2976 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2977 the UI specification. PLAIN does not seem to be supported for most IMAP
2978 servers anyway, and I am not sure what it would mean.
2979 However, we probably need to discover which of the secure-authentication
2980 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2981 * src/modest-account-mgr-helpers.c:
2982 (modest_account_mgr_get_server_account_data):
2984 * src/modest-tny-account.c:
2985 (modest_tny_account_new_from_server_account):
2986 Use tny_account_set_mech() to set secure-authentication methods,
2987 with some special-casing for IMAP, based on my observations of how
2990 * src/modest-account-mgr-helpers.h:
2991 * src/modest-account-mgr.c:
2992 * src/modest-defs.h: Comment that the URI is only used for local folders.
2994 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2996 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2997 parameter const, just to be neat.
2998 * src/modest-text-utils.c: (modest_text_utils_inline):
2999 End g_strconcat() with NULL, as its documentation says. This is almost
3000 certainly the cause of my crash at startup on the device. Interestingly,
3001 valgrind doesn't tell us about these errors.
3003 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3005 * scripts/build-packages: Added more precise comments about how to use
3006 this script, though I still get this error:
3007 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3008 error building tinymail
3010 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3012 * src/maemo/modest-main-window.c: (on_account_update):
3013 Very slight cleanup, hoping to make it simpler to discover what causes
3014 a crash here sometimes.
3016 * src/modest-tny-account.c:
3017 (modest_tny_account_new_from_server_account): Set the port. Added
3018 comments about the options and a TODO comment because I need to find out
3019 how to specify the secure authentication method.
3021 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3023 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3024 changed CFlags paths form modest to libmodest
3026 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3028 * src/modest-account-mgr-helpers.c:
3029 (modest_account_mgr_get_server_account_data),
3030 (modest_account_mgr_free_server_account_data):
3031 * src/modest-account-mgr-helpers.h:
3032 * src/modest-account-mgr.c:
3033 (modest_account_mgr_add_server_account):
3034 * src/modest-defs.h:
3035 * src/modest-tny-account.c:
3036 (modest_tny_account_new_from_server_account):
3037 Determine the options for tny_camel_account_add_option() here,
3038 based on the settings, rather than storing them directly in gconf.
3040 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3043 Show a more friendly error dialog now that we expect (from the tinymail
3044 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3046 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3048 * src/maemo/modest-main-window.c: (on_account_update): Check that
3049 account_name is not NULL, to prevent a crash at startup that I am
3050 seeing on the N800. I do wonder why it is NULL.
3052 * src/maemo/easysetup/modest-easysetup-wizard.c:
3053 (create_page_user_details):
3054 * src/maemo/modest-account-settings-dialog.c:
3055 (create_page_user_details), (create_page_outgoing):
3056 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3057 (modest_connection_specific_smtp_edit_window_init):
3058 * src/modest-ui-actions.c:
3059 (modest_ui_actions_on_password_requested):
3060 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3061 might do something useful with the on-screen keyboard.
3063 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3065 * src/maemo/modest-main-window.c: (on_account_update):
3066 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3067 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3069 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3071 * src/modest-tny-account-store.c: (on_account_changed):
3072 Correct the signature of this signal handler.
3074 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3076 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3077 Show a HildonNote instead of a GtkDialog for Maemo.
3079 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3081 * src/widgets/modest-account-view.h:
3082 * src/widgets/modest-account-view.c: (on_account_changed),
3083 (on_account_removed). Added a boolean flag, set/unset by
3084 modest_account_view_block_conf_updates(),
3085 modest_account_view_unblock_conf_updates() to prevent unnecessary
3086 updates, but this is not very useful because the gconf notifications are
3087 so delays (maybe only on Maemo Bora).
3088 So auto-updating is turned off, and these functions do an explicit
3089 update when necessary.
3090 However, something else is still doing too much work when adding/removing
3091 accounts, probably in another part of the application.
3093 * src/maemo/modest-account-view-window.c:
3094 (on_delete_button_clicked), (on_edit_button_clicked),
3095 (on_new_button_clicked): Use the new functions.
3097 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3099 * src/modest-account-mgr-helpers.c:
3100 (modest_account_mgr_set_first_account_as_default):
3101 Sort the list of names alphabetically-by-title, so we choose the first one
3103 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3104 alphabetically by the title.
3106 This fixes projects.maemo.org bug NB#56418 .
3108 * src/modest-account-mgr-priv.c:
3109 (_modest_account_mgr_account_from_key):
3110 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3111 avoid a valgrind error, and possible random behaviour.
3113 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3115 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3116 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3117 tinymail documentation to say that this can be expected.
3118 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3119 pretty, and should not happen, but I would prefer to know when it does.
3121 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3123 * configure.ac: When using the older hildon version, probably on Bora,
3124 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3126 * src/widgets/modest-attachment-view.c:
3127 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3130 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3132 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3133 Implemented the prototype. Can be tested with
3134 tests/dbus_api/test_open_message:
3136 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3138 * src/modest-tny-account-store.c:
3139 (modest_tny_account_store_instance_init), (get_password):
3140 * src/modest-ui-actions.c:
3141 (modest_ui_actions_on_password_requested):
3142 Do not store the password in gconf, because this function is called
3143 for non-remembered passwords. Actually use the cached (in the hash map)
3144 password instead of releasing it.
3145 The password will now not be remembered if it is asked via the protected
3146 password dialog, as per the UI spec.
3148 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3150 * src/modest-defs.h:
3151 * src/modest-account-mgr-helpers.h:
3152 * src/modest-account-mgr-helpers.c:
3153 Added modest_server_account_get_username_has_succeeded(),
3154 modest_server_account_set_username_has_succeeded().
3155 (modest_server_account_set_username),
3156 Reset the has-succeeded flag if the username changes.
3158 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3159 * src/maemo/modest-connection-specific-smtp-window.c:
3160 (modest_connection_specific_smtp_window_save_server_accounts):
3161 Use modest_server_account_set_username() instead of using
3162 modest_conf_set_string() directly, so that the has-succeeded flag is always
3165 * src/modest-ui-actions.c:
3166 (modest_ui_actions_on_password_requested): Dim the username entry if
3167 the username has ever worked, as per the UI spec.
3169 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3171 * src/modest-tny-account-store.c: (get_password):
3172 * src/modest-ui-actions.c:
3173 (modest_ui_actions_on_password_requested):
3174 Allow the username to be changed too, though there is more work to
3175 be done on exactly how this behaves.
3177 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3179 * src/modest-account-mgr-helpers.h:
3180 * src/modest-account-mgr-helpers.c:
3181 Added modest_account_mgr_get_display_name(),
3182 modest_server_account_get_username(),
3183 modest_server_account_set_username(),
3184 modest_server_account_set_password(),
3185 modest_server_account_get_hostname() functions so we do not need to
3186 use the conf API directly.
3188 * src/maemo/modest-main-window.c: (connect_signals):
3189 Actually connect ot the ModestAccountStore::request-password signal,
3190 so that we show the dialog when the password is requested by Tinymail,
3191 for isntance if it is empty.
3193 * src/modest-marshal.list:
3194 * src/modest-tny-account-store.c:
3195 (modest_tny_account_store_class_init), (get_password),
3196 (modest_tny_account_store_alert):
3197 * src/modest-tny-account-store.h:
3198 * src/modest-ui-actions.h:
3199 * src/modest-ui-actions.c:
3200 (modest_ui_actions_on_password_requested):
3201 Change the signal parameters, so it is obvious that we are providing
3202 the non human-readable server name, and receiving both the username
3203 and password, though changing of the username is not yet implemented.
3204 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3205 for the GNOME version.
3207 This should fix the projects.maemo.org bug NB#56209, though it does not
3208 work on Bora, because the gconf_client_get() for the password fails
3209 immediately after we save it with gconf_client_set().
3211 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3214 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3215 caused an undefined symbol error:
3216 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3218 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3220 * src/modest-tny-account-store.c:
3221 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3222 using a GError instead of a string message, so we can translate it in
3225 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/modest-address-book.c:
3228 (modest_address_book_check_names):
3229 * src/maemo/modest-msg-view-window.c:
3230 (modest_msg_view_window_clipboard_owner_change):
3231 * src/modest-init.c: (modest_init_init_ui):
3232 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3233 (update_folders_cb), (modest_mail_operation_update_account):
3234 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3235 (modest_ui_actions_on_msg_attachment_clicked),
3236 (modest_ui_actions_on_msg_recpt_activated):
3237 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3238 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3239 (modest_msg_view_search_next):
3240 * src/widgets/modest-recpt-editor.c:
3241 (modest_recpt_editor_on_button_release_event),
3242 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3243 g_message(). At this point we should only be seeing interesting errors on
3244 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3246 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3248 (modest_wizard_dialog_force_title_update):
3249 * src/maemo/easysetup/modest-wizard-dialog.h:
3250 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3251 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3252 can update the title when appropriate. Otherwise the title is wrong if the
3253 pages are added after adding the notebook to the dialog.
3254 This must be a problem in HildonWizardDialog too.
3255 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3257 * src/maemo/easysetup/modest-easysetup-wizard.c:
3258 (create_subsequent_customsetup_pages),
3259 (create_subsequent_easysetup_pages):
3260 Call modest_wizard_dialog_force_title_update() so that the title is
3261 correct even with GTK+ < 2.10.
3262 This fixes projects.maemo.org bug NB#56145 .
3264 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-platform.c:
3267 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3268 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3271 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3273 * src/widgets/modest-window.h:
3274 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3275 and modest_window_save_state(), which invokes it.
3277 * src/widgets/modest-window-mgr.h:
3278 * src/widgets/modest-window-mgr.c:
3279 Added modest_window_mgr_save_state_for_all_windows(), which calls
3280 the save_state vfunc on all registered windows, if implemented.
3282 * src/gnome/modest-msg-edit-window.c:
3283 * src/gnome/modest-msg-view-window.c:
3284 * src/maemo/modest-msg-edit-window.c:
3285 * src/maemo/modest-msg-view-window.c:
3286 * src/maemo/modest-main-window.c:
3287 Specify the existing save_settings functions as implementations of
3288 ModestWindow::save_state_func().
3290 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3291 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3292 enabling hibernation, for instance.
3294 We may need to do the same thing for restoring settings.
3297 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3299 * src/widgets/modest-window-mgr.c:
3300 * src/widgets/modest-window-mgr.h:
3301 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3302 modest_window_mgr_get_hibernation_is_prevented().
3304 * src/maemo/modest-main-window.c:
3305 (on_hildon_program_is_topmost_notify): Prevent hibernation
3306 (possible when the application goes to the background in the WM),
3307 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3309 * src/maemo/easysetup/modest-easysetup-wizard.c:
3310 (modest_easysetup_wizard_dialog_init):
3311 * src/maemo/modest-account-settings-dialog.c:
3312 (modest_account_settings_dialog_init):
3313 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3314 (modest_connection_specific_smtp_edit_window_init):
3315 * src/maemo/modest-connection-specific-smtp-window.c:
3316 (modest_connection_specific_smtp_window_init):
3317 * src/maemo/modest-signature-editor-dialog.c:
3318 (modest_signature_editor_dialog_init):
3319 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3320 prevent hibernation while any of these account settings dialogs are open.
3322 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/Makefile.am:
3325 * src/maemo/modest-osso-state-saving.c:
3326 * src/maemo/modest-osso-state-saving.h: Added
3327 modest_osso_load_state() and modest_osso_save_state() though they do
3328 nothing now. They should iterate through all the open windows and load/save
3330 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3331 save state when closing.
3333 * src/maemo/modest-main-window.c:
3334 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3335 Add a notification handler for the HildonProgram::is-topmost property,
3336 so we can allow hibernation when the application goes into the background.
3337 But we still need to detect when the accounts setup windows are open so
3338 we can stop hibernation when they are open.
3339 To do this, I also added the main window the HildonProgram. This might have
3340 other side-effects/benefits, and should maybe be done for other windows.
3342 * src/maemo/modest-osso-autosave-callbacks.h:
3343 * src/maemo/modest-osso-autosave-callbacks.c:
3344 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3345 though it does not do anything yet, and we might never need this to do
3346 anything. For instance, we already save drafts.
3348 * src/maemo/modest-platform.c: (modest_platform_init):
3349 Specify the libosso auto-save callback.
3351 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3353 * src/maemo/modest-platform.c:
3354 (modest_platform_set_update_interval):
3355 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3356 aparently stays valid between application instances, so we can use this
3357 to remove and reset it later. According to a maemo-developers email from
3360 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3362 * configure.ac: Depend on libalarm for Maemo.
3364 * src/dbus_api/modest-dbus-api.h:
3365 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3366 (on_send_receive), (modest_dbus_req_handler):
3367 Handle a SEND_RECEIVE D-Bus method.
3369 * libmodest-dbus-client/libmodest-dbus-client.c:
3370 (libmodest_dbus_client_send_and_receive):
3371 * libmodest-dbus-client/libmodest-dbus-client.h:
3372 Add C convenience functions for calling the new D-Bus method.
3374 * src/modest-platform.h:
3375 * src/gnome/modest-platform.c:
3376 * src/maemo/modest-platform.c:
3377 Added modest_platform_set_update_interval(), which uses the
3378 alarmd API on Maemo.
3379 (modest_platform_init),
3380 Call modest_platform_set_update_interval(), using a hard-coded
3381 interval for now (until the global settings dialog is implemented),
3382 though I am not sure that this makes sense yet.
3384 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3386 * src/dbus_api/modest-dbus-callbacks.c:
3387 (modest_osso_cb_hw_state_handler):
3388 * src/dbus_api/modest-dbus-callbacks.h:
3389 * src/maemo/modest-platform.c: (modest_platform_init):
3390 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3391 in case this has some effect on the ability for Maemo to ping the
3394 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3396 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3397 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3398 warning. It is probably a logic error, but I need to fix the build.
3400 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3402 * src/modest-account-mgr.h:
3403 * src/modest-account-mgr.c:
3404 (modest_account_mgr_account_names): Add a gboolean enabled_only
3405 parameter, so we can get lists of onlt the enabled accounts.
3407 (modest_account_mgr_add_account),,
3408 (modest_account_mgr_account_with_display_name_exists):
3409 * src/maemo/modest-msg-edit-window.c: (get_transports):
3410 * src/modest-account-mgr-helpers.c:
3411 (modest_account_mgr_set_first_account_as_default):
3412 * src/modest-init.c: (init_default_account_maybe):
3413 * src/modest-tny-account-store.c: (get_accounts):
3414 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3415 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3416 * tests/check_account-mgr.c: (START_TEST):
3417 Provide the extra parameter, as appropriate.
3419 * src/widgets/modest-account-view.c: (update_account_view):
3420 Do not show disabled accounts (meaning that there is no way to
3421 enable/disable accounts in the UI (the feature is not in our UI
3422 specification), so we can use this internally only to mark unfinished
3423 or temporary account data.
3425 * src/maemo/easysetup/modest-easysetup-wizard.c:
3426 (create_account): Add boolean enable parameter, so we can specify FALSE
3427 to create the temporary account.
3428 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3429 (on_before_next): When finishing, when there is a temporary account, just
3431 Also, use a timeout to delay the showing of the dialog until gconf is likely
3432 to return correct information, due to a maemo gconf bug that is fixed in
3433 osso 1.1, but not yet in Bora.
3434 However, the dialog stays on screen after it is destroyed.
3436 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3437 for invalid data when cancelling. Use a hildon note instead of a dialog
3438 to complain about invalid data. Do not show the account-saved note if the
3439 account is disabled (a temporary account that will not really be saved for use
3442 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3444 * src/modest-account-mgr-helpers.h:
3445 * src/modest-account-mgr-helpers.c:
3446 Added modest_account_mgr_unset_default_account(),
3447 Added modest_account_mgr_set_first_account_as_default().
3449 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3450 If it was the default account, unset the default account name.
3452 * src/maemo/modest-account-view-window.c:
3453 (on_delete_button_clicked): If it was the default account,
3454 set the first remaining account as the default instead.
3456 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3457 a NULL account or a NULL default account, to prevent a crash. This should
3458 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3461 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3463 * src/widgets/modest-recpt-editor.c:
3464 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3465 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3466 TODO comment for this. This fixes the build.
3468 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3469 be the best place for it. This will in future update all auto-update accounts,
3470 rather than just the current/default account, when that gconf key exists.
3471 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3472 if there are no accounts, before calling do_send_receive().
3473 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3475 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3476 * src/maemo/modest-main-window-ui.h:
3477 * src/maemo/modest-main-window.c: (on_connection_changed),
3478 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3479 directly, becaue the signal handler does more.
3481 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3483 * src/modest-account-mgr-helpers.c:
3484 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3485 for the case that the account does not exist.
3487 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3488 (equivalent to the modest account name) rather than the tinymail account name
3489 (equivalent to the modest account title - human readable) to get the account data.
3490 Check for null account data to prevent the crash, and add a TODO comment saying that
3491 this needs fixing because it is using the server account name instead of the account name.
3493 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3495 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3496 * src/maemo/modest-account-settings-dialog.c: (show_error),
3498 Use hildon_note_new_information() for informative and error messages,
3499 which seems to be expected for Maemo applications (no documentation that I know of
3500 says this). I am surprised that there is no distinction between info and error
3503 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3505 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3506 it is easy to find where this is used.
3508 * src/maemo/easysetup/modest-easysetup-wizard.c:
3509 (create_page_welcome), (create_page_account_details),
3510 (create_page_user_details), (create_page_complete_easysetup),
3511 (create_page_custom_incoming), (create_page_custom_outgoing),
3512 (create_page_complete_custom):
3513 * src/maemo/modest-account-settings-dialog.c:
3514 (create_page_account_details), (create_page_user_details),
3515 (create_page_incoming), (create_page_outgoing):
3516 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3517 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3518 (modest_connection_specific_smtp_edit_window_init):
3519 * src/maemo/modest-connection-specific-smtp-window.c:
3520 (modest_connection_specific_smtp_window_init):
3521 * src/maemo/modest-signature-editor-dialog.c:
3522 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3523 and scrolling policy as per the Email Application Layout Guide, if I have
3526 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3528 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3529 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3530 which were empty, because these vfuncs have been removed from TnyAccountStore.
3531 This fixes the build.
3533 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3535 * src/maemo/modest-main-window.c:
3536 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3537 showing/hiding it. Added TODO because it probably should not be NULL.
3538 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3539 because unnecessary g_warnings() make degugging difficult.
3541 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3543 * src/maemo/modest-msg-edit-window.c:
3544 (modest_msg_edit_window_select_color),
3545 (modest_msg_edit_window_select_background_color): 2 const corrections and
3546 moving 2 #endifs before closing brackets, to fix the build.
3548 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3550 * src/maemo/easysetup/modest-easysetup-wizard.h:
3551 * src/maemo/easysetup/modest-easysetup-wizard.c:
3552 (modest_easysetup_wizard_dialog_finalize),
3553 (on_button_edit_advanced_settings), (create_page_complete_custom),
3554 (on_response), (create_account):
3555 Implement the Advanced Settings edit button, by saving the account information,
3556 for the Advanded Settings dialog to use directly from gconf, and removing it
3557 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3558 Bug #5533 in the projects.maemo.org bugzilla.
3560 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3562 * src/maemo/modest-msg-view-window.c:
3563 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3564 when opening a message window.
3566 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3568 * src/maemo/easysetup/modest-easysetup-wizard.c:
3569 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3572 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3573 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3574 gconf settings. I probably added more checks than necessary, but that is safer.
3576 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3577 variable to fix the build, but this seems to be used when it is still NULL.
3579 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3581 * src/modest-platform.h:
3582 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3583 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3584 * src/modest-main.c: Implement this function so we can avoid using
3585 maemo-specific API from cross-platform code.
3587 * src/modest-tny-account-store.c:
3588 (get_smtp_specific_transport_account_for_open_connection):
3589 * src/modest-ui-actions.c: (check_for_connection),
3590 (modest_ui_actions_on_item_not_found):
3591 Use modest_platform_connect_and_wait() and put #idefs around other
3592 maemo-specific code, because only maemo currently has a way to
3593 identify connection names.
3595 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3597 * src/modest-tny-account-store.h:
3598 * src/modest-tny-account-store.c:
3599 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3600 the connection-specific SMTP server settings in the configuration.
3602 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3604 * src/maemo/modest-main-window.c: (on_connection_changed),
3606 * src/modest-main.c: (main), (start_ui), (send_mail):
3607 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3608 that is what is intended.
3610 * src/modest-ui-actions.c: (action_send), (action_receive),
3611 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3612 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3613 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3614 SMTP server is used when it is specified.
3616 (modest_ui_actions_on_send_receive):
3617 Check that a connection is open before proceeding.
3618 Receive and then send, instead of vice-versa, as per the specification.
3620 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3622 * src/modest-mail-operation.c:
3623 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3624 though I guess it should be something other than NULL.
3626 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3628 * src/maemo/easysetup/modest-easysetup-wizard.c:
3629 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3630 combo twice, to avoid an g_warning and to make it visible again.
3631 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3632 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3633 (already intended) dereference when detaching, because we then recreate the menu.
3634 But I am not sure why the warning was happening, and it is possible that this is a memory
3637 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3639 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3640 and uri_parse_mailto() utility functions.
3641 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3643 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3645 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3647 * src/dbus_api/modest-dbus-api.h:
3648 * src/dbus_api/modest-dbus-callbacks.c:
3649 Use an idle callback to execute the modest code in the application's own thread.
3650 Remove the helloworld example method.
3651 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3652 parsed, and the open-message method is not implemented because this is not yet implemented in
3654 * libmodest-dbus-client/libmodest-dbus-client.c:
3655 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3656 (libmodest_dbus_client_open_message):
3657 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3659 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3660 body without crashing.
3662 * tests/dbus_api/Makefile.am:
3663 * tests/dbus_api/test_mail_to.c:
3664 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3666 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3668 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3669 Added file to fix the build. Sorry.
3671 * src/dbus_api/Makefile.am:
3672 * src/dbus_api/modest-dbus-api.h:
3673 * src/dbus_api/modest-dbus-callbacks.h:
3674 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3675 (modest_dbus_req_handler):
3676 Put constants in a separate header so it can be reused by the
3677 client library, without duplication
3679 * libmodest-dbus-client/Makefile.am:
3680 * libmodest-dbus-client/libmodest-dbus-client.c:
3681 (libmodest_dbus_client_call_helloworld),
3682 (libmodfest_dbus_client_send_mail),
3683 (libmodfest_dbus_client_mailto),
3684 (libmodfest_dbus_client_open_message):
3685 * libmodest-dbus-client/libmodest-dbus-client.h:
3686 (Partly) Implement a send_mail D-Bus method.
3688 * tests/dbus_api/Makefile.am:
3689 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3690 the send_email D-Bus method.
3692 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3696 * libmodest-dbus-client/Makefile.am:
3697 * libmodest-dbus-client/libmodest-dbus-client.c:
3698 * libmodest-dbus-client/libmodest-dbus-client.h:
3699 * tests/dbus_api/Makefile.am:
3700 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3701 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3703 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3705 * src/maemo/easysetup/modest-easysetup-wizard.c:
3706 (create_page_account_details):
3707 * src/maemo/modest-account-settings-dialog.c:
3708 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3709 widgets, because this might not be the default in future versions of the Maemo GTK+.
3710 However, I can not not get capitalization to work even in a simple test case.
3712 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3714 * src/maemo/easysetup/modest-easysetup-wizard.c:
3715 (create_page_custom_incoming), (create_page_custom_outgoing):
3716 * src/maemo/modest-account-settings-dialog.c:
3717 (create_page_account_details), (create_page_incoming),
3718 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3719 instead of using gtk_check_button_with_label(), so they are aligned like the other
3720 widgets, as per the UI spec.
3722 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3724 * src/maemo/easysetup/modest-easysetup-wizard.c:
3725 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3726 * src/widgets/modest-validating-entry.c:
3727 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3728 Modest prefix instead of an EasySetup prefix.
3730 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3732 * src/widgets/modest-validating-entry.h:
3733 * src/widgets/modest-validating-entry.c: (on_insert_text),
3734 Added easysetup_validating_entry_set_max_func(), used to set a callback
3735 to call when the max number of characters is reached. GtkEntry has a max-length
3736 already but is silent about it.
3738 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3739 (create_page_account_details), (create_page_user_details),
3741 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3742 (create_page_account_details), (create_page_user_details),
3743 (create_page_outgoing):
3744 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3745 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3746 the UI spec, when the user tries to enter more than the max number of characters.
3748 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3750 * src/maemo/easysetup/modest-easysetup-wizard.c:
3751 (create_page_user_details), (create_page_custom_incoming),
3752 (create_page_custom_outgoing):
3753 * src/maemo/modest-account-settings-dialog.c:
3754 (create_page_user_details), (create_page_incoming),
3755 (create_page_outgoing):
3756 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3757 (modest_connection_specific_smtp_edit_window_init):
3758 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3759 not appropriate. Bad Maemo-specific defaults!.
3761 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3763 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3764 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3765 (modest_signature_editor_dialog_set_settings):
3766 Disable the label and textview when the checkbox is disabled, and use the
3767 specified (UI spec) default signature text.
3769 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3771 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3772 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3774 * src/modest-defs.h:
3775 * src/modest-account-mgr-helpers.h:
3776 * src/modest-account-mgr-helpers.c:
3777 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3779 * src/maemo/Makefile.am:
3780 * src/maemo/modest-signature-editor-dialog.c:
3781 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3784 * src/maemo/modest-account-settings-dialog.h:
3785 * src/maemo/modest-account-settings-dialog.c:
3786 (modest_account_settings_dialog_finalize), (on_button_signature),
3787 (save_configuration): Use the new dialog when the Edit button is pressed, and
3788 save the changes if necessary, as per the UI spec.
3790 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3792 * src/maemo/Makefile.am:
3793 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3794 based on maemo-develoers email from Dirk.
3796 * src/maemo/easysetup/modest-easysetup-wizard.c:
3797 (create_page_welcome), (create_page_account_details),
3798 (create_page_user_details), (create_page_complete_easysetup),
3799 (create_page_custom_incoming), (create_page_custom_outgoing),
3800 (create_page_complete_custom),
3801 (modest_easysetup_wizard_dialog_init):
3802 * src/maemo/modest-account-settings-dialog.c:
3803 (create_page_account_details), (create_page_user_details),
3804 (create_page_incoming), (create_page_outgoing),
3805 (modest_account_settings_dialog_init):
3806 * src/maemo/modest-connection-specific-smtp-window.c:
3807 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3809 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3811 * src/maemo/easysetup/modest-easysetup-wizard.c:
3812 (create_page_account_details), (create_page_custom_outgoing),
3813 (create_page_complete_custom):
3814 * src/maemo/modest-account-settings-dialog.c:
3815 (create_page_user_details), (create_page_incoming),
3816 (create_page_outgoing):
3817 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3818 (modest_connection_specific_smtp_edit_window_init):
3819 Use the correct (UI spec) port min/max, and use horizontal separators,
3822 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3824 * src/maemo/easysetup/modest-easysetup-wizard.c:
3825 (set_default_custom_servernames):
3826 * src/maemo/modest-account-settings-dialog.c:
3827 (create_page_incoming), (on_combo_outgoing_security_changed),
3828 (on_combo_incoming_security_changed), (create_page_outgoing),
3829 (modest_account_settings_dialog_set_account_name),
3830 (save_configuration):
3831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3832 (on_combo_security_changed),
3833 (modest_connection_specific_smtp_edit_window_init),
3834 (modest_connection_specific_smtp_edit_window_set_connection),
3835 (modest_connection_specific_smtp_edit_window_get_settings):
3836 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3839 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3842 * src/maemo/easysetup/modest-easysetup-wizard.c:
3843 (create_page_custom_outgoing), (create_page_complete_custom):
3844 * src/maemo/modest-account-settings-dialog.c:
3845 (create_page_user_details), (create_page_outgoing):
3846 * src/maemo/modest-account-view-window.c: (button_box_new):
3847 Use changed logical IDs as per the most recent UI spec:
3848 mcen_bd_emailsetup_edit -> mcen_bd_edit
3849 mcen_bd_emailsetup_delete -> mcen_bd_delete
3850 mcen_bd_emailsetup_close -> mcen_bd_close
3852 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3856 * src/dbus_api/Makefile.am:
3857 * src/dbus_api/modest-dbus-callbacks.c:
3858 * src/dbus_api/modest-dbus-callbacks.h:
3859 * src/maemo/modest-platform.c: (modest_platform_init):
3860 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3862 * tests/Makefile.am:
3863 * tests/dbus_api/Makefile.am:
3864 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3866 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3868 * src/maemo/modest-account-settings-dialog.c:
3869 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3870 Removed unnecessary includes.
3872 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/easysetup/modest-easysetup-wizard.c:
3875 * src/maemo/modest-account-settings-dialog.c:
3876 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3877 * src/widgets/Makefile.am:
3878 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3879 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3880 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3881 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3882 * src/widgets/modest-secureauth-combo-box.c:
3883 * src/widgets/modest-secureauth-combo-box.h:
3884 * src/widgets/modest-serversecurity-combo-box.c:
3885 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3886 made the GObject names more consistent with the rest of the Modest code.
3888 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3890 * src/maemo/easysetup/Makefile.am:
3891 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3892 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3893 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3894 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3895 * src/maemo/easysetup/modest-easysetup-wizard.c:
3896 * src/maemo/easysetup/modest-validating-entry.c:
3897 * src/maemo/easysetup/modest-validating-entry.h:
3898 * src/maemo/modest-account-settings-dialog.c:
3899 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3900 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3901 widgets/ because they are used outside of easysetup too. After checking in,
3902 svn will allow me to rename them too.
3904 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3906 * src/gnome/modest-msg-edit-window.c:
3907 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3908 linker error, to fix the build on the GNOME platform.
3909 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3910 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3911 ifdefed out to avoid a warning.
3913 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3915 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3916 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3917 some alternative for GTK+ 2.6.
3919 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3921 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3923 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3924 specified for EmailAccountsDialog in UI spec.
3926 * src/maemo/easysetup/modest-easysetup-wizard.c:
3927 * src/maemo/easysetup/modest-easysetup-wizard.h:
3928 * src/maemo/modest-account-settings-dialog.c:
3929 * src/maemo/modest-account-settings-dialog.h:
3930 Reuse a member window widget for the connection-specific SMTP server accounts,
3931 so we can tell it to create/save the accounts only if we actually save changes.
3933 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3934 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3935 (modest_connection_specific_smtp_edit_window_get_settings):
3936 Return a struct instance for temporarily remembering the entered data.
3938 * src/maemo/modest-connection-specific-smtp-window.h:
3939 * src/maemo/modest-connection-specific-smtp-window.c:
3940 (modest_connection_specific_smtp_window_finalize),
3941 (modest_connection_specific_smtp_window_fill_with_connections),
3943 (modest_connection_specific_smtp_window_save_server_accounts),
3944 (update_model_server_names): Do not actually save data until asked,
3945 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3947 (on_selection_changed),
3948 (modest_connection_specific_smtp_window_init): Disable the edit
3949 button when nothing is selected.
3951 * src/modest-account-mgr-helpers.c:
3952 * src/modest-account-mgr-helpers.h:
3953 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3956 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3958 * src/modest-account-mgr-helpers.h:
3959 * src/modest-account-mgr-helpers.c:
3960 (modest_account_mgr_get_unused_account_name),
3961 (modest_account_mgr_get_unused_account_display_name): Added these
3962 utility functions, to avoid code duplication.
3964 * src/maemo/easysetup/modest-easysetup-wizard.c:
3965 (create_page_account_details), (create_account):
3966 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3967 (on_combo_security_changed),
3968 (modest_connection_specific_smtp_edit_window_init),
3969 (modest_connection_specific_smtp_edit_window_save_settings):
3970 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3971 * src/maemo/modest-connection-specific-smtp-window.c:
3972 (modest_connection_specific_smtp_window_finalize),
3973 (modest_connection_specific_smtp_window_fill_with_connections),
3974 (on_button_edit), (modest_connection_specific_smtp_window_init):
3975 * src/maemo/modest-connection-specific-smtp-window.h:
3976 Implementing saving of connection-specific server accounts.
3978 But I need to refactor this so we can save the data for each
3979 possible connection-specific account and only actually create the server accounts
3980 when the easysetup finished, or the OK button is pressed on the account settings
3983 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3985 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3986 (on_combo_security_changed):
3987 (modest_connection_specific_smtp_edit_window_init):
3988 Auto-fill the port number as in the account settings.
3990 (modest_connection_specific_smtp_edit_window_set_connection):
3991 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3992 * src/maemo/modest-connection-specific-smtp-window.c:
3993 (fill_with_connections), (on_button_edit),
3994 (modest_connection_specific_smtp_window_init):
3995 Turn the edit window into a dialog to simplify the code, and
3996 set a WM hint as in a GtkDialog, because only a popup can be on top of
3997 another window in Maemo, and popups usually have no WM decoration.
3999 * src/modest-defs.h:
4000 * src/modest-account-mgr-helpers.c:
4001 (modest_account_mgr_set_connection_specific_smtp),
4002 (modest_account_mgr_remove_connection_specific_smtp),
4003 (modest_account_mgr_get_connection_specific_smtp):
4004 * src/modest-account-mgr-helpers.h: Some functions to write the
4005 connection-specific SMTP server information. Not yet used.
4008 * src/widgets/modest-folder-view.c: (text_cell_data):
4009 Fix a warning about an uninitialized variable.
4010 (on_configuration_key_changed): Put an #ifdef around the use
4011 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4013 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4015 * src/maemo/modest-account-settings-dialog.h:
4016 * src/maemo/modest-account-settings-dialog.c:
4017 Added connect_for_modified() utility function to mark the new modified boolean.
4019 (create_page_account_details), (create_page_user_details),
4020 (create_page_incoming), (create_page_outgoing), (on_response),
4021 (modest_account_settings_dialog_init),
4022 (modest_account_settings_dialog_set_account_name):
4023 Only warn about unsaved changes when there are actually unsaved changes.
4025 * src/modest-account-mgr-helpers.c:
4026 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4027 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4028 to get the data from there in future.
4030 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4032 * src/modest-defs.h:
4034 * src/modest-account-mgr-helpers.h:
4035 * src/modest-account-mgr-helpers.c:
4036 Store the security account setting in a single conf key instead of using
4037 the options list, so that the list is left for just the to-be-removed camel hack,
4038 and because gconf_client_set_list() is failing for some reason.
4040 * src/modest-account-mgr.c:
4041 (modest_account_mgr_add_server_account):
4042 * src/maemo/modest-account-settings-dialog.c:
4043 (modest_account_settings_dialog_set_account_name),
4044 (save_configuration): Use the renamed functions.
4047 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4049 * src/widgets/Makefile.am:
4050 * src/widgets/modest-limit-retrieve-combo-box.c:
4051 * src/widgets/modest-limit-retrieve-combo-box.h:
4052 * src/widgets/modest-retrieve-combo-box.c:
4053 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4054 the account settings dialog.
4056 * src/modest-defs.h:
4057 * src/modest-account-mgr-helpers.h:
4058 * src/modest-account-mgr-helpers.c:
4059 (modest_server_account_get_option_secure_auth),
4060 (modest_server_account_set_option_secure_auth):
4061 * src/modest-account-mgr.c:
4062 (modest_account_mgr_add_server_account):
4063 Use the existing AUTH_MECH conf key for the secure-auth setting,
4064 instead of putting it in the list options, because this was actually used already.
4066 * src/maemo/modest-account-settings-dialog.c:
4067 (create_page_account_details),
4068 (modest_account_settings_dialog_set_account_name),
4069 (save_configuration):
4070 * src/maemo/modest-account-settings-dialog.h:
4071 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4072 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4074 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4076 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4077 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4078 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4080 * src/modest-defs.h:
4081 * src/maemo/modest-account-settings-dialog.c:
4082 (create_page_incoming), (on_combo_outgoing_security_changed),
4083 (on_combo_incoming_security_changed), (create_page_outgoing),
4084 (modest_account_settings_dialog_set_account_name),
4085 (save_configuration): Load/Save the port number, and change it when the
4086 security combo changes, to suitable defaults.
4088 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4090 * src/modest-account-mgr.c:
4091 (modest_account_mgr_add_server_account): Set the security and secure-auth
4092 options, and add a comment saying that the other camel-specific options should be
4095 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4097 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4099 * src/modest-tny-account-store.c: (account_list_free),
4100 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4101 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4104 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4106 * src/modest-protocol-info.c:
4107 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4108 is required by our UI spec. Maybe something in our implementation will use this eventually.
4109 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4110 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4111 instead of the previous 0 placeholder.
4113 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4114 secure-auth settings.
4115 * src/modest-account-mgr-helpers.h:
4116 * src/modest-account-mgr-helpers.c:
4117 (modest_server_account_data_get_option_secure_auth),
4118 (modest_server_account_set_option_secure_auth),
4119 (modest_server_account_data_get_option_security),
4120 (modest_server_account_set_option_security): Added this API for getting and setting the security
4121 and secure-auth settings.
4123 * src/maemo/modest-account-settings-dialog.h:
4124 * src/maemo/modest-account-settings-dialog.c:
4125 (modest_account_settings_dialog_finalize), (check_data),
4126 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4127 about changing titles.
4128 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4129 (save_configuration): Save the security and secure-auth settings.
4131 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4132 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4134 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4136 * src/modest-defs.h:
4137 * src/modest-account-mgr.c:
4138 (modest_account_mgr_add_server_account):
4139 Added and used defines for the options key and value pair strings,
4140 that are used so far, though they do not seem to correspond to anything in our
4141 UI specs or ModestProtocol enum.
4143 * src/modest-account-mgr-helpers.h:
4144 * src/modest-account-mgr-helpers.c:
4145 (compare_option_strings_for_name),
4146 (modest_server_account_data_get_option_value),
4147 (modest_server_account_data_get_option_bool),
4148 (modest_account_mgr_get_server_account_option):
4149 Added helper functions for parsing the options GSList.
4151 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4153 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4154 display name is based on the supplied account name.
4155 * src/modest-account-mgr.c:
4156 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4157 with an inefficient, but good-enough, implementation.
4159 * src/maemo/easysetup/modest-easysetup-wizard.c:
4160 (create_page_account_details), (on_before_next), (create_account):
4161 Check for existing display names rather than (non-user-visible) account names, and just
4162 create and set a unique account name at the end.
4164 * src/maemo/modest-account-settings-dialog.c:
4165 (modest_account_settings_dialog_init),
4166 (modest_account_settings_dialog_set_account_name),
4167 (create_page_incoming): Show the display name, instead of the account name.
4168 (on_response): Do some (not all) extra checks, as in the UI spec.
4169 (save_configuration): Save the display name if it was changed.
4171 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4173 * po/en_GB.po: Added needed logical ID and translation.
4174 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4175 (init_view): Made the is-default column clicking work.
4177 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4180 * src/maemo/easysetup/Makefile.am:
4181 * src/maemo/easysetup/modest-easysetup-wizard.c:
4182 (modest_easysetup_wizard_dialog_init):
4183 * src/maemo/easysetup/provider-data-test.keyfile:
4184 * src/maemo/easysetup/provider-data.keyfile:
4185 Moved the provider data file to the new modest-providers-data package and used it from there.
4187 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4189 * src/modest-local-folder-info.c:
4190 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4191 N_() was already used on the static strings, but this just marks it for translation without
4192 using the translation.
4194 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4196 * src/maemo/modest-account-settings-dialog.c:
4197 (create_page_incoming),
4198 (modest_account_settings_dialog_set_account_name):
4199 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4200 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4201 I will do this if nobody else gets there first.
4203 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4205 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4206 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4207 save the security stuff.
4209 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4211 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4212 Set the email address and user fullname, which I now see must be
4215 * src/maemo/modest-account-settings-dialog.h:
4216 * src/maemo/modest-account-settings-dialog.c:
4218 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4219 leave-on-server and authentication.
4220 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4223 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4226 * src/maemo/modest-account-settings-dialog.c:
4227 * src/maemo/modest-account-settings-dialog.h:
4228 Most (but not all) of the widgets are now present as specified by the UI spec.
4229 No changes are yet saved, and some details are not properly shown yet.
4231 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4233 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4235 * src/maemo/Makefile.am:
4236 * src/maemo/modest-account-settings-dialog.c:
4237 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4238 an existing account. Doesn't do much yet.
4240 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4241 Open the accounts settings dialog when Edit is clicked.
4243 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4245 * src/maemo/easysetup/Makefile.am:
4246 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4248 * src/maemo/easysetup/modest-easysetup-wizard.c:
4249 (modest_easysetup_wizard_dialog_init):
4250 Try to get the source directory from the build system,
4251 instead of hard-coding "./" into the source code, when opening our local
4252 copies of the configuration files.
4253 But this still fails when opening the wizard from the Accounts window,
4254 maybe because the working directory seems to change at runtime.
4255 So the wizard will fail the second time unless you copy the files into their
4256 proper locations - see the stdout warnings for the paths.
4258 (create_page_account_details),(on_before_next):
4259 Check for existing non-server accounts instead of server accounts,
4260 so the default account name is useful again, and to prevent trying to
4263 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4264 Show the wizard when New is clicked.
4266 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4267 (init_view): Show the column headers, and show the columns that are
4268 specified in the UI specs. However, something in Maemo's GTK+ prevents
4269 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4270 change the default account. This is despite unsetting the special properties.
4272 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4274 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4275 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4276 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4277 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4278 to make that clearer.
4279 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4281 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4283 * src/maemo/modest-account-view-window.c:
4284 (modest_account_view_window_init),
4285 (modest_account_view_window_new):
4286 Use the same buttons as specified in the
4287 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4288 the existing widgets, which never had a chance of working.
4289 Put the ModestAccountView treeview in a scrolled window.
4290 Do not repeat the initialization in both _init() and _new().
4292 * src/widgets/modest-account-view.c: (update_account_view):
4293 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4294 this widget and window shows no accounts.
4296 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4298 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4300 * src/maemo/easysetup/modest-easysetup-wizard.c:
4301 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4302 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4303 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4306 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4307 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4308 accounts exist yet, as in the UI spec.
4310 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4312 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4314 * src/maemo/Makefile.am:
4315 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4316 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4317 New window for editing connection-specific smtp details.
4318 Not fully implemented.
4320 * src/maemo/modest-connection-specific-smtp-window.c:
4321 (modest_connection_specific_smtp_window_finalize) :
4322 unref the tree model.
4323 (on_button_edit): Show the edit window.
4325 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4327 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4330 * src/maemo/Makefile.am:
4331 * src/maemo/modest-connection-specific-smtp-window.c:
4332 * src/maemo/modest-connection-specific-smtp-window.h:
4333 New window for showing the list of connections, for connection-specific
4334 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4335 * src/maemo/easysetup/modest-easysetup-wizard.c:
4336 (create_page_custom_outgoing): Show the new window when the button is clicked.
4338 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4340 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4341 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4342 * src/maemo/modest-msg-edit-window.c:
4343 (modest_msg_edit_window_insert_image):
4344 * src/modest-conf.c: (modest_conf_key_escape):
4345 * src/modest-mail-operation.c:
4346 (modest_mail_operation_send_new_mail):
4347 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4348 (modest_ui_actions_on_new_account):
4349 * src/widgets/modest-attachment-view.c: (update_filename_request):
4350 * src/widgets/modest-mail-header-view.c:
4351 Corrected warnings that were breaking the build, by commenting out unused variables,
4352 and a function, and by including a header.
4354 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4356 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4357 so we can #ifdef around platform-specific code when necessary.
4358 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4359 to allow this to build for the GNOME platform too.
4361 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4363 * src/maemo/easysetup/modest-easysetup-wizard.c:
4364 Added util_increment_name() and used it in create_page_account_details()
4365 to make sure that the default account name is always a new name.
4367 (modest_easysetup_wizard_dialog_init),
4368 (set_default_custom_servernames): Some minor memory management fixes.
4370 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4374 * src/modest-runtime.c: (init_i18n): Restored the translation
4375 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4376 are defined in config.h, and the translations are installed.
4378 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4379 is defined for translation.
4381 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4383 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4385 * src/maemo/easysetup/modest-easysetup-wizard.c:
4386 (modest_easysetup_wizard_dialog_init):
4387 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4388 Use realistic paths (though they should use $prefix generically) to the
4389 mcc_mapping and provider-data.keyfile files which might work when they
4390 are installed by the future version of the operator-wizard package,
4391 and then fallback to paths in our source code, with an explanatory
4394 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4398 * src/maemo/Makefile.am:
4399 * src/maemo/easysetup/: Added files from the previously-exernal
4400 osso-modest-easysetup.
4401 * src/maemo/modest-main-window-ui.h:
4402 * src/modest-ui-actions.c:
4403 * src/modest-ui-actions.h:
4404 Added modest_ui_actions_on_new_account() as a signal handler for the
4405 New Account menu item. It shows the easysetup wizard.
4406 * po/en_GB.po: Added additional needed logical IDs and translations.