1 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-account-settings-dialog.c:
4 (modest_account_settings_dialog_set_account_name):
5 Automatically choose the port numbers based on the secure authentication
6 methods, if they have not been chosen before.
7 This fixes projects.maemo.org bug NB#56273 .
9 2007-05-17 Murray Cumming <murrayc@murrayc.com>
11 * src/maemo/modest-main-window-ui.h:
12 * src/modest-ui-actions.c:
13 * src/modest-ui-actions.h:
14 Connect the Tools/SMTP Servers menu item to
15 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
16 SMTP servers dialog, as in the UI specification and saves changes when it
17 is closed. This fixed projects.maemo.org bug NB#56305 .
19 2007-05-17 Murray Cumming <murrayc@murrayc.com>
21 * src/maemo/modest-connection-specific-smtp-window.c:
22 (modest_connection_specific_smtp_window_init):
23 Use gtk_window_set_default_size() to make this window big enough, so
24 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
26 2007-05-17 Murray Cumming <murrayc@murrayc.com>
28 * src/maemo/modest-connection-specific-smtp-edit-window.h:
29 * src/maemo/modest-connection-specific-smtp-edit-window.c:
30 (modest_connection_specific_smtp_edit_window_init),
31 Do not try to connect to a combobox signal before the combobox exists.
32 This fixes the cras in projects.maemo.org bug NB#56288 .
33 (modest_connection_specific_smtp_edit_window_get_settings):
34 Remove the server_account_name parameter which was being checked for NULL
35 though it was not used.
37 * src/maemo/modest-connection-specific-smtp-window.c:
38 (modest_connection_specific_smtp_window_fill_with_connections),
39 (on_button_edit), (modest_connection_specific_smtp_window_init):
40 Correct the number of treemodel columns to prevent a warning.
41 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
42 libconic does not work.
44 2007-05-16 Murray Cumming <murrayc@murrayc.com>
46 * src/modest-tny-account.c:
47 (modest_tny_account_new_from_server_account):
48 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
49 SMTP when "None" was chosen by the user. However, with my SMTP server that
50 does not support ANONYMOUS, the emails do not leave the Outbox and I see
53 2007-05-16 Murray Cumming <murrayc@murrayc.com>
55 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
56 to explain the memory management issue with the ID in the ModestPair.
58 * src/gnome/modest-account-assistant.c: (add_receiving_page),
59 (add_sending_page), (modest_account_assistant_finalize):
60 * src/gnome/modest-gnome-global-settings-dialog.c:
61 (create_updating_page), (create_composing_page):
62 * src/gnome/modest-msg-edit-window.c: (get_transports),
63 (init_window), (modest_msg_edit_window_finalize),
64 (modest_msg_edit_window_get_msg_data):
65 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
66 * src/gnome/modest-transport-widget.c:
67 (modest_transport_widget_finalize), (smtp_configuration):
68 * src/maemo/modest-maemo-global-settings-dialog.c:
69 (create_updating_page), (create_composing_page):
70 * src/maemo/modest-msg-edit-window.c: (get_transports),
71 (init_window), (modest_msg_edit_window_finalize),
72 (modest_msg_edit_window_get_msg_data),
73 (modest_msg_edit_window_free_msg_data):
74 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
75 (modest_store_widget_finalize):
76 * src/maemo/modest-transport-widget.c:
77 (modest_transport_widget_finalize), (smtp_configuration):
78 * src/modest-main.c: (send_mail):
79 * src/widgets/modest-combo-box.h:
80 * src/widgets/modest-global-settings-dialog-priv.h:
81 * src/widgets/modest-global-settings-dialog.c:
82 (modest_global_settings_dialog_finalize):
83 * src/widgets/modest-msg-edit-window.h:
84 Whenever using modest_combo_box_new(), keep the ModestPairList alive
85 as long as the combo box, to prevent use of freed memory for the ID.
87 2007-05-15 Murray Cumming <murrayc@murrayc.com>
89 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
90 get_accounts(), to make this clearer. Do not check for the enabled gconf
91 key, because we do not use this for server accounts (at least, not yet).
92 This allows us to send email again.
94 2007-05-15 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/modest-platform.c:
97 (on_modest_conf_update_interval_changed), (modest_platform_init):
98 Only respond to this particular key change. All these strcmp()s cannot be
101 2007-05-15 Murray Cumming <murrayc@murrayc.com>
103 * src/maemo/modest-maemo-global-settings-dialog.c:
104 (current_connection): Prevent a crash in scratchbox when
105 ny_maemo_conic_device_get_current_iap_id() returns NULL.
106 * src/maemo/modest-platform.c:
107 (on_modest_conf_update_interval_changed), (modest_platform_init):
108 Get the update interval from gconf and reset it when the gconf key changes.
110 2007-05-15 Murray Cumming <murrayc@murrayc.com>
112 * src/modest-protocol-info.c:
113 * src/modest-protocol-info.h: Adde enum-specific get functions,
114 instead of using a ModestProtocolType enum parameter.
116 * src/gnome/modest-account-assistant.c:
117 * src/gnome/modest-store-widget.c:
118 * src/gnome/modest-store-widget.h:
119 * src/gnome/modest-transport-widget.c:
120 * src/gnome/modest-transport-widget.h:
121 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
122 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
123 * src/maemo/easysetup/modest-easysetup-wizard.c:
124 * src/maemo/modest-account-settings-dialog.c:
125 * src/maemo/modest-account-settings-dialog.h:
126 * src/maemo/modest-store-widget.c:
127 * src/maemo/modest-store-widget.h:
128 * src/maemo/modest-transport-widget.c:
129 * src/maemo/modest-transport-widget.h:
130 * src/modest-account-mgr-helpers.c:
131 * src/modest-account-mgr-helpers.h:
132 * src/modest-account-mgr.c:
133 * src/modest-account-mgr.h:
134 * src/modest-tny-account.c:
135 * src/modest-tny-folder.c:
136 * src/widgets/modest-account-view.c:
137 * src/widgets/modest-retrieve-combo-box.c:
138 * src/widgets/modest-retrieve-combo-box.h:
139 * src/widgets/modest-secureauth-combo-box.c:
140 * src/widgets/modest-serversecurity-combo-box.c:
141 * src/widgets/modest-serversecurity-combo-box.h:
142 * tests/check_account-mgr.c:
143 Use the specific functions, and use the re-renamed enum values for GNOME too.
145 2007-05-15 Murray Cumming <murrayc@murrayc.com>
148 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
149 so we can get the second based on the first.
151 * src/maemo/modest-account-settings-dialog.h:
152 * src/maemo/modest-account-settings-dialog.c:
153 Added get_supported_secure_authentication_methods(), though it is mostly
154 commented-out for now until the necessary API is committed to tinymail.
155 (modest_account_settings_dialog_set_account_name),
156 (save_configuration): Request the supported authentication methods from the
157 server, so we can choose a working method.
159 * src/modest-tny-account-store.h:
160 * src/modest-tny-account-store.c:
161 (modest_tny_account_store_get_session): Rename from
162 tny_account_store_get_session().
164 2007-05-14 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-protocol-info.h: Split the ModestProtocol enum
167 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
168 There was no need to have these unrelated values in one enum.
170 * src/: many files: Adapted to changed enum. This makes the code a bit
171 clearer, and the compiler could catch some errors.
173 2007-05-14 Murray Cumming <murrayc@murrayc.com>
175 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
176 Show the detailed internal camel error message when an error happens
177 during the configuration, so that our testers can give us more clues.
178 For instance, in projects.maemo.org bug NB#56910 .
180 2007-05-14 Murray Cumming <murrayc@murrayc.com>
182 * src/modest-tny-account.c:
183 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
184 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
186 2007-05-14 Murray Cumming <murrayc@murrayc.com>
188 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
189 * src/maemo/modest-account-settings-dialog.c:
190 (modest_account_settings_dialog_set_account_name),
191 (save_configuration): For the incoming secure authentication checkbox,
192 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
193 the UI specification. PLAIN does not seem to be supported for most IMAP
194 servers anyway, and I am not sure what it would mean.
195 However, we probably need to discover which of the secure-authentication
196 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
197 * src/modest-account-mgr-helpers.c:
198 (modest_account_mgr_get_server_account_data):
200 * src/modest-tny-account.c:
201 (modest_tny_account_new_from_server_account):
202 Use tny_account_set_mech() to set secure-authentication methods,
203 with some special-casing for IMAP, based on my observations of how
206 * src/modest-account-mgr-helpers.h:
207 * src/modest-account-mgr.c:
208 * src/modest-defs.h: Comment that the URI is only used for local folders.
210 2007-05-11 Murray Cumming <murrayc@murrayc.com>
212 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
213 parameter const, just to be neat.
214 * src/modest-text-utils.c: (modest_text_utils_inline):
215 End g_strconcat() with NULL, as its documentation says. This is almost
216 certainly the cause of my crash at startup on the device. Interestingly,
217 valgrind doesn't tell us about these errors.
219 2007-05-11 Murray Cumming <murrayc@murrayc.com>
221 * scripts/build-packages: Added more precise comments about how to use
222 this script, though I still get this error:
223 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
224 error building tinymail
226 2007-05-11 Murray Cumming <murrayc@murrayc.com>
228 * src/maemo/modest-main-window.c: (on_account_update):
229 Very slight cleanup, hoping to make it simpler to discover what causes
230 a crash here sometimes.
232 * src/modest-tny-account.c:
233 (modest_tny_account_new_from_server_account): Set the port. Added
234 comments about the options and a TODO comment because I need to find out
235 how to specify the secure authentication method.
237 2007-05-11 Marcus Bauer <marcusb@openismus.com>
239 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
240 changed CFlags paths form modest to libmodest
242 2007-05-10 Murray Cumming <murrayc@murrayc.com>
244 * src/modest-account-mgr-helpers.c:
245 (modest_account_mgr_get_server_account_data),
246 (modest_account_mgr_free_server_account_data):
247 * src/modest-account-mgr-helpers.h:
248 * src/modest-account-mgr.c:
249 (modest_account_mgr_add_server_account):
251 * src/modest-tny-account.c:
252 (modest_tny_account_new_from_server_account):
253 Determine the options for tny_camel_account_add_option() here,
254 based on the settings, rather than storing them directly in gconf.
256 2007-05-10 Murray Cumming <murrayc@murrayc.com>
258 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
259 Show a more friendly error dialog now that we expect (from the tinymail
260 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
262 2007-05-10 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/modest-main-window.c: (on_account_update): Check that
265 account_name is not NULL, to prevent a crash at startup that I am
266 seeing on the N800. I do wonder why it is NULL.
268 * src/maemo/easysetup/modest-easysetup-wizard.c:
269 (create_page_user_details):
270 * src/maemo/modest-account-settings-dialog.c:
271 (create_page_user_details), (create_page_outgoing):
272 * src/maemo/modest-connection-specific-smtp-edit-window.c:
273 (modest_connection_specific_smtp_edit_window_init):
274 * src/modest-ui-actions.c:
275 (modest_ui_actions_on_password_requested):
276 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
277 might do something useful with the on-screen keyboard.
279 2007-05-10 Murray Cumming <murrayc@murrayc.com>
281 * src/maemo/modest-main-window.c: (on_account_update):
282 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
283 NULL, to avoid lots of warnings. However, it probably should not be NULL.
285 2007-05-09 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account-store.c: (on_account_changed):
288 Correct the signature of this signal handler.
290 2007-05-09 Murray Cumming <murrayc@murrayc.com>
292 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
293 Show a HildonNote instead of a GtkDialog for Maemo.
295 2007-05-09 Murray Cumming <murrayc@murrayc.com>
297 * src/widgets/modest-account-view.h:
298 * src/widgets/modest-account-view.c: (on_account_changed),
299 (on_account_removed). Added a boolean flag, set/unset by
300 modest_account_view_block_conf_updates(),
301 modest_account_view_unblock_conf_updates() to prevent unnecessary
302 updates, but this is not very useful because the gconf notifications are
303 so delays (maybe only on Maemo Bora).
304 So auto-updating is turned off, and these functions do an explicit
305 update when necessary.
306 However, something else is still doing too much work when adding/removing
307 accounts, probably in another part of the application.
309 * src/maemo/modest-account-view-window.c:
310 (on_delete_button_clicked), (on_edit_button_clicked),
311 (on_new_button_clicked): Use the new functions.
313 2007-05-09 Murray Cumming <murrayc@murrayc.com>
315 * src/modest-account-mgr-helpers.c:
316 (modest_account_mgr_set_first_account_as_default):
317 Sort the list of names alphabetically-by-title, so we choose the first one
319 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
320 alphabetically by the title.
322 This fixes projects.maemo.org bug NB#56418 .
324 * src/modest-account-mgr-priv.c:
325 (_modest_account_mgr_account_from_key):
326 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
327 avoid a valgrind error, and possible random behaviour.
329 2007-05-09 Murray Cumming <murrayc@murrayc.com>
331 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
332 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
333 tinymail documentation to say that this can be expected.
334 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
335 pretty, and should not happen, but I would prefer to know when it does.
337 2007-05-09 Murray Cumming <murrayc@murrayc.com>
339 * configure.ac: When using the older hildon version, probably on Bora,
340 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
342 * src/widgets/modest-attachment-view.c:
343 (modest_attachment_view_set_part_default): Initialize variables, to fix the
346 2007-05-09 Marcus Bauer <marcusb@openismus.com>
348 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
349 Implemented the prototype. Can be tested with
350 tests/dbus_api/test_open_message:
352 2007-05-08 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-tny-account-store.c:
355 (modest_tny_account_store_instance_init), (get_password):
356 * src/modest-ui-actions.c:
357 (modest_ui_actions_on_password_requested):
358 Do not store the password in gconf, because this function is called
359 for non-remembered passwords. Actually use the cached (in the hash map)
360 password instead of releasing it.
361 The password will now not be remembered if it is asked via the protected
362 password dialog, as per the UI spec.
364 2007-05-08 Murray Cumming <murrayc@murrayc.com>
367 * src/modest-account-mgr-helpers.h:
368 * src/modest-account-mgr-helpers.c:
369 Added modest_server_account_get_username_has_succeeded(),
370 modest_server_account_set_username_has_succeeded().
371 (modest_server_account_set_username),
372 Reset the has-succeeded flag if the username changes.
374 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
375 * src/maemo/modest-connection-specific-smtp-window.c:
376 (modest_connection_specific_smtp_window_save_server_accounts):
377 Use modest_server_account_set_username() instead of using
378 modest_conf_set_string() directly, so that the has-succeeded flag is always
381 * src/modest-ui-actions.c:
382 (modest_ui_actions_on_password_requested): Dim the username entry if
383 the username has ever worked, as per the UI spec.
385 2007-05-08 Murray Cumming <murrayc@murrayc.com>
387 * src/modest-tny-account-store.c: (get_password):
388 * src/modest-ui-actions.c:
389 (modest_ui_actions_on_password_requested):
390 Allow the username to be changed too, though there is more work to
391 be done on exactly how this behaves.
393 2007-05-08 Murray Cumming <murrayc@murrayc.com>
395 * src/modest-account-mgr-helpers.h:
396 * src/modest-account-mgr-helpers.c:
397 Added modest_account_mgr_get_display_name(),
398 modest_server_account_get_username(),
399 modest_server_account_set_username(),
400 modest_server_account_set_password(),
401 modest_server_account_get_hostname() functions so we do not need to
402 use the conf API directly.
404 * src/maemo/modest-main-window.c: (connect_signals):
405 Actually connect ot the ModestAccountStore::request-password signal,
406 so that we show the dialog when the password is requested by Tinymail,
407 for isntance if it is empty.
409 * src/modest-marshal.list:
410 * src/modest-tny-account-store.c:
411 (modest_tny_account_store_class_init), (get_password),
412 (modest_tny_account_store_alert):
413 * src/modest-tny-account-store.h:
414 * src/modest-ui-actions.h:
415 * src/modest-ui-actions.c:
416 (modest_ui_actions_on_password_requested):
417 Change the signal parameters, so it is obvious that we are providing
418 the non human-readable server name, and receiving both the username
419 and password, though changing of the username is not yet implemented.
420 Change the dialog UI to match the Maemo UI specifications, with #idfefing
421 for the GNOME version.
423 This should fix the projects.maemo.org bug NB#56209, though it does not
424 work on Bora, because the gconf_client_get() for the password fails
425 immediately after we save it with gconf_client_set().
427 2007-05-08 Murray Cumming <murrayc@murrayc.com>
430 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
431 caused an undefined symbol error:
432 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
434 2007-05-08 Murray Cumming <murrayc@murrayc.com>
436 * src/modest-tny-account-store.c:
437 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
438 using a GError instead of a string message, so we can translate it in
441 2007-05-08 Murray Cumming <murrayc@murrayc.com>
443 * src/maemo/modest-address-book.c:
444 (modest_address_book_check_names):
445 * src/maemo/modest-msg-view-window.c:
446 (modest_msg_view_window_clipboard_owner_change):
447 * src/modest-init.c: (modest_init_init_ui):
448 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
449 (update_folders_cb), (modest_mail_operation_update_account):
450 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
451 (modest_ui_actions_on_msg_attachment_clicked),
452 (modest_ui_actions_on_msg_recpt_activated):
453 * src/widgets/modest-header-view.c: (drag_data_get_cb):
454 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
455 (modest_msg_view_search_next):
456 * src/widgets/modest-recpt-editor.c:
457 (modest_recpt_editor_on_button_release_event),
458 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
459 g_message(). At this point we should only be seeing interesting errors on
460 stdout. Debugging messages could be #ifdefed-out if they are still useful.
462 2007-05-07 Murray Cumming <murrayc@murrayc.com>
464 (modest_wizard_dialog_force_title_update):
465 * src/maemo/easysetup/modest-wizard-dialog.h:
466 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
467 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
468 can update the title when appropriate. Otherwise the title is wrong if the
469 pages are added after adding the notebook to the dialog.
470 This must be a problem in HildonWizardDialog too.
471 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
473 * src/maemo/easysetup/modest-easysetup-wizard.c:
474 (create_subsequent_customsetup_pages),
475 (create_subsequent_easysetup_pages):
476 Call modest_wizard_dialog_force_title_update() so that the title is
477 correct even with GTK+ < 2.10.
478 This fixes projects.maemo.org bug NB#56145 .
480 2007-05-07 Murray Cumming <murrayc@murrayc.com>
482 * src/maemo/modest-platform.c:
483 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
484 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
487 2007-05-07 Murray Cumming <murrayc@murrayc.com>
489 * src/widgets/modest-window.h:
490 * src/widgets/modest-window.c: Added a save_state_func vfunc,
491 and modest_window_save_state(), which invokes it.
493 * src/widgets/modest-window-mgr.h:
494 * src/widgets/modest-window-mgr.c:
495 Added modest_window_mgr_save_state_for_all_windows(), which calls
496 the save_state vfunc on all registered windows, if implemented.
498 * src/gnome/modest-msg-edit-window.c:
499 * src/gnome/modest-msg-view-window.c:
500 * src/maemo/modest-msg-edit-window.c:
501 * src/maemo/modest-msg-view-window.c:
502 * src/maemo/modest-main-window.c:
503 Specify the existing save_settings functions as implementations of
504 ModestWindow::save_state_func().
506 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
507 Call modest_window_mgr_save_state_for_all_windows(). This happens before
508 enabling hibernation, for instance.
510 We may need to do the same thing for restoring settings.
513 2007-05-07 Murray Cumming <murrayc@murrayc.com>
515 * src/widgets/modest-window-mgr.c:
516 * src/widgets/modest-window-mgr.h:
517 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
518 modest_window_mgr_get_hibernation_is_prevented().
520 * src/maemo/modest-main-window.c:
521 (on_hildon_program_is_topmost_notify): Prevent hibernation
522 (possible when the application goes to the background in the WM),
523 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
525 * src/maemo/easysetup/modest-easysetup-wizard.c:
526 (modest_easysetup_wizard_dialog_init):
527 * src/maemo/modest-account-settings-dialog.c:
528 (modest_account_settings_dialog_init):
529 * src/maemo/modest-connection-specific-smtp-edit-window.c:
530 (modest_connection_specific_smtp_edit_window_init):
531 * src/maemo/modest-connection-specific-smtp-window.c:
532 (modest_connection_specific_smtp_window_init):
533 * src/maemo/modest-signature-editor-dialog.c:
534 (modest_signature_editor_dialog_init):
535 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
536 prevent hibernation while any of these account settings dialogs are open.
538 2007-05-04 Murray Cumming <murrayc@murrayc.com>
540 * src/maemo/Makefile.am:
541 * src/maemo/modest-osso-state-saving.c:
542 * src/maemo/modest-osso-state-saving.h: Added
543 modest_osso_load_state() and modest_osso_save_state() though they do
544 nothing now. They should iterate through all the open windows and load/save
546 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
547 save state when closing.
549 * src/maemo/modest-main-window.c:
550 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
551 Add a notification handler for the HildonProgram::is-topmost property,
552 so we can allow hibernation when the application goes into the background.
553 But we still need to detect when the accounts setup windows are open so
554 we can stop hibernation when they are open.
555 To do this, I also added the main window the HildonProgram. This might have
556 other side-effects/benefits, and should maybe be done for other windows.
558 * src/maemo/modest-osso-autosave-callbacks.h:
559 * src/maemo/modest-osso-autosave-callbacks.c:
560 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
561 though it does not do anything yet, and we might never need this to do
562 anything. For instance, we already save drafts.
564 * src/maemo/modest-platform.c: (modest_platform_init):
565 Specify the libosso auto-save callback.
567 2007-05-03 Murray Cumming <murrayc@murrayc.com>
569 * src/maemo/modest-platform.c:
570 (modest_platform_set_update_interval):
571 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
572 aparently stays valid between application instances, so we can use this
573 to remove and reset it later. According to a maemo-developers email from
576 2007-05-03 Murray Cumming <murrayc@murrayc.com>
578 * configure.ac: Depend on libalarm for Maemo.
580 * src/dbus_api/modest-dbus-api.h:
581 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
582 (on_send_receive), (modest_dbus_req_handler):
583 Handle a SEND_RECEIVE D-Bus method.
585 * libmodest-dbus-client/libmodest-dbus-client.c:
586 (libmodest_dbus_client_send_and_receive):
587 * libmodest-dbus-client/libmodest-dbus-client.h:
588 Add C convenience functions for calling the new D-Bus method.
590 * src/modest-platform.h:
591 * src/gnome/modest-platform.c:
592 * src/maemo/modest-platform.c:
593 Added modest_platform_set_update_interval(), which uses the
595 (modest_platform_init),
596 Call modest_platform_set_update_interval(), using a hard-coded
597 interval for now (until the global settings dialog is implemented),
598 though I am not sure that this makes sense yet.
600 2007-05-02 Murray Cumming <murrayc@murrayc.com>
602 * src/dbus_api/modest-dbus-callbacks.c:
603 (modest_osso_cb_hw_state_handler):
604 * src/dbus_api/modest-dbus-callbacks.h:
605 * src/maemo/modest-platform.c: (modest_platform_init):
606 Registered (empty) callbacks for the osso hardware state D-Bus signals,
607 in case this has some effect on the ability for Maemo to ping the
610 2007-05-02 Murray Cumming <murrayc@murrayc.com>
612 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
613 Comment out an if() that checks a gchar for < 0, causing a build-breaking
614 warning. It is probably a logic error, but I need to fix the build.
616 2007-05-02 Murray Cumming <murrayc@murrayc.com>
618 * src/modest-account-mgr.h:
619 * src/modest-account-mgr.c:
620 (modest_account_mgr_account_names): Add a gboolean enabled_only
621 parameter, so we can get lists of onlt the enabled accounts.
623 (modest_account_mgr_add_account),,
624 (modest_account_mgr_account_with_display_name_exists):
625 * src/maemo/modest-msg-edit-window.c: (get_transports):
626 * src/modest-account-mgr-helpers.c:
627 (modest_account_mgr_set_first_account_as_default):
628 * src/modest-init.c: (init_default_account_maybe):
629 * src/modest-tny-account-store.c: (get_accounts):
630 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
631 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
632 * tests/check_account-mgr.c: (START_TEST):
633 Provide the extra parameter, as appropriate.
635 * src/widgets/modest-account-view.c: (update_account_view):
636 Do not show disabled accounts (meaning that there is no way to
637 enable/disable accounts in the UI (the feature is not in our UI
638 specification), so we can use this internally only to mark unfinished
639 or temporary account data.
641 * src/maemo/easysetup/modest-easysetup-wizard.c:
642 (create_account): Add boolean enable parameter, so we can specify FALSE
643 to create the temporary account.
644 (on_button_edit_advanced_settings): Create the temporary account as disabled.
645 (on_before_next): When finishing, when there is a temporary account, just
647 Also, use a timeout to delay the showing of the dialog until gconf is likely
648 to return correct information, due to a maemo gconf bug that is fixed in
649 osso 1.1, but not yet in Bora.
650 However, the dialog stays on screen after it is destroyed.
652 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
653 for invalid data when cancelling. Use a hildon note instead of a dialog
654 to complain about invalid data. Do not show the account-saved note if the
655 account is disabled (a temporary account that will not really be saved for use
658 2007-04-30 Murray Cumming <murrayc@murrayc.com>
660 * src/modest-account-mgr-helpers.h:
661 * src/modest-account-mgr-helpers.c:
662 Added modest_account_mgr_unset_default_account(),
663 Added modest_account_mgr_set_first_account_as_default().
665 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
666 If it was the default account, unset the default account name.
668 * src/maemo/modest-account-view-window.c:
669 (on_delete_button_clicked): If it was the default account,
670 set the first remaining account as the default instead.
672 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
673 a NULL account or a NULL default account, to prevent a crash. This should
674 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
677 2007-04-30 Murray Cumming <murrayc@murrayc.com>
679 * src/widgets/modest-recpt-editor.c:
680 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
681 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
682 TODO comment for this. This fixes the build.
684 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
685 be the best place for it. This will in future update all auto-update accounts,
686 rather than just the current/default account, when that gconf key exists.
687 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
688 if there are no accounts, before calling do_send_receive().
689 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
691 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
692 * src/maemo/modest-main-window-ui.h:
693 * src/maemo/modest-main-window.c: (on_connection_changed),
694 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
695 directly, becaue the signal handler does more.
697 2007-04-30 Murray Cumming <murrayc@murrayc.com>
699 * src/modest-account-mgr-helpers.c:
700 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
701 for the case that the account does not exist.
703 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
704 (equivalent to the modest account name) rather than the tinymail account name
705 (equivalent to the modest account title - human readable) to get the account data.
706 Check for null account data to prevent the crash, and add a TODO comment saying that
707 this needs fixing because it is using the server account name instead of the account name.
709 2007-04-29 Murray Cumming <murrayc@murrayc.com>
711 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
712 * src/maemo/modest-account-settings-dialog.c: (show_error),
714 Use hildon_note_new_information() for informative and error messages,
715 which seems to be expected for Maemo applications (no documentation that I know of
716 says this). I am surprised that there is no distinction between info and error
719 2007-04-29 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
722 it is easy to find where this is used.
724 * src/maemo/easysetup/modest-easysetup-wizard.c:
725 (create_page_welcome), (create_page_account_details),
726 (create_page_user_details), (create_page_complete_easysetup),
727 (create_page_custom_incoming), (create_page_custom_outgoing),
728 (create_page_complete_custom):
729 * src/maemo/modest-account-settings-dialog.c:
730 (create_page_account_details), (create_page_user_details),
731 (create_page_incoming), (create_page_outgoing):
732 * src/maemo/modest-account-view-window.c: (window_vbox_new):
733 * src/maemo/modest-connection-specific-smtp-edit-window.c:
734 (modest_connection_specific_smtp_edit_window_init):
735 * src/maemo/modest-connection-specific-smtp-window.c:
736 (modest_connection_specific_smtp_window_init):
737 * src/maemo/modest-signature-editor-dialog.c:
738 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
739 and scrolling policy as per the Email Application Layout Guide, if I have
742 2007-04-27 Murray Cumming <murrayc@murrayc.com>
744 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
745 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
746 which were empty, because these vfuncs have been removed from TnyAccountStore.
747 This fixes the build.
749 2007-04-27 Murray Cumming <murrayc@murrayc.com>
751 * src/maemo/modest-main-window.c:
752 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
753 showing/hiding it. Added TODO because it probably should not be NULL.
754 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
755 because unnecessary g_warnings() make degugging difficult.
757 2007-04-27 Murray Cumming <murrayc@murrayc.com>
759 * src/maemo/modest-msg-edit-window.c:
760 (modest_msg_edit_window_select_color),
761 (modest_msg_edit_window_select_background_color): 2 const corrections and
762 moving 2 #endifs before closing brackets, to fix the build.
764 2007-04-27 Murray Cumming <murrayc@murrayc.com>
766 * src/maemo/easysetup/modest-easysetup-wizard.h:
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 (modest_easysetup_wizard_dialog_finalize),
769 (on_button_edit_advanced_settings), (create_page_complete_custom),
770 (on_response), (create_account):
771 Implement the Advanced Settings edit button, by saving the account information,
772 for the Advanded Settings dialog to use directly from gconf, and removing it
773 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
774 Bug #5533 in the projects.maemo.org bugzilla.
776 2007-04-27 Murray Cumming <murrayc@murrayc.com>
778 * src/maemo/modest-msg-view-window.c:
779 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
780 when opening a message window.
782 2007-04-27 Murray Cumming <murrayc@murrayc.com>
784 * src/maemo/easysetup/modest-easysetup-wizard.c:
785 (create_page_custom_outgoing): Correct the position of the horizontal separator to
788 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
789 before showing/hiding them, to avoid a crash when clicking on folders when there are no
790 gconf settings. I probably added more checks than necessary, but that is safer.
792 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
793 variable to fix the build, but this seems to be used when it is still NULL.
795 2007-04-27 Murray Cumming <murrayc@murrayc.com>
797 * src/modest-platform.h:
798 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
799 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
800 * src/modest-main.c: Implement this function so we can avoid using
801 maemo-specific API from cross-platform code.
803 * src/modest-tny-account-store.c:
804 (get_smtp_specific_transport_account_for_open_connection):
805 * src/modest-ui-actions.c: (check_for_connection),
806 (modest_ui_actions_on_item_not_found):
807 Use modest_platform_connect_and_wait() and put #idefs around other
808 maemo-specific code, because only maemo currently has a way to
809 identify connection names.
811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
813 * src/modest-tny-account-store.h:
814 * src/modest-tny-account-store.c:
815 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
816 the connection-specific SMTP server settings in the configuration.
818 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
820 * src/maemo/modest-main-window.c: (on_connection_changed),
822 * src/modest-main.c: (main), (start_ui), (send_mail):
823 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
824 that is what is intended.
826 * src/modest-ui-actions.c: (action_send), (action_receive),
827 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
828 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
829 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
830 SMTP server is used when it is specified.
832 (modest_ui_actions_on_send_receive):
833 Check that a connection is open before proceeding.
834 Receive and then send, instead of vice-versa, as per the specification.
836 2007-04-26 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-mail-operation.c:
839 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
840 though I guess it should be something other than NULL.
842 2007-04-26 Murray Cumming <murrayc@murrayc.com>
844 * src/maemo/easysetup/modest-easysetup-wizard.c:
845 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
846 combo twice, to avoid an g_warning and to make it visible again.
847 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
848 attached before detaching it, to avoid a g_warning, and add comment about the implicit
849 (already intended) dereference when detaching, because we then recreate the menu.
850 But I am not sure why the warning was happening, and it is possible that this is a memory
853 2007-04-25 Murray Cumming <murrayc@murrayc.com>
855 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
856 and uri_parse_mailto() utility functions.
857 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
859 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
861 2007-04-24 Murray Cumming <murrayc@murrayc.com>
863 * src/dbus_api/modest-dbus-api.h:
864 * src/dbus_api/modest-dbus-callbacks.c:
865 Use an idle callback to execute the modest code in the application's own thread.
866 Remove the helloworld example method.
867 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
868 parsed, and the open-message method is not implemented because this is not yet implemented in
870 * libmodest-dbus-client/libmodest-dbus-client.c:
871 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
872 (libmodest_dbus_client_open_message):
873 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
875 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
876 body without crashing.
878 * tests/dbus_api/Makefile.am:
879 * tests/dbus_api/test_mail_to.c:
880 * tests/dbus_api/test_open_message.c: New tests for the new methods.
882 2007-04-24 Murray Cumming <murrayc@murrayc.com>
884 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
885 Added file to fix the build. Sorry.
887 * src/dbus_api/Makefile.am:
888 * src/dbus_api/modest-dbus-api.h:
889 * src/dbus_api/modest-dbus-callbacks.h:
890 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
891 (modest_dbus_req_handler):
892 Put constants in a separate header so it can be reused by the
893 client library, without duplication
895 * libmodest-dbus-client/Makefile.am:
896 * libmodest-dbus-client/libmodest-dbus-client.c:
897 (libmodest_dbus_client_call_helloworld),
898 (libmodfest_dbus_client_send_mail),
899 (libmodfest_dbus_client_mailto),
900 (libmodfest_dbus_client_open_message):
901 * libmodest-dbus-client/libmodest-dbus-client.h:
902 (Partly) Implement a send_mail D-Bus method.
904 * tests/dbus_api/Makefile.am:
905 * tests/dbus_api/test_send_mail.c: (main): Added a test for
906 the send_email D-Bus method.
908 2007-04-24 Murray Cumming <murrayc@murrayc.com>
912 * libmodest-dbus-client/Makefile.am:
913 * libmodest-dbus-client/libmodest-dbus-client.c:
914 * libmodest-dbus-client/libmodest-dbus-client.h:
915 * tests/dbus_api/Makefile.am:
916 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
917 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
919 2007-04-24 Murray Cumming <murrayc@murrayc.com>
921 * src/maemo/easysetup/modest-easysetup-wizard.c:
922 (create_page_account_details):
923 * src/maemo/modest-account-settings-dialog.c:
924 (create_page_account_details): Explicitly set auto-capitalization mode for the title
925 widgets, because this might not be the default in future versions of the Maemo GTK+.
926 However, I can not not get capitalization to work even in a simple test case.
928 2007-04-24 Murray Cumming <murrayc@murrayc.com>
930 * src/maemo/easysetup/modest-easysetup-wizard.c:
931 (create_page_custom_incoming), (create_page_custom_outgoing):
932 * src/maemo/modest-account-settings-dialog.c:
933 (create_page_account_details), (create_page_incoming),
934 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
935 instead of using gtk_check_button_with_label(), so they are aligned like the other
936 widgets, as per the UI spec.
938 2007-04-24 Murray Cumming <murrayc@murrayc.com>
940 * src/maemo/easysetup/modest-easysetup-wizard.c:
941 * src/maemo/modest-connection-specific-smtp-edit-window.c:
942 * src/widgets/modest-validating-entry.c:
943 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
944 Modest prefix instead of an EasySetup prefix.
946 2007-04-23 Murray Cumming <murrayc@murrayc.com>
948 * src/widgets/modest-validating-entry.h:
949 * src/widgets/modest-validating-entry.c: (on_insert_text),
950 Added easysetup_validating_entry_set_max_func(), used to set a callback
951 to call when the max number of characters is reached. GtkEntry has a max-length
952 already but is silent about it.
954 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
955 (create_page_account_details), (create_page_user_details),
957 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
958 (create_page_account_details), (create_page_user_details),
959 (create_page_outgoing):
960 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
961 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
962 the UI spec, when the user tries to enter more than the max number of characters.
964 2007-04-23 Murray Cumming <murrayc@murrayc.com>
966 * src/maemo/easysetup/modest-easysetup-wizard.c:
967 (create_page_user_details), (create_page_custom_incoming),
968 (create_page_custom_outgoing):
969 * src/maemo/modest-account-settings-dialog.c:
970 (create_page_user_details), (create_page_incoming),
971 (create_page_outgoing):
972 * src/maemo/modest-connection-specific-smtp-edit-window.c:
973 (modest_connection_specific_smtp_edit_window_init):
974 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
975 not appropriate. Bad Maemo-specific defaults!.
977 2007-04-23 Murray Cumming <murrayc@murrayc.com>
979 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
980 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
981 (modest_signature_editor_dialog_set_settings):
982 Disable the label and textview when the checkbox is disabled, and use the
983 specified (UI spec) default signature text.
985 2007-04-23 Murray Cumming <murrayc@murrayc.com>
987 * src/maemo/modest-connection-specific-smtp-edit-window.c:
988 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
991 * src/modest-account-mgr-helpers.h:
992 * src/modest-account-mgr-helpers.c:
993 Added modest_account_mgr_get/set_signature(), using new gconf keys.
995 * src/maemo/Makefile.am:
996 * src/maemo/modest-signature-editor-dialog.c:
997 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1000 * src/maemo/modest-account-settings-dialog.h:
1001 * src/maemo/modest-account-settings-dialog.c:
1002 (modest_account_settings_dialog_finalize), (on_button_signature),
1003 (save_configuration): Use the new dialog when the Edit button is pressed, and
1004 save the changes if necessary, as per the UI spec.
1006 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1008 * src/maemo/Makefile.am:
1009 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1010 based on maemo-develoers email from Dirk.
1012 * src/maemo/easysetup/modest-easysetup-wizard.c:
1013 (create_page_welcome), (create_page_account_details),
1014 (create_page_user_details), (create_page_complete_easysetup),
1015 (create_page_custom_incoming), (create_page_custom_outgoing),
1016 (create_page_complete_custom),
1017 (modest_easysetup_wizard_dialog_init):
1018 * src/maemo/modest-account-settings-dialog.c:
1019 (create_page_account_details), (create_page_user_details),
1020 (create_page_incoming), (create_page_outgoing),
1021 (modest_account_settings_dialog_init):
1022 * src/maemo/modest-connection-specific-smtp-window.c:
1023 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1025 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1027 * src/maemo/easysetup/modest-easysetup-wizard.c:
1028 (create_page_account_details), (create_page_custom_outgoing),
1029 (create_page_complete_custom):
1030 * src/maemo/modest-account-settings-dialog.c:
1031 (create_page_user_details), (create_page_incoming),
1032 (create_page_outgoing):
1033 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1034 (modest_connection_specific_smtp_edit_window_init):
1035 Use the correct (UI spec) port min/max, and use horizontal separators,
1038 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1040 * src/maemo/easysetup/modest-easysetup-wizard.c:
1041 (set_default_custom_servernames):
1042 * src/maemo/modest-account-settings-dialog.c:
1043 (create_page_incoming), (on_combo_outgoing_security_changed),
1044 (on_combo_incoming_security_changed), (create_page_outgoing),
1045 (modest_account_settings_dialog_set_account_name),
1046 (save_configuration):
1047 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1048 (on_combo_security_changed),
1049 (modest_connection_specific_smtp_edit_window_init),
1050 (modest_connection_specific_smtp_edit_window_set_connection),
1051 (modest_connection_specific_smtp_edit_window_get_settings):
1052 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1055 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1058 * src/maemo/easysetup/modest-easysetup-wizard.c:
1059 (create_page_custom_outgoing), (create_page_complete_custom):
1060 * src/maemo/modest-account-settings-dialog.c:
1061 (create_page_user_details), (create_page_outgoing):
1062 * src/maemo/modest-account-view-window.c: (button_box_new):
1063 Use changed logical IDs as per the most recent UI spec:
1064 mcen_bd_emailsetup_edit -> mcen_bd_edit
1065 mcen_bd_emailsetup_delete -> mcen_bd_delete
1066 mcen_bd_emailsetup_close -> mcen_bd_close
1068 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1072 * src/dbus_api/Makefile.am:
1073 * src/dbus_api/modest-dbus-callbacks.c:
1074 * src/dbus_api/modest-dbus-callbacks.h:
1075 * src/maemo/modest-platform.c: (modest_platform_init):
1076 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1078 * tests/Makefile.am:
1079 * tests/dbus_api/Makefile.am:
1080 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1082 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1084 * src/maemo/modest-account-settings-dialog.c:
1085 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1086 Removed unnecessary includes.
1088 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1090 * src/maemo/easysetup/modest-easysetup-wizard.c:
1091 * src/maemo/modest-account-settings-dialog.c:
1092 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1093 * src/widgets/Makefile.am:
1094 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1095 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1096 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1097 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1098 * src/widgets/modest-secureauth-combo-box.c:
1099 * src/widgets/modest-secureauth-combo-box.h:
1100 * src/widgets/modest-serversecurity-combo-box.c:
1101 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1102 made the GObject names more consistent with the rest of the Modest code.
1104 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1106 * src/maemo/easysetup/Makefile.am:
1107 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1108 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1109 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1110 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1111 * src/maemo/easysetup/modest-easysetup-wizard.c:
1112 * src/maemo/easysetup/modest-validating-entry.c:
1113 * src/maemo/easysetup/modest-validating-entry.h:
1114 * src/maemo/modest-account-settings-dialog.c:
1115 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1116 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1117 widgets/ because they are used outside of easysetup too. After checking in,
1118 svn will allow me to rename them too.
1120 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1122 * src/gnome/modest-msg-edit-window.c:
1123 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1124 linker error, to fix the build on the GNOME platform.
1125 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1126 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1127 ifdefed out to avoid a warning.
1129 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1131 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1132 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1133 some alternative for GTK+ 2.6.
1135 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1137 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1139 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1140 specified for EmailAccountsDialog in UI spec.
1142 * src/maemo/easysetup/modest-easysetup-wizard.c:
1143 * src/maemo/easysetup/modest-easysetup-wizard.h:
1144 * src/maemo/modest-account-settings-dialog.c:
1145 * src/maemo/modest-account-settings-dialog.h:
1146 Reuse a member window widget for the connection-specific SMTP server accounts,
1147 so we can tell it to create/save the accounts only if we actually save changes.
1149 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1151 (modest_connection_specific_smtp_edit_window_get_settings):
1152 Return a struct instance for temporarily remembering the entered data.
1154 * src/maemo/modest-connection-specific-smtp-window.h:
1155 * src/maemo/modest-connection-specific-smtp-window.c:
1156 (modest_connection_specific_smtp_window_finalize),
1157 (modest_connection_specific_smtp_window_fill_with_connections),
1159 (modest_connection_specific_smtp_window_save_server_accounts),
1160 (update_model_server_names): Do not actually save data until asked,
1161 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1163 (on_selection_changed),
1164 (modest_connection_specific_smtp_window_init): Disable the edit
1165 button when nothing is selected.
1167 * src/modest-account-mgr-helpers.c:
1168 * src/modest-account-mgr-helpers.h:
1169 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1172 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1174 * src/modest-account-mgr-helpers.h:
1175 * src/modest-account-mgr-helpers.c:
1176 (modest_account_mgr_get_unused_account_name),
1177 (modest_account_mgr_get_unused_account_display_name): Added these
1178 utility functions, to avoid code duplication.
1180 * src/maemo/easysetup/modest-easysetup-wizard.c:
1181 (create_page_account_details), (create_account):
1182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1183 (on_combo_security_changed),
1184 (modest_connection_specific_smtp_edit_window_init),
1185 (modest_connection_specific_smtp_edit_window_save_settings):
1186 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1187 * src/maemo/modest-connection-specific-smtp-window.c:
1188 (modest_connection_specific_smtp_window_finalize),
1189 (modest_connection_specific_smtp_window_fill_with_connections),
1190 (on_button_edit), (modest_connection_specific_smtp_window_init):
1191 * src/maemo/modest-connection-specific-smtp-window.h:
1192 Implementing saving of connection-specific server accounts.
1194 But I need to refactor this so we can save the data for each
1195 possible connection-specific account and only actually create the server accounts
1196 when the easysetup finished, or the OK button is pressed on the account settings
1199 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1201 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1202 (on_combo_security_changed):
1203 (modest_connection_specific_smtp_edit_window_init):
1204 Auto-fill the port number as in the account settings.
1206 (modest_connection_specific_smtp_edit_window_set_connection):
1207 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1208 * src/maemo/modest-connection-specific-smtp-window.c:
1209 (fill_with_connections), (on_button_edit),
1210 (modest_connection_specific_smtp_window_init):
1211 Turn the edit window into a dialog to simplify the code, and
1212 set a WM hint as in a GtkDialog, because only a popup can be on top of
1213 another window in Maemo, and popups usually have no WM decoration.
1215 * src/modest-defs.h:
1216 * src/modest-account-mgr-helpers.c:
1217 (modest_account_mgr_set_connection_specific_smtp),
1218 (modest_account_mgr_remove_connection_specific_smtp),
1219 (modest_account_mgr_get_connection_specific_smtp):
1220 * src/modest-account-mgr-helpers.h: Some functions to write the
1221 connection-specific SMTP server information. Not yet used.
1224 * src/widgets/modest-folder-view.c: (text_cell_data):
1225 Fix a warning about an uninitialized variable.
1226 (on_configuration_key_changed): Put an #ifdef around the use
1227 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1229 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1231 * src/maemo/modest-account-settings-dialog.h:
1232 * src/maemo/modest-account-settings-dialog.c:
1233 Added connect_for_modified() utility function to mark the new modified boolean.
1235 (create_page_account_details), (create_page_user_details),
1236 (create_page_incoming), (create_page_outgoing), (on_response),
1237 (modest_account_settings_dialog_init),
1238 (modest_account_settings_dialog_set_account_name):
1239 Only warn about unsaved changes when there are actually unsaved changes.
1241 * src/modest-account-mgr-helpers.c:
1242 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1243 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1244 to get the data from there in future.
1246 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1248 * src/modest-defs.h:
1250 * src/modest-account-mgr-helpers.h:
1251 * src/modest-account-mgr-helpers.c:
1252 Store the security account setting in a single conf key instead of using
1253 the options list, so that the list is left for just the to-be-removed camel hack,
1254 and because gconf_client_set_list() is failing for some reason.
1256 * src/modest-account-mgr.c:
1257 (modest_account_mgr_add_server_account):
1258 * src/maemo/modest-account-settings-dialog.c:
1259 (modest_account_settings_dialog_set_account_name),
1260 (save_configuration): Use the renamed functions.
1263 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1265 * src/widgets/Makefile.am:
1266 * src/widgets/modest-limit-retrieve-combo-box.c:
1267 * src/widgets/modest-limit-retrieve-combo-box.h:
1268 * src/widgets/modest-retrieve-combo-box.c:
1269 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1270 the account settings dialog.
1272 * src/modest-defs.h:
1273 * src/modest-account-mgr-helpers.h:
1274 * src/modest-account-mgr-helpers.c:
1275 (modest_server_account_get_option_secure_auth),
1276 (modest_server_account_set_option_secure_auth):
1277 * src/modest-account-mgr.c:
1278 (modest_account_mgr_add_server_account):
1279 Use the existing AUTH_MECH conf key for the secure-auth setting,
1280 instead of putting it in the list options, because this was actually used already.
1282 * src/maemo/modest-account-settings-dialog.c:
1283 (create_page_account_details),
1284 (modest_account_settings_dialog_set_account_name),
1285 (save_configuration):
1286 * src/maemo/modest-account-settings-dialog.h:
1287 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1288 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1290 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1292 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1293 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1294 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1296 * src/modest-defs.h:
1297 * src/maemo/modest-account-settings-dialog.c:
1298 (create_page_incoming), (on_combo_outgoing_security_changed),
1299 (on_combo_incoming_security_changed), (create_page_outgoing),
1300 (modest_account_settings_dialog_set_account_name),
1301 (save_configuration): Load/Save the port number, and change it when the
1302 security combo changes, to suitable defaults.
1304 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1306 * src/modest-account-mgr.c:
1307 (modest_account_mgr_add_server_account): Set the security and secure-auth
1308 options, and add a comment saying that the other camel-specific options should be
1311 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1315 * src/modest-tny-account-store.c: (account_list_free),
1316 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1317 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1320 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-protocol-info.c:
1323 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1324 is required by our UI spec. Maybe something in our implementation will use this eventually.
1325 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1326 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1327 instead of the previous 0 placeholder.
1329 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1330 secure-auth settings.
1331 * src/modest-account-mgr-helpers.h:
1332 * src/modest-account-mgr-helpers.c:
1333 (modest_server_account_data_get_option_secure_auth),
1334 (modest_server_account_set_option_secure_auth),
1335 (modest_server_account_data_get_option_security),
1336 (modest_server_account_set_option_security): Added this API for getting and setting the security
1337 and secure-auth settings.
1339 * src/maemo/modest-account-settings-dialog.h:
1340 * src/maemo/modest-account-settings-dialog.c:
1341 (modest_account_settings_dialog_finalize), (check_data),
1342 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1343 about changing titles.
1344 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1345 (save_configuration): Save the security and secure-auth settings.
1347 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1348 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1350 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1352 * src/modest-defs.h:
1353 * src/modest-account-mgr.c:
1354 (modest_account_mgr_add_server_account):
1355 Added and used defines for the options key and value pair strings,
1356 that are used so far, though they do not seem to correspond to anything in our
1357 UI specs or ModestProtocol enum.
1359 * src/modest-account-mgr-helpers.h:
1360 * src/modest-account-mgr-helpers.c:
1361 (compare_option_strings_for_name),
1362 (modest_server_account_data_get_option_value),
1363 (modest_server_account_data_get_option_bool),
1364 (modest_account_mgr_get_server_account_option):
1365 Added helper functions for parsing the options GSList.
1367 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1369 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1370 display name is based on the supplied account name.
1371 * src/modest-account-mgr.c:
1372 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1373 with an inefficient, but good-enough, implementation.
1375 * src/maemo/easysetup/modest-easysetup-wizard.c:
1376 (create_page_account_details), (on_before_next), (create_account):
1377 Check for existing display names rather than (non-user-visible) account names, and just
1378 create and set a unique account name at the end.
1380 * src/maemo/modest-account-settings-dialog.c:
1381 (modest_account_settings_dialog_init),
1382 (modest_account_settings_dialog_set_account_name),
1383 (create_page_incoming): Show the display name, instead of the account name.
1384 (on_response): Do some (not all) extra checks, as in the UI spec.
1385 (save_configuration): Save the display name if it was changed.
1387 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1389 * po/en_GB.po: Added needed logical ID and translation.
1390 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1391 (init_view): Made the is-default column clicking work.
1393 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1396 * src/maemo/easysetup/Makefile.am:
1397 * src/maemo/easysetup/modest-easysetup-wizard.c:
1398 (modest_easysetup_wizard_dialog_init):
1399 * src/maemo/easysetup/provider-data-test.keyfile:
1400 * src/maemo/easysetup/provider-data.keyfile:
1401 Moved the provider data file to the new modest-providers-data package and used it from there.
1403 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1405 * src/modest-local-folder-info.c:
1406 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1407 N_() was already used on the static strings, but this just marks it for translation without
1408 using the translation.
1410 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1412 * src/maemo/modest-account-settings-dialog.c:
1413 (create_page_incoming),
1414 (modest_account_settings_dialog_set_account_name):
1415 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1416 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1417 I will do this if nobody else gets there first.
1419 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1422 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1423 save the security stuff.
1425 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1427 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1428 Set the email address and user fullname, which I now see must be
1431 * src/maemo/modest-account-settings-dialog.h:
1432 * src/maemo/modest-account-settings-dialog.c:
1434 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1435 leave-on-server and authentication.
1436 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1439 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1442 * src/maemo/modest-account-settings-dialog.c:
1443 * src/maemo/modest-account-settings-dialog.h:
1444 Most (but not all) of the widgets are now present as specified by the UI spec.
1445 No changes are yet saved, and some details are not properly shown yet.
1447 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1449 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/Makefile.am:
1452 * src/maemo/modest-account-settings-dialog.c:
1453 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1454 an existing account. Doesn't do much yet.
1456 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1457 Open the accounts settings dialog when Edit is clicked.
1459 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1461 * src/maemo/easysetup/Makefile.am:
1462 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1464 * src/maemo/easysetup/modest-easysetup-wizard.c:
1465 (modest_easysetup_wizard_dialog_init):
1466 Try to get the source directory from the build system,
1467 instead of hard-coding "./" into the source code, when opening our local
1468 copies of the configuration files.
1469 But this still fails when opening the wizard from the Accounts window,
1470 maybe because the working directory seems to change at runtime.
1471 So the wizard will fail the second time unless you copy the files into their
1472 proper locations - see the stdout warnings for the paths.
1474 (create_page_account_details),(on_before_next):
1475 Check for existing non-server accounts instead of server accounts,
1476 so the default account name is useful again, and to prevent trying to
1479 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1480 Show the wizard when New is clicked.
1482 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1483 (init_view): Show the column headers, and show the columns that are
1484 specified in the UI specs. However, something in Maemo's GTK+ prevents
1485 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1486 change the default account. This is despite unsetting the special properties.
1488 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1490 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1491 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1492 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1493 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1494 to make that clearer.
1495 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1497 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1499 * src/maemo/modest-account-view-window.c:
1500 (modest_account_view_window_init),
1501 (modest_account_view_window_new):
1502 Use the same buttons as specified in the
1503 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1504 the existing widgets, which never had a chance of working.
1505 Put the ModestAccountView treeview in a scrolled window.
1506 Do not repeat the initialization in both _init() and _new().
1508 * src/widgets/modest-account-view.c: (update_account_view):
1509 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1510 this widget and window shows no accounts.
1512 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1514 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1516 * src/maemo/easysetup/modest-easysetup-wizard.c:
1517 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1518 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1519 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1522 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1523 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1524 accounts exist yet, as in the UI spec.
1526 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1528 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1530 * src/maemo/Makefile.am:
1531 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1532 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1533 New window for editing connection-specific smtp details.
1534 Not fully implemented.
1536 * src/maemo/modest-connection-specific-smtp-window.c:
1537 (modest_connection_specific_smtp_window_finalize) :
1538 unref the tree model.
1539 (on_button_edit): Show the edit window.
1541 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1543 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1546 * src/maemo/Makefile.am:
1547 * src/maemo/modest-connection-specific-smtp-window.c:
1548 * src/maemo/modest-connection-specific-smtp-window.h:
1549 New window for showing the list of connections, for connection-specific
1550 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1551 * src/maemo/easysetup/modest-easysetup-wizard.c:
1552 (create_page_custom_outgoing): Show the new window when the button is clicked.
1554 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1557 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1558 * src/maemo/modest-msg-edit-window.c:
1559 (modest_msg_edit_window_insert_image):
1560 * src/modest-conf.c: (modest_conf_key_escape):
1561 * src/modest-mail-operation.c:
1562 (modest_mail_operation_send_new_mail):
1563 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1564 (modest_ui_actions_on_new_account):
1565 * src/widgets/modest-attachment-view.c: (update_filename_request):
1566 * src/widgets/modest-mail-header-view.c:
1567 Corrected warnings that were breaking the build, by commenting out unused variables,
1568 and a function, and by including a header.
1570 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1572 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1573 so we can #ifdef around platform-specific code when necessary.
1574 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1575 to allow this to build for the GNOME platform too.
1577 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1579 * src/maemo/easysetup/modest-easysetup-wizard.c:
1580 Added util_increment_name() and used it in create_page_account_details()
1581 to make sure that the default account name is always a new name.
1583 (modest_easysetup_wizard_dialog_init),
1584 (set_default_custom_servernames): Some minor memory management fixes.
1586 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1590 * src/modest-runtime.c: (init_i18n): Restored the translation
1591 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1592 are defined in config.h, and the translations are installed.
1594 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1595 is defined for translation.
1597 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1599 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1601 * src/maemo/easysetup/modest-easysetup-wizard.c:
1602 (modest_easysetup_wizard_dialog_init):
1603 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1604 Use realistic paths (though they should use $prefix generically) to the
1605 mcc_mapping and provider-data.keyfile files which might work when they
1606 are installed by the future version of the operator-wizard package,
1607 and then fallback to paths in our source code, with an explanatory
1610 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1614 * src/maemo/Makefile.am:
1615 * src/maemo/easysetup/: Added files from the previously-exernal
1616 osso-modest-easysetup.
1617 * src/maemo/modest-main-window-ui.h:
1618 * src/modest-ui-actions.c:
1619 * src/modest-ui-actions.h:
1620 Added modest_ui_actions_on_new_account() as a signal handler for the
1621 New Account menu item. It shows the easysetup wizard.
1622 * po/en_GB.po: Added additional needed logical IDs and translations.
1624 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1625 Apparently ChangeLog is not used for some vague Nokia legal reasons.