1 2007-07-12 Murray Cumming <murrayc@murrayc.com>
3 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
4 * src/maemo/modest-platform.c:
5 (modest_platform_connect_and_wait):
6 Take a TnyAccount* parameter and try to set it to online
7 (a TnyCamel-only API), because tinymail sets accounts to offline
8 when the user cancels a password dialog, and doesn't ask again until
9 it has been set to online.
10 However, this is commented out because it causes a hang now.
12 (modest_platform_connect_and_wait_if_network_account):
13 * src/modest-mail-operation.c:
14 (modest_mail_operation_update_account):
15 * src/modest-platform.h:
16 * src/modest-ui-actions.c: (_modest_ui_actions_open),
17 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
19 2007-07-12 Armin Burgmeier <armin@openismus.com>
21 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
23 * src/modest-mail-operation.c:
24 * src/modest-ui-actions.c: Check for already existing folder before
25 querying the server, show error message from camel if the request
26 still fails. This fixes projects.maemo.org bug NB#58701.
28 2007-07-12 Murray Cumming <murrayc@murrayc.com>
30 * src/modest-tny-account-store.h:
31 * src/modest-tny-account-store.c:
32 Added modest_tny_account_store_forget_password_in_memory(),
33 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
34 when creating a new account, so that new passwords will be used, instead of
35 us thinking that it's a second request as a result of a failed password again.
37 2007-07-12 Murray Cumming <murrayc@murrayc.com>
39 * src/dbus_api/modest-dbus-callbacks.c:
40 (on_idle_open_message): If the message is in drafts then open it
41 in an edit window instead of a view window. This fixes
42 projects.maemo.org bug NB#63005.
44 2007-07-12 Murray Cumming <murrayc@murrayc.com>
46 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
47 Avoided a harmless g_warning().
49 2007-07-12 Murray Cumming <murrayc@murrayc.com>
51 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
52 Pass the modest account name, not the TnyAccount display name to
53 modest_msg_view_window_new() so that the reply feature works,
54 fixing projects.maemo.org bug NB#62892.
56 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
57 (modest_msg_view_window_new_with_header_model):
58 * src/maemo/modest-msg-view-window.c:
59 (modest_msg_view_window_new_with_header_model),
60 (modest_msg_view_window_new):
61 * src/modest-ui-actions.c: (reply_forward):
62 * src/widgets/modest-msg-view-window.h:
63 * src/widgets/modest-window.c: (modest_window_set_active_account):
64 Rename an account parameter to modest_account_name to make this clearer.
66 2007-07-11 Murray Cumming <murrayc@murrayc.com>
68 * src/modest-ui-actions.h:
69 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
70 modest_do_message_delete().
71 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
72 Call modest_do_message_delete(), hoping that this would cause messages
73 to be really deleted from search instead of just marked with strike through.
74 Does not seem to help.
76 2007-07-11 Armin Burgmeier <armin@openismus.com>
78 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
79 priv->reselect to FALSE prior to calling
80 modest_folder_view_select_first_inbox_or_local() to prevent endless
81 recursion and thus a crash on startup.
83 2007-07-11 Armin Burgmeier <armin@openismus.com>
85 * src/maemo/modest-account-settings-dialog.h: Include
86 <gtk/gtknotebook.h> to fix the build (at least for me).
88 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
89 Use "New FolderN" as default suggested name if "New folder" already
90 exists, with N being the first free number, though never exceed "New
91 folder99" in which case we just fall back to "New Folder" even though
92 it already exists. This fixes projects.maemo.org bug NB#58663.
94 2007-07-11 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
97 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
98 projects.maemo.org bug NB#62778.
100 2007-07-11 Murray Cumming <murrayc@murrayc.com>
102 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
103 Ignore the wrong (for now) secure-smtp setting in the presets -
104 just default to requiring secure authentication for SMTP, because
107 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
109 * src/widgets/modest-folder-view.c: (filter_row)
110 Do not show drafts folder (see UI specs)
112 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
114 * src/modest-ui-actions.c:
115 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
116 place and also not necessary.
118 * src/widgets/modest-folder-view.c: (filter_row)
119 Guess folder type and hide Sent & Outbox if necessary.
120 Fixed project.maemo.org NB#57328
122 2007-07-11 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-ui-actions.h:
125 * src/modest-ui-actions.c:
126 (modest_ui_actions_on_delete_message):
127 Move some code into a new
128 modest_ui_actions_refresh_message_window_after_delete()
129 function so we can use it from elsewhere.
131 * src/dbus_api/modest-dbus-callbacks.c:
132 (on_idle_delete_message), (on_delete_message): Used an idle
133 handler, as we do for the other D-Bus method handlers.
134 Call modest_ui_actions_refresh_message_window_after_delete()
135 if the deleted message was open in a window. This fixed
136 projects.maemo.org bug NB#62862.
138 2007-07-11 Murray Cumming <murrayc@murrayc.com>
140 * src/modest-main.c: (main): Only show the UI at the start if
141 the showui command line option was given. For instance,
142 run-standalone src/modest showui
143 Otherwise, we wait for the top_application D-Bus method to
144 be sent by hildon-desktop when the application is selected
146 This allows us to run without a UI when osso-global-search
147 uses our D-Bus methods.
149 2007-07-11 Murray Cumming <murrayc@murrayc.com>
151 * src/dbus_api/modest-dbus-api.h: Added a define for a
152 top-application D-Bus method.
153 * src/dbus_api/modest-dbus-callbacks.c:
154 (on_top_application),
155 (modest_dbus_req_handler): Handle the top-application D-Bus
156 method, which might be an undocumented D-Bus signal sent by
157 hildon-desktop when it starts the application from the menu.
158 But I am not sure and I need to test it on the device, because
159 my scratchbox does not have the application in the menu now.
160 This method shows the main window, so that it can be invisible
161 when started, for instance, just for email searching from
164 * src/maemo/modest-main-window.c: (restore_settings),
165 (modest_main_window_new): Do not show the window immediately
166 upon creation. We show it later.
167 * src/modest-widget-memory.c: (save_settings_paned):
168 Try (unsuccessfully) to avoid saving the paned position when
169 it is not even visible.
170 (restore_settings_paned): Do not allow a silly paned position.
171 This seems necessary when not showing the window at first.
173 * tests/dbus_api/Makefile.am:
174 * tests/dbus_api/test_top_application.c: (main): Test for the
177 2007-07-10 Murray Cumming <murrayc@murrayc.com>
179 * src/modest-ui-dimming-rules.c:
180 (modest_ui_dimming_rules_on_new_msg),
181 (modest_ui_dimming_rules_on_reply_msg),
182 (modest_ui_dimming_rules_on_delete_msg),
183 (modest_ui_dimming_rules_on_details),
184 (modest_ui_dimming_rules_on_view_window_move_to),
185 (modest_ui_dimming_rules_on_view_previous),
186 (modest_ui_dimming_rules_on_view_next),
187 (_invalid_folder_for_purge): Added checks before
188 casting the window. This looks like an actual
189 logic error in _invalid_folder_for_purge(), because it
190 tries to use a ModestMainWindow as a message window.
192 2007-07-10 Murray Cumming <murrayc@murrayc.com>
194 * src/maemo/modest-account-settings-dialog.c:
195 (show_error): Use the same implementation as in
196 modest-easysetup-wizard.c:
197 (on_entry_invalid_character): The logical ID contains a %s.
198 Guessed what it should be.
199 (on_entry_max), (check_data), (on_response): Adapt to
200 changed show_error().
201 (create_page_account_details): Really call
202 modest_validating_entry_set_func() on the correct widgets.
203 * src/maemo/easysetup/modest-easysetup-wizard.c:
204 (on_entry_invalid_character): Fix the logical ID here too.
205 (create_page_account_details),
206 (create_page_user_details):
208 modest_validating_entry_set_func() on the correct widgets.
210 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
211 Do not try to use the account if it is NULL.
213 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
215 * src/modest-ui-actions.c: (create_move_to_dialog),
216 (modest_ui_actions_on_main_window_move_to),
217 (modest_ui_actions_on_msg_view_window_move_to):
218 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
219 (filter_row), (modest_folder_view_show_non_move_folders):
220 * src/widgets/modest-folder-view.h:
222 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
223 the Sent folder yet as it does not report the correct folder type.
225 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
227 * src/maemo/modest-msg-edit-window.c: (init_window):
230 2007-07-10 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
233 Take a parent widget instead of a parent window, and
234 implement this with hildon_banner_show_information() instead.
235 Non-Maemo builds can just ifdef that there.
236 This fixed projects.maemo.org bug NB#62766.
238 (on_entry_invalid_character): Use show_error() again instead
239 of using hildon directly, and use the _CS() macro to use the correct
241 (create_account), (check_for_supported_auth_methods), (on_entry_max):
242 Pass a widget instead od a window to show_error().
244 2007-07-10 Murray Cumming <murrayc@murrayc.com>
246 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
247 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
248 This allows us to show the server name in the error message, fixing
249 projects.maemo.org bug NB#62904.
250 Also, use the appropriate logical ID message for the account protocol.
252 2007-07-10 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-tny-account-store.c: (on_idle_wrong_password):
255 A compilation fix, though the build wasn't broken for me.
257 2007-07-09 Murray Cumming <murrayc@murrayc.com>
259 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
260 Do not try to unref a NULL folder store, to avoid a runtime warning.
261 This seems to happen sometimes when changing accounts settings.
263 2007-07-09 Murray Cumming <murrayc@murrayc.com>
265 * src/modest-tny-account-store.c:
266 (modest_tny_account_store_instance_init),
267 (modest_tny_account_store_finalize),
268 (on_account_settings_hide), (on_idle_wrong_password):
269 Use a GHashTable to ensure that we only show one account settings
270 dialog per modest account. This avoids us having a dialog open for
271 both the store and transport accounts, or due to repeated get_password()
272 calls that shouldn't happen anyway.
274 2007-07-09 Murray Cumming <murrayc@murrayc.com>
276 * src/maemo/modest-maemo-utils.c: (on_hide),
277 (modest_maemo_show_dialog_and_forget): Handle the response, because
278 the window is not even hidden by default.
280 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
281 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
282 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
283 which seems to prevent some modality problems.
285 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
286 Ignore user cancellation errors.
288 * src/modest-account-mgr-helpers.h:
289 * src/modest-account-mgr-helpers.c:
290 Added modest_server_account_get_password() and
291 modest_server_account_get_has_password() to avoid direct use of
294 * src/maemo/modest-account-settings-dialog.h:
295 * src/maemo/modest-account-settings-dialog.c:
296 (modest_account_settings_dialog_init): Store the notebook so we can
298 Added modest_account_settings_dialog_switch_to_user_info().
300 * src/modest-tny-account-store.c:
301 (get_password): When the password in the account settings is wrong (we think),
302 show the relevant page of the account settings dialog, in the mainloop.
303 However, we currently get many of these at once because cancel does not
305 (forget_password): Do not forget the password
306 from the account settings, because this causes side-effects when
307 tinymail seems to call it at strange time, maybe because of how we
308 are cancelling get_password().
309 (modest_tny_account_store_alert): Ignore user cancellations.
311 2007-07-09 Murray Cumming <murrayc@murrayc.com>
313 * src/maemo/modest-maemo-utils.h:
314 * src/maemo/modest-maemo-utils.c:
315 Added modest_maemo_show_information_note_and_forget() for use instead of
316 gtk_dialog_run() when the response is not needed, to avoid an extra
317 mainloop which could cause a hang.
319 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
320 Use the logical IDs for the error message, though they are not
321 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
322 because gtk_dialog_run() caused a hang here (the window did not close).
323 This fixes projects.maemo.org bug NB#62646.
325 2007-07-09 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-account-mgr-helpers.h:
328 * src/modest-account-mgr-helpers.c:
329 Added modest_account_mgr_get_store_protocol().
331 * src/maemo/modest-account-view-window.c:
332 (on_delete_button_clicked): Show different warning text depending on
333 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
334 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
337 2007-07-09 Murray Cumming <murrayc@murrayc.com>
339 * src/maemo/modest-msg-edit-window.c:
340 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
341 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
343 2007-07-07 Armin Burgmeier <armin@openismus.com>
345 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
346 ckdg_ib_maximum_characters_reached from correct package.
348 * src/modest-ui-actions.c: Show an error message when a folder could
349 not be created. Tinymail does not give us specific error codes about
350 what has gone wrong, so we assume that a folder with that name
351 already exists, though there might be other reasons.
353 2007-07-06 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
356 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
357 give a more exact error message that can be partly translated.
359 2007-07-05 Murray Cumming <murrayc@murrayc.com>
361 * src/maemo/modest-address-book.c:
362 (select_email_addrs_for_contact): Specify a default window size for the
363 select-email-address dialog, so that it is probably big enough for the
364 title. This should fix projects.maemo.org bug NB#62277.
366 2007-07-05 Murray Cumming <murrayc@murrayc.com>
368 * src/maemo/easysetup/modest-easysetup-wizard.c:
369 (create_page_complete_easysetup): Use
370 gtk_widget_set_size() request to ensure that the text wraps
373 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
375 * src/maemo/easysetup/modest-easysetup-wizard.c:
376 (on_entry_invalid_character), (create_page_account_details),
377 (create_page_user_details):
378 Use new API of ModestValidatingEntry. But for some reason the banner is
379 not shown. I will have to investigate that further.
381 * src/widgets/modest-validating-entry.c: (on_insert_text),
382 (modest_validating_entry_set_func):
383 * src/widgets/modest-validating-entry.h:
384 Added a new callback function to be able to react to prevented
385 characters whitespaces to e.g show a banner.
387 2007-07-05 Armin Burgmeier <armin@openismus.com>
389 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
390 notification of HildonNumberEditor instead of remembering the port
391 number. Thanks to Johannes for pointing this out.
393 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
395 * src/maemo/easysetup/modest-easysetup-wizard.c:
396 Check if there are any user changes before showing a confirmation
397 dialog (projects.maemo.org NB#60946)
399 2007-07-05 Armin Burgmeier <armin@openismus.com>
401 * src/maemo/modest-account-settings-dialog.c: Remember custom port
402 number at the beginning of the dialog and set the modified flag at the
403 end if the port number has changed. This is necessary because
404 HildonNumberEditor does not support notification when the value has
407 2007-07-05 Murray Cumming <murrayc@murrayc.com>
409 * src/modest-ui-actions.c:
410 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
411 a connection before asking anything else. Correct the check for the destination
412 folder so that it succeeds when online.
413 This fixed projects.maemo.org bug NB#61645.
415 2007-07-05 Murray Cumming <murrayc@murrayc.com>
417 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
418 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
419 to fix projects.maemo.org bug NB#62439.
421 2007-07-05 Murray Cumming <murrayc@murrayc.com>
423 * src/modest-tny-account.c: (on_connection_status_changed):
424 Really do not use tny_device_force_offline() here. See the previous comment.
426 2007-07-04 Murray Cumming <murrayc@murrayc.com>
428 * src/modest-tny-account.c: (on_connection_status_changed):
429 Do not use tny_device_force_offline() when tinymail says that something
430 went wrong with the connection. It seems to report this unnecessarily.
432 2007-07-04 Murray Cumming <murrayc@murrayc.com>
434 * src/maemo/modest-connection-specific-smtp-window.c:
435 (modest_connection_specific_smtp_window_init):
436 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
437 does not seem to have any effect in osso 1.1 (though it works in
438 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
440 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
442 * src/maemo/modest-connection-specific-smtp-window.c:
443 Fix UI specification problems with projects.meamo.org NB#60479
445 2007-07-04 Murray Cumming <murrayc@murrayc.com>
447 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
448 clue when this has failed, because the error dialog is not always shown
449 (at least in earlier version).
451 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
452 GError message, because the generic error dialog is not helpful.
454 'This message is not currently available (can't let a new connection go online)'
455 when trying to open an IMAP message.
457 (_modest_ui_actions_open): Offer a connection when some messages would
458 have to be downloaded and we are offline.
460 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
462 * src/widgets/modest-folder-view.c:
463 Don't check for MERGE type anymore as we use the correct type
465 NOTE: For the last two changes you need to update your tinymail copy
466 because of API changes!
468 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
470 * src/modest-tny-local-folders-account.c:
471 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
472 (see projects.maemo.org NB#61580)
474 2007-07-04 Murray Cumming <murrayc@murrayc.com>
476 * src/modest-tny-account.c: (on_connection_status_changed):
477 Commented out the call to modest_platform_connect_and_wait() because this
478 seems to always hang, and I would like to know if this is the only thing
479 that causes a hang when showing the connection dialog.
480 It is not very useful anyway.
482 2007-07-04 Murray Cumming <murrayc@murrayc.com>
484 * src/maemo/modest-msg-view-window.c:
485 (modest_msg_view_window_select_next_message):
487 * src/modest-platform.h:
488 * src/maemo/modest-platform.c:
489 Added modest_platform_connect_and_wait(), which calls
490 tny_maemo_conic_device_connect() always in the main thread, by calling it
491 in an idle handler and waiting for the idle handler to run. It should be
492 in the main thread because it uses GTK+ UI code. It just returns TRUE
493 if the device is already online.
495 There is some nasty code to ensure that subsequent calls to
496 modest_platform_connect_and_wait() just wait for the first one to finish,
497 by checking repeatedly in another idle handler. This is necessary,
498 because other threads (or even the main thread, via another idle handler)
499 can call modest_platform_connect_and_wait() while
500 modest_platform_connect_and_wait() is running.
502 (modest_platform_connect_and_wait_if_network_account),
503 (modest_platform_connect_and_wait_if_network_folderstore):
504 Convenience functions that calls modest_platform_connect_and_wait() if
505 the account or folder might want network access.
507 * src/modest-mail-operation.c:
508 (modest_mail_operation_update_account):
509 * src/modest-ui-actions.c: (download_uncached_messages),
510 (modest_ui_actions_on_rename_folder), (delete_folder),
511 (modest_ui_actions_on_main_window_move_to),
512 (modest_ui_actions_on_msg_view_window_move_to):
513 * src/widgets/modest-folder-view.c:
514 (drag_and_drop_from_folder_view):
515 Offer a connection if we are offline.
517 * src/modest-tny-account.c: (on_connection_status_changed):
518 Document this as only handling errors during network operations in progress,
519 and replace the idle code with a simple call to
520 modest_platform_connect_and_wait(), which does this instead.
522 2007-07-03 Murray Cumming <murrayc@murrayc.com>
524 * src/modest-tny-account.c:
525 (modest_tny_account_get_special_folder): (util_on_idle),
526 Handle the GError so we can see when tny_folder_store_get_folders()
527 fails, as it currently does while something else is connecting.
529 Added util_run_in_main_thread_and_wait()
530 which uses an idlen handler and mainloop to ensure that the function
531 is called in the main thread.
532 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
533 to make sure that we call attempt the connection in the mainloop only,
534 which might solve some hangs.
536 2007-07-03 Murray Cumming <murrayc@murrayc.com>
538 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
539 be found by their display name. This is never useful.
540 * src/modest-tny-account-store.c: (on_account_removed): Find the account
541 by its ID, instead of trying to use its ID as its display name.
543 * src/modest-tny-account-store.h:
544 * src/modest-tny-account.c:
545 (modest_tny_account_get_special_folder): Add a g_warning() when
546 tny_folder_store_get_folders() returns an empty list for the maildir.
548 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
549 Add a g_warning() when this returns NULL, because that it not allowed
552 2007-07-02 Armin Burgmeier <armin@openismus.com>
554 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
555 note when trying to cancel the wizard. This fixes projects.maemo.org
558 2007-07-02 Murray Cumming <murrayc@murrayc.com>
560 * src/modest-tny-account.h:
561 * src/modest-tny-account.c:
562 (modest_tny_account_new_from_server_account),
563 (modest_tny_account_new_from_server_account_name),
564 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
565 because this must now be set before setting the proto. This is usd in
566 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
567 warning in camel_session_get_service() caused by
568 tny_camel_transport_account_prepare().
570 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
573 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
575 * src/maemo/modest-connection-specific-smtp-edit-window.c:
577 (modest_connection_specific_smtp_edit_window_init):
579 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
582 2007-06-29 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-tny-account.c:
585 (modest_tny_account_new_from_server_account):
586 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
587 now uses to request a connection when it needs one, and which it uses
588 to tell us that something is wrong with the connection, so we can force
589 the accounts offline to prevent further problems.
592 * src/modest-init.c: (init_default_settings):
593 * src/modest-mail-operation.c:
594 (modest_mail_operation_update_account):
595 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
596 This should not be necessary anymore. Do not set the conf key that
597 determined this (it was always TRUE and not set anywhere else).
599 * src/modest-ui-actions.h: Remove unused and unimplemented
600 modest_ui_actions_on_online_toggle_toggled().
602 2007-06-29 Murray Cumming <murrayc@murrayc.com
604 * src/maemo/modest-main-window.c: (connect_signals):
605 Don't connect to delete_event twice. Maybe this was harmless.
607 2007-06-29 Murray Cumming <murrayc@murrayc.com
609 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
610 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
611 Debug output to give some more clue when a folder move is not allowed.
613 2007-06-28 Murray Cumming <murrayc@murrayc.com
615 * src/modest-tny-account.c: (on_modest_file_system_info),
616 (modest_tny_account_get_mmc_account_name):
617 Always call the callback, without checking whether the name has changed.
618 * src/widgets/modest-folder-view.c: (strings_are_equal),
619 (on_model_foreach_set_name), (on_get_mmc_account_name),
620 (text_cell_data): Compare the name here, and use the name from
621 the account rather than from the
622 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
623 if the name was changed after the account was added to the model.
624 That's a tinymail bug but not one that I want to fix now.
626 This finally fixes projects.maemo.org bug NB#59301.
628 2007-06-27 Armin Burgmeier <armin@openismus.com>
630 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
633 2007-06-27 Murray Cumming <murrayc@murrayc.com
635 * src/modest-tny-account.h:
636 * src/modest-tny-account.c:
637 Added modest_tny_account_get_mmc_account_name(), to set the memory
638 card name asynchronously for the given account and then notify.
639 (modest_tny_account_new_for_local_folders): Use this new function instead
640 of using hildon_file_system_info_async_new() directly.
642 * src/widgets/modest-folder-view.c: (text_cell_data):
643 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
644 gtk_tree_model_row_changed() when it is available.
646 This should fix projects.maemo.org bug NB#59301.
648 2007-06-27 Murray Cumming <murrayc@murrayc.com
650 * src/modest-mail-operation.c: (update_account_thread),
651 (get_msgs_full_thread): Fix typo failures in the revert
654 2007-06-27 Murray Cumming <murrayc@murrayc.com
656 * src/maemo/modest-maemo-global-settings-dialog.c:
657 (idle_select_default_focus):
658 * src/modest-mail-operation.c: (idle_notify_progress),
659 (idle_notify_progress_once), (set_last_updated_idle),
660 (update_account_thread), (get_msgs_full_thread):
661 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
662 * src/widgets/modest-header-view.c:
663 (idle_notify_headers_count_changed_destroy),
664 (idle_notify_headers_count_changed):
665 Reverted the additions of gdk_threads_enter/leave(), in case this
666 helps with a startup hang on the device.
668 2007-06-26 Armin Burgmeier <armin@openismus.com>
670 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
671 for supported secure authentication methods from server by
672 gtk_dialog_run(), saving CPU time and a potential race condition.
674 2007-06-26 Armin Burgmeier <armin@openismus.com>
676 * src/maemo/modest-maemo-utils.h:
677 * src/maemo/modest-maemo-utils.c: Added a
678 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
679 only error code to tell the calling code when the user canceled the
682 * src/maemo/modest-account-settings-dialog.h:
683 * src/maemo/modest-account-settings-dialog.c:
684 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
685 message if the retrieval of secure authentication methods was canceled
686 by the user. Perform the check before saving anything to configuration
687 to not end up with half-committed configuration changes, do not show
688 a "Saving to configuration failed" note when authentication methods
689 could not be retrieved.
691 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
694 2007-06-26 Murray Cumming <murrayc@murrayc.com>
696 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
697 Only return the first level of folders under accounts, because the
698 osso-global-search UI spec doesn't want the rest.
699 This fixed projects.maemo.org bug NB#61811.
701 2007-06-26 Murray Cumming <murrayc@murrayc.com>
703 * src/modest-tny-account-store.c:
704 * src/modest-tny-account-store.h:
705 Added modest_tny_account_is_memory_card_account().
706 * src/maemo/modest-main-window.c: (create_details_widget):
707 Show the same information items for the memory card as we show for the
708 local-folders, to fix projects.maemo.org bug NB#59307.
710 2007-06-26 Murray Cumming <murrayc@murrayc.com>
712 * src/modest-tny-account-store.c: (get_password):
713 Added some checks for NULL to maybe prevent crashes, though I think
714 it was Philip's last commit that actually prevented the crash here
715 when creating a first new account.
716 But the new account is still not usable (no messages are shown)
717 until a restart of the application.
719 2007-06-26 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/modest-maemo-global-settings-dialog.c:
722 (idle_select_default_focus):
723 * src/modest-mail-operation.c: (idle_notify_progress),
724 (idle_notify_progress_once), (idle_notify_update_account_queue),
725 (set_last_updated_idle), (update_account_thread),
726 (notify_get_msgs_full), (get_msgs_full_destroyer),
727 (get_msgs_full_thread):
728 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
729 * src/widgets/modest-header-view.c:
730 (idle_notify_headers_count_changed_destroy),
731 (idle_notify_headers_count_changed):
732 Use gdk_threads_enter() and gdk_threads_enter_leave() in
733 all idle handlers, because some other thread could be blocking
734 the GDK lock, so that it can do GUI stuff.
736 2007-06-26 Murray Cumming <murrayc@murrayc.com>
738 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
739 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
740 (on_idle_send_receive), (on_idle_open_default_inbox):
741 * src/maemo/modest-msg-edit-window.c:
742 (modest_msg_edit_window_attach_file_noninteractive):
743 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
744 to prevent a hang. I don't quite understand why these are necessary,
745 beause we should already be in the main loop. I guess something outside
746 of the main loop is taking the lock.
748 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
749 we are really using URIs, and use files that are more likely to exist.
751 2007-06-26 Murray Cumming <murrayc@murrayc.com>
753 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
754 necessary because configure.ac now defines different variables.
756 2007-06-26 Murray Cumming <murrayc@murrayc.com>
758 * libmodest-dbus-client/libmodest-dbus-client.c:
759 * libmodest-dbus-client/libmodest-dbus-client.h:
760 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
761 libmodest_dbus_client_compose_mail() is what things actually use.
763 * src/dbus_api/modest-dbus-api.h:
764 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
765 * tests/dbus_api/Makefile.am:
766 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
769 2007-06-26 Murray Cumming <murrayc@murrayc.com>
771 * src/modest-init.c: (modest_init_local_folders):
772 For memory-card (or other non local-folders) maildir accounts,
773 always create an Archive folder, so that there is somewhere to put
774 messages. This should be less confusing, because the user does not need
775 to guess that the need to create a folder.
777 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
779 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
780 Fixed icon size by using (50, 50) which is the same as defined by
783 2007-06-25 Armin Burgmeier <armin@openismus.com>
785 * src/widgets/modest-window-mgr.c:
787 * configure.ac: Correctly recognize hildon-notify presence and fixed
788 the build without it being installed.
790 2007-06-25 Murray Cumming <murrayc@murrayc.com>
792 * libmodest-dbus-client/libmodest-dbus-client.c:
793 (libmodest_dbus_client_search): Fix the build. Sorry.
794 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
795 (reply_forward_cb): Initialize variables to fix the build.
797 * src/modest-tny-account-store.c:
798 (modest_tny_account_store_get_tny_account_by): Fix the account URI
799 comparison (a silly typo) so that email search results can be opened
800 when there are more than one account.
802 2007-06-25 Murray Cumming <murrayc@murrayc.com>
804 * libmodest-dbus-client/libmodest-dbus-client.c:
805 (libmodest_dbus_client_search),
806 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
807 instead of 1 second, because the search gets folders and messages from
808 the server, which can take a long time. When it times out,
809 osso-global-search will report no results.
811 We need to specify whether we should search only cached information
812 (maybe with a user preference), and the osso-email-search-plugin
813 API should really be improved to allow that option, and to allow results
814 to be delivered asynchronously in batches.
816 2007-06-25 Murray Cumming <murrayc@murrayc.com>
818 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
819 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
820 GTK_ICON_SIZE_DIALOG is probably the wrong size.
822 2007-06-25 Murray Cumming <murrayc@murrayc.com>
824 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
825 that is an empty string. D-Bus seems to give us these instead of NULL.
827 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
829 * src/dbus_api/modest-dbus-callbacks.c:
830 * src/maemo/easysetup/modest-easysetup-wizard.h:
831 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
832 * src/maemo/modest-connection-specific-smtp-edit-window.c:
833 (modest_connection_specific_smtp_edit_window_init):
834 * src/maemo/modest-maemo-global-settings-dialog.c:
836 * src/maemo/modest-maemo-utils.c:
837 (modest_maemo_utils_setup_images_filechooser):
838 * src/maemo/modest-main-window.c: (create_details_widget):
839 * src/maemo/modest-msg-edit-window.c:
840 (modest_msg_edit_window_attach_file_noninteractive),
841 (modest_msg_edit_window_color_button_change),
842 (modest_msg_edit_window_set_zoom):
843 * src/modest-mail-operation.c: (update_account_thread):
844 * src/modest-tny-account-store.c:
845 * src/modest-tny-account.c:
846 * src/widgets/modest-global-settings-dialog.c:
847 * src/widgets/modest-window.h:
851 2007-06-25 Murray Cumming <murrayc@murrayc.com>
853 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
854 * src/modest-search.c: (modest_search_folder),
855 (modest_search_all_accounts): Actually search only in the specified folder,
856 doing a simple match on the folder ID.
857 * src/modest-search.h: Added a folder field to the ModestSearch struct,
858 and added some documentation.
860 2007-06-22 Armin Burgmeier <armin@openismus.com>
862 * src/maemo/modest-maemo-utils.h:
863 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
864 modest_maemo_utils_get_supported_secure_authentication_methods.
866 * src/maemo/easysetup/modest-easysetup-wizard.c:
867 * src/maemo/modest-account-settings-dialog.c: Show correct error if
868 one occured, not just "Server does not support secure authentication".
870 2007-06-22 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-tny-account-store.c: (get_password):
873 Restored the call to tny_account_set_user() because Philip seems to have
874 stopped this from crashing (by not using the freed string). It still does
875 not work, but now we can test it.
877 2007-06-22 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/modest-msg-edit-window.c: (init_window):
880 Comment out use of an uninitialzed GtkScrolledWindow variable,
881 to fix the build and stop a crash. Yet again.
883 2007-06-22 Murray Cumming <murrayc@murrayc.com>
885 * src/modest-tny-account-store.c: (get_password):
886 Remove the call to tny_account_set_user() because this actually crashes.
887 As mentioned in the last commit, it is known to not work anyway.
889 2007-06-22 Murray Cumming <murrayc@murrayc.com>
891 * src/modest-tny-account-store.c: (get_password):
892 Use tny_account_set_username() to tell tinymail that the username might
893 have changed too. But tinymail ignores this: see projects.maemo.org
895 * src/modest-ui-actions.c:
896 (modest_ui_actions_on_password_requested): Remove the useless attempt to
897 reset the connection when changing the username, and improve the comments.
898 Save the changed username to gconf at least, so it is used when Modest is
901 2007-06-21 Murray Cumming <murrayc@murrayc.com>
903 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
904 Do not use a query, so that we get all folders, including for POP and
905 local-folders. They work as search criteria too.
906 This fixes projects.maemo.org bug NB#57740.
908 2007-06-21 Murray Cumming <murrayc@murrayc.com>
910 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
911 Comment out the use of hildon_notification_set_sound() because it is
912 not declared, to fix the build. Warnings are serious, people.
914 2007-06-21 Armin Burgmeier <armin@openismus.com>
916 * src/maemo/modest-maemo-utils.h:
917 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
918 modest_maemo_utils_get_supported_secure_authentication_methods()
919 to query authentication methods for a specific user. This should fix
920 projects.maemo.org bug NB#61369.
922 * src/maemo/easysetup/modest-easysetup-wizard.c:
923 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
926 2007-06-21 Murray Cumming <murrayc@murrayc.com>
928 * libmodest-dbus-client/libmodest-dbus-client.h:
929 * libmodest-dbus-client/libmodest-dbus-client.c:
930 (modest_dbus_message_iter_get_search_hit),
931 (libmodest_dbus_client_search):
932 Reorganised and commented this.
933 Removed modest_search_hit_free() from the public API because it
936 Added libmodest_dbus_client_get_folders() and
937 modest_folder_result_list_free().
939 * src/dbus_api/modest-dbus-api.h:
940 * src/dbus_api/modest-dbus-callbacks.c:
941 (modest_dbus_req_filter): Commented. Moved most code to
942 on_dbus_method_search() and added on_dbus_method_get_folders().
944 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
945 of the extra D-Bus handler.
947 * tests/dbus_api/Makefile.am:
948 * tests/dbus_api/test_get_folders.c: New test for
949 libmodest_dbus_client_get_folders(). This seems to return an empty list
950 at the moment. That could be the same error that causes the message list
951 to be empty sometimes.
952 This should help with projects.maemo.org bug NB#57740.
954 2007-06-21 Armin Burgmeier <armin@openismus.com>
956 * src/modest-mail-operation.c: Do not call
957 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
958 notify the operation's end after having set the status to CANCELED for
959 the operation queue to listen on. This fixes a deadlock when there
960 were mail operations in the queue during its finalization.
962 * src/modest-singletons.c: Reordered uninitialization of the account
963 manager to happen after the mail operation queue was uninitialized
964 because the mail operation's in the queue might still try to access
965 the account manager (see modest_mail_operation_notify_end()). This
966 fixes a potential crash when terminating the application.
968 2007-06-21 Murray Cumming <murrayc@murrayc.com>
970 * src/modest-search.c:
971 (search_mime_part_and_child_parts): Moved some code here so we
972 can search recursively in child folders.
973 (modest_search_folder): Search in the message as a mime part, instead
974 of just its child mime parts.
975 (read_chunk), (search_mime_part_ogs):
976 Check how many bytes were read, to prevent an endless loop.
977 Searching in message bodies now works. This finishes the fix for
978 projects.maemo.org bug NB#61007.
980 2007-06-20 Murray Cumming <murrayc@murrayc.com>
982 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
983 Add a g_warning when the item is not a folder.
985 * src/modest-ui-dimming-rules.c:
986 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
987 when selected item is not a folder (for instance, an account), because
988 the UI spec only talks about folders.
989 I am not sure what the UI spec wants, so this might not totally fix
990 projects.maemo.org bug NB#60794.
992 2007-06-20 Murray Cumming <murrayc@murrayc.com>
994 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
995 (load_from_file): Sort the list. The unsorted list would be more noticeable
996 in non-English locales.
998 * src/maemo/modest-msg-edit-window.c:
999 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1000 warning and fix the build.
1002 * src/maemo/modest-progress-bar-widget.c:
1003 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1004 avoid a g_warning, and probably to avoid a crash.
1006 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1008 * src/modest-search.c: (modest_search_folder): Check for a GError
1009 when calling tny_folder_get_headers(), to show that this is not the cause
1012 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1014 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1015 Actually set the body query instead of the subject query.
1017 * src/modest-search.c: (search_mime_part_ogs),
1018 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1019 which would probably cause it to fail if we got this far.
1021 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1022 to simplify the code.
1023 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1024 be causing search-in-body to fail.
1026 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1028 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1030 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1031 Better debug message when the folder cannot be found.
1032 This should help with fixing projects.maemo.org bug #61287.
1033 * src/modest-search.c: (add_hit): Do not leak the furl string.
1035 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1037 * src/modest-ui-actions.c:
1038 (modest_ui_actions_on_folder_selection_changed):
1039 Do not special-case TNY_MERGE_FOLDER here, because
1040 modest_tny_folder_get_account() already does that. This fixes
1041 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1042 shown when the Outbox was selected).
1044 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1046 * libmodest-dbus-client/libmodest-dbus-client.c:
1047 (_dbus_iter_get_string_or_null): Initialize the string variable in
1048 case this helps with Dirk's crash.
1050 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1052 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1053 though it is not implemented yet (this function is maybe not even used),
1054 to avoid breaking ABI in future.
1055 * libmodest-dbus-client/libmodest-dbus-client.c:
1056 (get_attachments_string): Moved some code into this generic function.
1057 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1058 sends email. It is maybe not used.
1059 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1060 (on_send_mail): Use attachments.
1062 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1063 * src/maemo/modest-msg-edit-window.c:
1064 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1065 a filename before using it, to fix projects.maemo.org bug NB#58233.
1067 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1069 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1070 Initialize the continue_download variable to fix the build, and probably
1071 to fix randome behaviour.
1073 2007-06-18 Armin Burgmeier <armin@openismus.com>
1075 * src/modest-tny-send-queue.h:
1076 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1077 the queue so we can later show it in the UI. Replaced
1078 modest_tny_send_queue_msg_is_being_sent() by
1079 modest_tny_send_queue_get_msg_status().
1081 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1083 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1084 gpointer. This probably was not harmful, but just to be sure.
1086 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1088 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1089 Fix the build, but leave the function broken on Bora, because
1090 hildon_uri_action_get_service() does not exist.
1091 osso_uri_action_get_service() does not exist either, it seems.
1093 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-tny-account.c:
1096 (modest_tny_account_new_from_server_account):
1097 Uncommented the url debug output again, because it is useful for
1098 debugging, as I said in the comment.
1100 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1102 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1104 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1105 for Mameo Bora, to fix the build.
1107 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1110 Fixed build with hildon < 0.99
1112 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1113 Check if the selected account is busy instead of checking all accounts
1115 * src/modest-account-mgr-priv.h:
1116 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1117 (modest_account_mgr_init), (compare_account_name),
1118 (modest_account_mgr_set_account_busy),
1119 (modest_account_mgr_account_is_busy):
1120 * src/modest-account-mgr.h:
1121 Added busy information to the account manager. It possible to
1122 set an account to busy or not busy now.
1124 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1125 (modest_mail_operation_update_account),
1126 (modest_mail_operation_notify_end):
1127 Set the account to busy/not busy depending on the operation state.
1129 * src/widgets/modest-account-view.c:
1130 (modest_account_view_finalize), (get_last_updated_string),
1131 (update_account_view), (on_account_busy_changed), (init_view):
1132 Show string "Refreshing..." if the account is currently busy.
1134 All this fixes projects.maemo.org bug NB#59711
1136 2007-06-14 Armin Burgmeier <armin@openismus.com>
1138 * src/widgets/modest-attachments-view.h:
1139 * src/widgets/modest-attachments-view.c: Added
1140 modest_attachments_view_has_attachments() and fixed coordinate
1141 transformation in get_att_view_at_coords(). This fixes attachment
1144 * src/widgets/modest-msg-view.c: Make use of
1145 modest_attachments_view_has_attachments() to decide whether to show
1146 attachments in the header.
1148 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1151 (on_change), (on_combo_security_changed),
1152 (modest_connection_specific_smtp_edit_window_init),
1153 (modest_connection_specific_smtp_edit_window_set_connection),
1154 (modest_connection_specific_smtp_edit_window_is_dirty):
1155 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1156 * src/maemo/modest-connection-specific-smtp-window.c:
1159 Show an comfirmation dialog for the smpt-edit-window if there are
1160 unsaved changes and the user hits cancel.
1161 (projects.maemo.org bug NB#60479)
1163 2007-06-14 Armin Burgmeier <armin@openismus.com>
1165 * src/maemo/easysetup/modest-easysetup-wizard.c:
1166 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1167 address" info in banner instead of node, and select all the text as
1168 per UI spec. This fixes projects.maemo.org bug NB#60550.
1170 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1172 reviewed by: <delete if not using a buddy>
1174 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1175 * src/modest-ui-actions.c: (folder_refreshed_cb):
1177 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1179 * src/widgets/modest-folder-view.c: (filter_row):
1180 Explictly filter out the per-account outbox accounts. I don't know why
1181 these only sometimes show up, but now they should never show up in the UI.
1182 This should fix projects.maemo.org bug NB#60160.
1184 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1187 when the toolbar does not exist yet.
1188 * src/modest-widget-memory.c: (save_settings_header_view):
1189 Added g_warnings() to help us to discover when we are trying to set
1190 an empty columns list in gconf.
1192 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1194 * src/modest-init.h:
1195 * src/modest-init.c:
1196 Added modest_init_get_default_header_view_column_ids().
1198 * src/modest-widget-memory.c: (restore_settings_header_view):
1199 Use the new function to get defaults, if the gconf key is empty,
1200 instead of not creating any columns. This seems to fix the
1201 empty right-hand pane problems.
1203 * src/widgets/modest-header-view.h: Improved documentation.
1205 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1207 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1208 Revert the use of the display name as the account name, because this
1209 is generally wrong and would break the code that follows.
1211 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1213 * src/maemo/easysetup/modest-easysetup-wizard.c:
1214 (check_for_supported_auth_methods), (on_before_next),
1217 More correct fix for projects.maemo.org bug NB# 58991
1218 Do not longer accept AUTH_PASSWORD as secure method and choose
1219 correct method when creating the account.
1221 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1223 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1224 Fixed projects.maemo.org bug NB# 58991
1226 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1228 * src/modest-init.c: (modest_init_init_core),
1229 (modest_init_local_folders): Fixed compilation errors.
1231 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1233 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1234 Remove unnecessary lib/include, though it is good in principle when needed.
1236 * src/modest-init.c: (modest_init_one_local_folder),
1237 (modest_init_local_folders):
1238 * src/modest-init.h: Initialize the .modest library for memory cards,
1239 instead of just doing nothing for them. This should allow us to create
1240 folders there, fixing projects.maemo.org bug NB#59297.
1242 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1244 * libmodest-dbus-client/libmodest-dbus-client.c:
1245 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1246 (libmodest_dbus_client_compose_mail),
1247 (libmodest_dbus_client_open_message),
1248 (libmodest_dbus_client_send_and_receive),
1249 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1251 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1252 (on_idle_open_message), (modest_dbus_req_handler),
1253 (search_result_to_message), (modest_dbus_req_filter):
1254 * src/modest-search.c: (add_hit), (modest_search_folder),
1255 (modest_search_all_accounts): Improved debug messages.
1257 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1259 * src/modest-tny-account-store.c:
1260 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1263 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1266 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1268 * src/modest-tny-account-store.c: (get_server_accounts):
1269 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1270 even when there are no accounts, so that the Outbox folder is always
1271 visible. This fixes projects.maemo.org bug NB#60158.
1273 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1275 * src/maemo/modest-main-window.c: (create_details_widget):
1276 Use the mcen_va_never logical ID.
1278 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1280 * src/dbus_api/modest-dbus-api.h:
1281 * src/dbus_api/modest-dbus-callbacks.c:
1282 (on_idle_open_default_inbox), (on_open_default_inbox),
1283 (modest_dbus_req_handler):
1284 Added a new OpenDefaultInbox method.
1286 * libmodest-dbus-client/libmodest-dbus-client.h:
1287 * libmodest-dbus-client/libmodest-dbus-client.c:
1288 Added libmodest_dbus_client_open_default_inbox() to call the new
1289 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1290 though it should maybe be used by a new osso-email-interface function.
1292 * tests/dbus_api/Makefile.am:
1293 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1296 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1298 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1299 NULL, so that the signals get all the keys. This should not actually
1300 change any behaviour because we currently update everything when anything
1303 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1305 * src/widgets/modest-folder-view.c: (text_cell_data),
1306 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1307 (find_inbox_iter): If tinymail tells us that the folder is
1308 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1309 This causes the inbox to be selected at startup, fixing part of
1310 projects.maemo.org bug NB#56305.
1312 * src/modest-ui-dimming-rules.c:
1313 (modest_ui_dimming_rules_on_tools_smtp_servers):
1314 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1315 the SMTP servers menu item.
1316 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1317 that the SMTP Servers menu item is dimmed when there are no accounts,
1318 as a future version of the UI spec will require. This fixes
1319 projects.maemo.org bug NB#56305.
1321 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1323 * src/maemo/modest-maemo-utils.c:
1324 (modest_maemo_utils_get_supported_secure_authentication_methods):
1325 Added label to dialog instead of unreadable title
1327 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1328 (modest_main_window_new):
1329 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1332 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1333 * src/modest-account-mgr.h:
1334 Added method to avoid code duplication
1336 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1337 (modest_ui_actions_on_send_receive):
1338 Use modest_account_mgr_has_accounts
1340 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1342 * src/maemo/easysetup/modest-presets.c:
1343 (modest_presets_get_info_server_security): Do not report secure auth
1345 * src/modest-protocol-info.c: Use the defines for the gconf key names
1346 for secure authentication. This was not working because we were writing
1347 Password and reading password, and the check was case sensitive.
1348 With this, gmail now works for receiving and sending when created via
1351 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1353 * src/maemo/easysetup/modest-presets.c:
1354 (modest_presets_get_info_server_security): Correct the key name for
1355 SecureSmtp, because it seems to be case-sensitive.
1356 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1357 Do not try to get the 0th notebook page if there are 0 pages, to
1358 avoid a g_warning().
1360 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1362 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1363 Prevent use of the new notification feature for now, because it currently
1364 shows one dialog for each new email, which is annoying.
1366 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1368 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1369 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1370 when no country was selected, so that we show the global ones.
1371 * src/maemo/easysetup/modest-presets.c:
1372 (modest_presets_get_providers): Return only the global providers, not
1373 all providers when mmc=0 was requested.
1375 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1377 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1378 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1379 provider ID in the combo.
1381 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1382 Do not show the page numbers, because it would be confusing when we add
1383 the 2 extra pages for the custom setup, when the user chooses the "Other"
1384 provider. This fixes projects.maemo.org bug NB#59028
1386 * src/modest-init.c: (modest_init_init_core),
1387 (modest_init_local_folders):
1388 * src/modest-init.h:
1389 * src/modest-tny-account.c:
1390 (modest_tny_account_new_for_local_folders): Do not create default folders
1391 for the memory card. This should fix projects.maemo.org bug NB#59328.
1393 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1395 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1396 Free the changed_conf_keys string items. They are already freed in the
1397 idle handler if that runs first.
1399 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1401 * src/modest-ui-actions.c:
1402 (modest_ui_actions_on_password_requested): Check that the server name
1403 is not NULL, because I just saw a password dialog with (null) as the
1406 * src/modest-tny-folder.[h|c]: Added
1407 modest_tny_folder_is_memory_card_folder().
1408 * src/modest-ui-dimming-rules.c:
1409 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1410 menu item for memory cards, as per the UI spec (section 7.4). This should
1411 fix projects.maemo.org bug NB#59297.
1413 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1415 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1416 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1417 is another problem with the code, see Murray's comment at line 772)
1419 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1421 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1422 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1423 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1424 (load_from_file), (easysetup_country_combo_box_init),
1425 (easysetup_country_combo_box_get_active_country_ids),
1426 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1427 instead of just one ID, to avoid duplicate country names in the UI.
1429 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1430 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1431 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1432 a single ID, avoiding duplicate providers.
1433 * src/maemo/easysetup/modest-easysetup-wizard.c:
1434 (on_combo_account_country): Adapt to use a list.
1436 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1438 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1439 keys changed in the last X seconds.
1441 * src/modest-account-mgr.h:
1442 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1443 (on_key_change), (modest_account_mgr_class_init),
1444 (modest_account_mgr_init), (modest_account_mgr_finalize):
1445 As the keys are changed, save them in a GSList* and signal that GSList*
1446 further every X seconds, to batch changes, to allow us to do just one
1447 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1448 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1450 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1451 changed signal signature.
1453 * src/modest-conf.c: (modest_conf_set_list),
1454 (modest_conf_on_change): Reenable notification.
1456 (modest_conf_maemo_fake_on_change): Comment out the hack that
1457 notified immediately instead of asynchronously.
1459 * src/widgets/modest-account-view.h:
1460 * src/widgets/modest-account-view.c:
1461 (update_account_view): Select the previously-selected account ID,
1462 if possible. This fixes projects.maemo.org bug NB#56933.
1464 (on_account_changed), (on_account_removed),
1465 (modest_account_view_select_account):
1467 Remove the block/unblock functions
1468 because they were not useful.
1470 * src/maemo/modest-account-view-window.c:
1471 (on_delete_button_clicked), (on_edit_button_clicked),
1472 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1474 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1476 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1477 Improve the error dialog to show Incorrect Account Settings, which seems
1478 clearer, and say that the internal error message (to be removed from the
1479 dialog later) is often misleading.
1480 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1482 * src/modest-tny-account.c:
1483 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1484 URL because this is so useful for debugging on the device.
1486 * src/widgets/modest-serversecurity-combo-box.c:
1487 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1489 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1491 * src/modest-mail-operation.c:
1492 (modest_mail_operation_send_new_mail):
1493 Added a comment about a nasty but apparently harmless message. Details
1494 added to the wiki g_warnings() page.
1496 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1499 (modest_tny_send_queue_class_init):
1500 Do not use the priv struct because it is empty, to avoid g_warnings
1501 about a non-existant priv struct.
1503 * src/modest-tny-account-store.c:
1504 (modest_tny_account_store_get_server_account),
1505 (modest_tny_account_store_get_transport_account_for_open_connection
1506 ): Do not try to get transport server accounts for local folders,
1507 because they don't have any. This avoids a g_warning().
1509 * src/maemo/modest-main-window.c:
1510 (modest_main_window_notify_send_receive_initied),
1511 (on_configuration_key_changed):
1512 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1513 * src/modest-defs.h:
1514 * src/modest-mail-operation.c:
1515 (modest_mail_operation_update_account):
1516 * src/modest-tny-account-store.h:
1517 * src/modest-tny-account.c:
1518 (modest_tny_account_get_special_folder),
1519 (modest_tny_account_new_for_local_folders),
1520 (modest_tny_account_new_for_per_account_local_outbox_folder):
1521 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1522 * src/modest-tny-local-folders-account.c:
1523 (add_account_folders_to_merged_folder):
1524 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1525 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1526 (modest_ui_actions_on_send):
1527 * src/widgets/modest-folder-view.c: (update_model):
1528 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1529 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1530 modest_tny_account_store_get_tny_account_by_account() to
1531 modest_tny_account_store_get_server_account() to make the code clearer.
1533 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1535 * src/dbus_api/modest-dbus-api.h:
1536 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1537 * src/maemo/modest-msg-edit-window.c:
1538 (modest_msg_edit_window_attach_file_noninteractive):
1539 added g_warning in case the file to be attached does not exist
1540 * tests/dbus_api/test_compose_mail.c: (main):
1541 removed obsolete comment, added generic files as test case
1543 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1545 * src/modest-tny-account-store.c: (get_server_accounts):
1546 Create the local folders account only once, not once for each outbox, and
1547 not only when there are some outboxes.
1549 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1551 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1552 code that is causing a crash at startup. Sergio says that he is fixing this.
1554 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1556 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1557 * src/maemo/modest-account-settings-dialog.c:
1558 (create_page_outgoing),
1559 (modest_account_settings_dialog_set_account_name),
1560 (save_configuration):
1561 - Fixed handling of the "Use secure authentication" toggle to comply with
1562 the ui specification. See also projects.maemo.org bug NB#58400
1564 - Restore the Secure connection setting combo correctly when loading
1567 * src/maemo/modest-maemo-utils.c:
1568 (on_camel_account_get_supported_secure_authentication),
1569 (modest_maemo_utils_get_supported_secure_authentication_methods):
1570 Fixed a crasher if operation is canceled
1572 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1573 (modest_protocol_info_auth_is_secure):
1574 * src/modest-protocol-info.h:
1576 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1577 the sense of the "Use secure authentication" toggle.
1579 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1581 * src/modest-tny-account-store.h:
1582 * src/modest-tny-account-store.c:
1583 Added modest_tny_account_store_get_local_folders_account().
1585 * src/modest-tny-folder.h:
1586 * src/modest-tny-folder.c:
1587 (modest_tny_folder_get_account):
1588 Added this replacement for tny_folder_get_account() which returns
1589 the local-folders account for TnyMergeFolders, to avoid the
1590 warning about the unimplemented get_account_func() vfunc().
1592 (modest_tny_folder_get_rules),
1593 * src/modest-ui-actions.c:
1594 (modest_ui_actions_on_folder_selection_changed):
1595 * src/modest-mail-operation.c:
1596 (modest_mail_operation_remove_folder),
1597 (modest_mail_operation_xfer_folder),
1598 (modest_mail_operation_rename_folder),
1599 (modest_mail_operation_get_msg),
1600 (modest_mail_operation_get_msgs_full),
1601 (modest_mail_operation_remove_msg),
1602 (modest_mail_operation_xfer_msgs),
1603 (modest_mail_operation_refresh_folder):
1604 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1606 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1608 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1609 (modest_server_account_set_security):
1610 * src/modest-defs.h: Add comments explaining that our
1611 UI spec means TLS when it says Normal, so these do not look like errors.
1613 * src/modest-tny-account.c:
1614 (modest_tny_account_new_from_server_account): Use the new tinymail
1615 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1616 for TLS. This should fix projects.maemo.org bug NB#58460.
1618 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1620 * src/maemo/easysetup/modest-easysetup-wizard.c:
1621 (create_account): Correct the position of the gconf sanity check warning.
1622 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1623 of using the g_idle_add() hack, because this does not seem to be necessary
1624 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1625 caused by something other than maemo's gconf.
1626 This fixes projects.maemo.org bug #59022.
1628 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1630 * src/modest-account-mgr-helpers.c:
1631 (modest_account_mgr_get_default_account): Do not check that the account
1632 exists if there is no default account (NULL), to fix a runtime warning.
1634 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1636 * src/widgets/modest-folder-view.c: (update_model):
1637 Do not unref the treemodel before we have finished with it.
1638 This prevents a valgrind warning and an occasional crash at startup.
1640 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1642 * libmodest-dbus-client/libmodest-dbus-client.h:
1643 added libmodest_dbus_client_compose_mail()
1644 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1646 added functions needed for SendAsMail() functionality
1647 * src/maemo/modest-msg-edit-window.c:
1648 (modest_msg_edit_window_attach_file_noninteractive):
1649 non interactively attaching files to message edit window
1650 * src/widgets/modest-msg-edit-window.h:
1651 * tests/dbus_api/Makefile.am:
1652 added test_compose_mail.c
1653 * tests/dbus_api/test_compose_mail.c: (main):
1655 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1657 * src/modest-account-view.c:
1658 Fixed bug projects.maemo.org bug NB#59307
1660 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1662 * src/maemo/easysetup/modest-easysetup-wizard.c:
1663 (get_serverport_incoming), (on_before_next), (create_account):
1664 * src/maemo/modest-account-settings-dialog.c:
1665 (modest_account_settings_dialog_set_account_name):
1666 * src/maemo/modest-maemo-utils.c:
1667 (on_camel_account_get_supported_secure_authentication_status),
1668 (on_camel_account_get_supported_secure_authentication),
1669 (on_secure_auth_cancel),
1670 (modest_maemo_utils_get_supported_secure_authentication_methods):
1672 Implemented security authentication for settings and easysetup.
1674 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1676 * src/maemo/modest-main-window.c: (create_details_widget):
1677 Show the total size for memory card accounts too, instead of showing
1678 the name again. Fixes bug projects.maemo.org bug NB#59307.
1680 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1683 * src/modest-tny-simple-folder-store.c:
1684 * src/modest-tny-simple-folder-store.h: Removed.
1686 * src/modest-tny-local-folders-account.h
1687 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1688 for the local-folders maildir, with an extra TnyMergedFolder containing
1689 the folders of the per-account outbox store accounts.
1690 * src/modest-tny-account-store.c: (get_server_accounts):
1691 Add the outboxes to the special local folders account after creating it.
1693 * src/modest-tny-account.c:
1694 (modest_tny_account_new_for_local_folders): Create the derived
1695 account when creating the main local-folders account.
1697 * src/maemo/modest-main-window.c: (create_details_widget),
1698 (modest_main_window_set_contents_style):
1699 Adapted to the use of the derived account instead of the folder store.
1701 * src/modest-ui-actions.c:
1702 (modest_ui_actions_on_folder_selection_changed):
1703 * src/modest-ui-dimming-rules.c:
1704 (modest_ui_dimming_rules_on_new_folder):
1705 * src/widgets/modest-folder-view.c: (text_cell_data),
1706 (icon_cell_data), (filter_row), (update_model),
1707 (get_cmp_rows_type_pos):
1710 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1711 Do not get the priv struct, because no priv struct has been set,
1712 to avoid a runtime warning.
1714 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1715 #ifelse with #else, to fix a warning, to fix the build.
1718 2007-06-05 Christian Kellner <ckellner@openismus.com>
1720 * libmodest-dbus-client/libmodest-dbus-client.c:
1721 Fix small typo in doc (why do you always see them
1722 AFTER committing stuff?)
1725 2007-06-05 Christian Kellner <ckellner@openismus.com>
1727 * libmodest-dbus-client/libmodest-dbus-client.c:
1728 (libmodest_dbus_client_search):
1729 Initialize hit list with NULL. Also set folder list
1730 to "" if NULL was supplied.
1733 2007-06-03 Christian Kellner <ckellner@openismus.com>
1735 * libmodest-dbus-client/libmodest-dbus-client.c:
1736 (modest_search_hit_list_free):
1737 Make it save to call it with NULL.
1739 * src/dbus_api/modest-dbus-callbacks.c:
1740 * src/modest-search.c:
1741 Return full ModestSearchHits as the search result list not TnyHeader
1742 since can't be around withouth the correspoding TnyFolder.
1744 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1746 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1747 Added currently commented code to check for secure auth
1749 * src/maemo/modest-account-settings-dialog.c: (on_response),
1750 (save_configuration), (show_ok):
1751 Fixed projects.maemo.org bugs NB #59248 and #59251
1753 * src/maemo/modest-maemo-utils.c:
1754 (on_camel_account_get_supported_secure_authentication_status),
1755 (on_camel_account_get_supported_secure_authentication),
1756 (modest_maemo_utils_get_supported_secure_authentication_methods):
1757 * src/maemo/modest-maemo-utils.h:
1758 Moved get_supported_secure_authentication() method here to be able
1759 to use it from easysetup wizard.
1761 * src/modest-pair.c: (on_pair_compare_as_string):
1762 Should compare string with first part of pair and not
1763 strcmp pairs which will crash.
1765 * src/modest-protocol-info.c:
1766 (modest_protocol_info_protocol_is_store):
1767 * src/modest-protocol-info.h:
1768 Added modest_protocol_info_get_auth_protocol_name()
1770 2007-06-03 Armin Burgmeier <armin@openismus.com>
1772 * src/modest-mail-operation.c:
1773 (modest_mail_operation_get_msgs_full): Set priv->account also when
1774 only retrieving a single message. This avoids a crash when canceling
1777 (modest_mail_operation_notify_end): Do not explicitely remove the
1778 operation from the queue but only emit the progress_changed signal.
1779 The queue itself listens to that signal to remove the operation when
1780 it is finished. This reduces coupling and removes a potential deadlock
1781 when modest_mail_operation_notify_end() is called from the queue
1782 itself. If that is a problem performance-wise, I would suggest to
1783 implement a status-changed signal or something.
1785 * src/modest-mail-operation-queue.c: Make sure to never call a
1786 function from another file while the queue is locked. This (hopefully)
1787 fixes another deadlock when exiting the application while retrieving
1790 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1792 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1793 Fixed build if libogs is not available
1795 2007-06-03 Christian Kellner <ckellner@openismus.com>
1797 * libmodest-dbus-client/libmodest-dbus-client.h:
1798 * libmodest-dbus-client/libmodest-dbus-client.c:
1799 (libmodest_dbus_client_delete_message):
1800 Implement deletion of messages (Client side).
1802 (modest_search_hit_free),
1803 (modest_search_hit_list_free):
1804 Utility functions to free the result hits.
1806 * src/dbus_api/modest-dbus-api.h:
1807 * src/dbus_api/modest-dbus-callbacks.c:
1808 (on_delete_message),
1809 (modest_dbus_req_handler):
1810 Implement deletion of messages (Server side).
1812 * tests/dbus_api/test_search.c: (main):
1815 * tests/dbus_api/Makefile.am:
1816 * tests/dbus_api/test_delete_message:
1817 Add little test for the message deletion logic
1819 2007-06-03 Armin Burgmeier <armin@openismus.com>
1821 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1822 when the operation queue was not empty. projects.maemo.org bug
1825 2007-06-03 Armin Burgmeier <armin@openismus.com>
1827 * src/widgets/modest-account-view.c
1828 (on_account_default_toggled): Toggle default account column
1829 explicitely instead of waiting for gconf notification (which is
1830 currently ignored). This should fix projects.maemo.org bug NB#56910
1831 for now. It should probably be removed when gconf notifications are
1834 2007-06-03 Christian Kellner <ckellner@openismus.com>
1836 * libmodest-dbus-client/libmodest-dbus-client.c:
1837 Removed debugging spew.
1839 * src/dbus_api/modest-dbus-callbacks.c:
1840 Added debugging info.
1842 * src/modest-search.c:
1843 (modest_search_all_accounts):
1844 Use tny_account_store_get_accounts () on the account store
1845 to get all accounts which is the way to get all accounts.
1847 * tests/dbus_api/test_search.c: (main):
1848 Make it possible to supply the search term on the command line.
1850 2007-06-03 Christian Kellner <ckellner@openismus.com>
1852 * libmodest-dbus-client/libmodest-dbus-client.c:
1853 * libmodest-dbus-client/libmodest-dbus-client.h:
1854 Implement searching for mesages over raw dbus. (Client side)
1856 * src/dbus_api/Makefile.am:
1857 * src/dbus_api/modest-dbus-api.h:
1858 * src/dbus_api/modest-dbus-callbacks.c:
1859 * src/dbus_api/modest-dbus-callbacks.h:
1860 Search framework (Server side). Also implement on_idle_open_message().
1862 * src/maemo/modest-platform.c: (modest_platform_init):
1863 Prepare for raw dbus/osso rpc interaction.
1865 * src/modest-search.h:
1866 Changed minsize from unspecific guint to guint32.
1868 * src/modest-search.c:
1870 Added strange hack which magically made tnymail work.
1872 (modest_search_folder),
1873 (modest_search_account),
1874 (modest_search_all_accounts):
1875 Implement helper functions to search all accounts, specific account
1878 * tests/dbus_api/Makefile.am:
1879 * tests/dbus_api/test_open_message.c:
1880 Read url to open from commandline.
1882 * tests/dbus_api/test_search.c:
1883 Implement small test for dbus search stuff
1885 2007-06-02 Armin Burgmeier <armin@openismus.com>
1887 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1888 include account type and account title. This fixes projects.maemo.org
1891 * src/maemo/modest-account-view-window.c: Set a title for the window.
1893 2007-06-02 Armin Burgmeier <armin@openismus.com>
1895 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1896 incoming and outgoing server name based on email address and server
1897 types as long as the names have not been edited manually. This fixes
1898 projects.maemo.org bug NB#58671.
1900 2007-06-02 Armin Burgmeier <armin@openismus.com>
1902 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1903 server type cannot be changed in future to the incoming details page
1904 when creating an account. This fixes projects.maemo.org bug NB#59029.
1906 2007-06-02 Armin Burgmeier <armin@openismus.com>
1908 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1909 and assigned max width chars so that they wrap instead of being
1910 truncated. Fixes projects.maemo.org bug NB#56126.
1912 2007-06-02 Armin Burgmeier <armin@openismus.com>
1914 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1915 introductory note to the connection specific smtp servers dialog, as
1916 section 8.12 of the email UI specification requires. This fixes
1917 projects.maemo.org bug NB#59212.
1919 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1921 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1922 Check for running mail operations, and offer to cancel them, as per the UI
1923 spec. This fixes projects.maemo.org bug NB#59041 .
1924 However, I suspect that tinymail may still use the network connection
1925 in ways that we cannot detect or cancel. But it should at least adapt to
1926 changes fairly well.
1928 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1930 * src/modest-tny-account-store.c: (recreate_all_accounts),
1931 (get_cached_accounts), (get_server_accounts): Do more sensible
1932 ref-counting of the temporarily-cached outbox accounts list. This seems
1933 to fix a crash when entering the password when the password was wrong.
1935 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1937 * src/gnome/modest-main-window.c: (connect_signals):
1938 * src/modest-tny-account-store.c: (get_password),
1939 (modest_tny_account_store_alert): Added comments and clues and
1940 commented-out code about how we currently fail to deal with connection
1941 errors and wrong passwords, and how we should.
1943 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1945 * src/widgets/modest-retrieve-combo-box.c:
1946 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1947 This fixes projects.maemo.org bug NB#58472 .
1949 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1951 * src/maemo/easysetup/modest-easysetup-wizard.c:
1952 (create_page_complete_easysetup):
1953 (create_page_complete_custom): Correct the last commit,
1954 putting the correct sentences in the correct pages.
1956 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1958 * src/maemo/easysetup/modest-easysetup-wizard.c:
1959 (create_page_complete_custom): Show the second sentence of text
1960 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1963 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1965 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1966 Set the leave-on-server conf key by default. This fixes
1967 projects.maemo.org bug NB#59258 .
1969 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1971 * src/maemo/modest-account-view-window.c:
1972 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1973 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1976 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1978 * src/maemo/easysetup/modest-easysetup-wizard.c:
1979 (create_caption_new_with_asterisk):
1980 * src/maemo/modest-account-settings-dialog.c:
1981 (create_caption_new_with_asterisk):
1982 Uncomment the code to add the asterisk, because they are no longer in the
1983 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1984 (update_incoming_server_title): Add an asterisk here too.
1986 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/modest-maemo-global-settings-dialog.c:
1989 (current_connection): Check that we are even connected before trying to
1990 get the current connection name, to prevent a warning.
1992 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1993 Change the comments because tny_maemo_conic_device_connect() is now meant to
1995 * src/modest-mail-operation.c:
1996 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1997 make sure we have a connection and fail if we can't connect.
1999 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2001 * src/maemo/modest-main-window.c:
2002 (on_account_store_connecting_finished): Do not try to get the
2003 connection ID if we are not really connected. I am surprised that
2004 this signal handler is called when we are not connected.
2006 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-error.h:
2009 * src/modest-ui-actions.c:
2010 (modest_ui_actions_get_msgs_full_error_handler):
2011 Renamed an enum, added comments, added an enum
2012 for retrieve-limit errors.
2014 * src/modest-mail-operation.c: (foreach_add_item),
2015 (internal_folder_observer_update), (update_account_thread),
2016 (modest_mail_operation_get_msgs_full):
2017 (modest_mail_operation_update_account),
2018 Added comments about how this works, and some code that should
2019 (but does not) check the retrieve-limit. See the TODO comment.
2021 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2023 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2024 Initialize help_id to fix the build. Warnings are good.
2026 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2028 * src/widgets/modest-hbox-cell-renderer.c:
2029 (modest_hbox_cell_renderer_append):
2030 * src/widgets/modest-vbox-cell-renderer.c:
2031 (modest_vbox_cell_renderer_append):
2032 Fix the last commit by doing an extra ref.
2034 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2036 * src/widgets/modest-hbox-cell-renderer.c:
2037 (modest_hbox_cell_renderer_append):
2038 * src/widgets/modest-vbox-cell-renderer.c:
2039 (modest_vbox_cell_renderer_append):
2040 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2041 to fix the build with Maemo Bora.
2042 However, there seems to be a remaining crash, probably due to reference
2045 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2047 * src/modest-tny-account.c:
2048 (modest_tny_account_new_for_local_folders):
2049 Use hildon_file_system_info_async_new() to get a better name for
2050 the memory card account, setting it as the account name.
2051 The timing seems to work, but this is probably
2052 not the best place to do this. See the TODO comment.
2053 * src/maemo/modest-main-window.c: (create_details_widget):
2054 * src/widgets/modest-folder-view.c: (text_cell_data):
2055 Use the tny account name instead of hardcoding a name.
2057 2007-05-30 Christian Kellner <ckellner@openismus.com>
2059 * src/modest-search.c: (modest_search):
2060 Correctly set part_search_func even if we have already parsed
2061 the query and thus a valid OgsTextSearcher object.
2063 2007-05-30 Christian Kellner <ckellner@openismus.com>
2066 Search and check for libogs.
2069 Incooparte the ogs build env.
2071 * src/modest-mime-part-search-stream.c:
2072 * src/modest-mime-part-search-stream.h:
2073 Removed since we do the real searching now in modest-search.c.
2075 * src/modest-search.c:
2076 * src/modest-search.h:
2077 Implement support for ogs. We use that if available and requested
2078 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2079 should now handle the corner case when the search term is spread
2080 across multiple reads.
2081 Also the logic in modest_search () was corrected to search all
2082 requested fields until one is found.
2084 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2086 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2088 * src/modest-init.h:
2089 * src/modest-init.c: Made modest_init_local_folders() take a
2090 path and be public so we can iniitialize maildir folders on
2093 * src/modest-local-folder-info.h:
2094 * src/modest-local-folder-info.c:
2095 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2097 * src/modest-tny-account.c:
2098 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2099 still means the standard local-folders path on the local volume.
2101 * src/modest-tny-account-store.c:
2102 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2103 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2104 all accounts when that happens.
2105 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2106 this too, so it shows up in the treeview.
2108 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2110 * src/maemo/modest-maemo-global-settings-dialog.c:
2111 (current_connection):
2112 * src/widgets/modest-global-settings-dialog.c:
2113 (current_connection_default):
2114 Use the enum values instead of 0, 1 and -1,
2115 to make the code clearer.
2117 * src/modest-account-mgr-helpers.c:
2118 (modest_account_mgr_get_connection_specific_smtp): Make this code
2121 * src/modest-runtime.h:
2122 * src/modest-runtime.c:
2123 Added modest_runtime_remove_all_send_queues().
2124 * src/maemo/modest-main-window.c:
2125 (on_account_store_connecting_finished): Recreate the send queues,
2126 using the appropriate transport accounts for this new connection.
2127 Some futher adapting might be needed if the old send queues are not
2128 automatically stopped at this point.
2130 * src/modest-tny-account-store.c: (get_server_accounts):
2131 Create the connection-specific transport accounts, so that they can
2132 be found later by their ID.
2134 * src/modest-tny-account.h:
2135 * src/modest-tny-account.c:
2136 Added modest_tny_account_new_from_server_account_name().
2137 modest_tny_account_new_from_server_account(): Do not create the
2138 send queues here, because they will be
2139 recreated anyway when the connection changes for the first time.
2141 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2143 * src/modest-local-folder-info.h:
2144 * src/modest-local-folder-info.c:
2145 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2146 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2147 tbox_folder): Take a modest account name instead of a server TnyAccount,
2148 so we can have per-modest-account rather than per-transport-account
2150 We must make sure that we change or recreate the exisitng send queues
2151 when the connection changes for connection-specific transport accounts.
2153 * src/modest-tny-account-store.c:
2154 (create_per_account_local_outbox_folders): Create outboxed per modest
2155 account, not per transport account.
2157 * src/modest-tny-account.h:
2158 * src/modest-tny-account.c:
2159 (modest_tny_account_get_special_folder): For outboxes, get the
2160 parent modest account name. The account is ignored for other folders.
2161 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2162 modest account name rather than a server TnyAccount.
2164 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-tny-account.c:
2167 (modest_tny_account_new_from_server_account):
2168 Call modest_runtime_get_send_queue() immediately after creating transport
2169 accounts, so that they start trying to send email from the outbox as soon
2170 as possible at startup. This is probably what we want.
2172 * src/modest-mail-operation.c: (update_account_thread):
2173 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2174 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2175 * src/modest-tny-send-queue.h:
2176 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2177 (modest_ui_actions_on_send):
2178 Added comments about how sending works, though it needs some more work.
2180 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2182 * src/modest-tny-account.c:
2183 (modest_tny_account_get_special_folder): Add TODO because this fails when
2184 the network is busy.
2185 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2186 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2187 Do not try to show this window when there is no active account. The UI
2188 specs does not tell us what to do in this case.
2190 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2194 * src/maemo/Makefile.am:
2195 * src/widgets/Makefile.am: Some dist fixes.
2197 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2199 * src/maemo/modest-connection-specific-smtp-window.c:
2200 (on_button_edit): Make the code clearer, to prevent a double free.
2202 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2204 * src/maemo/modest-account-settings-dialog.c:
2205 (modest_account_settings_dialog_set_account_name),
2206 Check the connection-specific smtp servers checkbox if there are any.
2208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2209 (modest_connection_specific_smtp_edit_window_init):
2210 Start with a suitable port number.
2212 * src/modest-account-mgr-helpers.h:
2213 * src/modest-account-mgr-helpers.c: Added
2214 modest_account_mgr_get_has_connection_specific_smtp().
2216 (modest_account_mgr_set_connection_specific_smtp),
2217 (modest_account_mgr_remove_connection_specific_smtp),
2218 (modest_account_mgr_get_has_connection_specific_smtp),
2219 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2220 connection-specific smtp server accounts in the account, rather than
2221 the server account conf dir.
2223 This fixes bug projects.maemo.org bug NB#58263 .
2225 * src/modest-tny-account-store.c:
2226 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2227 if there are no server accounts yet, to prevent an infinite loop when there
2228 are no accounts. Document that one must be called before the other.
2230 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2232 * src/modest-account-mgr-helpers.c:
2233 (modest_account_mgr_get_default_account): Make sure that at least
2234 one account is always the default, if there are any enabled accounts.
2235 This is just a sanity check that shouldn't be necessary.
2237 * src/modest-account-mgr-priv.c:
2238 (_modest_account_mgr_account_from_key): Unescape the conf key to
2239 get the real account name. For instance, this is an issue if a space
2240 was in the account name, which can happen because the account name
2241 is generated from the display name.
2242 (_modest_account_mgr_get_account_keyname): Always escape the
2244 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2245 Unescape the conf keys to get the real account names.
2247 For instance, previously the is-default radio button in the accounts
2248 list was not checked for any accounts at first. This fixes that,
2249 and might fix several similar bugs.
2251 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2253 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2254 Removed some debug printfs.
2256 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2258 Modest on-disk outbox directories are now here, for instance:
2259 $HOME/.modest/outboxes/<account-id-1>/outbox
2260 $HOME/.modest/outboxes/<account-id-2>/outbox
2262 $HOME/.modest/local-folders/outbox
2263 so we can have a separate outbox for each account.
2264 But they are shown as one outbox in the GtkTreeView, by using a
2265 TnyMergeFolder in a ModestTnySimpleFolderStore.
2268 * src/modest-tny-simple-folder-store.c:
2269 * src/modest-tny-simple-folder-store.h:
2270 Added ModestTnySimpleFolderStore, used to contain folders from
2271 other folder stores, such as other accounts.
2273 * src/modest-tny-outbox-account.h:
2274 * src/modest-tny-outbox-account.c:
2275 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2276 used for the per-account local outbox folders.
2278 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2279 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2280 only use this (internally) now for the non-outbox local folders.
2282 * src/modest-init.h:
2283 * src/modest-init.c: Added modest_init_one_local_folder(), for
2284 setting up the directory structure for each local folder.
2286 * src/modest-local-folder-info.c:
2287 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2288 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2290 * src/modest-local-folder-info.h:
2291 * src/modest-tny-account-store.c: (on_account_removed),
2292 (on_account_changed), (create_per_account_local_outbox_folders),
2293 (get_server_accounts), (modest_tny_account_store_get_accounts),
2294 (modest_tny_account_store_get_tny_account_by_account),
2295 (modest_tny_folder_store_is_virtual_local_folders):
2297 * src/modest-tny-account.h:
2298 * src/modest-tny-account.c:
2299 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2300 to create an on-disk per-account local outbox folder for each
2302 (create_per_account_local_outbox_folders): Create a local outbox folder
2303 for each transport account.
2304 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2305 for all local folders.
2307 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2308 instead of using g_object_get/set() directly. It is clearer.
2310 (modest_tny_folder_store_get_message_count),
2311 (modest_tny_folder_store_get_local_size
2312 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2313 because we now use these with non-acount folder stores.
2315 (modest_tny_account_get_special_folder),
2316 (modest_tny_account_new_from_server_account),
2317 (modest_tny_account_new_from_account):
2318 (recurse_folders): Adjust to the new outbox system.
2320 * src/modest-tny-folder.h:
2321 * src/modest-tny-folder.c:
2322 (modest_tny_folder_is_local_folder),
2323 (modest_tny_folder_get_local_folder_type),
2324 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2326 * src/widgets/modest-main-window.h:
2327 * src/maemo/modest-main-window.c: (create_details_widget),
2328 (modest_main_window_set_contents_style): Show details for any folder store,
2331 (modest_tny_folder_get_rules):
2332 Remove the const. C does not support constness enough for this.
2334 * src/modest-ui-actions.c:
2335 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2336 make all outboxes appear as one, in the usual local-folders tree node.
2338 (set_active_account_from_tny_account),
2339 (modest_ui_actions_on_folder_selection_changed):
2340 * src/widgets/modest-folder-view.c: (text_cell_data),
2341 (icon_cell_data), (filter_row),
2342 (add_account_folders_to_merged_folder),
2343 (add_account_folders_to_simple_folder_store), (),
2344 (get_cmp_rows_type_pos), (cmp_rows),
2345 (modest_folder_view_set_account_id_of_visible_server_account):
2346 Adjust to the new outbox system, using generic folder stores and folders
2347 in the GtkTreeModel.
2349 2007-05-23 Christian Kellner <ckellner@openismus.com>
2351 * src/modest-mail-operation.c:
2352 (modest_mail_operation_update_account):
2353 Use info->max_size instead of unintialized local var [small
2354 build fix]. (Added TODO to review that change since I don't
2357 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2359 * libmodest-dbus-client/libmodest-dbus-client.c:
2360 (libmodest_dbus_client_compose_mail): function added
2361 * src/dbus_api/modest-dbus-api.h:
2362 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2363 (on_compose_mail): Implementation of the SendAsMail functionality
2365 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2367 * src/modest-account-mgr.c:
2368 (modest_account_mgr_add_server_account): Set the secure-connection
2369 conf key for transport accounts as well as store accounts. I don't know
2370 why the if was there. For instance, this makes sure that we use SSL
2371 for the gmail preset from the easysetup wizard.
2373 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2375 * src/gnome/modest-main-window.c:
2376 (on_account_store_connecting_finished), (connect_signals):
2377 * src/maemo/modest-main-window.c:
2378 (on_account_store_connecting_finished), (connect_signals),
2379 (modest_main_window_new):
2380 Handle TnyAccountStore::connecting-finished instead of
2381 TnyDevice::connection-changed, because we cannot actually perform
2382 operations on accounts until TnyAccountStore has itself responded to
2383 the TnyDevice::connection-changed signal. This prevents a GError from
2385 Do not try to update at startup, because we (at least on scratchbox)
2386 already do an update at startup when the device goes online.
2387 This prevents a GError from tinymail.
2388 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2389 Added TODO about stopping simultaneous operations.
2391 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2393 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2394 * src/modest-mail-operation-queue.c:
2395 (modest_mail_operation_queue_remove):
2396 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2397 about where they happened.
2399 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2401 * src/modest-ui-actions.c:
2402 (modest_ui_actions_on_password_requested): Make sure that the remember
2403 output parameter is always TRUE.
2405 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2407 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2408 Show a OK/Cancel dialog if the error is a question, though we still do not
2409 know anything more about what we are asking the user.
2410 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2411 Fix an uninitialized variable (helper). This is a logic error, however.
2413 2007-05-21 Christian Kellner <ckellner@openismus.com>
2415 * src/modest-search.h:
2416 Correct bit shifting in the ModestSearchFlags enum.
2418 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2420 * src/modest-tny-account.c:
2421 (modest_tny_account_new_from_server_account): Do not use the lsub and
2422 check-all hard-coded IMAP options when using POP.
2424 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2426 * src/modest-tny-account.c:
2427 (modest_tny_account_new_from_server_account):
2428 Use NULL for the secure-auth method for POP when Password auth has been
2429 specified by the user, as we already do for IMAP. "auth=Login" causes
2430 an error from camel or the server.
2432 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2434 * src/maemo/modest-account-settings-dialog.c:
2435 (create_page_account_details),
2436 (modest_account_settings_dialog_set_account_name):
2437 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2438 for the leave-on-server checkbox, rathr than just the checkbox, when
2439 the protocol is not POP.
2441 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2443 * src/widgets/modest-account-view.c:
2444 * src/widgets/modest-account-view.h:
2445 Added modest_account_view_select_account() which will be useful later
2446 to asynchronously re-select the edited account.
2448 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2450 * src/maemo/modest-account-settings-dialog.c:
2451 (modest_account_settings_dialog_set_account_name):
2452 Automatically choose the port numbers based on the secure authentication
2453 methods, if they have not been chosen before.
2454 This fixes projects.maemo.org bug NB#56273 .
2456 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2458 * src/maemo/modest-main-window-ui.h:
2459 * src/modest-ui-actions.c:
2460 * src/modest-ui-actions.h:
2461 Connect the Tools/SMTP Servers menu item to
2462 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2463 SMTP servers dialog, as in the UI specification and saves changes when it
2464 is closed. This fixed projects.maemo.org bug NB#56305 .
2466 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2468 * src/maemo/modest-connection-specific-smtp-window.c:
2469 (modest_connection_specific_smtp_window_init):
2470 Use gtk_window_set_default_size() to make this window big enough, so
2471 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2473 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2475 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2476 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2477 (modest_connection_specific_smtp_edit_window_init),
2478 Do not try to connect to a combobox signal before the combobox exists.
2479 This fixes the cras in projects.maemo.org bug NB#56288 .
2480 (modest_connection_specific_smtp_edit_window_get_settings):
2481 Remove the server_account_name parameter which was being checked for NULL
2482 though it was not used.
2484 * src/maemo/modest-connection-specific-smtp-window.c:
2485 (modest_connection_specific_smtp_window_fill_with_connections),
2486 (on_button_edit), (modest_connection_specific_smtp_window_init):
2487 Correct the number of treemodel columns to prevent a warning.
2488 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2489 libconic does not work.
2491 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-tny-account.c:
2494 (modest_tny_account_new_from_server_account):
2495 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2496 SMTP when "None" was chosen by the user. However, with my SMTP server that
2497 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2500 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2502 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2503 to explain the memory management issue with the ID in the ModestPair.
2505 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2506 (add_sending_page), (modest_account_assistant_finalize):
2507 * src/gnome/modest-gnome-global-settings-dialog.c:
2508 (create_updating_page), (create_composing_page):
2509 * src/gnome/modest-msg-edit-window.c: (get_transports),
2510 (init_window), (modest_msg_edit_window_finalize),
2511 (modest_msg_edit_window_get_msg_data):
2512 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2513 * src/gnome/modest-transport-widget.c:
2514 (modest_transport_widget_finalize), (smtp_configuration):
2515 * src/maemo/modest-maemo-global-settings-dialog.c:
2516 (create_updating_page), (create_composing_page):
2517 * src/maemo/modest-msg-edit-window.c: (get_transports),
2518 (init_window), (modest_msg_edit_window_finalize),
2519 (modest_msg_edit_window_get_msg_data),
2520 (modest_msg_edit_window_free_msg_data):
2521 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2522 (modest_store_widget_finalize):
2523 * src/maemo/modest-transport-widget.c:
2524 (modest_transport_widget_finalize), (smtp_configuration):
2525 * src/modest-main.c: (send_mail):
2526 * src/widgets/modest-combo-box.h:
2527 * src/widgets/modest-global-settings-dialog-priv.h:
2528 * src/widgets/modest-global-settings-dialog.c:
2529 (modest_global_settings_dialog_finalize):
2530 * src/widgets/modest-msg-edit-window.h:
2531 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2532 as long as the combo box, to prevent use of freed memory for the ID.
2534 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2536 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2537 get_accounts(), to make this clearer. Do not check for the enabled gconf
2538 key, because we do not use this for server accounts (at least, not yet).
2539 This allows us to send email again.
2541 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2543 * src/maemo/modest-platform.c:
2544 (on_modest_conf_update_interval_changed), (modest_platform_init):
2545 Only respond to this particular key change. All these strcmp()s cannot be
2548 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2550 * src/maemo/modest-maemo-global-settings-dialog.c:
2551 (current_connection): Prevent a crash in scratchbox when
2552 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2553 * src/maemo/modest-platform.c:
2554 (on_modest_conf_update_interval_changed), (modest_platform_init):
2555 Get the update interval from gconf and reset it when the gconf key changes.
2557 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2559 * src/modest-protocol-info.c:
2560 * src/modest-protocol-info.h: Adde enum-specific get functions,
2561 instead of using a ModestProtocolType enum parameter.
2563 * src/gnome/modest-account-assistant.c:
2564 * src/gnome/modest-store-widget.c:
2565 * src/gnome/modest-store-widget.h:
2566 * src/gnome/modest-transport-widget.c:
2567 * src/gnome/modest-transport-widget.h:
2568 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2569 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2570 * src/maemo/easysetup/modest-easysetup-wizard.c:
2571 * src/maemo/modest-account-settings-dialog.c:
2572 * src/maemo/modest-account-settings-dialog.h:
2573 * src/maemo/modest-store-widget.c:
2574 * src/maemo/modest-store-widget.h:
2575 * src/maemo/modest-transport-widget.c:
2576 * src/maemo/modest-transport-widget.h:
2577 * src/modest-account-mgr-helpers.c:
2578 * src/modest-account-mgr-helpers.h:
2579 * src/modest-account-mgr.c:
2580 * src/modest-account-mgr.h:
2581 * src/modest-tny-account.c:
2582 * src/modest-tny-folder.c:
2583 * src/widgets/modest-account-view.c:
2584 * src/widgets/modest-retrieve-combo-box.c:
2585 * src/widgets/modest-retrieve-combo-box.h:
2586 * src/widgets/modest-secureauth-combo-box.c:
2587 * src/widgets/modest-serversecurity-combo-box.c:
2588 * src/widgets/modest-serversecurity-combo-box.h:
2589 * tests/check_account-mgr.c:
2590 Use the specific functions, and use the re-renamed enum values for GNOME too.
2592 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2594 * src/modest-pair.h:
2595 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2596 so we can get the second based on the first.
2598 * src/maemo/modest-account-settings-dialog.h:
2599 * src/maemo/modest-account-settings-dialog.c:
2600 Added get_supported_secure_authentication_methods(), though it is mostly
2601 commented-out for now until the necessary API is committed to tinymail.
2602 (modest_account_settings_dialog_set_account_name),
2603 (save_configuration): Request the supported authentication methods from the
2604 server, so we can choose a working method.
2606 * src/modest-tny-account-store.h:
2607 * src/modest-tny-account-store.c:
2608 (modest_tny_account_store_get_session): Rename from
2609 tny_account_store_get_session().
2611 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2613 * src/modest-protocol-info.h: Split the ModestProtocol enum
2614 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2615 There was no need to have these unrelated values in one enum.
2617 * src/: many files: Adapted to changed enum. This makes the code a bit
2618 clearer, and the compiler could catch some errors.
2620 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2623 Show the detailed internal camel error message when an error happens
2624 during the configuration, so that our testers can give us more clues.
2625 For instance, in projects.maemo.org bug NB#56910 .
2627 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2629 * src/modest-tny-account.c:
2630 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2631 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2633 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2635 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2636 * src/maemo/modest-account-settings-dialog.c:
2637 (modest_account_settings_dialog_set_account_name),
2638 (save_configuration): For the incoming secure authentication checkbox,
2639 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2640 the UI specification. PLAIN does not seem to be supported for most IMAP
2641 servers anyway, and I am not sure what it would mean.
2642 However, we probably need to discover which of the secure-authentication
2643 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2644 * src/modest-account-mgr-helpers.c:
2645 (modest_account_mgr_get_server_account_data):
2647 * src/modest-tny-account.c:
2648 (modest_tny_account_new_from_server_account):
2649 Use tny_account_set_mech() to set secure-authentication methods,
2650 with some special-casing for IMAP, based on my observations of how
2653 * src/modest-account-mgr-helpers.h:
2654 * src/modest-account-mgr.c:
2655 * src/modest-defs.h: Comment that the URI is only used for local folders.
2657 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2660 parameter const, just to be neat.
2661 * src/modest-text-utils.c: (modest_text_utils_inline):
2662 End g_strconcat() with NULL, as its documentation says. This is almost
2663 certainly the cause of my crash at startup on the device. Interestingly,
2664 valgrind doesn't tell us about these errors.
2666 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2668 * scripts/build-packages: Added more precise comments about how to use
2669 this script, though I still get this error:
2670 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2671 error building tinymail
2673 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2675 * src/maemo/modest-main-window.c: (on_account_update):
2676 Very slight cleanup, hoping to make it simpler to discover what causes
2677 a crash here sometimes.
2679 * src/modest-tny-account.c:
2680 (modest_tny_account_new_from_server_account): Set the port. Added
2681 comments about the options and a TODO comment because I need to find out
2682 how to specify the secure authentication method.
2684 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2686 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2687 changed CFlags paths form modest to libmodest
2689 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2691 * src/modest-account-mgr-helpers.c:
2692 (modest_account_mgr_get_server_account_data),
2693 (modest_account_mgr_free_server_account_data):
2694 * src/modest-account-mgr-helpers.h:
2695 * src/modest-account-mgr.c:
2696 (modest_account_mgr_add_server_account):
2697 * src/modest-defs.h:
2698 * src/modest-tny-account.c:
2699 (modest_tny_account_new_from_server_account):
2700 Determine the options for tny_camel_account_add_option() here,
2701 based on the settings, rather than storing them directly in gconf.
2703 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2705 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2706 Show a more friendly error dialog now that we expect (from the tinymail
2707 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2709 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2711 * src/maemo/modest-main-window.c: (on_account_update): Check that
2712 account_name is not NULL, to prevent a crash at startup that I am
2713 seeing on the N800. I do wonder why it is NULL.
2715 * src/maemo/easysetup/modest-easysetup-wizard.c:
2716 (create_page_user_details):
2717 * src/maemo/modest-account-settings-dialog.c:
2718 (create_page_user_details), (create_page_outgoing):
2719 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2720 (modest_connection_specific_smtp_edit_window_init):
2721 * src/modest-ui-actions.c:
2722 (modest_ui_actions_on_password_requested):
2723 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2724 might do something useful with the on-screen keyboard.
2726 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2728 * src/maemo/modest-main-window.c: (on_account_update):
2729 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2730 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2732 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2734 * src/modest-tny-account-store.c: (on_account_changed):
2735 Correct the signature of this signal handler.
2737 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2739 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2740 Show a HildonNote instead of a GtkDialog for Maemo.
2742 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2744 * src/widgets/modest-account-view.h:
2745 * src/widgets/modest-account-view.c: (on_account_changed),
2746 (on_account_removed). Added a boolean flag, set/unset by
2747 modest_account_view_block_conf_updates(),
2748 modest_account_view_unblock_conf_updates() to prevent unnecessary
2749 updates, but this is not very useful because the gconf notifications are
2750 so delays (maybe only on Maemo Bora).
2751 So auto-updating is turned off, and these functions do an explicit
2752 update when necessary.
2753 However, something else is still doing too much work when adding/removing
2754 accounts, probably in another part of the application.
2756 * src/maemo/modest-account-view-window.c:
2757 (on_delete_button_clicked), (on_edit_button_clicked),
2758 (on_new_button_clicked): Use the new functions.
2760 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2762 * src/modest-account-mgr-helpers.c:
2763 (modest_account_mgr_set_first_account_as_default):
2764 Sort the list of names alphabetically-by-title, so we choose the first one
2766 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2767 alphabetically by the title.
2769 This fixes projects.maemo.org bug NB#56418 .
2771 * src/modest-account-mgr-priv.c:
2772 (_modest_account_mgr_account_from_key):
2773 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2774 avoid a valgrind error, and possible random behaviour.
2776 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2778 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2779 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2780 tinymail documentation to say that this can be expected.
2781 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2782 pretty, and should not happen, but I would prefer to know when it does.
2784 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2786 * configure.ac: When using the older hildon version, probably on Bora,
2787 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2789 * src/widgets/modest-attachment-view.c:
2790 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2793 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2795 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2796 Implemented the prototype. Can be tested with
2797 tests/dbus_api/test_open_message:
2799 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2801 * src/modest-tny-account-store.c:
2802 (modest_tny_account_store_instance_init), (get_password):
2803 * src/modest-ui-actions.c:
2804 (modest_ui_actions_on_password_requested):
2805 Do not store the password in gconf, because this function is called
2806 for non-remembered passwords. Actually use the cached (in the hash map)
2807 password instead of releasing it.
2808 The password will now not be remembered if it is asked via the protected
2809 password dialog, as per the UI spec.
2811 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2813 * src/modest-defs.h:
2814 * src/modest-account-mgr-helpers.h:
2815 * src/modest-account-mgr-helpers.c:
2816 Added modest_server_account_get_username_has_succeeded(),
2817 modest_server_account_set_username_has_succeeded().
2818 (modest_server_account_set_username),
2819 Reset the has-succeeded flag if the username changes.
2821 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2822 * src/maemo/modest-connection-specific-smtp-window.c:
2823 (modest_connection_specific_smtp_window_save_server_accounts):
2824 Use modest_server_account_set_username() instead of using
2825 modest_conf_set_string() directly, so that the has-succeeded flag is always
2828 * src/modest-ui-actions.c:
2829 (modest_ui_actions_on_password_requested): Dim the username entry if
2830 the username has ever worked, as per the UI spec.
2832 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2834 * src/modest-tny-account-store.c: (get_password):
2835 * src/modest-ui-actions.c:
2836 (modest_ui_actions_on_password_requested):
2837 Allow the username to be changed too, though there is more work to
2838 be done on exactly how this behaves.
2840 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2842 * src/modest-account-mgr-helpers.h:
2843 * src/modest-account-mgr-helpers.c:
2844 Added modest_account_mgr_get_display_name(),
2845 modest_server_account_get_username(),
2846 modest_server_account_set_username(),
2847 modest_server_account_set_password(),
2848 modest_server_account_get_hostname() functions so we do not need to
2849 use the conf API directly.
2851 * src/maemo/modest-main-window.c: (connect_signals):
2852 Actually connect ot the ModestAccountStore::request-password signal,
2853 so that we show the dialog when the password is requested by Tinymail,
2854 for isntance if it is empty.
2856 * src/modest-marshal.list:
2857 * src/modest-tny-account-store.c:
2858 (modest_tny_account_store_class_init), (get_password),
2859 (modest_tny_account_store_alert):
2860 * src/modest-tny-account-store.h:
2861 * src/modest-ui-actions.h:
2862 * src/modest-ui-actions.c:
2863 (modest_ui_actions_on_password_requested):
2864 Change the signal parameters, so it is obvious that we are providing
2865 the non human-readable server name, and receiving both the username
2866 and password, though changing of the username is not yet implemented.
2867 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2868 for the GNOME version.
2870 This should fix the projects.maemo.org bug NB#56209, though it does not
2871 work on Bora, because the gconf_client_get() for the password fails
2872 immediately after we save it with gconf_client_set().
2874 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2877 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2878 caused an undefined symbol error:
2879 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2881 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2883 * src/modest-tny-account-store.c:
2884 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2885 using a GError instead of a string message, so we can translate it in
2888 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2890 * src/maemo/modest-address-book.c:
2891 (modest_address_book_check_names):
2892 * src/maemo/modest-msg-view-window.c:
2893 (modest_msg_view_window_clipboard_owner_change):
2894 * src/modest-init.c: (modest_init_init_ui):
2895 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2896 (update_folders_cb), (modest_mail_operation_update_account):
2897 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2898 (modest_ui_actions_on_msg_attachment_clicked),
2899 (modest_ui_actions_on_msg_recpt_activated):
2900 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2901 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2902 (modest_msg_view_search_next):
2903 * src/widgets/modest-recpt-editor.c:
2904 (modest_recpt_editor_on_button_release_event),
2905 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2906 g_message(). At this point we should only be seeing interesting errors on
2907 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2909 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2911 (modest_wizard_dialog_force_title_update):
2912 * src/maemo/easysetup/modest-wizard-dialog.h:
2913 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2914 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2915 can update the title when appropriate. Otherwise the title is wrong if the
2916 pages are added after adding the notebook to the dialog.
2917 This must be a problem in HildonWizardDialog too.
2918 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2920 * src/maemo/easysetup/modest-easysetup-wizard.c:
2921 (create_subsequent_customsetup_pages),
2922 (create_subsequent_easysetup_pages):
2923 Call modest_wizard_dialog_force_title_update() so that the title is
2924 correct even with GTK+ < 2.10.
2925 This fixes projects.maemo.org bug NB#56145 .
2927 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2929 * src/maemo/modest-platform.c:
2930 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2931 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2934 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2936 * src/widgets/modest-window.h:
2937 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2938 and modest_window_save_state(), which invokes it.
2940 * src/widgets/modest-window-mgr.h:
2941 * src/widgets/modest-window-mgr.c:
2942 Added modest_window_mgr_save_state_for_all_windows(), which calls
2943 the save_state vfunc on all registered windows, if implemented.
2945 * src/gnome/modest-msg-edit-window.c:
2946 * src/gnome/modest-msg-view-window.c:
2947 * src/maemo/modest-msg-edit-window.c:
2948 * src/maemo/modest-msg-view-window.c:
2949 * src/maemo/modest-main-window.c:
2950 Specify the existing save_settings functions as implementations of
2951 ModestWindow::save_state_func().
2953 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2954 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2955 enabling hibernation, for instance.
2957 We may need to do the same thing for restoring settings.
2960 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2962 * src/widgets/modest-window-mgr.c:
2963 * src/widgets/modest-window-mgr.h:
2964 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2965 modest_window_mgr_get_hibernation_is_prevented().
2967 * src/maemo/modest-main-window.c:
2968 (on_hildon_program_is_topmost_notify): Prevent hibernation
2969 (possible when the application goes to the background in the WM),
2970 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2972 * src/maemo/easysetup/modest-easysetup-wizard.c:
2973 (modest_easysetup_wizard_dialog_init):
2974 * src/maemo/modest-account-settings-dialog.c:
2975 (modest_account_settings_dialog_init):
2976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2977 (modest_connection_specific_smtp_edit_window_init):
2978 * src/maemo/modest-connection-specific-smtp-window.c:
2979 (modest_connection_specific_smtp_window_init):
2980 * src/maemo/modest-signature-editor-dialog.c:
2981 (modest_signature_editor_dialog_init):
2982 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2983 prevent hibernation while any of these account settings dialogs are open.
2985 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2987 * src/maemo/Makefile.am:
2988 * src/maemo/modest-osso-state-saving.c:
2989 * src/maemo/modest-osso-state-saving.h: Added
2990 modest_osso_load_state() and modest_osso_save_state() though they do
2991 nothing now. They should iterate through all the open windows and load/save
2993 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2994 save state when closing.
2996 * src/maemo/modest-main-window.c:
2997 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2998 Add a notification handler for the HildonProgram::is-topmost property,
2999 so we can allow hibernation when the application goes into the background.
3000 But we still need to detect when the accounts setup windows are open so
3001 we can stop hibernation when they are open.
3002 To do this, I also added the main window the HildonProgram. This might have
3003 other side-effects/benefits, and should maybe be done for other windows.
3005 * src/maemo/modest-osso-autosave-callbacks.h:
3006 * src/maemo/modest-osso-autosave-callbacks.c:
3007 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3008 though it does not do anything yet, and we might never need this to do
3009 anything. For instance, we already save drafts.
3011 * src/maemo/modest-platform.c: (modest_platform_init):
3012 Specify the libosso auto-save callback.
3014 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3016 * src/maemo/modest-platform.c:
3017 (modest_platform_set_update_interval):
3018 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3019 aparently stays valid between application instances, so we can use this
3020 to remove and reset it later. According to a maemo-developers email from
3023 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3025 * configure.ac: Depend on libalarm for Maemo.
3027 * src/dbus_api/modest-dbus-api.h:
3028 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3029 (on_send_receive), (modest_dbus_req_handler):
3030 Handle a SEND_RECEIVE D-Bus method.
3032 * libmodest-dbus-client/libmodest-dbus-client.c:
3033 (libmodest_dbus_client_send_and_receive):
3034 * libmodest-dbus-client/libmodest-dbus-client.h:
3035 Add C convenience functions for calling the new D-Bus method.
3037 * src/modest-platform.h:
3038 * src/gnome/modest-platform.c:
3039 * src/maemo/modest-platform.c:
3040 Added modest_platform_set_update_interval(), which uses the
3041 alarmd API on Maemo.
3042 (modest_platform_init),
3043 Call modest_platform_set_update_interval(), using a hard-coded
3044 interval for now (until the global settings dialog is implemented),
3045 though I am not sure that this makes sense yet.
3047 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3049 * src/dbus_api/modest-dbus-callbacks.c:
3050 (modest_osso_cb_hw_state_handler):
3051 * src/dbus_api/modest-dbus-callbacks.h:
3052 * src/maemo/modest-platform.c: (modest_platform_init):
3053 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3054 in case this has some effect on the ability for Maemo to ping the
3057 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3059 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3060 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3061 warning. It is probably a logic error, but I need to fix the build.
3063 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3065 * src/modest-account-mgr.h:
3066 * src/modest-account-mgr.c:
3067 (modest_account_mgr_account_names): Add a gboolean enabled_only
3068 parameter, so we can get lists of onlt the enabled accounts.
3070 (modest_account_mgr_add_account),,
3071 (modest_account_mgr_account_with_display_name_exists):
3072 * src/maemo/modest-msg-edit-window.c: (get_transports):
3073 * src/modest-account-mgr-helpers.c:
3074 (modest_account_mgr_set_first_account_as_default):
3075 * src/modest-init.c: (init_default_account_maybe):
3076 * src/modest-tny-account-store.c: (get_accounts):
3077 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3078 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3079 * tests/check_account-mgr.c: (START_TEST):
3080 Provide the extra parameter, as appropriate.
3082 * src/widgets/modest-account-view.c: (update_account_view):
3083 Do not show disabled accounts (meaning that there is no way to
3084 enable/disable accounts in the UI (the feature is not in our UI
3085 specification), so we can use this internally only to mark unfinished
3086 or temporary account data.
3088 * src/maemo/easysetup/modest-easysetup-wizard.c:
3089 (create_account): Add boolean enable parameter, so we can specify FALSE
3090 to create the temporary account.
3091 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3092 (on_before_next): When finishing, when there is a temporary account, just
3094 Also, use a timeout to delay the showing of the dialog until gconf is likely
3095 to return correct information, due to a maemo gconf bug that is fixed in
3096 osso 1.1, but not yet in Bora.
3097 However, the dialog stays on screen after it is destroyed.
3099 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3100 for invalid data when cancelling. Use a hildon note instead of a dialog
3101 to complain about invalid data. Do not show the account-saved note if the
3102 account is disabled (a temporary account that will not really be saved for use
3105 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3107 * src/modest-account-mgr-helpers.h:
3108 * src/modest-account-mgr-helpers.c:
3109 Added modest_account_mgr_unset_default_account(),
3110 Added modest_account_mgr_set_first_account_as_default().
3112 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3113 If it was the default account, unset the default account name.
3115 * src/maemo/modest-account-view-window.c:
3116 (on_delete_button_clicked): If it was the default account,
3117 set the first remaining account as the default instead.
3119 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3120 a NULL account or a NULL default account, to prevent a crash. This should
3121 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3124 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3126 * src/widgets/modest-recpt-editor.c:
3127 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3128 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3129 TODO comment for this. This fixes the build.
3131 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3132 be the best place for it. This will in future update all auto-update accounts,
3133 rather than just the current/default account, when that gconf key exists.
3134 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3135 if there are no accounts, before calling do_send_receive().
3136 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3138 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3139 * src/maemo/modest-main-window-ui.h:
3140 * src/maemo/modest-main-window.c: (on_connection_changed),
3141 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3142 directly, becaue the signal handler does more.
3144 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3146 * src/modest-account-mgr-helpers.c:
3147 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3148 for the case that the account does not exist.
3150 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3151 (equivalent to the modest account name) rather than the tinymail account name
3152 (equivalent to the modest account title - human readable) to get the account data.
3153 Check for null account data to prevent the crash, and add a TODO comment saying that
3154 this needs fixing because it is using the server account name instead of the account name.
3156 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3158 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3159 * src/maemo/modest-account-settings-dialog.c: (show_error),
3161 Use hildon_note_new_information() for informative and error messages,
3162 which seems to be expected for Maemo applications (no documentation that I know of
3163 says this). I am surprised that there is no distinction between info and error
3166 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3168 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3169 it is easy to find where this is used.
3171 * src/maemo/easysetup/modest-easysetup-wizard.c:
3172 (create_page_welcome), (create_page_account_details),
3173 (create_page_user_details), (create_page_complete_easysetup),
3174 (create_page_custom_incoming), (create_page_custom_outgoing),
3175 (create_page_complete_custom):
3176 * src/maemo/modest-account-settings-dialog.c:
3177 (create_page_account_details), (create_page_user_details),
3178 (create_page_incoming), (create_page_outgoing):
3179 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3180 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3181 (modest_connection_specific_smtp_edit_window_init):
3182 * src/maemo/modest-connection-specific-smtp-window.c:
3183 (modest_connection_specific_smtp_window_init):
3184 * src/maemo/modest-signature-editor-dialog.c:
3185 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3186 and scrolling policy as per the Email Application Layout Guide, if I have
3189 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3191 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3192 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3193 which were empty, because these vfuncs have been removed from TnyAccountStore.
3194 This fixes the build.
3196 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3198 * src/maemo/modest-main-window.c:
3199 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3200 showing/hiding it. Added TODO because it probably should not be NULL.
3201 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3202 because unnecessary g_warnings() make degugging difficult.
3204 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3206 * src/maemo/modest-msg-edit-window.c:
3207 (modest_msg_edit_window_select_color),
3208 (modest_msg_edit_window_select_background_color): 2 const corrections and
3209 moving 2 #endifs before closing brackets, to fix the build.
3211 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3213 * src/maemo/easysetup/modest-easysetup-wizard.h:
3214 * src/maemo/easysetup/modest-easysetup-wizard.c:
3215 (modest_easysetup_wizard_dialog_finalize),
3216 (on_button_edit_advanced_settings), (create_page_complete_custom),
3217 (on_response), (create_account):
3218 Implement the Advanced Settings edit button, by saving the account information,
3219 for the Advanded Settings dialog to use directly from gconf, and removing it
3220 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3221 Bug #5533 in the projects.maemo.org bugzilla.
3223 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3225 * src/maemo/modest-msg-view-window.c:
3226 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3227 when opening a message window.
3229 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3231 * src/maemo/easysetup/modest-easysetup-wizard.c:
3232 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3235 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3236 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3237 gconf settings. I probably added more checks than necessary, but that is safer.
3239 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3240 variable to fix the build, but this seems to be used when it is still NULL.
3242 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3244 * src/modest-platform.h:
3245 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3246 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3247 * src/modest-main.c: Implement this function so we can avoid using
3248 maemo-specific API from cross-platform code.
3250 * src/modest-tny-account-store.c:
3251 (get_smtp_specific_transport_account_for_open_connection):
3252 * src/modest-ui-actions.c: (check_for_connection),
3253 (modest_ui_actions_on_item_not_found):
3254 Use modest_platform_connect_and_wait() and put #idefs around other
3255 maemo-specific code, because only maemo currently has a way to
3256 identify connection names.
3258 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3260 * src/modest-tny-account-store.h:
3261 * src/modest-tny-account-store.c:
3262 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3263 the connection-specific SMTP server settings in the configuration.
3265 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3267 * src/maemo/modest-main-window.c: (on_connection_changed),
3269 * src/modest-main.c: (main), (start_ui), (send_mail):
3270 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3271 that is what is intended.
3273 * src/modest-ui-actions.c: (action_send), (action_receive),
3274 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3275 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3276 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3277 SMTP server is used when it is specified.
3279 (modest_ui_actions_on_send_receive):
3280 Check that a connection is open before proceeding.
3281 Receive and then send, instead of vice-versa, as per the specification.
3283 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3285 * src/modest-mail-operation.c:
3286 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3287 though I guess it should be something other than NULL.
3289 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3291 * src/maemo/easysetup/modest-easysetup-wizard.c:
3292 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3293 combo twice, to avoid an g_warning and to make it visible again.
3294 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3295 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3296 (already intended) dereference when detaching, because we then recreate the menu.
3297 But I am not sure why the warning was happening, and it is possible that this is a memory
3300 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3302 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3303 and uri_parse_mailto() utility functions.
3304 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3306 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3308 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3310 * src/dbus_api/modest-dbus-api.h:
3311 * src/dbus_api/modest-dbus-callbacks.c:
3312 Use an idle callback to execute the modest code in the application's own thread.
3313 Remove the helloworld example method.
3314 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3315 parsed, and the open-message method is not implemented because this is not yet implemented in
3317 * libmodest-dbus-client/libmodest-dbus-client.c:
3318 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3319 (libmodest_dbus_client_open_message):
3320 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3322 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3323 body without crashing.
3325 * tests/dbus_api/Makefile.am:
3326 * tests/dbus_api/test_mail_to.c:
3327 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3329 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3331 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3332 Added file to fix the build. Sorry.
3334 * src/dbus_api/Makefile.am:
3335 * src/dbus_api/modest-dbus-api.h:
3336 * src/dbus_api/modest-dbus-callbacks.h:
3337 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3338 (modest_dbus_req_handler):
3339 Put constants in a separate header so it can be reused by the
3340 client library, without duplication
3342 * libmodest-dbus-client/Makefile.am:
3343 * libmodest-dbus-client/libmodest-dbus-client.c:
3344 (libmodest_dbus_client_call_helloworld),
3345 (libmodfest_dbus_client_send_mail),
3346 (libmodfest_dbus_client_mailto),
3347 (libmodfest_dbus_client_open_message):
3348 * libmodest-dbus-client/libmodest-dbus-client.h:
3349 (Partly) Implement a send_mail D-Bus method.
3351 * tests/dbus_api/Makefile.am:
3352 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3353 the send_email D-Bus method.
3355 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3359 * libmodest-dbus-client/Makefile.am:
3360 * libmodest-dbus-client/libmodest-dbus-client.c:
3361 * libmodest-dbus-client/libmodest-dbus-client.h:
3362 * tests/dbus_api/Makefile.am:
3363 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3364 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3366 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3368 * src/maemo/easysetup/modest-easysetup-wizard.c:
3369 (create_page_account_details):
3370 * src/maemo/modest-account-settings-dialog.c:
3371 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3372 widgets, because this might not be the default in future versions of the Maemo GTK+.
3373 However, I can not not get capitalization to work even in a simple test case.
3375 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3377 * src/maemo/easysetup/modest-easysetup-wizard.c:
3378 (create_page_custom_incoming), (create_page_custom_outgoing):
3379 * src/maemo/modest-account-settings-dialog.c:
3380 (create_page_account_details), (create_page_incoming),
3381 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3382 instead of using gtk_check_button_with_label(), so they are aligned like the other
3383 widgets, as per the UI spec.
3385 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3387 * src/maemo/easysetup/modest-easysetup-wizard.c:
3388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3389 * src/widgets/modest-validating-entry.c:
3390 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3391 Modest prefix instead of an EasySetup prefix.
3393 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3395 * src/widgets/modest-validating-entry.h:
3396 * src/widgets/modest-validating-entry.c: (on_insert_text),
3397 Added easysetup_validating_entry_set_max_func(), used to set a callback
3398 to call when the max number of characters is reached. GtkEntry has a max-length
3399 already but is silent about it.
3401 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3402 (create_page_account_details), (create_page_user_details),
3404 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3405 (create_page_account_details), (create_page_user_details),
3406 (create_page_outgoing):
3407 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3408 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3409 the UI spec, when the user tries to enter more than the max number of characters.
3411 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3413 * src/maemo/easysetup/modest-easysetup-wizard.c:
3414 (create_page_user_details), (create_page_custom_incoming),
3415 (create_page_custom_outgoing):
3416 * src/maemo/modest-account-settings-dialog.c:
3417 (create_page_user_details), (create_page_incoming),
3418 (create_page_outgoing):
3419 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3420 (modest_connection_specific_smtp_edit_window_init):
3421 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3422 not appropriate. Bad Maemo-specific defaults!.
3424 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3426 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3427 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3428 (modest_signature_editor_dialog_set_settings):
3429 Disable the label and textview when the checkbox is disabled, and use the
3430 specified (UI spec) default signature text.
3432 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3434 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3435 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3437 * src/modest-defs.h:
3438 * src/modest-account-mgr-helpers.h:
3439 * src/modest-account-mgr-helpers.c:
3440 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3442 * src/maemo/Makefile.am:
3443 * src/maemo/modest-signature-editor-dialog.c:
3444 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3447 * src/maemo/modest-account-settings-dialog.h:
3448 * src/maemo/modest-account-settings-dialog.c:
3449 (modest_account_settings_dialog_finalize), (on_button_signature),
3450 (save_configuration): Use the new dialog when the Edit button is pressed, and
3451 save the changes if necessary, as per the UI spec.
3453 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3455 * src/maemo/Makefile.am:
3456 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3457 based on maemo-develoers email from Dirk.
3459 * src/maemo/easysetup/modest-easysetup-wizard.c:
3460 (create_page_welcome), (create_page_account_details),
3461 (create_page_user_details), (create_page_complete_easysetup),
3462 (create_page_custom_incoming), (create_page_custom_outgoing),
3463 (create_page_complete_custom),
3464 (modest_easysetup_wizard_dialog_init):
3465 * src/maemo/modest-account-settings-dialog.c:
3466 (create_page_account_details), (create_page_user_details),
3467 (create_page_incoming), (create_page_outgoing),
3468 (modest_account_settings_dialog_init):
3469 * src/maemo/modest-connection-specific-smtp-window.c:
3470 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3472 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3474 * src/maemo/easysetup/modest-easysetup-wizard.c:
3475 (create_page_account_details), (create_page_custom_outgoing),
3476 (create_page_complete_custom):
3477 * src/maemo/modest-account-settings-dialog.c:
3478 (create_page_user_details), (create_page_incoming),
3479 (create_page_outgoing):
3480 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3481 (modest_connection_specific_smtp_edit_window_init):
3482 Use the correct (UI spec) port min/max, and use horizontal separators,
3485 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3487 * src/maemo/easysetup/modest-easysetup-wizard.c:
3488 (set_default_custom_servernames):
3489 * src/maemo/modest-account-settings-dialog.c:
3490 (create_page_incoming), (on_combo_outgoing_security_changed),
3491 (on_combo_incoming_security_changed), (create_page_outgoing),
3492 (modest_account_settings_dialog_set_account_name),
3493 (save_configuration):
3494 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3495 (on_combo_security_changed),
3496 (modest_connection_specific_smtp_edit_window_init),
3497 (modest_connection_specific_smtp_edit_window_set_connection),
3498 (modest_connection_specific_smtp_edit_window_get_settings):
3499 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3502 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3505 * src/maemo/easysetup/modest-easysetup-wizard.c:
3506 (create_page_custom_outgoing), (create_page_complete_custom):
3507 * src/maemo/modest-account-settings-dialog.c:
3508 (create_page_user_details), (create_page_outgoing):
3509 * src/maemo/modest-account-view-window.c: (button_box_new):
3510 Use changed logical IDs as per the most recent UI spec:
3511 mcen_bd_emailsetup_edit -> mcen_bd_edit
3512 mcen_bd_emailsetup_delete -> mcen_bd_delete
3513 mcen_bd_emailsetup_close -> mcen_bd_close
3515 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3519 * src/dbus_api/Makefile.am:
3520 * src/dbus_api/modest-dbus-callbacks.c:
3521 * src/dbus_api/modest-dbus-callbacks.h:
3522 * src/maemo/modest-platform.c: (modest_platform_init):
3523 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3525 * tests/Makefile.am:
3526 * tests/dbus_api/Makefile.am:
3527 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3529 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3531 * src/maemo/modest-account-settings-dialog.c:
3532 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3533 Removed unnecessary includes.
3535 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3537 * src/maemo/easysetup/modest-easysetup-wizard.c:
3538 * src/maemo/modest-account-settings-dialog.c:
3539 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3540 * src/widgets/Makefile.am:
3541 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3542 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3543 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3544 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3545 * src/widgets/modest-secureauth-combo-box.c:
3546 * src/widgets/modest-secureauth-combo-box.h:
3547 * src/widgets/modest-serversecurity-combo-box.c:
3548 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3549 made the GObject names more consistent with the rest of the Modest code.
3551 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3553 * src/maemo/easysetup/Makefile.am:
3554 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3555 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3556 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3557 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3558 * src/maemo/easysetup/modest-easysetup-wizard.c:
3559 * src/maemo/easysetup/modest-validating-entry.c:
3560 * src/maemo/easysetup/modest-validating-entry.h:
3561 * src/maemo/modest-account-settings-dialog.c:
3562 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3563 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3564 widgets/ because they are used outside of easysetup too. After checking in,
3565 svn will allow me to rename them too.
3567 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3569 * src/gnome/modest-msg-edit-window.c:
3570 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3571 linker error, to fix the build on the GNOME platform.
3572 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3573 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3574 ifdefed out to avoid a warning.
3576 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3578 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3579 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3580 some alternative for GTK+ 2.6.
3582 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3584 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3586 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3587 specified for EmailAccountsDialog in UI spec.
3589 * src/maemo/easysetup/modest-easysetup-wizard.c:
3590 * src/maemo/easysetup/modest-easysetup-wizard.h:
3591 * src/maemo/modest-account-settings-dialog.c:
3592 * src/maemo/modest-account-settings-dialog.h:
3593 Reuse a member window widget for the connection-specific SMTP server accounts,
3594 so we can tell it to create/save the accounts only if we actually save changes.
3596 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3597 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3598 (modest_connection_specific_smtp_edit_window_get_settings):
3599 Return a struct instance for temporarily remembering the entered data.
3601 * src/maemo/modest-connection-specific-smtp-window.h:
3602 * src/maemo/modest-connection-specific-smtp-window.c:
3603 (modest_connection_specific_smtp_window_finalize),
3604 (modest_connection_specific_smtp_window_fill_with_connections),
3606 (modest_connection_specific_smtp_window_save_server_accounts),
3607 (update_model_server_names): Do not actually save data until asked,
3608 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3610 (on_selection_changed),
3611 (modest_connection_specific_smtp_window_init): Disable the edit
3612 button when nothing is selected.
3614 * src/modest-account-mgr-helpers.c:
3615 * src/modest-account-mgr-helpers.h:
3616 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3619 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3621 * src/modest-account-mgr-helpers.h:
3622 * src/modest-account-mgr-helpers.c:
3623 (modest_account_mgr_get_unused_account_name),
3624 (modest_account_mgr_get_unused_account_display_name): Added these
3625 utility functions, to avoid code duplication.
3627 * src/maemo/easysetup/modest-easysetup-wizard.c:
3628 (create_page_account_details), (create_account):
3629 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3630 (on_combo_security_changed),
3631 (modest_connection_specific_smtp_edit_window_init),
3632 (modest_connection_specific_smtp_edit_window_save_settings):
3633 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3634 * src/maemo/modest-connection-specific-smtp-window.c:
3635 (modest_connection_specific_smtp_window_finalize),
3636 (modest_connection_specific_smtp_window_fill_with_connections),
3637 (on_button_edit), (modest_connection_specific_smtp_window_init):
3638 * src/maemo/modest-connection-specific-smtp-window.h:
3639 Implementing saving of connection-specific server accounts.
3641 But I need to refactor this so we can save the data for each
3642 possible connection-specific account and only actually create the server accounts
3643 when the easysetup finished, or the OK button is pressed on the account settings
3646 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3648 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3649 (on_combo_security_changed):
3650 (modest_connection_specific_smtp_edit_window_init):
3651 Auto-fill the port number as in the account settings.
3653 (modest_connection_specific_smtp_edit_window_set_connection):
3654 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3655 * src/maemo/modest-connection-specific-smtp-window.c:
3656 (fill_with_connections), (on_button_edit),
3657 (modest_connection_specific_smtp_window_init):
3658 Turn the edit window into a dialog to simplify the code, and
3659 set a WM hint as in a GtkDialog, because only a popup can be on top of
3660 another window in Maemo, and popups usually have no WM decoration.
3662 * src/modest-defs.h:
3663 * src/modest-account-mgr-helpers.c:
3664 (modest_account_mgr_set_connection_specific_smtp),
3665 (modest_account_mgr_remove_connection_specific_smtp),
3666 (modest_account_mgr_get_connection_specific_smtp):
3667 * src/modest-account-mgr-helpers.h: Some functions to write the
3668 connection-specific SMTP server information. Not yet used.
3671 * src/widgets/modest-folder-view.c: (text_cell_data):
3672 Fix a warning about an uninitialized variable.
3673 (on_configuration_key_changed): Put an #ifdef around the use
3674 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3676 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3678 * src/maemo/modest-account-settings-dialog.h:
3679 * src/maemo/modest-account-settings-dialog.c:
3680 Added connect_for_modified() utility function to mark the new modified boolean.
3682 (create_page_account_details), (create_page_user_details),
3683 (create_page_incoming), (create_page_outgoing), (on_response),
3684 (modest_account_settings_dialog_init),
3685 (modest_account_settings_dialog_set_account_name):
3686 Only warn about unsaved changes when there are actually unsaved changes.
3688 * src/modest-account-mgr-helpers.c:
3689 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3690 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3691 to get the data from there in future.
3693 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3695 * src/modest-defs.h:
3697 * src/modest-account-mgr-helpers.h:
3698 * src/modest-account-mgr-helpers.c:
3699 Store the security account setting in a single conf key instead of using
3700 the options list, so that the list is left for just the to-be-removed camel hack,
3701 and because gconf_client_set_list() is failing for some reason.
3703 * src/modest-account-mgr.c:
3704 (modest_account_mgr_add_server_account):
3705 * src/maemo/modest-account-settings-dialog.c:
3706 (modest_account_settings_dialog_set_account_name),
3707 (save_configuration): Use the renamed functions.
3710 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3712 * src/widgets/Makefile.am:
3713 * src/widgets/modest-limit-retrieve-combo-box.c:
3714 * src/widgets/modest-limit-retrieve-combo-box.h:
3715 * src/widgets/modest-retrieve-combo-box.c:
3716 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3717 the account settings dialog.
3719 * src/modest-defs.h:
3720 * src/modest-account-mgr-helpers.h:
3721 * src/modest-account-mgr-helpers.c:
3722 (modest_server_account_get_option_secure_auth),
3723 (modest_server_account_set_option_secure_auth):
3724 * src/modest-account-mgr.c:
3725 (modest_account_mgr_add_server_account):
3726 Use the existing AUTH_MECH conf key for the secure-auth setting,
3727 instead of putting it in the list options, because this was actually used already.
3729 * src/maemo/modest-account-settings-dialog.c:
3730 (create_page_account_details),
3731 (modest_account_settings_dialog_set_account_name),
3732 (save_configuration):
3733 * src/maemo/modest-account-settings-dialog.h:
3734 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3735 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3737 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3739 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3740 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3741 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3743 * src/modest-defs.h:
3744 * src/maemo/modest-account-settings-dialog.c:
3745 (create_page_incoming), (on_combo_outgoing_security_changed),
3746 (on_combo_incoming_security_changed), (create_page_outgoing),
3747 (modest_account_settings_dialog_set_account_name),
3748 (save_configuration): Load/Save the port number, and change it when the
3749 security combo changes, to suitable defaults.
3751 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3753 * src/modest-account-mgr.c:
3754 (modest_account_mgr_add_server_account): Set the security and secure-auth
3755 options, and add a comment saying that the other camel-specific options should be
3758 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3760 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3762 * src/modest-tny-account-store.c: (account_list_free),
3763 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3764 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3767 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3769 * src/modest-protocol-info.c:
3770 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3771 is required by our UI spec. Maybe something in our implementation will use this eventually.
3772 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3773 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3774 instead of the previous 0 placeholder.
3776 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3777 secure-auth settings.
3778 * src/modest-account-mgr-helpers.h:
3779 * src/modest-account-mgr-helpers.c:
3780 (modest_server_account_data_get_option_secure_auth),
3781 (modest_server_account_set_option_secure_auth),
3782 (modest_server_account_data_get_option_security),
3783 (modest_server_account_set_option_security): Added this API for getting and setting the security
3784 and secure-auth settings.
3786 * src/maemo/modest-account-settings-dialog.h:
3787 * src/maemo/modest-account-settings-dialog.c:
3788 (modest_account_settings_dialog_finalize), (check_data),
3789 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3790 about changing titles.
3791 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3792 (save_configuration): Save the security and secure-auth settings.
3794 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3795 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3797 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3799 * src/modest-defs.h:
3800 * src/modest-account-mgr.c:
3801 (modest_account_mgr_add_server_account):
3802 Added and used defines for the options key and value pair strings,
3803 that are used so far, though they do not seem to correspond to anything in our
3804 UI specs or ModestProtocol enum.
3806 * src/modest-account-mgr-helpers.h:
3807 * src/modest-account-mgr-helpers.c:
3808 (compare_option_strings_for_name),
3809 (modest_server_account_data_get_option_value),
3810 (modest_server_account_data_get_option_bool),
3811 (modest_account_mgr_get_server_account_option):
3812 Added helper functions for parsing the options GSList.
3814 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3816 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3817 display name is based on the supplied account name.
3818 * src/modest-account-mgr.c:
3819 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3820 with an inefficient, but good-enough, implementation.
3822 * src/maemo/easysetup/modest-easysetup-wizard.c:
3823 (create_page_account_details), (on_before_next), (create_account):
3824 Check for existing display names rather than (non-user-visible) account names, and just
3825 create and set a unique account name at the end.
3827 * src/maemo/modest-account-settings-dialog.c:
3828 (modest_account_settings_dialog_init),
3829 (modest_account_settings_dialog_set_account_name),
3830 (create_page_incoming): Show the display name, instead of the account name.
3831 (on_response): Do some (not all) extra checks, as in the UI spec.
3832 (save_configuration): Save the display name if it was changed.
3834 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3836 * po/en_GB.po: Added needed logical ID and translation.
3837 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3838 (init_view): Made the is-default column clicking work.
3840 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3843 * src/maemo/easysetup/Makefile.am:
3844 * src/maemo/easysetup/modest-easysetup-wizard.c:
3845 (modest_easysetup_wizard_dialog_init):
3846 * src/maemo/easysetup/provider-data-test.keyfile:
3847 * src/maemo/easysetup/provider-data.keyfile:
3848 Moved the provider data file to the new modest-providers-data package and used it from there.
3850 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3852 * src/modest-local-folder-info.c:
3853 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3854 N_() was already used on the static strings, but this just marks it for translation without
3855 using the translation.
3857 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3859 * src/maemo/modest-account-settings-dialog.c:
3860 (create_page_incoming),
3861 (modest_account_settings_dialog_set_account_name):
3862 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3863 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3864 I will do this if nobody else gets there first.
3866 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3868 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3869 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3870 save the security stuff.
3872 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3874 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3875 Set the email address and user fullname, which I now see must be
3878 * src/maemo/modest-account-settings-dialog.h:
3879 * src/maemo/modest-account-settings-dialog.c:
3881 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3882 leave-on-server and authentication.
3883 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3886 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3889 * src/maemo/modest-account-settings-dialog.c:
3890 * src/maemo/modest-account-settings-dialog.h:
3891 Most (but not all) of the widgets are now present as specified by the UI spec.
3892 No changes are yet saved, and some details are not properly shown yet.
3894 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3896 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3898 * src/maemo/Makefile.am:
3899 * src/maemo/modest-account-settings-dialog.c:
3900 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3901 an existing account. Doesn't do much yet.
3903 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3904 Open the accounts settings dialog when Edit is clicked.
3906 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3908 * src/maemo/easysetup/Makefile.am:
3909 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3911 * src/maemo/easysetup/modest-easysetup-wizard.c:
3912 (modest_easysetup_wizard_dialog_init):
3913 Try to get the source directory from the build system,
3914 instead of hard-coding "./" into the source code, when opening our local
3915 copies of the configuration files.
3916 But this still fails when opening the wizard from the Accounts window,
3917 maybe because the working directory seems to change at runtime.
3918 So the wizard will fail the second time unless you copy the files into their
3919 proper locations - see the stdout warnings for the paths.
3921 (create_page_account_details),(on_before_next):
3922 Check for existing non-server accounts instead of server accounts,
3923 so the default account name is useful again, and to prevent trying to
3926 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3927 Show the wizard when New is clicked.
3929 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3930 (init_view): Show the column headers, and show the columns that are
3931 specified in the UI specs. However, something in Maemo's GTK+ prevents
3932 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3933 change the default account. This is despite unsetting the special properties.
3935 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3937 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3938 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3939 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3940 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3941 to make that clearer.
3942 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3944 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3946 * src/maemo/modest-account-view-window.c:
3947 (modest_account_view_window_init),
3948 (modest_account_view_window_new):
3949 Use the same buttons as specified in the
3950 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3951 the existing widgets, which never had a chance of working.
3952 Put the ModestAccountView treeview in a scrolled window.
3953 Do not repeat the initialization in both _init() and _new().
3955 * src/widgets/modest-account-view.c: (update_account_view):
3956 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3957 this widget and window shows no accounts.
3959 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3961 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3963 * src/maemo/easysetup/modest-easysetup-wizard.c:
3964 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3965 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3966 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3969 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3970 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3971 accounts exist yet, as in the UI spec.
3973 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3975 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3977 * src/maemo/Makefile.am:
3978 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3979 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3980 New window for editing connection-specific smtp details.
3981 Not fully implemented.
3983 * src/maemo/modest-connection-specific-smtp-window.c:
3984 (modest_connection_specific_smtp_window_finalize) :
3985 unref the tree model.
3986 (on_button_edit): Show the edit window.
3988 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3990 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3993 * src/maemo/Makefile.am:
3994 * src/maemo/modest-connection-specific-smtp-window.c:
3995 * src/maemo/modest-connection-specific-smtp-window.h:
3996 New window for showing the list of connections, for connection-specific
3997 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3998 * src/maemo/easysetup/modest-easysetup-wizard.c:
3999 (create_page_custom_outgoing): Show the new window when the button is clicked.
4001 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4003 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4004 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4005 * src/maemo/modest-msg-edit-window.c:
4006 (modest_msg_edit_window_insert_image):
4007 * src/modest-conf.c: (modest_conf_key_escape):
4008 * src/modest-mail-operation.c:
4009 (modest_mail_operation_send_new_mail):
4010 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4011 (modest_ui_actions_on_new_account):
4012 * src/widgets/modest-attachment-view.c: (update_filename_request):
4013 * src/widgets/modest-mail-header-view.c:
4014 Corrected warnings that were breaking the build, by commenting out unused variables,
4015 and a function, and by including a header.
4017 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4019 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4020 so we can #ifdef around platform-specific code when necessary.
4021 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4022 to allow this to build for the GNOME platform too.
4024 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4026 * src/maemo/easysetup/modest-easysetup-wizard.c:
4027 Added util_increment_name() and used it in create_page_account_details()
4028 to make sure that the default account name is always a new name.
4030 (modest_easysetup_wizard_dialog_init),
4031 (set_default_custom_servernames): Some minor memory management fixes.
4033 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4037 * src/modest-runtime.c: (init_i18n): Restored the translation
4038 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4039 are defined in config.h, and the translations are installed.
4041 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4042 is defined for translation.
4044 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4046 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4048 * src/maemo/easysetup/modest-easysetup-wizard.c:
4049 (modest_easysetup_wizard_dialog_init):
4050 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4051 Use realistic paths (though they should use $prefix generically) to the
4052 mcc_mapping and provider-data.keyfile files which might work when they
4053 are installed by the future version of the operator-wizard package,
4054 and then fallback to paths in our source code, with an explanatory
4057 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4061 * src/maemo/Makefile.am:
4062 * src/maemo/easysetup/: Added files from the previously-exernal
4063 osso-modest-easysetup.
4064 * src/maemo/modest-main-window-ui.h:
4065 * src/modest-ui-actions.c:
4066 * src/modest-ui-actions.h:
4067 Added modest_ui_actions_on_new_account() as a signal handler for the
4068 New Account menu item. It shows the easysetup wizard.
4069 * po/en_GB.po: Added additional needed logical IDs and translations.